yashsingh1/xdaforums huggingface dataset:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] prasung10:
Video stuttering bug is still there. It happens with mkv files irrespective of codecs, mostly. Some mkv file s play some don't. And all mkv file's audio dont use audiofx. Some how they bypass audiofx settings. Some thing is not right, either ffmpeg not offloading to Qualcomm HW codecs or ffmpeg is outdated, I don't know, I'm not a developer. MP4 files play well though, on both h264 and hevc.

Thanks for the thermal setting.

I should not have bought this one handset. Except Motorola no company is reliable in software. [MENTION=3208754]codeworkx[/MENTION]
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ganu6000:
This is a noobie question but do I have to wipe system before installing
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Jk124:
No need to wipe system. If u are flashing this over stock eui Rom then use the wipe option in twrp. Make a backup of your current ROM first..
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Lavin_A:
Moving from

stock/other rom to lineage - yes

unofficial build to official build - yes

official build to unofficial build - yes

unofficial build to newer unofficial build - no

official build to newer official build - no
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RONIN-IND:
Battery not charging even if plugged in AC and USB, only charging when switched off. When plunged in charging only showing the charging lighting bolt but not charging the phone.

USB cable is working fine

Battery temperature is very high plz see the attached images:confused:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Dhruv Dhawan:
Copy the last thermal manager file to system/etc/

Or charge your phone inside a fridge(I tried)
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Dhruv Dhawan:
Can anyone upload 21s boot.img or TWRP backup?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] codeworkx:
No. Lineage updater wipes system partition during install.

But a factory reset is required if coming from another rom.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
Thanks a lot!! I was worried for a moment when it didn't charge... I needed the phone for a meeting and there wasn't time for flashing another thing
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
nevermind, charging still stops.. and with the phone not even hot...

these thermals policies are weird, I was checking them... isn't it supposed to SLOW DOWN charge and performance when heat increases? not just.. plain stop charging, the phone needs to be charging on a fridge basically... because with 45° on the CPU and like 35 on the battery it just stops charging at all... and the weather here is 35-37°, so I definitely wont be able to charge outside of the fridge...
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] codeworkx:
Are you sure that you're using the latest xml?

It starts to slow down at 41° battery temp. On 45° it goes to lowest level which should be 500mA. On 67° it stops.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
yup, I'm pretty sure..
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
Flashed the latest build. How to get the Volte working? There's no clear instruction.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] reozy:
substratum font is not working in linage 14.x (only font others are working fine)
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ganu6000:
Is volte working on the 13 build?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Mads71:
Yep & Post Yours Question Related To Lineage 13 On Lineage 13 Thread!
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] mdfarazb2:
It's working out of the box for everyone..no need to tweak anything
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Lavin_A:
Do you have this enabled under sim settings?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
Ok, after properly setting up the thermal policies... and after like 4 battery cycles.. I have to say, this ROM has gotten really far... performance is smooth, charging is fast, temps are cool (it heats up more than EUI, but definitely not like older builds) and no errors so far...

battery life seems pretty great so far.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shivamg95:
I had same issue buddy in the latest build of rom. So i tweaked the thermanager.xml file myself, and now it is charging fast as before and charging slows down when the phone actually gets hot. If you want, i can upload my xml file for you.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Da-Fied:
Hello,

I have real problems installing this rom.

How do I have to proceed?

With the instructions on the first page I can not cope.

The original rom is 5.8.016S installed.

An old twrp version and xposed are on it.

Can someone please write me a step for step instructions for people without plan?

How do I get the Bootloader 20S on it?

Many Thanks
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
Of course. I haven't flashed the modem firmware stated as I don't know which one is for India. Also people say Volte works out of the box. Doesn't for me.

---------- Post added at 12:03 PM ---------- Previous post was at 11:40 AM ----------

Keep calm.

1) first unlock bootloader through adb, this is easy. Setup the right drivers on PC(Android sdk or adb/fastboot drivers). Windows should detect adb interface AND Android device in device manager. Fairly simple but you havta spend some time of the internet.

2) that done. Put twrp 3.1 file in adb folder and flash it through terminal command on windows. (xda has guides for every step I mention here).

Once done boot into recovery, enable mtp in settings and connect data cable and see if windows show the internal storage (this step is important as once you wipe data you can just connect the cable, put the new files and flash it, simple. The other processes are too painful, install mtp drivers for windows.)

3) if mtp is working, you're good to go. First get 20s bootloader zip. Flash it through twrp while you're still on your stock OS. New bootloader is installed.

4) Reboot once, go to twrp again, backup old rom if you want to, optional (it'll save the file in storage so transfer it before the wiping)

Now wipe dalvik, system, cache, data, (I even wipe internal storage for clean install), once done format data to remove encryption on internal storage (otherwise PC won't write on the internal storage).

Reboot in twrp. Connect cable. You'll see your internal storage, cleaned out. Copy ROM and gapps file of your choice. Flash it in that order.

Enjoy your new ROM!

PS: Just go through the xda thread on each step if you're totally new. Especially till you get twrp installed and working with PC. That way whenever you brick the ROM or something goes wrong, you can always wipe and throw new ROM files and flash to get going.

---------- Post added at 12:07 PM ---------- Previous post was at 12:03 PM ----------

How? Which is the Volte firmware for India? I haven't flashed the modem/standalone firmware on this clean flash yet as I don't know which is the right file. I've tried two of the four MPSS files available and it didn't work. So this time I flashed nothing except the ROM to check if it works out of the box but it didn't. LTE is working fine.

Please help.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Lavin_A:
Modem only:

http://eu.host.erwanleboucher.fr:80...ems/MPSS.TA.2.0.C18-66782_VoLTE_dangerous.zip

Bootloader:

http://eu.host.erwanleboucher.fr:8080/codeworkx/lineage/s2/bootloaders/bootloader-19S-india-s2ww.zip

If standalone modem doesn't work, flash the entire bootloader.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
what xml are you using? because for me i still cant charge my phone same like earlier. It charged 5% in past 30 min
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
I'm on 20s bootloader. Will that be a problem?

---------- Post added at 12:52 PM ---------- Previous post was at 12:35 PM ----------

Flashed the modem. Didn't work. I'll try flashing the bootloader and modem together. Hope that doesn't it. Sigh.

---------- Post added at 01:12 PM ---------- Previous post was at 12:52 PM ----------

Nope. Still didn't work. I guess I'll switch to RR after next update. There it actually works out of the box. Buggy but still.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
Also, Did Google lock Ok Google detection for non pixel devices?

It suddenly stopped working.

I'm on the latest Lineage build and I made these modifications to build prop and now the detection works, however only when the phone is unlocked. How do I fix that? So I can unlock from my lockscreen.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
These setting still remain locked. Even if I try to enable it. But it registers my voice. Detection works only after unlocking phone.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
this one
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
Forget the one I posted earlier, Thus one is the one I'm using and works fine... the other one was an old one
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
as far as I know you have to enable ok Google from Any place to "unlock" the other options
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
what an avg can you charge within 30 min? Also did u tried using phone while charging? did it slowed down the charge drastically? coz i was just using internet for few min while charging and battery went down from 22% to 20%
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
It charges from 0-60 in 30 mins aproximately..

and yes, it continues to charge decently even when playing...
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
not charging for me :( . My phone charged 25% in 2.5 hours . Leme try the .xml file u send and hope it works
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
Yeah, with the stock one the ROM comes with, my phone didn't charge... try that xml..
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
tried it and with normal use it discharged 2% while charging :(
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
did you rebooted the phone?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
Everything is enabled.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
everytime i change xml i rebooted my phn but nothing seems to be working so far...can you gimme any contact detail so that mods wont think this as a spam
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
Ok, the first time I changed XML, it didn't work at first..

but I let my phone cooldown... and when it was cool, it seemed the new xml started working and now it could charge from now on
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
Lol you just need to reboot. That's all.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
yeah, I did rebooted but the XML wouldn't take effect until the phone was cool enough to trigger the new config.. since it was cool, it never gave a problem anymore...

just my theory, but it worked that way
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
ok i did as u said..rebooted my phone,let it cool down..went to do some work and when i came back phone was discharged from 39% to 38% in 20 min even while charging:(
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
this is what battery usage shows
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
weird... because mine wasn't even saying it was charging... it just turned the LED... and after a few seconds it turned off... and no charging was made... but yours seems to even recognize the charger.....

hmm... interesting, what if you try to change the XML from TWRP... ?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
and how exactly can i do that
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
There's a File Explorer inside TWRP under the Advanced Settings
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
gonno give it a try
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
How would that make a difference?:rolleyes:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] CpaoV:
I've been long enough in Android to realize, everything is possible... who knows, maybe the explorer he's using it's not setting the permissions right, maybe he hasn't properly set root access... who knows... worth a try
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
Hmm fair enough.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ganu6000:
Is there any way to show battery percentage on the status bar on 13?

Edit: I figured it out.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] 42fortytwo:
I tried and failed three times ;( "Encryption unsuccessful"

---------- Post added at 02:40 AM ---------- Previous post was at 02:39 AM ----------

same here. Tried with and without pin, on freshly imaged phone :(
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
So i tried all the .xml files mentioned in thread,every single possible way of charging and so far none of them worked. Used the .xml file codeworkz mentioned and left phone to charge all night and battery went from 22% to 10%... Looks like im in deep deep trouble... Idk what will i do if charge goes 0%. So for now im open to any kind of suggetions. This time i really need some help

---------- Post added at 04:56 AM ---------- Previous post was at 04:42 AM ----------

Can u upload the xml file you using plz.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Lavin_A:
No problems with the last xml; probably​ something wrong with your hardware. Try tweaking it yourself, temperature varies everywhere and someone else's config might not be the best for you.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] codeworkx:
Offmode charging?

For me it sounds like a broken charger or cable.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] piku 123:
Switch off your phone then charge if this fails then your charging cable is faulty

---------- Post added at 05:31 AM ---------- Previous post was at 05:25 AM ----------

You need to format data partition
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
OK right now im feeling like most dumb person on earth. First thanks to everyone who tried to help. So I was just about to give up on my phone, then I thought maybe its a coincidence but it might be possible that my charger is faulty right after changing to new build. So I tried new adapter but it didn't work then I thought of cable fault so I tried normal USB cable with type c adapter and voila, it worked. Phone charged from 3% to 25% in 10 min
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] godfire2203:
Anyone please tell me how to copy any xml file in phone?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Isaac Sailo:
You can use root explorer
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] troytheboy:
Hahaha...buddy you took everyone on a wild goose chase...but the incident was quite funny... :laugh::laugh::laugh::laugh:

There are two things that you take from this

(1) Always check your adapter and cable if your phone is not charging :D

(2) XDA is a great place... people from all over the world, people who don't know each other, come over to help each other even if it means helping someone change his charging cable....

hahaha...:silly:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
its seriously a coincidence that my cable gets faulty right after i changed my build.

And yes no doubt xda is the best place for finding solution for any phone. Thats why i will try to learn some android work after i complete my studies

---------- Post added at 02:18 PM ---------- Previous post was at 02:17 PM ----------

use es file explorer or any root explorer
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] godfire2203:
That i know bro...but where to paste.? Tell me the whole procedure if possible bro. I am very thankful to you
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] parthpwar:
paste the file in below mentioned directory

system/etc/
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
open es file explorer->swipe from right-> grant root permission->copy thermanager.xml file-> swipe from right-> goto local-> device-> system->etc -> paste file
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] prasung10:
1. enable usb debugging in developer options.

2. connect to PC

3. adb root

4. adb remount

5. adb push thermanager.xml /system/etc/

6. adb reboot device
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shivamg95:
Good. So the cable was faulty ??
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] godfire2203:
Thank you bros...
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] 42fortytwo:
thanks! not sure what you mean here. Between unsuccessful encryption attempts I wiped out data + cache ("factory reset" in TWRP) which cleans the data (sdcard) partition, and then I attempted to encrypt again. Am I missing something obvious here?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Lavin_A:
Factory reset doesn't format internal storage. I don't know if that affects encryption.

For a full wipe, you need to go to wipe>advanced wipe in twrp and select everything there. The rom zip file will also be deleted which you'll need to copy from a computer.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] piku 123:
Wipe alone won't do any good you need to format data partition in twrp. Then only do wipe data,cache,system,dalvik after that flash ROM and Gapps then reboot.

---------- Post added at 05:21 AM ---------- Previous post was at 05:20 AM ----------

Wipe internal and boot is not needed.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] someonezhq:
support F2FS??:)
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] ganu6000:
Anyone thought of Dolby Atmos . It should be added too.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] piku 123:
That is never going to happen but you can always flash dolby atmos if you need.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] sahilashraff9:
After MiUi chineese rom i flash and m seeing these chineese word everything in eng but these few thing are in chineese even my 1st boot default language was chineese i set it to eng

india then finished boot anyone know why m facing these
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shivamg95:
I have some weird observations in this rom lately, and all these observations are regarding the big cores of the cpu.

First of all,

most of the apps shows that the all big cores of the cpu are stopped(you can verify this in vafious apps like cpu-z and others). In my testing, only "kernel auduitor" app and "multi-core observer" app shows it correctly that 2 of the big cores are always online and 2 are offline when no cpu intensive operations are performed.

Secondly,

I saw in thermanager.xml file that when the temperature rises to some threshold(hotplug), the big cpu cores should be turned off step wise. But it simply doesn't happen. I managed to cross the threshold several times but 2 of the big cores are online everytime.

Thirdly,

Sometimes randomly, all the big cores went offline for no possible reason. Even if the temperatures are well within the threshold mentioned in thermanager.xml file. Even if I put load on cpu by running geekbench test, those cores never get back online. Those cores get back online only if the phone is rebooted.

It would be helpful if anyone can verify these observations.

Thank you [MENTION=3208754]codeworkx[/MENTION] for providing and managing lineageOS for our device. Yiu did a tremendous job here.:good::good:
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
Use Viper4Android sound drivers instead. I'm a sound guy and this emulates sound way better because all the parameters are tweakable as against Dolby being predefined. Set it up correctly and you'll fall in love with music all over again.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] godfire2203:
Is there any viper4android for nougat? Please share link.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
http://downloadmirror.co/2zYA/ViPER4Android_2.5.0.5_guitardedhero.zip

---------- Post added at 08:09 PM ---------- Previous post was at 08:04 PM ----------

Instructions:

http://googleweblight.com/i?u=http:...viper4android-nougat/&grqid=U5mSKRzb&hl=en-IN
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] subham164:
well i heard everywhere the rom is having camera issue..is it stable now? what about video recording etc?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] godfire2203:
Error. Viper4android couldnt detect root access
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
Yep. It's normal. You didn't install it correctly. Go to apps click show system and disable SoundFX. Go file manager. Under system/vendor/etc add .bak at the end of audioconfig file. Just that one file.

Reboot. Enjoy.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] godfire2203:
It couldn't find root access. I had done all the things.

---------- Post added at 09:25 PM ---------- Previous post was at 09:23 PM ----------

Someone told me to use viper4arise instead of this. Because in cm14.1, viper4android is not able to find root access with in built su
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
It sound ask for it automatically. Try clearing data and restart app. If doesn't work. Uninstall and reflash. The SoundFX and config file thing needs to be done before flashing.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] godfire2203:
I flashed it 3-4 times. But same prob persists. I am going to flash su from outside after flashing upcoming latest cm14.1. I will not flash addon su. Btw config file done after flashing vipr4android
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
Make sure root access is properly set up. Make sure no other equalizer/music app is running. Should work. Mine works perfectly every time. Do the file renaming before flashing.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] godfire2203:
You have set up root access from add on su? Seems like i don't have any audio fx. I am not able to find any fx. I think i uninstallled it by mistake
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] RoguishOfficial:
I'm on RR Rom. It's pre rooted. But it works just fine on Lineage too. Clean flash everything. And follow the instructions.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] subham164:
yes i m facing the issue ,as soon as i connect it to charger, the led light glows and then switch offs..bt the phone keeps on charging and the camera is damn slow...how to fix it ,if i toggle with inbuilt camera .,takes 10 sec to click a pic
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] piku 123:
Download from here

https://xdaforums.com/le-2/themes/viper-dolby-atmos-flashable-t3605439

Also make sure your phone is rooted to root lineage flash su from add on section then change enforcing to permissive then flash vipre dolby atmos flashable zip

---------- Post added at 04:10 AM ---------- Previous post was at 04:08 AM ----------

Try april builds recent lineage builds have charging bugs.
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] shanufox18:
u can try to zip flash dolby atmos and post here if it works
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] subham164:
No way to fix it? And wht about camera n flashlight? They continue not to work?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] Nehal Rishi:
Flashlight,not much of concern but camera 4k video recording ..!!!
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] godfire2203:
Your selinux mode is on permissive or enforcing?
[LeEco Le 2 ROMs, Kernels, Recoveries, & Other Deve] subham164:
is the camera working for u ?charging issues i m facing on latest build.whch build r u on?

---------- Post added at 06:39 AM ---------- Previous post was at 06:24 AM ----------

and how to lock apps in ram? so that wen i clear memory they dont get closed?