yashsingh1/xdaforums huggingface dataset:
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
Its not said that the new batterycode Samsung implemented gives extended overall lifetime

Fact is the battery has been doing okay all years and as it seems after the new code it does not do okay, in fact it runs empty fast and u have to reload sooner than before.

If you call that extended overall lifetime I day not get that.
[Galaxy S 5 Android Development (Snapdragon)] mrini:
My Wi-Fi not connected with version 29/11/2018 any help please?
[Galaxy S 5 Android Development (Snapdragon)] rollinrollinrollin:
iirc I have read something similiar from multiple sources

[MENTION=5156684]andreoide[/MENTION]

"We know from research done by the auto industry that batteries live longer when not charged to 100 percent every time…but at the same time, you should charge your battery to 100 percent at least once in a while to ensure it’s “balance” charged."

https://www.electricbike.com/ebike-battery-longevity/

same here

https://www.androidauthority.com/maximize-battery-life-882395//
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
.... " Fact is the battery has been doing okay all years and as it seems after the new code it does not do okay, in fact it runs empty fast and u have to reload sooner than before.

If you call that extended overall lifetime I day not get that...."

Whatever there is out in the internet this is my experience and that from many others I suppose.

After the implementation of the Samsung battery code it runs empty from 93 to 82% in 6hours during night.

The same battery I put in old s5 (same model but with broken glass but functionali and fw from before battery code ) had the good old 2or3% loss during my sleep.

So whatever anybody writes anywhere, i feel bad about the change.

It feels like my S5 is a sucking phone now wich I have to charge before (from daily use that day like 28% to 93%) and after my sleep (from sunken 82% during 6hrs sleep to 93% AGAIN) to get trough the day.

It just sucks, whatever anybody says.
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
[MENTION=3419717]cvxda[/MENTION]

Hi Corinna,

Will you leave the battery-chargingcode as it is or will you change it back the way it was ?

See some postings above, I see no benefit in the new code.....

:confused:
[Galaxy S 5 Android Development (Snapdragon)] olauer:
I reinstalled Lineageos OS from stock rom and it still loads just 94%.

The question is how many mV you loose over night. For me from 94 to 88% it looses from 4282 to 4180 mV. You know, for percentage the reference is important :)

---------- Post added at 02:20 PM ---------- Previous post was at 02:15 PM ----------

No problem with my newly installed kccat6
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
The 25 Nov message was a glitch.

Read before you post please. Samsung implemented code so the charge will stop at 93-94%. You can read all about that in the messages from last 2weeks here.
[Galaxy S 5 Android Development (Snapdragon)] olauer:
Stay cool, I did the comparison with the stock rom. Perhaps I misinterpreted the glitch :)
[Galaxy S 5 Android Development (Snapdragon)] Zubagy:
I tgoght u was the only 1 experiencing this. From 93-94%....I get down to 80s very fast....
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
Samsungs shi**y code makes me feel bad about S5 and lineage. I have to charge more often than before and its not proven to he a better code. Obvious its a bad code running the battery dry for no reason.

I asked cvxda already but she don't answer (yet)
[Galaxy S 5 Android Development (Snapdragon)] Zubagy:
Just to add....I last updated 4 days ago.....the rolling updates have no change logs so I see no point in downloading..... So there z that.

Corinna maybe busy with some other stuff....let us give her time.
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
Yes she's busy with the other variant (RR mix ) but I'll expect an answer between now or a few days :good:

I'm not pushing anybody :)
[Galaxy S 5 Android Development (Snapdragon)] bege10:
I also have on my SM-G901F the two bugs that the battery is charged only up to 94% and the battery drain is extreme when the phone is shut down.

Additionally I wonder how it is possible that the 2800 mA batteries (both a used and a new one) are fully charged from 1% within 1.5 hrs with a 1000mA charger. With the same charger my S3 battery with 2100mA takes about 3 hrs to be fully charged from 1%.

How long takes charging on your phones?
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
Hi

Comparing those two gives different results, because they are physically different, so there is no answer to give....

One just charges faster than the other, it is an other model with other specs. ( not just the mA) But i understand your suprise in thouhgts ;)

How long it takes to charge my S5 idk, never pay attention to it. Once its below some point i hook it up. I do this for like years, never problems with battery before like it occurs now, since Samsung's new "batterycode" to avoid charge 100% without any clear reason. ( see my postings before )

:cowboy:
[Galaxy S 5 Android Development (Snapdragon)] Nerva:
Bueller?

Bueller?
[Galaxy S 5 Android Development (Snapdragon)] cvxda:
There was a security patch which made problems on certain routers. Should be fixed in the next build.

Corinna
[Galaxy S 5 Android Development (Snapdragon)] cvxda:
Battery

Any idea that the new charger code would also result in more battery usage is plain wrong. The code only cares for

charging

the device.

Uncharging

the device is the job of your apps.

Having said that.

I will not revert Samsung's battery change. I spent a lot of time with what it's doing and overall it's still a good change. The battery is handled more carefully to avoid battery swelling and the charging process itself is better controlled.

However, even if I can't understand the problem with 6-7% less battery, I understand that some people might miss the extra 12 hours of standby time. So I pushed a change to the battery handling like this:

The original patch changed the maximum battery voltage from 4400 mV to 4300 mV. This is the main reason the battery doesn't load to 100%. I changed the value to 4350 mV which results in a maximum charge to 98.6%.

At the same time, I changed the conversion between raw load and percent value so that 98% in old currency == 100% in new currency.

In other words: You'll see the device being charged to 100% again. In reality this will be a scant 2% less than before Samsung's new charger code.

I'm confident that everybody can live with this compromise. Hey, come on, 2%? Seriously?

The patch will be in the next build.

Corinna
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
Hi Corinna,

Thank you for diving in this matter and taking the time and effort tot chance it tot something we van live with.

The only thing im curious about is the superfast decharge wich takes place in my nighttime from 94 tot 83% in 6 hours eversince the new code was implemented. I have no other apps than before installed, changed no settings etc.

So looking forward to the next build to see its behaviour concerning this matter, by which you as I suppose mean the build nightly/daily from Dec 5?

:cowboy:
[Galaxy S 5 Android Development (Snapdragon)] xMandy:
Will we find these changes in the next RR as well?

And still a big thank you for your work!
[Galaxy S 5 Android Development (Snapdragon)] Samsung_S5_Plus:
Help! Stuck in TWRP after installation of Modem /Bootloader

EDIT:

To solve my SIM-Card issue I just tried to install another Modem/Bootloader and used the guide on page 1. I used Odin and selected BL there. But then my phone only rebooted into TWRP and I didn't get back into the system, even if I selected "reboot into system" in TWRP. I then did a dirty flash, got my data from the google-cloud back and now everything works fine. Also the bootloader /modem works fine so far, I have CRK1 (which you get when you download CRH1 from sammobile).
[Galaxy S 5 Android Development (Snapdragon)] olauer:
If you used a TAR together with odin you should have taken AP instead of BL, at least that worked for me.
[Galaxy S 5 Android Development (Snapdragon)] bege10:
Thank you very, very much. :good:

Will this have any effect on the extreme battery drain when the device is completely switched off?

https://jira.lineageos.org/browse/BUGBASH-2367
[Galaxy S 5 Android Development (Snapdragon)] js-xda:
Thank you for developing and implementing the above described changes. Very much appreciated what you are doing for us! From my point of view, this is a very good compromise. Two things that I observed and might be good to know for you [MENTION=3419717]cvxda[/MENTION] and others to know that it is not a glitch of their phone:

flickering of LED during charging

I can not recall that this has been the case before the initial battery code changes while I see it now quite often. Not sure whether it is really indicating something or whether it is only a glitch of the LED. Just for your information.

NEW with 181205 or 181206 - instant drop of indicated battery charge when disconnecting the charger

Charging the phone overnight, it will indicate 100 % charge in the morning but drop e. g. instant to 97 % when disconnecting the charger. When disconnecting right after reaching 100 %, it will not drop. I guess it is about - on purpose - not maintaining 100 % to improve battery life. Not sure what could be a good workaround to indicate both that the phone was charged in the mean time fully but is now not anymore.
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
It was the case b4, the changed code too, what you mean is not constant flickering but just now and than the charge-led turns off for 1/4 second and turns on right after that again, Hardly noticeable is what I try to say.

But it was there for at least more than a month.
[Galaxy S 5 Android Development (Snapdragon)] olauer:
I can confirm this behaviour of immediately dropping battery state after disconnecting the cable. Somehow the communication between GUI and battery state does not work as expected. I am not sure whether there is a direct link between battery voltage (shown e.g. by 3C Battery Monitor Widget) and battery state shown in the GUI.

In my logs battery is loaded up to 4330mV (at that time 89%!?), then it stays at 4330mV, but state increases to 100% over time. Then battery voltage drops to 4250mV (still connected to charger), battery state stays at 100%. After disconnecting the cable, battery state drops immediately to 96% (yesterday morning, today 98%, because voltage was higher).

https://drive.google.com/open?id=1Rg0-frGGMPZNuimH5_KnWjc_-iV1O5_G

https://drive.google.com/open?id=1udvNFHIqtEQ4UDhMce3szJ2JJdT9pJAI
[Galaxy S 5 Android Development (Snapdragon)] cvxda:
Weird. I can reproduce it... and then I can't anymore. I'm checking the values in the kernel and there is a situation where the scaled charge is 98.9% in the fuelgauge but for some reason the calling function changes that to 100% instead of the expected 98%. The problem is that this doesn't occur all the time. I'm debugging this for a while but the mechanism which suddenly decides to report 100% to the framework escapes me yet. I need more time to debug this, maybe even a lot more.

Corinna
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
Maybe its just me thinking simple:

Take out the new "better"-charge-code and all problems are solved about this matter, charging good like it did from the beginning and nothing wrong anyway as there was nothing wrong before the code ?

:cowboy:
[Galaxy S 5 Android Development (Snapdragon)] cvxda:
Yeah, sure. The simplest way is to stick to one version of the kernel and not apply any more patches. What are those good for anyway, right?

Corinna
[Galaxy S 5 Android Development (Snapdragon)] olauer:
Hello Corinna,

perhaps this is not a very clever question, but how do you get the Samsung patches? Do you only get the hardware patches (e.g. battery charging code) or do you also have access to the corresponding Samsung GUI changes?

I am - I think as well as you - not really satisfied with the current situation. The old code was working and now Samsung changed the behaviour for some - unclear - reason. In their own GUI they implemented a solution to cover that.

What we can see, is that the battery voltage is now not completely kept at its max value when the charger is connected.

Just to understand, how is this battery percentage calculated? Just from voltage or are there any other informations used?

Thank you for your work.

Oliver
[Galaxy S 5 Android Development (Snapdragon)] js-xda:
I agree completely that simply reverting to the old code is not solution - if at all, it is a temporary workaround. Not knowing much details, I can still imagine that also some future changes from Samsung depend remotely on having the code implemented and than you would only delay further issues.

I am glad that you are trying to fix this in a good way. Once things work as planned (indicating 100 % at the former 98 % and behaving properly with regards to % indicated before and after disconnecting the charger), I would be completely satisfied.
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
I never said not to apply any patch. I'm just talking about this one.

You know I'm no programmer, just end-user and giving feedback from my thoughts.

The way you write your answer tells me you get annoyed. Well that's your problem, not me causing that. Maybe you should think before you type things the way you do now. Its kinda impolite, not to say rude. A good advice I think. Cheers.
[Galaxy S 5 Android Development (Snapdragon)] mannu56:
Hello Corinna

Good job for our G901F, without you mine would be at the bottom of a drawer.

a big thank you for your efforts.

cordially

(translated with google translation)
[Galaxy S 5 Android Development (Snapdragon)] Zubagy:
Old battery code, no problems

New battery code, abazillion bugs and problems...

Why Samsung, why:rolleyes:
[Galaxy S 5 Android Development (Snapdragon)] Krapotke:
We should give [MENTION=3419717]cvxda[/MENTION] a chance and time to solve issues. It's good to grab them in the root and don't invent workarounds. They causing often more problems than they solve. Only if there's no other way.

Even then, there's always the option on remaining on old stable builds. Even then, Corinna is a voluntary contributor, and I don't doubt you appreciate that. But noone is responsible here for any problems as it is, as I said, voluntary. There's always the option to propose better suggestions (if they really are). And then can always discuss them.

Maybe [MENTION=5156684]andreoide[/MENTION] I kindly ask to start learning to code yourself; I think you will be a critical and a good programmer and will help the community in your way as you understand the structures and emphasis.

If time allows it, everyone is welcomed to post pull requests with fixes and features.

Maintain such a complex device is always extremely time consuming (you won't believe it).

Noone meant to be impolite; but as I remember there's always a limit of politeness (more or less for each pointing at themselfs).

I know such issues are quite annoying, but we can improve them ourselfs, if we really want to / or need patience.

Thanks to all for your contribs.

P.S.: I switched device to another newer one, once my display got partly broken. Sometimes the effort of maintaining such a device reaches a limit, even if I would always appreciate any enhancements.
[Galaxy S 5 Android Development (Snapdragon)] js-xda:
I can confirm that the behavior is still present with build 181208 (there was some unrelated - I guess - change in the change log). Dropping from 100 to 97 % when disconnecting after charging overnight. For the overnight scenario, it is 100 % reproducible so far.
[Galaxy S 5 Android Development (Snapdragon)] bege10:
"Warning: no file_contexts" during update process

The information shown in TWRP during every update has a statement saying "Warning: no file_contexts". Is that normal or an error message? What does it mean?
[Galaxy S 5 Android Development (Snapdragon)] virsago_mk2:
Can I install LineageOS in G870A or G870F model?
[Galaxy S 5 Android Development (Snapdragon)] cvxda:
The charger code charges the battery up to the defined maximum, then it stops charging until some configurable "low value" condition arises. This condition triggers recharging. The point where it starts recharging was badly defined because I didn't change it together with the change to charge up to 4350mV.

I applied a patch which is supposed to fix the issue. This should show up in the next build.

Be aware that you can still observe a drop from 100% to 99% or maybe even 98% (didn't occur in my testing) as soon as you unplug the charger. This is perfectly normal. The recharge condition is only defined in terms of mV, which is a pretty variable definition. It may occur earlier under load or later if the battery has nothing to do.

Corinna
[Galaxy S 5 Android Development (Snapdragon)] cvxda:
I get access to the kernel sources on request, thanks to the GPL. I don't get access to any other source(*) because they are under less free licenses.

Corinna

(*) There's a way to decompile the java blobs, but it's quite a hassle.
[Galaxy S 5 Android Development (Snapdragon)] cvxda:
Yes for G870F, but not this one. It's for G901F and G906S/K/L only. Try the G870F kernel instead:

https://download.lineageos.org/klteactivexx.

You also won't get any help for this device in this XDA thread. Search for an S5 Active thread instead.

Corinna
[Galaxy S 5 Android Development (Snapdragon)] Zubagy:
Same observation on my end....I stayed on 100.

Am kinder having glitches with my phone and the lineage, my screen displaces itself.... This is in search a way that the keyboard can appear at the top of the screen but later returns to its position. Notification panel also moves to any position it wants... Basically the screen gets shuttered/scattered for a sec then everything returns to normal again...I do not know if am the only 1 experiencing this
[Galaxy S 5 Android Development (Snapdragon)] js-xda:
Thank you for implementing the changes.

Charging overnight, I saw still a drop to 97 % when disconnecting - using build 181212. Battery menu states charged 0 min ago right after disconnecting.

Fine with - just sharing the observation. And might be due to the battery while it is otherwise still delivering good performance/endurance.

ADDITION: Reproducible on same build this morning.
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
I notice the same, and after that for instance reading 10 main in XDA here drops from 96 to 87.

Fast decharge while doing nothing special. ( screen brightness like 40%)
[Galaxy S 5 Android Development (Snapdragon)] js-xda:
Not valid for me. Right now, I am still on 94 % after having read some news, posting this and similar low load activities. But I can recall that the drop to 96 % was quite soon after disconnecting the charger.
[Galaxy S 5 Android Development (Snapdragon)] olauer:
Would it be possible for you and andreoide to record voltage values, e.g. with Battery Monitor Widget? For me battery does not load over 4313mV, perhaps because battery is already two years old. I am not sure to how which percent corresponds this value.

Regards Oliver
[Galaxy S 5 Android Development (Snapdragon)] Samsung_S5_Plus:
SD-card is "missing" after update

After each update my phone says "SD-Card is missing". After a manual restart the SD-Card is there again, but all shortcuts on the homescreen from apps that were installed on the SD-Card (and not the inner storage) are gone.

Does anyone experience the same?
[Galaxy S 5 Android Development (Snapdragon)] jerfsonpaiva:
This room actually has Vulkan?
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
Only he is.....
[Galaxy S 5 Android Development (Snapdragon)] oddfellow667:
Hi Corinna,

thanks for your support of the G901F kccat6. I have a spare device (German T-Mobile version, used but fully functional) and if you need one for development or testing, I can send it to you. Just drop me a private message if there is any interest.
[Galaxy S 5 Android Development (Snapdragon)] jerfsonpaiva:
805 and Adreno 420 not have Vulkan? The notices is a Qualcom joke\fail?
[Galaxy S 5 Android Development (Snapdragon)] js-xda:
[MENTION=3419717]cvxda[/MENTION]: I saw that you released "apq8084: kccat6/lentislte: Fix battery settings, take 3" on Sunday and monitored the behavior after updating on Sunday even so I am not sure whether the change ("Change battery,recharge_condition_type to recharge on 98% SOC as well.") is related to my previous observation. With regards to that, I can mention that I had since then once 98 % (very soon after drop to 97 %) and once 98 %. Again, no complaint - just trying to give you input. If the code change does what you intended it to do, I am happy - since I am also happy how great everything is working on my G901F.

Further observation until 22.12. [MENTION=3419717]cvxda[/MENTION]: This morning, it dropped again straight to 97 %. Difference that I can think of is that the first two nights were short (6-7 h) while the last was 10+ h. But I am doubting a bit that it is solely due to the battery shape - it last still two days (morning until evening the day after) which is quite good to my opinion.
[Galaxy S 5 Android Development (Snapdragon)] Néocray:
Hey guys,

I'm a RR rom user, but my problem is from TWRP and it seems there is no support thread for TWRP.

I'm having some trouble in restoring a NAND backup from one G901F to an other: the receiver recovery finds the backup location on the SD card, but doesn't seem to properly read it. The name is wrong and no partitions are seen in the backup.

Any idea what is going wrong?
[Galaxy S 5 Android Development (Snapdragon)] Zubagy:
Hi Corinna, how are you. i need assistance with my device. It keeps restarting when it gets difficulty in processing i think and it heats up alot at that point. Every after a call, my sensors that are supposed to power on my screen fail and at that point, the phone will restart. Even the bug i told you about where there are many lines in different colours drawn causes it to restart. Please help me fix this bug. and it has started happening of recent. Today i have installed the update "lineage-15.1-20181221-nightly-lentislte-signed" and so far nothing has happend. but let me continue monitoring the progress and see how thw hone will act.
[Galaxy S 5 Android Development (Snapdragon)] liverhook:
Updated 4 days ago: before charging until 94%, now 100% (with Samsung wireless charger on usb)!

But: with phone powered off beginning of charging wireless, but then seems like a loop to begin charging new. After waiting 10 min. no change of behavior.

By the way: I flashed new modem (baseband CRA1) and bootloader CRH1 (as it is always said 'use the newest versions'). Is this a problem for the further maintenance of this phone model, must it be considered in the work of Corinna, or is this not critical because it doesn't matter?
[Galaxy S 5 Android Development (Snapdragon)] Hellisonearth:
im on dec 16 nighty. today bluetooth didnt work, suddenly after 5 minutes it popped on (too late). now, i got no simcard signal. restart fixed it, but still reporting it, since i didnt have that since months.
[Galaxy S 5 Android Development (Snapdragon)] andreoide:
The same thing happens to me too every now and than. No pattern in which you know when it will occur, bug come random.

It is a known-not-fixed (yet) bug.