yashsingh1/xdaforums huggingface dataset:
[Magisk] ianmacd:
Yes, exactly right.

Given that the addition of new channels is an infrequent occurrence, I don't think it's worth writing code to work around this problem. If John adds more channels in the future, anyone using the ianmacd channel will just have to reselect it. A workaround is to simply apply the ianmacd channel URL to the Custom channel and use that instead, since Custom is a standard channel and will not ever need to be renumbered.

One good thing to come out of this is that I found a bug in the section of my build script that creates the in-app changelog. Commits would be omitted if their commit timestamp was earlier than the timestamp of a commit already included in the previous release. This could happen, for example, if I made some original commits of my own, released a build containing them, then merged commits from John that had been committed earlier than mine, but not pushed until after the release of my build. It's quite an awkward issue to even describe, actually, but the fix was to use the --topo-order switch when running git log. You learn something new every day.

---------- Post added at 16:19 ---------- Previous post was at 16:15 ----------

Out of interest, where did you find preferences.xml? My MM installation doesn't have this file. I did a full file-system search for the file, but found only a handful belonging to other apps on the system.
[Magisk] neekless:
Not sure if this is what he's referring to, on my device the path is /data/user_de/0/com.topjohnwu.magisk/shared_prefs/com.topjohnwu.magisk_preferences.xml
[Magisk] guest4711:
[MENTION=7187684]ianmacd[/MENTION] Yes, it was in folder "shared_prefs” of (hidden) MagiskManager, e.g. /data/data/com.blabla/shared_prefs/. But after upgrading to 2019030909 it's gone, even after wiping cache and data of MM. But it was on my tab2 running Android 6 (M). Now I'm on the way using a S4 running Android 9 (P). When back at home I'll have a look.

Edit: On P it is at /data/user_de/0/com.xeQL1.W6TRUTbF3n/shared_prefs as com.xeQL1.W6TRUTbF3n_preferences.xml
[Magisk] HamsterHam:
I'm trying to figure out if this is a magisk issue. Pretty much and found after a few seconds my apps don't show data correctly.

If I check straight away all good. After a few seconds it's showing zero. Can someone check please. I've got a Pixel 3XL.
[Magisk] bggold:
Yes it is magisk hide. I opened an issue with topjohnwu and he has confirmed it.

He said he will need to look into it.
[Magisk] HamsterHam:
Just saw your report on GitHub. Cheers. Does it really affect anything? Do you leave magiskhide on?
[Magisk] bggold:
Nope have had not issues
[Magisk] guest4711:
On my tab running M is it stored in folder /data/data/com.TXnc13SoU.f3VUFD/shared_prefs as com.TXnc13SoU.f3VUFD_preferences.xml . /data/user/0/ is a link to /data/data; /data/user_de/ is inexistent. [MENTION=7187684]ianmacd[/MENTION]
[Magisk] HamsterHam:
[MENTION=7187684]ianmacd[/MENTION] - can you revert this please? https://github.com/topjohnwu/Magisk/commit/081074ad9d5c02e589f265373c0dfa867c9eeaff

It's causing increase CPU usage and lags. Cheers.
[Magisk] Tornado15550:
It's best to file an issue on GitHub so John can take a look into it. There's no point in reverting the commit here when the next version of Magisk may include it.

For what it's worth, I've noticed a slowdown on my Pixel 2 XL as well, so it's not an isolated issue.
[Magisk] martyfender:
I guess I am one of the fortunate, then, I am not noticing any slow downs on any of my 5 Nextbook Ares 8A's, x86, Android 6.0.1 tablets with both the latest Canary and [MENTION=7187684]ianmacd[/MENTION] builds. So far, this seems to be one of the best builds for me, yet. I see no higher than normal CPU usage and battery life seem normal for these devices. The only time I notice high CPU usage is when a device has been in doze for some time and I wake it up. However, that has always been normal for these devices. It always settles down after a few minutes.
[Magisk] Tornado15550:
The next nightly build should fix this issue. Check this commit.
[Magisk] martyfender:
These issues appear to be fixed in the latest Canary 18116 build.
[Magisk] habylab:
No issues in 116.
[Magisk] ianmacd:
Indeed. 2019031001, which I have just pushed, should fix this issue for those who experienced it.

Even if it didn't, however, I am loath to revert any commit from these unofficial builds, unless I can't get a build to even boot without doing so. The more device models and configurations hit by a bug and the more reports that follow, the more data John has to work with. That's what a good canary does: he tests the environment on behalf of others, sometimes sacrificing his own well-being in the process. At least we canaries make the choice ourselves to be a canary.

Apart from which, daily snapshots (intra-daily, in the case of these builds) are, by their very nature, at the very bleeding edge of software, more so even than the Canary builds. Sometimes, you'll bleed. Any given build might blow up on any given device, even if it works perfectly on another. Or it might function (for a generous definition of 'function'), but in an unacceptably poor way.

The way to proceed in such cases is one of the following:

Report the problem (upstream), including logs and steps to reproduce, and patiently wait for a fix.

Revert to the previous build.

Only run snapshots on devices whose performance isn't critical to you.

If you dare to run these builds on a production device, they will break it sooner or later. It's only a matter of time. That doesn't mean you shouldn't, but it does mean you have to be prepared to take the rough with the smooth. Calls to revert a commit will usually fall on deaf ears if the build that contains it works for someone, and if I chose to release it at all, that almost certainly means it worked for me at least.
[Magisk] tycoon78[stoner]:
MM crashing

MM is crashing on the latest build(2019031403) on my note 9(exynos) pie when setting up environment is completed. Plus additional setup pop-up is coming up every time i open magisk app even after the setup is done. :eek:

here is the SS and magisk log.
[Magisk] DIMITRISGR83:
Where can I find builds??

Στάλθηκε από το Redmi Note 4 μου χρησιμοποιώντας Tapatalk
[Magisk] RagingHarry:
https://github.com/ianmacd/MagiskBuilds/find/master
[Magisk] martyfender:
https://github.com/ianmacd/MagiskBuilds/tree/master
[Magisk] DIMITRISGR83:
Thanks very much!!!

Στάλθηκε από το Redmi Note 4 μου χρησιμοποιώντας Tapatalk
[Magisk] Tornado15550:
Good news folks, Magisk now supports Android Q on Pixel 1 and 2 including the XL variants! The next nightly will most likely contain those commits.
[Magisk] PokemonTotalWar:
Does anybody know how Magisk handles conflicts? For example, if two modules add the same apk file to /system/app, which one would win and have their file used?
[Magisk] Didgeridoohan:
Whichever module is first in the mounting queue (if I remember correctly, the module that was installed first).
[Magisk] PokemonTotalWar:
That makes sense, I couldn't find any apparent list of which modules you have installed in the Magisk files. Is there anywhere to see the order, and would enabling/disabling modules reorder it at all, or is it strictly installation-based?
[Magisk] Didgeridoohan:
I don't quite remember, but I believe it's strictly installation based (but a reinstallation over the existing module should count, pushing the module to the end of the queue). You'll see in the Magisk log in what order the modules are loaded.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I was looking forward to a new build, when I saw your issue posted on github about the problems you had with it.

I was wondering if compatibility with Q could potentially break older versions.
[Magisk] ianmacd:
There's a test build in the testing branch if you're feeling brave, but as you saw, I can't boot since that commit went in. And even with that commit reverted, the next one breaks my boot, too.
[Magisk] martyfender:
I think I’ll wait.

Thanks.
[Magisk] martyfender:
On my 2 devices with Canary, I flashed 181119 and so far it seems to be working well.

On the first device I flashed it on, it only booted to the battery screen and upon booting into TWRP and flashing 181118, it did the same thing, so I thought I had bricked the device.

It turns out it was a stupid mistake, as the battery was at 1%. I'm not sure how it was that low so quick, but since the last Canary update, I may not have charged it and thought it was much higher. Thank goodness! I guess I have never let a device get that low that it booted to the battery screen, so I thought it was bricked.

So with that said, I believe your test build on my other device should theoretically work fine. I may test it on one of my three devices on your build.

I'm not sure though, that there is anything in there for improvement on older devices, but compatibility is important, though.

---------- Post added at 01:33 AM ---------- Previous post was at 12:42 AM ----------

UPDATE:

Your test build 2019031501 bootlooped on first boot, but after a forced shutdown and a cold boot, it booted up fine.

I posted a log created with a bootscript yesterday on github about the first boot bootloops I have been intermittently experiencing on my 5 devices since the end of January or the first part of February, Sometime around the time that magisk.img was removed. Also a lot of boot code was migrated to c++, also. It seems like if I shut down after updating and do a cold boot, I have fewer first boot bootloops. However, I did not do that this time to test.

When your S9 bootlooped, did you try a forced shutdown, followed by a cold boot to see if it would eventually boot? With this latest test build, I had to wait some time for it to boot, in what seemed much longer than normal. When I thought it had bootlooped a second time, it eventually booted.

That particular device appears to have slower internal memory than the other 4 devices, because installing updates from the playstore, or flashing magisk in twrp has always taken much longer on that device. It is my oldest, v1.1 device.

I hope John quickly come up with a solution for your device and any others experiencing issues with the Q compatibility added.
[Magisk] bggold:
I flashed your test build just for s**ts and giggles and it booted, had root but safetynet failed.

Flashed back to your previous build and all is good.

Just wanted to pass that info along.

Thanks
[Magisk] martyfender:
Safetynet passes for me with that build.
[Magisk] ianmacd:
John has located the source of the problem and is going to restrict the code in question to running on Android Q only.

As soon as this commit is pushed to the repo, I'll post a new build.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I had trouble with your latest build as well as Canary 18120 with modules not working but solved it by running the latest Magisk unistallers followed by reflashing Magisk and all of my modules.

All of the devices appear to be running good.

Thanks for your builds.
[Magisk] tycoon78[stoner]:
Updated to latest build of ianmacd. Everything is good and smooth on sammy Note9. Thanks [MENTION=7187684]ianmacd[/MENTION] :angel:
[Magisk] kondrakov:
please share files 7.0.1 and 18.2,

thank you!
[Magisk] guest4711:
You will find all files on GitHub. See e.g. https://github.com/ianmacd/MagiskBuilds/tree/master
[Magisk] Kglim:
032301 build safetyNet checks pass.

Finally I moved from 0228 build and no bootloop issue for me
[Magisk] DIMITRISGR83:
Where is latest download links, I can't found please?

Στάλθηκε από το Redmi Note 4 μου χρησιμοποιώντας Tapatalk
[Magisk] Kglim:
032301 build

https://github.com/ianmacd/MagiskBuilds/find/master?q=0323

Check this
[Magisk] Techvir:
HI, I want to report on 2 bugs. Sorry no logs but if these are not know issues I can try to grab some logs.

Both the issues happen with V18.2 ( tired few different 18.2 versions) and not with V18.1 . As soon I flash v18.1 the issues are sorted out

I am using note 9 ( N960F) on ketan romv09

1-	Swift installer does not theme any app using root.

2-	The bigger problem is with installing detach module of youtube vanced. When I flash using magisk or via twrp the file, ytva-universal-installer-v4.1.zip and using the detach script ytva_detach_from_playstore.plz I get the error /data/adb/magisk.img not found

Then when I go to TWRP I get data cannot be mounted. So I have to erase everthing to fix the problem

The files can be downloaded at https://drive.google.com/drive/folders/1x67EYgPeLLSVzRfZyeLRCeWmbF-fUggd
[Magisk] guest4711:
The second issue is definitely a problem of the module expecting magisk.img to be an image file, not a link. Since 18.1 Magisk does not use an image for storing modules, they are stored in /data/adb/modules instead. Probably the module should be updated. Please talk to it's developer if there are no updated versions for use with Magisk>=18.1
[Magisk] Techvir:
Thanks.... Will do...

---------- Post added at 09:42 AM ---------- Previous post was at 09:37 AM ----------

I have the issue with 18.2 but with 18.1 it works fine
[Magisk] edzamber:
Try this for Detach YouTube from Playstore.

Thanks to [MENTION=1909299]hinxnz[/MENTION] and [MENTION=5332893]Rom[/MENTION]

https://www.mediafire.com/download/hjkd9fv41vkbzkh
[Magisk] Techvir:
Shoud i use the same script as before ?
[Magisk] edzamber:
Just flash, the needed script is include in my zip.
[Magisk] Techvir:
Thank you so much.. It worked well.. even with 18.2
[Magisk] Ubimo:
I'm worried, is everything ok with [MENTION=991723]ianmcd[/MENTION]?

Last build was 3 days ago.

Hope he is OK?
[Magisk] ianmacd:
Thanks for the concern, but I'm fine.

There has been nothing new committed to Magisk in the last few days, hence the lack of new builds.

In the background, John is presumably beavering away on the back end, making adjustments to the repo server and whatnot for an imminent milestone release of Magisk.

Rest assured, as soon as there's something worth sharing, I'll share it.
[Magisk] hanschke:
I dont think we will see a build with root soon that works.
[Magisk] martyfender:
It works for most of us, but without more information, nobody can help you. Did you try the new builds from today?

https://www.didgeridoohan.com/magisk/MagiskHelp
[Magisk] jcmm11:
[MENTION=7187684]ianmacd[/MENTION]

I see you updated your sqlite mod for the latest Magisk template. Just wondering why you didn't bump the sqlite version while you were at it? Thanks.
[Magisk] ianmacd:
A combination of expedience and laziness.

I wanted to update a low-key module to ensure that I understood the v19 template model, so I picked this (and one other).

When I looked at when the module had last been updated, I thought to myself "I wonder if anyone is actually using this module. Maybe I'll find out when I update the module without refreshing the binary."

And then you posted. :)

So, I guess I'll update it shortly; just as soon as I've got all of my other modules updated to the v19 template, since that operation has a hard deadline to contend with.

UPDATE: Module updated to SQLite 3.27.2.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] Your latest build is work very well for me as is the latest Canary build, On my Nextbook Ares 8A's. However, I keep seeing report after report of Samsung users having problems with the latest v19 where they are booted to download mode. Do you have any insight as to what is going on, since you are also on a Samsung device?

Thanks
[Magisk] Techvir:
I think I said too soon... Module installed but it is not detaching the YouTube from playstore...

Any other suggestions??
[Magisk] ianmacd:
Both of my trusty Samsungs (an S9+ and a Tab S4) are Oreo devices and have no problems with the latest Magisk. If they did, I would have held back on releasing a new build and would have filed bugs against the code.

I've also got an S10+ (which is a Pie device) that is currently running an earlier hand-patched canary build, and that's running fine, too.

I haven't seen the bug reports about Samsung devices, to be honest. I assume they're in the main support thread, which I will have a look at later.
[Magisk] martyfender:
Yes, they are in the main and Canary threads.
[Magisk] guest4711:
I tested the builds on five different Sammy devices (maguro on N, jfltexx on P, jfltexx on N, jactivelte on N, espressowifi on M) without problems. All have custom ROMs. Perhaps it's a problem with newer devices or stock ROM only.
[Magisk] martyfender:
I believe most of the reports I have seen were on Lineage OS.
[Magisk] edzamber:
Enter theses command into Terminal Emulator app :

su

Detach -id
[Magisk] Techvir:
Please see the screenshot View attachment 4733619
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I see you have a new testing build up, 19.1-2019033001-ianmacd/7.1.2-2019033001-ianmacd. Did you have issues with it on your devices?

Thanks
[Magisk] ianmacd:
Not much gets past you, Marty. :)

This testing build contains code to support the S10 range, but yes, there are problems with it on my device.

Since the S10 changes are the only changes in this build, I've chosen not to release it until I can talk to John and find out whether there's an actual problem with the code, or whether I've just misunderstood something
[Magisk] martyfender:
I assume since he didn't release a new Canary build that it is a work in progress, maybe? Was it a problem on all of your devices, or just your new S10?

Your build from yesterday is working great and Google Pay is working so far, but I can't test in stores, since my devices don't have nfc. I have my debit card and PayPal added. I don't need gpay, but I am testing it since others seem to have problems with it. I am old school and still pay with my debit card.

Thanks
[Magisk] guest4711:
If you call this "old shool", how do you call paying by real money (because of privacy, less costs for dealer and buyer, accessibility and so on)?
[Magisk] ianmacd:
I didn't bother testing other devices, because those devices aren't A-only partition system-as-root devices and shouldn't be affected by the new code. Since there were no other code changes, no other device stands to gain anything.

Anyway, I figured out my issue and have moved this morning's build over to master. In other words, it's now publicly available.

It's not a question of being old school; it's just plain common sense: Use a payment mechanism that requires a power source and is prone to multiple points of failure in both hardware and software, or use a robust piece of plastic that requires no power, no hardware and no software?

If we'd been using Google Pay for years and someone now came along and proclaimed he had invented the plastic debit card, he would rightfully be hailed a genius. Solutions like Google Pay are to virtually fail-safe mechanisms like debit cards what fax machines are to e-mail. The emperor isn't wearing any clothes.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] When flashing your latest through TWRP, I get an updater error 1. When I reboot and then open MM, I get the message that additional setup is required. on the modules tab only placeholders for them are shown. I'm going to work so I won't be able to test further until later.

Thanks
[Magisk] bggold:
Had no issues installing on 2 devices through mm.
[Magisk] ianmacd:
No issue here on my S9+, S10+ or Tab S4 when flashing with the MM app.
[Magisk] martyfender:
I see hou released a second build today and when I get a chance I will try it. The one I reported was the first build, I believe.
[Magisk] jcmm11:
[MENTION=7187684]ianmacd[/MENTION]

Can you take a look at https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post79232901

Pretty sure you can give him better info than I can (Forum mod asking for help)
[Magisk] ianmacd:
I tried flashing my S9+ with my latest build through TWRP instead of Magisk Manager and, whilst there are no errors and everything appears to go well, the patched boot image isn't getting flashed.
[Magisk] martyfender:
During my dinner hour I tried on my primary device and got the same error. This time though, I was smart enough to flash your previous build, before rebooting and every thing is good again.

When I get home I will try to save a recovery log, probably won't be useful, though.
[Magisk] Ferbee:
[MENTION=7187684]ianmacd[/MENTION] I don't know if you know this or not, but I'm on your latest build and everything is working fine, but the modules aren't appearing in the module list, they are working though just nothing appears in the list.

Device Specs:

Exynos Samsung Galaxy Note 8 (N950F)

Infinity Rom 3.0

Phantom kernel 2.1

Your latest magisk build as of time of this post.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I just tried the patched boot.img method and flashed that in TWRP and it bootlooped, on first boot. I did a forced shutdown , started up with a cold boot and it boots up normally and in the modules section I get:

img

(no info provided)

(no info provided)

(no info provided)

With a root explorer, I see all of them there in

/sbin/magisk/modules

and:

/data/adb/modules

This is the strangest behavior I have seen with Magisk, yet, I believe.

Furthermore, to emphasize, this is why I test these builds, so no complaints.

All root functions and magisk hide appear to work, though. The safetynet test passes.

I am now rebooting to TWRP and wiping the cache and dalvik cache.

I get the same result after that.

So it is back to v19.1-2019032901, for me now.

Flashing the v19.1-2019032901 zip restores my modules which were still there, as expected.

Because of all of the issues I had with direct install in the past, I have been hesitant to try it again, since it often involved a factory reset to sort it out.

when I went back and tried to restore v19.1-2019032901 I had issues with a bootloop. What finally resolved it was flashing my stock boot.img, followed by v19.1-2019032901.

I wonder why boot.img are getting corrupted after multiple patchings with Magisk, or maybe it is when only reverting to a previous version.

With all of my problems, I forgot to save logs with those failed attempts.

I also just tried the direct install method, since you had no problems with it and my modules are not there again, even though they are there in the default places.

So once again, back to v19.1-2019032901 until a newer version is released to test.

One question, why is MM reset to the Canary build in settings and not yours? It is not a problem, since I now know this and change it in MM settings.
[Magisk] guest4711:
No such problem here on all devices I tested. (Version 20190330002) [MENTION=8126387]martyfender[/MENTION] The update channel is still on ianmacd per default for me.
[Magisk] martyfender:
Try deleting data and cache of the app in android settings, app and see if that is still true. Sometimes when I initially update MM to a new version in settings, it freezes on the splash screen. Deleting the data for the app always solves it.

I don't post about it but on 5 devices it randomly occurs. Maybe on my devices there are delayed writes and I launch it to quick after installing?
[Magisk] guest4711:
Ok, did it. Clearing data of MM resets the updata channel to canary-debug. (And timeout etc. to default).

After resetting data of an app I always check every setting of this app, so not a problem.

Module list still intact.
[Magisk] ianmacd:
Those of you with module problems, are you definitely running the latest MM?

I had a brief mismatch yesterday between the versions of my MM and Magisk and saw odd behaviour myself. Any module installed with the latest MM installed correctly and was listed in the app, but would not load on boot with a version of Magisk from just a few days ago. Here, my version of MM was newer than my Magisk. If your MM were older than your Magisk, it's conceivable that your modules might disappear from the list instead.
[Magisk] Laserek_Poland:
I dont know if its important but 19.1.for 3003 does not work with GoolePay on Mi9