yashsingh1/xdaforums huggingface dataset:
[Magisk] martyfender:
Your build is working well on three devices.

The thing I have not tested recently is the direct install method, Since I have had so many problems with it in the past few weeks. I have been installing in TWRP.
[Magisk] daleski75:
Followed the instructions given by [MENTION=7187684]ianmacd[/MENTION] and flashed the latest zip under TWRP, cleared data, installed the latest 5.8.4 magisk manager but keep getting invalid response still on my oneplus 6.

**EDIT**

Decided to start from scratch and narrowed it down to a oneplus 6 camera m magisk module which is tripping safetynet the second I removed it safetynet check passed.
[Magisk] neekless:
There was a commit 11 days ago that adjusted the direct install method. Have you tried direct install after that?
[Magisk] martyfender:
Yes, if my memory serves me correctly, it worked after that commit, then on a build or two after that I got my famous, boot to a bootloader error message I posted about a few weeks ago.
[Magisk] L.F.B.:
Pretty nice to have snapshots!

Ive added your update chanel and now all update to your versions!

All working smooth and safnet responce is working again! ??
[Magisk] ianmacd:
I'm glad that you got it working, but an invalid response is not the same thing as a failure to pass. Given how you fixed the problem, I'm assuming that the invalid response you reported was simply a failure to pass.
[Magisk] daleski75:
Yup it wouldn't download or pass the safetynet until I removed that module.
[Magisk] ianmacd:
Today's build (2018082401) of my fork integrates a patch not yet merged into upstream Magisk that gets Magisk working on Note 9 devices. I imagine users of that device will want to try this out at their earliest convenience.
[Magisk] RagingHarry:
Working like charm.
[Magisk] kantjer:
I used your code to raise the patch level but took another route to get the base levels.

I wanted to also pull the snet versioncode, the only place I could find that was in the original json. This is what I came up with.

JSON="beta.json"
VERSION="version.sh"

wget https://raw.githubusercontent.com/topjohnwu/magisk_files/master/beta.json >/dev/null 2>&1

sed -n '/"version"/p;/"versionCode"/p' ${JSON} > ${VERSION} # copy all lines containing version/versionCode to temp file
sed -i -e 's/^[ \t]*//' ${VERSION} # delete all leading blank spaces/tabs (whitespace) from each line
sed -i -e 's/"version\": //g;s/"versionCode\": //g' ${VERSION} # remove version/versionCode strings
sed -i -e '2d;4d' ${VERSION} # delete lines 2 and 4
sed -i 's/,$//' ${VERSION} # remove comma at end of each line
sed -i '1s/^/MagiskManagerVer=/' ${VERSION} # set variablename 1
sed -i '2s/^/MagiskVer=/' ${VERSION} # set variablename 2
sed -i '3s/^/snetVer=/' ${VERSION} # set variablename 3

chmod +x ${VERSION}
. ${VERSION}

MagiskManagerVer=${MagiskManagerVer%.*}.$((${MagiskManagerVer##*.} + 1))-unofficial
MagiskVer=${MagiskVer%.*}.$((${MagiskVer#*.} + 1))-unofficial

rm ${JSON}
rm ${VERSION}
[Magisk] ianmacd:
You can obtain the snet version locally like this:

snet_version=$( sed -rne 's/^.*versionCode ([0-9]+).*$/\1/p' snet/build.gradle ) # -> 11

Like you, I was using find and replace on the JSON file until John's most recent changes. Now, it's become just too awkward.

Now I simply embed the JSON file in my bash script as a double-quoted so-called here-document, and I let variable interpolation add the right version strings in the right places. This is really easy, with the only disadvantage that I won't notice if John silently adds new parameters to his JSON.

For example:

cat > $json << EOF
{
"app": {
"version": "$app_version",
"versionCode": "$versioncode",
"link": "https://github.com/ianmacd/MagiskBuilds/raw/$branch/MagiskManager-v$app_version.apk"
},

# etc., etc.

}
EOF
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I finally tested the direct install method with your latest build yesterday and all went well.

When [MENTION=3306843]kantjer[/MENTION] releases a new build, I will test the direct install on it, also. I installed through TWRP on his latest build, on my 3 other devices.

Thanks
[Magisk] aer0zer0:
[MENTION=7187684]ianmacd[/MENTION] latest works like a dream on essential, thank you
[Magisk] paolocorpo:
[MENTION=7187684]ianmacd[/MENTION] I changed inside Magisk Manager the line of testing using the GitHub web site link method and all worked well to me

MANY THANKS

ONE NOOb QUESTION: which is the most important extra feature that your release offers versus the official release ??

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] 587.saboor:
Same on A8
[Magisk] Vuska:
Hi..

i just installed 2018082301 version... over magisk 16.7

it work...

but i see the message :

"There's an internal problem with your device. Contact your manufacturer for details"

how can i get rid of it?

sorry..

Thank you

edited : Sorry.. just fixed this issue by flashing a custom kernel.

thank you OP for this wonderful Mod.
[Magisk] L.F.B.:
Lol johwhu said on Twitter he managed to solve the quota problem on api key?

Anyone have any clue how he managed to solve this? Im really courious ?

My idea was every user should have your key... But is not sooo easy to medium user to acqire one...
[Magisk] Didgeridoohan:
That's easy... [MENTION=4470081]topjohnwu[/MENTION]'s real identity is Sundar Pichai... :cool:
[Magisk] martyfender:
Does anyone know what: Samsung defex is?

https://github.com/topjohnwu/Magisk/commit/f6aae2b048966e2c5c065c9a9906aa6d021333d0

Thanks

Never mind, I found it here:

https://github.com/topjohnwu/Magisk/issues/426
[Magisk] ianmacd:
I don't know how John circumvented the issue, but I can think of a number of ways one might implement this.

One could, for example, have multiple hard-coded keys picked at random. That would be a trivial fix with little administrative overhead.

A more flexible solution might involve running a separate server that serves API keys in round-robin fashion, but that obviously comes with more overhead and responsibility.

Personally, I'm rather surprised that so many people feel the need to check SafetyNet every day. For me, it's a check-once-and-forget-about-it kind of thing.
[Magisk] JEANRIVERA:
exactly this is a thing you check when you have issue with an app that uses the API, it is not a thing to check every 2 or 3 hours. :fingers-crossed:
[Magisk] martyfender:
With the latest build, where is Magisk placing download files such as: Magisk-2018082708.zip, module downloads and install logs saved?

Thanks
[Magisk] Didgeridoohan:
In the Downloads folder.
[Magisk] neekless:
Magisk zip and module downloads should be in your [Internal Storage]/Download folder. Not sure where the logs are.

Edit: Sorry didn't see didgeridoohan already answered it
[Magisk] martyfender:
That is true for the install log and if you choose download zip only, but not if you choose the direct install method. I found it, not sure if I should say, though. The MagiskManager.apk is downloaded to internal/MagiskManager/
[Magisk] Didgeridoohan:
Let me guess: /data/data/com.topjohnwu.magisk/files (or whatever the repackaged Manager has for a package name).

It should be in Downloads. The other location is probably a bug...

The apk ended up in MagiskManager because it was downloaded by the old Manager that didn't have the new download location.
[Magisk] kantjer:
Correct, the zip is downloaded in "/data/data/com.topjohnwu.magisk/files"
[Magisk] mabd_m:
latest ver it works, thank you

Sent from my LG-D802
[Magisk] martyfender:
Yes, and it is renamed, with permissions 600.
[Magisk] Dark-Coder:
Getting safety net API error.. still API not updated in Magisk Manager unofficial.. ?! [emoji848]
[Magisk] Didgeridoohan:
Different error...

https://www.didgeridoohan.com/magisk/MagiskHide#hn_SafetyNet_API_error
[Magisk] kantjer:
Clear MagiskManager data, set custom channel link and test again. Clearing data will force the updated snet.apk to be downloaded
[Magisk] carlos974:
Working like charm ! :good:
[Magisk] Dark-Coder:
Thanks.. clearing data fixed the issue... [emoji16][emoji106]
[Magisk] acestars:
maybe someone should update the download link in the thread,
[Magisk] godzulu:
Got this all done on Galaxy tab and it worked fine....a little difficult to get Magisk manager to install... But I got it. Now, trying on pixel 2 xl, I have installed the new Magisk zip, restarted phone....no magisk mgr. Tried to install apk. Doesn't install. Even tried older version of mgr... No dice. Any ideas?

Pixel 2 XL
[Magisk] kantjer:
When switching from one build to another you will need to uninstall MagiskManager first.

Every builder uses a different key to sign the apk.
[Magisk] martyfender:
If you had the stable version or the official beta installed, you must first un-install the Magisk Manager, only, before you can install the unofficial version, because they are signed with different keys.

The same holds true if, for example, you have [MENTION=3306843]kantjer[/MENTION] 's build installed and want to try [MENTION=7187684]ianmacd[/MENTION] 's builds.
[Magisk] godzulu:
Worked like a charm, thanks
[Magisk] kantjer:
Why didn't you install the latest version?
[Magisk] martyfender:
If you want to receive updates of the unofficial builds, I would suggest setting the authors custom update channel in settings of MM.
[Magisk] godzulu:
Is this the custom channel?

https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json

So if the magisk I have installed "Magisk-2018082308.zip" and I input the custom channel above, I get there is an update for magisk manager to MagiskManager-v5.8.4-2018082701-ianmacd(2018082701).apk. Do I need to uninstall existing magisk manager, restart and install new one? Thanks
[Magisk] buffal0b1ll:
AFAIK if you want to switch from katnjer unofficial to ian unofficial you need to uninstall the Magisk Manager and then install the Magisk Manager for the channel you're switching to, then add the json url for that channel. Flashing the Magisk zip over the previous version should then go smoothly.

But the apk has a different signature so you need to uninstall the one you're leaving before you leave, just like you had to do when you switched from tjw version.
[Magisk] godzulu:
Got it, thanks. Went perfectly :)
[Magisk] Homeboy76:
:):good::)
[Magisk] radz_:
What a changelog..[emoji23][emoji23]
[Magisk] kantjer:
Sorry about that.

I did a rewrite of the changelog and file naming part of my build script yesterday and made a typo.

But all the latest commits are included :o

The reason for the changelog rewrite is it will now include the Selinux and BusyBox changes if there are any.
[Magisk] Ubimo:
What does this mean in changelog?

Add hexpatch to remove Samsung defex in kernel

What does this do?
[Magisk] DanGLES3:
Bypass another samsung security feature that was preventing magisk to work properly on the note 9
[Magisk] :
I can't decide me which Version of Magisk i should use: from [MENTION=3306843]kantjer[/MENTION] or [MENTION=7187684]ianmacd[/MENTION]

It's difficult :D

By the Way, i can't install this update from the Magisk Manager: MagiskManager-v5.8.4-2018082901-ianmacd.apk neither automatically over the update function nor manually downloaded from github.
[Magisk] radz_:
Uninstall existing MM... Then install thats apk

Both builds are good, im using kanjer builds
[Magisk] :
[MENTION=5140419]radz_[/MENTION]

Thanks for your answer mate, it works :)

Can you tell me your reason(s) why you're using kantjer's builds?
[Magisk] Paschfire:
Next time try using the forums search to find answers before posting, this includes skim reading over the last 10~15 pages or so. This keeps thread posting clutter down and less work for the mods.

As the fist post of page 226/post#2251, buffal0b1ll basically answered exactly what your original question asked within your previous post.(I meant to respond to it originally sorry for tagging the wrong post)
[Magisk] anttaz:
What is the new APK snet.apk for?
[Magisk] martyfender:
It is for the Safety Net check.
[Magisk] ballabdhakal:
where is download link ...cant find one ..plz help

ist time trying to install this ....help
[Magisk] vandyman:
Did you even read the first post?

Well?
[Magisk] Homeboy76:
Pixel XL with pie and Magisk 16.7 (1671)

- Uninstalled Magisk Manager 16.7 (1671)

- Tried to install kantjer's Magisk Manager apk 16.8 08/30

'Application not installed' :(
[Magisk] buffal0b1ll:
You uninstalled Magisk Manager 16.7 first right? You said removed. Is that what you meant? If you look in Settings>Apps is MM still in there?
[Magisk] Homeboy76:
Yes, I uninstalled MM for Magisk 16.7 (1671).

No MM was not in Settings > Apps and it wasn't in the app drawer. So, booted twrp flashed Magisk 16.7 uninstaller,

Flashed Magisk 16.8 08/30, rebooted. No MM. I checked the app drawer, no MM. I tried to install MM apk and got 'Application not installed' :(
[Magisk] martyfender:
was it this one: MagiskManager-v5.8.4-2018083011.apk, or the one you extracted from the Magisk-v16.8-2018083011.zip, common folder?
[Magisk] Homeboy76:
Yes, that's the one. I didn't extract Magisk-vMagisk-v1616.8-2018083011.
[Magisk] martyfender:
Did you, by chance use the hide Magisk Manager in the previous version you had installed? If not check and see if you have: /data/app/com.topjohnwu.magisk-1. If you do delete that folder and the try to install again. If you did hide the Magisk Manager before, the folder it was renamed to could still be there in /data/app/, also. However, I would have thought the Magisk uninstaller would have removed those mentioned?

Did you use [MENTION=3306843]kantjer[/MENTION] 's latest uninstaller: Magisk-uninstaller-2018083011.zip? I assume in settings, security, you are allowing apps from unknown sources?

When ever I install the Magisk Manager, I get a prompt from Google Play Protect as to if I want to allow the install that I have to approve before the install continues. I am on the latest Play services beta and Playstore. Could it be an issue with Android Pie? Finally, have you sought help in your device thread?
[Magisk] Homeboy76:
Yes, I used Magisk Hide (Hide Magisk from various detections) on Magisk 16.7.

No, I used the magisk 16.7 uninstaller to remove magisk 16.7. I thought the Magisk-uninstaller-2018083011.zip was for uninstalling Magisk-v16.8-2018083011.zip.

The allow unknown sources is not in Pie Security > Security & location.

Google play protect did prompt me, I think, I tapped install.

I have the latest play services and play store apps.

Finally, I did a search of the different Pixel XL forums for unofficial Magisk and the only thread I found with information on Unofficial Magisk was my thread Android 9.0.0 (Pie)

where I explained how to set MM update channel for Unofficial Magisk (#9).
[Magisk] martyfender:
What I was referring to was not Magisk Hide, but In Magisk Manager settings:

Hide Magisk Manager: Repackage Magisk Manager with random package name.
[Magisk] Homeboy76:
I didn't use Hide Magisk Manager.
[Magisk] martyfender:
I am at a handicap because I have never used Android O or P and I'm guessing you know about this already, but here goes, I found this only for Android Oreo:

https://www.theandroidsoul.com/where-is-install-from-unknown-sources-option-on-android-o/

My guess is Pie is similar. Maybe [MENTION=4667597]Didgeridoohan[/MENTION] or others may have some Ideas.
[Magisk] SpectraFun:
I see Magisk 16.8 on github?
[Magisk] kantjer:
without logs is hard to tell whats happening here.
[Magisk] Homeboy76:
I'll check Didgeridoohan thread and try getting logs.

---------- Post added at 02:08 PM ---------- Previous post was at 01:57 PM ----------

That is what I used to allow 'unknow sources'
[Magisk] Paschfire:
Try rebooting the device a second time, MM should show up.

Same happened on my OP3T on initial bootup after flashing Magisk, a second system reboot and MM was present within my app drawer.
[Magisk] Homeboy76:
I'll try that, thanks.
[Magisk] dingolino:
Hi,

would it be possible to show the changelog of a new version BEFORE installing the new magisk app (the notification is poping up that a new version is available and with the notification I would like to have the possibility to see the the changelog on the new version)? Or do i miss something in the existing app that it is already possible?

Best regards,

dingolino
[Magisk] kantjer:
It's been possible for some time.
[Magisk] dingolino:
Great! Many thanks!

Is your screenshot working? I cannot open it on my side

Best regards,

dingolino
[Magisk] kantjer:
No, XDA app doesn't upload it :(
[Magisk] dingolino:
ok, will check later, hope you you have time to try it again when you are back at your computer.

Best regards,

dingolino
[Magisk] kantjer:
On the MagiskManager main screen => install => release notes

The release notes will always show the changelog of the most recent upload. The changelog in the about screen shows the changelog of the installed version.

So when you have the latest build installed they will be the same until a newer build is s uploaded.

That's how I implemented it on my builds.
[Magisk] dingolino:
Got it!

Many thanks!

dingolino
[Magisk] radz_:
[MENTION=3306843]kantjer[/MENTION]

Just wanted to check, im still using your build and latest is 17.1 unofficial.

Question, this is the same as the official version right? The stable one?
[Magisk] kantjer:
yes they are 100% the same
[Magisk] martyfender:
Is there any new news on the new experimental update channel?

Thanks
[Magisk] paolocorpo:
Dear developer/users

I am running Last Magisk (see picture) on my Stock Mi A1 8.1.0

I am facing some soft reboot

Any help ?

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] guest4711:
I discovered the same problem on one device until I de-installed MagiskManager (which was hidden by a random id/package name), rebootet into recovery, flashed magisk uninstaller and flashed Magisk again... Now all is fine again.
[Magisk] paolocorpo:
Thanks

I will try this procedure

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] kantjer:
In order to better show where my builds are compared to the official builds I will change the versioning for my builds a bit.

When my build is compiled with the same commit level as the official build I will use the same version codes as the official builds only with the unofficial addition.

So my current build is (same code as official build)

17.1-unofficial/5.9.1-unofficial

When my build is ahead of the official build I will raise the minor version by “1” and add an extra experimental version number.

example: the next build will be

17.2.e1-unofficial/5.9.2.e1-unofficial

That last number will be raised for every experimental build until the next official build is released.

I hope this makes it easier to find the most recent build and know where it is in the build cycle.
[Magisk] paolocorpo:
Dear [MENTION=7187684]ianmacd[/MENTION],

I was using your release for around one week

After the last update I was facing some (2 or three) soft reboot

I cannot be sure 100% about the root cause ...

I am investigating into direction of Magisk release

So ... I have booted to TWRP, flashed the last official beta and rebooted to system

Now I would like install the official Magisk Manager too

May I install the official Apk over your beta release apk or I need uninstall previously your beta release ?

Thanks

Paolo

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] buffal0b1ll:
This question has been answered many times in this thread. If you want to switch from Magisk channel A to Magisk channel B (e.g., unofficial A to official B, official A to unofficial B, or unofficial A to unofficial B) then you always need to uninstall Magisk Manager A and then install the Magisk Manager B for the channel you're switching to (and if you're switching to Unofficial, add the json url for that channel). The Magisk Manager apk has a different signature for every channel so you always need to uninstall the one you're leaving before you leave, just like you had to do when you switched from tjw version to unofficial.

After installing the Magisk Manager B apk, flashing the Magisk B zip over the previous Magisk version A should go smoothly.
[Magisk] paolocorpo:
Dear,

I am sorry to have obliged you to repeat the procedure

It is very clear

But unfortunately as I wrote before my personal procedure has been a little bit different :(

I was running Magisk and MM unofficial

I have flashed by TWRP the Magisk official but Magisk Manager is unofficial yet

The system seems run well

So, considering the my actual status, what suggestion for me ?

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] guest4711:
As a rule of the dumb: Use the MagiskManager which belongs to your version of Magisk. (So uninstall your MagiskManager and install the official one.)

But if you are satisfied with your current setup, why do you want to change it?

*** Never touch a running system ***
[Magisk] paolocorpo:
My aim is just to align M and MM but ... probably I can wait ;)

A question:

if I uninstall unofficial MM and install official MM ... When I reboot I will find all my modules or I have to reload all of them ?

Inviato dal mio Mi A1 utilizzando Tapatalk
[Magisk] guest4711:
As long as you don't flash the uninstaller for Magisk your modules will be kept (they are part of the img Magisk mounts). Even the settings for MagiskHide and superuser are kept.
[Magisk] martyfender:
At this moment in time, both the stable v7.1, [MENTION=3306843]kantjer[/MENTION]'s and [MENTION=7187684]ianmacd[/MENTION]'s builds are at the same commit level, but with different signing keys for mm. So in theory, they should all be virtually identical. So there is really no benefit to switching.
[Magisk] jcmm11:
Now where's the fun in that? ? ? ?

(although I will agree that when you're going from A to B you should ensure you can get back to A)
[Magisk] SysWiz:
Is there a way to backup the Magisk Manager settings? For example, a quick way to restore the Magisk Hide list after having to run the uninstall? Where is the config stored? Thanks!
[Magisk] jcmm11:
It's all stored in /data/adb/magisk.db
[Magisk] martyfender:
Now that would really be a useful feature for [MENTION=4470081]topjohnwu[/MENTION] to add?
[Magisk] jenslody:
No, it's in "/sbin/.core/img/.core/hidelist".
[Magisk] jcmm11:
Oops - forgot about that one. Thanks
[Magisk] L.F.B.:
It seems snapshots stopped...

Its the cause what John Wu said about his experimental channel?

So now we dont have beta anymore right? Stable and beta will be the same?

You guys will still maintain your snapshots channel?
[Magisk] SysWiz:
Bingo. That will help a lot when/if I need to uninstall while changing things around in the future. Thanks!
[Magisk] ianmacd:
They haven't stopped. There simply hasn't been any public development since 17.1, so there's nothing new to build.
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] has a new MacBook Pro on order and is waiting on it before he continues development.
[Magisk] landwinwand:
I get update channel fail,when try update

Is github down?

Tryed set stable,beta,custom

Same result

I need to download modules from Google

Please someone give me a working URL to add

In custom update link.

Thankz

Bye
[Magisk] martyfender:
https://raw.githubusercontent.com/kantjer/MagiskFiles/master/updates/kantjer.json

https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json
[Magisk] martyfender:
I just updated 3 out of 4 devices to the [MENTION=3306843]kantjer[/MENTION] 2018090608 build and on one device, all flashed through TWRP, it booted to the Android startup wizard.

I clicked on setup wifi and it was still setup. I hit complete and it booted to the normal Android desktop, after I entered my pin. That is a strange issue, indeed. The other 2 devices booted normally. I will wait to flash it to my last, primary device, since new commits were released since then. I am waiting for a release on the 1 device with [MENTION=7187684]ianmacd[/MENTION] 's build.
[Magisk] ianmacd:
I hadn't noticed that John was coding again. Thanks for the tip.

I've just released a new build. It boots fine on my devices, but you and I have totally different hardware.
[Magisk] kantjer:
I did a direct install on both today's e1 and e2 build, no issues here.

I hardly ever flash Magisk through TWRP now direct install is working perfectly for me.