yashsingh1/xdaforums huggingface dataset:
[Magisk] dahawthorne:
[MENTION=4667597]Didgeridoohan[/MENTION]

Yes, understood - no problem. I take what I'm given and I wouldn't dream of denigrating the work of devs who keep my old machines alive and constantly come up with new methods to make them better. I was just adding my experience in case it gave stangri any pointers to improve the process.
[Magisk] Didgeridoohan:
I don't think there's much [MENTION=2226076]stangri[/MENTION] can do... He's just building whatever [MENTION=4470081]topjohnwu[/MENTION] have put on GitHub. None of the builds since 15 April have been useable.
[Magisk] dreinulldrei:
Maybe there's a reason topjohnwu does not make them official. ;)

My bet is that this is very simple: If it works - enjoy. If it does not ... well use an older build.
[Magisk] Ubimo:
As stated above, Magisk-v13-170424.zip does not work on my end too.

Maybe the log attached will help to solve the problem.
[Magisk] Didgeridoohan:
Not really... There probably is no problem. The snapshot is built from code that's not release ready, simple as that.

But thanks for showing the new log format. I like it! :)
[Magisk] saturday_night:
It would maybe be a good idea to delete the files that are not working so that not everybody comes to the same error and isnt able to use magisk anymore until they come here read about it and download the older version. Would also prevent those several posts "doesnt work"
[Magisk] dahawthorne:
I agree. Although I appreciate the work that's going into continued development, it seems strange to offer files that are causing multiple people to report "not working". It seems to be against stangri's own interests to provide releases and even prompt via Magisk Manager to upgrade to newer builds when even [MENTION=4667597]Didgeridoohan[/MENTION] says "None of the builds since 15 April have been useable."
[Magisk] DodoGTA:
My Magisk v13.0 snapshot report

Everything is working except the Magisk Manager says that Magisk isn't installed so I can't use any modules (but the high CPU usage problem from v12 is finally fixed):

[IMG="Magisk v13.0 SafetyNet test"]http://i.imgur.com/mH6cXUM.png[/IMG]

2017 April 26th update​

I know why "Magisk isn't installed" message is showing up:

https://github.com/topjohnwu/Magisk...14fbe620f46f43f6e5721a#commitcomment-21909438​
[Magisk] Didgeridoohan:
https://xdaforums.com/showpost.php?p=71891026&postcount=419

The builds are automatic.
[Magisk] dahawthorne:
Ah... thank you. I have a vague memory of reading that, but I'm getting old, you know? :)
[Magisk] Didgeridoohan:
Aren't we all? I'm surprised I even remember to put on pants in the morning anymore. And I only occasionally put them on my head...

I had forgotten about it as well, but did some backtracking in light of today's discussions.
[Magisk] Ardany Jolón:
The lastest version of magisk not work too. I tried installing from the app and TWRP and not works (version of the day 24 and 25 april). Out jumps the message "Magisk no installed'.
[Magisk] DodoGTA:
It works but only MagiskSU, Magisk Hide and resetprop is working
[Magisk] hanschke:
installed, reboot and got the message that it is not installed :rolleyes:
[Magisk] DodoGTA:
If MagiskSU shows up, then you have a common problem
[Magisk] dahawthorne:
As detailed over the last two pages, the recent builds after 15th don't work. Just reinstall 170415 and you should be back up and running.
[Magisk] Deic:
The not installed problem with build after of 15th is that [MENTION=2226076]stangri[/MENTION] bug the version of Magisk... If you run from terminal

setprop magisk.version 170425

or create a file called "magisk_version.sh" for example in "/magisk/.core/post-fs-data.d" with this

VERSION=170425
[ "`getprop magisk.version`" -lt $VERSION ] && setprop magisk.version $VERSION || return 0

is fixed

the no modules problem is related a some change that [MENTION=4470081]topjohnwu[/MENTION] did.
[Magisk] the_brad:
works.

f***ing brilliant :good:

**

Update: Magic-Mount does not seem to work. I have two files, that got mounted into \system\etc fine with 11.6 but aren't mounted with 170425.
[Magisk] DodoGTA:
Magisk core functionality (like modules, magic-mount, systemless busybox and systemless hosts) isn't fully working (according to [MENTION=4470081]topjohnwu[/MENTION]), so don't complain about those features and wait until [MENTION=4470081]topjohnwu[/MENTION] fixes them
[Magisk] the_brad:
That wasn't meant to be a complaint! Just an info for the others, that are tempted to install that version.

Btw, where did you read that note from topjohnwu? I follow mostly everything, but did not get that one... :confused:
[Magisk] DodoGTA:
https://github.com/topjohnwu/Magisk...14fbe620f46f43f6e5721a#commitcomment-21909438
[Magisk] DodoGTA:
Please don't do this: https://github.com/topjohnwu/Magisk/blob/master/jni/daemon/post_fs_data.c#L67
[Magisk] Deic:
you replied the wrong post xd

why?
[Magisk] stangri:
[MENTION=4476591]Deic[/MENTION]'s magisk file manipulation before build was reverted, if you guys try 170427 build, do post if it works without setprop or not.
[Magisk] Deic:
I reverted that because is not needed already, the problem was your changes in build line and the problem is too.

EDIT: [MENTION=2226076]stangri[/MENTION] ok, the problem is that it has to be as

build.sh all <version name> <version code>

so

build.sh all ${suffix} <somenumber>

or may (?)

build.sh all ${MAGISKVER}.${suffix} <somenumber>
[Magisk] stangri:
Yeah, that was fixed on 24th, until you've reverted it with this commit: https://github.com/stangri/MagiskFiles/commit/692cb793536b038f9e41ddb9777eb03ba69d80e8
[Magisk] Deic:
you have it as

build.sh all ${MAGISKVER} ${suffix}
[Magisk] 13680201:
HI

App magsik manager v427 installed success.

But magsik v427.zip error in whin install in magsik manager

In recovery twrp installed magsik v427.zip after boot , open magsik manager. Oh oh show massage magsik.zip not install,

Please help for install magsik v427.zip

Thanks

فرستاده شده از SM-T805ِ من با Tapatalk
[Magisk] jb0ne:
Magisk 04025 acts like it installs in TWRP but on system start magisk not installed. Based on above comment it's still a problem in 0427. Is there a fix for this? Staying on 0415 for now.
[Magisk] wrongway213:
Humble request:

Guys, its really useless to report errors and issues here, as no one involved in this thread is actively involved in developing Magisk. I have yet to see topjohnwu visit this thread. So, even if you had logs, they would not be useful for this or really any thread, as obviously topjohnwu is aware he has disabled things in Magisk source. As you can see the evidence from [MENTION=6429309]DodoGTA[/MENTION] on github as to why things are not working, it seems to me it would be more beneficial for everyone to:

a) Pay attention to github as DodoGTA is doing, and understand what they are flashing if there is no confirmation a build is working, as there has been confirmation builds as of now do not work.

b) Wait until there is actually a development that either: enables progression of this thread or snapshot builds, provides insight into why the changes by topjohnwu have been made that are currently causing snapshot builds to be unusable, or actually confirms a snapshot build to be working.

I can't speak for everyone, but I know this thread would be a lot more useful to me if I wasn't constantly checking it just to see yet another person report something confirmed not to work isn't working. Please, if you are going to post about this before it is actually again usable, at least make it useful information and not just "me too" posts. I cannot see this thread going in a positive direction if this continues, and I would hate to see such a nifty idea and thread deteriorate over people not reading and understanding what they are flashing, or people posting just to post.

No disrespected intended to anyone and not singling anyone out - just a humble request from a user starting to see a familiar and generally unlpeasant pattern. Please, guys - don't let impatience or not reading turn this thread into something unpleasant.
[Magisk] Deic:
Workaround https://xdaforums.com/showpost.php?p=72050553&postcount=473
[Magisk] stangri:
Is there a length limit on the <version code>?
[Magisk] Deic:
I guess is the reason because version fail to be set... try the 2 variants I said you in the other post to see if work https://xdaforums.com/showpost.php?p=72062226&postcount=482

All in this life is trail & error my friend.
[Magisk] DodoGTA:
That link I provided says the reason
[Magisk] Deic:
Obviously I checked the link, but I don't know that you means with that... Explain please. What does problem there is with run a script from that folder?
[Magisk] DodoGTA:
// TODO: Magic Mounts, modules etc.

This is a code comment of [MENTION=4470081]topjohnwu[/MENTION]

If you don't know what TODO means, then click this link: http://wordaligned.org/docs/todo/todo/what_does_todo_mean_.html
[Magisk] Deic:
I saw it, but what is wrong with add a script in post-fs-data.d?

I know that todo means ._.
[Magisk] DodoGTA:
Because it tries to enable broken and/or incomplete functionality
[Magisk] jsaxon2:
As far as I know, you can add the script and magisk hide and su will work, but your modules will not load. Hence the TODO comment on GitHub. So basically, you will be using a crippled version untill topjohn finishes his work. The problem with and asking not to do it is so we are not seeing a bunch of people say my modules are not working when we know they will not work. Also, if you do add it, it may interfere and cause problems later down the road if you do not remove it once we have a working version.
[Magisk] Deic:
So the magisk.version prop value problem is intended? Are you sure that you said? o_9 I thought was due a bad args when build with "build.sh all <version name> <version code>" because was changed, before was "build.sh all <version name>" only.

The script can't interfere, it has got a "if" to avoid prop set if magisk.version prop value is greater than the one defined in "$VERSION" var.
[Magisk] DodoGTA:
Yes and yes
[Magisk] bountyman334:
Thanks for this works on lg v20.. No complaints...?
[Magisk] stangri:
I've changed things a bit yesterday, now when building magisk I use only <mdd> (3 digits) as a version code, however the filenames and the version info for the update checker still includes full <yymmdd>. Hopefully this works and I'll find a better solution comes October.
[Magisk] Deic:
Doesn't work. [MENTION=6429309]DodoGTA[/MENTION] said that the version bug is intended (he talked with topjohnwu I guess), so is indifferent 6 digits, 3 or over 9000.
[Magisk] lagendbun:
Finally i found this thread.
[Magisk] Sam Nakamura:
Good to know, I was worried already.. :)
[Magisk] lars85destroyer:
Hey guys,

If I flash the latest working "v13", do I need to use unofficial magisk manager too ?
[Magisk] DodoGTA:
No (I use it with the latest Magisk Manager app from Play Store)
[Magisk] 13680201:
HI

In magsik manager

, error install for update magsikv429.zip and install

Please help for install magsik.zip v429

فرستاده شده از SM-T805ِ من با Tapatalk
[Magisk] culiacanazo:
Anybody, i need a facepalm, my two hands just won't do!

-------

Mr, if you have any kids, please hire someone to instill the habit of reading. :good:

(Hint: go back to v15 for the time being)
[Magisk] Deic:
install from twrp, because sepolicy-inject can't be found when install from Magisk Manager (and some busybox applets if you haven't got busybox installed, so symlinked all the applets, the busybox of magisk doesn't work atm)
[Magisk] sponky514:
Hi i just installed a room called dedraks essentia, this rom comes with magisk installed so i get an update for the magisk so when i tried to installed the app crash, so what i did was, restart my phone and use recovery to install the update, but i have like 4 days trying to install it and nothing happen also when i opened the magisk app appear a message "magisk not installed" im using a moto z play phone. any idea?
[Magisk] 13680201:
I install magsikv429.zip from twrp,

After boot. Open magsik manager. Oh oh show massage ,,magsik.zip not install ,,,

فرستاده شده از SM-T805ِ من با Tapatalk
[Magisk] culiacanazo:
For the second time, install from twrp all you want but go back to v15 for right now

Señor, "unsu" (that's a verb), and reflash magisk, sticking a clean boot right in between both actions, let us know how it goes :)
[Magisk] Deic:
Return to 170415, aren't ready to use the new snapshots too.
[Magisk] BolintsMiki:
Hi [MENTION=4476591]Deic[/MENTION] & [MENTION=2226076]stangri[/MENTION]

On GitHub, today's commits say that Magic Mount is fixed. Can this mean that Magisk will work again? I'm eagerly waiting for the next build! ?
[Magisk] kantjer:
The build with that commit included is already available (Magisk-v13-170430.zip)
[Magisk] BolintsMiki:
Are you running it? If so, is Magisk functional now?
[Magisk] dahawthorne:
I believe that a new Magisk version installs directly over the top of the existing one?

I've just installed 170430 in TWRP 3.1 and first got a red "Magisk not installed, 170430 available" but also a green "Root ok" box. I didn't try Safetynet. I chose the top box to install 170430 via Magisk Manager, and this time I had nothing working - no Magisk, no root. I've restored my TWRP image back to 170415 (always, always back up...) and everything is working again.

No logcat, this is purely info for those thinking of trying the 170430 version.

Also no complaints - when I'm using cutting edge tech I expect to bleed a little... :)

Nexus 6, Pure Nexus April NHG47K.
[Magisk] kantjer:
I tried the 04/30 build in combination with a dirty ROM flash but it didn't work (no root)
[Magisk] BolintsMiki:
Well, let's play the waiting game then. :angel:
[Magisk] death_jax:
Magisk (in my case 170430) cannot see and start magisk.version.sh (or any other name) file; command prompt code worked instead.

The only way (workaround) I found to make it work is to edit DevBase post-fs-data.d script (Magisk starts correctly this one) and insert your command there; in this mode it worked, and my modules too :)
[Magisk] 13680201:
Magsik v501.zip from magsik manager install successful, and show massage successful install.

After reboot, oh oh show massage not install magsik.zip, !!

Please help for install, magsik.zip

فرستاده شده از SM-T805ِ من با Tapatalk
[Magisk] jsaxon2:
Try reading the last couple of pages. It says what to do and why the snapshots currently do not completely work.
[Magisk] DodoGTA:
Magisk core functionality is in progress, so that's why Magisk Manager is saying "Magisk not installed"
[Magisk] BolintsMiki:
Why even bother replying? He clearly didn't read the previous posts where numerous people tried explaining it to him. He will probably continue with his ignorance.

And if I offended anyone, I'm sorry. I don't want to sound like a jerk, but this guy's ignorance got on my nerves as I was reading through his previous posts.
[Magisk] Sytis:
Oh Oh, shots fired. No but seriously, this is a snapshot thread with experimental builds. Maybe we need a disclaimer at the beginning saying "If you don't have basic knowledge about Android, GitHub and/or flashing experimental stuff just leave this thread and keep yourself from problems" :confused:
[Magisk] Hooxp17:
My problem's that the magisk manager shows no magisk.img installed with root properly running.

flashed with magisk v12 it could lose root, while with v13(newly) it could have no img.

{

--------- beginning of main

05-03 12:12:30.892 I/Magisk ( 240): Magisk v13 daemon started

05-03 12:12:30.894 I/Magisk ( 240): ** post-fs mode running

--------- beginning of system

05-03 12:12:31.159 I/Magisk ( 240): ** post-fs-data mode running

05-03 20:12:31.159 I/Magisk ( 240): * Mounting magisk.img

05-03 20:12:31.160 E/Magisk ( 240): mount /dev/block/loop0->/magisk failed with 22: Invalid argument

05-03 20:13:31.433 I/Magisk ( 240): ** late_start service mode running

05-03 20:13:31.433 I/Magisk ( 240): * Running service.d scripts

05-03 20:13:31.433 I/Magisk ( 240): * Running module service scripts

--------- beginning of crash

}

---------- Post added at 01:38 PM ---------- Previous post was at 12:39 PM ----------

is "/magisk/.core/post-fs-data.d" needed to create manually?

---------- Post added at 01:39 PM ---------- Previous post was at 01:38 PM ----------

is "/magisk/.core/post-fs-data.d" needed to create manually?
[Magisk] teddy0209:
Just stick with the 0415build, development for the next release is still ongoing, if it's ready for testing, the snapshots build probably will work as normal again...
[Magisk] Hooxp17:
i tried it before. It lost root wit 0415...
[Magisk] teddy0209:
Yeah, it's not really sticking for all setup/devices... It disappears on my Mi5 as soon as I enable magiskhide, but not for all apps... It's a different case on my M9, don't have any issues with it...
[Magisk] lagoskon:
I think more stable is v270317

Στάλθηκε από το SM-G930F μου χρησιμοποιώντας Tapatalk
[Magisk] bountyman334:
For some..but 170415 is the sweet spot.the newer ones work with the script but loses root after reboot
[Magisk] SCrid2000:
Set Tasker up to run the setprop command on boot and everything seems to be working on the latest build.
[Magisk] edgarf28:
I can confirm this, that the latest nightly (20170503) is fully working, including modules, after applying the setprop fix.
[Magisk] Hooxp17:
Do I need to run the code in tasker or just in the terminal？
[Magisk] teddy0209:
Just in terminal is ok...

I don't know but 0503 is still not fully functional on my device..., You can still try...
[Magisk] rignfool:
This thread... Makes me laugh...

Plz fix it... It no work... No I didn't read that it hasn't worked in 2 weeks...

Logs? Are we starting a fire?

But my device is speacil...
[Magisk] Tesla:
What the....? :confused:
[Magisk] culiacanazo:
Damn drugs, I'm telling ya!
[Magisk] kantjer:
170504 build is working for me (before that last working build was 170415)

The setprop command is still needed

---------- Post added at 11:18 ---------- Previous post was at 10:33 ----------

If you keep the zip on the sd you can use Tasker to pull the version number from the zip.

I have set Tasker to do just that when booting
[Magisk] opz187:
would you be able to maybe share that Tasker profile or how you did that? I've never really messed w Tasker, looked too complicated, and I've never had that attention span to figure it all out..
[Magisk] kantjer:
See attachment, you only need to change the path in line 1 to match the location you store the Magisk zip

You can have multiple Magisk zip's on the SD, Tasker will use the version number from the most recent one.
[Magisk] bountyman334:
It seems that if i install the latest update via the app it works...i have the script placed in magisk/.core/post-fs-data.d but i updated it to 05/04..
[Magisk] culiacanazo:
*170415

(Lest you send ppl for whom latest one doesn't work looking for March's)
[Magisk] Hyflex:
Any idea what is wrong with this?
[Magisk] Didgeridoohan:
I don't think you're pointing the Tasker profile to a folder with beta snapshots and that's why it's failing. It's expecting file names like this: "Magisk-v13-170505.zip", rather than the official "Magisk-v12.0.zip".
[Magisk] HamsterHam:
Does anyone get bootloop with any build.prop modules with the latest beta?
[Magisk] teddy0209:
Didn't have issue like that on 0504 build... Though I'm back on 0415 version now as magiskhide is not working...
[Magisk] Hyflex:
This is the folder and the file names the app is downloading.
[Magisk] kantjer:
Then the app you use to download renames the zip. You will need to change the Tasker profile accordingly
[Magisk] Hyflex:
I'm using MagiskManager... I have no idea how to change accordingly
[Magisk] Didgeridoohan:
In that case the easiest way to fix your issue would be to rename the files to match what I posted earlier (add v13).
[Magisk] hanschke:
back to 0415 here too :)
[Magisk] HamsterHam:
Wasn't the build prop module that was the issue. :good:
[Magisk] grodri19721:
Anyway to get my Nvidia shield working I already flashed but I'm getting this message magisk rooted but no permission
[Magisk] Artim_96:
Does the official version work? If so, just go back to version 0415 since every newer version is not really working
[Magisk] grodri19721:
What version is 415 I thought they went by v6 through v12
[Magisk] teddy0209:
Unofficial Snapshots V13 0415 is the date of the build...
[Magisk] grodri19721:
Ah ok thanks for the help
[Magisk] pandavova:
Why is this "error" don't getting fixed? And wich is the lastet version where i dont need a Tasker-Boot Script? Cause my S5 Neo is already VERY slow, i dont want to make it even slower ._.
[Magisk] DodoGTA:
I built Magisk v13.0 snapshot which has that problem solved (Downloads are attached to this post)

Note: Magisk Manager needs to be updated as well to fix things like adding more apps to Magisk Hide list or removing them, enabling systemless hosts etc.
[Magisk] pandavova:
Which Magisk Manager Version? PlayStore?

Ok PlayStore, but now its again "CTS PROFILE MISMATCH" (I hate the S5 Neo...)
[Magisk] DodoGTA:
All versions of Magisk Manager don't play very well with Magisk v13.0 snapshots (Wait until [MENTION=4470081]topjohnwu[/MENTION] releases official Magisk v13.0 or deal with the issues I mentioned above)
[Magisk] pandavova:
Ok... So its "normal" that im getting a mismatch? And how long do we need to wait? ._.
[Magisk] Didgeridoohan:
Yeah... No. Don't ask for ETAs, please. It'll be done when it's done...
[Magisk] pandavova:
Sorry ._.
[Magisk] Didgeridoohan:
No worries... The developers on XDA do all their wondeful work in their spare time and share it with us lucky plebs out of the goodness of their hearts. :p The last thing they need is feeling pressured and stressed about releasing.

While waiting for a new release, you can entertain yourself by following the coding going on over at GitHub. There are links to the repositories in the OP of this thread... I pop in there once in a while to see how things are progressing and what kind of goodies we might expect for later. There was a commit to the Manager just a few minutes ago. Grab some popcorn and join the fun! :highfive: (Seriously... I actually enjoy it :D)
[Magisk] pandavova:
I will :D

For now i installed the lastet v12 again... My S5 Neo is already very slow, so Xposed, Addons, etc. are only dreams...
[Magisk] DodoGTA:
What ROM are you running on that device?
[Magisk] pandavova:
Stock Rom + Nova Launcher and Magisk... I already had so many problems with this phone... (Not loading, boot errors) Warranty...
[Magisk] culiacanazo:
Dude, it's unbeknownst to me if NEO is better or worse than regular S5, but mine is snappier than when it was knew, I'm Googleless and keep tabs in what tabs need to be kept so they aren't consuming my RAM (along with battery, not to mention data and good-ol space). And not only that, at the moment i have three ROMs in my device booting up. If any questions arise as to my setup, pm me so we don't derail more
[Magisk] nathanchance:
I just built the zip and the manager and everything appears to be working great! I would recommend restoring your stock boot image and clearing the manager data but everything seems good.

I used zip version 13 and version code 130.
[Magisk] Mezabaru:
Wait working without setprop or tasker?!?!?!?
[Magisk] nathanchance:
Yes, thanks to this commit: https://github.com/topjohnwu/MagiskManager/commit/962f8354acaf5a2520dd1ba91a0a2037d1d3cc98
[Magisk] Mezabaru:
Can you post your build?
[Magisk] nathanchance:
Just fair warning, my APK is completely incompatible with what [MENTION=2226076]stangri[/MENTION] has available since I sign with my own private keys and I won't provide any updates past this one. So you'll need to uninstall your current APK, install mine, then uninstall mine and reinstall his when it's available.
[Magisk] android_htc:
Thanks for your build..

Unfortunately, I get an error on my Samsung device and Safetynet fails, see screenshot.
[Magisk] DodoGTA:
Magisk Hide didn't start up (Try rebooting your phone or enabling Magisk Hide)
[Magisk] android_htc:
Still no good due to the error shown in the log..magisk folder is empty.

Also same issue with your v13 Magisk build...Magisk is probably not playing nice with Samsung devices again