yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
Hal 3 have been already enabled again on lineageOs again? Witch app do you use to the 13/17 camera?
[OnePlus 3 & 3T Cross Device Development] matssa:
Woot, nice! If you manage to build it, would you share your process? I'll like to use it as well in the futur builds ;)

I reverted all the camera commits until it get's sorted it, so it is like before (HAL 3 disabled).
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok guys I managed to copy the VMWare machine on work PC, so it's running while I work :) Stuff has been merged, I'm making a second build with the sdcardfs stuff directly merged in.

Please be aware that there may be camera issues with Snap (touch to focus may not work). Please use another app or the OOS Camera Port.

Of course, if you find bugs, please report them! :)
[OnePlus 3 & 3T Cross Device Development] dante_nfs:
THANKS for your awesome work mate, just wondering the bug with changing the data sim card in setting makes setting crash is resolved or not, it was introduced in 15/1 build of official lineage os.
[OnePlus 3 & 3T Cross Device Development] matssa:
Um I dunno, I don't have a dual SIM :/ Might be there in the changelog though ;) If not, then should not be fixed :/
[OnePlus 3 & 3T Cross Device Development] :
OK, thx for this remark, that format isn't required.

But what "new twrp" version you are talking about? The official new 3.0.3.0 or the unofficial new 3.0.3.0_N from dianlujitao?

Thx again for clarification
[OnePlus 3 & 3T Cross Device Development] matssa:
New TWRP are those that are on the first post. Some people reported that arter97 TWRP or eng.stk TWRp worked better than dianlujitao TWRP.

Btw, latest build online for those who didn't see ^^
[OnePlus 3 & 3T Cross Device Development] :
Thx.

Btw the link on the first post for the eng.stk.twrp doesn't work (error 404).
[OnePlus 3 & 3T Cross Device Development] LKspro:
Last time I flashed this rom with older version, the oos cam port has some bugs with the video recording, the viewfinder is rotated 90 degree during recording, showing distorted image, does anyone know if it has been fixed automatically in newer builds? Since on siankatabg's very old version of cm14 it works flawlessly. Thanks in advance.
[OnePlus 3 & 3T Cross Device Development] matssa:
OK thanks, I'll try to change it.

Dunno if it has been fixed, maybe it was changed. Did you use a newer version of the camera port?
[OnePlus 3 & 3T Cross Device Development] matssa:
Did you manage to build it? I started checking it out, and I can't seem to find the first commits from each repos. What process did you follow? Feel free to contact me via PM, we can help each other ;)
[OnePlus 3 & 3T Cross Device Development] LKspro:
edit: no bugs now for recording. quality is stock like now.
[OnePlus 3 & 3T Cross Device Development] nandeshm:
Headphone

Headphones seem to have stopped working in the latest build. For music and calls.
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok guys new build is underway. I reverted the camera stuff and went back to the closed commits from LineageOS. This means that we can have issues with touch to focus, recording, or other stuff. The reasons is because we are using a new HAL3, which is supposed to be more recent than the old one (HAL1) which was using MM blobs.

Furthermore, I permanently added the sdcardfs commits since I don't have any issues and I didn't see any bug reports. Last but not least, I added the usb fix commits to see if it works or not. To test it, please plug in the phone to your PC, turn on MTP, remove from PC, wait a bit, check if it went to deepsleep with betterbatterystats.

If everything is good, I'll add more new kernel commits tomorrow.

For OMS, I will also start working on it. A lot more people are turning towards it so it will be easier to port it :)
[OnePlus 3 & 3T Cross Device Development] matssa:
New build up guys, changelog on first post. Furthermore, I see that dianlujitao sent a pull request for new camera blobs, I'll make a new build when it get's merged, but I may not be able to share it today.
[OnePlus 3 & 3T Cross Device Development] gruntyoldbag:
I tried dianlujitao's build for a few days until camera stopped working on 2017/1/16 (focus) - now focus does not work on this build either with todays update.

I have reverted back to yesterdays build - I will sit down and stop updating until autofocus is fixed :)
[OnePlus 3 & 3T Cross Device Development] matssa:
I'm making a new build with some updated camera blobs and using HAL3 instead of HAL1. Maybe it will fix it, but the build is taking forever... only at 28% and launched it before going to lunch... If it still isn't done before leaving, I'll let it run and run it a second time on my home PC, takes about 2hours.
[OnePlus 3 & 3T Cross Device Development] NoobMonkey:
Kind of dummy question, but what's the fuzz about f2fs? Any reason why I should change to it? If I'm right it's a file system and replace for ext4 but why? What's the benefit of f2fs?
[OnePlus 3 & 3T Cross Device Development] siankatabg:
The new blobs (I don't know from which rom they are taken) doesn't fixed the video recording for me. I'm not using snap cam, so I can't tell about touch to focus :)
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok thanks for the info, I'll test it when I can ;)
[OnePlus 3 & 3T Cross Device Development] kipue:
f2fs kinda help with app launching speed, but unless I'm wrong for now, it is more trouble than it is worth. (I think you can see some youtube videos of OP3T using f2fs VS OP3 using ext4, and the apps indeed start faster. But in my opinion, really, so what).

When I see all those Tales of Horrors by f2fs users (especially in regard of the recovery), I'm happy to stay put until it's really a necessity :)
[OnePlus 3 & 3T Cross Device Development] dante_nfs:
Not just that, better nand life, better garbage collection and trim support and so on. It's way better in every aspect but people don't know it. [MENTION=3873953]eng.stk[/MENTION] have a really good and informing informations in his thread, he supports f2fs and i believe the knowledge of this guy.
[OnePlus 3 & 3T Cross Device Development] kipue:
Alright, did not know that :)

I'll still stay on ext4 until it's not so touch and go.

Some roms work with it, some other won't, some recovery version will, but with that kernel it won't...

I mean it's too much issues (for now, I understand that) to be really woRth it. My nand will live a few more weeks still :D
[OnePlus 3 & 3T Cross Device Development] smouker:
New Build works great so far :)

But I cant get Viper4Android working... Someone managed to get it running?

Cheers

Edit:

Got it working now. Problem was SeLinux lol ^^
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
[MENTION=6313536]matssa[/MENTION]

I was able to build your ROM using your source with the sdcardf2fs fix. Took about 7 hours! Haha.

#### make completed successfully (07:47:59 (hh:mm:ss)) ####

I believe the reason why it took this long is because of me diabling ninja compiler (I hope that's what it's called).

Now that I'm certain I'm able to build the ROM from your sources with no problem, the root of the issue must be caused by the OMS repos. I'm going to make another attempt at building with OMS repos and commits and see if my build is successful. :good:

I will be uploading my build to my AFH directory, there are no changes and uses the same roomservice that was provided in the OP.

Here's my first build, thanks [MENTION=6313536]matssa[/MENTION] for providing the roomservice and build process!

lineage-14.1-20170119-MisterCoolBeans-UNOFFICIAL-oneplus3.zip

md5sum
[OnePlus 3 & 3T Cross Device Development] shade.sh:
wtf? Did you build it on a Raspberry PI? :D
[OnePlus 3 & 3T Cross Device Development] siankatabg:
Lol, nice one :D

Just for info, sdcardfs is merged to the kernel and some selinux denials about it too, so no need of cherry picking anymore :)
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
Eh of the equivalence haha, I have a junk laptop with 8GB of RAM and an old Intel i5 from the sandy bridge processor era lol. :good:

I uninstalled Windows from the laptop (It's a lenovo) and I installed Ubuntu Server 16.04 LTS on it. I access it anywhere with SSH
[OnePlus 3 & 3T Cross Device Development] matssa:
Wow, that took a lot of time! It's faster after when you don't do the make clobber. The make clobber is recommended when proprietary files are updated, like today.

I change a lot my repos, so the changelog can be different ;)

For OMS, try activating again ninja and make a second build without OMS. The time should diminish. After, we can test out several methods for example merging the repos, cherry-picked, or other. But disabling ninja isn't required IMO.
[OnePlus 3 & 3T Cross Device Development] matssa:
New build is uploading guys, changelog has been updated. I will need testing for USB commits.
[OnePlus 3 & 3T Cross Device Development] :
In addition to your statement ...

I've never had any trouble with f2fs and I'm using f2fs with my OnePlus One and 3 directly from day one, when they released in Sommer 2014/2016. And I'm flashing cm/Laos nightlies more or less every day for the last couple of days.

F2fs get my personal recommendation.
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
I have reverted to ext4 due to the boot up time on twrp... Can I clean flash this update on simple ext4 file system?

Awesome work from everybody and Cheers for a gigantic changelog :D
[OnePlus 3 & 3T Cross Device Development] matssa:
Boot up time on TWRP? I don't understand ^^ and yeah you can clean flash ;)
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
Yes I will try to explain :P

My twrp was taking almost 2 minutes loading (with arter97) twrp... Unless there is some diference with 3.0.0.3 from dianlujitao that i have already installed has some diference,i've read that twrp take more time to read and check diskspace with f2fs, is that true?
[OnePlus 3 & 3T Cross Device Development] matssa:
Strange, mine doesn't take that long, I'm using dianlujitao TWRP and it works fine. Why don't you try his recovery? For the check disk space, I don't see much differences...
[OnePlus 3 & 3T Cross Device Development] :
[MENTION=3404009]PuCiNhOOO[/MENTION]

Approx. 25-30 sec for me with dianlujitao TWRP and f2fs. 34GB used at data partition.
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
That might be it :D already installed dianlujitao twrp, will clean flash again to f2fs system :D on antutu I have had > 157000 and now only 149000 :P thanks

And [MENTION=6313536]matssa[/MENTION] to you too
[OnePlus 3 & 3T Cross Device Development] EatBeans:
[MENTION=6313536]matssa[/MENTION] I'm willing to switch to this rom when you have added oms support but I want that everything is in my language. If I would translate the last missing strings could you maybe include them?
[OnePlus 3 & 3T Cross Device Development] matssa:
It is coming soon TM :)

For the strings, I dunno if those that are missing are translatable strings or not :/ feel free to give them and I'll try to check if it is a translatable string or not .
[OnePlus 3 & 3T Cross Device Development] EatBeans:
Okay thanks. I have one question. Does this weather widget on Lockscreen work on lineageos? Because I need it and I believe this feature is included but I'm Not sure ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Nope I don't think so, on which ROM are you? I would like to have it as well :)
[OnePlus 3 & 3T Cross Device Development] EatBeans:
I'm on the resurrection remix ;)
[OnePlus 3 & 3T Cross Device Development] xantic21:
I love this rom and I use it as a daily driver. But I have two issues right now, I'm on ext4:

- can someone confirm that in-build root is not working? It was working before (till build 170112?)

- Titanium backup is crashing when I backup apps, and TB recognizes only system apps.
[OnePlus 3 & 3T Cross Device Development] Hedrush:
Over the past 3 nightlies I've had to flash SuperSu via twrp as it has been losing root with each new build I've flashed. No big deal though, but yeah to answer your question in built root isn't working.

Really like this ROM, I've been following it's progress and using it since the beginning of January flashing each new build. I've never done a clean flash either, I originally dirty flashed it over CM14.1 and it's never given me any issues, It's very stable and a great daily driver.

Thanks so much for this.
[OnePlus 3 & 3T Cross Device Development] :
Inbuild root isn't working anymore, it's disabled by default. But you can easily use SuperSU or phh-superuser.

TB behavior sounds strange, there is something really broken in your setup. Have you tried a reinstallation of TB? Mine TB is working fine for years now, and on all my devices with latest LAOS nightlies until today.
[OnePlus 3 & 3T Cross Device Development] matssa:
OK thanks, I might look into porting that feature :) but if LAOS changed to much, it may be suite complicated...
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
Attempted to build with OMS commits and used git remote to add the repos but to no avail, same errors as before:

fatal error: too many errors emitted, stopping now [-ferror-limit=] │
target C++: libbatteryservice <= frameworks/native/services/batteryservice/IBatteryPropertiesRegistrar.cpp │
20 errors generated. │
build/core/binary.mk:986: recipe for target '/home/sambegui/WORKSPACE/LineageOS-matssa/out/target/product/oneplus3/obj/│
STATIC_LIBRARIES/libbatterymonitor_intermediates/BatteryMonitor.o' failed │
make: *** [/home/sambegui/WORKSPACE/LineageOS-matssa/out/target/product/oneplus3/obj/STATIC_LIBRARIES/libbatterymonitor│
_intermediates/BatteryMonitor.o] Error 1 │
make: *** Waiting for unfinished jobs.... │
make: Leaving directory '/home/sambegui/WORKSPACE/LineageOS-matssa' │
│
#### make failed to build some targets (27:59 (mm:ss)) ####

Perhaps you may be more successful than I am, I may need to look into how other ROM builders manage to do it. :/
[OnePlus 3 & 3T Cross Device Development] matssa:
Mmm, I'll try on my side and see how it goes.
[OnePlus 3 & 3T Cross Device Development] vinax89:
OP released sources. Seems like a lot of fixes and dev can now begin. https://github.com/OnePlusOSS
[OnePlus 3 & 3T Cross Device Development] EatBeans:
[MENTION=5091734]dianlujitao[/MENTION] Is already working in lineageos gerrit :good:
[OnePlus 3 & 3T Cross Device Development] xantic21:
Thank's a lot for your answer. I already flashed superSU. I just wanted to know if in-build root is broken by default or just a strange thing on my side. I re-installed TB and now it's working fine.
[OnePlus 3 & 3T Cross Device Development] matssa:
No disabled by default now since a commit has been merged waaaay to early. It removes the su in order to replace it by an add-on, which doesn't exist ^^ so yeah, my builds are now without root! Please flash systemless root if you need it!

By the way, new build is on its way, I couldn't manage to build it on my work PC cause of the new camera blobs, so building on my home PC and will upload it when finished. I won't add any kernel commits, I'll wait until the kernel is updated with the sources :) furthermore, touch to focus is fixed in my new build.

Last but not least, thanks to [MENTION=4837394]siankatabg[/MENTION], I might be able to merge OMS in my builds, I'll try to start it today and this week-end, but can't guarantee anything for now and it won't be 100% OMS since stuff are present in settings app and other which have been altered by LineageOS team (is it LAOS now? Didn't see if it was official ^^).
[OnePlus 3 & 3T Cross Device Development] EatBeans:
[MENTION=6313536]matssa[/MENTION] What do you mean with not 100% exactly?
[OnePlus 3 & 3T Cross Device Development] matssa:
I will be able to include basic stuff as said in their post of how to port (4 main repos), the others are for extra stuff, and I'm afraid I won't be able to port those in particular.
[OnePlus 3 & 3T Cross Device Development] ivanich:
I was wondering why I still have su in my builds, then I found export WITH_SU=true in my build script. :)
[OnePlus 3 & 3T Cross Device Development] Rajeev:
So can we expect better camera results with new update? Better than previous?
[OnePlus 3 & 3T Cross Device Development] matssa:
Strange that you still have it cause it was supposed to bring the su add-on, which wasn't done yet... Maybe they changed it to inbuilt su until the add-on is done?

To have the su, seems like you used the open commit from dianlujitao ;)

I can't say for sure, what I think is a better compatibility with less bugs. For the quality, we need to get the processing stuff but we don't have it since we need the blob and know how to use it. It's the blob that OnePlus promised to deliver one day ;)
[OnePlus 3 & 3T Cross Device Development] ivanich:
No I'm not using any open commits, it means that this variable can be exported within bash environment and just enable build of su binary which is disabled by default. And it nothing to do with addon, just good old su binary. For reference look inside commit which disables su.
[OnePlus 3 & 3T Cross Device Development] matssa:
Mmmh nice find, and I didn't check more than that the commit, just tmsaw the comments ;)
[OnePlus 3 & 3T Cross Device Development] [deXter]:
Will you be fixing this then in the next build, [MENTION=6313536]matssa[/MENTION]? I really prefer inbuilt su because it's required by the iSu app, (which automatically toggles su/SELinux based on the current app). With builtin su + iSu, I can play Pokémon Go and use my banking apps without any issues. The last time I tried Magisk + phh it didn't work for me (maybe because I'm on unencrypted f2fs) but iSu has been working 100% and I don't have to flash anything extra - just the ROM!
[OnePlus 3 & 3T Cross Device Development] Rajeev:
Thanks for the answer my friend.. Will try ur new build for the first time. Thanks alot for ur effort to the community.. Keep up the good work..
[OnePlus 3 & 3T Cross Device Development] ivanich:
[MENTION=6313536]matssa[/MENTION]

Quote from http://lineageos.org/Update-and-Build-Prep/
[OnePlus 3 & 3T Cross Device Development] matssa:
Yup I'll add it until I find the flash able stuff that you will need for inbuilt su. The made a flashable zip which you only need once.
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks for the heads up, read it a bit and seems promising :) so weekly builds, that's a start :)

I'll continue making my builds even if they make theirs, cause I'll try to add custom stuff in there and maybe OMS ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
New build up guys. Inbuilt su is there, and OMS work has started ;)
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
I took a little pause away to see how you integrate it with your repos and whatnot, let me know if you manage to get it working I'm very curious! :good:
[OnePlus 3 & 3T Cross Device Development] Pumpino:
OnePlus didn't provide the camera blobs with the Nougat kernel sources? Have they provided any information about whether they intend to release them, or is it in the "too hard basket"? I'm surprised there's such a difference in camera quality between OOS and LineageOS. The Mi5 has the same camera sensor. Does anyone know whether it performs OK with LineageOS?
[OnePlus 3 & 3T Cross Device Development] matssa:
For now, masquerade is there, I managed to include frameworks_base, native, Settings I think, seems like Selimux is the last one ^^ I'll test it today.
[OnePlus 3 & 3T Cross Device Development] matssa:
Still nothing on that side, no ETA, nothing. So I dunno when they release it, if they ever do release it.
[OnePlus 3 & 3T Cross Device Development] piats:
[MENTION=6313536]matssa[/MENTION]

https://xdaforums.com/oneplus-3/dev...ficial-cyanogenmod-13-0-t3444221/post70655778

Kudos to [MENTION=1795993]kristofpetho[/MENTION]

He's made a commit from OOS brightness values + logic and rampup/rampdown speed.

Maybe we could test this?

https://github.com/kristofpetho/and...mmit/9b507b327fddb6a57189a26beaf2bc87fdd9f766
[OnePlus 3 & 3T Cross Device Development] rituj_b:
It works on RR nougat I can confirm
[OnePlus 3 & 3T Cross Device Development] hasdroid:
I'm so sorry for the dump question that I'm going to ask...

I installed Substratum app from play store on latest LineageOS from official post nd tried some themes so it worked like a charm... So why we need to incloud OMS commits in the holl ROM?

Thanks in advance ??
[OnePlus 3 & 3T Cross Device Development] siankatabg:
If you don't have those commits merged, substratum work on legacy mode (you can get in bootloop on some themes and you need to restart the device to apply it).

With full substratum support you can change themes, fonts, sounds and bootanimaton without need of restart and I think the chance of bootloop is minimal if any. Also some of the commits are for proper theming of the system and so on :)
[OnePlus 3 & 3T Cross Device Development] EatBeans:
And you will not have to reapply every theme after an ota if you have full oms support.
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks for the heads up, I'll include it in the next build. I'm currently launching a build to see if I managed to include OMS :)

///EDIT

Ok merged it with my stuff :) I'm launching now a build without OMS with this commit and we'll see how it goes :) I didn't include anything else that is open on review.lineageos since it is still WIP and I don't want to brick devices :)
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok guys, I managed to merge OMS!

Next step:

make a non-OMS build + upload it

make a OMS build and upload it :)

I'll keep you posted!
[OnePlus 3 & 3T Cross Device Development] piats:
OMS first? ;) :good:
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
Updated and substatum theme aplayed, and all ok by now ;)
[OnePlus 3 & 3T Cross Device Development] EatBeans:
I think one build is enough because the people which aren't using Substratum will not notice any difference
[OnePlus 3 & 3T Cross Device Development] matssa:
Nope after ;)

OMS not included yet ;)

After yeah only one build, but since I dunno if OMS works or even builds, I wanted to have a fresh start.
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
[MENTION=6313536]matssa[/MENTION], really? It worked ;) and no bootloop
[OnePlus 3 & 3T Cross Device Development] matssa:
Cause it uses legacy options from Substratum, on some themes you can have issues.
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
OK, understood, ;) will wait for OMS build to test more themes
[OnePlus 3 & 3T Cross Device Development] stryker09:
[MENTION=6313536]matssa[/MENTION] - building with your repos, running into build errors with OMS branches :(

frameworks/base/libs/androidfw/AssetManager.cpp:765:20: error: out-of-line definition of 'addSystemOverlays' does not match any declaration in 'android::AssetManager'
void AssetManager::addSystemOverlays(const char* pathOverlaysList,
^~~~~~~~~~~~~~~~~
frameworks/base/libs/androidfw/AssetManager.cpp:794:13: error: no member named 'isSystemOverlay' in 'android::AssetManager::asset_path'
oap.isSystemOverlay = true;
~~~ ^
frameworks/base/libs/androidfw/AssetManager.cpp:806:54: error: no member named 'addOverlay' in 'android::AssetManager::ZipSet'
const_cast<AssetManager*>(this)->mZipSet.addOverlay(targetPackagePath, oap);

looks like they got removed in https://github.com/Matssa56/android_frameworks_base/commit/b7fa2ff011b11a85a4773a486751f336a99692e6

but it looks like it was intentional...
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah this is what I was checking... I think I need to redo the repo from scratch...
[OnePlus 3 & 3T Cross Device Development] hasdroid:
Thanks buddy for informations :good::highfive:
[OnePlus 3 & 3T Cross Device Development] EatBeans:
[MENTION=6313536]matssa[/MENTION] dianlujitaos kernel updates are now buildable. Will they be included in the next build?
[OnePlus 3 & 3T Cross Device Development] matssa:
Well this depends, do you guys want OMS or the kernel? I can't do both ^^'
[OnePlus 3 & 3T Cross Device Development] EatBeans:
Well, I would say OMS :P
[OnePlus 3 & 3T Cross Device Development] Gandicela:
OMS, please
[OnePlus 3 & 3T Cross Device Development] piats:
Well I would say overall user experience is better with OMS :good: