yashsingh1/xdaforums huggingface dataset:
[Magisk] kantjer:
This was John's reaction when looking at my log:

why are there so many `com.microsoft.windowsintune.companyportal` in the list?

A single `com.microsoft.windowsintune.companyportal` will already handle all cases

Ah, it won't

I will try to add this feature to MagiskHide

The stack corrupted because the string length is too long LOL

Extending the buffer size will fix this issue

char sql[128];
sprintf(sql, "INSERT INTO hidelist (process) VALUES('%s')", proc);

The buffer size of `sql` is not big enough

I never expected anyone to use such long process names
[Magisk] ianmacd:
Yes, I read the code in the commit, and that's precisely what I don't understand. The length of that SQL command + the length of your package name is still < 128 characters.

I must be making an incorrect assumption somewhere. It's not important. I just prefer to understand why things work or don't work.
[Magisk] dethknite:
So excited! I think this may finally fix the issue with Moon+ Reader not working in MagiskHide.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] I just updated to r15 and noticed some weird quirks with the new systemless host module. In MM there is not a toggle as in the past. It is still using the old method until you click on it. If you now go into modules it shows the new module and states it will be active on reboot, just like any new module update, which makes sense. It just does not show in settings that a reboot is required. Even before reboot though, the new directories do show up.

I put r15 on two of my Nextbook Ares 8A's. On my oldest device, upon first reboot after flashing in TWRP, everything went as expected.

On my second, newest device, upon first reboot after flashing in TWRP, it booted to the startup wizard where I had to set up wifi and date, which of both were still saved with my previous settings. Upon closing the wizard it went to my previously saved desktop with all of my apps still intact, so it had not deleted userdata. On subsequent reboots, it booted normally again.

This was a strange set of circumstances, indeed.

Does anyone know what the reason is for this new systemless hosts module, vs. the older systemless way of doing it? Since [MENTION=4470081]topjohnwu[/MENTION] did not release a new Canary build also, maybe it is still an unfinished work in progress, as he states in the OP of that thread?

Thanks
[Magisk] buffal0b1ll:
Installed r15 on bullhead with 8.1 abcrom. Saw the things you noticed with systemless hosts but in the workflow I did notice a red "need reboot to activate" under the newly added module (but yeah I had to know to go to modules to check for it and see that I had to reboot, even tho I already knew that's the rules for a newly added module). After rebooting systemless hosts worked again as expected. It's interesting that it's a module now, but the workflow didn't seem kludgy to me at all to get it working right again
[Magisk] martyfender:
Yes it appears to work fine, but the toast that is shown in MM settings should probably state also that a reboot is required. But it is no big deal, as it is working.
[Magisk] kantjer:
I guess that's the risk of using nightly builds

I haven't tested the build myself yet.

My daily driver is the OP6T, there is no TWRP for that phone yet so I'm not experimenting on that.

EDIT:

Installed r16 over r14 on my Nexus, everything worked as expected

Only needed to activate AdAway host file again.
[Magisk] martyfender:
R6 has been working well for me, also.
[Magisk] psychoela:
Anyone have issue with substratum using r14 up, cannot create new or upgrade overlay.thanks
[Magisk] martyfender:
https://xdaforums.com/showpost.php?p=78197335&postcount=264
[Magisk] BustedFly:
Hi,

Is r17 working normal?

With r16 nothing is working on S7 Edge/ SM 2.8 Rom.

Actually i use r14 without Problems.
[Magisk] Ubimo:
r17 is working fine on S7 edge SM2.9. Only issue is that the changelog in magisk manager is jumping up and down.
[Magisk] martyfender:
I had that issue a few builds ago. Closing, swiping from recents and reopening MM solved it for me in that case.
[Magisk] kantjer:
the same issue in the canary builds.
[Magisk] martyfender:
I can reproduce that on all builds, Canary, yours and [MENTION=7187684]ianmacd[/MENTION] by clearing the repo cache, swiping down, the immediately going to about, changelog. It can happen also when checking for updates. When these checks have happened and I close the about box and try again, it doesn't happen.
[Magisk] kantjer:
According to John not much he can do about it, the rendering is done with the platform WebView (which is Chrome)
[Magisk] martyfender:
That may be the case, but then why did it just recently start happening? I have also noticed that sometimes when I clear the repo cache and swipe, it sits there forever trying to load. If I close MM and relaunch it, it then loads the download page.
[Magisk] guest4711:
No such problems here, using system webview on 7.1.2 and 8.
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] I can reproduce the above problem most of the time by doing the steps above. And if I turn off wifi and try it, it does not happen.

Attached is a per app logcat from LogcatX.
[Magisk] neekless:
[MENTION=7187684]ianmacd[/MENTION] 2018112002 build safety net API error. Something to do with your key?
[Magisk] ianmacd:
I did need to update my key, but I don't see any problem with today's latest build.

I can reproduce your issue if I hammer the button, no doubt triggering some kind of throttling on the servers. If I wait a couple of minutes, it works again.

Is it working for you now?
[Magisk] neekless:
I was still getting API error, but I cleared app data and redownloaded the snet.apk and it's working now. Thanks!
[Magisk] ianmacd:
Ah, I see. Yes, then others will probably have to do the same thing.

I never do the SafetyNet check myself, so I had to download snet.apk just to test this release; and so, of course, it worked for me.
[Magisk] martyfender:
This solved it for me, also.
[Magisk] Ubimo:
Just FYI, todays Android System WebView update resolves "jumping changelog" problem. :)
[Magisk] hshah:
I had this issue a few weeks back and I think I posted about it in this thread... completely forgot about it because it started working again a few days later. After reading the latest posts regarding this, it makes more sense because now I remember that I had wiped the MM data and it prompted me to install snet.apk.

On a slightly separate note, has anyone noticed that after one of the last couple of updates, the su access toasts have started showing even though they were disabled. I had to toggle the setting to disable them again.
[Magisk] martyfender:
That does not resolve it for me on my 5 Nextbook Ares 8A's, Android 6.0.1, Intel x86. Two devices are on [MENTION=3306843]kantjer[/MENTION] latest build, one on [MENTION=7187684]ianmacd[/MENTION] latest build and two on the latest Canary. I updated to Android System Webview 71.0.3578.64.

I can usually, but not always get it to happen by opening MM, go to downloads, swipe down to refresh, then quickly go to the about: changelog. However it does not always happen. I seems to be somewhat dependent on how fast the downloads refresh. I often have to try multiple times before it happens again, but I am able to duplicate it on all 5 devices.

The same error in a logcat is repeated over and over with many, many lines.

They are noted also in the logcat I attached yesterday and starts with:

11-19 22:44:57.967 2694 2723 E BufferQueueProducer: [com.topjohnwu.magisk/a.d] connect(P): already connected (cur=1 req=1)
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] Has anyone else experienced the problem of randomly loosing root on apps in some of the latest unofficial and Canary builds? It has happened to me with Kernel Aduitor and Apps2SD, more than once, and I believe it may be after a reboot.

At that point the app does not show up in MM under superuser and I must open the app and re-authenticate it. In the case of Apps2SD it will show up but I have to toggle it to allow it as it has been denied on reboot. And, like I stated it is random but has re-occurred several times over the last week, or so. It never happened before. Maybe it has something to do with the database being moved to the magisk.img?
[Magisk] sdeft:
In the latest kantjet builds Magic Manager is installed but when you run it it says that is needs to be updated. Why is this ?
[Magisk] kantjer:
your Magisk or Magisk Manger is most likely not updated yet.

I checked the json file and for both, it's correctly pointing to the r18 build
[Magisk] sdeft:
but magisk manager is installed from recovery when you install magisk.zip and this is from completely fresh rom install.

if i install 17.3 zip then magisk manager runs fine...
[Magisk] BustedFly:
Same Problem for me. Try r18 with fullwipe.

Last working Version for me is r14.
[Magisk] kantjer:
I noticed on my retired Nexus6P that the in app update doesn't work anymore (at least not for MM).

It just don't download the file :confused:

TWRP flash is still ok
[Magisk] martyfender:
Do you mean the update of the Magisk Manager in the app or the direct install method? It worked for me going from r17 to r18 but I still use TWRP to update Magisk as I don't trust the direct install method anymore.
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=3306843]kantjer[/MENTION] [MENTION=7187684]ianmacd[/MENTION] I do not need the hide Magisk Manager option, but from time to time I test it. I tested it a few weeks ago and the hide option works but the restore Magisk never works. When I click on the restore Magisk Manager, it starts to download the file, but never completes and I have to uninstall the hidden version, download the one on your github site and reinstall it. Does anyone else have this happen?

As I stated, the download starts and an incomplete file is created in my downloads folder. I deleted it and download the one on your github site and re-install it every time.

Attached is a logcat, but I am not sure if it has any useful info, as it was taken after I restored the Magisk Manager. Should I have done this logcat earlier?

Thanks for any input.
[Magisk] HamsterHam:
[MENTION=3306843]kantjer[/MENTION] latest build work fine for you? I ended up bootlooped but might not be magisk related. Tried too many things at once, lol. Annoying thing about Pixel 3XL is no recovery partition so gotta wait until I am home to fix it.

Edit: All good. Dunno what I did earlier.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] Has anyone else experienced spontaneous reboot of their devices with r23? I have had this happen on the 2 Nextbook Ares 8A's that I have this build on. I will look into getting logs.

Interestingly, I have not had this happen yet on the 2 devices that I have the latest Canary build on, which should be at the same commit level.
[Magisk] martyfender:
I just had another spontaneous reboot of one device or r24. The devices seem to settle down after a second reboot after updating Magisk.

Is it possible that recent builds need 2 reboots after updating?

I have not had this happen with recent [MENTION=7187684]ianmacd[/MENTION] or Canary builds. The one device with [MENTION=7187684]ianmacd[/MENTION] build on it was sluggish until a second reboot, and the launcher was apparently crashing and relaunching. I has seemed to settle down after a reboot.

Thanks
[Magisk] guest4711:
Did not notice it on Galaxy Nexus, S4, S4 active, Tab S2, neither with Ians nor with kantjers builds... Everything working as expected after updating and rebooting.
[Magisk] sdeft:
also got one in r24 in xiaomi a1...
[Magisk] psychoela:
[MENTION=3306843]kantjer[/MENTION] MM r25 is something error, clear data still not help:D
[Magisk] an21281:
I got a notification that there was an update for mm25, clicked to update which opened the app. Then it showed invalid update channel(even though it was set correctly to kantjer). Had to click on custom and manually add the url. Now it's working fine
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] The kantjer channel is apparently broken in this build. Entering the url in the custom field works though.
[Magisk] kantjer:
I will check it later, probably a commit interfering with my update channel change.
[Magisk] martyfender:
I'm still getting spontaneous reboots after the first reboot after install. maybe an hour later, after the device has been in doze mode for a while. I will delete cache and dalvik cache in TWRP. This only appears to happen after the first reboot after install, so far.
[Magisk] kantjer:
The issue is fixed in r26
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] When I download MM through MM and try to install it, I get a parse error. When I download it directly through my web browser, it is fine. I get the same on a second device.
[Magisk] Deic:
what do you mean? the notification only show when a update is available. If you refer to the stuff occurs when open the app, I said you that you have to ignore the icon in the launcher and not need to launch it.

Run the script attached from device (with Terminal Emulator for Android, not adb), if shows a notification and waiting 5 seconds shows other and if tap it opens Magisk Manager, all is fine.

Do as this:

$ su
# sh $EXTERNAL_STORAGE/Download/notification.sh.pdf
[Magisk] kantjer:
Does anybody know if/how it's possible to toggle "Magisk Hide" with Tasker?

With the unofficial v12 version I need to toggle the setting after every boot to make it work. It would be nice if for the time being that can be done with Tasker after a reboot.

I tried running the disable/enable scripts is /magisk/.core/magiskhide but that didn't work
[Magisk] kantjer:
Just had my Magisk manger updated by the updater script (v3.1.0) but unfortunately Magisk Manger setting were all lost.

Anything I can offer to help fixing that?
[Magisk] Artim_96:
I had to uninstall the manger first "failed because of an existing package with the she name" or something like that
[Magisk] Deic:
Running enable script with root privileges from Terminal Emulator works, I don't know how Tasker works.

That is strange, because "pm uninstall -k <package>" only removes apk and not data.

you can post "updater.log" under "/magisk/magisk-manager-snapshot-updater" folder after install update.

updater.log got overwrite every boot, you can force update editing "magisk_manager_version.txt" to something as "version=1". I will add to module a backup feature of log of previous boot for convenience in next release.
[Magisk] Artim_96:
Installed the 20170308 version, Magisk hide is still not reacting. I wish I could help you with since logs but since the last ones I posted nothing had changed, still only the normal entries like always (at least what I see) without any entries concerning Magisk hide
[Magisk] Deic:
That is related to Magisk (I think APK side), you must post in official thread or open an issue in official Github repo of Magisk/Magisk Manager.
[Magisk] Artim_96:
New issue is opened in GitHub
[Magisk] Deic:
When I said official Magisk Manager Github I refer to https://github.com/topjohnwu/MagiskManager hehe. Stangri only build Magisk from lastest commits from topjohnwu's one, he can't do nothing to solve this. Sorry if I confused you.
[Magisk] Artim_96:
.... Really:eek:

Is there a way to delete it?
[Magisk] Deic:
no problem, I will close it and all ok xD...
[Magisk] thedevilslettucemd:
+1 for this. same issue and would love to know if there's a workaround that i don't have to apply every time i reboot. cant even seem to get the script to work in terminal. it executes but the toggle isnt changed.
[Magisk] Deic:
The toggle is only a UI stuff and is bug, run the enable script as root and launch an app like Pokémon GO (that detects for root) and you will see that magisk hide is working correctly.
[Magisk] kantjer:
I had already done a reboot

I will monitor this for the next update and post the log if it happens again
[Magisk] Deic:
I got why Magisk Hide doesn't autostart if enabled on boot

The problem is in magic_mask.sh, it does the job of run every stuff of Magisk.

When the device boot, it run init.magisk.rc in root directory that it runs /sbin/magic_mask.sh (both are in ramdisk of boot image and got overwritten every boot, so edit them directly is useless).

Here is a place of magisk_mask.sh:

service )
[...]
log_print "** Magisk late_start service mode running..."
[...]
run_scripts service

# Start MagiskHide
[ "`getprop persist.magisk.hide`" = "1" ] && sh $COREDIR/magiskhide/enable

It call in "run_scripts service" a function called "run_scripts" with "service" as argument, so here runs in a loop all module's service.sh & scripts under service.d directory (in this situation $MOD/$1 is same as /magisk/module/service.sh & $SCRIPT is /magisk/.core/service.d/script) untill all got executed:

run_scripts() {
[...]
sh $MOD/$1.sh
[...]
sh $SCRIPT
[...]
}

The problem is that they got run one by one and every one need to wait to current to be finish.. So if a module service.sh or script under service.d have got a loop and don't finish never (like my snapshot updater module), then magic_mask.sh got paused untill that script end and this code under "run_scripts service" doesn't get execute never:

# Start MagiskHide
[ "`getprop persist.magisk.hide`" = "1" ] && sh $COREDIR/magiskhide/enable

It checks if persist.magisk.hide value is equal to 1 and if yes, run enable script to run Magisk Hide functionality. persist.magisk.hide is set from Magisk Manager app settings.

The solution is add a space and "&" back to "sh $MOD/$1.sh" and "sh $SCRIPT". "&" runs the command in background to allow that the magic_mask.sh can does its job and doesn't get paused.

I did a pull request to Github repo of Magisk:

https://github.com/topjohnwu/Magisk/pull/106

PS: That English... XD
[Magisk] Deic:
Hot fix - Magisk Manager Snapshot Updater 3.1.0 Background Edition

Now running in a subshell to not interfere with other modules and Magisk Hide boot start and some fast small changes to fix problems with apk updates for some devices.

Sorry for waiting, I was a little busy...
[Magisk] weeka89:
Facing the attached error running latest versions of both magisk and magisk manager 170308
[Magisk] stangri:
[MENTION=4476591]Deic[/MENTION] try 'wget --no-check-certificate'
[Magisk] Deic:
All is fine, the first 2 "errors" were because no internet conection in your device or the connection to server was impossible

wget: unable to resolve host address 'raw.githubusercontent.com'

the others are normal, are advise of problem with certs of website... all correct.

#↓this lines are advise of problem with cert
WARNING: cannot verify raw.githubusercontent.com's certificate, issued by '/C=US/O=DigiCert Inc/OU=www.digicert.com/CN=DigiCert SHA2 High Assurance Server CA':
Unable to locally verify the issuer's authority.

#↓this line means that download was successfully
2017-03-10 22:12:35 URL:https://raw.githubusercontent.com/stangri/MagiskFiles/master/updates/module_update.txt [206/206] -> "/magisk/magisk-manager-snapshot-updater/module_update.txt" [1]

[MENTION=2226076]stangri[/MENTION] wget --no-check-certificate was since first version (v1.0) xD... without that, wget doesn't work with problematic certs :3
[Magisk] dreinulldrei:
Just to let you know

Magisk-v12-170311.zip

version does not work on OnePlus3T. It can't unpack boot image.

Magisk-v12-170308.zip

works fine.
[Magisk] kantjer:
Next time when that happens can you please download MM from my GitHub and see if that installs. Could be a bad up or download
[Magisk] martyfender:
That is what I said I did in the web browser and it is ok, then.
[Magisk] kantjer:
Sorry I didn't read correct :o

No idea what's going on then.

MM should do the same version.
[Magisk] martyfender:
I didn't experience that on the other device I have [MENTION=7187684]ianmacd[/MENTION] and the 2 devices I have the latest Canary on.

However on one of my devices I updated to todays Canary, I did have a spontaneous reboot, which seemed to be ok again after the second reboot. For good measure, I rebooted to TWRP and wiped the dalvik cache and cache.

The issue seems to happen only once, after the device is in doze mode, or at least the screen is off for some time.

I'm not sure how I would even log this issue?
[Magisk] kantjer:
I tested with r27, and MM download and install is working

Only my update channel is broken again :confused:

EDIT: Update channel fixed in r28
[Magisk] martyfender:
I am still getting a parse error when trying to update MM through MM. Downloading it manually from github works, though. r28.

UPDATE: The same thing happens with the newest Canary build on another device.
[Magisk] bggold:
No problems with r28. Pixel 3xl.

Thanks
[Magisk] martyfender:
I am also getting a parse error when trying to update MM, in MM, with [MENTION=7187684]ianmacd[/MENTION] 's latest build. All 5 these devices are x86, could that have anything to do with it or is it a problem with MM's new built in download manager? There is also no new or partially downloaded file in the downloads folder.

Once again, the manual download of the file on github, with a web browser always works.

UPDATE: [MENTION=4470081]topjohnwu[/MENTION] did a commit that is supposed to fix this issue on older Android versions.
[Magisk] mirfatif:
64-bit build

[MENTION=4470081]topjohnwu[/MENTION] [MENTION=7187684]ianmacd[/MENTION] [MENTION=3306843]kantjer[/MENTION] any chances for 64-bit builds? Or if you can give some hints what changes to source code be made for arm64 builds?

I run Linux on my phone inside chroot and namespaces (which obviously requires root access). I need 64 bit so that my login and hence subsequent processes run as aarch64. If the architecture is 32-bit (e.g. uanme -m shows armv8l), building/compiling environment is disturbed resulting in errors or 32-bit libraries/binaries.

Any help would be greatly appreciated. Thanks.
[Magisk] LazerL0rd:
This would apply to Kali Nethunter if I'm correct? I now see why it wasn't working, thanks.
[Magisk] kantjer:
https://github.com/ianmacd/Magisk/commit/27fe7db36b229a20a81ba8f5f7660a27e30b3b95

https://github.com/ianmacd/Magisk/commit/c40197cfa31d29ce8a1c20f84f3da9314e80e59a
[Magisk] ianmacd:
I removed the 64 bit versions, because they no longer appeared to have a purpose, but this seems like a good argument for reinstating them. The obvious place to do so, however, would be upstream, and I'm wondering what [MENTION=4470081]topjohnwu[/MENTION] thinks of the idea.

UPDATE:

[MENTION=7805402]mirfatif[/MENTION], ianmacd build 2018120502 reinstates the 64 bit binaries, at least temporarily. Please test for your purposes and advise me of your progress.
[Magisk] mirfatif:
Yeah, I use others as well; Ubuntu, Void, ArchLinux. In fact it applies to every process started by su but such changes aren't noticeable for common Android UI apps unless you spend enough time on command-line.

---------- Post added at 07:23 PM ---------- Previous post was at 07:19 PM ----------

That's helpful. I didn't notice those commits but in fact I tried that a few days back and got some errors. I'll update on that if needed.

---------- Post added at 07:24 PM ---------- Previous post was at 07:23 PM ----------

Not up on github yet? Waiting...
[Magisk] ianmacd:
Evidently, I neglected to merge the testing branch into the master branch.

I will push the new build to master in an hour or so, once I get home.

---------- Post added at 03:01 PM ---------- Previous post was at 02:54 PM ----------

Those commits will no longer apply cleanly, I'm afraid, and there are a couple of new obstacles to overcome, as I discovered today when I set out to include the 64 bit binaries again.

Just bear with me a while longer. I'll have the new build up in about an hour.

UPDATE:

It's going to take me a while longer. There's a problem with the 64 bit binaries that I need to trace before I can release them.

2ND UPDATE:

This turns out to be trickier than it used to be. My first boot in testing yesterday was OK, but with subsequent reboots I have lost root. Most odd. I've sunk quite a bit of time into figuring out why, but no answer yet. So, until I trace the problem, I can't include the 64 bit binaries again.