yashsingh1/xdaforums huggingface dataset:
[Magisk] kantjer:
Including the last commit hash after the build date isn't going to happen for various reasons.

But most important, I don't like it :p

But I have some ideas how to give users more info in the last added comits.

I will upload the changelog to my github with every build and you can check that from MM if you goto Install=>Release Notes

For now it will show you all commits from the last 10 days, I will try to find a way to have the build script calculate the time between last 2 builds and only generate a changelog for that period.
[Magisk] martyfender:
Thank you for adding the changelog. I do monitor [MENTION=4470081]topjohnwu[/MENTION] 's commits but when he continues to update on the same day as your build is released, it was sometimes hard to determine if yours had his recent changes, or not, other than the time that shows when you did it For example, it now shows an hour ago. Of course, right now it is easy to tell because he has not posted any updates today. The direct install method almost always works well for my devices.

Thanks again.

---------- Post added at 01:31 PM ---------- Previous post was at 12:58 PM ----------

As can sometimes happen with these unofficial builds, I lost root a few minutes after install, noticed when I launched the beta Adaway-4.0.4-180603, only installed on one of my devices. Root was back after a reboot.

[MENTION=4470081]topjohnwu[/MENTION] and [MENTION=3306843]kantjer[/MENTION]

In addition to debug and magisk log I re-ran the direct install from the Magisk Manager and also attached the install log.

That was build 180617. I have installed it on a second device of the same hardware, but will hold off on installing it on my 2 other devices.

Would it be better to post the logs in the general thread or will [MENTION=4470081]topjohnwu[/MENTION] see them here as well as [MENTION=4667597]Didgeridoohan[/MENTION] , here?

UPDATE:

So far, the error has not re-occurred on that device, or appeared on the second device of the same hardware I did Magisk Manager direct installs on. In a couple of past builds where this occurred, it took several hours to manifest itself, though. It was quite a few builds back when this loss of root happened, until today. That has not happened for some time.

Is it possible that the reinstall that I did solved it, as in a bad install on that one device?

Thanks
[Magisk] Didgeridoohan:
[MENTION=8126387]martyfender[/MENTION] So far I believe I've read pretty much every single post in all the threads of the Magisk forums... Especially the ones where I'm mentioned. :p

Noted... :good:
[Magisk] martyfender:
Thanks for replying, sorry, I thought you did, I just mentioned you also, as you are so good at reading logs and helping. That is much, much appreciated. My device has been asleep for a couple of hours and upon awakening it, I don't see the error again. Maybe the second install fixed it, not sure, only time will tell. I just checked on the second device I installed it on and root is granted when I launch root app, also.

So I am tempted to install 180617 on my other 2 devices, but maybe I should wait. However, it is easy enough to go back to the previous, 180614 build by flashing it in TWRP. If you have the time could you review the logs and see if you see anything that stands out? Maybe not since as of yet I can't reproduce the problem. [MENTION=4667597]Didgeridoohan[/MENTION]

I just lost root again, this time on the third device I flashed it on. I did the direct install recommended method again, then went out for Fathers Day dinner with my sons, came back and opened Adaway again and get the message: rooted android required, in Adaway. I also get this in other apps and Magisk Manager wants to install it again but I only get the options: download zip only and patch boot image file. I will try to attach a logcat after reboot, since adb root also does not work without root on the device.

Will it be useful after reboot and root is gained, again?

I just reflashed build 180617 through TWRP on the last mentioned, 3rd device to see if the issue reoccurs. So far root loss has not returned to the first 2 devices I did the direct install on where I redid the direct method a second time in the MM. I may post back tomorrow if I loose root again, if [MENTION=3306843]kantjer[/MENTION] does not update for the commits [MENTION=4470081]topjohnwu[/MENTION] did today after his 180617 release.
[Magisk] Didgeridoohan:
[MENTION=8126387]martyfender[/MENTION] I don't see anything apparent in your logs. The best one would be the magisk_debug.log, saved before you boot up your device after experiencing a loss of root.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] For some reason, on multiple devices, when I try to download your 180618 build through the custom update channel, I get and invalid update channel.

Was there possibly a mistake in It? I will try again in the morning, to see if it is fixed, or download the files and flash through TWRP.

Thanks

---------- Post added at 04:07 AM ---------- Previous post was at 04:03 AM ----------

But how would I save it without root? When I didn't have root, I got access denied when trying to open that folder where it is stored. Can it be done somehow in TWRP?
[Magisk] kantjer:
It's already fixed.

It could take a few minutes before MM picks up the correction.

I added generating and uploading the changelog to the build script but made a typo in updating the json part.

EDIT: The changelog wil now only show commits added after the previous upload.
[Magisk] Didgeridoohan:
Yeah. Boot to TWRP and use the file manager (Advanced -> File Manager) to copy the file from /data/adb to a more accessible location on your internal storage (/sdcard).
[Magisk] BustedFly:
Hi, I have problem with a few builds. After full wipe and fresh installation with the first start. Phone starts 2times like a bootloop.

Whats happend?
[Magisk] ianmacd:
My builds now include something similar. MM's change log now shows the most recent 10 commit messages from my fork (excluding any merges from upstream, as those are implicit), along with the short hash of the latest commit, which will usually be a merge from the upstream repo. If people have better ideas of what they'd like to see here, I'm open to hearing them.

Incidentally, the latest build, 20180618, contains an upstream fix for installation on the S9/S9+. The temporary hack that allowed these devices to be supported by the same ZIP file as other devices has been removed.

At this point, the only area in which my fork diverges from upstream is in the continued inclusion of 64 bit binaries.
[Magisk] kantjer:
Still working on improving the change log stuff
[Magisk] ianmacd:
I have that, too, although I'm not sure whether the hashes actually add anything to the user experience, since the text alone pretty much uniquely identifies the commit to anyone who is actively scanning the git log.

I've now modified mine to also only list the changes since the last build, but I'm in two minds about it. If a snapshot with only one or two commits quickly follows a period of heavy work, any user who installs only the later build will miss most of the recent changes. If people are only interested in identifying the most recent change, however, it doesn't matter.
[Magisk] kantjer:
I agree hashes are only of interest if the commits are force pushed, otherwise the commit description should be sufficient.

For now I mostly concentrated on scripting everything more than the actual content. Specifically how to show only the commits added after the last upload needed some thinking.
[Magisk] odinville:
pass selinux permissive experimental on native root checker

please give me a solution...

rom dot os 7.1.2 a6020a46, magisk v16.0 installed... safetynet passed but when i check by native root checker, it says status ROOTED: red checklist [x]Selinux permissive experimental...

although status of my hh is Enforcing.

thanks
[Magisk] martyfender:
With the most recent build , after a period of time, I loose root, just like the previous build. I saved a debug log in twrp, but I am at work and it is on a second device at home. Will post much later, when I can.
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=4667597]Didgeridoohan[/MENTION] Here is the magisk_debug.log after I installed build 180618 and lost root. It appears this problem appeared after Commits on Jun 16, 2018, as the previous build, 180617, had the same root loss issue on my devices. build 180614 works great on all 4 of my Nextbook Ares 8A, Intel x86_64 tablets.
[Magisk] redultra82:
On Huawei P Smart Emui 8/Oreo I HAVE to use unofficial builds or magisk manager keeps crashing within seconds of opening

Then I can install ianmacd zip, but not the apk

Such a weird phone for things like this
[Magisk] redultra82:
To be honest I dont want to mess with trying to install Magisk again as the least thing and this phone "breaks"(TWRP kinda works, no real custom rom, only certain stock rom works) Otherwise id be all in for trying it out and providing any/all feedback to help

Just a generalization I said id throw out there. Could be something to do with X64 drivers, think that what causes the issues with Viper4andorid and maybe Xposed
[Magisk] ianmacd:
I don't know why the official builds crash on your device, but my guess would be that a bug has been fixed post-v16.4 that your device relies on. Logs would be needed to say for sure, though.

As for not being able to install my MM APK, please first uninstall your current APK and try again. You cannot simply upgrade from one version to another if the packages were signed with different keys, and everyone from the developer himself with the official builds, to people like me offering unofficial builds, is necessarily using a different key to sign these APKs.
[Magisk] redultra82:
I tried after fresh official unistall

I can have your zip installed with the other unofficial apk

I know all this is just talk without logs etc, but just general chat and have a non crashing magisk so am happy
[Magisk] kantjer:
I also lost root today (hasn't happened for a long time)

I tried reverting this commit but that breaks the build.
[Magisk] ianmacd:
Yeah, when I saw that commit come by, I thought to myself "Let's hope that one doesn't cause any problems."

Reverting that one commit isn't enough, because of the confusing way that submodules work in git.

If you run the following command after reverting, you should be able to build successfully:

$ git submodule update --recursive
[Magisk] Didgeridoohan:
It's an ongoing attempt to cure the disease rather than the symptoms. Root loss with Magisk has been the holy grail of bugs for a long, long time...
[Magisk] ianmacd:
I've never used the official uninstaller before, but if that's what you used, looking at it now, it appears to remove only Magisk, and leave Magisk Manager itself intact. That would cause the problem you describe.
[Magisk] redultra82:
No there was no magisk manger installed when trying to install your apk

While we're talking, what's the difference in the unofficial versions? Just i cant see information
[Magisk] ianmacd:
OK, you've got me there. An incomplete download? I don't know.

Not much at the moment, as far as I know. Mine still includes 64 bit binaries, which might be the only notable difference.
[Magisk] martyfender:
I also suspected that commit was one of the reasons for lost root. On my devices, root loss seem to occur after I am away from the device for some time and in goes into deep sleep for a long period of time. It is when I wake the device up from doze that I then see root is lost. I have reverted to build 180614 to solve it for now.

[MENTION=3306843]kantjer[/MENTION] Did you rebuild 180618 as it shows a time of three hours ago?
[Magisk] kantjer:
No nothing new, I only pushed last_commit.txt

That file will have the last commit included in the current build and will be used when generating the next change-log. The commit in that file and all older ones will be removed from the next change-log by the script.
[Magisk] hshah:
[MENTION=4667597]Didgeridoohan[/MENTION], I got bored of waiting for my phone to lose root again, especially I've I tried to install random modules and even that didn't break it.

Installed kantjer's 180618 MM and then flashed the ZIP, and still no issues. It looks like the issue has fixed itself by magisk :fingers-crossed:
[Magisk] redultra82:
Curiosity got the better of me and eventually got Ian version working

Last thing was to install some environmental zip which never seem before

I'll stick with this now and see, thanks for help
[Magisk] edzamber:
For me since this last build i don't loose root anymore...

S9 g960f with my full deodexed Rom
[Magisk] ianmacd:
Root loss bug finally squashed?

I've just pushed a 20180619 build to my custom channel that contains [MENTION=4470081]topjohnwu[/MENTION]'s latest batch of changes, amongst which the following very striking commit:

Could it be that the (Samsung) root loss bug has finally been consigned to the annals of Magisk history? We'll soon see.

And, just to avoid any confusion, those with sharp eyes may notice that the above was committed to the upstream repo in the early hours of 20th June, whilst my 20180619 snapshot already has the code. That's because [MENTION=4470081]topjohnwu[/MENTION] is located in Taiwan at UTC+0800, whereas my builds use UTC to normalise the date. So, it was still the 19th of June in Greenwich when John was committing the code.

Good luck with this snapshot.
[Magisk] joluke:
Anyone having problems with their Note 8 (SM-N950F) ever since the build from day 14?

My UI suddenly stops responding and i have to bruteforce the phone to reboot..

And when it stops responding it reboots on its own...

Can't get any logs from the event :(

PS: I've tried all builds until today and all do the same with the phone. Only build from day 14 is stable
[Magisk] SpectraFun:
Lost root on my Oneplus 6 with Magisk-180617.zip.
[Magisk] JEANRIVERA:
The loosing root issue has been resolved on latest commits by topjohnwu, those commits are not present on kantjer latest build yet
[Magisk] JEANRIVERA:
Here some proof
[Magisk] SpectraFun:
Flashed now this Build and root working on my Oneplus 6. I also see there is no more a/b boot for treble devices.
[Magisk] martyfender:
Has anyone confirmed that the root loss was fixed with these commits? I have installed your build on 1 device to test.
[Magisk] SpectraFun:
Its working on my OP6.
[Magisk] ianmacd:
I'm running it on two different Samsung devices here. Only time will tell, I suppose. It's too early to say just yet.
[Magisk] pjrs2812:
No longer loosing root but Titanium Backup is being granted root access. Root checker can't verify root and says it's not installed. My other root apps when run prompts the superuser to grant access.
[Magisk] Didgeridoohan:
[MENTION=4283035]armando_rod[/MENTION] You could try one of the unofficial snapshots from here. There was a commit yesterday that might fix the root loss.
[Magisk] armando_rod:
Just flashed this on Android P beta 2 to test it, the log still has a "file doesnt exist" on the hidelist and I can't install the "app systemizer" module, it says the installation was ok but after reboot it isnt there.
[Magisk] Didgeridoohan:
That Magisk log is not from any snapshot, it's the v16.4 beta... And there might be more info in the magisk_debug.log.

But, I was mainly interested in the root loss... It'd be interesting to hear if you'll be able to run this build without loosing root.
[Magisk] kantjer:
With the previous build I lost root twice in 24h

The next 24h will tell if the problem is fixed or at least improved :fingers-crossed:
[Magisk] kantjer:
Unfortunately lost root again with today's build
[Magisk] Didgeridoohan:
Is this on your Nexus? And you had not lost root at all before the invincible mode commit was reverted, right?
[Magisk] kantjer:
Correct on my Nexus6P. No root los before the invincible mode was reverted a few days ago.
[Magisk] ianmacd:
It's possible that these recent commits have fixed the Samsung root loss at the accidental expense of other devices.
[Magisk] Didgeridoohan:
I suspect that it's a two part deal. Some experience the daemon getting killed (invincible mode took care of that) and some experience the double zygote server (the new fix). I'll bring it up with [MENTION=4470081]topjohnwu[/MENTION].
[Magisk] BustedFly:
I try new build with full wipe. The same thing happens. Is this a bug or a new feature :).

I use a s7 Edge with SM 2.8.

I do this.

1: full wipe with twrp

2: install Rom, csc, kernel and magisk

3: now... First boot....

4: I can see the first boot screen...

5: now the phone boot again and the phone boots normal to the second bootanimation

With Magisk 15.3 is this not... Only one boot.
[Magisk] ianmacd:
Yes. I just meant that invincible mode may have been removed to facilitate the insertion of the double zygote handling code.

Or possibly there's a reimplementation of invincible mode just around the corner. It's hard to know where the developer is going with this.
[Magisk] BustedFly:
I found a new bug: SD Maid don't work. No root rights.
[Magisk] Didgeridoohan:
If you could grab the magisk_debug.log after you've lost root, it might at least give a hint as to why the daemon is being killed/crashing. If you could grab a logcat of it happening, that'd be freaking amazing!
[Magisk] SpectraFun:
No problem on Oneplus 6.
[Magisk] radz_:
I had the same problem and I just fixed it few days ago.

Try to reflash Magisk via Magisk Manager app then reboot.

That fix my problem, try it, it might work for you too.

Note: the issue occurred to me when I was using 06/16 build. Not sure with the latest version.

Check the discussion here:

https://xdaforums.com/showthread.php?p=76834486
[Magisk] kantjer:
I will pull the debug. log next time root loss happens (I have already rebooted)

Grabbing a logcat will be much harder, root loss is very unpredictable.
[Magisk] BustedFly:
Thx... I flash magisk via Twrp again and now SD Maid works.
[Magisk] radz_:
Great!! Happy to help![emoji4][emoji4]
[Magisk] martyfender:
Last night I installed you build on one of my devices. This morning when I woke it up root was there initially, but about an hour later it was lost again for me. the temporary fix was to reboot. I guess it is back to build 180614, again.

I just installed [MENTION=3306843]kantjer[/MENTION] 's new, 180620 build on one device and I am almost certain root will be lost on it within a few hours, also.
[Magisk] ianmacd:
Thank you for the report. Can you please state the make and model of your device?
[Magisk] kantjer:
For me the root loss is guaranteed to happen overnight. Making my scheduled nandroid to fail :crying:
[Magisk] martyfender:
It is shown in my signature but an older revision of the tablet, with an older build date. It has the same Android version and kernel version and an older IFWI (Intel Firmware Interface) version. ROM build v1.1.1.

A couple of days ago I posted a debug log copied in TWRP before reboot when the root loss occurred from one of [MENTION=3306843]kantjer[/MENTION] 's previous builds, (I believe 180618).

https://xdaforums.com/showpost.php?p=76855955&postcount=1708
[Magisk] Didgeridoohan:
Save the magisk_debug.log before rebooting next time, please.
[Magisk] martyfender:
I did previously for 180618:

https://xdaforums.com/showpost.php?p=76855955&postcount=1708

It was copied in TWRP, before reboot and is not the one you reviewed, previously.

If root loss occurs on the devices I installed [MENTION=3306843]kantjer[/MENTION] 's 180620, or [MENTION=7187684]ianmacd[/MENTION] I will post it later after work, much, much later tonight since I work 2nd shift and getting ready to go to now.

Thanks
[Magisk] martyfender:
Attached is the debug log from [MENTION=3306843]kantjer[/MENTION] 180620, copied in TWRP, after root was lost. It happened before I had to leave for work.
[Magisk] armando_rod:
I keep flashing ianmacd build it says it's successful but when I boot, it's the old 16.4 beta

edit: I think it has to do with A/B partitions because even if I flash the factory image happens the same, it says Magisk is not installed (Pixel on Android P)
[Magisk] kantjer:
Could be just a coincident but after the root loss yesterday (about 20h ago) as an experiment I did remove MagiskManager from Androids battery optimization.

No root loss since then, root even survived the night, finger crossed.
[Magisk] ianmacd:
I've yet to hear of a Samsung user losing root with the double zygote fix, but that could just be due to the tiny number of people actually running the code.

Have you built with John's commits from today yet? I'm running 14eebd582fe030fca5805f3529d4f6137d01b0c1 on my S9+ and Magisk Manager is starting very slowly now, but everything works fine otherwise. I'm wondering if you see the same on your device.
[Magisk] kantjer:
I flashed today's build about 30 minutes ago, I have root but can't open MM (hangs on splash screen)

Restoring a nandoid now, and try again.

Could be it's so slow I didn't wait long enough
[Magisk] ianmacd:
Yes, I suspect you didn't wait long enough. :) The app opened just as I was about to kill it.

Today's changes are minimal, so I suspect it's due to the addition of the function find_block() in scripts/util_functions.sh, which is very inefficient in the large number of external commands that it spawns.
[Magisk] kantjer:
I probably killed it just before it was about to open :D
[Magisk] dingolino:
Edit: on my Note 8 the start takes approx 40s

Me too,

After a reboot MM is starting as it should but after a while not.

Best regards

dingolino

Gesendet von meinem SM-N950F mit Tapatalk
[Magisk] kantjer:
yep, reverting "Get device blocks with sysfs" fixed the issue

EDIT: I have force pushed the build with the above commit reverted.

Auto changelog creation is working :D
[Magisk] kantjer:
Now 24h without root loss after removing MagiskManager from Battery Optimization.

[MENTION=4667597]Didgeridoohan[/MENTION] could it be su daemon was killed by doze?
[Magisk] joluke:
This does too make my UI force close the my phone (Sm-n950f) to fully boot. Ever since build 20180614 until now that issue occurs. But with 20180614 it's running smoothly.

Any ideas?

Can't get any logs because the phone will all crash and reboot by itself after the UI stops responding.

I did a previous post but was ignored
[Magisk] martyfender:
I will try that also, with your latest build today.

UPDATE:

Unfortunately, removing Magisk Manager from battery optimization did not work for me with 180621.

[MENTION=4667597]Didgeridoohan[/MENTION] [MENTION=4470081]topjohnwu[/MENTION]

Attached is the magisk debug log saved in twrp, once again.

Could you post if there is any useful info in it?

[MENTION=3306843]kantjer[/MENTION], I did notice that the su daemon was updated a few days ago, also, could that be the cause?

https://github.com/topjohnwu/MagiskSU/commit/29d5740205753f911123e6672a53d8d3414e49dc

Thanks
[Magisk] kantjer:
I don't think thats the cause, removel of the invincible mode is causing this I think. But that was a bandaid and not a fix.
[Magisk] martyfender:
Build 180614 is the latest one that continues to work well for me. I could not remember what invincible mode was, but found reference to it near the end of the stable thread.

Looks like [MENTION=4667597]Didgeridoohan[/MENTION] is away on a trip around the world, so may not troubleshoot my log for a while, but who knows?

Nextbook Ares 8A

Processor: Intel x86 Cherry Trail Atom x5-Z8350 @1.92 GHz, 1gb RAM, 16gb internal storage

Model number: NX16A8116K

Android version: 6.0.1 Marshmallow

Kernel version: 3.14.64-x86_64

Build number: V3.0.4.MMB29M.201710620..075926

IFWI version: M882_JJ.023_JJ

Recovery: TWRP 3.1.0-0 built by vampirefo

Root: Magisk (180614) Unofficial Version Kantjer With [MENTION=4470081]topjohnwu[/MENTION] 's lastest commits on github.

Thanks for your continuous builds and feedback in the hope of making Magisk better.
[Magisk] kantjer:
AFAIK it was a meganism to restart the daemon when it stopped/crashed. Ideally you don't want it to crash at all. I think that's what this is all about. Finding a way it won't crash