yashsingh1/xdaforums huggingface dataset:
[Magisk] HamsterHam:
Anyone not passing CTS now? Running the latest r29 on my Pixel 3 XL.
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=3306843]kantjer[/MENTION] Attached is a per app logcat after the parse error occurred. That was with r28 trying to update to r29.

Once r29 MM is updated, this, of course, should be fixed with your latest commit. I thought maybe a logcat could still be useful.
[Magisk] martyfender:
My Nextbook Ares 8A passes with r29.
[Magisk] martyfender:
The parsing error was fixed in r29 and updates to r30 fine.
[Magisk] ianmacd:
I assume this also applies to my latest build. Correct?
[Magisk] mirfatif:
Thanks for your efforts. Anxiously waiting for your beta release. I'm available for testing or any other support.

Meanwhile is it possible to implement Treble support on 16.0 stable build or the last 64-bit supported official build 16.3? I tried a few of existing modified zips but those didn't seem to work. Actually I have been using 16.0 so far on non-Treble Oreo ROMs just because of this 64-bit issue but now finally I switched to Pie ROM (Pixel Experience on Redmi Note 4). So the non-treble Magisk is of no use now.

Or is it possible to make it work by replacing just the binaries (in boot.img ramdisk or /data/adb) after flashing Magisk or (in flashable zip) before flashing? I built the 64-bit binaries (magisk, magiskinit and magiskboot) without building whole zip but not sure about signing part and if these binaries would work or not. I'm almost a layman when it comes to coding and all that stuff. :)
[Magisk] martyfender:
I haven't tried it yet, as it was not out and usually is not by the time I go to bed. (Different time zones.) I will try it and let you know.

UPDATE: I have no parse error on your build, as well. I do however get an lspeed apply on boot root denied error, for some reason with your build. I'm almost certain it is a problem with the app. The author has posted in the general thread concerning Android 9. I however, did not experience this on my 4 other devices with [MENTION=3306843]kantjer[/MENTION] and Canary builds.

UPDATE: The lspeed apply on boot was granted root and applied upon a second reboot.

On recent builds of Magisk, it has seemed that I have needed 2 reboots after updating, for everything to be ok. I'm not sure why.

Thanks
[Magisk] cmo220:
Sorry if this is off topic!

Does anyone know if the latest canary builds have a working Hide Magisk Manager on Pixel 3? The last time I tried, which was a while ago, hiding failed.

Thanks!
[Magisk] jcmm11:
Yes it does. Latest canary is a release candidate.
[Magisk] HamsterHam:
Pixel 3 XL - I am testing more but r30 seems to lose SafetyNet after half an hour sometimes less for me. Back on r29 and it hasn't lost SafetyNet and it has been just over an hour.
[Magisk] kantjer:
I can only suggest to install the latest official canary debug build and post the issue including log in the canary thread
[Magisk] HamsterHam:
Yeah, good idea. Will do that.
[Magisk] kantjer:
Current canary build could be the next stable so now is the time to post any issues
[Magisk] mirfatif:
As per my limited knowledge, Bionic libc and particularly arm64 libc is notorious for such crashes. Isn't it a viable option to build "magisk" binary statically (if there aren't license issues or any other) so that we aren't linking to system's libc?
[Magisk] WizP:
Definitely some issue with the latest build as it intermittently and continuously exposes and then hides the su binary...
[Magisk] hshah:
Same with kantjer's latest build :silly:
[Magisk] radz_:
Confirmed.
[Magisk] kantjer:
Let's hope it will be fixed in the next update
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] With the latest [MENTION=3306843]kantjer[/MENTION] and [MENTION=7187684]ianmacd[/MENTION] builds, I am getting an fc of mm when trying to check the changelog.

Logs attached from [MENTION=7187684]ianmacd[/MENTION] build from today.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] [MENTION=7187684]ianmacd[/MENTION] Uninstalling MM and reverting to MagiskManager-v6.1.1.r3-2018121214.apk and MagiskManager-v6.1.1-2018121201-ianmacd.apk

of course, solved the issue. I could have waited to see if it is fixed in the next version, but since I am a beta tester, why not? That is the only issue I am aware of with the latest releases.
[Magisk] Ubimo:
Magisk Manager fc when clicking on changelog in r4.
[Magisk] hshah:
Oh really... we had no idea :silly:
[Magisk] kantjer:
It's news to me:p
[Magisk] gorilla p:
Just installed latest ianmacd magisk manager 2018121301 and upon opening, repeated FC. Cleared storage and same thing.
[Magisk] ianmacd:
Working fine for me, except for the known changelog crash.
[Magisk] aer0zer0:
[MENTION=3306843]kantjer[/MENTION] r4 mm fc's upon opening, currently on r2. I have attached a log. OP6T, OOS 9.0.7
[Magisk] jenslody:
Is it by any chance installed in external (adoptable) storage ?
[Magisk] gorilla p:
Both people with FC issues are using One plus devices. Both are using OOS.

<--- OnePlus 5T on OB20 (Pie Beta)

---------- Post added at 08:15 AM ---------- Previous post was at 08:13 AM ----------

It is not. It might be an OOS thing. Added logs.

Everything works fine on 2018121201
[Magisk] kantjer:
It seems to be a WebView issue.

It's reported to be working with an older Android WebView build.
[Magisk] gorilla p:
I don't know if it's relevant, but Android System Webview is showing as disabled on my device and is being handled by Chrome.
[Magisk] kantjer:
Yes, changlog is fc if chrome is used, also latest Webview from GPlay is causing the fc
[Magisk] ianmacd:
Reverting bce9cfa39a252dacb392d01787c68b222fbbfa80 fixed the changelog crashes for me in my 2018121501 build.
[Magisk] gorilla p:
2018121501 - I disabled chrome to re-enable standard webview. No FC on this version. No issues with Chrome either.
[Magisk] guest4711:
Working well now with bromite webview, too. The problem was not related to the variant of webview in use I suppose.
[Magisk] aer0zer0:
R5 solves all the problems, thanks [MENTION=3306843]kantjer[/MENTION]

Also, did read you got op6t somewhere.
[Magisk] kantjer:
I reverted the commit [MENTION=7187684]ianmacd[/MENTION] pointed out.

Yes the OP6T is my dd, great phone
[Magisk] martyfender:
Yes, that is normal on Android Nougat and newer.
[Magisk] guest4711:
...but only if g-apps are installed.
[Magisk] gorilla p:
Yeah, some roms have the option to set one or the other. OOS seems to default to Chrome once installed
[Magisk] kantjer:
Fixed in r6, also the dancing changelog issue is now history.

[I]Render Markdown natively
Stop using problematic WebView[/I]
[Magisk] martyfender:
I haven't tested yet, but I believe this may have solved MM crashing when updating modules in the last build.

Thanks
[Magisk] radz_:
Weird, r5 works fine me, now I updated to r6, i got fc'
[Magisk] kantjer:
In r5 a commit was reverted. I also had an fc in r6 but that was theme related
[Magisk] radz_:
I don't have a theme though. I clear data, still the same..

Will check the logs
[Magisk] aer0zer0:
I'm also getting a FC, by theme, do you mean one plus icon pack?
[Magisk] kantjer:
I had to rebuild the substratum theme. No more fc now
[Magisk] aer0zer0:
I'm not using substratum though, just stock OOS. Want a log
[Magisk] martyfender:
MM fc when updating modules, still on r6. upon reboot, the modules appear to be updated properly, though. you see the black module install progress window, but when it gets near the end where one sees, to save log and reboot, it fc.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I just updated the one device I have your build on. I first updated MM, launched it, and no matter what I did, it was stuck on checking or updates, when, though other apps I knew I had an internet connection. MM would crash when I tried to go into it's settings. I then went into app settings and deleted data and cache and relaunched the app, went to its settings and realized that your custom ianmacd channel was no longer there, so I had to enter the url in the manager custom area, like in the past. I wonder if the app crashed because I had had your custom channel set in settings, and when it did not find it, it was stuck?

[MENTION=3306843]kantjer[/MENTION] 's build still has his custom channel there.

It also fc when updating modules from the download area in MM.

Thank You
[Magisk] ianmacd:
Ugh. That's rather embarrassing. I somehow reverted my own customisation of the app, no doubt when reverting a change of John's that conflicted with my customisation.

A second build (02) has just been uploaded to fix this problem. I do hope this one behaves better. I actually had a custom channel configured myself, which is why I didn't notice the issue.
[Magisk] martyfender:
No problem, Ian, that is why I'm here to test builds. It is now working as expected with your update channel.

As far as crashing when updating modules, that was something that was introduced in the commits from last week. I wonder if this is only on my devices, or if others have had this happen. It does not happen on the 2 devices I have the last Canary on.

Logs attached. Does [MENTION=4470081]topjohnwu[/MENTION] read this thread?

As always

Thanks
[Magisk] guest4711:
It happens for me on one of my i9505s too (with [MENTION=7187684]ianmacd[/MENTION]'s builds of the last two weeks). Everything installs fine but then MM fc's.

BTW: No such problem with [MENTION=3306843]kantjer[/MENTION]'s latest build.

BTW2: Happy holidays to everybody and peace on earth...
[Magisk] martyfender:
I have it happen on both builds, strange?
[Magisk] hshah:
I have had the same issue with the last few builds from both... but as its been mentioned, everything still works fine :)
[Magisk] ianmacd:
That's a relief. I thought it was happening only on my builds.

I've spent a couple of hours this morning hunting the bug down. [MENTION=4470081]topjohnwu[/MENTION] introduced it in commit ff3d66a661a00dffc5879c9a67ef080f6ceb483d on 2018-12-13 (Separate backend logic from frontend UI), but it's a very large change, so the offending line or section isn't obvious (especially to a non-Java programmer like me).
[Magisk] ianmacd:
[MENTION=4470081]topjohnwu[/MENTION] has heard us. The end-of-module-installation crash has been fixed today in 75c2cfe7bfda56e19f0062af5da01f0d8b1907e9. Thanks, John!

ianmacd build 2018122414 has the fix.
[Magisk] guest4711:
Ianmacd's build is running on Android N while kantjer's one on P. Perhaps this makes a difference?

---------- Post added at 03:23 PM ---------- Previous post was at 03:21 PM ----------

Confirmed, it's working for me now. Thank you so much and happy holidays!
[Magisk] martyfender:
Confirmed working now.

The bug is also present in last nights latest Canary build, but was fixed with todays most recent build.

Thanks
[Magisk] RagingHarry:
R7 installed properly again and working fully.

R6 mm gave me force closes on opening the app and could not continue on further, on OP6 OOS Beta 9
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I want to point out a very minor issue that has been happening for some time on the 1 device I have your build on.

I am trying to determine if something is different on that device, or if there is something different with your build.

On the other Nextbook Ares 8A's that I have [MENTION=3306843]kantjer[/MENTION] and Canary builds on, I get a notification that a new Magisk Manager update is available.

On your build I do not get a notification even though I get notifications for new updates in the play store. I have checked MM app settings under Android settings and notification settings and they are all set the same on all of the devices.

Do you have any ideas as to what is going on?

Thanks
[Magisk] ianmacd:
I don't, I'm afraid. There's nothing different about my builds with regard to this feature. Whatever it is, it must be external to MM on the device in question.

On a related note, please note that recent builds of Magisk no longer display a pop-up dialogue on opening when a newer version of either MM or Magisk is found to be available.
[Magisk] martyfender:
Yes, I am aware of that, but that is independent of the notification.

Like I said, it is not a big deal as I always check your github page from my desktop, daily for updates.

Thanks
[Magisk] Hemphiz:
Should I stick with magisk 17.4 or upgrade to 18? Alot of people report a few issues with 18. Personally i can't get my system rw lately and I'm thinking it may be magisk as it worked a little while. Also no disrespect to devs work. Was curious is all
[Magisk] guest4711:
If you have a backup of your boot image and know how to use TWRP you can upgrade to latest canary build or to the unofficial builds.

If you are not satisfied or get a bootloop restore the stock (unpatched) boot image and the play can goon (error analysis, disabling all modules, etc. pp.)

On the six devices I installed latest Magisk updating was easy.
[Magisk] Hemphiz:
Well I reverted to 17.4, edited the a modules config for late start script even though I have no clue what it does. Then flashed the rw module and everything is dandy atm. 18 magisk works fine on my other devices, it just this one with dm verity I have issues with
[Magisk] Tornado15550:
The latest build 18.1.r11 causes Magisk to fail repackaging/hiding Magisk Manager. Downgrading Magisk Manager doesn't seem to fix the issue either. Updating a pre-hidden Magisk Manager changes the app name to "Download Proprietary Code". I was able to reproduce this on a Nexus 5 and Pixel 2 XL both running 9.0 Pie. I'll perform a full uninstall and reinstall and report back.
[Magisk] kantjer:
That's a known issue, John is informed about it
[Magisk] Tornado15550:
Rolling back to the previous build and performing a clean flash still doesn't fix the Magisk hide repackaging feature. Does the app automatically download the latest APK when attempting to repackage? Or was this issue also present in the previous build too?
[Magisk] guest4711:
On my i9505 (arm, 32 bit) with pie it was telling me it downloads "proprietary" stuff but it updated the repacked MM without problems to 6.1.1.r11
[Magisk] Tornado15550:
Yep, just make sure you don't uninstall it because you will not be able to hide it again.
[Magisk] kantjer:
I don't know when the issue first started, I saw the first report yesterday.
[Magisk] kantjer:
Try r12, issue should be fixed
[Magisk] guest4711:
Looks ok, thank you.

Have an happy new year!
[Magisk] kantjer:
Happy New year to you all
[Magisk] guest4711:
BTW version 18.1-2018123001-[MENTION=7187684]ianmacd[/MENTION] fixed it, too.
[Magisk] Romaan:
Anyone else having issues where Snapchat is still detecting root even though it is hidden in MagiskHide and the device passes SafetyNet?
[Magisk] guest4711:
Repack MagiskManager... (MM -- Settings)
[Magisk] Tornado15550:
I can confirm that r12 indeed fixes the issue. Thank you! Happy New Year! :)
[Magisk] hshah:
Anyone noticed that with r11 and r12 the Magisk Log is by default at the top and you have to scroll to the bottom to see the new stuff? I swear previously it was at the bottom by default?
[Magisk] martyfender:
I'm not sure I understand what you are saying? In MM? It looks the same to me in MM.

I thought it has always started with the first line? I could be wrong, though. I've usually just clicked on it then quickly saved it.

If I want to view it, I go to the cache folder and open it in a file explorer so it is big enough to read. Could the text size be larger?
[Magisk] jenslody:
I don't know if it was at first or last line before, but it was completely reworked by John, so it might well have changed.
[Magisk] hshah:
In the attached view, by default it's at the top of the log rather than the bottom like it used to be.

Apologies for not explaining it well the first time round :eek:
[Magisk] martyfender:
It looks like the way I usually see it, but I am on 8" tablets always used in lanscape mode.

Do really happen to mean the title bar,

or do you mean the actual text?
[Magisk] hshah:
Third time lucky lol... when you go to that screen it's usually automatically scrolled to the bottom and you can easily see the latest logs. However, now its always at the top so if you want to see the latest entries, you have to scroll all the way down to the bottom.
[Magisk] martyfender:
I never noticed that before, but as I stated, I usually open the log with either Total Commander or Mixplorer from /cache/ as it is too small to easily read in MM, even on my 8" tablets.
[Magisk] neekless:
[MENTION=7187684]ianmacd[/MENTION] magisk manager crashes when downloading it through the 'Update Magisk Manager' button on 2019010201 while trying to update to 2019010401. crash log here https://del.dog/weponosatu.sql

I remember this happening when I was updating to 2019010201 from the previous build too. is it my rom's problem?
[Magisk] martyfender:
Just for reference, I did not have any problems with these builds.

You can try clearing the cache and app data in Android settings, for MM, to see if that solves your problem.
[Magisk] guest4711:
It happens for me too when MM was repacked. Copying the apk from the cache directory of Mm to my Download directory, uninstalling MM and installing the apk solved it for me. Now MM is repacked again. Let's see what the next update brings.
[Magisk] NLBeev:
Download does not finish ... Essential PH-1
[Magisk] ianmacd:
The last 2 builds have presented the same problem on my devices, even when MM has not been repacked. They crash on download of an updated MM package.

Interestingly enough, the download completes in the background, but the resulting manager.apk needs to be moved out of the MM cache directory before it can be installed by the Android Package Manager.

I would assume that the official nightlies have the same issue, assuming John has released any in the last few days.
[Magisk] Mecca EL:
I'm having trouble locating this folder. Is there a link to your git, where I can manually download the apk?

Update: nevermind, I found it. Fixed.
[Magisk] hshah:
Does this not wipe the hide list and su grants?

/Edit: I'm so confused right now... I just uninstalled and reinstalled and it didn't wipe everything. I genuinely have no idea why I always thought it would :eek:
[Magisk] jenslody:
No they are in a database in recent versions.
[Magisk] guest4711:
You may loose your settings for MM, but the modules, the hidelist and the root options are now stored in another directories. (Hidelist and root options have been wiped until Magisk 14 when uninstalling MM, if I remember right.)
[Magisk] martyfender:
No it does not. You just have to go back in and redo only some settings, some are maintained and it doesn't touch your hidelist, su grants and the modules that you previously had.

Mount Namespace mode is retained in settings. If you had a custom update channel you will have to add it again and if you had the setting, like I do: reauthenticate after upgrade, set, you will have to turn it back on

.

If I have a custom update channel set, before wiping data, I open it in settings hold on it until a copy dialog comes up, copy it. Then I delete data, go to Android settings for the app, turn on the storage permission, relaunch the app, go to settings, custom channel and paste the save url in the custom area. The copy and paste saves alot of time for me.

There may be other settings, which I don't use, that may need being set again.

I really appreciate both [MENTION=7187684]ianmacd[/MENTION] and [MENTION=3306843]kantjer[/MENTION] adding there own channels into the build so I don't have to go through the last step of copying and pasting. It is no big deal to do that, but this little extra feature is nice.

I wish [MENTION=4470081]topjohnwu[/MENTION] would do this also in his builds by adding the Canary url in his settings by default, also.

A feature request, John, thanks.

Has anyone had this issue with [MENTION=3306843]kantjer[/MENTION] 's build?
[Magisk] hshah:
Ahh, guess I've not read the change logs properly. My bad :o
[Magisk] martyfender:
It is no big deal, that is one of the many reasons we are all here: to help each other.
[Magisk] martyfender:
Does anyone have any idea if [MENTION=4470081]topjohnwu[/MENTION] is back at the University of Michigan and recovering from jet lag?

I am looking forward to new commits.

Thanks

Never mind, just saw his twitter feed:

Also he pushed a new commit a few hours ago.
[Magisk] habylab:
Any major issues with the recent snapshots? I'm using Canary (non-debug) at the moment and have zero issues, but the updates are only every week or so.
[Magisk] HamsterHam:
Anyone having trouble with hiding magisk manager on r14? I download it but it hangs on hiding the apk.
[Magisk] guest4711:
Yes. I got it working by copying the new manager.apk out of the cache folder of the old hidden MM into download folder, uninstalling the hidden MM, installing manager.apk and repacking the new MM.
[Magisk] HamsterHam:
Thanks but slightly confused. So basically uninstall magisk manager and install it from the zip (extract the apk) and rehide it? Where's the cache folder you are on about?
[Magisk] guest4711:
You will find the new manager in /data/data/random-name-of-the-repacked-mm/cache/manager.apk To keep it for installing via pm you should copy it from there into a folder like /downloads before uninstalling the repacked MM.
[Magisk] HamsterHam:
Nice one. I usually download the zip and extract it from there. This worked well. Cheers.
[Magisk] HamsterHam:
The same issue with hiding magisk manager happens on r15. Wonder why it's happening on the last few releases.
[Magisk] hshah:
Is the issue with hiding it or trying to update with it hidden?

For the last few updates, MM crashes when trying to update. I have to unhide it, update and then rehide it. The flashing part hasn't been an issue though :)
[Magisk] HamsterHam:
That's a good way to do it! Cheers.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] on todays build 2019012001, when I check safety net status, I get: The response is invalid. I cleared the apps data and cache, redownloaded the proprietary code and I get the same response. With the latest Canary and [MENTION=3306843]kantjer[/MENTION] builds it checks ok.

Tried reverting to the 2 previous MM versions, only, deleted data and cache and got the same results.

Then I reflashed v18.1-2019011702 and the check worked fine once again.

Does anyone have any clues as to why this happened?

Thanks
[Magisk] ianmacd:
Odd.

2019012001 successfully queries the server on my devices. The results are false, because I run Xposed, but the response to the query is valid.

I've just released a 2019012101 build with the very latest commits. That, too, successfully queries the server on my devices.
[Magisk] martyfender:
I have the same issue with 2019012101. Reverting to v18.1-2019011901 or older, solves it.

One other thing I tried without success, was to delete the dalvik cache and cache in TWRP.
[Magisk] Francescorm76:
Hello master!.. Other bug... When I active magic hide on one application.. The application crashed

Enviado desde mi SM-N950F mediante Tapatalk
[Magisk] ianmacd:
What model of device is this happening on?

Is anyone else seeing this?

I don't see anything in the commits of 20th January that would explain this, so I'm stumped at the moment.

---------- Post added at 09:38 ---------- Previous post was at 09:33 ----------

I can't reproduce this here, either, on my 2019012101 build. Is that the one you're using?

Which model of device exhibits this behaviour?
[Magisk] Francescorm76:
My model is note 8f with oreo and I use magisk 2019012101

Enviado desde mi SM-N950F mediante Tapatalk

---------- Post added at 09:00 AM ---------- Previous post was at 08:58 AM ----------

With magisk v18.1-2019011702 work very well

Enviado desde mi SM-N950F mediante Tapatalk
[Magisk] WizP:
I'm also seeing this with a Note 8, this time on both orea and pie.

Maybe it's an issue with Samsung devices?

For me the su binary is exposed in /sbin/ and root is detected.
[Magisk] daywalk3r666:
same here with newest kantjer build.safety net api error

my devices are running on oreo and pie