yashsingh1/xdaforums huggingface dataset:
[Magisk] teddy0209:
Not just your device... That just means its not yet ready... ???
[Magisk] DodoGTA:
I made a build of Magisk with the most recent commit from [MENTION=4470081]topjohnwu[/MENTION] (Downloads are attached to this post)
[Magisk] teddy0209:
How about the manager? Has it receive enough update to properly support v13?...
[Magisk] DodoGTA:
Almost yes
[Magisk] teddy0209:
If he's working on manager now, then it might be closing to final stages... ???
[Magisk] Mezabaru:
I tried the posted build manager works but modules did not. It's getting closer our chief is making solid progress. I'm getting super excited to see how it works when official is out.
[Magisk] DodoGTA:
Why they don't work?
[Magisk] android_htc:
Not sure how The Flash made it work... but as reported previously the /magisk folder is empty as the files are not being copied for some reason
[Magisk] wrongway213:
You guys having issues should all really check GitHub a little more carefully.. :p

Thanks [MENTION=2226076]stangri[/MENTION]!
[Magisk] DodoGTA:
[MENTION=4667597]Didgeridoohan[/MENTION] [MENTION=2226076]stangri[/MENTION] I built Magisk and Magisk Manager again with the latest commits by [MENTION=4470081]topjohnwu[/MENTION]

Downloads: https://github.com/TheComputerGuy96/MagiskFiles/releases/tag/20170513
[Magisk] Didgeridoohan:
For me it has.
[Magisk] foxhroma:
what about multirom in magisk 10?
[Magisk] mrxtc89117:
Safetynet does not pass for me on V10 and MagiskHide. On an unrooted Resurrection Remix 6.0.1 ver 5.7.4 on and LS990 LG G3 it passes Safetynet.
[Magisk] Captain_Throwback:
Works fine on my HTC 10 running Magisk version of Viper ROM with the latest Magisk zip from this thread.
[Magisk] JEANRIVERA:
I haven't lost root since I updated the Magisk manager app with the one provided by [MENTION=2401586]jsaxon2[/MENTION] in the last 36 hours it worth mentioning that I am also running magisk v10 provided here i have talked to topjohnwu about it and he confirmed me that he has identified the issue and that an official update should be out soon
[Magisk] mrxtc89117:
I redid the installation and now it works and passes safetynet. Still too early to tell if I will lose root, but will let you know.
[Magisk] JEANRIVERA:
[MENTION=2226076]stangri[/MENTION] or [MENTION=2401586]jsaxon2[/MENTION] any plans on building with todays commits that fix loosing root issues?
[Magisk] Captain_Throwback:
FYI - It's not fixed (completely) yet...
[Magisk] mrxtc89117:
Is there an uninstaller for v10?
[Magisk] Captain_Throwback:
Does the uninstaller from the Magisk thread not work?
[Magisk] mrxtc89117:
I have not tried. I was just wondering just in case. However, it works just fine now.
[Magisk] stangri:
Hey Cap, any idea why the Magisk Manager builds from CLI might result in crash on start while apk built from within Studio GUI works fine? Started happening on 26th, the apk I built on 23rd was built from CLI just fine.

Really don't have time to investigate via adb, wondering if you might know something.
[Magisk] Captain_Throwback:
I've never built Magisk Manager, so I have no idea.
[Magisk] A_Random_Guy:
Both APK of Magisk 2.6 crashed for me at the start

RR N 7.1.1 Xiaomi Redmi Note 3
[Magisk] Berik84:
the uninstaller didn't work for me
[Magisk] stangri:
I've successfully used the latest official uninstaller with 161223 and 161226 builds.
[Magisk] Kal-El7:
How come no one answered this? =)
[Magisk] Didgeridoohan:
Since topjohnwu has stated he hasn't had much time to work on multirom support (see the announcement thread, always a good place to look for info) and there hasn't been a multirom commit since Oct 30, I'm gonna say: no.

Because... :D
[Magisk] mrxtc89117:
What does this mean on my log?
[Magisk] mucha.k1994:
Hi, someone who know how to do it - some1 can compile new magisk zip? In repo topjohnwu is new note what says he fix a problem with root lossing state. So if someone can do that, we wait :)

Or? Simple instruction howto compile on windows? I have ndk, jre 8 etc.
[Magisk] bountyman334:
Thanks...i see the manger doesn't say what version am using.. Is that normal? Or part of the update
[Magisk] DodoGTA:
Can you post a screenshot?
[Magisk] culiacanazo:
What happened to good old busybox? :crying:
[Magisk] teddy0209:
That option was removed... ?
[Magisk] culiacanazo:
Honestly I don't know how to read that page, and it took me years to figure out how to download stuff from there

Why? :eek:
[Magisk] DodoGTA:
https://github.com/topjohnwu/MagiskManager/commit/e272dbe9af2685f7f9b7ca59955ed7f63003bff1
[Magisk] DodoGTA:
Because busybox is automatically installed
[Magisk] Artim_96:
So only the toggle was removed? Ok, then I hope that means that the problem with LOS ROMs loosing root with Magisk busybox is fixed. Already thought it was completely removed because of too many problems
[Magisk] culiacanazo:
Nope, not only the toggle. I had never had any problems. Well back to Stephen's

Not contradicting your knowledge but some of my apps saying otherwise :(

That was the only part i understood
[Magisk] Artim_96:
Well, I guessed because it says "lnclude busybox binary and remove busybox toggle". But the comment suggests that the problem still it's not fixed
[Magisk] culiacanazo:
Nope, i was wrong, he was right. My bad

Edit: it's because jrummys toolbox was asking for busybox and then adaway didn't do its thing but (since i reinstalled magisk) i hadnt granted adaway access, and i checked with sd maid, so that's two against rummy, idk! But busybox i do have
[Magisk] DodoGTA:
Try to run "ls -l /data/data/com.topjohnwu.magisk/busybox" in a terminal with root access and say if you see files in that directory

Edit: Try to run "echo $PATH|grep busybox" in a terminal and say if you see some output after running that command
[Magisk] ajaxcbcb:
Viper4arise module is broken as well on the latest v13 manager and magisk binary
[Magisk] culiacanazo:
Just updating in case anyone wants to go through this again, there's no need:

ROM Toolbox works (so I'm assuming any that might not detect it do as well).

•I know what a lot of you think about that app, lol it's just convenient for a couple of things for me

•That's what happens when i speak too soon, that's why i hardly ever do

•thank you all for your replies

•peace out
[Magisk] chikimonke:
Are you in the Magisk Module testing Telegram group?
[Magisk] Mecca EL:
Link?
[Magisk] chikimonke:
It's the Telegram group for the Arise Magisk Module. It's a small group, and not mine to invite to. Sorry
[Magisk] wrongway213:
This is not the case, at least not for ARISE installations - in fact, I just tested the newest ARISE build available with the Magisk Compatibility module on the 0512 Snapshot and 0512 Magisk Manager, and every single effect is procesing, as seen via dumpsys output in terminal. Everything audio related, via ARISE, anyway, works 100% on this release - just want to make sure others don't avoid this because of reading this comment, as I have confirmed it not to be the case.
[Magisk] android_htc:
Getting SafetyNET to pass now :)
[Magisk] Artim_96:
Wow... How? And which ROM?
[Magisk] Spazturtle:
Installed MagiskManager-v5.0-170512.apk and Magisk-v13-170512.zip to test and found that USB audio support is broken when they are installed, works fine on Magisk v12.
[Magisk] ajaxcbcb:
Where do I find this particular module?

I've just uploaded my screenshots. I have installed the modules but the status still appears abnormal
[Magisk] wrongway213:
As I said, ARISE installations work - I don't claim to support other mods or know if they work or not at any point, but our V4A in ARISE works fine.
[Magisk] teddy0209:
You have multiple V4A mods... The one ported by johnwu has its own app (download it, click on the module from the download section of magisk manager)...

Edit: or maybe just use the v12... Until v13 is released...
[Magisk] ajaxcbcb:
Found the solution to be due to selinux enforcing. Changed it to permissive and it works
[Magisk] bountyman334:
Sorry so late.. Here's the screenie..agajn.. Am using lg v20 deoxeded
[Magisk] DodoGTA:
I see nothing wrong in your screenshot
[Magisk] bountyman334:
It wasnt nothing wrong...it didn't show what version i was on like this
[Magisk] DodoGTA:
If Magisk is showing as installed and it's working, then there's no problem
[Magisk] bountyman334:
Gotcha...i never said it was a problem..i just was wondering if the latest commits from github removed the date from the manager ..
[Magisk] teddy0209:
Does anyone have an idea how to manually enable magiskhide on the new v13?...

It doesn't properly start on MIUI, so I had to manually enable it via terminal or include su -c fix on the enable script... Magiskhide has change on the new version, and I have no idea how to enable it now... tried magiskhide --enable in terminal, did not work... If anyone has an idea that I can try... Thanks!!!
[Magisk] DodoGTA:
Try to run:

su -c "magiskhide --enable"
[Magisk] teddy0209:
Okay, thanks! Will install v13 again tomorrow to try this... ?
[Magisk] DodoGTA:
Which apps don't work with MagiskSU? And, how do they behave with MagiskSU?
[Magisk] swa100:
https://xdaforums.com/android/apps-games/root-battery-charge-limit-t3557002. Wiping the battery stats (clear battery graph) doesn't work with magiskSU, while it does with SuperSU.
[Magisk] topjohnwu:
I'm really glad that many people are interested in the recent development on Magisk :D:D

Here are some info in the main thread you might find interesting, hopefully it would solve many questions in your minds

Recent Updates
[Magisk] Didgeridoohan:
Like I believe I said earlier... You'll most likely need to ask the apps developer to add support for MagiskSU. Or, just give the v13 snapshot a go and see if it works...
[Magisk] stangri:
Can you please publish the updated template *before* you release the new magisk/magisk manager? With busybox now being an option update-binary will sure change and it might dramatically affect developers of the more complex modules.
[Magisk] teddy0209:
[MENTION=6429309]DodoGTA[/MENTION] It didn't work...

Anymore suggestions on manually activating magiskhide on latest v13 guys?
[Magisk] 13680201:
HI. Install magsik manager v512

Install magsik.zip v512 from twrp success

After reboot, enable and contact to wifi . And open magsik manager, oh install magsik, ,coler silver

فرستاده شده از SM-T805ِ من با Tapatalk
[Magisk] 13680201:
فرستاده شده از SM-T805ِ من با Tapatalk
[Magisk] teddy0209:
Oh... It was installed... Try the 0513 version posted a few pages back, it should be green again...
[Magisk] swa100:
Is magisk v13 compatible with Android O dp?
[Magisk] DEVILOPS 007:
I tried v13 but it caused my phone to be stuck at the boot logo. Did I miss something?
[Magisk] DodoGTA:
Maybe
[Magisk] Sytis:
What phone, what OS, what else did you flash, how did you install it, etc. Do you think we all are magic wizards who know everything? A bit more information would be great.
[Magisk] DEVILOPS 007:
Well basically I flashed the v12 uninstaller to get rid of v12 then flash v13. That was basically it. Im using a nexus 6p on 7.1.2
[Magisk] Sytis:
Maybe try different versions as some are causing problems (read back a few posts to decide for yourself) or grab a log and share it with topjohnwu, maybe he can fix it if it is caused by magisk in this specific setup. And always make some backups when flashing experimental snapshots ;)
[Magisk] kantjer:
I always flash Magisk update together with a dirty ROM flash, never failed for me.
[Magisk] DEVILOPS 007:
I tried that aswell and still had the problem.
[Magisk] DodoGTA:
Then reflash the latest 7.1.2 factory image
[Magisk] Telperion:
Magisk-v13-170512 also freezes for me on boot, had to reflash my boot image. Such is the nature of unofficial builds.

What's the latest v13 build that is working for someone? I'd like to flash that version to give it a try.
[Magisk] Artim_96:
Most likely. Just read the official release thread. It's most likely already built into the beta but will definitely be with official v13

---------- Post added at 10:14 PM ---------- Previous post was at 10:13 PM ----------

V170415 is the one working for the most.
[Magisk] kantjer:
v13-170512 is working fine for me
[Magisk] jsaxon2:
You may have some magisk modules installed that are not yet compatible with the latest version. You could try running the magisk uninstaller zip fist and then try the 170512 version. I currently don't have any modules installed and it is working for me. Might be worth a shot...
[Magisk] Telperion:
No modules active at the moment. Huawei device support is spotty due to their poor development practices. All versions after 11.1 break the fingerprint sensor on my Honor 8, which I'm sure is Huawei's fault. He'd said in the update that pre-13 is so different he's not kept up with Github issues so I'll hold off and put on a request.

[MENTION=5125527]Artim_96[/MENTION] V170415 boots for me but same fingerprint issue, looks like I might need to submit on Github after all.

Looks like Magisk hide is the culprit: https://github.com/topjohnwu/Magisk/issues/188
[Magisk] pandavova:
Hey guys, i have Magisk v12 170328 + the Manager v5.0 170304 apk... This combo cause of compatibility... Im getting now a with the Xposed Module a CTR Mismatch. When i deactivate it and restart my device its green again... Is Xposed even working with SafteyNet?
[Magisk] Artim_96:
1. No

2. Completely wrong thread
[Magisk] pandavova:
1. Sorry

2. Is there a possibility to get it work?
[Magisk] Artim_96:
I said wrong thread. So no help here.

But don't get your hope too high, it's probably more likely to get struck by lightning
[Magisk] dnle71:
Is there a plan for ui overhaul for v5? The front page card sizes are just too big. Perhaps you could size it down and put more info somewhere the available space?

Thanks for the great work!
[Magisk] Didgeridoohan:
It's not a bad idea, but not really the place for feature requests... Open an issue on GitHub and put "Feature request" in the title.
[Magisk] dnle71:
Oh, right! I'm so sorry about that. It's just a food for thought and I don't think that putting it on github will be picked up on knowing that v5 is still on a development phase where bugs and fixes are a priority?

Thanks for the acknowledgement though!
[Magisk] Captain_Throwback:
The size of the cards really depends on your device's resolution. And what "more info" do you think should be there? That page is explicitly for "Status" so that's what you see there.
[Magisk] RogerF81:
After flashing latest v13 build, my HTC 10 doesn't boot up any more. After simply re-flashing v12, it normally boots again.
[Magisk] Artim_96:
Try version 170415
[Magisk] onesolo:
Does this magisk version works on the new O preview ?!
[Magisk] nathanchance:
Why don't you give it a shot and let everyone know? Make a backup of your boot image and TWRP and if something goes wrong, restore it.
[Magisk] Artim_96:
Try it. If it doesn't the will probably an update soon since topjohnwu now has a Nexus 5X
[Magisk] dnle71:
For one, the check logo is taking all the card space. Perhaps you can make it smaller and move it on the left side and put details on the right. If there's extra space under that page, you can maybe put a recommended modules section?

Anyway, it's your decision and I'm just making suggestion.
[Magisk] 13680201:
HI.

Install update magsik manager v517

After

Install magsik.zip v517 from twrp

Oh oh

Failed to boot and will remain on the logo Tablet

Whin When the power button and keep the home in the same mode. Boot Android

Why ? How solve the problem?

فرستاده شده از SM-T805ِ من با Tapatalk
[Magisk] bmg1001:
Magisk v13 works fine on Android O DP2 on a Nexus 6P.
[Magisk] Sytis:
Honestly I'm not sure if you're just trolling or ignorant af. You ask the same things over and over again and never answer again just to complain in bad english a few days later again. If you would just read what the others on this thread are writing instead of repeating it, then maybe you would have come to an answer to your problem already. I don't really want to criticize you, but you don't seem like a user to me, who suits testing experimental snapshots. Sorry if I was a bit harsh, but this user in particular is bugging me since his first post.
[Magisk] Ubimo:
Latest Magisk-v13-170517.zip is somehow working on S7 edge with SuperMan ROM 2.5

Root apps are granted root privileges, but I see some errors in Magisk log. (magisk startup log)

Edit:

I see there was also a file cleanup here: https://github.com/stangri/MagiskFiles
[Magisk] teddy0209:
Restore your boot.img, reflash the previously working version of magisk, that's it...
[Magisk] dahawthorne:
I hear that... :)

I wonder if it has anything to do with his device? "I have a tablet sumsung sm- T805 whit android 5.01"

Me, I can't get Magisk to install on my Nexus 10, and I accept that, since the FAQs say that not all devices are supported and that if you want it to work on your device you need to post your boot image on Github. Since my N10 is old, I'm not going to waste stangri's or topjonwu's time by adding to their workload, and I'm certainly not going to waste everybody else's by posting "I can't get it to work" over and over again.
[Magisk] teddy0209:
But according to him, what I understand is it's working until he updated... Lol..., Though I'm not so sure, I just reconstructed his statements...
[Magisk] dahawthorne:
Nah, I just read through all his posts - didn't take long, there are only 14. Every single one says "Installed, problem, how fix?"

I agree entirely with [MENTION=6493997]Sytis[/MENTION], having seen far too many people trolling in various threads, apparently with little genuine interest in following advice but more interested in seeing their name in print. As Sytis rightly says, if this user is so inexperienced and unable to follow simple instructions, what's he doing in a development thread?
[Magisk] radaloel:
I flashed it via TWRP and SU works fine but opening the Magisk manager says Magisk is not installed and asks me to install v12. How did u work it out?
[Magisk] dahawthorne:
Do you mean MagiskSU or SuperSU? And are you using the Manager v5? I'm only guessing, but if Manager v4.3.3 doesn't know about Magisk v13 then it might not "see" it and therefore recommend v12.
[Magisk] chikimonke:
I've got the 0517 manager and Magisk installed, and everything seems to work except one thing. In Magisk Manager the top card says it can't check for an update because there's no internet connection. I clearly have one so I'm guessing there's something a little messed up.
[Magisk] dahawthorne:
Firewall? I've done that myself lots of times, forgotten to grant access after installing... :)
[Magisk] chikimonke:
Nope, no firewall. Don't have anything like that installed. I do have adblock, though currently it's not active and it worked fine before anyway. I was using the 0513 build somebody had posted in here and that one worked fine. I do still pass SafetyNet though.
[Magisk] android_htc:
Could you please post Magisk log
[Magisk] kantjer:
No sure if it a coincidence but I had the same issue when using a recent Magik Manager from the OP github

I now build Magisk Manager from source and never had the issue again.
[Magisk] chikimonke:
Magisk and just a catlog from opening and refreshing Magisk manager.http://cloud.tapatalk.com/s/591d9d1a906be/magisk_error_20170518_060659.log

http://cloud.tapatalk.com/s/591d9d3296d44/2017-05-18-06-05-01.txt

---------- Post added at 06:11 AM ---------- Previous post was at 06:10 AM ----------

The 0513 build was someone's personal build too, maybe there's something to that?
[Magisk] kantjer:
in the version from the OP the CheckUpdates.java is changed to check for the snapshot build

$repl_command "s|topjohnwu/MagiskManager|stangri/MagiskFiles/master|" MagiskManager/app/src/main/java/com/topjohnwu/magisk/asyncs/CheckUpdates.java

I keep that unchanged, result is that the update check doesn't work for the Magisk snapshot but the check is "green"
[Magisk] chikimonke:
Sounds to me that's it's broken in both cases then. In the current OP build it's looking for snapshots, but can't find them. In yours it's technically looking for official builds, which also isn't correct if you're running a snapshot. As long as everything else still functions, it's not a big deal for now.
[Magisk] kantjer:
I don't care about update notification so I never bothered to look at it

EDIT:

Checked the source and found the OP's Magic Manager is pointing to the incorrect magisk_update.json path (should be " updates/magisk_update.json" )

I fixed that in my build but that didn't solve the "no internet" issue. Also noticed in the original magisk_update.json "version" is added, that's missing in the OP's version. Not sure if that's the problem.

This fixed the path issue:

sed -i "s|topjohnwu/MagiskManager[COLOR="Red"]/update/[/COLOR]|stangri/MagiskFiles/master[COLOR="red"]/updates/[/COLOR]|" app/src/main/java/com/topjohnwu/magisk/asyncs/CheckUpdates.java
[Magisk] android_htc:
There are a few errors for me as well; Magisk hide needs to be toggled after first install and after a restart. However, the modules are still broken and do not install for me.
[Magisk] teddy0209:
Don't worry you're not the only one... Happened to me as well when I tested it...
[Magisk] stangri:
Thanks man, I've fixed the replacement in the build script and the updated files will be pushed to github shortly.
[Magisk] swa100:
Safetynet won't pass on the last beta build (from today) with build number (OPP2.170420.19). More people have this problem? Is this a known issue?

edit: while it did on the first dp2 build

Edit 2: seems that even stock dp2 OPP2.170420.19 does not even pass safetynet check:

https://www.reddit.com/r/AndroidPre...ll_ota_received_over_the_beta_factory_images/ so t should have nothing to do with magisk v13!

---------- Post added at 10:33 AM ---------- Previous post was at 09:40 AM ----------

Also, sysdump command does not seem to be working. ('sysdump batterystats --reset' gives error). It does work with SuperSU
[Magisk] Artim_96:
At least you are the first one reporting about that. But if topjohnwu had the same problem he will sure find a fix
[Magisk] swa100:
The safetynet problems seems to be related to the latest dp2 build (019). Even stock users won't pass safetynet.

So the only problem left is the dumpsys error.
[Magisk] bmg1001:
Yeah, I was going crazy yesterday, did 5 clean flashes, including locking the bootloader on one flash, and nothing worked. Most likely not a Magisk issue. 6P here on O (0.19 or whatever)
[Magisk] bmg1001:
SafetyNet got updated. Android Pay should work now. Android Pay is now fully functioning on my Nexus 6P with Magisk v13.
[Magisk] chikimonke:
[MENTION=2226076]stangri[/MENTION] Is there an updated uninstaller? If not, should we just use the "stable" uninstaller?
[Magisk] swa100:
Does anyone know why the dumpsys command doesn't work with magisk? Command: dumpsys batterystats--reset , results in error in terminal. Would love to be able to reset the battery graph manually again.
[Magisk] Captain_Throwback:
What does dumpsys have to do with Magisk?
[Magisk] swa100:
Well, it works on SuperSU, but it doesn't on magiskSU. Don't know why.. see: https://xdaforums.com/android/apps-games/root-battery-charge-limit-t3557002/page66

To be clear, it doesn't work on any terminal on the device, tried multiple. Don't know about adb she'll though.

Edit; got it working on my old n5 running darkrom with magisk. So I don't know why it won't work on my 6p after flashing magisk. Really clueless here.

Problem seems to happen more often on more versions of magisk: https://xdaforums.com/showpost.php?p=69260286&postcount=612

Edit 2: another case of failing dumpsys command with magisk, but working again after flashing super su: Magisk and DUMPSYS root commands.

https://www.reddit.com/r/tasker/comments/69ulrk/magisk_and_dumpsys_root_commands/

And:

https://www.reddit.com/r/cyanogenmod/comments/441bkb/dumpsys_working_on_adb_not_on_device/

Hope this helps.
[Magisk] stangri:
Thanks for the reminder/suggestion, from May 19th build forward the uninstaller will be rebuilt every time Magisk is built.
[Magisk] kantjer:
I fixed the update check, will make a pull request when I'm back home later