yashsingh1/xdaforums huggingface dataset:
[Magisk] ianmacd:
I don't think I've used --init with update since I set up my tree.

I moved to using this a while back:

$ git submodule update --remote --recursive

I found I needed --remote when John would update the submodules, but not immediately fold them back into the supermodule. If I didn't use that, my build wouldn't pick up the changes to the submodules, while git status on the supermodule would report that everything was up to date.

Now the Magisk Manager app is no longer a submodule, this isn't such a big issue any more; and now it turns out that --remote doesn't play well with the Busybox submodule, because it doesn't have an origin/master branch.

I don't know; maybe it's me, but I find the implementation of submodules in git to be less than intuitive. Intuitiveness is a necessarily subjective concept, of course, but there are much more complex aspects of git that I make fewer mistakes with than submodules.

Anyway, not a big deal. Thanks for your tip. I'll move to using that until I trip over something new. :)

---------- Post added at 18:32 ---------- Previous post was at 18:31 ----------

Yes, indeed. It seems that I struggle with the difficult concept of incremental dates, too.
[Magisk] kantjer:
Same for me, that's why I revered to using a manifest so I can do a familiar repo sync.
[Magisk] martyfender:
deleted

---------- Post added at 02:02 AM ---------- Previous post was at 02:01 AM ----------

In recent builds, for quite a while, has anybody else had issues with module installs through the direct download or through the add module modes in MM? I use the following, most recent versions: osmosis Busybox for Android NDK, Sysconfig Patcher, Greenify4Magisk and Magisk Hide Props Config. I also had fails in TWRP, but success in the add module, with Magisk Hide Props Config, I believe.

Osmosis new version of Busybox, an update to his 1.29.2, fixes an issue when using Magisk Hide Props Config on x86 devices, (not certain if it affects other architectures) where the download of the mod's internal Busybox would fail, therefore, the module would fail if Busybox did not already exist in the module folder.
[Magisk] mkdante381:
Safety Net fail also without root. Google server problem?
[Magisk] Ferbee:
Yeh it's down atm
[Magisk] guest4711:
No, a change to the API. Google announced that after August, 1rst the old way for checking safety net will not be usable anymore. But a lot of tools (including MagistManager) did not change to the new requirements...

So look for updated safety net checkprograms, they should work.
[Magisk] martyfender:
Thanks to [MENTION=8445868]mkdante381[/MENTION] posted over in the Magisk Beta thread:

Here is one that works right now, scroll way down on the page and enroll in the beta. It may take a few minutes for the enrollment to take affect.

https://play.google.com/store/apps/details?id=org.freeandroidtools.root_checker
[Magisk] DenyDarko:
https://mobile.twitter.com/topjohnwu/status/1029239685338419200
[Magisk] martyfender:
I just saw this on topjohnwu's Twitter feed:

It looks like it will be a little while before we see any new commits.
[Magisk] RealAkito:
Can anyone tell me the difference of both Official Stable Beta and iammacd version...

---------- Post added at 13:44 ---------- Previous post was at 13:44 ----------

and can i use it on ARM phone?
[Magisk] guest4711:
The unofficial builds are almost daily builds. That means they are compiled from the current sources (bleeding edge) and should work but they are not tested in all details. The official betas are tested a bit more and are semi-stable (frozen for some weeks).

Issues in current betas are worked on in the unofficial, so these may work better for you than the officials. But new problems may occur...

And yes, you may use them on ARM devices.
[Magisk] RealAkito:
Thank you
[Magisk] :
Guys, which build can you recommended actually?
[Magisk] martyfender:
The latest is working great for me.
[Magisk] :
The latest from kantjer?

I have looked in your signature.
[Magisk] SpectraFun:
is there a new link? This not work https://github.com/kantjer/MagiskFiles/raw/master/ ?
[Magisk] Didgeridoohan:
https://github.com/kantjer/MagiskFiles
[Magisk] SpectraFun:
last is 8 day old?
[Magisk] Didgeridoohan:
Yes. Since [MENTION=4470081]topjohnwu[/MENTION] has been moving halfway across the world, there hasn't been much activity for the past week. That'll change now...
[Magisk] 587.saboor:
NOTICE TO ALL A8(+) USERS

MAGISK THAT WORKS FOR YOUR DEVICE IS ONLY THIS ONE BECAUSE NORMAL MAGISK HAS BASEBAND PROBLEMS

Here are commits of the magisk hexpatch (for devs lel)

https://github.com/breakersvd/Magisk/commit/951db6c3249483ed6155a5d4375b7e4254d8276c

https://github.com/breakersvd/Magisk/commit/82e29516d29943094c10e643edbef9bae2bd634e

Download 16.73:

https://mega.nz/#!nJZzWY7R!aXjEWqzr_TeZQIz8QPsI6dAy9GuAd6tY8sjZ1-IkN30

Custom URL for unstable build from [MENTION=7187684]ianmacd[/MENTION]:

https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json

Credits to breakersvd (from github) and [MENTION=7187684]ianmacd[/MENTION] for unstable builds
[Magisk] ianmacd:
My new v16.8-2018082201 build also contains this patch (amongst many other new commits), although I've read the pull request and have my doubts whether the fix as given would also work for a stock kernel. That may be why John hasn't merged it yet, even after clearing all of the other queued pull requests.

Anyway, if it doesn't work, it will have no effect at all, so including it is benign.
[Magisk] DenyDarko:
[MENTION=4470081]topjohnwu[/MENTION] enabled safetynet for hidden Magisk Manager using the new API, however something's probably still missing as it doesn't work as expected.
[Magisk] Didgeridoohan:
Works fine here. You might have to redownload the snet.apk. Clear data for the Manager and try again.
[Magisk] DenyDarko:
I'm stupid, I haven't performed the most basic thing before posting. xD

Well... :silly:
[Magisk] -Duir-:
I tried to install this and after completing my device reboots into recovery.

The recovery log (which shows no error) and patched boot.img can be downloaded here (too large to attach).

-EDIT-

Forgot to mention, after flashing the uninstaller the device boots fine and that "official" stable/beta releases flash and boot fine as well.
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=3306843]kantjer[/MENTION] [MENTION=7187684]ianmacd[/MENTION] On the latest builds I keep getting a safetynet api error. I have tried deleting data and cache of the app, re-enabling storage permissions deleting the snet.apk and dex files to let it redownload and I still get that error. As far as I can tell, the magisk.log looks normal. Does anybody have any suggestions? The safetynet attest app shows passing safetynet and the playstore shows the device as certified.

Thanks

EDIT: On a device with a good internet connection, with the [MENTION=7187684]ianmacd[/MENTION] build, when I a try to check safetynet it brings up the box to download the code, but never downloads it as seen by the empty snet folder in /data/data/com.topjohnwu.magisk/snet. On multiple tries, it pops up the box to download the code, but never does.

On the 2 devices I have installed the [MENTION=289782]kanjer[/MENTION] build, it does download the code, on check, but fails with the safetynet api error.
[Magisk] Paschfire:
Had you searched a little within this the Unofficial Magisk thread, or even within the Official thread, you'd already know this is a known issue and will be solved in the next Magisk release.

topjohnwu just moved to a new city, so once his life is in order and he has settled in, he will start working on bringing an update to Magisk.

You should follow topjohnwu on twitter as he has discussed all of this there in greater detail.

https://mobile.twitter.com/topjohnwu

**EDIT**

I must apologize as this page didn't update before I responded, I wasn't aware there had been a more recent releases of Magisk.

Just getting used to people reporting the safety net check error without looking for the answer as to why, I jumped the gun on this one.
[Magisk] kantjer:
All I can say is that it works for me.
[Magisk] buffal0b1ll:
Kantjer 08222018 passing safetynet on Pixel 2 and Nexus 5x here.

I did have to clear app data twice. The first time I cleared data and reaccepted the FOSS safety net API dowload I got "safety net invalid API" on both devices. Clearing app data again and re-reaccepting the FOSS safety net API download a second time did the trick.
[Magisk] mkdante381:
Good job. After updating to latest unofficial, magisk deleting stockboot backup and all modules. AOSP EXTENDED SM-G900F. After clean install magisk, safety net not passed in magisk manager
[Magisk] martyfender:
Thanks, that worked for me on the one device I have with me.

I wonder why clearing data twice worked as opposed to once.

Also, when I did it before, I also force closed the app, before deleting the data once.
[Magisk] 587.saboor:
It works
[Magisk] bggold:
Confirmed safetynet check fix works.

Pixel 2 xl flash kernel pie
[Magisk] neekless:
[MENTION=7187684]ianmacd[/MENTION] I can't download the safetynet code on your latest build. it never downloads anything and I can only see a "safetynet api error" everytime I try. Cleared data multiple times but it didn't help. Do you experience this? On an unrelated and insignificant note, your latest manager version is "null" instead of a number.

Edit: I even completely uninstalled manager and reinstalled it but it still doesn't download the safetynet code.

Edit 2: I found the problem. [MENTION=4470081]topjohnwu[/MENTION] removed the snet url in the update snet extension commit. you now have to add it into the update channel json. [MENTION=3306843]kantjer[/MENTION] has it in their json, so does topjohnwu.
[Magisk] martyfender:
I am not sure about the above, but Ian's worked for me after I deleted data and cache in settings, app, Magisk Manager.
[Magisk] neekless:
Are you sure you're on ian's build and not kantjer's? Because from the code it seems like the only place it can get the url to download snet.apk is from the update channel json, where ian's doesn't include the snet.apk url but kantjer's does. (Or maybe you already had snet.apk from kantjer's build before changing to ian's build and somehow clearing data didn't remove snet.apk? idk)
[Magisk] martyfender:
On my 4 Nextbook Ares 8A's, x86, Android 6.0.1 devices, the safetynet check worked after I deleted cache and data in app settings, for some devices it was required to do this twice, or some, only once. The one thing I did change here in this process, was that I did not stop the app first in the app settings. I am still not sure why all of this was required, but maybe, someone more knowledgeable will reply..

All I know is that the safetynet check is working again for me on all of my devices and more importantly, passing.

---------- Post added at 11:45 PM ---------- Previous post was at 11:37 PM ----------

Yes, I am sure, as I have kept that one device on Ian's channel for some time just to test his builds versus kantjer's builds. I have 3 devices on kantjers builds and 1 on Ian's builds. The 4 devices are virtually the same.
[Magisk] neekless:
Can you try again on ian's build? Try deleting all/any snet.apk from your device and try checking safetynet again.

Because based on multiple lines from this commit I'm very sure john moved the url of snet.apk to the update channel json. This fails on ian's build (for me) because his json doesn't have the snet url.
[Magisk] martyfender:
Yes, on the device with ianmacd's build, I deleted /data/data/com.topjohnwu.magisk/snet/snet.apk and snet.dex. I then downloaded the proprietary files and it passed safetynet. That was the only directory the file was found in a Total Commander search. It was failing to download for me also until I deleted cache and data in app settings. don't stop the app first. Give storage permissions.
[Magisk] neekless:
I think I know how it worked for you. After clearing cache and data in app settings, you opened the app and tapped the safetynet check and it downloaded the proprietary files, am I right? I think you did this before putting in ianmacd's custom update channel, correct?

Can you repeat the steps but BEFORE you tap to download the proprietary files, put in ian's custom update channel first. THEN, try to download the safetynet files. I think it won't work then.
[Magisk] martyfender:
Actually, I thought you were wrong, but as it turns out you are correct. I duplicated that twice to confirm. On my other three tablets with [MENTION=3306843]kantjer[/MENTION] 's build, I am not sure in what order I did that. I had thought though that I had set the update channel first on all 4 tablets. I must have been wrong.

So it appears that on ian's build when the update channel is not set, it is downloading the code directly from Google, as I believe it should be doing. Maybe the other builds have it in there as a safety fallback? I am just speculating at this point. I hope someone more knowledgeable will clarify this.

I wonder if it is a case of all of the recursive changes not being in his build.

A possible clue was what kantjer posted a few days back about recursive. I don't have the exact quote without a search.

I hope [MENTION=3306843]kantjer[/MENTION], [MENTION=7187684]ianmacd[/MENTION], or [MENTION=4470081]topjohnwu[/MENTION] will clarify.

Thanks
[Magisk] neekless:
It's not the recursive changes, and it's not downloading directly from google. My original post was correct. If you clear app data, you clear away the custom update channel. By default you go into topjohnwu's stable channel.

Like I mentioned in my original post, topjohnwu's jsons have the snet url in them, even for the stable channel. That's why when you go to the stable channel (after clearing app data), you are able to download the snet.apk, directly from topjohnwu and not google.

Since kantjer also has the url in his json, his update channel works too. It will download the snet.apk from kantjer's repo, also not from google.

Ian just needs to add the snet url in his custom update channel json, that's all. He may or may not also need to have the snet.apk in his own repo. Probably not if he just uses topjohnwu's or kantjer's url.
[Magisk] martyfender:
Yes, I think you are correct and more clever than this 60 year old! That is great detective work on your part, [MENTION=6014314]neekless[/MENTION] !

And I just noticed [MENTION=7187684]ianmacd[/MENTION] added it to his .json file!
[Magisk] neekless:
New problem [MENTION=7187684]ianmacd[/MENTION], using the snet.apk from your channel I get API error, but no problems using john's snet.apk. Both files seem identical. Could it be due to api keys?
[Magisk] kantjer:
deleted
[Magisk] neekless:
I cleared data to remove john's snet before putting in ian's channel and downloading ian's snet so that I can test his json. So it couldn't be updating snet.apk could it?

I just reproduced the problem by clearing data and downloading john's snet. Safetynet Passes. I then cleared data again and put in ian's channel and then downloaded ian's snet. API error again. I read that the new safetynet api requires api keys, but I don't know how that works. Are custom builds also using john's api keys?
[Magisk] ianmacd:
I'm on holiday at the moment, and am consequently a bit less quick to respond.

I spent an hour after breakfast this morning fixing my build system to be able to cope with the changes that [MENTION=4470081]topjohnwu[/MENTION] has made in recent commits.

Sorry about the issue of the missing snet.apk. I hadn't noticed that this had been externalised. I have now added it to my JSON file, using the same version number that John maintains in snet/build.gradle. This is fixed in 2018082301.

The MagiskManager app is now versioned in line with John's official versioning. John has delegated the versioning of this from app/build.gradle to config.prop, so I now version my APK snapshots as ${major}.${minor}.${patch+1}-${date}${build}-ianmacd, such that if 5.8.3 is the current beta release, my snapshots will reflect that they are early snapshots of 5.8.4. This can be seen in the app's About menu. Previously, my MM APKs were given the same version as Magisk itself, which is ${major}.${minor+1}-${date}${build}-ianmacd, so if 16.7 is the current official (beta) release, my Magisk snapshots will reflect that they are early snapshots of 16.8.

As far as snet.apk not working, this seems to be the reason in snet/src/main/java/com/topjohnwu/snet/SafetyNetHelper.java:

/* Insert the magic API key here :) */
private static final String API_KEY = "";

Yeah, that's not going to work. I suppose we custom builders should also apply for an API key.
[Magisk] neekless:
First off, sorry for disturbing you on your holiday. Thank you for taking time to fix your build!

Yeah I figured it may have to do with the api keys. I assume that the snet.apk would not be updated frequently (or more accurately, newer snapshot builds should work with older snet.apk provided there aren't any big changes to snet). If so, what if custom builders just linked directly to john's snet.apk in their json?
[Magisk] kantjer:
I force pushed snet.apk with my own api
[Magisk] ianmacd:
No worries. It's my fault. I can't let some things go.

That's one option, of course. However, I've just requested an API key and am testing with that now.
[Magisk] HannibalLecter:
when I do this, my magisk version becomes 16.0 from 16.7.

should I flash 16.7 again from recovery to get the latest version.

Oneplus 6 stock rom with magsik ofcourse.
[Magisk] Deic:
I did it, shows notification of new version and installed it without problems, all is fine. Thanks mate
[Magisk] biggdevon:
Installed the snapshot module but didn't get a notification of the update. It shows in manager as available and installed correctly. Anything I can check/provide to fix notifications?

v12-17225beta, Manager v5-17221

Snapshot module v1

Tested on SM-N920T running:

Stock 6.0.1 DPK6

arter97's v22 kernel

Root Checker Pro

Safetynet Helper

Edit: is the Manager app supposed to get updated along with framework? Mine didn't had to install it separately.
[Magisk] Deic:
The snapshot module hasn't notification... is all done in background (apk installation included). is a simple shell script, check source code to see how works.

Magisk and Magisk Manager got updated in different way and when an update is available for every one..
[Magisk] Filip013:
This is probably off-topic, but can anyone explain to me what topjohnwu is up to on GitHub?
[Magisk] nathanchance:
Adding support for a variety of boot images.
[Magisk] Deic:
Magisk Manager Snapshot Updater v2.0.1

changelog:

-built-in module auto-update

-gui install is defined by default if background install fail

-code improvements & bugfixes

if you have got some bug or something strange occurs, please post "updater.log" file found in "/Magisk/magisk-manager-snapshot-updater/".

source code: https://github.com/DeicPro/magisk-manager-snapshot-updater
[Magisk] biggdevon:
Will this install over v1 or does it require uninstall?
[Magisk] Deic:
When a module is installed, it usually (if install script is not modified I guess, I didn't check it) remove completelly the old module and install the new one, so you can perfectly install it over the old.

Regards

PS: I'm going to release v3.0 with notifications and toasts thanks to 2 useful apps developed by 2 generous devs, I love them!

https://github.com/halnovemila/Notify4Scripts

https://xdaforums.com/showpost.php?p=7995004&postcount=2
[Magisk] reis1996:
What exactly is this thread about? Magisk for Samsung devices? The op doesn't have much data
[Magisk] Shadowghoster:
This is clearly stated in the title of this thread: Builds of current Magisk v12 and MagiskManager v5 sourcecode available on GitHub.

Btw I thought vendor mounts were fixed but my vendor is still not touched by magisk even though there is a vendor symlink created by Magisk in the module folder inside magisk.img and some files in $MODPATH/system/vendor. Anyone facing similar issues?
[Magisk] Didgeridoohan:
I haven't seen anything about a fix for the vendor mount issue in the commits on GitHub. Only that it's a known issue: https://xdaforums.com/showpost.php?p=71092344&postcount=14
[Magisk] Shadowghoster:
Yeah, you're right. I checked github myself after posting and found nothing. I thought topjohnwu mentioned somewhere that he found a fix for it but seems like my memory was faulty and it was only the post telling it's a know issue :D
[Magisk] damian93as:
Hello, sorry if my question annoys, but I have a moto z Play with marshmallow 6.0.1, as to install and properly run magisk?
[Magisk] same-xx:
Yeah that was my phone. Sorry.
[Magisk] LPW00:
This isn't a sentence. If u want to be understood, use complete sentences.
[Magisk] same-xx:
Got my nenemesis nougat working with v.12.something. But I was wondering van somebody give me advise how to remove magisk and replace it with supersu. With magisk everything gives a lot more work and trouble. Like installing sound mode. S6e nemesis rom nougat. Or is even possible? Thanks.
[Magisk] jhedfors:
Using uninstaller from release thread will do the job of getting rid of Magisk.

https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445

Restoring your ROM's boot.img will also get rid of Magisk. You can choose "flash image" in TWRP, and select that boot.img. Then find latest SuperSU and flash in recovery.
[Magisk] HamsterHam:
Latest build safetynet won't pass unless you toggle hide off and on from a reboot.
[Magisk] yochananmarqos:
Latest build of what? No issues here.
[Magisk] HamsterHam:
Latest builds of Magisk here: https://github.com/stangri/MagiskFiles
[Magisk] kantjer:
personal snet api is working now
[Magisk] ianmacd:
OK, I believe I have this working now, which means it works for me. 2018082304 has the changes.

Anyone who wants to test should perform these steps:

install MagiskManager-v5.8.4-2018082304-ianmacd.apk

Erase the app's data (not just cache).

Add my custom update channel.

Perform the SafetyNet check (which will cause the new snet.apk with my API key to be downloaded).

If the check passes, my API key is working for you. This will (ever so slightly) help [MENTION=4470081]topjohnwu[/MENTION] stay under his daily quota of 10,000 API calls.

My custom update channel's URL is:

https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json
[Magisk] Didgeridoohan:
That means you haven't changed the Update channel (Manager settings) from stable to beta or whatever custom build you want to use (since we're in the unofficial snapshot thread).
[Magisk] carlos974:
A good drawing is better than a long speech !!!
[Magisk] DenyDarko:
You noticed the awesome change on the last build?

Fingerprint authentication is required to disable the setting and the setting itself got moved inside Magisk DB and it's now immune to Magisk app data wipe. ?
[Magisk] lekiaM:
I might be doing something wrong:confused:
[Magisk] LeMoise:
If I currently have Magisk Manager repackaged (via hide magisk manager) how would I go about updating the app to your version without messing anything up?
[Magisk] kantjer:
Do you pull the variables ${major},${minor},${patch} from somewhere?

I have been looking for a way to extract them but my current way is fairly complex.
[Magisk] ianmacd:
My way was overly complex, too, so I've boiled it down to this now:

$ git describe --tags --abbrev=0 --match 'v*' master
v16.7
$ git describe --tags --abbrev=0 --match 'manager*' master
manager-v5.8.3

So, then something like this will work for incrementing the version number (assuming bash syntax):

magisk_v=$( git describe --tags --abbrev=0 --match 'v*' master )
app_v=$( describe --tags --abbrev=0 --match 'manager*' master )
next_magisk_v=${magisk_v%.*}.$((${magisk_v#*.} + 1)) # -> v16.8
next_app_v=${app_v%.*}.$((${app_v##*.} + 1)) # -> v5.8.4
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I followed your instructions for your latest build and safetynet check is working as expected.

Thanks
[Magisk] ianmacd:
Thank you for confirming that, Marty.
[Magisk] kantjer:
Same instructions for my build, tested and working
[Magisk] Ace42:
Looking good. :victory:

(Screenshot isn't working but safetynet passed)