yashsingh1/xdaforums huggingface dataset:
[Magisk] kantjer:
You mentioned changing channels alters the behaviour, that makes me think it's the json MM is pointing to (AFAIK changing channels (stable, beta or custom) only make MM points to another json file.

I checked official, [MENTION=7187684]ianmacd[/MENTION] and mine and the difference is that Ian's json does not include the Magisk-uninstaller.

It could be MM is searching for the uninstaller, can't find it and crashes.

Official: https://raw.githubusercontent.com/topjohnwu/magisk_files/master/stable.json

Ian: https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json

Mine: https://raw.githubusercontent.com/kantjer/MagiskFiles/master/updates/kantjer.json

As a test you could try to install Ian's MM and put my update channel link in there.
[Magisk] neekless:
I'm using Ian's mm and magisk, and I have tested putting your update channel. No issues here.

Since he mentioned your builds are fine but ian's are not. could it be the commits that ian has ahead of your build? But even if so I'm not getting any issues with ian's build so I'm not sure. I took a look at the new commits and don't see any changes that might have caused it (though I'm not well-versed in code so I could be wrong). Maybe the issues are only present on x86 devices?
[Magisk] kantjer:
If you didn't have issues before, changing update channel won't make any difference.
[Magisk] ianmacd:
I can't remember why I didn't include the uninstaller from the beginning; probably because I have never once used it myself.

However, even if this doesn't turn out to be the cause of the issue now, it seems I should include the uninstaller for the sake of completeness, so I've now added it retroactively to yesterday's build, and will include it with all future builds.
[Magisk] martyfender:
I couldn't sleep very well so I am up briefly and updated 2 devices to [MENTION=3306843]kantjer[/MENTION] 20180731 and I have none of the previously reported issues on these 2. Since I've had issues, of recent, I did not try the direct install method, but opted for doing it in the add module section, to flash your zip

I still do have the issues on [MENTION=1269522]inma[/MENTION]cd , even though you added the uninstaller link in the custom channel, so I don't believe that is the issue. I am like you, I normally don't run the uninstaller, but could, then reinstall it, if you think that might help.

I think I will try the above [MENTION=3306843]kantjer[/MENTION] 20180731 on that particular device to see if the issues returns on that device.

Nextbook Ares 8A Android 6.0.1

As far as I know the hardware, Android version and kernel version are the same, with different build ids and dates for the roms, and different revisions of the IFWI (Intel Firmware Interface).

When I am up, I will do further testing on the other tablets.

EDIT: I installed on a third device and it is also working ok.

Logs attached.

Thanks, all, for your input.
[Magisk] mkdante381:
Help only restore data and system partitions from backup.

Dear Kantjer latest magisk manager from 31.07.2018 is unstable and crash or stop responding. I have aosp extended android oreo 8.1. Data and cache formatted in f2fs
[Magisk] martyfender:
I installed 20180731 on the 4th tablet I had Ian's build on and it is also working fine, as the other three. When I first updated mm to 20180731.apk, I did get the popup again to install additional files, but once I flashed the 20180731 Magisk.zip, that went away after reboot. After reboot, I tried different update channels with no problems.

It seems to me that the problem is in the different Magisk builds and not the different Magisk Managers, not sure, though.

Thanks
[Magisk] hshah:
Not sure if this is progress or not with regards to the V lol :p
[Magisk] kantjer:
Yes, I gave up. V has won

Going to accept it and work around it
[Magisk] guest4711:
Had the same problem on one device, coming from vunofficial-20180721 after flashing current version via MagiskManager. Reflashing via TWRP solved it.
[Magisk] hshah:
So I've still been going through the list and unchecking items. One app I hadn't tested for a few weeks was the NatWest Online Banking one and it no longer accepts fingerprint logins.

The app hasn't been updated and I haven't installed anything new (other than Magisk updates). Tried uninstalling and reinstalling it but not having any luck, so now need to try and figure out if anything I had unselected could have caused that :(
[Magisk] kantjer:
I had the same issue with my Dutch banking app, not accepting FP login (it wasn't even offering it)

A reinstall fixed it in my case.
[Magisk] dead0:
[MENTION=3306843]kantjer[/MENTION] you wouldn't happen to know if these unofficial builds have the fix for my query in the support thread or know where to look at in the source code? ive tried the latest ianmacd's build but still lose magisk hide in MM
[Magisk] neekless:
I believe this is fixed in this commit. Both ian and kantjer's builds have them and it solved the magisk hide issue on my side. Have you tried uninstalling MM and reinstalling the latest version? If that still doesn't work then it may be a different issue and you should post your logs.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] I just updated my four devices to 2018080200 and as in previous, recent builds, direct install crashes Magisk Manager. Installing through the module section works on 3 devices, but on one I had to install through twrp to avoid the message dialog of installing additional flle, as before, that crashed the MM. On 2 of the 4 devices, I get the: unfortunately, magisk has stopped error on reboot. Launching root apps at this point shows no toast, but root is granted. The toasts show up again if I launch MM again. So MM crashes on reboot on those 2 devices . MM crashing on reboot appears to be intermittent. Sometimes it is fine on additional reboots..

One of the devices that had the message:

"Requires Additional Setup

Your device needs additional setup for Magisk to work properly. It will download the Magisk setup zip, do you want to proceed now?

I get a very brief dialog:

running environment setup

then:

Unfortunately, Magisk Manager has stopped."

The above was solved by flashing Magisk.zip in twrp.

EDIT: The errors on the second device were apparently solved also, by flashing Magisk in twrp, also.

Providing logs for 4 devices could be done, but I would like to have some input If there is a better way to do this.

I also noticed that text is larger in MM. While this may be good for phones, it is too big on an 8" tablet. I do like the fact that you brought back the Magisk version number in this build. This help to know where it is in relation to the stable and beta builds. Thanks.

I reflashed Magisk through twrp with good results, also, at least on one reboot, anyway.

Thanks
[Magisk] kantjer:
yes that fix is included in the unofficial builds.

Magisk Hide is working fine again for me.
[Magisk] kantjer:
The Pin not accepted issues at boot some users where experiencing (mainly on Pixel devices) should also be fixed in today's build.
[Magisk] buffal0b1ll:
Preliminary testing on my end suggests this is true for walleye. I'll continue to monitor with every reboot and update. I've been suffering from the wrong pattern/pin bug on walleye for many months and I'm very pleased that there's progress towards a fix now.
[Magisk] dead0:
seems to be a problem on my end. if i install the rom as a file based zip only the stable v16 works with magisk hide showing up as normal in MM, the betas or unofficial do not work. if i install as image based, then the betas and unofficial work as normal. i dont see much of a difference to cause issues in the magisk updater script between v16 stable and the betas/official unless im missing something
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] Last night when I flashed 2018080200 through TWRP and deleted the dalvik cache and cache, then rebooted, on my 4th device, I realized that the data had somehow been corrupted. I am not sure why. Drop down notifications, sliding from the top, did not work and the recent app switcher would not open. When an app was opened I had to use the back button to get out of it. Everything else appeared to function ok, though. Multiple reboots, reflashes of the stock boot and Magisk, etc, did not solve it.

I re-flashed my stock boot and system backups in TWRP, followed by a factory reset in TWRP to delete data and then set up the devices as new again and downloaded apps, modules, etc and all is well again.

I currently have 3 modules installed , Osmosis Busybox for Android NDK 1.29.1 , Sysconfig Patcher 2018.7.24, and greenify4magisk v4.1.1. Logs from last night all looked normal with no errors. The logs look the same as the other 3 devices I flashed it on. So, therefore, I did not see the need to attach them.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] I just installed v16.8-2018080201 on to one of my tablets, this time a different one. So far it is working great with no problems I can see except for the ongoing one seen in the filtered logcat.
[Magisk] deepu458:
Hi OP,

I have been using this version of Magisk on my Essential PH-1 Stock Oreo. All was good with Magisk Installation and other hide things. But when I use the EX Kernel Manager App which uses the Root to flash a kernel it says an error "Segmentation Fault" all over the log and failed. When I ask this dev there it might be an issue with the Magisk I'm running. Is this an issue already known and let me know any kind of logs u need for this issue.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION], I see you have found a good way to do multiple builds in one day. Is that last number in the build number, the hour, on a 24 hr. Clock, that it was built? The last 2 builds have worked well for me.

Thanks.
[Magisk] kantjer:
Yes, last 2 digits are the build hour.
[Magisk] kantjer:
Is direct install now working or TWRP only?
[Magisk] buffal0b1ll:
I never had an issue with direct install on Pixel 2. Last 3 dailies direct installed fine. On 2018080319 now.
[Magisk] martyfender:
I have not attempted it recently because of the problems I had with it. I have used TWRP.
[Magisk] guest4711:
On my S4 (i9505) and my S4 active (i9525) it was/is okay (I never had problems). On my Tab2 I was forced to use TWRP. I'll try it when I'm at home...

Edit: Still crashing when trying to download/direct install via MM on my Tab2. So had to download in MM and flash in TWRP.
[Magisk] ianmacd:
New zip signing code presenting a problem

[MENTION=4470081]topjohnwu[/MENTION]

Hi John,

Your new build feature (commit 32809e56d003d9fb87ad419bea53a7c89a13e5a3) that allows the release ZIP to be signed with release-key.jks is producing an error when I attempt to build:

* Signing Zip

Exception in thread "main" java.io.IOException: Keystore was tampered with, or password was incorrect
at sun.security.provider.JavaKeyStore.engineLoad(JavaKeyStore.java:780)
at sun.security.provider.JavaKeyStore$JKS.engineLoad(JavaKeyStore.java:56)
at sun.security.provider.KeyStoreDelegator.engineLoad(KeyStoreDelegator.java:224)
at sun.security.provider.JavaKeyStore$DualFormatJKS.engineLoad(JavaKeyStore.java:70)
at java.security.KeyStore.load(KeyStore.java:1445)
at com.topjohnwu.utils.SignAPK.sign(SignAPK.java:88)
at com.topjohnwu.utils.ZipSigner.main(ZipSigner.java:36)
Caused by: java.security.UnrecoverableKeyException: Password verification failed
at sun.security.provider.JavaKeyStore.engineLoad(JavaKeyStore.java:778)
... 6 more

Any ideas? This is obviously the same release-key.jks that I use to sign my builds of the APK.

I have created an issue for this on GitHub.
[Magisk] kantjer:
I don't have any build issues with that commit.
[Magisk] ianmacd:
Interesting.

[MENTION=4470081]topjohnwu[/MENTION] summarily closed my GitHub issue, claiming that I'm using the wrong password, but that's obviously not the case, as I can sign the MM APK with the same key and have been doing so since the day I created the JKS.

Not only that, but manually signing a zip file works:

$ java -jar ./utils/build/libs/zipsigner-3.0.jar release-key.jks foo org.caliban bar out/unsigned.zip out/signed.zip

Well, no more builds from me until I figure this out.

EDIT: New GitHub issue, #445, opened.
[Magisk] guest4711:
Has your build process the necessary permissions to read the keyfile? Chmod 644 keyfile may help....
[Magisk] ianmacd:
Yes, of course. I'm already signing the MM APK with it as part of the build process. It's just the newly added signing of the Magisk ZIP archive that doesn't work.
[Magisk] ianmacd:
I've figured this out. My config.prop looks like this:

keyStorePass="foo bar"
keyPass="baz qux"

It turns out that those quotes are needed to sign the MM APK (because of the spaces in my passwords), but are passed as literal characters to the subprocess when signing the ZIP, so they invalidate the passwords.

I've passed the details on to John via the GitHub issue.
[Magisk] martyfender:
I see topjohnwu just made a commit to fix the issue.
[Magisk] ianmacd:
Indeed, although I expected him to make the pre-existing behaviour — i.e. the acceptance of quotes in the config.prop — apply to ZIP signing as well as APK signing. Instead, however, he has chosen to make the new ZIP signing behaviour — i.e. the requirement to use no quotes — also apply also APK signing.

In short, parameters in config.prop may no longer be quoted.

My builds are back in action, anyway. 2018080501 will follow shortly.
[Magisk] kantjer:
For those who like me often flash Magisk through TWRP I now also generate an md5 file during build.

Place the md5 file in the same folder as the zip and TWRP will automatically recognize it and use it to check the zip integrity preventing flashing a corrupt file due to a bad download.
[Magisk] 587.saboor:
Speaking of twrp and flashing magisk and problems

Any luck on the imei/cell problem in the a8 2018 oreo?
[Magisk] Didgeridoohan:
You can monitor the progress yourself in the issue tracker, right here:

https://github.com/topjohnwu/Magisk/issues/426

Until there's an update to that issue, there are no news...
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] On todays build, on 1 of 3 devices I flashed it on I am apparently having data corruption issues again, on a different device, but the same symptoms as in this post:

https://xdaforums.com/showpost.php?p=77233723&postcount=2085

I have not factory reset it yet like I did the other device to solve it. I hope there is another solution.

There is an error in the Magisk log and will post it when I get a chance.

The recovery log is after this happened and I reflashed the Magisk.zip to see if that would fix it. I did try core only mode, also.

Does anyone have any ideas?

Thanks

EDIT: Sorry, I did not mean to reply to your post.
[Magisk] hshah:
The latest update seems to have wiped my hidden apps and reselecting them doesn't seem to stick :(
[Magisk] martyfender:
[MENTION=4667597]Didgeridoohan[/MENTION] [MENTION=3306843]kantjer[/MENTION] [MENTION=4470081]topjohnwu[/MENTION]

Does anyone know what this entry in a Magisk log is? it is the first line of the log I posted in the previous post.

08-07 11:29:51.509 2323 2323 E Magisk : fopen: /data/adb/.boot_count failed with 2: No such file or directory

EDIT:

Unfortunately, I ended up reflashing my rom and starting fresh.

Thanks
[Magisk] Didgeridoohan:
That's part of a new feature that'll be useful if a Magisk module is preventing your device from starting or causing it to bootloop. After a couple of failed boots, Core Only Mode will be enabled automatically and the device should be able to boot so you can take care of whatever module caused it. Not sure if the implementation is finished yet... That might be why you're seeing that error.
[Magisk] kantjer:
I'm seeing the same line in my log, but no negative effects.
[Magisk] martyfender:
Do you have any idea what could be causing my data corruption issue on 2 different devices with recent builds, mentioned in previous posts?

The only way I have figured out how to solve it is to reflash the rom, although a factory reset probably would have solved it also. Both devices had not had the rom reflashed on them since they were new: (~12-2017). On the first device I had flashed boot, system and magisk and that did not solve it so that is why I believe it was data that was some how corrupted.

Drop down notifications, sliding from the top, did not work and the recent app switcher would not open. When an app was opened I had to use the back button to get out of it. Everything else appeared to function ok, though. Multiple reboots, reflashes of the stock boot and Magisk, etc, did not solve it.
[Magisk] Didgeridoohan:
I do not, unfortunately. Your tablets are weird...

It's also such a difficult issue to figure out. I think you'd have to be saving a logcat during boot at the time it happens for it to even have a chance of showing anything (and even then it's not guaranteed). Sounds a bit tedious hooking your device up to a computer and save a logcat while booting after each flash of a new Magisk version, until it happens. But, I think that'd be the best shot...
[Magisk] kantjer:
I had that a few years ago, long before Magisk existed. It turned out to be a kernel setting keeping data in memory before writing it to disk when the cpu was idle. Disabling that fixed it for me back then.

AFAIK no app can do a clean reboot (save everything, and close apps nicely) so in app update and reboot could cause that. Next time don't use MM to trigger the reboot but use the pwr menu.
[Magisk] eak1080:
[MENTION=3306843]kantjer[/MENTION] your newest build fails to install pixel 2 xl on PPR1
[Magisk] kantjer:
Yes, I noticed that also. Install using the module interface or TWRP works.

EDIT: bug reported.
[Magisk] aer0zer0:
I was gonna mention something earlier, but same with essential phone. I just used the module interface.
[Magisk] kantjer:
John found the issue, I hope it will be fixed in the next build.

EDIT: fix pushed
[Magisk] hshah:
A reboot seemed to solve that issue, however now the updates don't seem to direct install via MM:
[Magisk] bggold:
Read a few posts above yours. Use twrp or mm direct as you were installing a module. Go-to modules and press the +.
[Magisk] kantjer:
I just pushed a new build, it's fixed now
[Magisk] bggold:
Confirmed just updated and it works pixel 2 xl running pie.

Thanks for the quick update.
[Magisk] kantjer:
This was the fix, LOL 1 extra byte
[Magisk] hshah:
Confirmed working :svetius:
[Magisk] joluke:
Thank god for that extra byte... saved our device :D
[Magisk] hshah:
May have spoken too soon...phone seems to always boot up on core only mode and even though it tells me to reboot after unticking the option, it's back to normal if I ignore that message.
[Magisk] martyfender:
Was that fix for the direct install not working, recently?

EDIT: I just tested direct install on a second device instead of TWRP and it finally works again. My guess is that it also fixed the error of the Magisk Manager quiting on boot?

I can also confirm that [MENTION=7187684]ianmacd[/MENTION] 's build also works with direct install on the one device I have it installed on.

Thanks
[Magisk] kantjer:
Check if you have /data/adb/.boot_count

And check Magisk log.

EDIT: try build 2018080910, that should hopefully fix the issue

---------- Post added at 09:04 ---------- Previous post was at 08:35 ----------

Yes
[Magisk] kantjer:
Fixed in build 2018080910
[Magisk] martyfender:
triple post deleted. xda is having problems again.
[Magisk] martyfender:
deleted due to xda errors.
[Magisk] martyfender:
deleted
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] [MENTION=7187684]ianmacd[/MENTION]

I just flashed to one device through the direct install method and got the boot.img error on boot once again that I posted photos of a few days ago.

Once again, re-flashing my stock boot.img and magisk through TWRP solved it.

I updated the tablet with [MENTION=7187684]ianmacd[/MENTION] 's latest build through direct install with no problems.

The one above with the bootloader error was also the one with the busybox problem I posted in the Magisk Hide props config thread.

I just flashed the [MENTION=3306843]kantjer[/MENTION] build also, 2018080910, to a second device with direct install and also got the bootloader error on that device.

I once again flashed stock boot and magisk in TWRP to solve it.

Is this once again one of those 1 byte errors?

I guess it is back to flashing in TWRP again.

EDIT: I just flashed on a 3rd device through TWRP and it all went fine.
[Magisk] SpectraFun:
With today build force encyption not work on Oneplus 6.
[Magisk] bggold:
[MENTION=3306843]kantjer[/MENTION]

I updated yesterday pixel 2 xl pie to 20180809 and noticed that the preserve force encryption was no longer checked and everything is running fine. Today I updated to 20180810 and after reboot got a magisk notification that dtbo was patched and to reboot. After reboot magisk no longer has the preserve acb 2.0/dm-verity checked. Once again all seems to be fine

Should I be concerned at this point and roll back?

Thanks

Edit: I do use pattern lock and fingerprint.
[Magisk] kantjer:
No don't worry, I'm also seeing other behavior. As long as you don't experience any issues ignore it.
[Magisk] kantjer:
It's fixed in the next build.

I'm using it now.

Last test build was made with John's FrankeNDK, I will test it before uploading.

https://github.com/topjohnwu/FrankeNDK
[Magisk] SpectraFun:
No answer is a good answer.
[Magisk] bggold:
No issues updating. No patch notification but both check boxes still not checked. As long as it's working I'm not concerned about it.

Thanks
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I decided to risk the direct install method once again considering the commits in it and it is once again working on the one device I have your builds on.

EDIT: [MENTION=3306843]kantjer[/MENTION] released a second build today with those commits and the direct install is working again on the 3 device I have installed it on.

[MENTION=4470081]topjohnwu[/MENTION] In the recent builds, I am no longer seeing errors in the MM filtered logcat, just some warnings. If anyone wants to see the logcat, I can provide it.

On thing I notice on these builds is that I don't see an Android drop down notification that there is an update for Magisk available like I have always seen in previous builds.

Thanks
[Magisk] ianmacd:
Thanks, Marty. Does this mean that your longstanding direct installation issue is fixed?

By the way, I always read the messages in which you tag me. In fact, I read any and all messages in this thread, but I just wanted to let you know that you are not talking into the ether.
[Magisk] martyfender:
In a response in the Magisk Hide Props Config thread I realized that the internal busybox version is 1.28.4 and not 1.29.2, unlike the [MENTION=3306843]kantjer[/MENTION] build. I ran the following in the terminal to determine this:

/sbin/.core/mirror/bin/busybox

Is that the proper command to determine it?

Could you check your recent build to see if this is true for you also, or did I get an incomplete install of your latest build, v16.8-2018081201?

Edit: I reinstalled build, v16.8-2018081201 through TWRP and get the same busybox version: 1.28.4.

Thanks
[Magisk] ianmacd:
Magisk's submodules seem to be beyond my ability to script into staying synchronised.

I've just released a new build with Busybox updated to 1.29.2. There are no other changes, as John hasn't pushed anything to GitHub today.
[Magisk] kantjer:
have you tried this:

git submodule update --init --recursive
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] In your repository it states: Update testing build to v16.8-2018081201.

Shouldn't it be: Update testing build to v16.8-2018081301?

Thanks