yashsingh1/xdaforums huggingface dataset:
[Magisk] hshah:
I'm getting bootloops with the last update on my Note 8. Just trying to sort it out now :)

/Edit: Just to be specific, it turns on and optimises the apps before restarting. I've cleared the cache etc but still does the same. Going to see if downgrading Magisk helps in any way :)

/Edit2: Booted without issues when I reflashed r15 :)
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION]

Nextbook Ares 8A Android 6.0.1 x86.

I just updated another Ares 8A with [MENTION=3306843]kantjer[/MENTION] build and it has the same issue. The device show certified in the play store. I went to the troubleshooting guide then cleared play services data and rebooted, but that didn't help.

I kept the r16 mm, rebooted to twrp and flashed r15 and safety net passes with it.

I appears to have happened after these commits: Switch to libc++ and Migrate to STL. Also, maybe this: Bump to C++17.
[Magisk] bggold:
Just updated to kantjer v16 pixel 3 xl no safety net issues.
[Magisk] guest4711:
Tested a bit more with [MENTION=3306843]kantjer[/MENTION]'s and your last build on two jflte (i9505 with P and N)

If I hide MM for terminal the console prompt does not appear - I sometimes get a notification like "terminal is not respondingc". If I unhide MM for it, everything is ok (and I can su, too).

Same for some banking apps.

Unfortunately, I have no logs while on the road...

Edit: Downgrading Magisk to 20190119 helped. Root is properly hidden where needed, no FCs anymore...

Edit2: Toggling " MagiskHide" from on to off and back gives immediate and reproducible reboots whith [MENTION=395164]ianmac[/MENTION]cd's builds since january, 19 (older ones and [MENTION=3306843]kantjer[/MENTION]'s not tested)
[Magisk] martyfender:
Why would you hide the terminal from Magisk? I see no reason for that, like your banking app needs. Your terminal needs to detect root to be able to do root functions, I believe.
[Magisk] Francescorm76:
Even with the latest actualization magic hide does not work.. By selecting an application to hide it crashes... Up to version 702/901 work..... All other actualizations does not work.... I have a Notes 8 Oreo with the latest firmware installed.. Thank you very much [MENTION=7187684]ianmacd[/MENTION]

Enviado desde mi SM-N950F mediante Tapatalk
[Magisk] guest4711:
Just for testing... The builtin terminal is available on most devices right after flashing the ROM. No need yo install any store.
[Magisk] ianmacd:
This is just a general reminder that one should not have the same expectation of nightly snapshot builds, official or otherwise, as one does of production or even beta software.

Reporting bugs in unofficial nightly builds is probably not as useful as one might hope, unless the report pertains to a feature added by the maintainer that is unique to his builds.

If it concerns an upstream bug, it should (also) be reported upstream against an official build. That's almost certainly the quickest path to a fix.

Reporting it here does have limited usefulness, however. For me, it can be good to know that a bug afflicts not just my builds, for example, but if I can reason that the bug will soon be fixed upstream, then I'm unlikely to try to fix it myself. Anyone who can't live with the bug and can't wait for John to fix it can simply roll back to an earlier snapshot. I don't want to speak for [MENTION=3306843]kantjer[/MENTION], but I'd be surprised if he didn't feel the same way.

So by all means keep reporting the bugs here, but please do so with the knowledge that [MENTION=4470081]topjohnwu[/MENTION] needs to be aware of them to fix them. They're probably not going to be fixed downstream and passed back to him.

Also, please be aware that Magisk development is going through some major changes at the moment. Breakage is inevitable.
[Magisk] martyfender:
The bug I am experiencing is also present in the latest Canary on my devices, so I reported and posted logs in the Canary development thread also.

Would I actually be better off reporting an issue, with logs, on his github issue area, or does it matter?

And yes, I understand that there will be bugs in these development versions.

Thanks
[Magisk] jenslody:
John knows about it, but can not reproduce it.

I can and currently try to debug it, I know where it happens (strace), but not why.
[Magisk] martyfender:
On 2 of my Nextbook Ares 8A, x86, Android 6.0.1 tablets that I have the Canary debug builds on, I updated to the just released update and all of the problems I experienced are gone. So when [MENTION=7187684]ianmacd[/MENTION] and [MENTION=3306843]kantjer[/MENTION] update I think the problems should be gone on my devices, at least.

Thank you for all of your efforts also, you are one of the most respected and knowledgeable posters I see here on these forums.
[Magisk] ianmacd:
I've just released a 2019012301 build. I hope that fixes your problems.

My other posting about having realistic expectations wasn't aimed at you, by the way, or anyone else in particular. I just wanted to make the point that these downstream builds are rarely debugged and rely almost entirely on upstream fixes. That makes bug reports made here, but not also upstream, of limited use.
[Magisk] daywalk3r666:
safety net is working again
[Magisk] hshah:
r16 was a no go for me as the phone refused to boot, but just installed r17 (over r15) and not had any issues. This is on a Note 8 running DeluxeROM v10 (Oreo 8.0) :)
[Magisk] martyfender:
Your new build and [MENTION=3306843]kantjer[/MENTION] 's new build both appear to be working great.

Many hours have passed and they both are still working very well on my devices.
[Magisk] hshah:
I've not had issues with SafetyNet for ~8 hours now, whereas by now I would have had to toggle Hide.
[Magisk] habylab:
It changes from time to time for me, without any new version flashed.
[Magisk] guest4711:
The actual builds (2019-01-23) by [MENTION=3306843]kantjer[/MENTION] and [MENTION=395164]ianmac[/MENTION]cd do their jobs well. Root is hidden for all apps I need to hide (and my test with terminal works again). Thanks for the new builds!

But still (soft) reboot when toggling "hide magisk" off and on again.
[Magisk] martyfender:
Do you have a reason to hide the terminal app? I think I asked previously, but got no response.

Just out of curiosity, I temporarily hid my terminal emulator app and when I typed su in it, it stated su not found, so I don't understand why you would want to hide it?

Thanks
[Magisk] habylab:
I think it's to show that Magisk Hide works.
[Magisk] martyfender:
Personally, I use Root Beer Sample for that. For me, it works very reliably.
[Magisk] guest4711:
There was a response but probably it was too short... So a little bit longer:

I had problems with some apps not starting or not running well after updating Magisk (e. g. some banking apps). To analyze it I took the easiest app I could think of (the terminal) to check whether su binary could be visible for apps and which environment settings used in each mode (normal, root granted, root hidden). While Magisk before 2019-01-19 was fine the next few builds had problems...
[Magisk] hshah:
Mine was completely random as well, but by now SafetyNet would have most definitely failed and required Hide to be toggled. Still going strong :)

By any chance, do you have SystemUI on your hide list?
[Magisk] guest4711:
No.
[Magisk] hshah:
There are a few processes that would cause that when you toggle Hide. SystemUI is one of them.
[Magisk] guest4711:
Thanks for helping. But toggling hide off and on again chrashed even after removing all apps from MagiskHide list.

So I decided to start over: I uninstalled the repacked Manager, booted into TWRP, moved /data/adb/magisk.db out of the way and reflashed Magisk. After rebooting I repackaged MM again, granted the necessary root permissions to some apps and hided magisk from others (banking apps e.g.).

Now everthing seems to be as it should.

Probably my magisk.db was broken...
[Magisk] hshah:
Dammit, just failed :(
[Magisk] habylab:
Surely Google have done some changes on their side?
[Magisk] martyfender:
On my devices, these builds are working great, with one exception: on one device I didn't already have Magisk Hide Props Config on, upon installing it on that one device, Canary debug build, it is broken.

On all other devices which already had it installed it works fine. I have 2 Nextbook Ares 8A's, x86, Android 6.0.1 with [MENTION=3306843]kantjer[/MENTION] v17, one with [MENTION=7187684]ianmacd[/MENTION] latest build and 2 on the latest Canary debug build. Safety Net passes every time I check it and Magisk Hide always works, also. I test that with RootBeer Sample, Since I don't have any apps that detect root and refuse to work.
[Magisk] Ace42:
Noticed something interesting. When "Downloads" is restricted (Pie) Safetynet fails, then gets restored as soon as it's released. Dunno if this'll help anyone but maybe it'll come up one day.

I was going crazy trying to figure out why my games wouldn't work.
[Magisk] Didgeridoohan:
What do you mean by "restricted"? Are you talking about permissions, or what?
[Magisk] kantjer:
I managed to break my Linux setup, I need to find time to setup Linux again.

For now I won't make any new Magisk builds
[Magisk] Ace42:
No, nothing permission related. It's one of the new battery mechanics in Pie to prevent background usage/activity. I've been using it for months, but accidentally added that particular app on my new phone. So I compared the restricted list on both to find the culprit.

I have Ian's version on 3 devices, which tells me whether an issue is down to user error/ROM or with that release.
[Magisk] martyfender:
I'm sorry to hear that. I was wondering why you had not posted a new build recently.

What version of Linux are you using? I have been using Linux Mint for over a year and am loving it, vs Windows 7. I hope to you get it back up soon. Just out of curiosity, how did you break it? I have been afraid that something like that will happen to me also.

I have 2 of my tablets with your latest build and it has been performing absolutely without any problems.

I just updated the one tablet I have Ian's latest build on and it appears to be without issue, also. I am not getting random root loss issues with apps such as Apps2SD and Kernel Aduitor, that I have had with previous versions. The only problem I had previously, was that I had to sometimes reauthenticate those apps, when a new root prompt popped up. Maybe I need to turn off the setting: reauthenticate on upgrade? But maybe not, now?
[Magisk] WizP:
For those using Samsung devices whose apps are still detecting root, can you try the following and see if it helps any.

In Magisk Manager go to settings and then make sure Super User access is set to Apps only and NOT ADB.

I am thinking that it might have something to do with ADB and possibly ADB/USB debugging being enabled...

So if you have ADB/USB debugging enabled turn it off in the developer section in your android settings.
[Magisk] guest4711:
Thank you for proposal. But I believe [MENTION=4667597]Didgeridoohan[/MENTION]'s "Magisk Hide Props Config" module handels it for you so you don't need to care. More solutions in his fine "Magisk Trouble Shooting Guide"

https://www.didgeridoohan.com/magisk/MagiskHelp.
[Magisk] Didgeridoohan:
Thanks for the confidence, but my module does not handle USB/ADB Debugging or Developer options. I could make the module turn it off but I don't want to be changing a user's settings for them like that...

If you want to mask the fact that you have USB/ADB Debugging or Developer options enabled I believe you need Xposed.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] With the latest build, has anyone else been stuck at checking SafetyNet status? I still have the previous build on another device and the check is working on it. I tried deleting cache and data for the app, also. The check is ok in another app.

Thanks
[Magisk] ianmacd:
Yes, I saw the same behaviour myself this morning. The code is undergoing a massive reorganisation at the moment, and I saw that the SafetyNet code had been touched in the process.
[Magisk] hshah:
Does checking SNet just hang for anyone else on ianmacd's latest build?

/Edit: I ought to have refreshed the page first lol!
[Magisk] martyfender:
Uninstalling MM only and installing the MM from yesterday only, solves it for now, or one can just wait for a fix. Also, I am sure [MENTION=4470081]topjohnwu[/MENTION] will fix it also.

Problems like this are expected with such massive code changes.
[Magisk] bggold:
Works fine with latest canary build.
[Magisk] martyfender:
Yes, of course, that build is from 9 days ago. It works as well on all unofficial builds since then, until today's massive changes.
[Magisk] bggold:
Ha didn't even look at the age.

Thanks
[Magisk] neekless:
[MENTION=7187684]ianmacd[/MENTION] does 2019020101 fix safetynet?
[Magisk] martyfender:
No, but [MENTION=4470081]topjohnwu[/MENTION] just released a commit to fix that issue and it is working on the latest Canary build. I'm sure Ian's next update will have the fix in it.
[Magisk] ianmacd:
Thanks, Marty.

Indeed, 2019020102 fixes the problem.

Meanwhile, it's worth remembering that a broken SafetyNet check in MM doesn't mean that SafetyNet verification itself is no longer being passed by the device. It's just MM's check of it that is failing.

When this check fails, there's always a bigger outcry than I can understand. Do people really spend a significant amount of time in MM, pressing that button for some kind of comfort? As long as the device itself is still passing, whether MM itself can carry out the check is much less worrisome.
[Magisk] martyfender:
I realize all of this, but since I am tester, I report bugs when I see them both here and in the Canary thread. Otherwise, I would stay on a stable build or one that is working for my devices. So that is why I check it with each build release.

I noticed that [MENTION=4470081]topjohnwu[/MENTION] removed the about, changelog, so where do I now find that for your releases, since you don't have it on the github page similar to [MENTION=3306843]kantjer[/MENTION] ?

There is a link in the new MM to [MENTION=4470081]topjohnwu[/MENTION] 's page, but like today's earlier build for example, they were not the same, until you updated again. I know that they were up to date at the time you built them, though. I wonder why he removed it?
[Magisk] ianmacd:
Ha, as usual I wasn't addressing anyone in particular and certainly not you.

It's certainly worth knowing that the feature is temporarily broken, but it's not an important enough concern to either downgrade MM over or avoid upgrading it.

I actually hadn't noticed that myself yet. I suppose I'm going to switch to an on-line solution; either that or reinstate the changelog, but swimming against the current doesn't seem the right thing to do here. Watch this space.

I'm not sure I follow. What exactly has John removed? I see the link to his GitHub and it goes to the right place. Do you mean something else?

---------- Post added at 18:05 ---------- Previous post was at 17:39 ----------

@martyfender, please evaluate my 2019020103 build. The XDA link has been updated to point to this thread (whose OP refers only to kantjer's builds, but my builds don't have their own thread) and the source link has been updated to point to my GitHub repo. However, where John chose the project page, I have instead opted for the commit history, as that seems more pertinent to these bleeding-edge builds.

Let me know if you're happy with this as a replacement changelog or whether you'd like to see something else as well. Obviously, you'll need to update MM once before you're in a position to view the changes in an updated MM in my next build, but you'll be able to see now already whether this satisfies your need.
[Magisk] martyfender:
Yes, that is better. Turns out I have your Magisk Builds page bookmarked, so I was not seeing the changes on your Magisk github page. Having it in MM as about, changelog was convenient because I didn't have to launch the browser when using the tablets. At home I use my linux Mint desktop.

Thanks
[Magisk] ianmacd:
After sending my message, I realised, of course, that this isn't quite as useful as a changelog, because it's not static. In other words, the GitHub page will always show you which commits the latest version has, but not which commits were already present in the version you are currently running. I have to think about whether that's a problem that needs solving and, if so, how best to tackle it.
[Magisk] Exodusnick79:
See
[Magisk] ianmacd:
I didn't realise canary builds were appearing that infrequently. I guess these unofficial builds do serve a useful purpose, then, for those whose bleeding edge can't be bloody enough.
[Magisk] martyfender:
Yes, that is why I prefer the unofficial builds, because there are more frequent updates with a more of a risk of things broken, of course.

This is one of the few days that topjohnwu has released more than one Canary build in one day.

You released 4 builds today. I think that may a record for you although I know you are not in any kind of contest, but I appreciate all of your hard work.
[Magisk] ianmacd:
How often I update depends on a couple of factors, mostly on what kind of work John is doing.

If John updates the translations for 5 different languages over the course of a day, I may release only one build or even none at all. My reasoning is that probably no-one can get terribly excited about updated strings in their MM app.

If more interesting things are afoot, however, such as is now the case with the UI changes in MM, then I try to get those out to people faster, because, well, that's just more fun, isn't it? Similarly, if new features are being added to Magisk itself or the system is being overhauled in some fundamental way, or some broken feature being fixed, then I try to get those out quickly, too, of course.

I hold back only if I can tell just by looking at the commits that the system is in a state of flux, or if my testing reveals issues. I have a testing branch in which I test every build before I release it. I have only a couple of devices, so this is by no means a guarantee that I'll prevent serious bugs from going out in these unofficial builds, but it's better than nothing.

I've actually had a day when I built 14 or 15 versions over the course of the day and pushed these to the testing branch, but only 3 or 4 of them made it over to the master (a.k.a. release) branch that day.

So my update schedule is totally arbitrary, really, and also dependent on how much time on any given day I can get behind my laptop. Some days, that's hardly at all.

BTW, 2019020201 is already out, again with lots of optimisations and now with support all the way down to API 16.
[Magisk] avd:
Google pay not working?
[Magisk] avd:
And neither is attaching screenshots using the xda app it seems.
[Magisk] guest4711:
Long press the text "magisk manager is uptodate" to display it's changelog...
[Magisk] ianmacd:
Well, well, well. I thought it had disappeared, too. Whilst not exactly intuitive, at least the feature is still there.
[Magisk] martyfender:
Yes that works. How did you discover this. I saw nothing to indicate this behavior. And as Ian stated, it is not exactly intuitive.

I just tried on the Canary build on another device and it only shows the updates for the Magisk Manager. I believe that was the same though, when the about: changelog was still there.
[Magisk] guest4711:
I was playing with the new interface and tried to zoom the version information.

BTW pressing it long is not necessary, short is enough.
[Magisk] ianmacd:
Yes, I run a rather convoluted script as part of my build that constructs a custom changelog. It's still not perfect, though, because if a build is short-lived, the following build will have almost nothing in its changelog. The changelog should really span multiple builds, but that's more complicated, so I haven't got around to it.
[Magisk] Ubimo:
No updates since 13 days from kantjer, hope everything is alright with him?
[Magisk] ridobe:
https://xdaforums.com/apps/magisk/unofficial-magisk-v10-beta-built-t3521901/post78789605
[Magisk] habylab:
Is there a way you can limit it depending on the date of the last Canary build? Maybe that's the best way to do it. Not saying it's easy though!
[Magisk] ianmacd:
Well, there's really no intrinsic relationship between my builds and the canary builds, and no-one who runs the canary builds is switching to mine to get a more up-to-date build until the next canary release, because package signatures make that too cumbersome to do.

I'll come up with something eventually. All of the changes do appear in the changelog of whichever build first incorporates them. The only issue is that people who skip a build don't get to see very changelog, but then again, there are probably a lot of people who don't even look at the changelog and care only about running the latest build.
[Magisk] habylab:
Anyone finding it takes far longer with the new UI (not sure if related) to check for updates?

That's fine by me. I'm patient enough for Canary, as builds are pushed out when there are worthwhile updates. Not saying yours aren't, but I know there have been issues in the past.
[Magisk] jsaxon2:
Same here on HTC 10.
[Magisk] opz187:
same here. can't unpack boot. angler
[Magisk] Artim_96:
And same here. So just all skip it
[Magisk] MrWolfman:
same on s6 :(
[Magisk] Deic:
topjohnwu changed bootimgtools binary name to magiskboot and modified it... I replace every thing related with bootimgtools and equally didn't work, included removing the exit in the status error conparising to follow the installation and not work too...

*****************************
Magisk v170311 Boot Image Patcher
*****************************
- Mounting /system(ro), /cache, /data
- Device platform: arm64
- Constructing environment
- /data/magisk.img detected!
- Mounting /data/magisk.img to /magisk
- Found Boot Image: /dev/block/mmcblk0p7
- Unpacking boot image
MagiskBoot (by topjohnwu) - Boot Image Modification Tool

Parsing boot image: [/dev/block/mmcblk0p7]

IMG [AOSP]
KERNEL [6724781] @ 0x40080000
RAMDISK [1673975] @ 0x44000000
SECOND [0] @ 0x40f00000
DTB [0] @ 0x4e000000
PAGESIZE [2048]
NAME [7.3.9]
CMDLINE [bootopt=64S3,32N2,64N2]
COMPRESSION [gzip]

Decompressing to [ramdisk.cpio]

! Unable to unpack boot image

the binary not shows error message, so I guess the binary modification​ is incomplete and we have to wait to topjohnwu finish it.

EDIT:

the magiskboot binary is fine, the problem is that now extract ramdisk as ramdisk.cpio not ramdisk.gz... I see that I can to do after, now I haven't got time.
[Magisk] Mezabaru:
Well I have to say that's a bit different, I'm x

Curious to see it in action, starting to feel the next official release is going to be quite the changelog.
[Magisk] czmasterlp:
I cant update magisk or install modules... SM-G925

Here is logs...
[Magisk] topjohnwu:
Proper build scripts and flashing scripts are now live, unofficial builds shall now work properly.
[Magisk] LPW00:
That's nice! Thanks for ur hard work!
[Magisk] Xephyrex:
I keep getting "Unable to unpack boot image" when attempting to flash using TWRP, can anyone help?
[Magisk] jsaxon2:
When attempting to flash what? Which version? Did you compile yourself or use one from this thread?
[Magisk] Xephyrex:
I got the latest version of the zip and the apk from github https://github.com/stangri/MagiskFiles
[Magisk] jsaxon2:
If you read a couple of posts back, you would have seen that there is a problem with that one. Flash the one from 0308 or wait for new version that should compile later today.
[Magisk] Xephyrex:
Ahh right, I see.

---------- Post added at 03:51 PM ---------- Previous post was at 03:50 PM ----------

Magisk works great, however, I seem to be having a problem passing SafetyNet, I was hoping these unofficial builds may help but to no avail so far. I'm running the DittoNote7 rom on my N910C using the Suemax custom kernel. I've been trying to get my device's SELinux status to "Enforcing" for so long now, but I just can't seem to change it from "Permissive". Here's hoping one of these builds will alleviate this problem and SafetyNet will pass.
[Magisk] LPW00:
Lol... Magisk can hide permissive