yashsingh1/xdaforums huggingface dataset:
[Magisk] guest4711:
Your latest build (2019021801) seems to have fixed magisk hide problem - no interrupted system call in log, no stopping of magisk hide since updating (S4 i9505 AOSP-extended on pie). Thanks for the new build!

Edit: Did not fix it. Again read_inotify failed with error 4, interrupted system call.

BTW: When downgrading to your latest well working version magisk ate my modules, too (on another device). But I only had to copy them from the new location (/data/adb/modulesl) to the old one ( /sbin/.magisk/img) and reboot...
[Magisk] daywalk3r666:
with last release safety net on my htc one failed but my moto g passed.previous release works on both

very strange
[Magisk] kantjer:
Same on last Canary build. John is trying to find and fix the cause
[Magisk] PokemonTotalWar:
What is the latest well working version?
[Magisk] guest4711:
20190211xy (Feb 11, 2019). After that there are a lot of changes which made it a little bit more unstable ;)
[Magisk] PokemonTotalWar:
And you didn't run into any problems copying the modules over? Mine fails no matter how I try
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] Hopefully topjohn will quickly fix the issues I noted here on the Canary thread:

https://xdaforums.com/showpost.php?p=78932652&postcount=727

I have flashed [MENTION=7187684]ianmacd[/MENTION] latest build on only 2 of my devices and one passed the safetynet check in the manager and the other does not, just like my other 2 devices on Canary. I'm not sure why?
[Magisk] ianmacd:
That's good to know. I tried restoring magisk.img from a back-up, but that made the device operate very strangely. Next time I test, I will simply move the modules as you suggest.

Thanks for the tip.
[Magisk] martyfender:
I posted and issue on github concerning my last post and that topjohnwu did a commit that is supposed to fix this issue:

https://github.com/topjohnwu/Magisk/commit/660e0dc09a78e311ae8bcaa3566d3631d98647b5
[Magisk] habylab:
I'm sure he'll release a new Canary when it is fixed as people have been asking for one.
[Magisk] martyfender:
He released a new Canary with the commit. 18108
[Magisk] kantjer:
The CTS issue is fixed in that build
[Magisk] habylab:
Thanks. All fine since flashing.
[Magisk] daywalk3r666:
is the magisk hide fix reverted?with the newest release safety net fails again.magisk hide won't save the selected apps.

but only on htc one.moto g 2014 works without any problems

edit: a reboot fix the issue
[Magisk] edzamber:
All good here

S9 G960f on my own custom Rom base CSB3 TW + Permissive kernel
[Magisk] daywalk3r666:
now its working
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] The latest version has been working well for me, with one ongoing issue through quite a few versions. After update, on first reboot only, I get a bootloop, stuck on the boot animation. It has happened randomly on all three of my devices with [MENTION=7187684]ianmacd[/MENTION] builds and Canary on the other 2 devices I have it on. When this happens I have to hold the power button to force a shut down. When I boot up again everything is

usually

good from then on.

Does anyone have any ideas what would cause this? I can't provide an adb logcat at boot when this happens, because it will not start until the device is actually past the boot animation stage.

Thanks
[Magisk] jenslody:
Did you try to place a logcat boot script in postfs-data as described here: https://didgeridoohan.com/magisk/MagiskHelpBugs ?
[Magisk] habylab:
Anyone experiencing issues with the latest version as of posting? Will try it if not.
[Magisk] guest4711:
Flashed it in the morning. Magisk Hide still working (no interrupted system call for 8hrs). :good:
[Magisk] martyfender:
I don't think that would work when stuck on the boot animation. On my devices, adb logcat doesn't start until the device is almost fully booted up.

---------- Post added at 11:18 AM ---------- Previous post was at 10:50 AM ----------

@ianmacd I noticed in the changelog you reverted several changes that [MENTION=4470081]topjohnwu[/MENTION] made to the code. Did you find issues with those latest commits?

Thanks
[Magisk] jenslody:
That's why I wrote it, when bringing up Pie for my device I was sometimes stuck at bootanimation or it just rebooted in the middle of the bootanimation.

But Magisk was running anyway and the logcat started in the script has nothing to do with adb logcat, which often does not work before unlocking the device for security purposes.
[Magisk] ianmacd:
I did experience a problem with the cpio changes. There was a compile error and the problematic commit couldn't be reverted without also reverting other cpio-related commits made after it, so I had to bin the lot.
[Magisk] jcmm11:
[MENTION=4667597]Didgeridoohan[/MENTION]

I've made a slight modification to that script to prevent it from filling up the partition.

#!/system/bin/sh
rm -f /cache/bootlog_last.log
[ -e /cache/bootlog.log ]&&mv /cache/bootlog.log /cache/bootlog_last.log
logcat -f /cache/bootlog.log &
sleep 15
kill %1
exit

You can adjust the sleep time to suit.
[Magisk] Tornado15550:
I can confirm that I've experienced this on the pixel 2 xl as well. It's not too much of a big deal because a hard reboot fixes it and boots me into the system properly. Glad to know that I'm not the only one facing the issue.
[Magisk] KaMyKaSii:
Did you really mean boot animation or did you want to refer to boot logo? I have a similar problem on my Zenfone 4, after powering on/rebooting, some random boots simply stuck on the boot logo, forcing me to do a hard reboot. But I'm using the latest Magisk Canary Release, not some unofficial build. If your problem is being stuck on boot animation, you can install Liveboot and send the log (boot to TWRP immediately and catch /cache/liveboot.txt) after the problem occurs. If the problem is stuck on the boot logo, you can send the last kernel log (/proc/last_kmsg or /sys/fs/pstore/console-ramoops)

Edit: attached is my kernel log after being stucked on the boot logo again
[Magisk] martyfender:
Yes, it is the Nextbook logo scrolling across the screen. I do see the boot logo before that, then a second or 2 pause before the boot animation is shown.
[Magisk] guest4711:
So magisk is loaded and you should be able to catch a log using the method explained a few posts ago...
[Magisk] martyfender:
Maybe after work or tomorrow when I am off. I also have noticed the last couple of times, if I flash the stock boot.img followed by the magisk. Zip in twrp, it did not happen again until the next update, but that could be because I had previously forced a shutdown, then successfully booted before I did that.

When the next [MENTION=7187684]ianmacd[/MENTION] release comes, I may flash stock boot.img before I update the magisk.zip, to see if that makes a difference.
[Magisk] martyfender:
I tried the boot script but I must have done something wrong. I created a text file with Mixplorer and copied the text from the post and saved it. I changed the permissions to 755. I see no file created in cache.

In the text editor in Mixplorer it shows up as one line, could that be the problem? In your post it shows up as multiple lines.

UPDATE: I am definitely a newb when it come to doing such a script. When I put them on separate lines, it worked. why is that? copying and pasting this does not obviously do this. Is it something to do with carage returns and line feeds? I used Android to do this and not Windows.

I could post that log is you think it would be useful, but the device obviously boots up fine now since it is not the first boot after update. I posted the log, anyway and will do one with the next [MENTION=7187684]ianmacd[/MENTION] update.

By the way, [MENTION=7187684]ianmacd[/MENTION], did you figure out why the latest commit would not compile? I see [MENTION=4470081]topjohnwu[/MENTION] has been busy today again with more commits, while I was at work.

Thanks to all of you for your great help!
[Magisk] ianmacd:
I haven't had a chance to look at it yet. I had an early morning flight today.

I missed my connection, though, so I'm stuck in Dubai now until the middle of the night, so I'll try to put together a new build this evening.
[Magisk] Didgeridoohan:
Don't forget to update FrankeNDK.

https://twitter.com/topjohnwu/status/1099119913061494785
[Magisk] ianmacd:
Thank you. I hadn't seen that. And now I get to pull it over this lovely airport hotel wi-fi that I'm lumbered with, which is rather like trying to suck a golf ball through a garden hose.

While I'm waiting, I tried another compile with the latest commits and cpio is still giving me trouble. Maybe that's NDK-related, maybe not. I won't know until I've pulled the updated NDK.

EDIT: Yes, the old NDK was the issue. Magisk is building again now.

Build 2019022401 compiled and pushed.
[Magisk] daywalk3r666:
last release ends with endless booting with reboot into twrp.

android 9 moto g 2014.tomorrow i will try to grab a lig
[Magisk] guest4711:
Installed without problems on my i9505 running Pie... Thanks for your build. :good:
[Magisk] hsiehboss:
last release can not boot。

nexus 6p statiXOS 9

我從使用 Tapatalk 的 Nexus 6P 發送
[Magisk] neekless:
Also failed to boot on my pixel 2 xl
[Magisk] martyfender:
Build 2019022401 worked fine on 2 devices. On a third device, when rebooted, it stuck on the boot logo. This was a different device than previously mentioned that was stuck on the boot animation. Flashing a stock boot.img, followed by Build 2019022401, solved the problem.

On the device that was stuck on the boot animation in previous builds, I first flashed a stock boot.img, followed by Build 2019022401, with no problems.

All 3 devices are now working well as expected.

Could previously patched boot.imgs be getting corrupted some how on patching again with a newer version?
[Magisk] daywalk3r666:
it seems magisk module rated.clean install with last release it boots perfect.flashing modules bootloop with booting into twrp

edit:maybe kernel log helps
[Magisk] rabiddoughnuts:
[/COLOR]

And to no avail, ran uninstaller, then tried rebooting, ended up back at twrp, flashed stock boot img over twrp now that magisk should be uninstalled, still no go, should have stuck with messed up google stuff maybe? Anyone got any other steps to try before I reset? would hate to factory reset unnecessarily, or reset and it not be fixed.

EDIT : and took ota straight from essential through adb in recovery, claimed it updated, but still wouldnt boot, tried running their fastboot version, still no dice, factory reset finally did it, scared to try it clean now. really dont want to go through a cycle of resets till I figure out what went wrong for me.
[Magisk] jcmm11:
You may well have problems flashing modules into the latest Canary or unofficial builds. There's no more magisk.img file so we're going to need a new template and the modules are going to have to be upgraded.

Already installed modules will transfer with no problem, it's only new modules that are problematic.

For the moment you can either set them up manually (extract the files and place them where they belong) or wait for an update.
[Magisk] daywalk3r666:
but on my htc one i have no problem with modules
[Magisk] ianmacd:
Xposed module working again.

[MENTION=4470081]topjohnwu[/MENTION] has traced the origin of the Xposed module not working and fixed the bug. Thanks, John!

ianmacd build 2019022502 contains the fix and is verified working on my Samsung S9+ (with John's Xposed module enabled).

This joyous occasion means I can now return to testing my builds before releasing them to the public.
[Magisk] neekless:
I think my failed boot is due to v4a module. removed that and it booted. tried flashing it after that and it got stuck while flashing. gonna live without v4a until zack updates it ¯\_(ツ)_/¯
[Magisk] martyfender:
With the latest unofficial and Canary builds, my 5 devices are all booting up normally again after updating, with no bootloops like before.

Update: As it should be, this appears to be the best release yet, for my devices.

Thanks, [MENTION=4470081]topjohnwu[/MENTION] [MENTION=7187684]ianmacd[/MENTION]
[Magisk] neekless:
[MENTION=7187684]ianmacd[/MENTION] are you running zack's viper4android module on your latest build?
[Magisk] ianmacd:
Yes, indeed. I've just checked it and it's working fine for me.
[Magisk] neekless:
Thanks, I've got it installed now.

Installing via twrp failed for me. It didn't even prompt me for vol keys and just attempted to install the default configuration, but gets stuck in installing.

Installing via magisk manager gets stuck on decompressing the first try, but on the second try it installed properly, with vol key prompts and everything.
[Magisk] martyfender:
For many of us, with this new build and also with the latest Canary build, Magisk Manager is crashing when trying to access the hide list. Clearing the app data does not help. I have provided logs for the Canary build in that thread.
[Magisk] Kglim:
Hi sir. Really appreciate for your work ?️?️

But I cannot pass the safetyNet checks after I updated build to 030201 version.

Is this related to substratum?

Everytimes I failed to pass the safetyNet checks is when my substratum can theme Sbrowser and Playstore app.

( I installed and activated substratum them on Sbrowser and Playstore but didn't work when safetyNet checks success)

By the way 030201 magisk manager is awesome for hide apps more variety! Thank you so much ?️
[Magisk] radz_:
Safety net is also failed with the latest official Canary
[Magisk] martyfender:
On my devices, it is working on both the latest unofficial and Canary builds.
[Magisk] habylab:
It's something they must have changed in the latest update, but I've been told this can fix it (sorry for the screenshot, can't remember where I saw this post).
[Magisk] neekless:
[MENTION=7187684]ianmacd[/MENTION] am I correct to assume 2019030502 reverted the zygote ptracing commits?
[Magisk] ianmacd:
Yes.

John took the unusual step of resetting the master branch to remove the new ptrace code, so I did the same with mine.

The ptrace code has been moved to a separate branch, which I'm assuming will be developed in parallel for the time being. The ptrace code in its current state runs fine on one of my devices, but puts the other into a boot loop, so it's quite raw at the moment. Raw is the nature of snapshots anyway, of course, so I'm not sure why John opted to move the code to a separate branch. Perhaps he intends to produce a separate set of canary builds for this branch.

All of this is conjecture. I haven't seen him create a separate branch like this before.
[Magisk] bggold:
I know this has been an issue the past week.

Is there a know reason why safetynet is failing on all your builds after 2-28? I have flashed each one has they come out on my pixel 3 xl and each one fails the check. Reverting back to 2-28 fixes it.

Thanks

Thanks
[Magisk] neekless:
Thanks for clarifying. The ptrace code was causing safetynet fails for me. And I saw in the magisk log that proc_monitor wasn't catching all my magiskhidden apps/processes(?). I have magiskhidden a banking app, a transport app (only hidden because it was asking for root), google pay, and gms.unstable. The proc_monitor was catching my banking app and transport app, but not google pay and gms.unstable, the latter I suspect was the cause of my safetynet fails.

Updating to 2019030502 caused safetynet to pass again, and proc_monitor was correctly catching all magiskhidden apps/processes.

---------- Post added at 09:54 AM ---------- Previous post was at 09:52 AM ----------

Do you have any modules/mods that might cause this? My (Pixel2XL) safetynet has passed in all recent builds by Ian, except 2019030501 which had the zygote ptrace code.
[Magisk] bggold:
I will go ahead and flash the latest build after I disable all of them. If it passes I will do the old process of elimination and enable one at a time.

Thanks for the idea. It didn't occur to me that a module might cause that.

Thanks
[Magisk] ianmacd:
Magisk works at such a low level that it becomes extremely sensitive to device implementation details that don't matter to any other user-installable piece of software.

Magiskhide currently isn't hiding Magisk for my banking app on my S9+, but the ptrace code made it work again. It will be interesting to see where the code goes from here.
[Magisk] bggold:
[MENTION=817664]neck[/MENTION]less

EDIT:. Well that was sort of a bust. I disabled all modules updated and passed. Enabled one at a time and now with them all enabled I pass. Will have to see on the next update.

Thanks again for the idea it did fix it.

Well it did it again. It seems that the latest edxposed is no longer passing safetynet. Will open an issue with them. They can work with topjohnwu. Weird that it works fine with 2-28 build of magisk. Well I should say that there is always changes being made.

Last update but just in case others have this issue.

Add Google play services to edxposed blacklist.

Credit to [MENTION=5696257]PokemonTotalWar[/MENTION]

Well lost it again. That's seems to not work.
[Magisk] martyfender:
Sorry, but I am a bit confused by this. I mistakenly thought this was the code that caused Magisk Manger to crash when trying to access the Magisk Hide list, but it still happens for me. I can, however, access it through the teminal with the magiskhide command.

Thanks
[Magisk] neekless:
I think your hide list crash was happening even before John added the ptrace code. I don't think John has done anything regarding your problem yet.
[Magisk] martyfender:
Yes, with todays build, even in the terminal it works when adding an app and removing it, but the magisk.log shows the start of a crash, but nothing more in the log. However, these are release and not debug builds, so that may be why?
[Magisk] jenslody:
It's just to dangerous for daily use, because it can (e.g.) freeze your device, and this will probably be hard to fix for normal users, especially on modern devices with non-removable batteries.

He wants to test it on all his devices (and iron out found bugs) and then probably do internal tests before pushing it to a public available channel.
[Magisk] ianmacd:
Correct. Marty reported that issue prior to the ptrace code going in.

---------- Post added at 09:03 ---------- Previous post was at 08:53 ----------

Well, that's what I assumed, although I would contend that canary builds, by their nature, are not for the faint-hearted. They're prone to break in new and interesting ways, often resulting in an unbootable device. Anyone not comfortable with recovering from such a situation ought not to be running them. Remember: Some canaries encounter carbon monoxide in the mine and die! :fingers-crossed:

UPDATE:

LOL. No sooner do I post that, than John merges the ptrace branch back into master.

2019030601 pushed. Flashing via MM gave no error on my S9+, but resulted in no Magisk on boot. Maybe a simple reboot would have fixed it, but I instead flashed Magisk in TWRP to make sure.

The exact same code presented no problems yesterday in 2019030501 on this device. My Tab S4 (another Android 8.x Samsung) won't boot with it, though, so your mileage will almost certainly vary.

My first boot was absent Chainfire's LiveBoot, oddly enough, though this returned the next time I rebooted.

Magiskhide works again for me.
[Magisk] Tornado15550:
What's interesting is that yesterday's build (prior to removing the ptrace code) had Magisk Hide running fine on my P2 XL but the device was running quite sluggish. And there were significant slowdowns when accessing settings> apps > see all apps.

Today's build was very snappy but Magisk Hide failed to hide my app even post reboot so I downgraded to yesterday's second build.
[Magisk] ianmacd:
This really demonstrates how tough John's job is in supporting such a heterogeneous environment as Android. Today's build breaks your Magiskhide functionality, but fixes mine. LOL.
[Magisk] DenyDarko:
Those new changes have been readded to the repo.

Had anyone the chance to test them?

Any explosions on OP devices? ?
[Magisk] neekless:
What modules have you installed and are you running any scripts?
[Magisk] ianmacd:
You could have saved yourself the question if you had read before you wrote.
[Magisk] Tornado15550:
Youtube Vanced and its detach module, systemless adblock hosts module (comes built in with MM), and a Pixel Camera permissions module. I'm not running any scripts. I'll try a complete uninstall and re-install the latest build when I get some spare time to see if that fixes the issue, but so far things are running well on yesterday's second Magisk build (18.2-2019030502).
[Magisk] DenyDarko:
Just because it's buggy on one device doesn't mean it has to be on every device.

That was always the case.

That's why I'm asking, just in case there is positive feedback too.
[Magisk] neekless:
Nvm I thought a script of mine was causing safetynet not to pass.

This ptrace code is a hit or miss for me. On some boots I pass safetynet and all my magiskhidden processes are correctly caught by proc_monitor, the critical one being gms.unstable. On other boots I fail safetynet because my gms.unstable is not caught by proc_monitor.
[Magisk] ianmacd:
Well, I gave my experience of running the code on two devices, not one, and on one of them the experience was ultimately positive.

Fair enough, but what you actually wrote was:

which was information that had already been given, and:

And "anyone" had tested them, and had already reported his findings. And another user had already responded with his findings, too.

In other words, your wording was that of someone who hadn't read the postings of even an hour earlier; hence my comment.
[Magisk] DenyDarko:
Jesus Christ, I've missed some grammar on my post, burn me alive.

Sorry for the interruption, move on I'm leaving.
[Magisk] bggold:
Same here today's build fails safetynet. Went back to yesterday's second build with no issues. No edxposed loaded either. I'm sure topjohnwu will get it all ironed out soon.
[Magisk] martyfender:
On the one device I tried today's build on it bootlooped on the boot animation, so I reverted also.

I had to flash the uninstaller first, then reflash magisk.
[Magisk] bggold:
I also had to use the uninstaller the past couple times. There must be changed to the database occuring in these builds. I don't think I ever had to use the uninstaller in the past. Probably a good sign of changes.
[Magisk] martyfender:
Yes, I had to use the uninstaller because when I reflashed a previous version, upon reboots, it showed Magisk was not installed.
[Magisk] PokemonTotalWar:
Blacklisting GMS still allows EdXposed to pass for me on today's build, but I'm also having to disable and reenable magiskhide on reboot no matter what modules I have loaded on today's build
[Magisk] ianmacd:
Same here on one of my devices. Most Magisk foul-ups are easily corrected with a reflash, but this particular problem was quite resistant to correction.

An alternative solution is to just move the Magisk directory out of the way:

# mv /data/adb /data/adb~

The advantage of this is that when you reinstall Magisk, you can move your modules directory back into place.

I didn't bother spending the time to figure out which file in /data/adb was causing Magisk to appear not to be installed following subsequent reflashes.