yashsingh1/xdaforums huggingface dataset:
[Magisk] martyfender:
From my experience, MM won't let you update Magisk, until you have updated the Manager, although it is possible to do that in TWRP by flashing the zip first. I was on the latest MM when I updated Magisk.

When I reverted to the older, v19.1-2019032901, I uninstalled and reinstalled the older manager, also. The above is true for recent versions of Magisk.
[Magisk] martyfender:
I tried updating to todays build and had the same result. Attached is the recovery log. When I have time later, I may run your latest uninstaller and try again.

Your latest uninstaller also fails with the same error in TWRP. I will try this older one: Magisk-uninstaller-v19.1-2019032901. That uninstaller worked. Unfortunately, reflashing the magisk.zip still failed. I still had the patched boot from yesterdays build. I uninstalled MM, then I flashed the patched boot.img, successfully. When I open MM I get the dialog, requires additional setup, which I do. I reinstall all modules from the manager and reboot, and unfortunately, they are not there. Even the systemless hosts module, which I had clicked on previously in settings before rebooting.

I also used the direct install from there to update todays build, from today's MM.

When I rebooted it went to bootloader mode with an error, so I had to shut down, boot to TWRP and reflash my stock and the previous, working version of Magisk and I come back, full circle. All of my modules are showing up again and are working: Busybox NDK, App Systemizer terminal emulator, Enable Doze for GMS and Magisk Hide Props Config.

So I had the same issue I had in the past with direct install that caused me to use TWRP for flashing.

I will wait for a new Canary release by [MENTION=4470081]topjohnwu[/MENTION] to test on my 2 devices with the Canary debug builds.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] [MENTION=4470081]topjohnwu[/MENTION]

I just flashed v2019033102, using the patched boot.img method and as expected, the modules are still not showing up. I am attaching a magisk.log. Note the. Busybox error:

Does anyone have any idea about this error?

In a working installation I see no such error, I see this:

My architecture is x86. Device info is in my signature.

Thanks
[Magisk] Kglim:
I can see the crash start in log at the bottom.
[Magisk] Ubimo:
Is there anything unusual in my magisk log?

What's

/system/xbin/fakeidentd

or

hide_list init: [org.microg.gms.droidguard/com.google.android.gms.unstable]

Is this normal?

Edit:

I find these entries in the logs posted above too. I guess that's normal.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] [MENTION=4667597]Didgeridoohan[/MENTION]

I tried again to flash todays build, v2019040101 in TWRP, unsuccessfully.

once again I immediately flashed v2019032901 too bring back a working solution.

Is there a difference in the updater script between versions?

Attached is the recovery log where both versions were flashed. Note the line: target image, in both flash instances, they are different. So it appears that in the first it is not unpacking the boot.img.

Does anyone have any ideas what is going on? Also see my previous posts above.

Thanks
[Magisk] ianmacd:
Yes, there's definitely some oddness there:

- Target image: /dev/block/platform/pci0000
- Device platform: x86
- Constructing environment
/dev/tmp/install/META-INF/com/google/android/updater-script: line 97: can't open /dev/block/platform/pci0000: no such file
Updater process ended with ERROR: 1
I:Legacy property environment disabled.
I:Install took 2 second(s).
Error installing zip file '/sdcard/Download/Magisk-v19.1-2019040101-ianmacd(2019040101).zip'

It seems boot partition detection is failing, no doubt as a side-effect of the recovery-based Magisk code having been added.
[Magisk] hshah:
I reflashed a ROM on my Note 8 and then went to flash today's build via TWRP. Tried multiple times and even cleared MM data but every it apparently wasn't installed.

So I flaahed the latest Canary, which worked straight away and then flashed today's build after.

Got there eventually, but I'm guessing the extra step shouldn't have been required?
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION]

Also in the patched boot.img method I did yesterday, there is a busybox error, like it is detecting my x86 arch as arm, for example. That is about as close as I found from a search of the error:

* Setting up internal busybox
execve /sbin/.magisk/busybox/busybox failed with 8: Exec format error

I was hoping to get some more insight from someone about this issue. Especially about the busybox error.

Thanks
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] [MENTION=4470081]topjohnwu[/MENTION]

After flashing your latest build, v2019040201, using the patched boot.img method, since flashing in TWRP fails, I discovered that apparently all of my modules work despite not showing up in modules or downloads in the Magisk Manager. So I assume they have been working all along in the last few builds, they are just not showing up. The magisk.log still shows the previously mentioned busybox error.

Just out of curiosity, I tried replacing the internal busybox in /sbin/.magisk/busybox/ with the osmosis version and setting the same permissions: 755, but it gets replaced on a reboot.

executing /sbin/.magisk/busybox/busybox works in the terminal, so I don't think that it is the cause of the error?

Thanks
[Magisk] dingolino:
Hi guys,

I was not paying attention to my phone and the corresponding forums for the last 6 months or so. I was just happy that everything was working as it should. But now I am wondering about the unofficial updates from kantjer what I have installed on my phone. In the past once a week there was a update. My Magisk version is v18.1.r17.

So I am guessing that I am missing something. Is kantjer still working? Or what other reason could be for not receiving Magisk updates?

Please help me out with some quick info.

Many thanks

dingolino
[Magisk] martyfender:
His Linux system died and he rebuilt it, but decided not to build anymore, since there are Canary builds and [MENTION=7187684]ianmacd[/MENTION] builds.

I would suggest the latest beta v19, Canary builds or [MENTION=7187684]ianmacd[/MENTION] unofficial builds. Since you do not update that often, my recommendation would lean toward betav19 or the Canary builds.
[Magisk] hshah:
Sorry but I'm not really sure what that has to do with this thread...
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] Hello, Ian. I noticed earlier today that you released a test build: v9.1-2019040502, but not one to the master so I assume you had issues. Move forward hours later and I just got home from work and was slightly bored, so I thought, what the hell, I will try it. On the last few builds on one device only, updating in twrp has failed, although, I didn't try yesterdays in twrp. the last few builds I have used the patched boot.img method and all of my modules worked, they did not show up in MM downloads or modules section.

With todays test build, I was able to successfully flash in twrp and all appears to be working again.

Do you think that it was this commit:

that solved my flash in twrp problem?

I am just curious, what issues did you have with these: v19.1-2019040501 and v19.1-2019040502 builds?

I think [MENTION=4470081]topjohnwu[/MENTION] is getting close to a new Canary build, also, to test on my other 2 devices on the Canary debug build.

Thanks
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I've successfully updated my 3 devices on your build to v2019040601 and the other 2 devices to the latest Canary debug v19002.

Thanks
[Magisk] ianmacd:
Yes, the above builds were unrooting my devices, a problem also present in my first build today, which did make it to the master branch, because it worked on one of my devices. It appears that only some Samsung devices were affected.

The bug was finally tracked down this evening and build 2019040602 restores service to all Samsung devices.

I know a fix went in yesterday to make recovery work again, so this is probably why your devices started to work yesterday.
[Magisk] Ace42:
I would use Magisk uninstaller to remove current build first, not a good idea to flash nighty over stable. To be safe I'd wipe system, reflash the rom + gapps, and then flash Ian's Magisk.

No probs on my ancient Note 4 + LOS16, so it should def work with an S5.
[Magisk] techloverxda:
Is the 19 version a stable version? My magisk is the 18th version and it says that is updated.
[Magisk] daywalk3r666:
no its beta channel
[Magisk] guest4711:
Even clean installing (wiping everything, installing ROM, booting, shutting down, installing Magisk from TWRP or installing ROM and Magisk) did not work for Magisk > stable on my klte with Android P. After staying on boot logo for 1' it reboots into download mode. Booting into TWRP and wiping dalvik+cache does not help.

So staying on stable now.

When I'll have enough time I'll try to get logs with canary.
[Magisk] psychoela:
[MENTION=7187684]ianmacd[/MENTION] version 0408,0409 n 0410 is not working,bootloop for my n6, here my recovery log, thanks

--------- beginning of main

--------- beginning of system

01-12 13:44:31.664 302 302 I Magisk : Magisk v19.1-2019041001-ianmacd(2019041001) daemon started

01-12 13:44:31.664 302 302 I Magisk : * Device API level: 28

01-12 13:44:31.694 302 303 I Magisk : ** post-fs-data mode running

01-12 13:44:31.697 302 303 I Magisk : * Initializing Magisk environment

01-12 13:44:31.712 302 303 I Magisk : * Mounting mirrors

01-12 13:44:31.712 302 303 I Magisk : mount: /sbin/.magisk/mirror/system

01-12 13:44:31.712 302 303 E Magisk : stat tmpfs failed with 2: No such file or directory

01-12 13:44:31.713 302 303 I Magisk : mount: /sbin/.magisk/mirror/data

01-12 13:44:31.713 302 303 E Magisk : mount /sbin/.magisk/block/data->/sbin/.magisk/mirror/data failed with 16: Device or resource busy

01-12 13:44:31.713 302 303 I Magisk : mount: /sbin/.magisk/mirror/data

01-12 13:44:31.713 302 303 I Magisk : link: /sbin/.magisk/mirror/vendor

01-12 13:44:31.714 302 303 I Magisk : * Setting up internal busybox

01-12 13:44:31.735 302 303 I Magisk : * Running post-fs-data.d scripts

01-12 13:44:31.735 302 303 E Magisk : mount /sbin/.magisk/mirror/data/adb/modules->/sbin/.magisk/modules failed with 2: No such file or directory
[Magisk] edzamber:
Hi mate

This have to do because its updated to work with 19+ Magisk version. Its only an anoucement. This is a life saver if you have uncompatible module installed instead of asking here why your phone bootloop [emoji6]
[Magisk] Kglim:
041101 build mess up the pip mode on Samsung device I think.

After 041101 build causing randomly turns on pip mode with YouTube, Netflix, and all of other pip included apps.

I did everything that I could do to fix with pip mode but failed.

Since I downgrade magisk to 0410 build, it just solved.
[Magisk] hshah:
Have there been no commits recently?
[Magisk] ianmacd:
Not to the master branch.

There has been activity the last couple of days around a new UI for Magisk Manager in a new WIP branch, but as the name suggests, that's a work in progress.

As soon as the master branch sees some new activity, I'll issue a new build.
[Magisk] hshah:
That's alright... I was just indirectly checking that all was good because I was getting withdrawal symptoms from the lack of updates :eek:
[Magisk] ianmacd:
I trust you got your fix late last night with the new build I put up.
[Magisk] hshah:
That I did, and had a lovely nights sleep afterwards :silly:
[Magisk] Kglim:
Why do I get automatically pip turns on forcely since after 0411 build?
[Magisk] guest4711:
My S5 (klte) is running fine with your latest build :svetius:

Thank's a lot!
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] topjohnwu has completed his final exams and released some new commits. I am looking forward to new builds by you.

Thanks
[Magisk] ianmacd:
Thanks.

I saw that this morning, but I had submodule conflicts and I couldn't resolve them before I had to leave. We're travelling on holiday until 5th May, so my builds may not appear as rapidly as you are used to until then.

John has been quiet of late, but I think we can expect a flurry of activity from him now his exams are behind him.

Build 2019043001 is entering the world as I type this.
[Magisk] martyfender:
Have a great and safe trip.

Thanks
[Magisk] Ubimo:
Whoa, the new log during magisk flash is nerdy. :)

I freaked out at first, thinking it's a virus. :eek:
[Magisk] ianmacd:
This is the output one sees when boot_patch.sh is run at the command line. It's very convenient to be able to see the details in MM now, too.
[Magisk] geko37:
On my Samsung s9 pie tgp i can install Magisk-v19.1-2019042301-ianmacd.zip without problems all working fine but all other versions after this says after install that's Magisk is not installed. No root. After flash a older Version all working fine. Anybody have a solution?

Gesendet von meinem SM-G960F mit Tapatalk
[Magisk] Tornado15550:
The new Magisk Manager UI is sexy!!
[Magisk] RagingHarry:
Love the 4 updates today, the new look of the terminal almost pushes me to to change my desktop back to Ubuntu or Debian again cause of all that nice detailed commandline pron to look at.
[Magisk] habylab:
Screenshot?
[Magisk] guest4711:
Here you are...
[Magisk] martyfender:
On my 8" Nextbook Ares 8A, Intel x86, Android 6.0.1 tablets, the text is very tiny, which is surprising. I always use them in landscape mode. In the display settings I have the font size set to huge. I will attach a screenshot. Xdpi is 188. I posted in the MM redesign thread, also.

Also, [MENTION=7187684]ianmacd[/MENTION] , on one of my three tablets that I have your build on, note the com. etc under your build number on the opening page, in my screenshot. I only see that on one device. Do you have any idea what that is, or is my device compromised, somehow?

UPDATE: I just realized that this is the only device where I have MM hidden and that is what the package is renamed to. Is this a new feature in the MM redesign?

Thanks
[Magisk] ianmacd:
Do you have Magisk hidden (i.e. repackaged) on that device?
[Magisk] martyfender:
Yes, that was it. Is that a new feature in the redesign? I just recently hid MM on that device.

Thanks
[Magisk] Didgeridoohan:
That's been there since [MENTION=4470081]topjohnwu[/MENTION]'s latest UI redesign in v7.0.0.
[Magisk] dracinn:
The app won't install.

Sorry I figured it out it was user error I had to uninstall manager in other user profile.
[Magisk] guest4711:
No, it's been there since weeks...

But the font is very tiny now, you are right.
[Magisk] ianmacd:
It seems this verbose console logging was a bug and it has now been removed (in my builds, as of 2019050301).

Personally, I liked it and I wish there were a toggle for it in Settings. [MENTION=4470081]topjohnwu[/MENTION]?
[Magisk] guest4711:
+1 :)
[Magisk] psychoela:
Can you checking my log here, this already know issue or what. Thanks

https://drive.google.com/file/d/1msKHDfGbMtIKUGoc8QhkGVDb8hHNMxvH/view?usp=drivesdk
[Magisk] hshah:
I agree! As far as "bugs" go, this was a pretty good one and should be classed as a "feature" :)
[Magisk] guest4711:
You'll get the full output in the saved log (press the floppy symbol after flashing). Example log - cause XDA server does not allow me to add a zipfile, a textfile nor a log:

- Target image: /dev/block/mmcblk0p15
- Device platform: armeabi-v7a
- Downloading zip from [url]https://github.com/ianmacd/MagiskBuilds/raw/master/Magisk-v19.2-2019050301-ianmacd.zip[/url]
... 0%
1014+1 records in
1014+1 records out
1039176 bytes (1014.8KB) copied, 0.013082 seconds, 75.8MB/s
- Unpacking boot image
Parsing boot image: [/dev/block/mmcblk0p15]
HEADER_VER [0]
KERNEL_SZ [8657360]
RAMDISK_SZ [2685542]
SECOND_SZ [0]
EXTRA_SZ [1859584]
RECOV_DTBO_SZ [0]
DTB [0]
OS_VERSION [9.0.0]...
[Magisk] ianmacd:
I know, and that was always the case, but it's very convenient to be able to view the output directly in the console.
[Magisk] rp4k:
how to use your uninstaller on s10+ [MENTION=7187684]ianmacd[/MENTION] . i am having issues with magisk 19.1
[Magisk] martyfender:
You have to flash the uninstaller through TWRP. The other way to do it is to use the uninstall option in Magisk Manager.
[Magisk] AndrzejDwo:
Hi guys! I'd like to ask you if one of yours unofficial builts would be able to fix this problem, or help with taking logs. My friend is going to try logging on his p9 tonight, and every advice from you would be appreciated.

https://xdaforums.com/apps/magisk/dev-magisk-canary-channel-bleeding-edge-t3839337/post79475866

https://github.com/topjohnwu/Magisk/issues/1409

https://github.com/topjohnwu/Magisk/issues/1390
[Magisk] rp4k:
as of now i am having lots of installing issues. with Magisk 19.1 and edxposed installed. so i have to revert back to the older version of magisk on my s10+ i already posted at topjohnwu's github and he said that the issue is with edxposed.
[Magisk] rp4k:
Magisk Manager: MagiskManager-v7.1.3-2019051001-ianmacd

Magisk : latest build from Inamacd Repo

Modules in Magisk :

libsecure_storage

Riru-Core V19

Riru - Ed Xposed v0.4.1.2 beta Sandhook

Systemless Hosts

Edxposed v 2.2.4 Modules

Firefds Stable -4

Wexposed v2.2

Working

Google play store download & install

ADB install with usb debug

Not working:

Side load APK from phone freezes and doesn't finish

Galaxy Store install applicaitons freezes and doesn't finish

i dont know how to fix this issue.. factory reset works and then everything works again but then stops working a few hours later so i dont know if its a settings issues or what.
[Magisk] psychoela:
[MENTION=7187684]ianmacd[/MENTION] Finally problem completed with version Magisk-v19.2-2019051101. Thanks:D
[Magisk] rp4k:
[MENTION=7187684]ianmacd[/MENTION] i am not getting requests from edxposed or firefds on the latest build in your github of magisk .
[Magisk] dynospectrum:
Firefds doesn't ask for root because it doesn't have to. EdXposed still asks for root on latest Magisk from Ian's git (but install with root in EdXposed has never worked for me on s10+).
[Magisk] rp4k:
My edxposed has never asked for root and idk why. And I am on [MENTION=7187684]ianmacd[/MENTION] latest build
[Magisk] psychoela:
sorry for this, to get root query, try to go to module log in edxposed or try activating black and white list:D
[Magisk] rp4k:
Yes this is what worked to get it to showed up. But now on the latest [MENTION=7187684]ianmacd[/MENTION] build . I am having lots of issues with edxpose modules but only after installing [MENTION=3844620]firefds[/MENTION] for pie. So if i don't install that edxposed module my phone works fine.
[Magisk] rp4k:
i factory reset my device and now it says "official released binaries only " in red and it wont boot at all. idk what to do.. i dont know how to force it to go into download mode i tried plugging it into the computer but it doesn't help. it just keeps restarting over and over again i only see the Samsung S10+ with the Yellow Triangle logo with that message at the top then it reboots. " anyone got any ideas how i can fix this there isn't a samsung store near me. i tried ADB but it doesn't recognize it.
[Magisk] guest4711:
You should ask in your device forum.

On most Sammy devices pressing Power, Home and Volume- simultanous for several seconds brings you to the download (ODIN) mode, Power, Home, Volume+ to recovery mode. Power off the device before.
[Magisk] rp4k:
I fixed it but thank you. I want to ask has anyone see issues with asd6 firmware and [MENTION=7187684]ianmacd[/MENTION] latest magisk manager & magisk build. I have zero modules installed and my titanium backups won't restore.
[Magisk] philcoo2:
Hi, is anyone else having an issue with the latest manager released 13/05? It shows as downloaded and then shows error parsing the package.

I have tried downloading separately and trying to install but same error.

Samsung galaxy A8 2018 9.00 running ianmac from 11/05.

Thank you
[Magisk] DenyDarko:
https://github.com/topjohnwu/Magisk/issues/1453
[Magisk] zzz2002:
i am not sure, but it looks as though the built updater downloads the required files and the hides them (not sure why), problem is that it seems lose track of where the files are.

After several attempts to find the files the updater had downloaded, I gave up and downloaded them myself and used TWRP to install the new version and and just clicked on my DLed apk to install the app. Everything seems to work.
[Magisk] philcoo2:
Hopefully attached log for the parsing error.

Hi attached the latest log with parsing error
[Magisk] hshah:
Same, can't install MM :(
[Magisk] martyfender:
It is a known bug in the latest manager, especially on devices with Pie.
[Magisk] hshah:
Is the solution something we have to do on our end or something that needs to be fixed upstream?
[Magisk] jcmm11:
You need to wait for a fix. I could tell you how to update it, but it would then no longer be hidden and you'd be unable to hide it again. (If that's acceptable just go into settings And unhide Manager - just remember you won't be able to hide it again)
[Magisk] hshah:
I have no issue waiting for a resolution. I was just asking because I had no idea what the actual problem was :)
[Magisk] martyfender:
The bug has been posted on the github issues section:

https://github.com/topjohnwu/Magisk/issues/1453
[Magisk] philcoo2:
Parsing error fixed, the latest build 14/5 has fixed the error.

Thanks [MENTION=7187684]ianmacd[/MENTION]
[Magisk] hshah:
Confirmed :good:
[Magisk] rp4k:
Latest update kind of messed little with my 4g signal
[Magisk] hshah:
Not trying to imply you are wrong or anything, but I'm curious to find out what makes you think it was the update? My 4G signal tends to vary quite a lot and I've never been able to pinpoint whether it's my network, phone, location, time of day etc etc.
[Magisk] rp4k:
I take the normal daily routine every day for the last 6 years and I have been watching my signal since asd6 came out. Even though the modem is still asd4 I noticed though some of my apps were yesterday in a certain location they had signal . Have 0 signal or lost a little bit of signal today after the flash.
[Magisk] ianmacd:
I don't think it did.

The latest version contains a fix for the issue of MM failing to be repackaged, plus some Catalan translation updates.

If Magisk plays any part at all in your signal loss, assuming your observation is even accurate and enduring, then it will be the result of some wacky module that you have installed.
[Magisk] rp4k:
Ok good to know
[Magisk] Kglim:
Still struggling with the Pip mode.

Even my keyboard, Netflix, and all of the apps that include with pip function.
[Magisk] Didgeridoohan:
That probably means you have a device where the OEM is blocking broadcasts (stupid), which means that Magisk has to launch an activity to communicate with the Manager, resulting in other processes (like pip) losing focus when an app requests su.
[Magisk] Kglim:
Probably related to edxposed I guess.

Thanks dev!
[Magisk] DanGLES3:
Edxposed doesn't block broadcasts,I use Edxposed and this issue was fixed for me in the recent updates of magisk,so it's unlikely an issue with Edxposed,as previously said you might have a device whose stock OS might be blocking broadcasts
[Magisk] Kglim:
Well I'm using custom rom and tested 041001 build and it has no any problem with broadcast thing.

This keep happening when root permissions has been allowed.

Recently I updated magisk to 052002 and it seems quite okay when I rebooted right after install but next time keep happening same as what I mentioned.

Thank you ??️
[Magisk] martyfender:
Hello [MENTION=7187684]ianmacd[/MENTION], my curiosity got the best of me, finally. I saw yesterday that you did a couple of test builds which you subsequently pulled later, so I assume you had problems with them on your devices? I am just curious what went wrong with them?

Of course, the current released build is working very well. A problem with Magisk Manger not being able to launch intermittently, seems to be gone.

As I have stated many times, thank for all of your releases.