yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok thanks for the info. And yeah, I don't get why it was accepted in the first place since an auto mail is sent saying that it can't be merged and needs to pass via review.lineageos.org... Anyways, I reverted one of his commits (not entirely, cherry-picked the f2fs stuff from the link above) and I'll see if it works. If the sdcardfs stuff doesn't work, I'll use the main branch :)

Not much people use F2FS for data, I don't use it cause root doesn't work correctly (at least systemless) and too much issues, not enough used by devs. The speed differences can't even be seen IMO.

Guys, first post updated, build launched on 2 PCs (sdcard stuff on home PC, without sdcard stuff on work PC, let's see how it goes).
[OnePlus 3 & 3T Cross Device Development] Sithben24:
Bluetooth settings freeze and reboot the phone every time I go into them. Log attached.
[OnePlus 3 & 3T Cross Device Development] dante_nfs:
[MENTION=6313536]matssa[/MENTION] going to test the new build with sdcardfs and my data partition in f2fs, do we need to flash the 4.0.1 firmware ?

how can I check for deadlock?
[OnePlus 3 & 3T Cross Device Development] matssa:
Please be very VERY carefull! I'm not sure if it works correctly, or if the stuff has been merged correctly. From my point of view, you should stay on your build and don't use it unless you know what you do and not afraid to recovery etc... I cleaned my repo in order to have everything clean and organized. I'll make a new clean build tonight and another one with the sdcards stuff.
[OnePlus 3 & 3T Cross Device Development] dante_nfs:
well I'm here to help , i will flash it you can count on my help and no, I'm not afraid of some adventure :fingers-crossed::cool:
[OnePlus 3 & 3T Cross Device Development] matssa:
Hehe ok well please make sure to backup everything just in case! Sorry for the miss-building, was too greedy and got disorganized. Since i'm learning will i'm doing it, I make some beginner errors and problems ^^
[OnePlus 3 & 3T Cross Device Development] dante_nfs:
well so far so good, no crash no abnormal cpu usage but i think the sdcardfs thing is just bug squishing because there is no speed improvement . in roms with sdcardfs the difference in performance is visible.
[OnePlus 3 & 3T Cross Device Development] matssa:
Ah ok, thanks for the info. [MENTION=4329165]ivanich[/MENTION], how do you know if there are deadlocks? When the phone crashes and reboots? I may not have any on this build since I'm not using the commits for the F2FS stuff. So no deadlocks is normal. Next build will have the kernel stuff with updated linux, so it can be present :)
[OnePlus 3 & 3T Cross Device Development] ivanich:
Deadlocks it's when applications can't open/read/write to their sqlite db files because fs locks all operations, so you will see crashes for most of the apps, however it's only happens with new f2fs code and not related to sdcardfs. Anyway if you use ext4 for /data you unaffected.

Finally, they reverted faulty display blobs commit https://github.com/TheMuppets/propr...mmit/4eba50043fcfb418f6d93029259bedceeb115c76 so livedisplay should be fine now.
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok thanks for the heads up, i'll stop copying the file :) How did you manage to merge the commit https://github.com/LineageOS/androi...mmit/254c780539f19191f13723ec01954f62ab52e66c ? I'm trying but get conflicts. Any help? Seems it's because of 2 parents.
[OnePlus 3 & 3T Cross Device Development] ivanich:
It's not an single commit, it's a merge which contains many more other commits. Moreover it depends on previous merge https://github.com/LineageOS/androi...mmit/29eb37f9271814806faa0a7454b1e4d526720cbc . You can merge whole branch with git merge your_remote_name/cm-14.1
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok thanks, managed to merge it, I cherry-picked the commit that you linked before merging the stuff, so I reverted and merged and voila.

Ok guys, I have two test repos: one for the f2fs stuff with the SuperSU fixes, then I have the sdcardfs stuff. I'll build the first one so that you can test it out, then I'll build the second one with the first stuff if everything is ok.
[OnePlus 3 & 3T Cross Device Development] hasdroid:
So just in case..

F2fs will be applied on /Data file system not on /System 's one right?!

Thanks btw you are building the best LAOS for oneplus 3 out there ?✋
[OnePlus 3 & 3T Cross Device Development] matssa:
F2FS won't be applied unless you format the partitions in TWRP. If you don't format and change the type, then it won't change anything for you if you are on ext4. If, however, you are already on F2FS for data, then you can have issues (or not).

Those who has F2FS, new build is uploading. Can you please test it? Please make sure you backup everything!!! SMS included since restoring backup can wipe SMS data.
[OnePlus 3 & 3T Cross Device Development] EatBeans:
What about oms? Will you include it in future builds?
[OnePlus 3 & 3T Cross Device Development] hasdroid:
Yeah I tried to change file system of cache, data and system by formatting everything with twrp.. So when I flashed you latest build I noticed that it changed system to ext4 so I re-changed everything again to ext4 until we get fully working f2fs build ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
No, not until everything is sorted out. Once this has get a bit calm, I'll try to do it, but it is the least of my problems. Furthermore, the Substratum team should make a merge commit with everything included, as they said before (a lot simpler for ROM devs to port it....).
[OnePlus 3 & 3T Cross Device Development] matssa:
Ah, that's strange... Maybe you can test it with the new build that is uploading, we never know :)
[OnePlus 3 & 3T Cross Device Development] EatBeans:
Ok but someone posted here his repo earlier where all of the oms commits are included so it wouldn't be that difficult.
[OnePlus 3 & 3T Cross Device Development] matssa:
I can't use his repo like that since LineageOS team updates it. I need to fork and commit and merge extra stuff that is merged in review.lineageos. Furthermore, I don't know how many commits are necessary, last time I checked it was about 20, but didn't check more than that.

If you can build, feel free to use the official repo without extra stuff in order to use the correct commits, that way I will cherry-pick them. That way, it will be a lot easier ;) But as I said before, I don't have the time and I'm still learning, I'm not a dev or a software engineer :)
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
Okay! I managed to build with your roomservice in the OP. It was my first build ever, was very excited to see that I've managed to complete it with the help of you and a few others. Hopefully I can help out in some way in the future. Thanks. :good:
[OnePlus 3 & 3T Cross Device Development] matssa:
Hehe no problem! What did you build? Using cm14-1 or a test repo? Mine or ivanich? Do you have enough bandwidth to upload? :)
[OnePlus 3 & 3T Cross Device Development] EatBeans:
Actually I can build but I'm still learning like you but I will try it maybe ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Hehe OK well keep me up to date, and feel free to contact me if you need help in something ;)
[OnePlus 3 & 3T Cross Device Development] ivanich:
[MENTION=6313536]matssa[/MENTION]

I've reverted https://github.com/LineageOS/androi...mmit/0e71fea71137c336f8e5cda752ead1c3488e701b and seems that it was the cause, at least for more than 1 hour all works just fine. If this commit was missing in gemini and other 8996 devices why it has been merged to op3 without any real testing with this particular device?

So please drop/revert this commit for good.

OMG, this is how cm/laos was developed for years... They keep useful and tested commits unmerged for months but pushing some broken crap without any testing. :laugh:
[OnePlus 3 & 3T Cross Device Development] matssa:
Hehe thanks for heads up, I saw your comment in GitHub. I'll check if I already reverted tomorrow, the build is still uploading for those who wants to test it.
[OnePlus 3 & 3T Cross Device Development] ivanich:
So I hope most of the nasty bugs was fixed, except new camera blobs?
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
I can upload it for you, I have pretty good internet on my end, I have not tested it myself though as I did not have time to test it. I use the roomservice available on the OP and skipped the cherrypicks. I simply copied your roomservice and enabled jack server, ran breakfast then brunch. Four hours later it completed!
[OnePlus 3 & 3T Cross Device Development] matssa:
I didn't have a lot of bugs before with beta9 blobs, using the fixes of course. On my end, I don't see any major bugs. However, having the kernel changes will of course help us get the maximum.

For the camera blobs, I'll trust [MENTION=4837394]siankatabg[/MENTION] on this :) furthermore, OnePlus said they would release the full blobs, but when, I'll bet on soon(TM).
[OnePlus 3 & 3T Cross Device Development] matssa:
Nah it's OK, it's mostly for other people so that they can test it :) anyways, nice job! Next build should be faster though.
[OnePlus 3 & 3T Cross Device Development] matssa:
OK guys build is up! I need people using F2FS to test this and see if you get deadlocks, and if SuperSU works.

With this info, I'll change or not the commits. Furthermore, I'll upload the build with the sdcardfs commits tomorrow. Until then, good night!
[OnePlus 3 & 3T Cross Device Development] davemuir:
I'm using F2F2. I'll give it a shot.
[OnePlus 3 & 3T Cross Device Development] ivanich:
Actually we have new camera blobs but kernel sources for this blobs still not released.

BTW, I have random phone vibration when in call, and this is really annoying. Also sometimes can't change volume level during call.
[OnePlus 3 & 3T Cross Device Development] smouker:
54
[OnePlus 3 & 3T Cross Device Development] RohanAJoshi:
For not changing volume level in call, bug preset in all oxygen os also, happened on latest 4.0.1 also.
[OnePlus 3 & 3T Cross Device Development] matssa:
For the volume bug, I get it sometimes as well. However, I don't have the vibration issues :)

Anyone managed to test the new F2FS build? [MENTION=5370545]piats[/MENTION], this build should have the SuperSU fixes as said in https://xdaforums.com/apps/supersu/2014-09-02-supersu-v2-05-t2868133/post70492947#post70492947 . Can you please try it out?

I'll upload a second build with only the sdcardfs stuff, I will need people to test this out too. Please be aware that these two builds don't do anything if you use ext4, you must use F2FS to see if it works correctly or not.
[OnePlus 3 & 3T Cross Device Development] piats:
Well I tried to install SuperSU 2.79 SR2 and it installed fine in recovery but after boot there's no SU app and root is missing. After installing SU app from the playstore su gets installed and device needs to be rebooted. After reboot SU app says root is missing...

Edit: turns out that you need to use this recovery https://xdaforums.com/showpost.php?p=70411336&postcount=2426 to get SuperSU working.
[OnePlus 3 & 3T Cross Device Development] djdeeles:
I have same problem how can i install supersu?
[OnePlus 3 & 3T Cross Device Development] matssa:
Mmmh strange... I'm not using F2FS so can't test it. [MENTION=4329165]ivanich[/MENTION], are you on F2FS? Did you manage to install SuperSU on your builds?
[OnePlus 3 & 3T Cross Device Development] ivanich:
I'm on f2fs but not using supersu, inbuilt root works for me.
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah had the same issue before, that is the reason why I switched back to ext4.
[OnePlus 3 & 3T Cross Device Development] emontes:
Same here!
[OnePlus 3 & 3T Cross Device Development] matssa:
New build up guys! This has only the sdcardfs stuff, without the f2fstest stuff.

Those on f2fs, can you please test this new build? If it works properly, I'll put it in the base tree and use it in the f2fstest tree.
[OnePlus 3 & 3T Cross Device Development] matssa:
New build up guys (f2fstest). Please, those who are using F2FS, please test this and tell me if you get deadlocks or other! I'll upload an updated version of the sdcardfs soon.
[OnePlus 3 & 3T Cross Device Development] akssmax:
Jio network in India is facing some network drops.. Idk why.. It works fine is oxygen os 4.0. The network indicator shows low bars.. The lte is lil slow too.
[OnePlus 3 & 3T Cross Device Development] ivanich:
Found an issue with USB patches... They causes reboots when phone connected to PC's usb port. I spent 2 hours fighting with reboots before I realized that phone crashes only when connected to usb.
[OnePlus 3 & 3T Cross Device Development] davemuir:
I'm on f2fs, but I'm struggling to download the file from afh!
[OnePlus 3 & 3T Cross Device Development] ivanich:
Yeah, it's a pain, that's why I prefer GoogleDrive for such purposes

If you still need this build I uploaded it to my GDrive
[OnePlus 3 & 3T Cross Device Development] davemuir:
Finally grabbed 13th Jan build from AFH.

All working perfectly well here on f2fs. Haven't tried SuperSU, though.
[OnePlus 3 & 3T Cross Device Development] emontes:
Thanks, have been trying to download from AFH and no luck.
[OnePlus 3 & 3T Cross Device Development] hasdroid:
On /System f2fs or just /data , /cache !?
[OnePlus 3 & 3T Cross Device Development] davemuir:
System data and cache
[OnePlus 3 & 3T Cross Device Development] hasdroid:
Going to change file system tomorow and see ??
[OnePlus 3 & 3T Cross Device Development] davemuir:
I still haven't tried SuperSU, but I'm used to using inbuilt root since I switched to f2fs.
[OnePlus 3 & 3T Cross Device Development] hasdroid:
Yeah super su is better everytime but the most important that laos working on f2fs
[OnePlus 3 & 3T Cross Device Development] davemuir:
Just installed SuperSU.

Everything working perfectly.

Thank you, [MENTION=6313536]matssa[/MENTION] and everyone else involved!
[OnePlus 3 & 3T Cross Device Development] cluster1:
[MENTION=2442575]davemuir[/MENTION]

You're running the latest build with /system formatted to f2fs? I was under the impression /system stayed ext4. Just want to make sure I understand you correctly.
[OnePlus 3 & 3T Cross Device Development] hasdroid:
İ'm on ext4 right now but İ'll try f2fs tomorow as well
[OnePlus 3 & 3T Cross Device Development] davemuir:
You're right. My mistake.

/system is ext4
[OnePlus 3 & 3T Cross Device Development] gruntyoldbag:
Dumb question:

Which version should I use as a regular user?

I do not care for f2fs.

Or should I just stop updating for a couple of days until things are 'normal' again?

Until 'sdcardfstest' or 'f2fstest' is not part of the file name of the latest uploads?

"lineage-14.1-20170110-UNOFFICIAL-oneplus3.zip" (from this thread) is the ROM I am using.
[OnePlus 3 & 3T Cross Device Development] matssa:
Either ROM will work for you since you don't use F2FS. These two branches are mostly changes for F2FS. Use the f2fstest build since i merge most of the stuff there for testing.
[OnePlus 3 & 3T Cross Device Development] matssa:
Arg, you gave me hope! ^^ let's see if it does something for SuperSU :) if it still doesn't work, I don't know what to do then...

However, once you have system to F2FS, or if someone has it already, can you please test the f2fstest? I want to know if you have deadlocks. If not, I'll merge this stuff in the cm-14.1 tree and in the sdcardfs. I'll use only one tree when I get your confirmations.
[OnePlus 3 & 3T Cross Device Development] matssa:
If I upload to Gdrive, I fear that I will have a download limit, this means not everyone will be able to access it. If you guys prefer, I can try uploading to Gdrive.
[OnePlus 3 & 3T Cross Device Development] matssa:
I didn't have time to fully test this, but I managed to connect via USB and upload my new build. I'm not on F2FS however.

I didn't test it the new build though, will try tomorrow.
[OnePlus 3 & 3T Cross Device Development] matssa:
OK guys I won't be able to make any builds this week-end, sorry. I'll follow the repos and XDA ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Wow thanks for the info, that's a big feedback :)
[OnePlus 3 & 3T Cross Device Development] matssa:
New build available, tested out and boots up :)
[OnePlus 3 & 3T Cross Device Development] Normas Interruptor:
What about the GPS? is it working fine? Or it is behaving the same as in CM ROM??

Sent from "Oneplus 3, with Oxygen OS beta8 (Android-N, 7.0, stock kernel, Official Twrp 3.0.2-1)" via XDA apps
[OnePlus 3 & 3T Cross Device Development] matssa:
As said in the first post, NFC fix and GPS fix are merged, as well as N blobs.
[OnePlus 3 & 3T Cross Device Development] Lownita:
Nice work! Is it right to assume that once the official Android N for the op3 arrives, cm will drastically improve due to oneplus releasing blobs, source and stuff?
[OnePlus 3 & 3T Cross Device Development] ivanich:
True but seems there is no one who will merge all this stuff into cm.
[OnePlus 3 & 3T Cross Device Development] matssa:
Yup, not sure if someone in CM will merge it, maye Steve or dianlujitao will help on the new CM :) I would like to help, but I don't have much knowledge or free time... I can make the builds and test it, but that's about it ^^'
[OnePlus 3 & 3T Cross Device Development] Tikerz:
Probably because Nougat for OP3 is not final.
[OnePlus 3 & 3T Cross Device Development] ivanich:
Nougat for gemini in beta stage too, but I see active development for it and they already merged all Nougat blobs, configs etc into cm repos.
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
Edited
[OnePlus 3 & 3T Cross Device Development] chazey2:
Least I can do as you've took the time and trouble to build it!

Dirty flashed today's latest, super SU updated to 2.79 all the same so far 'solid' good job thanks!
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok perfect, good to know. For now, if we have new bugs, then they are linked to CM commits since nothing new on the OnePlus3 side...
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
Hey I just wanted to report that Android Pay is working on your build. I know you mentioned it should be working but I figured I might as well report this to confirm it works 100%. Great job with this ROM, keep it up! :)
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks for the info, I didn't know it was working ^^ the NFC issue that was foxed was NFC crashing and the phone heating up, which of course couldn't let you use Android Pay.
[OnePlus 3 & 3T Cross Device Development] Giocarro:
[MENTION=6313536]matssa[/MENTION], are you by chance going to cook something today? I'm asking just because I'm gonna perform a clean flash with wipe, format, and all that stuff, and would like to go as up-to-date as possible.

Thanks in advance and keep up the good work!

P.S. I know this is an ETA request (nasty thing) but I'm trying to make it as friendly and cheerish as possible :)
[OnePlus 3 & 3T Cross Device Development] matssa:
Hehe no worries I'll make one, actually I'm already building it, I'm at 84%, taking more time than before since there was some translation commits thanks to Cid.

For everyone, just a heads up, I'll be going on vacation for the next few weeks. I'll have my big PC so I'll be building everyday, but since the connection is very low in terms of upload, I might not me able to upload everyday, I'll try though. If I manage to upload, it won't be at the same time as now, which is in the morning for me ;)
[OnePlus 3 & 3T Cross Device Development] Giocarro:
Thanks mate, now this is what I call passion and positive behaving! Bravo!
[OnePlus 3 & 3T Cross Device Development] Giocarro:
Just for clarification, I have to be rooted to change build.prop, so this fix is not a way to avoid installing SuperSU and enable built-in CM root, right?
[OnePlus 3 & 3T Cross Device Development] ivanich:
I haven't tried to edit build.prop from android.

You can do this even from recovery

Plug phone via usb to PC, boot into twrp

type

adb shell
mount /system
vi /system/build.prop

Find and comment out or delete corresponding line, save and reboot.
[OnePlus 3 & 3T Cross Device Development] matssa:
I'll try to change this directly in the ROM before shipping it, can't guarantee though.

Btw, new build is up.
[OnePlus 3 & 3T Cross Device Development] smouker:
Installed the newest Build with /system, /data, /cache on f2fs.

I also installed magisk and Supersu for magisk. So far everything works great and the phone seems alot smoother :) Thx for your great work :)

Cheers
[OnePlus 3 & 3T Cross Device Development] miscom:
Firmware from Stock ROM

In case someone needs it, I have uploaded the firmware files from several versions here

With those files you don't need to flash the stock ROM to get the latest radio.

Flash at your own risk.
[OnePlus 3 & 3T Cross Device Development] hasdroid:
Can you re-check if your /system still at f2fs from twrp please!?
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
[MENTION=6313536]matssa[/MENTION]

Tried doing a build with substratum / OMS support, my build kept failing with Substratum Resources. https://github.com/SubstratumResources

I pulled from their git and had merged it to:

frameworks/base

frameworks/native

system/sepolicy

However, the build failed. I did another separate build with just this add from this repo:

https://github.com/TeamSubstratum/masquerade/tree/n

But there seem to have been no change even though it built successfully. Did a little research and it appears the January Security Patch may be the culprit as to why the build is failing when fetching the repos mentioned here on their official XDA thread. https://xdaforums.com/showpost.php?p=67854202&postcount=4

I also believe I may have slipped up somewhere which could have caused my build to fail. :good:

build/core/binary.mk:1087: recipe for target '/home/sambegui/WORKSPACE/LineageOS/out│
/target/product/oneplus3/obj_arm/SHARED_LIBRARIES/libavcodec_intermediates/ffv1enc.o│
' failed │
make: *** [/home/sambegui/WORKSPACE/LineageOS/out/target/product/oneplus3/obj_arm/SH│
ARED_LIBRARIES/libavcodec_intermediates/ffv1enc.o] Killed │
make: *** Waiting for unfinished jobs.... │
make: Leaving directory '/home/sambegui/WORKSPACE/LineageOS' │
│
#### make failed to build some targets (02:28:10 (hh:mm:ss)) ####
[OnePlus 3 & 3T Cross Device Development] matssa:
Nice, which build did you try? F2fstest or sdcardfstest?

The firmware is already included it seems, if I'm not mistaken. [MENTION=4329165]ivanich[/MENTION] already included the OOS4.0.1 firmware.

Nope, since I won't do any OTA. This is an experimental ROM, for advanced users, where things can break between builds. This is to supply a more up to date builds based on LinrageOS so that all the good thing GS can then be integrated to LineageOS.

I already managed to build with masquerade, there isn't any issue nor change on our side. Masquerade is used only when all the repos are synced ;) that's why you don't see any issues.

For the build, can you try to merge everything from their repos, all of them, including masquerade? The build fails maybe because he doesn't find masquerade somewhere in the build. If it fails, can you link the error? I feel we are on the good side :)

I'll try to clone my repos and try to merge the said repos when I come back, we never know :) but before, I'm making my VMWare again in order to reduce the size (250-->150) in order to copy/paste on my work PC, which can't seem to pass a certain step in the building...

Thanks again for your help! I doubt LineageOS team would like to use Substratum instead of the CM Theme Engine though...