yashsingh1/xdaforums huggingface dataset:
[Magisk] carlos974:
It boot fine also on my device ! :good:

Thanks
[Magisk] L.F.B.:
[MENTION=3306843]kantjer[/MENTION] Ive updated to your snapshots and all working fine in all my devices!

Galaxy s4, nexus 5, nexus 7, nexus 6 and Xperia Tab Z.

And its very nice to have release notes on every snapshots! Thanks for your work on this details????
[Magisk] chikimonke:
[MENTION=3306843]kantjer[/MENTION] In the just released official nightly/canary Magisk builds it mentions "The binaries are built with debug flag ON: excessive logging enabled in both Magisk and Magisk Manager for debugging." Is this something that you also have enabled, or do we avoid having all that logging going on with your builds?
[Magisk] radz_:
Official Snapshots are now available from john, will this project still be active?

https://xdaforums.com/showthread.php?p=77549897
[Magisk] kantjer:
I don't have the debug flag on.

I always build with the release flag, so no debug logging on my builds.
[Magisk] ianmacd:
Neither [MENTION=3306843]kantjer[/MENTION] nor I produce debugging snapshots. I can't speak for him, but this isn't something I wish to change in my builds, so whilst I had been hoping that the advent of official snapshots would mean that these builds would become superfluous to my own needs and could therefore quietly fade into the sunset, it seems this is not the case. I shall continue to produce them, and continue to make them available to others as a courtesy.

One thought that occurs to me is that the willingness of [MENTION=4470081]topjohnwu[/MENTION] to entertain bug reports from people continuing to use these unofficial snapshots may decrease now, since anyone using them will necessarily be unable to provide an accompanying debug log. He may decide that such a log is a prerequisite for support. This is just speculation, of course, based on how I imagine I might feel in his position.
[Magisk] topjohnwu:
The debug builds aren't really that bad. I use debug builds on all my devices daily and never really ran into an issue. The logs won't be too obnoxious.

Release builds are more strictly stripped, especially Magisk Manager thanks to Proguard, but that also means that stack traces are more difficult to read. Other than binary size and a little more verbose logging, there is not such big of a difference ?
[Magisk] martyfender:
I have been using CANARY on one of my devices and it is working great. What about battery life on debug builds?
[Magisk] jenslody:
I (nearly) never use release builds and don't see any impacts on battery life.
[Magisk] Homeboy76:
:eek: Please, tell me that device is that a pixel XL. Please. :cyclops:
[Magisk] martyfender:
No, it is a Nextbook Ares 8A, x86, Android 6.0.1.

---------- Post added at 10:32 AM ---------- Previous post was at 09:54 AM ----------

Does anyone know what this commit is and what an external config file is?

Better support for external config file.

Thanks
[Magisk] ianmacd:
The config file is used to configure the build environment of the software. It's not something that the end-user ever sees.
[Magisk] Homeboy76:
:laugh:

Ok!
[Magisk] martyfender:
I'm sorry, I don't understand the joke.
[Magisk] Homeboy76:
Edited post, No Joke.
[Magisk] pankspoo:
R u able to play fornite and fate grand games
[Magisk] martyfender:
I haven't tried, nor do I intend to.
[Magisk] Ace42:
Grand Order doesn't launch, can't test Fortnite. Doesn't it need an invite? :confused:
[Magisk] Tornado15550:
Any idea why there's no new build that includes the latest two commits? Specifically commits 67103148 and 0cd4fa6f.
[Magisk] ianmacd:
There is such a build. The one I put together two days ago has these two commits.
[Magisk] kantjer:
Thanks for the reminder.

I totally forgot about uploading the build.

Too many other interesting projects going on ATM

Building Pie ROM and setting up Jenkins.

Last Magisk is now uploaded.
[Magisk] martyfender:
As is usual with your builds, this one is working great on all of my devices I have it on. I am still Leary to test direct install, considering all of the problems I have had with it. Out of curiosity, do you know what those latest commits do. I always have a hard time reading the code and telling what they do, since [MENTION=4470081]topjohnwu[/MENTION] rarely ever comments them to make it easy to understand what they do.

Thanks again
[Magisk] buffal0b1ll:
Direct install hasn't failed in over a month on bullhead and walleye. That bug only lasted a couple days and was fixed early in August.
[Magisk] kantjer:
Often you will see a hint just below the commit name.

In case of "Allow all context to SIGCLD magisk" it's Fix #596

That Fix # will link to the bug report the fix is for.

In case of the "Simplify SignAPK code" that one is of no interest for users, for me as a builder this is actually an interesting one.

Often during a build, the signing of the zip's (especially the uninstaller.zip) could take forever and sometimes just hang.

Forcing me to abort the build, that messed up the changelog generation and builds versioning.

This commit seems to fix this.
[Magisk] martyfender:
Wow, thanks, I did not even know that was there. I had to click on the 3 dots to show that.

Also, has anyone else noticed marginal battery improvements with recent builds?
[Magisk] uudruid74:
Turn on Magisk Hide, Hide Magisk Manager app, rename Magisk Manager folder, turn off developer settings.

Root and modules still work, and so will Fortnite
[Magisk] Ace42:
Apps can monitor the names of folders? Sounds like an invasion of privacy to me, especially since permission to snoop isn't given.

I don't care for those games, but it's interesting to see what lengths devs will go to burn root users.
[Magisk] uudruid74:
Like most games, it says it wants storage permission to save your game progress. This is a lie, since game save data can (and should) be stored in app-private areas, not in shared storage. You could make a case that this allows saved data to remain if someone uninstalls the game and reinstalls it, but that seems to only further the point - if I uninstall the game, I probably don't need the saved data taking up space!

Once storage permission is given, the Magisk Manager folder is easy to spot. I suppose Magisk could start storing its data in private storage, but this would get wiped when wiping data for a new ROM.
[Magisk] jcmm11:
They can find the Magisk Manager folder even if permission isn't given. The way it works (may be slightly off, not going to track it down again) they make a request to directly access the folder. This returns one of 2 possible errors:

Permission denied

Folder not found

If they get permission denied that means the folder exists = rooted (according to them).

This is why the folder is no longer used in the latest version.
[Magisk] martyfender:
It failed for me after those fixes on one of my devices, where data was corrupted and required a factory reset to fix. So that is why I have stuck with the TWRP method.
[Magisk] uudruid74:
That's really odd considering the magisk is installing the boot partition in a factory reset would be touching the data partition not the boot partition. Are you sure magisk was the problem?
[Magisk] martyfender:
I posted info about it twice along with logs, several weeks ago.

I have both lspeed and kernel aduitor tunings. I'm not sure if this could have contributed, but it never has in the past. The problem has not happened flashing in TWRP.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] I just flashed your just released build through direct install and got the bootloader error I previously posted screen shots of a few weeks ago. To fix it I must reflash the stock boot.img and Magisk.zip again in TWRP. I guess it is back to flashing in TWRP.
[Magisk] kantjer:
Your device doesn't like direct install for whatever reason :confused:

EDIT: Last 2 builds were made using Jenkins

I can now make and release a build from anywhere as long I have a browser and internet :D
[Magisk] martyfender:
Yes, it is no big deal to flash in TWRP, but I would sure like to know why on my devices, direct install often fails.
[Magisk] kantjer:
You can use Flasher to make TWRP flash easy, and do scheduled nandroids and much more

I have been using that since beta 1, and I think we ended with beta 28 before it appeared in Google Play :D
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] I looked at this and it stated that my device is not compatible with this version. My devices are all Android 6.0.1, x86.
[Magisk] neekless:
That app is only for android 7+ :/
[Magisk] Killua96:
[MENTION=3306843]kantjer[/MENTION] may i ask if in your latest builds full obfuscation is present? Need it to hide root from FGO an GPay...
[Magisk] kantjer:
Yes, I'm building in release mode (python3.6 ./build.py --release all) so "Excessive obfuscation when building in release mode" should be working.

I don't use FGO or GPlay so I haven't tested it

---------- Post added at 13:18 ---------- Previous post was at 13:15 ----------

AFAIK no app can do a clean shutdown/reboot.

Newer Android version doesn't seem to be affected by that but on older Android version doing a non-clean shutdown can lead to data corruption.

You can see what I mean by comparing doing a reboot using the power menu and using an app.

Rebooting using the power takes much more time because the system is closing all running processes gracefully before shutting down and restart.
[Magisk] Killua96:
Tried right now, GPay works, FGO doesn't, i really don't understand what's the problem...

Here there are some logs if can help:

Magisk Log: https://mega.nz/#!XcI2mSgI!epnWSWCujYGPRRfcc4LMJW24M1u08Acqzt5-RHZBzBU

Catlog: https://mega.nz/#!bBAkBSwb!pIFRUJYKg36a9GanHCcwwsDtqy9C2K5Fy1nFLTZ7imA
[Magisk] Ubimo:
In kantjers builds, is the debug flag on or off?

In topjohnwus canary builds the binaries are built with debug flag ON: excessive logging enabled in both Magisk and Magisk Manager for debugging.
[Magisk] guest4711:
As you can see three posts above, he is building in release mode with means debug flag off.

See also https://xdaforums.com/apps/magisk/unofficial-magisk-v10-beta-built-t3521901/post77553180
[Magisk] martyfender:
With direct install, even using the power button, updating to your build today (e12), I got the bootloader error once again. Restoring my stock boot.img in TWRP and flashing Magisk in TWRP, fixed it. So I will stick with TWRP.

From time to time I will test direct install in future builds.
[Magisk] jcmm11:
Just out of curiosity what's the value of /sys/module/sync/parameters/fsync_enabled ?
[Magisk] martyfender:
I don't have this directory on my device:

/sys/module/sync/

Is there some other location to look?

When I search for fsync on my device with Total Commander I find:

sbin/.core/busybox/fsync

sbin/.core/img/busybox-ndk/system/xbin/fsync

system/xbin/fsync

Is there a command I can enter in the terminal to determine if fsync is enabled?
[Magisk] jcmm11:
Try /sys/class/misc/fsynccontrol/fsync_enabled

There's no command I know of.

The other thing you can try is to manually issue a sync (not fsync) command before rebooting.
[Magisk] martyfender:
It is not there either but I do see a sw_sync.
[Magisk] jcmm11:
I know that stands for software sync. Not sure exactly what it does. Did find this (note the warning)

-config SW_SYNC
- bool "Software synchronization framework"
- default n
- depends on SYNC_FILE
- depends on DEBUG_FS
- ---help---
- A sync object driver that uses a 32bit counter to coordinate
- synchronization. Useful when there is no hardware primitive backing
- the synchronization.
-
- WARNING: improper use of this can result in deadlocking kernel
- drivers from userspace. Intended for test and debug only.
-
source "drivers/staging/android/ion/Kconfig"

endif # if ANDROID

Reference (very bottom of first post)

https://groups.google.com/forum/m/#!msg/fa.linux.kernel/XRFNIi90zqI/vreSMaDaAAAJ

---------- Post added at 06:39 PM ---------- Previous post was at 05:53 PM ----------

@martyfender What kernel are you running? Maybe try a different one?

If it's the stock kernel I'm fairly certain fsync is on, even if the toggle isn't enabled. If it's some type of high performance kernel there's a chance fsync is off.

The other problem I'm having I can't definitively find the kernel config parameter that enables the toggle. I think it's 'CONFIG_SYNC', but I'm not 100% sure. If it's enabled in your kernel you can find the current config options in /proc/config.gz
[Magisk] TheUndertaker21:
seems like spay for the gear worked once LOL

then stopped working on other rom with 17.2

from Kantjer and canary

i hate that god damn app so much lol

see logs

View attachment com.samsung.android.samsungpay.gear.log
[Magisk] martyfender:
Kernel architecture i686

3.14.64-x86_64 (warrior@warrior-MS-7673) (gcc version 4.9.2(GCC) ) #1 SMP PREEMPT Wed Jun 21 03:00:22 EDT 2017

Tags release keys

Type user

It is a 32 bit device and as far as I know there are no other rom or kernels for it. Nextbook does not provide a stock rom so I have to depend on my first TWRP backup for restore.

I don't see /proc/config.gz either.

I am using Kernel Aduitor and Lspeed to tune. In Lspeed under the cpu tuner I am using the Governor Tuner Balanced profile.

Under the main tweaks I have set kernel sleeper optimization and flag tuner set. Under I/O tweaks I have set Scheduler tuner, I/O boost and Partition remount. Under the battery section, improve battery.

I use Greenify and am using aggressive doze.

In Kernel Aduitor I have dirty_ratio at 10, dirty_background_ratio at 10, overcommit_ratio at 87 and 400mb zram is on by default. It is a 1gb device.
[Magisk] kantjer:
Guys,

After running into build errors today and since we now have the official canary channel I decided its no longer worth the effort for me to keep building unofficial builds.

It was a fun ride and I learned a lot.

cheers.
[Magisk] Skittles9823:
Thanks Kantjer, appreciate the effort you put in with these builds :good:
[Magisk] martyfender:
It is sad to hear that, but I understand your position. Thank You for your efforts and for all of the help you have given me and others.
[Magisk] kantjer:
I won't stop helping where I can.
[Magisk] Paschfire:
Much appreciation for all the work you have done here. :highfive:
[Magisk] ianmacd:
Thanks for all of your efforts, [MENTION=3306843]kantjer[/MENTION].

Should anyone still be interested in an alternative to the official canary builds, my release-type builds will continue to be made available for the foreseeable future.

As a reminder, this is the URL for the custom update channel:

https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json

Take care with signatures when making the transition to my builds. You may need to manually remove and reinstall Magisk Manager.
[Magisk] hshah:
Thanks for all your time and effort! :svetius:

/Edit: what's the best way to move off your builds and onto one of the others?
[Magisk] kantjer:
Uninstal MagiskManager and flash the version of choice and set the desired update channel. You will not loose magisk modules or su settings
[Magisk] hshah:
I kind of wanted to see what would happen, so instead of the above, I changed the custom URL to ianmacd's one. It prompted me to install a new MM, which installed over the top and then just did a direct install when it prompted to install the new version.

Rebooted and here I am with everything working just like before. In a way I'm a little disappointed because it was too easy lol!
[Magisk] kantjer:
Are you sure MagiskManager updated? I would be surprised because of the difference in sign key.
[Magisk] Homeboy76:
Kantjer Unofficial Magisk builds is gone?

Thanks for all your hard work and sticking around to help.
[Magisk] hshah:
All looks to be in order I think :)
[Magisk] kantjer:
Looking good
[Magisk] hshah:
Ahh, just realised why it worked so easily... the ROM I'm using has signature checking disabled :good:
[Magisk] kantjer:
I'm almost feeling guilty stopping the builds ?

Last year I fell seriously ill.

I'm still recovering from the aftermath of that period, being part of the XDA community and build projects helped me through that difficult time but I feel it's now time to take a break.
[Magisk] Homeboy76:
A well deserved break:)
[Magisk] topjohnwu:
[MENTION=3306843]kantjer[/MENTION] [MENTION=7187684]ianmacd[/MENTION] thanks for keeping this thread alive :D

I'm looking forward to the same healthy discussion in this thread moved over to the Official Canary Thread.

If people really want to have upstream builds without debug flags, I can add another channel for those who doesn't want to debug :p
[Magisk] martyfender:
My thoughts, also. I have always had to remove one with different signing keys first, or I will get an app not installed error trying to install the other.

---------- Post added at 05:52 PM ---------- Previous post was at 05:34 PM ----------

Yes, so far, there hasn't been much discussion in that thread,, which may be a good thing, as it has not got the many useless posts, Witbout logs, off topic. Safety net questions, etc, that the closed beta thread had.

It would also be appreciated if you continue to post the changes in each Canary build, in that thread to make it clear in laymans terms what has changed.

Thanks for your continued efforts and good luckwith your edu. At UM.
[Magisk] SysWiz:
Yes, please.
[Magisk] ianmacd:
Thank you for the offer. I do think there's a demand for it.
[Magisk] hshah:
If you could give the choice or even make it something that could be turned on and off, that would be amazing :svetius:

It seemed to work for me... see the screenshots I attached :)
[Magisk] esgie:
Thank you [MENTION=3306843]kantjer[/MENTION] for your effort, used your builds as a daily driver for some time. Good to hear that your health got strong again.

And thank you [MENTION=7187684]ianmacd[/MENTION] for your effort and attitude in providing us snapshot builds.

Yes, that is what the community love: UPDATES. Including the adrenaline when flashing an untested zips; but including also the knowledge gathered when investigating what changed and how was it made, even without professional devellping skills; or even a proudness of being able to play fortnite again three days before others ;) that's a perfect idea.
[Magisk] edzamber:
[MENTION=7187684]ianmacd[/MENTION]

It seems that update url is Unknown in Magisk update Channel

https://raw.githubusercontent....ds/master/updates/ianmacd.json
[Magisk] guest4711:
Just tested with https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json

and all is working fine. Did you grant MagiskManager the access to internet in your firewall (e. g. AfWall)?

Edit: The url you used could be scrambled, use the one above...
[Magisk] edzamber:
No Luck with

https://raw.githubusercontent....ds/master/updates/ianmacd.json
[Magisk] kramer04:
Try with this link

https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json
[Magisk] carlos974:
To use this custom channel, configure the following URL in your Magisk Manager settings:

https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json

Alternatively, this shortened URL will also work:

https://goo.gl/yZpnrf
[Magisk] edzamber:
Ok this is good link

https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json
[Magisk] yochananmarqos:
Whoops, Forgot I was in the unofficial​ thread. I'm also sick and in the hospital, so that doesn't help, either.
[Magisk] kantjer:
Same here, I guess that's the risk of running unofficial/unreleased builds.
[Magisk] ahrion:
The last few builds are giving me errors when installing some mods. Essentially it says that the Magisk merge is having issues with my filesystems. I reverted back to 11.1 and the problems stopped. So I was only experiencing issues with the last few builds.
[Magisk] calikevin:
Build 17302 failed the CTS check but passed basic integrity. The build 17303 does not pass either one.
[Magisk] koko115:
After install V12 still long boot on galaxy s7 with MM rom
[Magisk] LPW00:
I can't confirm. It works just like the other builds. Try disabling Adb and set root access to "apps" instead of "apps and adb"
[Magisk] Artim_96:
Sorry, but just tested myself (build 0304), developer settings show SELinux as permissive, basic integrity check fails and as you can see in the screenshot, note even RootBeer Sample fails. I just managed in v11.1 (with busybox disabled because it caused loss of root for me) to get everything to pass there, but now many stuff fails, it's basically like Magisk hide doesn't react at all.

EDIT: completely reinstalled Magisk, still failing everything. But at least now I have the logs

EDIT: just saw Magisk hide is actually not reacting at all. Before liking the log I ran SN test in Magisk manger, SafetyNet helper and ran RootBeer sample. As you see, Magisk hide never is mentioned in logs. Even turning it off and on again does not help
[Magisk] Deic:
Magisk Manager Snapshot Updater v3.0.0

changelog:

-added notifications and toast when check, download and install updates ¹

-uninstall old version of Magisk Manager w/o remove data ²

-code improvements & bugfixes

¹ install "Notify4Scripts" and "ShowToast" if ask

² to check when update is installed

if you have got some bug or something strange occurs, please post "updater.log" file found in "/Magisk/magisk-manager-snapshot-updater/".

source code: https://github.com/DeicPro/magisk-manager-snapshot-updater
[Magisk] kartikb:
Hi [MENTION=4476591]Deic[/MENTION], after installing this updated module, it tries downloading the two apk file you've mentioned but it's never successful downloading it and comes up with a message saying "there was a problem parsing the package." I've had to disable the module for now to stop it from coming up all the time.. Is there a fix for this?
[Magisk] Deic:
do you can post updater.log file under module folder?
[Magisk] Artim_96:
Had the same problem. I just got the URL for the first apk from the services.sh in the module (https://github.com/halnovemila/Notify4Scripts/raw/master/com.hal9k.notify4scripts.apk), downloaded and installed the apk and then the second one wasn't a problem anymore
[Magisk] Deic:
Without log of that moment I can not fix it, because I do not get that problem and I do not know what is the reason of it.
[Magisk] kartikb:
Hi, attached log file as requested. I had to zip it as it was 1.25MB in size. Hope you can figure out what the issue is. Thanks..
[Magisk] kartikb:
I found new version of the updater on Stangri's github. Installed that and it's fine but it keeps downloading the notify4scripts apk even though it's downloaded and installed. Also, the notify4scripts app after running it, comes up with a message saying:

Sorry, can't read launcher.

Can't find any authority provider that declares this permission:

com.android.launcher.permissions.READ_SETTINGS

It seems the app doesn't know that there is MagiskSU already installed.

I've attached a new log file for the snapshot updater [MENTION=4476591]Deic[/MENTION]
[Magisk] Deic:
Seems that something is wrong with your package manager shell function, do you can run "pm list packages" without quotes from terminal and post the results?

Ignore the notify4scripts icon on your launcher, it is not the problem.

EDIT: [MENTION=2704407]kartikb[/MENTION] try the module.zip attached and tell me if problem is solved.
[Magisk] kartikb:
Hi, I've installed the new module attached in your previous post and it keeps doing the same thing. It wants to install the notify4scripts apk file even though it's installed. I also tried running the app after it was installed and I got the same message:

Sorry, can't read launcher.

Can't find any authority provider that declares this permission:

com.android.launcher.permissions.READ_SETTINGS

I have also run the shell command, "pm list packages" and got the following output:

com.hal9k.notify4scripts shows as being installed. I have disabled the module now and uninstalled the app as it's not working for me.
[Magisk] Deic:
Sorry I forgot to add some things, now must be fixed.

[MENTION=2704407]kartikb[/MENTION] try new attached.
[Magisk] kartikb:
It seems to be fine so far. Thanks for the fix. Much appreciated. :good: