yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok I cleaned the repo, made a second branch OMS2, I'm trying to build at this moment. I had other conflicts that were solved automatically by git in the same commit, so let's see how it goes :) I didn't want to check the 5 different files... Might have to depending of the error ^^'

EDIT///

Crap, an error again... Fuuuu
[OnePlus 3 & 3T Cross Device Development] EatBeans:
If you don't get it to work I would suggest you to ask nicesoni_ash because he has integrated OMS perfectly into resurrection remix and rr is based on lineage so he maybe could help you.
[OnePlus 3 & 3T Cross Device Development] matssa:
It's quite simple really, there are conflicts in the merging, so some stuff needs to go, other needs to stay, and I need to do this manually... So gonna clean AGAIN the repos and gonna solve each conflict one by one...
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok guys, last try for me, I'll test again the build, I made the frameworks_base repos clean, took a lot of time to check. If it goes to crap, I'll stop porting OMS until someone manages to build it with LineageOS source without changes so that we can check together ( [MENTION=4837394]siankatabg[/MENTION] :) ).

EDIT/// Ok seems to be building, reached 5% without issues... Let's see how far it goes... After that, I'll try to include the latest kernel changes from [MENTION=5091734]dianlujitao[/MENTION] so that we can test it. After that, I'll add the camera stuff ;)

EDIT 2/// Ok can't do it, build stopped at 5%. I don't have the time or energy or the knowledge to debug this. Sorry guys, seems like OMS is not going to be included in this ROM, gonna stay fully, 100% stock LineageOS with extra commits. Can't say I didn't try!
[OnePlus 3 & 3T Cross Device Development] nicesoni_ash:
Absolutely right. Even if I wanted to, I hardly can help in this. Each conflict has to be fixed individually. Plus RR is a lot different than stock LOS. Still I guess few devs were managed to implement oms in lineageOS too, just give a look at their repos.

Meanwhile you can push ur changes to a test branch and post ur build errors here so others can have a look, I'll give a try too.

Sent from my "1+2" powered by Unofficial RR 7.x.x

Compiled by myself
[OnePlus 3 & 3T Cross Device Development] gruntyoldbag:
I hope you are wrong :)

https://review.lineageos.org/#/c/29936/

... even though it is possible that the latest blobs has fixed the issue.
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks for you help! I made my own repos that you can find in github (github.com/Matssa56). In there, the OMS branch has everything. For the error issue, it was concerning the API (a big star with funny messages ^^). If you can take a look, that would be great!

But as you said, LineageOS is quite different, and there are added stuff for the OMS that enters in functions which changes the numbers of arguments, etc... So I'm quite sure that if I change something in there, there more than 70% chance that I will break something. The better would be someone who managed to include it in a stock LineageOS like what I'm trying now, so that he can explain or even share his stuff... I already contacted some people, but their help isn't very helpfull. The only person who really helped me was [MENTION=4837394]siankatabg[/MENTION].

I don't like this commit since we don't know if it has been tested with the latest blobs or with the latest kernel changes...
[OnePlus 3 & 3T Cross Device Development] nicesoni_ash:
The error you mentioned is a simple one and easy to fix. It's not related to oms.

Run make update-api*

You would be able to build after that.

Sent from my "1+2" powered by Unofficial RR 7.x.x

Compiled by myself
[OnePlus 3 & 3T Cross Device Development] proag:
Hey, are you going to make a build with kernel based on OOS sources? It already builds and works fine, from what I've read on gerrit.

Thanks!
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
OMS for sure!

---------- Post added at 09:49 PM ---------- Previous post was at 09:43 PM ----------

Right here is lineageOS with OMS merged have u checked that source? https://xdaforums.com/oneplus-3/development/rom-tugapower-1-0-t3531164/page12
[OnePlus 3 & 3T Cross Device Development] solokiller11:
So, I have not been around for a long time (army...) So if I wanna flash the latest build should I flash the OB9 firmware? Or something else?
[OnePlus 3 & 3T Cross Device Development] matssa:
No need, firmware is already included. Only flash the latest version, but make sure you backup everything, just in case.
[OnePlus 3 & 3T Cross Device Development] apascual89:
Just in case you can comment that out in the system prop in device tree before compiling. Not sure if you knew that.
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks for the info, I didn't know that, I was going to search Google :) I'll try to do that in my next build.
[OnePlus 3 & 3T Cross Device Development] ivanich:
lol. I'm using this for my builds:

cd device/oneplus/oneplus3
git am ../../../patches/0001-op3-Temp-disable-frp.patch
cd -
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks for you help, i'll apply it on the next build :)
[OnePlus 3 & 3T Cross Device Development] matssa:
New build guys (2016-12-16 v2) with dev settings fixed with a temporary hax.
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
Thanks for the awesome builds :good:
[OnePlus 3 & 3T Cross Device Development] _MartyMan_:
Yeah, [MENTION=6313536]matssa[/MENTION] is back :D Good job (again) :good:
[OnePlus 3 & 3T Cross Device Development] Stefano187:
Hi all,

First of all thanks to [MENTION=6313536]matssa[/MENTION]! Your builds work great! GPS fix within seconds with any kind of app that needs location! Thanks! Just out of curiosity... What did you do to get GPS working as it should?

Thanks again

Best regards

Stefano
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
My understanding is, they used the commits mentioned in the OP which fixed GPS.
[OnePlus 3 & 3T Cross Device Development] matssa:
Yup, used the open commits from [MENTION=5091734]dianlujitao[/MENTION] which aren't merged yet.

I think that they should be merged in the nightlife's since no bugs are reported, except the Dev settings, but a temp hack has been found...
[OnePlus 3 & 3T Cross Device Development] matssa:
Hehe I'm always here ;) but yeah, good to see you again ;) do you continue building?
[OnePlus 3 & 3T Cross Device Development] solokiller11:
Can I use substratum themes on this rom?
[OnePlus 3 & 3T Cross Device Development] _MartyMan_:
Unfortunately i don't have enough time.... :/
[OnePlus 3 & 3T Cross Device Development] matssa:
Ah I feel you, have the same issue here, not enough time to contribute more than what I already do.
[OnePlus 3 & 3T Cross Device Development] silentvisitor:
Hello [MENTION=6313536]matssa[/MENTION]

First, thanks for your builds, time and dedication :good:

Second, would you consider adding Subs to your builds?

Thanks once again !
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks for you encouragement, what do you mean by Subs? Substratiumm or whatever it's called?
[OnePlus 3 & 3T Cross Device Development] matssa:
I dunno, I need to check what it does... I may do two different builds, one with and one without, but I have a crappy connection... I'll try to make a poll in order to see how much people want it ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks for the heads up, I'll try to give a look
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
Welcome bud! Would love.to see OMS make it into this
[OnePlus 3 & 3T Cross Device Development] matssa:
I was thinking about doing that as well, gonna do that tomorrow. Let's hope it works! I hope... :)

However, we can still have some conflicts after when the LineageOS team is gonna update stuff.
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
Here's another just popped up, not sure where thread or source is though, lol. https://www.androidfilehost.com/?fid=529152257862697498
[OnePlus 3 & 3T Cross Device Development] siankatabg:
That's my personal build with the new kernel, I've uploaded it for one friend :) There is no source (as I said it's mainly private build) and I already said to matssa why and I've mentioned it in my oxycam thread too some days ago(on the previous build) :)
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
Thanks
[OnePlus 3 & 3T Cross Device Development] nicesoni_ash:
Unofficial builds always have a cat and mouse game .. You need to fix stuff after every few syncs.. :)
[OnePlus 3 & 3T Cross Device Development] matssa:
True story, it's almost a full time job after ;) thanks again for your help, I'll make the API update thing this morning and see how it goes.
[OnePlus 3 & 3T Cross Device Development] RohanAJoshi:
[MENTION=6313536]matssa[/MENTION] : will please guide me to build which contains brightness fix ?

https://github.com/kristofpetho/and...mmit/9b507b327fddb6a57189a26beaf2bc87fdd9f766

or will you please make new on if not ?
[OnePlus 3 & 3T Cross Device Development] matssa:
I already included it in my repos (cm-14.1).
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok guys tested building OMS, still got issues with merge stuff. As I said, some functions have extra stuff in LineageOS, so on some, I don't know if I need to change it or not, and it may break stuff, so I will stop trying to port OMS. If someone manages to merge OMS into a stock LineageOS, then I'll cherry-pick. Until then, sorry guys, can't spend time that I don't have on this.

I'll make new builds using new kernel today and I'll upload it.
[OnePlus 3 & 3T Cross Device Development] RohanAJoshi:
Thanks, but which build includes this commit ?

I see you merged this on 22 and your latest build is 21, correct me if I am wrong
[OnePlus 3 & 3T Cross Device Development] matssa:
Still not on AFH, I'll make a new one and post it.
[OnePlus 3 & 3T Cross Device Development] matssa:
New build is up guys, changelog has been changed.

I'll take a last LAST look at the OMS porting, gonna check how Team-octs solved it, but I don't guarantee anything.
[OnePlus 3 & 3T Cross Device Development] davemuir:
I can't seem to boot up the new build. Anyone else?
[OnePlus 3 & 3T Cross Device Development] Gandicela:
Great energy you have! Hopefully you can help us out, Mate. No rush, perfection takes time.

I'm presently on FOS 2.2 primarily because I must run black or dark theme. But I reckon I can't stay long because I don't like non expanded desktop. For now, it's best compromise and once you succeed, that would be marvelously nearest perfection.
[OnePlus 3 & 3T Cross Device Development] matssa:
What do you mean? What process did you follow?
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok guys, i'm doing a new build for OMS, last time I try, let's hope it's OK!
[OnePlus 3 & 3T Cross Device Development] davemuir:
Dirty flashed over the previous build in TWRP, flashed supersu, then it boots to the battery charge screen.

Tried it a few times.

Flashed the previous build again and everything is working fine.
[OnePlus 3 & 3T Cross Device Development] xantic21:
The latest build boots fine, but I can't activate wlan. Anyone else?

Update: Latest Boeffla kernel breaks wlan. ROM is fine!!!
[OnePlus 3 & 3T Cross Device Development] yka:
+1 all ok, data+cache f2fs
[OnePlus 3 & 3T Cross Device Development] daggorlad:
Clean flashed, stuck in setup process. Can't skip the "Tap & Go" step.
[OnePlus 3 & 3T Cross Device Development] matssa:
Mmm very strange, I did the same and no issues on my side... Did you test today's build? If so, please wait for tomorrow, I'll upload a new build.

By the way guys, maybe good news tomorrow, current build is at 70% :)
[OnePlus 3 & 3T Cross Device Development] matssa:
OK so build crapped out near 85% because if mismerge stuff in settings app. I'll have to clean it a bit. I'll check it tomorrow.
[OnePlus 3 & 3T Cross Device Development] davemuir:
Yeah, tried today's build.

Looks like nobody else is having that issue, I'll assuming it's because I dirty flashed!
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
I have dirty flashed and everything is fine
[OnePlus 3 & 3T Cross Device Development] matssa:
Oh wait, I maybe know why. You need to wipe data, format it and flash again. If you are using F2FS, this is necessary since some changes have been made. Those who already did that before are clean, however if you didn't, then you can have this type of issues, or deadlocks.
[OnePlus 3 & 3T Cross Device Development] davemuir:
Okay, I'll do a clean install when I get the chance.

Thank you!
[OnePlus 3 & 3T Cross Device Development] matssa:
OK, but do you use F2FS? Furthermore, I can't guarantee it will work.
[OnePlus 3 & 3T Cross Device Development] davemuir:
Yes, I'm on F2FS
[OnePlus 3 & 3T Cross Device Development] matssa:
OK then there is a bug chance that it will fix it ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Make sure you use the correct TWRP! See first post!
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok guys in about one hour, you should be able to find a little suprise :)
[OnePlus 3 & 3T Cross Device Development] beelzebu:
you are the man! Great work ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
You don't even know what the surprise is! ;) I only hope it will work as expected, I didn't have time to use it since I'm not at home, using remote stuff to build it.
[OnePlus 3 & 3T Cross Device Development] beelzebu:
Any surprise are always welcome even if I dont knot what it is, just guessing, i might be substraum, isn´t it?
[OnePlus 3 & 3T Cross Device Development] matssa:
Maybe... :)

Ok guys so here is the different objectives for the next few days:

Today = Test OMS stuff :)

Tonight = Add upstream kernel changes to my repo + new build (may not be able to share it though since I don't have a good connection

Tomorrow = Add Camera changes + add SU addon changes + make su addon package + make build

Tomorrow + futur = Test the kernel changes and the camera changes

I will of course need your help on these points.

I want to point out that if I have OMS issues when merging new stuff, then I may stop supporting OMS.
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
Lets do this!!! Ready for testing and flashing ;)

Good job
[OnePlus 3 & 3T Cross Device Development] NoobMonkey:
Yesterday's build seems great. Haven't noticed any bugs on few hours usage.
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok guys build is up, please be sure to BACKUP everything on your phone and SMS, and your cat, and your girlfriend / boyfriend, etc... OMS is included in this build, so please test it out and keep me posted :)

Furthermore, kernel is also included, with the restart bug issue fixed (phone would turn off when using restart).
[OnePlus 3 & 3T Cross Device Development] TekRantGaming:
Cool ROM thinking of flashing if I do when the official laos 14.1 is out can I flash over this or are you going to continue to add your own stuff to this version I might end up staying on yours
[OnePlus 3 & 3T Cross Device Development] matssa:
I will continue adding stuff on my ROM, and you can flash mine over the one from LineageOS, but the other way around can break stuff.

You can always try but backup first, and make clean flash.
[OnePlus 3 & 3T Cross Device Development] TekRantGaming:
Thanks man another question on stock oos 4.0.2 I suffer android OS and android system battery drain never had this back on mm I'm going to assume this is an oos issue and not a cm or Laos issue ?

Miss my 6 to 7 hours sot man lol
[OnePlus 3 & 3T Cross Device Development] matssa:
Erm good question, I dunno, I can't really say since I keep flashing, etc... I don't seem to see any battery drain though.
[OnePlus 3 & 3T Cross Device Development] Gandicela:
OMS, yeah baby! Let me try how it goes. Cheers.
[OnePlus 3 & 3T Cross Device Development] matssa:
Thanks, I hope there aren't gonna be any issues :/
[OnePlus 3 & 3T Cross Device Development] Gandicela:
You're a machine! I ran out of "thanks" for the day, sorry
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
This the one with OMS? just checking, lol I ready test!
[OnePlus 3 & 3T Cross Device Development] matssa:
Yup, you can find it in the OMS folder.
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
setting up quickly, then testing subs, so far it is registering and all good, gotta try buil and enable in a second here.
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
Alright so everything compiled and applied correctly!!! Only question I did have is masquerade not included? At no point in building or applying do it as for root access for masquerade or is that a new feature of OMS?

EDIT: I see now it is not installed.....
[OnePlus 3 & 3T Cross Device Development] nicesoni_ash:
You need to include masquerade repo in your local manifest.

Sent from my "1+2" powered by Unofficial RR 7.x.x

Compiled by myself
[OnePlus 3 & 3T Cross Device Development] Gandicela:
So thus far so GOOD, Mate. Nice!
[OnePlus 3 & 3T Cross Device Development] matssa:
Oh crap, I may have forgotten... I'll check, thanks :)

EDIT/// Already there, I included the project path in android/system/android/default.xml and included the package in device/oneplus/oneplus3/device.mk

Everything should be ok, right?

EDIT2//// didn't see that it was in the roomservice, gonna add it now... crap, I thought it was finally OK...
[OnePlus 3 & 3T Cross Device Development] matssa:
Do you have an example for this? It seems it doesn't want to pull the sh**, I think the revision is bad (use n instead of master?). Furthermore, if I already included it in the default.xml, is it necessary again?
[OnePlus 3 & 3T Cross Device Development] nicesoni_ash:
No, if it's in your default manifest, you don't need to add it again. Better to put the package name to build on your vendor common.mk.

Sent from my "1+2" powered by Unofficial RR 7.x.x

Compiled by myself
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok thanks, and gonna switch it to N, apparently it's not master anymore ^^.
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok guys, soooo without masquerade, OMS shouldn't be able to work, soooo I'm making a new build with masquerade and it should work after. I'll upload the build once I'm done.
[OnePlus 3 & 3T Cross Device Development] matssa:
Since masquerade isn't built, it isn't installed, so your themes applied using legacy mode. I'm making a new build and will share it once it is done. I removed the old one so that no one flashes the wrong version :)
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
Well, it is crazy because everything still applied and it did not use legacy mode or it would say that in app before applying and all layers stayed upon dirty flash. So......... this has something to do with it I believe, https://plus.google.com/+NicholasChumCDT/posts/HvhrhsKjAzp?sfc=false
[OnePlus 3 & 3T Cross Device Development] matssa:
Mmm maybe, but gonna use masquerade, just in case :)
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
Yep, I would do the same, it was just crazy how everything worked as planned and not legacy, lol can't wait! Great ROM by the way, first I tried 100% lineageOS
[OnePlus 3 & 3T Cross Device Development] Gandicela:
Sure, Mate. I'm not seeing anything wrong at my end though.
[OnePlus 3 & 3T Cross Device Development] matssa:
New build is uploading, currently at 10%, it can take about 1 hour I hope :/ Or maybe 2, I dunno, depends on the bandwidth...
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
nooooooooo! :p I cannot take the anticipation, lol, thanks for your hard work bud! will flash and test immediately
[OnePlus 3 & 3T Cross Device Development] nicesoni_ash:
No, that's not it. You still need to have masquerade included to have that security patch working.

Sent from my "1+2" powered by Unofficial RR 7.x.x

Compiled by myself
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
How come it still compiled correctly and did not act as legacy? Lol, strange
[OnePlus 3 & 3T Cross Device Development] nicesoni_ash:
Compiling won't give any issue as it isn't needed necessarily to have it compiled but to know how it's still working perfectly, need to have a look at the source as how it was build.

Sent from my "1+2" powered by Unofficial RR 7.x.x

Compiled by myself
[OnePlus 3 & 3T Cross Device Development] vivian&ondine:
Theme?
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
Reverie by Andre Zimmerman
[OnePlus 3 & 3T Cross Device Development] matssa:
OK guys build is live! Please test it to see if masquerade is included.
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
Man great job bud! Masquerade in, got root pop up, all is working, I thank u very very much!!!!
[OnePlus 3 & 3T Cross Device Development] matssa:
Hehe OK then, I'm happy :) I think I can change the thread title to add OMS.

I'll wait a bit though, and I only included the import stuff, I didn't add the misc stuff.

Furthermore, all of this will have to be done for the next update, I'm currently using mr1.
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
Awesome, looking forward to the additions and OMS commitsz thanks again bud
[OnePlus 3 & 3T Cross Device Development] ysco:
Hello dev,

Thanks for your work.

I just try your latest rom with OMS and masquerade and tested a few themes and all is working great. Masquerade is working perfectly .

Thanks again.

Regards ysco..
[OnePlus 3 & 3T Cross Device Development] Gandicela:
For the love of Pete, now it doesn't work for me. After a reboot i see it's theming my Pixel launcher but then a few seconds later it just blinds me with bl##dy white ui. I tried 2 themes, both failed. I'll have to try clean install again, perhaps
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
Wipe Masquerade and substratum app data and clear cache, also sometimes u have to rebuild the layers again instead of just applying them, all is working great for me.
[OnePlus 3 & 3T Cross Device Development] Gandicela:
Unfortunately, it didn't help. Thanks
[OnePlus 3 & 3T Cross Device Development] matssa:
It may be because I didn't pull everything from OMS, I only included the basic functionalities. I have 10 more repos to bring in... I'll try this later, but really if I have extra time.
[OnePlus 3 & 3T Cross Device Development] Nassi:
Anybody else having non working notification lights with releases 23. or 24. ? Worked for me before?
[OnePlus 3 & 3T Cross Device Development] matssa:
I still didn't test the latest build, gonna do it once my current build is done.
[OnePlus 3 & 3T Cross Device Development] matssa:
Do you have a log or something?
[OnePlus 3 & 3T Cross Device Development] Nassi:
I think this is the relevant error:

E ActivityManager: applyOptionsLocked: Unknown animationType=0

Battery light notification for example works, only notification lights for apps and missed calls stay off. Even if you configure it under settings (before you instantly saw the light by changing anything there, now the led stays dark)
[OnePlus 3 & 3T Cross Device Development] xantic21:
Is Boeffla kernel (beta 10) working (again) on latest build? On Build 23 WIFI was broken with Boeffla kernel.
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
It is confirmed... With 24/01 build notification Led do not work, neither with 3rd apps
[OnePlus 3 & 3T Cross Device Development] matssa:
Strange, can it be linked to OMS? Please test the latest build (25)
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
Downloading
[OnePlus 3 & 3T Cross Device Development] Gandicela:
the 20170125 build, does it now include the 10 more repos you mentioned?
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
Facebook notification started blinking Blue...will test sms and calls

Edit// it blinks with sms too (seems to be repaired ;))
[OnePlus 3 & 3T Cross Device Development] matssa:
No not yet, need more time to add it.
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok, may be linked to a new kernel patch? I'll take a look when the latest kernel has been updated
[OnePlus 3 & 3T Cross Device Development] NoobMonkey:
I'm on 2301 build and started today having problems with camera. Sound says that it takes a pic but nothing shows up on gallery and then it crashes. This happens both, OOS cam and built-in cam. Yesterday both worked fine so this is kind of confusing.