yashsingh1/xdaforums huggingface dataset:
[Magisk] hshah:
I probably can't help because somehow I managed to solve the losing root issue before a fix was actively worked on, and until recently the only applications that I have never managed to get working on a rooted device were ones created by Barclays (I'm excluded Samsung Pay etc because whilst that still doesn't work, I don't actually use it).

For the last month and a bit I've been running the Barclays bPay App, without any issues, whereas previously it detected root and closed itself.

I've attached screenshots of everything which may be of relevance in the hope that someone spots something.

Before anyone comments on the stupidly long list of apps that are currently "hidden", I'm currently in the process of gradually unhiding a few everyday to try and work out if it's one of them that is causing root to be detected.
[Magisk] martyfender:
I don't see the Magisk Hide screenshot, you mention, or are they essentially hidden by freezing them in TB? I don't use TB to know.
[Magisk] hshah:
Technical difficulties lol! How about now?
[Magisk] martyfender:
Is that a joke? For what reason would you hide all of those apps? They are surely not all root detecting apps? That is unreal.
[Magisk] hshah:
Read the last paragraph of my post...
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] I see [MENTION=4470081]topjohnwu[/MENTION] updated libsu extensively and also added that v2.0.0 to Magisk. As always, I look forward to your next release.

Thanks
[Magisk] ianmacd:
The changes actually aren't very interesting. All he's done is rearrange the classes somewhat. There are no functional changes.

Nevertheless, this the first commit in nearly a week.

EDIT: I've released a 20180727 build.

---------- Post added at 09:45 ---------- Previous post was at 09:33 ----------

Since the 20180726 build, my builds no longer contain the 64 bit binaries.

Their inclusion was almost without purpose at this point, serving only to assist diagnostic apps in correctly reporting the kernel architecture. However, DevCheck has been fixed and now properly identifies 64 bit kernels regardless, and Phone Info now once again incorrectly reports a 32 bit kernel regardless. Either way, continuing to include the 64 bit binaries serves no useful purpose.
[Magisk] neekless:
[MENTION=3306843]kantjer[/MENTION] your latest magisk manager (20180727) messes up the icon?

Edit: WHOOPS NVM. Reboot fixed it.
[Magisk] neekless:
[MENTION=3306843]kantjer[/MENTION] 20180727 version possibly breaks magiskhide persistance? After updating my magisk hide keeps turning off after I close magisk manager.

I followed the solution here but my /data/property/persist.magisk.hide doesn't exist. So I created a file named persist.magisk.hide with a value of "1" inside and it solved the problem, my magisk hide persisted, until after a reboot. My persist.magisk.hide disappears after a reboot and I lose magisk hide persistance again. Please check if it happens on your end. [MENTION=7187684]ianmacd[/MENTION] may I ask you to check too? I wanna know if it's my device or libsu 2.0 causing this.
[Magisk] martyfender:
For [MENTION=4470081]topjohnwu[/MENTION] , also:

It's not just your device, it happens on my Nextbook Ares 8A's also. In addition, I am still getting the: unfortunately, Magisk has stopped error after reboot. My guess is that if I uninstall the manager only and revert to the mm 20180719 or older, this message will go away, as it did with 20180721.

Edit: Despite the Magisk Hide toggle being off, my device is passing safety net and play certification. If I toggle it on, then off, it does not pass, as usual. So apparently it is working, but just not reflected correctly with the toggle switch.

EDIT: I just tested the [MENTION=7187684]ianmacd[/MENTION] 's latest build on one of my devices and it also has the same issues.

I can post logs if you want, but they appear to be almost the same as the ones I posted a few days ago.
[Magisk] kantjer:
I can confirm the issue. I'm using a latest "official" internal test build and have the same issue (and reported)

Edit, John fixed it in the source. I will make a new build when I'm home
[Magisk] ianmacd:
I've just pushed a 2018072702 build with [MENTION=4470081]topjohnwu[/MENTION]'s fix, plus a few new commits from today.
[Magisk] kantjer:
I need to change my build script to accommodate multiple daily builds.
[Magisk] svbarbosa:
Simple way - add build hour using military time.
[Magisk] martyfender:
5[MENTION=7187684]ianmacd[/MENTION] and [MENTION=4470081]topjohnwu[/MENTION] I flashed your latest build on one device and my error on reboot of: unfortunately, Magisk has stopped error was gone, as well as the apparent cosmetic bug of the Magisk Hide being unchecked, when it really was working.

Here is where the fun began. I flashed it on a second device, through the direct install method in mm as usual, after first installing your lastest MM.

When I rebooted I got the error that one gets when no boot.img is present, an android error, then the device shuts down. I reboot to TWRP and tried to flash your zip there and was met with the same error.

Apparently, a boot.img can eventually get corrupted after flashing multiple builds on the same, existing image.

I reflashed a fresh, stock boot.img, followed by your latest .zip and that second tablet is working great, just like the first one I flashed your latest build.

Do you guys alway flash a virgin, stock image, each time, or do you do as I have done and flashed over the existing boot.img, each time? This is the first time this has happened to me with that method.

EDIT: I have flashed it on a third device, and all has gone well, except For the magisk has stopped error is on it, like before.

All of these Nextbook Ares 8A's have this error in the logcat, filtered for com.topjohnwu.magisk, in the recent builds:

07-27 23:47:03.547 E/AndroidRuntime(6534): java.lang.RuntimeException: Unable to start receiver com.topjohnwu.magisk.receivers.BootReceiver: java.lang.SecurityException: Neither user 10128 nor current process has android.permission.WAKE_LOCK.

THANKS
[Magisk] DanGLES3:
You can boot into twrp with a broken boot.img? How's that possible? That's the first time i hear that,i always though if the boot.img is either broken or not there the phone wouldn't boot at all and would just vibrate
[Magisk] martyfender:
I am not knowledgeable enough to know that, all I do know is that when I flashed the stock boot.img again, followed by [MENTION=7187684]ianmacd[/MENTION] 's latest build, all was well again. This is a tablet and it does not have the hardware to vibrate. It was similar, but different to the screen you get when it does not have verity disabled in the boot.img, but even less info. Something like, this device cannot be verified. As I stated, I have never seen this screen before. I wish I had written the info down. It was as minimal and had very small, red, text with a black screen background. I do not know how to duplicate it. It is very different than when the bootloader/fastboot partition is messed up, in that case it would have booted to the efi boot manager screen, or ftm screen.
[Magisk] DanGLES3:
Thx for the info,so it only seems to happen on devices with dm-verity regardless of it being on or off?,so it seens to me like the kernel itself wasn't corrupted but it looks like its signature might have been broken or something (its just an idea)
[Magisk] martyfender:
I'm not sure if it is related to the dm_verity, I only gave it as an example as a screen that was similar only in black background but with very different text, layout and info.

Nextbook has never released stock roms so I have had to rely entirely on TWRP backups for the devices, created when the device was new. I do know that in the couple of instances I have reflashed those TWRP, stock backups, including the stock recovery, that they never passed verity because somehow the system must have been modified. Maybe because they were not originally mounted as read only in TWRP. So, as you stated, the signature must have been modified.
[Magisk] ianmacd:
That shouldn't be possible. You're just flashing the same changes over the top, over and over again.

I flash over the existing boot.img almost every time. The only time I flash over a virginal boot image is when I'm testing a new kernel build.

It's probably a device architecture-specific thing, because I'm not seeing any errors here on two Samsung devices. There are a couple of new commits today, but just documentation and SafetyNet-related stuff. As soon as I see something that resembles a possible fix, I'll compile a new build.

---------- Post added at 09:44 ---------- Previous post was at 09:38 ----------

Recovery has its own, separate boot image. Boot into TWRP and run uname -a in the terminal, and you'll see that you're running a different kernel in that environment than when you boot Android.

If you couldn't boot into recovery after flashing a bad Android boot.img, there would be a lot of bricked, unrecoverable devices all over the world.

A broken bootloader is a different matter. If you manage to trash that, you usually do have a big problem.
[Magisk] DanGLES3:
Thx for the information,really didn't knew that recoveries had their own kernels (always tought they used the system one),that makes so relieved knowing that even if i mess up my kernel i can restore it through twrp
[Magisk] martyfender:
Yes, some users posting on my Nextbook Ares 8A root thread have done just that by confusing the model of tablet that they have: the Ares 8 with Android 5+ vs the 8A with Android 6+. The two devices have totally different hardware and partitioning schemes. The users flashed totally incompatible files for their system and as far as I can tell, messed up the bootloader partition. I have recovered it before on the original 8, but have no idea how to recover it on the newer 8A's.

---------- Post added at 10:05 AM ---------- Previous post was at 09:54 AM ----------

I noticed you pushed out 20180728 and in the change log you state nothing new. Does that mean that it has none of the newer commits and fixes newer than the addition of libsu 2.0.0?
[Magisk] kantjer:
No that's a fluke. My first build hang on signing the app. The second build generated a changelog comparing that build with the previous 60 second old build. Hence no changes.

I hadn't thought of that situation when adding change log generation to the script.

Today's build has all the latest
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] I just installed 20180728 on 2 devices and when I check the safetynet status, it pops up the normal dialog to download proprietary code, which I approve, then it gets stuck continually in checking safetynet status.

I checked safetynet status in jrummy's root check app, and of course, it does pass, as usual. In addition, I confirmed that I had a good internet connection on both devices.

EDIT: The safetynet issue is also confirmed on [MENTION=7187684]ianmacd[/MENTION] 's latest, v16.8-2018072702. In all cases checking with the jrummy root check app shows that the devices pass safetynet.

And no, I do not have the MM hidden.
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=3306843]kantjer[/MENTION] I got this again, on a different device, the third of which I have now flashed @ kantjer 20180728.

On the other tablet I had this error, was when I flashed [MENTION=7187684]ianmacd[/MENTION] build. I fixed it once again by flashing the stock boot.img followed by your latest, 20180728.zip, in TWRP.

Was the boot patching code changed when Libsu 2.0.0 was added?

See attached images

THANKS!
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] I just updated one of my devices to v16.8-2018072801, with the latest fixes and the safetynet check is still stuck on checking. The jrummy root check app still shows that this, different device, passes, though. I also had to reflash the stock boot.img and flash the zip in twrp because the, different device, also booted to the screen that I posted in my previous post. It appears that something is wrong with the recent, boot.img patching code, at least for my devices. Does anyone else have this issue, or is this an isolated case?

EDIT: I uninstalled MM only and installed an older MM version and the safetynet check works once again, so it appears that the failing is in the changes to MM.

The install, TWRP and magisk logs all look normal to me, as far as I can tell, nothing appears any different to me, in them.

Attached is a recovery log failure, before I flashed the stock boot.img and your zip, again.

I hope this is useful, as I often don't get a response (and it is not always expected, of course, but much appreciated.), so I am never sure if my postings are a waste of time, or not?

Thanks
[Magisk] neekless:
Yeah, my safetynet also gets stuck on checking forever, on both [MENTION=7187684]ianmacd[/MENTION] or [MENTION=3306843]kantjer[/MENTION] latest builds, and one or two builds earlier.
[Magisk] ianmacd:
Yes, I confirm this is happening with my latest build. I'm not sure when it started, though, because I usually run with Xposed, so when I want Safetynet to pass, I have to reboot with the module disabled.

It's a minor bug, because SafetyNet is passing; just not with MM's own built-in check.
[Magisk] neekless:
Last working version was magisk manager 20180721 builds for both you and [MENTION=3306843]kantjer[/MENTION]. Later versions will get stuck on checking. Magisk versions doesn't matter it's only the manager causing the problem.
[Magisk] kantjer:
I wonder if "Shrink snet APK, and prevent crashing" commit helps to fix this safenet issue.

Pushed 20180729 build with that included.
[Magisk] ianmacd:
If that's when it broke (i.e. in my 2018072701 build rather than 2018072702), then it must have been the libsu update that broke it.

---------- Post added at 11:13 ---------- Previous post was at 11:11 ----------

No, my latest build already had that commit and it doesn't help. The master repo as of now still has the bug. It's got to be in the libsu update.

EDIT: Well, scratch that theory. I reverted the entire libsu update commit and the problem persists.
[Magisk] kantjer:
I'm stil using the last internal test build that was made 20180726, no issues on that one.
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] I am still getting corrupted boot.img's with both of your [MENTION=3306843]kantjer[/MENTION] [MENTION=7187684]ianmacd[/MENTION] and through testing, I determined that it is only through the direct install method that this happens.

When I update first through TWRP, this does not happen.
[Magisk] martyfender:
Attached are some better images.
[Magisk] anttaz:
[MENTION=7187684]ianmacd[/MENTION] could you include whatever fix is in this build to allow Santander UK app to run:

https://xdaforums.com/apps/magisk/santander-app-custom-rom-root-device-t3794753/post77196283
[Magisk] ianmacd:
There's no such version as 16.7.2, but my latest build from this morning is fully up-to-date with the official code repository, so any code commits that anyone compiled into a build yesterday are also present in mine.
[Magisk] anttaz:
Even on this morning build Santander app is detecting rooting even though hidden in magisk hide
[Magisk] ianmacd:
Magisk is GPL'ed, so ask the supplier of the version that works for you whether he modified the code and, if so, ask him to supply you with the modifications.

If he made no changes, then there has to be another explanation. Have you tried, for example, deleting the data of the Santander app? Many apps cache the fact that they once detected root, so you may need to force the app to forget.
[Magisk] abacate123:
Have you tried the "hide magisk manager" option? It'll change the manager apk package name. Maybe it'll help (?).
[Magisk] anttaz:
Yes tried both of the above options.
[Magisk] martyfender:
But did you try deleting the apps data and cache

after

hiding the Magisk Manager? If you did, then the app is detecting root some other way, possibly.

Some of the steps in this troubleshooting guide may help:

https://www.didgeridoohan.com/magisk/HomePage
[Magisk] anttaz:
This too not working, was worth a try thanks
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=3306843]kantjer[/MENTION] Here are logs for [MENTION=3306843]kantjer[/MENTION] 20180729 with Magisk crash, which look to be about the same as previous logs posted. First logcat is filtered for com.topjohnwu.magisk.

EDIT: Here is an unfiltered logcat from another device with [MENTION=7187684]ianmacd[/MENTION] build.

EDIT 2:
[MENTION=4470081]topjohnwu[/MENTION] One effect of using MM versions newer than 20180719 is that I alway get a: unfortunately, magisk has stopped error on reboot and on launching root apps the root granted toasts don't show up, even though root was granted for the app, unless I launch MM, then the toasts do show up. I believe I forgot to mention this in previous days posts for recent versions. Using MM versions, 20180719 and older, I don't have either of the above happening.
[Magisk] martyfender:
This is in regards to the safetynet check getting stuck.

In /data/data/com.topjohnwu.magisk/snet there is an snet.apk, which has the permissions of 600. Is it normal for it not to have the execute permissions? I have not went back to and older version of Magisk to compare this.

Thanks
[Magisk] neekless:
I'm using an older magisk manager with working safety net check. Snet.apk has permission 600. So that's not the issue.

Edit: to be specific the 20180721 version of magisk manager. both ianmacd and kantjer's version works.
[Magisk] kantjer:
The snet issue should be fixed in the 20180730 build :fingers-crossed:

---------- Post added at 16:38 ---------- Previous post was at 16:24 ----------

Friendly reminder and request to all.

Please be aware builds found here are unofficial and potentially unstable.

Also please don’t report issues and post logs concerning problems found while running any unofficial build in the official stable or beta thread.

If you want to report a problem while running an unofficial build do it in this thread, and like in the official beta thread reports without logs will be ignored.
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] Yes, snet is fixed. However, when I try to use the direct install, mm crashes. So I installed Magisk through twrp successfully and rebooted.

I then launch mm and get a popup dialog message:

Requires additional setup

Your device needs additional setup to work properly. It will download the magisk setup zip. Do you want to proceed?

I click yes and mm crashes.
[Magisk] kantjer:
weird, by the sound of it it seems that you can't update the Magisk binaries.

I will check your log and report hen I'm at my PC (I don't like checking logs on my phone)
[Magisk] martyfender:
I keep getting bad gateway when I upload the logs. 2 of them open, but when I try to reupload the small magisk.log it won't open when I try later?

EDIT: I zipped the magisk.log and it worked. The recovery.log sent unzipped, but magisk.log didn't, go figure?

On one of the 2 tablets I updated, I uninstalled MM

only

and installed the mm 20180719.apk and all seems well again.

Also that message that I reported is a popup dialog box, not the same as when you see the magisk is not installed error, that was in some past builds.

All apps I have tested have root access.

The magisk binaries in /sbin/ show a date of 7/30.
[Magisk] kantjer:
Can you please test the attached build :fingers-crossed:
[Magisk] hshah:
What's vunofficial? :silly:
[Magisk] kantjer:
removing that "v" prefix is a constant battle

Removed it in at least 10 different places in the source but it keeps showing up.
[Magisk] guest4711:
Short of "version unofficial" ;)
[Magisk] hshah:
Damn that peskv V... alvays cropping in ve most annoving of places :laugh:

I took it to mean "very unofficial" :p
[Magisk] mkdante381:
My Samsung Galaxy S5 ([ROM][8.1.0_r36][OFFICIAL] AospExtended ROM V5.7 [DUI]) stuck on aosp extended logo, after uninstall unofficial build Magisk 20180730

Pls help I can't using my smartphone!!
[Magisk] guest4711:
Did you try to reflash your original (stock) bootimage? Magisk makes a backup usually (stock-......img), you can also extract it from your ROM. Or you can try to flash "dirty" your ROM (without wiping data).
[Magisk] martyfender:
I just installed your test mm and then the test Magisk. Zip through the install module fuction and no messages on reboot and safetynet test works.

However, viewing the per app logcat in logcatx for mm appears to show the same as the one I posted earlier.

I am at work and updated another tablet than the one previosly, as it is at home.

so far, no other prblems.

What was changed? Only what is in the changelog built in to mm, or more?

Thanks
[Magisk] kantjer:
This was the fix: https://github.com/topjohnwu/Magisk/commit/e39f83edbf81be2751357c7da4952dd353fa4637

John found the issue (Accidentally unmounted the database when clearing up debris) based on your logs.
[Magisk] martyfender:
But I didn't have the mm repackaged or hidden, or does it still apply?

Was it for the crashing on restart or the corrupted boot.img with direct install, or both?

Or, I forgot the additional pop up to install other needed files?

Sorry not use to typing on a cell phone, I usually do it on desktop or tablet.

I also see my signature does not show, where all my device info is listed.
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=7187684]ianmacd[/MENTION] [MENTION=3306843]kantjer[/MENTION] I just got home from work and on one of my 4 Nextbook Ares 8A's I have ianmacd build on it. kantjer, it has those commits in your test build, plus newer. MM crashes on direct install, but works fine if I use the install module option. on reboot, I get the unfortunately, magisk has stopped error.

When I launch mm I once again get the popup dialog:

Requires Additional Setup

Your device needs additional setup for Magisk to work properly. It will download the Magisk setup zip, do you want to proceed now?

I get a very brief dialog:

running environment setup

then:

Unfortunately, Magisk Manager has stopped.

Will provide logs, shortly..............

EDIT:

When I uninstall the latest ianmacd

MM only

, and install kantjer's test mm: MagiskManager-20180730.apk I do get the error at boot, but not the popup dialog to install additional files. So now, I am confused, ian's build has those commits according to his changelog.

EDIT2:

I guess I am a glutton for punishment, to a certain degree. I uninstalled kantjer test MM, and installedMagiskManager-v16.8-2018073001-ianmacd.apk and don't get the dialog popup on stable channel, but if I change the update channel to either beta or add ian's custom channel I do get the message to install additional files. If I select yes, mm crashes, once again.

EDIT3:

More testing indicates that either ian's or kantjer's MM get the popup to install additional files when I insert your respective update channel into your respective Magisk Manager, when either are installed. [MENTION=4470081]topjohnwu[/MENTION], [MENTION=7187684]ianmacd[/MENTION] or [MENTION=3306843]kantjer[/MENTION] , do you have any idea what is going on? So apparently, the test build did not fix the issues, after all.

Zipped logcat is unfiltered, for whole device. The others are filtered for com.topjohnwu.magisk.

EDIT4:

Upon further testing of your test build [MENTION=3306843]kantjer[/MENTION] on the original and a second device, it appears I was wrong, it is working as expected when both your test mm and Magisk.zip are used together.

I'm not sure what is different about ians builds, since his has those commits plus newer ones.

Feel free to ask if there is any additional info I can provide to help the cause.

Thanks, all of you for your dedication and hard work!