yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 & 3T Cross Device Development] ivanich:
[MENTION=6313536]matssa[/MENTION]

Seems like my theory about f2fs backward compability makes sense. I flashed https://xdaforums.com/showpost.php?p=70541197&postcount=2519 , then did fsck.f2fs /dev/block/sda15. Need some more time for testing but I have feeling that it should be fixed for me.

Also dropped usb commits in order to merge stuff from dianlujitao kernel repo and now testing how it goes(all f2fs stuff included) https://github.com/ivanich/android_kernel_oneplus_msm8996/commits/cm-14.1-test

And there is new adreno libs 156392 156393 https://github.com/dianlujitao/proprietary_vendor_qcom_binaries/commits/cm-14.1

1000 post! :)
[OnePlus 3 & 3T Cross Device Development] matssa:
Woot, congrats for the 1000 post! ;)

For the USB stuff, can it be linked to F2FS? I just tried with the PC of my gf and no issues, can switch to mtp, etc.

In the repo from dianlujitao, what is new? And nice for the proprietary stuff, will merge this when I get access to the PC.

Concerning the F2FS, [MENTION=5370545]piats[/MENTION] had some deadlocks as well, and apparently slimrom has the same issues. I think LinrageOS should revert until it is better.
[OnePlus 3 & 3T Cross Device Development] matssa:
OK checked the repo, there's a lot of stuff in there! Does it fix anything for you, maybe the vibration stuff or battery drain.
[OnePlus 3 & 3T Cross Device Development] ivanich:
Actually not sure about usb vs f2fs stuff, but dianlujitao pushed ~100 commits with some camera,ipa, wifi and usb stuff and it conflicting with gerrit usb patches thats why I dropped them. Regarding deadlocks - I'm almost sure it's incompatibility with old f2fs twrp implementation and newer driver, so new twrp from eng.stk fixed it for me, at least it works fine more than a hour, before it crashes in a 5-10 minutes.

Also read last 2-4 pages here about similar f2fs issues https://xdaforums.com/oneplus-3t/development/rom-unified-lineageos-cm14-1-t3525551/page25
[OnePlus 3 & 3T Cross Device Development] matssa:
Mmmh OK I'll take a look, if I merge your stuff, will it automatically revert the USB patches that you already reverted?

For the deadlocks, if this is the reason, then we can keep it but specify the recovery to use, which seems a bit of a hassle.
[OnePlus 3 & 3T Cross Device Development] ivanich:
Nope, I've completely dropped them.
[OnePlus 3 & 3T Cross Device Development] smouker:
I flashed the f2fstest Build, but I actually noticed that

/system changed back to ext4 fs...
[OnePlus 3 & 3T Cross Device Development] matssa:
OK I'll do the same then ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
OK, I suggest you use the new TWRP version since it fixes that stuff apparently.
[OnePlus 3 & 3T Cross Device Development] ivanich:
It's ok, there is no f2fs support for system partition. Only data and cache.

Отправлено с моего ONEPLUS A3000 через Tapatalk
[OnePlus 3 & 3T Cross Device Development] smouker:
Where can I grab it or wich version is it?
[OnePlus 3 & 3T Cross Device Development] ivanich:
https://xdaforums.com/devdb/project/dl/?id=22583

https://www.androidfilehost.com/?fid=457095661767129727

Second one compiled by dianlujitao with new f2fs driver, I've not tested dianlujitao's version yet.
[OnePlus 3 & 3T Cross Device Development] smouker:
Thx.

Tried it with 3.0.3-N but System changes back to ext4
[OnePlus 3 & 3T Cross Device Development] ivanich:
I said before you cannot change system partition to f2fs, this is not supported.
[OnePlus 3 & 3T Cross Device Development] dante_nfs:
you can't format system partition to f2fs but you can format data to f2fs and there is no benefit in system f2fs since all the heavy lifting is in data partition, the only rom and kernel that supports system, cache, and data f2fs is arters rom.
[OnePlus 3 & 3T Cross Device Development] philidor:
But, if I understand right, there is little advantage of system partition f2fs. But it's useful to have cache partition in f2fs. For me it work without issues but it's useful or only a placebo effect?

Thanks

Inviato dal mio ONEPLUS A3003 utilizzando Tapatalk
[OnePlus 3 & 3T Cross Device Development] dante_nfs:
Well i believe that is placebo effect and there is no benefit in catch f2fs, the system reads and writes mostly in data partition, and just reads in system partition and ex4 is not bad at reading.
[OnePlus 3 & 3T Cross Device Development] matssa:
For those who use F2FS, can you please test with the TWRP recovery from dianlujitao? https://www.androidfilehost.com/?fid=457095661767129727

If should fixe most of the issues. Thanks!
[OnePlus 3 & 3T Cross Device Development] tomhtg90:
i think smouker already tested it
[OnePlus 3 & 3T Cross Device Development] smouker:
I already did that yes but nothing changed at all.
[OnePlus 3 & 3T Cross Device Development] matssa:
The new recovery should fix the deadlocks, not the system F2FS format.

If I make a head count, who has deadlocks and who doesn't have any issues? Data must be at F2FS since the latest ROM is specific for this version. Please use the new recovery as well!

If too many people have the deadlock issues, then we may revert the patch.
[OnePlus 3 & 3T Cross Device Development] ivanich:
I believe all f2fs issues has been sorted out and this code should be kept as is.
[OnePlus 3 & 3T Cross Device Development] matssa:
By using the new TWRP version. This means that everyone needs to use the new TWRP, until the official one is sorted out.

I'll add it to the first post when I get the chance :)
[OnePlus 3 & 3T Cross Device Development] ivanich:
AFAIK official twrp is not compatible with Nougat firmware so anyway all use custom twrp builds.
[OnePlus 3 & 3T Cross Device Development] dante_nfs:
Did you guys looked at the twrp v12 by eng.stk? Ivanich what you think about it, he is a f2fs lover and i always use his kernels( I'm disappointed with oneplus because of OOS4 sources)
[OnePlus 3 & 3T Cross Device Development] matssa:
True, since kernel isn't open source yet.
[OnePlus 3 & 3T Cross Device Development] ivanich:
v12 by eng.stk solved f2fs deadlock issue for me, but I don't like his custom logo :) So I moved to dianlujitao's twrp.
[OnePlus 3 & 3T Cross Device Development] smouker:
Okay, now I understand it correctly.

Got no Deadlocks so far and everything seems fine tho

Cheers
[OnePlus 3 & 3T Cross Device Development] davemuir:
I can't seem to get into recovery with that. Screen flickers constantly when I try.

eng.stk works fine, though.
[OnePlus 3 & 3T Cross Device Development] Jole7:
Guys try Arter97's recovery it has all the fixes and latest F2fs drivers

http://www.arter97.com/browse/op3/AOSPA/
[OnePlus 3 & 3T Cross Device Development] matssa:
Dianlujitao built the recovery with the fixes it seems already ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Strange, did you flash or use ADB?
[OnePlus 3 & 3T Cross Device Development] davemuir:
ADB.

Very strange.
[OnePlus 3 & 3T Cross Device Development] matssa:
Mmmm.... I'll test it out now ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Just flashed via TWRP, works ;)
[OnePlus 3 & 3T Cross Device Development] davemuir:
Just tried again via twrp, same issue.

Do you need to decrypt with a password when twrp boots up?
[OnePlus 3 & 3T Cross Device Development] matssa:
Nope, and im not using f2fs either
[OnePlus 3 & 3T Cross Device Development] piats:
Same issue here. I flashed it via recovery.

But anyway latest recovery by eng.stk seems to be working better than expected!

I'm now able to pass safety net with magisk + phh's su!

So **** yes finally I'm able to use f2fs + every root method works + safety net passes!

Million thanks to [MENTION=6313536]matssa[/MENTION] [MENTION=4329165]ivanich[/MENTION] [MENTION=3873953]eng.stk[/MENTION]
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah I included the changes from sultan in order to bypass safteynet check :) I'm happy it works :) <3
[OnePlus 3 & 3T Cross Device Development] [deXter]:
Thank you - confirmed that arter97's recovery fixes the f2fs deadlock issues! Also ran an fsck.f2fs and found errors in both my /data and /cache partitions, which were fixed. Then dirty-flashed matssa's latest f2fstest build and haven't experienced any of the app crashes I was getting earlier.
[OnePlus 3 & 3T Cross Device Development] Jole7:
You're welcome no problem.
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
[MENTION=6313536]matssa[/MENTION], nice work, cache and data formated to f2fs, using [MENTION=4898097]arter97[/MENTION] TWRP and everything seems to work fine ;)
[OnePlus 3 & 3T Cross Device Development] dante_nfs:
Guys eng.stk pulled out twrp v12 because of some problems, just wanted to notify you.
[OnePlus 3 & 3T Cross Device Development] Jole7:
Use arter97's instead
[OnePlus 3 & 3T Cross Device Development] matssa:
OK guys so now that we now that the f2fstest build is OK, did anyone test the sdcardfstest build? It doesn't have the commits from f2fstest in order to reduce the number of variables if crashing would occur.

If it works, I'll merge both in the new test builds.
[OnePlus 3 & 3T Cross Device Development] hasdroid:
Hey..

İs there anybody facing that issue in phone or contact apps... althogh just with contacts that have whatsapp... İt was fine on OOS or my old S6 tho..
[OnePlus 3 & 3T Cross Device Development] siankatabg:
Finally everything has been merged 1 minute ago :)

https://review.lineageos.org/#/q/project:LineageOS/android_device_oneplus_oneplus3
[OnePlus 3 & 3T Cross Device Development] EatBeans:
I have the issue. If you install the contact app by google you can quickly link the duplicates Into one
[OnePlus 3 & 3T Cross Device Development] hasdroid:
Can you explane a how-to please!?
[OnePlus 3 & 3T Cross Device Development] matssa:
Yup almost everything got merged with some extra stuff like the camera blobs :) some items are still necessary to test.

[MENTION=4329165]ivanich[/MENTION], did you find anything strange in the merged commits? It appears like some of them come from your side (sound trigger, camera), dunno if the ril is the new one though.

In any cases thanks everyone for your help! I'll continue making some builds, but apparently some regular builds will soon be launched :)
[OnePlus 3 & 3T Cross Device Development] piats:
Well big thanks to you! Maybe you could still build with OMS support?
[OnePlus 3 & 3T Cross Device Development] ivanich:
All commits are fine but there is no new camera blobs actually, maybe dianlujitao just preparing for new blobs when kernel sources gets released. Ril is opensource and soundtrigger was broken with M blobs.

BTW video recording is broken because of disabled HAL V1 hack.
[OnePlus 3 & 3T Cross Device Development] siankatabg:
My comment wasn't meant to tell you to stop making builds :D I just reported here, because you are the most active "experimental" builder and this should be a good news for you. Now you will have time for some more fun things like OMS or something else :P I might to try play with the OMS too, but first I need to download the Lineage source(I didn't make a build since the dead of CM).
[OnePlus 3 & 3T Cross Device Development] EatBeans:
Yep. Download Google Contacts from the playstore. Then go to suggestions and you will be able to fix this duplicate issue. Hope I could help you ;)
[OnePlus 3 & 3T Cross Device Development] hasdroid:
Thanks for trying to help but I tried this before without luck... Anyways I did it manually hopfull it will not come again
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah I'll be able to work on this, but will first need to clear some stuff in the room service in order to use my own repos and merge it with OMS repos.

Oh I thought he added a new camera blobs, my bad. Did you try using [MENTION=4837394]siankatabg[/MENTION] camera port?

Hehe no worries ;) I'll try to play with it a bit as well when I sort out the main repo.
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
[MENTION=6313536]matssa[/MENTION]

I hope you don't mind me asking what your build process is when merging in OMS commits and anything else that's necessary in order to achieve full OMS support. I tried experimenting on my own but the build had failed. I mentioned to you it may have something to do with the January patch... I've mentioned before I'm new to building ROMs so I haven't quite got the gist of it yet. Do you simply include the source from:

https://github.com/TeamSubstratum/masquerade

https://github.com/SubstratumResources/

Into the roomservice.xml? I tried following this from the OP on the respected thread but got a build error which I posted. Thanks for helping me out and taking time to educate me on building from source haha. :good:
[OnePlus 3 & 3T Cross Device Development] matssa:
What I was thinking is to fork the needed repos from LinrageOS, insert them in the roomservice so that it always uses my repos, then merge the different repos from the OMS team so that I takes all the necessary commits directly :) otherwise, there are many commits that needs to be cherry-picked...
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
That's what I was thinking as well! Their instructions kinda threw me off because cherry-picking each commit individually may take a decent amount of time. :good:
[OnePlus 3 & 3T Cross Device Development] matssa:
Or another way is to use their command, the git cherry-picked ssha^..ssha cherry-picked everything between these two commits :) may be easier than creating a repo and all ;)
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
Okay so I made a couple changes and I'm going to see if I'm able to successfully build. Take a look at the attachments. :good:

I also added masquerade to:

# Required CM packages
PRODUCT_PACKAGES += \
BluetoothExt \
CMAudioService \
CMParts \
Development \
Profiles \
WeatherManagerService \
masquerade

In the common.mk file located in:

/vendor/cm/config

As a result though, this is the error I got.

fatal error: too many errors emitted, stopping now [-ferror-limit=]
│20 errors generated.
│build/core/binary.mk:986: recipe for target '/home/sambegui/WORKSPACE/LineageOS/out
│/target/product/oneplus3/obj/STATIC_LIBRARIES/libbatterymonitor_intermediates/Batte
│ryMonitor.o' failed
│make: *** [/home/sambegui/WORKSPACE/LineageOS/out/target/product/oneplus3/obj/STATI
│C_LIBRARIES/libbatterymonitor_intermediates/BatteryMonitor.o] Error 1
│make: *** Waiting for unfinished jobs....
│make: Leaving directory '/home/sambegui/WORKSPACE/LineageOS'
│
│#### make failed to build some targets (35:23 (mm:ss)) ####
[OnePlus 3 & 3T Cross Device Development] matssa:
Really strange errors... I can't really help out, try to add masquerade only, then build. Then try by adding the repos.
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey guys I'm cleaning a bit the repos in order to start fresh from [MENTION=4329165]ivanich[/MENTION] ones' since he removed some stuff, added some, etc... So from now on, please use branch cm-14.1 until I add the sdcardfs stuff again ;)

This WILL have the F2FS stuff included, so please use the correct TWRP!

Btw, [MENTION=4329165]ivanich[/MENTION], can you revert the commits that you pull? It would be easier for me to keep the repo up to date with a merge instead of searching and stuff ;)
[OnePlus 3 & 3T Cross Device Development] ivanich:
You should rebase all your repos from upstream, however I'm going to delete all op3 repos from my github because it's not needed anymore.
[OnePlus 3 & 3T Cross Device Development] matssa:
How come you want to delete? You can still bring stuff that is needed or other stuff :)
[OnePlus 3 & 3T Cross Device Development] matssa:
Furthermore, don't you have more updated blobs from what is already merged? Don't you have some commits that are not yet in LineageOS? If you want to delete, why not upload these commits? :)

I saw that some blobs were merged in TheMuppets, are they the same as yours?
[OnePlus 3 & 3T Cross Device Development] ivanich:
The reason I was created these repos is a big number of gerrit open changes which was hard to manage but now all the stuff got merged and small changes could be uploaded to gerrit and repopick'ed at build time.

Instead of redefining roomservice I can just clone needed repo, make changes and do something like that in order to upload to gerrit

git push ssh://<name>@review.lineageos.org:29418/LineageOS/android_kernel_oneplus_msm8996 HEAD:refs/for/cm-14.1

---------- Post added at 11:53 AM ---------- Previous post was at 11:51 AM ----------

Blobs are the same. I'm using official repos for now. Actually there is no commits that needs to be merged to LineageOS
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok thanks for the info, I'll delete (again) my repos and fork those from LineageOS ;) You can still keep yours in git, just don't update them ;)
[OnePlus 3 & 3T Cross Device Development] matssa:
Hey guys it will take a bit longer than expected to have a build, I'm making a new VM with a lower HDD, so I'm getting issues either with repo command, either breakfast command, or other stuff... Gonna switch from xubuntu to Lubuntu and gonna install everything from scratch.
[OnePlus 3 & 3T Cross Device Development] hasdroid:
Take your time bro.. Your builds are the best.. :good:
[OnePlus 3 & 3T Cross Device Development] matssa:
OK guys managed to create the VM, launched a build but wasn't successful (seems like it didn't use my 10Gb RAM or something). I updated my repos using stock lineageOS, uploaded some changes on review.lineageos.org, and made two different test repos (one with sdcardfs, one with device stuff). More should come as soon as they change the security stuff (they must remove the spaces for us to test the topic) and USB stuff.

Tomorrow I should be able to have a build :) I hope... ;)
[OnePlus 3 & 3T Cross Device Development] bombaglad:
hey, can anyone tell me how they managed to pass safetynet? did a clean install of this rom, followed the instructions, but i keep getting the infamous CTS profile error. thanks for tips! and cool rom btw, had no other problems so far using it :)
[OnePlus 3 & 3T Cross Device Development] stryker09:
I seem to be having issues with breakfast command as well, not sure how I'm going to fix it yet but might redo my repos...

update: well shoot, breakfast seems broken? i deleted my sources and re-repo sync'd to no avail. seems like it might be related to the oneplus device tree, bacon isn't working either whereas bullhead/angler works just fine. not so sure about this then.

edit: nevermind, my vendor was not updated properly :P
[OnePlus 3 & 3T Cross Device Development] matssa:
What are you using to pass it? What SuperSU? Maybe [MENTION=5370545]piats[/MENTION] can help you out on this since he managed to make it work.
[OnePlus 3 & 3T Cross Device Development] matssa:
Ok guys so I managed to make a build, gonna make it again cause I forgot some items. Since there are a lot of different changes, I don't want to include everything to avoid issues and see what causes the issues.

For now, I will test the sdcardfs. This is mostly for the F2FS users, EXT4 users won't change anything. Furthermore, I included the photo merges, if you have issues, please tell me.

Tomorrow, if everything is ok for you, I'll include more changes, but this relies on your help! I can't test everything :)

Thanks a bunch! Build uploading ;)
[OnePlus 3 & 3T Cross Device Development] bombaglad:
well, the classic way, magisk and phh's SU. but, safetynet helper says, it doesn't even pass (CTS profile mismatch) after a clean flash without any magisk or other mods, so the problem has to be somwhere else, but i'm unaware of the cause... i mean, it is supposed to pass after a clean install, right?

[MENTION=5370545]piats[/MENTION], please could you tell me how you made it?
[OnePlus 3 & 3T Cross Device Development] matssa:
New build is up guys, changelog in first post. It's big since I added everything that was done since last build ;)
[OnePlus 3 & 3T Cross Device Development] piats:
Go to magisk settings and enable magisk hide and reboot.

If that doesn't work wipe system and reflash ROM + unSU.zip.

Then flash magisk etc.
[OnePlus 3 & 3T Cross Device Development] matssa:
Can you please share you unSU zip file? :)

I tested it on my side and I get the same CTS failure check, dunno if it is because I use EXT4 instead of F2FS ^^ Do you know if Xposed ever worked with F2FS partition?
[OnePlus 3 & 3T Cross Device Development] piats:
Here's that zip: https://xdaforums.com/showpost.php?p=63615067

I thought that Xposed doesn't work with nougat?
[OnePlus 3 & 3T Cross Device Development] matssa:
No not yet, but since they will bring it (I hope), it may be the same as before, so if it didn't work on MM for F2FS, maybe it won't work for Nougat.
[OnePlus 3 & 3T Cross Device Development] matssa:
New builds are underway guys in order to fix the camera issues (new camera commits may break the touch to focus and recording, so going back to what it was before and gonna make a second test branch). I won't be able to upload everything though, so I'll upload only the sdcardfs build.
[OnePlus 3 & 3T Cross Device Development] qhsusb_bulk:
Dirty flashed 01-17 build. Built in root broken. Data and cache partitions are F2FS.

EDIT: Flashed SuperSU 2.79. No problem.
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah it seems this is normal since a commit has been merged that removes the intergrated SU unless a lline is specified somewhere to add the SU addon. The thing is that the SU addon is still not made, so no SU unless I revert that commit, either you guys flash systemless with magisk and SuperSU or other (which is better IMO).
[OnePlus 3 & 3T Cross Device Development] qhsusb_bulk:
Thanks for your answer. Your builds are running well. No deadlocks, good battery life, stable for daily using.
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
[MENTION=6313536]matssa[/MENTION], sorry, but I didn't have time yet to read every thing about f2fs. I have already your build with f2fs data and cache... I have seen your updated build but you only say it is sdcardfs. Is that a build for us that have f2fs file system? Many thanks for your awesome work
[OnePlus 3 & 3T Cross Device Development] matssa:
Yeah the F2FS stuff is now merged directly in LineageOS, so now I'm only gonna add the open commits. The latest build is to test the sdcardfs. If it works, I'll add open commits on top.
[OnePlus 3 & 3T Cross Device Development] PuCiNhOOO:
But what I dont understand is for what the sdcardfs stuff is :P

Sorry, but work and baby daughter store my all time and Google is not a good friend when asking what is sdcardfs xD
[OnePlus 3 & 3T Cross Device Development] yung40oz84:
I thought the merges were kernel side, not ROM side as u said f2fs stuff is merged into lineage now? Or is it merged I to stock lineage kernel also? Thanks, just confused, lol
[OnePlus 3 & 3T Cross Device Development] matssa:
If I understand correctly, the sdcardfs commits are fixes when you format your sdcard to F2FS. Maybe [MENTION=4329165]ivanich[/MENTION] can tell you a bit more ;)

The F2FS kernel side. It was merged into LineageOS without any prior testing. With [MENTION=4329165]ivanich[/MENTION], we added this merge into our ROMs in order to test it, that is how we found out that there was an issue with old F2FS partitions when using the new Linux F2FS stuff. This is also why we need to format /data if using the new F2FS stuff.

Now, this is fully merged into LineageOS, and I forked it from their repo. Now everyone needs to use the new updated recovery if using F2FS.
[OnePlus 3 & 3T Cross Device Development] ivanich:
FYI, I never said that format is required, all I did in order to fix f2fs deadlocks is just fsck(repair filesystem from new twrp)
[OnePlus 3 & 3T Cross Device Development] bombaglad:
thanks, i did it again and everything's fine now :)
[OnePlus 3 & 3T Cross Device Development] SamuelBegui:
[MENTION=6313536]matssa[/MENTION]

Silly me. As far as I'm aware, the build kept failing because I kept trying to build with this included commit.

https://github.com/SubstratumResour...mmit/da738b2edc528a9c0a7a048a7d820e57f391e979

I'm going to try again and if I'm successful I don't mind uploading it for everyone here, I'm going to be using your roomservice with OMS support and hopefully it will work! :good: