yashsingh1/xdaforums huggingface dataset:
[Magisk] armando_rod:
I flashed 180614 (last build with invincible mode and A/B support apparently) and I'm going to 24h without root loss Pixel Android P beta 2
[Magisk] martyfender:
180614 continues to work well for me also.

---------- Post added at 11:57 AM ---------- Previous post was at 11:56 AM ----------

I updated my post above.

"meganism" That is a new word on me, I had to look it up. Forgive me, I turn 60 tomorrow!

Do you have any idea why [MENTION=4470081]topjohnwu[/MENTION] removed invincible mode? He doesn't comment his code very often as to what each commit does, at least where a non-programmer can understand. And no disrepect on his part intended. His work is great.
[Magisk] kantjer:
Congratulations, you are one year ahead of me.

End of next year it is my turn.
[Magisk] martyfender:
Note that I do not loose root as long as my device is plugged in to a charger. It looses root after doze and wakeup. It usually occurs after the device is asleep for a long period of time, as in hours.

This morning, though, I updated to your latest build, with Magisk Manager not battery optimized and root loss occurred within a few minutes. In this case the tablet was unplugged, as it always is when I loose root.

I am going to turn off aggressive doze in Greenify, to see if that helps, also. Some state that aggressive doze may not be beneficial, but on my tablets, it appears to save a small amount of battery power, not much, though. Finally, Magisk is, of course, not "Greenified". Very few apps are.
[Magisk] ianmacd:
I assume he meant mechanism. :)
[Magisk] kantjer:
Now I need to decide, blame my age or spellchecker
[Magisk] martyfender:
I flashed 180621 on a second device and lost adb access. nothing was listed with:

adb devices

I reverted it to 180614 and I still have no adb access on that device, weird.

I had just restored the ROM a few weeks ago on that device. Nextbok has never released factory images so I have to depend on TWRP backups created when the devices were new.

However, on my 3 other Nextbook Ares 8A's I do have adb access from Linux Mint.

All devices have adbd in /root/adbd and /sbin/adbd. And that is a directory named root in the root directory. I thought the normal location is /system/bin/adbd in most versions of Android, or am I wrong?

Does anybody have any ideas as to what might have happened?

UPDATE: I figured it out, somehow USB debugging got turned of for that device, however, I am not sure what caused that. Maybe reflashing the stock boot image, a few days ago, was the cause?

Thanks
[Magisk] guest4711:
When properly flashing a stock image over a custom rom you should wipe all settings (perform a factory reset) which should also disable usb debugging (and developer options).
[Magisk] martyfender:
I flashed the stock boot.img in TWRP Then I immediately flashed Magisk.zip, before reboot, since I am unencrypted and prefer not to delete my data unless absolutely necessary. It is a stock ROM, since no custom ROM is available for my Nextbook Ares 8A.
[Magisk] joluke:
Well after a while and reading a few pages back. I went to github and tried to figure which of the commits would break stuff up in the Note 8 (SM-N950F) and can't figure what commit was done to crash the UI and cause the whole device to become irresponsive.

Can it be that setting SELinux to permissive breaks magisk?

I can only think of it since the only log i could get was this, after flashing 20180621 build zip:

https://www.dropbox.com/s/5ghmc8jomdtoh09/magisk_log_20180621_050824.log?dl=0

PS: Build 20180614 is the only one that works fine, no root loss or any crashes.

From that build i get total freezes and random crashes and reboots.

Trying to provide a fix for the note 8 community since i am no developer (trying to help... sorry)
[Magisk] pjrs2812:
I flashed kantjer's 20180621 build on a galaxy note8 ruinng latest stock Oreo firmware with a permissive kernel. So far I have not lost root for serveral hours. Fingers crossed.

I have not been able to able to run Titianbackup on any of the unoffical builds I have installed. Always get an error that root is not installed. I've uninstalled and reinstalled Titanium Backup. All other root apps.

Has anyone else had this problem with Titaniumback? I run out of ideas how to diagnose and fix the problem.
[Magisk] fedez:
Titanium backup working on 20180619 build from ianmacd. Note 8, oreo custom rom, permissive kernel.

Enviado desde mi SM-N950F mediante Tapatalk
[Magisk] dingolino:
Will you release this version?

Best regards

dingolino

Gesendet von meinem SM-N950F mit Tapatalk
[Magisk] ghbuur:
yep, reinstall helped and made it work again ;)
[Magisk] pjrs2812:
I previously tried ianmacd's 20180619 build with the same result. I guess Titanium backup is not finding the su binary. Do you know if the the apk is hard coded to look for the binary in a specific location?
[Magisk] fedez:
I don't know bro, what I think of this that you can try other versions of titanium backup.

Enviado desde mi SM-N950F mediante Tapatalk
[Magisk] kantjer:
That's the 180621 build on my Git
[Magisk] martyfender:
The only solution on my devices to solve the root loss issue, is to revert to 180614, where invincible mode is still there. I have tried both your and [MENTION=7187684]ianmacd[/MENTION] 's recent builds, to no avail.

Does anyone have any ideas why [MENTION=4470081]topjohnwu[/MENTION] removed it?
[Magisk] fedez:
Bro can you share the direct link to that build?

Enviado desde mi SM-N950F mediante Tapatalk
[Magisk] ianmacd:
He's pushed quite a few big changes through in the last week. We've seen some obvious bugs, and there are probably others, too, that we haven't discovered yet. Another large change went in towards the end of the day yesterday (UTC).

I don't know why invincible mode was removed, but it might not even be a permanent thing. I don't know on which basis the developer pushes his commits to GitHub. Possibly he always tries to leave the code in a working state, because he knows people are compiling snapshots for production use, or possibly it's just good luck if it all seems to work when you install it. I'm a relatively recent convert to Magisk, after using it once when it was first released, and sticking to SuperSU after that until the latter's de facto demise forced my hand. The latest code does, at least, always seem to build cleanly.

Whatever the case, running these snapshots is not without risk, so it's always good to know the date of the last version that worked well for you.
[Magisk] hshah:
I had somehow sorted the root loss issue on my Samsung Note 8 and have been running fine for weeks with v16.3.

Been flashing the dailies for the last couple of days and haven't lost root with those either.

I think my last root loss was over a month ago :good:
[Magisk] martyfender:
It was there last night but was removed today due to a new release. He only keeps a few days of older releases, so I have attached it here. Luckily, I downloaded it to my Linux desktop, last night.
[Magisk] topjohnwu:
The official release "should" be available tomorrow if no big issues.

Right now the Magisk Manager have some problems with backward compatibility, it's late here so I'll start working tomorrow morning

I'll polish the release for smooth upgrading transition, there is no need to publish snapshot builds now, as it might cause more issues for you to upgrade for the official release :)

Stay tuned for the wonderful upgrade!
[Magisk] stangri:
Can you have a look at the Magisk Manager issues and also accept requests for new repos?
[Magisk] rxk:
Installed v11.. safety net and pokemon go is working fine
[Magisk] naveenfre:
hello i get cts profile mismatch whether any module is available for active my headset moto g3 with RR 7.1.1 only cts false
[Magisk] Didgeridoohan:
You're still in the wrong place... The support thread is the place for these kind of questions: https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382

And your post is still missing a lot of information. We need details as to what you actually want, what you've tried, your setup and please provide a Magisk log (it's in the Manager). Go to the support thread with the above info and I'm sure you'll get some help.
[Magisk] acultr:
Hello!

I can't install moduls. I hope I'm not on wrong thred:)
[Magisk] crusader727:
WRONG THREAD - READ TITLE :rolleyes:
[Magisk] Captain_Throwback:
You are on the wrong thread.
[Magisk] acultr:
sorry,but can you please help me .?

what do you mean what's the problem?
[Magisk] Captain_Throwback:
Post in the correct thread...
[Magisk] acultr:
OK. thanks
[Magisk] nick491:
The new Magisk Manager 11.1 actually works with the root access! Keep up the excellent work.
[Magisk] yochananmarqos:
Who are you taking to? Wrong thread.
[Magisk] Deic:
[MENTION=2226076]stangri[/MENTION] Build more please.
[Magisk] Deic:
Lastest snapshots

I built lastest snapshots of Magisk & Magisk Manager.

↓↓↓Download↓↓↓
[Magisk] kartikb:
Hi, what's new in this version?
[Magisk] Deic:
A lot of fixes, su binary update, can only download modules without install it, tap a module shows readme.md of module's repo and many many more...
[Magisk] Deic:
Lastest MagiskManager snapshot + update Magisk snapshots from app

I built the lastest commits and modified to can update Magisk snapshots from app (I will make to can update MagiskManager snapshots from app too when I have got time).

Changelog:

-Update Spanish, German and Polish languages

-Several refinements
[Magisk] Deic:
Thanks

Thanks [MENTION=2226076]stangri[/MENTION] for keep this thread live to can test bleeding-edge features to this amazing app.

Do you may modify the app to can update Magisk versión from app?

Is easy, only need to modify https://github.com/topjohnwu/Magisk...om/topjohnwu/magisk/asyncs/CheckUpdates.java:

private static final String UPDATE_JSON = "https://raw.githubusercontent.com/stangri/MagiskFiles/master/magisk_update.json";

Here is a example of as works magisk_update.json:

{
"app": {
"version": "stub",
"versionCode": "10",
"link": "https://github.com/topjohnwu/MagiskManager/releases/download/v3.0/MagiskManager-stub.apk",
"changelog": " - Upgrade on Play Store!"
},
"magisk": {
"versionCode": "12",
"link": "https://github.com/stangri/MagiskFiles/raw/master/Magisk-v12-170217.zip",
"changelog": "Check the release notes",
"note": "https://xdaforums.com/showthread.php?t=3521901"
},
"uninstall": {
"filename": "Magisk-uninstaller-20170206.zip",
"link": "http://tiny.cc/latestuninstaller"
}
}

May use "note" to can download the apk when press on "Release Notes" to avoid agresive code modification or something? IDK xD

And modify your build script to can do this automatically.

Thanks for your work mate.
[Magisk] stangri:
Wow, man, that's fantastic news! I've implemented the changes you described into the build process and the new app (building now) should be checking my repo for updates and the json file in the repo is generated when the new build is posted!

Please test it for a few days and let me know. I'll need to further tweak the build script for conditions where either of Magisk or MagiskManager had new commits and not both, but if there were new commits for both Magisk and MagiskManager it should work well.
[Magisk] martyfender:
Maybe he is working toward a better solution. I'm not sure the magisk_debug.log I provided show any useful information?

I could run a logcat for hours until the problem occurs, but I am not sure of the best way to do that since when root is lost, even adb root is lost. Would modifying my boot.img's default.prop in Android Image Kitchen, with ro.adb.secure=0, ro.debuggable=1 and ro.secure=0 allow adb root access when root is lost, or not?

Thanks
[Magisk] kantjer:
Let's wait and see what happens and if further logs are needed. For me no root loss for over 48h now.

MM is still removed from battery optimization.
[Magisk] radz_:
MM takes almost 1 minute to open. It stuck in splash screen
[Magisk] bggold:
Having the same issue on today's build. Completely uninstalled and it did not help.

Thanks
[Magisk] kantjer:
If you checked the last 1-2 pages of this thread you would have know about this issue . We know exactly which commit causes this. In my 180621 build I disabled that particular commit to test that.
[Magisk] bggold:
Sorry didn't see anything about the delay on opening. I have a pixel 2 XL and have not experienced root loss of any kind.
[Magisk] guest4711:
Oh, in 180622 built the commit is enabled again? Now it's clear why I have to wait again... After deinstalling MM and reinstalling yesterdays version all is fine again.
[Magisk] martyfender:
I installed todays build on one of my devices to test a few hours ago. When I launch MM there is, unlike others reporting, only a very slight delay in the launch: I counted four seconds where as on one of my other tablets of the same hardware with build 180614, I count 2 seconds.

Root has not been lost yet but I expect it to eventually happen because last night I installed the [MENTION=7187684]ianmacd[/MENTION] build with the same commits and it took many hours before root eventually failed. I believe the only difference in his builds is that he includes the 64 bit binaries, also. Finally, as I did yesterday, I turned off battery optimization for MM.

Root never seem to fail when plugged in to the charger. It only fails after some time in doze mode and woken up. When woken up, root is there at first and within a few minutes it fails. I have tested this with several root apps such as adaway, kernel aduitor greenify, apps2sd and more.
[Magisk] ianmacd:
For the record, my builds have the commit that causes the MM start-up delay removed, as do [MENTION=3306843]kantjer[/MENTION]'s, I believe; unless he has reinstated it.
[Magisk] martyfender:
A page back he only mentions his 180621 build with it disabled, so I took it to mean it is in todays build 180622, however, I may be wrong about that. [MENTION=3306843]kantjer[/MENTION] may clarify this.
[Magisk] kantjer:
On Today's build the commit is back in. When I tested this morning MM opened within a few seconds so I left it in.

Now it's slow opening again. Will leave it out on the next build if the issue isn't fixed by then
[Magisk] martyfender:
I updated to 180622 a few hours ago and I only notice a very slight delay in launching MM (4-5 sec) vs. 2 second on a tablet of the same hardware with 180614.

I will report back later, after hours of use to see if the delay is increased for me, also.

Right now though, my primary concern is the root loss issue.

Recently, I have been bouncing back and forth with both your and [MENTION=7187684]ianmacd[/MENTION] 's builds and sometimes have long splash screen lockups when first launching the changed builders version of the MM. Sometimes, uninstall of that particular version of manager and reinstall fixes it. Other times a reboot seems to clear it up. And yes I do uninstall initially as I am aware they are signed with different keys.

I used to just be able to hide the MM in settings, install the other version and everything was ok. One of [MENTION=4470081]topjohnwu[/MENTION] 's recent commits change the behavior, so a complete uninstall appears to be necessary now for MM to go between different signed versions. I forget which commit it was, but reading it clarifies why hiding and installing the new version no longer works.

Here:

https://github.com/topjohnwu/MagiskManager/commit/e6c1dd532d2910285d503f271183839446495360

And also maybe here:

https://github.com/topjohnwu/MagiskManager/commit/a9496413425fe9e4e2a400a4cdc043591f6afb43
[Magisk] jenslody:
The intention is, that a hidden Manager survives an update, what is a good thing, because an update does not accidently "break" apps, that detect the Manage otherwise.

Unfortunately you can not switch between Managers, that have been signed with different keys any longer.
[Magisk] martyfender:
As expected, I finally lost root on the 180622 build. I did not notice any problem with a delay opening MM though, other than the ~4 sec launch time as I noted earlier.

Hopefully, [MENTION=4470081]topjohnwu[/MENTION] will fix the root loss issue in future commits. I must note that over the past few months he has added and removed invincible mode at least a couple of times.

His recent commit did not fix the root loss cause for some devices:

https://github.com/topjohnwu/Magisk/commit/44395e8ff0712e00003cff71a157c5fb3da63c1a

One thing I have not tried is disabling Magisk Hide in settings.

[MENTION=4470081]topjohnwu[/MENTION] Attached is a logcat and magisk_debug.log, saved before reboot.

UPDATE: [MENTION=4470081]topjohnwu[/MENTION] the magisk_debug.log I previously uploaded was a 0 byte file. Corrected now with one I had previously uploaded when root failed
[Magisk] dingolino:
My experience is that right after boot MM is starting as normal but after a while there is the "startup delay".

So testing right after booting would be missleading..

Best regards,

dingolino
[Magisk] Ubimo:
Since there are two "builders", which one is recommended? What's the difference or are both the same?

https://github.com/ianmacd/MagiskBuilds

https://github.com/kantjer/MagiskFiles

Edit:

There is sure a difference in file size in their latest build: :confused:

ianmacd: 5.8 MB

kantjer: 4.72 MB
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] builds include the 64 bit binaries that [MENTION=4470081]topjohnwu[/MENTION] removed recently from the builds.
[Magisk] ianmacd:
Perhaps I should make a separate thread for my builds, but then useful postings about the latest state of the code would get split over two threads, and I wanted to avoid that. The downside of that may have been adding to the confusion in this thread, in which case I apologise.

[MENTION=3306843]kantjer[/MENTION] and I now both include a commit change log in the MM app, so that will tell you — post-installation, admittedly — how bleeding edge the build is if intra-day granularity is required. If you want to know more than that, my GitHub repo is the authoritative source on exactly what's in my build.

[MENTION=8126387]martyfender[/MENTION] has it exactly right, though. My builds continue to include 64 bit binaries and that explains 99% of the difference in archive size between mine and [MENTION=3306843]kantjer[/MENTION]'s. The only reason I include these is that Magisk-patched kernels are otherwise misidentified by apps like DevCheck and Phone Info as being 32 bit. Actually, that may no longer be true in the case of DevCheck, because I reported the issue to the developer and he stated his intention to change the method of identifying the kernel architecture.
[Magisk] edzamber:
Hi all,

Here is temporary solution to make Working Titanium backup with latest [MENTION=3306843]kantjer[/MENTION] Magisk build...

- First flash this Magisk

https://www.mediafire.com/download/ys64cpumdbq1zg2

- Reboot and launch Titanium backup then accept root rights

- Flash latest [MENTION=3306843]kantjer[/MENTION] Magisk build

- Enjoy ;)
[Magisk] hshah:
What exactly is the issue with Titanium? It's working fine for me on [MENTION=3306843]kantjer[/MENTION]'s latest build.
[Magisk] edzamber:
Uninstall Titanium then re-install from Playstore, you will see that Titanium won't find su binary. Its Magisk img issue, not related to [MENTION=3306843]kantjer[/MENTION] build but with last [MENTION=4470081]topjohnwu[/MENTION] commits. I don't know why. This issue is here since 180620 build
[Magisk] monleylord:
Exactly the same behavior on ianmacd builds. In builds after 17.06 is quite impossible for titanium backup to receive root rights.

Another observation is that the apps receive root rights slower. To clarify this I have a lemax2 smartphone and i use also Xposed. Because Xposed slow down the hole system due JIT is quite easy to feel and see in real use how fast/slow the difference between the different Magisk versions is. The root rights process needs/takes almost 2x the time prior to the 17.06 build who everything seams to happens instantly.

further I don't have used/tested kantjer builds and root doesn't get lost as it happens to other devices.

Please correct me if I am wrong with my observations.

BTW! Many thanks both of you, kantjer and ianmacd for your efforts and everything you've already done and do here.
[Magisk] hshah:
Ahh, so it would be fine if it already had root? Explains why I'm not seeing any issues lol. Guess I won't be reinstalling it since it's fine for me :p
[Magisk] kantjer:
Test build with invincible mode back.
[Magisk] kantjer:
Seems you can't upload a zip and Pic in one post using the mobile app
[Magisk] martyfender:
I am downloading now and will report here if I have any issues. I assume you did not put it in the custom channel because it is a test version? So this has all of the commits of 180622 plus invincible mode back?

Thank You
[Magisk] kantjer:
Yep, also the commit resulting in the slow MM opening is reverted. That are the 2 things bothering me with current source.
[Magisk] ridobe:
I haven't had issues with losing root at all, but the slow MM opening is fine with the test version.
[Magisk] kantjer:
I had root loss last night, first time in 3/4 days, and it killed my scheduled nandroid.

I hate it when I don't have a recent nandroid.
[Magisk] martyfender:
I see you reverted the daemon, also. I did have to extract the MM from the zip and install it separately, as it did not install when I flashed the zip in twrp on one device and when I used the install modules mode to install it on a second device. However, that happens to me frequently,but not all of the time, so I am used to checking the manager version, also.

I will keep my other 2 tablets on 180614, until I confirm all is well with this build.

It looks like [MENTION=4470081]topjohnwu[/MENTION] may possibly be taking some much deserved time away from coding?

Thanks Again
[Magisk] guest4711:
Thanks, installed without problems on three different devices (with M, N and O). MagiskManager does not lag on startup anymore...
[Magisk] kantjer:
That deamon update I reverted is part of the "Remove invincible mode" commit.

Without revert that commit also the build is failing.
[Magisk] martyfender:
So far, I have no problems on my device, that I am aware of.
[Magisk] kantjer:
Same for me, no issues found.

I pushed the build to my update channel
[Magisk] DenyDarko:
Hey [MENTION=3306843]kantjer[/MENTION],

Don't take me wrong here but I though the whole purpose of this is getting nightly of an unmodified magisk.

For example, in my case, root and everything works fine plus I'm really confident about topjohnwu coding skills.

I've got an idea though, How about considering to create another tree with your modifications?
[Magisk] ianmacd:
An unmodified nightly Magisk build would be ideal, but if there are serious bugs that can easily be removed, wouldn't you rather have a functional modified version than a broken pristine version?

The developer's coding skills aren't really a factor. In a project of this complexity, bugs can and always will be an issue. This is particularly true when you consider that these are nightly snapshots that are being built, that the latest code has received little or no testing, and that the developer, in any case, has an extremely limited number of devices at his disposal on which to test.

With all of that said, my last build (which I think was 20180622) features every commit from the developer to date, except for f9ed888abc3516a43065e11e22144b012a092494 (Get device blocks with sysfs), which destroyed MM performance. There have been no more commits in the last few days.