yashsingh1/xdaforums huggingface dataset:
[Magisk] Deic:
Magisk Manager Snapshot Updater v3.1.0

changelog:

-fixed apk install loop in some devices

-disabled toasts temporaly

-code improvements

if you have got some bug or something strange occurs, please post "updater.log" file found in "/Magisk/magisk-manager-snapshot-updater/".

source code: https://github.com/DeicPro/magisk-manager-snapshot-updater
[Magisk] kartikb:
The notify4scripts app still doesn't work.. not sure what else I can do.. any suggestions?
[Magisk] ianmacd:
The problem is that XDA truncates URLs for display. If you copy and paste the link text instead of the link itself, you will get a truncated URL that doesn't work. That's why I put the original link between CODE tags, because that disables truncation.

If you look at the link text you just posted, you'll see three dots in it, even though the link itself is fine.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION], did you change your mind? I just got home from work and saw that you have released a new update. I have already switched some of my devices to the Canary channel and one device to [MENTION=7187684]ianmacd[/MENTION] build. I have liked your builds because I can see the changelog on the github page, even before I update it. I don't see a way to do that on [MENTION=7187684]ianmacd[/MENTION] page. However, both work well and I do prefer a user build vs. a debug build. If you plan to continue, I would like to switch back. I however, understand why you may not want to continue building.

Thanks
[Magisk] kantjer:
I really tried to take a break but the build error kept me busy.

The error was caused by the NDK, that I didn't understand because I was using John's FrankeNDK.

The error message was about NDK not supporting gcc 4.9 ?

Then I realized that Android Studio updated its NDK earlier to r18. Still strange because I used FrankeNDK for the Magisk build.

After checking my build script again I noticed I didn't use FrankeNDK for the clean command. That turned out to be causing the issue.

Now that is fixed, I decided to continue building. Everything is scripted, syncing source, building and releasing is all done by starting one command so why not continue.

I was missing building my own Magisk after one day already.
[Magisk] guest4711:
Great, thank you. :svetius::good::good:
[Magisk] radz_:
Great, welcome back..lol

Custom URL now back to kanjer's build...[emoji4]
[Magisk] Skittles9823:
Hahaha welcome back :highfive:
[Magisk] kantjer:
I'm still looking for a builders anonymous support group to help me with my build addiction :D
[Magisk] Skittles9823:
Hahaha I'm sure we could make a support group for you on Telegram :D
[Magisk] martyfender:
I posted this over in the Magisk Canary Development forum where the Google backup account is greyed out in settings, backup & reset, with both recent Canary and unofficial builds:

https://xdaforums.com/showpost.php?p=77702430&postcount=107

Only core only mode and not the removal of all modules fixes it.

Another user reported this issue also over in the sysconfig patcher module thread. I believe this may have started with the 17 and plus versions. I don't usually check, but I think this started happening several weeks ago. The only way to know for sure would be to revert to older builds.

Has anyone else here experienced this problem?

Thanks
[Magisk] hshah:
I managed to move back to yours again by just installing MM over the top and flashing Magisk through MM :)
[Magisk] hshah:
PMed you :)
[Magisk] Vuska:
hi..

using your MM and Magisk from your source...

but, today... with 2709 update... i cannot passed cts profile and integrity... (safety net failed)

any clue?

because my phone operator app and banking detected rooted.

Thank you
[Magisk] martyfender:
On my devices it passes the safety net check with both [MENTION=3306843]kantjer[/MENTION] and [MENTION=7187684]ianmacd[/MENTION] builds.

The only issue I have is the Google Backup account being greyed out in settings. This is solved by booting into core only mode.
[Magisk] Vuska:
Strange...

do you with Stable Pie OOS 9?

2 or 3 days ago, it passed
[Magisk] kantjer:
I moved to Pie today, safetynet still passes.
[Magisk] Vuska:
any clue?

can i have your custom repo for update in setting? wanna try.

thank you

update : found the source update.. will try it asap

update 2 : already change to magisk 17.3r3-unofficial, still not passed safety [emoji20]

didn't know what made it failed
[Magisk] hshah:
Have you tried hiding the MM and using modules like "MagiskHide Props Config"?

I'm running Oreo 8.0 on my Samsung Note 8 and am still a happy bunny :)
[Magisk] hshah:
Forgot to mention, I had had an issue after some tinkering (can't remember what I was doing) and Root Beer flagged up BusyBox. Had to clean the lingering files and used the BusyBox Magisk module instead.

May be worthwhile seeing what Root Beer shows:

https://play.google.com/store/apps/details?id=com.scottyab.rootbeer.sample
[Magisk] Vuska:
already hide the MM and also try using magisk hide props... still same.

I'm on Pie... and couples days ago still work..

i still try to remember.. what i always try install is... kernel.. try many kernel.. update app from playstore...

nothing else..

If not work.. will try to clean install and change from stable oos to oob or hydrogen maybe.
[Magisk] hshah:
Apologies, I didn't realise you were running Pie and going by your screenshot, I assumed you hadn't hidden MM (because I thought the SafetyNet check in MM didn't work if it was hidden)?

I'm going to shut up now because there is no way I could help you more than [MENTION=3306843]kantjer[/MENTION] :silly:
[Magisk] topjohnwu:
Your demands are realized! I added a release channel to official Canary Channel, please go and check it out!
[Magisk] WizP:
Just out of curiosity, I have ran root beer and advanced root checker. On both everything is OK apart from:

"root cloaking apps" detected.

Is this the same for everyone? Or is there a way to hide the cloaking apps which I'm guessing is Magisk being detected...

I thought this was being obfuscated now when hidden.
[Magisk] hshah:
You have hidden MM right?
[Magisk] martyfender:
Did you hide the root beer app in Magisk Hide? I get that if it is not hidden, but get "not rooted" if I hide the root beer app. I use that app to show me with each build that Magisk Hide is doing it's job, since I don't use any other apps that detect root, such as banking apps, game, etc., on my tablets. I only use banking apps on my Iphone or my Linux desktop computer.
[Magisk] WizP:
Yes, the Magisk app is hidden/obfuscated (and the root checking apps are set in Magisk hide) and those apps still detect a "root cloaking app"

It says its not rooted and I can Pass the safety net test, but one banking app detects a mod so I'm guessing it's found Magisk somewhere...

I've even deleted the old Magisk fold on the SD card as I've heard these apps search for it too!
[Magisk] Killua96:
According to Magisk changelog full obfuscation is not enabled at 100% and it won't until a stable release
[Magisk] jenslody:
Do you have xposed-installer on you system ?

MagiskManager is not detected on my system by rootbeer.
[Magisk] WizP:
Thank you. It was the exposed installer...

Never thought about that... All working now including my banking app. :)
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] As always, thanks for this new update, today.
[Magisk] radz_:
Is there a new build?

Waiting for [MENTION=3306843]kantjer[/MENTION] build..[emoji4]
[Magisk] martyfender:
There is a new Canary build and [MENTION=7187684]ianmacd[/MENTION] has released one, but [MENTION=3306843]kantjer[/MENTION] has not released one yet. My guess is that he may release one, as usual, late at night, or in his time zone, very early in the morning.

---------- Post added at 01:30 AM ---------- Previous post was at 01:13 AM ----------

OT, [MENTION=3306843]kantjer[/MENTION] but I see, in your profile, your interests are photography, computers and cycling.

Interesting, I was a professional photographer in the school picture industry for 26 years, here in the USA, I used to race bicycles, just started cycling again this summer, after 6 years away and, of course, have had a strong interest in computers since the early Mac OS 7 and Windows 95 days. If it wasn't for a corporate buyout I would still be in school pictures.

It is nice to see some parallels in another part of the world.

I am looking forward to a new build from you.

Thanks for your efforts.
[Magisk] kramer04:
I use ianmacd to update magisk

i see MM in download folder but where is the zip file ?
[Magisk] martyfender:
If you choose install, download zip only, it also downloads to your download folder. I believe the direct install downloads it to that folder, also.
[Magisk] hshah:
Yes, the MM apk, Magisk zip and zips for modules all go to the usual download folder :)
[Magisk] kramer04:
I choose direct install but if can see MM apk zip file is where ?

Because not in download folder
[Magisk] hshah:
I use the direct install option too and the files are available for me in the Download folder. topjohnwu released a new version of his canary build earlier and I used the direct option for that. Also had noticed there was an update to a module so installed that too.

See attached :)
[Magisk] kramer04:
Ok I see module and MM apk but not magisk zip
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] 's latest should be named: Magisk-v17.3-2018100401-ianmacd.zip.
[Magisk] martyfender:
Suddenly, today My 5 Nextbook Ares 8A's are not passing safetynet in MM, safetynet attest and Root Checker beta. Has Google changed it once again? Rootbeer Sample is hidden in mm and it shows the device as not rooted. For clarification, in MM I get the response is invalid, in the other apps it shows safetynet fails. For over a year, or more I have been on Google Play Services betas. Last night there was an update to v14.5.68 040700 x86. I'm not sure if that could have had anything to do with it or not. For months now all of my devices have been passing safetynet with Magisk installed.

Thanks
[Magisk] kantjer:
SN still passing for me for now at least.
[Magisk] Paschfire:
I'm noticing the latest versions of Google are now check thoroughly within Internal Storage for files/folders named Magisk. If you recently updated Magisk and/or still have Magisk .apk, .zip, folders...etc, starting with the name Magisk within your internal storage delete them and reboot.

Twice now in the last few days I've solve Safety-Net issues by deleting magisk.apk, magisk-uninstaller-xxxxxx.zip, a folder named Magisk and a magisk-install log.

I performed 2 reboots before deleting anything and Safety-Net failed, once everything with the name Magisk was deleted from storage Safety-Net passes without issues.
[Magisk] martyfender:
I do still have the MagiskManager folder left over from older versions of Magisk. Is this also true for Magisk files in the new location of the Download folder? I hate to delete those as they are backups of some recent versions, but I will if necessary.

Thanks
[Magisk] Paschfire:
Yes, you must delete them all. Or rename the packages, files, folders...etc, without having the word Magisk.
[Magisk] martyfender:
I deleted the MagiskManager folder and everything with Magisk in the name I could find on internal storage and I still get an invalid response in MM. In safetynet attest it fails also. I also tried after deleting data in MM. In the Play Store it still shows the device as certified. The only thing left are some modules without Magisk in the name such as busybox NDK, etc.

Thanks
[Magisk] Paschfire:
Did you reboot afterwards?
[Magisk] martyfender:
Yes, more than once. The only thing I can find left are modules without Magisk in the name, such as Busybox ndk and unsu.zip, etc.
[Magisk] Paschfire:
Have you tried disabling all modules and rebooting?

Might even try completely uninstalling Magisk and starting over with a fresh Magisk installation?

I also suggest you thoroughly read through the Magisk troubleshooting Wiki for other possible solutions.

https://www.didgeridoohan.com/magisk/HomePage
[Magisk] martyfender:
After about 24 hours, safety net tests in MM and the other 2 mentioned apps are now working. In the last hour or so, it did not pass. So apparently it was something on Googles end and maybe it was regional in nature. I am in the USA.

EDIT: 10 minutes later it is doing it again on multiple devices, strange. Maybe Google is testing.

I rebooted my cable modem and wireless router and all is good once again. This has all been very strange. I had rebooted my router yesterday, only. The internet connection was working for everything else I had tested it with: Firefox, Google Playstore, Adaway hosts file update, Mixplorer internal updater, etc. and Magisk Manager custom update channel.

Sorry for the posts in multiple threads. I was trying to cover all bases.
[Magisk] radz_:
[MENTION=3306843]kantjer[/MENTION] official 17.3 is out, waiting for your build..[emoji4][emoji4]
[Magisk] vandyman:
That's odd, I just installed version 17.4.
[Magisk] DougMG:
17.3 is beta channel and 17.4 is canary channel.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] [MENTION=7187684]ianmacd[/MENTION] The latest canary build is failing to repack the boot.img

https://xdaforums.com/showpost.php?p=77934210&postcount=139

This is just a word of warning, before you all build with the latest commits, that this has happened in my case.

Please let me know if you also have trouble with the latest commits. It could be an isolated case with my particular device. It is definitely not the kind of error I have ever experienced with Magisk before.

Thanks again.
[Magisk] 587.saboor:
Looks like all the release channels are having problems (not magisk 17.1 but magisk 17.3 stable that just released and the other release channels like canary and beta)
[Magisk] martyfender:
So you are experiencing the same problems as me, in failure to repack the boot.img?

Thanks
[Magisk] 587.saboor:
Ye
[Magisk] Kloosek:
Me too.

Wysłane z mojego LG-H850 przy użyciu Tapatalka
[Magisk] kantjer:
I will wait for a fix before uploading a new build
[Magisk] ianmacd:
bootimg.c has been fully replaced by a new version in C++. That should have obviously had some testing before release.
[Magisk] kantjer:
I have reverted "Properly support boot image header v1" for now and uploaded the build.

John is busy with his study so it could take some time before he is able to fix the issue.
[Magisk] hshah:
The colours look a bit off if the rest of the phone's UI is themed with substratum (not the MM though) :(
[Magisk] ianmacd:
I don't know what possessed John to push through a commit like that without first pushing it to the Canary channel for at least some exposure in the field. It seems that every official Magisk release is plagued by at least one serious bug.

Anyway, since the official 17.3 is only slightly modified from the last snapshot that I compiled, I'm not going to bother with a build that reverts the bad commit. I'll just wait until the problem is fixed upstream and compile a new release then.
[Magisk] Sam Nakamura:
https://github.com/topjohnwu/Magisk/releases/download/v17.3/Magisk-v17.3.zip

This worked for me where the version pushed via MM failed to update, or more specifically it just remained on 17.2... Now on this version of 17.3 it's all fine and working as expected on my 5t - someone posted this hint at the "general support" thread, just to let you know about it...

Good night!
[Magisk] Badger50:
Congrats Sam on the color change! Well done! Don't let all that power go to your head now! :laugh::silly::good:
[Magisk] Sam Nakamura:
Nope, no worries, I'm just a peace keeper! :angel:

I'm still not used to the color change myself and still miss my "green badge" in a way, getting used to represent "purple" definitely doesn't happen over night!

Let's make XDA even better together!

I'm out, have fun... :highfive:

Edit: out of thanks Bro, sorry!
[Magisk] hshah:
Something weird going on... I have OCD when it comes to checking SafetyNet and stuff like Root Beer. Since [MENTION=3306843]kantjer[/MENTION]'s update earlier I've been checking both periodically.

I even managed to watch the whole F1 race using the Sky Go app. However as of 30 mins mins ago, SafetyNet fails, Sky Go detects root, as does Root Beer etc.

I'm sure if I reboot it will be fine, but what could have happened after hours of it being perfect?
[Magisk] hshah:
All perfect after a reboot, so am guessing MagiskHide stopped for some reason. I'll try and get logs if it happens again.
[Magisk] ianmacd:
bootimg.cpp fixed

The problem with the initialisation of the boot image is fixed.

I have pushed a 2018102201 ianmacd release that I have verified working.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] I'm a little confused as the last build was 17.4.r2 and this new build is 17.4.r1. Could you please clarify?

Thanks
[Magisk] radz_:
Im about to post this..
[Magisk] kantjer:
I'm as confused as you are.

It's a newer build but somehow my build script decided to mess up the versioning :(
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=3306843]kantjer[/MENTION] With your latest build I am getting a reboot to bootloader mode:

Bootloader error code 06 warning:

Multiple crash events have been reported. Use the above menu to select the next boot option.

If the problem persists, please contact the technical assistance.

The device will power off in 5 minutes.

Reflashing my stock boot.image, followed by the last build fixes it.

Is this another C++ programming error?

I tried this multiple times, even tried direct install and I got the same result.
[Magisk] kantjer:
I also ended up with a boot loop.

I removed that build for now
[Magisk] martyfender:
Install log now attached. I wonder why you get a bootloop and I get a boot to bootloader mode, as if the boot.img is missing?

He migrated MagiskBoot to C++, also. The last problem was caused by the previous migration to C++.

No worries, there is always a learning curve when trying something new. I'm sure [MENTION=4470081]topjohnwu[/MENTION] will iron out the problems.

Thank You, [MENTION=4470081]topjohnwu[/MENTION] , [MENTION=3306843]kantjer[/MENTION] , [MENTION=7187684]ianmacd[/MENTION] and all other contributors for all of your great contributions.
[Magisk] Tornado15550:
Can anyone install modules from the internal storage or does magisk manager crash?
[Magisk] Ace42:
I haven't encountered any crashes with magisk (Ian's version). This is the only module installed from storage.
[Magisk] martyfender:
I have no problems on [MENTION=3306843]kantjer[/MENTION] , [MENTION=7187684]ianmacd[/MENTION] , or Canary builds in installing modules on internal storage.
[Magisk] guest4711:
No problems here with installing from internal storage. I granted storage permission to MagiskManager....
[Magisk] bggold:
Hey guys I have an issue with hiding magisk manger. I am running the latest build by kantjer on a pixel 3 xl.

An app updated that is detecting root and magisk hide does not work for this app.

I wanted to try with hiding magisk manager to see if that would work.

After I hide it I am loosing root. I tried to reflash the modified bootloader and still no root

Any help would be appreciated.

Thanks
[Magisk] Didgeridoohan:
It's a good idea to keep track of [MENTION=4470081]topjohnwu[/MENTION]'s Twitter. Then you'll get titbits of information like this:

https://twitter.com/topjohnwu/status/1055866544700473345
[Magisk] ianmacd:
A couple of minor new patches to the ianmacd builds.

The latest ianmacd build of Magisk, 2018102701, now allows selection of the ianmacd builds using their own separate update channel. The Custom channel is no longer needed for these builds.

As a bonus, the colour of the cards used by the dark theme have been further darkened to #ff222222. They may need to go darker still.
[Magisk] Eamo5:
Looks so much better with update dark mode and only simplifies installation even more with the new channel selection. Well done Ian!
[Magisk] hshah:
I had previously mentioned how horrible the new colours looked... much better now though :D
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] This is a great new feature you added. I just installed it and it is working great. I assume it has the changes only from your last build, plus the 2 new features you added?

I have often had trouble reading dark themes in the past, but I have to admit that this one is pretty forgiving on my 60 year old eyes which now require bifocals. Even [MENTION=4470081]topjohnwu[/MENTION] default one is pretty good compared to many. I do still prefer the white background with black text for readability.
[Magisk] BustedFly:
Thx for your Version. I Like the black in s7 edge
[Magisk] ianmacd:
That's correct, Marty. John didn't introduce any new changes yesterday, so the two from me in the change list are the only ones.

I wear varifocals myself. My eyesight was perfect until into my forties, but suddenly took a steep downward slide a few years ago.

Oddly enough, I find dark themes restful on my eyes. Any app that can be configured into AMOLED jet-blackness, I configure that way, but some definitely work better than others, particularly when the developer has taken the trouble to modify the accent and other colours in step with the dark background. The currently selected item in MM's navigation menu is displayed in dark theme mode with text that is so dark that it is illegible, but I'm not sure how to address that problem the best. The few things I tried out had far-reaching effects across the app.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I am getting a SafetyNet API error with your just released build. On my other devices where I have today's Canary build and [MENTION=3306843]kantjer[/MENTION]s latest they all pass as normal in MM. On the one device I have with your build SafetyNet Attest and the beta of Root Checker both pass with no problems. I see that the commit: [MENTION=4470081]topjohnwu[/MENTION] Upgrade snet extension.

I also tried deleting data in MM, re-granting storage permissions and re-downloading the code in MM and had the same result.

Is anyone else having this error?

Thanks for this new build, everything else appears to be ok, so far.
[Magisk] ianmacd:
[MENTION=8126387]martyfender[/MENTION]

I've figured out how to make the change described above and it's now integrated in my latest build, 2018102804 (01 to 03 were internal builds only).

If you go to the navigation drawer in dark mode, you'll find that both the icon and the text of the currently selected item are now no longer displayed black on a dark background, but in white instead. This renders them discernible/legible.

Since this seems a useful change for the wider Magisk community, I've put in a pull-request to [MENTION=4470081]topjohnwu[/MENTION] to integrate it upstream.

---------- Post added at 00:59 ---------- Previous post was at 00:27 ----------

Changes to SafetyNetHelper.java broke the local build script that dynamically patches in my SafetyNet API key, so the 04 build shipped without a key to send along with API calls. I will add a check to ensure that this cannot happen again.

I have just pushed a 05 build with the fix. Please confirm that it works for you.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] That fixed it but only after I again deleted cache and data in MM and regranted storage permissions, then it re-downloaded the code again.

Also, the 05 does not show up in your update channel in MM, so Went to your github repository and found it there. I know you probably just haven't had the time to change it yet.

Thanks Again
[Magisk] Dark_Diver:
[MENTION=7187684]ianmacd[/MENTION]

v17.4-2018102804 and v17.4-2018102805 don't install on Xiaomi RedMi Note 3 Pro (kenzo): "Updater process ended with signal: 11"

TWRP: 3.2.2.0, ROM: MIUI 10 Developer Weekly 8-10-25

Earlier builds do.
[Magisk] ianmacd:
It should have been automatically updated and pushed, but for some reason that didn't happen this time. It's fixed now.
[Magisk] martyfender:
I believe that also happened with the changelog?