yashsingh1/xdaforums huggingface dataset:
[Magisk] ianmacd:
Hi Marty,

The latest upstream merge sees a lot of Viktor De Pasquale's work on the new UI design integrated into the master branch. This involves replacing a lot of the Java code with its Kotlin equivalent, presumably refactoring and otherwise improving it in the process.

The problem for me is that, whilst the code builds fine, MM crashes as soon as it leaves the splash screen, and reading the stack trace hasn't got me very far. On top of that, it's entirely possible that the HEAD of that branch is currently known to be in a broken state, in which case any time I might spend on it, trying to get it to work, would be futile. Since there's no other unofficial builder to ask 'Does it work for you?', I've been sitting it out, waiting for new commits; but those have been slow coming, making me think that the current state of the code is probably supposed to yield a working result.

The answers to these questions could be given by John in the twinkling of an eye, of course, but he's so busy at the moment that I didn't want to bother him with anything non-urgent.
[Magisk] Tornado15550:
Does hiding Magisk Manager cause Magisk to not be detected by the re-packaged Manager?

On a fresh Magisk install, hiding Manager states Magisk is not installed, but removing the re-packaged Manager and installing the regular Magisk Manager allows it to detect Magisk again. This is on the latest 19.3-2019053015 build.
[Magisk] jenslody:
Check if repackaged Manager is in rxternal/adoptable storage or if two Managers are in app drawer after repackaging.

If that's not the csase:

more info needed (device, OS ...),

and logs, logs, logs, ...
[Magisk] Tornado15550:
The re-packaged app does show up but it cannot detect the magisk process. Hope that makes sense.

Steps to reproduce:

1) Completely uninstall magisk along with any/all modules.

2) Install latest 19.3-2019053015 Magisk build through TWRP. The regular Magisk Manager appears and Magisk works as intended.

3) Re-package Magisk Manager

4) Manager re-packages successfully

5) Open the re-packaged Manager.

Expected Behavior: Magisk should be detected by the re-packaged Manager and function normally.

Actual Behavior: Re-packaged Manager states Magisk is no longer installed.

Re-installing the non-repackaged Manager detects Magisk once again and works normally.

OS: Android Q Beta 3

Device: Pixel 2 XL

Architecture: arm64

Logs: attached in the post.

Two screenshots have also been included which showcase:

1) Magisk working normally when not re-packaged.

2) Magisk no longer being detected by the re-packaged Manager.

Hope this helps.
[Magisk] Didgeridoohan:
[MENTION=5554234]Tornado15550[/MENTION] That can't be the full Magisk log, right? Could be useful to see the full log if there's anything else going on...

Do you experience the same with the official Canary or the stable release?
[Magisk] hshah:
Just noticed this with the latest update. Bug?
[Magisk] ianmacd:
There are probably a lot of exotic new bugs in 2019053015, because a huge amount of new code was merged into the master branch. Large parts of MM have been rewritten in Kotlin, which required me to hack my ianmacd channel back into the code. Then there was a bug related to JSON parsing, and finally I needed to add some code to get updates to download. Viktor De Pasquale helped me with that one.

So, the HEAD of master doesn't even work properly right now, and my 2019053015 build is a fixed version of that; and, incidentally, has already been superseded by 2019053101. So, expect many more bugs then usual, because a lot of code has changed.
[Magisk] hshah:
On the scale of things, it's minor. As long as Magisk works I couldn't care less lol :)
[Magisk] Tornado15550:
Are you able to hide and unhide Magisk Manager and have it work properly? If so, then it's clearly an issue on my end.

Also, yes that's the entire log created during the hiding procedure.
[Magisk] martyfender:
Could the issues possibly be related to this in Android Q?

https://www.xda-developers.com/android-q-storage-access-framework-scoped-storage/
[Magisk] Tornado15550:
Are you able to unhide and hide with no issues on your end?
[Magisk] martyfender:
No I thought so, but I was wrong, all of my 5 devices are on Android M, 6.0.1. My devices are in my signature. I only have one of my devices where I have MM hidden. I only hide it for testing purposes only, I do not need it.

I just tested restore and rehide and you are correct, when I rehide it, it shows Magisk as not installed. So maybe this is a bug in the recent builds, as I have never had this problem before, when I have done this before, recently. Reflashing Magisk in TWRP did not solved it though.

This is weird, upon reboot, the hidden MM, Manager, requested root access, which I granted, I have never seen this before, ever. I also tried the patched boot.img method that also fail with Magisk not installed. So I screwed up a perfectly working device testing this. I have no problems though, this is why I test Unofficial and Canary versions, to find bugs and it appears we have found a major one. My guess is that the Magisk uninstaller needs to be run to solve this? Fortunately, I did not have to do that. Even that is no big deal as all that one looses besides some settings is your modules, which can easily be restored.

Even though it states Magisk is not installed, apparently root is granted as I was able to use Simple reboot to reboot in recovery, an app that requires root access to work properly. I uninstalled repackaged MM first though. So upon reflashing Magisk in twrp, the unhidden MM was restored, with no Magisk is not installed message. I am really hesitant now to rehide it again with this apparently broken version. hmm, should I do it? I did try to hide it and of course, I get the Magisk is not installed message once again. I have tested and several root apps still have root access, though.

I will try flashing [MENTION=7187684]ianmacd[/MENTION] some versions back and report.

I think [MENTION=7187684]ianmacd[/MENTION] is correct, there may be many bugs in these recent versions.

I just tested 2019052801 and I had no problems hiding and unhiding MM.

I would suggest sticking with this version until the issues are resolved.

My other 2 devices with [MENTION=7187684]ianmacd[/MENTION] builds, where MM is not hidden, have no known issues with the newer versions released in the last two days.

Thanks, [MENTION=7187684]ianmacd[/MENTION] and [MENTION=5554234] [MENTION=5554234]Tornado15550[/MENTION] for making this issue be known to all of us.

This bug only surfaced for me when I unhide and rehide Magisk Manger on the recent version. it was working perfectly on today's version before doing the above. So in theory reflashing today's version it should remain working, but I will now wait, I have had enough drama for tonight and have to work again tomorrow, or today in reality, since it is almost 2AM here. Good night (or morning.)
[Magisk] Didgeridoohan:
Yes I can hide the Manager properly, but I don't use the unofficial snapshots. That's why I wanted to know if you see the same on the official releases... But, it seems like [MENTION=8126387]martyfender[/MENTION] might have confirmed it's in the current code but but but yet officially released. Would need more confirmation though (and logs).
[Magisk] hshah:
Anyone else also getting update notifications when there aren't any updates?
[Magisk] geko37:
Same here on s9.

Gesendet von meinem SM-G960F mit Tapatalk
[Magisk] ianmacd:
Marty, have you filed an issue about this on GitHub? [MENTION=9815783]diareuse[/MENTION] needs to know about bugs like this or they won't get fixed in a timely fashion. Viktor's very responsive once he's aware of the bug.

I don't hide Magisk, so hide-related bugs are never going to turn up during my minimal testing..
[Magisk] diareuse:
You're correct. Once it's properly filed on GitHub (preferably here if you're certain it's app error) it will be fixed asap.

If it's a crash it needs a step by step replication scenario and a logcat. If neither of those are provided then I'm unable to fix the bug.

If it's a visual bug it needs a screenshot, dpi settings (developer settings) and device display settings screenshot if applicable.

You can propose enhancements and discuss on them as well, these are not prioritized and might not be taken in regard.

If you encounter the same bug and have no additional insight mark the initial bug report with +1 (thumb up) emoji so I know that there's a pressure on that particular issue.

This will make things smoother and I'll appreciate all input of yours :)
[Magisk] Tornado15550:
Thanks for this! :) I've filed an issue. You may find it here.
[Magisk] martyfender:
I also posted logs under your issue and found one other that shows up at the end of the magisk.log: global namespace is not being set, it sets inherit. the magisk.log shows: sqlite3_exec: table settings has no column named mnt_ns.

This appears on the 3 Nextbook Ares 8A, Intel x86, Android 6.0.1 devices that I have [MENTION=7187684]ianmacd[/MENTION] builds on, only one of which I have the manager hidden.

On one of the devices with today's latest build, I uninstalled MM and installed the MM from 2019052801 and global namespace is being set as normal. It was recommended some time ago to set this by the author of Apps2SD if using Magisk. Apps2Sd is used to move apps to a second ext partition on the external SD card.

UPDATE: The latest Canary update, of course, has the same issues as above. I didn't try the hide MM because I don't need it, as stated before, but since it is based on the same code, I assume it is still there, also, I could be wrong. Yes it is, I broke down and tested.
[Magisk] martyfender:
The Magisk not installed error in the hidden Magisk Manager and the mount namespace setting not being set properly has been solved, but a new issue has emerged. After 2 devices were in doze for some time, upon awake and launching MM nothing was showing up in the downloads. I cleared the repo cache and it does not show the already installed modules in the downloads section. in fact, at first, before refresh, it showed no modules installed. They did show up in the modules tab, though. Eventually I did get them to show up on both devices, but I don't remember exactly how I did it. Maybe it was clearing the repo cache again then swiping down again, but not sure.

Is anyone else experiencing this?

Thanks
[Magisk] joluke:
Yep I am on Note 8 SM-N950F with latest build
[Magisk] hshah:
Yep, also on Note 8 N950F and have seen the same behaviour :svetius:
[Magisk] martyfender:
I believe the previously mentioned issue may be fixed in today's build.

Thanks
[Magisk] joluke:
Not for me. Same issue ocours today after updating and rebooting
[Magisk] hshah:
Same here. Flashed the update and rebooted earlier and noticed the attached. Rebooted again a little while later and everything is appearing as expected for now.
[Magisk] martyfender:
Earlier today I updated the 3 tablets that I have this build on. When I got home from work tonight I woke one of them up to see an Android notification that there was a Magisk update available, with a current time of 10:36 PM. [MENTION=4470081]topjohnwu[/MENTION] released a couple of commits that didn't make it in today's earlier [MENTION=7187684]ianmacd[/MENTION] build, so I thought that Ian had updated it again. But no, when checking, there was in reality no update. So it looks like there are still bugs in the current build of MM. Is there still? Has anyone else seen this kind of behavior?

Thanks
[Magisk] Deic:
Magisk Manager Snapshot Updater v3.2.1

Changelog:

-Added modified notification app to have got the same icon as Magisk Manager

-Added retry download if fail

-Added modify version file after of install new version of Magisk Manager in x86_64 SoCs

I think the module is very stable now and I must try to refactor and optimize the code... If somebody is a pro in shell and can help me I would be very grateful :).

If you have got some bug or something strange occurs, please post "updater.log" file found in "/data/magisk/magisk-manager-snapshot-updater/".

Source code: https://github.com/DeicPro/magisk-manager-snapshot-updater
[Magisk] JEANRIVERA:
I have installed the module but I don't know how to use it, is there a command or an app I need to open to perform the update script?
[Magisk] Deic:
You don't need do nothing. When an update is available a notification appears in notification bar.
[Magisk] lancespahr:
Is there any fix for losing root? It works for maybe 30 minutes to an hour after flashing then says function greatly limited and no SU :/
[Magisk] ahrion:
I'm pretty decent given my Audio Modification Library and creating a unified magisk/system installer update-binary. I also fixed pixel devices and vendor mounting scripts.

Honestly, you should add the notify apks as a separate module so other modules can take advantage of the whole automatic updater thing. I know I could use this for my Dolby Atmos and the mods I will be releasing soon.

3.2.1 and 3.2 don't install via magisk manager.
[Magisk] ahrion:
Forgot to add screen.
[Magisk] biggdevon:
I'm running that latest snapshot with updater module v3.1.1. Didn't get a notification of newer and getting installation errors even attempting to flash updated modules. I also don't have the specified folder listed so no updater log to post. SM-N920T.
[Magisk] oakley470:
Disable magiskhide
[Magisk] lancespahr:
How? I can't get SU to work, so no magiskhide toggle. Tried reflashing and still no
[Magisk] Artim_96:
Then you'll have to start from scratch.

Happening for me too every nite and then but after several reinstalls it can be be fixed by a simple reboot

---------- Post added at 06:52 PM ---------- Previous post was at 06:50 PM ----------

@Deic your latest module can't be installed. TWRP logs are attached
[Magisk] oakley470:
Run the uninstaller, then reinstall it and your modules, don't ever enable hide. This happens to me every time, reboot doesn't bring it back usually only sometimes. The only way to get it back for sure is to do the uninstaller first
[Magisk] Deic:
Magisk Manager Snapshot Updater v3.2.2

Changelog:

-Added download if Wi-Fi is connected only.

-Fixed module install from Magisk Manager

If you have got some bug or something strange occurs, please post "updater.log" file found in "/data/magisk/magisk-manager-snapshot-updater/".

Source code: https://github.com/DeicPro/magisk-manager-snapshot-updater
[Magisk] android_htc:
Thanks for the update.

Snapshot updater is stuck on checking for module updates.. is this due to WiFi download only?

I would prefer the download to be not restricted.
[Magisk] Deic:
Yeah.. sorry for the inconvenience. I will add a script called "mmsu" and running "mmsu wifi_only 0" from terminal can disable that restriction and saving it to no need to re-do every update for example, but I will keep restricted by default, because most of the people don't want waste valuable data.

Thanks for the feedback bro.

PS: [MENTION=3715141]android_htc[/MENTION] you've not got the modified notification app (now has got Magisk icon in notification).. For some reason it did not got installed in your device, I guess because "pm" command ("pm uninstall" in this situation) not works in some devices (for security reasons I guess, in MIUI and CM/AOSP there isn't this restriction or can be a change in Marshmallow/Nougat, IDK, I check "pm" command under Lollipop versions only). Is needed uninstall previous version of that app because different signature... I will replace "pm" command with a simple "rm" or gui uninstall to remove the previous app and it must to be fixed.
[Magisk] android_htc:
I did not get a prompt to install the app after installing the latest module. Hence, I installed a previous version that I had. I also found your new version with the Magisk icon and installed it manually. But, it shows the old icon in the notification panel.. is this okay?
[Magisk] kantjer:
[MENTION=4476591]Deic[/MENTION] I have been playing with you snapshop updater module and found something weird.

Using the module it never installed "com.hal9k.notify4scripts.apk" and no module and app check at boot (I was on WiFi during this test)

log file only showed prop content and Module version, no errors

I then removed the "no download if no wifi connection" commit and I then had "com.hal9k.notify4scripts.apk" installed at boot, only problem the apk was installed after every boot.

Now both module and apk version where checked at boot.

Strange thing is that in this case the log now showed no internet (log below)

ro.build.id=NOF27C
ro.build.display.id=NOF27C
ro.build.version.incremental=eng.kantje.20170317.104531
ro.build.version.sdk=25
ro.build.version.preview_sdk=0
ro.build.version.codename=REL
ro.build.version.all_codenames=REL
ro.build.version.release=7.1.1
ro.build.version.security_patch=2017-03-05
ro.build.version.base_os=
ro.build.date=Fri Mar 17 10:45:31 CET 2017
ro.build.date.utc=1489743931
ro.build.type=userdebug
ro.build.user=kantjer
ro.build.host=Phoenix
ro.build.tags=test-keys
ro.build.flavor=angler-userdebug
# ro.build.product is obsolete; use ro.product.device
ro.build.product=angler
ro.build.description=angler-user 7.1.1 N4F26T 3687331 release-keys
ro.build.fingerprint=google/angler/angler:7.1.1/N4F26T/3687331:user/release-keys
ro.build.characteristics=nosdcard
ro.build.selinux=1
ro.product.model=Nexus 6P
ro.product.brand=google
ro.product.name=angler
ro.product.device=angler
ro.product.board=angler
# ro.product.cpu.abi and ro.product.cpu.abi2 are obsolete,
# use ro.product.cpu.abilist instead.
ro.product.cpu.abi=arm64-v8a
ro.product.cpu.abilist=arm64-v8a,armeabi-v7a,armeabi
ro.product.cpu.abilist32=armeabi-v7a,armeabi
ro.product.cpu.abilist64=arm64-v8a
ro.product.manufacturer=Huawei
ro.product.locale=en-US
# ro.build.product is obsolete; use ro.product.device
ro.board.platform=msm8994

MODULE VERSION: 3.2.3

Success
No internet connection or server is down:
https://github.com/DeicPro/magisk-manager-snapshot-updater/raw/bin/com.hal9k.notify4scripts.apk
Starting: Intent { dat=file:/sdcard/MagiskManager/com.hal9k.notify4scripts.apk }
[Magisk] Deic:
[MENTION=3715141]android_htc[/MENTION] try clean install of the app and reboot

[MENTION=3306843]kantjer[/MENTION] only module version? not magisk manager version?

The no internet connection is normal when boot... it means that failed one time... is fine.
[Magisk] biggdevon:
I have the same situation as mentioned above. What app should I attempt to clean install?
[Magisk] Deic:
here:

https://github.com/DeicPro/magisk-manager-snapshot-updater/raw/bin/com.hal9k.notify4scripts.apk

or simply uninstall current notify app and reboot to install it..
[Magisk] kantjer:
Not sure I fully understand the question.

I removed notify4script and installed the module.

With the Wi-Fi is connected commit in the only thing working for me is the Magisk check/update. The rest, Magisk manager/Module and notify4script, are not being checked or updated/installed.

With the commit removed everything is working Magisk/Magisk manager/Module and notify4script.

Only issue with the commit removed is that after every reboot notify4script is removed and offered to be installed again.
[Magisk] martyfender:
I think the issues may be fixed with today's build. Also, the su menu is once again showing up in alphabetical order. I will report later if I find out otherwise.

[MENTION=4470081]topjohnwu[/MENTION]

Update: I just got home from work and on one of the tablet I leave at home, in a deep sleep state, I woke it to find that it shows no modules installed in the downloads section, until I clear the repo cache, then swipe down on the downloads page.

I tried on a second device on today's build and had the same result. I tried also on my third tablet and the result was the same.

Thank You

[MENTION=4470081]topjohnwu[/MENTION] for your improvements from day to day on these builds and [MENTION=7187684]ianmacd[/MENTION] or releasing them for all of us to test.
[Magisk] hshah:
I've not experienced the modules/downloads issue for a few days now so I guess that has been sorted.

However, I do have to force close the app every now and then because opening it just results in a black screen (screenshot example attached).
[Magisk] martyfender:
I'm still experiencing the problems with modules/downloads in the latest build.
[Magisk] jcmm11:
Try clearing data for the app and see if that helps (total guess, no real reason for this advice)
[Magisk] bggold:
I found that clearing the repo cache resolves it only while you are in mm. If you go back into it you have to do it again.
[Magisk] asanford:
Just adding in I tried both repo cache clearing and clearing data for app, and both only worked until app closed and opened again.
[Magisk] rp4k:
Thanks [MENTION=7187684]ianmacd[/MENTION]
[Magisk] martyfender:
Even with today's second build, I am still having issues in the downloads tab, where it shows no module installed or just shows mods randomly that are not installed. Clearing the repo cache sometimes fixes this, but not consistently.

I'm not even sure even how to log this, as nothing that I can see in the magisk.log shows this, or the per app logcat for MM, in LogcatX, shows anything about this. Therefore I have not reported it in the github issue area.
[Magisk] rp4k:
Do you want to know why ianmacd never responses to these type of complaints. It is because the user did not firstly let the rom rest. After you install and reboot let the phone rest for 20-30 minutes then after that reboot one more time . I always do this on every update from [MENTION=7187684]ianmacd[/MENTION] and I have never had these issues on my s10+ international version.
[Magisk] Didgeridoohan:
I honestly do not think that was any kind of complaint. Merely an observation of what seems to be a bug that some users are experiencing...
[Magisk] martyfender:
Yes, you are correct, it is merely an observation of a bug on my 5 devices on both unofficial and Canary builds. And believe me, I have been through many bugs that were much worse than this one.

One thought is to remove MM from battery optimization, but I have never had to do this before. I just tried that and the problem still exists.

Once again, reverting to MM 2019052801-ianmacd, only, solves the issue. In the case of Canary, reverting to MM 214 solves it.

This bug has been reported here:

https://github.com/topjohnwu/Magisk/issues/1591
[Magisk] martyfender:
The previously mentioned bug appears to be fixed with todays build.

Thanks, [MENTION=4470081]topjohnwu[/MENTION] [MENTION=7187684]ianmacd[/MENTION] [MENTION=9815783]diareuse[/MENTION]

Several user have mentioned that MM crashes when accessing the superuser menu. However, I have not experienced that on my devices with several days of use on both unofficial and Canary builds.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I just realize that you have updated your build. I missed it for several hours because it is not yet in [MENTION=4470081]topjohnwu[/MENTION] 's master build.

I just updated 3 devices and in all cases, after I updated MM, downloaded the magisk.zip and chose reboot to recovery with Simple Reboot, root access to that app was denied. I had to open MM and go to the superuser tab and toggle the slider to allow that app superuser access again. Then I relaunched Simple Reboot and rebooted to TWRP recovery, like normal.

Other than that weird issue, this build seems to work normally after it is installed in TWRP.

Thanks, as usual, for your builds, Ian.
[Magisk] ianmacd:
Magisk development has slowed somewhat since John started at Apple, so I thought I'd pull in a trio of Victor's commits from the fix-superuser branch in anticipation of John merging them in the near future.

You're welcome, Marty.
[Magisk] zgfg:
I can test this fix for the crash with Superuser menu, I have this random crash both with v7.3.1 222 official and 223 Canary on my Huawei P9 Oreo

Where can I download this pre-release Magisk Manager?