yashsingh1/xdaforums huggingface dataset:
[Magisk] LPW00:
The new build doesn't work
[Magisk] Xephyrex:
That's what I was thinking, what with the "fake enforcing" feature it should've worked. In this case though, with me being in Permissive, Magisk fails to hide it for some reason. :(

---------- Post added at 06:38 PM ---------- Previous post was at 06:36 PM ----------

umm, there's your answer....
[Magisk] HamsterHam:
Anyone using the magisk app updater module get a notification to install the official app today?
[Magisk] Deic:
for some reason when stangri build the magisk.zip, it was not built with lastest commit, please be patient. And sorry for the problems... many things have changed in Magisk and were a problem to build snapshots... but the great topjohnwu did a fantastic job to fix those problems :)
[Magisk] jsaxon2:
For those that can't wait for latest build. Here it is. Sync'd and built about 20 minutes ago.

Removed link since OP version is working...
[Magisk] ianmacd:
The delay is just 1000ms (1 second), so it shouldn't take "much longer" on any device and should fix problems on some.
[Magisk] habylab:
Well, it's a lot slower for me. It seems to bug out completely, my modules don't appear and no downloads show at all (installed or otherwise). I have to close the app to fix it, or restart.
[Magisk] ianmacd:
OK, then be sure to report the issue upstream. It sounds as if your issue may be caused by something other than the delay that John introduced.
[Magisk] habylab:
Clean flash, seems to be fine now.
[Magisk] guest4711:
Actual build by [MENTION=7187684]ianmacd[/MENTION] (20190210) booted ok on my S4 i9505, no bootloop as reported in the canary thread. Thanks for the new build (which tries avoiding bootloops on non system-as-root-devices according to changelog). :good:
[Magisk] martyfender:
If you have TWRP for your device, try flashing the Magisk.zip with it. You may need to flash a stock boot.img before you do this though. I don't have a Samsung device but I have had the same issue when trying to use the direct install method in the past. That is why I always use TWRP to flash it now.

When this happened in the past, I rebooted to TWRP, flashed by stock boot.img, immediately followed by the newest, unofficial Magisk.zip, all before rebooting.
[Magisk] ianmacd:
I went through a few internal builds this weekend, but didn't release any of them, because of the boot loop issue.

I reported this to John, but before he saw my message he put out a canary release that contained the bug and suddenly half the rooted world was failing to boot, so a fix wasn't far behind at that point.

This is an example of the cursory testing that I do before a release actually yielding a useful result. When my own devices failed to boot, I sat on the code until a fix was forthcoming.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION]

Are you having trouble with current commits In testing internal builds? There are some dramatic changes there.

Thanks

I just updated my other 2 devices with the Canary build 18105 and so far I have had no issues
[Magisk] ianmacd:
Yes, there are some radical changes going into the code base at the moment.

Monday saw [MENTION=4470081]topjohnwu[/MENTION] add some commits that caused Magisk to eat my entire set of modules on my main device, so I had to reinstall and configure the lot. Reading the commits, I had expected the compatibility layer to take care of module migration to the new paradigm, but it didn't.

Needless to say, I decided to spare the world that build.

Today, some commits have been entered that look as if they would fix yesterday's issue, as they explicitly address Magisk image migration, so I've just produced a new test build and installed that, only to find that this causes a boot loop on my main device. Restoring to my last working version (2019021102) reveals that Magisk has once again gobbled up all of my modules. Grr.

So, I'll keep working on it and hopefully find the cause of the issue, but more likely is that John will find it first.

In the meantime, you're welcome to pull the latest build from my testing branch and try it out, but I obviously don't recommend it. Any build in that branch that is not also found in the master branch is either fresh out of the oven and currently being tested, or I have rejected it after testing as hazardous. If the latest Canary has these commits and is working for you, however, it's entirely possible that my latest (2019021301) would work for you, too, but it definitely isn't booting on Samsung devices.
[Magisk] habylab:
The latest Canary worked fine for me, maybe something since you tried building?
[Magisk] ianmacd:
Looking at the latest Canary, I see it has 2 commits fewer than my latest (2019021301, which causes a boot loop and eats modules) and 12 commits more than my previous (2019021201, which boots, but eats modules).

I'll now produce a build with exactly the same commits as the latest canary and see what that does. Either way, I'm getting my modules eaten, I suspect. It's just a question of whether it boots.

UPDATE:

Even after removing those most recent two commits, my S9+ still won't boot, so there are at least a couple of issues with code added in the last 48 hours on Samsung devices.

[MENTION=4470081]topjohnwu[/MENTION]
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I just updated to testing 2019021301 and all appears to be working fine for me, so far.

All of my modules are there and the only app I have hidden, RootBeer Sample, shows that hiding is working by indicating the device as not rooted.
[Magisk] ianmacd:
Yeah, see?

I've compiled a couple of builds since then. There's a 2019021303 that is bang up to date, which will probably run fine for you, but caused me a major headache this afternoon. I can't in good conscience move this to the master branch until it at least boots for me. Snapshot releases are inherently dangerous, of course, but I don't want to knowingly trash anyone else's device.
[Magisk] martyfender:
I thought in 2019021303 that you removed some commits?
[Magisk] ianmacd:
No, that was in 02, but it didn't help in my case, so I removed it. Anyone else who wanted to run the latest of the latest would have been better off with 01.

03 has everything that 01 had, plus a few new commits that have appeared in the meantime.
[Magisk] Tornado15550:
I can also confirm that the latest testing build 2019021303 works perfectly on my end. I installed magisk first, then uninstalled the existing manager and installed the updated testing build APK. Magisk Hide also works perfectly.
[Magisk] martyfender:
Works well for me too.
[Magisk] hshah:
Fine for me on Note 8 running DeluxeROM Pie v11.1 :good:

/Edit: Sorry, forgot to mention that Hide works fine and I didn't need to do anything special to install this (installed a Hidden MM via the Custom Update URL and then flashed Magisk via the updated app) :)
[Magisk] neekless:
[MENTION=7187684]ianmacd[/MENTION] 2019021303 has merged up to which commit?
[Magisk] Tornado15550:
Everything up to and including commit c66cabd80f8f8e556223154d63091359aefbdd15 - "Several MagiskHide improvements" has been merged in 2019021303.
[Magisk] ianmacd:
Interesting that you have this working on a Note 8, although you're on Pie with a custom ROM, which takes your Samsung some distance from my own two devices, which are both basically stock Oreo. I'll continue to try to troubleshoot this.

If any other S9 user still on Oreo could try the latest test build and confirm it working or failing to boot, that would be a big help in determining whether there's something in Magisk or something in my own particular set-up causing this issue.
[Magisk] hshah:
I only switched to Pie a few days ago and haven't faced any issues with Magisk. In fact, I've not even seen SafetyNet fail after a while like I regularly saw on Oreo, although that was occurring less frequently following the commits over the last week or so.

However, just updated to your latest test build and SafetyNet fails immediately after booting up. Strangely Hide had turned itself off, but even after turning it back on or after toggling Hide, SafetyNet is still failing :(

/Edit: Rebooted a few times and Hide turns itself off every time. SafetyNet is still failing regardless of what I do. Going to revert back :good:
[Magisk] jenslody:
In latest commits there are massive changes to MagiskHide and it does not work with system apps.

John works on it.
[Magisk] habylab:
Is this based on what arter has been working on? He's been tweeting about how he rewrote it.
[Magisk] ianmacd:
Well, this spurred me on to perform another round of testing and now I'm much closer to the cause.

I discovered that newer Magisk builds will still boot for me in core-only mode, after which began a process of elimination that ultimately revealed Xposed Framework (SDK 26) to be the fly in my ointment. With this module turned off, I can boot. As soon as I turn it back on, a loop occurs during boot. logcat messages didn't immediately point in this direction, which is why I've been slow to localise the cause.

I am not yet able to determine which change in the last few days causes this upheaval. It was running absolutely fine for me on all of my builds up to and including 2019021102. Perhaps if I tag [MENTION=4470081]topjohnwu[/MENTION], he'll have a lightbulb moment and know exactly what is breaking and why.

Given that the cause of the boot failure has now been isolated to a single module, I'm more comfortable moving this build to the master branch. Anyone who requires a working Xposed should stay on 2019021102 for the time being.

UPDATE:

John had pushed a couple more commits while I was testing, so the latest build is 2019021402 as of this writing and works for me as long as the Xposed module is disabled.

UPDATE 2:

Github issue #1080 opened.
[Magisk] jenslody:
Yes.
[Magisk] hshah:
Seems to be all good now :good:
[Magisk] guest4711:
No problems here on my old Sammies (S4, S4 active, Tab2). Thanks for the build.
[Magisk] :
Magisk Hide not work for me and not safety pass. Error reinstall module Magisk Hide And after lost root.
[Magisk] :
deleted
[Magisk] habylab:
Ah, so he's merging his work? Interesting!
[Magisk] hshah:
That sounds like the issue I had with the 20190213 build. It is sorted with the latest from today though :)
[Magisk] jenslody:
If you would look at his github, you would see it was merged yesterday.

Nevertheless it's still be worked on.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I updated 2 of my Nextbook Ares 8A, x86, Android 6.0.1 devices to today's build and everything is fine.

On the third device, I have Magisk is not installed. I have never had this happen. I restored the stock boot.img and tried again and got the same result.

Reverting to Magisk-v18.2-2019021303-ianmacd.zip solved it. I also tried booting into core only mode from above and installing todays update with the same result.

The thing I have not tried was uninstalling all modules or the Magisk Uninstaller.

My modules are App Systemizer (Terminal Emulator), Busybox for Android NDK, Enable Doze for GMS Magisk Module, MagiskHide Props Config and Systemless Hosts. The other working devices have the above modules plus CloudflareDNS4Magisk module. The only app I have systemized is Greenify.

I am not sure what is different on that device. I install it through TWRP, but also tried the patched boot.img method also.

I prefer to not start over with the modules, but should I try the Magisk uninstaller or do you think something in userdata is corrupted that would warrant a factory reset? I just factory reset a few weeks ago.

As I previously stated, reverting to Magisk-v18.2-2019021303-ianmacd.zip, solves the issue. Do you have any other thoughts?

I realize that [MENTION=4470081]topjohnwu[/MENTION] has made some dramatic changes to Magisk so things like this are bound to happen.

Thanks

UPDATE: used the Magisk Uninstaller, the version that matched Magisk-v18.2-2019021303-ianmacd.zip, then tried your latest again and had the same result. I then restored Magisk-v18.2-2019021303-ianmacd.zip and saw that my modules were still there. I thought the uninstaller would remove the modules, also.

I guess I could uninstall all of my modules and try that, or factory reset, or reinstall the rom? I just don't get why it works on the other 2 devices.

It is the same Android and kernel version, but the devices had different rom build numbers and different IFWI (Intel Firmware Interface) versions.
[Magisk] habylab:
Yes I had a look yesterday, promising to see. I'm on arters build at the moment actually, will wait for these builds to become more stable.
[Magisk] ianmacd:
I can't help you, I'm afraid. Quite a few people are experiencing weird issues this week after the radical changes to Magisk, which are the most invasive in a long time. By the time I could hope to investigate a problem, new commits have appeared and the topology of the Magisk universe has changed yet again.

I've put out a 2019021501 build. Give it a whirl and see if it makes any difference.

I'm about to get on a plane until tomorrow morning, so this will be the only build from me today.
[Magisk] martyfender:
I installed 2019021501, it bootlooped on the animation screen, so I shut down and rebooted and it booted and appears to be working fine now. I have not mentioned this before, but with recent builds I have had this same bootloop on the animation screen at times on different devices and is always solved by a forced shutdown, followed by booting up again. I believe it happened also on the devices I have the latest Canary build on.

Thanks for your efforts and have a safe trip.
[Magisk] Homeboy76:
arters 'Magisk' build:confused:

Where?

What devices does it support?
[Magisk] habylab:
Look on his Twitter. Fairly sure the latest build here incorporates his work.

Anyone used this build? Any issues?
[Magisk] guest4711:
No problems here on my old Sammy arm devices running Android M and N.
[Magisk] habylab:
Stupid question: how do I install this? The GitHub link is a year old, and the Magisk manager module won't install for me.
[Magisk] guest4711:
Install what? Magisk Modules install from Download Section of MagiskManager, custom builds of Magisk either by setting the custom channel to the json file (e.g. https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json) or by pointing your browser to the github, e.g. https://github.com/ianmacd/MagiskBuilds/find/master?q=
[Magisk] martyfender:
See my post above. I have had no issues since then..
[Magisk] habylab:
Thanks, OP doesn't mention to add it as a custom channel. Just has a link to GitHub which has .zips in and also a Magisk module to presumably aide updating this.
[Magisk] habylab:
Confirming the latest has installed and working fine! Seeing massive improvements in Magisk Hide, as my banking apps do not require host blocking any more.
[Magisk] Ubimo:
Does anyone know if [MENTION=3306843]kantjer[/MENTION] will continue builds? Or if he is repairing his linux?
[Magisk] kantjer:
I have reinstalled Linux but I haven't setup the build environment yet.

At the moment I have a few other interests consuming my free time.

Not sure if I will continue to build Magisk since we have good unofficial builder and the Canary builds.
[Magisk] Ubimo:
But, but you were the best.
[Magisk] neekless:
Anyone have issues with abnormal viper driver with the recent builds? I think the deprecation of magisk.img may have messed up viper's driver installation.
[Magisk] Didgeridoohan:
I saw this too on the recent Canary builds, but everything's working after uninstalling and reinstalling the V4A module.
[Magisk] neekless:
I did a fresh install of all my modules but still had the problem, but now I think it's caused by AML or some of zack's other audio related modules. I removed them all and reinstalled viper alone and now it works.
[Magisk] Didgeridoohan:
That might be it... I actually had AML installed previously but did not install it again now, since I no longer have any other audio mods than V4A.
[Magisk] Ubimo:
How do I do if I want to change from kantjer to ianmcd?
[Magisk] guest4711:
How did I do it?

1. Download latest magisk zip from his git: https://github.com/ianmacd/MagiskBuilds/find/master?q=

2. unhide MagiskManager (if repacked previously)

3. uninstall MagiskManager

4. reboot into recovery,

5. flash magisk.zip from step 1.

6. Reboot and enjoy

7. Repack MagiskManager again if needed for some apps, e.g. banking apps, poGo ...

Edit: If MagiskManager is missing after step 6, install MM out of the zip downloaded in step 1. It's located in common folder named magisk.apk
[Magisk] martyfender:
Does anyone know what this error is in the magisk. Log after updating? It is gone after a second reboot.

MagiskHidePropsConf: exec [service.sh]

02-16 10:28:49.916 3323 3323 E Magisk : execve /system/bin/pm failed with 8: Exec format error

Thanks
[Magisk] Didgeridoohan:
I think that's the Manager installation that is failing.
[Magisk] martyfender:
On multiple devices, the error is gone after an 2nd reboot. This has been happening with recent unofficial builds. I don't see it in the Canary debug build logs. It looks like a script failing to run?
[Magisk] Didgeridoohan:
If the Manager installation during boot fails that is what's to be expected, I believe. I think it'll only be done on the first boot after flashing the Magisk zip in recovery.
[Magisk] martyfender:
This maybe confirms that from the log on another device with the latest Canary:

MagiskHidePropsConf: exec [service.sh]

02-16 10:31:24.484 2374 2931 I Magisk : apk_install: /data/magisk.apk

02-16 10:31:25.826 3180 3180 I Magisk : apk_install: Error: Could not access the Package Manager. Is the system running?

02-16 10:31:31.702 3708 3708 I Magisk : apk_install: Error: Could not access the Package Manager. Is the system running?

02-16 10:31:37.869 4135 4135 I Magisk : apk_install: Error: Could not access the Package Manager. Is the system running?

Maybe because MM was updated to the latest already?
[Magisk] daywalk3r666:
i think magisk hide is inactiv.i have similar problems...sometimes magisk hide switched off automatic
[Magisk] guest4711:
PacketManager (pm) has no correlation to MagiskHide. The error indicates that auto-installation of MagiskManager fails. If you are missing MM after fresh installation of Magisk you can install it from the magisk.zip, where MM is located in the "common" folder as magisk.apk.
[Magisk] martyfender:
If I unistall Magisk and reinstall it, I usually have to install mm that way as it is not installed after flashing. Occasionally it is though.

With recent builds, has any one else experienced a bootloop after updating, on the first reboot only. A forced shutdown, followed by starting up again, solves it for subsequent reboots. It has happened randoomly on the 3 tablets I have [MENTION=7187684]ianmacd[/MENTION] build on, but not always on the same device. It is usually only on one out of the 3 devices.

Reflashing the stock boot.img, has not solved this. It is, of course, a minor problem, since all is working now. [MENTION=4470081]topjohnwu[/MENTION]
[Magisk] ianmacd:
ianmacd builds no longer internally tested prior to release.

This is just a quick note to inform anyone who uses my builds (i.e. the ianmacd builds) that, until further notice, I am no longer in a position to perform even trivial testing of new builds prior to releasing them.

These builds always were an at your own risk affair by their very nature, but I still acted as a trivial gatekeeper to prevent the most glaringly broken software from escaping into the wild. Now, however, I have had to fall back to using my trusty 2019021102 build to restore the Xposed module, broken by later builds, to working order on my devices. Switching between builds from before and after 12th February is destructive and therefore laborious, so I will regretfully be unable to install and test new builds until such time that the Xposed breakage is remedied.
[Magisk] martyfender:
Does that mean you will still be releasing new, untested builds, though?
[Magisk] habylab:
Only testing is mentioned, so yes.
[Magisk] martyfender:
So they will be on your master channel?

https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json

Thanks
[Magisk] bggold:
[MENTION=8126387]martyfender[/MENTION]

I'm sure this issue will be resolved very soon for ianmacd. He already put in an issue on GitHub for topjohnwu and he already engaged with ianmacd.

It seems it is an issue with his Xposed magisk module and/or magisk builds since.

Since they are both topjohnwu's projects I'm sure he will fix it soon and knowing him he has already started.

Btw others are experiencing this too.
[Magisk] teddy0209:
I've also experienced xposed causing my 7.0 device not to boot, and switching back and forth is a hustle because the last build with working xposed will be unable to read your modules after it was transfered by installing the latest build.
[Magisk] ianmacd:
Yes, everything will continue as before; the only difference being that I won't have tried the builds myself before releasing them.

Just for kicks, I tried the other Xposed module yesterday, the universal one that detects which SDK to install Xposed for. That module causes the same loop that John's Xposed module causes.

John thinks the problem is related to Samsung's KNOX. All I know is that the module works fine with all Magisk builds up to 11th February, and with none of them since then.
[Magisk] martyfender:
Thanks, I see topjohnwu has done a few commits since your last release, so I look forward to test your next build. I will let you know if I have any problems.
[Magisk] ianmacd:
Actually, I did test a build with those commits prior to going back to an older build, and I had problems with MM consistently crashing within 15 seconds of launching, which is why you haven't seen a build from me that has them.

I've been waiting for new commits, one of which will hopefully fix the crashing problem, before pushing a new release.
[Magisk] PokemonTotalWar:
Is anybody else experiencing Safetynet failing on the latest ianmacd build? Toggling MagiskHide on and off doesn't help, and both basicintegrity and ctsprofile fails.
[Magisk] martyfender:
I'm not having any problems on my devices with it. It looks like MagiskHide is not working for you. Have you tried rebooting again?

UPDATE: I just updated one device to [MENTION=7187684]ianmacd[/MENTION] testing build 18.2-2019021602, which he did not recommend, but MM works fine. Safety Net, however, did not pass until I rebooted to TWRP, deleted the cache and dalvik cache then rebooted. After that it passed. I'm not sure if it was the second reboot, or deleting cache that solved it though, or both. After some time I am seeing high cpu usage, also, so that is another good reason why Ian did not push this build.

Rebooting to TWRP and deleting cache and dalvik cache seems to have solved the high cpu usage.

No complaints here, this is why I test, issues are expected with these builds.
[Magisk] hshah:
I think it's very respectable of you to believe that it may be expected of you, let alone call it out.

We are all testing unofficial builds here and have signed up to things not going as expected. Simply put, those who don't agree are just wrong :)
[Magisk] Ubimo:
In [MENTION=7187684]ianmacd[/MENTION] builds, is the debug flag on or off?

In topjohnwus canary builds the binaries are built with debug flag ON: excessive logging enabled in both Magisk and Magisk Manager for debugging.
[Magisk] ianmacd:
Actually, John offers Canary builds in both release and debug flavours. There are separate channels for each.

My unofficial builds come only in the release flavour.
[Magisk] bggold:
Latest build working just fine on pixel 3 xl AOSiP. No install issues, Fc's and safety net passes.

Thanks