yashsingh1/xdaforums huggingface dataset:
[Magisk] ianmacd:
It seems it's my day for screw-ups.

I accidentally compiled those builds with version r18b of the NDK, and some devices don't like the code that produces.

Please upgrade to 2018102901, where order should be restored.

---------- Post added at 03:14 ---------- Previous post was at 03:07 ----------

No, that's a different shortcoming.

The changelog is automatically produced by finding all of the commits from the present down to the previous release. Under normal circumstances, this approach works well, but when I have to rebuild without committing any new code (as was the case when the API key didn't get inserted at build time, for example), it results in a new changelog containing no entries at all. Ideally, an empty changelog should be ditched in favour of the previous one, but my build system isn't currently intelligent enough to reconstruct the previous log.

The latest build (2018102901) has an empty changelog yet again, as it was simply recompiled against a different NDK and again contains no actual code changes.
[Magisk] Dark_Diver:
It works now, thank you.

But Magisk behaves strangely on this week Xiaomi Developer ROM, I have two RedMi phones, Note 4 MTK & Note 3 Pro, upgraded them yesterday.

It seems that Xiaomi changed something. Will look more attentively later, may be I'm wrong.
[Magisk] martyfender:
What was changed in 2018102902?
[Magisk] ianmacd:
Nothing. Just a rebuild.

After I pushed 2018102901, it failed to install on a second device of mine. I was concerned that I might have become confused and somehow built yet another version with the wrong NDK, so I rebuilt it another time, just to be on the safe side.

Meanwhile, 2018102903 has appeared. This one has no Magisk changes per se; just some updates to the submodules that Magisk relies on.

Sorry for pushing several builds in the last 24 hours. If it's any consolation, there were many more internal builds yesterday that never escaped Dr. Frankenstein's lab.
[Magisk] kantjer:
Nice addition, I'm going to kang it :D

Thanks :good:
[Magisk] edzamber:
Hi [MENTION=3306843]kantjer[/MENTION]

Seems to have Saftynet api issue in your last build...

View attachment 4629480
[Magisk] psychoela:
Clear data will fixed
[Magisk] kantjer:
I know, I will fix it later.

Need to go now.
[Magisk] edzamber:
Thanks bro [emoji106]

Fixed by wipe Magisk Manager data [emoji16]

View attachment 4629496
[Magisk] kantjer:
Did a wipe fix it :confused:

Didn't expect that

EDIT: As I expected, didn't work for me. It should not be working because the API key is missing

EDIT 2: fixed by pushing John's snet.apk as a temp fix

I will check how to inject my own API later. It's the same issue [MENTION=7187684]ianmacd[/MENTION] had earlier
[Magisk] ianmacd:
You're very welcome. That's the beauty of the GPL. I'm happy for you to reuse my work, and you're entitled to do so, anyway.

[SOAPBOX]

You know, I really dislike the connotation this silly verb to kang often has in the Android community. It originally meant to take another person's code and pass it off as your own, but nowadays it's also used to refer to the act of taking code in full compliance with the terms of its licence and reusing it with full and proper attribution of the original author. As someone who has been cheerfully releasing my own code and gratefully reusing others' for several decades now, I'm dismayed that anyone in the Android world considers this practice anything less than normal and commendable behaviour.

Reusing code, with proper attribution, is a good thing, and not something to be embarrassed about, apologise for, try to hide, or ask permission for. On the contrary, code reuse is one of the most significant reasons we have managed to progress as far as we have with software. Even proprietary operating systems are peppered with code reused under a very liberal licence.

It seems to be that many in the Android community fundamentally misunderstand free and open source software, particularly the GPL licence, and spend far too much time fretting about who is reusing what code, in which project, and for what purpose.

[/SOAPBOX]

The above isn't aimed at you at all, mate. I know you were using the word in jest. You just touched on one of my pet peeves and triggered a rant, that's all. :)

Please do grab the navigation drawer commits, too. Hopefully, those will get merged upstream in due course.

That bit me, too. I've added code now to verify the presence of the API key in the source file before building.
[Magisk] Didgeridoohan:
[MENTION=7187684]ianmacd[/MENTION] A simple click of the "Thanks" button just doesn't cut it... That warrants a standing ovation! Very well put.
[Magisk] kantjer:
I have now done the same, check if the key is inserted in SafetyNetHelper.java and exit if it isn't
[Magisk] ianmacd:
One day, I hope to be clever enough to anticipate issues like this and fix them preemptively. :)
[Magisk] kantjer:
Having the API in the config.prop would be a great step forward.

But for now, adding checks will have to do.
[Magisk] SysWiz:
Mystery Module

Question for you all. I have had a "phantom" module showing up in the Magisk Manager Modules section for the last few builds now. See pic below. I have tried deleting it via Magisk Manager, but it always returns after a reboot. Any ideas what it is, or how to identify what it is, and possibly nuke it? Thanks.
[Magisk] Didgeridoohan:
Check in /sbin/.core/img. There's probably gonna be a file or a directory that doesn't belong there, as in it's not one of your installed modules. Delete it and you're good to go.
[Magisk] SysWiz:
Hmm, I already looked there and I'm not seeing anything weird. What now?
[Magisk] Didgeridoohan:
The hidelist doesn't belong there, it's supposed to be in /sbin/.core/img/.core. I've no idea why it's been created directly in the img directory, but that's not where it belongs...
[Magisk] SysWiz:
That was it, Thanks a million!
[Magisk] martyfender:
Yes, I agree, I have never had my hidelist show up there on my devices, it is rather strange?
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=3306843]kantjer[/MENTION] [MENTION=7187684]ianmacd[/MENTION] I have never reported this before, but this behavior has been happening for some time. In Magisk Manager settings I have set Re-authenticate after upgrade. When I update an app, whether it is in the Playstore or through an apk download, on first launch, instead of getting the superuser prompt, I get a toast saying superuser rights have been granted. On the second launch of the app, I do get the superuser prompt to allow me to grant access. However, sometime I do get the prompt on first launch. Has anyone else seen this behavior? This has happened with all root apps for quite some time.

Thanks
[Magisk] kantjer:
I don't use the Re-authenticate option.

---------- Post added at 15:27 ---------- Previous post was at 15:20 ----------

@martyfender have you already tried today's build?

Just found that I can't open MM :confused:
[Magisk] martyfender:
Yes I thought about doing that as I guess I would see a toast that root was granted, or not.
[Magisk] bggold:
Have a strange one. After updating to r7. Lost root. Flashed the uninstaller and tried rooting again by patching boot and flashing it.

Still no root for apps. What can I check as far as files or folders that might have not gotten cleaned up after the uninstaller?

Edit:

Just tried again and here is the magisk log.

11-02 12:26:20.123 719 719 I Magisk : ** Initializing Magisk

11-02 12:26:20.124 719 719 I Magisk : * Creating /sbin overlay

11-02 12:26:20.126 719 719 I Magisk : * Mounting mirrors

11-02 12:26:20.126 719 719 I Magisk : bind_mount: /sbin/.core/mirror/system

11-02 12:26:20.126 719 719 I Magisk : mount: /sbin/.core/mirror/vendor

11-02 12:26:20.126 719 719 I Magisk : bind_mount: /sbin/.core/mirror/bin

11-02 12:26:20.127 719 719 I Magisk : * Setting up internal busybox

11-02 12:26:20.145 722 722 I Magisk : Magisk v17.4.r7-unofficial(2018110209) daemon started

11-02 12:26:20.165 727 727 I Magisk : Magisk v17.4.r7-unofficial(2018110209) logger started

11-02 12:26:20.196 722 723 I Magisk : ** post-fs-data mode running

11-02 12:26:20.196 722 723 I Magisk : * Mounting /data/adb/magisk.img

11-02 12:26:20.246 722 723 I Magisk : * Running post-fs-data.d scripts

11-02 12:26:20.246 722 723 I Magisk : * Running module post-fs-data scripts

11-02 12:26:20.246 722 723 I Magisk : * Loading modules

11-02 12:26:20.246 722 751 I Magisk : * Starting MagiskHide

11-02 12:26:20.247 722 751 I Magisk : hide_utils: Hiding sensitive props

11-02 12:26:20.249 722 751 I Magisk : hide_list: [com.google.android.gms.unstable]

11-02 12:26:20.643 722 978 I Magisk : ** late_start service mode running

11-02 12:26:20.645 722 978 I Magisk : * Running service.d scripts

11-02 12:26:20.645 722 978 I Magisk : * Running module service scripts

11-02 12:28:37.102 5962 5962 E Magisk : write failed with 32: Broken pipe

11-02 12:28:37.102 5962 5962 E Magisk : readlink /proc/4431/cwd failed with 2: No such file or directory

11-02 12:28:37.103 5962 5962 E Magisk : read failed with 9: Bad file descriptor

11-02 12:28:37.103 5962 5962 E Magisk : read failed with 9: Bad file descriptor

11-02 12:28:37.103 5962 5962 E Magisk : stat icu failed with 2: No such file or directory

11-02 12:28:37.103 5962 5962 E Magisk : su: Wrong permission of pts_slave

Thanks
[Magisk] ianmacd:
Watch out for the commits from 1st November. I had to pull a build that initially seemed OK in testing, and flash two devices back to my 20181030 build.

The latest commits cause MM to forget your entire list of root-granted apps.
[Magisk] bggold:
Thanks that might explain my issue I will try your 1030 build.

[MENTION=7187684]ianmacd[/MENTION]

Tried your build and here is the log. Still no app getting granted root. Any ideas?

11-02 12:43:49.148 719 719 I Magisk : ** Initializing Magisk

11-02 12:43:49.149 719 719 I Magisk : * Creating /sbin overlay

11-02 12:43:49.151 719 719 E Magisk : lstat (null) failed with 14: Bad address

11-02 12:43:49.208 719 719 I Magisk : * Mounting mirrors

11-02 12:43:49.209 719 719 I Magisk : bind_mount: /sbin/.core/mirror/system

11-02 12:43:49.209 719 719 I Magisk : mount: /sbin/.core/mirror/vendor

11-02 12:43:49.209 719 719 I Magisk : bind_mount: /sbin/.core/mirror/bin

11-02 12:43:49.209 719 719 I Magisk : * Setting up internal busybox

11-02 12:43:49.226 724 724 I Magisk : Magisk v17.4-2018103001-ianmacd(2018103001) daemon started

11-02 12:43:49.249 729 729 I Magisk : Magisk v17.4-2018103001-ianmacd(2018103001) logger started

11-02 12:43:49.280 724 725 I Magisk : ** post-fs-data mode running

11-02 12:43:49.280 724 725 I Magisk : Create /data/adb/magisk.img with size 64M

11-02 12:43:49.297 724 725 I Magisk : * Mounting /data/adb/magisk.img

11-02 12:43:49.336 724 725 I Magisk : * Running post-fs-data.d scripts

11-02 12:43:49.336 724 725 I Magisk : * Running module post-fs-data scripts

11-02 12:43:49.336 724 725 I Magisk : * Loading modules

11-02 12:43:49.337 724 755 I Magisk : * Starting MagiskHide

11-02 12:43:49.337 724 755 I Magisk : hide_utils: Hiding sensitive props

11-02 12:43:49.338 724 755 I Magisk : hide_list add: [com.google.android.gms.unstable]

11-02 12:43:49.831 724 1008 I Magisk : ** late_start service mode running

11-02 12:43:49.831 724 1008 I Magisk : * Running service.d scripts

11-02 12:43:49.832 724 1008 I Magisk : * Running module service scripts

11-02 12:45:16.890 6458 6458 E Magisk : write failed with 32: Broken pipe

11-02 12:45:16.890 6458 6458 E Magisk : readlink /proc/4736/cwd failed with 2: No such file or directory

11-02 12:45:16.890 6458 6458 E Magisk : read failed with 9: Bad file descriptor

11-02 12:45:16.890 6458 6458 E Magisk : read failed with 9: Bad file descriptor

11-02 12:45:16.890 6458 6458 E Magisk : stat icu failed with 2: No such file or directory

11-02 12:45:16.890 6458 6458 E Magisk : su: Wrong permission of pts_slave

11-02 12:45:35.786 724 755 I Magisk : proc_monitor: com.google.android.gms.unstable

11-02 12:45:50.553 7954 7954 E Magisk : write failed with 32: Broken pipe

11-02 12:45:50.553 7954 7954 E Magisk : readlink /proc/5979/cwd failed with 2: No such file or directory

11-02 12:45:50.553 7954 7954 E Magisk : read failed with 9: Bad file descriptor

11-02 12:45:50.553 7954 7954 E Magisk : read failed with 9: Bad file descriptor

11-02 12:45:50.553 7954 7954 E Magisk : stat icu failed with 2: No such file or directory

11-02 12:45:50.553 7954 7954 E Magisk : su: Wrong permission of pts_slave

---------- Post added at 08:51 PM ---------- Previous post was at 08:38 PM ----------

Very strange now. After letting the phone sit a few mins apps started asking for root access. I will reboot and see if those that did not get granted are.
[Magisk] hshah:
Is the SafetyNet check still broken or is it just on my end?

I'm on Kantjer's latest build :)
[Magisk] buffal0b1ll:
Same thing happened to me on [MENTION=3306843]kantjer[/MENTION] 10292018 and 10302018. I've reverted to 10272018 and all's well for 2 days. Seems commits that cause it may be earlier than Nov 1.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION], just as you stated, on my one Nextbook Ares 8A, that I have your build on, 2018103001, I lost both my superuser list and my hide list. However, I re-added each app by launching each and getting the prompt and also added my one app in the hidelist: Rootbeer Sample and they are all there after one reboot of the device.

[MENTION=3306843]kantjer[/MENTION] latest, 2018110209 r7, which should have the same commits as your latest, has no such problems on the 2 Nextbook Ares 8A's that I have it on.

So something is clearly different about the way you each built it. I have faith that you will sort it out.

EDIT: I rebooted to TWRP, deleted cache and dalvik cache, then rebooted to system and both lists are still there on your 2018103001, build.

Do you know if both of those lists are now stored in the Magisk database?

Apparently you reverted your channel from 2018110101, to 2018103001. I did not realize that before posting and flashed 2018103001, thinking my update last night had failed, without really reading the date. So maybe having the newer build first, is what actually deleted the database, not the 2018103001, build?

Even with the above mistakes that I made, it still doesn't explain why 2018110101

fails and 2018110209 r7 is working with the same apparent commits.
[Magisk] carlos974:
FYI ! I am on MM 20181101 and for now I still have the list of root-granted apps.
[Magisk] bggold:
[MENTION=7187684]ianmacd[/MENTION] [MENTION=3306843]kantjer[/MENTION]

I have tired both your builds and the canary.

After flashing the uninstaller and rerooting magisk seems to load very slow and still getting the following errors.

After the phone has been sitting for about 5 mins you can grant apps root and once you reboot those that were granted root before do work before the 5 mins.

Is there anything that might be left behind that I can look for to remove after flashing the uninstaller?

Pixel 3 xl.

11-02 23:01:30.769 7583 7583 E Magisk : write failed with 32: Broken pipe

11-02 23:01:30.769 7583 7583 E Magisk : readlink /proc/5830/cwd failed with 2: No such file or directory

11-02 23:01:30.769 7583 7583 E Magisk : read failed with 9: Bad file descriptor

11-02 23:01:30.769 7583 7583 E Magisk : read failed with 9: Bad file descriptor

11-02 23:01:30.769 7583 7583 E Magisk : stat icu failed with 2: No such file or directory

11-02 23:01:30.769 7583 7583 E Magisk : su: Wrong permission of pts_slave

Thanks
[Magisk] ianmacd:
Thank you for all of the information, guys. I am trying to reconcile the somewhat contradictory findings and suss out exactly what this means.

The only thing I can say with certainty right now is that my own 2018110101 build behaved very poorly when I pushed it to my master channel after first having it in my own private testing channel, which I use to test builds on my own devices before making them public. It's not much of a safeguard, because everyone's hardware and software configuration is different, but the practice does occasionally catch a large, Magisk-wide coding blunder.

Anyway, it initially seemed OK, but after a second reboot, the problems came. I lost all of my grants, and continued to lose them after readding them, following each subsequent reboot.

The problems went away when I backed down to 2008103001. I had to readd everything one final time, but then they were persistent again.

The issue was severe enough that I took the unusual step of reverting the build. It hadn't been up for long, so I was hoping that no-one had grabbed it.

I'm baffled how a later kantjer build would behave differently, if no commits were omitted from it; especially in view of the fact that one person reports that an earlier kantjer build already suffered from the issue.

I don't see how all these things can be true at the same time, so I'm not sure at this stage whether Magisk has a general issue, or whether it's just my latest build. That build, however, was built no differently than the one before it.

Hopefully, the next few commits will shed some light on this.
[Magisk] carlos974:
For me it works correctly for now :good:, so I remain on this version 2018110101 ... to follow !
[Magisk] ianmacd:
I was out of the house when I wrote the previous posting.

Back home, I see that John has pushed a bunch of new commits, some of which touch a lot of code. My experience tells me to expect new bugs.

That said, I've built the code in its newest state, flashed it onto my S9+ and rebooted several times. Magisk seems to be functioning as expected, with none of the shenanigans exhibited by my 2018110101 build.

I shall push this 2018110301 build to the ianmacd channel as soon as I hit Post on this posting.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I just wanted to let you know that the new build, 2018110301, is working well for me as well, so far.

Thanks
[Magisk] kantjer:
I pulled all post 30/10 builds.

I keep losing my superuser db with newer builds, also Magisk Manager can't be opened.
[Magisk] psychoela:
latest build r8 is work as usual with my device's, no issue so far. Thanks
[Magisk] BustedFly:
For me too. S7 edge with SM 2.8. All fine with r8 build.
[Magisk] guest4711:
No problems here on S4 i9505 android N using r8. Everything good as usual, even after some reboots. Updated some modules, granted root access to some apps, checked which apps are in hide list. MagiskManager is still repackaged. No need to downgrade for me :)
[Magisk] ianmacd:
The problems went away for me after I recompiled with commits from 3rd November. Is that not the case for you?

Today brings another fairly large change, with the last vestiges of C replaced by C++. That one, too, also seems to be working without issue for me.
[Magisk] kantjer:
Tried yesterdays build and it isn't working (direct install)

I'm going to try a TWRP flash see if that makes a difference
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] r8 has worked fine for me on 2 devices, installed through TWRP. I still have issues sometimes when I use the direct install method, So I haven't attempted it on my devices in several days.

I'm just installing r9 on one device to see how it goes. A far as I can tell, it is working well. My superuser list is there and my hidelist is also there on both of these builds.
[Magisk] jenslody:
The latest canary does not mount magisk.img on my device, so be careful with latest sources.
[Magisk] kantjer:
Same for me on the Nexus 6P

---------- Post added at 15:40 ---------- Previous post was at 15:39 ----------

Seems to be an issue on some devices only

I flashed the uninstaller and then r9, still no luck
[Magisk] bggold:
Just flashed on my pixel 3 xl and no issues so far.

Was running R8 without issues prior.

Thanks
[Magisk] martyfender:
The latest Canary, [MENTION=3306843]kantjer[/MENTION] and [MENTION=7187684]ianmacd[/MENTION] builds all work on my Nextbook Ares 8A's, with no issues, so far. Magisk image is mounted fine.
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] I see you pulled r6-r9, based on the problems you and others had with them. I just wanted to let you know that r9 is still functioning well on the 2 devices I have it on. Have you provided any feedback to [MENTION=4470081]topjohnwu[/MENTION] ?
[Magisk] kantjer:
No, for that I need to switch to the canary channel and some do proper logging.

I don't have time for that ATM.

All I know is that the issue started with the Nov 1 commits.

After installing the new MM all is fine but after a reboot, I can't open MM. After reverting to the previous MM my SU database is empty.
[Magisk] ianmacd:
This is similar, but not quite identical, to what I experienced.

The fix was for me to revert to the previous MM, rebuild the su database, and then skip forward to a post-2nd November build. From the number of builds you have pulled, however, I'm assuming you have already tried this.
[Magisk] kantjer:
I tried that, didn't work.

Even flashing the uninstaller and flash a recent build gave the same outcome.

"Better debugging output" is the last known working commit for me.
[Magisk] Ubimo:
I also see that r6-r9 are gone.

r9 is working very good on my S7 edge stock nougat rom.
[Magisk] hshah:
Stupidly I downgraded to r5 via the app and now my MM doesn't work :confused:
[Magisk] bggold:
Updated to Nov update pixel 3 xl and when I flashed magisk again I am still getting the following errors. I flashed the uninstall and reflashed magisk and the errors still occur.

Apps don't ask for root until the phone has been up for about 5 mins.

I have tried builds from both devs and canary.

Any ideas?

Thanks

write failed with 32: Broken pipe

11-05 16:03:29.909 10032 10032 E Magisk : readlink /proc/6241/cwd failed with 2: No such file or directory

11-05 16:03:29.909 10032 10032 E Magisk : read failed with 9: Bad file descriptor

11-05 16:03:29.909 10032 10032 E Magisk : read failed with 9: Bad file descriptor

11-05 16:03:29.909 10032 10032 E Magisk : stat icu failed with 2: No such file or directory

11-05 16:03:29.909 10032 10032 E Magisk : su: Wrong permission of pts_slave

Update:. After some further research and testing on another phone. This seems to be normal as of several builds ago. Not sure what build.

After testing on a fresh build. It seems magisk has not completely started so root is not available yet.

Just have to grant root to those apps after. Once root is granted all is good.

Case closed.
[Magisk] RagingHarry:
Got 2 devices (op6 ob6 on r6 and gts210velte Lineage 15.1 on r9) running without any problems.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] Thanks for adding the extra root prompt timeout options in MM. [MENTION=4470081]topjohnwu[/MENTION] should consider doing this, also.
[Magisk] ianmacd:
You're welcome. 10 seconds is sometimes too short for me, because I have Magisk hidden behind an AppLock and can't get to the grant pop-up in time. 45 seconds is for a little extra granularity at the extreme end.

I was too tired last night to create the pull-request, but here it is for [MENTION=4470081]topjohnwu[/MENTION].
[Magisk] kantjer:
John found the reason I was having issues with all November builds.

Turns out the buffer size of `sql` is not big enough.

I'm using a module that exceed the current limit,

So I hope to be back in business soon
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] That is great to hear. Is that something John has to fix in a new commit, before you can update your build? Also, out of curiosity, what was that module?

Thanks
[Magisk] kantjer:
It was the Microsoft Intune Company Portal Hider module, well not the module itself but Microsoft using a long package name "com.microsoft.windowsintune.companyportal"

John already pushed the commit to fix this, going to test it asap.

EDIT: tested and working
[Magisk] ianmacd:
I looked at the commit and, to be honest, I don't see how that package name could have been causing a buffer overflow. The buffers he had originally allocated, whilst small, seem large enough to accommodate that package name plus the other data that was being copied.

With the new 4 kB buffers, all but a hypothetically pathological case should be catered for, but I'm still curious exactly which buffered overflowed and how.