yashsingh1/xdaforums huggingface dataset:
[Magisk] edzamber:
Hi

Install this one, i have resigned it :)

https://mega.nz/#!P8sBQbCQ!boWV5ocfYkcY6iDxQXRmrqRq1uoz3bhtqYkAXOCkDuU
[Magisk] Renovatio_ edi:
Are you losing root with that one
[Magisk] edzamber:
Hi

Too Early to say if yes or no.

For now i have flash it about 2 hours and no root lost..
[Magisk] kantjer:
I'm fixing the issue now.

I needed to generate a new sign key, so you will have to uninstall the old apk when I upload it.
[Magisk] martyfender:
I just read all of this, so I will wait to download. Will you be reporting back here when you have it fixed?

Thanks
[Magisk] kantjer:
I uploaded the new fixed build

Best way to install this, dl the 29/5 MagiskManager.apk uninstall and reinstall MM (you can restore data from TiBu)

install Magisk update using MM

---------- Post added at 17:13 ---------- Previous post was at 17:13 ----------

:D, done
[Magisk] laupuy:
Thanks kantjer, it's good :good:
[Magisk] martyfender:
I just installed by hiding the Magisk Manager first and so far, so good.

Thanks, for your continued work on this.
[Magisk] hanschke:
Install dont work for me with new apk :(
[Magisk] guest4711:
For me it worked after repacking (hiding) MagiskManager.

Without it failed...
[Magisk] arjuna_:
After installing the latest update I am unable to install modules. I get the error /data/adb/magisk_merge.img mount failed
[Magisk] DIMITRISGR83:
Is this build treble support?

Στάλθηκε από το Redmi Note 4 μου χρησιμοποιώντας Tapatalk
[Magisk] guest4711:
Right, even after reboot it cannot mount the image.

As I see from the logs, it tries to mount to /dev/tmp. But [MENTION=3306843]kantjer[/MENTION]

/dev/tmp does not exist, creating it with mkdir does not help/work

jfltexx:/ $ su
jfltexx:/ # mkdir /dev/tmp
jfltexx:/ # ls -l /dev/tmp
ls: /dev/tmp: No such file or directory
1|jfltexx:/ #

Edit: After flashing magisk_20180520.zip through MagiskManager all is working again, even without rebooting...
[Magisk] hanschke:
I uninstall "old" manager but got the same error and hiding work not too. I have done a restart after uninstall.
[Magisk] oreo27:
The latest version I've built myself is also experiencing the same issue of not being able to install any modules:

https://github.com/0reo27/Travis-CI-Magisk-Builder/releases

I suppose a commit may have caused this. I'd wait for topjohnwu to get it sorted. In the meantime, we can use the previous commit version. You can grab it from kantjer's Github Repository.
[Magisk] martyfender:
Sure enough, modules will not install. All of my existing modules are still there, though. I reverted to 180520, with the newer, 180529 Magisk Manager version and modules install fine. I do see an error concerning busybox in the install log about opening the archive. Unfortunately, the log was deleted when I reflashed v180520. I now wish I had saved it.

Has anyone tried to build it with a newer NDK version, to see if this problem persists?

UPDATE: [MENTION=3306843]kantjer[/MENTION] [MENTION=4470081]topjohnwu[/MENTION] I tried to install a module on a second device and have attached a TWRP recovery log. Please note the busybox error in it.

Thanks

Thanks
[Magisk] kantjer:
Yesterdays build was made with NDK r17, that is the latest
[Magisk] martyfender:
That being the case, I guess we will have to wait until [MENTION=4470081]topjohnwu[/MENTION] sorts it out. On the 3 out of four devices I still have the newer build on, everything else seems to work fine, including my existing Magisk Modules. As noted, previously, only new modules fail to install. I have no need for any new ones, I just tried to install one as a test.

Thanks, again.
[Magisk] jenslody:
I would try to replace the internal busybox with the binary from [MENTION=4544860]osm0sis[/MENTION]' busybox module, just to test it.
[Magisk] hshah:
[MENTION=4667597]Didgeridoohan[/MENTION], following my previous posts of trying to provide as much information as possible for the "losing root" issue, I have reverted back to v16.3 with no modules. In about 30 hours now I've had the loss of root issue once, and that was only after I installed:

mm

MagiskHide Props Config

ExSDCard Access Enabler

I have previously tried v16.4 and all of the recent unofficial builds (apart from the ones from yesterday) without any modules and even then I was losing root.

I won't even pretend to understand this stuff, but maybe there is something in v16.3 that feels more at home with Samsung ROMs?
[Magisk] Didgeridoohan:
[MENTION=271749]hshah[/MENTION]

It's on the investigation list, but the very limited time [MENTION=4470081]topjohnwu[/MENTION] has means it will be some time until you'll see any kind of fix for this issue...
[Magisk] dingolino:
Just to report:

On my Note 8 with Android 7.1.1 I installed yesterday the new version and yesterday evening there was a new update of the busybox module. Also this update was done fine. I have not installed any new module so far (and have no time for detailed testing because of traveling)

Best regards

dingolino

Gesendet von meinem SM-N950F mit Tapatalk
[Magisk] martyfender:
Is the internal BusyBox located in: /sbin/.core/mirror/bin ?
[Magisk] jenslody:
Yes, softlinks for applets are in /sbin/.core/busybox .
[Magisk] martyfender:
Attached are logs for module install on build 180529 vs. 180520. Failure vs. Success.
[Magisk] edzamber:
Hi

Since 24 hours, no root lost with last kantjer 18.05.29 build...
[Magisk] hshah:
[MENTION=4667597]Didgeridoohan[/MENTION], I wasn't chasing for an update or anything. Just letting you all know what has improved the issue for me.

[MENTION=4507636]edzamber[/MENTION], what are you running? I would like to help test it but am currently in two minds on deviating away from what is currently working well for me lol.
[Magisk] edzamber:
I'm running my own custom TW Rom and my own kernel on S6 g925f Nougat 7.0
[Magisk] buffal0b1ll:
Same experience here on 052918 build. I had no trouble updating osmosis busybox module on Nexus 5x 8.1. I had no trouble installing osmosis busybox module on Pixel 2 DP2. I did not try to install any other modules.
[Magisk] martyfender:
I also successfully install the osmosis busybox 1.28.4 update on the 180529 build, unlike the unsuccessful install of another module. Does anyone know what is different in this module that made the install succesful, vs. other modules. Do modules need an update to succeed?

Update: It appeared to succeed, but when I open the terminal and type su then busybox, it shows not found.

Did you others that reported, actually confirm that busybox actually was installed by verifying it in the terminal?

I will revert to 180520, until [MENTION=4470081]topjohnwu[/MENTION] has a fix.

I reverted and all is working fine, again.
[Magisk] hanschke:
Android o work with uninstall on android p not thats I found now.
[Magisk] guest4711:
Just for the reports: *Not* fixed in 20180602. Had to reflash 20180520 (through MagiskManager) to get it working again.
[Magisk] martyfender:
Another user found where the problem is and fixed it here:

https://xdaforums.com/showpost.php?p=76686542&postcount=25052

And provided a flashable zip here:

https://xdaforums.com/showpost.php?p=76689421&postcount=25056

Of course, it doesn't include today's commits, but it does include last weekends, where module install was broken. Apparently [MENTION=4470081]topjohnwu[/MENTION] wasn't aware of the broken module install, when he did todays commits, or didn't have time to incorporate it in.

What is the best way to report issues to [MENTION=4470081]topjohnwu[/MENTION] ? I don't see a place for issue report on his github repository, unlike many github pages. Maybe he has that disabled on purpose so he doesn't get swamped with the many useless, unresearched posts like I see in these threads?
[Magisk] Didgeridoohan:
That is exactly why... :laugh:

And as if by magic:

https://github.com/topjohnwu/Magisk/commit/274efb49e747bc27f20cb7a320e38166711fa47c
[Magisk] hshah:
[MENTION=4667597]Didgeridoohan[/MENTION], I've not lost root since my last post 4 days ago. I'm still running v16.3 and my use has been no different... in fact I'm using root more freely because I don't have to reboot and hope it stays long enough for me to do what I wanted.

Is it worthwhile me trying to make the issue come back so I can provide information on what it may have been? Not sure if I'll even be able to break it again because nothing on my phone has changed other than running an older version of Magisk.
[Magisk] Didgeridoohan:
I'd leave it alone for now. [MENTION=4470081]topjohnwu[/MENTION] will be done with military soon and will hopefully have more time on his hands. Until then enjoy things working... :D
[Magisk] kantjer:
Just uploaded a build with the official fix
[Magisk] guest4711:
Thank you. It's working again. :)
[Magisk] ianmacd:
That user was me. I would have posted those messages in this thread instead, but, well, I didn't know of the existence of this thread until yesterday.

I'm glad [MENTION=4470081]topjohnwu[/MENTION] has now fixed the problem at his end.

If anyone's interested, I've just compiled a new build from the latest upstream source, with the 64 bit binaries reinstated (to prevent the patched kernel being misidentified as 32 bit by apps like DevCheck and Phone Info). There's probably a better way to tackle this problem, but hey, this works, too.

This build also contains conditional code for install-time patching of sepolicy for the S9/S9+ (G96[05]F/DS). Although the basic patch for this is now widely in use on these devices, this conditional version of it eliminates the need to create a separate version of Magisk.zip for these two devices. The same Magisk.zip will now work on any device, including the S9/S9+.

Rather than ask if anyone is interested, I'll just attach the ZIP here. I've tested it on an S9+ and a Tab S3. It works for me, but as always, make a boot.img back-up before you try it out.

For more details, see my fork of Magisk on GitHUb.
[Magisk] hshah:
Haha, you are a techie person as well so you know that I can't be happy without working out what actually has solved it.

I'm now doing the opposite to what I was before... instead of crossing everything possible in the hope that I don't lose root, I'm now opening the manager and even terminating the process on purpose to see if it will die. Unfortunately/Fortunately (depending on how you look at it) it's still alive and kicking.

:silly:
[Magisk] radz_:
Where's the download link? The link in the OP is not working
[Magisk] laupuy:
On kantjer's github https://github.com/kantjer/MagiskFiles (open as desktop from your phone)

Or choose custom update channel from magisk settings and copy this url:

https://raw.githubusercontent.com/kantjer/MagiskFiles/master/updates/kantjer.json
[Magisk] hshah:
It's still working flawlessly. Not lost root since I last mentioned it a couple of weeks ago. Still running 16.3 though and annoyingly I haven't been able to work out what's made the massive difference.

:victory: and :confused: and :eek:
[Magisk] guest4711:
Thanks for the new build, [MENTION=3306843]kantjer[/MENTION]. Flashed without problems, now rebooting...

... without problems.
[Magisk] ianmacd:
My Magisk builds now available via custom update channel.

For any interested parties, my Magisk builds are now available as a custom update channel via GitHub. I wanted to set this up for my own purposes, but since the only overhead involved in offering this to the general public is posting this message on XDA, I'm doing so in the hope that the work can be of benefit to others, too.

The config data for the update channel can be found here:

https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json

or, alternatively, from its shortened form:

https://goo.gl/yZpnrf

Feed either of those URLs into Settings→Update Channel→Custom in Magisk Manager, pull down to refresh, and away you go. Note that Magisk Manager may fail to install the very first time that you update from my channel, due to a version number and/or signing key discrepancy with whichever version you're currently running. If you experience this problem, simply remove your current version of Magisk Manager by hand and install the new one. You should not experience the problem again.

If you'd rather manually download my builds of either the Magisk ZIP or the Magisk Manager app, you can find them here:

https://github.com/ianmacd/MagiskBuilds

And if you want to inspect my fork of [MENTION=4470081]topjohnwu[/MENTION]'s Magisk repository, from which the above binaries were built, that can be found here:

https://github.com/ianmacd/Magisk

Currently, my build of Magisk diverges from the original in the inclusion of 64 bit binaries (to avoid an incorrect 32 bit kernel diagnosis by apps such as Phone Info and DevCheck), and the inclusion of a patch to enable Magisk to function on the Samsung Galaxy S9 and S9+ (G960F and G965F). The patch is universal, which means that the same ZIP file will work on any device, not just the S9 and S9+.

For the sake of completeness and convenience, I'm attaching today's builds to this message. Subsequent updates will be offered only via the Magisk Manager update channel and the links above.

I'll do my best to keep the channel updated with builds that I have verified to be functional on my own devices, but all of the typical disclaimers and warnings should be assumed to apply here.

Update:

The initial build I made available (Magisk-16.5-20180610-64bit-universal.zip) contained a Magisk Manager APK that was accidentally built in debug mode instead of with --release. This made the ZIP file larger than it needed to be. Sorry about that.

This is fixed in 16.5-20180611. I have updated the attachments below for your convenience.
[Magisk] kantjer:
Thanks, you can expect an other update in morning (my morning), a few more commits are being pushed.
[Magisk] nguyentankiet:
Work fine, S8 oreo. But, you can add kantjer chanel update by default? I mean no need add custom chanelView attachment 4523425
[Magisk] martyfender:
Why? It is very, very simple to add the custom channel. I just add it by copying it and pasting it. It literally just takes a few seconds. There is no need to type it in.
[Magisk] nguyentankiet:
Because it professional
[Magisk] anttaz:
Copying text from provided link into magisk is giving invalid URL channel when trying to update?

I copied and pasted the following:

{ "app": { "version": "16.5-20180611-ianmacd", "versionCode": "20180611", "link": "https://github.com/ianmacd/MagiskBuilds/raw/master/MagiskManager-16.5-20180611.apk" }, "magisk": { "version": "16.5-20180611-ianmacd", "versionCode": "20180611", "link": "https://github.com/ianmacd/MagiskBuilds/raw/master/Magisk-16.5-20180611-64bit-universal.zip", "note": "https://xdaforums.com/showthread.php?t=3521901" } }
[Magisk] ianmacd:
XDA truncates the URL for display and I can't immediately find a way around that. Copy the actual link address instead, not the visible link text.

For your convenience, I have updated the posting with a shortened URL that can be used as an alternative.
[Magisk] jenslody:
Just copy the link, not the content of the file it points to.
[Magisk] kantjer:
I won't do that, it's a 5 seconds job for a user to add the custom update-channel link.
[Magisk] guest4711:
Thanks again for the new build. Flashed without problems, now rebooting...

... without problems. ;)
[Magisk] martyfender:
I agree. Hold down on the link in your browser, choose copy from the popup menu. Then open mm, settings, custom channel, hold down there and wait for paste. to popup and choose it. Finally, hit ok to save it.

It. Took me much, much longer to type this than to copy and paste it. The url to paste is at the bottom of kantjer's github page:

https://raw.githubusercontent.com/kantjer/MagiskFiles/master/updates/kantjer.json
[Magisk] Tautvydas:
EDIT: Didgeridoohan solved it, thanks mate!
[Magisk] Dark-Coder:
Latest Versions Causing Bootloop on my Phone. is their any way to download older zip file ( before 02-06-2018)... ?!
[Magisk] kantjer:
No, my build script is set to only keep last 3 builds. This is done to prevent my disk filling up with old builds.

I will set that to keep last 5 builds for future builds.
[Magisk] ianmacd:
With the latest commit from yesterday, 20180614, it's working fine on both of my test devices here.

What device do you have?
[Magisk] kantjer:
I discovered I made a typo in my build script that broke the Magisk addon.d script.

This should be fixed in my next build.
[Magisk] pjrs2812:
I've search the thread for a possible answer to why I can't install the magisk manager apk. I assume I did something wrong but not sure what. Installed Magisk-v16.5-20180614-ianmacd.zip in TWRP and it appeared to install without any errors. I can see the the corrent directories and the magisk boot image in TWRP file manager. I also installed busybox.

Booted into the system and there was not Magisk manager installed. I tried to install the manager from the apk file but I get an error the the file is not installed. Root checker verified that buysybox was installed correctly but not root. Help. Thanks in advance.
[Magisk] buffal0b1ll:
I've gotten into this pickle before when switching Magisk versions. These steps may help.

Extract stock boot.img from ROM zip and have it handy.

Flash unsu zip https://xdaforums.com/apps/supersu/2014-09-02-supersu-v2-05-t2868133/post63615067

Flash stock boot.img

Flash unsu zip again (it can't hurt)

Boot device

Install 0614 MM ian apk

Reboot to recovery

Flash custom kernel (optional-not sure what device you're on our if you use one)

Flash Magisk 0614 ian zip

Boot system

Hope this helps.
[Magisk] ianmacd:
It's because your previous version of the Magisk Manager app was signed by someone else.

All you need to do is uninstall your existing app before installing mine. Superuser privileges should reappear immediately.
[Magisk] pjrs2812:
Thanks. I did not have any root installed at the time.
[Magisk] pjrs2812:
buffal0b1ll & ianmacd for your help

Still unable to install the magisk manager apk file. Strange since I have been able to installed Magisk beta's 16.3 & 16.4 thru TWRP on this Note 8 950F ex with the stock May Oreo firmware.

Is there some setting in the firware that needs to be enabled that I'm missing? Any further suggestions would be appreciated before I clean install the firmware.

Thanks
[Magisk] jenslody:
Have you been able to uninstall MagiskManager ?

Can you install othet apk's directly ?

On some roms you can not install from all locations via filemanager.

"adb install xxxx.apk" from a pc (with enabled adb debugging of course), usually works, assuming the old Manager is uninstalled.

You should also be able to install a Manager with different signing-key, if you hide (repackage) the Manager (from its settings).
[Magisk] Tecalote:
I had the same issue with your last Build.

I flashed it on Samsung S8+ newest Oreo FW

First time it worked, Magisk Manager was installed .

I had some (mind) trouble with OEM Unlock, but not because of your Build ( I am not familiar yet with Samsung - flashed TWRP, formatted data, flashed remove RMA and so an, flashed Custom Kernel and your Magisk Build - after I rebooted to system and OEM Unlock was disabled in Dev Settings and not possible to enable..)

I thought first it has something to do with Magisk (but it couldn't be, because phone wouldn't work at this state with OEM locked)

I flashed official Uninstaller (because you haven't own, right?)

After I flashed Kernel again and your Magisk Build - and it was successful, but Magisk Manager was not installed.

Sorry, I didn't make TWRP log.

It wasn't possible to install the apk from folder common. It aborted with the message: "Magisk Manager not installed"

I tried it after with official (16) and Beta Magisk (16.4) It was the same..

I found out that in download mode FRP and OEM wasn't locked, even the Dev Options showed OEM locked :)

I flashed with Odin the firmware again, did all steps for TWRP and Root again. This time everything was successful, but I used NX-R10 and Magisk 16.3 and didn't update to newest Manager.

Dev Options show again OEM Unlock disabled ( it's not really the case, because important is what Download Mode says) so it doesn't matter and it's perhaps better (because it can not be unintentionally disabled)

Edit: For the Magisk Manager issue - I should have uninstall your Magisk Manager apk before flashing Magisk Uninstaller?
[Magisk] pjrs2812:
Thanks for your interest in my install problems. I gave it another try after extracting the mm apk from a prior universal zip you had posted - 20180611. I was able to install the extracted apk without a problem. I flashed the universal zip in twrp with no errors and magisk root was installed.

Passing the safety net check with this version of magisk was hit or miss. I added the url for custom and installed the 20180614 manager and magisk. The safety net check is now passing more reliably with the updates. Is there some difference that I don't understand in the apk that I extracted and the mm apk file that I downloaded?

To jenslody - I could not install the initial mm apk that I downloaded and yes I can install other apks with file manger I use after giving it the correct permissions.

Thanks all again.
[Magisk] ianmacd:
When you switch from an APK with package name X, signed with key Y, to an APK with package name X, but signed with key Z, you will encounter an installation problem. This is true in the case of Magisk Manager, too, unless, as [MENTION=8340552]jenslody[/MENTION] states, you have opted to repackage the currently installed APK with a random package (via the app's own feature). It will also happen if you're trying to replace a copy of Magisk Manager that someone (usually a ROM builder) has seen fit to install under /system.

I bump the build number of Magisk Manager with every build I publish, so they should always install over the top of any previous build made by me, even when there are no actual code changes.

The separate Magisk Manager app I offer via my channel is identical to the copy packaged inside the Magisk ZIP file in every way except the file name. Once installed, the actual contents are identical. The only exception to this was my initial release, 20180610, where I accidentally packaged an unsigned copy of the APK inside the ZIP. The separate APK was signed. If you used that original ZIP file at any stage, that could explain the difficulty you ran into with later builds.
[Magisk] KaMyKaSii:
[MENTION=3306843]kantjer[/MENTION] and [MENTION=7187684]ianmacd[/MENTION], could you include the id of the last commit just after the build date? This will make it easier for users to identify which commits are present in the build and which ones are not yet. Thank you!
[Magisk] ianmacd:
The only problem with that is that the latest commit to my fork could be one that isn't in the upstream repo. In fact, that will technically always be the case, since my latest commit will always be either a merge from upstream, or an extra patch that doesn't exist upstream.

I suppose you would like me to always use the hash of the latest commit merged from upstream. Is that right?

EDIT:

Having thought about this some more, the basic options are the following:

$ git describe --tags master
v16.4-48-ge94d294

$ git describe --tags upstream/master
v16.4-40-g838f3cc

The first command describes the state of my fork, while the second describes [MENTION=4470081]topjohnwu[/MENTION]'s upstream.

The problem with the output of the first command is that it doesn't actually tell you whether my fork is ahead of anyone else's. Even if I had more commits than someone else since v16.4 was tagged , that doesn't necessarily mean that I am more up-to-date with upstream.

The problem with the output of the second command is that it ignores the fork used for the actual build, and so doesn't tell you how, if at all, it differs from upstream.

What would be more useful? I agree that something is desirable, since even daily snapshots aren't temporally fine-grained enough to imply what's in them.