yashsingh1/xdaforums huggingface dataset:
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] Thanks, that may help in the future. I had to jump a few hoops to get rootbeer sample, my only hidden app, not to detect root.

I added it in the terminal, verified it was showing up with the - - ls command, disabled, renabled magisk hide with the terminal, cleared the apps data, then rebooted and it was still detecting root. Eventually reverted to 20190228 to solve it.

One question, though, Is this the full command to move the Magisk directory:

# mv /data/adb /data/adb~

Or do I also need another location added to it as it appears to be the same location, all though I do see the tilde there, not sure what that means? I am not very adept at using linux commands.

To move it back, would I use this:

# mv /data/adb~ /data/adb

?

That did not work, but copying and pasting in Total Commander did, even though I got error that it could not copy, when it came to post-fs-data.d and service.d but it looked like they copied fine. I did all of this on a second device I reverted to 201902282. Never mind, I got magisk not installed again and flashing the uninstaller in TWRP had an error.

Also, [MENTION=4470081]topjohnwu[/MENTION] release a commit to fix the but I reported on github concerning MM crashing when accessing magiskhide tab. I not sure if it will work, considering the last few previous commit have caused issues for many of us, which for me was a bootloop.

Thanks
[Magisk] Tornado15550:
[MENTION=7187684]ianmacd[/MENTION] I figured out why Magisk Hide didn't seem to hide my app on the latest build. If I hide Google Play Services, Magisk Hide doesn't work, but safety net passes. If I don't have the Google Play Services system apps checked in Magisk Hide, it works well for the app that detects Magisk but safety net fails. Interesting phenomenon haha

So far I've just enabled Magisk Hide for the app that detects it and I'm letting safety net fail because I don't really have any app that relies on it.
[Magisk] ianmacd:
That's the whole command.

The tilde suffix is an idiom in the UNIX world, used by text editors when creating a back-up of an edited file. By association, it's also used as a suffix when temporarily moving things out of the way to preserve them, as was the case here. Windows can also be seen to use the tilde in the name of some temp files, although there it's a prefix, not a suffix.

You would, although if you did that after reinstalling Magisk, you would end up with the original directory in /data/adb/adb~, since /data/adb would have been recreated by Magisk, and so you would now be moving your directory under that path.

More likely, you would want to move only /data/adb~/modules/* back into place, to save you from having to reinstall all of your modules. You may have to do that in TWRP, though, depending on how Magisk treats /data/adb on a running system.

There's only one way to find out, isn't there? I've just verified 2019030701 as functional on my S9+ and pushed it to master.
[Magisk] martyfender:
Yes, I am updating mm now, downloading magisk and getting ready to flash it now in TWRP to test.

I forgot to mention, I am getting frequent bootloops after updating magisk, updating modules, etc. Rebooting the device and it will boot. Or even better, choosing shutdown in twrp, then starting up, seems to work better.

I just flashed your latest build and my device booted normally, for a change. In the boot process, now, as we speak, I get a message, unfortunately, Chrome has stopped. weird!

The Magiskhide tab is now accessible in mm. Everything seems to be working again.

Thanks, [MENTION=4470081]topjohnwu[/MENTION] and [MENTION=7187684]ianmacd[/MENTION] for this update!

I had one device, where the magisk module, Enable Doze for GMS was not working and Google Play Services was not showing as optimized in battery. Now it is working, as in the past. So it was not a module needing update, after all.

On the 2 out of three devices I have updated with your latest build, Google Chrome is popping up message, stating that it has stopped. It was just updated in the Playstore today, so this may not be Magisk related. However, the error never occurred until I updated Magisk. I may just be timing, as I just had updated it on the Playstore before updating Magisk.

On my third device that I updated Chrome, but have not yet updated Magisk, Chrome launched fine.

On the other devices, I reverted to the Chrome that came on the device in app settings, and it works fine.

I have tried several older version of chrome and the one that work now seems only to be the original that came on the device. This is strange that magisk would cause this. Also, Android System Webview beta, was updated today, not sure if that could be the reason.

This is minor to me, because I primarily use Firefox as my default web browser, because text actually enlarges in it, with settings, unlike Chrome. Chrome text is to small, even on my 8" tablets.
[Magisk] Dodgexander:
Direct install doesn't work for me. I always have to install in TWRP recovery.

Before using this channel (thanks [MENTION=7187684]ianmacd[/MENTION])! I didn't have this problem but I started to try the channel because I own a Chinese device (ZTE Axon 7) and couldn't use magisk before without reduced functionality(magisk hide didn't work) andi had to use a patched boot.img.

Here's the commit that allows magisk to work on various Chinese devices: https://github.com/topjohnwu/Magisk/commit/e72c6685edf81706617a3444575c4500b9b8fe6c

Is there something causing this?
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] In the last 2 unofficial [MENTION=7187684]ianmacd[/MENTION] builds, is anyone else getting an fc from Google Chrome, upon reboot and subsequent relaunches of Chrome? Reverting Chrome to the factory image, v50.2661.89 works. Logs attached.

Thanks
[Magisk] guest4711:
Works for me on Android 6, too. No issues with webview (using bromite flavour).
[Magisk] neekless:
People using builds that include the zygote ptracing codes (2019030702, 2019030701, 2019030602, 2019030601, and 2019030501), is your device performance negatively affected? On my Pixel 2XL boot up time significantly increased, apps take noticeably longer to open, phone is warmer and cpu usage is higher. Switched between a few ptrace builds and a build without, the difference is quite apparent for me.

Plus the ptrace magiskhide is less reliable for me. YMMV.
[Magisk] Ubimo:
Yesterdays and latest ianmcd build causes constant cpu load of about 20-30%.

S7 edge stock Oreo

Edit:

False alarm, the high cpu load is not related to magisk, I have to investigate further...
[Magisk] Tornado15550:
Can confirm all of the above symptoms mentioned on my Pixel 2 XL. The issues are resolved instantly by reverting to pre-ptracing builds.
[Magisk] ianmacd:
The ptrace(2) system call is expensive by its very nature, so this new approach to making Magiskhide robuster may not have much longevity in it.

I don't notice a longer boot on my own device (my other device boots infinitely), nor have I checked for increased CPU usage, but that doesn't mean I'm not affected. It's clear that this new detection mechanism is very heavily dependent on implementation details, so if there are performance issues to suffer as well, it may be no more attractive than the method it's intended to replace, and may end up being abandoned. We'll see.
[Magisk] asanford:
On the 2019030801 build and haven't been experiencing the slowdowns I was yesterday and so far CPU usage and battery drain seem normal.
[Magisk] martyfender:
Today's build fixed the issue I had with Chrome crashing on boot and on launching it. So far, I am not noticing any high cpu usage, but I will report back if I do, after hours of usage. Right now, my cpu usage is at 1% on two of my devices I have updated, so far, with no apps open, except System Monitor. Aida64 shows it fluctuating between 2-10%.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] After updating to your latest MM 18.2-2019030803 and relaunching it, it is set to the Canary Channel. When I go into settings and change it back, MM crashes. I then deleted its data and I was then able to set the channel back to ianmacd and download the 18.2-2019030803 magisk.zip and install it in TWRP.

I tried on a second and third device and it did the same thing on it.

After flashing the updated magisk.zip, so far it is working well. [MENTION=4470081]topjohnwu[/MENTION] I have still been randomly getting the bootloops on first boot and it randomly happens, usually on one of the three device, but it is not always the same device. This also happens randomly sometimes when there is a module update.

This has been happening randomly for the last 2 or 3 weeks. I don't remember how long ago it started.

At least 2 out of these 3 devices have had the magisk uninstaller run on them. I did not use your restore command on them but redownloaded modules and set them all up again.

I may have to put that boot script to log at boot back on them to narrow it down though. That is for another time as it is time to get ready for work.

It has also happened on devices with Canary on them, but not with today's Canary build.

Thanks
[Magisk] martyfender:
The channel issue is now fixed with 2019930804.

Thanks
[Magisk] Dodgexander:
So no-one else having issues with direct install not working?
[Magisk] HamsterHam:
Worked for me on my Crosshatch.
[Magisk] ianmacd:
John introduced two new channels today, one of which predictably yet unfortunately stole the integer value I was using for the ianmacd channel. That's why the app switched to that channel when you fired it up.

I wanted to stick as close to the official MM as possible, so I gave my channel a new number, rather than giving John's new channels a number. If I hadn't done that, anyone switching from Canary to the ianmacd channel would have experienced the same unwanted auto-selection of a different channel that you did, but in the other direction.

I realise now that I should have selected a much higher new value for my channel, so that even if John adds more channels in the future, the ianmacd channel will not be affected and this will remain a one-time issue. I may fix that this evening in a new build or perhaps tomorrow morning, so you will probably have to clear the data again,

A few other changes went in today that required modifications to my build system, but I think I caught them all. Let me know if anything's not working quite the way it should be.
[Magisk] HamsterHam:
[MENTION=7187684]ianmacd[/MENTION] - all good here on crosshatch. Just the standard gpay issue with 16.x play services. ??
[Magisk] Tornado15550:
It seems the performance issues were indeed caused by the zygote notifier. The latest build brings back the snappy performance from before.

[MENTION=7187684]ianmacd[/MENTION] even after resetting data on MM, while the default channel is ianmacd, selecting the ianmacd channel from the list of channels results in MM crashing.
[Magisk] martyfender:
Ian fixed it in 2019030804 build.
[Magisk] Tornado15550:
This occurs on 2019030804. Try selecting "ianmacd" channel even if your current channel is ianmacd and you'll notice the crash.
[Magisk] guest4711:
Really? Still crashing for me when I try to select Ian's channel. So I changed to custom channel and put https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json into it. Switching to the canary channels using the new selectors works fine. (I'm on 2019030804 build.)

Should I create/provide a matlog?
[Magisk] martyfender:
Yes, you are correct. I did not notice, because if you don't select anything, it is on Ian's channel by default. In that state no buttons are checked with a black dot. If you select ianmacd only, like you stated, it does crash.
[Magisk] guest4711:
The current build 2019030804 uses round about 40% of my cpu time - (my tab2 has two cores only running at 1GHz).
[Magisk] KaMyKaSii:
Out of curiosity, which app is this?
[Magisk] guest4711:
OS Monitor (Monitor the Operating System) - https://f-droid.org/app/com.eolwral.osmonitor
[Magisk] ianmacd:
There's a bug in the latest MM that causes a crash if the last channel in the list is selected. I've moved the ianmacd channel above the Canary channels in my latest build, so that it can now be safely selected.
[Magisk] bggold:
Also found that even on the latest build 2019030903 it FC'd going j to settings. I cleared app data and storage that fixed it. It was still looking at stable.
[Magisk] Tornado15550:
The latest build works perfectly!

Cheers!
[Magisk] bggold:
+1 had to go back to 18.1 for a couple days because it was so unpredictable. Not a single issue. [MENTION=7187684]ianmacd[/MENTION] thanks for the hard work.
[Magisk] neekless:
Hi Ian I think the last channel crashes is because your builds have 6 update channels but "value_array" here https://github.com/ianmacd/Magisk/blob/master/app/src/main/res/values/arrays.xml#L19 only has 5 elements. If you add one more element then you can safely have your channel last with int 99, correct me if I'm wrong.

<ListPreference
android:key="update_channel"
android:title="@string/settings_update_channel_title"
android:entries="@array/update_channel"
android:entryValues="@array/value_array" />
[Magisk] ianmacd:
No, that array also has 6 elements in the build. You saw only 5 in the repo at the time, because I hadn't yet synced the latest code to GitHub.

The bug lies elsewhere.
[Magisk] neekless:
I'm using your 2019030903 build. Selecting the last channel produces this crash log. Seems like an array issue somewhere.

time: 1552102093827
msg: java.lang.ArrayIndexOutOfBoundsException: length=5; index=5
stacktrace: java.lang.ArrayIndexOutOfBoundsException: length=5; index=5
at a.Ch.g(:2)
at a.Ih.onDismiss(:8)
at android.app.Dialog$ListenersHandler.handleMessage(Dialog.java:1393)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:193)
at android.app.ActivityThread.main(ActivityThread.java:6739)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:495)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:859)

Is the code in your repo the latest now? Because I still see only 5 elements.
[Magisk] martyfender:
[MENTION=7187684]ianmacd[/MENTION] I think you set a record in the recent builds you have done to fix bugs.

I want to thank you for your dedication, it is much appreciated.

I almost hate to report yet another bug with updating to 2019030903. When updating MM, it is defaulting to the Canary builds in settings, instead of ianmacd. On my first device I downloaded the Canary Magisk.zip, before realizing this. Fortunately I switched channels in mm settings and downloaded magisk 2019030903 before flashing.
[Magisk] bggold:
Clearing app data fixed that for me.
[Magisk] martyfender:
Thanks, it did for me when I did that after the fact, but ideally, we should not have to do that every time.

Thanks for every one's input on this and especially, I give thanks to [MENTION=4470081]topjohnwu[/MENTION] and [MENTION=7187684]ianmacd[/MENTION].

On my devices I am not experiencing high cpu usage, but I may reinstall OS monitor to test it on one of my devices.

With OS Monitor this device is showing 0.6-1.4% CPU used. When I allow root access in settings and show system processes, CPU jumps to 1.9-7.0%.

I think my My System Monitor app may paint a more accurate picture though, with it's graph, as I think OS Monitor may have a higher CPU utilization in root mode, overall. If I am wrong, any of you experts please clarify.
[Magisk] bggold:
You are correct on that. There must have been something from a previous build that was stored.

Checked mine again and the channel is still correct.
[Magisk] guest4711:
Crash is fixed in 2019030901.

Tab is snappy now again, but magiskd still consuming about 40% cpu (and no deep sleep anymore. CPU runs at full speed all the time).
[Magisk] ianmacd:
Thanks for the kind words. I do feel a responsibility to the people running the ianmacd builds.

That build of MM selected Canary on start-up because I had to reorder the damn channels yet again, to avoid mine being the last one and triggering the crash that currently occurs when the last channel in the list is selected. Sorry about that.

I've searched in vain to find that bug and I can't fire up MM under Android Studio, because John introduced a dependency in MM on a dev build of Android Studio, which I don't want to overwrite my stable release with. If John doesn't fix this bug soon, I might install the dev build of Android Studio separately and try to debug the crash there.

Once the bug is fixed, there will be one final renumbering of the channels to give ianmacd a much higher integer than the others, so that it will never need to be renumbered again.

UPDATE:

I'm an idiot. [MENTION=6014314]neekless[/MENTION] had edited his post above and already revealed the cause of the MM crash to me, but I didn't see that until I'd already found and fixed it on my own. It was I who introduced this bug, not John.

I will post a new build this afternoon.
[Magisk] stangri:
There was a problem with submodule updates in my build process (probably the reason why some of the more recent builds didn't work). I've (hopefully) resolved that and pushed the updated files which should work.
[Magisk] Artim_96:
Sure that's already with the last updates and but the second failed build?
[Magisk] jsaxon2:
It looks like [MENTION=2226076]stangri[/MENTION] has fixed his build so no need for mine, but yes, this has the latest updates from topjohnwu and installs.
[Magisk] HamsterHam:
Anyone had android pay stop working? I can open the app etc but fails when paying. First time it's happened today. Worked at lunch but evening failed. Safetynet passes.
[Magisk] Artim_96:
https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post71414823
[Magisk] HamsterHam:
Thought I'd post here as I'm running unofficial. I'm on angler so not that issue. I paid earlier in the day and it worked. So odd.
[Magisk] Artim_96:
This isn't really that much of a help forum, it's mostly for the beta builds and problems of they don't work. But in your case either discuss it in the main forum and say that you are on beta or open an issue in topjohnwu's GitHub
[Magisk] LPW00:
Actually not, as i talked about a newer build that was uploaded an hour before i wrote the previous comment, I'm not an idiot.
[Magisk] android_htc:
[MENTION=4476591]Deic[/MENTION] after installing the latest Magisk Manager Snapshot updater module the following "Complete action using" dialog box keeps appearing, see screenshot. Can you please fix this?

Thanks
[Magisk] Deic:
if you install 3.1.1, go back to 3.1.0-bg https://xdaforums.com/showpost.php?p=71358992&postcount=264

if I not post that version is for something.
[Magisk] ahrion:
Click the package installer
[Magisk] Deic:
[MENTION=3715141]android_htc[/MENTION]

Oh yeah, I'm a little zzz... I'm implementing that the install come when tap the notification for both package manager (silent install) and package installer (gui install) in next version.
[Magisk] ahrion:
I get a parsing error on one of my devices. I would assume it has to do with the apk
[Magisk] Deic:
was with silent install or gui one? attach updater.log please under module folder (/magisk/magisk-manager-snapshot-updater)
[Magisk] Deic:
Magisk Manager Snapshot Updater v3.1.1

changelog:

-added a separate file to install module update

-added backup log of previous boot

-changed module directories structure

-changed check/download url of module

-moved all secondary files to /data/magisk/magisk-manager-snapshot-updater (config, update, log)

This update hasn't got any important change for user experience, is only to prepare for 3.2.0, which has some nice changes.

if you have got some bug or something strange occurs, please post "updater.log" file found in "/data/magisk/magisk-manager-snapshot-updater/".

source code: https://github.com/DeicPro/magisk-manager-snapshot-updater
[Magisk] Deic:
Magisk Manager Snapshot Updater v3.2.0

changelog:

-added check installed magisk manager version directly from apk file by aapt binary, no more txt file with version saved in it (except in x86_64 SoCs)

-added wait to user to tap the notification to start download/install

-changed download function to show output in log if an error occurs only

-changed notification function to not replace every one to new notification and separate module and magisk manager notifications

-changed notifications of checks to show in first run only

-removed silent install (package manager) due many device have got problems with it

-removed toasts completely due is useless and anoying

-other changes

if you have got some bug or something strange occurs, please post "updater.log" file found in "/data/magisk/magisk-manager-snapshot-updater/".

source code: https://github.com/DeicPro/magisk-manager-snapshot-updater
[Magisk] storm119:
Hi,

Sound a bit silly and sorry if this been answer before....:D

Can i install the snapshots ontop of the official Magisk 11.1 and MagiskManager 4.2.6...or one need to uninstall the official first before install the snapshots build...?

TIA
[Magisk] Artim_96:
You can, but if you have problems, first try a reinstall
[Magisk] android_htc:
Working fine with v3.2.0, clicked package installer.

Also, what is the function of "read launcher DB" in Notify 4scripts?

Thanks
[Magisk] Deic:
on top of Magisk 11.1 yes

on top of Magisk Manager 4.26 no, because the installation fails due different sign (except if you have got a modified core.jar), you need uninstall it first.

It shows intents for all apps... just ignore the app if you don't need that info.
[Magisk] guest4711:
Edit: After disabling MagiskHide CPU load is gone (magiskd consumes less than 0.2%}. Re-enabling it does not increase it, but hiding works .. :good: Have to look after next reboot.

Rebooted with 2019030904. All seems to be fine now with hiding. Now trying 2019030905.

No crashes on selection of update channel. But labels and channels do not compare (perhaps I do need to wipe data of manager?)

Edit2: [MENTION=7187684]ianmacd[/MENTION] After wiping cache and data of MM MM crashes when opening its settings (even after granting storage access). 2019030905. Editing the preferences.xml and changing the channel# from 99 to 1 solved it. But still label in selector and real channel do not compare.
[Magisk] HamsterHam:
[MENTION=7187684]ianmacd[/MENTION] latest build, your channel in settings directs to canary builds. ??*♂️
[Magisk] ianmacd:
Yes, I discovered the misalignment too late, and it seems that non-sequential channel numbering has an unpredictable effect, too.

I will have a fix out for this as soon as I can get home and patch the code.

---------- Post added at 14:32 ---------- Previous post was at 13:48 ----------

Build 2019030908 pushed. There should be no misalignment between channel and content any more, and no crash when selecting the last channel in the list.

Apologies for the chaos today. I am pushed for time and tried to do too much in too short a period. I know better than to attempt this, and the result was a good reminder why.
[Magisk] guest4711:
2019030908 fixed it for me. Thanks for your hard work. Please no apologies, we are on bleeding edge and we know that no prog is perfect... And you are right: quid quid agis age bene and respice finem. So no hurry anymore.
[Magisk] neekless:
Hi Ian, thanks for the fixed builds. For curiousity's sake I installed 2019030905 to troubleshoot the int 99 channel numbering crash. This was the crash log:

time: 1552140268032
msg: java.lang.ArrayIndexOutOfBoundsException: length=6; index=99
stacktrace: java.lang.ArrayIndexOutOfBoundsException: length=6; index=99
at a.kt.b(Unknown Source:269)
...

It was the same array index out of bounds issue. So if you want to number your channel int 99 in the future, it seems you'll need to actually have 100 elements in value_array.