yashsingh1/xdaforums huggingface dataset:
[Magisk] kantjer:
Yes I saw that.

I have setup the config.prop and renamed my key to release-key.jks but when running "python3.6 ./build.py binary" it errors out with the this

If you have any idea how to fix that on my side I would be very grateful.

PS, I also tried python 3.5, same error
[Magisk] Didgeridoohan:
Sorry... I know nothing about building, unfortunately. I know [MENTION=4470081]topjohnwu[/MENTION] has tested building after that commit though, so it should be possible.

Edit: [MENTION=8340552]jenslody[/MENTION] You have any insight?
[Magisk] jenslody:
I'm at work at the moment. I will have a look later.
[Magisk] topjohnwu:
I'm still in the military base but I'll reply real quick. I bet you are using an incompatible NDK version.

The building is only tested on the *latest* stable NDK (which is r17 as of writing) and NDK r10e. I always make sure Magisk is buildable on the latest NDK version for future proofing, but personally I build things with r10e. I would recommend all unofficial builders to also build with r10e for the same result as release builds from me.

You can specify a custom NDK path to point to r10e, check out README.md on GitHub.

I have tried to support as many versions as possible, but for some reason Google cannot provide consistent libc and headers throughout the revisions. The issue mainly happens when building BusyBox because it uses a wide range of system calls, and each NDK version ships with a different libc binary which covers a different range of system call wrappers, and it will conflict with the implementation manually added because they are missing in previous NDK versions.

I added #ifdef guards in all places so it can build on both r10e and r17, but it is too trivial to support any versions in between.
[Magisk] kantjer:
Thanks, afaik I'm still using r16 I wasn't aware r17 was out already. I will give that a try. For some reason building with r10e never worked for me.

EDIT: NDK r17 fixed the error, thanks again.
[Magisk] martyfender:
Did you have trouble compiling, after that?
[Magisk] kantjer:
The build is fine now (running yesterday build without any issues)

I only need to make some changes to my build script to accommodate the new build related commits.

EDIT: Since I needed to change my build script I used the opportunity to also change the build versioning as discussed last week.

From now on I will no longer use the official version number/build-date but I now use build date only.

As part of my build script every build starts with a repo sync, so my builds will always have all the latest commits. Official version numbers are not relevant for these unofficial builds IMO.
[Magisk] edzamber:
Working perfectly on S6 Edge g925f with my oxn kernel and Rom base 6ERC1 :good:
[Magisk] Renovatio_ edi:
Did you lose root somehow??

Wysłane z mojego SM-N950F przy użyciu Tapatalka
[Magisk] laupuy:
Please, can you post English screenshot, I don't understand French :silly:

Hello Ed :D

:p

Thanks kantjer for last build :good:
[Magisk] hshah:
I'm on the latest build now and still losing root not long after booting :confused:
[Magisk] Didgeridoohan:
Could you supply the magisk_debug.log from after you lose root (in /data/adb, grab from recovery)?

And after that, could you try running your device without MagiskHide enabled for a while? I have a slight suspicion it's caused by MagiskHide sometimes failing to remount folders after hiding itself, but need some help to confirm from those that experience the issue.
[Magisk] hshah:
Log attached. I am pretty sure it is down to Magisk Hide as well but I need to have it enabled for certain applications otherwise they will permanently disable themselves and I will have to jump through hoops at work to get it all back :(
[Magisk] oreo27:
Edit - The latest build is working okay on my device. The uninstaller however is throwing an Error 1 in TWRP.

So I was knee deep in some work to get my startup's website re-launched and I wasn't able to check XDA.

Looks like the changes [MENTION=4470081]topjohnwu[/MENTION] implemented in the build system caused the build error I was encountering earlier. I've always used R10E to build Magisk.

I've since added the required config.prop to the Travis workflow and it seems to be working again. I have the latest commit here:

It's under a new repository too. I'm opting out of a Custom Update URL because I believe snapshot builds are best flashed in recovery coming from a dirty flash of the boot.img.

https://github.com/0reo27/Travis-CI-Magisk-Builder/releases

Which is based on the latest commit:

https://github.com/topjohnwu/Magisk/commit/bcdadc65819925dec1a0768b8252bcf49ccd8853
[Magisk] hshah:
I've been going through the logs I attached before and to be honest I don't actually know what I'm looking for. Sometimes my root stays for 10+ hours, other times it's gone as soon as I turn the phone on. Its not really consistent and I can't work out what the differences could be :eek:
[Magisk] martyfender:
I don't know if this will solve the error 1 on your case, but I have seen that error also, recently, when flashing zips. On the zips I flashed, I solved it by mounting the system first in TWRP. I'm curious if that will work for your uninstaller.zip?
[Magisk] Renovatio_ edi:
Losing root........ some can fix that issue

Wysłane z mojego SM-N950F przy użyciu Tapatalka
[Magisk] oreo27:
That's something I can certainly try when the next commits come out. For now, it's working nicely on my device. I am still using the latest stable Magisk Manager, not the one that I built.
[Magisk] hshah:
Ok to this is a puzzle for everyone... I've been having issues with losing root so have uninstalled through the app, rebooted, wiped caches and rebooted again.

There should be no trace of Magisk at this point.

I've then flashed the version linked to a few threads up, but when I opened the app after booting it said Magisk wasn't installed and therefore I had next to no options available.

I have the Bixby key on my Note 8 set to take screenshots (set with BxActions) on a double press and without thinking I did that. It took the screenshot and had a toast saying BxActions has been granted root.

Given that I had uninstalled it and haven't actually reconfigured it since I reflashed Magisk, everything should be as their defaults. BxActions shouldn't have root, and if for some reason it could su, it should come up with a notification. None of other that I have which use root say root is available and Magisk Manager still claims its not installed.

Attached a few screenshots to show this. I can only assume that the uninstall didn't properly work because every app should be asking for root from scratch. More importantly why does BxActions have root but nothing else does?

[MENTION=4470081]topjohnwu[/MENTION]
[Magisk] kantjer:
If you want to remove every trace of Magisk remove /system/addon.d/99-magisk.sh and dirty flash your ROM.

That should wipe everything
[Magisk] hshah:
I'm going to try that now, but I'm still curious about how BxActions is getting root? Apologies in advance if I'm just being dense here.

BxActions seems to get root when nothing else can. It also seems to know it previous had root, and uninstalling via the app should have removed all trace.

Logically that makes no sense, unless something has messed up and settings files are still lurking. There is no other way BxActions can get root other than that, especially since the Manager can't, and it may explain why its all screwing up. I'm hoping that it makes someone who knows far more about this than me, think and figure out wtf is going on.

/Edit: Shouldn't uninstalling via the app wipe everything? I thought that that was the recommended method?
[Magisk] Didgeridoohan:
There haven't been any commits to Magisk since v10.2, right? Not really necessary to build a version "11" beta when it's the same as current stable release...
[Magisk] BolintsMiki:
There have been, but only to MagiskManager yet.
[Magisk] Didgeridoohan:
Yes, I know there's been a whole bunch of commits to the Manager. But, I'm talking about Magisk. Magisk and the Magisk Manager are seperate...
[Magisk] BolintsMiki:
But, you know, development is gonna start soon on that, too. I'm waiting for the dual boot myself. :)
[Magisk] Didgeridoohan:
I love going on github once in a while and see what's been added. :) Can't wait for that commit counter for Magisk go past 92...
[Magisk] stangri:
Thanks for posting this and letting people who (like me) don't track commits know that Magisk reflash is not necessary. As you probably know Magisk is very inexpensive to build comparing to Magisk Manager.
[Magisk] BolintsMiki:
Hi, [MENTION=2226076]stangri[/MENTION]

The build of MagiskManager is working fine, but it seems to require a new build of the phh SuperUser too.

At least the commits here ( https://github.com/topjohnwu/Superuser ) seem to suggest so, and I can't find the SuperUser settings in MagiskManager with the current official phh SuperUser. Could you build the Superuser, too?

Thanks!

Also thanks for being awesome and checking this thread often :)
[Magisk] stangri:
Thanks for testing and posting your feedback!

If you mean the boot-image modifying flashable part of Superuser -- the https://github.com/topjohnwu/Superuser/ (with the latest commit done 28 days ago) is a submodule of the Magisk and it is linked to a specific tree/commit. The results of mix'n'match could be so unpredictable that I don't want to do that.

If you mean the Superuser app, I could look into building it sometime later in the week, but I was under impression that PHH posts the early builds himself.
[Magisk] BolintsMiki:
I was talking about topjohnwu's fork of Superuser. If you look at my attachment, he has commits, that change Superuser from interacting with the Superuser app to interacting with MagiskManager.

(At least that's what I think those commits are, but my programming knowledge is rather limited.)

Also: links:

Commits overview: https://github.com/topjohnwu/Superuser/commits/master

The mentioned commit #1: https://github.com/topjohnwu/Superuser/commit/b8a4e7e50e0c2add6e26386db346434ceeccdad5

The mentioned commit #2: https://github.com/topjohnwu/Superuser/commit/105192ed4a6fc31709581e63a820578570121b6b
[Magisk] stangri:
You're right, I don't know where I was looking at.

Anyways, here's the deal. With the submodules linked as is, the Magisk builds but doesn't include some newest features (I'm guessing towards full integration of superuser management into Magisk app). If I update all submodules, the build chokes on selinux and breaks.

Attached is the magisk built with only one submodule (jni/su) updated to include latest commits.

I'm not responsible if it ruins your bootloader! If you don't want to take a risk, maybe wait until [MENTION=4470081]topjohnwu[/MENTION] pushes all his updates/submodule updates to master.

PS. With the latest commit to Magisk Manager, the build also breaks. Unfortunately I do not have the time to investigate if it's something in the commit or my SDK/NDK settings or me using CLI instead of Studio GUI.
[Magisk] BolintsMiki:
Thanks, will try later today (Central European Time) :)

I'm also thinking about learning to build things from source, but I'm far from it now. I have only been programming C++ with IDEs so far...
[Magisk] Deic:
I didn't get superuser integration with this, all seems the same.
[Magisk] stangri:
Thanks for reporting! I have limited time to look into it this week and I'm not the most qualified person for building, but I'll see what I can dig up.

If you're on Mac/Linux, the build.sh script I use is posted on github, just make sure to have stuido/ndk set up and in the $PATH.
[Magisk] BolintsMiki:
OMG, It did work!

But, in order to make it work, I had to force it to install phh's superuser.

Steps to do it:

0. Boot into your recovery of choice

1. Flash Mount-Magisk to mount your magisk.img

2. Copy all of the folders from there to somewhere else with Aroma File Manager

3. Reboot to unmount /magisk

4. Uninstall Magisk

5. Install the mentioned Magisk v11 with the new root

6. Flash Mount-Magisk again

7. Copy the folders you copied in step 2. back into /magisk with the exception of .core and phh

8. Reboot

See the UI in my attachments
[Magisk] BolintsMiki:
After testing, I am happy to report that all of my root apps work well. Root access times are similar to phh's root.

Also, Magisk Hide is working as well. SafetyNet checks out!
[Magisk] Deic:
Modified zip to force reinstall new su attached.

Only flash, no more steps.
[Magisk] biggdevon:
What phone and rom?

What phone and rom?
[Magisk] biggdevon:
Apologize for the double post. If I'm currently running v10.2 can I just dirty flash v11 over v10 or should I flash the uninstaller and start fresh?
[Magisk] Doctor Zoidberg:
anyone have a Magisk Manager apk the new for v11 ?
[Magisk] BolintsMiki:
I'm on OxygenOS Community Beta 11 on my OnePlus3.

Stock, unmodified /system, only Magisk is installed.

My Magisk is the latest build by stangri with a lot of modules (see attachments) and a modded magisk.img that is 512 MB instead of 64 MB.

EDIT: Just checked, the February 3. version does break Magisk Hide.

Also in the Screenshot the phh Supeuser is present, but after a reboot it was removed.
[Magisk] jenslody:
except the stuff in data (if uninstalling did not work), like /data/adb/magisk*, /data/stock:boot*, but the boot-image should be clean and therefore magisk is not running (if your rom does not provide an own su binary).

You can also try [MENTION=4544860]osm0sis[/MENTION]' unSU-script .
[Magisk] hshah:
Just flashed unSU and no screenshots are being taken with the Bixby key. In fact it's not doing anything at all, but given the ROM has options for the button and I was using BxActions to do what I wanted, I'm assuming that that is probably normal.

They key thing is that BxActions is not getting root and providing the functionality.

Interestingly, the phone feels faster. I've not wiped any caches etc... since my last post where Magisk was installed but only BxActions could get root, all I've done was flash unSU.

Not sure if it's justified but I'm now suspicious of BxActions because it's the only app I have which uses root that actually picked up root and worked. I won't remove it just yet because it would be good to see if I continue to lose root after reflashing Magisk.

By the way, I'm only posting this because I'm a technical person and I'm thinking that what I've seen may help. I don't have the knowledge to explain any of it or to determine if it's of any relevance (aka if I'm talking ****) so please let me know if I should stop posting etc.
[Magisk] hshah:
Out of habit I opened Titanium and usually when I've lost root is tells me so immediately... after flashing unSU and dirty flashing the ROM (sorry forgot to mention that previously) which hopefully removed all root, it now hangs on this view.

Is that normal or does it imply something is still lurking?
[Magisk] hshah:
Did it all over again, flashed Magisk and more or less lost root within minutes.

Noticed this in the logs though:

Internal Error
java.io.IOException: Cannot run program "su": error=13, Permission denied
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1048)
at java.lang.Runtime.exec(Runtime.java:692)
at java.lang.Runtime.exec(Runtime.java:560)
at com.topjohnwu.superuser.internal.ShellImpl.<init>(ShellImpl.java:59)
at com.topjohnwu.superuser.internal.Factory.createShell(Factory.java:28)
at com.topjohnwu.superuser.Shell.newInstance(Shell.java:316)
at com.topjohnwu.superuser.Shell.getShell(Shell.java:246)
at com.topjohnwu.superuser.Shell.rootAccess(Shell.java:366)
at com.topjohnwu.superuser.io.SuFile.<init>(SuFile.java:114)
at com.topjohnwu.magisk.utils.Const.<clinit>(Const.java:30)
at com.topjohnwu.magisk.database.MagiskDatabaseHelper.openDatabase(MagiskDatabaseHelper.java:67)
at com.topjohnwu.magisk.database.MagiskDatabaseHelper.<init>(MagiskDatabaseHelper.java:54)
at com.topjohnwu.magisk.database.MagiskDatabaseHelper.getInstance(MagiskDatabaseHelper.java:44)
at com.topjohnwu.magisk.MagiskManager.onCreate(MagiskManager.java:135)
at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1125)
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6058)
at android.app.ActivityThread.-wrap1(Unknown Source:0)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1764)
at android.os.Handler.dispatchMessage(Handler.java:105)
at android.os.Looper.loop(Looper.java:164)
at android.app.ActivityThread.main(ActivityThread.java:6940)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:327)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1374)
Caused by: java.io.IOException: error=13, Permission denied
at java.lang.UNIXProcess.forkAndExec(Native Method)
at java.lang.UNIXProcess.<init>(UNIXProcess.java:133)
at java.lang.ProcessImpl.start(ProcessImpl.java:128)
at java.lang.ProcessBuilder.start(ProcessBuilder.java:1029)
... 23 more

magisk -v

sh: <stdin>[5]: magisk: not found
[Magisk] hshah:
Tried changing the WebView to Chrome Beta and saw this.

Calling it a day for now lol!
[Magisk] Didgeridoohan:
[MENTION=271749]hshah[/MENTION] I've also noted an issue with uninstalling Magisk from the Manager with the current code. Investigation ongoing...
[Magisk] kantjer:
I made some further changes to the versioning of my builds.

To avoid any confusion between my snapshot builds and the official builds by [MENTION=4470081]topjohnwu[/MENTION] I now use "unofficial-build_date" as version.
[Magisk] hshah:
Did it all over again and had root for about 30 seconds:

05-22 11:13:42.615 3212 3212 I Magisk : ** Initializing Magisk
05-22 11:13:42.759 3212 3212 I Magisk : * Creating /sbin overlay
05-22 11:13:42.760 3212 3212 I Magisk : * Mounting mirrors
05-22 11:13:42.760 3212 3212 I Magisk : mount: /sbin/.core/mirror/system <- /dev/block/platform/11120000.ufs/by-name/SYSTEM
05-22 11:13:42.760 3212 3212 I Magisk : link: /sbin/.core/mirror/vendor <- /sbin/.core/mirror/system/vendor
05-22 11:13:42.761 3212 3212 I Magisk : bind_mount: /sbin/.core/mirror/bin <- /data/adb/magisk
05-22 11:13:42.761 3212 3212 I Magisk : * Setting up internal busybox
05-22 11:13:42.845 3218 3218 I Magisk : Magisk v16.5-bcdadc6(1650) daemon started
05-22 11:13:42.847 3218 3226 I Magisk : ** post-fs-data mode running
05-22 11:13:42.848 3218 3226 I Magisk : * Mounting /data/adb/magisk.img
05-22 11:13:42.987 3218 3226 I Magisk : * Running post-fs-data.d scripts
05-22 11:13:42.987 3218 3226 I Magisk : * Running module post-fs-data scripts
05-22 11:13:42.987 3218 3226 I Magisk : * Loading modules
05-22 11:13:42.988 3218 3249 I Magisk : * Starting MagiskHide
05-22 11:13:42.988 3218 3249 I Magisk : hide_utils: Hiding sensitive props
05-22 11:13:42.988 3218 3249 I Magisk : hide_list: [com.google.android.gms.unstable]
05-22 11:13:42.999 3218 3249 I Magisk : proc_monitor: init ns=mnt:[4026531840]
05-22 11:13:43.336 3218 3360 I Magisk : ** late_start service mode running
05-22 11:13:44.062 3218 3360 I Magisk : * Running service.d scripts
05-22 11:13:44.062 3218 3360 I Magisk : * Running module service scripts
05-22 11:13:45.214 3218 3249 I Magisk : proc_monitor: zygote ns=mnt:[4026533594] zygote64 ns=mnt:[4026533596]
05-22 11:14:07.431 3218 3249 I Magisk : proc_monitor: com.google.android.gms.unstable (PID=6604 ns=mnt:[4026533789])
05-22 11:14:15.717 3218 7174 E Magisk : sqlite3 open failure: unable to open database file
[Magisk] hshah:
So, everything was fine with MagiskHide disabled and when enabled it, it lost root after a while. However, I am write confused again because it has only gone for some applications.

Titanium and Root Explorer can't get root. MagiskManager has been open, so I can still view everything in there but if I was to close it then it would think root was not present.

Terminal Emulator however can get root, and I have attached the logs to show all this.

What commands can I run to possibly bring this back to life?

/Edit: I tried "magisk --daemon" and it showed no errors in the terminal (just returned me back to the prompt) but in MagiskManager Logs, I see:

read failed with 0: Success

No idea what failed and success at the same time could mean lol! :)
[Magisk] Didgeridoohan:
[MENTION=271749]hshah[/MENTION] It's a known issue, and [MENTION=4470081]topjohnwu[/MENTION] will look into it when he's got the time.
[Magisk] hshah:
I swear that I had seen somewhere that people wanted logs / information from people who were having this issue, and that's why I have been posted.

If its all covered then, it's all good :)
[Magisk] Didgeridoohan:
Yeah, no worries. I've been asking in several places for info from users with this issue, and you've provided some. Now I think we'll just have to wait until [MENTION=4470081]topjohnwu[/MENTION] has the time to look into it closer.
[Magisk] kantjer:
For those interested in building Magisk, or just want to know what I'm doing :D

This my current build script, I tried to make it foolproof.

BTW next build will be with NDK r10e (like official builds)
[Magisk] jenslody:
If you do so, please test the wget applet of the internal busybox, it will most likely not work.

The next official build will use a higher revision of NDK, probably r17, because some busybox applets (at least wget) are currently broken (at least on internal test-version):

wget: socket(AF_INET,1,0): Address family not supported by protocol
[Magisk] kantjer:
Thanks, I moved the NDK version to a variable in the build script so it's easy to change it.
[Magisk] martyfender:
Does this only apply to Magisk's internal BusyBox and not to the ones installed as modules, for the system, such as Osmosis's or YDS's?

I also see that BusyBox has been updated to 1.28.4 stable at busybox.net.
[Magisk] jenslody:
It's only the internal busybox, but some moduls rely on it, because it's the only one guaranteed to be available.
[Magisk] hshah:
I've been tinkering since my previous posts and every time I lose root for all applications, it never seems to apply to Terminal Emulator. So if that can su is there something I can run to restore root?
[Magisk] martyfender:
[MENTION=3306843]kantjer[/MENTION] Anxiously anticipating the next build, from the weekends commits, like a kid in a candy store.

Thanks
[Magisk] JEANRIVERA:
Kantjer build has a different signature than topjohnwu build if you trying to install over it it just won't work, you'll have to uninstall current app and then install kantjer build, either way the zip should be enough if flashed on recovery it should overwrite current installed version...
[Magisk] kantjer:
There indeed seems to be an issue with the lastest APK.

I will have to check my build script
[Magisk] JEANRIVERA:
ups, sorry I guess that could be an option too..... :silly:
[Magisk] jenslody:
It will not overwrite the app, just the magisk-files.

But to install it, if you switch from official to unofficial or vice versa, you can just hide the installed version and then install the new one, it will be used and the repackaged version gets removed.

So you do not lose any of your settings.

If you first remove the app, su-database and magiskhide-list, etc will be kept anyway, but some of the minor settings, like update-channel, theme, etc will be lost.
[Magisk] kantjer:
I didn't change the key to sing the apk and I can't install the MM.apk

---------- Post added at 11:47 ---------- Previous post was at 11:36 ----------

I'm getting this log after building, any ideas?

63 actionable tasks: 61 executed, 2 up-to-date
Traceback (most recent call last):
File "./build.py", line 475, in <module>
args.func(args)
File "./build.py", line 208, in build_apk
sign_apk(unsigned, release)
File "./build.py", line 185, in sign_apk
apksigner, config['keyStorePass'], config['keyAlias'], config['keyPass'], target), shell=True)
KeyError: 'keyAlias'

I tried both NDK r10e and r17, same log with both.

APK won't install
[Magisk] jenslody:
I am not at home, so can not test, but I think you have to update the config.prop (if it exists), see: https://github.com/topjohnwu/Magisk/commit/ef2f8d485b936ca429b889e48ffda7be655b600b or if this does not work, try to revert the commit for the moment.

I have no time to investigate the purpose of this commit at the moment (at work).