yashsingh1/xdaforums huggingface dataset:
[Sony Cross-Device General] munjeni:
Just use nougat and everything from sonyxperiadev instruction page, its kernel 1.3.3 which is very good, extract things from mynougat.rar to android tree, build kernel with script buildkernel.sh (you will need some path modification to it), and the rest like mentioned...
[Sony Cross-Device General] munjeni:
#define MIN_UNDEQUEUED_BUFFERS 1 // This is required if preview window is not set

This probably can be increased to 2
[Sony Cross-Device General] munjeni:
I have libthermalclient.so and libthermalioctl.so from stock rom from first day worked with stock kernel, you can use these two libs from stock 14.6.A.1.236 rom!
[Sony Cross-Device General] munjeni:
Anybody have librmnetctl.so ??

Edit:

PRODUCT_PLATFORM definition missing! We have missing whole sony/common and whole qcom opensource because of that!!!!

We have SOMC_PLATFORM definition instead and to build things needs to define PRODUCT_PLATFORM!
[Sony Cross-Device General] munjeni:
This is soo strange:

u32 msm_camera_io_r_mb(void __iomem *addr)
{
uint32_t data;
rmb();
data = readl_relaxed(addr);
rmb();
CDBG("%s: 0x%pK %08x\n", __func__, (addr), (data));
return data;
}

dmesg:

amami:/ # dmesg | grep cam | grep err
[ 23.322856] msm_camera_io_r_mb: 0xpK-error 01000000
[ 23.322859] msm_camera_io_w_mb: 0xpK-error 01000000
[ 23.322864] msm_camera_io_w_mb: 0xpK-error 00000001
[ 23.322868] msm_camera_io_w_mb: 0xpK-error 00000000
[ 23.323235] msm_camera_io_r_mb: 0xpK-error 00000001
[ 23.323240] msm_camera_io_w_mb: 0xpK-error 00000001
[ 23.323244] msm_camera_io_w_mb: 0xpK-error 00000001
[ 23.323248] msm_camera_io_w_mb: 0xpK-error 00000000
[ 23.534977] msm_camera_io_r_mb: 0xpK-error 01000000
[ 23.534981] msm_camera_io_w_mb: 0xpK-error 01000000
[ 23.534985] msm_camera_io_w_mb: 0xpK-error 00000001
[ 23.534989] msm_camera_io_w_mb: 0xpK-error 00000000
[ 23.535388] msm_camera_io_r_mb: 0xpK-error 00001000
[ 23.535393] msm_camera_io_w_mb: 0xpK-error 00001000
[ 23.535397] msm_camera_io_w_mb: 0xpK-error 00000001
[ 23.535401] msm_camera_io_w_mb: 0xpK-error 00000000
[ 23.671438] msm_camera_io_r: 0xpK-error 00000800
[ 23.671446] msm_camera_io_w: 0xpK-error 00000800
[ 23.673061] msm_camera_io_r: 0xpK-error 00000800
[ 23.673067] msm_camera_io_w: 0xpK-error 00000800
[ 23.756365] msm_camera_io_r: 0xpK-error 80000000
[ 23.756367] msm_camera_io_r: 0xpK-error 00000000
[ 23.756369] msm_camera_io_w: 0xpK-error 80000000
[ 23.756371] msm_camera_io_w: 0xpK-error 00000000

Wrong __iomem *addr ??? wth :eek:
[Sony Cross-Device General] munjeni:
Finaly aosp 7.1.0 done, camera patched kernel started working, green half screen present :( , but got full kernel camera hal log, lets analyse https://paste.ubuntu.com/23360965/ (vfe1 buffer error is noticeable on line 22) and many more, better view now on kernel log, hope [MENTION=359497]jerpelea[/MENTION] give help on this. One good thing from aosp 7.1.0 is torch no more disapears from togles :)

Complete kernel patch which I'm using on 1.3.3 is in attachment (enabled cam loging is included in patch), android camera hal + display hal is the same which I'm using (LA.BR.1.3.6_rb1.6) you can download from some pages back if you need...

One more thing... does 1.2.2 uses msm_vfe40 or msm_vfe34 ???
[Sony Cross-Device General] aquaboy11:
Are these errors by using the stock librmnetctl.so? Also, is using logcat and dmesg + grepping "camera" the right way to get useful logs? Right now I am on 7.1.0_r4 with the newest CAF camera HAL, but the split view is still there.
[Sony Cross-Device General] munjeni:
Grepping just camera is not a right way for example if you going to locate problem since some messages between camera and other important things will be hidden. About libnetctl please read all my posts above this post, please do not read only last one. Libnetctl.so is missing because is not built from vendor/qcom/opensource/dataservice because PRODUCT_PLATFORM deinition missing... see post 183. Log from post 184 and 185 is kernel log (enabled all logging on camera)
[Sony Cross-Device General] tomascus:
Well if anything needed it, wouldn't compilation just fail in the first place...?
[Sony Cross-Device General] munjeni:
Can't fail since on 1.3.3 these struct is not implemented. I think in case when we enable dualcam property things, camera working good, right? Only which I thinking by now is we have missing right padding! Probably implementing that structure from 1.2.2 kernel to 1.3.3 kernel probably we can get working camera, I don't know for sure but just thinking :)
[Sony Cross-Device General] munjeni:
I have overwrote 1.3.3 vpe and cpp with 1.2.2 and this is diferencie for reference https://paste.ubuntu.com/23363846/

Edit:

On first look I can see its on 1.3.3 defined in dtbs

-	CPP_DT_READ_U32_ERR(fw_info_node, key, "qcom,stripe-base", ret,
-	payload_params->stripe_base);
-	CPP_DT_READ_U32_ERR(fw_info_node, key, "qcom,plane-base", ret,
-	payload_params->plane_base);
-	CPP_DT_READ_U32_ERR(fw_info_node, key, "qcom,stripe-size", ret,
-	payload_params->stripe_size);
-	CPP_DT_READ_U32_ERR(fw_info_node, key, "qcom,plane-size", ret,
-	payload_params->plane_size);
-	CPP_DT_READ_U32_ERR(fw_info_node, key, "qcom,fe-ptr-off", ret,
-	payload_params->rd_pntr_off);
-	CPP_DT_READ_U32_ERR(fw_info_node, key, "qcom,we-ptr-off", ret,
-	payload_params->wr_0_pntr_off);

maybe we can check that way. First which we need to do is to extract this info from 1.2.2 (cpp_dev->fw_version) and use that for reference
[Sony Cross-Device General] munjeni:
This payload info (qcom,cpp-fw-payload-info) in arch/arm/boot/dts/qcom/msm8974-camera.dtsi need to be modified and I am prety sure if we do that right way we can get camera:

qcom,cpp-fw-payload-info {
qcom,stripe-base = <130>;
qcom,plane-base = <115>;
qcom,stripe-size = <27>;
qcom,plane-size = <5>;
qcom,fe-ptr-off = <5>;
qcom,we-ptr-off = <11>;
};

by looking in https://paste.ubuntu.com/23363846/ (at start of line 239) we need info from 1.2.2 about cpp_dev->fw_version, than harcode payload info
[Sony Cross-Device General] munjeni:
Info extracted :D

amami:/ # dmesg | grep "CPP FW VERSION"
[ 22.566913] CPP FW VERSION = 10020000
[ 27.198898] CPP FW VERSION = 10020000
[ 38.418075] CPP FW VERSION = 10020000
[ 38.774843] CPP FW VERSION = 10020000
[ 88.832663] CPP FW VERSION = 10020000
[ 89.187115] CPP FW VERSION = 10020000
[ 93.636911] CPP FW VERSION = 10020000
amami:/ #

#define STRIPE_BASE_FW_1_2_0	130

#define MSM_CPP_INVALID_OFFSET	0x00000000

On 1.2.2 cpp firmware is CPP_FW_VERSION_1_2_0

so we need:

+	if ((cpp_dev->fw_version & 0xffff0000) ==
+	CPP_FW_VERSION_1_2_0) {
+	cpp_dev->stripe_base = STRIPE_BASE_FW_1_2_0;
+	cpp_dev->stripe_info_offset = 12;
+	cpp_dev->stripe_size = 27;
+	cpp_dev->rd_pntr = 5;
+	cpp_dev->wr_0_pntr = 11;
+	cpp_dev->wr_1_pntr = 12;
+	cpp_dev->wr_2_pntr = 13;
+	cpp_dev->wr_3_pntr = 14;
+	cpp_dev->rd_ref_pntr = MSM_CPP_INVALID_OFFSET;
+	cpp_dev->wr_ref_pntr = MSM_CPP_INVALID_OFFSET;
+	cpp_dev->wr_0_meta_data_wr_pntr = MSM_CPP_INVALID_OFFSET;
+	cpp_dev->wr_1_meta_data_wr_pntr = MSM_CPP_INVALID_OFFSET;
+	cpp_dev->wr_2_meta_data_wr_pntr = MSM_CPP_INVALID_OFFSET;
+	cpp_dev->wr_3_meta_data_wr_pntr = MSM_CPP_INVALID_OFFSET;
+	}

Which is diferent than 1.3.3:

qcom,cpp-fw-payload-info {
qcom,stripe-base = <130>;
qcom,plane-base = <115>;
qcom,stripe-size = <27>;
qcom,plane-size = <5>;
qcom,fe-ptr-off = <5>;
qcom,we-ptr-off = <11>;
};

Lets fix stupid cam
[Sony Cross-Device General] munjeni:
This shuld be:

cpp_dev->stripe_base = STRIPE_BASE_FW_1_2_0; [COLOR="DarkOliveGreen"]qcom,stripe-base = <130>;[/COLOR]

cpp_dev->stripe_info_offset = 12; [COLOR="Red"]defined in CONFIG_COMPAT but we have no enabled CONFIG_COMPAT[/COLOR]

cpp_dev->stripe_size = 27; [COLOR="DarkOliveGreen"]qcom,stripe-size = <27>;[/COLOR]

cpp_dev->rd_pntr = 5; [COLOR="DarkOliveGreen"]qcom,fe-ptr-off = <5>;[/COLOR]

cpp_dev->wr_0_pntr = 11; [COLOR="DarkOliveGreen"]qcom,we-ptr-off = <11>;[/COLOR]

cpp_dev->wr_1_pntr = 12; [COLOR="DarkOliveGreen"]defined in msm_cpp.c as a wr_0_pntr_off + 1;[/COLOR]

cpp_dev->wr_2_pntr = 13; [COLOR="DarkOliveGreen"]defined in msm_cpp.c as a wr_1_pntr_off + 1;[/COLOR]

cpp_dev->wr_3_pntr = 14; [COLOR="DarkOliveGreen"]defined in msm_cpp.c as a wr_2_pntr_off + 1;[/COLOR]

cpp_dev->rd_ref_pntr = MSM_CPP_INVALID_OFFSET; [COLOR="DarkOliveGreen"]qcom,ref-fe-ptr-off = <0>;[/COLOR]

cpp_dev->wr_ref_pntr = MSM_CPP_INVALID_OFFSET; [COLOR="DarkOliveGreen"]qcom,ref-we-ptr-off = <0>;[/COLOR]

cpp_dev->wr_0_meta_data_wr_pntr = MSM_CPP_INVALID_OFFSET; [COLOR="DarkOliveGreen"]qcom,we-meta-ptr-off = <0>;[/COLOR]

cpp_dev->wr_1_meta_data_wr_pntr = MSM_CPP_INVALID_OFFSET; [COLOR="Red"]cant be defined right since wr_1_meta_data_wr_pntr_off = (wr_0_meta_data_wr_pntr_off + 1);[/COLOR]

cpp_dev->wr_2_meta_data_wr_pntr = MSM_CPP_INVALID_OFFSET; [COLOR="Red"]cant be defined right since wr_2_meta_data_wr_pntr_off = (wr_1_meta_data_wr_pntr_off + 1);[/COLOR]

cpp_dev->wr_3_meta_data_wr_pntr = MSM_CPP_INVALID_OFFSET; [COLOR="Red"]cant be defined right since wr_3_meta_data_wr_pntr_off = (wr_2_meta_data_wr_pntr_off + 1);[/COLOR]

Things should be:

qcom,cpp-fw-payload-info {
qcom,stripe-base = <130>;
qcom,plane-base = <[COLOR="Red"]???[/COLOR]>;
qcom,stripe-size = <27>;
qcom,plane-size = <[COLOR="Red"]???[/COLOR]>;
qcom,fe-ptr-off = <5>;
qcom,we-ptr-off = <11>;
qcom,ref-fe-ptr-off = <0>;
qcom,ref-we-ptr-off = <0>;
qcom,we-meta-ptr-off = <0>;
qcom,set-group-buffer-len = <[COLOR="Red"]???[/COLOR]>;
qcom,dup-frame-indicator-off = <[COLOR="Red"]???[/COLOR]>;
};

Have no idea how to get <???>
[Sony Cross-Device General] aquaboy11:
We could leave qcom,set-group-buffer-len and qcom,dup-frame-indicator-off out as they're optional. First we need to focus on the correct values for plane-base (Base offset of planes in CPP payload) and plane-size (Size of each plane in payload) first.

EDIT: using 115 for plane-base and 5 for plane-size, my front cam is now upside-down with green on the left. Back camera is still the same, preview split in 3, taken picture split in 2, but it is focusing properly.
[Sony Cross-Device General] munjeni:
I will try to use whole cpp/msm_cpp.c from 1.2.2 , see diferencie between 1.22 and 1.33 cpp/msm_cpp.c !
[Sony Cross-Device General] jerpelea:
imx200 uses dual vfe on msm8974

imx132 uses single vfe
[Sony Cross-Device General] jerpelea:
dual camera refers to dual camera modules on the back

fual vfe refers to 2 vfe used for the same camera
[Sony Cross-Device General] jerpelea:
8974 does not use pinctrl

tgat lib is missing and should be missing
[Sony Cross-Device General] munjeni:
persist.camera.dual.camera if I am not wrong refers to dual VFE?
[Sony Cross-Device General] jerpelea:
since we have 1 dual vfe camera and 1 single vfe it is not posible to set the property unless you want to crash the camera
[Sony Cross-Device General] aquaboy11:
[MENTION=4120742]munjeni[/MENTION] are you sure the problem lies in the camera post processing (cpp)?
[Sony Cross-Device General] munjeni:
But it not crash it, it working better when that property is enabled, don't know why. Focus and things starting to work corectly when it is enabled

Edit:

you are right, it crashes camera when I switch to front cam!
[Sony Cross-Device General] tomascus:
The camera HAL is open source, you can read what it does in there, Jerpelea already linked it in a previous post... Unfortunately I'll be busy til late November so I can't do much to help you out.
[Sony Cross-Device General] munjeni:
I'm not sure

Edit:

Now I am sure its not. Used cpp from 1.2.2 and the same half green screen exist

Edit:

I think problem is probably a blobs! Definitelly I will not mess anymore with 1.3.3, going back to working 1.2.2 sorry! Apsolutly have no idea whats wrong with camera. Probably 1.3.3 branch is not a right branch for rhine platform + blobs too. Final decision... good luck!
[Sony Cross-Device General] aquaboy11:
I do not think it is the blobs, as 1.2.2 is working fine. Unless there are some things incompatible with the current camera branch, but that could probably be fixed by adjusting/reverting some stuff.
[Sony Cross-Device General] munjeni:
1.2.2 blobs and 1.3.3 blobs is diferent in vendor/qcom , but in vendor/sony blobs is the same. I realy don't know if big or small changes is done in blobs in vendor/qcom but as we can see it not working even with 1.2.2 kernel, even not working on android M! Significant changes is done on 1.3.3 kernel hal in comparation to 1.2.2 kernel hal! I no want to waste time anymore with 1.3.3, I'm unable to fix it, wasted 15 days allready and finaly confused and disapointed with it. I am from now on 1.2.2 since camera is working on N using 1.2.2!
[Sony Cross-Device General] SuperLamic:
so you want to fix random reboots on 1.2.2 instead (while playing videos)? Both branches have it's own problems...
[Sony Cross-Device General] munjeni:
I'm using 1.3.6 rb 1.6 as a display hal and I noticed fly in videos and display in booth branches! Never got any single reboot!

Edit:

At least we can implement back only camera and vidc from 1.2.2 to 1.3.3
[Sony Cross-Device General] SuperLamic:
When I was using mm with 1.2.2 there were some random reboots while watching YT for some time, while calls and so on... It was really annoying and I remember kholk saying that 1.3.3 branch is ok.

Some iommu problems as I recall.
[Sony Cross-Device General] munjeni:
I will build test build asop 7.1.0 for amami, let see :)
[Sony Cross-Device General] SuperLamic:
Is this a fix to camera? https://github.com/sonyxperiadev/kernel/pull/932
[Sony Cross-Device General] munjeni:
WTH is going on with youtube, testing things whole day and it finaly worked with patch, now after clean install yt started again with black screen on rotate, f**k
[Sony Cross-Device General] brickhayabusa:
[MENTION=4120742]munjeni[/MENTION]

so, there are no random reboots, in place of this ¿is only a black screen?

you tested with open and close the camera app 2 or 3 times?
[Sony Cross-Device General] munjeni:
Camera working after 3 times opening and closing, no problem at all, sometimes it crashes for example if I change resolution and some parameters e.g. zoom...etc, its not stable but can take picture and video on default parameters. Yes, black screen happend after 5 seccinds when yt is rotated horizontaly and when rotate vertical black screen disapears. I fixed it by using whole media from 1.3.3 and needed changes in dtbs, it worked for hour, I finaly thinked that I fixed that so made clean build in order to post test build for amami, somehow I tried build to be sure it working but it not worked corectly, the same thing happened on yt :(. Also whole day in the same time tried to implement 1.2.2 kernel camera hal to 1.3.3 kernel without luck, need proper changes in dtbs which I am unable to colect, have problems related to clocks on ispis and isp
[Sony Cross-Device General] Myself5:
Thats actually something I would be intrested in too. Have you had a stable camera (opening without any can't connect to camera crashes, ignoring the half screen only thing.) on 1.3.3 and Nougat? If yes, how did you archieve it? Would be cool if you could share that, as it would help a lot of kitakami and loire Nougat users :P

TIA
[Sony Cross-Device General] munjeni:
I have posted display and camera hal some pages back, it was based on rb 1.6, yes its somehow smoother than one from msm8994, you need to build kernel inline and export headers (use makekernel.sh script for booth)
[Sony Cross-Device General] :
While definitely camera related, I'm afraid that commit is for a completely irrelevant matter ;)

Anyway, back on subject:
[MENTION=4120742]munjeni[/MENTION] it's great that you're describing what you're doing so that other people can try and do on their own, but it would be really great if you uploaded some commits so that everyone can see what you're doing.

I for one can't replicate what you're doing because i don't have a rhine nor a shinano device available for testing, but would still like to see if i can help/learn from what you're doing, at least by looking over the code :D
[Sony Cross-Device General] brickhayabusa:
so, you don't have the "can't conect to camera" problem? :o
[Sony Cross-Device General] munjeni:
No. Camera crashes only when I take picture with zoom or when I change resolution! On default parameters its ok but somehow dark, need to use manual exposure 2 to get things ok, in general it takes satisfied picture on default parameters. Only which I noticed is camera takes too long on first start, have no idea why its happening. I found that array of resolutions is wrong, probably other parameters too? Maybe we can setup fixed camera parameters in hal? When I somehow get 1.2.2 camera kernel hal working in 1.3.3 kernel I will look into 1.2.2 android camera hal, will try to implement exposure property which already exist in rb 1.6 hal so we can set exposure to 2 by default... going now to compare camera dtbs
[Sony Cross-Device General] munjeni:
What might be wrong with this?

10-24 17:14:25.858 518 518 D mm-camera-intf: index = 0 flag = 1 mount_angle = 90 facing = 0
10-24 17:14:25.858 518 518 D mm-camera-intf: index = 1 flag = 101 mount_angle = 90 facing = 1
10-24 17:14:25.858 518 518 I CameraService: Loaded "QCamera Module" camera module
10-24 17:14:25.859 518 518 I CameraFlashlight: Opening camera 0
10-24 17:14:25.862 518 518 I QCamera2HWI: [KPI Perf] int qcamera::QCamera2HardwareInterface::openCamera(hw_device_t**): E PROFILE_OPEN_CAMERA camera id 0
10-24 17:14:25.863 518 806 D QCameraStateMachine: static void* qcamera::QCameraStateMachine::smEvtProcRoutine(void*): E
[COLOR="Red"]10-24 17:14:25.867 536 536 E mm-camera: iface_discover_subdev_nodes: no ispif/isp subdev found!!! error rc = -1[/COLOR]
10-24 17:14:25.867 536 536 E mm-camera: module_iface_init: cannot create iface
10-24 17:14:25.867 536 536 E mm-camera-isp2: isp_resource_gen_hws_caps:3591 failed: num_of_isp 0
10-24 17:14:25.867 536 536 E mm-camera-isp2: isp_resource_init:3661 failed: isp_resource_gen_hws_caps
10-24 17:14:25.867 536 536 E mm-camera-isp2: module_isp_init:661 failed: isp_util_gen_hws_caps
10-24 17:14:25.867 536 536 E mm-camera-isp2: module_isp_init:682 failed: module_isp_init
[Sony Cross-Device General] masterofnocrack:
I think the dark images are due to the camera being stuck at an ultra low ISO. MM has the same issue and camera lag. Whats interesting is that I can recreate almost the same dark image and camera lag on CM12.1 using low ISO values!
[Sony Cross-Device General] munjeni:
New error integrating 1.2.2 kernel cam hal to 1.3.3:

10-24 20:23:38.859 528 528 I CameraService: Loaded "QCamera Module" camera module
10-24 20:23:38.859 528 528 I CameraFlashlight: Opening camera 0
10-24 20:23:38.860 528 808 D QCameraStateMachine: static void* qcamera::QCameraStateMachine::smEvtProcRoutine(void*): E
10-24 20:23:38.863 528 528 I QCamera2HWI: [KPI Perf] int qcamera::QCamera2HardwareInterface::openCamera(hw_device_t**): E PROFILE_OPEN_CAMERA camera id 0
10-24 20:23:38.870 528 809 D QCamera2HWI: static void* qcamera::QCamera2HardwareInterface::defferedWorkRoutine(void*): start data proc
10-24 20:23:38.875 542 542 E mm-camera-isp2: isp_resource_get_isp_id:3526 cannot open '/dev/v4l-subdev11'
10-24 20:23:38.875 542 542 E mm-camera-isp2: isp_resource_gen_hws_caps:3603 failed: subdev name /dev/v4l-subdev11 sd_num 0 [COLOR="Red"] invalid isp_id 2[/COLOR]

What might be a problem with "invalid isp_id 2" ??
[Sony Cross-Device General] drakonizer:
[MENTION=4120742]munjeni[/MENTION] What HAL did you use to get the cam to work using the 1.2.2 kernel? 1.3.6 or 1.2.2 from sonyxperiadev sources? Did the kernel need to be patched? (I saw your patch a few posts back, but I ran into a few compilation errors after I applied it)
[Sony Cross-Device General] brickhayabusa:
[MENTION=5258151]drakonizer[/MENTION] probably because he use the z1 compact?

i don't know much about that.
[Sony Cross-Device General] munjeni:
You need blobs SW_binaries_for_Xperia_AOSP_M_v05a.zip + camera hal from sonyxperiadev 1.2.2 branch + kernel 1.2.2 using my patch (patch is some pages back) + display hals from rb 1.6 (also you have these files some pages back)! In any way I will pack everything you need tommorow!
[Sony Cross-Device General] Luncer:
Deleted....
[Sony Cross-Device General] munjeni:
hey sorry, I forgot to save txt file which I using for copy paste for boot image make, somehow I used 1.2.2 kernel instead of 1.3.3, thats a reson why I have got camera now, 1.3.3 kernel with 1.2.2 cam not working, sorry! :(
[Sony Cross-Device General] davidteri91:
munjeni on CM14 I am using aligned display and media HAL CAF ... but still ... same problem
[Sony Cross-Device General] erikcas:
lol... On what track are you anyway? Looks like a giant blob-lottery to me, with a copy-paste-cameradriver-from-1.2.2-to-a-random-kernel-tag as a bonus.

Do you have a plan to stick with?
[Sony Cross-Device General] davidteri91:
let me quote you
[Sony Cross-Device General] munjeni:
I copy paste 1.2.2 whole kernel cam hal to 1.3.3, there is no other way, and whole day analysed dtbs, done some things, but problem with:

10-24 21:50:36.966 516 516 E mm-camera-isp2: isp_resource_get_isp_id:3526 cannot open '/dev/v4l-subdev11'
10-24 21:50:36.966 516 516 E mm-camera-isp2: isp_resource_gen_hws_caps:3603 failed: subdev name /dev/v4l-subdev11 sd_num 0 [COLOR="Red"]invalid isp_id 2[/COLOR]

If you thinks you can do that better fill free to continue my work in attachment :good: Everything working except isp and ispif, cam takes parameters and initialise modules but without isp android cam crashes, I have no idea what mean invalid isp id 2
[Sony Cross-Device General] davidteri91:
you can't copy kernel driver from 1.2.2 to 1.3.3 .... you will break 8952 camera man ..... you need play under the same rules as we did for make it partially working on 8974
[Sony Cross-Device General] munjeni:
I have plan to make camera 1.2.2 separate in new folder in case if I get camera working, thats a plan! Priority now is getting 1.2.2 kernel cam working on 1.3.3 kernel since 1.2.2 kernel is sh...y
[Sony Cross-Device General] erikcas:
copying and pasting drivers between kerneltags is not my favorite thing, so I will leave that fun to you.

Last time I did that, I almost blew up my device by modifying underlying i2c, ioctl etc crap.

ofc blew up is an overstatement
[Sony Cross-Device General] davidteri91:
as a start can you please tell me ... which blobs have you been mixed from 1.2.2 to 1.3.3? is just for know ..... because some parameters were moved to dts
[Sony Cross-Device General] munjeni:
android blobs? Or kernel things?
[Sony Cross-Device General] davidteri91:
as I said .. you are saying good bye loire .. on you patch .... also remove clocks from dts seems not a good idea .... and also removing whole CAM-SMMU is crazy

-#define VFE40_8952_VERSION 0x10060000

-#define VFE40_8976_VERSION 0x10050000
[Sony Cross-Device General] erikcas:
oh, oppo did that for their camera stack before.

Also remember, you most probably need a bunch of 1.2.2 headers too to get it to work with the hal.

Mixing the headers might imo also the beginnen of the end (been on that road before with xperia M2)
[Sony Cross-Device General] munjeni:
Thats just camera mate, I didn't touch i2c and things! only some dtbs related to camera and 3 kenel headers also related to camera
[Sony Cross-Device General] munjeni:
Whole things will be revert back in case camera start working! It will be moved to new folder and things related to 8952 and the rest will be in if-else statement. Help me first to fix 1.2.2 cam on 1.3.3
[Sony Cross-Device General] erikcas:
In my case, it was just camera....