yashsingh1/xdaforums huggingface dataset:
[Galaxy S 4 i9505 Original Android Development] Rhoban:
"Unroot" does not mean "disable from developer options". That Only turns it OFF, but the files are still present.

"Unroot" means DELETING those root files.

To add SafetyNet support to this ROM would mean to remove root from it completely. And I'm pretty sure most of this ROM's users don't care about passing SafetyNet.

Also, hiding root is possible (on this ROM too) . I did it, others did it.

There's no need to add support to this ROM when there are methods out there that allow you to hide it.

As I said, SafetyNet detects root. So the only way to make this ROM (or any other custom ROM) support it is either to hide root or to completely remove the root files. Both methods can be done by yourself.
[Galaxy S 4 i9505 Original Android Development] Buff99:
Best suggestion ever.

Rom needs to be renamed this.

Super Siderman OS
[Galaxy S 4 i9505 Original Android Development] dhaern:
I think Safetynet is more advanced than only detecting root and typical hide root solutions are not working. I will try new Magisk v11 and MagiskSU.

I only say if [MENTION=5968293]side[/MENTION] could change old SuperSU root method for new MagiskSU by default because it's more advanced and better and it's the same for all users and have more features.
[Galaxy S 4 i9505 Original Android Development] markiarom:
Didn't test it, but i assume with this setting's change you simply raise minimum brightness level, which isn't a solution. I can however set a very low brightness with screen dimmer which apply an overlay but doesn't have auto regolation..
[Galaxy S 4 i9505 Original Android Development] xell75:
Never had any problems with Safetynet myself, seems like because I don't use apps that relies on it.
[Galaxy S 4 i9505 Original Android Development] xmicroman:
Thanks you maybe on to something! Only answer before was Max brightness. If this works it needs it's own thread IMHO
[Galaxy S 4 i9505 Original Android Development] xmicroman:
Works so far for me sorry if this is a double post. Thought I posted before but can't find it
[Galaxy S 4 i9505 Original Android Development] HectorAguirre:
I experience the same behavior in my i337
[Galaxy S 4 i9505 Original Android Development] Undefined Origin:
Same thing here on my i377. Very slight delay from the lock screen, but noticeable for answering a call.

Also, a small issue with Blur home screen. If you have a music player (only tested with Amazon) that has lock screen visuals, using the lock screen controls for play/pause etc will remove the Blur and make any background app fully visible
[Galaxy S 4 i9505 Original Android Development] Rhoban:
As I said, one month ago I was able to pass SafetyNet and play Pokemon on this ROM. But the game sucks so I deleted it, therefore I do not know if there was an update to it that renders those root hide methods useless.

Also, phh root - or MagiskSU as you call it - is not more advanced. I've used it and, judging from the app, it's pretty basic. It also had a few problems with some apps like STweaks (not root access).

You say you would like it changed, but what if 1000 other people don't want it changed?

In my opinion, it is unnecessary to change root solutions for just one or two people.

One is able to pass SafetyNet on CM/Lineage ROMs, all you have to do is use the right method. Magisk works, and so do some others, so no need to change anything. There's a Magisk thread and a Pokémon Magisk thread if that's what you want. You have everything you need to make it work.
[Galaxy S 4 i9505 Original Android Development] dhaern:
Sorry but safetynet is not a dumb root detection only, it's much more advanced and well designed system. You can check this blog here:

koz.io/inside-safetynet

Finally I installed a few hours ago new Magisk v11.1 and it's much better than SuperSU, new version improved a lot and I dont have bugs with permissions or another things. Now safetynet test pass but CTS mismatch always fails even with Optimized Lineageos 14.1 fresh install and fully unroot without SuperSU/MagiskSU installed with stock kernel or alucard kernel. Test not only check root as I said before, it's much more advanced detection.

I hope [MENTION=5968293]side[/MENTION] give me a response about this but I think it's not possible pass the test with this ROM atm. Sorry but I dont believe you passed full test with this ROM. Maybe you could play earlier Pokemon Go versions but pass the full test no.
[Galaxy S 4 i9505 Original Android Development] Rhoban:
Why do you need to pass full test anyway? As long as you can use the apps that have SafetyNet system, there's no need for a full pass.

And it's impossible to make SafetyNet fully pass in some cases. First, it may require the selinux to be permissive. This isn't hard to do.

Second, some say that you also need a locked bootloader. Now that's more complicated, because locking a bootloader basically makes your phone harder to hack (root and install a custom recovery). And locking a bootloader can only be done by the manufacturer.

And I told you in my previous post that I played Pokémon Go last month! (2 weeks ago actually).

So that means that it was the most recent version of the game and the most recent SafetyNet version. Unless they updated them in those two weeks, which I doubt.

I've been able to pass SafetyNet and play the game without any problems. And I've been doing this for months.

I don't understand why you insist so much on this when I have clearly said that it's possible to hide root. They won't send the FBI and CIA after you if you happen to fail one of the verifications, don't worry.

Also, this thing to make the ROM pass SafetyNet by default is just a hack, an exploit. If Google updates SafetyNet, this exploit/hack will become useless until there's another one. So why would side waste time on this when there are more important issues to be fixed?
[Galaxy S 4 i9505 Original Android Development] dhaern:
I cant use any app that check root without the full test passed, I need CTS mismatch passed too, it's only 3 things to pass but I failed in the CTS mismatch with MagiskSU or fully unroot (with SuperSU fails at all). An example is IRCTC Official app from Google play or Android Pay. the selinux is not the problem now with new Magisk v11.1 because they add Pseudo enforcing selinux in new version:

I want to know if CTS mismatch could be passed with this ROM or not but I need [MENTION=5968293]side[/MENTION] response I think.

EDIT: I dont play Pokemon GO but I tried installing the app and cant register an account in game (authentication failed) because this Safetynet fail... I cant understand as you play the game with this ROM guys, I tried unroot also and dont work.
[Galaxy S 4 i9505 Original Android Development] elv1503:
Maybe you're asking too much. Its a custom ROM. Take it or leave it.
[Galaxy S 4 i9505 Original Android Development] Rhoban:
As I said, I heard talks about SafetyNet failing if your bootloader is unlocked.

And since most phones in the S4 family have an unlocked bootloader, SafetyNet would fail no matter what you do. And there's no way to lock the bootloader yourself.

One could use an exploit to make SafetyNet believe the bootloader is locked even though it isn't, but how long will that work?

Google constantly updates SafetyNet and all those exploits will become useless. And, at some point, SafetyNet will be impossible to bypass.

There is no method that works 100% or forever. And different devices have different needs.

Some devices can't pass SafetyNet even with Magisk. So it is not clear if what you're suggesting would even work on this device.

Also, people on the Magisk discussion thread say that Android Pay is working with the latest version!

So obviously you're doing something wrong. Maybe you should do more reading.

And here's some reasons why you probably couldn't log into Pokémon:

1) Maybe Magisk can't successfully hide selinux mode, so that means you'd have to set it to enforcing manually just to make sure.

2) USB debugging is on. USB debugging also affects SafetyNet. If it's on, it will fail.
[Galaxy S 4 i9505 Original Android Development] xell75:
Am I the only one who never had problems with Safetynet? Me personally never used Magisk and I don't wanna use another app than SuperSU. (Never had any problems with that apps I use) I mean Magisk should just be added to Aroma Installer and not a complete replace of SuperSU. Cause not all people need or want to use Magisk.
[Galaxy S 4 i9505 Original Android Development] akk29:
I'm on AOSP but can confirm that the latest Magisk doesn't successfully hide SELinux mode / use pseudoenforcing mode. I have set a script to run at boot to set SElinux to enforcing and I can pass safetynet using Magisk 11.1 and Magisk Manager 4.1.

The Magisk release thread contains information for ROM developers regarding SELinux pseudoenforcing but this is [MENTION=2743644]Sides[/MENTION] ROM so we have to respect the his choices in superuser management.
[Galaxy S 4 i9505 Original Android Development] walttheboss:
It seems to me that if we get dual booting working then people can have a stock Rom when they need it for safetynet and optimized for the rest. The dual boot patcher app seems very promising.

I can't test anything as I am on a Korean S4 till my new screen arrives.
[Galaxy S 4 i9505 Original Android Development] MaxFire913:
that's the point ,, i guess that the new software auto regulation isn't somehow compitable with the HW of the screen .. so it does that FLICKERING .. I red a post that disabling HW Overlays in DEVELOPER OPTION helps .. n it did but not for so long as it turns off by itself every reboot ..

any way .. the whole thing isn't about a permanent solution .. it more an OVERCOME to this problem ..

i rarely see that FLICKERING now ,, lower the brightness at night and that's what matters ;)
[Galaxy S 4 i9505 Original Android Development] markiarom:
I can't go lower than half, so no dim at all
[Galaxy S 4 i9505 Original Android Development] MaxFire913:
did u try lux ?!
[Galaxy S 4 i9505 Original Android Development] dhaern:
It would be very good idea, [MENTION=5968293]side[/MENTION] could add MagiskSU/Magisk to AROMA installer. I hope he can read this and add Magisk to AROMA in future releases. I will try today again another tricks and I will test with Pokemon Go app, I have USB debugging on, I will try turning off the option.
[Galaxy S 4 i9505 Original Android Development] markiarom:
Will try ;)

EDIT.

Nope, it flicker..
[Galaxy S 4 i9505 Original Android Development] elv1503:
I agree.
[Galaxy S 4 i9505 Original Android Development] Jimbus369:
+1
[Galaxy S 4 i9505 Original Android Development] verlorenintranslation:
Some bugs I’ve detected when testing Beta 4 over the past 2-3 weeks

Hi everyone!!

I'm new in XDA, although I've been following and recommending my friends this website for quite a while. I have to say in the first place that I'm quite happy and thankful to all the people behind this project (LineageOS). This ROM is working awesomely well and does really optimise performance in my S4 device.

I've been using this ROM since the Beta 2 update was released, which obviously had a few bugs, which have been fixed over the Beta 3 and 4 updates. Now, I have Beta 4 update since the very first day it came out and I must admit this ROM is almost perfect! The very few bugs that I've experienced so far over the past 2 and a half weeks are basically due to battery issues.

Of course, my two genuine Samsung batteries are a bit old now but they haven't ever behaved as weird as they do lately. Their performance has decreased so much that my phone experiences "sudden death" every now and then when battery percentage is under 50% ish (which hadn't ever happened to me before). On top of that, there are a few apps like the Google Clock which don't work (the classic "Unfortunately this App has stopped working").

I think I've found a pattern that might be related to the "sudden deaths". When battery percentage is under 50% and I run an App that requires a significant amount of RAM (like Google Maps or Snapchat/WhatsApp/HDR camera Apps), my phone dies instantly. Also, when it's under 15%, it sometimes dies without even running a "heavy" App, just by using the device normally (and it never lets me awake it again til battery is charged again). There are sometimes also problems when my phone is plugged to charger and I want to use it simultaneously, since it sometimes starts working slowly or freezes and battery percentage doesn’t go up (in this case I usually have to restart my device).

These battery issues are quite annoying, to be honest, since you never know when your device can bail out and let you down, plus it makes the battery life shorter. I'm aware that this ROM is still at a Beta version, so I'm not criticising it, but just reporting bugs that could be fixed for further versions. I'd also like to suggest that the Wi-Fi hotspot function gets a bit more polished, so that you can actually see who is connected to your network (IP, name, device, etc.) and kick them out whenever you want, just like in the Samsung Touchwitz based ROMs.

Thank you again and all the best for the developing of this HUGE ROM! - I also apologise for any English mistakes made in this post; I'm a Spanish native speaker (from Spain).

Greetings,

José Ángel
[Galaxy S 4 i9505 Original Android Development] sjamie:
Not to crush your hopes but [MENTION=5968293]side[/MENTION] has no interest in adding Magisk/Safetynet exploits to the ROM at this time.

That would be cool! :good:
[Galaxy S 4 i9505 Original Android Development] dhaern:
Well I'm fine with this but at least add Magisk/MagiskSU to Aroma installer would be a good idea, Privacy Guard is in Aroma installer.... why not MagiskSU too??

EDIT: Finally I passed the full Safetynet test disabling ADB interface in developer options with Magisk 11.1 and Magisk Hide/MagiskSU enabled without SuperSU, I tested Pokemon Go app and now i can login, nice!

[MENTION=5968293]side[/MENTION] add Magisk to AROMA installer plz. New MagiskSU is very good. Thanks guys for the info.
[Galaxy S 4 i9505 Original Android Development] handyflo:
I have this Bootloader and Modem installed:

I9505XXUHPK2

maybe hardware issue as mentioned here:

https://www.androidpit.de/forum/716057/samsung-galaxy-s4-s4-erkennt-nur-die-neue-sim-karte-nicht

anyone with the same issue?
[Galaxy S 4 i9505 Original Android Development] side:
Root ways/methods will stay as they are guys...

the advanced root methods etc cant be added to roms just because there are 1-2 people who use em.

sorry for that :/ .i wish u do understand the situation
[Galaxy S 4 i9505 Original Android Development] dhaern:
I understand this but it's only add another option to AROMA installer, I think new Magisk version deserve it, it's an amazing root method now. I hope you can reconsider in the future but I'm fine if you dont want add it. Check yourself if you want please:

https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445

https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445/post70897029#post70897029
[Galaxy S 4 i9505 Original Android Development] elv1503:
You doth protest too much..!!!
[Galaxy S 4 i9505 Original Android Development] Sogli:
Delete
[Galaxy S 4 i9505 Original Android Development] JerwinSayat:
You can always add it if you want, even side doesnt?
[Galaxy S 4 i9505 Original Android Development] dhaern:
Yes, I modified updater-script and aroma-config and I added MagiskSU to AROMA options. Installer is working with Magisk now, I wasted 10min only editing these files for add Magisk to AROMA... When [MENTION=5968293]side[/MENTION] upload a new version I can upload a modified file with Magisk AROMA support if you want test this guys.
[Galaxy S 4 i9505 Original Android Development] Buff99:
Without trying to sound too dicky, why should people trust root files that you've inserted?

If i download magisk files myself I can check the md5sum.

I trust side's work as he has a history here and publishes his source for everything on github.

Who are you?
[Galaxy S 4 i9505 Original Android Development] sjamie:
The next build of this ROM is going to epic. I can feel it! :D
[Galaxy S 4 i9505 Original Android Development] FeelsTuturu:
Odds crashing when using Fire Emblem Heroes

Hey,

I've been playing Fire Emblem Heroes for a bit, and I've noticed that when that app is in the background for a few seconds, let's say 30 seconds, it freezes the phone, and ends up rebooting. I am not sure if it's due to the rom or my model (SGH-M919), but I have tried both version of the rom (december and january) and they always have the same problem. (I even did a full wipe and everything!)

My question is to ask if you guys are experiencing that too, or it it's just me. It's Really annoying because when you try to login with the browser, it freezes before you can react, unless you are already logged in

If you need some kind of crash log to know what's the problem, let me know how and i'll upload it as soon as I can!
[Galaxy S 4 i9505 Original Android Development] Rhoban:
I told you that it is possible that hide root and pass SafetyNet.

Privacy Guard is in AROMA because it is the default root for CM/Lineage ROMs. And even if people choose to install SuperSU, the ROM will still have the CM root files included. In other words, it will have both root methods.

Whether AROMA installs Magisk or you do it yourself, it's the same result. You would still have to go through the process of deleting the CM root files manually.

Also, I've said before that some apps (Stweaks, Titanium Backup) had problems with phh root. MagiskSU is based on phh, so it's probably gonna have those problems too and the thread will be filled with people reporting "no root" issues unnecessarily.

You may feel like everybody here is against you, but the truth is that you're the only one requesting Magisk to be integrated into the ROM, so the better option would be to just leave it as is.

I said it once and I will say it again, whether you install it or AROMA does, in the end it will be the same result and probably will take the same amount of time. The only difference is that installing manually requires more implication from the user.
[Galaxy S 4 i9505 Original Android Development] akk29:
The version of STweaks included in side's latest lineage ROM works perfectly with Magisk. I've pulled the file and am using it without problem on the JDC AOSP build. However I may have to switch to Lineage when the next version drops in the hope that Bluetooth HFP is working.
[Galaxy S 4 i9505 Original Android Development] thenooblee:
How can I change my theme? Downloaded a few from the playstore but I cant apply them
[Galaxy S 4 i9505 Original Android Development] lekiaM:
By using Subtratum, aldo it's a bit laggy to. It doesn't work optimal with Lineage OS based roms from my experience.
[Galaxy S 4 i9505 Original Android Development] xmicroman:
It worked then flashing came back I ran the setup wizard again and flashing stopped. This is my third day trying this. I have a SPH L720 maybe it only helps with this model?
[Galaxy S 4 i9505 Original Android Development] Undefined Origin:
Your English is far superior to my Spanish!

I recommend trying a new battery. I've had similar issues in the past, I wasn't able to test it but I believe that under heavy loads the old batteries can't maintain full voltage leading to a freeze/shutdown. When it would occur to me, I even had to pull the battery and let it rest for a bit.
[Galaxy S 4 i9505 Original Android Development] verlorenintranslation:
That could be it

Thanks for your reply, dude! Yeah, I have that in mind, but these problems have started since I installed Beta 4, so I thought there might be a correlation. If these issues remain with the next LineageOS versions, I'll consider buying a new battery :) My second battery is not even 2 years old :D
[Galaxy S 4 i9505 Original Android Development] navcar:
If you wish to share your work (whether here or elsewhere), consider posting just the changed files which can be used to patch the ZIP. This makes it easier to review and verify your edits.

From memory, "Root Switch" worked for me to play PoGo some time ago.
[Galaxy S 4 i9505 Original Android Development] leinad:
Hello all.

Is 'quick Pin unlock' feature present in this ROM?

Thank you for your help.
[Galaxy S 4 i9505 Original Android Development] Rhoban:
It is most probably your battery. That it started happening right when you flashed this ROM is just a coincidence.

I don't know how much of this thread you've read, but I believe you're the only one with such a problem regarding this ROM.

Common sense would dictate it's your battery.
[Galaxy S 4 i9505 Original Android Development] Patrick x:
this rom doesn't have quick unlock

Nope.
[Galaxy S 4 i9505 Original Android Development] lekiaM:
Battery life with this ROM is just perfect. My battery is never replaced in all those years. My standard procedure is to calibrate my battery at full charge after i flash another ROM. But it's more a myth what experts are saying. But i do it anyway even if I'm selfish. With normal usage (checking the news, whatsapp, listening to music, using greenify etc etc..) i can do with this ROM about 24-30 hours!
[Galaxy S 4 i9505 Original Android Development] side:
screen-on-time :cool::cool::cool: hehehehe
[Galaxy S 4 i9505 Original Android Development] Sogli:
I have used optimized cm13 and it was good but this one is even better, I like it so much. Thank you JDCTeam, really appreciate your work. Keep it up!
[Galaxy S 4 i9505 Original Android Development] Mittaa:
I can do 80 hours if I don't use it at all (3-4 hours SOT if actually use it for talk and surfing) :D

BTW after 2 years I replaced my battery and i gave my a solid boost.

Now my second battery is nearly 2 years old so maybe it time again (Oh God I love the concept of replaceable battery) :good:
[Galaxy S 4 i9505 Original Android Development] lekiaM:
"Must" be possible, but that's abosute the maximum with a 2600mah battery. I guess.. :confused::silly:
[Galaxy S 4 i9505 Original Android Development] dhaern:
If you have brain you can check the apps and changes added to system folder, aroma-changes and updater-script because I will post the changes done to the zip but now I can see you dont have brain... anyways I dont care about your opinion, who are you?? I would like upload for people if they want test, not all people downloading the rom are writing on this forum or dont have brain as you.
[Galaxy S 4 i9505 Original Android Development] sjamie:
Me too! It's one of the main reasons I have not upgraded from this beast of a phone! :cyclops:
[Galaxy S 4 i9505 Original Android Development] 63ck0:
Yes, replaceable batteries are great!! :good:
[Galaxy S 4 i9505 Original Android Development] Buff99:
Wow, did you type that quicker than you thought it? So I do have a brain or I don't have a brain, I'm confused?

I was not insulting you, as you appear to believe, simply pointing out that no-one will trust what you suggest. A script so people can do it themselves at their time of choosing would be the more trustworthy approach.
[Galaxy S 4 i9505 Original Android Development] chashmaa:
Friends now I have resurrection naught latest ROM with PI1 modem.it was superb but WiFi issued. WiFi on but can't connected and received any data. any WiFi issued with this?
[Galaxy S 4 i9505 Original Android Development] Buff99:
[MENTION=6357682]chashmaa[/MENTION]

You would be better making a nandroid backup of your current rom then wiping cache, system and data and installing Side's standard LOS rom + gapps to confirm if it has the same wi-fi problems that you currently get on RR.

If it works there then you should be good to use optimised. If however you still see same problems as RR then it's some kind of firmware issue.
[Galaxy S 4 i9505 Original Android Development] chashmaa:
OK.I will dwnld and flash tomorrow. One more help I have already gapps arm 7.1.1 pico and nano file.this file using to resurrection. can I use or redownload?
[Galaxy S 4 i9505 Original Android Development] topiratiko:
Hey guys is there a wake lock blocker app that will work with this ROM? Everything I find says it need xposed

Optimized LineageOS