yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S 5 Unified Development] O_oaa:
After fighting with getting the project into IntelliJ and moving a bunch of classes around to get things to compile just enough to replace smali files with my modifications, I'm now fighting with the AudioManager. Apparently the stock AudioManager is aware of a STREAM_FM_RADIO, but trying to access that stream in Lineage throws this exception:

12-20 01:19:40.081 2697 2751 W System.err: java.lang.IllegalArgumentException: Bad stream type 10
12-20 01:19:40.089 2697 2751 W System.err: at android.os.Parcel.readException(Parcel.java:1688)
12-20 01:19:40.089 2697 2751 W System.err: at android.os.Parcel.readException(Parcel.java:1637)
12-20 01:19:40.089 2697 2751 W System.err: at android.media.IAudioService$Stub$Proxy.getStreamVolume(IAudioService.java:915)
12-20 01:19:40.090 2697 2751 W System.err: at android.media.AudioManager.getStreamVolume(AudioManager.java:990)
12-20 01:19:40.090 2697 2751 W System.err: at com.samsungframeworks.media.fmradio.FMRadioImpl.init(FMRadioImpl.java:51)
12-20 01:19:40.090 2697 2751 W System.err: at org.nablabs.libFmRadioImpl.FmRadio.init(FmRadio.java:19)
12-20 01:19:40.090 2697 2751 W System.err: at com.nextradioapp.radioadapters.AdapterListing.getFMRadioImplementationClass(AdapterListing.java:80)
{...snip...}

I'm not sure if the fix is to update AudioManager to correctly reference the stream (if it's even available) or the "audio" service itself as referenced in AudioManager:

sService = Stub.asInterface(ServiceManager.getService("audio"));

At any rate, I hard-coded the STREAM_MUSIC ID just to get past it, and now I'm greeted with this exception:

12-20 01:45:39.192 2835 2889 W System.err: java.lang.NullPointerException: Attempt to invoke virtual method 'boolean com.samsung.media.fmradio.FMPlayer.isOn()' on a null object reference

Looks like the "FMPlayer" service needs to be running after all. Anyone have information on adding/starting framework services for Nougat?
[Samsung Galaxy S 5 Unified Development] systemcrash:
Any devs?

Dig in the git repo for the FM tuner.

Forget the Samsung cruft and build your own tuner with the above drivers :D
[Samsung Galaxy S 5 Unified Development] O_oaa:
I've briefly looked at that stuff, and I think the necessary modules are already compiled into our kernel. While I've been taking a top-down approach to solving this problem, I believe the FMPlayer service uses the "radio-iris" functions. Looking in /dev as stock is running, there is a radio-iris device that appears functional, however I've not come close to getting to that point. There's probably more to it than just that. EDIT: Looking at stock again, this is actually /sys/devices/qcom,iris-fm.69 (or similar), and /sys/devices/qcom,iris-fm.69/power/runtime_status has "unsupported" in it. I think this was a red herring. So now I have no idea what the FMPlayer service is driving.

Decompiling Marshmallow framework files is relatively straightforward, modifying them is tricky, but figuring out how to integrate the changes into Lineage's framework build is still an unknown to me. I'd like to get the FMPlayer code into the SystemServiceRegistry so it starts on boot just to prove it works, so that's next on my to-do list.

It's either that or rewrite the entire internal FMRadio service code, which at this point I'm not convinced it's worth it until I can prove the stock code works with minimal modifications (working with the player as a service through IFMPlayer and bindings vs. invoking functions directly is a nontrivial change). This seems like the path of least resistance to me.

No matter what direction is taken, AudioManager and related code still needs updated to have access to the FM audio stream. That light I mentioned earlier is fading. :eek:
[Samsung Galaxy S 5 Unified Development] fipsy:
No matter how things turn out at the end, I would like to thank you very, very much for all the effort you have put in and for all the interesting information!
[Samsung Galaxy S 5 Unified Development] cal002:
I think Iris is Qcom's FM radio, S5 doesn't have it although it has a useless devicetree entry for it.

S5 has Broadcom fm radio. I'd suggest to check out spririt2_free source and info.
[Samsung Galaxy S 5 Unified Development] O_oaa:
mikereidis has been a major inspiration and source of a lot of the information I've found. No matter what I turn to next, I usually find a post by him like a note from the past.

I took a bit of a break today from looking into this, but I'm still hopeful. The build for Lineage pulls in what I believe is necessary to interface with the bluetooth chip (bcm4350*.hcd), so there's that. I have no clue if it's needed or not. Unfortunately, there's multiple components that need updated to support the radio at least in the way the NextRadio app is using it on stock. The audio framework kinda scares me, but I'll worry about that if I can get the service running.
[Samsung Galaxy S 5 Unified Development] Atento:
I liked the description of a recent commit:

* If your display is flickering your HW is broken, the rest of us like our retinas intact when using the phone in the dark.

Hahaha that's awesome.
[Samsung Galaxy S 5 Unified Development] luki7151:
Ok, i did some research and solved my problem with wakelocks temporarily using silly workaround method till next clean flash. :silly:

Initially i switched off my FP scanner unlock, to see if it was waking up the phone, but the battery graph didn't change. Then i started to think if it really was NFCs fault. I've downloaded Wakelock Detector and i saw over ~3,5mln wakelocks during 10 hours from NFC system activity :eek: I couldn't turn it off it settings, because it was greyed out, so i went to /system/app/ and deleted "NfcNci" folder for now. Wakelocks are gone, and i think i will stay with this setup till the start of official nightlies. :p

Could you PM me a link to this patch? It's ridiculous that even my standalone battery charger is faster than plugging this guy directly to the brick.
[Samsung Galaxy S 5 Unified Development] rayzen6:
Wow [MENTION=2693412]haggertk[/MENTION] our klte is der listed on official nightlies list for cm14.1.

Ousmmmm. Thank you.
[Samsung Galaxy S 5 Unified Development] galaxyornothing2:
messages

OK, I noticed something today, I'm using the G900T and the 10/29 build. When I picked a person to send a message to, once I sent the message it shows that it went to a totally different person? Any ideas why this would be? Other than that I have no other problems.
[Samsung Galaxy S 5 Unified Development] S5AndroidUser:
Why Dark Quick Settings?

Why are the quick settings soo dark, in stock android 7.1 its like blue and grey, but in cm14.1 its like brown.

Everything else works very nice :)

I'm using the newest build for sm-g900f.
[Samsung Galaxy S 5 Unified Development] jairoa:
Si y nunca le pedi una disculpa verdadera
[Samsung Galaxy S 5 Unified Development] :
thanks for the tip, seems to work.

ya, i can. may not b until tmrrw night, not going to b home until late tonight, i'll also have to double-check that it applies over haggertk's kernel, as i am using 3.4.90. it shouldn't be an issuee...

btw, i AM planning to submit usb-fast-charge to cm/klte, just not until all of linux-stable is caught up. (i actually have a few features to submit + a number of backports and some bits from google's android trees).
[Samsung Galaxy S 5 Unified Development] htb2050:
Looks like they finally are going with sdclang. I saw fewer framedrops with sdclang on the last batch of test builds.

http://review.cyanogenmod.org/#/c/169935/
[Samsung Galaxy S 5 Unified Development] sadaniel79:
First build of nightlies are on the way. Galaxy S5 is on the list.

http://www.cyanogenmod.org/blog/cm14-is-landing
[Samsung Galaxy S 5 Unified Development] haggertk:
Yes, hustling home to submit the patch to opt in before nightlies kick.
[Samsung Galaxy S 5 Unified Development] Pillle:
With CM14 for klteduos it is also not possible to switch mobile Radio on/off for the different SIM cards (except airline mode). The switches are missing like in CM13.
[Samsung Galaxy S 5 Unified Development] david825234:
It's pretty awesome how we're on this list of only nine devices trees.
[Samsung Galaxy S 5 Unified Development] haggertk:
I didn't promote duos to 14.1 yet due to some of the problems for that specific variant. There have been several msim related fixes in the last week, so I'm going to post new test builds soon for just duos.
[Samsung Galaxy S 5 Unified Development] kn00tcn:
CM hasnt used aosp camera since ~february, or does the sprint variant not use snapdragon camera?

dim google camera sounds unusually familiar.... like it was in one of the nexus changelogs or made some sites re-review the phone
[Samsung Galaxy S 5 Unified Development] fureisenjin:
Long live the S5 [emoji3]
[Samsung Galaxy S 5 Unified Development] SB4BBs:
Solved my battery drain problems.
[Samsung Galaxy S 5 Unified Development] david825234:
The first build with cm14.1 was posted recently. Not out S5, but it's nice to see builds are coming really, really soon.
[Samsung Galaxy S 5 Unified Development] dazemc:
I've noticed that if I first set my wallpaper to my old lock screen picture it stays my lock screen background. Even if I change my wallpaper the lockscreen stays the same.
[Samsung Galaxy S 5 Unified Development] haggertk:
Things are *supposed* to be in alphabetical order, but there were some stupid problems with the build servers tonight. They were worked through and cyanogen re-kicked the builds. The one or two that got lucky and completed will end up having 2-3 "nightlies" tonight.

klte is building now (see http://jenkins.cyanogenmod.com/) and *should* be uploaded to the official download site in ~ 1 hr. The rest of the variants will follow shortly thereafter.
[Samsung Galaxy S 5 Unified Development] sadaniel79:
Once the official nightlies out, can we dirty flash it or we need to clean install?
[Samsung Galaxy S 5 Unified Development] fipsy:
There were some remarks about the last release (also from me) concerning detected problems. I'd like to come back to that.

I mainly remember three problems with Release 20171214:

[MENTION=6952874]Johny81[/MENTION]: Missing HDR functionality of the camera with the LOS Camera App.

[MENTION=8126437]Raynelfss[/MENTION]: Microphone not working for WhatsApp (telephone calls and voice messages)

WiFi terminations

I have set my device back to the LOS version 20171207. It has been said that the problems did not yet arise there. The result: ALL problems also occurred in the LOS version from December 7th. I therefore believe that these problems must have arisen before and are not specifically due to the version of December 14th.

The only way to avoid the HDR problem seems to be by bypassing the HDR functionality of the camera chip and using an app that "emulates" HDR through several consecutive images (e. g. OpenCamera App).

The microphone problem can be solved by a patch to adjust the microphone settings in the /system/etc/mixer_paths.xml file. After that, the microphone in WhatsApp on my phone has the correct volume again.

I could now also set the aborts with WLAN in relation to connection problems to the mobile radio network, as [MENTION=7978913]fitittome[/MENTION] had already said: If the mobile radio icon has a small cross in the lower right corner (i. e. no connection to the Internet could be established), the WLAN connection also aborts. The developers would probably have to investigate this more closely.
[Samsung Galaxy S 5 Unified Development] fitittome:
Hey, these need to be reproducible and test cases provided, along with logcats. The devs won't stand a hope of identifying the problem without this sort of info. They need to be submitted on JIRA as a BUGBASH over the weekend.
[Samsung Galaxy S 5 Unified Development] Dr.N@:
LiveDisplay toggle removed when i reboot my device
[Samsung Galaxy S 5 Unified Development] clintonholder:
Power off charging loop

I was able to install TWRP recovery and install LineageOS 14.1, which works great, but now when I power off the phone and try to charge it while the power is off an empty battery image comes up, the phone vibrates, the screen goes blanks, and then this just repeats showing the empty battery and the screen going blank. I can power it on just fine but it's nice to charge it when powered off. Anyone have this problem?
[Samsung Galaxy S 5 Unified Development] jdrch:
The power off while attached to AC source behavior is kinda wonky. Workaround: charge it with the phone on. Trust me when I say the charging speed will still be fast enough.
[Samsung Galaxy S 5 Unified Development] fipsy:
I doubt there will be any helpful logcats for these special problems. The LOS camera app has never worked with HDR before in my case. And when I launch the app, I have hundreds, maybe even thousands of errors in the Logcat. That means that this app seems to work only by chance anyway. So it's probably useless if I create a Logcat with thousands of different errors for something that has never worked.

As far as the WiFi problem is concerned, one would have to somehow provoke the error for a Logcat, which is almost impossible, because how do you want to make sure that the data connection to the provider is lost without losing the mobile phone connection and the WiFi connection? Coincidentally, this happens very rarely. In my case, only once every few months. Manually disabling the data connection does not provoke the error.
[Samsung Galaxy S 5 Unified Development] omgbossis21:
I have only noticed as far as WiFi goes that its not automatically connecting to WiFi from one location to the next. For example when Im at my moms house it will remain disconnected until I manually reconnect. Same thing when I get back home, turning WiFi on and off will connect on its own.
[Samsung Galaxy S 5 Unified Development] fipsy:
Strange! That is working for me. But WiFi has always been and still is something that was sometimes very fragile and subject to problems. It already was not completely unproblematic with CM11 and has never really been perfect.

My problem I had recently, however, was particularly outstanding because the WiFi connection was disconnected several times while streaming to Chromecast after exactly 10 seconds and could not be re-established afterwards. Sometimes not even any WiFi network was found. That was a particularly unusual situation, which I had never had before.
[Samsung Galaxy S 5 Unified Development] fitittome:
My stock camera and marginz snap HDR seem to work OK with HDR. That's why I got mad. The guy said hdr didn't work. No explanation of what the problem actually was. How to test it etc.

Yes camera logcats are ultra spammy! I don't know how to adjust that.

Wi-Fi. I have one location, kids football training, where I see this. I was going to take a 'virgin' phone there and see if I could grab some data. New year now, though when training restarts..
[Samsung Galaxy S 5 Unified Development] fipsy:
I did the test by simply taking two pictures of the same, relatively high contrast object with LOS stock camera (snap camera version 2.0.002). Once with and once without HDR activated. Both pictures looked the same. Therefore I assume that HDR is not working. Have you ever compared two images before?
[Samsung Galaxy S 5 Unified Development] fitittome:
Is that valid? Probably naively, I would expect that. I thought HDR images had to be 'processed' before you would notice a diffrence. Research required by both of us, I think.

Edit:

http://timclarkehdr.com/what-is-hdr/

Edit2:

So it maybe that the Gallery software is not capable of rendering the HDR info on the fly?
[Samsung Galaxy S 5 Unified Development] fipsy:
I also had always assumed this until [MENTION=7518817]cal002[/MENTION] taught me something better here. You probably skipped his story:

The normal camera apps like OpenCamera do it the way you said. You take several images one after the other with different exposures and then combine them into one image by calculations. But the LOS camera app should use the image sensor's HDR function directly. The necessary adjustments are already made directly in the sensor and the image provided by the sensor is already an HDR image - without any further calculations. And this obviously is not working with LOS. So one of the most advanced features of the S5 got lost: Taking HDR videos!!! :( :crying:
[Samsung Galaxy S 5 Unified Development] fitittome:
OK. Got it. SNAP HDR does it by taking a number of shots. They are quite different when viewed in the gallery.

The LOS Camera claims to be HDR, but as you say they are not.

Interestingly, a Nexus running AOSP seem to use the sensors capabilities to do this in the same way the Samsung Stock appears to do.

Now I understand what the dev was saying about the camera now. The Samsung 'rt-hdr' parameter is 'buggy'. I guess that's a huge job to rewrite and debug. https://review.lineageos.org/#/c/198297/
[Samsung Galaxy S 5 Unified Development] 10goto10:
Can also report that currently, switching HDR toggle on built-in camera doesn't change the image output. HDR with built-in camera app used to work fine though (with live view, even!) I've got a pair of pictures on my gallery from October that shows increased shadow details without highlight being overly blown out.

Back then, I even delayed switching from CM13.1 to CM14 until HDR worked on Nougat. If I've been using this phone camera more I would've probably noticed sooner... I wish I could help bisect the builds until I find one that works, but right now I can't... Maybe next year if it's not fixed already :)

As for HDR video on the S5, I've used it when I was on stock years ago. Works fine for sunset / sunrise, but can look a bit unnatural otherwise. IIRC it even works with 1080p60 recording...
[Samsung Galaxy S 5 Unified Development] sogol:
Samsung Sidesync crashes

Hi. No one uses Samsung Sidesync on this ROM?

It always crashes... ALWAYS... Cleaned cache... reset... everything checked, but it always crashes; update after upadate of the ROM...

Why? Thank you.
[Samsung Galaxy S 5 Unified Development] fitittome:
It's odd. The same thing is noted a year ago. https://xdaforums.com/showpost.php?p=70817951&postcount=4330 It could be that this has never worked! It has been fooling everyone all along.
[Samsung Galaxy S 5 Unified Development] beatboxer:
What's the latest version suitable for daily driver? I am on 20170419 kltedv and everything works.

I just want the latest security updates, but don't want to risk any more serious issues that seem to happening for some people e.g. microphone, wifi, cpu/battery life.

Should I just try the latest nightly and hope it's ok?
[Samsung Galaxy S 5 Unified Development] fitittome:
The latest will work great!
[Samsung Galaxy S 5 Unified Development] 10goto10:
Naw, it definitely worked before. Here's a comparison shot from October. Spot the one with HDR enabled :)
[Samsung Galaxy S 5 Unified Development] fitittome:
What Nightly would that have been running?
[Samsung Galaxy S 5 Unified Development] 10goto10:
Not 100% sure, but it's the first build for October (or the one before that.)
[Samsung Galaxy S 5 Unified Development] fipsy:
Then it shouldn't be so hard to find out what caused the HDR functionality to be lost and fix the problem!?
[Samsung Galaxy S 5 Unified Development] KKTHX:
Hi,

Whit build is best for daily usage? stable and error proof?
[Samsung Galaxy S 5 Unified Development] fitittome:
I have rolled back to 13SEP and I think it was working there. The images 'look' different but I wish there was a 'cast iron' way to

prove

this is the case. Otherwise the test is just subjective.
[Samsung Galaxy S 5 Unified Development] reaperlinkz:
Anyone else having issues with the latest gapps?
[Samsung Galaxy S 5 Unified Development] fipsy:
Take a picture at sunrise or sunset and you'll be absolutely sure. ;)
[Samsung Galaxy S 5 Unified Development] godofsalt:
AWESOME!!!

Darn glad your putting in the hard foot work on this. The FM Radio was great an miss it.

Tanx

And Merry Christmas to all that read this... Or don't!
[Samsung Galaxy S 5 Unified Development] tommasa:
Hi all and thanks for all your work on this rom. I love it. I have little lag problems with the last releases, expecially with clash royale. I reverted back to nightly 20171207 and the rom work like a charm. Any solutions?

Tnx in advance.
[Samsung Galaxy S 5 Unified Development] brianinmaine:
So my sensor has been intermittent for a while too. If I pull the battery and boot, it seems to always work for a while. Still trying to see what makes it stop, or if it's a hardware problem.
[Samsung Galaxy S 5 Unified Development] cal002:
V4L2 is only used with a kernel fm radio driver (e.g. for Qcom). Broadcom uses BT HCI vendor commands. I checked the Nu3001 stuff but the interesting code is in binary-only libbt-fmcore.a. It might be better to read spirit2_free code since it seems Mike Reidis had already reversed the protocol. However, since this stuff would have to be integrated into the bluetooth stack (system/bt/) I have doubts it's worth the hassle.
[Samsung Galaxy S 5 Unified Development] fipsy:
Do you have a custom kernel installed?
[Samsung Galaxy S 5 Unified Development] brianinmaine:
no custom kernel, did a total clean install 2 weeks ago and then this week did a dirty flash to update. I use a custom gapps-config.txt file to install many gapps programs. Also, (might be related?) I use greenify and naptime to ignore sensors and stay asleep unless I wake it. Of course I just tried the battery pull thing again and it didn't work... No idea where to check next. Not a huge deal for me, just would be nice to know if it is indeed my hardware.
[Samsung Galaxy S 5 Unified Development] Paul_Lunardi:
TuneIn radio and radioapp frequently pauses radio streams

Hi all,

When using radioapp and TuneIn radio at home on my wifi the stream has been pausing intermittently. It's driving me crazy. I have my Bluetooth speakers connected and have noticed this issue since the Dec 14 th build. I've updated to the 21 St build today though still the same issue.

Not sure whether this log is good enough for people to help. Thanks.
[Samsung Galaxy S 5 Unified Development] Wolfillete:
Hi! I'm having some problems since I updated (wipe, recovery update...) from CM to LineageOS (14.1). The first problem is mobile signal sometimes goes off for a moment and then comes back idk why... Then NFC doesn't work at all, I turn it on on setting but icon doesn't appear on status bar and I tried to read some NFC cards and it doesn't work either. I'll appreciate your help.
[Samsung Galaxy S 5 Unified Development] fitittome:
Try updating the baseband. The dev has some here:

https://androidfilehost.com/?w=files&flid=102820
[Samsung Galaxy S 5 Unified Development] phalkon30:
https://www.lineageos.org/Celebrating-one-year-of-LineageOS/

Number 5 device! Merry Christmas everyone, I'm so glad to have such dedicated people making software for my phone and volunteering their time
[Samsung Galaxy S 5 Unified Development] fipsy:
Same here. I also used ES (but pro version) for years and I'm satisfied. Never had any problems.

---------- Post added at 04:36 PM ---------- Previous post was at 04:23 PM ----------

I'd recommend to not manually edit the XML file but download the zip from this location and flash it via TWRP.
[Samsung Galaxy S 5 Unified Development] Atlantisvip:
Will this work on T-MO S5 ?
[Samsung Galaxy S 5 Unified Development] Bobcus Leper:
Yes. Read the OP.
[Samsung Galaxy S 5 Unified Development] SamuelMaki:
Does encryption work in the latest nightlies properly? How about performance, still eating battery out quickly?
[Samsung Galaxy S 5 Unified Development] fitittome:
It seems to work OK. It properly displays progress now, which it didn't at the beginning of the year. Don't know about battery, I don't recall any complaints here.
[Samsung Galaxy S 5 Unified Development] J-Lindo:
I've been having a hard time getting GPS to lock lately. Do any fellow Verizoners ( [MENTION=4828250]Ibuprophen[/MENTION] ?) find any particular basebands to be better than others? Or, if there's another tactic to try, I'm all ears.