yashsingh1/xdaforums huggingface dataset:
[ONE Android Development] Gawd:
Very much interested in this ROM

PLEASE don't let it die :)
[ONE Android Development] freshgiammi:
Not gonna die! Had my finals this week, and needed my phone fully operational. Since OPO is my main device, I can't spend time as a flashaholic on it.. But i've kept in touch with a few other devs and i'm building right now. Hope to get Sultanxda's camera HAL to work on 7.1.1
[ONE Android Development] Gawd:
We're with you :)
[ONE Android Development] freshgiammi:
Update: I've managed to find out why camera wasn't working on 7.1.1.. But I still doesn't know why the issue happens. Basically, it's just a library that gets renamed when it shouldn't. Weird.

However, the status of the HAL is: Video working, but photos doesn't get saved. So we're at the starting point, again..
[ONE Android Development] zjxpot:
tale your time bro .. you will sort it out ..
[ONE Android Development] freshgiammi:
I've uploaded a test build to my basketbuild server. You can download it here.

It's 7.1.1 with Sultanxda's Camera HAL. Video recording works but you can't take pictures. In case any of you wants to try it out..

Beware camera doesn't work on first boot. After you've flashed, boot into TWRP, mount /system, connect your OPO via USB to your computer and do:

adb push camera.msm8974.so /system/vendor/lib/hw/camera.msm8974.so && adb shell rm /system/vendor/lib/hw/camera.bacon.so

Be sure to be on the folder where you've downloaded this file.

camera.msm8974.so
[ONE Android Development] freshgiammi:
Doing the finishing touches right now. SultanXDA'S Camera HAL is up and running now.

The new build should be up tonight or tomorrow.

-Haven't been able to build Snapdragon Camera, tho. If you know an AOSP rom that has it working, let me know.
[ONE Android Development] mustang_ssc:
Glad you finally got it.

AOSP Roms which i know have snap camera/snapdragon camera working are:

Slim 7: https://xdaforums.com/oneplus-one/orig-development/rom-slim7-bacon-t3464848/page64

ChyperOS: https://xdaforums.com/oneplus-one/development/rom-cypheros-2-3-hazelnut-t3413861/page15

And not sure about this one (NitrogenOS): https://xdaforums.com/oneplus-one/development/nitrogen-os-7-1-0-nde63p-t3491386/page101
[ONE Android Development] Spider-Vice:
Awesome, can't wait!
[ONE Android Development] SirSoviet:
Dev is a champ for doing everything the clean way. Props to him
[ONE Android Development] DeadFox-xda:
Holy damn you went from 25th of november to 9th of january!!! But congrats on successfully transfering sultans camera hal to your rom, thanks for keeping OPO alive :D
[ONE Android Development] freshgiammi:
AOSPlusone_090117 is out! Enjoy that sweet new Camera HAL from [MENTION=4800121]Sultanxda[/MENTION] ! Download HERE or on #1.

Props to [MENTION=5975974]amardeep434[/MENTION] for the help on fixing the JPEG saving issue!

Changelog

25 Nov. 2016 -> 09 Jan. 2017

Updated to 7.1.1_r13 (5 Jan. Security Patchset)
[B]ADDED SULTANXDA’S CAMERA HAL! Enjoy that sweet camera optimization
Enabled HSR (High speed recording). Slow-mo doesn’t work yet.[/B]
Added back Substratum, with improved functionalities and customization.
Updated bionic libraries to load shims correctly
[B]Enabled Night Mode
Enabled Storage Manager[/B]
Under-the-hood device optimization

A dirty flash over 7.0 should be okay, but a clean flash is advised. Enjoy your new camera!
[ONE Android Development] freshgiammi:
Yeah haha, adapting the HAL took quite some time and I haven't had much free time lately.. Thanks a lot to you and all the other running this rom!
[ONE Android Development] Spider-Vice:
Fast and stable so far, thanks for this!
[ONE Android Development] DeadFox-xda:
Which tends to have better battery, cyanogen (Lineage) or Aosp?
[ONE Android Development] frolicflyer:
Not able to install open gapps for 7.1 ...It is asking for 6.0.1 gapps

Don't know what's the issue
[ONE Android Development] C4SCA:
If supersu isnt flashed does this rom passes safety net? (PoGo and banking apps work?)
[ONE Android Development] SirSoviet:
Reboot recovery after flashing the rom.
[ONE Android Development] ahmedradaideh:
use Opengapps 7.1 pico.
[ONE Android Development] frolicflyer:
While rebooting to recovery it says no OS INSTALLED , although i have already flashed the rom zip

---------- Post added at 02:26 AM ---------- Previous post was at 02:24 AM ----------

I used it but still getting error
[ONE Android Development] SirSoviet:
Just ignore the warning and reboot.
[ONE Android Development] freshgiammi:
Kernel side, we're on the same branch of CM. Battery life is consistent across all ROMS. CM might have a better battery life, but not by much. (Due to optimizations)

Even tho, I always had better battery life on AOSP based roms.

Yes, sometimes it does this. While in recovery, reboot to recovery again and you should be able to flash.

Main banking apps in Italy work without the SafetyNet checks, so I can't confirm. But I believe SafetyNet checks also the integrity of boot loader (locked/unlocked). If you could tell me wether it passes or not, I can dig into it and fix possible errors.

Same as the GApps issue. Sometimes, recovery doesn't read the /system partition after flash. But if you encountered no errors during the flash procedure, you can safely ignore the message and reboot.
[ONE Android Development] C4SCA:
My banking app works on Omni unrooted Selinux enforcing but it gives warnings and PoGo doesnt authenticate and safetynet fails. Now im back to COS 13.1.2 unrooted stock and even with the bootloader unlocked i get no errors and safetynet passes.

So the other thing i think safetynet checks is the build type on the kernel side and not the bootloader state (does SELinux mathers?). COS since its stock is a releasebuild, Omni is userdebug.

I ask this cuz im looking for a simple AOSP 7.1 rom with no root since CM is dead but i need these apps.

Thanks for clarifying:)
[ONE Android Development] freshgiammi:
The majority of roms here is userdebug. Probably you're right, but that can be worked around by editing your build.prop. Bootloader check might have been disabled since it's been worked around kernel side. Don't know about SELinux, but I'm writing rules right now. Hope to get enforcing working the next few days.

If it doesn't work on OMNI, it shouldn't be working here too. Even with SELinux set on enforcing.
[ONE Android Development] C4SCA:
Someone tried to edit the build.prop but didnt work. Dev said safetynet checks it kernel side (dunno exactly what it meant with that).

So no hope on passing safetynet unless its user build i think...

Whats the difference in bulding userdebug or userbuild?

PoGo is life hahahahaha
[ONE Android Development] DeadFox-xda:
Awesome thanks for the detailed answer!! You are one of the kind developer ;)
[ONE Android Development] freshgiammi:
No problem! Had no reason not to be kind ;) Just remember YMMV depending on your usage and apps. I have currently 120 apps (even a few battery hungry ones) and I get to the end of the day with 15% left and 3h of SOT.

Gonna look more into that, but I don't know if any 7.1 roms has this worked around. However, you can find the differences here https://source.android.com/source/add-device.html#build-variants

Basically, an userdebug build allows for easier development.
[ONE Android Development] SirSoviet:
Stericson's BusyBox isn't installing with phh's SU on this rom (/system/xbin doesn't work) but it works with SuperSU (/su/xbin). It works on other roms, even Evolitist's AOSP.
[ONE Android Development] Ninnix96:
Very very good work!

Bravissimo spero di riuscire a provarla presto ?
[ONE Android Development] freshgiammi:
Weird. I'll look into it, thanks for reporting. I use Meefik's BusyBox but I'm planning on including it on the next build.

EDIT: A first look hasn't made me see any substantial changes that could affect this. Could you provide me with a log?

Thanks a lot! Hope you'll have a good time!

(Però non quotare il primo post delle discussioni, è buona usanza non farlo.. meglio taggare l'autore! ;) )
[ONE Android Development] SirSoviet:
Also guys, kernels for CM will break camera. CAF kernels are fine. Just don't flash the ColorOS camera version.
[ONE Android Development] freshgiammi:
Thanks, I completely forgot to say that.

CM Kernels are not compatible, but you can flash the CAF ones that are working on SultanXDA's CM13.1 ROM.

If any dev reads this:

I'm going to make a gist in the following days so that every developer can implement SultanXDA's Camera HAL in his own rom.
[ONE Android Development] ramosroger:
Does the ROM come with round icons?, I don't wanna go through the lengthy process of flashing to find it. And no I'm not asking you guys to recommend icon packs and nova launcher
[ONE Android Development] freshgiammi:
No it doesn't, and neither it has the Google Pixel's color scheme.
[ONE Android Development] SirSoviet:
Not at the moment, sorry.
[ONE Android Development] DeadFox-xda:
How do I do short button on menu for recent apps?
[ONE Android Development] mp3deviant721:
Is notification/battery light controls going to be added eventually? It'd be nice to be able to turn off the battery light during charging cause it's annoying at night.

Edit: also what about a lockscreen media art toggle? To disable the album art background when playing music.
[ONE Android Development] freshgiammi:
You can't. Recents is hardcoded to be working with a long press only.

Short touches can't be changed.

No new features will be added. That's the default behavior and I'm keeping it as close as possible to AOSP.

I believe there are apps on the play store that can change notification lights, but I might be wrong.
[ONE Android Development] C4SCA:
To control the led u can use lightflow for example.

One question on an older changelog, button config was added, so in recent updates that feature was taken down? Is usefull since having the menu button not work as recents is kinda pointless nowdays (3dot or drawer are the menu since kitkat no? No need for a dedicated key, look at the navbar, doesnt have a menu button)

05 Nov. 2016

Added On-Screen NavBar and HW Keys customization (Settings -> Buttons)
[ONE Android Development] SirSoviet:
Well actually, it can be changed! Open /system/usr/keylayout/Generic.kl with a text editor and scroll down to key 139. Change "MENU" next to it to "APP_SWITCH". Save the file and reboot to apply changes.
[ONE Android Development] freshgiammi:
Yeah lightflow was the app i was thinking of, just couldn't remember if it was still supported.

It hasn't been taken down. You can find it under Settings -> Buttons. You can remap long press and double press. Single press is hardcoded.

Also, the 3dot menu comes up only with the navigation bar.

The hardware keys config is:

Long press: recents (or customizable)

Single press: show menu (not customizable)

If you are a tech savvy with the terminal and ADB, sure it is ;) but it might break the button customization feature. At least it did during my tests.

Otherwiae, system isn't accessibile. You'd need busybox in order to remount it in R/W mode.
[ONE Android Development] C4SCA:
I dont wanna have a rooted device. For many reasons mainly cuz i dont need it. Can i do those changes without having root and use a build prop editor? Like from twrp or adb?

Im was looking to migrate from COS to a simple 7.1.1 rom, simple but with the menu key as recents, since for custom toggles i own the app Tiles

Edit: changing that value will break things, thanks for the quick anwser OP. Might just use the app button remapper to change the action of quick press?
[ONE Android Development] Barnett:
USB connection can not share network
[ONE Android Development] DeadFox-xda:
Do you think this can be added? Short button press menu to open recent apps, if not its not the end of the world :p
[ONE Android Development] firenxe:
is f2fs on data and cache working on this ROM?
[ONE Android Development] beatbrot:
Menubutton for recents is literally the only thing that's left to make this ROM perfect for me :) I do hope this can be considered :)
[ONE Android Development] DeadFox-xda:
Quality is awesome, probably the best camera in android N
[ONE Android Development] DeadFox-xda:
One more :)
[ONE Android Development] LucentBirch:
Anyone here trying to use magisk and phh magisk superuser? I get everything to install correctly, but I can't get safety net check to work. Is this because of selinux?

Weird...I went to try and hide Pokemon go, but it wasn't in the list. Pokemon go still opens just fine even without hide on...
[ONE Android Development] freshgiammi:
AOSPlusone_090117 is out! Fixes USB Tethering and replaced the launcher with AOSP version of Launcher3. Download here or on #1.

Changelog:

09 Jan. 2017 -> 11 Jan. 2017

Changed kernel name for conformity (from -cyanogenmod to -bacon)
[B]Fixed USB tethering not working[/B]
Replaced Launcher2 with Launcher3 (Materialized version)
[ONE Android Development] molohov:
So this ROM uses Sultan's camera HAL + OxygenOS blobs? I've been waiting for a Nougat ROM to do this :D Flashing now!
[ONE Android Development] mubharad:
What's the recommended way to dirty flash or every build has to be clean? Is there a possibility to add status bar customizations and if it makes sense Smartbar/fling settings? At least status bar would be good.
[ONE Android Development] LucentBirch:
So what's the dealio with selinux? Why can't we have it set to enforcing?
[ONE Android Development] lumufei:
Can we use lighting kernel v34 or other custom kernel?
[ONE Android Development] Gawd:
Keep this as close to stock as possible. Just like pixel/ nexus devices. Nothing more, nothing less. Would be great. :D
[ONE Android Development] arfasyrf:
Cannot flash the ROM when data and cache is f2fs. It stuck on the one plus logo. Change back to ext4 and it all works. Except some apps cannot be restored using titanium backup. It stuck at restoring
[ONE Android Development] TheNerd:
Is thethering (making the phone act as Access point) works?
[ONE Android Development] Gawd:
Yes, I guess.

[MENTION=4986658]freshgiammi[/MENTION] Is SElinux fixed?
[ONE Android Development] freshgiammi:
Yep! The ROMs that currently have Sultan's HAL on nougat are this one and NitrogenOS by amardeep434.

I usually clean flash only on major releases, like from 7.0 to 7.1. Otherwise, just clean your cache, flash the update along with Gapps and any zip you use that modifies /system files.

Features that are external to AOSP won't be ported. The only exception so far has been the button customization setting, since it came bundled with the Navigation Bar/HW Keys switch.

SELinux is still permissive as I haven't had time to write sepolicies yet. Too busy porting the HAL.

As long as it has CAF Camera Drivers, you should be good to go.

Thanks, I'll see if i can get some info and i'm probably gonna post here somewhere a rom with F2FS support. If someone with F2FS could test it, that'd be awesome.

As stated in the latest changelog, it is. Both USB and Hotspot are working.
[ONE Android Development] freshgiammi:
Yeah battery life tends to be underwhelming for me too the first 24h or so, but I usually under clock my cpu so i'm running cool. I down clocked my max speed to 1958mhz and my boost frequency to 1036mhz. So far, so good.

In case other devs merge the HAL, you'll see customization from there. To me, I've never liked customization. Keeping close to AOSP means I can update faster and with less headaches during the merge process. The only thing slowing me down, actually, is the fact that OPO is my main device (So I can't be too flashaholic, even tho this allows me to run better tests since i can keep it under control during long run times), and the slowness of my building machine. Takes about ~5h for a dirty build with major changes, and ~12h for a clean build. That's a lot, considering that good machines usually clean build in less than 2h.

However, back to the customization question. I know I'll keep on being asked to port features, but since this is an AOSP rom I'll never do it, unless it's part of the AOSP system. Sorry to let everyone down, but that's my philosophy! I like what is stable for sure, after my past experiences with other ROMs (which I won't name, on multiple devices) I feel uncomfortable with customization.

Also, adding a customization would mean that users would start saying "You added x, why don't you add z? at the end you already added something"

Hope I can get everyone's understanding. (And sorry for the long post)
[ONE Android Development] LucentBirch:
I can completely get behind that philosophy! Really, the pull down to get to quick settings is the only custom feature I really use, haha. I haven't changed my battery icon, or time location, or anything like that for a while now. I guess I re-map the hardware keys (change menu to recents) too, but that's it. I know how to re-map them manually, so the fact it's not in this rom isn't a big deal. Is there a way to do your changes and have someone else do the builds for you on a faster machine? I don't really know how all of that works tbh. I have a good understanding of flashing roms, and root, and stuff to customize my phone -- but the actual coding/development behind the roms is where I'm completely ignorant. However, if you can have someone else do the builds, my machine isn't half bad (I guess I don't know what "slow" is for your build machine -- specs??).

Cheers!
[ONE Android Development] freshgiammi:
Ironically, the pull down to quick settings is the first thing i used to remove when flashing roms with that enabled haha

Still, you can double-finger swipe down to get instantly to quick settings.

Actually, I do my changes locally on my Macbook (which I do not build on since it runs on a SSD) and then push them to my build server via SSH, so I'm doing everything on my own. My build server is, ehm... my ex laptop, which fell and broke the screen. I took it off and I connect to it via SSH. Once i've updated my sources, I build and then pull the .zip package.

PC Specs are pretty low for building: 4GB Ram and Intel i3 3rd Gen. And it's a laptop.. (ASUS X551CA) But until it works, I'm okay.

I could rent a server to build, but I can't afford to maintain it. And also, there's still the problem that I can't flash many times over every day.

When, and if I get a new phone, I could then think about taking a build server, since I wouldn't have the problem of not having my main device.

Dev'ing on your main device is uncomfortable, yes.. But I like it. Until there's people who enjoy my work, I see no reason not to keep on building.
[ONE Android Development] LucentBirch:
Understood! Not sure of the particulars about building on an ssd, but that's what my desktop has right now, so perhaps not what you'd want to do anyway, haha. Wish I could donate, though -- living is a bit tight over here atm, unfortunately. For now, though, if everything continues to work, and work well, I'll stick with where the camera is the best. :D You said you were trying to get the snap camera put in here earlier, I think? Wish it were possible to get the OP2 + OP3 camera on here -- love the ui that OnePlus did on those.
[ONE Android Development] mp3deviant721:
When I asked about the LED controls I was asking about a stock feature that's in the stock ROM. It may be a customization for AOSP but it's OEM for the phone and I believe it wouldn't be a customization per se. I still understand if you're still adamant on not adding it though. And if you absolutely won't, this is the last time you'll hear about this from me. Promise. ?
[ONE Android Development] ggg333:
opengaaps install failed

Thank you for putting your time and effort to make the Bacon better. I ran in to an issue when i tried to flash the rom

File Name: AOSPlusone_bacon_110117.zip

File Size: 359.31 MB

File MD5: 1ae5f1aa9bd2f6f4c0277dc72739b69f

Developer: freshgiammi

I also downloaded the opengapps mini/micro/stock, the rom flashed just fine, but when i tried to flash the gapps, it said the version of rom that iam using is 6.x and the gapps is compatible with only 7.xx. I have used other nougat rom's with no problem. I did a wipe/Factory reset so its not the dirty flashing. Not sure if anyone else faced this problem(i did go through the link apologies if i have missed).

Appreciate your help.
[ONE Android Development] Gawd:
I too remove the pull down to quick settings, the first thing.

There's only one thing "I" want. Menu button changed to recents and long tap on menu button to multi-window mode/ split screen.

And regarding the camera, is everything the same as sultan's CM13? Like all the slow and high motion video recording stuff. Because that cam (everything included) is the best imho

And clean, pure AOSP. That flows like liquid. ^-^

---------- Post added at 03:45 PM ---------- Previous post was at 03:32 PM ----------

:)
[ONE Android Development] freshgiammi:
Do not worry about donations. They are always welcome, but I'm not asking for them. (Also living is tight here too sadly, but we keep up)

And oh, OP camera.. ya mean this one? ;P

[IMG="OP Camera"]https://i.imgsafe.org/79528c5ad9.png[/IMG]

It works, but after you stop recording a video you have to close and re-open the app or you won't be able to use it again. It just freezes. Link is here, choose the sultanxda version zip.

Was it? I don't remember it honestly. I'll look into it. I haven't been able to add gestures, too... hope i can make them work in the future, but it's not in my top priorities.

High motion works for me, slow isn't still working. IDK if CM has it working too. I'm building right now with a few possible fixes to that and to make Snap Camera build. Can't promise anything tho!
[ONE Android Development] LucentBirch:
Yeah, that's the one! I have used different ports in the past, but for some reason, whenever I go to edit the photo in Google Photos (not that I do it that often) it gives me an error (Can't edit pic of 50x50 pix -- or something like that). I will give this version a try and see what happens. Though, any pictures I take is usually with snapchat and saved to my phone -- don't really take too many pictures otherwise.

Edit: Looks like this one is done much better -- I can edit photos in google photos. Also see what you mean by the app freezing with video. Don't have to close the app, though. Just swipe over to the video, start watching it, and then swipe back to camera and it's ready to go. Weird bug to have, haha.
[ONE Android Development] freshgiammi:
Oh, yeah it works this way too! Cool, I won't have to close and open it again the next time. Thanks for letting me know! Weird bug indeed haha
[ONE Android Development] molohov:
Seems to happen to me with a number of Nougat roms. You have to boot the ROM first, then go back and flash gapps. It will work then.

[MENTION=4986658]freshgiammi[/MENTION], the ROM doesn't boot as Multirom primary after I flash SuperSU. Does it work for you if you are not using Multirom?

For some reason when I flashed this ROM as multirom primary it completely messed up one of my secondary ROMs. Is there some kind of f2fs stuff going on here? My phone is ext4.
[ONE Android Development] LucentBirch:
I think you can just reboot to recovery and it will flash normally -- or is that a different error I'm thinking of?
[ONE Android Development] Papi72:
Yes for me too just reboot recovery after flash rom and then flash gapps, it works.
[ONE Android Development] darjwx:
For me it takes usually like 5, 6 hours more or less on a clean build...

I remember the days when I built dirty on 30 Min and clean on 1 h an a half hahaha.
[ONE Android Development] ggg333:
Yes that's what was recommended and it did work, i just did a reboot and flashed the gapps. Went back to another ROM as i didn't have the su binary downloaded. Once i have, will come back to this ROM.

But on none of the nougat's i was able to flash the Stock gapps. And the face unlock never worked for me, wondering its no supported on bacon?
[ONE Android Development] LucentBirch:
What gapps are you using? I'm using opengapps micro and face unlock is working for me...interesting.
[ONE Android Development] ggg333:
opengaaps mini is what iam using. I set up the pin and then go back and enable the face unlock, do multiple scanning of the face. But it never works. Am i missing something? Appreciate your help :)