yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy S 5 Unified Development] jdrch:
You're welcome!

My original official bug report was on the now defunct CM JIRA. Otherwise I've reported it both on this thread and also in the TWRP support thread.

This probably requires wrangling with ADB, which I don't like (generally I try to avoid anything with command lines due to the risk of command error.) I have no idea of or experience with how to do that. OTG is just the easiest solution for me.

The only thing that can reasonably be backed up to an external SD card is internal storage. Otherwise, you're storing the backup on the same partition (and physical medium!) as the data, which doesn't make it a truly failsafe backup.

My original adoptable storage post explains how to backup everything on your phone. To recap: use nandroid for your /system and /data partitions, and then use network transfer (any protocol you choose will do, it's totally up to you,) OTG sneakernet, or ADB (I don't know how to do this) to backup what's on the adopted card.

I've never done this before and cannot guarantee it will work. IMO if you're gonna clean flash you might as well also start over from scratch with adopted card (restoring files from a backup), but here's how I'd do it:

- Download latest LOS build to USB drive.

- Turn phone off.

- Remove adopted SD card.

- Boot into recovery (TWRP).

- In TWRP, do a nandroid backup to USB OTG drive.

- In TWRP, wipe the phone.

- In TWRP, flash the latest build using USB OTG storage.

- In TWRP, restore the /data partition from the USB OTG drive. Remember, it is the /data partition that "pairs" uniquely with the adopted card. The same data partition on different builds of the same ROM should work with the same adopted card.

- Reboot into system.

- Wait for system to boot completely.

- Go to Settings -> Storage.

- While phone is running, reinsert adopted SD card. You'll see "SD Card Checking ..." or something like that appear on the Settings screen.

- Wait for the check to complete and the adopted card storage to appear. Once that happens you should be good to go, except that because you wiped the system partition before flashing your system and data partitions may not be "in sync" (i.e. the system partition thinks it's on a brand new device, while the data partition thinks it's on the same device it was previously. Also, I may be wrong about that.)

I don't know exactly how to do this, because there typically isn't any need to know unless you're developing your own flashable apps. If a developer makes a flashable app, they typically provide the flashable zip for it as that's the only way other people will be able to use it. There is a way to do it, however.
[Samsung Galaxy S 5 Unified Development] bytes2bits:
Will this still run with an Lollipop bootloader or has that changed since the start of this thread? Thanks.

Update: I can confirm (at least in my case) that this rom will not run with an LL bootloader.
[Samsung Galaxy S 5 Unified Development] jdrch:
I'm not sure if it will, but you can safely update nearly all non-/system & non-/data partitions anyway. If your phone shipped with a locked bootloader and currently has an unlocked one, do not under any circumstances update it. Otherwise, go right ahead. Details here.
[Samsung Galaxy S 5 Unified Development] bytes2bits:
Thanks for replying but that's not my situation at all. I'm currently on an MM bootloader and running a variant of this rom with no issues. The problem is I travel overseas once a year and want/need to run a stock Sprint LL rom while I'm there in order to have service. I'm wondering if I can flash an LL bootloader and still continue to run this rom after flashing the LL bootloader. I'm trying to avoid flashing the bootloader back and forth as needed and would rather stick with LL if it will work.
[Samsung Galaxy S 5 Unified Development] jdrch:
Wait, are you referring to bootloader or modem firmware? I guess I'm not really seeing how the bootloader, specifically, could affect you getting service.
[Samsung Galaxy S 5 Unified Development] bytes2bits:
I'm referring to the bootloader. It's not that the bootloader gets me service. It's more so that I have to run a stock Sprint rom in order to be able to use Sprint global roaming (which is free!). The LL stock rom works much better for me. I used the MM stock rom last trip and a lot of things about it were a hassle. I'm just exploring options in advance of my next trip.
[Samsung Galaxy S 5 Unified Development] jdrch:
Ah I understand. And I have no idea, unfortunately.
[Samsung Galaxy S 5 Unified Development] fitittome:
Curiously, the Google Pixel C also uses the same BCM4354 chip that the S5 uses according to https://wikidevi.com/wiki/Broadcom I don't think Google class it as end of life yet. There maybe hope!
[Samsung Galaxy S 5 Unified Development] JohnnyMwanza:
Testing

ama give it a test too and get back to you later
[Samsung Galaxy S 5 Unified Development] Paul_Lunardi:
Hi there

Thanks after having cleared cache dalvik it worked.

Thank you

Thought it may have been a bug.

Tried the software restart which worked too.
[Samsung Galaxy S 5 Unified Development] bencetari:
I think the only useful way is to get biohazard soundmod and replace the ****ty audiofx. If you want clear sound. Audiofx is not your friend. But Viper Dolby and am3dzirene IS. It's compatible with android 7.0 so you can download the aroma installer (TWRP RECOMMENDED) select what you want instal reboot turn seandroid to permissive and you are ready to go.
[Samsung Galaxy S 5 Unified Development] v00d007:
No thanks, never was a friend of this bloated viper sound tool. I just want AudioFx back to it's former options as there were and working fine up to LP. I really wonder why the devs removed the support for all other sound devices anyways...?
[Samsung Galaxy S 5 Unified Development] omgbossis21:
Viper audio isn't the bloat it once was. Now its just a single app you flash in recovery and install the driver from app. All settings are adjusted from a single app and I've not found any sound mod comparable. Admittedly if your using vipers HiFi processing it can eat some battery when playing music but mines usually on charge in the car jamming out.
[Samsung Galaxy S 5 Unified Development] wieman01:
Relax, dude. Your interpretation of "blame" is supposed to mean in this context may be a little biased. This was a mere observation on the user's part and speculation at best. He wasn't even asking for your support. As simple as that.

How about we change our style a little and respond in a more appropriate and less condescending manner?!
[Samsung Galaxy S 5 Unified Development] omgbossis21:
It seemed pretty clear the original guy was on a newer build WO the newer kernel. Boeffla takes a little time to make new ones off the new builds and likely that was the issue. Lord boeffla is awesome and I appreciate what he does for us. I took the same from the post he did, that he was blaming boeffla opposed to "oh I just needed to wait for the updated kernel". We've lost so many developers over users that are unappreciative,disrespectful or outright oblivious to the fact that we don't do XDA for a living. I wasn't going to say anything about op's post but I knew someone would and I'm actually glad it was the man himself and he was cool enough to get a laugh out of it. I originally developed when android was gingerbread, 2.1, 2.2 etc. I tried to build cm7 I think it was for a device that wasn't popular and it was my first go at a device tree. Once I got a bootable build I released it hoping to get others to help. I got a little help and a ton of crap, not limited to PM's about my crappy broken ROM as if it didn't state in the first post that it basically only booted at the time. Those members pretty much made me decide screw it, not worth it.

Anyways I digress, maybe op didn't mean to come off the way it sounded (or maybe he did I don't know). Maybe occasionally reread your post particularly when your discussing a developer(s) to make sure it doesn't possibly come off the wrong way and of course just refrain from any negative comments and eta talk.

Back on topic I'm looking into the Bluetooth issue where we can only send certain file types, just need time to sit down and work hasn't been letting me leave!
[Samsung Galaxy S 5 Unified Development] fitittome:
I used a custom kernel once and my cat got fleas. Never again. :laugh:

Anyway, I was curious about your bluetooth problem and asked a question but I am pretty sure you know the answer from what you said above.

https://www.reddit.com/r/LineageOS/comments/6qvzls/editing_framework_xml/
[Samsung Galaxy S 5 Unified Development] KazuDante:
Im a kltevzw user , you can clean flash the klte to you verizon s5 no problems at all since all roms now have merged except crdroid wich still builds seperate build for each variants that it supports which is a refreshing thing to see. but in the case of LOS klte is the way to go for the kltevzw(g900v) ive been flashing it for months now and have not comme across any problems that would hinder it from being a daily stable driver. but do make sure its a fully clean wipe/install , itend to do it that way to further avoid any potential problems.
[Samsung Galaxy S 5 Unified Development] sunilpaulmathew:
Dear [MENTION=947981]Lord Boeffla[/MENTION], We all know who you are and your contributions to the community. Users have their on opinions. Some one even criticize others hard work with absolutely no evidence and with out any basic tests. You don't need to responded/consider someone's stupidity. Just like they all have the right to criticize your hardwork, you have all the rights to ignore...
[Samsung Galaxy S 5 Unified Development] omgbossis21:
Actually I was working on this on my lineageOMS ROM and I asked the cm13 guys to screenshot where it ask you to allow to send all files for Bluetooth. I'm cluess where to look as I don't recall where or what menu that question was at. I already did a dirty hack to try to make it send all files. From what I see we have all the code but lost the GUI part w the option. I haven't updated my ROM on my phone to pull my Bluetooth apk but if u want to see if what I did worked grab my lineageoms ROM (latest one) from my thread,replace your Bluetooth.apk file with mine and see what happens. If that don't work try the lib file in system-app-bluetooth-lib and try again. I know quite a few have grabbed my ROM but no feedback so far.
[Samsung Galaxy S 5 Unified Development] fipsy:
As I already supposed in my first posting and noted in the kernel thread the problem occurs if the WhatsApp folder is bound from the external sdcard to the internal card with a mountscript created by Apps2SD. If you don't use folder binding you will not notice any issues!

Just for those who don't read the boeffla thread: It's not possible anymore to unbind folders within Apps2SD that have previously been bound with an Apps2SD mount script. This is a new issue related to boeffla kernel 2017-08-02. If reverting to the previous kernel version, binding and unbinding works without any issues. You may reproduce this on any LOS installation with boeffla kernel 2017-08-02.

[MENTION=7060205]sunilpaulmathew[/MENTION]: What may happen if developers constantly ignore critical voices you can see in the VW diesel scandal. One can discuss the form, but not the content. I'm a DOS / windows developer since 1986. And I have always been happy about ANY form of criticism or error message. It helps me to become better every day.
[Samsung Galaxy S 5 Unified Development] omgbossis21:
Constructive criticism with some content to back it is always welcome. If it wasn't we wouldn't have bugbash,got pushes etc. Its just when someone says "my Bluetooth don't work on omg's latest rom ,reverting to last build works." "Update its definitely omgs fault BC Bluetooth works on on official latest". Usually they give vague info, or dirty flashed (not supported in this thread) and have no logcat. Roms are always a work in progress, we encourage reporting issues (the right way) while including your variant,build,mods like xposed and has it states in post one of this thread, aftermarket kernels are not supported so don't expect help with them. Boeffla has its own thread, I'm a user and I love it. This is why in my thread I gave a template for reporting issues.
[Samsung Galaxy S 5 Unified Development] cal002:
Glonass

Had some time to look into why Glonass signals don't seem to be used for GNSS fix

(BUGBASH-383).

I'm writing this here for lack of a better place since Jira doesn't allow me to

add a comment to a closed case.

TL;DR: I think Glonass signals are actually used for the fix, but a Qcom screwup prevents it

from reporting the "used in fix" status for Glonass to the framework , and also caused

wrong "used in fix" reports in cm-13.

klte uses Samsung's binary gps HAL so I can't be 100% certain, but it's derived from

Qcom's gps HAL where source is published on CAF.

The Samsung binary, as well as the Qcom gps HAL source, use the old (pre-N)

gps_sv_status_callback which allows to report only 32 satellites, not the new

gnss_sv_status_callback which supports 64. The data structure passed is

GpsSvStatus. gps.h does not document the meaning of the

bits in the used_in_fix_mask, but the Java API docs and Java code make it clear

each bit corresponds to one GpsSvInfo entry in the sv_list.

LocApiRpc::reportSv() is the function which converts the status report from lower

software layers to the gps.h API. As you can see Qcom scewed up and set the used_in_fix_mask

bits based on the satellite's prn (pseudo-random-number, in newer API renamed svid, the

satellite's identification number which is in the range 1 to 32 for GPS) instead of using

the index number into the sv_list. And note that used_in_fix_mask

is only set for GPS, not for Glonass.

Update: LocApiRpc is old actually used on klte is LocApiV02 which talks to modem via qmi.

It has the same issue as LocApiRpc in LocApiV02::reportSv().

cm-13: The status info is just blindly copied and the used_in_fix_mask misinterpreted,

i.e. when Qcom says "GPS satellite with prn 5 used in fix" then framework Java gets "satellite 5 in the

sv_list used in fix", it could be a Glonass satellite.

cm-14.1: The status info is converted to a format compatible with the new GnssSvStatus,

and here the used_in_fix_mask is interpreted to be compatible with Qcom's implementation

for GPS only.

The bottom line:

the old gps HAL API doesn't allow to report "used in fix" status for Glonass

cm-14.1 code correctly reports this to apps while cm-13 code was buggy

BTW, I think the A_GLONASS_POS_PROTOCOL_SELECT from gps.conf only

selects assistance protocol for A-GLONASS, setting it to 0 doesn't disable

using Glonass satelltes for GNSS fix.

If there is a device which uses the open source gps HAL one could add some debug

prints to confirm the "used in fix" status for Glonass.
[Samsung Galaxy S 5 Unified Development] signupstuffid:
I also would like to know if Broadpwn has already been patched. I saw on reddit that you can run a terminal command to check. See link below:

https://www.reddit.com/r/LineageOS/comments/6n4xdm/is_lineageos_patched_for_cve20179417_broadpwn/

Also, I'm not sure why the reddit had a different cve number, since everywhere I have seen it says it is cve-2017-3544.

I looked in the changelog on lineage site and didn't see any reference to this cve, or broadpwn, so short of installing the ROM and running the command, I don't see any other way to verify.

I looked at the kltespr device log, as that is what I'm looking to patch.

https://download.lineageos.org/kltespr/changes/
[Samsung Galaxy S 5 Unified Development] lollipo:
My camera doesn't open after sometime booted on last nightly (2.8). How to fix this?
[Samsung Galaxy S 5 Unified Development] fitittome:
Mines fine. Try Wiping dalvic cache. Otherwise if that doesn't sort it post a logcat up here.
[Samsung Galaxy S 5 Unified Development] Robby69:
Hello

I have bluetooth issue on my S5 LineageOS since quite some time and also on the latest nightly (1.8.). My problem is that one bluetooth device will not be recognized at all. I cannot see it when scanning.

On another (not Lineageos) phone I can see and can connect to it. I searched in the internet about bluetooth issues with LineageOS but I could not find people who have trouble detecting a bluetooth device. Is there someone who has a simlar issue?

Maybe it is a problem of the baseband ROM version. I have no glue why I cannot see this device.
[Samsung Galaxy S 5 Unified Development] fitittome:
I think cve-2017-3544 is a completely different problem. Also, I don't think that redit command will run on a phone terminal. I think you need to have your own build locally and run the strings command against that.

I guess that the Samsung supplied Broadcom WiFi drivers will be here somewhere:-

https://github.com/TheMuppets/proprietary_vendor_samsung/tree/cm-14.1/klte-common

Hopefully Samsung will release something in due course.
[Samsung Galaxy S 5 Unified Development] jdrch:
Given the level of interest in my adoptable storage explainer, I've started a related thread listing devices and ROMs that support it.
[Samsung Galaxy S 5 Unified Development] fipsy:
I totally agree with you! But sometimes you don't know from the first moment what exactly is the cause for a failure. Then you try to post something here in this thread to perhaps find users with the same problem. That was what I have done! In the next few days (if you have enough time) you try to encircle the issue. In my case first to a problem with the kernel, then to a problem with binding folders from the external sdcard and finally to a problem when the sdcard is exFAT formatted. All this took me 2 days of work on a test device to create a reproducible scenario (you may read it here: https://xdaforums.com/showpost.php?p=73312010&postcount=3521). My first assumption that it's LOS-related was wrong. But the other assumptions have been accurate. So I feel quite disappointed about the reactions I got. I would have expected a bit more support.
[Samsung Galaxy S 5 Unified Development] omgbossis21:
nm
[Samsung Galaxy S 5 Unified Development] fitittome:
Just a heads up. If anyone else has the confusing issue of having to enable MTP from the notification bar to get ADB working properly. It seems to be a compatibility problem with the Samsung USB Drivers. On a Windows machine I removed the official Samsung install and updated the drivers with the Google generic version. works much better with ADB and seems to work OK with Odin too. Untested with Samsung Smart Switch.
[Samsung Galaxy S 5 Unified Development] mattnin:
What is the best camera app to use? Best settings? My pictures often come out blurry. Every so often they come out great though! I miss a lot of good moments though trying to use the S5 camera with Lineage... Help!
[Samsung Galaxy S 5 Unified Development] fitittome:
Everyone has their favourite but checkout:-

https://play.google.com/store/apps/details?id=com.marginz.snap

I paid (the price of a beer) but I think there's a free version.
[Samsung Galaxy S 5 Unified Development] jdrch:
Snap Camera works best for me.
[Samsung Galaxy S 5 Unified Development] bruce the boss:
I am using open camera for a long time.

Verstuurd vanaf mijn SM-G900F met Tapatalk
[Samsung Galaxy S 5 Unified Development] sparky7231:
Hello,

After the latest update, I'm having problems with screen rotation.

Did anyone else having this problem?

I haven't read any comments on that in the last pages of the thread, so I think is just an issue with my phone.

SM-G900F

Thanks

Giorgio

Inviato dal mio SM-G900F utilizzando Tapatalk
[Samsung Galaxy S 5 Unified Development] bruce the boss:
And what are the problems? I don't have them.

Verstuurd vanaf mijn SM-G900F met Tapatalk
[Samsung Galaxy S 5 Unified Development] sparky7231:
No screen rotation at all, is impossible to see full screen YouTube, for example.

I can only manually choose how orientate display.

Inviato dal mio SM-G900F utilizzando Tapatalk
[Samsung Galaxy S 5 Unified Development] eurohunter:
For G900P kltespr

Can the users of G900P kltespr please confirm if they have the same two issues as I do? They both seem to be related to the phone being recognized as CDMA or GSM (also discussed on bugbash nr. 37, in jira)

- After a reboot, if phone immediately connects to LTE, SMS send issue persists (phone seems to be on GSM LTE), but for subsequent switches to 3G and LTE , SMS send issue is resolved (phone switches and stays on CDMA LTE)

- Phone does not automatically reconnect to network after losing service to Airplane Mode. This issue seems to be related to GSM vs CDMA as well. If the phone is recognized as GSM (this was the case when SMS send wasn't working on LTE), Airplane mode issue is not present, but if phone is recognized as CDMA (3G or LTE when SMS send works), the phone doesn't automatically reconnect.

If a G900P kltespr user does not have either of these issues, please let me know.

These are the only two issues that I have found to be specific to the kltespr variant of GS5.
[Samsung Galaxy S 5 Unified Development] chichareal:
Any help for xposed 7.1.2
[Samsung Galaxy S 5 Unified Development] bytes2bits:
I'm not sure about the first issue. I'll have to experiment a bit. I do know if I put the phone in airplane mode and then switch airplane mode off I can't get a signal back. I usually click on Cellular Networks and then Carrier Settings (under settings). This causes Carrier Settings to crash and the signal to return.

Update: I experimented with the first bit and I had the same problem you described. Once I switched to 3g my text sent and then after switching back to LTE it continues to send fine. After initial boot on LTE it would not send until switching to 3g. I'm not sure how you can tell it's on GSM though. My preferred network type is set to LTE.
[Samsung Galaxy S 5 Unified Development] yurkennis:
This message on TWRP support thread? So in your case, a reboot from recovery with non-internal storage selected was what led to corruption, not actually a backup or other user-invoked write operation?

By "storage is selected before rebooting", you mean TWRP menu Mount > Select Storage > Internal Storage, right?

BTW, have you considered reporting the issue to TWRP Issues at GitHub and LineageOS Jira? I wish I could report it myself, but still have too little information to localize or reproduce it.
[Samsung Galaxy S 5 Unified Development] jdrch:
That's an interesting way to think of it.

The problem with this bug is the only way to reproduce it is to (risk) blow(ing) all my adopted microSD card data away. Re-syncing that data and setting up apps that rely on it is a major PITA, and so I can only tell you what I recall from the bug. I'm not about to try to reproduce it anytime soon (unless I magically get another identical S5 to play with.)

You can see how reporting it on the TWRP GitHub and/or LOS JIRA without being willing to attempt to reproduce it would not be very helpful. If you'd like to test the issue yourself, go right ahead. For now, I've found an effective workaround and am sticking to that.
[Samsung Galaxy S 5 Unified Development] eurohunter:
The GSM issue was discussed on the Jira Bugbash 37 for the SMS send issue. Someone said that they could check by using the app Network Info II, and under device, the phone type would show as GSM when on LTE. But now that the issue is fixed, the GSM is shown only on initial boot (even though not every single time). subsequent switch to LTE would make the phone stick to CDMA.

This is the possible fix for the sms that was included in the 0426 build: https://review.lineageos.org/#/c/169021/

You can also check by going to Settings -> More -> Cellular Networks screen. If I don't see the options "System select" and "CDMA subscription", then it probably is under GSM mode (strange), and I also cannot send sms.

For me it's easier to detect because i'm on Virgin Mobile, and when it shows that I'm connected to Virgin Mobile, I know the sms will work. But when it shows that I'm connected to Sprint service (which i'm not since i'm a VM user), I know that i won't be able to send the sms because of this particular issue. But for sprint users, it will probably just show Sprint in both cases.