yashsingh1/xdaforums huggingface dataset:
[Nexus 5 Android Development] androcraze:
Radio is under: Settings -> About phone -> Baseband version

What do you mean "choosing high accuracy doesn't change anything"? It's set to "High accuracy", and you have at least two apps that have (successfully) requested that permission. Are you getting an error, or is something failing to function when using GPS?

The mode requested by an app is determined by the app. If Google Maps needs High accuracy, it will request it; otherwise, it will request the mode it needs at the time. Just changing the setting to "High" doesn't mean all app requests will convert to High as well.

My understanding is that by selecting "High", the app won't need to ask your permission to tweak Location, or ask you to tweak it for the app to work; it's simply making it available if needed.
[Nexus 5 Android Development] fKm:
Well, it is because Google Fit asks me to activate the high accuracy mode every time and it doesn't help when I activate it in the settings. Maybe it is an app fault, gonna do further tests.
[Nexus 5 Android Development] androcraze:
Check the Permissions under Google Fit, see if Location is made available.
[Nexus 5 Android Development] fKm:
It is and I just deleted the whole data from Fit but it's still the same. Minimal Elegant (Google Wear) is asking me the same every time so I think it is a ROM issue. Maybe I am going to flash it again and see if it helps.
[Nexus 5 Android Development] androcraze:
You could also try UntouchedAOSP and see if it behaves the same; if it does, then it's an AOSP issue.

If it's asking for "High accuracy", you grant it, and it works (for that instance), it's not a GPS or Location issue.

Not sure why it's not "sticking". Did the app behave differently with a different 6.0.1 ROM? The app itself might be the culprit, either for security or battery-saving measures.
[Nexus 5 Android Development] androcraze:
Other devices have this issue too:

http://xdaforums.com/mate-8/help/google-fit-location-disabled-t3426891

When doing a general search on XDA for "google fit location", I see many hits for location battery drain. Perhaps the app is behaving this way to save the battery.
[Nexus 5 Android Development] Scott:
Glad I could help out :)
[Nexus 5 Android Development] androcraze:
Great Scott!

We're not worthy! We're not worthy!
[Nexus 5 Android Development] roshan2989:
can you odex the whole rom?
[Nexus 5 Android Development] androcraze:
I'll have to look into this. What's the advantage?
[Nexus 5 Android Development] roshan2989:
checkout here its the same as google stock,just want to try your rom..
[Nexus 5 Android Development] androcraze:
If you read the answers to the question in link you provided, I'm seeing an overwhelming recommendation for deodex.

I really don't see much chatter about odex vs. deodex anymore. The folks who use deodex ROMs use them for a reason:

1. Deodex permits easier custom theme-ing

2. Deodex is ONLY slower on INITIAL boot. Subsequent boots build the Dalvik cache to the point where there should be no discernible difference

From Post #1 in this thread: http://xdaforums.com/showthread.php?t=2200349

I've looked at this in the past, and I've never seen a compelling reason to prefer odex over deodex. As I'm not even using my ROM until the 3rd reboot, the Dalvik cache is well-established by the time my ROM is running full-steam. From a speed concern, it's a moot point.

I'm also concerned about alienating users who want to customize this ROM. This ROM (along with any other "vanilla" ROM) is a fine basis for building a ROM to suit your needs.

I'm not saying "no" or "never". I'm just looking for a reasonable, realistic benefit to one vs. the other.

BTW, have you looked at this?: http://xdaforums.com/showthread.php?p=44228706
[Nexus 5 Android Development] androcraze:
You can try the ROM (without odex). I won't tell anybody ;)
[Nexus 5 Android Development] BreckZeBoulay:
[MENTION=5061138]androcraze[/MENTION]

do you think there will be a november update ?
[Nexus 5 Android Development] androcraze:
Yes. I'm thinking we'll have one.

Rowhammer is an ugly exploit that begs patching. That fix is supposed to arrive in the November update.
[Nexus 5 Android Development] androcraze:
The answer is "no".

The Nexus 6 got two MM updates in November, the N5 got zero.

I'm seeing MMB31C & MOB31K. I don't know what the changes are yet. They could be device specific, or they could be something else. I'm suspecting the latter.

I'd be surprised if it was a significant security update. If it is, I may pull-down the manifest and try building it. I'll need to see change logs.
[Nexus 5 Android Development] amnher:
do we are now on nov security update?
[Nexus 5 Android Development] androcraze:
There was no November Security Update for the Nexus 5. The Nexus 6 was the only Nexus device to receive a Marshmallow (6.0.1) update.

So I'll make my own for now.
[Nexus 5 Android Development] amnher:
Yeah so security update will still go on
[Nexus 5 Android Development] swat4samp:
Thanks a lot for providing marshmallow updates mate :) I tried nougat but reverted back to mm as it's still not stable (although it can be used as daily driver) and I miss Xposed :D
[Nexus 5 Android Development] fKm:
Hey [MENTION=5061138]androcraze[/MENTION], in the previous version I suffered from the GPS problem (I think you know what I mean, we discussed it here). Do you think that problem can be caused by using different gapps packages (i.e. OpenGapps)?

Gonna try your latest build (or my own build with UBERTC and DragonTC) today or tomorrow and will use the gapps package you mentioned. Hopefully it works then ;)

Thanks for the efforts and the patches you provide in this thread. They are very helpful for me while building on my own.
[Nexus 5 Android Development] androcraze:
I don't think your issue is either a ROM issue or a GApps issue. I'll give you my reasoning:

I run two apps that use GPS: Google Maps and Forecastie (a fine weather app). Both apps request "Location" permissions, and I grant those permissions. Once set up and as long as that app remains installed, I don't have to go back and do anything else. If I update Maps, I may have to grant permission again, but only once per version or install.

For both of the above apps (and additional apps using GPS), it's a "set-up-once-and-walk-away" scenario. Both apps work (I get weather listed for my location, and Maps works well while travelling). Again, I only have to "touch" each app once. Compass apps I've installed worked well too.

If I installed four GPS apps, and one of the four didn't behave properly, I'd blame the app; if only one of the four worked, I'd blame the ROM.

I've installed Google Fit, and I'm seeing exactly what you are: I set it to "use high accuracy" in the app, it takes me to location settings (which are set to "high accuracy" already), and it does NOTHING. The app will not work properly, and it never appears to make a request to Location, despite being told to do so.

I don't have an answer to this dilemma. Google Fit is included in the factory ROM. Does it work there? Possible issue:

http://xdaforums.com/showpost.php?p=69171945&postcount=2742

Counter-punch:

http://xdaforums.com/showpost.php?p=69430953&postcount=3569

I tried the GMS location fix in the links provided above. It's two lines added:

--- frameworks/base/core/res/res/values/config.xml	2016-10-17 09:04:51.000000000 -0500
+++ frameworks/base/core/res/res/values/config.xml	2016-10-17 09:10:01.409761348 -0500
@@ -1174,6 +1174,8 @@
that matches the signature of at least one package on this list.
-->
<string-array name="config_locationProviderPackageNames" translatable="false">
+ <!-- The Google provider -->
+ <item>com.google.android.gms</item>
<!-- The standard AOSP fused location provider -->
<item>com.android.location.fused</item>
</string-array>

All hell broke loose when I built with that patch; Google Play Services continually crashed no matter what permissions I gave. We're not talking every 30 seconds; the crashes were occurring every 3 to 5 seconds. Building without it works fine. That patch does nothing.

I can't find an AOSP ROM that has done anything with location services. All ROMs seem to do exactly what I'm doing: nothing. Perhaps I need to pull a library from the factory ROM and add it. Dunno.

I think Google did some custom tweaking in their factory ROM to get Fit to work. It may be a factory-only option.
[Nexus 5 Android Development] androcraze:
Glad you find them helpful. I think the patches provide a better understanding of code changes; it sucks when someone points you to github and you have to figure out what changes are actually relevant.
[Nexus 5 Android Development] androcraze:
Solved! ( I think)....

Instead of downloading it from the Play Store, try flashing the stand-alone GoogleFit app from Post #1 in DeltaDroid's GApps:

http://xdaforums.com/showpost.php?p=58047099&postcount=1

The issue is that Fit wants to be a /system app, not a /data app. I flashed the zip, and all appears to work.

GoogleFit is a system app on the factory ROM. Even though it updates from the PlayStore to /data, the original resides in /system.

I need to make a note of that for reference; some apps, even though Play Store available, need to be flashed.
[Nexus 5 Android Development] fKm:
That doesn't work for me. Fit is still asking for high accuracy every time I start it :(

But thanks for the investigation. I really appreciate it.

Btw: Never had such problems with other AOSP ROMs.
[Nexus 5 Android Development] swat4samp:
Just a heads up: installing xposed on latest version causes bootloop. I think it has something to do with november security patch.
[Nexus 5 Android Development] androcraze:
So that's an xposed issue, or a ROM issue?
[Nexus 5 Android Development] androcraze:
OK. Looked at this again.

The Delta version, as-flashed, works as expected. When it ***UPDATES*** through the Play Store, it quits working (again).

Delta's Google Fit, before update:

So, older versions of fit appear to work, but the newest version (as on 03 NOV) doesn't. You can keep the older version, but that's a pain (you'd have to disable auto-updates, and install updates as notifications arise).

I posted a question in Delta's thread:

http://xdaforums.com/showpost.php?p=69601753&postcount=2850
[Nexus 5 Android Development] swat4samp:
It's Xposed issue which isn't compatible with latest security patches, nothing to do with your ROM :) I just informed beforehand so that others won't flash it.
[Nexus 5 Android Development] androcraze:
More further testing....

I downloaded the Google Fit APKs that I could find online from www.apkmirror.com (no DPI versions).

Each was installed, set to "High Accuracy" in Fit's Settings (with AlmostVanilla already set at "High Accuracy" in Location), and I started an activity (Walking). I was looking for two items:

1. It would pull-up Google Maps within the Fit app

2. It would leave a record under "Location -> Recent location requests"

Results are as follows:

1.56.14-008 - January 7, 2016 - Success (version in Delta's GApps)

1.58.09-100 - August 1, 2016 - Success

1.59.14-100 - August 30, 2016 - Success

1.59.15-100 - September 1, 2016 - Success

1.61.11-100 - November 1, 2016 - Fail

The last version that will work properly with AlmostVanilla 6.0.1_r74 is 1.59.15, released on-or-about September 1, 2016.

Looking back on your posts, October 26th is when you posted about the issue with r72. I'm guessing that was probably with the 1.59.15 version. Perhaps they fixed the 1.59.15 issues with r74, but didn't update enough to get 1.61.11 working.

So something was changed within the app between September 1 and November 1. It's not a complete answer, but it's progress.

I'll keep digging and continue to investigate.

EDIT: the APKs were side-loaded to /data, not /system.
[Nexus 5 Android Development] androcraze:
OK. Hopefully it will get fixed soon.
[Nexus 5 Android Development] androcraze:
What Xposed modules do you add when using this ROM?
[Nexus 5 Android Development] swat4samp:
Gravitybox and YouTube AdAway :D
[Nexus 5 Android Development] swat4samp:
Hey [MENTION=5061138]androcraze[/MENTION] , arter fixed Xposed bootloop issue on November security patch and here's the solution https://github.com/arter97/android_frameworks_base/commit/35724b039e7a990950100354d01467c05756de37

Can you please look into it :o
[Nexus 5 Android Development] androcraze:
I can add it. Some questions, though.

Is this a one-off fix (until a better solution is found), or will this be expected on subsequent builds?

Does this mean that Xposed is a custom-only ROM option?
[Nexus 5 Android Development] androcraze:
Sent you a PM.
[Nexus 5 Android Development] swat4samp:
Its just a temporary fix until rovo either finds a new way or merge this patch in framework. Right now, xposed doesn't work by default, so only way to make it run is to apply that patch.
[Nexus 5 Android Development] androcraze:
Almost Vanilla AOSP Xposed patch.

Removed - No need as the issue has been fixed, and the patched version was a hack at best.
[Nexus 5 Android Development] androcraze:
Downloaded Fit from the Play Store (v1.62.06-108), and it seems to work. Either they fixed the app, or something got fixed in r77.

EDIT: Nope. Worked the first time. When I exited the program and re-entered, it went back to it's bad behavior.
[Nexus 5 Android Development] fKm:
Meh, what a pitty. But thanks for testing :good:
[Nexus 5 Android Development] androcraze:
Updated to 6.0.1_r78-MOB31S.

This tag was originally intended for the N6, but it seemed to build fine on the N5. Right now everything appears to be working.

I used the drivers from the 6.0.1_r77-M4B30Z factory release. Modem and add-ons from r77 should work fine.
[Nexus 5 Android Development] androcraze:
Thank you for the feedback. Let's start....

1. It can be changed, rather easily. It's not a "bug", though, and it's completely accurate. "AOSP on HammerHead" is exactly what this version of AOSP is, where "HammerHead" is the Nexus 5. Is this causing issues for you, or is it just something you want to match the factory ROM?

I've tried keeping things as close to AOSP source as possible, with a focus on bugs and security as reasons for modifications. I even upgraded app icons to keep with a "Material" theme. I'm very happy with it as-is, and would prefer to keep "AOSP on HammerHead". To me, having "AOSP" there is a badge of honor. If it's causing a compatibility issue, I need to know that. I'll need to stew this over....

FYI, if you're building your own ROM, you can change it yourself in the file:

device/lge/hammerhead/full_hammerhead.mk

Look for the line: "PRODUCT_MODEL := AOSP on HammerHead"

2. So you agreed to High Accuracy mode, and it always stays on HA? What app(s) are you using that require(s) GPS? I ran into issues with Google Maps.... Last time it told me outright that it required HA mode, so I've left it there. I'll need to do some checking this weekend and see what happens with location. I think it's app-driven, and location services is an odd-duck under Android. GPS-only really drains the battery, doesn't it? Here's a read for you:

https://csullender.com/blog/2014/01/26/automatic-high-accuracy-android-location/

3. I've never used a fingerprint feature. I've certainly made no changes to the code regarding it. I wonder if it's a GApps feature, like FaceLock? I'm seeing fingerprint support for the 5X and 6P.... I wasn't aware that the N5 supported it. Here's a read for you:

http://www.guidingtech.com/57976/lock-apps-android-6-fingerprint-sensor/

4. Different applications use WebView differently. Your current apps might be behaving "sanely". The patch I applied came with the warning to leave to AOSP version in-place; my recommendation to folks is to leave it alone.

I'll do some searching.
[Nexus 5 Android Development] androcraze:
Look at post #8 here:

http://forums.androidcentral.com/sa...-my-location-mode-changing-high-accuracy.html

And here:

https://android.stackexchange.com/questions/137985/how-do-i-get-the-location-consent-prompt-back
[Nexus 5 Android Development] androcraze:
1. Funny. I think in terms of "HammerHead". When I see "Nexus 5", my mind converts it over. I've been using code and build names for so long, it's rather second-nature.

2. Dunno. Doing searches online, I'm seeing many folks with the same issue. I think some vendors "fix" it. Location is becoming app-driven, which has advantages and disadvantages. My feeling is that location is a mess. Read through this thread about Google Fit. It doesn't want to work right (maybe it's fixed, but I'm too lazy to check anymore). I felt bad that it wasn't working right, until I went to the developer's G+ page for Fit. After reading the reports, I felt privileged to even have the thing run without crashing.

3. Check this:

https://stackoverflow.com/questions...-rsa-dialog-when-connecting-usb-in-debug-mode

https://www.reddit.com/r/oneplus/comments/30cpux/no_rsafingerprint_window_when_entering_debugging/

4. OK. Understood.

I will gladly build-in a reasonable bug or security fix. If you can find the code or patch, I'll gladly play with it. Location and your RSA fingerprint issues are common to probably all Android devices. Maybe someone has a fix.
[Nexus 5 Android Development] androcraze:
This post is saying to try a custom/different kernel:

https://stackoverflow.com/questions...ization-is-not-listed-under-developer-options

If that's the solution, I may have to add that.
[Nexus 5 Android Development] swat4samp:
Thanks once again androcraze for keeping MM rom updated :good: While nougat based ROMs are stable for daily use, i still have some small issues like youtube videos freezing most of the times (even with youtube fix ) and high memory usage.
[Nexus 5 Android Development] androcraze:
Sounds like Google is tying Location Services to Google Play Services. Their right, I guess. I'm not aware of a work-around. Every Android revision puts more requirements on having Play Services running. Google's running a company; it's their code and investment. They technically don't have to release any source code other than the Kernel (GPL); I'm grateful that they still are releasing 99%+ of their code to the community.

"It's like the phone has direct access to any computer." I'm missing the concern on this.... I build a device, plug it into a Windows (or Linux) computer, and I don't get an authentication challenge; why is that my (or AOSP's) problem? How will adding a a challenge on AOSP's end improve the security of the device I'm plugging into? To me, it's like leaving the front door of my house unlocked; if you knock and ask to come in, my house isn't suddenly more secure because of your kindness.

If AOSP is challenged through authentication/verification, it responds, or at least it does under bluetooth. I imagine it would under other scenarios too. The mechanism to do so is there. AOSP is working as it's supposed to.

UntouchedAOSP offers a debloated factory ROM: http://xdaforums.com/google-nexus-5/development/rom-untouchedaosp-aug-17-2015-t3182377

There is an issue with the lockscreen; installing SuperSU then uninstalling it seems to fix it.

No clue about the tethering issue; if you find out more, please let me know. Most plans don't allow tethering, and in the mobile phone world it's an oddity.
[Nexus 5 Android Development] androcraze:
I won't run Nougat on my N5 until the video issues are fixed. As long as Marshmallow security updates keep coming, I'll stick with MM.
[Nexus 5 Android Development] swat4samp:
I too had similar thoughts, but since nexus 5 official support has ended and as no MM roms were updated, i installed nougat ROM. Thanks to you, i came back to MM :D

Regarding new update, i flashed with open gapps pico and got many play service FCs which was solved by giving permissions manually.
[Nexus 5 Android Development] androcraze:
Right now, N5 support is still going. They had a December update, which everyone (including myself) was sure wouldn't happen. Maybe they'll do an every-other-month update.

As long as the MM update tags show on GitHub, I'll build.

The FC's are expected. I refuse to build-in the GApps "fix" that bypasses security measures; it's a simple matter to manually set permissions for three apps then reboot the phone, and that's the intent to begin with. I have a procedure for Delta's GApps included in the OP; Delta's GApps are very modular and more in-tune with the way I run my ROM.
[Nexus 5 Android Development] swat4samp:
It's no big deal, apart from that FC, everything else is fine with open gapps. I just had open gapps as backup beforehand, hence didn't download any new package. Lets hope google will keep updating MM branch as well.
[Nexus 5 Android Development] androcraze:
Haven't had any issues with notifications on any of the apps that I run. I have Doze enabled; I wonder if that could be creating issues? You can disable Doze for a given app:

Settings -> Battery -> . . . Battery optimization -> down arrow -> All apps

A wireless charger would definitely fix the USB charging issue. The N5 does support that.

Best of luck. Hope you find something that works to fit your needs.
[Nexus 5 Android Development] swat4samp:
[MENTION=5061138]androcraze[/MENTION] Location isn't working on google maps even after enabling high accuracy. I downloaded gps status app, still i didn't get any lock on gps satellites. Can you please have a look at it?
[Nexus 5 Android Development] androcraze:
I'm not seeing any issues on my end with GPS Test and Google Maps:

.

When I try to select a route, Google Maps always seems to "fail" on the first attempt with "My location", but subsequent attempts work fine.

GPS will not work in my house's lower level due to the concrete blocks, so I have to move to the upper floor.

In the days of old, there were apps that would tweak the /etc/gps.conf, but I think most of these stopped working with Lollipop. I'd avoid them. Android and GPS settings should both be mature enough to where this isn't an issue.

If you're not able to acquire satellites with "GPS Test" from the Play Store, I'm not sure what software issue it could be. GPS is a hardware thing, and either it works, or it doesn't.

Was GPS working fine with another ROM?

Here are some tips:

https://www.technobezz.com/fix-android-gps-issues/
[Nexus 5 Android Development] androcraze:
I don't like tearing apart phones, but this is interesting:

https://www.youtube.com/watch?v=QBpNtWvY454

https://www.youtube.com/watch?v=K1-uCIb-t8I&feature=youtu.be
[Nexus 5 Android Development] swat4samp:
Hey thanks for your reply and detailed explanation. TBH i didnt really fully test with google maps as i just checked whether it will point to my location when battery saving is turned on. When it didn't work, i checked with high accuracy when i was inside home and came into conclusion. I reported because i never faced this issue so far (both on MM and nougat ). I will tweak a little bit and see if it solves :)
[Nexus 5 Android Development] scala_:
Thanks for being the only up-to-date MM rom. Keep it up, androcraze!
[Nexus 5 Android Development] androcraze:
I'm still checking for github updates; hopefully we'll have some more.
[Nexus 5 Android Development] scala_:
[MENTION=5061138]androcraze[/MENTION]

New March Security Patch has been released for Marshmallow. https://developers.google.com/android/images

Thank you!
[Nexus 5 Android Development] androcraze:
I'm building it already. I'll do some testing and see if it'll be ready to post.
[Nexus 5 Android Development] androcraze:
Updated the ROM to 6.0.1_r79-MOB31T.

This code base is for the N6, but it seems to build and install fine on the N5.

All of the 6.0.1_r77 add-ons will work fine with this ROM.
[Nexus 5 Android Development] scala_:
Sweet. Best Rom Ever!

Thanks!

---------- Post added at 02:58 PM ---------- Previous post was at 02:57 PM ----------

@androcraze

Is it okay to dirty flash? I have xposed and supersu installed
[Nexus 5 Android Development] androcraze:
Thanks.

I don't dirty-flash. I always wipe everything but storage, then flash the ROM.

For every 3 people extolling the virtues of dirty-flashing, you always seem to have one with a nightmare.

You can try and see if it works. If it doesn't, it's a quick-enough fix to wipe and reflash the ROM.