yashsingh1/xdaforums huggingface dataset:
[ONE Android Development] freshgiammi:
No prob. Thanks!

Nice spot haha, i wouldn't have thought about that!

Let's make this easy and clear: blobs are precompiled files that don't give us access to the source code.

Sultanxda used not to release the code of his HAL, leaving us with OOS camera blobs and his HAL blobs. Now that we have access to the HAL source code, we can trash the HAL blobs, and replace them with the ones built from the source code he now released.. Still, we need OOS blobs, because we don't have access to proprietary files.

tl;dr

1. OOS blobs (necessary, closed source)

2. Sultanxda's HAL blobs (now open source, replaced with the open source implementation)

To make this easy, we could say that HAL contains the "features" of the camera, while the OOS blobs have all the technical drivers to make the camera recognizable. (It's not the right definition but it's as noob-proof as I can be, not really great with words)

Sultanxda's HAL is not compatible with CM Camera Blobs, and it's better since CM camera has really bad blobs.

However some updates on the ROM.

Camera looks stable now. HFR/HSR has the improvements stated in the previous pages.

I'm working on SElinux (almost fully implemented) right now, hope to get a build this weekend. Still permissive tho, enforcing might be coming next week.

EDIT: Thanks to the ones who reported the HW keys status! I'm gomma leave the implementation as-is, since i've seen there's some movement in AOSPA (The place I took the commits from).

I'l probably wait for them to merge it and add it later. We're fine for now.
[ONE Android Development] se7enlyn:
I use the Google calendar widget+pixel launcher but there isn't any lag in my OPO.

Did you restore your apps or did you set up as a new device during installation?
[ONE Android Development] fireflyv2:
[MENTION=4986658]freshgiammi[/MENTION]

Hi, I'm using the 15th Jan build, and I'm getting some random reboots. Not quite clear why, but it happens when I'm using the phone. Happened a couple of times, and while doing different activities like browsing, watching a video and even playing Pokémon Go (lost a chance to catch a vaporeon!). Adding the last kmsg log I could grab after the latest reboot. Could you help me out?

I have grabbed other logs also right after the reboot, so if required, I can provide them.
[ONE Android Development] myshakugan:
Setup as a new device, but restored Google calendar from titanium backup.
[ONE Android Development] se7enlyn:
Delete that TiBu Google calendar app and data. Reinstall from the play store.
[ONE Android Development] Gawd:
Sleeps perfect
[ONE Android Development] myshakugan:
Already tried that, the launcher starts to slow down after a while unless I remove the google calendar widget.
[ONE Android Development] freshgiammi:
You did changes to kernel settings? Looks like it's kernel panic, not rom related.

However, the next build will probably need a few more days, SELinux is being problematic due to the new HAL
[ONE Android Development] lowlow2:
My first nougat ROM and it's gooood! After +1 year of sultan continuously. Choose it because of the sultan camera.

All working very smooth, only things I'm missing are the advanced reboot menu, battery percentage next to battery icon and lighting up screen when using a magnetic case.

Very stable rom and lightweight, highly recommended!!

Only thing, sometimes I have to reboot phone to get on mobile data. Only sometimes and had the same problem in some versions of android 4.4 and 5.x. Probably something with nougat. Thanks for this amazing ROM!!

Edit: re-enabling mobile data is a bit of a problem. Need to reboot almost always! Can other persons test this please? Disable your mobile data and WiFi for a couple hours
[ONE Android Development] indhimaga:
Stable and perfect for daily driver and best battery... Just missing the quick charging here...
[ONE Android Development] abdullah.ibn.umar:
Plz add charge level
[ONE Android Development] freshgiammi:
Charges at 2000ma without problems here.

Have you tried different radios? no problem here

1- Commands are okay but i don't use "make clobber"

2- I am aware of this problem but haven't solved it. I worked around it by setting a different out directory.

export OUT_DIR="/path/to/dir/"

3- Have you done changes to the repo? It should work just fine. Check your frameworks/base repo, you should have this https://github.com/AOSPlusone/andro...mmit/da870c7814a4f1154e586ac0b8f41d179fbcaefd

If you don't, repo sync the repo again.

plz no

However, managed to fix SELinux, so a build might be pushed today.

Still no F2FS, i might manage to get it working on the next build but i need someone to help me test it, since I can't change from EXT4.
[ONE Android Development] Gawd:
Charges very slow for me, negligible charge when screen is on. Takes 3+ hours when screen is off (not using).

Anyone with same issue?
[ONE Android Development] fabio.pagliuca:
Not here, charging is fine
[ONE Android Development] freshgiammi:
You have a 2A charger?
[ONE Android Development] Gawd:
Yes I do.

If you remember, I told you about sultan's charging logic, idk what he did exactly but it fixed slow charging issues for me and many others. Even Lightening Kernel adapted to that about a month ago, and now both of them charge equally great. Can you look into what he did?

Thanks.
[ONE Android Development] lowlow2:
Oh no, how do I add the dutch dictionary for the android keyboard? Thanks!
[ONE Android Development] freshgiammi:
Settings -> Languages & Input, you should select Dutch there and it will apply globally to your keyboard and ROM.

When i'll have time, as I have more important stuff to do right now.
[ONE Android Development] lowlow2:
For the spell check I can only select these (few) languages!

Thanks in advance!!

Edit: still not found, no dutch spell check, solved by installing Google Gboard
[ONE Android Development] adeptustech:
Longer for me here closer to 4-5 hrs with screen off.

Doesn't matter which charger or cable I use.
[ONE Android Development] SirSoviet:
Damn, that is bad. Flash Lightning Kernel CAF, install Kernel Adiutor Mod and go to the "Power and Battery" section. Raise the AC Charge Level to whatever your wall charger supports.
[ONE Android Development] adeptustech:
Flashing when I get home I'll report back if that works
[ONE Android Development] freshgiammi:
Yeah it probably isn't bundled on AOSP Keyboard, then. GBoard is the same but with Google support, so you should be okay.

I'll see if i can get something done this week but i need you and [MENTION=6363737]Gawd[/MENTION] to try some test kernels for me, as I can't replicate this issue.
[ONE Android Development] freshgiammi:
AOSPlusone_bacon_220117 is here! Greatly improved security!

Major changes are present in this build. A clean flash is advised but not required.

SELinux is enforcing, so please report any issue you find. (With logs)

Also camera now relies on the new libstagefright hardening, so we don't use those HAL1 workarounds anymore.

Encryption might be working, but if someone could test and report, that would be awesome.

There's some other minor stuff too, but it's mostly a security update.

CHANGELOG

16 Jan. 2017 -> 22 Jan. 2017

[B]Adapted Camera HAL to work with the new stagefright hardening![/B]
[B]SELinux is now enforcing![/B]
[B]*maybe*[/B] Fixed HW Encryption (Need confirms)
[B]Fixed most of HFR/HSR;[/B] Everything works besides HFR@60 and HSR@120
[B]Fixed Ambient Display
Fixed audio misbehaving with AUX cords (>3 pins jack)[/B]

EDIT: Added some basic FAQ on #6! I'm not good at FAQ, so if you come up with some questions to write there, shoot me up.
[ONE Android Development] FrenchSparda:
Great, downloading it right now ;)

Many thanks
[ONE Android Development] Angrydr0id:
Excellent work.

Just a little pettion... Can you add "Single-tap action" in the settings for Hardware Keys?

Please.

Amazing job again. ;)
[ONE Android Development] LucentBirch:
Using magisk and phh superuser. Everything is working right, but safety net is still failing, even with selinux enforcing...Any thoughts?

Deleted magisk and did a dirty flash of latest. Still failing safety net? Thought there was no root on here? Nothing is appearing in system/bin but there is a su file in system/xbin...

I don't know what else to do -- I've flashed SuperSu and deleted it completely. Deleted any supersu file present in the /system folder still can't pass safetynet...
[ONE Android Development] adam.banny002:
[MENTION=4986658]freshgiammi[/MENTION] can you add fitur network traffic bro ?
[ONE Android Development] Angrydr0id:
Camera crashes in last build. :eek:
[ONE Android Development] wingedpanther:
did you clean flash the rom ?
[ONE Android Development] indhimaga:
Move to lightning kernel all came fine now quick charging back...!!!
[ONE Android Development] myshakugan:
It doesn't. Do a clean flash.
[ONE Android Development] shubham1120:
I am ready to help you test on F2FS.

/system on ext4 and /data and /cache on f2fs.:)

The 17th build is not booting. It is stuck on 1+ logo with this setup.
[ONE Android Development] freshgiammi:
Thanks! Yes I am aware of that, i've noticed i got stuff missing. So i'll include in the next build and hopefully it should work, but i can't test since i can't format to F2FS.

If you dirty flashed, please delete data in the Snap app and reboot. That should do it.

How about

(look at older post if you want to set the menu key as recents)

Never used Magisk, but if you need the rom to be on userbuild remember it isn't yet. It's still userdebug.

Also, we've discussed this in the first pages of the thread: the SU binary in /system/xbin is built by AOSP itself, and it is needed to run utilities such as "adb root", without the use of external binaries. So it's not a leftover or anything else. Yes that may be bothering with SafetyNET but I actually don't know. Perhaps it doesn't get built on userbuild.

What error do you get?
[ONE Android Development] LucentBirch:
Yeah, guy on Magisk thread just replied and said:

Ah well...will have to wait. What is the difference between the two? What does userdebug allow you to do?

He says I can change "userdebug" to "user" with some magisk tools (resetprop), but I don't fully understand tbh...
[ONE Android Development] imtemplain:
My WiFi becomes inactive in the latest build when the phone enters standby. It's really annoying, do you have any solution?

I didn't do a clean flash, I just updated from an older version of this ROM, where I didn't have this problem at all.

thanks
[ONE Android Development] Gawd:
It's simple then, perform a clean flash and see if the problem persists.

[MENTION=4986658]freshgiammi[/MENTION] here is the commit related to charging https://github.com/nikhil18/lightning-kernel-bacon/commit/9e031129c8ea0b6f7abcd5ff3c76b95c44597837
[ONE Android Development] freshgiammi:
You can find the difference here. https://source.android.com/source/building.html#choose-a-target

Never used Magisk; can't help. I'll see if i can compile userbuild.

Probably a dirty flash issue. Try and clean flash, it doesn't appear here.

Yes I am aware of that commit. There are a few things I wanted to add along with it tho.

So keep an eye on today and tomorrow as I could release a test kernel that should fix the charging issue.
[ONE Android Development] mad.jack10:
Just tried to clean flash and I got this error.

Could it be a duff download?
[ONE Android Development] Gawd:
Search the thread before you post.
[ONE Android Development] imtemplain:
Thanks for the quick replies, I really don't want to create a new thread so I hope you'll forgive me if I ask this noobie question in here:

What is the best way to backup my data before doing a clean flash? Can I somehow keep app data as well (e.g., downloaded Spotify content etc.)?

When I did the dirty flash I had to use the pico Gapps package and had to reinstall all other google apps manually, can I somehow backup my apps before doing a clean flash?
[ONE Android Development] LucentBirch:
Don't worry about it! Keep doing what you're doing. I'll survive without it. Only Android Pay is affected by it, and I don't need it.
[ONE Android Development] arfasyrf:
Got two camera in latest build, android camera forced closed when opening. Snap camera crash when trying to resume video after pausing. Clean flash twice. Wiping all except local storage.

Besides that, it's a good build. Thanks!
[ONE Android Development] Aniket.t20:
Mirror Request

Having trouble downloading this from basketbuild, failed several times. Can someone please mirror the latest build, if the OP doesn't mind this .
[ONE Android Development] shubham1120:
You don't have to worry about testing. I'll be your guinea pig :highfive:

I'll be on a watchout for your build with f2fs and I'll let you know how the test goes :)

Eagerly waiting for it. :D
[ONE Android Development] freshgiammi:
Please search the thread before asking. Just reboot to recovery and flash gapps.

+1

I use Titanium Backup for app+data transfer across ROMs. And you have to flash Gapps after every ROM update, as i haven't integrated backuptools yet.

Yeah sorry, my bad. Forgot to clean the output folder and left Camera2 there. You're fine, you can disable it. It will be removed in the next build.

Thanks for the report about Snap camera, i've been able to replicate and i'll try to track it down.

Yeah sure, mirrors are accepted. But I can't mirror right now.

Thanks! I'll try to bundle the F2FS changes in the next build, so please try that when it goes live.
[ONE Android Development] rphlfjrd:
Anyone here having bluetooth audio sync issues when playing videos? Audio is give or take a half-second late. I've tried different roms and it's the same.
[ONE Android Development] arfasyrf:
Phone reboots when trying to setup google fit. Happened twice.
[ONE Android Development] lumufei:
Can i flash pixel nav bar on lastest build?
[ONE Android Development] vergilz18:
Yes
[ONE Android Development] shubham1120:
Thank you for taking f2fs support into consideration. Waiting for the new build. Will get my hands on it as soon as it's uploaded :D
[ONE Android Development] ShinnAsuka:
When I flash the latest build (downloaded from Basketbuild), and flash opengapps, it says the Android version of the ROM is 6.0.1.

Anyone else seeing this when flashing the latest build from the OP (Basketbuild)?
[ONE Android Development] SirSoviet:
Reboot recovery to flash GApps, it's a problem that most AOSP roms have.
[ONE Android Development] Gawd:
Before you ask questions, this option is very useful. Just so you know.
[ONE Android Development] ShinnAsuka:
I always find this type of post kind of redundant because if you take the time to post that, you might as well just give a useful answer. Either respond to the question or don't post at all.

Thanks for the tip though, I really didn't know that....
[ONE Android Development] Gawd:
Considering you already got the answer to that by [MENTION=6917522]SirSoviet[/MENTION], I just posted a tip for future references and also for other users.

Your very welcome.
[ONE Android Development] TheGratefulDead:
Great ROM, running the latest since 1/22, rock solid, haven't run into one issue. Battery is top too with heavy use in an area with poor service. Thanks Dev for excellent aosp build
[ONE Android Development] joshiameya:
does the 1/22 build have f2fs support?
[ONE Android Development] se7enlyn:
Not yet, if I'm not wrong
[ONE Android Development] wszebor:
I'm waiting too for f2fs support. Then I gonna try this Rom.

Wysłane z mojego A0001 przy użyciu Tapatalka
[ONE Android Development] Evolitist:
Boots fine for me with /data and /cache on f2fs.
[ONE Android Development] joshiameya:
ohhh thats nice, thanks for the info
[ONE Android Development] :
It must be chance or something . I tried over 5 times clean and it din't work.I flashed Nos and it worked. I am thinking you are using a test build.
[ONE Android Development] Claudiosvs:
Just made this my primary ROM. Everything works so far. Flashlight tile is a bit glitchy sometimes i.e. doesn't work half the time. Any chance of Advanced Reboot menu and/or Double Tap Statusbar to sleep? Thank you very much for this ROM!
[ONE Android Development] salmonthefish:
Quick question... Can I install this rom on ext4 partition? today is the second time I try installing it and whenever I try to install gapps it says Error code 20. And try rebooting to system and recovery says I have no OS. TWRP recovery 3.0.2-0
[ONE Android Development] sax0406:
Yes you can. After flashing the rom, reboot to recovery (not the system). Then flash the gapps.
[ONE Android Development] salmonthefish:
Ok... It booted into system, recovery and installed Gapps. I'm all good. Gracias
[ONE Android Development] Kaar3l:
Tested F2FS - doesn't work. :)

Otherwise really nice rom.
[ONE Android Development] originaltebas:
Hi, one little detail I miss from cyanogemod. Is it possible to change the locking pattern grid to allow more than 3 row/cols? Right now it's impossible to change it.

Thanks a lot!

Originaltebas
[ONE Android Development] Gawd:
He will not add it. This ROM is supposed to be pure AOSP and it does not have that feature.
[ONE Android Development] originaltebas:
Well, he also said "aosp with a few tweaks" ;)
[ONE Android Development] Gawd:
CM features!=tweak
[ONE Android Development] Zealotki11er:
I am doing a clean instal and phone just gets stuck in OPO logo. What could it be?
[ONE Android Development] lordsinasina:
Had the same problem and it came to be f2fs format. Format all partitions to ext4 and flash again
[ONE Android Development] lowlow2:
What's the best way to upgrade builds generally?

I want to go from the Jan5 to the Jan22 build?

Just flash the zip and clear cache+dalvik?

Love this ROM!! Stable, good pictures (Sultan), good call quality, good battery life, good job Giammi!!
[ONE Android Development] eiwarmer:
Usually I wipe dalvik/cache, system and cache and leave the data and internal partition intact. Flash the update and gapps and other mods like SU and reboot. This is a cleaner dirty flash and leaves all your settings intact.
[ONE Android Development] lordsinasina:
I used super su 2.79 sr3 to root this but apparently it cannot be installed as systemless. Any ideas why ?

---------- Post added at 10:51 AM ---------- Previous post was at 10:48 AM ----------

@freshgiammi any chance you can include Kcal display control in your kernel ?

---------- Post added at 10:52 AM ---------- Previous post was at 10:51 AM ----------

@freshgiammi any chance you can include kcal display control in your kernel?
[ONE Android Development] freshgiammi:
Seen the flashlight issue. Probably part of something bigger in Camera HAL. I need to debug still.

"tweaks" is different from "features"

Yeah that's fine, remember to flash gapps as they get removed with dirty flashes.

Systemless working fine here.

No major changes to kernel (Fast Charging aside) since i'm trying to clean the mess CM left here, by adapting 3.4 CAF or 3.10 from erocrun.

Been a while, so here are the updates:

I've changing build server. [MENTION=5267387]Evolitist[/MENTION] gave me access to his builder so I can work faster (2h instead of 12h for a clean build is faster indeed). But finals are hitting hard right now and I don't have much time to work on the rom.

I've been able to do some progress tho, here's what I accomplished till now

ROM: Removed Camera2
ROM: *enabled* F2FS-tools support
ROM: Re-enabled textiles check (Textiles are not globally allowed anymore)
Kernel: Fixed fast-charging not working for some users
Kernel: Fixed MPDecision not turning off cores 2 and 3
Kernel: Restored CONFIG_MACH_OPPO; (This will probably make kernel more stable,
but can cause instabilities. Please report any reboots.)
Snap: Fixed crash when resuming a video paused during recording

I'll upload a test build for those willing to help me with F2FS testing and a test kernel for those who are encountering the slow charging issue, but I have to wait until AFH gives me access to their hosting site. (Yeah, basketbuild is giving me issues so i have to change the hosting provider.)
[ONE Android Development] efrai3:
[MENTION=4986658]freshgiammi[/MENTION]

Sultan update his mm rom and have some fixes also for the camera if you check in the changelog.
[ONE Android Development] Gawd:
Let's make this simple because no one likes big-a** posts

I created a debloater for this ROM a while ago for my own use. It'll remove stock AOSP Apps because I use Google Apps. The Debloater is attached to this post and so is the list of apps it'll remove. If you want stock apps back, simply flash the other zip I'm attaching and then dirty flash the ROM.
[ONE Android Development] pattyboi:):
[MENTION=4986658]freshgiammi[/MENTION] fancy seeing you here ;)
[ONE Android Development] iDorkKnight:
This is what I get after every reboot. Is it just me? Should I reflash the ROM?

PS: I'm on the 22-01 build, clean flash.
[ONE Android Development] freshgiammi:
Thanks. I merged the newest changes.

Guess i'll have to add this post too to #3 ;)

No you're fine. That's probably conflicting with SELinux being enforcing and it should be good on the next build.

Hey there, long time no see! Didn't expect to see you here, you made the switch to OPO after maguro?

However, made some progress today.

Kernel: Fixed NULLPointer (kernel panic) when watching WEBM videos or using Google Fit.
Kernel: Merged the latest patches from LOS
ROM: Fixed torch QS misbehaving and not working randomly
ROM: Enabled backuptool (thanks to @mandaman2k)
Snap/CameraHAL: Merged lastest patches from Sultanxda.

We're heading to the point where the ROM is pretty much stable and working on every side. The testers for F2FS and slow charging issue will be notified when i get access to AFH.
[ONE Android Development] Spider-Vice:
backuptool means that we won't need to reflash gapps anymore, right? Correct me if I'm wrong.
[ONE Android Development] lordsinasina:
I totally understand your point but I don't think kcal would be a major change and it is included in almost all other kernels.

https://xdaforums.com/android/software-hacking/dev-kcal-advanced-color-control-t3032080

Oneplus one default color settings is too dull and kcal would help to make it a bit more colorfull. Your rom is alreay perfect and this would make it almost unbeatable :)
[ONE Android Development] lordsinasina:
I also tried lightening kernel to get kcal but it breaks video recording on camera
[ONE Android Development] lalith sai:
I'm using lightning kernel. No problem with video recording, everything works fine
[ONE Android Development] hammer-is:
[MENTION=4986658]freshgiammi[/MENTION]

fantastic smooth ROM and it compiles just fine now after you did some cleanup. My new daily driver!

Btw. "backuptool" works as expected. No need to reinstall Gapps anymore! nice!

I have not tested F2FS (but I can do it if you like)

A few suggestions:

build/target/product/full_base.mk refers to sounds that are not included, so on a clean install notification and ringtone is "unknown"

- ro.config.ringtone=Ring_Synth_04.ogg \

- ro.config.notification_sound=pixiedust.ogg

+ ro.config.ringtone=Titania.ogg \

+ ro.config.notification_sound=Tethys.ogg

and i guess there is really no reason to set ro.config.notification_sound in both "full_base.mk" and "core_base.mk"

It seems the following commits can be reverted to keep it closer to AOSP

https://github.com/AOSPlusone/android_frameworks_av/commit/39a3b6f03d7951f5c18c234623f6a555d0f308b7 (as I can't find anywhere BOARD_CANT_REALLOCATE_OMX_BUFFERS is set)

https://github.com/AOSPlusone/android_frameworks_av/commit/da2c066e0a39a517a689e38c912df14bb16ba783 + https://github.com/AOSPlusone/andro...mmit/39da37ee29ef47cc356742162676198a9eb4c77f (as they seem to duplicate the functionality of https://github.com/AOSPlusone/android_frameworks_av/commit/1a3f6d4d7453d553d365f6addd1ab016e8b2db84)

Maybe you can also revert this: https://github.com/AOSPlusone/android_frameworks_av/commit/63be5bfce94b691e54cad897c3b155537f53bbae