yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 Guides, News, & Discussion] tukiii:
i'm on taker18's build from yesterday (+ opengapps nano). running great so far.

i've noticed that battery stats are not reset after charging to > 90%. Is this stock nougat behavior or just a bug?

Call quality is normal on other end, no echos reported.

Battery is not bad, almost on par with OOS (4h SOT).

Camera works (photo & video), i currently use OOS Cam for nougat roms (http://xdaforums.com/oneplus-3/themes/port-oxygenos-stock-camera-cm-t3451721) and it works great (except panorama).

Permissions pop up inside of apps is not displayed correctly, can be worked around by manually granting permissions in settings/apps.

Power menu customization gives FC.

No pocket mode implementation (yet), so screen was sometimes on in my pocket.

And one more thing: I set home button long press to screen off. When I unlock the phone and try to immediately turn off screen by long clicking home button, it doesn't work. i get a vibration feedback, but nothing happens (not even normal home behavior). I have to tap and hold again, then it works.
[OnePlus 3 Guides, News, & Discussion] Giocarro:
[MENTION=5095986]tukiii[/MENTION]; I can confirm the little issue setting home button to turn screen OFF. I end up performing a thing like "short press + long press" to be sure that the screen OFF command is triggered.
[OnePlus 3 Guides, News, & Discussion] Harry44:
Disregard.
[OnePlus 3 Guides, News, & Discussion] kalpik:
Or just tap 3 times, works always :D
[OnePlus 3 Guides, News, & Discussion] Lodberg:
I see that Daleskis builds says non-rooted. Does that mean I have to flash SuperSU if I want root?
[OnePlus 3 Guides, News, & Discussion] Giocarro:
Yep, exactly!
[OnePlus 3 Guides, News, & Discussion] SamuelBegui:
Hey guys so I figure since this is offtopic and shouldn't be talked about on the main thread, I was curious if any of you use Android Pay and are able to make a transaction without root? I have yet to be successful and was wondering if anyone else was experiencing the same issue. I apologize if I have already brought this up too many times, thanks!
[OnePlus 3 Guides, News, & Discussion] timbremer:
Hi! I'm new to CM14 and tried out Taker18's builds, which ones do you recommend? Are there differences in terms of stability and which one is updated regularly?

Thanks!
[OnePlus 3 Guides, News, & Discussion] Sowdiyeah:
It is known that Android pay doesn't work. I'm experiencing issues with that myself. They expect it is NFC. Wouldn't expect an update any time soon as this is not such an important focus.

Just look at the latest one. They are getting more stable every day and all builders use the same repository, so these should be near identical. Daleski75 is the one who puts out builds most often, so it will probably be his build.
[OnePlus 3 Guides, News, & Discussion] timbremer:
So could I dirty flash Daleski75's latest build over Taker18's? Or did he do something different, because it says "No root only"?

Thanks again ?
[OnePlus 3 Guides, News, & Discussion] Sowdiyeah:
Jou can just flash one on top of the other. If you flash daleski75 over Taker then you will lose root and vice versa.
[OnePlus 3 Guides, News, & Discussion] SamuelBegui:
I had gotten logs when trying to use android pay on CM14, where would I go to submit them and report the bug formally ? Thanks !
[OnePlus 3 Guides, News, & Discussion] Sowdiyeah:
I think posting them in the official development thread is the best option.
[OnePlus 3 Guides, News, & Discussion] sebfar:
Why we don't have the same dual sim management on CM14 and CM13?
[OnePlus 3 Guides, News, & Discussion] darkberry19:
How long until this ROM is in nightly
[OnePlus 3 Guides, News, & Discussion] clintonbugz:
delete
[OnePlus 3 Guides, News, & Discussion] ShadowRii:
Had to return back to stock oxygen Os, cm 14 is great works fast and pretty stable but had a few call bugs like the echo thing which people got annoyed about and gps signal was terrible couldn't do any navigation on it.
[OnePlus 3 Guides, News, & Discussion] NoobMonkey:
What camera is working best? Just got this phone today and the stock cm cam doesn't have working video recording.
[OnePlus 3 Guides, News, & Discussion] ShadowRii:
https://play.google.com/store/apps/details?id=com.footej.camera
[OnePlus 3 Guides, News, & Discussion] keviiin38:
Hello [MENTION=3400932]Taker18[/MENTION] and thanks for this amazing builds, i'd like to know where I can report some bug etc.. ?

Thanks in advance
[OnePlus 3 Guides, News, & Discussion] Taker18:
http://xdaforums.com/oneplus-3/development/rom-t3454940

Best Regards,

Taker
[OnePlus 3 Guides, News, & Discussion] keviiin38:
Thanks very much :good:
[OnePlus 3 Guides, News, & Discussion] Jakkomo77:
Is there coming one day Themen engine? Thanxx

Gesendet von meinem ONEPLUS A3003 mit Tapatalk
[OnePlus 3 Guides, News, & Discussion] Jaanuunuu:
Has anyone else had problems with usb network tethering? Using the 29.10 taker build
[OnePlus 3 Guides, News, & Discussion] Dejc16:
Icons in cm14. 1

Hellow!

I just want to ask you how change icons in cm14.1. I dont faund any option for that. I have flo71 build 2. november.

Tnx guys for your answers.
[OnePlus 3 Guides, News, & Discussion] ShadowRii:
Latest cm experimental build killed my mobile network connection can't make calls or texts anymore even after flashing oxygen Os 3.2.7
[OnePlus 3 Guides, News, & Discussion] BugdroidNerd:
Can I upgrade to a newer build by dirty flashing? Or do I need to nuke if I want to install the latest? [MENTION=3400932]Taker18[/MENTION]
[OnePlus 3 Guides, News, & Discussion] Sowdiyeah:
You have to do a clean flash. Normally you can try dirty flashing, but a lot of people are encountering issues with that. So I would suggest doing a complete wipe.
[OnePlus 3 Guides, News, & Discussion] Giocarro:
Apologize for the silly question, I'm moving my first steps with CM 14.1 Nougat: is it normal to constantly see a few notifications telling me what apps are running?

I mean not the "normal" permanent notifications I expect to see, but something like a way to monitor background apps.

I know I can "silence" each notification, but wondering if there's a reason for this "notification spamming" activated by default.
[OnePlus 3 Guides, News, & Discussion] kv1dr:
Because I don't want to clutter development thread, I will ask here... I have installed latest cm 14.1 from daleski with pixelify 10.3, but Google keyboard is not installed nor can I install it from Google Play. I got error -505 if I want to install it from Google play, if I install it manually I got error that package with the same name is already installed on the phone, if I wanted to search by same package name, there is no package and if I wanted to uninstall it by package name it says app is not found
[OnePlus 3 Guides, News, & Discussion] Inlacrimas:
Anyone knows when i can expect the first official stable version?
[OnePlus 3 Guides, News, & Discussion] Balajiich:
Could not flash the firmware modem and FINGERPRINT SENSOR DOESN'T WORK PROPERLY!

The system's getting crash very often. especially the cm report is getting crashed. Could not flash the firmware modem too.
[OnePlus 3 Guides, News, & Discussion] milap007:
upgraded to cm14.1 device name one plus 3 i want to roll back to oxygen os plz help

Installed Cm 14.1 but i dont like it current device one plus 3 i want to roll back to oxygen os plz help me twrp recovery not working cynagenmod recovery not showing my internal storage plz help me sir
[OnePlus 3 Guides, News, & Discussion] AFschizoid:
Need to reflash recovery. Not just any recovery though, has to be a community build of twrp. Here is one (version 3.0.2-1.28)

http://xdaforums.com/devdb/project/dl/?id=21835&task=get

Turn off phone, vol up and power to bootloader, fastboot flash recovery, so on and so forth. This will get twrp working again. Download and flash rom as normal.

If you want to try 14.1 the way it's supposed to be, wipe everything but internal storage and flash the latest nightly (or adb sideload in twrp if you're an idiot like me and wiped everything)
[OnePlus 3 Questions & Answers] XpellCZ:
Is there a way to backup all my apps and their layout on home screen? I use Titanium backup but then I have to rearrange my apps manually into folders again when switching to different custom ROM.

Guys, who switch ROMs almost every day, what's the easiest way to fully setup your phone again?
[OnePlus 3 Questions & Answers] ghostofcain:
Nova launcher allows you to backup your configuration.
[OnePlus 3 Questions & Answers] XpellCZ:
Thanks for the tip!
[OnePlus 3 Questions & Answers] Explorer23:
Even if you don't use Nova I guess you could backup data (with Titanium) of default launcher and then restore it.

But Nova makes things easier + it offers a lot more customization.
[OnePlus 3 Questions & Answers] kkccttccy:
I use Titanium but I don‘t need to "rearrange":confused:
[OnePlus 3 Questions & Answers] XpellCZ:
I don't know I switched to Nova and it solved my problem.
[Windows Mobile Development and Hacking General] IgorA100:
Russian WM6 Asus P526

Problem:

After processing default.hv (Use rgucomp.exe & cereg400.dll) Russian letters vanish in file boot.rgu

An example:

Should be so:

[HKEY_CLASSES_ROOT\{030D681B-1DFC-4bd0-A72A-A9B3CCCDA653}]

"DisplayName"="Камера"

And it turns out so:

[HKEY_CLASSES_ROOT\{030D681B-1DFC-4bd0-A72A-A9B3CCCDA653}]

"DisplayName"="

:(

There is an idea?
[Windows Mobile Development and Hacking General] IgorA100:
I have solved the given problem. Here the utility working with Cirilic;)

Here a source:

http://forum.wce.by/viewtopic.php?t=6023&postdays=0&postorder=asc&&start=165
[Windows Mobile Development and Hacking General] phsnake:
many thanks to IgorA100 - it works with other slavic languages as well (Slovak/Czech) although we don't use Cyrilic, but characters like ť č ž řwere converted incorrectly - same prob as above. Problem solved using above version of rgucomp. Thanks
[Windows Mobile Development and Hacking General] somphon_r:
IgorA100, I 'm also own the P526. Did you success customize the Russian ROM? I'm trying to translate it's rom to English. Once I created the boot.rgu using rgucomp.exe, the boot.rgu file is bigger than other rom I've seen. The big problem is I'm not sure the device will work after flashing. :p
[Windows Mobile Development and Hacking General] phsnake:
it's ok i think - its because of unicode.
[Windows Mobile Development and Hacking General] somphon_r:
phsnake, How about your ROM?

Thanks phsnake, Did you success customize P526 ROM? using your new boot.rgu?

I only have got the Hongkong latest GallaxyII ROM file and trying to translate to English with the resources and knowledge in this web. After the translation, how do I know the ROM is usable? (without flashing to device)

Thanks in advance. :D
[Windows Mobile Development and Hacking General] IgorA100:
somphon_r

How you are flashing P526? I for this purpose did not meet utilities, except for pdowrite.:(

I only extract ROM and convert to dump.. I have addresses of sections of original flash P526.pim. It is necessary?

It can be necessary to organize a separate thread for flashing P526?;)
[Windows Mobile Development and Hacking General] phsnake:
i have htc-artemis & htc-universal. but the hv & rgu file format are same.
[Windows Mobile Development and Hacking General] somphon_r:
I'm not success flashing P526 yet, and still finding solutions. :D IgorA100, did you 've tried flashing through Boot Loader using USBLoader?

Thanks.
[Windows Mobile Development and Hacking General] IgorA100:
USBLoader flashing only for CPU Intel PXA27x :(
[Windows Mobile Development and Hacking General] somphon_r:
:( have to find another way. Thanks IgorA100.
[Windows Mobile Development and Hacking General] Govorun:
I have the same problem with Chinese language. How could be fixed this problem? Or, where I can find sources of rgucomp?
[Galaxy Note 10.1 Q&A, Help & Troubleshooting] jas1rw:
Hi all,

I have a Galaxy Note 10.1 (2012) which worked fine until one night I switched it off before bed. The next morning it doesn't boot up. It just shows the Samsung logo.

The machine won't go into recovery but starts to show the TWRP initial screen before going back to rebooting.

The machine will go into download mode and I have tried flashing stock a stock ROM and TWRP again but each time, ODIN reports a fail.

This is the log from ODIN when I try to flash the stock ROM:

<ID:0/004> Removed!!

<ID:0/004> Added!!

<OSM> Enter CS for MD5..

<OSM> Check MD5.. Do not unplug the cable..

<OSM> Please wait..

<OSM> Checking MD5 finished Sucessfully..

<OSM> Leave CS..

<ID:0/004> Odin engine v(ID:3.1101)..

<ID:0/004> File analysis..

<ID:0/004> SetupConnection..

<ID:0/004> Initialzation..

<ID:0/004> Get PIT for mapping..

<ID:0/004> Firmware update start..

<ID:0/004> SingleDownload.

<ID:0/004> sboot.bin

<ID:0/004> NAND Write Start!!

<ID:0/004> FAIL!

<ID:0/004>

<ID:0/004> Complete(Write) operation failed.

<OSM> All threads completed. (succeed 0 / failed 1)[/SIZE]

I have very often flashed ROMs in the past without a problem. I had TAB Sensation on the Note and had been using this for quite a while, then this just happens without any obvious reason.

Any help would be so gratefully received.

Thank you.

Jason :confused:
[Galaxy Note 10.1 Q&A, Help & Troubleshooting] JJEgan:
Download again.
[Galaxy Note 10.1 Q&A, Help & Troubleshooting] jas1rw:
Thanks for this but what should I download again?
[Galaxy Note 10.1 Q&A, Help & Troubleshooting] JJEgan:
stock ROM # for your model .
[Galaxy Note 10.1 Q&A, Help & Troubleshooting] jonathanljs:
Same problem, but with unrooted model on stock 4.4.2. Happened once before, when under guarantee, and Samsung fixed it. Issue in detail:

Switch on - stuck at 10.1 logo

Will restart into download mode

Won't restart into recovery

Windows 10 computers won't recognise it when attached ('unknown USB device'), so ODIN doesn't see it.

So I'm stuck - any suggestions? Thanks in advance.

:confused:

Attempted remedies so far:

uninstalled Kies

installed Samsung drivers (various versions)

reinstalled Kies

Skipsoft Toolkit
[Galaxy Note 10.1 Q&A, Help & Troubleshooting] Generz:
I've got the exact same problem with mine, it started several months ago. I was about to toss it but figured I'd give it another shot after a coworker told me of this forum. He suggested loading a new firmware/OS via the micro SD card, although since it won't even really boot I'm not sure how I'm going to do that.
[Galaxy Note 10.1 Q&A, Help & Troubleshooting] JJEgan:
http://xdaforums.com/showthread.php?t=2080366
[Galaxy S 5 Q&A, Help & Troubleshooting] AndreAkaNick:
Im on Ubuntu and I need to flash the latest rom (6.0.1) using Heimdall but I'm really lost with the process.

The thing is, the file I downloaded is the .tar.md5 format and Heimdall cant read it directly through the GUI version and from what I've read on some forums, I need to flash it using the command line option.

But, how do I do it?
[Galaxy S 5 Q&A, Help & Troubleshooting] psykickuk:
Hi all,

I'm uncertain as to Samsung's policy with regards to providing updates. 2years is the norm, but I'm wondering if the S5 neo will get:

2 years from release (Aug2015 > Aug2017)

or

refuse to release anything past what the the original S5 does not get (Apr2014 > Apr 2016).

Call me a cynic, but I'm guessing the latter, can anyone think of similar examples from the past, or have any hints from Samsung?
[Galaxy S 5 Q&A, Help & Troubleshooting] jimbomodder:
It'll be from first s5 release as it's still an s5 after all so MM will be the last update
[Magisk] topjohnwu:
The thread is now depreciated

Please check out this post for more info!
[Magisk] topjohnwu:
Example Submission

Module name: Magisk Module template

Repo Link: https://github.com/topjohnwu/magisk-module-template

XDA Support Link: http://xdaforums.com/showthread.php?t=3473486
[Magisk] stangri:
Module name: Nexus 6 LED Enabler

Repo Link: https://github.com/stangri/Nexus6_LED_Enabler

XDA Support Link: http://xdaforums.com/apps/magisk/module-nexus-6-led-enabler-t3473605
[Magisk] topjohnwu:
Added to the repo :)
[Magisk] ibrokemypie:
Bit of terminology, are the github repos that we can make just for the modules and then you pull them into the magisk repo? Just a bit confused as to whether multiple user run repos like cydia is what you are going for or if it will be one big repo like xposed.
[Magisk] jaimbo:
Module name: PixelLauncher

Repo Link: https://github.com/jaimbo/PixelLauncher

XDA Support Link: http://xdaforums.com/apps/magisk/module-pixel-launcher-t3473882
[Magisk] Tkkg1994:
Deleted
[Magisk] ibrokemypie:
Module name: Kill VoLTE Status Icon {HTC10}

Repo Link: https://github.com/ibrokemypie/magisk-module

XDA Support Link: http://xdaforums.com/apps/magisk/module-novolteicon-t3474259/page1
[Magisk] Seyaru:
Module Name: Sony Framework, for non Sony-Users

Github Link: SonyFramework

XDA support: Playstation Remote Play on any Android Device
[Magisk] crusader727:
[MENTION=4470081]topjohnwu[/MENTION]:

Imo the hosts file should be also listed as a module (could still be preinstalled) to avoid confusion like this and make it consistent
[Magisk] topjohnwu:
https://github.com/Magisk-Modules-Repo/PixelLauncher

https://github.com/Magisk-Modules-Repo/SonyFramework

It is a single "group of Git repos", something similar to Xposed
[Magisk] Nbay64:
Module Name: Console Controller Keylayouts

Repo Link: https://github.com/HylianGaming/Console-Controller-Keylayouts

XDA Support Link: http://xdaforums.com/apps/magisk/magisk-console-controller-keylayouts-t3474174
[Magisk] ibrokemypie:
Module name: Acoustix v29 Stock

Repo Link: https://github.com/ibrokemypie/magisk-module/tree/acoustix

XDA Support Link: http://xdaforums.com/showthread.php?t=2211163

Module name: Acoustix v29 Optimised

Repo Link: https://github.com/ibrokemypie/magisk-module/tree/acoustixv29optimised

XDA Support Link: http://xdaforums.com/showthread.php?t=2211163

Module name: Acoustix v29 Overdrive

Repo Link: https://github.com/ibrokemypie/magisk-module/tree/acoustixv29overdrive

XDA Support Link: http://xdaforums.com/showthread.php?t=2211163

Module name: Acoustix v28 Stock

Repo Link: https://github.com/ibrokemypie/magisk-module/tree/acoustixv28stock

XDA Support Link: http://xdaforums.com/showthread.php?t=2211163

Module name: Acoustix v28 Optimised

Repo Link: https://github.com/ibrokemypie/magisk-module/tree/acoustixv28optimised

XDA Support Link: http://xdaforums.com/showthread.php?t=2211163

Module name: Acoustix v28 Overdrive

Repo Link: https://github.com/ibrokemypie/magisk-module/tree/acoustixv28overdrive

XDA Support Link: http://xdaforums.com/showthread.php?t=2211163

Module name: Kill VoLTE Status Icon {HTC10}

Repo Link: https://github.com/ibrokemypie/magisk-module/tree/novolte

XDA Support Link: http://xdaforums.com/apps/magisk/module-novolteicon-t3474259/page1
[Magisk] grimsandwich:
Module name: Enable EIS for Nexus 5X

Repo Link: https://github.com/grimsandwich/magisk-enable-eis-nexus5x

XDA Support Link: http://xdaforums.com/apps/magisk/module-enable-eis-nexus-5x-t3474672/
[Magisk] Nbay64:
[MENTION=4470081]topjohnwu[/MENTION] I noticed that my module Custom Controller Keylayouts was added to the repo, but I am unable to edit it on Github, which means I can't push out updates when needed. Could you please give me access?
[Magisk] knipp21:
Removed
[Magisk] knipp21:
Will EIS for nexus 5x or adblocker be added to the repo?
[Magisk] CrashOverride1995:
Action Launcher 3 Magisk Module

Module name: Action Launcher 3

Repo Link: https://github.com/crashoverride1995/ActionLauncher3

XDA Support Link: http://xdaforums.com/apps/magisk/module-action-launcher-3-t3476397
[Magisk] jsaxon2:
Module Name: GPEDialer and Contacts for HTC 10

Repo Link: https://github.com/jsaxon2/GPEDialer_HTC10

XDA Support Link: http://xdaforums.com/htc-10/themes/mod-gpe-dialer-contacts-magisk-mod-htc-t3463856
[Magisk] stangri:
Great job! Have you considered specifying the supported models in the module name, so it's easier to find/ignore if you don't have a supported phone?
[Magisk] djb77:
I just updated the description tag in the module.prop, hopefully that will be good enough :)
[Magisk] Zer0t3ch:
Module Submission

Module name: ActionLauncher 3 as System app

Repo Link: https://github.com/zer0t3ch/magisk-actionlauncher

XDA Support Link: None yet, is this needed?
[Magisk] JudgeDread11:
A module for this was posted 2 days ago already.
[Magisk] Zer0t3ch:
Oh ****, didn't see that. It's not in the Magisk Manager yet, is it?
[Magisk] knipp21:
Not that I see
[Magisk] napster113:
Module name: napster113 debloat

Repo Link: https://github.com/napster113/magisk-module-template

XDA Support Link: http://xdaforums.com/showpost.php?p=69066126&postcount=1

Hope Iv'e done this right.
[Magisk] jerbear294:
Module name: Emoji One

Repo Link: https://github.com/jerbear64/Magisk-EmojiOne-systemless

XDA Support Link: http://xdaforums.com/apps/magisk/module-emoji-one-t3477911
[Magisk] Zer0t3ch:
Pretty sure the other guy's may not work right, anyway. From a quick google, the APK needs to be in /system/priv-app for system permissions, being in /system/app doesn't actually give the special abilities. (Like mine does)
[Magisk] little_cup:
Module name: ice-box-plugin-magisk-module

Repo Link: github.com/heruoxin/ice-box-magisk-module

XDA Support Link: none

Google Play App Link: play.google.com/store/apps/details?id=com.catchingnow.icebox
[Magisk] CrashOverride1995:
The module was made by me and I have been using it since then and it works with all the special permissions in this case Google Now Integration.
[Magisk] Zer0t3ch:
Ah, okay. Good to know.
[Magisk] flindaman:
Module Submission request

Module name: Nexus Assitant

Repo Link: https://github.com/kudiaborm/Nexus-Assistant

XDA Support Link: http://xdaforums.com/apps/magisk/module-nexus-assistant-t3478316
[Magisk] djb77:
Module Name: TheSoundMod v18 S7 Dual Lv3

Repo Link: https://github.com/djb77/magisk-soundmod-s7-dual-l3.git

XDA Support Link: http://xdaforums.com/showthread.php?t=3339809

Description:

The Sound Mod v18 for S7 / S7 Edge with Dual Speaker Setting Level 3

Supports:

- Galaxy S7 / S7 Edge

:D

(I had this originally under a different repo name, but changed it because I plan to do the N7 ported ROM versions too).
[Magisk] jerbear294:
Bear in mind that this module is *very* device specific as if replaces the build.prop itself.

[MENTION=1016795]loserskater[/MENTION] has a better module in that thread that dynamically sets build.prop on boot.
[Magisk] flindaman:
I'll add some disclaimers on the github page.
[Magisk] knipp21:
Would it work on a nexus 5x
[Magisk] rignfool:
Why not make it a cache mod so it can setprop the line in question on the fly...
[Magisk] stangri:
May want to rename the module so it's more obvious what it does and what phone model it is for.
[Magisk] flindaman:
https://github.com/topjohnwu/Magisk/issues/7
[Magisk] topjohnwu:
Sorry, I've got a busy week.

Schoolwork is overwhelming....

https://github.com/Magisk-Modules-Repo/magisk-enable-eis-nexus5x

Please change the description of your repo to your module id.

https://github.com/Magisk-Modules-Repo/GPEDialer_HTC10

https://github.com/Magisk-Modules-Repo/napster113_debloat

https://github.com/Magisk-Modules-Repo/Magisk-EmojiOne-systemless

https://github.com/Magisk-Modules-Repo/magisk-soundmod-s7-dual-l3
[Magisk] CrashOverride1995:
Done.
[Magisk] djb77:
[MENTION=4470081]topjohnwu[/MENTION]

No need to apologise mate, everybody gets busy with stuff in their life.

Many thanks for everything you do for us :)
[Magisk] jsaxon2:
How long does it take for a module that is updated on github to show in Magisk Manager? GPEDialer was added and is now available to download through Magisk Manager, but I updated a couple things and bumped up the versionCode number but I am not seeing the update in Magisk Manager. I made the changes in the master branch. I am new at this, so might be something I am doing wrong.

Is there anything else I need to do?
[Magisk] djb77:
It doesnt take long at all, I had to do a quick update on my module. Clear the cache and data of the Magisk manager and restart. the changes should be there then.