yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
This thread is about making your own modules and modifications, so this question would have been better suited for the support thread... If you have further questions about installing Magisk, go there. If you bump into any hurdles on the way, take a look in the support thread. Most questions have already been asked there and most of those have been answered.

If you're using a systemless SuperSU today and want to continue using it, just flash Magisk in recovery. Done! Install Magisk Manager and the modules you want.

I'm guessing you want to use Magisk superuser though. Remove any previous root (which might entail flashing a clean boot image, that's the stock part), flash Magisk in recovery. Done! Install the Magisk Manager, phh's superuser app and the modules you want.

Your mileage may vary, but it shouldn't be more difficult than that.

The chance of bricking is quite low. The only modifications that are made, are made to the boot image. If anything goes wrong it's just a matter of flashing your ROM's unmodified boot image. This is also done when using the uninstaller...

If you want to make your own modules, this thread has the instructions and tips that you want. It's quite easy to make a basic module. Download the template and read the included instructions. You can replace/create build.prop properties, move apps to system, replace system audio, etc, etc. Any system modification really, and more... All without touching your actual system. I love it!

Good luck and happy flashing.
[Magisk] 4RK4N:
can it be there is a bug in magisk 10.2 with disabled modules still being active ? i made a module changing some build.prop entries using the system.prop function with only PROPFILE=true set in config.sh and the changed build.prop lines in common/system.prop

everything worked fine and the play store recognized my phone as pixel xl to get all daydream apps.

BUT google camera fc'ed upon opening (latest purenexus rom) and daydream apps forced me to quit the game due to "overheating" while the phone was cool.

So i went to disable the module and rebooted. build.prop was still changed.

uninstalling my module restored original build.prop but thats not how its supposed to work with disabling modules, right?

i attached the module if someone wants to test. dont worry it only changes some build.prop entries to pixel xl values. feel free to inspect it. maybe i did smth wrong?
[Magisk] reis1996:
I did a similar thing to disable google assistant which my dev has made in built into my note 2 ROM and the sim card doesn't get detected. Un did the edit in the build.prop and it got detected again
[Magisk] ahrion:
So I'm porting my Dolby Atmos mods to Magisk but I'm running into a problem where my SuperSu/Su gets deleted. I'm assuming it is because the apps are about 130mb combined. Any ideas as to why this is?
[Magisk] Didgeridoohan:
Details and logs needed...
[Magisk] Didgeridoohan:
I can confirm this... Properties set with system.prop are still set from a disabled module. I'll open an issue on GitHub.
[Magisk] ahrion:
I can't give a log because root is unavailable and I'm not around a pc. here's the link https://drive.google.com/file/d/0BxlY-VYiFXU7YmhGWnZUYTZsVDQ/view?usp=sharing

Essentially I made my edits and root is removed when I made my edits. There's not much else to it.
[Magisk] Didgeridoohan:
Sounds like the module isn't working and causing Magisk to not mount properly (late_start services starts early).

The only obvious thing I can see with your module is that you've added lines to post-fs-data.sh but not set POSTFSDATA=true in config.sh. Might be other things causing issues as well.

Recovery log from flashing and Magisk log from the following boot are both very useful. Neither of those need a computer. Recovery log is saved in TWRP and Magisk log is in /cache and can be pulled through TWRP.
[Magisk] RequeLine:
I created a Large Caller ID module using InCallUI.apk. The module works fine on its own. However, if there's another module installed that uses InCallUI.apk, then my module does not get applied. How do I go about fixing this?
[Magisk] Didgeridoohan:
How do the different modules use the apk? Would it be possible to merge the two modules? Also, a Magisk log with both modules active could be helpful.
[Magisk] RequeLine:
Both modules contain their own version of InCallUI.apk. Mine just modifies the caller ID screen. Viper10 is a ROM module. Obviously I can't merge them as I cannot distribute the ROM module.
[Magisk] Didgeridoohan:
Two modules won't be able to replace the same file without issues...

I haven't tinkered with them myself, but are you talking about the Magisk one click custom ROM modules? If so, you should be able to replace the apk in that module zip with yours, no? Alternatively remove the apk from the ROM module altogether and only use your module. Since I'm not quite sure how the modules are set up or how they work, I'm just throwing out ideas here...
[Magisk] RequeLine:
I know how to replace the apk in the ROM module for my own personal use, but I would like to share my work and create a module that others can download and use on top of the ROM module.
[Magisk] Didgeridoohan:
Ah... That's what you're asking. It was not clear from your original post.

That, I believe, is currently impossible. You can't have two modules replace the same file. One module is gonna take precedence over the other.

Maybe you should open an issue with a feature request on GitHub. Seems like this could become an issue if and when more ROM modules start turning up.
[Magisk] laggardkernel:
I remember I encountered the same problem on Magisk v8. Since adding new props, the new props which you can't see through getprop command on a device, take much more time than modifying an existing prop. Hence su, from the SuperSU, didn't have enough time to be mounted.

But this could be avoided using the RESETPROP introduced in v9, or maybe it's just because I swithed to phh's superuser. And you'd better comment the PPID part which is used to keep Dolby service to exclude its influence firstly before your test.

Here is the module I modified upon your Dolby ATMOS ports before. I tested it with Magisk v9 and phh's superuser on OnePlus 3. Maybe it will help you a little. https://github.com/laggardkernel/magisk-module-template/tree/leeco_lemax_2
[Magisk] RequeLine:
Just to explain this a bit more. I have a LargeCaller ID mod for the classic (non-Magisk) version of Viper10 ROM that is available in Venom HUB. I would like to have the same mod available for the Magisk version of Viper10 as a separate Magisk module. I've tried using the same MODID in config.sh as the ROM module, but then the whole module gets replaced. I would like to find a way to apply my module on top of the ROM module without replacing it entirely.

[MENTION=4470081]topjohnwu[/MENTION]

is this possible?
[Magisk] ahrion:
So I'm not changing any props. I deleted the apks from the script and I'm still encountering the lack of Su after flashing. I'll check when I come home from work but going to a Chevelle concert tonight so maybe after.
[Magisk] kami2k:
After installing viper rom in magisk as module what to do next? how to activite it? nothing happins its only showing in module list
[Magisk] mrinmaydhar:
Download the app from the ? below
[Magisk] jejemc:
Hello topjohnwu esce possible a module for crt off animation? thank you ;);)
[Magisk] ryaniskira:
Viper4Android Bootloop issue

I capped an adb logcat during the bootloop caused by the V4A Magisk Module

http://pastebin.com/zGRGdxEx
[Magisk] PixelatedVision:
i am having the same issue
[Magisk] moore.bryan:
Same boat; ever figure this one out?
[Magisk] spacebar2011:
My fellow Magiskers, I have a few questions here.

How does Magisk deal with encryption, specifically the new file based encryption in Nougat. I mean, is it possible to use Magisk while still having encryption on?

If i want to update my ROM (Oxygen OS 4.0.2 on a Oneplus 3), have Magisk installed (with MagiskSU), what's the best way to go about it without a full wipe.

Which version of TWRP is recommended for this? I mean, with all the decryption password, dm-verity issues and then the risk of the device getting fully wiped, which one is recommended? I'm using the blu_spark 3.0.2 v11 and it's been doing okay, at least till the last time I used it for Oxygen OS 4.0.2 installation.

I know the TWRP question might be out of place here, but, I guessed someone here might have an answer anyway.

Greatly appreciate any help with the above.. thanks! :)
[Magisk] stangri:
[MENTION=4470081]topjohnwu[/MENTION] -- please review 3 module submissions currently active.
[Magisk] redemptionx11:
I didn't have any luck doing it with magisk. I ended up flashing a viper4arise zip and it seems to be working.
[Magisk] jasio2k:
Hi all

I'm new to magisk all work fine on rr passing safenet etc.. but I can't find how to set selinux permissive on boot? I was look for answare on forum but can't find anything. Thx for help
[Magisk] darkeyes22:
Hello

I've made a Magisk module that's supposed to add ZenUI apps, but it only installed 3 apps out of 15 ;( Any advice how to fix it?
[Magisk] Didgeridoohan:
No advice, because no-one but you have seen the actual module... If you upload it someone might be able to take a look.
[Magisk] darkeyes22:
https://www.mediafire.com/?ohj27vllrwlbvep here is the module.

NOTE: i haven't named module yet, but idea of name is: ZenUI Essentials
[Magisk] shingz96:
i noticed that when put the boot animation zip in the /cache/magisk_mount/system/media/bootanimation.zip will replace the original bootanimation and when i deleted the bootanimation.zip in the /cache/magisk_mount/system/media/bootanimation.zip, it will revert back to the original bootanimation.

May i know how magisk store the original bootanimation? because after replace, i view in the /system/media/bootanimation.zip was change to the one in /cache/magisk_mount/system/media/bootanimation.zip
[Magisk] KRiST0F:
Is there a way tu remove magisksu? if i remove magisk, magisksu ain't gone.
[Magisk] teddy0209:
It's Magic... ?
[Magisk] Filip013:
Flash Magisk uninstaller. Download it here.
[Magisk] rignfool:
I bet you're out of space... Or corrupted your magisk.img
[Magisk] RandomPooka:
You could also wipe /system and then dirty flash your ROM, gapps, and kernel (if you use a custom one). That should do it.
[Magisk] darkeyes22:
What space? I have 32gb of internal memory. By the way, did module worked for you?
[Magisk] shingz96:
may i know if there any way to set permission to a file when adding that file to /system/xbin?

i try the set_perm function in the config.sh but still the permission is not set when the file is added to /system/xbin
[Magisk] Didgeridoohan:
Could you post the config.sh for your module, or at least the permissions part of it?
[Magisk] Roroow:
Hi, I have a MOTO g4 with RR v5.8.2 nougat and I cleaned the ROOT that came by default, since this prevented me from running applications like Pokemon GO, so I want to install magisk from 0 with the ROOT included. What are the steps that I should follow?.

Sorry for my bad english
[Magisk] godzulu:
Magisk 11.1 and pairs.apk 1.2. I just did a clean flash on 6P PN. Reinstalled apps all is working incl AP. Except when I try to open pairs. Says it can't get root, but it never asks for root. Any ideas how fix? Tried deleting data/cache, clean install etc. Even flashed the su xbind zip. Nothing works. Thanks
[Magisk] Didgeridoohan:
I believe that's a small detail you left out of your original post... And probably the source to your problem. Go to your ROM's thread for advice.
[Magisk] RandomPooka:
Very much an important detail. I'm a bit curious which ROM you're using that has magisk already built in. That seems like trouble waiting to happen if anyone using it decides they want to change versions or even switch to a different root solution. It also vexes me in that baking a systemless root solution into system seems like it would defeat the purpose of a systemless root.

Good luck, though. Hopefully, the magisk zip is just bundled in with the installer zip as an additional flash and isn't so highly integrated into the ROM that you can't get rid of it.
[Magisk] KRiST0F:
i've used tesla (op2) rom from GZR.
[Magisk] smeejaytee:
Guys I wonder if someone might be kind enough to help​ me out, i make a booster mod for m8 and many ROMs are now converting to magisk as the standard root method, I've had a couple of people try to make my mod magisk compatible but we keep running into issues, the first couple of attempts failed safety net and the others the scripts shouldn't execute, should anyone be kind enough to lend a hand please, proper credits will be given of course. TIA.
[Magisk] ahrion:
Should have come to me brother.
[Magisk] hachiroku:
has anybody been able to get root access to work using Magisk 11.1? when I click "Use Root" the box won't check and obviously I don't get the prompt that root is not detected since I am rooted.

I've been reading and supposedly tasker can only detect SuperSU? those were old threads so I'm not sure if that still maybe the case.
[Magisk] Didgeridoohan:
Not quite clear and in the wrong place, but I think you're talking about using Tasker with MagiskSU... If so go here and scroll down to "Tasker and MagiskSU": https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] J0L3:
Good Job!
[Magisk] Nomelas:
Information is a bit conflicted on the OP for resetprop.

Originally I have been using post-fs-data.sh to call resetprop. However, I want to move it to the system.prop configuration that it suggests:

But the usage example it gives:

Does not match the example in the system.prop file:

How do I use the -n and --delete using this setup?

For example:
[Magisk] ahrion:
So I'm not exactly sure what's causing this issue but with ONLY my Dolby Atmos mod SystemUI FC on 11.5/6. This only happens with the newest version so I'm thinking something isn't working properly. [MENTION=4470081]topjohnwu[/MENTION]

https://github.com/therealahrion/Dolby-Atmos-LeEco-Le-Pro-3
[Magisk] topjohnwu:
If you want the detailed options, you will need to manually call resetprop through scripts.

The system.prop is only using the --file option, a convenient shortcut since most developers are adding or modifying props, and whether it triggers things doesn't matter that much.
[Magisk] ahrion:
So the app itself is changing the system props in my mod causing the SystemUI FC.

How do I make my ported app work in this regard? It worked prior to this version.
[Magisk] Nomelas:
ok, so I can continue to use /data/magisk/resetprop as I have been?
[Magisk] topjohnwu:
Yes, and you actually can just directly call resetprop, as it is now added to /sbin
[Magisk] nvlinh.kaitoukid:
Help me

Help me

My flash zip error

upsieutoc.com/image/YulJzG
[Magisk] Zackptg5:
Support questions belong on the support thread. Besides, he'll need more information than that such as phone model, rom, etc.
[Magisk] nvlinh.kaitoukid:
Lenovo k3 note rom vieui 1604 st
[Magisk] hroen_al:
hy I'm new with magisk

I'm comin from v11.1, my app working fine

but after updated to 11.6 some of my app FC

disable magisk and no FC anymore

do I need to uninstall 1st before update?

or reflash system rom and flash new version of magisk?
[Magisk] kunal1540:
Why don't you help the developer by getting a logcat (just google it, it's very easy) of your fc's

That way they can exactly tell what's wrong with your setup
[Magisk] wordlessecho:
Awesome!
[Magisk] metrize:
Keep losing root when install module? what's happening with magisksu
[Magisk] jhedfors:
This is the wrong place for support questions.
[Magisk] JohnCorleone:
Mr. WIZARD, I know that you are busy 24/7 but when you get a chance can you update, the modules you made for the HTC 10? The,GPE dialer and contacts module and any that may not be out there yet. Congratulations on adding a new layer to phone customization!
[Magisk] Didgeridoohan:
Uninstall SuperSU. This is where you might get issues since you're using a pre-rooted ROM. It might be difficult to find a boot image that doesn't already come patched for SuperSU. Check your ROM thread for advice or try flashing a custom kernel.

Flash the Magisk zip in recovery.

Reboot and install the Magisk Manager.

Done.

There are currently (v11.6) some compatibility issues with certain Samsung devices. It'll probably be fixed in the next release (soon, very soon).

If you have issues on the way, got to the support thread and search (this is not the correct thread for support requests). If you can't find the solution, post as much details as possible with relevant logs (recovery log, Magisk log, etc). Most issues have already been covered. You can also take a look here for some collected tips and tricks:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] anshulsingh:
Thanks I have raised this question in the support forum.
[Magisk] alb.boy:
Dummy question

Sorry, one quick question. I have flashed an custom rom on my S7 and i have Magist v11.1 installed from the rom, now i receive an update what to do, can i directly type from in the application "Download&Install" but my question is do i have to check those to lines into the advanced setting? Thanks in advance :D
[Magisk] MBariya:
[MENTION=4470081]topjohnwu[/MENTION]

Megisk Modul got getting installed though latest Magisk Manager app 4.3.1.

I have updated module to latest v3 as latest available. Also on Magisk v12
[Magisk] nevernat_theoriginal:
Selinux permissive script

Hi,

first of all, thanks for your great work.

I'm a newbie. I'm on LG G4 H815.

I would like to ask two questions:

1. where should I put the attached script (before it functioned in /su/su.d) to run it on every boot? (I tried to put it in post-fs-data.d and service.d, to no avail);

2. why the SafetyNet control gives the error reported in the attached image?

I installed Magisk 12.0.

Sorry for my english.

Thanks in advance.
[Magisk] laggardkernel:
It works, but magiskhide will hide it as pseudo-enforcing.

I dont know since I don't care about safetynet.

BTW, why you guys are trying to ruin the Wiki & DOC thread for developers?
[Magisk] adewisman:
+1 for a module development wiki & doc threads.

I kept on failing to archive my module no logs to show me what I do wrong ... or did I miss something ?
[Magisk] Doc Franky B.:
Tap Repo-Cache clear and restart your Phone.

That's did it for me

Send from Note4 - 6.0.1
[Magisk] alb.boy:
Hi all, im a bit new with Magisk, i've instaled on my s7 a custom rom which had pre-installed an Magisk version, now that i have some days with this rom i got an update notification, how does update work? i just hit "download&install"? and before doing so i have to check the two lines : force encrypt amd dm-verify. Thanks in advance! :)
[Magisk] Didgeridoohan:
Wrong thread for support questions, but just press install...

If you need further help go here:

https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382
[Magisk] Telperion:
I'm working on a module for systemlessly replacing stock Huawei apps with Google versions (or other alternatives) and I'm running into a bit of a problem. I started off small by replacing Gallery2.apk with QuickPic. It overwrites the stock gallery as intended, but crashes when it attempts to load.

Update: It looks like the library folders under the application folders in /priv-app/ were the problem, when I explicitly listed those folder paths in config.sh to replace the whole directory the applications work now. I'm leaving this post up so that if anybody else has a similar problem they can find it.
[Magisk] Jack'O:
Hi, is there a way to install Magisk via fastboot or adb in order to not need to unlock devices bootloader and flashing a third party recovery?
[Magisk] Zackptg5:
I'm pretty sure you can't modify anything other than data, cache, and sdcard if your bootloader is locked so probably no
[Magisk] Jack'O:
Thanks for reply, I would like to install just an ad blocker, don't know if it needs to manage /system or other restricted partitions.

Edit: Unfortunately yes, those are AdAway requirements (from AdAway official site):
[Magisk] Zackptg5:
Most adblockers that require root modify system (and most require root). So if you don't want to unlock the bootloader/root your phone (magisk is a root solution among other things), you'll need to find an adblock that doesn't require root. The only ones I know of just route your network traffic through the filters via VPN
[Magisk] guest4711:
You may try DNS66. You will find it on f-droid: DNS66 (Block ads/hosts via DNS) - https://f-droid.org/app/org.jak_linux.dns66
[Magisk] Jack'O:
Thank you, didn't know about this kind of rootless adblocker
[Magisk] guest4711:
Old SuperSu was mot uninstalled properly. So magisk thougth you will use it again and recommended to flash it as next step.

Either uninstall it properly or flash it after magisk...
[Magisk] :
this application it's meant to self auto installing after removed from system ?
[Magisk] Didgeridoohan:
I think you need to take that again, and give some more detail... Because I have absolutely no idea what you're asking. :confused:
[Magisk] habylab:
How can I see currently available modules without installing Magisk?
[Magisk] stangri:
Only like this: https://github.com/Magisk-Modules-Repo.
[Magisk] habylab:
Thanks. Virtually nothing on offer that interests me for now, so I will leave it. Thanks!
[Magisk] ZawZaw:
Hi...all,

I want to build Magisk from source.

Please Guide link me.

•••
[Magisk] teddy0209:
https://xdaforums.com/showthread.php?t=3473445
[Magisk] nathanchance:
It's literally in the README... https://github.com/topjohnwu/Magisk/blob/master/README.MD
[Magisk] ZawZaw:
Thanks Sir Flash. ?

•••
[Magisk] AzzidReign:
I get nothing but bootloops with Magisk.

I'm on Note 3 (sprint), Android 5.0. I've been rooted for years and am currently on the newest 2.79 systemless su.

Here's what I've tried:

Recovery > flash magisk 12.0 (and unofficial 13.0) > reboot ---> bootloop

Recovery > flash magisk 12.0 > flash supersu 2.79 > reboot ----> bootloop

Recovery > flash supersu 2.79 > reboot (so now I'm stock rom + supersu and I do have xposed, looks like v85.0, it was hard to find a working one for note3 about a year ago) > launch magisk manager > install magisk ---> error quickly flashes about saving or storage (too quick for me to read, isn't in any log iirc)

Am I doing something wrong? Should I flash a specific ROM to get this to work? TIA!
[Nexus 5X General] Wuzimu:
Hi. New image is available https://developers.google.com/android/nexus/images . Anyone testing it?
[Nexus 5X General] crian:
Has something changed, like bootloader, radio,...?
[Nexus 5X General] bostonirishguy13:
New BL. Same radio.
[Nexus 5X General] linqdesires:
Trying to download the zip from chrome on the N5X and download after 2-3 minutes drop silently! Same there?
[Nexus 5X General] vince.lupe:
Runs smooth as hell!
[Nexus 5X General] crian:
Download it on your PC. I had the same issue with downloading it on my phone.
[Nexus 5X General] linqdesires:
Yeah it was the only way I had to use a PC, I wasn't able to download it from the phone. Quite strange.
[Nexus 5X General] hilla_killa:
Strange i never have issues dling them on my phone! Is your data saver on in chrome?
[Nexus 5X General] zurik:
Use Opera Browser to download it. I used this browser to download the Factory Image.

Δημοσιεύτηκε από Google Nexus 5X με Android 7.0 Nougat μέσω Tapatalk.
[Nexus 5X General] nitinvaid:
can someone post the vendor.img flashable if possible
[Nexus 5X General] Tulsadiver:
Here is the vendor image pulled from the update.

https://www.androidfilehost.com/?fid=312968873555002997
[Nexus 5X General] nitinvaid:
is there anyway i can flash it from recovery?

EDIT i think i can ill check it
[Nexus 5X General] Tulsadiver:
Yes, just select image option after you hit install (bottom right side). I believe that should work.
[Nexus 5X General] NewAndreas:
Had the same problem, it helps if you keep chrome open. Still annoying though ?
[Nexus 5X General] cryhos:
You can flash the vendor.img with this command in fastboot mode :

fastboot flash vendor vendor.img
[Nexus 5X General] procito0o:
Where found a changelog of the builds? :confused: