yashsingh1/xdaforums huggingface dataset:
[ONE Android Development] harshdoshi25:
List of requested features

Ah, since you ask, and I've been inactive for way too long, here goes:

1. More QS tiles! GPS, mode switching, sync tile, auto brightness, blue filter night mode, all of it. (but it is possible to add these with other apps, through which I now have 100QS tiles :P but not GPS modes.

2. Full manual mode in the camera with any blob. I use Bacon Camera now which works perfectly and esp. since I use lossless codec of Bacon camera.

3. Crop before taking screenshot option like it was there in the very beginning.

4. Voltage control! (if unstable, it'll be the users' fault, not the ROMs :P)

5. Full OMS support!

6. Call recording!

7. Display color settings! OPO doesn't have the best display or the best blacks. The option to tweak saturation/contrast would be awesome (and not just temperature) this was there before I think, and having it natively would be awesome.

P.S. This is the best and the only ROM I use now on my OPO. Amazing work mate, huge fan. [MENTION=2040569]jgcaap[/MENTION]
[ONE Android Development] bernardoko:
No problem here, connected to my Toyota Touch and to my Samsung Gear S2.

BT always on.
[ONE Android Development] pitflyer:
I don't have any Bluetooth issues but both of my OnePlus one devices with this ROM on it now often boot and show 'no sim card inserted'. On one of them no matter how often I rebooted or tried different SIM cards it would not read ANY of them. I assumed it was a hardware failure. However, on my other one it worked initially, then usually in the morning it would not read the SIM card (I turn off this phone at night). I would reboot again and most of the time it would work. This morning it took me six tries before the phone finally read the SIM card.

The only external factor I can think of is that it may be a bit cold (it's in the glove compartment and I'm in a cold area) and that's somehow causing this problem. Because of that I'm going to keep it inside and see if it works, but now that I have TWO phones with the same issue, I'm going to take the old one I thought was 'broken' and install another ROM on it and see if it works now.

Again, could just be a hardware/cold issue but just something to report in case other people run into it.
[ONE Android Development] TVJS:
Deleting battery stat's whenever I want. It was there in your cm13.. Thank you
[ONE Android Development] arifnasirshaikh:
Holding power button for even 2 second results in soft boot
[ONE Android Development] Wisiwyg:
Try replacing a SIM... Drop by your service co and ask them for a replacement. Should be able to give you a new one in a few minutes.
[ONE Android Development] prototyp01:
Can't confirm this.
[ONE Android Development] :
May be due to substratum theme if you are using one. I faced this issue once.
[ONE Android Development] svnhvn:
Me neither.
[ONE Android Development] arifnasirshaikh:
Yes... Theme was the culprit.

Install swift black substratum theme and see for yourself or any other.. Majority of theme resulted in soft reboot
[ONE Android Development] LucentBirch:
Can anyone get substratum legacy to work with this ROM?

If we're still suggesting features -- full OMS support would be lovely.
[ONE Android Development] bmark240:
If you are prepared to wait, Substratum will release a non rooted version (you don't have to be rooted) which means the Legacy integration won't be as buggy.
[ONE Android Development] Gawd:
There will be absolutely no change in Substratum Legacy regarding that release. It's just that it won't require a rooted device to use Substratum now. See more about it here and rootless commits here.

So yeah, Substratum support would be a bliss!
[ONE Android Development] jgcaap:
Tomorow! :)
[ONE Android Development] DeadFox-xda:
Do you plan on changing the camera hal? There has been some talk about oxygen camera hal, just wandering, nevertheless your rom is great.

Edit: i read about you updating sultan camera looking forward to that port
[ONE Android Development] User15243:
Noob question sorry but do you have to flash the firmware after every update or only once from the very beginning?
[ONE Android Development] Levivig:
You don't have to flash it everytime.
[ONE Android Development] AZGeek:
If you can please unlink the phone ringer and notifications volumes.

And if you could let us know which camera is in new build when done.
[ONE Android Development] Gawd:
"Some time ago, LineageOS maintainer [MENTION=5405215]forkbomb444[/MENTION] replaced one of sensor blobs with find7 one and disabled text relocations for Oneplus One (click). Why? Because it caused some security issues. With replacing this lib, dependency of allowing them is gone. The problem is that OxygenOS 1.x JPEG encoder (sultanxda camera HAL is based on OxygenOS 1.x blobs) uses text relocations. After this change Android linker refuses to load that blob, so captured photos aren't saved. Because *almost* all ROMs for OPO use LineageOS-based trees, camera breaks at new builds."

- [MENTION=7534963]ab123321[/MENTION]

So jgcaap now needs to allow text relocation in the ROM and it's much more work, I guess.

I'd advise to go for OxygenOS 3.xx blobs since they're much better quality and isn't that much of a hassle too.
[ONE Android Development] :
Can I flash magisk to root this ROM?
[ONE Android Development] jango93:
Yes Magisk is working perfectly :)
[ONE Android Development] ashutoshmn:
Agreed.
[ONE Android Development] Areebanwar:
Hello..could we please have an option in the File Manager to allow root? I'm asking so because I don't really like the shutter sound but the new updates don't show it...I've tried deleting the sounds from other apps like ez file manager but it doesn't really remove the file..thank you so much!
[ONE Android Development] svnhvn:
I'm using Root Explorer and just renamed the files with adding *.bak, rebooted it and profit.
[ONE Android Development] robbieast:
Do you use titanium backup?

I tried magisk and it seems titanium backup has issues restoring apps with magisk
[ONE Android Development] jango93:
I just did a backup using tb, uninstalled the APP and restored APP+data...

No Problem!

What is your issue when restoring apps?
[ONE Android Development] GXGOW:
Haven't experienced any problems yet with the TB + Magisk combo. What's the exact issue?
[ONE Android Development] robbieast:
I am trying to restore pixel launcher as a system app with data as that is the only way it will completely function at least for me and I am unable to do it with just magisksu (I want to be able to use android pay so no superuser combo)...

Usually for me with only superuser 2.79 when I restore pixel launcher as a system app it just hangs on its processing and I wait for a little then restart and pixel launcher is restored perfectly fully functioning as in I can swipe right and get to the google now cards

With magisk it says its restoring and I try to restart and it doesn't restore it
[ONE Android Development] jgcaap:
New build with new full lineageos rebase. Next step features.
[ONE Android Development] CooperBrick:
Can you consider to add something like a wakelock blocker? It's very useful for better standby times, and without Xposed there aren't any other solutions
[ONE Android Development] jgcaap:
be carefull. Thats not a good feature. We've added in the past, and even after the developer reviewed the code and published again on marshmallow version, temasek tested it and it still created battery drains. If you find contrary, trust me ... is not realted to the wakelock.

The wakelock discussion, we learned that is related on how you configure google services. So forget stuff like that.... It's the wrong way to enhance battery.
[ONE Android Development] jgcaap:
This last version is very fast..
[ONE Android Development] jgcaap:
It seems the caf rebase lineageos team did was completely worth it.
[ONE Android Development] ShouriX:
How should we configure the google services?

So apps like amplify and powernap to block wakelocks are counterproductive?
[ONE Android Development] ashutoshmn:
so the rom is now on caf base? Cool!
[ONE Android Development] K.rockr:
Why did they rebase to caf? Any idea?
[ONE Android Development] billbuds:
How you increase performance in this rom ?
[ONE Android Development] Gawd:
Short answer: no

Long answer: you need to read the code of those Apps, they're (awesomely) open-source. I don't feel eligible enough to understand it all myself, let alone explaining.

Ps: wakelock blocker as a ROM feature is useless
[ONE Android Development] jgcaap:
When you use each app you need to configure how it'll use good services. That is something which has to be done with patience.

Guys... We were always caf... Lineageos team Just done a new rebase over caf sources, problably to clean bugs.
[ONE Android Development] thra1982:
Is it fast compared to the official Linage builds? Or is the builds nearly identical?

Is the camera still a top priority and how is the progress?
[ONE Android Development] jgcaap:
Matter of testing and letting me know... I've added a some optimizations which I learned to be worth it.

Well see if today I can release a new camera port.
[ONE Android Development] Jole7:
[MENTION=2040569]jgcaap[/MENTION] please don't forget us OP3 users man
[ONE Android Development] JonasMeyer:
new feature maybe?! :

volume down + power = screenshot

Volume up + power = particial screenshot

I think that would be awesome :) would love to see that
[ONE Android Development] jgcaap:
Sorry. I'll put building today.
[ONE Android Development] Morghoth:
Hi guys, I´m on a different ROM now which I use as a daily driver. Can you please confirm/deny following issues?

1. In the first nightly there was no way how to hide brightness bar in notification drawer. Is it possible now?

2. Is it possible to turn wifi on and off (using notification drawer) just by ONE click? Not sure if this is a feature of Nougat but it is extremely annoying.

3. If I select to use only 3G connection does it still switch to LTE etc randomly?
[ONE Android Development] jgcaap:
Well on those 3 questions..

Google has implemented two views on notification draw. The simple view and the more complete view. So to answer the first two questions, I'm not sure when you mean by one click, since that it already exists. If you are used to the more complete view and want to have 1 click on that... Then not yet implemented that. But you have the option of a simple click on simple view, which is pratical also.

On your third question I believe you can select the preferred band on mobile network settings. Have you tried selecting only 3g in case yo don't want LTE? It is important to understand that is not randomly but when there is good LTE signal available :)

Hope I was able to help.
[ONE Android Development] DeadFox-xda:
Ohh... (Quickly dash home and download your rom asap and call in sick for work)
[ONE Android Development] Jole7:
Thank you very much Sir many peolple waiting for your builds because you're making the best optimized roms out there.
[ONE Android Development] jgcaap:
Building for op3
[ONE Android Development] Morghoth:
Thank you for reply jgcaap. Well I mean the complete view. The fact that there is no way how to hide brightness bar and turn wifi one/off in one click are things that hold me back from Nougat/Lineage. The existence of small and complete view is schizophrenic anyway, haha
[ONE Android Development] jgcaap:
Why it is so important? Is so nice the speed :p
[ONE Android Development] mustang_ssc:
How do you manage to build it with the phone? :confused: It must be really comfortable to check the build process while you're for example meeting with friends.
[ONE Android Development] GXGOW:
Tried to dirty flash the latest build, but that resulted in a bootloop. Guess it has something to do with the rebase in this build. That'll be a clean flash.

Just putting this out here. Be careful dirty flashing the latest build.
[ONE Android Development] vicks0602:
no problem for me dirty flashed wiped cache and dalvik...looking good and yes it feels fast :)
[ONE Android Development] DeadFox-xda:
What did you do to make it so fast?
[ONE Android Development] Gawd:
This
[ONE Android Development] DeadFox-xda:
Okay so not the drivers that sultan used? I'm just learning about ROM hopefully one day I'll be able to build my own
[ONE Android Development] jgcaap:
thanks to xda members, I have an server to only make builds for the community.
[ONE Android Development] Prinz`:
Umm, actually they are present in Nougat ! RR, Aosip and almost every feature filled rom has it ;) You can try them
[ONE Android Development] NeoAqr:
Sorry for dumb question but CAF based rom means no slow shutter longer than 2 seconds?
[ONE Android Development] LookedPath:
[MENTION=2040569]jgcaap[/MENTION] can you take a look if you can integrate this into the rom?

Apparently LOS team added it but then reverted the commit and I didn't understand why. You can view the commit here.

Thanks
[ONE Android Development] Pacer_456:
[MENTION=2040569]jgcaap[/MENTION] Small request to change the thread title to [Make LOS great again!]

Not important but kinda bugs me out lol.
[ONE Android Development] Syaani:
You can't make LOS great again because it has you been established. We are making CM great again by making LOS better and better. ;)
[ONE Android Development] kallest1100:
Can anyone tell me, oms substratum is working now?

With the latest Nightly?

Thanks
[ONE Android Development] BigMacca:
Hello all,

Has anyone managed to get android pay working using magisk?

Is something that I've wanted to get up and running for a while, but the magisk thread was just a clusterf**k you try and follow...

Cheers

Macca
[ONE Android Development] LucentBirch:
I'm using it right now!
[ONE Android Development] bmark240:
Just installed the new build, weird as it came out a different size. Seems snappier but at increased battery drainage. I will let it settle in fully for a couple of charge cycles to get a fairer drain level.

Could you add this setting from:

https://www.xda-developers.com/how-to-double-the-wifi-speed-on-your-oneplus-3-3t/
[ONE Android Development] jgcaap:
No drain here. That's only for op3 hardware I believe..

I'll update soon to sqlite 3.17
[ONE Android Development] BigMacca:
That's encouraging :)

Could you run me through the steps you went through to get in working?

Cheers

Macca
[ONE Android Development] LucentBirch:
Go to this thread (https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445) and download the 11.1 Magisk zip. Go to the play store and download the Magisk manager app. Reboot to TWRP. Flash magisk zip. Reboot. Open magisk app. Go to settings and enable magisk hide, BusyBox, and systemless hosts. Reboot. Open magisk app again. You will now be rooted and have magisk hide enabled. Android pay will be selected by default and will work on this rom because you should pass safety net. If you had a superuser installed you'll have to delete the su files from system/bin and system/xbin. Though, it would just be easier imo to do a clean flash and start from scratch. If you do that, don't flash magisk until after you've booted up the clean ROM.
[ONE Android Development] BigMacca:
You Sir, are a gent :)
[ONE Android Development] robbieast:
Same dirty flash didn't boot :(
[ONE Android Development] jgcaap:
Mine booted... What changes did you made?
[ONE Android Development] prototyp01:
Dirty flash worked fine for me, as always.
[ONE Android Development] robbieast:
Maybe cuz I have multirom?
[ONE Android Development] 0r32:
I don't use multirom but still had to do a clean flash
[ONE Android Development] robbieast:
I wiped system dalvik and cache and installed magisk 11.1 and the manager...

I have those 3 options enabled and USB debugging disabled and I can't get safety net check to pass?

Always says CTS profile mismatch...
[ONE Android Development] LucentBirch:
Selinux status? It seems that a lot of people can be hit and miss with safetynet. Did you do a clean flash to ensure there were no su remnants?
[ONE Android Development] robbieast:
I wiped system through twrp so I figured that would do the job for cleaning su remnants.

I've tried both enforcing and permissive

Edit.... Actually it's enforcing.. Permissive I can't use.. Changes back to enforcing
[ONE Android Development] LucentBirch:
Well, that's unfortunate... Don't know what else can be done, really. I was in same boat with fresh's AOSP ROM, but it works just fine coming to this one. I'm sorry I don't know what else can be done at this point.
[ONE Android Development] BigMacca:
I've got exactly the same thing.

Followed the instructions exactly but am getting CTS profile mismatch (been through it all 3 times now :( )

Poo!
[ONE Android Development] robbieast:
I figured out what causes safetynet to fail...

Its if you use the app "get assistant" to have google assistant. It modifies something in build.prop that breaks the safetynet check from passing.

Can anyone do some recon to figure out what it is??
[ONE Android Development] BigMacca:
I don't have the google assistant installed, so it must be something else causing me issues. ..
[ONE Android Development] C4SCA:
I tried this a while back in COS 13.1.2, forced my router to 40MHz and on 2.4GHz i would reach easily my full bandwith (100Mbps up and down) but since i live in a city it was ultra unstable.

So yeah the OPO can do this on its own but i wont recommend to anyone.
[ONE Android Development] DeSlaye:
I'm still on an iPhone 7+ but I love to tinker, does anyone know of a way to install oxygenOS 3.0 blobs on top of this rom?
[ONE Android Development] ashutoshmn:
only one way i. e. porting, to make sure it's fully functional and stable, Jorge is working on this, we need to wait.
[ONE Android Development] djozaa:
For me safty net passed when i disabled busybox in magisk management and pressed clear repo cache, then rebooted.
[ONE Android Development] zlewe:
Got a random reboot off latest build.

last_kmsg: https://www.dropbox.com/s/0w7a1z1avdxploa/last_kmsg.txt?dl=0
[ONE Android Development] bmark240:
The setting is related to 2.4GHz frequency.

The one that is included in WCNSS_qcom_cfg

Is purely for 5GHz frequency.

I have used it my settings and it feels faster. I just need someone to test & see if it isn't a placebo as my router has 5GHz as primary frequency.

Oops. I hadn't realised a reply. Maybe someone else could try the setting & report back. I live in London & haven't encountered any problems, yet.
[ONE Android Development] jgcaap:
Wcn as Crash.

If this happens again please reflash latest firmware.
[ONE Android Development] BigMacca:
Thanks for the suggestion, still doesn't pass for me with the above change :(
[ONE Android Development] Interfector:
18/02 build (latest)

Everything works fine and smooth, and it seems quite faster then the previous build.

Flashed yesterday, no bugs spotted.

Clean Flash (data, system, dalvik/art, cache) with SuperSU V2.79.

EDIT: I also use V4A and it works fine.
[ONE Android Development] digitalpig82:
What's your impression regarding battery life?

I'm a bit concerned about these "everything's faster now" posts... In the past, almost every time when people wrote this, the battery life went significantly down at that point.

Btw, I'm still on the 20170209 build and loving it! :) Great overall user experience and battery life! Thanks jgcaap!
[ONE Android Development] marinespl:
It's all placebo effect.
[ONE Android Development] Genericxx:
Meanwhile those Apps are obsolete because OpenGapps enables Google Assistent itself on any device if "GoogleAssistant" is found in gapps-config. It does it by adding a certain line i build.prop. I guess it has to do with something else, because i am currently using RR, am rooted (integrated SU) and have Google Assistant enabled and passing Safety Net.
[ONE Android Development] Gawd:
The line is:

ro.opa.eligible_device=true

Anyone having Google App version 6.11.13.21 or higher can just add this line to the end of build.prop to get Google Assistant, and the model name line is not needed anymore.

Get Assistant is not an obsolete App because it does what it is designed to do, and nothing else. Also, it creates a backup (.bak) of the original build.prop which is a neat inclusion.

Yes, you can also use OpenGApps' gapp-config file to get Google Assistant, but that doesn't make any other thing obsolete. Or you can just make the change manually. It's that simple.

Edit: SafetyNet doesn't check build.prop but RootBeer does.
[ONE Android Development] Interfector:
Let me try it for a couple of charging cycles so I can be more accurate :)
[ONE Android Development] BigMacca:
Ok - I've just done a clean flash (full wipe exluding user data, latest ROM + SettingOut's GAPPS + SU Unistaller just in case), nothing else installed other than MagiskSU and the MagiskAPP and safety next is now passing....

So, the next step is to start restoring apps and see if any cause SafetyNet to fail....

Macca
[ONE Android Development] bmark240:
AOSP WebViewer doesn't seem as fast at loading Webpages compared to Google Webviewer.

I installed Google Webviewer from The Play Store & changed Webview Implementation in Developer to Google Webviewe Options & it loads webpages faster for me.
[ONE Android Development] Abhinav_Rakesh:
[MENTION=2040569]jgcaap[/MENTION] .. is the otg fixed in this build ? i am on cm 13 build right now with no access to fast internet to download this build.
[ONE Android Development] BigMacca:
Ok - Now back up and running with all of me previously installed applications and Safetynet is still passing.

How very odd (It was only about 7 days since I last did a clean flash).

But I can use Andriod Pay now (happy days) :)

Macca
[ONE Android Development] Bieniu:
I had yesterday a random reboot with latest build.

https://www.dropbox.com/s/oiq191f9avl28yv/last_kmsg.log?dl=0
[ONE Android Development] bmark240:
Those who need their phones charging faster need to turn on airplane mode. This will ensure that no services running in the background are soaking up the charge. If you can live with not using your phone for a little while then your phone will charge faster.

Another aside point Kernel Adiutor Battery & Power setting AC Charge Level set to 1800 helps too.
[ONE Android Development] jgcaap:
If possible, could you share what we're you doing before the random reboot? Did you do any changes beside stock rom? Thanks.
[ONE Android Development] jgcaap:
Maybe xD but seems faster... At least my build was a bit laggy before and I was annoyed with it.
[ONE Android Development] Bieniu:
I think reboot occurred during standard browsing the web. Besides Your rom I flashed only Setting.Out Script https://xdaforums.com/showpost.php?p=55284394 and SuperSU 2.79.
[ONE Android Development] jgcaap:
hmmm Maybe is SuperSU. Try see if happens another random reboot. If does, try leave only SU from stock.
[ONE Android Development] jgcaap:
Another thing. Just checked the script. Don't use it!

The zipalign might be causing problems here. And you don't need it.

The edits which does to the build prop doesn't provide any improvement on performance or anything else.

I'll add in case i find something nice , or we come into good conclusions.

I found this:

# Renice

B=/system/xbin/busybox

( while true

do

sf=$( service list | $B grep -c "SurfaceFlinger" )

if [ $sf -eq 1 ]

then

service call SurfaceFlinger 1008 i32 1

break

else

sleep 2

fi

done

) &

And you got on your log something about surfaceflinger

# Disable Sleepers

echo "NO_NEW_FAIR_SLEEPERS" > /sys/kernel/debug/sched_features;

echo "NO_NORMALIZED_SLEEPER" > /sys/kernel/debug/sched_features;

This you do on stweaks.

# Kill Media Tweak

busybox killall -9 android.process.media

busybox killall -9 mediaserver

This doesn't make sense unless you wish to not update your gallery.

The only thing that makes sense on that script is to add on build.prop:

setprop ro.kernel.android.checkjni 0

This is already added.

The rest is to forget.

BTW I forgot to add the line of google assistance. Can someone show me which line to add on the build prop?
[ONE Android Development] jgcaap:
news about the caf rebase: https://www.xda-developers.com/late...port-for-aptx-and-aptxhd-caf-rebase-and-more/
[ONE Android Development] Gawd:
This one