yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Latest Canary (+Debug) Magisk:

Magisk (e5641d5b) (25208)​

Fix release builds

Diffs to v25.2​

[General] New magic mount backend. It supports loading modules into system with overlayfs files injected

[MagiskPolicy] Fix minor bug in command line argument parsing

[Zygisk] Prevent crashing daemon in error

[Zygisk] Rewrite zygote code injection with new loader library approach

[Zygisk] Release new API version 4

[App] Make stub patching 100% offline

[App] Support patching init_boot.img for Samsung ODIN firmware

[MagiskInit] Support replacing existing *.rc files in overlay.d

[MagiskInit] Rewrite sepolicy.rules mounting and loading implementation

https://github.com/topjohnwu/magisk-files/blob/0e63c640c4b8799609d6cf3bdd4f88b2e8df4c08/notes.md

👍 PW
[Magisk] perseoxd:
How can i uninstall Magisk app?? cant find anywhere

I tried to install new version but i have the same problem, so i think i have to uninstall before.

Problem is i have already hide it so i cant not find the app to uninstall
[Magisk] zgfg:
Like any other app - eg, from Settings, Apps

Or by long-pressing on the app on the home-screen or drawer and taking Uninstall

Details depend on your ROM - something you need to know/find how does it work for your phone and ROM
[Magisk] zzz2002:
Look for an app called "settings"/" Settings"

When you hide the Magisk app it renames it self as settings.
[Magisk] HippoMan:
... however, be careful that this isn't your actual Settings app for your device.

On my device, the system settings are accessible via an app named "Settings".

Before you delete any app named "Settings", click on it and see whether or not it opens up your system Settings.
[Magisk] zzz2002:
Thsnks, You learn something new every day
[Magisk] J.Michael:
I think @zgfg once described how to use the "pm" command from a command prompt to list all installed packages, displaying their package names. I think if you look through all package names, the only truly cryptic looking ones are renamed Magisk manager apps.
[Magisk] cosy6ay:
unable to hide magisk apps.

upon hide and after entering name - it show install but does not appear in apps drawer.
[Magisk] J.Michael:
So, you *were* able to hide the Magisk manager app, and now you can't find it?

Are you looking for the name you gave it?
[Magisk] pndwal:
Yup, Hide the Magisk app fails w/ 25208... Please see new GitHub issue Unable to hide Magisk app...

👀 PW
[Magisk] Homeboy76:
(y)
[Magisk] pndwal:
Very interesting new PRs in the mix:

Refactor zygisk to use native bridge to inject

#6659 opened yesterday by yujincheng08• Draft

and supporting commit:

Add support for showing property context

#6660 opened 19 hours ago by canyie• Draft

allowing resetprop -Z to run without root privilege...

'Refactor zygisk to use native bridge to inject' is connected with issues relating to Android Studio and native debugging broken as .so detection fails, however there may (haha) be other considerations. 😜...

I mentioned the analysis of dev @5ec1cff re. efforts needed to hide zygisk hooks from banks, and use of native bridge Zygisk loading in her Maru Magisk fork here:

https://xdaforums.com/t/discussion-...third-party-magisk-fork.4460555/post-87729841

In her GitHub notes 'maru: zygisk based on Native Bridge' I linked she writes:

Of course Maru does just this, and @huskydg has since made such Zygisk hiding accessible to many users via his Delta Magisk fork...

@5ec1cff also speculates in the conclusion of her notes entitled 'Modify Magisk to provide a new startup method for Zygisk':

so it's interesting (to say the least) to see this LSP dev initiative to use Native Bridge Zygisk loading in official Magisk... 😃 PW
[Magisk] pndwal:
Quite a flurry of Magisk activity occurring... Never seen four workflow runs occurring simultaneously in Actions before! 😋

... 25208 Magisk App hiding issue just got closed with a fix by John and re-opened again by Shana... 👀 PW
[Magisk] pndwal:
Very sad to see @Didgeridoohan's officially endorsed Magisk and MagiskHide Installation and Troubleshooting guide/Wiki link dropped from Magisk GitHub home page. ☹️

This may now be a tad out of date, but has been / remains an elegantly appointed and an extremely valuable and comprehensive resource covering both "Magisk - Installation and troubleshooting" and "MagiskHide - Hiding root and passing Safety Net"...

Here's the link for anyone facing any Magisk related issue on any device anytime anywhere:

Magisk and MagiskHide Installation and Troubleshooting guide​

... It comes with this note of resignation from the Didgeridoo man from Sweden:

I am no longer involved in the Android modding scene and haven't been for some time. I don't have the energy or will to take it up again... This guide will no longer be updated.

If anyone feels like taking over, give me a holler.

So long and thanks for all the fish.

... What can I say... Sterling contribution mate!... We're missing you already, but wish you all the best w/ real life, family and health as well as every happiness... And thank you for teaching us to fish... 👏

Re: If anyone feels like taking over, give me a holler, I'd like to nominate @ipdev if he's interested...

You'll recall I suggested an 'Age of Zygisk' wiki when your [Discussion] Magisk - The Age of Zygisk thread opening post notes were still in beta... Well how about keeping a Magisk institution alive Doc?... Can't think of a better candidate to safeguard, rejuvenate and keep such a legacy alive!

... No pressure though...

Marvin.
[Magisk] huskydg:
it will also fix this https://github.com/topjohnwu/Magisk/issues/5395
[Magisk] Clandaries:
Hello,

i have a android head unit and want to root it.

Unfortunately it is no MTC device so push SU to system/bin and so on does not work.

It seems there is no system folder just sys folders.

Is it somehow possible to root it?
[Magisk] zgfg:
Standard procedure for the Magisk installation:

- install Magisk app

- from the Magisk app patch your boot.img

- flash the patched boot img by Fastboot

Alternatively, flash the Magisk apk by TWRP (you may need to rename it to zip)

Instructions are available on the Magisk GitHub:

GitHub - topjohnwu/Magisk: The Magic Mask for Android

The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.

github.com

However, I don't know if anything of that applies to the head-unit (in the car?) - is TWRP available, can you obtain boot.img and could you flash by Fastboot (Bootloader must be unlocked)

---

BTW, just curious what could you obtain by rooting the head-unit - if that's related to Android Auto, I think all the limitations are pushed by Google through AA on the phone side.

Also, features to control the car should be on the car's computer

However, with root you can maybe install additional apps directly to the head-unit or so
[Magisk] pndwal:
Galaxy S7 (and other old Sammy device) owners using stock ROMs will be pleased to know this... 👍

I believe most w/ these devices unlocked will already have moved from stock TouchWiz to LineageOS etc however... PW
[Magisk] badabing2003:
TB checker from Play Store will detect and show the package name of hidden Magisk.
[Magisk] J.Michael:
Talk about "good news, bad news".
[Magisk] zgfg:
Hide the Magisk app by HMA and TB Checker will no more find it.

And then you even don't need to do Hide Magisk app in the Magisk app itself
[Magisk] badabing2003:
When I was working on the package manager in PF I noticed some characteristics of hidden Magisk app and wondered that it might not be that difficult to identify.

I'm not sure how it's doing it, but I suppose it is keying on those unique patterns.
[Magisk] badabing2003:
So this just became good news, good news.

Hide in HMA to deter root detection.

Unhide in HMA (if you have it hidden) to find your hidden Magisk to unhide or to uninstall it when running into duplicate Magisk issues.
[Magisk] zgfg:
By HMA, you hide some app (like Magisk app) only from certain app(s) like from TB Checker (and banking apps)

Hence you don't need to "un-hide in HMA" for anything. The app (Magisk app) is still there, you can use it and you can safely upgrade when the new version is released - you don't have problems like with 'Hide Magisk app' from the Magisk app itself when upgrading

HMA does not repackage or so. But HMA refers to the package name. Hence if you first hide by HMA and then repackage (by Hide Magisk app in the Magisk app), then hiding by HMA will no more work (since HMA will no more find the original package name).

Or if you repackage, then hide by HMA and then restore - again, finding by HMA will no more work since HMA will not find the repackaged Magisk app

Please install HMA and play yourself with

The guide (from our former fellow here):

GitHub - adrianmmiller/Hide-My-Applist-Guide: A brief guide to using Hide My Applist

A brief guide to using Hide My Applist. Contribute to adrianmmiller/Hide-My-Applist-Guide development by creating an account on GitHub.

github.com

Skip the first part of the guide (Shamiko, USNF, etc - it's not related to HMA but generally to hiding the root from banking apps) and go to the end, with screenshots how to configure HMA
[Magisk] pndwal:
Latest Canary (+Debug) Magisk:

Magisk (2717feac) (25209)​

Fix release stub APKs

Several minor changes

Diffs to v25.2​

[General] New magic mount backend. It supports loading modules into system with overlayfs files injected

[MagiskPolicy] Fix minor bug in command line argument parsing

[Zygisk] Prevent crashing daemon in error

[Zygisk] Rewrite zygote code injection with new loader library approach

[Zygisk] Release new API version 4

[App] Make stub patching 100% offline

[App] Support patching init_boot.img for Samsung ODIN firmware

[MagiskInit] Support replacing existing *.rc files in overlay.d

[MagiskInit] Rewrite sepolicy.rules mounting and loading implementation

https://github.com/topjohnwu/magisk-files/blob/0b9eca062198e568f9cc101eaf64bb5d9edb8a34/notes.md

👍 PW
[Magisk] pndwal:
Yeah, if you turn off hiding for TB checker in HMA you'll see randomised name at end of XPosed Check 🙃... Otherwise:

Probably is... Promon security engine used by Sparkasse Push-TAN detects hidden Magisk App hidden using classes.dex code which is why freezing this works but 'Hide the Magisk App' alone is not enough as with that

https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-893367674

Nb. link to the Magisk code given...

https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-892775076

So if stub app is rebuild it can be hidden. Simply put, "a simple app packer [does] mitigate the detection very easily"

https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-892224424

However as later discovered, using HMA module also solves this:

https://github.com/topjohnwu/Magisk/issues/1084#issuecomment-964222271

However banks may still find App if stub is not used... I can confirm that at least Promon / Push-TAN finds full Magisk app hidden by original HMA with all hiding methods employed, but Magisk in stub can be hidden from it using intent query hiding...

Well, in this context the member was only meaning to force TB Checker to do this:

... like this:

... and notice that Magisk randomly initialled my hidden App for me too! 😋 😂

Well, the original package is actually uninstalled which is why it's not found...

HMA does in fact see the new stub/package name however, and does work to hide Magisk in stub from bank apps like Push-TAN that can detect it using pattern matching as I've mentioned...

Actually HMA remembers all previously hidden apps, so if a user has added full Magisk App in list previously, it will 'miraculously' reappear in the list when Magisk App is restored... Otherwise users can simply add it...

Hidden App will need adding each time Magisk App is re-hidden however as name is randomised... So these remembered packages accumulate as 'apps invisible' in a template... For example one HMA template I use shows only 5 checked apps, but says '15 apps invisible'... I've found no way to purge previously installed app package names from HMA short of uninstalling! 🤪

🤠 PW
[Magisk] osm0sis:
Speaking of bad news.

Ah sh*t, here we go again... 😞

Remove obsolete and long broken addon.d support by vvb2060 · Pull Request #6676 · topjohnwu/Magisk

https://github.com/yujincheng08/Magisk-Addon https://github.com/programminghoch10/Lygisk/blob/ci-management/README.md?plain=1#L9-L11

github.com
[Magisk] huskydg:
Expected, they already removed support in their Mahisk alpha fork 😏
[Magisk] asripath:
Would it be possible to support it in Delta?
[Magisk] pndwal:
It's still supporting in official Magisk so why would it be removed from Delta?... Or do you mean going forward?... PW
[Magisk] pndwal:
Feel you pain...

Could be worth brainstorming this a bit here however...

I'm a lttle confused about Lygisk fix... Seems it's for FBE?.. And vv's confused too it seems to me unless I'm reading wrong...

Please say your feelings re./understanding of that fix... 👍 PW
[Magisk] huskydg:
vvb2060 is a developer with bad behavior and this is not the first time i met.

I asked her for reasonable explaination for this PR and she just simply (shut my f**king mouth up) marks my comment as off-topic ¯\_(ツ)_/¯

Is this a good behavior from a good developer?

unshare magiskd by vvb2060 · Pull Request #6673 · topjohnwu/Magisk

The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.

github.com
[Magisk] zgfg:
We lost a fellow from Sydney due to a dispute with them

Btw long ago (when Alpha was new and Magisk v24 was not released yet) I was kicked out from their TG group although I really did not argue anything and did not ask anything OT

At that time TG group was still opened for English. I think she kicked me out that day as an English speaker

Later I registered my second TG account and rejoined (at that time it was still possible to find the invitation links) but since then I never posted anything to their TG channel

Later I exited the Alpha TG group, it became pretty useless (mostly pets, aggressive posts in Chinese and so) and moreover I stopped using Alpha

Also, once I opened a ticket on GitHub and she immediately closed with no explanation.

But somebody else then reopened the ticket, inspected the logs and provided a fix in the later Magisk build

But she, and the whole group are really excellent developers
[Magisk] zgfg:
I tried to upgrade on my old Xiaomi with MIUI 12.5, A11

So far I never had problems. I patched the original boot.img (as I usually do, not re-patching the one that was already patched by previous Magisk version and not doing Direct install)

I flashed in TWRP but Magisk app did not recognize Magisk - N/A.

However, I never do Hide Magisk app (HMA is better and enough for me), hence it was not my fault

Then I patched once again - I looked and it did not report any issue while patching (Stock boot IMG detected, Patching Ramdisk, Repacking) but again, when flashed (this time from Fastboot), Magisk app again did not detect Magisk

Then I booted with my boot img patched by previous Magisk version and I made Direct install (later I repeated the same by re-patching and flashing the previously patched boot img with the same success)

When rebooted, Magisk app correctly found the Magisk and everything seems to be ok

Since I use(d) Canary, not Debug, I don't have proper logs. And I'm not going to re-test with Debug and into the battle to report the ticket
[Magisk] rodken:
Even though I still run with the Alpha version, I whole heartedly agree with the aggressive nature of the posts coming from that channel.

If you are not careful, you can cause brain damage from all of those whimsical content being shared on that medium.
[Magisk] pndwal:
I can understand Magisk taking a stock-centric approach for several practical reasons, but I agree that it's also important to accommodate custom ROMs properly...

I don't understand vv's view that LOS is negligent for not guaranteeing CDD compliance... Luca did discuss that with Shawn Willden a while ago citing need for disabling Verity etc to sideload GApps etc... I was hoping to see something hammered out re. certifying LOS at the time, but seems it may be too complex or it may be to big a commitment for a handful of Devs working for love...

Despite LOS's decisions/reluctance/missed opportunities, Magisk should certainly support the staple of custom android mods, ie. custom ROMs however... (Especially as we've even seen Google do this and even encourage a working relationship...)

However, perhaps a compromise can be reached:

If addon.d were moved to a module, it seems it could still be kept as an official Magisk component...

I envision it being like the Systemless Hosts module, installable from Magisk settings page perhaps with a legend like:

Magisk Survival for Custom ROM updates

Addon.d Magisk Survival Script support for ROMs with addon.d support

This way

it remains available for Customer ROM users in Magisk out-of-the-box

the function is presented as a user option and use-case can be made clear in legend

it is only activated if user knows and intends to use it

it can receive both official and 3rd party support (via Magisk GitHub Issue reports and Pull requests)

potential for a plethora of additional (confusing/unwanted) forks is checked and proper/official support and PRs are encouraged (I understand LSP/Magisk Devs' view that it may be good to encourage 3rd party iterations, but this also has the potential to become very messy.)

it is officially available whether Magisk is installed via custom ROM .zip installation or App patch/fastboot flash method.

an amicable compromise is reached AFAICS... addon.d Magisk script becomes a module but remains an official component, and this may leave all interested parties, ie. Magisk Owner/Devs, the script author(s), custom ROM users as well as 3rd party contributors, HAPPY! 😃

And let's face it, despite Magisk being very stock-ROM-centric these days (understandably if not well understood...), custom ROMs are the traditional Android modders staple and it would not be a mistake at all for a custom mod of Magisk's calibre to officially support these modders in particular with a module like this... (Even Google offers special support for custom ROM users!) 😜

... I've just put the above to the Magisk/LSP Devs... Please let me know if you disagree strongly so I can amend something/everything... Addon.d is your baby and a staple of Magisk after all!... Regards, PW
[Magisk] pndwal:
Yup, seems unrooted-boot.img patching is broken ATM in 25209 (patch doesn't obtain system_root)... Surprised there haven't been more reports... This was the only instance reported:

Magisk stopped working after installing latest LineageOS 20 build

No need... It was also the first issue off the 25209 block fixed:

Fix SYSTEM_ROOT not passed to boot patch

For everyone:

For clarity, I believe this will mean that Patching/flashing pre-rooted boot image (eg direct install or .zip flash over rooted system) will be necessary for any using Canary 25209...

🙂 PW
[Magisk] pndwal:
Incidentally, regarding the issue of Magisk's random failure to uninstall full app when taking "Hide the Magisk app", or failure to uninstall the stub app when taking "Restore the Magisk app" (which can result in requests for SU permission, Magisk Installed = NA, etc), despite 25208 Unable to hide Magisk app being fixed, this long-standing issue was prematurely closed.

It is now labelled: Hiding and Restoring Magisk App not consistently working properly on many devices, and @osm0sis kindly reopened it...

Now it finally seems to be getting proper attention, and Shana has identified a race condition... Hope we see a fix/PR merged soon!

Here's a little strategy I posted to recover from this in the meantime:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-87044311

👍 PW
[Magisk] osm0sis:
To be fair, I proposed this exact thing back at Christmas in the big showdown thread in the issue, but they didn't want to hear it then.. we'll see what John thinks I guess, now that he's invested enough to at least comment passively on the situation..

Nothing installed in Lineage /system/addon.d/ via Magisk app Direct Install + fix_env · Issue #3820 · topjohnwu/Magisk

I installed Magisk by using the "patch boot.img and flash with fastboot" method, since the installation instructions say that using the installer zip via a custom recovery is no longer recommended....

github.com
[Magisk] pndwal:
... And I thought I'd read that whole thread! 🤪 Must be the Alzheimer's.... Anyway, your proposal was even better!...

Hope John expresses some option publicly... and I see it... PW
[Magisk] ipdev:
Arrogant and Condescending would be the terms I use. ;)

Cheers. :cowboy:
[Magisk] pndwal:
Well flippant, obdurate, unapologetic... Or possibly just to busy / in too much of a hurry anyway... PW
[Magisk] huskydg:
@osm0sis it seems that they are going to remove custom recovery support 😂

Edit: I read too fast, i was thinking they were going to remove completely recovery install
[Magisk] osm0sis:
I... wow. Sadly I had a hunch this was coming next. Say goodbye to Magisk on locked devices with bootloader workaround hacks.

Edit: See following replies, before anyone else jumps to conclusions. 😅
[Magisk] canyie:
It is because Magisk can't work properly on some broken custom recoveries, which mount partitions with wrong devices...

Found no way to workaround it other than detecting and warning user to reinstall Magisk manually...
[Magisk] m0han:
New (Icon) Magisk Delta Canary. Hope everything remains in Delta.
[Magisk] osm0sis:
Okay, so in reading the actual issue being discussed, no, they are not considering fully removing recovery install; the proposed idea is more that it will only do a simple boot patch (similar to the unrooted Magisk app), which will then update itself to fully functional when run rooted.

Refactor sepolicy.rules resolve more · Issue #6684 · topjohnwu/Magisk

Background: We need to find a partition after booting that can store module rule, because some devices have cache/metadata partitions but they will not be mounted after booting. The target partitio...

github.com

Best not to jump to conclusions. 😉
[Magisk] pndwal:
Yup.

... and @canyie just said:

... Context is everything...

FWIW, Canyie does a lot of analysis-in-real-time in "The Rock Revolution of Pochi and Kita" (formerly Alpha discussion) TG thread and is a prolific Magisk contributor but not (yet 😉) a 'Magisk Dev"... Also, 'Admin' could also be other Devs

vvb2060 is Alpha's author and, along with Shana, often acts on such analysis in proper PRs... So does Canyie...

Alpha discussion has always been a very effective way to rectify issues for all using a substantial Chinese Alpha userbase... 👍 PW
[Magisk] huskydg:
Sorry for the conclusions. I read too fast, i was thinking they were going to remove completely recovery install. Translation was sometimes incorrect and I was misunderstanding
[Magisk] pndwal:
... FWIW, analysing this problem is still in progress... They're just helping a member to post kmsg as we speak... PW
[Magisk] badabing2003:
Looks like even the rooted one.

https://xdaforums.com/t/pixelflasher-for-google-pixel-7-pro-support-thread.4505287/post-88239887
[Magisk] pndwal:
mmm. I'm not familiar with Pixel Flasher, but wouldn't the user be patching a clean (unrooted) 'software package' with 25209?...

Because if only rooted boot images 'show up in the list of boot images', this result would be expected as unrooted images patched with 25209 remain unrooted... Images rooted with earlier binary versions should update to 25209 successful and retain root however...

... What am I missing? 🤔 PW