yashsingh1/xdaforums huggingface dataset:
[Magisk] Henry1231:
Im using a sprint s6 edge(sm-g925p) on marshmallow. I rooted it by using chainfires auto root.

Heres the magisk log:

** Magisk post-fs mode running...

** Magisk post-fs-data mode running...

Remove module: /magisk/xposed

Preparing modules

Bind mount dummy system

Bind mount module items

Bind mount system mirror

Mount: /system

Bind mount mirror items

** Magisk late_start service mode running...

service: /magisk/phh/service.sh

phh: Live patching sepolicy

phh: Mounting supath

phh: Starting su daemon

** Removing tampered read-only system props

** Starting Magisk Hide

MagiskHide: Update process/package list:

MagiskHide: [com.google.android.gms.unstable]

MagiskHide: [com.nianticlabs.pokemongo]

MagiskHide: [com.joeykrim.rootcheck]

MagiskHide: Error occurred...
[Magisk] putridfoetus:
Thank you for the clarification. To be sure, you're saying that the bind mounting of bin/xbin should happen during post-fs-data, right? I believe that's how phh is doing it, if I read the code correctly.
[Magisk] Didgeridoohan:
Running both Chainfire's SuperSU and phh's superuser is just asking for trouble...

You've removed Xposed. That'll help you pass Safety Net.

But, as we already know, there's something wrong with your Magisk Hide (last line: Error occurred...).

Are you for real running with both Chainfire's SuperSU and phh's superuser? Or are you just continuing to be vague...?

It feels to me like you've not done enough of your homework. You should at least have read the entire Official Magisk announcement thread and most, if not all, of this thread. A good point of entry as a new user on xda is to read, read, read and to me it feels like you haven't done enough of that.
[Magisk] Henry1231:
Im only running phh superuser. Ill read the magisk announcement again and see if there is something i missed. Thanks for your help.
[Magisk] Toninho13:
I have magisk v8 with magisk manager 2.5. The magisk manager show there is update for magisk v9. I click on download and install, after reboot. My phone is rebooting, but nothing is happened. What should i do? I have phh superuser and i gave permission to magisk manager.
[Magisk] reddv1:
Edir: nevermind cache mids not supported anymore.

So, I want to port a mod to a magis k mod. It has a build.prop boot animation and other system apps. Would I need to make two mods for this to work? One cache mod for the build.prop and boot animation and another data mod for the rest of the system changes?

I'm asking this because the phone cache only has 97mb but the mod I'm porting is more than that?
[Magisk] putridfoetus:
Cache mods are not supported anymore. Use resetprop command to set custom properties.
[Magisk] reddv1:
Where do I place the new prop file to overwrite the old prop file in the zip with post-fs-data. Is that possible, or do I have to make changes individually?

What's the difference between trigger and non trigger changes?
[Magisk] dimm0k:
previously I had a module that replaced the build.prop, which from what I understand with Magisk v9 that it is no longer a viable method anymore. while using resetprop works for most of the properties in build.prop, it looks like there's two that won't take for some reason on my LGV10. does this mean to effectively replace the build.prop, I have to put my version of build.prop in /cache/magisk_mount/system/ manually for it to replace?

EDIT: tried using that folder and... SUCCESS!
[Magisk] putridfoetus:
You can keep your prop file, if you like, and feed it to the resetprop command. Details in release thread. I have not personally used this method yet, but some are saying it's better to put your resetprop commands in service.sh to allow other processes to complete in post-fs-data. Not sure about the trigger vs non-trigger. I'll not speculate wildly about their meanings here without some research. :p
[Magisk] laggardkernel:
Yes, I'm talking about the bind_mount during post-fs-data. At least bind mount xbin during this stage will work. No test has done with bin.

Some other info you might be interested in. There are mainly three commits relating to magisk_magisk.sh, which makes the Magisk mount happen, at the Github page of Magisk after Magisk v9 release,

Various fixes, improved the mounting process a little.

Magic Mount total re-factor, mounting binaries to /system/bin worked well, but mounting frameworks made my phone stuck at boot.

Magic Mount Total Re-factor Part 2, I haven't done a comprehensive test with this commit. The weird is that mounting a modified SystemUI.apk made my device stuck at boot. While I have no problem with replacing other existing apks in /system. This obviously didn't happen before.
[Magisk] putridfoetus:
Cool I will do some reading then :good:.

I have had some interesting results from trying to replace SystemUI.apk as well. It's been suggested that deleting /data/data/com/android.systemui and also wiping dalvik/cache before booting should alleviate any problems beyond setting correct permissions, but it seems to be hit or miss. Sometimes when reverting back to stock SystemUI.apk, all permissions are lost, causing force close errors. I was able to resolve it once by setting a specific permission (can't remember which one, but it showed in a logcat which permission was failing--maybe a location permission?) and that got me into a working system. Still had a lot of problems beyond that,, so I ended up factory resetting anyway.

If you're interested, would you take a look at this work in progress, and see if there are any glaring mistakes? I've adapted it based on your suggestions and phh's method of bind mounting binaries. Haven't been able to test it yet, but I think it looks promising...

https://github.com/putridfoetus/ViperAtmos-Magisk
[Magisk] Didgeridoohan:
No worries mate... I'm not sure I've been much help really.

I've seen other users getting that error with Magisk Hide (from your log), but unfortunately I've no idea what causes it.

Personally, at this point I'd wipe my device and start afresh, just to make sure there's no remnants of anything old messing me up.

Funny thing I noticed right now, is that quite a few users reporting that error with Magisk Hide have Samsung devices. Could it be one of Samsung's modification to Android that causes it? Wouldn't be the first time... Maybe if you try running a custom ROM not based on a Samsung ROM?
[Magisk] qriozum:
I have a question to the holders HTC10 related Magiska and actions AndroidPay.

Starting from Viper10 v3.5.0 to v4.2.0 - you could not be forced to act in this AP system.

On my HTC10 he acted AP tests passed and the SafetyNet Helper on customROM ICE2.4.2.

Yesterday, taking full official system (I have uploaded RUU 2.28.401.9) on the device configuration, the test ran AndroidPay.

It turned out that you can not use it. On the displayed nagscreen was the information that the system can have root (but not in the RUU for HTC root) or unlocked startup module.

And here is my question - is unlocked bootloader affects not under the control of the operation AndroidPay Magiska v9 / v9.1?

Do people work on the AP customROM Viper have a locked bootloader?

I have mixed feelings, because I have the bootloader unlocked all the time - and ICE 2.4.2 AndroidPay work properly.

The problem with the AP and Viper are all familiar people with a Polish forum on topics related to Android and smartphones.

regards

q.
[Magisk] reddv1:
So, if I want update my custom kernel I'm using while Magisk is installed, can I just flash it over Magisk?
[Magisk] Fentadroid:
tried magisk 9 on Oneplus 3 with the last Open Beta 9 based on nougat but it doesn't work... even if checked on magisk hide, safetynet won't pass....
[Magisk] Didgeridoohan:
Lots of things may trigger Safety Net and not all of them can be hidden with Magisk. Magisk can hide itself, Magisk phh's superuser (not normal phh's or Chainfire's SuperSU) and possibly an unlocked bootloader. Xposed and permissive SELinux cannot be hidden by Magisk Hide.

It is also possible that Magisk Hide isn't working on your device, but it's hard to tell with the sparse amount of information you've given. At the least you should provide a Magisk log.
[Magisk] Fentadroid:
that's the log:

** Magisk post-fs mode running...
** Magisk post-fs-data mode running...
Preparing modules
Bind mount dummy system
Bind mount module items
Bind mount system mirror
Mount: /system
Bind mount mirror items
** Magisk late_start service mode running...
service: /magisk/phh/service.sh
phh: Live patching sepolicy
phh: Mounting supath
phh: Starting su daemon
** Removing tampered read-only system props

** Starting Magisk Hide

Nothing happens when i start app checked on Magisk Hide, no icons on status bar....

Maybe it's not working on Nougat....

OnePlus 3 with stock ROM (Open Beta 9 based on Nougat) and phh superuser 266.
[Magisk] Artim_96:
Yes but you'll have to flash Magisk again since the changes to boot.img will be lost
[Magisk] Didgeridoohan:
It should be working on Nougat...

That log looks awfully short to me. Have you enabled verbose logging in the Magisk Manager? If not, please do, reboot and post the new log.
[Magisk] Artim_96:
The log looks like a fight between mounting superuser and enabling Magisk hide. Maybe he has the same problem that these two don't play together nicely
[Magisk] Fentadroid:
Yes, enabled, rebooted phone and log is the same whatever i do....

---------- Post added at 12:37 PM ---------- Previous post was at 12:35 PM ----------

used phh 266 superuser, flashed AFTER magisk 9.zip.

It always worked on previous version of android on this phone...
[Magisk] brahma666:
my problem
[Magisk] Didgeridoohan:
Hmm.... Maybe it could be related, but I have a feeling it's not. As far as I can tell root is working. If it's related it should hopefully be fixed with the next Magisk update, maybe.

I just realised I've recently seen that exact log. Another user with an OP3 trying the open beta 9. Seems like it's rather a device/ROM specific issue.
[Magisk] ammar18:
what do you mean? why not explain in text rather than image with text as it is not specific and detail.
[Magisk] brahma666:
I can not install the mod sorry my english is very bad
[Magisk] ammar18:
logs.
[Magisk] brahma666:
** Magisk post-fs mode running...

** Magisk post-fs-data mode running...

Preparing modules

Bind mount dummy system

Bind mount module items

post-fs-data: /magisk/xposed/post-fs-data.sh

Xposed: Mount: /magisk/xposed/system/lib/libsigchain.so

Xposed: Mount: /magisk/xposed/system/lib/libart.so

Xposed: Mount: /magisk/xposed/system/lib/libart-disassembler.so

Xposed: Mount: /magisk/xposed/system/lib/libart-compiler.so

Xposed: Mount: /magisk/xposed/system/bin/patchoat

Xposed: Mount: /magisk/xposed/system/bin/oatdump

Xposed: Mount: /magisk/xposed/system/bin/dex2oat

Xposed: Mount: /magisk/xposed/system/bin/app_process32

Enabling systemless hosts file support

Mount: /magisk/.core/hosts

Bind mount system mirror

Mount: /system

Bind mount mirror items

** Magisk late_start service mode running...
[Magisk] MMFreax:
[MENTION=4710837]brahma666[/MENTION]

Have the same problem when I want to install the modules. Can not install Xposed time ZIP is no Magisk modul.

Gesendet von meinem Pixel XL mit Tapatalk
[Magisk] Artim_96:
Yes, you did that right. I don't know how it behaved on other Android versions, I switched to phh after switching to Android 7.1.1 since suhide would only cause bootloops from November patch on. And I can't use Magisk hide since I would lose root when using it.

So, what exactly is not working for you? It's it only that Magisk hide isn't effective or is root not working too?
[Magisk] Fentadroid:
Root perfectly works, the "magisk hide" part doesn't work.....

So... android pay and pokemon go don't start and of course safetynet won't pass....
[Magisk] Artim_96:
1. Which Android version are you on?

2. Tried to download XPosed from the thread and flash manually through TWRP? If so, what where the errors there?
[Magisk] brahma666:
Android 6.0.1

rom: MagMa NX port n7
[Magisk] Artim_96:
Tried it with a root detection app? In the worst case you would have gotten an SN update. Otherwise, is it possible, that you have some leftovers of an XPosed installation or a preinstalled root or something like that?
[Magisk] Fentadroid:
Apps that require root works, like titanium backup or adaway....

Never installed xposed, i had supersu 2.79 but i recently have dirty flashed Open Beta 9 on OnePlus 3..... so old root is gone i guess...
[Magisk] Artim_96:
Maybe it's because of the note 7 port. Try to manually flash the zip downloaded from the thread. For comparison, the md5 of v87.0-sdk23 is 9e6890d5093716c0018b8376dbe85be0
[Magisk] zzzhead:
Will like to report strange behavior.

Using magisk v9 with supersu latest.

If I reboot with airplane mode on, will lose root a min + after boot.

Restore system, boot does not help. Reflash does not help. Still lose root a min after boot, only after restore data then root is back.
[Magisk] Artim_96:
No, not necessarily. Get the UPDATE-unSU-signed.zip by osmosis, fish it and afterwards flash the stock boot.img and Magisk, in that order. That size remove all leftovers from SuperSU. I'm not sure if system version only, otherwise look into /dev of there is still a su.img and delete it.

And with "trying a root detection app" I meant to try to hide rid from it via Magisk hide.
[Magisk] oblitus:
Hello.

I followed the installation process and couldn't got it working. In Magisk Manager, if I check the Magisk Hide box, app closes itself. Also cant get pass the safetynet scanner. Error msg says response payload validation failed.

LG G2 with 6.0.1. Xposed installed.
[Magisk] Artim_96:
Which root method do you use?
[Magisk] JohnCorleone:
Did you reboot after enabling "Magisk Hide"?, That made it work for me BUT Magisk 9 might not be updated to 7.1.1 yet. I know that it works great on the HTC 10, Nougat 7.0..
[Magisk] android_htc:
MagiskHide: Error occurred...

Hi guys,

I am back on Note 4 stock ROM and getting an MagiskHide error. Not sure if this issue has been resolved as a few users have reported this issue before.

Please see attached logs and advise if anything can be done to resolve this issue.

Many thanks
[Magisk] Artim_96:
And what exactly is the problem? Without knowing anything I don't see anything that would cause problems
[Magisk] android_htc:
Magisk hide error as shown in the logs... this causes SafetyNet to fail
[Magisk] Artim_96:
Yes, Magisk hide had its problems and often causes loss of root. But that there is an error is the only thing visible. Already enabled verbose logging? Magisk log seems a bit too short.
[Magisk] android_htc:
Thanks for your reply.

Not experiencing issues with root, only MagiskHide is not working for some reason...not sure if there is an issue with the stock kernel as I've had it working with a custom kernel before.

Verbose logging is enabled, how can I get a better log?

Thanks
[Magisk] Artim_96:
If it's enabled you can't. I know only problems with Sony kernels but then installing Magisk would already fail.
[Magisk] Didgeridoohan:
Most of the users I've seen with Magisk Hide "Error occurred..." have been Samsung users. On your description it sounds to me like it's an issue with the stock boot image. How about opening an issue on github with logs and both the stock boot image (not working) and one that's been modified by your custom kernel (working).
[Magisk] jhedfors:
I am on CM14 nightly (7.1.1) and Magisk Hide is working fine from what I can tell.
[Magisk] JohnCorleone:
It was just a guess. I am still on 7.0 and it hasn't failed on me once but I did a clean install exactly as it said in the OP.
[Magisk] CapnShiner:
I'm running Magisk v9 with the latest phh superuser and Magisk Hide enabled but SafetyNet check still fails. I've verified Magisk Hide is working by testing on root checker. Root is working, verified by Titanium Backup working. The first 2 steps of the SafetyNet test pass but it fails the CTS profile match. I'm trying to get PoGo to work and Android Pay would be a bonus. I have had my phone randomly lose root a few times since upgrading to Magisk 9 but I'm obviously able to get it working again. I'm using a Moto X PE with stock Marshmallow ROM. What should I look for? What logs might you guys need?
[Magisk] Devimax:
Doogee Titans 2 (DG700) lolipop

TWRP 3.0.2.0

installing Magisk v9 - "Unable to detect boot image"

installing Magisk v8 - done, bootloop

Help plz
[Magisk] nixie2121:
quick question as I want to make sure I am OK with what I did... I'm using dirty Unicorns latest test version which uses super su. I just installed magisk manager, installed magisk, everything seems to be working as the app that did not run before works now. do I need Phh su or can I just stay the way I am now? thanks so much!
[Magisk] Rhoban:
Magisk hide only works with phh superuser as far as I know.
[Magisk] jb0ne:
Which Flashfire sadly doesn't recognize, hence won't run
[Magisk] culiacanazo:
The time bomb hasn't done anything for me in a while... I thought it was a (.53) version thing. Anyways, have you tried permissive? It would work with CMs super user... You can give it a try
[Magisk] grep_i:
If you mean the free use of the pro functionality.

That's date driven it will stop somewhere in the second month of 2017 if I recall it correctly.
[Magisk] culiacanazo:
53 is or was when i last tried to use it the latest one, and no, the only freeload according to me would be bootloaders which i wouldn't touch without a computer, and according to chainfire, there's no extra functionality for freeloading.

I've used it successfully before.

Now, however, It does go blank and just reboot, but im afraid it's waaaay off topic now...

I still appreciate it, Señor

Mods, i think somebody's calling me, gots to go
[Magisk] nixie2121:
I'm confused now. I left supersu and just install magisk and set fios mobile to hide. supersu is still working, and now fios mobile works. to me this would mean magisk hide is working G with super su? I must be misunderstanding something?
[Magisk] Artim_96:
It can work with SuperSU but Magisk hide won't. So from November patch on it won't really work with SuperSU since suhide will cause bootloops and Magisk hide won't support it so you won't have a way to pass SN
[Magisk] nixie2121:
ok, i get it. since it is working for what I need, it is ok then. thanks everyone!
[Magisk] waylo:
I'm attempting to build a test version from the latest github files, on Windows 7x64, using the super-easy build scripts [MENTION=4470081]topjohnwu[/MENTION] has created.

The logs are outputting this error (putting in "10" as the new version)

* Adding version info
************************
Get-Content : A parameter cannot be found that matches parameter name 'Raw'.
At line:1 char:9
+ (gc -Raw <<<< scripts\flash_script.sh) -replace 'MAGISK_VERSION_STUB', 'Magi
sk v10 Boot Image Patcher' | sc zip_static\META-INF\com\google\android\update-bi
nary
+ CategoryInfo : InvalidArgument: (:) [Get-Content], ParameterBin
dingException
+ FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Comm
ands.GetContentCommand

Get-Content : A parameter cannot be found that matches parameter name 'Raw'.
At line:1 char:9
+ (gc -Raw <<<< scripts\magic_mask.sh) -replace 'MAGISK_VERSION_STUB', 'setpro
p magisk.version "10"' | sc zip_static\common\magic_mask.sh
+ CategoryInfo : InvalidArgument: (:) [Get-Content], ParameterBin
dingException
+ FullyQualifiedErrorId : NamedParameterNotFound,Microsoft.PowerShell.Comm
ands.GetContentCommand

It does output a signed magisk zip at the end though.

Also, the signed .zip is missing the file "magic_mask.sh" file in /common, which had been present in previous versions.

Is this to be expected?
[Magisk] Fenny:
Sounds like you are not on PowerShell v3. The -Raw parameter was introduced in v3.
[Magisk] reddv1:
Does anyone have an idea why a mod replacing framework-res.apk and enabling magisk hide causes a bunch of errors. Same mod without framework work perfectly.
[Magisk] oreo27:
Any chance you could PM on how you're building the latest updates of Magisk or perhaps make a guide? :)
[Magisk] putridfoetus:
[MENTION=7897801]laggardkernel[/MENTION] [MENTION=6366997]UltraM8[/MENTION]

So I was able to test my audio mod a little tonight, and bind mounting /system/bin binaries does NOT work with v9. Sent my Nexus 6 into a bootloop and unable to get logcat with this error:

CANNOT LINK EXECUTABLE "logcat": file offset for the library "libbase.so" >= file size: 0 >= 0

No errors in magisk.log.

Removing the bit in my scripts for mounting bin got me booted into working system with no errors whatsoever. So it seems bind mounting /system/bin is not possible (for now, I hope).
[Magisk] UltraM8:
Did you bind it from the new folder? Or with v9 binder? Cause it seems we need to create new partition
[Magisk] putridfoetus:
I used phh's method of creating a new folder and bind mounting to /system/bin. The mod works fine without the binaries, so I'm not too worried about it.
[Magisk] rignfool:
Ummm... You're hotswapping framework-res... GIAGANTIC NO NO... You're lucky you didn't crash outright...

I bet the reboot takes 10 minutes... Then errors to panic and reboots again...

---------- Post added at 01:49 PM ---------- Previous post was at 01:47 PM ----------

Could your binaries in question be called from the data partition?
[Magisk] putridfoetus:
Theoretically, I suppose they could, but they're not really my binaries. They are related to Viper/Dolby Atmos, so I assume the app calling them would have to be edited to call them from data partition. Really, I have no clue about that. I'm just adapting an existing mod to magisk for personal use.
[Magisk] laggardkernel:
Bind_mount binaries to /system/bin works according to my test. The mod you tested is your Audio MOD, right? I will have a try soon.

Edit: Sorry, I don't have an HTC device. Just uploaded a demo here, wish it will help you. Bin_bind Demo

---------- Post added at 23:23 ---------- Previous post was at 23:06 ----------

Sorry to reply to you after such long time. DolbyAtmos doesn't need binaries in /system/bin, I use LeEco LeMax 2 Atmos by ahrion. He ported three kinds of DolbyAtmos from differrent ROMs, and all of them don't include binaries, just configurations and libriaries. I made a demo about bind_mount binaries to /system/bin. May this helps you. Bin_bind Demo.
[Magisk] putridfoetus:
I guess that's why it works without the binaries lol. Good info :good:

I did try again, because I found a typo in my script, but I still got a bootloop with no way to get logcat. I wonder if mounting binaries and libraries at the same time causes a conflict? I think I remember someone mentioning it a while ago... Probably not...

Unrelatedly, adding libs disables magiskhide, which is interesting:

"Crash prevention" from /magisk/phh/sbin_bind/magic_mask.sh:

# Some libraries are required
LIBS="libc++.so libc.so libcutils.so libm.so libstdc++.so libcrypto.so liblog.so libpcre.so libselinux.so libpackagelistparser.so"
if [ -f "$MOUNTINFO/dummy/system/lib" ]; then
cd /system/lib
cp -afc $LIBS $DUMMDIR/system/lib
# Crash prevention!!
rm -f $COREDIR/magiskhide/enable 2>/dev/null
fi
if [ -f "$MOUNTINFO/dummy/system/lib64" ]; then
cd /system/lib64
cp -afc $LIBS $DUMMDIR/system/lib64
# Crash prevention!!
rm -f $COREDIR/magiskhide/enable 2>/dev/null
fi

At least on my Nexus 6 build NBD91U. After installing my audio mod (which has many libs included), magiskhide would not enable for nothin. Check the box, reboot, not checked. Uninstalled the mod, check the box, reboot, magiskhide enabled and sn passing. Neat.:cool:

Edit: I'm starting think the bin mounting may be device specific. [MENTION=7897801]laggardkernel[/MENTION] your poc module put my N6 into a bootloop too. Same deal with mine, unable to get logcat.
[Magisk] rinart73:
Xiaomi Mi4c - Ressurection Remix based on CM (Android 7.1).

I made a full unroot.

Then flashed Magisk, pph-supersu through recovery. Installed Magisk Manager, pph-supersu application.

And.. Magisk Hide doesn't work. I check Pokemon Go, but after reboot or exit from Magisk Manager, it automatically unchecks.