yashsingh1/xdaforums huggingface dataset:
[Magisk] c3k:
In the S21 forum there's no much activity, but I'll try.

My question is magisk install related and I remember similiar discussion in this thread, but I could be wrong.
[Magisk] zgfg:
Np, if somebody here knows
[Magisk] J.Michael:
What is "*almost* no root privileges"?
[Magisk] J.Michael:
What problem do you want to fix?

If you can't find things related to a module repository, it might be because some versions of Magisk Manager app no longer are tied to a module repository, and there is no longer an official repository.
[Magisk] pndwal:
Broken in current released builds. Fix merged in Magisk master repo downstream for S21

https://github.com/topjohnwu/Magisk/issues/5162#issuecomment-1004475802

+ many other Sammy models two weeks ago.

PR: https://github.com/topjohnwu/Magisk/pull/5139

Committed:

https://github.com/topjohnwu/Magisk/commit/19182ffddf6f7c87bacab4b9f91cfaec3ee79537

John commented on Sammy's 'solution' for broken fstab in device tree (MA content):

www.twitter.com/topjohnwu/status/1475985579036667904

You'll need to wait for next TJW build (Canary or Beta), but you can try latest test build from artifacts here:

https://github.com/topjohnwu/Magisk/actions/runs/1632403163

Also, fix is merged in latest vvb2060 Alpha builds.

https://github.com/vvb2060/Magisk/commit/19182ffddf6f7c87bacab4b9f91cfaec3ee79537

Nb. Standard procedure is to flash patched firmware file as AP + HOME_CSC + BL + CP as per instruction:

Never just flash only AP, or else Odin may shrink your /data filesystem size. Flash AP + BL + CP + HOME_CSC when upgrading.

👀 PW
[Magisk] Eng.Raman:
To Get Rid of Xposed hooks flag: Don't Check/Select Applist Detector in any LSPosed Module Scope List.
[Magisk] c3k:
yes, i did not specify, but I include BL and CP in "standard procedure".

I'm just asking if the Android version jump needs any special attention.
[Magisk] pndwal:
Well you actually asked for confirmation standard upgrade procedure will work... (I could simply have said 'no it won't' I guess... )

Sorry if it wasn't clear, but I did say / indicate that currently it won't as A12 compatibility is broken for S21 etc in current released TJW builds.

Please check what I said as there is a fix downstream from current official builds, and working test / unofficial builds are available. PW
[Magisk] c3k:
My excuse. I totally miss the first part of your reply, I saw the double quote and think you want ti quote other post.

And very big thank for your info, I was close to try the update and mess my device...
[Magisk] zzz2002:
How can I tell which version of Magisk I am using.

Info avail 92546e8a (23016) (23) I ask because I seem to have got "hide" working. I am not sure how/why! I thought I had alpha but I am no longer certain.
[Magisk] pndwal:
Send Magisk App home screen screenshot... PW
[Magisk] zzz2002:
As requested
[Magisk] CZ Eddie:
Installed Magisk Canary and clicked on modules. It's not showing anything. No modules available to download and install?

On Android 9
[Magisk] zzz2002:
the modules & repositories are no longer part of TopJohnWu's version of Magisk.

You need to install Fox Mmm (FoxMagiskModukeManager) you can find it on github under Fox2Code.

Good Luck
[Magisk] pndwal:
So you have both TJW Canary App and Magisk (mask)...

Guessing you have old device not meeting current Hardware Tee requirements, or OnePlus or other device where OEM messed up Hardware Tee implementation of I'm seeing all installed modules, and that you've manually enabled Google Play services SafetyNet process (com.google.android.gms.unstable) and possibly main Play services process in denylist...

And no, you no longer have MagiskHide. (But you haven't yet enabled 'Hide the Magisk app'; you can if needed.)

MHPC module now restores sensitive prop changes (removed from post 23001 Magisk) where needed by default (even when nothing is configured using terminal emulator), and this can be enough to allow many devices to pass SafetyNet w/ the SafetyNet process hidden as mentioned. 😀 PW
[Magisk] zzz2002:
I'll take it. The device is an S7 edge, so hw tee is not avail, fortunately.

Thanks for the info.
[Magisk] pndwal:
In addition to post above:

ANYONE adventurous enough to install 'bleeding edge' Canary builds should at least read Release Notes! 😬

The first post 23001 Canary build (23010) Release Notes included a link to John's blog outlining major changes and future direction for Magisk:

https://github.com/topjohnwu/magisk-files/blob/9537c5d8cedfc09ca723ae0392b1219e75d9b636/notes.md

🤪 PW
[Magisk] pndwal:
Am I correct that you have manually added Play services process(es) to denylist? PW
[Magisk] zzz2002:
Yes, gsm & gsm.unstable.

the OLG app would not run, complained about rooted device etc. Tried to get it to work with the deny list, didn't work. Rebooted after each change, no effect.

Used foxmmm to add magic hide props (may have mistyped this) to magisk.

OLG worked/works without problems. Same for several other apps.

What am I doing right or wrong?
[Magisk] pndwal:
What Android version?... Likely only need hide SafetyNet process unless on A11+....

Is OLG a Canadian Bank?... Doesn't show in playstore for me...

Bit confused by "OLG app would not run, complained about rooted device etc." then added MagiskHide Props Config and now "worked/works without problems. Same for several other apps. What am I doing right or wrong?"... Is OLG working now? If so, nothing wrong... (or is something wrong??)...

What you're doing right is adding back part of what was done previously by removed MagiskHide. @Didgeridoohan added Magisk's former sensitive prop changes to his MHPC module to do this by default... Recent Universal SafetyNet Fix (USNF) module builds do the same...

Before testing any bank app, you should ensure you have Play Protect 'Device is certified' in Playstore (requires SafetyNet pass). I'm guessing you didn't pre MHPC. After that, bank apps may just work, but may require clearing their data to remove cached detection flags.

I wrote this on the basics yesterday:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86237221 😶 PW
[Magisk] musicvikingpro:
Hey guys need help,

I rooted my mi a2 lite (android 10) to use gcam port. But couldn't edit the build prop to enable camera2 api even after rooting the device. I tried to enable the api from adb, terminal but in vain. Is there any magisk module or any other way to enable it ?

I read about magiskHide prop config but could not get much information.
[Magisk] pndwal:
There may well be other solutions, but if prop changes are what you want to pursue, your problem is Google's Read Only 'Shared blocks' / Dynamic Partition (logical RO) scheme used since Android 10.*

The best solution (and a main purpose of Magisk) is to make such changes systemlessly.

Since it's prop changes you need, MagiskHide Props Config Thread would be a better place to ask:

https://xdaforums.com/t/module-magiskhide-props-config-safetynet-prop-edits-and-more-v6-1-2.3789228/

Use MHPC to make your prop changes systemlessly. OP has link to GitHub doc; first paragraph discusses exactly what you want; edit buildprop... More here:

https://github.com/Magisk-Modules-R...master/README.md#changeset-custom-prop-values

*Nb. You can get RW back if you're really adventurous; 'Power Users' can use a mod that can 'Universally Mount System read write for Android 10+ ROM w/ SUPER or NO_SUPER' partitions.

It does this by dumping existing super OR system / product / vendor partitions, extracting embedded read-only partitions, then flashing images back to device as read-write partition(s). (Understand that this is fraught / not for the faint hearted.) Game?:

https://xdaforums.com/t/script-andr...-superrw-featuring-makerw-read-write.4247311/

or

https://xdaforums.com/t/tool-win-li...ake-partitions-rw-in-super-partition.4120963/

🤠 PW
[Magisk] BillGoss:
Background: I know that there's a CLI to Magisk that you can use to install a Magisk module: magisk --install-module <module.zip>. I've tested it and it works.

You can install both Magisk modules and other flashable zips, such as the TWRP installer, in the Magisk app.

Question: is there a CLI for installing flashable zips, like TWRP, in Magisk?

I've tried using --install-module twrp-installer.zip but that doesn't work.
[Magisk] CitizenSmith:
I have android 8 using ALEXNDR custom rom and I updated Magisk to 23.0 now wish I didn't!.

I have now lost half of magisk settings I can no longer access anything below Download Path in Customization window and there for can not access Magisk Hide.

tried reinstalling older version via TWRP say ok but when I check nothing has changed I still have v23. creator says Magisk manager is dead!. has he done this on purpose?.

now most important apps that this was used for no longer work.

I managed to downgrade back to Magisk-v21.4 from 23.0 but had to deal with boot loop issue as a result but finally got pass it and could boot normal and did have all settings back in Magisk for a short moment but still could not get safetynet to succeed and creator seems to be forcing updates!!! which is why I tried to update in the first place. I never had any issue until I updated magisk now can't get no versions to work on safetynet which was ok before this point but now certain apps important are useless and thanks to his forcing of updates I can no longer even open magisk again unless I update first but can't as it now seems to bootloop my phone.

main reason I started looking at magisk again is I wanted to see if there was a more up to date rom I could install as mine may be causing issues with net speeds due to lack of update so I thought I would see if Lineage 19.0 might be better option but thought it a bad move at moment as I have issue with magisk and unless I can sort it it's not worth installing another rom with some of the same issues.

So the main issue is when I update to magisk 23.0 I no longer had access to half the settings like hide magisk or clear cashe there no longer available!!! why on earth he has removed that is any ones guess!!!!! and as i stated because the creator is forcing updates I can't even open magisk without having to first start updating and it's now locking my phone up boot loop when I do try so after many tries at resetting I finally get back in to my phone but have to go to recovery to get magisk back working if only for a short moment! but as I said it's short lived due to forced updates. at present I'm trying to follow instructions to remove magisks via twrp using Magisk module uninstaller/disabler By Veez21 not even sure that will work without locking up phone but at this stage I wondering if successful weather to just recover my original rom and stop using custom roms as magisks is more of a pain in the arse than a helpful app.
[Magisk] pndwal:
2.5 K pages! ... Some kind of XDA record? PW
[Magisk] DiamondJohn:
Are you asking if you can flash a TWRP specific (non-magisk) ZIP using Magisk?
[Magisk] c3k:
I've read your link, thank you again.

Another couple of questions:

seems a problem with lastest samsung firmwares, but a previuos Android 12 build (with a valid fstab) should work with Magisk 23 stable?

looking ahead to the Magisk 23+ without MagiskHide what you suggest to pass SafetyNet? com.google.android.gms.unstable in denylist + MagiskHide props config + universal safetynet fix?
[Magisk] pndwal:
(Samsung J4)

I see you run custom ROM. Please say ROM & Android versions...

Also, looking at your posts elsewhere it seems you've been playing with SuperSU, debloating etc...

Have you tried installing Magisk after a clean ROM install (full data wipe)? Really at this stage this is probably necessary to revert any mods made, even if you were careful to run proper SuperSU cleanup tools etc... Lost Magisk boot.img backup may be a clue to the state of your system. Unless this was done you can't be sure previous root / other changes have been fully teverted. PW
[Magisk] BillGoss:
Yes, I'm asking if i can flash a non-Magisk zip using a Magisk CLI.
[Magisk] lolvatveo:
This happens for all users with certain models. such as for all j5 users, of course even if the installation starts with Stock ROM. Then i flashed supersu in twrp, it detects boot.img then patch & overwrites magisk patched boot.img in rom. then supersu can take root from boot.img on boot, and magisk can't. no matter how do I install, the current magisk version cannot get root, my android is 7
[Magisk] lolvatveo:
exactly is magisk can't get root from patched stock boot, supersu can. canyie's custom magisk version only allows magisk to detect patch installed, it has no root permission. old magic version like 18.0 can root without any problem
[Magisk] pndwal:
Guess so... If there was one... Roll back and try!... Or try working Magisk builds mentioned! (Personally, I'd favour latest Sammy OS despite Samsung Devs shoddy practice...)

I put basic hiding info here yesterday:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86237221

I put detailed information here:

Post in thread 'Magisk General Support / Discussion' https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86217355

Nb. Re Passing SafetyNet: SafetyNet process, com.google.android.gms.unstable in hidelist / denylist works where Magisk is in /sbin. For Android 11+ etc (assuming Magisk is not in /sbin), main process, com.google.android.gms needs adding also.

Also, as mentioned many consider Riru as at end-of-life with introduction of Zygisk injection (hooking) including @kdrag0n, so only Zygisk enabled Universal SafetyNet Fix will work going forward. This solution hides the Google Play Services process(es) itself (you don't need to add any process manually with this), and will actually remove this (these) if in dentist.

Considering the above, all you need for passing SafetyNet w/ Zygisk enabled Magisk is USNF generally, and MHPC additionally with passing (CTS certified fingerprint set / spoofed) when using a non Google certified ROM, ie. China region etc ROM and custom ROMs except where these integrate fingerprint spoofing. 🥵 PW
[Magisk] vandyman:
And 80% are worthless posts. 😜

Most posts deserve an Oscar award.
[Magisk] martyfender:
have you tried the install from storage in the modules section of the app?
[Magisk] pndwal:
OK, so hybrid / unsupported Magisk install method in any case... No wonder getting 'no stock boot exists'... But I see longstanding issue with J4...

Many new fixes coming in next TJW build, eg:

- https://github.com/topjohnwu/Magisk/pull/5139

- https://github.com/topjohnwu/Magisk/commit/fd7bf2bc3a891fa22fbd2e43216e9695e4c7984c

If still not fixed, please consider opening issue ticket specificly for J4... PW
[Magisk] nu11ptr:
I got a mail from XDA on 2021/12/06.

@pndwal mentioned me but I dunno what and why.

It seems like he couldn't get completely happy Momo when using Zygisk.

My phone's screen broke two months ago,and now it still haven't been fixed.

Hmm,maybe he just mentioned the wrong guy?

Whatever, i'll try to find the solution if my phone is back from OEM.

Sorry for my poor English.
[Magisk] zzz2002:
OLG = Ontario Lottery and Gaming commission they run/regulate the gambling industry in Ontario. Amongst other thing they run weekly lotteries which roll over. Friday's will be $36,000,000.

Without the Magic Hide module the OLG app would start, issue msg about rooted device and close.

I asked here as I was under the impression that it was not possible have both deny and hide together. Which is what seems to be happening now.

Do you know if this will coninue to be the case with a more modern device with hw tee.
[Magisk] BillGoss:
Yes. Installing either modules or flashable zips like TWRP installer work fine using the Magisk app.

I am asking if there's a CLI option in Magisk for flashable zips like there is for Magisk modules.
[Magisk] J.Michael:
Have you tried "magisk --help" and see if anything looks promising?
[Magisk] J.Michael:
If you broke your Magisk installation by installing SuperSU, I think you need to start over: install stock ROM, install Magisk.

If an old version of Magisk works fine, why not use it?
[Magisk] BillGoss:
Yes, that's how I came across magisk --install-module which unfortunately doesn't work for non-modules.
[Magisk] pndwal:
Yes, this:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86052061

I was referring to this:

https://t.me/c/1414270883/25467

And I think you said Shamiko will probably never be open sourced...

Maybe I did if more than one nu11ptr.

I see two owners on GitHub:

https://github.com/awathefox

and

https://github.com/nu11ptr

BTW, this looks great:

https://xdaforums.com/t/a-minimal-rom-edit-tool-dnanother.4387403/

https://github.com/awathefox/DNAnother

👍 PW
[Magisk] HippoMan:
The next message will be number 50,000!

Who will be the lucky poster?

:)
[Magisk] Badger50:
Victory! What did I Will Merv!😉
[Magisk] vandyman:
You get to be a guest host for the Magisk Oscar awards. 😁
[Magisk] pndwal:
Well, as has been discussed this depends on your meaning, and you're simply not being specific enough.

To deny modifications and to hide 'root' are two different things, and in in Magisk going forward Xygisk enabled denylist replaces MagiskHide and its hidelist.

This is not to say that user implemented or 3rd party hiding is not possible with 23010+ Magisk, (in fact Zygisk support makes hiding module solutions potentially more powerful / effective) and that's exactly what you have w/ MHPC's alter sensitive props feature.

This is quite evidently the way forward for ANY device... Both devices w/o HKA late enough for Google's current implementation / testing*, and those with the hardware needed.

The user implemented or 3rd party hiding needed of course will vary with later devices requiring solutions like USNF, uncertified ROMs needing MHPC or other solution for fingerprint spoofing etc.

Also, any number of solutions may also be needed for advanced hiding needed for bank apps etc; Shamiko can now hide Zygisk itself for instance.

All this work will of course cease to be relevant as soon as Google swings their Big Hammer (ie. enforces HKA for SafetyNet or new Device Integrity APIs); even old non-affected devices will likely see diminished support.

* Nb. Even pre Android 6 Launch Version devices supported hardware-backed Keymaster in HAL. This has been strengthened continually with Android 6.0 providing an extended Keystore API to provide a broader range of capabilities, Android 7.0's Keymaster 2 adding support for key attestation and version binding, Android 8.0's Keymaster 3 transitioning from the old-style C-structure Hardware Abstraction Layer (HAL) to the C++ HAL interface generated from a definition in the new Hardware Interface Definition Language (HIDL) and extending Keymaster attestation feature to support ID attestation to provide a limited and optional mechanism for strongly attesting to hardware identifiers such as device serial number, product name and phone ID (IMEI / MEID).

The strong attestation HKA in Android 8 LV seems to be the level needed for current testing of Google's Hardware backed attestation, but this has continued to be strengthened. For example, Android 9 LV with its update to Keymaster 4 brought support for embedded Secure Elements, support for secure key import, support for 3DES encryption and changes to version binding so that boot.img and system.img have separately set versions to allow for independent updates...

https://source.android.com/security/keystore

🤠 PW
[Magisk] ManOfP:
So its been a while since I've rooted a smartphone, and I planned on using Magisk for the first time to root my Samsung Galaxy S8 Plus. I loaded it via TWRP as per the instructions on the site and online tutorial guides. Everything seemed fine until I installed the .apk file once the phone was rebooted. When I pressed the "Install" button in the Magisk tab( and later the App tab) the process seemed to be successful but then checking with Root Checker Basic shows the rooting was not done successfully. Upon checking the Logs, I do see "su: request rejected (10202)" a few times and the "Install" buttons still appear in both tabs and not "Update" .

Did I do something wrong on installing, or maybe didn't use the right package in TWRP? There was only one .apk file that was loaded then and no .zip. Oddly enough, when going to the SuperUser section swiping on Root Checker Basic then changes it's status to the device being fully rooted. But I'm still suspicious.

Sorry for the long query and if it's a noob error, like I said its been a while since I rooted. If anyone can help that would be awesome.
[Magisk] pndwal:
What site / guides?

This is correct when you are up to date... Install will load / flash / patch with version shown as latest. You can always reload latest app / magisk mask also...

If you don't know about single package installation archive (since 22.0) or renaming APK to zip for legacy custom recovery installation, I suspect you haven't read official instructions... Please click OctoCat symbol in Magisk App to get GitHub Magisk home, then Installation Instruction...

SafetyNet Check in Magisk may now be disabled... YASNAC is currently the best alternative...

Nb. There are several issues affecting some Sammy devices that have fixes merged downstream of last Magisk builds. If these affect your device you may be best to wait till next Canary or Beta release. I mentioned these here:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86245349

You could do worse than provide a screenshot of your Magisk App home screen and say what ROM / Android version you use for further suggestions... 👍 PW
[Magisk] ManOfP:
Thank you for your help, it seems that I got overconfident with the instructions and didn't rename the .apk file when installing via TWRP. Would it be best to uninstall and reload Magisk the same way? Or could I just uninstall it and install the app normally without booting into TWRP? Would the SafetyNet Check work then if I do the above?

The S8 Plus is stock ROM, Android 9 and Model SM-G955F (Exynos)

Thanks again for your help.
[Magisk] zelodev:
Hello folks,

I'm using the latest canary build of Magisk (23016) and am facing a CTS profile mismatch leading to me failing safetynet checks. I have zygisk on, I am using universal safetynet fix 2.2.1, magiskhide props config 6.1.2 configured to pixel 6 pro props with force basic key attestation enabled, and shamiko instead of the denylist. I also have xprivacylua installed on lsposed and even with disabling google play services tracking I still fail. Any idea what I could be doing wrong and how to fix it? Thanks

Edit: A temporary fix I found was resetting my props to default and spoofing them for certain apps like google photos using lsposed.
[Magisk] J.Michael:
It sounds like you have succeeded. Show @pndwal your Magisk Manager app screen and wait.

I have read that later versions of TWRP allow you to choose an .apk -- so you do not need to rename to .zip first. If your version of TWRP allowed you to pick an .apk, it must be willing/able to handle it.
[Magisk] Lughnasadh:
You can check out the OP of these 2 threads to see how people are passing safetynet on the Pixel 6 Pro...

https://xdaforums.com/t/guide-root-pixel-6-pro-with-magisk.4356231/

https://xdaforums.com/t/working-safetynet-with-pixel-6-pro-android-12.4354149/
[Magisk] zelodev:
See, I am using pixel 6 pro props but not on a pixel 6 pro. That may be part of the issue, but my device doesn't even have props in magiskhide props config, and others on my device bypass with pixel 6 pro props.
[Magisk] Lughnasadh:
May be helpful for you to state what device you are on and maybe others who have the same device can help.
[Magisk] zelodev:
I'm using a xiaomi redmi note 10 pro (sweet) on arrowos 12. A temporary fix I found was resetting my props to default and spoofing them for certain apps like google photos using lsposed.
[Magisk] Der_Googler:
Why can't run magisk as system app. It says abnormal state