yashsingh1/xdaforums huggingface dataset:
[Magisk] klemi71:
It isn't the issue you mentioned. After flashing patched boot.omg the device doesn't boot to system. It shuts down.

I tried alpha build, same behaviour.

Finally I booted to a TWRP Testbuild for Android 10. Data is encrypted though I removed Lockscreen before doing this. I was able to flash v21.4 from there. Same behaviour.

I set active slot after flashing just in case... nothing changes. Matlog isn't available, adb commands work, but before I can do anything, phone shuts down.

After flashing stock boot.img to both slots again everything works fine... unrooted, Magisk is not available if course.

Thank you very much do far, but issue isn't solved.
[Magisk] DiamondJohn:
I havent tested it on the new Magisk lite. I thought the module location had changed so would of assumed it would not work; but talk that the others may or were expected to work makes me think it might. However, the app TeMeFI has a built in Magisk debloater module builder. It can be found at Magisk>Modules>TeMeFI Hide System Apps>Add or Remove - Hide System Apps using a TeMeFI Module>Add One>* One thing that is clear, I really need to shorten some of those menu items...

If it is simply a case of a moved module location, if you let me know what that is and how to detect when to use/switch to it (eg if statement based on Magisk version), it would probably be pretty simple to modify the path it is built into. And I am working on new release right now.

My app above, uses a GUI, so it is pretty easy apart from having to use the GUI again if you clean flash your ROMS. But you can save off the scripts to automate it if you do it repeatedly and dont like to click.

Regarding Viper, if its the SEPolicy changes that are questionable, then switching to permissive should make that irrelevant (ie test the theory); for testing only of course. There are many methods used to install viper. I have had the best luck on A11 using the attached Magisk zip; note, I did not build it, and it defaults to boot permissive, which can be easily changed with a delay in the service script. It also has a few other very minor things not quite neat, but it has worked for me and others.

TeMeFI does. It looks under (all under system) app, priv-app, product, product/priv-app, vendor, vendor/priv-app
[Magisk] ascendant512:
Thanks, it worked.

I couldn't figure out how to apply the patch to the phone without root so I followed the build instructions. The project doesn't open in current android-studio but it does build so hey!
[Magisk] zgfg:
About the Magisk Lite and its /data/adb/lite_modules folder and the needed manual renaming of /data/adb/modules_update to/data/adb/lite_modules_update (when installing a module) please see my previous post:
[Magisk] 73sydney:
Im back on full magisk (Alpha) again (with riru_momohider & config settings) and back on my favourite ROM which allows my banking apps, Google Pay AND Samsung Pay to work...i just needed sanity again :) Its still weird to me that switching ROM's no matter what you do with magisk/riru etc, the ROM itself can sometimes give you up to root checking apps via build.props or kernel, or not executing magisk properly...i have one ROM thats safe and lets me use everything...

Next time im fiddling with magisk lite ill give TeMeFi a crack for the debloat function - you just know im slowly finding my way around it, even after a year of pokery...and you just keep adding stuff ...though not a chorus line of bananas :) I regularly use your Doze setting btw, and the graphs youve added are killer

I use the same viper zip for 11....it doesnt work on magisk lite at all :(

Yeah that doesnt apply for viper under magisk lite for the viper zip i use (as DiamondJohn has also linked above)

Basically im happy for the moment, all my bank apps, GPay and SPay are working (for the moment)
[Magisk] klemi71:
Is there a way to fix using the other slot (unused up to now) without losing apps, data, ...
[Magisk] zgfg:
Why didn't you use Uninstall Magisk from Magisk app? Easier and probably more confident
[Magisk] klemi71:
Of course I already did so. Issue persists. Flashing Magisk patched boot.img leads to a non booting device.
[Magisk] J.Michael:
Once you flash stock firmware, I do not think you need to worry about "Magisk" still being installed. I think you *do* need to worry about having one or more copies of "Magisk Manager app" installed. Make sure you uninstall all Magisk Manager apps, by any name, before installing a new version of Magisk Manager.

Have you been making a new patched boot image after each time you installed a new Magisk Manager app?
[Magisk] klemi71:
There was only one version (canary) installed. I used "settings" and Magisk hide in daily use, but reverted this before updating. Modules were disabled. Only thing that may be tricky is pixeltweakshelper-module as it modifies systemUI. Though I used safe mode to disable modules. When Magisk Manager was updated, I updated Magisk in place as recommended. After monthly ROM updates I patch the according boot.imp and flash it. This is the first time this doesn't work.

Nevertheless I'd really like to flash renamed (APK to zip) apkdebug.apk as uninstaller and begin from scratch without remains of settings, ...

But root is gone and there's no working custom recovery for Pixel 3 Android 11. Can this be done using fastboot flash?
[Magisk] J.Michael:
I'm confused about the order of these steps. With a patched boot image flashed, when you cannot boot normally, are you able to boot to Safe Mode?

I don't think you can flash a zip file other than with TWRP. You can look into the zip file and maybe make sense of what it does, but you probably won't be able to manually reproduce the steps of the uninstall script without root privilege.
[Magisk] klemi71:
I described it in detail earlier, sorry.

What could be really helpful is a working url for creating a user defined channel for Magisk 20.4 inside Magisk Manager. I can download the zip but there is no way to flash it. Next time I'll keep working Magisk_patched.img for sure, but at the moment I have to create one.
[Magisk] pndwal:
Stable json for 20.4 is here:

https://github.com/topjohnwu/magisk_files/tree/63555595ffa9b079f3a411dd2c00a80a3d985ccc

Need address for raw file:

https://raw.githubusercontent.com/t...5ffa9b079f3a411dd2c00a80a3d985ccc/stable.json

This address and path should work in custom Channel, but I'd assume newer App does not have full backward compatibility with older Magisk in any case. (I'm fairly sure you'll need to enter json path in old Manager Custom Channel setting; newer App only uses channel setting to update/change App). I do know 'Hide The Magisk App' option is incompatible with older method for instance.

Incidentally, issue with duplicated App/Manager arises from failing to Unhide/Restore App/Manager in App settings before updating, NOT reverting MagiskHide which is something quite different.

If you didn't and you had hidden app (often named simply "Settings", etc), you will necessarily see Magisk Installed: N/A, and have other issues. You'll likely need to find it in device settings App list, and uninstall.

Nb. This is expected coming from incompatible pre 21406, but in practice it is an issue even with current builds:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85078241

Hope it helps. 🤠 PW
[Magisk] pndwal:
Uninstall zip and uninstall from app are practically identical, an if inaccessible (no TWRP, no root, etc), are not entirely necessary anyway.

Flashing clean boot image completely removes Magisk (mask).

Settings, modules etc are all stored in /data/adb, and boot image copies at /data/magisk_backup_xxx. (Modules etc are only overlayed over system at boot time).

These can be removed manually for full cleanup, but do no harm without root, and are accessible / can be modified when root is restored in any case.

Nb. Neither Manual removal or App/zip Uninstall methods ensure complete reversal of changes made by modules. These should be properly uninstalled from Modules list (and any apps they set up uninstalled) prior to Magisk un-installation.

Without installed TWRP or root, you may be able to load a TWRP in memory (fastboot boot only), or use ADB to remove these files, or full data wipe (Factory Reset) / Clean ROM flash will do it. PW
[Magisk] J.Michael:
If the zip you downloaded was https://github.com/topjohnwu/Magisk/releases/download/v20.4/Magisk-v20.4.zip, there is a "magisk.apk" under "common". That might be the apk you should install under Android. Then, maybe if you set it to use the Custom update channel, but do not give it a working URL, it will be willing to patch an image for you. (All of this is conjecture, with no basis in personal experience.)
[Magisk] klemi71:
I already did so, but in this case installation (to patch a file) isn't available. The only option without valid url seems to be updating manager and using v22.1 that doesn't work. In this thread is described how to create user defined URLs by yourself, but I didn't manage this.
[Magisk] J.Michael:
Maybe if you post details of how you tried to provide a custom channel URL, and how it failed, someone could help.

Did you copy a JSON file, edit the URLs in it, and put it on a web server?
[Magisk] klemi71:
Thanks a lot so far.

I just patched with Magisk 20.4, flashed it. Thanks for the withing URL. Device doesn't pass Google logo on boot and reboots to bootloader. Flashed back boot.img to both slots.

I'll try other suggestions later this day and report.
[Magisk] pndwal:
With older pre-standalone builds, this this was/is not possible.

Standard channels always point to/look for latest builds and require Manager Update to allow Magisk patching.

Custom Channel gives N/A for 'latest' without URL for raw json containing links, and won't patch as it's looking for latest.

So custom Channel is/was required for older builds, and needs corresponding json path entered.

Nb. Only old public release json files work as hosted as these contain path to specific builds. Pre 22001 debug (Canary) builds had json files pointing to location for current Canary (as John wanted to ensure only latest Canary was ever used for its debug / reporting purpose), so to install older Canary requires editing json files and re-hosting.

Newer builds work differently of course.

Channel setting only points to App build to install, and Magisk (mask) version is solely dependant on App installed, and therefore works offline now also.

Nb. Older builds mentioned above refer to pre 21406, but more revision was also done to stand-alone archive delivery system before it was fully functional.

Older json files and Canary builds up to 22002 debug and 22100 (22.1) public are now archived at https://github.com/topjohnwu/magisk_files

json files and Canary builds from 22000 are found at

https://github.com/topjohnwu/magisk-files

so there is some duplication in John's repos.

Notably, even Canary build json files in the latter repo point to files for specific builds. This means we can revert to any Magisk build (inc. debug) post 22000, and any public builds before that using raw json file URLs as officially hosted in Custom channel. PW
[Magisk] J.Michael:
@pndwal I don't see anything useful at https://github.com/topjohnwu/magisk_files.

That's why I wandered, and posted a link to the Magisk 20.4 I found elsewhere.
[Magisk] klemi71:
Tulsadiver said:

Yes magisk survives updates. Here is what you need to do:

1. Boot into fastboot and flash stock boot.img, and reboot. "fastboot flash boot boot.img"

2. Boot as if entering safemode (push and hold power button until the power off icon shows. Long press it for safemode option).

3. Your phone will reboot. Before it boots all the way back up, press and hold power and volume down to enter fastboot mode. Fastboot flash magisk_patched.img and reboot. You'll be rooted in safemode.

4. You can now use adb to remove all modules.

"adb wait-for-device shell magisk --remove-modules"
[Magisk] pndwal:
So all fixed, and have Magisk root? 😛

Please say which module was incompatible with Update. PW
[Magisk] pndwal:
Well 'releases' location you found is exactly where you need to get zip and apk files, and that's all you need for custom recovery Magisk Installation.

To use patch image method w/ 20.4 (and any pre 22.0) however, you also need corresponding json file URL for custom Channel.

I already posted that, but you can find, copy, paste these as follows:

Eg,

- Go to repo you linked

- Click History (clock) symbol

- Scroll down and click Release Magisk v21.4

- Click Browse files

- Click View code

- Click Stable json

- Click menu (3 dots, second instance)

- Click View raw

- Copy URL for this from browser

- Paste that to Custom channel

🤠 PW
[Magisk] klemi71:
Everything is fine.

ADB command removed all modules, so... 🤷🏻‍♂️. I think it was Pixeltweakshelper-module. But it was my fault to install it before updating ROM as it is monthly updated.
[Magisk] roninspin:
Hi! Is there a way to replace files (vendor/etc/init/init*.rc) earlier than magisk does it by default?
[Magisk] pndwal:
Great!

Re. your difficulty booting to Safe mode:

I know w/ Android 11, some devices incl. Samsung now require plugged in USB in addition to key combo to boot to Safe mode or Recovery. Some have success with PC usb connection, others need usb headphones it seems... But I don't think this applies to Pixels. 😜

Just found this info for Pixel:

https://github.com/topjohnwu/Magisk/issues/4011

I used Translate in Chrome for Chinese.

It has interesting info on keypress detection etc, but what may be useful is that when you can't use Long power press / Vol down to reach Safe mode w/ bootlooping magisk-patched boot image, you can simply flash unpatched image (restores normal boot), then Safe mode key combo should work, and modules are disabled.

Next, reflash patched image, and you should now be able to boot w/ Magisk root!

It seems to me that you may have actually achieved exactly this (especially as your pm said "It is solved! At point two I had to press and hold vol down during boot animation instead of power button."

Did you observe Safe Mode booted? ... If so, I'm not sure point four, "adb wait-for-device shell magisk --remove-modules", is actually needed. 😬 (Not sure comment at point four "You'll be rooted in safemode" is accurate / relevant either.)

Anyway, well done, enjoy, and thanks for feedback! 🙂 PW
[Magisk] pndwal:
I think John Wu does this (applies overlays) as soon as is possible:

The Magisk Story

www.reddit.com/r/Android/comments/7oem7o

This discovery of his was the basis for Systemless XPosed as well as the Systemless Magisk root solution we have today, and is vital for MagiskHide, especially Magisk's SN bypass feature.

Nb. The Magisk Story linked above is a great read, and enhances understanding of the root process and methods employed.

If the heading "The Beef: Controversy" caught your attention, be sure to read further posts below the story from @Chainfire (Jorrit), @topjohnwu (John) and others. More here:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-83707709

🤓 PW
[Magisk] DiamondJohn:
I found on my A11 Pixel 4a the boot animation wasn't being replaced before it played. The work around I used was to have a reboot in the module, so it would make the change and then reboot and use the newly replaced version.
[Magisk] pndwal:
Very interesting / useful! ...

I can only guess how this works 😕 ... I assume it does because reboot may be less inclusive / later start than powered down boot. Presumably it does not reload some items already in memory, incl. boot animation file? PW
[Magisk] DiamondJohn:
And just to be clear.

I had two reasons for the"soft-reboot". I also changed a prop to enable the blurred background under the QS Tile-panel. This also did not work until after the "soft-reboot". So my blur script handled both the set prop and the reboot, which was also taken advantage of by the bootanimation change. It was of course a service.d script and not post-fs-data

#!/system/bin/sh
setprop ro.surface_flinger.supports_background_blur 1;

killall surfaceflinger;

Where it got a little "funky" was sometimes the first few frames of the standard boot animation played, before the reboot and it then played my boot animation.

FYI: I have posted all the above in a couple of other places where others may possibly find it of use.
[Magisk] roninspin:
The files are replaced but logs keep showing actions.

Please, help me.
[Magisk] pndwal:
Way out of my depth here sorry... Anyone else? PW
[Magisk] klemi71:
Safe mode was displayed in the left down corner. Maybe this would have been enough to solve the problem.
[Magisk] pndwal:
Yep, then that's what did it! 😜

Seems ADB command "adb wait-for-device shell magisk --remove-modules" to remove all modules is actually a good alternative, and would [Edit: MAY (see posts below)] have worked even w/ bootlooping setup.

In your case though, since you flashed unpatched boot image, booting to Safe mode could succeed or at least became less difficult / key combo timing started working normally ... And holding vol down 'at boot animation' occurring as you did, happens to be precisely the way to do this!

https://support.google.com/pixelphone/answer/2852139?hl=en#zippy=,if-your-phone-is-off

So modules were already disabled at this point (no need for "adb wait-for-device shell magisk --remove-modules" command). 😛

I'm still mystified regarding safe mode, or safe mode key combo at least, being broken / difficult w/ Magisk patched boot image on Pixels however... Perhaps it's broken on other devices w/ Magisk root too. (?)

Anyway, as they say in the business, the rest my friend is history. 🙂 PW
[Magisk] klemi71:
I tried "adb wait-for-device shell magisk --remove-modules" with patched boot.img in regular mode and it didn't work. Phone shut down as soon as Google animation was passed.
[Magisk] DiamondJohn:
My experience with init.rc files was a couple of years back when I was building ROMs and the source for the device (built and maintained by someone else) had a bootloop. I went through it and basically reordered the load sequence. And from memory, the one I looked at mostly controlled the boot sequence (ie starting services) and setting mounts and folder permissions to enable the ROM to run as expected.

Now, your screenshots appear to be that you are trying to replace your RC's with empty files? ie delete them.

When I was looking at the RC file I dealt with, a lot of it looked like it could of been done after the boot had completed. For example, set the write permissions on the file that controls brightness, so that when you slide the brightness UI controller, it could write to the file.

Anyway, getting back to your actual issue, I would guess that magisk would not be able to replace your init.rc files in time, as its way to early in the boot process, (as I found with replacing the boot animation which I think is started by an init.rc file) and possibly magisk itself depends on some of that, and even is part of the boot img modifications it does. ie it actually changes the boot image, to be able to do what you wish to do. But remember, its a guess.

Are you certain you cannot achieve the actual changes you are trying to achieve, post boot? I REALLY don't think it would work in your case, but maybe give the reboot trick above a go. And maybe it will be a different level / service to kill to catch it after it has been changed, but keep it changed, but make it re-run the init files, but as I am typing, that just sounds like a path for duplication (ie retsart services that are already running), that just isnt going to succeed.

If its a custom ROM, maybe get your builder to change the build.
[Magisk] pndwal:
Thanks... Seems Safe mode solution may be pretty much indispensable for you then. Just as well John implemented it! 🙂

Nb. Both methods seem to have worked with Pixel 5 here (use Chrome + Translate option):

https://github.com/topjohnwu/Magisk/issues/4011 PW
[Magisk] soaib333:
The lastest magisk zip or boot.img patch ia not working on samsung TAB A SM-T285 (Lollipop)

I flash the correct zip file so many time and it flash the success on TWRP but after reboot the manager showes Installed : N/A. Then I read the magisk blog instructions and patch the boot img file but the result is same. The only thing is working the older version of magisk but I want to up to date so please fix this bug or announce a new method for samsung lollipop version.
[Magisk] pndwal:
Likely this known issue affecting older Android:

https://github.com/topjohnwu/Magisk/issues/4174

See also XDA link there, and this:

https://github.com/topjohnwu/Magisk/issues/4107 PW
[Magisk] martyfender:
John took a job with Google, so the way I understand it, he is no longer allowed to develop Magisk.
[Magisk] rodken:
Is there an advantage in utilizing Magisk Lite versus other versions of Magisk?
[Magisk] pndwal:
Not for most: It breaks normal use of modules for example. Seems its sole purpose / only advantage is for those desperate to pass SafetyNet for bank apps detecting "root" through isolated processes, or interested in testing MagiskHide with this ability.

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85103873

Alpha Magisk from same dev is best bet for those simply wanting newer updates / fixes at present:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85103975 PW
[Magisk] DiamondJohn:
I have never installed it nor used it or even followed what the heck it is. However, it looks like the direction Magisk will be heading in, in the future. The advantage in my eyes is best to find any roadblocks and soln now, before they become a sticking point.
[Magisk] DiamondJohn:
I dont know your device, however, I have owned older devices, and on those devices, I cannot run the latest software. Maybe your device running lollipop is just not ready for running the latest of software in other regards. Lollipop is getting old.
[Magisk] 73sydney:
I have an old Samsung Galaxy Tab 3 10.1 (GT-P5210) and it wont support Magisk above v20. Just the way it is.

Im afraid you just have to realise your request will go into the "wont be fixed" list sorry
[Magisk] rodken:
@pndwal What would be the difference in these three versions?
[Magisk] pndwal:
Just download/use the app-release.apk as per my linked notes.

Not sure why app-32bit.release.apk and app-64bit.release.apk have been left there, but they're clearly not up to date in any case.

stub-release.apk is called (as per json file link) for 'Hide the Magisk app' function if online when selecting this, but this Alpha will use a local stub apk otherwise. (See changelog "- use the local version when you can not download stub, can be completely offline now Magisk") You don't download that manually. 👍 PW
[Magisk] rodken:
Since using this Alpha version, have you seen any updates come through the pipes automatically via the Alpha channel or this one of those situations where I have to 'hunt down' and manually install any future updates of the Alpha build?
[Magisk] zgfg:
Having Alpha for cca 10-14 days, there were no updates so far

As you were responded, install app-release.apk (17 days old as of today) - my download is 9.87 MB and with MD5 checksum: b989587f1ac9a1ff2ca03c87f017a3c7
[Magisk] rodken:
Correct me if I am wrong - I would have to repatch my boot.img with the alpha release in order to get this work in my favor because simply installing the alpha apk over the existing Magisk Manager is not an option.
[Magisk] zgfg:
Yes, first install Magisk Alpha apk and allow to finish the installation once you run the app (it will fetch the stub.apk)

Then, make sure that Alpha Update channel is selected in Settings

Use Install Magisk option to patch your (boot) image, flash and reboot - to obtain as on my screenshot

Important - to install Magisk Alpha app, you will probably have to uninstall Magisk Stable/Canary application (because of the missmatch in the apk package names and/or version number)