yashsingh1/xdaforums huggingface dataset:
[Magisk] Captain_Throwback:
I think AdAway being pre-installed might be your problem. In the same way that using Magisk allows the system to only see stock "stuff," just using Magisk to replace the folder won't prevent apps from seeing what's already there. I'd try removing it and see if that helps your SafetyNet issue.

Magisk is really only *supposed* to work on stock-based ROMs; that it can be made to work on custom ROMs is much less likely, though as we know it can be done.

Only the gms.unstable process needs to be added to Magisk Hide for SafetyNet to pass, and that's selected by default. Anything additional is superfluous.

Sorry, I didn't see any mention in your post of what device you were using; even so, I know nothing about Samsung devices, so thanks for the information.

I also didn't see your reply to my question about trying it with no modules at all, but if I'm right about AdAway, I'm going to assume that it wouldn't work anyway. Does the ROM you're using come with a pre-patched hosts file? If so, that's undoubtedly your problem.
[Magisk] Didgeridoohan:
From the man himself (Official announcement thread, currently known issues):

"Stock Samsung Kernel hides namespace of processes. Magisk Hide cannot work properly"

Do you have a kernel that's supported? This is the incompatibility I was talking about.

Also, as already stated, there's no need to hide any apps to pass Safety Net. Having too many apps hidden may even be counter productive:

"The best practice is to NOT add a lot of apps in the blacklist of MagiskHide (managed in Magisk Manager), so that the MagiskHide daemon has the time to react."

(Also from the Official announcement thread)
[Magisk] JJXB:
Since the last time i posted i've seen nada about my current problem so again, posting so i can find out *if* i can do something without having to backup and install a custom rom (i don't want to have to back every damn thing up).

My A300FU is on the last available version (5.0.2 API21) and while i have Magisk, phh SU, V4A all working i haven't got xposed for it because there appears to be no API21 compatible samsung xposed version. is there any solution that isn't "backup, wipe and custom rom" because i don't want to mess around with that in order to use the gyro emulation xposed module. SO HALP?
[Magisk] Andreasworks:
excuse me can you tell me why I remain so? where did I go wrong ? thank you
[Magisk] Artim_96:
.... Who is seriously that masochistic to use stock Samsung software?

And I don't have any com.google.android.gms.unstable in the list
[Magisk] Andreasworks:
I downloaded magisk from play store downloaded phh 's superuser started and looks like this ... I would like to be able to use your smartphone to type Android pay payments ... thanks

Inviato dal mio m8
[Magisk] Captain_Throwback:
It's not supposed to be in the list. Magisk disables it by default because it's SafetyNet. Again, there's nothing you have to manually do to hide Magisk from SafetyNet besides enabling Magisk Hide.
[Magisk] Didgeridoohan:
Read the link I posted... And maybe also the official announcement thread.
[Magisk] Artim_96:
Here is the log without anything additionally ticked and AdAway removed. Doesn't help.

And stock hosts file only contains

127.0.0.1 localhost
::1 ip6-localhost
[Magisk] Captain_Throwback:
Looks like you still have modules enabled:

* Stage 3: Mount module items
Mount: /magisk/rm_Adaw_cam-sound/system/app/AdAway
Mount: /magisk/rm_Adaw_cam-sound/system/media/audio/ui/camera_focus.ogg
Mount: /magisk/rm_Adaw_cam-sound/system/media/audio/ui/camera_click.ogg
Mount: /magisk/rm_Adaw_cam-sound/system/media/audio/ui/VideoStop.ogg
Mount: /magisk/rm_Adaw_cam-sound/system/media/audio/ui/VideoRecord.ogg
Mount: /magisk/MM_bootanim/system/media/bootanimation.zip
Mount: /magisk/GPM/system/priv-app/GreenifyPrivileged

And Play Services is still being hidden:

* Starting Magisk Hide
MagiskHide:
Update process/package list:
MagiskHide: [com.google.android.gms.unstable]
MagiskHide: [com.google.android.gms]

Can you please disable all your modules (besides root), remove Play Services from the Magisk Hide list and get another log? Thanks!

Because you're running a custom ROM, any number of things could be your issue, but I couldn't tell you what they might be. Like I said before, Magisk is really only expected to work on stock setups, so you may be on your own with this. I think I've checked for everything I can think of, without knowing much about Samsung devices and the ROM you're running.

P.S. Does your custom boot animation actually work without being placed in /cache?
[Magisk] qu4gmire:
Great call! From the description, I thought that module could only be used for the apps specifically listed by the developer. This sounds pretty perfect. Thank you!

I should add that I've gotten most streaming apps like Spotify to work with V4A as I have it installed now, but my general "Music" player doesn't agree with it.
[Magisk] Didgeridoohan:
Since it seems you've got Magisk working without problems, maybe this query is better suited for the Xposed forums?

I won't be able to help since I don't use Xposed, or Samsung. From what I gather though, the Magisk version of Xposed should work with Samsung. But, better to move over to the Xposed forums.
[Magisk] Artim_96:
Well, disabling all modules means no root and no Magisk hide and especially no logs.

And I didn't place it in cache, I just let it mount to /system/media. But that module is s bit older, I think from when cache modules where still possible
[Magisk] Captain_Throwback:
Did you not read what I said? I said disable all modules (besides root).

I was just curious if it works - I see it's not in cache from the log.
[Magisk] Artim_96:
No, it does still fail
[Magisk] Captain_Throwback:
I meant the boot animation - does it work?
[Magisk] Artim_96:
... What exactly do you want me to try? To copy the zip somewhere to /cache? Because cache modules aren't possible anymore.
[Magisk] JJXB:
the trouble is that afaik the systemless modification to xposed for magisk is only supported here in the magisk forums, not the xposed forums.
[Magisk] Artim_96:
He meant the thread for systemless XPosed, not the one for normal XPosed.

But no, there is no systemless version for Android 5 on Samsung stock ROMs. This is based on Wanams version of XPosed which needs at least 5.1. 5.0 needs a deodexed ROM on Samsung devices, so either you manage to deodex yours or you have to install a custom one anyway
[Magisk] Captain_Throwback:
It was a simple yes or no question. Does it work?
[Magisk] Artim_96:
What?
[Magisk] Captain_Throwback:
Does the boot animation work?
[Magisk] djb77:
BUMP

[MENTION=4470081]topjohnwu[/MENTION]

I seem to be encountering a problem with the v10 version of magisk regarding some modules I create exclusively for my ROM. The issue is with implementing the 3minit battery mod.

On v9 everything works perfectly, but on v10 it causes major issues. It seems to do real crazy stuff with my phone like changing permissions that shouldn't be changed, you cant use the keyboard etc. The other 2 mods that I create work perfectly (5 way reboot module and custom sound mod module written for TGP) but this particular one messes everything up.

It injects 2 new apks to /system/app, but the one that seems to have the issue (I'm thinking) is SystemUI (located in /system/priv-app). Here's some tests I did and the results:

- Hard-implemented the mod (physically copied to /system) -- WORKS

- Include the 2 apks and the 3minit version of SystemUI into the magisk module -- FAILS

All I did previously in v9 to get it to work was change the module id in config.sh, and adjusted the changelog.txt and module.prop files. Is there something else I need to be doing for v10, further edits to config.sh ??

Thanks in advance, I hope you can help me here.

More info: Magisk module ends up being about 60mb or so unpacked, so it has to resize magisk.img. Could an issue lie here possibly?
[Magisk] MorpheusKiller:
Hi,

i know it's still the same old story, but i can't get Saftynet to pass after installing Magisk with integrated phh's (aroma choice). I've also installed Magisk hide and rebooted. I alos tried with Prometheus Kernel as someone said it worked for him.

Device: Galaxy S7 Edge

Magisk: 10.2

phh's: r2

Kernel: Prometheus 2.2.0

ROM: Stock latest 6.0.1
[Magisk] Oki:
Not true, in the ZTE Axon 7 the only way to have root+Xposed+Safetynet is by using SUhide. Actually Magisk is the method that is not working in our device, It simply doesn't installs in our Android M ROM. Probably there are other devices out there that still have to use SUhide due to, I hope temporal, Magisk incompatibilities.
[Magisk] Artim_96:
Of course it does, why shouldn't it? It just gets mounted on top of the original one.
[Magisk] culiacanazo:
Tell me more, i thought they were separate (phh-superuser-topjohnwu-r2.zip as opposed to the "262-or-so" one)
[Magisk] Artim_96:
Well, did you download the latest template after the update and rebuilt the module? Maybe that's the problem. Otherwise you should at least upload the zip you flashed so someone can take a look at it.

---------- Post added at 11:51 PM ---------- Previous post was at 11:49 PM ----------

Well, then you probably don't have the november patch. Or your ROM already "patched that patch". Either way, what he wrote is true.
[Magisk] culiacanazo:
There are multiple ways to accomplish wiping them from within android
[Magisk] Artim_96:
Just read back, there is a big discussion about that topic. In worst case it's device specific and can't be solved here. Logs are needed.
[Magisk] culiacanazo:
Sh*t, not trying to kiss anybody's ass but i love it, simple, clean, open, effective, what else can one ask for!
[Magisk] Captain_Throwback:
Logs?

Well on some devices, using a standard Magisk module to replace boot animation doesn't work, as the boot animation is called too early in the boot process and magisk.img hasn't been mounted yet. That issue is described in the official thread, which is one of the reasons cache modules existed in the first place. That's why I wanted to know if your module was working fine as a standard module - because it doesn't for me. I have to magic mount in /cache for a working custom boot animation.

I'm sorry if my questions are annoying you. I won't bother you anymore. If you figure out the issue with your custom ROM passing SafetyNet, let us know.
[Magisk] djb77:
Heres some logs for you
[Magisk] novren:
I haven't been able to find a single working one, could you point me to it?
[Magisk] culiacanazo:
Just my two cents: i read that if you hide too many apps it may go wacko on you
[Magisk] Andreasworks:
excuse how do you upload here the error file? I can not.

Inviato dal mio m8
[Magisk] Syoenth:
can't pass SafetyNet, I fresh installed Magisk 10.2 with phh superuser and cant pass Safetynet :(
[Magisk] Andreasworks:
+1

Inviato dal mio m8
[Magisk] Eddie_Brock:
I upgraded from within the app without issue.
[Magisk] culiacanazo:
Not even systemlessly?
[Magisk] Artim_96:
Well, I can tell you that the Magisk one seems a bit very short, especially under step 5. Did you enable both debug options in settings?

---------- Post added at 12:27 AM ---------- Previous post was at 12:26 AM ----------

Nope. Even with less it won't work

---------- Post added at 12:28 AM ---------- Previous post was at 12:27 AM ----------

At least not on Android 7 and not on Android 5.0 Samsung devices, no. And not if you want to pass SN
[Magisk] culiacanazo:
He wants to use YOUR phone!!
[Magisk] Syoenth:
attach log of magisk, it seem it not work properly, I'm on a Samsung S3, model I9300 wit Resurrection Remix 5.8.0
[Magisk] Didgeridoohan:
To pass Safety Net you cannot have an active installation of Xposed, at all.

Since I don't use Xposed I'm not very well versed in its ins and outs, but I think you might disable the systemless one (and maybe rebooting) to pass SN.
[Magisk] culiacanazo:
Well, i know xp isn't AVAILABLE in 7 yet, i did mean the obvious (MM)

....So! It is (possible)?
[Magisk] djb77:
I tried enabling it and it came up with the same log, nothing extra in step 5
[Magisk] culiacanazo:
Is that all you need or would it HAVE to be from within TWRP?

without waiting for your reply, lest we spark a full-blown, off-topic discussion, there are multiple apps out there, just choose wisely

(If it's when flashing that you need it, I'll dare say that if it's really that important then, most zips will include the wiping when flashing)

EDITED
[Magisk] novren:
I have found several apps that claim to wipe cache and dalvik.

Neither of them do what they advertise.

If you know of one, please tell me.

I understand that to wipe dalvik cache I just have to delete the folder, but it doesn't seem to work.

And to delete cache, I'm not sure, and don't wanna **** it up since I can't restore backups from twrp (nor make them either)
[Magisk] Artim_96:
If you don't want to pass SN it is

---------- Post added at 01:14 AM ---------- Previous post was at 01:11 AM ----------

... Either you messed up TWRP or your OEM is a dumb asshole. Either way, that belongs into a device specific thread.
[Magisk] culiacanazo:
I PM'ed you
[Magisk] Mr.Fearless:
Hi guys, i cant install magisk by recovery or shows me "out of date".

1) i have tryed to flash magisk 10.2 by recovery but after flashing the s7 edge goes in bootloop (tyed with SuperSu disabled and without binary installed). So i had to flash the unistaller.

2) I even tryed enabled the chainfire SuperSu just for trying to flash the magisk+phh by magisk manager. Out of date. I think it cames cause magisk try to load the chainfire supersu binary and not the SU binary magisk has.

Help me please.

P.s. i have tryed with a clean boot image charged.
[Magisk] culiacanazo:
Acknowledged. Thank you
[Magisk] novren:
My oem is a dumb asshole sometimes (oneplus), but I just wanna know if it is because of not wiping cache that viper does not work.
[Magisk] Artim_96:
Only logs could tell. But anyway, that might fit better into a device specific forum. We can only tell if you did anything wrong. And I'd guess that XPosed the only module is that needs cleared cache and dalvik.

PS: already tried to find the terminal commands for that? TWRP does just use make_e2fs. Maybe you find one other for formatting
[Magisk] steveo17:
turns out i had xposed still installed which was preventing the phone from booting.

once i removed the xposed img it works fine now
[Magisk] dimm0k:
previously flashed the systemless AdAway zip file... any idea how I can remove that and let Magisk handle this?
[Magisk] Captain_Throwback:
If you're not using SuperSU then there's nothing to remove. If you are, just remove the adaway script from /su/su.d.
[Magisk] datafoo:
I just checked my magisk folder and using systemless adaway and PHHs superuser it does put hosts in magisk/hosts so it's systemless :)

Sent from my HTC 10 using telepathy...
[Magisk] topjohnwu:
Massive Update!! Magisk v4

Celebrate!! XDA finally updated my status to Recognized Developer :p:p (I released 12 zips today lol)

Here comes the long awaited "Magisk v4"!

The first 4 posts are now filled with TONS of new information, this shall be the final API of Magisk and won't change in the near future.

All existing Magisk modules are updated (phh, SuperSU, Xposed). Two new modules are now added to the #2 post: Viper4Android and Liveboot.

Magisk Module port requests are welcome, but I only accept those that can be applied to all devices.

Developer feel free to ask questions about the API, porting issues, and bug reports. I will help you as much as I can

A brand new "Magisk Manger" is still work in progress, I'm currently working with [MENTION=5345056]DVDandroid[/MENTION] to speed up the development (and due to my poor Android App development skills lol), if you're experienced in Android App development, please contact me to give me a hand, I appreciate any help!

In the future, Magisk Modules can be manged just like Xposed Modules (currently v4 has the management API built in, the only thing missing is just an application to deal with it)

Lastly, people interested in Android Pay stuffs:

Recruit Testers!! Android Pay Beta Testing / Discussion

Changelog

v4

- Important: Uninstall v1 - v3 Magisk before upgrading with the uninstaller in the OP!!

- Massive Rewrite Magisk Interface API ! All previous mods are NOT compatible! Please download the latest version of the mods you use (root/xposed)

- Mods are now installed independently in their own subfolder. This paves the way for future Magisk Manager versions to manage mods, just like how Xposed Modules are handled

- Support small boot partition devices (Huawei devices)

- Use minimal sepolicy patch in boot image for smaller ramdisk size. Live patch policies after bootup

- Include updated open source sepolicy injection tool (source code available), support nearly all SuperSU supolicy tool's functionality
[Magisk] garthybarthy:
Deleted
[Magisk] Shockz:
Congrats man! Thank you for your awesome work and support in the community, all of us appreciate it :good:
[Magisk] rgawenda:
root@bacon:/sdcard/download # pm install Magisk_Manager_v1.2.apk

pkg: Magisk_Manager_v1.2.apk

Failure [INSTALL_FAILED_INVALID_URI]

1|root@bacon:/sdcard/download #
[Magisk] SirVilhelm:
I cannot install the manager either.

pkg: /data/local/tmp/Magisk_Manager_v1.2.apk

Failure [INSTALL_FAILED_UPDATE_INCOMPATIBLE]
[Magisk] waylo:
Did you uninstall the previous version?
[Magisk] Artim_96:
The new version behaves quit...strange. I uninstalled Magisk with the uninstaller zip and then reflashed the ROM just to be sure.

I didn't let it boot to system for first compiling because I didn't want it to do it a serving time after fishing XPosed, so I just flashed TWRP and booted there. I flashed Magisk v4, then phh's SuperUser, XPosed v86.5 and the modified LiveBoot.

The first interesting thing was, that it booted the system very fast, no recompiling. Root it working fine, XPosed installer reports v86.5. But I can't install the Magisk manger apk and the livebootlog is quite empty, looks like errors with the rights.

Dev: Note 4, stock M
[Magisk] TheManii:
Uninstalling the old version and rebooting still results in the same error, there's nothing in the manifest to indicate why it's incompatible though.

The only thing in it (that's relevant to this) is:

targetSdkVersion="24" (7.0/Nougat)
minSdkVersion="21" (5.0/Lollipop)
[Magisk] rgawenda:
Yes, IIRC. I can't find it via settings app, and it isn't found in /data/app
[Magisk] SirVilhelm:
Sure did and even checked system apps to be 100% sure it was gone.
[Magisk] agentdr8:
Reinstall Magisk Manager from phh-superuser v2 (just the apk), then uninstall it, then install Magisk Manager 1.2.
[Magisk] rgawenda:
This worked. Thank you!
[Magisk] Artim_96:
I have no idea why that works but it works. Thanks.

PS: did the safetynet test also work on previous version? I thought at the moment Magisk can't hide XPosed. Or was it just fixed in v4?
[Magisk] agentdr8:
Safetynet tests worked fine on previous versions once root is unmounted, with or without Xposed. It's when it comes time to do a transaction that it actually fails. It has still yet to be determined if it has anything to do with Xposed being installed/present, as some have posted successful transactions with Xposed installed at the time.
[Magisk] tikizondo94:
Thank you for this! Works great now!
[Magisk] elreydenj:
Finally works on DP5 Nexus 6P running EX Kernel. Android Pay transaction went through after toggling root off in Magical Manager. Only downside is root explorer doesn't work with phh superuser....
[Magisk] Captain_Throwback:
Have you tried disabling Xposed?

From a cursory review, things look proper, but resizing can't be the issue. I think the updates [MENTION=4470081]topjohnwu[/MENTION] made to the zygote detection and namespace updates have just broken some of the Samsung devices. There's nothing I can do about that unfortunately; you're going to have to wait until John has more time to look into it. But I'm not sure whether he has a relevant device to test on :rolleyes:.

In general, Magisk has no problem resizing magisk.img or replacing SystemUI. All of the ROM modules I have installed replace SystemUI, and my magisk.img is larger than 1 GB.
[Magisk] djb77:
You can rule out Xposed. I just tried doing a fresh magisk install with only the mod that doesn't work, and it still fails.

The resizing definitely can be ruled out too because it didn't need to resize magisk.img this time around either.
[Magisk] andrew2432:
Search dclarke xposed, has a wanam fork for lollipop, system install only :(

---------- Post added at 02:35 AM ---------- Previous post was at 02:31 AM ----------

Some are afraid to make the full jump. I didn't move completely until I could accomplish everything I wanted to on a custom os. With that said stock smg was absolutely terrible and other than some cell issues there's absolutely no reason for running inhibited like that. If you're on a touch wiz ROM get off now before you're trapped.
[Magisk] novren:
Edit. Double post.

---------- Post added at 04:43 AM ---------- Previous post was at 04:40 AM ----------

You are right, this is a device specific issue and would fit better into an op3 specific forum. Thank you for your help anyway. I'll try to get this sorted before trying to figure out why doesn't viper work.

Sorry for the off-topic.
[Magisk] xd4d3v:
Magisk manager force closes on Android TV :(

How can I help troubleshoot it?
[Magisk] me7tarfeek:
Will Magisk root work on Mate 9, please?
[Magisk] Artim_96:
Try it yourself, nobody here is psychic. But as long as Huawei hasn't needed up the system too much there shouldn't be any problems.
[Magisk] rignfool:
Make sure you have a substitute user control app...

PHH's is available in the playstore...

And!

[MENTION=5444464]PunchUp[/MENTION] has a new super fancy control app that doesn't take the whole screen when requesting elevation... And can make allowed toasts go away and only denied appear... And allows for a notification instead of a toast
[Magisk] mucha.k1994:
Ok, done. I drop my search for solution to RUN v4a on nougat (7.0). After a lot of combinations, like flash other modules (v4a-v1 from this thread, few pages back, give a boot loop in result btw.), like make my own with replacements of files (i combine v4a by guitar hero zip from xda and put this into module, but after flash a my own module in manager I see 2x my module without any description and in folder magisk i have 3x folder with my module, where each of them have only a 1/3 of my files, lol). I try with change SElinux policy to perm, then install drivers via v4a app. It work once or twice, but then something was wrong and stop working anyway + show me failed CTS profile when wanna pass SN, what is important for me.

Maybe, in future, I will try last thing(s), and if I find a solution to working v4a in nougat on OP3 - I tell you guys. Now, I use stock (& poor) music quality. Thanks anyway. Cheers.
[Magisk] Equi1:
I cant get Viper4Android found in the Magisk manager working. As you can see in the screenshot Viper says that it should be working but for some reason the processing status says no. Doesnt matter if its Spotify or any other music app, nothing works.

Any ideas to fix this? I have tried clearing caches, reinstalling and once even reseted my whole phone. My phone is OP3 running stock 7.0 rom.
[Magisk] darkeyes22:
If I flash magisk v10.2, will it remove Cyanogenmod's built-in root?
[Magisk] LucentBirch:
Have the new 10.2 and I still lost root randomly.
[Magisk] yochananmarqos:
No, you'll need to remove it first.

---------- Post added at 08:38 PM ---------- Previous post was at 08:38 PM ----------

I don't. Try a clean install of Magisk.
[Magisk] LucentBirch:
It is a clean install.
[Magisk] Didgeridoohan:
If you'd like any kind of help with that, or want to contribute to finding a possible problem with Magisk, provide some information... Device, ROM, what type of root, is Magisk Hide enabled, what modules do you have, any other kind of mods, and so on... And of course logs are always helpful.