yashsingh1/xdaforums huggingface dataset:
[Magisk] silvercat:
Can someone please confirm if it work on HTC 10 with Viper rom 2.6.1 and no custom kernel.. Everything is working fine except for I couldn't pass the safety net test
[Magisk] digitalhigh:
Just wanted to chime in:

Tested on Nexus 6P Running N Preview 5 - no luck. I get the initial Google logo, but the phone reboots at the boot animation and kicks to recovery.

Guessing it's the N Preview, as I did see it's supposed to work with X64. I know it's new and all, so I wouldn't dare ask for an ETA on such a thing, but I'll definitely keep an eye on this thread.

Awesome concept, btw. I thought of trying such a thing a little while ago, but didn't know near enough about the underpinnings of systemless to give it a crack. Many many kudos. :D
[Magisk] stangri:
http://xdaforums.com/showpost.php?p=68038091&postcount=34
[Magisk] harpin14789:
Thanks, didn't see that.
[Magisk] topjohnwu:
This project's main point is not Android Pay, that's just one of the side benefits :D.

The real value is in the Systemless Interface part. I'll create more examples to demonstrate the usage of it

To all that fails to use Android Pay:

Safety Net detects host file changes in system. You should use systemless host to make it work.

Here is a guide to setup systemless host to work with phh's root: http://xdaforums.com/showpost.php?p=65189125&postcount=259

Custom roms in general: It won't work out of box. I'll update the details in how the unmount root works soon (need to go to class today). Custom roms has to change their rooting method completely

So right now even if you flash Magisk it won't work.

Seems that some devices fail to boot after flashing Magisk. Right now the most complaint I got is on Samsung MM devices.

If you have free time and think you're experienced enough for testing, please contact me and I'll reach you in my free time.

Are you using a custom rom? It detects whether su exists in path. This means that your rom has system root installed.

The tiback thing is how phh's superuser work, nothing to be concerned.

Yes, but you need to ues the ".replace" function. I'll create more examples to show how to achieve them

Only if they don't change the ramdisk

My verity patch fails to patch it. I'll update this in the next update.

I do have a working build for DP5, but I haven't include them because the sepolicy is likely to be updated again in the official release.

BTW, phh's superuser doesn't support it yet :D (but I got it running)
[Magisk] harsh2193:
Im running a custom rom based on stock image with supersu 2.76, ad blocked hosts file and new sounds .etc. baked in and systemless xposed 86.2 installed by me. Do I have to revert to stock or is it enough to just uninstall supersu from app and uninstall xposed and then install magisk. Is it preferred to copy over the stock boot image over the current one (is it ok to do so, considering it is a stock based rom)? Please help guys
[Magisk] petbede:
Howdy TopJohnWu,

I got free time and I am experience enough to test your Magist on Samsung G900H running MM.

Please, do get back to me, thanks.

By the way, you are awesomatic :svetius:
[Magisk] tikizondo94:
Sure, Full wipe. Flash ROM and gapps. Then flash UnSU.zip (to remove SuperSU) . next in twrp go to advanced, then terminal. There's 2 commands to force systemless mode. I don't have the link but I'll find it for you. After those to commands go back and flash magisk then phh-magisk, then reboot. Make sure to download phh's superuser app from the play store.
[Magisk] Artim_96:
Don't use the SuperSU app! It's not supported! Follow exactly the guidelines provided in the OP or leave!

---------- Post added at 02:17 PM ---------- Previous post was at 02:15 PM ----------

Yes. Be glad that it works on 5.0+, originally systemless development was only meant for 6.0+, 5.0+ only for Samsung devices

---------- Post added at 02:18 PM ---------- Previous post was at 02:17 PM ----------

If you want to be able to unmount root, don't. Not possible.
[Magisk] AlphaKoi:
Here's how I got this to work using Android pay and the Pokemon go update......

1. Uninstall root&superuserSU

2. Open TWRP

3. Flash magisk uninstall

4. Flash magisk v6

5. Flash ppsuperuser

6. Reboot

7. Install ppsuperuser app

8. Install magisk app

Now you can toggle root off and it sticks when you want to use Android pay or play Pokemon go

Enjoy
[Magisk] Artim_96:
When you install the phh SuperUser zip it's rooted.
[Magisk] lancespahr:
:/ Guess that nullifies the point of systemless?
[Magisk] romskidd:
Ok, so, my Galaxy S7 Edge doesn't work with Magisk at all, everytime I install Magisk I have a bootloop after showing the first start screen. So, that mean, Galaxy S7 Edge bootloader is locked, Magisk will never work until it's solved I think.

So yeah, f... you niantic, really, f... you. I need my root more than pokemon go.
[Magisk] squazee:
Magisk v6 still isn't compatible with Moto X (2014) - I get kicked into the bootloader with the error "fall-through from normal boot". I did an un-root, total wipe and installed stock Moto 6.0 before flashing Magisk v6.

Just thought I'd mention this - other Motorola users have reported similar issues with earlier versions somewhere in this thread.

topjohnwu, if you need moto's boot.img to play with let us know!
[Magisk] gk1984:
---------- Post added at 02:18 PM ---------- Previous post was at 02:17 PM ----------

If you want to be able to unmount root, don't. Not possible.[/QUOTE]

I can toggle root just fine with phh su
[Magisk] westeight:
Automation of root using Magisk with Android Pay is already possible. See the Android Pay / Magisk thread. :)
[Magisk] :
I tried to test it on a Xperia Z3C.

Phone boots, but after a few second it freezes and restarts itself.
[Magisk] romskidd:
Exactly the same as me, probably locked bootloader I think. But you can unlock for Sony phone directly from Sony if i'm right. not like samsung.. u_u
[Magisk] havens1515:
Android Pay was just an example. What about other apps? There are a lot of other apps that require you to unroot when you use them. As I said, it would be nice to have a list in the Magisk app and auto unroot for that list.
[Magisk] Artim_96:
No. Point of systemless itself is to be able to have OTA updates because you can modify your device without changing anything in /system. Side effect was that Android Pay would keep working. Google updated SafetyNet, that was gone. That's why Magisk exists.
[Magisk] :
I'm unlocked and on custom kernel here.
[Magisk] lancespahr:
Alright, willing to give up Android pay. I'd rather have Xposed functionality haha. How would I switch?
[Magisk] romskidd:
I can toggle root just fine with phh su[/QUOTE]

How do you toggle root with phh ? In the app ? Can't find it..
[Magisk] Wlkchnbndgr:
I tot it! Big thanks. :laugh:
[Magisk] Artim_96:
You mean switch to non-Magisk XPosed?

Instructions are in the OP, but basically just reflash your ROM or at least it's stock boot.img.
[Magisk] gk1984:
How do you toggle root with phh ? In the app ? Can't find it..[/QUOTE]

The magisk manager app (in OP) let's you toggle. You need the phh su app from OP too. You have to grant the Magisk Manager app root permissions when it prompts. If you have any traces of Chainfire's SU, I don't think it'll work.
[Magisk] lancespahr:
No, switch to SuperSU from phh
[Magisk] romskidd:
Ah.. I was thinking you were saying it's possible to toggle root directly in the app and don't have it when you restart. Magisk doesn't work for my because my S7 Edge have a locked bootloader. :crying:
[Magisk] triggerlord:
Don't update to 13.2. It's broken.
[Magisk] logo20heli:
I had a similar problem with mounts. It turns out that MagiskSU now by default uses a mount namespace associated with the parent process. So only child processes will see the mount.

Git commit is here: https://github.com/topjohnwu/MagiskSU/commit/1bbf96a0a7a942798df58883a376b8024d0fae7f

The easiest way to fix this is to set MagiskSU to use the global mount namespace. There's a new setting in Magisk Manager called "mount namespace mode". Set it to "global namespace" and it should work properly.

There's also a new option to su called --mount-master that you can specify which does the same thing.

Hope this helps.
[Magisk] :
[MENTION=4470081]topjohnwu[/MENTION]

[MENTION=4667597]Didgeridoohan[/MENTION]

[MENTION=6429309]DodoGTA[/MENTION]

[MENTION=4899305]ashyx[/MENTION]

Multi-user is still not working as of 13.2.

Also, neither SuperSU nor Magisk 13 (betas and stable) are flashable in TWRP, and I can't provide the logs on this due to the device being shutdown a second after flashing has started. So, I still need v12 for TWRP, and SuperSU through Flashfire second, for multiuser.

I opened a github issue (#247) on the multiuser problem, it doesn't seem like it has gotten noticed. On it, my device's boot images were attached as well, as I had hope that by studying it, TWRP flashing for Samsung "2017 boot images" would also be fixed, along with the multiuser feature.

I'm a little disappointed that a "stable" version was released, when I and others reported issues during the beta stages, which most, if not all, are still persisting. I will also update issue #247 again, and soon. Hopefully, [MENTION=4470081]topjohnwu[/MENTION] will be on top of things soon.

Screenshot and log are from the owner profile, as the secondary user gets no root nor logging with the manager.

PS: this is just me guessing, but, see the line circled in the image ? (that is only generated when opening the manager in the second profile, so that's the error, definetly). Is that ">0" referring to the owner profile, though? 'Cause, if I am right, it should read ">10" and so on, for other profiles, like:

"su: request granted (XXXXXXX->10)"

*Xs = whatever they need to be for the different profiles.
[Magisk] shadavis08:
Well I updated to 13.2 then downgraded back to 13.1 and Magisk wouldn't pass safety net then I messed with it and it worked and then it stopped working and then works again?! WTH going on here LOL
[Magisk] Shtiff1:
Updated to v5.0.5 and v13.2.

NO issues here.

XT1254, 6.0.1, stock rom
[Magisk] BrikHaus:
Magisk Noob here. Please bare with me.

Running a Note 4 [SM-N910G] with Nameless Rom v4 (6.0.1), Rooted (SuperSU) and Xposed.

Yesterday I installed Magisk v13.1. I lost my root initially, but after re-flashing SuperSU in TWRP, both root & Magisk played nice. Installed the Xposed repo in Magisk, and everything seemed good. I was having an issue with an Xposed plugin, that I couldn't remove, so I did a complete, full system roll back restore using TWRP.

Cue Today, I downloaded the updated Magisk v13.2, and repeated the steps I did yesterday, however when I try to install Xposed from the Magisk repo, it downloads but fails to install. I've read a couple of posts that say 13.2 has issues. Is this the case here?

Questions; I've read several Magisk wiki / threads, but am not sure how I root through Magisk. Also, how do I obtain Safety Net? I've seen a universal patch, is that all I need to apply?

(My Boot rom is patched with SuperSU, so I believe I may have to restore a stock boot rom from official FW?)

Hope you guys can provide some great advice. :) Thanks in Advance!
[Magisk] teddy0209:
All you need is flash the stock/clean boot.img...

Flash magisk, then you'll be rooted with magisksu...

If you're using stock or other roms with stock props, you won't be needing the sn fix...
[Magisk] Garock:
need to uninstall first? eh guess I'll keep using 13.0 beta then
[Magisk] BeerReverend:
5.0.5 seems to have broken module downloads

On Nexus 6 stock 7.1.1
[Magisk] exodius48:
[MENTION=4470081]topjohnwu[/MENTION] Magisk Manager 5.0.5 always fc when try to install Viper4Android 2.5.0.5 module. Also Viper4Android 2.5.0.5 module can't be installed via twrp and Magisk Manager app.

Logcat attached.
[Magisk] BrikHaus:
Thanks Teddy0209. I will do that.

Given I'm on a custom ROM, I kind of figured SN was more for stock ROMs?

How do I tell if my custom ROM has stock props?
[Magisk] solifice:
+1
[Magisk] yorllin:
I am having problems after flashing magisk 13.2, the Google application stops. If uninstall magisk it works normal. i'm on last build of nitrogen os with nexus 6p.
[Magisk] Danny1976:
I am on Magisk 13.2 on app version 5.05. When I go to the menu and select Superuser the app closes or crashes. Has anyone experience this? Any solution?

Edit: clearing app cache and data fixed it.
[Magisk] anon1135:
anyone know why this happens? I tried installing from both internal and external
[Magisk] Luniz2k1:
Try reading the 2 lines above the red lines. It tells you what is wrong.
[Magisk] bobonit:
HTC U11 upgraded to 13.2 from 13.1 with no issues. HTC M8 HK wouldn't work on 13.1 but works great after installing 13.2. No errors during installation and passes safety net. Many thanks to Didgeridoohan, Jenslody, topjohnwu, Captain Throwback and whoever else worked on this.
[Magisk] teddy0209:
You can compare it with stock rom, make your own props module... Or you can simply just use the sn fix module...
[Magisk] Didgeridoohan:
Magisk v13+ isn't compatible with SuperSU anymore. You'll have to do a full unroot and install Magisk again.

Yes, it's a known issue that's being worked on. Temporary solution is to disable MagiskHide.

Upload your recovery log from the recovery installation.

---------- Post added at 05:55 ---------- Previous post was at 05:50 ----------

I'll see if I can do some testing...
[Magisk] anon1135:
ty. think I installed the older one fine so was wondering why now
[Magisk] jenslody:
In your prior post you wrote, that you use xposed.

In this case you will not be able to pass safety-net, neither with pure MagiskHide nor with safety-net-fix.
[Magisk] solifice:
Magisk 13.2 shame in you
[Magisk] heri1978:
Works fine.....just Developer option gone after installation, need to tap build number again, others issue cannot download update from repos, download manager crash, so i will attempt others method reinstalling magisk 13.2 soon.
[Magisk] y2kbugleung:
I have tried flashing 13.1 on Pixel-C but it fails.

13.2 could be flashed, but Pixel-C cannot boot into system anymore. A system reboot would boot into recovery.

I have flashed July official ROM before flashing Magisk.

Without flashing Magisk, it could boot into ths system.

Does anyone have any idea?
[Magisk] cbendixe84:
Dunno if is fixable or not, but I'm on Tipsy rom for OnePlus 3, and with version 13.1 and 13.2 the developmental settings disappear after flashing
[Magisk] AlxMAX:
Call me paranoid, but in my opinion it would be useful to have the official check sums of the Magisk manager and the flashable Magisk zip. This way we could know your files weren't tampered with.
[Magisk] Didgeridoohan:
¿Que? Details, please...

Could you post a recovery log from the installation? It might (or not) show something...

About developer options, see below. Good thing it worked by tapping the build number again... The Downloads crash seems widespread. I'm sure it'll be looked at as soon as possible.

That's a result of MagiskHide setting ro.build.type to "user"... No workaround as of now, except to disable MagiskHide whenever you need to enter Developer options. You could try tapping the build number 7 times, but it might not work.
[Magisk] nathanchance:
There is also this commit ROM developers can add: https://github.com/DirtyUnicorns/an...mmit/5a647d96432abcb1276fab695600c5233e88b8d3
[Magisk] y2kbugleung:
Please take a look.

https://pastebin.com/g6Qrp5p0
[Magisk] Didgeridoohan:
Still... Details, please...

I see "cat: xwrite: Broken pipe" at the end of the log. What's the result? And please be as detailed as possible (device, ROM, kernel, what works, what doesn't, whatever you feel might be useful, etc) so we don't have to do this one-sentence thing back and fort all day long...
[Magisk] shabtab:
Cannot download or install modules in 13.2
[Magisk] y2kbugleung:
Pixel-C, July stock ROM stock kernel, dirty flash from

June stock rom stock kernel with Magisk 13 installed.

After dirty flash to July ROM, boot-up works.

I then flash TWRP and Magisk 13.2, and it does not show any error.

The recovery log is taken at this stage.

Choosing reboot to system, it reboots to recovery again.

Power-off and restart boots into recovery as well.

There is no way to go back to system.
[Magisk] Albert Poon:
13.2 F/C right after the download finished in Downloads. But I can manually install the module in Modules by using the + button and open the downloaded zip.
[Magisk] kessaras:
[MENTION=4470081]topjohnwu[/MENTION], hi :) is there somewhere i can go to help with magisk translation in Greek ?
[Magisk] jenslody:
The "cat: xwrite: Broken pipe" is because of writing from /dev/zero until dd stops with "no space left ..."-massage, which is piped to nirvana (to avoid confusion).

Unfortunately the piped cat-command still prints out the error-message. Should be safe to ignore.

What I saw before in other recover-logs (if I remember correctly) is the following:

Installing zip file '/sideload/package.zip'
I:Update binary zip
I:Zip does not contain SELinux file_contexts file in its root.
I:Legacy property environment initialized.
Segmentation fault
Archive: /sideload/package.zip
inflating: META-INF/MANIFEST.

Te segfault seems to happen before inflating the zip, so it is probably a twrp issue.

Whether it's related or not I don't know, but it's a t least suspicious.
[Magisk] Didgeridoohan:
I'm so sorry... :crying: There's a lot of posting back and forth and I'm not sure I'm quite awake yet (didn't have much sleep last night). I mistook you for another user. :eek: You had already posted those details... Again, I'm so sorry. :laugh:

The always amazing [MENTION=8340552]jenslody[/MENTION] have a great explenation of the issue right here:

You are awesome! When I saw "cat: xwrite: Broken pipe" I was looking for that segfault line, but I just couldn't see it. :laugh:
[Magisk] y2kbugleung:
It is understandable. Thank you for answering our questions.

I don't quite understand. Does it mean without TWRP being updated, Magisk v13.2 won't work on Pixel-C? Or the "broken pipe" is just an ignorable error?
[Magisk] [Lemmy]:
I just updated magisk manager, and after that magisk, and now my device fails safetynet with "no internet connection"... but my internet connection works just fine. Any ideas?

Edit: Samsung Galaxy Tab S2, Sm-T719N, Stock Samsung Android 7.0

Edit 2: strangely enough my S6 edge is *not* showing this, there everything works just fine...
[Magisk] shabtab:
I can't do that either going back to 13.1 is a better idea so.
[Magisk] Didgeridoohan:
Honestly, I have no idea... That's a bit above my skill level. :laugh: I can try to do some investigations though.
[Magisk] y2kbugleung:
Thanks anyway ;)
[Magisk] RashaMatt:
Recovery.log from failed Magisk 13.2 installation

Device: Samsung Galaxy Tab S2 SM-T710

OS: Stock Samsung Android 7.0

I tried to install Magisk 13.2 (via TWRP) many times, even on a clean install (wiped data) - always the same error:

- Mounting /data/magisk.img to /magisk
Cannot mount image!
! Magisk image mount failed...
Updater process ended with ERROR: 1
[Magisk] tanago:
not working for me

just like all other 13.* versions where I posted logs,

MM: not rooted, magisk not installed

su is missing too
[Magisk] [Lemmy]:
...after a few reboots now both my devices *pass* safetynet. I don't really have to understand this.
[Magisk] Aria.A97:
Both of the attached modules work fine individually, however when both are installed phone will stuck at splash screen with Magisk 13, 13.1 & 13.2.

I've been playing with this for a while, I can't find any reason for this incompatibility. Sqlite module only uses a late start service and ViPER is topjohnwu's ViPER port (uses post-fs). However both work fine with Magisk 12.0

Any help is appreciated. I'm using Galaxy S6 Nougat (Stock boot.img obviously)
[Magisk] xXxNeXuSxXx:
Installed latest magisk for the first time on RN3 Kenzo LOS ... Tried to install v4a and other modules but as soon as download is finished the app force closes.... Also when trying to manually add the module it says this is not a magisk module....

Any solution?
[Magisk] Yusei:
I can't download, but it let me install manually.

I've an Oneplus 3T.

Any help?
[Magisk] McHerold:
wohoo, that helped me out, thanks :good:
[Magisk] lebaud07:
Hi,

Same error here with magisk 13,2 : application crashes when downloading a new module.

However, the installed module seems to work (Android Mic fix), but I'm unable to upgrade it.

Thanks in advance
[Magisk] Codebucket:
Mounting folders works fine when using inherited mountspace, so no need to use "--mount-master" or global namespace ;)
[Magisk] xXxNeXuSxXx:
Yup... on magisk 13.1 there was no such force close.... hope this will be fixed soon
[Magisk] suniluv:
Facing the same issue, can someone clarify whether the mods downloaded can be flashed through twrp ?

Thanks
[Magisk] Yusei:
U can still install manual trough Magisk manager if you find the zip file elsewhere.

I'm trying to find the Oneplus 3T wifi bonding channel without success. :/
[Magisk] suniluv:
Tried to install them manually,

It shows that the mod is not Magisk mod
[Magisk] Yusei:
Corrupted downloads.

You've to download the mod from another source other than Magisk Manager.
[Magisk] suniluv:
Tried to install BusyBox downloaded from other source, still getting installation error
[Magisk] tejas_kesaria:
--del --
[Magisk] Yusei:
Both manually downloaded and installed.
[Magisk] xXxNeXuSxXx:
Even manual flashing through magisk doesn't work.... it throws error that this is not a magisk module
[Magisk] McHerold:
Same here
[Magisk] Yusei:
Don't know then.

Both of my modules were downloaded outside of Magisk Manager and I managed to install them without any issues.
[Magisk] suniluv:
I don't know how you managed to install them, mine keeps on showing installation error
[Magisk] TheAtheistOtaku:
can also confirm not being able to install modules via magisk app or zip, running latest lineage on a nexus 6p
[Magisk] vegetaleb:
I loosed safetynet with 13.1 update, now I have the 13.2 notification to download, what is the best way to update so safetynet will work again?

Automatically from the manager or manually from TWRP?
[Magisk] Yusei:
Btw I'm running PA with Magisk 13.2 and Magisk Manager 5.5
[Magisk] MrKaon:
Using latest Magisk all OK with SafetyNet all passed also Google Play says device is certificated but I can't find Netflix on Play Store?

any help guys?

---------- Post added at 10:22 AM ---------- Previous post was at 10:21 AM ----------

I've updated within Manager all OK :good:
[Magisk] Folie17:
Hi!

I've updated Magisk to v. 13.1 and I had a lot of problems. I've just updated to v. 13.2 e still have the same problems: a lot of apps crash on the opening (Twitter, Amazon, Google rewards and more...). With v. 12.0 all worked.

I'm on AOSP 7.1.2.
[Magisk] vegetaleb:
Even if safetynet didn't pass on 13.1?

I don't want that 13.2 inherit same ''bug''
[Magisk] DodoGTA:
What's your device?
[Magisk] xXxNeXuSxXx:
have you tried to delete play services data and all?
[Magisk] Folie17:
OnePlus 2
[Magisk] Doe.it:
I would like to report one issue:

- I have an encrypted android phone (sony z5 compact)

- I can't decrypt data partition with TWRP (there is no support for this yet)

- I've tried Magisk 13.1 and last 13.2, but I can't install Magisk. The log says everything is fine, but once rebooted the phone Magisk Manager says no Magisk is installed (this problem doesn't happen with unecrypted phone or with other devices where TWRP can decrypt data partition)

Is it possible to install Magisk on encrypted phone without being able to decrypt data partition?

I can successfully install SuperSU in this codition, shouldn't Magisk being able to do this too?

If so... am I missing any step to follow?
[Magisk] DodoGTA:
SuperSU uses /cache partition in this case

But Magisk removed /cache workaround
[Magisk] Daviteusz:
Magisk Manager can not download or install modules because the application is stopped

Magisk v13.2

MIUI 8 by xiaomi.eu 7.6.10 Android 6.0.1

Xiaomi Redmi Note 3 Snapdragon
[Magisk] rogirogi:
Why does Magiskmanager say "Log is empty"?
[Magisk] DodoGTA:
I found the root cause of this problem
[Magisk] piri_vm:
I have the same problem.
[Magisk] suniluv:
Finally, able to install am3d (side loaded) !