yashsingh1/xdaforums huggingface dataset:
[Magisk] samhhmobil:
Just one question more (please take my apologies, if it was discussed earlier)...

I did switch to a Xiaomi Mi10T-lite (gauguin) a few weeks ago. The installed OS is LineageOS19.1 with MindTheGapps.

Installing Magisk 24300 (and M-App 24300) did work without any trouble.

Magisk-App is hidden, Shamiko and HideMagiskProps work well. So (nearly) everything is, as it should.

But all the time LOS19.1 is updated, the Magisk-addon.d-script is NOT working.

The workaround is to flash Magisk 24.3 zip again via adb sideload immediately after the LOS-update.

But... maybe there will be a "clean" solution, that the addon.d-script will work even for Xiaomi gauguin?

If not, I can live with this workaround.

Thanks a lot,

samhhmobil
[Magisk] Slluxx:
Ah, thanks for the heads up!

Uh, i dont actually know but i find it more secure to wait for it yourself instead of relying on the flash command. Other commands might not wait for the phone/fastboot and my solution is "one size fits all" basically.

Well, the name suggests its for pixel phones and on a quick glance ive seen some google specific code (not looked what it actually does). I have a Redmi Note 10 Pro tho and my script will work on basically all phones.

Also, its written as a class for other devs to use in their scripts and only secondary as a standalone application, with minimal requirements.

While i am sure your tool works far better than mine, your readme is so intimidating that even when i knew it existed beforehand, i probably wouldnt have used it.

Suggestion for your UI: Use Eel. A super simple lib for making your UI in html/css/js. Its compatible with pyInstaller so you can also generate mac and linux binarys.
[Magisk] zgfg:
Btw, downloading of the py script would be much easier if you publish a Release 👍
[Magisk] Slluxx:
Didnt do it on purpose cause there are still some things to flesh out 😅

Will do very soon though. Ill keep you updated :)
[Magisk] badabing2003:
I only have Pixel phones and have only tested it on Pixel phones hence why it is called and advertised as such, however at the core of it, all it is , is a GUI layer on top of adb / fastboot commands, everything so practically it should work for other phones, extracting boot.img, transferring to the phone, patching with magisk, and pulling back to flash is definitely not Google exclusive.

That's a good thing, I'll take a look at it when you publish.

:( I tried to be thorough, not everyone is a developer or very technical, but I'm surprised that it intimidated someone technical as yourself, what suggestions would you advise to make it less intimidating without losing critical details?

Thanks for the info, I didn't know, I will look at it, I wish I knew about it sooner, at this stage of development, a total UI rewrite without breaking anything would require a major time investment.
[Magisk] pndwal:
Seems there's issues with addon.d in Android 12, especially w/ LOS recovery (can't decrypt)... Read back this saga for insight, GitHub issue links w/ comments from @osm0sis etc:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86935631

👀 PW
[Magisk] Slluxx:
Ah okay. You even wrote it in the readme i just saw it. Its kind of marketed as Pixel software with an asterix that it might/should work on other phones too. You should maybe rephrase that to attract more potential users

Its easy to understand, yes but it has so many features outside of flashing that the readme is just huge and packed with info. In my opinion you should just put the most basic stuff in the readme and write the rest into githubs wiki pages (and refer to it from the readme). Also, since you have somany features packed in your tool, wouldnt it make more sense to call it "Toolbox" instead of flasher? Everything that shows info or has to do with magisk (beyond patching and flashing) is out of scope for a "flasher" tool imo.

Yeah, i know that struggle. Thats why i now tend to write everything in classes managed by a greater application, so something as a UI layer can easily be added, switched or removed.

Its not a perfect readme / wiki by any means but check out this project of mine. Thats how i personally like to organize things
[Magisk] razrielsch:
Is Magisk able to hide TRWP ? My Applistdetector says Abnormal environment TRWP detected.
[Magisk] zgfg:
Magisk does not hide anything, it's not the purpose of Magisk

And it's not about detecting do you really have custom Recovery - it's as primitive as finding of a folder named TWRP on the Internal memory

You should remove that TWRP folder or just rename it - it's been many times mentioned here, I have it renamed to TWRP.bak and it's good for both: TWRP (3.6) still finds the renamed folder but detector does no more complain
[Magisk] samhhmobil:
Thanks a lot.

So it seems, there is no fix yet? (Upto LOS18.1 it DID work,... but for me on other devices).

So I'll live with flashing Magisk again immediately after each update.

Thanks again,

samhhmobil
[Magisk] pascal009:
Greetings to all,

A new version of Magisk (25.0) has been released recently

Release Magisk v25.0 · topjohnwu/Magisk

Another major release! A lot of the changes aren't visible at the surface, but v25 is actually a really substantial upgrade! MagiskInit Rewrite A significant portion of magiskinit (the critical sof...

github.com

In the words of its developer it is "Another major release! A lot of the changes aren't visible at the surface, but v25 is actually a really substantial upgrade!"

I have an Amazon Fire HD 10 7th Gen (giza) with TWRP installed and rooted with Magisk 24.3

Can one of the experts here on the forum tell me whether it is safe to flash the new version (25.0) over the previous one (24.3) on my tablet?

Your opinion is greatly appreciated.

pascal009
[Magisk] huskydg:
Custom Magisk fork by HuskyDG. Sync with official Magisk adding back hiding functionality and more advanced hiding such as hide zygisk. Support hiding for isolated process and app zygote (for Android 10 and bellow).

GitHub - HuskyDG/magisk-files

Contribute to HuskyDG/magisk-files development by creating an account on GitHub.

github.com
[Magisk] Radulescubg:
I wasn't able to fix my magisk, and momo would show that the environment is broken... I said fk it, did a full wipe, reinstalled my rom, and that was that.

I did find something weird tho.

The combination of magisk 25(25000) and Shamiko 0.5.0 breaks the ING banking app.

Also, momo detects zygisk.

In 24.3 with an older Shamiko, it was fine. So I guess either magisk or Shamiko changed something and the banking app, revolut and outlook are not happy about that. Just a random thing I noticed

Also. Anyone knows a module that blocks access to the applist? So I don't have to hide and unhide the Magisk for every test I make?
[Magisk] zzz2002:
Thank you! I already knew about renaming the TWRP folder, but I wound up having to do it after each use of TWRP. But your tip to call it ...bac solves this problem. Once again thank you!!
[Magisk] J.Michael:
From the name, I would guess that Hide My Applist does what you want.
[Magisk] ipdev:
@Slluxx

Since you are basing your script for TWRP..

If you did not find this yet..

TeamWin - [twrp.me] - [WebSite] - TWRP Commandline Guide

twrp

Spoiler content hidden.

Example using adb.

Start TWRP sideload on the device.

adb shell twrp sideload

Using the TWRP installer to install a file on the device.

adb shell twrp install /path/to/file.zip​

Cheers. :cowboy:
[Magisk] pndwal:
I don't use addon.d now, but from reading/memory I think it's broken in LOS recovery due to no decryption... If you install / retain TWRP I'm guessing it should work again, but I may have missed something... So many prerequisites for working addon.d... PW
[Magisk] ipdev:
No difference that I noticed. 🙃

Same results with or without it enabled in the denylist.

I still do not remember why I originally started removing that process.

With Shamiko.

Sometimes Momo found Zygisk sometimes not.

There was no rhyme or reason I could come up with to get Zygisk found at will.

When I thought I had it..

I would repeat the same steps and get the same or opposite results.​

With DenylistUnmount.

Momo never found Zygisk.

Repeating the same steps that I used with Shamiko.​

Cheers. :cowboy:

B.
[Magisk] samhhmobil:
Thanks for your suggestions.

Nevertheless even TWRP cannot decrypt with A12 (LOS19.1, but even with MIUI13), tests with different other devices did show me the same even with Xperia-devices, running A12.

And TWRP does not work clean on this particular Xiaomi device, all the time it says: no OS installed, but of course it is (and works).

samhhmobil
[Magisk] zgfg:
TWRP generally does not support storage encryption on A12 (and generally, TWRP for A12 is not released yet) That should be a well known fact for all devices - you can read about on the official TWRP.me site
[Magisk] samhhmobil:
Yes, I know. Of course. It is as it is.

So TWRP (as suggested by pndwal) is even not the way to circumvent the problem with addon.d-script not working (due to missing decryption).

BTW, with Xperia XA2(pioneer) even LOS19.1(A12), LOS-recovery, the addon.d-script works, yeah! But... that's an A/B-device, the update is done in the background of the running (and decrypted) OS-environment, and not in recovery.

No workaround for A-only-devices with A12 yet, right? Just only flash Magisk again after update, right?

Thanks, samhhmobil
[Magisk] Captain_Throwback:
It can be used on any device on which you can install Magisk. It's just a Magisk module - there's nothing HTC-specific about it.

You'll probably want to check the Magisk log and see if it's actually changing anything, though.
[Magisk] negroxxx:
you step safetynet with Xposed?

use magisk v8 + supersu phh 259 ???
[Magisk] android_htc:
Hi guys,

Anyone have this working on a galaxy Note 4?

Installed Magisk and superuser module. Unfortunately, safety net checks fail, even with magisk hide selected. Note that safety net checks pass when I remove Magisk.

Any suggestions will be much appreciated.
[Magisk] Captain_Throwback:
You tried xSetProp module, in case bootloader status is detected?
[Magisk] android_htc:
Thanks for the suggestion... Unfortunately, it still fails [emoji26]
[Magisk] android_htc:
Flashed a modified kernel, RamKernel v1, reflashed magisk and safety net now passes :) Android pay works but Barclaycard detects root.
[Magisk] Captain_Throwback:
There's nothing in that log for xSetProp, so it doesn't appear to be running. That's a problem.

Did you add the Barclaycard app to the magiskhide list?
[Magisk] android_htc:
Hi, see log below:

xSetProp by nkk71 - zip by Captain_Throwback

ro.boot.verifiedbootstate prop does not exist. Checking next prop...

ro.boot.flash.locked prop does not exist. Checking next prop...

ro.boot.veritymode prop does not exist. xSetProp complete

---------- Post added at 03:41 PM ---------- Previous post was at 03:39 PM ----------

I've used automagisk and selected Barclaycard. Is there another method? Thanks
[Magisk] Captain_Throwback:
So according to that log, you don' t need xSetProp ;).

AutoMagisk doesn't do anything with the latest version if Magisk. You need to read the Official Magisk release thread, especially the part about setting up magiskhide.
[Magisk] CryMasK:
Actually, is RootSwitch.

(Magisk & phh' Superuser help me get root access and hide root status)

I can't really say I pass safety net with Xposed,

but when I use RootSwitch instead of Xposed Installer to toggle off my Xposed, SOME module still work, and also can pass safety net(Green screen)
[Magisk] android_htc:
[MENTION=1162986]Captain_Throwback[/MENTION], added Barclaycard to the magiskhide list.. and it's working! Thanks
[Magisk] negroxxx:
You can show screenshot of rootswitch and Xposed?
[Magisk] desztan:
May I know how do you add into magiskhide list?
[Magisk] digitalhigh:
Light a candle and pray to the pagan gods of READ THE OP BEFORE ASKING QUESTIONS!!!!
[Magisk] android_htc:
See post #5214
[Magisk] Captain_Throwback:
You don't need both of those entries there. Did you read the instructions?

EDIT: I don't see it mentioned there, so I apologize. But you only need to include the package name - and partial matches work too, so "com.barclays.bca" would be sufficient.
[Magisk] android_htc:
Yes, first one did not work...
[Magisk] Captain_Throwback:
You rebooted after setting it? Because if the first one didn't work, then [MENTION=4470081]topjohnwu[/MENTION] would need to look into it. Can you remove the entry with the -1, reboot and confirm the app is detecting root? Thanks!
[Magisk] android_htc:
I did not reboot... and it seems reboot is not required as the settings are effective straight away.

Test results:

With -1 entry - root detected

Without -1 entry - works fine

Thanks
[Magisk] Captain_Throwback:
Right, because the -1 isn't part of the package name. Thanks for the detailed report.
[Magisk] eXtremeDevil:
Hi all! I'm using Momo 4.2.0 and it shows "Found code injection", anyone knows where that may be coming from? With Momo 4.1.0 that message did not appear.

Thanks!
[Magisk] zgfg:
Don't know. I have A/B Xiaomi and I had restrained from updating to MIUI 13/A12 - partially also bcs of TWRP
[Magisk] shadowstep:
This is from the Magisk Alpha's Telegram Channel (translated in English):
[Magisk] pndwal:
Seems that way; hadn't considered encryption not working in TWRP w/ Android 12, although I know it's not (properly) A12 compatible yet... Seem it may work once Dee's Troy and team get catch up with A12 implementation...

Addon.d won't work at all on LOS recovery w/ current no-decryption policy, but seems it should work with TWRP if decryption is supported/working.

Different story for A/B devices. Seems addon.d-v2 (for A/B seamless updates) will work from a booted OTA, so guessing that should work in A12. May also work using TWRP (nb. not LOS recovery) but may still only be supported in the _9 branch...

Of course, addon.d is not supported from Magisk initially installed from App; - The script is (currently) only added during traditional zip-installer setup from custom recovery... PW
[Magisk] eXtremeDevil:
Thanks!
[Magisk] zgfg:
Btw, does your script support A/B devices?

At least, you are flashing:

fastboot flash boot ...

where fastboot knows what's the currently active slot

Also, I see you are enforcing:

KEEPVERITY

KEEPFORCEENCRYPT

Do you really have a device with vbmeta included to boot partition and do you really need them

Btw, both ipdev and me have accounts on Github

PS: Since I have much more often the case that I need to update Magisk (Canary) I made myself a shell script (to be executed from Terminal or even easier, I execute the script directly from MiXPlorer).

Previous version of Magisk must be installed and Magisk app must be updated:

Etc/update_Msgisk.sh at main · zgfg/Etc

Et cetera. Contribute to zgfg/Etc development by creating an account on GitHub.

github.com

It does:

- disk-dump boot.img from the currently active slot (it supports A only and A/B devices, ie boot, boot_a or boot_b)

- patch the boot.img

- flash it back

- reboot

Basically what you get by Direct install but it's also based on invoking instead that /data/adb/magisk/boot_patch.sh script

and as result I have boot.img and patched_boot.img in Download (if I want to save or inspect)
[Magisk] Slluxx:
A/B devices? (ive seen this term but didnt google it yet)

it just flashes the first available phone.

(i made this script mainly for me and i only have one inserted at a time)

I enforced them due to this comment:

In his pixel flasher script they are hardcoded too so idk. I tried without and with them and my phone works absolutly fine so i just decided to commit it like that for now (its not released yet anyway so its fine).

How would i figure out if my or any other phone needs it? Obviously i can have it set manually but i want to avoid that if possible.

I like that but again, i made this script mainly for me and i **must** update via sideloading. since i will always run my script from a pc and since i am not even trying to make a "purely on phone" solution for this, i can just as well extract the img from the update and work with that from there.
[Magisk] zgfg:
Magisk GitHub, Installation instructions
[Magisk] Slluxx:
i should be more clear in what i text. i mean i dont want to know by looking it up by a resource or in my phone by some visual cue.

i asked because i wanted to know if there is some build.prop entry or something that i can use to determine it in an automated way

EDIT: okay, VBMETA can be checked as stated by magisk github docs

I am still a little confused on when to export KEEPVERITY and KEEPFORCEENCRYPT and how VBMETA is related to that. Ive looked in your script and you are never exporting variables.
[Magisk] Shadeclan:
I own Motorola phones and have had some experience unlocking the bootloader, modding and rooting them. I recently bought a newer Motorola phone with no available custom ROM or custom recovery - the Moto G Play (2021). I only just discovered that Motorola phones actually DO come with a stock recovery. From the bootloader, choose "recovery mode", wait for the dead android ("no command"), hold down the power button and press volume up - there it is! There's even an "Apply update from ADB" which enables ADB Sideload.

However, when I tried installing Magisk via the stock recovery, I got a "signature verification failed" error - not exactly sure what the recovery is looking for but it won't permit me to do the install. I tried installing v24.3 and v25 with similar results. Perhaps it's looking for a Motorola signature verification file? Or perhaps custom recoveries are built because stock recoveries will not allow the installation of anything not Motorola?
[Magisk] martyfender:
Yes, stock recoveries do not allow the installation of magisk. If you can extract a stock boot.img from the rom, if it is available, you can patch it in the magisk app and flash it in bootloader mode with fastboot.

You may be able to find info here, I have not read:

https://xdaforums.com/t/moto-g-play-2021-guamna-stock-firmware.4227229/
[Magisk] zgfg:
I made the script (also) for myself. My phone has separate vbmeta partition hence exporting the variables when patching boot.img does not apply. I also never patched vbmeta - I don't need all that at all.

I asked you since I was surprised do you really need in your script, for your Xiaomi
[Magisk] Timmmmaaahh!:
Devices that have two slots for the OS to reside on. It basically prevents corrupted updates. When an OTA comes in it installs on the inactive slot, upon reboot it then switches to the inactive slot. When this switch fails for some reason it just switches back to the other slot. Update failed but at least the system still works. It's kinda like dual boot but with two identical systems.
[Magisk] zgfg:
A/B devices come with boot_a, boot_b, etc. Specially SAR (System as root) partition(s) are duplicated. Ofc, Data and Internal mem are not duplicated

While running Android from the currently active slot, OTA can update the other, inactive slot.

Upon OTA and reboot, the updated slot becomes active and the other one can now be updated.

That way OTA is smoother, user just needs to shortly reboot

You can check whether you have A/B device and which slot is currently active by:

getprop ro.build.ab_update

getprop ro.boot.slot_suffix
[Magisk] Shadeclan:
I have installed Motorola Recovery on my Windows laptop, which grabs the stock ROM directly from Motorola, but thank you for the link. I have used Magisk to modify the stock boot image but the last time I tried that, the phone went into a bootloader loop, although last time I didn't use Magisk v25. I'll let you know what happens.

Edit 20220615 08:42EST - I flashed the boot partition with the Magisk-modified stock image and it worked this time. All is well.
[Magisk] H4X0R46:
So I'm just seeing that v25.0 was released. I wanted to ask if this new version would break zackptg5's decrypt zip? The description on Magisk's GitHub made me think it might 🤔
[Magisk] rhinodino:
Hi

I wanted to ask something. I currently have magisk zip installed version 23.0 and have the app installed as 25.0

When I open the magisk app it prompts me with a message "requires additonal setup", With it essentially giving me the magisk 25 zip to flash. Now if I flash this, it causes a boot loop after I flash andf then reboot, I can get out the boot loop, by going into download mode then going into recovery (for some reason I can't go into recovery as I am unable to turn my phone off unless I drain it completly of the battery) and then flash the uninstaller to uninstall magisk, I will then proceed to install the magisk apk and then it will still say I have magisk 23.0 zip installed and 25.0 apk installed.

How can I fully update to 25.0 on both the apk version and the zip install version without having it boot loop on me?

Phone: Samsung A50

Rom: Custom Rom: [ROM][OneUI 3.1][A50] Freshfor samsung A50
[Magisk] pndwal:
If you have have any hidden app, uninstall it and use only full app while updating as stub app is notorious for causing this kind of issue on updating... May work less than ½ the time... You can Hide the Magisk app again after update...

With root, take direct update from full installed 25.0 app (not stub).

Without root, patch AP and flash w/ other binaries per official Magisk Installation Instruction for Samsung initial setup...

I see A50 launched with Android 9... Please say if this is a Ramdisk = No device (A-only legacy SAR) w/ Magisk in recovery as there may be a different (known) issue... PW
[Magisk] rhinodino:
What do you mean by hidden app? I downloaded the apk from the official github repository and used the zip file which is downloaded within the apk itself.

What do you mean by stub as well?

As well as my custom room is prerooted, so what does flash AP mean as well as flashing other binaries.

How would I go about checking Ramdisk = No device? Assume this is done in recovery
[Magisk] pndwal:
Mean if you've used Magisk App, settings option 'Hide the Magisk app' which removes the full Magisk app and replaces it with an 'stub' app (to subvert detection by other apps) whose data is populated with the Magisk binary. This is obfuscated w/ random package name and custom app name chosen by user...

Officially provided empty .apk (stub app) for hiding Magisk App, see above.

You didn't say ROM was pre-rooted. This is not a recommended way to implement Magisk and can cause a number of issues... Updating can be fraught or impossible depending on Devs implementation... In some cases such ROMs can be unrooted or Magisk root updated easily, in others not... A Magisk App installed as a system app (systemised) won't behave as expected and this mode may also account for errors updating... The ROM dev / forum may offer advice, but prerooted ROMs fall outside the scope of normal Magisk use and it's behaviour will be unpredictable.

Patching / flashing AP binary is explained in John's Magisk Installation Instruction, Samsung (System-as-root) section, which you should familiarise yourself with...

I'm guessing your customised OneUI 3.1 uses standard Samsung binary packages including ap.tar. If not, you may be best to get advice in forum(s) for that ROM.

It's on Home page of Magisk App... 🙂 PW
[Magisk] rhinodino:
Thank you so much for this, I'll go to the custom rom thread and ask for support there, see if anyone else is having issues with this as it is a pre rooted custom rom! Thanks!
[Magisk] Spaceoid:
Is it normal behaviour that my Magisk app does not tell me to update to v25? :) Seems I can only do it manually through downloading the app from github.
[Magisk] zgfg:
Settings, Update Channel must be on Canary (Beta or Debug), not on Stable - since Stable is still on v24.3

Also, if you have StableMagisk app installed, you don't have Canary and Debug options in Update Channel settings

Make sure you know do you want to stay on Stable, or to switch eg to Canary
[Magisk] J.Michael:
All this time, when someone says "stub", I thought it referred to what Magisk injects if, at boot, Magisk does not detect a Magisk Manager app. I also thought that "Hide the Manager app" renamed / rejiggered a copy of the *full* Manager app.