yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Many factors...

- If using TWRP, none are yet properly A12 compatible...

- LOS recovery can't decrypt /data

https://github.com/topjohnwu/Magisk/issues/3820#issuecomment-857241389

- For A/B devices (i.e. addon.d-v2) the OTA must be run through the system settings updater app rather than LOS recovery

https://github.com/topjohnwu/Magisk/issues/3820#issuecomment-857094000

- A/B (addon.d-v2) when using TWRP may only work in certain branches (note the date here) https://github.com/topjohnwu/Magisk/issues/3820#issuecomment-856937113

Nb. @osm0sis is the resident expert on all things addon.d (and designer of much of it) here.

Hope this helps. 🙂 PW
[Magisk] meric57:
Hello, this weekend I followed a tutorial to install TRWP see topic on XDA you have to install with trwp.apk.

I got the concern that lineage 19 under android 12 bug no play store stops and other bugs.

see these 2 links

https://xdaforums.com/t/recovery-un...y-s10-exynos-g970f-g973f-g975f-g977b.3924856/

An early build of LineageOS 19.0 based on Android 12 is available for the Exynos Galaxy S10 series

An early build of LineageOS 19.0 based on Android 12 is now available for the Exynos Galaxy S10 series. Download links in the post.

www.xda-developers.com
[Magisk] rogers11:
Thanks for the hints. The device isn't A/B, TWRP isn't installed. I've used the inbuild LOS updater which rebooted into LOS recovery, installed the update, reinstalled GApps, but not Magisk. All addon.d scripts are in the same directory and have the same permissions.
[Magisk] zgfg:
Since that is about TWRP and custom ROM for your particular device, I think it should have been posted to the subforum for your phone, to the threads about your LOS (and TWRP), to the corresponding TG or Discord channels (whatever they have for support) and/or directly to those thread(s) you are quoting

Btw, as you wrote, these are some early versions of LOS 19 and TWRP for A12, hence all kinds of problems might be expected
[Magisk] kramer04:
Hello

Samsung Note9

android sotck rom 10

I followed instruction to install Magisk canary from here

Installation

The Magic Mask for Android

topjohnwu.github.io

Are there some informations to know before if i want to install TWRP recovery ?
[Magisk] zgfg:
Probably. I'd first look and ask where the TWRP is coming from.

If their author(s).provide guides like TJW does for his Magisk (don't expect that TJW or support channels for Magisk could be of much help for TWRP on the particular phone) - on some TG channel, GitHub or something.

Or in the Sammy Note 9 subforum - for A10 it's not something new and there must be guides or how-to threads/posts
[Magisk] gribna:
Hello!

I've updated to Magisk 24.3 via TWRP and now my mobile internet isn't working. Mobile data is "on" but phone Settings warns me that mobile data is actually off.

Is it a known issue? I've scoured the internet for any similar issue and came up with nothing.
[Magisk] zgfg:
Do you really think your problem is common for all phones (in that case nobody of us would use Magisk v24.3), or do we know by telepathy what is your phone, ROM, etc

Problems like that are generally rare and very specific - only if you provide the relevant info somebody who is familiar with the phone, ROM type and so could provide you some help
[Magisk] gribna:
OnePlus 5

LineageOS 17.1

TWRP 3.5.0_0-9
[Magisk] pndwal:
Could be some anomaly w/ LOS recovery, eg hidden comment after this one:

https://github.com/topjohnwu/Magisk/issues/3820#issuecomment-857115284

Wondering, you didn't ever need to uninstall a 'hidden' (obfuscated) Magisk app after update to get things working did you?...

Also, did you install Magisk from recovery zip installer prior to OTA? (Never installed via app patch/flash)? PW
[Magisk] pndwal:
Symptom smacks of mismatched kernel... Did you ever install Magisk using Magisk App patch/flash? PW
[Magisk] rogers11:
No, I never had to uninstall a 'hidden' version. The installation is just one week old and yesterday it got the first OTA.

Last week I installed LOS -> GApps -> Magisk.zip via adb. I did not flash a patched boot.img (I know that I will not get the script in this case).
[Magisk] pndwal:
So could be the anomaly I noted above... Or this one I mentioned earlier:

- LOS recovery can't decrypt /data

https://github.com/topjohnwu/Magisk/issues/3820#issuecomment-857241389

... But I don't understand why addon.d apparently worked for you GApps if that's the case...

Guess it may be worth opening a GitHub issue if you're prepared to supply logs / details as requested and would like to see a fix... @osm0sis may have thoughts... PW
[Magisk] rogers11:
I will try to get a log on next OTA but I'm on vacation next week so I will do it later.
[Magisk] traversone:
good morning all.

latest 5.0.5519 of Intune Portal (Microsoft) detects root !

On top of common/standard guideline (100& working till yesterday),

a) I hided xposed modules (HMA)

b) XprivacyLUA is set as well (tracking and analytics)

No way to circumvent root detection. I suspect Intune Portal needs to get the list of installed applications as - when I also set this flag in XPrivacy + complete app's data reset - the account cannot be addedd and app loops.....

I also froze (renamed) Magisk app --> no luck

any further suggestion from you?
[Magisk] rodken:
Just throwing a couple of ideas your way:

Magisk App Freezer

Shamiko
[Magisk] pndwal:
Latest Official TJW Canary (release) & Debug (debug) Magisk builds:

Magisk (8dfb30fe) (24313)​

[App] Fix Debug channel preference not sticking

[App] Update the stub dynamic resource loading implementation to use official APIs on API 30+

[MagiskSU] Prune unused UIDs as soon as possible to prevent UID reuse attacks

[MagiskSU] Verify and enforce the installed Magisk app's certificate to match the distributor's signature

[DenyList] Fix DenyList on shared UID apps

Diffs to v24.3​

[MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)

[MagiskInit] Introduce new sepolicy injection mechanism

[MagiskInit] Support Oculus Go

[MagiskInit] Support Android 13 GKIs (Pixel 6)

[MagiskBoot] Fix vbmeta extraction implementation

[App] [MagiskSU] Properly support apps using shared UID

[MagiskSU] Fix a possible crash in magiskd

[MagiskSU] Prune unused UIDs as soon as possible to prevent UID reuse attacks

[MagiskSU] Verify and enforce the installed Magisk app's certificate to match the distributor's signature

[Zygisk] Fix function hooking on devices running Android 12 with old kernels

[DenyList] Fix DenyList on shared UID apps

[BusyBox] Add workaround for devices running old kernels

https://github.com/topjohnwu/magisk-files/blob/e31315f0eadbcfb456ba9677da9248a5d2d8ea48/notes.md

👍 PW
[Magisk] gribna:
I've had 21.4 for a long while, then last day I updated it via its app which put the phone into a permanent loop of "Phone is starting" across the desktop. I then installed the same 24.3 via TWRP which removed the loop but also took away mobile data.
[Magisk] pndwal:
I meant did you ever use patch in app & then flash separately (eg after an OTA) as this is where many (unwary) get kernel mismatches due to using image from earlier ROM etc... This is different from Direct Install...

If you suspect this may have occurred, you should restore stock images and do a fresh Magisk installation; I'd:

1) simply delete everything in /data/adb folder, especially if you suspect Magisk installation may be corrupted (optional; removes all settings & modules also).

2) flash stock boot.img back, or dirty flash a complete ROM again. (Fastboot ROMs are the most complete.)

You could also try latest Canary if you have further issues as it has many recent fixes, but it's doubtful that these will be needed by older devices like yours. 🙂 PW
[Magisk] zputnyq:
I'm still confused with debug & canary version. I saw tjw only release canary version which was written on the github commits, what about the debug version, should it be build by people themselves ?

If someone use canary version does he/she could easily switch to debug version without flashing, I mean only only intalling the apk to debug ?
[Magisk] zgfg:
Why should you build debug for yourself?!

Isn't it more simple to follow the link from Magisk app (no matter which version) to go to the Magisk official GitHub page

Scroll down there to find Downloads - see the screenshot

You can download app-debug.apk (Debug) or app-release.apk (Canary)

To switch, you need to download and install the right APK and then to patch the img and flash (or you can flash the renamed APK to zip from TWRP).

Installation is also described in details on the Magisk GitHub page
[Magisk] zputnyq:
He didn't mention the debug release on the commit, like stable version or canary.
[Magisk] zgfg:
Download app-debug.apk - it will be 17 MB

app-realease.apk - it will be 10 MB

Install either one, it will display as 24313
[Magisk] pndwal:
Since Debug and Canary builds are basically functionally identical, they are produced in tandem and appear in https://github.com/topjohnwu/magisk-files/tree/canary (repo/branch).

Debug will produce a performance hit on old devices due to new debug tools integrated, but the difference is otherwise just build type. Canary is now smaller than it was as verbose debug logging is removed and it is built as release. Debug is built as debug. Both are built at the same time from same commit...

John posted this recently:

👀 PW
[Magisk] Fishawy:
Edit - Fixed.
[Magisk] dohanin:
my intune company portal is updated to latest version and it is still fine, i.e. root not detected. i only have usnf and shamiko modules

you have to make sure ALL activities under intune are ticked in denylist (default is not)
[Magisk] traversone:
ok, many thanks! I will select all the activities as per your suggestion (in last but noe version that was not needed).

But which ANdroid version do you use?
[Magisk] dohanin:
Actually, someone in this post also reported the need to check all activities for intune company portal:

https://xdaforums.com/t/discussion-magisk-the-age-of-zygisk.4393877/post-86519351

I am using Android 12.
[Magisk] traversone:
in Android 11 (it is supposed to deny access to applist) I have also added Outlook in Denylist (standard selection for IntunePortal too, non all activities) and it WORKS !

of course Manager must be repacked with random name,

In android 10 this trick does not work though, or I am not able to make it working
[Magisk] lindsaysxda:
Can someone please help with my issue?

I'm trying to install Magisk to inactive slot as per this guide but no success.

I uninstalled Magisk (restore images option) successfully, downloaded and installed OTA, went back to install Magisk but there is no "install to inactive slot" anymore (screenshot), only select patch a file. It used to be on older versions when I was on LOS 17 a few months ago. I'm on 18 now. Magisk latest.
[Magisk] zgfg:
Don't know regarding your ROM, on my Xiaomi, stock ROM the option is present

If you are on 24.3 Stable, have you tried with the latest Canary 24313.

Btw, if you want to report to Magisk GitHub, you will need (Canary) Debug version
[Magisk] lindsaysxda:
Yes I'm on stable channel.
[Magisk] zgfg:
Try with Canary, there are always newer fixes, may help
[Magisk] lindsaysxda:
There is no canary in the options. Only Stable, Beta, Custom.

I switched to beta. Clicked install on magisk app and it installed same version 24.3.

Magisk install still no inactive slot option
[Magisk] zgfg:
Only Canary is the latest.

Beta is old as Stable (I wrote 24313, Beta almost for sure is not that version)

You should go to the Magisk GitHub and download

And (for everybody else) - there is a direct link to GitHub from the Magisk app (no matter which version you use)
[Magisk] lindsaysxda:
ok I did that. It's the same. 24300
[Magisk] zgfg:
You may report to Magisk GitHub but you would need to use 24313 Debug and the logs

Sorry, cannot help you more
[Magisk] pndwal:
🤔 ... Then you didn't click Magisk Canary or Magisk Debug (under Downloads); the two red options... 😜 PW
[Magisk] lindsaysxda:
Yes I did. The canary one.
[Magisk] pndwal:
You won't get Direct Install option without root; I believe option for Install to inactive slot on A/B devices likewise is only available with root... Seems you have rebooted after taking Uninstall, Restore images, so have lost root.

John says:

Do not reboot or you will have Magisk uninstalled...

...do not press the "Restart now" or "Reboot" button!

Whole update process (incl. Installing Magisk to inactive slot) requires root retained in active system... Ie. You can Uninstall / Restore images and Magisk is still loaded, but not if you reboot. 😬 PW
[Magisk] lindsaysxda:
No I haven't. I have done this process multiple times as per the guide I linked in my original post.

The option is just simply on new versions.
[Magisk] pndwal:
So after installing that and then taking Magisk Install, are you saying Canary app is installing 24300??? PW
[Magisk] lindsaysxda:
It promts to install an update on magisk, I click yes and it's still 24300. I don't care about this though. The issue it that the OTA process in the guide is not working anymore as the inactive slot install is missing. I don't care anymore, I restarted the device and lost root now. Whatever.
[Magisk] pndwal:
Your screenshot above shows Magisk Installed, N/A! This means app can't see root. Either root is absent, it's borked, you have a rogue 'hidden' app conflicting with app in use or other app issue preventing root detection... You can't have Direct Install or Install to inactive slot w/ Magisk Installed, N/A unless I'm much mistaken... PW
[Magisk] lindsaysxda:
Of course it's uninstalled. It's part of the OTA process. Read this guide.
[Magisk] Stillhard:
why should we?
[Magisk] lindsaysxda:
Don't
[Magisk] pndwal:
Sorry, I don't know of option to click 'yes'...

If App Installed is 24313 clicking Magisk Install will patch with 24313...

Clicking App Install however will call app shown as App Latest, and this may well be pointing to 24300 if Update Channel is set to Beta or Stable... PW
[Magisk] lindsaysxda:
Yeah it's not exactly yes. I'm talking about this popup.

It was 24300 and apk install was 24313. I think channel was set to beta. But it doesn't matter anymore, since I didn't find inactive slot option I just rebooted and lost root. I have to reinstall magisk from scratch if I want now.
[Magisk] pndwal:
John says "first go to (Magisk app → Uninstall → Restore Images). Do not reboot or you will have Magisk uninstalled."

As I understand it, you shouldn't get Magisk Installed, N/A unless you reboot because rebooting completes the uninstallation / unloading... The process described only works as Magisk is still loaded even after taking Uninstall Magisk, Restore Images until you reboot...

I have read OTA guide many times, but don't have an A/B device, so I may be wrong, but I don't think you'll have Magisk loaded with Installed = N/A, and if it's possible you should at least have Direct Install option... PW
[Magisk] lindsaysxda:
I did not reboot my friend. Why is it difficult for you to understand?
[Magisk] pndwal:
I think I understand this part of your problem now... Your system is having a problem installing newer app so you still have original 24300. (Could be the way it handles signatures, changes in Canary Magisk, or other...)

Just check what folder is set in Magisk app as download folder, close app, find Canary APK from failed install there and try installing that APK directly from file manager... If you still have parsing / other issues, uninstall 24300 first... 😜 PW
[Magisk] pndwal:
Why are you just being difficult?

We are trying to help you to analyse a curly issue... You should admit that your own understanding has been somewhat lacking (sufficiently understated?) and try to understand what others are telling you...

I'd actually like to understand you issue too, but I don't like dealing with attitude, so I'm loosing interest... PW
[Magisk] lindsaysxda:
Beucase you are asking me to explain the same thing over and over always assuming it is my error.

I told you I have followed that guide multiple times in the past and explained my steps in the original post exactly and you still assume I am following the guide wrongly. So yes I get frustrated when you don't read what I say.

Good, but I gave up and now I don't have Magisk anymore since I rebooted and lost root.
[Magisk] pndwal:
That's baloney... made no such assumptions, only said 'seems you rebooted', never 'asked for same explanation over and over', or even once because I did read what you said, simply tried to help and am now regretting it, tis all! Goodnight. PW
[Magisk] 73sydney:
@pndwal

Meanwhile i borked the latest update...temporarily - totally self inflicted and my fault, hence qualifies for a Spanner Award

Unhid the Magisk app

Updated app

Direct Installed magisk

Rebooted

Went to hide the app, gave it a shortcut name (i just call mine App) and hit the button, and just at that moment a notification popped up and lost the Magisk app window

Went back to drawer - nova can stay on page if you like it to, i do...but on this occasion as you will see if i hadnt had this turned on i might have noticed i had an issue and figured it out earlier and just deleted the duplicate (explanation coming)

Still had a Magisk app in the drawer, so assumed it had failed, so repeated the process....worked ...and no more Magisk app.

So i go to look for "App" and theres two...

One opens and looks normal apart from the Zygisk: No

The other prompts to complete full install of Magisk

Well thats fun....

Unhid the one that opened, uninstalled the remaining "App" and rebooted

Waited a few minutes

Hid the proper remaining Magisk to "App" and rebooted

Zygisk said : Yes

Happy Days!

Takeaway/Moral of this story:

Kids, dont do what daddy did and try and hide the Magisk app immediately after reboot, let the system settle, because this was entirely my fault for rushing things :)

Sometimes life really is like a box of Ponkles, you never know what youre going to get....
[Magisk] Fishawy:
A similar thing happened to me yesterday when trying a Magisk module that hides Magisk manager app when opening any of the apps in DenyList, then restoring it once those apps are closed.

Problem is, I already had the Magisk manager app repackaged and named "Manager", and that was working perfectly. Reboot, gone. Still rooted though, but no app, and no way to 'unhide' it.

Stumbled for some time trying to figure out how to handle this. Ended up uninstalling the repackaged "Manager" app and installing Magisk manager, then re-applied my config.

Moral of the story: If it's working, don't fix it!
[Magisk] pndwal:
Just to clarify this point:

Update Channel no longer controls Magisk (mask) installations... To change target Magisk version, App must be changed / updated first.

Since we got Single package Magisk distribution (22.0), Magisk (mask itself) is not affected by Update channel and will always patch image or direct install/install to inactive slot using embedded (build specific) binaries. Ie. App Installed is always the target version for Magisk Install and this is regardless of Update channel...

This is also because we now also have entirely offline installation; Magisk doesn't call web hosted Magisk binaries any more and the APK package binaries are always called. Each APK only contains one corresponding set of binaries, so even if Debug channel is set and App Installed is 24313 for instance, Magisk Install will still call Canary 24313 binaries if Canary App was/is installed AFAIK... Users need to take Install App first if changing channel... An issue here is that knowing whether Debug or Canary is installed depends on users memory ATM AFAICS; a better naming convention may be needed to differentiate new Debug from Canary UIMS (unless I'm missing something).

This does mean that for in-app installation at least, Magisk (mask) will always match installed App if updated property as user now needs to update App before taking a Magisk (mask) update. (App will always be same version as Magisk (mask) or a later later version (if only App is updated), unless an app is downloaded and installed manually).

🤠 PW
[Magisk] ipdev:
@lindsaysxda

Hi. :)

I spent tonight testing something completely different on my Pixel 5a.

boot-looping and/or running into RED-boot. 🤬​

Since I have been borking my Pixel 5a all night, I decided to give it a try. 🙃

I normally update manually. Only use OTA(s) when I have to.

I clean flashed Lineage 19.1 20220505 (barbet).

Installed Magisk (app) and patched the boot image.

Pulled the patched boot image.

Rebooted into fastboot (bootloader), flashed the patched boot image and rebooted.

Hid (renamed) the Magisk app and then took the newest Lineage OTA for barbet (20220519).

Download was quick but, it took longer than I expected to install.​

Once done, I opened the Magisk (app) and used the patch-other-slot option.

I closed the Magisk (app) and went back to the OTA update and selected reboot.

It rebooted and I was on the 20220519 build with Magisk active (the new boot image was patched).

Magisk (app) was still hidden (renamed) and all was good.

At least one test I did tonight worked. 🙃

---

I might be wrong but, I thought you only had to uninstall/restore images for Factory/OEM ROM(s).

OnePlus used to download the full OTA instead of a partial OTA when "root" was detected.

Not sure if that is still the case.

Custom ROM(s) like Lineage, normally are not affected by root (Magisk).

Sorry if I missed it but, what device are you using?

Cheers. :cowboy:
[Magisk] pndwal:
This is true; only delta (incremental) OTAs should need Restore Images, so LOS updates (full ROM OTAs) don't.

Of course, Magisk root will be gone after OTA regardless, unless custom ROM complies with addon.d (v2 for A/B devices) and current Magisk was installed from custom recovery using apk as zip installer... (Code for addon.d still exists when Magisk is installed via app, but it's disabled.) The same methods to restore Magisk root will otherwise be needed.

Seems he's using Xiaomi Mi A1 w/ LOS 18.x ... Interesting early A/B (SAR) device launched w/ Android 7.1.2 and Android One OS instead of MIUI...

I'm interested to know this: On A/B devices using the OTA and Install Magisk to inactive slot method, after taking Uninstall Magisk, Restore Images but before rebooting, do you ever see Magisk Installed - N/A, Zygisk - Yes?... Seems strange to me, but perhaps it's as designed / intended...

🙂 PW
[Magisk] lindsaysxda:
@ipdev Yes, I am using Mi A1 with latest LOS. Thanks for the info about LOS OTA. The OTA method in the magisk guide has always worked for me however. Uninstall restore images, then flash to inactive slot after installing ota, however this was on older magisk versions. I don't know why it's like this now. Maybe I fat fingered the complete uninstall button instead of restore images. And to be honest, these options shouldn't be on top of each other, but left and right.
[Magisk] lindsaysxda:
@pndwal
[Magisk] andrea0807:
Is there a magisk or lsposed module to assign the screenshot function to the long press of the home or overview button since the lineageos ROM does not allow it?
[Magisk] zgfg:
GravityBox for LSPosed - see the screenshot (I didn't try)
[Magisk] J.Michael:
When did Magisk Manager app stop displaying some mention of "A/B"-ness? I do not see any mention in @lindsaysxda's screenshot.
[Magisk] andrea0807:
I have lineage 19.1 gravitybox is not compatible
[Magisk] zgfg:
It was already explained. Direct install and Install to inactive slot have to patch to the Boot partitions, not to boot.img file - as that they require root. If Magisk N/A there is no (more) root
[Magisk] amk316:
i delete magisk manger form my phone and install it if i need to use it so some apps don't find that i am rooted.

anyway the last update 24313 just add the manger shortcut every time i use an app with root access and that is vary annoying.

dose any one have the same problem? and how to stop it?
[Magisk] zgfg:
Sorry then, bad luck with LOS 19.1

I'm using GravityBox R, but of course with A11

Btw, I have the same option with another LSPosed module, CustoMIUIzer (screenshot) but it's only for Xiaomi (MIUI) phones