yashsingh1/xdaforums huggingface dataset:
[Magisk] alessio89g:
I've a Nexus 5 with Unlegacy Android ROM (a vanilla AOSP Nougat ROM) and today I've flashed an update of this ROM:

I've reboot the device in TWRP

I've wiped system, cache and dalvik

I've flashed the ROM, GApps and Magisk

At this point I immediately noticed that something was wrong:

During Magisk installation, in TWRP log console I've see: "! System installed root detected, mount rw :("

Not knowing what to do, I went ahead and I wiped cache, dalvik and reboot. So when Android was booted up, I've opened Magisk, tapped on SafetyNet checker and I see: "SafetyNet Failed: CTS profile mismatch".

I've tried to disable the built-in Busybox, systemless hosts, and USB debugging, and rebooted many times; I've also tried to uninstall through Magisk Manager feature (and also with uninstaller zip), and re-install, but the device doesn't pass SafetyNet.

The last time I checked (about a month ago), the device passed, but yesterday I've received a Play Store update (7.8.36.P-all [0] [PR] 156940515), and I didn't check SafetyNet (but Play Store was "Certified"). Is it possibile that this new version doesn't pass SafetyNet control?

I use MagiskSU, Magisk Manager 4.3.3, Magisk 12.0, any module installed and this is the log:

** Magisk post-fs mode running...
** Magisk post-fs-data mode running...
* Running post-fs-data.d
* Loading core props
* Preparing modules
* Stage 1: Mount system and vendor mirrors
* Stage 2: Mount dummy skeletons
* Stage 3: Mount module items
* Stage 4: Execute module scripts
* Stage 5: Mount mirrored items back to dummy
** Magisk late_start service mode running...
* Enabling BusyBox
* Linking binaries to /sbin
* Starting MagiskSU
* Running service.d
* Starting MagiskHide
MagiskHide: Moving and re-linking /sbin binaries
MagiskHide: Removing dangerous read-only system props
MagiskHide: resetprop by nkk71 & topjohnwu
Initializing...
Modify data structure: 'ro.debuggable'='0'
Existing property: 'ro.debuggable'='1'
Recheck property: 'ro.debuggable'='0'
Done!
MagiskHide: resetprop by nkk71 & topjohnwu
Initializing...
Modify data structure: 'ro.secure'='1'
Existing property: 'ro.secure'='0'
Recheck property: 'ro.secure'='1'
Done!
MagiskHide: Killing com.google.android.gms.unstable
MagiskHide: Starting MagiskHide daemon
MagiskHide: Update process/package list:
MagiskHide: [com.google.android.gms.unstable]
Zygote(0) ns=mnt:[4026534251]
MagiskHide: com.google.android.gms.unstable(PID=3426 ns=mnt:[4026534284])
MagiskHide: Unmounted (/sbin)
MagiskHide: Unmounted (/system/xbin)
MagiskHide: Unmounted (/magisk)
MagiskHide: Update process/package list:
MagiskHide: [com.google.android.gms.unstable]
MagiskHide: Update process/package list:
MagiskHide: [com.google.android.gms.unstable]
MagiskHide: Update process/package list:
MagiskHide: [com.google.android.gms.unstable]
MagiskHide: Update process/package list:
MagiskHide: [com.google.android.gms.unstable]
MagiskHide: Update process/package list:
MagiskHide: [com.google.android.gms.unstable]
MagiskHide: com.google.android.gms.unstable(PID=6263 ns=mnt:[4026534296])
MagiskHide: Unmounted (/sbin)
MagiskHide: Unmounted (/system/xbin)
MagiskHide: Unmounted (/magisk)
[Magisk] DodoGTA:
Can you run "getprop ro.build.fingerprint"?
[Magisk] alessio89g:
I downgraded the ROM to the previous build, and now SafetyNet passes again… so I think it's an issue of the newer build. I'll inform the developer.

For curiosity, what does that command do?
[Magisk] ragnarok00:
Could magiskhide also hide "/sbin_orig" folder? I found that the game I used to play (Puzzle and Dragons Japanese version) also checked files in that folder.

I guess they are using some kind of wildcard logic to check su related files in all *bin* folders.

I am running Magisk v12 on latest stable build in OnePlus3.

I tested the below method it could work fine, otherwise the whole game will exit upon entering.

1) Do not enable Magisk Hide from start, remove the /sbin folder

2) Enable Magisk Hide, remove both /sbin & /sbin_orig

However, removing such folders simply mean I lost root and also cannot use Android Pay.

Any help is appreciated!
[Magisk] DodoGTA:
Tells you the build fingerprint
[Magisk] twcobra:
Well Google just took a shot at Magisk with June security update. Cts fails now but at least pogo still works. Since my new cheap phone does not have nfc any way. No big for me.
[Magisk] dahawthorne:
Which version of Magisk are you using?
[Magisk] twcobra:
After 12 failed I tried 6/6 version 13 with matching manager. Cts failed but the other test passed. I went back to 12 due to a module not working in 13.
[Magisk] Wolfcity:
Yes you can. Just choose the latest build and the right one for your device. I'm new to magisk too and everything I did before with superSU as root app is working with magisk too. And I'm a flashaholic.;) Magisk offers just a few more features but the main things are the same.
[Magisk] rignfool:
DU still passes safety-net... On new blobs
[Magisk] Nomelas:
Yeah that's how it works. However you will likely still need to go reflash magisk each time AFAIK... I haven't tested that yet. Also for using magisk, make sure you opt out of flashing the flashfire root (I think it's supersu) as it won't work with magisk.

You can flash the system unconditionally I'm pretty sure. Even with a modified system, meaning Ota have a higher chance of success.

You can also flash fastboot zips straight from the OS instead of needing a computer. It has tons of potential as well.
[Magisk] Didgeridoohan:
Did you manage to figure this out? I've also got a stock (6.0.1 september update) Nexus 6 with custom kernel (FK) and can for the life of me not get Magisk to change DPI. I can see the post-fs script run in the log, but nothing happens. Magisk v6.
[Magisk] Captain_Throwback:
Rather than replacing the entire build.prop, did you try just using setprop to set the desired DPI?

EDIT: I just tested this myself and it appears to work fine - adding the setprop command to post-fs.sh in /cache/magisk/Change_DPI and adding a module.prop and auto_mount file set the DPI properly for me, without needing to bind mount an entire build.prop. That's the preferred way to do it.

EDIT 2: Make sure the secontext of your /cache/magisk folder and subfolders are system_file not cache_file - that will prevent the script from running in the correct context, so the values won't apply.
[Magisk] crime_of_heart:
Hi all.

First of all thanks [MENTION=4470081]topjohnwu[/MENTION] for this incredible work.

My issue is:

When I try to flash magisk v6 installer zip, it gives me 'Unable to detect boot image' error and quits. I have TWRP 3.0.0.0 installed with unlocked bootloader and unmodified boot.img. I tried also with re-flashing stock rom (to make sure no root nor xposed exists), still the same problem.

I have the Meizu pro 5 phone (with Android 5.1.1 based stock Flyme OS firmware) with same emmc mounts of boot.img with Samsung galaxy s6 phones. Exact location of the boot image in my device is: /dev/block/platform/15570000.ufs/by-name/bootimg

When I check the update-binary, I cannot understand why it cannot detect the boot.img as I can see the 'readlink /dev/block/platform/*/by-name/$PARTITION' line, which should match it. But it doesn't.

Where can be the problem?

PS: It did not create any log file under /cache partition. Please see attached the current boot.img in case you need to check.
[Magisk] Didgeridoohan:
I should have been clearer I guess...

I have tried both methods to no avail.

[MENTION=3875940]CHAMAVELI[/MENTION] was having problems with the setprop method prior to trying replacing build.prop as in the quoted post.
[Magisk] Captain_Throwback:
Well like I said, it's working for me. Did you check the secontext of the files, as per my second edit?

EDIT: And make sure the permissions of the script are at least 750?
[Magisk] Didgeridoohan:
Yup, I did have control over the permissions, but. SE context for the magisk-folder is set to cache_file. Both my limited terminal-fu and my Google-fu failed me at this point, though.

How do I go about changing it (and why doesn't it get set to system_file by default)? I tried running chcon in terminal but only got errors about it being read-only.

EDIT: It worked... I wasn't specifying the path properly in the chcon-command. Gonna try the mod now.
[Magisk] Captain_Throwback:
Just to confirm, you did chcon -R to make sure all the subfolder contexts got changed as well, right?

P.S. The next version of the template will take care of that automatically (changing the context to system_file).
[Magisk] Captain_Throwback:
It does appear to be running according to that log. I think a logcat from boot might be more helpful so we can confirm the value is actually getting set. Any chance you can pull that?
[Magisk] JRJ442:
Does anyone know of any intents for the root toggle in the Magisk Manager? I was thinking of using Tasker and Custom Quick Settings for a root toggle from Quick Settings. So far the worst I can come up with is using Auto-Input to toggle it. Kind of messy though.
[Magisk] Didgeridoohan:
I've actually never had a reason to run a logcat before... Nice to finally get that checked off.

I can see density being set at the default 560 and not 496 as I like it. Does it have anything to do with me having a password set up to start my device?
[Magisk] Captain_Throwback:
Hm, nothing in there offers a clue, as the cache mode stuff happens before logd is initialized, so we can't see what's going on at that time in logcat.

I'm out of ideas. It does seem to be working for most people on most devices, but perhaps some devices are different. Is there anyone else with your same device that has it working using this method?
[Magisk] Didgeridoohan:
D'oh!

It'd be interesting to hear if anyone with a stock (apart from custom kernel) Nexus 6 have managed to get this working. We know there's at least one more user, [MENTION=3875940]CHAMAVELI[/MENTION], that have had problems with this.
[Magisk] ZabiGarma:
I'm quite new to this, so I'll ask a few things:

1. I have to erase the previous root files, right? Would a regular OTA update do the work?

2. I'm not sure about the installation order. Okay, so, once I perform the regular OTA update (assuming this is enough to erase the old root) I proceed to unlock the bootloader and install TWRP. Then, I flash Magisk and once I'm done with that I root the phone (phh's SuperUser being the recommended choice, instead of SuperSU).

I'm also wondering if this version of v4a works with Magisk.

Anyhow, this probably has been asked already, but has this been tested with Nexus 6p?

Thanks in advance.
[Magisk] steveo17:
most people will say read the OP which answers all of your questions, but here are answers to your questions

1. You should be starting from a 100% clean untouched system. If you've rooted before, you wouldn't likely be able to take an OTA. with this you should flash the stock system and boot imgs to clean up your system.

2. Kinda a continuation of #1. but know that unlocking the bootloader will wipe everything on your phone...which would really take care of the first step.

after you have done all that you can flash Magisk

Magisk is first and then you flash modules

also, that version of v4a will not work with Magisk as it is not created for Magisk. there are versions floating around for Magisk, but i have not had luck with getting them to work yet
[Magisk] KAsp3rd:
In the 2nd post I believe. I'm using tasker to toggle it. Here is a link to my post here
[Magisk] ZabiGarma:
Thank you, I did read OP, but I was rather confused about installing Magisk before rooting, so I wanted to confirm.

I do receive the monthly updates, but I've never installed them directly in order not to lose root (systemless), so I've always flashed them with FlashFire.

Anyhow, considering an OTA wouldn't make it, I guess I'll just wipe the device with TWRP.

Thanks a lot, I really wanted to confirm this, as I wasn't sure if I understood the steps in the OP.

I see, hopefully they'll release a version that supports Magisk. That's the only version of v4a I've managed to get to work on my phone.
[Magisk] insaned:
You were able to flash Miagisk v6 and you checked superSU was working? Because with v4, v5 and v6 I cannot have root.

Unfortunately since knox tripped I guess no OTA updates anymore. I was using flashfire to update the roms, which turns the process a WHOLE lot easier and quick as it doesn't wipe the data and basically works like a OTA but you just flash it yourself.. however is not recognizing root with PHH superuser and SuperSU root is not working on magisk (or I?m not being able)... I didn't bother much and went back to normal root until TODAY, since my bank started using NFC payments. SO now im back again into systemless...
[Magisk] aaron804:
Android Pay weirdness

So I find this odd and maybe someone can shed so light on it...

I have a Nexus 5x running Android 7.0. I have Magisk v6 installed with phh-superuser-17-magisk installed and working.

However...

Android Pay does and doesn't work. I can add a card and use it at Walgreens with out issue. However when I try and use it at Trader Joe's it doesn't work, I get the Android Pay cannot be used on this device screen.

I assume it must have to do with the different cc processors?!?

Things I have done to test:

I have removed the card from AP and re-entered.

I have removed the card from google.

I have verified with my bank that the cc is setup correctly, have a valid virtual card and valid token.

I have also tested by going to Walgreens and successfully making a purchase, then immediately gone to Trader Joe's where it fails, then immediately back to Walgreens where it again works flawlessly.

Any thoughts / ideas?

Thanks!!
[Magisk] Didgeridoohan:
No issues passing SafetyNet on June security patches on my Vanillafied Nexus 6 with Magisk v12.
[Magisk] saransh arya:
Link for v 13?
[Magisk] Iradj:
Guys can someone tell me what I have to do to run S-PushTan on my S7 Edge because it closes down every time I open it it's already in the hide list.

S7 Edge

Stock Rom

Magisk V12

Safetynet passes
[Magisk] Didgeridoohan:
That seemed like a very unrelated question to my post... :confused:

But anyway... There's a brand new stickied Beta thread. You could try that, but remember it's BETA and there are certain things you need to think about if you decide to use it. [MENTION=4470081]topjohnwu[/MENTION] explains it very well in the thread.

Try temporarily uninstalling the Magisk Manager. I think i saw someone reported success doing that.
[Magisk] Iradj:
Tried already but no didn't work for me uninstalled Magisk Manager cleared cache and data from the latest S-PushTan App (1.0.12) and rebooted the phone even but it closed again down tried with one version older (1.0.11) same thing.

Here is a magisk log maybe you can find something in it.
[Magisk] shadavis08:
I can just download a rom and install it right from my device. No computer needed right? I really want a rooted stock so I can use the second screen on my v20. Also will I have to download magisk again after each flash?
[Magisk] ahse0w:
Well.... that didn't go quite like this for me.

So June update came, and I tried using Flashfire to flash the OTA that was downloaded on my phone. Disabled Everroot and added an action to flash Magisk.zip after that, and preserved recovery. Flashfire has an error that says content not as expected for the OTA and flashed Magisk.

I thought maybe that file was not correct, so I went to download the full OTA images from Google. Same thing, generated actions to flash the OTA and Magisk.

This time round, it was able to flash. After rebooting, I CANNOT unlock my device.

Fingerprint is recognized, the PIN I entered is DEFINITELY correct, but it just keeps prompting Wrong PIN.

Tried entering through ADB, this appeared

error: device unauthorized.
This adbd's $ADB_VENDOR_KEYS is not set; try 'adb kill-server' if that seems wrong.
Otherwise check for a confirmation dialog on your device.

That didn't work.

So I uninstalled Magisk through recovery, Wrong PIN again.

Downloaded the full image, and flashed without -w, Wrong PIN again.

Finally I gave up and flashed with -w.

Now I am just waiting for my phone to be restored.............. that was a bad experience.
[Magisk] fahd47:
Flashed Magisk 12.zip from twrp and then installed magisk manager but when I open it it says rooted but no root permission. How do I fix this?
[Magisk] GayCasper:
How do u get beta 13?
[Magisk] phillibl:
The beta 13 thread.
[Magisk] Elanza_48:
Can Magisk disable dm variety on samsung devices on flashing ??
[Magisk] Didgeridoohan:
S-PushTan is one of those finicky apps that isn't quite so easy to fool. I see you have Root Beer in there as well. If you add it to the Hide list, does it give you all green checks? If it does, you at least have the prerequisites to make it work.

I've gotten the app to start once or twice myself and I had to clear data for the app the few times I managed to open it.

If you've searched this thread you'll have seen that many have issues with S-PushTan...

D'oh!

"Content not expected" means that the OTA doesn't like the look of your system. To flash an OTA with Flashfire and MagiskSU you'd probably have to add a stock boot image to the top of the flash cue.

Don't know about what happened with full OTA...

About the PIN: for future reference, if you can enter recovery, you might be able to remove the PIN/password by navigating to /data/system and deleting any files with the .key extension and any files named locksettings something.
[Magisk] ArclightX:
nvm, found it.
[Magisk] ndarkside93:
Magisk snapshot thread
[Magisk] ahse0w:
So I would need to flash Magisk uninstaller first before flashing anything.

Thanks for the tip on the PIN!
[Magisk] Didgeridoohan:
I guess you could add the uninstaller to the top of the cue in Flashfire, but then you'll remove all your modules (if any) and will have to add them to the que as well. Better to just add a stock boot image. The Magisk image will still be in /data but the boot image will be clean and unmodified (and that's what matters).
[Magisk] DodoGTA:
Did you forget the word "queue"?
[Magisk] Didgeridoohan:
Freaking a... I completely had! :laugh: I'll make a half-assed excuse about not being a native English speaker. :D I am NOT gonna tell my wife about this... English is her first language and she teaches English on top of that. LOL
[Magisk] Iradj:
RootBeer is on the Hidelist and gives me all the green checks except the selinux one maybe thats the problem.
[Magisk] Didgeridoohan:
Actually, IIRC during one of my tests on how to get that app to work I did get it to open by setting ro.build.selinux=0. Seems completely wrong, disabling SELinux, but that's what worked then...

Another vague memory is that someone got it working on Magisk v11.6.
[Magisk] tag68:
For S-Pushtan (which I didn't try by now myself, I'd like to use S-ID-check on next credit card online payment, for usual banking I'm using ChipTAN) the posted solution was: 1. uninstall Magisk Manager 2. Clear Data/Cache of S-Pushtan, maybe uninstall and install S-Pushtan. 3. Use S-Pushtan. Problem seems to be: S-Pushtan recognized the app MagiskManager and remembers somewhere if it has seen it once.
[Magisk] Iradj:
Indeed sounds completly wrong but im trying it out, going back to an older version of Magisk is no option for me so i drop it. Can it be done when i make a module and set the property in the Module ? Where i have to get the Module Zip and a Guide maybe where i can see how this setup works.

Tested this also but unfortunately no luck.
[Magisk] Didgeridoohan:
For a simple prop change you can just as well use a boot script. Put this in a file (the name doesn't really matter, no extension needed) and place it in /magisk/.core/post-fs-data.d:

#!/system/bin/sh
resetprop ro.build.selinux 0
[Magisk] Iradj:
Oh ok cool thank you very much testing it now.
[Magisk] mrkrazy:
Has anyone been able to check out my logs to see if there's anything wrong? I'm still unable to pass SafetyNet on my Find 7A with OMNI ROM 7.1.2 :(
[Magisk] Iradj:
Ok I did that but still the App don't want to run ! in the Magisk log it shows me only that the file is loaded but when i entered the getprop command in a terminal it shows still that the Selinux flag is 1.

View attachment magisk_error_20170608_123350.log
[Magisk] Didgeridoohan:
You can also try running the command in a terminal emulator:

su
resetprop -v ro.build.selinux 0

The -v option is added to get a verbose output. I'm suspecting your kernel doesn't allow it though, or something similar.
[Magisk] Wolfcity:
Download ROM,gapps,magisk and what else you need to your phone,wipe dalvik,cache, system and data (if you're doing a clean flash which is recommended), place it all in the root of your sd and flash it. But that'll all described in the thread of the ROM you prefer. You don't have to download magisk everytime, only when it's updated.
[Magisk] Didgeridoohan:
Looks like the ROM/kernel isn't compatible with Magisk Hide. There are a lot of entries for the Hide list being updated that shouldn't be there. Seen it a few times and always on devices where Magisk Hide doesn't work. Don't know why though...
[Magisk] mrkrazy:
I see... I've raised it with the ROM developer and as mentioned in my original post I made sure I have a stock boot.img. Thanks for checking at least and for being helpful :good:
[Magisk] Iradj:
It worked selinux is set on 0 but still no success but nevermind i think for now i can live without it.
[Magisk] Windforce0511:
Anyone with v13.0 beta using Galaxy S6 Nougat?
[Magisk] Jenanga:
The unofficial thread can help you
[Magisk] Didgeridoohan:
There's actually an official beta thread now: https://xdaforums.com/apps/magisk/beta-magisk-v13-0-0980cb6-t3618589
[Magisk] WookieTookie:
Hi guys, I'm having this error while flashing Magisk 13

Updater process ended with ERROR: 1

Error installing zip file '/sdcard/MagiskManager/Magisk-v13.170606.zip'

I'm on TWRP 3.1.1 and have a OnePlus One, flashing Magisk 12 works just fine, but I can't update it as I get this error.
[Magisk] Hyperbomb64:
I see in this thread we can no longer pass safety net with systemless xposed. I was wondering if this is something that will be patched in the future. If not does using the switch in the materialized xposed installer to turn xposed off and then rebooting a safe way to temporarily pass safety net?
[Magisk] razorbeat:
Hello, i have an Asus ZE551ML with android 6.0.1, I installed TWRP and I flashed superSU.zip from it. Now i found Magisk and i wanted to install it, but after i flash it with TWRP my phone keep booting in recovery, do you know why? Thanks
[Magisk] CrazyCypher:
By guys, does this mean Magisk v13 can work on Samsung Galaxy S8 on stock ROM without root?

I don't want to root because I want to keep official updates..

Thanks!
[Magisk] kirito9:
But isn't using Magisk ....rooting?
[Magisk] CrazyCypher:
I thought so until this latest v13 version, now I'm not sure if it voids galaxy warranty or not...
[Magisk] kirito9:
I don't know how exactly it will be done but from what I read it's supposed to root your device without the use of a custom recovery or root.
[Magisk] Artim_96:
There is no way to install Magisk without tripping the Knox Warranty Counter. In fact no modification is possible without, root is irrelevant.

Magisk is supposed to hide the tripped counter, but I don't know if it really had any effect. For all I know it didn't.

So either you live with a tripped counter like everyone else here or you should leave xda at all, nearly everything you can flash (except Samsung's own files) will trip that counter.

But you'll probably come back in a year or sooner when your device bugs down like crazy like every Samsung and then you'll give a s*** about that stupid counter.
[Magisk] hachiroku:
i realized why 11.6 works while 12.0 does not. 11.6 includes phh's superuser r266-2 which is a modification from topjohnwu to work with Magisk. 12.0 and newer comes with Magisk SU, but does have issues installing itself on certain ROMs. If MagiskSU does not automatically install with flashing of zip, then your only alternative is to install phh's superuser r266-2 which currently took me 20 minutes to find across the internet. this is how i solved the "magisk rooted but no root permission"