yashsingh1/xdaforums huggingface dataset:
[Magisk] regularmen:
Hi guys, I have trouble setting up Password screen lock after using Swipe screen lock for a while. It's just doesn't work, when I set it up nothing happens, even it stays Swipe on it's settings. I'm running at Android 9 using Magisk 23 before but tried updating (and with no module at all) to Magisk 25 and it still doesn't work.
[Magisk] pndwal:
Interesting solution...

So what happens if you use this mod:

https://xdaforums.com/t/magisk-module-universal-safetynet-fix-2-3-1.4217823/post-87198517

only (with Zygisk enabled and nothing in denylist)?

- Moving this here since @Didgeridoohan's thread is really for things MHPC... 😛 PW
[Magisk] J.Michael:
Is what you're calling "crashing" that message about not being able to contact it's home server?

Did you try disabling the Magisk module that "might be having a conflict"?
[Magisk] m0han:
well, i'm trying to to figure out why the app is not able to contact it's home server. could it be a 'region thing'? my net connection is robust and intact. the original app is behaving okay without disabling any module.
[Magisk] Captain_cookie_200:
i dont didnt try that... rn i am just enjoying my A13 spark os with samiko and play services in deny list. safety net passes no problem. although i just found out what play integrity and i fail at strong integrity. can the module fix that?
[Magisk] J.Michael:
Do you know whether the old version also contacted the home server?

Does the new version crash if Magisk is disabled?

I don't know if it is easy to "disable" Magisk, but unless the checker runs quietly without Magisk and crashes with Magisk, I think you need to ask on the checker thread.

I tried using a browser to go to https://tbchecker.kryptonproject.my.id and the Google Play Store app opens. What does that?
[Magisk] pndwal:
No, we can't pass strongIntegrity... See this:

https://xdaforums.com/t/discussion-google-pay-magisk-discussion-thread.3906703/post-87481637

... Some technical stuff here:

https://xdaforums.com/t/discussion-google-pay-magisk-discussion-thread.3906703/post-87480375

🤠 PW
[Magisk] zgfg:
Previously I tested on on one phone with Magisk Canary, now also on the other with Magisk Delta - on both phones the new TB Checker works fine for me and its new PI Check option (upgrade from the previous SN Check) provides expected results:

MEETS_BASIC_INTEGRITY, MEETS_DEVICE_INTEGRITY

with

PLAY_RECOGNIZED
[Magisk] 73sydney:
i just updated here and its resolving for me....its a "you" thing :)
[Magisk] MorganXYZ:
Yeah, you're right the first time :

:)

(btw, been out for long Sunday walk, only just recovered from punished knees...)
[Magisk] pndwal:
... Further, as I said, Spark OS integrates SafetyNet Fix as well as @Displax's mod:

https://xdaforums.com/t/module-magi...p-edits-and-more-v6-1-2.3789228/post-87480647

Perhaps the Devs implementation doesn't work fully/properly if you also need Shamiko hiding for gms... But you're not running extra mods yourself affecting gms, eg in MagiskHide Props Config, are you? PW
[Magisk] Captain_cookie_200:
Nope. Only shamiko
[Magisk] m0han:
was. uninstalled; reinstalled. works.
[Magisk] MorganXYZ:
Okay folks, thought I'd post up the procedure:

Follow these instructions until you get to 7th bullet point here;

Stop. Some points to mention on the way:

Note my progress above from 'Preliminaries' until point 5, adb pull /sdcard/Download/magisk_patched_[random_strings].img works just fine;

Ignore my rambling queries up to point 5;

Install heimdall;

Boot device into 'Download' mode without USB cable connected, then once in 'Download' mode insert USB cable (this seemed important as I ran into quite a lot of ERROR: Protocol initialisation failed! type errors which seemed possibly cable/ hardware related);

$ heimdall detect
Device detected
$ heimdall print-pit --no-reboot > print-pit.txt

From print-pit.txt discover:

...

--- Entry #10 ---

Binary Type: 0 (AP)

Device Type: 8 (Unknown)

Identifier: 5

Attributes: 5 (Read/Write)

Update Attributes: 1 (FOTA)

Partition Block Size/Offset: 10240

Partition Block Count: 10240

File Offset (Obsolete): 0

File Size (Obsolete): 0

Partition Name: BOOT

Flash Filename: boot.img

FOTA Filename:

...

Reboot into 'Download' mode (this rebooting also seemed to help prevent the above errors);

$ heimdall detect
Device detected
$

Then, instead of fastboot flash boot /path/to/magisk_patched.img at the 7th bullet point here

Do:

$ heimdall flash --BOOT magisk_patched-25200_UjUVt.img
Heimdall v1.4.2

Copyright (c) 2010-2017 Benjamin Dobell, Glass Echidna
http://www.glassechidna.com.au/

This software is provided free of charge. Copying and redistribution is
encouraged.

If you appreciate this software and you would like to support future
development please consider donating:
http://www.glassechidna.com.au/donate/

Initialising connection...
Detecting device...
Claiming interface...
Setting up interface...

Initialising protocol...
Protocol initialisation successful.

Beginning session...

Some devices may take up to 2 minutes to respond.
Please be patient!

Session begun.

Downloading device's PIT file...
PIT file download successful.

Uploading BOOT
100%
BOOT upload successful

Ending session...
Rebooting device...
Releasing device interface...

$

At which, the device reboots and:

Happiness :)
[Magisk] 73sydney:
See theres that faffing about that i said made me avoid heimdall for my entire Android career :)

(i wont say that i could have installed windows and used ODIN in the time it took me to read and follow your exploits :) )

Im just glad you got it sorted, and now others may benefit, thanks for your sacrifice

@pndwal, tell him what he's won.....

(i bet its a set of steak knives)
[Magisk] dope77:
Ye had same issue on my old device. Flashing magisk would break lockscreen and if u set lockscreen it would stay say Swipe. You'll get bootloop if you reboot your device too.

Is there by any chance that you have a Samsung J-series device?
[Magisk] pndwal:
... And what a career!

He won! ... And made Gaël Duval proud!...

He'll be the /e/nvy of all if he can get S/N & PI verdicts passing with that! 🤪

Thing I'm most intrigued by is Zygisk = Yes on Galaxy S7!...

Last I knew this shouldn't work as the S7 pre 3.19 (3.18.91) Kernel had the the exec limitation (when exec an ELF from /proc the process can no longer call some systemcalls)...

- https://github.com/topjohnwu/Magisk/issues/5395#issuecomment-1073746347

- https://github.com/topjohnwu/Magisk/issues/5339#issuecomment-1031010036

- https://github.com/topjohnwu/Magisk/issues/5339#issuecomment-1031095243

Now I see this was fixed in LOS 18.1+ using 3.18.140 kernel...

- https://github.com/topjohnwu/Magisk/issues/5395#issuecomment-1073746347

Of course /e/ OS derives from LOS...

Guess this kernel may be available for stock S7 users, or ported to a compatible boot.img...

At least S7 users can move to Lineage OS or /e/ OS to get Zygisk working... 😛 PW

PS. Your steak knives!

🔪

🔪🔪

🔪🔪🔪

🔪🔪🔪🔪​
[Magisk] kugamu:
Who can tell me how to fix these errors?
[Magisk] zgfg:
All those apps must be in DenyList

For Oprek use additionally Hide My Applist (LSPosed module) to hide Magisk app and all LSPosed modules (HMA itself including)- there have been guides here how to setup.

See the screenshot.

Same works for TB Checker

From Momo you will probably never fully hide root - somebody else could give you some hints

Root Beer is pretty much deprecated.

But if it only detects BusyBox - make sure you use BB module, not a rooted BB app
[Magisk] 73sydney:
@zgfg has covered this before

and using search terms Hide My Applist or HMA would have gotten you here with a little clicking

https://xdaforums.com/t/discussion-magisk-the-age-of-zygisk.4393877/page-23#post-86376291

you can get a 100% pass on all but Momo (we tend to ignore it, if not call it pointless or worse here) but doing as suggested - create a blacklist with root and lsposed/xposed modules, and then apply it to any "detector" apps. also important is to force stop, then clear data on those detector apps before testing again each time as they can cache previous results....failure to do this last step can send you in hours of circular disappointment :)
[Magisk] 73sydney:
@m0han

Heres one that had me scratching my head, and i know @m0han mentioned it before

I noticed i was getting a red on Oprek for custom recovery files, and im like "but i haz no TWRP folder on my internal memory!"

Tonigth i figured it out with a bit of basic detective work....

at adb shell on pc, because daddy likes his 32" Odyssey G7 over a 6.5" phone screen:

y2s:/data # find / -iname "TWRP" 2> /dev/null

/mnt/runtime/full/emulated/TWRP

/mnt/runtime/write/emulated/TWRP

/mnt/runtime/read/emulated/TWRP

/mnt/runtime/default/emulated/TWRP

/mnt/pass_through/0/emulated/TWRP

/data/media/TWRP

/dev/lS2qb/.magisk/mirror/data/media/TWRP

how is it ive never looked in here before?

delete the /data/media/TWRP folder and all is goodness again in Oprek...

Anyways the lesson:

To avoid:

1) if you are in TWRP, and you flash the magisk.apk as a zip, before you reboot, go to file manager and delete the TWRP folder there

OR

2) navigate to /data/media with a file manager in booted system and delete TWRP there

Afterwards doing:

y2s:/data # find / -iname "TWRP" 2> /dev/null

will return a big fat blank.....as i suspect magisk wont have mounted/mirrored it...

seems a bit obvious now...you know...with hindsight....
[Magisk] kugamu:
When I install the BusyBox-ndk-master module I get an error
[Magisk] kugamu:
I did everything as you said, but these errors are still there
[Magisk] kugamu:
I am from Ukraine and do not know English well, so I communicate through an interpreter and it makes it a lot harder to find information
[Magisk] 73sydney:
I understand completely, i have to use Firefox Addon to translate some russian android sites all the time, so something like this may make things easier, you can use it to translate an entire page or from a highlighted section of text via the right click menu

TWP - Translate Web Pages – Get this Extension for 🦊 Firefox (en-US)

Download TWP - Translate Web Pages for Firefox. Translate your page in real time using Google or Yandex. It is not necessary to open new tabs. Now works with the NoScript Extension.

addons.mozilla.org

And without getting too political (actually impossible not to) as a former infantry soldier, know theres plenty of us here in Australia would come to help if we could. The Ukrainian people have really shown their courage and determination, and may there be peace for you soon.
[Magisk] kugamu:
Thank you for your help and thank you for your kind words.
[Magisk] 73sydney:
if you see -master at the end of a file that means its a zip of the master code of a github repository and NOT the correct magisk module zip file, and its contents arent arranged correctly, leading to the error you see

Usually you would get the correct file from the Releases page on a repository, but there hasnt even been that on that repo as his module was distributed via the magisk repository and via the Magisk Manager. that system has been ended - though replaced with a standalone app here (install the apk from under Assets):

Release Release v2.0.2 · Fox2Code/FoxMagiskModuleManager

Please read the full changelog. It contains very important information on the future of this app and caveats when updating. Release notes: https://www.androidacy.com/magisk-module-download-simplifi...

github.com

Once installed, you can search for magisk modules to install and maintain them using this app

For now, to speed things up, im attaching the correct file to this post
[Magisk] kugamu:
I had this apk file installed and the busybox module from it also gave me an error, but the module you sent me worked

Thank you so much!
[Magisk] kugamu:
But unfortunately the error remained even after installing the module
[Magisk] 73sydney:
Okay you only need one Busybox module, so disable (or uninstall) one of them

Also you should install this module (if you havent already)

https://xdaforums.com/t/magisk-module-universal-safetynet-fix-2-3-1.4217823/page-91#post-87198517

and (almost certainly/usually) disable MagiskHide Props Config unless theres a specific reason you need it enabled

Also i havent tested Deny List Unmount in a while, but Shamiko is an alternative (disable Enforce Deny List in Magisk -> Settings if you try this - making sure to disable DenyList Unmount first)

Releases · LSPosed/LSPosed.github.io

Contribute to LSPosed/LSPosed.github.io development by creating an account on GitHub.

github.com

and make sure you reboot after making any such changes

theres a lot of modules for basic root hiding that do similar things (sometimes in different ways), but you cant have them all installed or active at once....so you have to pick 1 or the other

you should probably also follow this thread, as its newer than the (legacy) magisk thread we're currently in, plus it also will have links to all the modules and latest info in the opening few posts:

https://xdaforums.com/t/discussion-magisk-the-age-of-zygisk.4393877/
[Magisk] kugamu:
I did everything as you said, but the errors are still the same
[Magisk] pndwal:
FYI (& others):

Authors official releases are here:

https://xdaforums.com/t/tools-zips-...tiple-devices-platforms.2239421/post-40409356

He (@osm0sis) has myriad useful tools, scripts, flashable zips...

For Busybox NDK, scroll to 3rd section, Flashable Installer Zips, and find Busybox Installer...

Do you have Shamiko?... PW
[Magisk] 73sydney:
I do usually quote osm0sis's entire page, but was looking for brevity today :)
[Magisk] regularmen:
It's not Samsung, It's a Nokia 5. no bootloop safe to say but It seems that you know something about this?

edit : I want to add, It used to be working. I used Password screen lock before using Swipe screen lock, in Magisk 23.
[Magisk] m0han:
I have 9.5.4. Is that the latest version?
[Magisk] zgfg:
I use Chrome, Chrome translates by itself
[Magisk] dope77:
How did this issue start? Did it happen after upgrading magisk? Or you've updated your rom?
[Magisk] 73sydney:
on mine, yes...
[Magisk] regularmen:
no idea, I just wanted to use swipe for faster unlock and now I can't use password anymore. no rom updates since 2020. password still works in magisk 23. everything else is working before and still now, except this.

I'll maybe throw some logs when I'm home later.
[Magisk] zgfg:
With the latest TB Checker (v2.4.9 from Sep 28), it reports now also Virtual integrity Fail - asking is this an Emulator?!
[Magisk] gecowa6967:
Hey everyone,

I am having troubles booting the flashed boot.img. I always bootloop, as discussed here https://xdaforums.com/t/guide-root-pixel-5-with-magisk-android-13.4187609/post-87391919 I have already tried to disable all modules but is seams like they always try to load on the next boot which causes the bootloop.

I can boot fine using the original boot image.

Does anybody have an idea how to fix this without wiping my device completely?
[Magisk] zgfg:
There are three ways to disable the modules (if you didn't do on-time before upgrading the ROM).

Look at Magisk GitHub, Wiki, Module issues

Btw, Magisk Github documentation should always be the first and primary place to look

Don't know which of those three (Safe mode, adb command, disabling or uninstalling the module(s) through TWRP) did you try - try all (if they apply to your device - ie, for TWRP method, appropriate custom recovery is needed that might not be available for all/new devices)
[Magisk] pndwal:
Took a quick look, and I'm not a pixel user...

If modules are the issue, simply booting to safe mode, then immediately to system should disable modules per:

https://topjohnwu.github.io/Magisk/faq.html#q-i-installed-a-module-and-it-bootlooped-my-device-help

ADB method method given there also, but requires USB debugging enabled in developer options... PW
[Magisk] gecowa6967:
Before I posted here, I already have tried different solutions.

1. I entered safe mode from Android with the original boot image. I am unable to enter safe mode with the patched boot image. (I read online that volume - during boot should be pressed, but I still bootloop, while pressing volume - the phone vibrates every 3-4s)

2. When booting the patched boot image, I was able to run "magisk --remove-modules" during boot without an error message, but on the next boot I still bootloop. (as described in https://xdaforums.com/t/guide-root-pixel-5-with-magisk-android-13.4187609/post-87391919)

3. With TWRP I had the problem that I did not have r/w permissions to manually remove the mgaisk modules.

I have attached a bootlog. (Before I have patched the original boot image to boot into safe mode).
[Magisk] pndwal:
Interesting... Perhaps app dev now anticipates this being used in Android running in emulator per:

https://developer.android.com/google/play/integrity/verdict#device-integrity-field

I have no idea if/how we could spoof an emulator that 'passes system integrity checks and meets core Android compatibility requirements', but this could be a fun undertaking. 😝 PW
[Magisk] zgfg:
That TWRP reads but cannot write to /data/adb/modules (that's the place where modules are installed, you can delete the whole folder) - that would be strange

Usually, there is a problem with encryption and then TWRP shows corrupted file names on /data and Internal memory

And there is a problem with writing to /system - but here we talk about /data

Did you:

- provide your Android screen unlock pin when booted to TWRP

- try mounting Data as read/write
[Magisk] pndwal:
You'll need to do this with a working magisk-patched image; this relies on Magisk daemon to be running to detect safe-mode key combo and to add files for disabling modules...

Could be a different issue causing bootloop then... (or ADB issue?)

Do you mean you patched it again here? PW
[Magisk] gecowa6967:
I realized the attachment did not work. This time the file is zipped.

Before I recorded the bootloop (with the patched imaged) I was using the original boot image to boot into safe mode. But as you explained this does not have an effect on the modules as magisk itself is missing.

I thought TWRP was working when I tested is a few weeks ago, but right now TWRP is stuck at the splash screen, so I cannot test it :( probably this is because of Android 13
[Magisk] trentini:
Hello Everyone. I have an old S8+ using android 8.0 with Renovate Ice . Magisk was working fine, dont recall the version but it was old . Trying to update to version 25.2 but nothing happens. Got stuck on 25.1 and besides that I cant get Magisk properly installed, zigdysk N/A . Which steps should I take ? I dont recall if I need to format data again, but I did not want to lose all the data inside the phone.
[Magisk] pndwal:
Please say what you mean by 'got stuck'... Are you using .zip installer in twrp, or in-app patching and fastboot flash?... When does "nothing happen"?...

Re. no Zygisk, you may need to update to a ROM with kernel version 3.19+:

https://github.com/topjohnwu/Magisk/issues/5395

🙂 PW
[Magisk] trentini:
Got stuck I meant it did not update to 25.2 . Used zip installer in twrp. My noob question is if I update the ROM I lose data, right ?
[Magisk] pndwal:
Not unless you wipe or format data = clean flash... Dirty flash to keep data...

If flashing Sammy binaries w/ Odin, CSC will wipe data for clean installation, HOME_CSC won't wipe data, ie. Installation will be 'dirty'...

🙂 PW
[Magisk] mx597turbo:
I have a question regarding deny list vs magisk hide. Using hide, I can still use apps that won't normally work on a rooted device. I can also take screenshots because I am able to disable secure flag to take screenshots in some apps where this is normally blocked.

Does this work the same in apps in the deny list? If secure flag is disabled, and you still take screenshots?

Thanks. And for clarity, this is simply to be able to screenshot one time use coupons, not anything creepy or gross.
[Magisk] pndwal:
While deny can be used for hiding purposes, it is quite different and is limited compared to hide.

Hide masks various traces of root/device modification from app processes in hidelist.

Deny reverts any Magisk modifications running in app processes in denylist and prevents further modifications.

This means Zygisk modules which inject into zygote in order to run their code in apps will not work / be active for apps in denylist.

Are you trying to use a Zygisk compatible Magisk module for screenshots?

The solution for this (and many bank apps etc) is to use Shamiko or similar module to hijack denylist (which must be disabled) and use it as a hidelist...

Nb. Shamiko adds more hiding mechanisms than old MagiskHide had incl. hiding some (possibly not all) traces of Zygisk itself, but some bank apps that could run on pre-Zygisk Magisk still detect modified environment w/ current Shamiko... PW
[Magisk] gecowa6967:
My solution was to modify magisk itself. I removed the module loading part, compiled magisk and patched the boot image again. This was I was able to boot and remove all modules and then again patch the original boot image with the "real" magisk. See here for more detail https://github.com/topjohnwu/Magisk/issues/6301#issuecomment-1265164036.

Thank you all for your help.

EDIT: I have attached the binary if anybody has the same issue. But you can and should always compile it yourself.
[Magisk] pndwal:
Well done Harry... Saw your GitHub issue yesterday; had hoped you'd get qualified help...

Seem you were right re. modules being the root issue (no pun intended)...

You code may be a useful alternative for others w/ module incompatibility... Good stuff, n thanks for including solution before closing issue...

Nb @huskydg has Magisk Bootloop Protector which I use:

https://github.com/Magisk-Modules-Alt-Repo/HuskyDG_BootloopSaver

Is it HarryWindsor aka Prince Harry, Duke of Sussex, Harry Windsor (surgeon) (1914–1987), Australian cardiac surgeon and mentor to Victor Chang, or Harry Windsor, a fictional character from John Birmingham's Axis of Time? 😝... PW
[Magisk] badabing2003:
Well done, your perseverance paid off.

Clearly Magisk failed at disabling modules, shouldn't the ticket remain open?

Curious if you determined which module was the culprit.

Furthermore, it would be great to add a feature into Magisk Manager UI to set a flag for disabling modules, yes I realize that it would need to be set outside of /data/adb, why not in /data/local/tmp? rooted Magisk can check for existence of a disable_modules or similar file and not load modules.

What is the order of Magisk modules loading?

Is it ordered by Name?

If so, perhaps such flag can easily be added to BootloopSaver, but that would require people to have that module in the first place.
[Magisk] pndwal:
Possibly... Others have made various suggestions for more reliable disabling of modules etc, and these have been closed...

Same...

I think any flag in data may be difficult to set w/ the TWRP / ADB issues this user had and others may face...

Entering Safe Mode from device off state w/ needed magisk Daemon detection is fraught on some devices also... I have a longstanding issue open for MIUI (and other devices?):

https://github.com/topjohnwu/Magisk/issues/4624

It seems that Magisk detects safe mode correctly when restarted into Safe mode (this method doesn't use key combo detection) so this alternative method from @Didgeridoohan might have worked (bit late to try now 😬) if this trick actually causes a detected reboot to safe mode from bootloader/fastboot screen as indicated:

https://www.didgeridoohan.com/magisk/MagiskModuleIssues#

... I'll keep that trick in mind...

Bootloop Protector should just work as it is however as it checks looping (via Zygote Process ID mismatch for some 30 secs) before disabling modules and rebooting...

I love @gecowa6967's build-core-only-mode-magisk concept as a solution here however...

Simply adding an option in Magisk App to Magisk-patch a boot image with module loading parts disabled for emergency use seems to be a concept that may have legs and be useful for many especially when other methods to disable modules fail...

Comments?

😋 PW