yashsingh1/xdaforums huggingface dataset:
[Magisk] kyzn:
Nexus 6P

SAOSP 7.1.2, ElementalX 4.07

Google Play Services 10.5.56.

SafetyNet still passes.
[Magisk] DiamondJohn:
Have you tried doing it while in recovery?
[Magisk] mims1979:
Yea, I can do whatever I need to do in recovery. But doesn't that kind of defeat the purpose of root browser, etc?
[Magisk] culiacanazo:
What's with all this screenie postie thingie? I wanna play, too!

Oh, wait, i don't count cause i MicroG it... :(
[Magisk] teddy0209:
Magisk is about modifying systemlessly... You can just make a debloater module...
[Magisk] culiacanazo:
I once faced your problem and good ol' ES took care of it. I forgot what it was but i even bought one that supposedly could and canceled it when it couldn't, so anyways, i doubt your problem is Magisk related (check out the date of the problem I'm describing to ya)
[Magisk] arf8:
I'm livid this app does not have a Warning about tripping Knox. It tripped Knox on my Samsung despite years of Root and 0x0 Knox. Now i can't even get components like the battery replaced b/c Knox is tripped no thanks to this app.

A simple warning on Google Play for the manger which installs version 12 that not only bricked the phone on reboot but tripped Knox would have been sufficient enough. Not everyone has a tripped Knox bit and Root. Really shame.
[Magisk] culiacanazo:
You make it sound like it's a walk in the park... :cowboy:
[Magisk] teddy0209:
He's got everything here, guides, the template, and sample modules... There is a debloater module in the old compilation.
[Magisk] tech_head:
Hi,

I see you are a senior member. I also understand you are angry.

But in the announcement thread this appears:

"Magisk modifies boot image and add files to /data and /cache"

Modifying anything on a KNOX device is likely to cause it to trip.

Any root method any modifications. This mod requires TWRP and that alone is enough to give pause if you have a KNOX device.

Also, if you are in the US a manufacturer cannot deny coverage for unrelated modification and it is up to them to prove your mode caused failure.

It's called the Magnuoen-Moss Warranty Act -> https://en.wikipedia.org/wiki/Magnuson–Moss_Warranty_Act

While it was initially for cars, the usage has been expanded. Multiple phone manufacturers have seen the light when denying coverage for phone issues on rooted and bootloader unlocked devices.
[Magisk] Didgeridoohan:
Sounds like /system isn't mounted rw. Try doing that...
[Magisk] masteruniverse:
No root permission granted. Same problem with Kernel Adiutor if i change the time of apply the settings to 50seconds everything but i will use Synapse.
[Magisk] nathanchance:
Thread cleaned. If you can't say anything nice, don't say anything at all.

The Flash

Forum Moderator
[Magisk] HamsterHam:
If apps are still detecting root using magisk hide when you don't want them to try this. Worked for me.

I changed my build.prop:

From: ro.build.tags=test-keys

To: ro.build.tags=release-keys

From: build.type=userdebug

To: build.type=user
[Magisk] Flippy498:
Guys, I want you all to re-read the rules you accepted while registering for this website. Especially rule #6 since dicussions about Lucky Patcher or similiar apps are not allowed on xda.
[Magisk] dahawthorne:
"you cheat us as a community"

Absolutely right. When a typical app, written over hours/days/weeks/months, costs less than a cup of coffee, there's no reason not to pay for it.

I've bought a lot of apps, many of which I no longer use, and I don't regret buying any of them.
[Magisk] Didgeridoohan:
Yes, this is true. Many apps look for more than just the su binaries. Those two are part of the usual suspects.

Since you're using Magisk (a systemless mask) I hope you used a script or a module to change those values. Kind of defeats the purpose of Magisk otherwise... :p
[Magisk] HamsterHam:
I didn't at first, now trying to create a module. Doesn't seem to work though. Can you help? I have attached what I have done. Thanks.
[Magisk] Didgeridoohan:
You have to change PROPFILE to true in config.sh if you're using system.prop to change the prop values. From personal experience: If apps still detect the original prop values after flashing your module, try using post-fs-data.sh instead. You'll have to use the resetprop command directly though, like this:

resetprop ro.build.tags release-keys
resetprop ro.build.type user

And also change POSTFSDATA to true in config.sh (and PROPFILE to false again).
[Magisk] HamsterHam:
Awesome, all works with changing PROPFILE to true. Thanks.
[Magisk] Didgeridoohan:
Awesome! In upcoming versions of Magisk you won't have to do this through a module since there's plans for a GUI in the Manager for this. Source.
[Magisk] Artim_96:
Like I said, provide logs, we are not psychic
[Magisk] rignfool:
Listen here jerky...

You want Knox not to trip... Don't flash your phone... Do you go blaming a dev for your stupidity and impatience...

If keeping Samsung happy is high on your priorities list... Stay offa XDA
[Magisk] Citizen_Snips:
Lol did you miss the "thread cleaned" message on the last page? Just curious...
[Magisk] rignfool:
If I thought for a split second that everyone listened to the mods around here..........
[Magisk] Citizen_Snips:
That makes no sense, but okay.
[Magisk] Nomelas:
Tripped knoxx bit doesn't brick phones. That sounds like another issue altogether.

Word of advice though, if you want a better rooting and modding experience, don't get a Samsung phone.
[Magisk] rignfool:
This might be a little bit before your time... But...

Right about when you signed in (I checked your profile) there was a mass XDA exodus... BrokenOS, the dev wildchild, the dev thacube, and a few others got fed up with people blaming devs for their inability to read...

So they packed up their toys... And left... Similar to what DU is doing now...

I for one appreciate having one or 2 centralized locations to get mods for my device... Not having to spend weeks on Google trying to find that one mod...
[Magisk] Citizen_Snips:
Okay, that has nothing to do with what I said. You could've handled it differently besides flaming the person which the mods specifically pointed out just a few posts before yours when they cleaned the thread. Again, another post from you that makes no sense given the context of what was going on. Just because that's your view doesn't give you the right to outright flame someone. Also, not that it matters but I was a lurker on XDA since 2008, 2 years before I made an account.
[Magisk] rignfool:
Sorry... Didn't realize I was dealing with a pro... I'll shut up now... ??
[Magisk] Citizen_Snips:
Look all I am saying is there was a better way to go about it than to call the person stupid. You could've made your​ exact same point without taking that route. But I guess since you don't like the idea of having to follow your favorite developer on their personal social media, that gives you the right to blatantly break XDA rules?
[Magisk] rignfool:
Ok... Now you won't stop so...

If you wanna be a mod... Go apply... Otherwise...

Shut your pie hole...
[Magisk] Citizen_Snips:
Since you seem so keen on checking my profile, I've addressed that response in a previous reply. Happy hunting. And again with the flaming, wow. What exactly makes you think your flaming is going to keep a developer who's chosen to leave XDA stay? How do you justify it in your mind?
[Magisk] dahawthorne:
Guy, what's with the Mr. Angry here? There's no need to bring down the tone like this, particularly from a senior member who should know better.

Get more sleep...

(And before you write the expected response, it's my forum as well as everyone else's, and I don't like to see unnecessary unpleasantness.)
[Magisk] mims1979:
I've attempted that, but when I use mount -o re,remount /system it says system isn't in list.
[Magisk] SFCMouco:
Just like me...

Star again and run magisk 11... that one works for me and solved de account problem
[Magisk] culiacanazo:
What? It's over?
[Magisk] khangcobra:
How to pass safetynet on LoS 14.1 ?? I'm using kenzo and i cant pass it...mismatch CTS profile all the time...what should i do ?
[Magisk] bipinbedi:
+1
[Magisk] arf8:
I wish that was the case, however, Samsung does not care, if you have a tripped Knox bit they will not replace components or sell them direct to the public regardless. Not everyone goes through new phones every year. I happen to like what my phone and now I can't get an internal battery or faulty OIS ridden camera replaced any longer.

My issue is the simple fact on Play the description mentions nothing, of any kind about the possibility of modifying the boot image. No mention of requiring TWRP which I agree would trip Knox. This is a simple common courtesy statement which would help any other user. Based on the Play Magisk Manager description it appears to be a very benign app to help hide root like similar apps which do not work and manage root. Not try to root the phone itself and modify the bootloader

I did not bother reading the xda link which is entirely my fault, but again a simple disclaimer or better description of what the app does would have been more than sufficient.

First off I don't need a "rooting method" already have one and you are wrong about bricking with Magisk? It not only tripped Knox but on a locked bootloaded S-phone it causes the Carrier warning to come on next boot after it tries to modify the BL, hence bricks it as a result. Only way to restore is Odin. This is not my first rodeo!
[Magisk] 135Shadowsoul:
user [MENTION=5747496]bhb27[/MENTION] mentioned in post of his iSu thread a possible chance: clean wipe and install rom + magisk could probably help. According to his statement, playservices/safetyNet triggers with the su-initialization and safes the "device rooted" state. maybe magisk is able to hide this initialization + su binaries + unsecure props? i do not know a lot about magisk or how safetynet works, but maybe this can be a helpfull hint?
[Magisk] Citizen_Snips:
Just FYI, Magisk Hide only hides Magisk root. Installing Magisk installs root, it is its own root solution. Root and Magisk are one in the same now. As you said, not your first rodeo, always read the OP of anything before you use any kind of apps or mods like this. Especially on a Samsung. I think​ it's a bit unfair, coming in here and saying those things.
[Magisk] nthnu:
Hi, I have a Motorola Bionic. It's been rooted using SafeRoot by RootJunky and has SafeStrap 3.75 and TWRP 2.7.1.0.

Will Magisk be able to help me update TWRP? How do I get Magisk to install in TWRP, because I get a couple of errors when installing it.

On the first run I see...

- Mounting /system(ro), /cache, /data

! System installed root detected, mount rw :(

- Device platform: arm

! Unable to detect boot image

E:Error executing updater binary in zip '/sdcard/MagiskManager/Magisk-v12.0.zip

Error flashing zip '/sdcard/MagiskManager/Magisk-v12.0.zip

On a second run...

- Mounting /system(ro), /cache, /data

- Device platform: arm

! Unable to detect boot image

E:Error executing updater binary in zip '/sdcard/MagiskManager/Magisk-v12.0.zip

Error flashing zip '/sdcard/MagiskManager/Magisk-v12.0.zip

Thanks!
[Magisk] 135Shadowsoul:
cant help you with the magisk part of your question, but for twrp update, if you are rooted, there is a official TWRP app in playstore where you can download for your device a fitting twrp (inapp) and flash it (inapp, too). you can try this and try again to install magisk.
[Magisk] Skulltec:
I am not routed and I want to flash v12 in TWRP 3.1.0.0 on my Nexus 5X. I use pixelmod as rom. installation fails.

http://imgur.com/a/7aC7D
[Magisk] nthnu:
Thanks, but it didn't list my device :/
[Magisk] Didgeridoohan:
We'd need to see the full recovery log (you can save it after flashing) to be sure, but it sounds like your device's boot image isn't supported. You could upload a copy of your boot image with the recovery log to GitHub and then there could be a possibility for future compatibility (no promises).

That first run was the installation script discovering your previous root (installed in system) and removing it. The sad face comes from having to modify /system to do this, something Magisk was created to prevent having to do...

---------- Post added at 19:00 ---------- Previous post was at 18:56 ----------

Have you previously been rooted with SuperSU? If so, restore your ROM's stock boot image (assuming it doesn't come pre-rooted) and try again. Unless you want to use SuperSU and then it's just a matter of following the instructions you get when flashing.
[Magisk] Nomelas:
Sorry but it's a risk you take. Being that it's not your "first rodeo" you should already know that.

Looking at the app in the play Store, it's pretty clear what it is and what it's used for. Why else would you have installed it?

Edit: to add to your first comment, and to translate for you: I'm basically saying that Samsung phones are garbage for modding and if you want a phone to mod/root/etc, get something else. I in no way said that magisk is a better "rooting method" - you're not quoting anyone here.
[Magisk] Skulltec:
I was rooted before with super SU. Restoring boot image didn't help. I flashed the ROM and installed as new, wiped data system etc beforehand​this didn't seem to help either
[Magisk] Karls0:
[MENTION=5522456]Skulltec[/MENTION] - look at the warning: "SuperSU patched boot detected!". It means that you didn't removed root correctly and that's why installation fail. Probably you unrooted your phone only partial. If you don't have root access, it doesn't automatically mean any residues of root didn't stay.
[Magisk] HoshiYamazaki:
I can't pass safetynet on my Z1 Compact, stock .236 rom without custom kernel, root, I want play pokemongo but at manager check it does infinite load.

---------- Post added at 10:18 PM ---------- Previous post was at 10:16 PM ----------

Ok, I got reply that CTS profile is invalid. So probably untill someone make new kernel with safetynet patches it will be problematic.
[Magisk] casouzaj:
Most probably your system partition has been modified. How have you rooted it? I know it should be rooted in order to have a custom recovery inhaled, but the rooting method should be systemless.
[Magisk] Mr_GreenJeans:
Anyone know why I can wipe dalvik and cache and safteynet will pass but if I then reboot it will fail?
[Magisk] Artim_96:
I think for some reason Magisk isn't setting SELinux to "enforcing" anymore. I didn't notice it first but since I'm not even passing basic integrity anymore and I already use a module to change all build proud props containing userdebug or test-keys to user or release-keys, I used getenforce since my systems settings used to show it as permissive when getenforce returned enforcing, but now it also returns permissive.

It's possible that is because of the beta 13, but I don't know for sure.
[Magisk] :
On my phone lg v20 when flashing magisk v12 it won't get past it installing saying there's an hour
[Magisk] teddy0209:
Still working here with official v12, so might be the v13 snapshot...

---------- Post added at 02:31 AM ---------- Previous post was at 02:29 AM ----------

Don't really understand what you mean, try to be a bit more clear and provide more derails...
[Magisk] karthik km:
Is latest magisk works with 64bit devices?

But I've tried it on my 64bit device

It gives me an error
[Magisk] HoshiYamazaki:
I installed prerooted .236 firmware with dual recovery. Also, before I installed custom kernel (from what I know the firmware does not have kernel inside if is flashed via recovery due to blocked bootloader, so I must check it).
[Magisk] culiacanazo:
Probably meant ERROR instead of HOUR
[Magisk] ammar18:
Yes it does, I saw a lot of magisk users who use 64bit devices like the Samsung S7, S6, Pixel, etc.
[Magisk] Jean_85:
I'm using SELinuxModeChanger and I'm still failing with enforced mode.. To be honest Google Play warned me about that app being dangerous and asked me to remove it a few days ago, and I did it, but now I reinstalled it and I'm still in enforced mode.

Ps: I'm with a Nexus 5X with Lineage OS
[Magisk] karthik km:
Try Terminal command

Su

setenforce 0
[Magisk] Skulltec:
Flashing boot.img from original android factory ROM did fix the problem! All working perfectly now
[Magisk] Danny94:
I have installed magisk via manager app, running supersu. How i can replace supersu now with magisksu ?
[Magisk] gil80:
Hi.

After every reboot I loose Magisk installation.

This happened after switching /data and /cache to F2FS from ext4.

/System is still ext4.

How can I fix this and make this permanent?

I'm running OnePlus one and SultanXDA CM13.

Thanks.
[Magisk] Jean_85:
Done, nothing changed. I needed to reboot to?

I think I will try later to flash the stock boot to see if that fixes anything...
[Magisk] teddy0209:
You have to totally remove supersu and install magisk via recovery...
[Magisk] Danny94:
[MENTION=3615867]teddy0209[/MENTION]

well then i will flash a recovery again.. Thanks.
[Magisk] teddy0209:
Make sure there is nothing left and that the boot.img returns unmodified (just reinstall the boot.img via recovery to be sure)...
[Magisk] gil80:
Seriously, this is very strange.

After a reboot, I loose root and I have to install MagiskSU.zip from TWRP again.

Why is this?
[Magisk] teddy0209:
Maybe it's the format...
[Magisk] Danny94:
Well i flashed now twrp 3.1.0.0, but now after using supersus "unroot" i get while trying to install magisk:

info

supersu patched boot detected !

we are using supersus own tools...

flash supersu immediately to finish installation

ERROR: 1 Error installing zip file

On boot i dont have magisk or magisksu.

Even on magisk manager -> install is empty.

How to fix this please ? =)
[Magisk] dahawthorne:
Try unsu. If that doesn't clean up SuperSU, flash the original boot image and then try Magisk again.
[Magisk] nguyentankiet:
Reflash kernel and flash magisk again. It will work
[Magisk] Danny94:
Already tried unsu.

It doesn't exist a kernel for my device. Supersu is preinstalled on mi-globe rom for my mi4c.
[Magisk] Karls0:
[MENTION=4488955]Danny94[/MENTION] - SuperSU unrot just failed. It looks like binaries are removed, but patches in kernel are still there. Check if SuperSu is really preinstalled or during first boot patches are loaded. If the second option you an extract clear kernel from rom package.
[Magisk] Danny94:
[MENTION=4586683]Karls0[/MENTION]

that's a problem don't know how and if it would work to flash a boot.img from the orginal miui rom.
[Magisk] Karls0:
If you can unpack rom, you could check if SuperSu installer is included or it is pre-integrated root.
[Magisk] Danny94:
[MENTION=4586683]Karls0[/MENTION]

must be included in boot.img.

I can't read it because it's encrypted ?

https://www.file-upload.net/download-12437260/boot.img.html
[Magisk] teddy0209:
I use recovery rom zip on my mi devices, it is inside, just extract it.

Edit:

If you don't have the recovery rom zip, just download it at en.miui.com
[Magisk] Danny94:
[MENTION=3615867]teddy0209[/MENTION]

im using mi-globe.

Edit: above i added my current boot.img

I think the developer Rom (current version im using) has included supersu too (or can i take the stable boot.img too). But if i would try that how i can flash it ?
[Magisk] teddy0209:
You mean the global dev rom comes prerooted with supersu?...

Edit: you extract the boot.img and flash via twrp... i think you can take the stable roms boot.img as long as it's the base as the dev rom you are using.
[Magisk] Danny94:
[MENTION=3615867]teddy0209[/MENTION]

yes but not sure. But i just seen my current build isn't available on en.miui.

I have 7.4.6 and the latest on en miui is 7.3.30 ...

http://en.miui.com/download-293.html
[Magisk] DarkSilentSC:
E6883 using MagiskSU and Magisk v12.0. Flashing either the Audiomod module from Magisk module list or ahrion's Viper v1.3 causes bootloop.

Even worse thing is I had to restore all images through TWRP, and THEN flash system.sin to get my phone working again. Perhaps this 'vendor' mount problem is still there...
[Magisk] teddy0209:
They took the 7.4.6 down for some devices, I think they need to fix something.

---------- Post added at 02:59 PM ---------- Previous post was at 02:47 PM ----------

You can remove a problematic module using Mount-Magisk zip via twrp.
[Magisk] mims1979:
Running android 7.1.2 stock. Magisk installed fine, no errors. Most things work, but I can't modify anything in /system which means anything that tries to remove system apps, etc fail. I'm used to using supersu so I'm not too familiar with magisk.

The other issue I'm having is that after installing magisk my phone randomly freezes up. About every 10 seconds it will unfreeze for a fraction of a second and then freeze again. The only way I've found to fix it is it hold the power button until it eventually reboots. I've tried running logcat to see what is causing it, but it's so random after leaving logcat running for a while I never seem to catch it. Any ideas on how to troubleshoot this?
[Magisk] Danny94:
[MENTION=3615867]teddy0209[/MENTION]

i downgraded to 7.3.3 and got bootloop after flash boot.img with "fastboot flash boot boot.img" from miui 7.3.3 :(
[Magisk] teddy0209:
That should not happen... Did you get the same error for flashing magisk after you downgraded?
[Magisk] Danny94:
[MENTION=3615867]teddy0209[/MENTION]

yes even i tried to flash older magisk builds. There i didn't get the error but it's just nor working.
[Magisk] Karls0:
[MENTION=4488955]Danny94[/MENTION] - Well it is more then 1GB so I not downloaded your example but can you look inside zip file? You should see few folders, list here what is included in /install. Is there folder called /supersu or not?
[Magisk] Danny94:
[MENTION=4586683]Karls0[/MENTION]

the boot.img i uploaded above is just 22 mb.

yeah in the folder META-INF-> com -> google -> android ->globeRom -> tmp -> data -> globeRom

there are the following files:

supersu.sh

supersu.zip

If i delete them the boot.img can't install them anymore ?

But i don't know how to zip it again. I get the error wrong zip or something like that.
[Magisk] Karls0:
Ok, I messed with links, I was watching on full rom package. So it means that SuperSU is included in kernel, not external in rom package as I expected. It is more complicated, I would not recommend to modify boot.img by your own. Someone more experienced need to explain how to safe unroot it in this case, sorry :silly:.
[Magisk] Danny94:
[MENTION=4586683]Karls0[/MENTION]

:(. I think it's even impossible because the boot.img is encrypted too. Maybe i should ask in the mi-globe forum.

But im really thankful for your help guys.
[Magisk] patmann03:
Anyone having any issues with apps crashing and the phone crashing and rebooting? When I installed magisk I was on a clean install.

Magisk v12, Android 7.1.2 (april security patch) stock, nexus 5x. Busybox is disabled, I had some issues installing some audio mods but I removed those via the magisk app. I did edit the buildprop to add a flag so tasker could identify that the system was rooted.
[Magisk] :
When I try to install it fails to install the zip saying error 1 updater process failed

On vs995 lg v20 rooted using super su and restock rom ?
[Magisk] per4manz:
Which device are you on? Sounds like what happened to my v20. Uninstall Magisk 12 via TWRP and then immediately install 11.6 (both before rebooting). Solved my problems.

---------- Post added at 08:57 PM ---------- Previous post was at 08:53 PM ----------

Magisk can't root if the boot.img you already have installed is rooted. I reinstalled stock 10L kernel (boot.img) and then I was able to install Magisk.

Do yourself a favor though: download the Magisk uninstaller and Magisk 11.6. Put both on your external card. See my post above about not using 12.0 on v20 devices.
[Magisk] patmann03:
I'm on Nexus 5x
[Magisk] per4manz:
Still may want to try 11.6 to see if it solves your issues.