yashsingh1/xdaforums huggingface dataset:
[Magisk] systemizer99:
Thanks for the feedback. Here is two DevCheck screenshots - one from stock device (without root) and another one is from debug version (with ADB root). But we cannot use such root because it works only after "ADB shell su" from a PC terminal, doesn't give root rights for the applications and we cannot take RW right for system partition

I saw you have Nokia 2.1 - maybe you could help with our problem with Nokia!!

Thanks
[Magisk] pndwal:
Don't think you'll get r/w /system at least w/ stock Android 10 or later any more due to shared blocks implementation:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85049195

Magic Mount is the new way to 'write' to /system w/ Magisk systemlessly.

Also, you can rebuild whole filesystem to overcome OEMs locking /system to read only by using an automated bash script by XDA member @lebigmac to "Universally Mount System read write"... BUT (big but), you MUST be adventurous / maverick / a 'Power User' / know your stuff!

I posted info on these two methods here:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84859571

Back to root problem; Here is one open issue that may be similar to yours, I'm not sure. John asked and 32 bit confirmed, no proper fix since, but OP does include a method to gain root for that device (patch getinfo.cpp to make init.cpp call SARInit or RecoveryInit. I'm guessing this may be for Magisk in recovery only). It's a bit beyond my experience/knowledge , but may help.

https://github.com/topjohnwu/Magisk/issues/3703

Sorry to mislead in my profile - I added Nokia 2.1 to 'Your Devices' yesterday as it's an easy way to check available threads and since I couldn't find much re. root for your 2.3 I was checking Nokia 2 series.

I've added / removed many devices for checking purposes, but Nokia ones recently are devices I've considered purchasing just-for-fun from second-hand listings as I like ('love' may be too strong a sentiment 😁) the Android One concept, Xiaomi and others have dropped the ball here, and Nokia's exclusively A1 range makes great sense to me; I, like many others, simply want best value hardware w/ 'pure' Android!

My current devices are Xiaomi Redmi Note 8T (Stock, Magisk Alpha; great hardware, bloated MIUI) and Xiaomi Mi Pad 4 LTE (LOS 18.1, Magisk Alpha, great device to customise). Previous experience with several old Lenovo tablets, and Huawei Ascend Y550. 😉 PW
[Magisk] 73sydney:
We need to get you into #PixelLyfe :)
[Magisk] pndwal:
Two additional thoughts:

Is it any different if you boot only to Magisk-patched boot.img? (fastboot boot magiskpatchedboot.img)

Have you tried older Magisk, eg 20.4, in case there's a regression? (many recent issues are.)

Nb. You'll need to download / install older manager, (always Uninstall other Magisk Manager / App first, and DON'T patch with Manager/App hidden) and (pre 22.0) put URL for associated raw json file in Custom channel to use non-current Magisk builds for patching. Eg, for 20.4, Manager is here:

https://github.com/topjohnwu/Magisk/releases/tag/manager-v7.5.1

stable.json is here:

https://github.com/topjohnwu/magisk_files/blob/63555595ffa9b079f3a411dd2c00a80a3d985ccc/stable.json

But you need to use (Paste in Custom channel) URL for raw file, so click 'view raw' from menu, and save URL for that, ie:

https://raw.githubusercontent.com/t...5ffa9b079f3a411dd2c00a80a3d985ccc/stable.json

If you can do either, you should then be able to install latest App and see Direct Install method, which may work to update / make root permanent... Long shot, but may be worth it. 🤠 PW
[Magisk] systemizer99:
This variant doesn't work

Wow!! It really works with 20.4 + 7.5.1 . Thank you very much for help!!!

Do we need to update magisk manager now or left 7.5.1 ?
[Magisk] pndwal:
Great!

Do you mean in order to update Magisk? You should use last manager released at time of a particular Magisk build release to ensure compatibility. - Check build dates to determine which Magisk, then download appropriate Manager and find correct json to copy URL for hosted raw file... (Nb. This won't work with Canary builds; they need customising / re-hosting so as not to simply default to LATEST debug build, but works fine for specific public releases.)

... You don't need to update, but may have advantages, eg better / improved MagiskHide (for bank apps detecting, etc), module compatibility, etc.

Besides, just good to know if you can!... Even if bootloops or get message 'system is corrupted' etc, just keep working patched image and reflash to fix! (Then downgrade app again).

Just knowing which is latest working Magisk build (trial and error) would be very useful info if you choose to help with compatibility by opening a GitHub issue. This will significantly reduce the pool of commit(s) that may have caused the regression! 😜

Great to know this Nokia device can be rooted w/ Magisk though. All best, PW
[Magisk] tazcan:
hello i just tried to update my device (mi 9 se) to miui 12.5 which is android 11 but with trying to install magisk i cannot boot(it just hangs on the MIUI screen) i tried using recovery and patching the boot.img what more can ı try?
[Magisk] pndwal:
Did you have Magisk installed previously?

Nb. You should have restored stock images for any changed before taking OTA. (boot.img, recovery etc)

If you did, you likely have modules set up that now conflict with latest MIUI, and cause bootloop when Magisk root is activated.

If so, try booting to Safe Mode, then immediately after, to system. This will disable modules and will fix bootloop in this case.

Nb. As in the case of other Xiaomi devices, even with Ramdisk= no, install Magisk in boot, not in recovery. Ie, flash zip package from a working TWRP, or patch boot.img / Direct install with Recovery mode UNSELECTED.

Also, it is VERY likely yours (for QCom SDM712?) is a similar issue to the MANY known current issues with A11 and Magisk. Eg currently:

- Xiaomi, MTK MT6893 -

https://github.com/topjohnwu/Magisk/issues/4447

- MTK mt6763 -

https://github.com/topjohnwu/Magisk/issues/4438

- QCom SDM632 -

https://github.com/topjohnwu/Magisk/issues/4435

(Similar Snapdragon 700 series device, this Dev knows his stuff too.)

- Xiaomi, MTK MT6833 -

https://github.com/topjohnwu/Magisk/issues/4421

(Seems flashing "empty" vbmeta fixes this for Xiaomi Poco M3 Pro 5G / Redmi Note 10 Pro 5G. Solution: https://xdaforums.com/t/root-gained.4290689/ )

- QCom SM8150 -

https://github.com/topjohnwu/Magisk/issues/4408

... And there are several more too to read too. 😬

Also, please can you confirm yours is QCom SDM712 SOC? PW
[Magisk] tazcan:
I didn't OTA, i dirty flashed the new Rom from TWRP.

yes indeed it is 712. I did make it boot again rooted by doing a 4 wipe and installing again, buti installed the same modules so i don't think it is the case. (but it can still be the case) I didn't know about booting the safe mode wish I knew that yesterday.

But now my twrp cannot decrypt the storage if i boot up from the phone itself but it can if i boot using fastboot is there a way to turn off the encryption on the phone?

Sorry about asking many questions and thanks very much for the help
[Magisk] pndwal:
Yes, full wipe removes Magisk data / modules in /data/adb, and some may require setting up in A11 environment to be configured correctly, so module conflict may have been the issue.

So Magisk is now working fine?

TWRP will not be compatible with A11. Incompatibly is why John has deprecated zip install method; I recommend moving to patch / flash boot.img from fastboot in future, especially w/o TWRP compatibility.

https://topjohnwu.github.io/Magisk/install.html#custom-recovery PW
[Magisk] justDave:
You don't need TWRP to sideload a zip.

Also, I've found that the patch/flash method has to be repeated after each OTA but that the sideload install survives upgrades.
[Magisk] Elyey:
Hello everyone

Is there any module for Magisk for screenshot in anywhere app?

Like screenshot secret chatroom in Telegram, for example, or screenshot in banking apps.

Or do I need to look for another program?

Sorry for my bad english
[Magisk] justDave:
There are a couple of Xposed modules that can do that but I don't think it can be done with just magisk.
[Magisk] tazcan:
yes now it is working perfectly, device is also passing safetynet with the module installed, thanks very much for your help and insight
[Magisk] pndwal:
AFAIK you do need a custom recovery, even to ADB sideload zips...

Are you saying there is a way to flashing Magisk zip installer w/o custom recovery? Or suggest using different recovery? Or other method?

Well, OTA requires all stock images to be restored first, so, apart from Magisk modules (best to disable for OTA) and settings (these are in /data/adb), Magisk (mask) survives in NEITHER case unless you risk OTA update w/o restoring boot.img (which will most likely result in bootloop if OTA includes any incremental update to boot.img).

https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md

If you meant modules / settings don't survive patch/flash, you have probably chosen "Complete Uninstall" from App before taking OTA. Only "Restore Images" is necessary, and modules / settings will survive in this case too. 👍

Nb. Some A/B devices can take OTA and preserve Magisk using flash-patched-image-before-reboot method:

Method here:

https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md#devices-with-ab-partitions

🤠 PW
[Magisk] pndwal:
I use my stock OS (MIUI) screenshot setting to do this from any screen. (Settings, Button shortcuts)... I use default 3-finger-down-swipe, and can then snap simple screen, or scroll down first to snap a complete (long) page! 👍

If OS doesn't include a similar feature, I guess you may be able to use a 3rd party app. PW
[Magisk] justDave:
I suppose I'm using a custom recovery. The one that ships with LineageOS.

LineageOS seems happy to do OTA updates with Magisk in place but I suppose it's a special case.

When I first installed Magisk using a patched boot image, I'd have to reinstall Magisk after each OTA. Back when I could do this in Magisk Manager it was only a little annoying. Once the option to install after OTA was removed I actually had to manually patch and install after each update.

But after once installing the zip file via sideload, I haven't had to reinstall Magisk since.
[Magisk] HippoMan:
Hmm ... I think that depends on what you mean by "custom recovery".

I know that LOS ROMs and also some ROMs that are LOS offshoots now automatically install the LOS Recovery, and that recovery indeed offers ADB sideload.

But perhaps you might still consider that to be a "custom recovery", because LOS is generally considered to be a "custom ROM".
[Magisk] casouzaj:
All the smartphones I owned so far take a screenshot by holding both the power and volume down buttons, until a screenshot being taken animation comes up.
[Magisk] pndwal:
Yep, custom recovery w/ ADB sideload support. (Even stock recovery embed such support now, but not for zip Installation as I understand it; can sideload stock ROM updates even with locked bootloader.)

Still, LOS recovery is likely more compatible with A11, especially w/ 18.x, but I have no idea if it can be flashed and used w/ stock MIUI 12.5.

I was commenting specifically about users existing TWRP custom recovery's compatibility, and John's general comments about custom recovery detection / compatibility issues leading to new patch/flash method and depreciation of zip Installation method.

When you say OTA, are you meaning "over the air"?... (Some custom ROMs only provide notification OTA, but ROM is flashed directly through recovery).

If true 'OTA' and you haven't done prescribed restoration of 'stock' (really just unpatched) images before OTA update (Nb. Complete Uninstall option is not necessary) you may just be lucky for one of the following reasons:

- addon-d survival script was added for Magisk in Custom ROMs ( https://github.com/topjohnwu/Magisk/commit/9430ed66cd6bc1f80442f051d31b5e535387bb7b ) and will reflash Magisk after Update. This may work only w/ zip Installation, I don't know how patch method implements it... Won't help user with MIUI anyway.

- LOS may well have other mechanisms to detect Magisk-patched boot image and be able to prevent OTA causing corruption (eg by restoring unpatched boot image first).

- LOS may seldom update boot.img, so patched one / root is unaffected.

- LOS OTA may include full images rather that the incremental bit-matched overlays used by stock OTAs, so even if boot.img is updated you'll still boot, but will loose root.

Nb. If LOS does use incremental updates however, you will likely experience 'corrupt system' message (ie really meaning boot.img) / bootloop if/when OTA ever includes a boot.img update. PW
[Magisk] pndwal:
Yep, if it's not stock it's custom! See post above... 😜

Note Instructions for official LOS for RN8T (my device):

https://wiki.lineageos.org/devices/ginkgo/install PW
[Magisk] ipdev:
Backup/Restore scripts live in /system/addon.d/

The only way to install one is to mount system read-write.

Note: Mounting system as read-write can bork the system on newer devices.

Most custom roms support addon.d

99-magisk.sh is only installed with the Custom Recovery method.

When Magisk is installed using the Custom Recovery method, it will..

Find and dump the boot partition.

Patch the dumped image and flash the patched boot image.

Save the original image dump to /data/magisk(hash-value)/

Install the stub version the Magisk app.

Check for addon.d support.

If supported, the script 99-magisk.sh will be generated and placed in /system/addon.d/

---

The Select and Patch a File option will only patch the image file supplied. ;)

Note: No backup is saved.

To uninstall you need to flash the original image back to the device.

---

The Direct Install option will..

Find and dump the boot partition.

Patch the dumped image and flash the patched boot image.

Save the original image dump to /data/magisk(hash-value)/

Custom rom recovery (lineage, crdroid, aex, DU, abc, ...), should be fully compatible with it's corresponding system.

Recovery is part of a system build, especially if it is a recovery-in-boot device.

The limitation of them is just that.

They are designed to work with the system they are built with and do not include extras.

Some installer zip files may not work with custom rom recoveries.

Signed/unsigned zip files may give issues..

The lineage recovery might work for a sister rom like crDroid. ?​

Most start with ADB disabled, and enable it only when you start the sideload option.

Normally they have an option to enable ADB under an Advanced option.

A custom recovery like TWRP, is built using a system build as a base (normally Omni or Lineage).

The separation happens by adding/replacing the appropriate sources with the TWRP versions.

Note: Recovery is a mini-system build.

It is a bootable Android environment just like the main system(rom).

Number three is correct.

- LOS OTA may include full images rather that the incremental bit-matched overlays used by stock OTAs, so even if boot.img is updated you'll still boot, but will loose root.

Lineage builds are full builds.

Everything is built, even if no changes were made.

The OTA update will notify and give the option to download.

If you have it set to Auto Update, it will download it automatically.

Then notify you to reboot once the download is complete.

Normally I just download and update by flashing in recovery.

I have not used the OTA updater since "cm" days. ;)

Unlike the CyanogenMod days, Lineage is more by the book.

For good reasons. ;)

Official Lineage builds are restricted to following their charter.

LineageOS Charter - GitHub - Link

Cheers all. :cowboy:

PS.

I know you know quite a bit of the above.

I included a lot so those not familiar with steps/procedures could hopefully follow along.
[Magisk] ipdev:
You should give it a try. ;)

Lineage is not my personal preference but, it is in my top three. 🙃

Lineage is the rom I use on quite a few devices.

I like it better than MIUI. :p

Nice to have control over my device without having to be logged into mi-account or work around it.

Example: Enable adb install on miui OS when not logged into mi-account - GitHub - Link

Cheers. :cowboy:
[Magisk] pndwal:
@ipdev

Thanks for the insightful forensic analysis! 😀

Totally agree - I have LOS on old Ascend Y550, old Lenovo tablets and Mi Pad 4.

I think I'll have it (18.1 unofficial) on RN8T in near future.

What's your No. 1 & 2 preference?

Nice script! 👍 PW
[Magisk] ipdev:
Ezio's abc rom is my favorite. :D

ezio84

[GitHub] - Link

There are ports for Pixel 4 and above.

Android Builders Collective - [Learn][Build][Share]

xdaForum - Link

---

Save for ABC.

GZR/Validus - Link

AospExtended (AEX) - Link

LineageOS - Link

crDroid - Link

DirtyUnicorn - Link

Links are to GitHub.​

Favorite roms are a personal preference. ;)

I do not need a lot of modifications so, I tend to lean to AOSP based roms with less modifications.

Lineage is a staple of the custom rom community and a lot pull/modify from lineage sources.

crDroid is a sister of Lineage and includes more modifications and changes that Lineage will not allow.

crDroid GitHub - Commit - Commit​

DU [Used to be number one, two or three. (Depending on the device.)] is officially EOL. :(

xdaArticle - Link

GZR lost a lead (and very loved) member last year.

xdaArticle - Link

I am not part of the GZR team but, everyone makes you feel like family.

Anyone who crossed paths just briefly with Martin, will miss him.

I miss him and happy that I was able to briefly cross paths with him. :)​

Those are my personal preferred roms. 🙃

Cheers. :cowboy:
[Magisk] bosr:
I would like to flash Magisk to Redmi Note 10S with ROM 12.5.8.0.RKLEUXM (EEA)

Device is unlocked, developer mode on, usb debug on, adb installed, drivers as well.

Since there in no TWRP available for RN 10S yet, the only way seems to be using patched_boot.img and fastboot but patched_boot.img done either by magisk v23 or v22 caused that device is stucked in fastboot mode (no way to reboot) the same with canary version.

So called working magisk v21 is impossible to install w/o twrp (which is N/A yet)

Is there any working solution how to achieve installed Magisk to RN 10S?
[Magisk] Gregbmil1:
I tried out the Aurora store but am I missing something? Why would I want to install the module? Is it for people that want nothing to do with Gapps or Google at all?

GitHub - whyorean/AuroraServices: A privileged extension for Aurora Apps - Gitlab Mirror

A privileged extension for Aurora Apps - Gitlab Mirror - whyorean/AuroraServices

github.com
[Magisk] pndwal:
I really know nothing about this, but just read it's "Aurora's android client for F-Droid", and needs to be installed as a system app. They offer APK or Magisk module, I'm assuming because module (Systemless overlay) is both an easy way to install a system app, and is probably the only way to install on stock Android 10 or later due to no r/w to system. 😜 PW
[Magisk] Mr Dini:
Hey,

I am using Pixel Experience on my Mi 9T and would like to bring back the feature from MIUI that the FM radio app works without connecting the headphone jack. I figured the original FM radio apk is at: /system/system_ext/app/FM2/FM2.apk so I grabbed it, used apktool to extract it, patched the smali and built it again. Then created a magisk module that simply just replaces the original apk file and does nothing else. However I got stuck with the signing part. I tried to sign it with the platform keys android provides, with the test keys or my own one, in all cases the new apk didn't work as expected. I get

AndroidRuntime: java.lang.RuntimeException: Unable to create service com.caf.fmradio.FMRadioService: java.lang.SecurityException: Must hold the MODIFY_PHONE_STATE permission.

all the time.

I assume this is because I didn't sign the APK with the rom's platform signature which I obviously don't have. So my question is, how could I use magisk to somehow replace this FM2.apk and then it would work?

Thanks
[Magisk] pndwal:
Did you update ROM / have Magisk installed previously?

If you did, you likely have modules set up that now conflict with latest MIUI, and cause bootloop when Magisk root is activated.

If so, try booting to Safe Mode, then immediately after, to system. This will disable modules and will fix bootloop in this case.

Also, it is VERY likely yours (for MTK Helio G95) is a similar issue to the MANY known current issues with A11 and Magisk.

I linked some here:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85274483

Note ref to Redmi Note 10 Pro 5G issue (MTK device also) and solution (workaround) incl. XDA link; this is likely similar / a fix for your device.

Well not impossible! Pre 22 builds can be installed using json URL / Custom channel. I mentioned method recently:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85266767

... And please say where you read it's working for your device!

... Please let us know! 😜 PW
[Magisk] Gregbmil1:
Yeah but I have a S8 with no service laying around. I installed the apk on that and it seems exactly the same as having the client installed. I did have the module installed at one time. I just don't understand what the purpose of giving a 3rd party app store root privileges with automatic installs and updates. Makes me wonder what really is going on, lol
[Magisk] pndwal:
Oh, I have no idea (or experience) about that either!... I was just having a stab at your original question, "Why would I want to install the module?" 😬 PW
[Magisk] 73sydney:
I'll just throw my 2 cents in, i use Aurora Store myself for some updates as some updates/apps are not offered through Google Play for my Pixel 2XL (even unspoofed), that Aurora does show. I have never installed the installer service, or use any of them, instead, i enable Settings > Downloads > User External Storage (enable) in Aurroa Store, then when an update has downloaded, i cancel the installer prompt, and manually install it by going to /sdcard/Aurora/Store/Downloads/<packagename>

Works perfectly well for single (unsplit) apks, for split APK's, well thats what SAI is for...hit Install in that and navigate to the same folder tree as above.
[Magisk] bosr:
I have not updated ROM / installed Magisk previously

When I flasheh patched_boot.img (patched by Magisk manager v23) the only possible action is reboot back to fastboot. It was not in the bootloop. The only way to return back to normal was re-flash back original boot.img.

The solution with patched boot.img is described here https://www.naldotech.com/root-xiaomi-redmi-note-10s-magisk/ but apparently it does not work as it should.

Going to test workarounds if I am able to do it

Thank you for returned me back to the ground :)
[Magisk] HippoMan:
Thank you.

It turns out that when flashing some ROMs, we get LOS Recovery installed by default, whether we want it or not.
[Magisk] DiamondJohn:
I cant answer your final/real question, however, regarding installing the permissions for the AP, the following utility I built has a method that systemises apps using shell scripts to create a Magisk module, and it utilizes AAPT to interrogate the APK to add the permissions into the system. You can find the function in the menu at: Magisk>Modules>Systemize OR Revert An App>Systermize An App>* Its all done with viewable shell script, so you can preview / extract the script before running, by long pressing the last menu path and choosing "Preview". Or run it and see the permissions created in the module (as well as retrieve the script). I wrote it a while back, and haven't really tested it personally in anger.

[APP][TOOL] TeMeFI comprehensive system Administration

TeMeFI This app provides/returns a bucket load of information regarding your device and the currently running ROM, and much, much more. And hence the name "TeMeFI"; as its Too Much F????? Information. The F stands for whatever your comfortable...

xdaforums.com