yashsingh1/xdaforums huggingface dataset:
[Magisk] ktmom:
I'm guessing you have a OnePlus 7 Pro based on your post history. Have you followed the steps outlined in this guide in the guides section of your device forum? My suggestion is for you to return to a known working state; probably a clean install of whatever you are running. Boot, setup the device then install Magisk manager and patch your boot.img then fastboot flash it to the currently booting slot. I'm sure there are guides or previously asked questions in your device forum on how to do this. Note: on an A/B slot device, always boot to system before trying to flash something like Magisk in recovery so it's being flashed to the active slot. Additionally, there is much to be said for not installing TWRP but fastboot booting it so both TWRP and Magisk are not trying to modify the same boot.img. Most A10 devices do not have a working TWRP at all.

If you have problems you will want to have carefully document the steps you are taking, including what ROM including version (stock or which custom) and post that information in the device forum Q/A section. I would think others will have experienced similar problems before.

It wouldn't hurt to search and read up on the theory behind slots and the Magisk installed docs, including the linked pages.
[Magisk] scrin378:
Yes, i have op7pro! Im on stock rom, with unlocked bootloader, and TWRP installed! I only wanted to install custom kernel, nothing else ;) like i said, already tried with patched boot.img, but again after reboot i ended in bootloader with stock recovery.. yes, i think both magisk and twrp are trying to modify same boot.img and dont know how to avoid that..

Dont know, maybe return to complete stock and try again ;)

Thanks for help ;)
[Magisk] ktmom:
Commonly, the device is rooted while using the stock setup. Then, after rooting and a reboot, the kernel is flashed from the Magisk manager or using something like Ex kernel manager or FK Manager.

Again, device specifics would be in a device forum. What works on my pixel may not on your device :good:
[Magisk] HippoMan:
Updating TWRP via MagiskManager?

I want to update TWRP to a newer version, and someone told me that this is possible via the MagiskManager.

I didn't realize that MagiskManager has this capability. If so, how could I upgrade my current TWRP version (3.3.1-70) to a newer TWRP version (3.3.1-76) using MagiskManager?

I'm running Magisk 20.3 and MagiskManager 7.5.1 (267), and my device is a OnePlus 7Pro (GM1917) running OOS 10.3.1.

Thank you in advance.

.​
[Magisk] ktmom:
MM -> modules -> the + button

Before you do this, reboot your TWRP and take a nandroid, just in case [emoji6]
[Magisk] HippoMan:
Oh! I didn't realize that non-Magisk modules could also be updated that way. So I assume that I would select the same TWRP module that I would normally flash through the bootloader, correct?

Any other steps in Magisk? ... such as, perhaps, flashing the A/B retention module? Or should I NOT do that, because of the fact that I'll be installing a new version of TWRP?

And after flashing TWRP in that way, will I need to go to recovery and re-flash Magisk?

And should I flash TWRP again via recovery, to make sure it gets into both the A and B slots?

And yes, I am addicted to nandroid! :)

Thank you!

.​
[Magisk] ultradj83:
MAgisk Module for Android Q

Hi there.

As Android Q doesn't allow to mount r/w the system partition, I'm creating a very simple module to inject file /system/vendor/etc/mixer_gains.xml on my S10+.

This file simply manages audio gains, I modded it to have louder volume.

Well, I followed the official guide for modules creation building the attached module, but it fails to install with no details:

Copying zip to temp directory
Installing DACboost.zip
Installation failed

Any suggestions?

Tks everybody!
[Magisk] Didgeridoohan:
Your update-binary is a html file rather than the required module installation script... You need to download the raw script, not the Github page.
[Magisk] ultradj83:
Well, now installation succeeds, but the module doesn't work.

It should replace /system/vendor/etc/mixer_gains.xml but it doesn't, opening that file I see it's the original file.

I added that file in the /system/vendor/etc/ in the zip, then I added in the config.sh

REPLACE="
/system/vendor/etc/mixer_gains.xml
"

Did I miss something?

Tks a lot!
[Magisk] Didgeridoohan:
The REPLACE variable is for replacing directories with an empty one, not for files. Any files places under the module /system directory will automatically replace their counterparts in the system directories. Other than that it looks like your module should work.
[Magisk] ultradj83:
Well, not only it didn't work, but I broke Viper4Android, which is another installed module.

I need to find out if Viper works on the same file or directory, but I couldn't find where Manager downloads the zips...

Thanks.

---------- Post added at 05:10 PM ---------- Previous post was at 04:58 PM ----------

Removed Viper4Android and Audio Modification Library modules, my module works.

I'm now searching for confilicts...

Just in case, any ways to sort modules loading in order to make my module overwrite that file as last?

Tks!
[Magisk] Didgeridoohan:
If you've got V4A installed and it's also replacing that file you're better off just editing the file directly in the V4A module directory under /data/adb/modules.

Only one module can replace a file, and if I can remember correctly it's whatever module was installed first that takes precedence.
[Magisk] ultradj83:
Well yeah I was thinking about that but I can't find /data/adb/modules.

Is it possible I don't have cause on Android Q Magisk is mounted elsewhere?

Moreover, if I'll find it to edit my file, will the modification persist upon reboot?

Tks!
[Magisk] Didgeridoohan:
You sure you're looking in the right place? Not in /data on your internal storage. This is /data found in the root of your device (/), and you'll need superuser access to access it.
[Magisk] ultradj83:
Yup, I don't have that folder in /data.

This might be because Magisk on S10 with Android Q is installed in the recovery partition, and I have no idea how to mount it...

PS: in the meanwhile I achieved my goal by editing the Audio Modification Library module: https://we.tl/t-Mu894EbvYz .
[Magisk] Didgeridoohan:
Now I'm curious... What is the output if you run the following in a terminal emulator?

su -c ls /data/adb
[Magisk] dimm0k:
just updated to the latest March update for the Pixel and going through the usual of patching the kernel and flashing. this time however it keeps booting up to a blank screen. any suggestions?

EDIT: while it's a blank screen, it's not completely blank as I can power down and see the menu. other than that I'm stuck, help!
[Magisk] ultradj83:
You're right it exists.

I'm a bit confused...

Now it shows also on Root Explorer, before it didn't.

And I'm still not drunk...
[Magisk] EVR_PR:
Just updated my Pixel 4 to the March update and Magisk is failing CTSProfile. Is anyone else having this issue and a possible solution to fix this? For what it's worth, I installed the ATT version.
[Magisk] Didgeridoohan:
Is it failing only CTS, or basic integrity as well?

If both, try toggling MagiskHide off and on.

If only CTS it could be that Google forgot to certify their own build. :D If that's the case they'll likely fix that shortly.
[Magisk] EVR_PR:
Just CTSProfile. Tried turning Magisk Hide off and then back on again, and nothing. I don't touch the settings at all and only have Preserve force encryption on. Have never had a problem until this update.
[Magisk] emanresu2:
How do you unhide com.android.webview from MagiskHide affected apps?
[Magisk] Didgeridoohan:
It is perfectly possible that Google actually did mess up the certificate for this build (I believe something similar has happened before), and if so it's just a matter of waiting for them to fix it on their end.

But, if that was the case I think we would see a lot more reports coming in. You haven't done any other modifications at the same time as updating that could be the culprit?

You could use my MagiskHide Props Config module to change to last month's fingerprint and see if you pass CTS with that (which could be an indicator for if Google did screw up or not).
[Magisk] Didgeridoohan:
I'm not sure what you mean. Could you be a bit more detailed as to what you're trying achieve and why?
[Magisk] Archangel:
Yeah same thing here for my Pixel 3a. After fastboot flashing the March magisk_patched.img it boots and the screen doesnt allow me to do anything?

edit: nevermind did it again and all is well
[Magisk] a871164854:
same things happen, but then I found that I was flashing the FEB boot.img, check yours
[Magisk] emanresu2:
I'm using a custom webview, package name com.android.webview.

MagiskHide apps will crash when loading WebView because it can't find com.android.webview, but non-MagiskHide apps works.
[Magisk] Didgeridoohan:
Do you mean that you have a Magisk module that installs webview systemlessly?

Whenever an app on the MagiskHide list starts all modules are unmounted, meaning those apps can't see them. If you then have webview as a Magisk module, those app can't access webview. I've never seen reports about this before, or tested something like it so naturally I'm just throwing out guesses based on my understanding of how Magisk works (and my guess on what your issue is)...

Solution: don't use a webview Magisk module and see if that works better.

If my assumptions about your issue is incorrect, please be more detailed in your next reply.
[Magisk] onesolo:
Did you guys received the OTA notification or applied OTA manually and then applied magisk afterwards ?!

This month I still haven't received the updated notification from OTA!! And last month the same thing. Last month I also had to manually update, I waited several weeks (did not had the time to manually update). I think Google has changed something on the OTA procedure that if the system is modified by magisk, it doesn't show up nothing. Before february I didn't had any problem, after a few minutes or hours from the release of OTA I always got the OTA normally.

Yesterday on the first manual checking's, I did get a quick glimpse saying that it was preparing for the update but in a fraction of second disappeared and I never got back the preparation on the update screen...

Pixel 3 here...
[Magisk] rogers11:
Yep, same here (Pixel 3a).
[Magisk] onesolo:
I'm on a telegram of Pixel phones and several ppl with Magisk also didn't receive the ota last and this month
[Magisk] EVR_PR:
No modifications except for rooting itself and updated using the factory images method and flashing Magisk on both slots.

I went ahead and installed your MagiskHide Props Config module and it worked perfectly, back to passing safety net.

Also I think most people will install the first build since 004.A1 is exclusive to AT&T.
[Magisk] Didgeridoohan:
That's been reported about for a couple of years now. Some Pixel devices never get the OTA with Magisk installed, but have to install manually. As far as I know, no-one has bothered to figure out why.
[Magisk] emanresu2:
Exactly. This is what happens. The setup is exactly what is running right now.

Thank you for the explanation.
[Magisk] onesolo:
But I did before February
[Magisk] Didgeridoohan:
Just because something used to work doesn't mean it will continue to work indefinitely...

Like I said, there are many users that have been experiencing this for years. And there are users that never have.
[Magisk] selemine:
I have a Xiaomi/Poco Beryllium Device. Using the Magisk Manager 20.3 i tried to update Magisk to 20.3. Something went wrong but i didn't write down the error.

Now after a reboot i can only choose between default fastboot mode and TWRP as recovery.

When i try to install magisk 20.3 from within TWRP again, i get about this log:

installing zip file /sdcard/magisk-v29.3.zip

Checking for digest file

Magisk v20.3 Installer

-mounting system

- mounting vendor

Encrypted data, keeep forceencrypt

target image /dev/block/sde45

device platform arm64

constructing environment

unpacking boot image

unsupported/unknown image format

unmopunting

"error: !"

updating partition details

... done

then i tried to flash the magisk uninstaller zip to get a clean state.

this fails with "cannot access data, use magisk manager".

What should i do next? I only know the case where the system boot logo with the Poco text in yellow letters shows forever, not the stuck in fastboot case.
[Magisk] ilal2ielli:
Google did forget. They pulled the link to the ATT build but it's still on the server.

I downloaded the build, then found out about this certification issue.
[Magisk] Frostbiter:
I've had the same issue happen too on my pixel two. Wasn't getting updates, then I started getting them again. Didn't get the February one but I was going to get the March one but something happened and now it no longer shows up.

I had gone to check if the update was going to show up so I tapped check for update, saw preparing system update, switched to magisk manager to restore my boot image, switched back to the update and it said I was up to date, hit check for update again and it now just says I'm on the latest update. Not exactly sure why it at least appeared like it was going to work then it stopped for some reason. Idk if that would be a helpful bit of info or not.
[Magisk] Didgeridoohan:
And it isn't the first time... I knew I'd seen this happen before, so I dug back in the annals and found that it was the Nexus 6, exactly three years ago. They fixed that with a new build rather quickly, but it just got worse after that with a forced downgrade for those that wanted to keep getting security patches. Story here for those that are interested:

https://www.xda-developers.com/google-rolling-back-nexus-6-devices-android-7-nougat/

Sorry about the OT, it will now stop. :good:
[Magisk] Audioboxer:
My OTAs were working fine on my Pixel 3 for about 6~7 months but then I got stuck on January. No Feb update. I didn't think much of it and thought maybe it'll fix itself for March, but no OTA. I usually do the restore image, OTA, install magisk and reboot method.

Uninstalled Magisk completely and tried to get the OTA, still nothing. Just sideloaded Feb and it works fine. Will wait to see if March pops on my Pixel 3 via OTA without root.
[Magisk] DOMF:
I'm on a P3XL and always patch the boot.img manually with magisk before manually flashing. However, this month, magisk closes immediately after I click "let's go" in Magisk to patch. I've tried clearing cache/data in Magisk Manager and that didn't help. Here's the output from a logcat showing the crash:

https://bpaste.net/CGPA
[Magisk] Didgeridoohan:
You're using the Canary Manager, right? That's a known bug with Canary Manager 277.
[Magisk] DOMF:
Aah! Thank you! At one point, Canary was required for my device and I never switched off of it. *EDIT* That was definitely it, flashed fine now, and I VASTLY prefer the old pre-canary interface, thanks again!
[Magisk] Spaceminer:
Moto G7 Play

Magisk can't make changes to /vendor or /oem. Does anyone know why? If I delete/add a file in either or those partitions with a root explorer, it reverts as soon as the partition is remounted. I've tried manually remounting and deleting with a terminal, and it still doesn't work. (I'm not booting into the other slot either.)
[Magisk] Bologner:
Pixel 4 XL here. To clarify what other Pixel-users are reporting:

After flashing the March update, patching the boot.img file from the March factory image via Magisk Manager, booting to fastboot, and flashing the new boot.img file, the phone boots but the touchscreen is completely unresponsive. I cannot even use the on-screen volume slider.

Flashing back to original boot.img fixes the issue.

This is with Magisk 20.3, Magisk Manager 7.5.1
[Magisk] zgfg:
Did you check is your device SAR
[Magisk] Spaceminer:
It is a SAR device. How can I mount those partitions rw?
[Magisk] Ch3vr0n:
I had to reflash Feb factory image for a different issue with patched image. Had the same problem, flashed image again, patched and flashed boot image again. fixed it. (For me at least)
[Magisk] CSX321:
Me, too! I kind of see what they were trying to do, but I really like the old interface much better.
[Magisk] ktmom:
Do it systemlessly. There is a discussion of another user modifying vendor here.
[Magisk] Spaceminer:
That kinda works. I mean, I can make modifications through Magisk & symlinks to vendor without issue, but that's not what I'm after. Those modifications aren't permanent. I can easily make permanent modifications to the system partition with just a root explorer (no modules or symlinks needed), so I don't understand why it doesn't work for vendor or oem. I don't want to do it "systemlessly" if that makes sense. I want to make my changes permanent, even when magisk is uninstalled. Is this even possible anymore? It definitely was on non SAR devices.
[Magisk] zgfg:
When you make permanent changes to system, does it maybe affect device certification in playstore
[Magisk] Spaceminer:
I'm not sure. I always delete the playstore. I prefer to run the stock os without any gapps. I really don't understand why my system changes stick permanently but vendor or oem won't. I can't run the magisk debug version to find out why either. It bootloops in it's current state.
[Magisk] zgfg:
Maybe this can help:

https://source.android.com/devices/bootloader/system-as-root
[Magisk] Spaceminer:
It does but at the same time raises even more questions and confusion.

The G7 Play, has recovery/boot merged. Inside the boot/recovery fstab, it says that system is located at, /dev/block/bootdevice/by-name/system and mounted to /system but... our vendor fstab says system is located at, /dev/block/bootdevice/by-name/system and mounted at /

We have similar things going on with /vendor too. One fstab says it's at /odm/vendor and mounted to /vendor, my ramdisk says, it's symlinked under /system and yet another fstab says it's mounted in the usual, /dev/block/bootdevice/by-name/vendor to /vendor

Even worse, cat proc mounts returns the following saying that it's mounted to dm-0. (Manually remounting dm-0 to /vendor as rw, has no effect. It does remount rw but changes don't stick.)

/dev/block/dm-0 /vendor ext4 ro,seclabel,relatime,block_validity,discard,delalloc,barrier,user_xattr 0 0

This is very confusing.
[Magisk] ktmom:
[MENTION=7718083]Spaceminer[/MENTION]

https://mobile.twitter.com/topjohnwu/status/1174392824625676288
[Magisk] Spaceminer:
This was actually extremely helpful, and it really cleared up the majority of my confusion. I greatly appreciate the info. Anyone else who checks that, be sure to expand the comments.
[Magisk] goodflood:
Hello!

Phone: S10e; https://en.wikipedia.org/wiki/Samsung_Galaxy_S10

LOS: 17.1; https://www.sammobile.com/samsung/galaxy-s10e/firmware/SM-G970F/XEU/download/G970FXXU4BTA8/316635/

ROM Thread: https://xdaforums.com/galaxy-s10/sa...exynos/rom-lineageos-17-0-s10-exynos-t4006917

The problem I am running into:

On flashing stock firmware, I have 107 GB of space.

When I flash magisk patched AP file (with the rest of the firmware), followed by TWRP and reboot to recovery, I have 15.7 GB.

I had previously flashed a tarred file to the AP partition by itself. Does this mean that my data partition has shrunk?

On asking for help, someone said that flashing stock firmware will reverse everything. But, I am not sure what is going on or how to fix it. Can anyone help?

Thanks!
[Magisk] ktmom:
Why are you assuming this is a Magisk created problem? I'm assuming you used Odin. Are you sure you didn't enable the re-partition option?

I think you would get good information by searching/posting in your device forum.
[Magisk] ChillDuder:
does magisk manager have command line command/parameters?

i would like to build a script, which trigger downloading and installing several modules from repo.
[Magisk] Didgeridoohan:
Nothing like that.

But if you're going to create a script anyway, you can just make it unpack the downloaded module zips to corresponding module directories in /data/adb/modules_update. On the next reboot that directory is integrated into /data/adb/modules automatically.

Good resources are the Magisk docs and the current module installation script:

https://topjohnwu.github.io/Magisk/

https://github.com/topjohnwu/Magisk/blob/master/scripts/module_installer.sh
[Magisk] goodflood:
Smaller data partition/space

Because, Magisk patched ROM gives me the problem. Going back to stock, and I get the full space back.

Yes, I used Odin. And, no, the re-partition option was not enabled.

Further, I am not performing any additional steps. Am I missing anything?

This is how I do it... I flash stock... the erase is done automatically, and I set up the device the first time. I install magisk manager, move the AP file, patch it, move it back (with adb), then, I re-flash it with the other files (except CSC_HOME). Oh, before that, I unpack the patched AP file, I swap, recovery.img, with custom recovery, renaming it, then, I repack the patched AP file. After flashing, and booting to TWRP, I get reduced space.

One more thing... I did flash a file in AP slot by itself... not sure if that messed things up and if there is something else that I need to do.
[Magisk] selemine:
So i had a problem being stuck in fastboot mode after a broken update from Magisk.

I read that you can get back to the old state by downloading the original rom, extracting boot.img and flashing it back.

How do you avoid resetting your whole desktop, installed apps and getting booted to the first install wizard after that? i mean the rest of the original files are still on the internal memory
[Magisk] CSX321:
Just flashing boot.img won't reset anything like that. If you have an A/B device, just extract the stock boot.img as you say, and then in fastboot mode:

fastboot flash boot_a boot.img

fastboot flash boot_b boot.img

fastboot reboot
[Magisk] selemine:
So what can do this kind of damage? According to the net the poco f1 is an a-only device for now.
[Magisk] CSX321:
Hard to say, really. I had to do something similar on my Pixel 3 last year at one point. I had switched Magisk update channels a couple of times over the previous months (stable/beta/canary), and I figure somewhere in there something got corrupted. I was able to flash everything back to stock (without wiping), temporarily boot TWRP from ramdisk, and reinstall Magisk from there. Since then I haven't had any trouble with my normal update process of using Magisk Manager to pre-patch the new boot.img from monthly updates, running flash-all after removing -w from the update line, and then flashing magisk_patched.img to the A and B boot slots.
[Magisk] selemine:
Ok i restored by twrp backup to the non booting state, put an bootimg over it and flashed magisk v20.3 over it, so i am greeted with the miui install wizard and my settings are gone.

Are they forever lost because the pre re-install state is ****ed or am i doing something wrong in the fixing process?
[Magisk] ktmom:
I'm not trying to be a jerk [emoji56] These device recovery questions are really outside of the scope of the Magisk support thread. There is usually so much information available in device forums. At the minimum, you won't have people with pixel devices trying to help you on your not pixel device like can happen here.
[Magisk] Philnicolls89:
Check out the recovery thread for s10, I'm pretty sure this is a known issue. If you flash firmware and don't fill all the slots (including either csc or home csc) then it can shrink the data partition.

https://xdaforums.com/galaxy-s10/development/recovery-twrp-3-3-0-galaxy-s10-exynos-t3924856
[Magisk] RZGM01:
Can't root Xperia xa1 plus

I can't root my xperia xa1 plus running android 7 (48.0.A.1.117) with boot image on xda: https://xdaforums.com/xa1/development/xperia-xa1-plus-stock-kernel-advanced-t3729856/amp/
[Magisk] rinlau:
I am using an OnePlus5T with OxygenOS 9.0.10. So far Magisk is working fine, but the banking app DKB-Tan2Go immediately crashes after activating Hide for it.

The main DKB-App is working fine with Hide.

Any ideas ?