yashsingh1/xdaforums huggingface dataset:
[Magisk] J.Michael:
But, as per @zgfg's comment, you shouldn't be messing in /sbin/.magisk/mirror, you should be messing in /data/adb/modules/make-up-a-name/cust. First question, does Magisk automatically obscure the original /cust with your modulename/cust? If not, does it at least leave the directory modulename/cust alone, so you can use it in a custom script.

If yours is not a SAR system, you might have more freedom to permanently mangle the system, but it seems preferable to not do that.
[Magisk] newbit:
Sure, this is the whole point actually.

I don't think so, it does this only with the mentioned partitions/directories.

But though, I'am still not sure, if magisk will handle a module folder data/cust/all/cn the same way it handles the rest, as @Didgeridoohan

already mentioned. The source code says it a bit different:

mount_mirror(system, MS_RDONLY)
mount_mirror(vendor, MS_RDONLY)
mount_mirror(product, MS_RDONLY)
mount_mirror(system_ext, MS_RDONLY)
mount_mirror(data, 0)

All except data has this Read Only flag.

This is exactly the opposite I want to achieve. Regarding future updates or debugging issues etc. I prefer the module version instead

of any permanently solution in form of flashing a partition which is not ramdisk or kernel.

Thanks

NewBit
[Magisk] zgfg:
Go to /data/adb/modules, every folder belongs to one of the modules installed (you can recognize them by folder names)

Go inside the module's folder and open (text file) for editing module.prop

In that file delete description= and the description that follows (or just that long description text) and save - Magisk Manager will now display as on the first screenshot

If you by mistake remove the other stuff (back-up the module prop before editing), or if you delete/rename the whole file, it will look like on the second screenshot, and Manager will not be able to show you when an update for the module will be available from Repo

DO NOT play with the other files in the folder (unless you know what you are doing and how you want to change the module's functionality) - except for files like licence or so

But why to bother with...
[Magisk] Didgeridoohan:
While Magisk creates all those mirrors (for various reasons), you can only make systemless modifications with a Magisk module to /system, /vendor and /product:

https://topjohnwu.github.io/Magisk/details.html#magic-mount
[Magisk] InTheY2K:
Was that a stupid question to ask or is this really a unique phenomenon? :(
[Magisk] Didgeridoohan:
Not a stupid question, just quite unique (to me at least). Don't think I've seen anyone reporting that Magisk reverts to the previous version on a reboot...

That does hint at something though. I'm assuming that your device has an A/B partition layout (if you're unsure, see what the Magisk app reports)? If so, it sounds to me like you're patching one of the boot partitions, but your device then reverts to the other one with the old Magisk patch on a later reboot (since something is wrong somewhere, or whatever). This is just me guessing though, since I have no real experience with A/B devices...

There's been quite a few reports of issues on Magisk v21.4 on some devices, so you might want to hold on the update for now. First though, it might be useful if you open up a Github issue describing this problem. You'll need to be detailed and provide logs (Magisk install log and a boot logcat sounds like they would be ideal) and a copy of your boot image. That might possibly help in ironing out any issues, if we're lucky.
[Magisk] dunderball:
Those are the steps I'm following. I think something is up with flashing my boot image. It just doesn't seem to "take" on my Pixel 3a. Maybe it has something to do with the A/B setup on the Pixel 3a? I wish I could figure this out.

I even tried to flash a patched January boot image without success (while being on the official Google Feb release image).
[Magisk] dunderball:
I've gone ahead and flashed a patched version of boot.img to BOTH slots and b and root is still not succeeding. I've also patched from both Stable and Canary magisk releases. I'm at a loss now.
[Magisk] an0therus3r:
Can anyone help me getting the latest magisk apk/zip? 21407 magisk-0646f48e(21407).zip

I'm searching for download links but couldn't find any. Previously you could get it within magisk manager but that's not an option anymore.
[Magisk] dunderball:
My other suspicion is that I have data in /data/magisk or something that I can't remove (since I don't have root). Maybe a full wipe is needed but that seems extreme.

Next time, might be worthwhile uninstalling magisk fully before trying to flash new factory images.
[Magisk] zgfg:
From Manager you have link to Github, scroll to Download, Canary
[Magisk] dunderball:
I solved my problem. I ended up just flashing with the -w flag which wipes the /data partition. I am able to achieve root again with Magisk.

Warning for everybody: If you're rooted, I would avoid flashing factory images without unrooting/removing modules first. Seems that leaving modules or files behind in /data will leave you in a bad spot, since you cannot remove them after losing root. Lesson learned.
[Magisk] Didgeridoohan:
Just out of curiosity, did you try to boot into safe mode to disable your modules or using the adb command to remove them?
[Magisk] zgfg:
Not necessarily:

- modules can be disabled to prevent bootloop upon next time rooting

Even without disabling modules:

- if TWRP is available, in case of bootloops modules can be still disabled or uninstalled

- even if TWRP is not available, booting to Android Safe mode and then back to 'normal', disables all modules and therefore saves from the bootloop

Hence there is always a risk but usually solvable and therefore a decision to be made, is the double work to uninstall Magisk (and therefore all modules, and later reinstall them again) really needed or not
[Magisk] InTheY2K:
I checked Magisk Manager and it says I don't have an A/B partition.

Like I said, up until 20.4 updating Magisk never was a problem. My ROM is the stock android 9 that came factory installed and that hasn't been updated since 2019 (abandoned by Umidigi),so I can rule out that as the cause.

OK, I may have to report that on github then.

Thanks for your advice!

Cheers

Sascha
[Magisk] ipdev:
That sucks. :(

Did you happen to notice if any root required still worked while Magisk was N/A?

Did any module still run, apps that had root access still work with root privilege?

@Didgeridoohan

@zgfg

I have had similar experience before.

Normally AdAway gives me a heads-up when my Magisk install becomes borked.

Seems to be the first app to show signs of Magisk issue.

Generally I still had root access (even if Magisk shows as N/A) and have a few options to recover before a full wipe.

Since we are moving to recovery-less Magisk..

Might be a good idea to enable adbd/insecure to the Magisk safe mode ? :unsure:

Cheers all. :cowboy:
[Magisk] pndwal:
Fixes coming... for some... 🙂

Here are commits since last Canary:

Commits on Feb 8, 2021

- Added translation of new strings

_@Henry2o1o committed 35 minutes ago

- Fix LZ4_LG format decompression (Fix #3802, fix #3722, fix #3770, fix #3635, fix #3787, close #3812)

_@topjohnwu committed 36 minutes ago

- Fix unable to patch images when app is hidden

_@topjohnwu committed 12 hours ago

Commits on Feb 7, 2021

- Fix boot image patching

_@topjohnwu committed 16 hours ago

Commits on Feb 5, 2021

- Update dependencies

_@topjohnwu committed 3 days ago

👍 PW
[Magisk] pndwal:
Latest Canary Changelog incl. Release Notes:

Magisk (721dfdf5) (21408)

[MagiskBoot] Fix bug when unpacking lz4_lg compressed boot images

[App] Fix boot image/tar file patching on some configurations

How to Use the APK for Recoveries

In general, it is recommended to install and uninstall Magisk through the Magisk app. However, if you insist to use custom recoveries, rename the Magisk APK's .apk file extension to .zip. TWRP should then be able to directly flash the zip file. If you have trouble renaming the file extension on PC, rename the file with TWRP's built-in file manager. To uninstall in recovery, rename the zip file to uninstall.zip before flashing it.

Diff from v21.4

[General] Magisk and Magisk Manager is now merged!

[App] Rename the app "Magisk Manager" to "Magisk"

[App] Support hiding the Magisk app with advanced technique (stub APK loading) on Android 5.0+ (it used to be 9.0+)

[App] Disallow re-packaging the Magisk app on devices lower than Android 5.0

[MagiskHide] Fix a bug when stopping MagiskHide does not take effect

[MagiskBoot] Fix bug when unpacking lz4_lg compressed boot images

👍 PW
[Magisk] pndwal:
Seamless update to new Canary for me using direct Install.

SafetyNet full pass (w/ USNF module) and all settings preserved and active after first reboot.

Xiaomi Redmi Note 8T, Stock ROM (Magisk in boot.img despite Ramdisk = no). PW
[Magisk] zgfg:
Tested and patching from hidden Manager works fine now
[Magisk] vip5912:
Magisk (721dfdf5) (21408): update is OK, SafetyNet is Pass.
[Magisk] dunderball:
No I definitely did not have root at all while it was displaying "N/A".

I can tell you that these are the steps I took just prior to flashing the official Pixel image (I was rooted, on the January 2021 image):

(1) I flashed the official February 2021 image (without the -w flag, which we all know leaves the /data partition untouched)

(2) I attempted to patch the boot image, however my Canary build of manager was out of date. Pressing "update" did not work, most likely because I was no longer rooted. I decided to just try to do an uninstall of the manager app followed by a re-install of latest Canary manager app.

(3) From this point on, patching and flashing boot images did not work at all

I plan to be more careful next time:

(1) Try to patch the boot image from the latest Pixel image. This will ensure that I am on the latest version of manager + magisk.

(2) Restore magisk manager app (since I am using the 'hidden/repackaged' feature)

(3) Uninstall all modules

(4) Perform "uninstall" from within the magisk manager app

(5) Flash stock image / flash patched boot image / reinstall modules

Long story short, if you flash an official image and leave some remnants in /data behind, you could end up borking Magisk overall. I truly think I had some things left behind in /data/adb that just didn't allow my patched boot image to be properly mounted or something to that effect, and obviously without root you just can't remove it.
[Magisk] pndwal:
Dev & User alert:

Toxic, irresponsible SELinux Permissive ROM?

"You should never, *EVER* switch to permissive unless actually doing development/debugging."

John is warning Root Access is gained (seccomp will be disabled then App Zygote processes can call setuid 0, escalate privilege and gain restricted root access) allowing modified malicious 'Magisk' to be installed by malware, giving it PERMANENT FULL ROOT ACCESS (security measures in Android are completely defeated when UID=0, and it is enough to allow patching boot images which means it can be used to inject malware such as modified Magisk to gain "real" root permissions) with SELinux Permissive (w/ Android 10+)!

www.twitter.com/topjohnwu/status/1359054106019565571

Thanks _@vvb2060 for Privilege Escalation Proof of Concept. 👍 Magica!

Putting the word out here. PW

Edit: There's more! Further comments: https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84461507

... and:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84462947
[Magisk] p.froide:
Hi :)

I've got a small problem with magisk.

When I want to open it, I've a message telling me that I ve to update. But I cannot update (I think it's because app is hidden) and I cannot open it to unhidde it :)

Anyone have a clue?

Thanks!
[Magisk] pndwal:
Re. https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84458833

Further:

www.twitter.com/topjohnwu/status/1359207913055637505 PW
[Magisk] zgfg:
You didn't provide any info that is important like are you on Stable or Canary, and on which Magisk and Manager versions you are

- If you are on Stable, download from Github the latest Manager app 8.0.7 and try to install manually

- If you are on Canary, download from Github the latest Magisk app 21408 and try to install manually

If still not working, uninstall first your hidden Manager app from Settings/Apps, then install the latest as above
[Magisk] p.froide:
Hi,

Thanks for helping.

I'm on canary. I'm unable to see the version now.

I've tried to install the 21408 but now i've two apps installed ?

In the 21408 that i just installed, it says magisk is not available...
[Magisk] zgfg:
Uninstall the old, hidden one with the ugly icon

Maybe you will need to uninstall both and reinstall 21408 again, you'll see :)
[Magisk] pndwal:
But wait... There's more!

Re. https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84458833

And further comments: https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84461507

John's on a roll re. security:

www.twitter.com/topjohnwu/status/1359307457986654209

...Lest it all explodes in our face, and "BOOM, your device is now #pwned."

Thanks for the warning John! PW
[Magisk] p.froide:
It works !

Thanks for your help !
[Magisk] pndwal:
News and Appeal:

New public release (ie. Beta / Stable) imminent, but John needs your help (see his Twitter post):

Commits since last Canary:

Commits on Feb 12, 2021

- Hide icons when things don't fit

_@topjohnwu committed 8 minutes ago

Commits on Feb 11, 2021

- App string resources overhaul

_@topjohnwu committed 3 hours ago

- Fix Android build version sdk in script

_@vvb2060 authored and _@topjohnwu committed 7 hours ago

👍 PW
[Magisk] McFlypants:
As you can see in this thread (click to read), Magisk can not be hidden from the german pay tv-app Sky Go. I did some tests and i can use the app when i'm not rooted and no magisk manager is installed. When I only install magisk manager (without root!!), it is detected and the app says, i have root installed (but only the manager is installed). When i flash the magisk zip and after that uninstall the magisk manager, i still get the same error. So it can detect the root and also the installed manager without root. After flashing uninstaller zip, everything is working normal again.

Of course i used all hide mechanisms (MagiskHide, different name for manager). Tested on two devices: Xiaomi Mi 9T Pro (xiaomi.eu 21.2.3 Beta) and Xiaomi MiPad 4 Plus (CrDroid 7.2). I pass safetynet on both devices and all other apps that might detect root are running great. Just this app doesn't.

What do you need to look into that and find out, what the app does and why it can detect root even when magisk is hidden?
[Magisk] pndwal:
https://www.didgeridoohan.com/magisk/MagiskHide#

https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot#

Hope this helps. It's probably your best resource. PW
[Magisk] pndwal:
Re. https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84471937

Updated Commits since last Canary:

Commits on Feb 12, 2021

[Edit; more:

- Updated Georgian translation

_@X1nto committed 26 minutes ago

- Minor fixes and changes to Swedish transaltions

_@Didgeridoohan authored and _@topjohnwu committed 27 minutes ago]

- Update Swedish translation

_@mbjurstrom authored and _@topjohnwu committed 2 minutes ago

- Hide OTA option on virtual A/B devices

_@vvb2060 committed 2 minutes ago

- Spanish strings

_@josecurioso authored and _@topjohnwu committed 10 minutes ago

- Update RU strings

_@Displax authored and _@topjohnwu committed 10 minutes ago

- Update strings.xml …

_@alex26052005 authored and _@topjohnwu committed 11 minutes ago

- Update Portugues Brazilian translation

_@DanGLES3 authored and _@topjohnwu committed 11 minutes ago

- Update Slovak translation

_@kubalav authored and _@topjohnwu committed 14 minutes ago

- Update zh-rCN translation

_@vvb2060 authored and _@topjohnwu committed 16 minutes ago

- Update Japanese translation

_@AndroPlus-org authored and _@topjohnwu committed 19 minutes ago

- Update hide icon strategy

_@topjohnwu committed 1 hour ago

- Hide icons when things don't fit

_@topjohnwu committed 19 hours ago

Commits on Feb 11, 2021

- App string resources overhaul

_@topjohnwu committed 21 hours ago

- Fix Android build version sdk in script

_@vvb2060 authored and _@topjohnwu committed yesterday

Thanks for efforts translators! 👍 PW
[Magisk] McFlypants:
I already read twice through this page and tried it all. I always came to the point "nothing works!".

It is not safetynet, because i pass it with and without magisk installed, one time it works, one time not. Is there any process running when magisk is installed, that is detected?

Thanks for your help!
[Magisk] pndwal:
Sorry, I have no suggestions not in wiki except that there are apps that 'sandbox' sensitive apps, and some have had success hiding modded system using these, but I have no such experience.

If you've read the wiki, removed all root apps, TWRP etc and taken other precautions mentioned (hid Magisk app etc), are on latest Canary, have playprotect 'device is certified' status, have your app selected in hide list and have cleared it's app data and rebooted (need to clear app's detection record) each time you test a change to setup, that's about all I know and you'll need help from others.

All the best with it! PW
[Magisk] howtoroots:
hai dev, apakah bagus membuat magisk sebagai aplikasi sistem
[Magisk] Wolfcity:
Please use english language on XDA, Google translate is ok.

To answer your question: No, it's not a good idea to install magisk as system app, that may cause problems. Just install it the way it's used to be done.

To contact the developer @topjohnwu you have to do that over GitHub, he isn't present on XDA anymore.

Silakan gunakan bahasa Inggris di XDA, terjemahan Google ok.

Untuk menjawab pertanyaan Anda: Tidak, menginstal magisk sebagai aplikasi sistem bukanlah ide yang baik, karena dapat menyebabkan masalah. Instal saja seperti biasanya.

Untuk menghubungi pengembang @topjohnwu, Anda harus melakukannya melalui GitHub, dia tidak lagi ada di XDA.
[Magisk] harddisk_wp:
I'm trying to use Magisk to root my new SM-T575 (Galaxy Tab Active 3). Magisk 21.4 resulted in "vbmeta: Error verifying vbmeta image: HASH_MISMATCH (3)" during boot after flash, Magisk Canary failed during flashing with "Only official released binaries are allowed to be flashed(VBMETA)".

I already filed an issue at Github three weeks ago (https://github.com/topjohnwu/Magisk/issues/3746), but until now no one had an idea.

Is someone out here who could help me? I have many years of general Linux experience and a bit generic Android hacking from 4.x days, but that new signing/secureboot stuff is beyond me.
[Magisk] pndwal:
Please can you confirm that in developer options OEM unlocking option exists and is grayed [/greyed] out. (If not, bootloader may not be fully unlocked; VaultKeeper service likely has not unleashed the bootloader, and unofficial images will not yet be accepted in download mode.)

... just one possibility. 😬 PW
[Magisk] harddisk_wp:
That one was the first thing I did ;) It also shows the usual warning at the bootloader that this device may not be trusted bla bla, and Magisk's SafetyNet check shows that attestation fails because of the Knox trip.
[Magisk] pndwal:
Goodoh.

I don't have a Samsung device, but noted this requirement for those who do, and I guess it's peculiar to Samsung. At least my (Xiaomi) device w/ unlocked bootloader doesn't grey-out OEM unlocking toggle.

Not sure attestation fails due to Knox trip (guess you mean evalType = Hardware / ctsProfile fails?) - After all you should be able to relock bootloader to pass ctsProfile even w/ Knox fuse blown, and ctsProfile trip due to Hardware key attestation w/ unlocked bootloader is common to most recent devices now, even if evalType shows Basic. Solution is to use Universal SafetyNet Fix Magisk module and Magisk root. (Working presently incl. customised fix for Samsung which, of course, also have tripped Knox, but won't work after Google swings the Big Hammer finally.)

You won't be able (on recent Samsung devices) to reset Knox so will have lost ability to set up/use secure Knox partition and possibly other 'Enterprise' mode features forever.

Please correct me if there is any evidence attestation is affected by Knox status. Would be helpful to know of any new connection. PW
[Magisk] ManeBoned:
If I uninstall a Magisk module, will all the changes be reverted that the module did?
[Magisk] BillGoss:
With the new APK/zip format of Magisk (starting with 21405) I've noticed that after flashing the Magisk zip in TWRP I cannot flash any other zips that try to mount /system - they'll all fail and the recovery log shows

mount: mounting /dev/block/sde20 on /system failed: Device or resource busy

If I reboot TWRP, then I can flash the additional zips without a problem.

Magisk 21.4 and earlier versions don't have this problem.

I raised a ticket in GitHub https://github.com/topjohnwu/Magisk/issues/3819 which topjohnwu closed saying it was a bug in the recovery.

Does anybody (@osm0sis perhaps?) have any knowledge about the nature of the bug and how Magisk triggers it? I would like to provide this info to the maintainer of TWRP for my device (OnePlus 3T).

I'm guessing (though I may be totally wrong) that it's related to how the busybox environment gets set up as that seems to be the biggest change in the flashing process between Magisk 21.4 and the new version.
[Magisk] DiamondJohn:
Without specific details on the module, if it was truly a systemless implementation, then yes. As "there were no changes" to the system ;)

Where you can come undone, a module could make permanent changes other partitions (or settings). Also, the running of some modules features may specifically make changes outside of the modue itself. Those changes may evenn be the whole purpose of the module. A very simple example would be the systemless installation of a new system app which writes to your SDCard.
[Magisk] pndwal:
Latest Canary Changelog incl. Release Notes:

Magisk (8476eb9f) (21409)

[MagiskInit] Support Galaxy S21 series

[App] Update many strings in the app

[App] Do not allow OTA feature on virtual A/B devices

How to Use the APK for Recoveries

In general, it is recommended to install and uninstall Magisk through the Magisk app. However, if you insist to use custom recoveries, rename the Magisk APK's .apk file extension to .zip. TWRP should then be able to directly flash the zip file. If you have trouble renaming the file extension on PC, rename the file with TWRP's built-in file manager. To uninstall in recovery, rename the zip file to uninstall.zip before flashing it.

Diff from v21.4

[General] Magisk and Magisk Manager is now merged!

[App] Rename the app "Magisk Manager" to "Magisk"

[App] Support hiding the Magisk app with advanced technique (stub APK loading) on Android 5.0+ (it used to be 9.0+)

[App] Disallow re-packaging the Magisk app on devices lower than Android 5.0

[MagiskHide] Fix a bug when stopping MagiskHide does not take effect

[MagiskBoot] Fix bug when unpacking lz4_lg compressed boot images

👍 PW
[Magisk] HippoMan:
Sadly, because of this, I have less and less reason to upgrade Magisk from 21.4. This OTA feature has made it trivially easy for me to upgrade my OS for the past year or so.

Without this feature, I will have a more complicated and therefore more error-prone procedure to deal with, if I want to upgrade my OS.

I've already been avoiding an Android-10-to-Android-11 upgrade because of the associated added complexities of dealing with Magisk under Android 11. And now, it appears that even if I remain under Android 10 on my A/B device, I will have to force myself to always use 21.4 if I want to benefit from an easy OS upgrade to a newer Android 10 version via that OTA feature.

Oh well ... (sigh) ...