yashsingh1/xdaforums huggingface dataset:
[Magisk] coronafire:
I've been working on getting Safetynet passing on Xiaomi Mi5 with unlocked bootloader with success thanks to Magisk.

Firstly, the props ro.build.description and ro.build.fingerprint need to match a xiamoi global stable release (marshmallow). I've been fixing this with a twrp zip, haven't converted it over to a magisk module yet.

Secondly, Magisk v11 doesn't work with the popular xiaomi.eu rom I was testing on. Turns out v9 with phh superuser does work however!

Magisk v11 does work fine on Lineage OS, however it's got some other kernel issues (xiaomi's fault really) that annoy me, particularly issues with the capacitive buttons. It's not quite as smooth as rom's based on miui in my experience.

I've found ADB does not need to be disabled, nor have I needed to change and SElinux settings.

I've been discussing my findings on a different thread. https://xdaforums.com/mi-5/how-to/mi-5-passing-safetynet-unlocked-t3557845

Is there anything I could do to help diagnose how v11 regresses from the v9 & phh combination?.

I'm an embedded software engineer, so happy to compile/log/debug at low level.

With my testing so far, with v11 on xiaomi.eu 7.2.24, magisk hide doesn't appear to work at all. This rom requires an unlocked bootloader.

I've tried a couple of root checker apps, these seem to show no change (they detect root) regardless of whether magisk hide is enabled for them or not.

I've tried setting selinux to permissive, toggle magisk hide enable, no difference.

One of the root checker apps that shows selinux mode still said permissive after I'd ticked it in magisk hide and toggled magisk hide enable setting.

Safetynet helper always shows both basic integrity fail and cts fail with v11.

On this same rom without magisk installed, I've had safetynet passing on a custom kernel which hides the bootloader unlocked status. On this same kernel, as soon as I install magisk I get the same basic integrity and cts fail. This kernel is a bit unstable though, not really a daily driver.
[Magisk] Didgeridoohan:
Providing the boot image, Magisk log (verbose logging enabled) and possibly logcats from a failed SafetyNet check and/or trying to hide root from a root checker. Attach that to a detailed issue on GitHub and I'm sure [MENTION=4470081]topjohnwu[/MENTION] can take a look at it...
[Magisk] calikevin:
I was passing SafetyNet initially, but now I am not.. could this be due to removing built-in system apps, either with TitaniumBackup or a root explorer?
[Magisk] Didgeridoohan:
If that's the only thing that's changed since you could pass: sure, why not?

If you've rebooted, have you checked the log to see if the Magisk daemon have started. Toggling hide off and on could fix that.
[Magisk] calikevin:
Well I've done quite a few things since I last passed the SafetyNet check, installed a flashlight zip that didn't work and removed apps and folders entirely from the system/app folder. I'm just wondering if anyone knows exactly how sensitive the SafetyNet check is, or just exactly how much modification can be done before you start to fail the integrity checks.
[Magisk] Didgeridoohan:
You're using a systemless mask, why start tampering with the system like that? Freeze apps or make a debloater module instead... And with a module you won't have to bother with manually removing or freezing apps after a system update.

I honestly have no idea if any of the modifications you've made have any impact on SN. I guess the easiest way for you to see if you can pass again is to dirty flash your ROM.
[Magisk] calikevin:
Yea, I did try the dirty flash already too, all it really did was reinstall phh superuser, still don't pass SN. I just can't stand having apps on my phone I never use taking up space, but I guess I'll have to make some sacrifices and try the stuff you mentioned if I want to pass SN.

I have no idea how to make a module or I would... one to remove unwanted Google Apps like Newsstand, Music, and Videos would be perfect.
[Magisk] karthik km:
Titanium backup is working fine but gives recommendation to use super su why?
[Magisk] Didgeridoohan:
Because it's programmed to... SuperSU is a tried and tested root method and if TiBu discovers another method on your device it'll tell you it'll probably work, but if it doesn't use SuperSU instead.
[Magisk] karthik km:
Thanks bro
[Magisk] culiacanazo:
What I'd like to know is what you're doing with a flashlight in a zip?
[Magisk] DDHBanger:
Hi. Running OP3 with Magisk. Installed Magisk V4a and all enabled but I can't get processing to work. Any ideas?
[Magisk] tag68:
You need MagiskSU for Magisk Hide (precondition for SN) to work, not phh nor SuperSU. So when you installed Magisk, it may (!) have automatically detected and removed phh and instead installed MagiskSU, that would explain why it worked for you before.
[Magisk] fndpena:
Exactly. I don't have much use for a custom recovery (Flashfire is a great alternative), so I always do that.

If anyone wanna try, just download the latest TWRP for your device and cmd "fastboot boot nameofthefile.img"

This also makes things easier when I need to update the system, OTAs and stuff...
[Magisk] nashlesub:
hello, I have a galaxy S7 edge G935F, king of nougat Roma, BL. DQAS and CSC. DPLT, I installed magisk to recovery but when I restart the sisema not restart the phone remains locked on the written Galaxy, if I uninstall always magisk in recovery then the phone will restart correctly. Could someone help me please?
[Magisk] Didgeridoohan:
Sounds like a simple incompatibility between your device's boot image and Magisk. There might be some information in the recovery log from when you flash the Magisk zip.

[MENTION=4470081]topjohnwu[/MENTION] have been working really hard recently on fixing compatibility issues. If you're lucky your's will be one of them.

There are unofficial builds available that are built from the latest source. Might be worth giving a shot:

https://xdaforums.com/apps/magisk/unofficial-magisk-v10-beta-built-t3521901
[Magisk] nashlesub:
thank you so much information now look at the link[emoji1]

Inviato dal mio SM-G935F utilizzando Tapatalk
[Magisk] Peter.1997:
I have clean flashed everything (Rom,Gapps,Unroot,Magisk) and installed the Magisk Manager App and enabled Magisk Hide.

I downloaded Root checker and SafetyNet Helper and set a tick in Magisk Hide.

Root Checker still asks for root permissions and says my device is rooted.

SafetyNet Helper says CTS Profile match false and also basic integrity false..

I don't know what i can do..I have disabled USB debugging and changeg SeLinux state already. I also deativated Busybox feature in Magisk Manager.

I also installed old versions of Magisk (everything to 7.0 down) and tried phh's superuser.

Also tried the app AutoMagisk, but it also doesn't work.

I don't understand why it is working perfectly on Android 6.0 and 7.0 on the same Rom..
[Magisk] Didgeridoohan:
Sounds like the boot image for that ROM simply is incompatible. If you really want to have it working on that ROM I'd suggest opening an issue on GitHub and upload the boot image. Maybe then topjohnwu can take a look at it, when he has the time...
[Magisk] darkeyes22:
You can't pass SN with custom ROM. Flash stock ROM and then flash Magisk, should help
[Magisk] jhedfors:
Ugh. There are different variables involved, but this blanket statement is simply not true.
[Magisk] darkeyes22:
You say that there are custom ROMs who can pass SN?
[Magisk] de.er:
Yes, definitely!
[Magisk] jhedfors:
Yes. I am on LineageOS 14.1 on my OnePlus One, and pass just fine. There are many other devices on LineageOS that have been reported passing as well.
[Magisk] darkeyes22:
Then ROM's maintainer should mention that imo.

---------- Post added at 04:24 PM ---------- Previous post was at 04:23 PM ----------

Did you passed totally or basic integrity only?
[Magisk] teddy0209:
Some do mention it... The thing is you can pass by using magisk regardless of the rom if you know what is required... Though it's easier to do it with stock...
[Magisk] jhedfors:
Totally.
[Magisk] darkeyes22:
I flashed LOS 14.1 on Z00T and failed in SN (passes only basic integrity). Any reasons or explanations?
[Magisk] jhedfors:
I would suggest checking out this thread:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] RawSlugs:
What does this mean? See screenshot
[Magisk] tag68:
Do you really want a translation from English to English? Magisk is installed, using SuperSU for root, and SafetyNet (of course, when using SuperSU) fails.
[Magisk] calikevin:
For some reason Nougat HTC M9 roms don't include the flashlight app, and the only thing I could find with a quick search was a flashable apk made for my model, M9.

Somehow with ViperONE 6.0 Nougat, I was able to pass the SN check with Magisk and MagiskSU installed, then I corrupted it somehow. Now I have reflashed LeeDroids Marshmallow build and while I am unable to pass the SN check in Magisk or SN Helper, I am able to launch and play Pokemon and login to Snapchat. I honestly don't use Android Pay so I don't know if that will work without passing the integrity check, but the whole thing is just weird how it fails the check but will still work with certain apps. Could this be related to the kernel being permissive Vs enforcing, or would that cause it to fail altogether?

After checking SafteyNet attest again, it shows that I'm failing CTS but passing the basic integrity check.
[Magisk] RawSlugs:
Was wondering about the safetynet. Thanks
[Magisk] Artim_96:
If you don't know what it is, ignore it. Only pay attention of you know what it is and why you would need to care.
[Magisk] jcrompton:
Gosh ... this whole thing has got to be soooooo frustrating for everyone .... I mean just the thought that this statement is true ...... I mean I have basically NEVER used "stock" and used Magisk to pass SN on 4 different devices! for months and months (until now -- for some reason I still can't get Magisk Hide to work on AOSP ROMs on my Galaxy S7 Edge but can on stock ROMs)

My point is in agreement that there are many variables.

Even minute points like recently I have been having to set my permission to 0640 for a specific file to pass SN on my stock ROMs sys/fs/selinux enforce

But the real point is that this thread seems to go through about 2 to 4 page cycles with the exact same questions / statements being asked / made over and over ..... nearly 1000 pages in !!!
[Magisk] seenahermes:
Hi,

Thanks for Magisk, it is really useful, but I'm having a problem that appears unique. I pass safetynet, and I can open snapchat, but my banking app won't allow NFC payment to be enabled and returns errr.custom.rom -- I am using a standard ROM (OOS 4.0.3 on a OP3T), but I have the bootloader unlocked and am using a custom kernel. Does anyone know how I can start to fix this ?
[Magisk] Alex311360:
i can't seem to install magisk v11.1 on a v10.2 device.

it's because it says the boot partition is too small after attempting an install in TWRP. do i have to uninstall magisk, then REinstall the newer version of magisk?

have a sprint samsung galaxy note 5 running MOAR v4.2.
[Magisk] jhedfors:
Try it! :)

If it complains the same flash 10.2 again. Or backup the boot partition beforehand. Let us know the result.
[Magisk] Artim_96:
You can't. Most banking apps can't be tricked. Too tired to explain in full length over and over again. Either use full stock without any modifications and you banking app or have root and stuff without banking app. Be glad that they only block NFC payment, most refuse everything
[Magisk] teddy0209:
Did you add your banking app to the magiskhide list?
[Magisk] jhedfors:
Hideroot

It is hard to say what methods the bank is using to determine what is a "custom ROM". It could be looking at certain property, or something else entirely. Attached is a module I created that might help. Give it a try - nothing to lose, right?
[Magisk] seenahermes:
Yep

---------- Post added at 08:06 PM ---------- Previous post was at 08:06 PM ----------

Thanks.
[Magisk] xtartrackR:
Phh superuser is displaying "The su binary is out of date" in the notification and I lost root in magisk v11 / marshmallow. Magisk manager says properly rooted and 6:MAGISKSU. How do I fix that please? Thank you.
[Magisk] Captain_Throwback:
Uninstall phh Superuser.
[Magisk] Didgeridoohan:
That's why I collected the most common answers I've given, over and over again in it's own thread. Now I mostly post the link to that... :)

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828

---------- Post added at 07:09 ---------- Previous post was at 07:05 ----------

You've gotten a bunch of tips already, but I'll give one more. The app might be dependent on another app/process for root checking. Go to the link below and scroll down to "Dependencies" in the "Hiding root and passing SafetyNet" post.

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828

---------- Post added at 07:50 ---------- Previous post was at 07:09 ----------

It's not that hard to make a basic module, actually. Lots of good info on that here (and in the module template):

https://xdaforums.com/apps/magisk/magisk-details-dummies-to-developers-t3473486
[Magisk] Alex311360:
didn't work. froze at the samsung note 5 splash (android has not booted at that point) after uninstalling. restoring a backup i made beforehand fixed it.

what do i do in this sorta case?
[Magisk] zurik:
[MENTION=4470081]topjohnwu[/MENTION] you are a wonder. Nice app ! Also magisk hide works nice!

Nexus 5X + PureNexus ROM + Magisk 11.1 + Franco.Kernel r35
[Magisk] Fentadroid:
I have the latest version of Magisk on Oneplus 3 running OOS. Any version of Titanium Backup crashes on start without asking permission for root access. Any solution?
[Magisk] DarkLanternX:
Uninstall the phh superuser, its useless now cuz all the superuser permissions are now handled by magisksu. Go to magisk manager settings and enable"superuser access" to "apps only".

From now onwards root access will be prompted by the magisk manager itself. Hope this helped

---------- Post added at 02:18 PM ---------- Previous post was at 02:17 PM ----------

Disabling magisk hide could work
[Magisk] DarkLanternX:
You must have corrupted the boot img file i guess. A fresh flashing should work. Just flash unsu before flashing magisk.

Here is the file
[Magisk] JaredTamana:
Looking for a little help...

Using a Nexus 5X and Nexus 4. I flash the Cosmic OS zip, GApps, (Elemental X on the 5X for unlocked bootloader check) and Magisk 11.1.

Here's the issue: Cosmic comes with SuperSU. It's also a 7.1.1 ROM, so suhide bootloops it.

I boot, set up the device, remove SuperSU (Full unroot, Yes, No). Remove and reinstall Magisk. Toggle Magisk Hide...

And CTS profile mismatch. Every time.

Can someone help me out? Does anyone know how to properly unpack a zip, remove SuperSU, modify the installer script and then repack? Or am I missing something obvious that doesn't have to do with Cosmic?

I used Magisk on Hexa ROM (LOS based) with no issues on the 5X. I've never been able to get Magisk working on the 4.
[Magisk] kgb88:
I cannot install Magisk 11 on S.Team-SL-2.0.1 rom (https://xdaforums.com/htc-one-m8/development/romthe-worlds-first100-m9-port-m8upload-t3064838)

It just show: "Updater process ended with ERROR: 1 Error installing zip file'/external_sd/Masigk_11.1.zip'"

I tried unSu script by Omsis but it is still error. Otherwise, I cannot install systemless mode of SuperSu, the only way is installing SuperSu in System mode
[Magisk] JaredTamana:
We'll need the twrp log.
[Magisk] karthik km:
Is there any way to take super user log on magisk ?
[Magisk] kgb88:
Here is the log I upload. It is quite long and I do not know what to take, so thank in advance. It took me whole day without any working result to install Magisk and SuperSu
[Magisk] Fentadroid:
Didn't work...

Disabled magisk hide, rebooted and TB still crash.....

Didn't find any log about that issue...

I would like to upgrade to open beta but i cannot do that if i can't backup apps.....
[Magisk] JaredTamana:
Magisk Manager -> Logs -> Swipe over to SU -> Save Button

---------- Post added at 05:12 PM ---------- Previous post was at 05:07 PM ----------

The log seems to have "Stock boot image backup missing", implying you've removed the stock images? This appears many times during the installation process.

My advice: clean flash everything, don't use SuperSU if at all possible.
[Magisk] Hyoretsu:
Can't pass Safety net after uninstalling magisk, root and everything. Also couldn't pass safetynet after magisk, magisksu and magiskhide.
[Magisk] karthik km:
One thanks for your quote

But there is a save button only for magisk log not for super user log

So Any idea ? For the same
[Magisk] jhedfors:
https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828/
[Magisk] kgb88:
The rom I flashed was pre-rooted by authors. It is impossible to make clean flash because boot.img was already patched.
[Magisk] xForsa:
i've got some questions on how this is used.

I've got a custom rom and i want to keep using it, BUT i understand i need a boot.img or system.img that is not rooted. but how am i supposed to install a custom rom without root via custom recovery (TWRP).

i want to bypass safetynet but i just can't find a solid tutorial that explains every step all the way from a clean state ( with clean state i mean standard samsung rom no root or customization whatsoever)
[Magisk] DarkLanternX:
Just use a nandroid backup then, a lot of people have reported that titanium backup crashes with magisk, i hope the dev will fix it in the upcoming updates.
[Magisk] Alex311360:
unfortunately, this doesn't work due to having a copy of systemless superSU and a ROM that doesn't come with a stock boot.img afaik

what am i supposed to do in this sort of situation?
[Magisk] teddy0209:
Use another kernel that is not patched for supersu...
[Magisk] Artim_96:
Well, stock in sense of unmodified, not containing supersu or such. No ROM can come without a boot.img.

If the boot.img contains supersu, either use a different ROM or at least kernel, but that one must come with it's own ramdisk, otherwise it probably won't overwrite supersu
[Magisk] zelendel:
That is not completely true. There are roms that do not exclude the boot.img they pull the one that is on the device and use that.
[Magisk] DarkLanternX:
Wipe and flash stock rom, see if that works, it should work ..if it does you can later experiment on roms. And always keep a backup of your original boot.img file.
[Magisk] Honeycd:
[MENTION=4470081]topjohnwu[/MENTION] I want to install magisk in the note 4 rom kurama, is it possible?
[Magisk] Didgeridoohan:
Make a backup, give it a try, report back and let us know. If it works, awesome! If it doesn't and you require help, make sure to provide enough details and any applicable logs (recovery log from installing, Magisk log, logcat, etc).

Also, check out this thread for some tips if you're having problems:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] NovaViper:
I keep on getting installation errors in the Magisk Manager and this Updater Process Ended with error: 1 Erorr Installing Zip file '/sdcard/MagiskManager/Magisk-v11.1.zip' from TWRP whenever I manually flash Magisk I'm not sure whats going on, but I've tried reflashing my ROM and wiped cache and dalvik ART cache. I am using the latest Magisk Manager and trying to flash v11 of Magisk.

TWRP Log

My Device Information:

-Device: Samsung S6 Edge Sprint (SM-G925P)

-Root: Yes, Systemless SuperSU

-Rom: Renegade v7
[Magisk] Didgeridoohan:
For some reason the installer can't restore the ramdisk. Might be an incompatibility issue... Have you tried a beta snapshot? There's been a lot of work on compatibility lately.

https://xdaforums.com/apps/magisk/unofficial-magisk-v10-beta-built-t3521901
[Magisk] NovaViper:
I flashed Magisk V9 and that actually installed successfully, but neither 10.2 or 11.1 installed correctly, both versions gives that updater error.
[Magisk] Didgeridoohan:
Did you try the beta version from the link I posted?
[Magisk] NovaViper:
No but im going to try it now and see if it works.

---------- Post added at 12:50 PM ---------- Previous post was at 12:26 PM ----------

I just tried v12.170304, still giving me that same error
[Magisk] Didgeridoohan:
Does the recovery log look the same or just the error number?
[Magisk] jhedfors:
[MENTION=7142895]NovaViper[/MENTION] please attach a file, rather than paste in post when it is longer than a snippet. Thank you.
[Magisk] NovaViper:
I tried to attach the file but it kept failing to upload it
[Magisk] jadajada:
Hi!

I have a Nexus 5X, it is running latest Pixel Rom. I am not rooted. I am trying to install Magisk, but when I flash it in TWRP it says:

SuperSU patched boot detected

Please immediatly flash SuperSU now

installation will complete after flashing SuperSU

Updater process ended with error 1

As far as I know, I don't have SuperSU. I don't want SuperSU, I want Phh superuser w/ Magisk.

How can I proceed?
[Magisk] Didgeridoohan:
Here's the important part... I'm guessing that your ROM comes pre-rooted with SuperSU. That's usually the case when you get this error message and I'm guessing you'd get the same message if you tried to flash the official SuperSU zip.

From what I've experienced there's not much to do except to make sure you start with a boot image that's not patched for SuperSU (check your ROM/device thread for help with that). After that you can choose to still use SuperSU by installing it systemless before installing Magisk. Or you can choose MagiskSU and then you just flash the Magisk zip and you're done.

---------- Post added at 20:14 ---------- Previous post was at 20:13 ----------

See the above answer to [MENTION=7142895]NovaViper[/MENTION]

Edit: Ok... Pixel ROM for N5X doesn't seem to come pre-rooted. Have you had SuperSU installed previously?
[Magisk] NovaViper:
It does but it loads SuperSU just fine when flashing it, even got it systemless. But I notice when this time around flashing the rom again it DIDN'T install SuperSu, had to flash it manually.

Let me explain the REALLY, REALLY lengthy situation I have:

First of all, this was after I finally decided to flash a rom again after having a really major bootloop a couple of months back, I had finally gotten the device to boot up and had the stock firmware all reinstalled and. Then a few days ago I rooted again after debating rather I should or not, and I decided to do so. Last night, I flashed the custom ROM and noticed SuperSU didnt appear, so thats when I went and flashed SuperSU. Today is when i tried to flash systemless Xposed and Magisk but I tried the latest Magisk (which gave me that updater error), then I tried v10 (still the same error), so then I tried v9 (which worked).

---------- Post added at 08:29 PM ---------- Previous post was at 08:21 PM ----------

Also to add in more details, the reason why my phone had ran into that major bootloop was because I tried to flash a rom (CarHD) BUT.. it only supported SM-G925V (didn't think that would make a different but it did), which somehow did work but with the APN not functioning. SOOO, I then flashed the SM-G925V Kernel along with the ROM again, which was what caused the bootloop.. I laterally ran all over to several different repair shops and even took the phone to Sprint (they couldn't fix it because I had no warranty
[Magisk] Didgeridoohan:
Hmm... I don't know. You could try a different kernel, or clean flash your ROM and try again. If nothing works I'd open an issue on GitHub with details, logs and the boot image.

Good luck.
[Magisk] NovaViper:
How would properly clean install? I'm trying to avoid completely nuking my systems files (which was a possible cause to my phone being messed up)
[Magisk] oakley470:
Anyone else experiencing loss of root with magisk 11.1 if you reboot with magisk hide enabled? I saw on op 3 thread a few others started to experience this again but not much here. The only way to keep root alive on a reboot is to keep hide turned off