yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
I believe [MENTION=3615867]teddy0209[/MENTION] asked you to provide some more detail... ROM, recovery log from installation, Magisk log (found in /cache through recovery if you can't get superuser access), etc.

It might be that the Nvidia boot image is incompatible.
[Magisk] dhirajahuja432:
@ teddy0209

Plz help unable to install magisk in my zenfone 5 when I try to install from TWRP its error comes unable to pack boot image recovery log addedhttp://cloud.tapatalk.com/s/5912c60de7871/recovery.log
[Magisk] kudoshinichi30:
plz help, I managed to install magisk hide, it worked for mario run, pokemon go, and passed safety net. But the "Mandiri Online" app (banking app) still detects root. My device is xiaomi mi max helium, rom lineageos 14.1 by nijel8.
[Magisk] karthik km:
Both the games requires just basic integrity and one other but the financial apps ( banking) requires full safety net features

Or

Wait till next magisk release
[Magisk] teddy0209:
Did you add it to the magiskhide list?

---------- Post added at 10:11 AM ---------- Previous post was at 10:08 AM ----------

You better create an issue on github and submit your boot.img...
[Magisk] Pratikmade:
Advanced tab missing
[Magisk] Didgeridoohan:
I am genuinely confused... You'll need to elaborate.
[Magisk] Pratikmade:
Oh I'm sorry, here's the thing, I'm on AICP Rom and it was pre-rooted and all I did was hide by using inbuilt hide and now root access is gone and gives CTS mismatch error. Also the advanced tab is missing from the Magisk setting option.
[Magisk] rignfool:
Can't log... Without root...

Advanced tab is all about logs
[Magisk] Pratikmade:
How can I gain back root access, also the options that were present before like Magisk hide/unhide button.
[Magisk] rignfool:
I would reflash my boot image... Then reflash magisk
[Magisk] Didgeridoohan:
You could start by clearing data for the Manager and then reboot. If that doesn't work, a reinstallation of Magisk should...

---------- Post added at 14:04 ---------- Previous post was at 13:59 ----------

Since he does mention SafetyNet passing I doubt that's the issue...

[MENTION=5002758]kudoshinichi30[/MENTION] Your app probably looks for certain prop values or use other apps to detect root, etc. Take a look in my troubleshooting thread... You might find something that helps.
[Magisk] Raijin:
I'm using VertexOS ROM in my OnePlus 3T. When a new update comes, I wipe /system and then flash the zip (there aren't OTAs). /boot is also replaced with a clean install of it.

After that I flash Gapps and then Magisk. Should I use the Magisk uninstaller every time I do this, before flashing Magisk?

Thank you very much.
[Magisk] waylo:
Are you using the magisk-specific version or the official version? You need the magisk-specific one.
[Magisk] sooyong94:
Where can I get the Magisk specific version of Phh Superuser?

Update - found it.
[Magisk] sooyong94:
Thanks - just managed to sort it out. All I need is to get the Magisk-specific version and everything is working A-OK as expected. ;)
[Magisk] Hakem:
Works perfectly on s7 edge, renovate rom, super stock kernel
[Magisk] fmc000:
Works perfectly on OnePlus One, SlimSaber ROM (6.0.1 - OmniRom based). On this ROM the standard phh's superuser installation ends up in a bootloop whilst with Magisk all works fine :D

Just for confirmation: I understand that every time I upgrade my ROM the only thing I have to do is reflash the Magisk zip and it will take care of the other mods (superuser included)?

Another question: what if I wanted to replace my /system/etc/mixer_paths.xml with a custom one? Is there an easy way to achieve that with Magisk?

Edit: never mind the two questions - already found out my answers :)
[Magisk] tohtorin:
What were the answers?
[Magisk] fmc000:
1) Yes

2) I made a module for that.
[Magisk] tohtorin:
I think its stupid to create module for just one file. Ja
[Magisk] fmc000:
It helped me to understand how it worked. What method would you use?
[Magisk] tohtorin:
I am just super fan of su.d scripting. But have to look into templates.
[Magisk] insaned:
I'm having trouble to root on s7 with the latest android version (G935FXXU1BPH6) and Magisk V6 + phh superuser 17 (magisk version)...

I'm installing it in a full clean version and simply it doesn't get root...

The APK is also being installed.

EDIT: I didn't update Magisk since v3 (as everything was working flawlessly) so now I tried to flash directly the v6 version. That seemed to be the problem... same with v5 and v4 as they don't seem to work on samsung s7 edge even with previous versions of phh superuser (magisk).

I doing full clean stock ROM installs over clean formatted partitions between each flash. (either way flashing the uninstall zip doesn't seem to work to downgrade to v3 and make it work again, I have to flash everything from scratch)

If I flash v3 it works perfectly (along with last versions of phh superuser and xposed)

The only issue is Viper4ANDROID it doesn't work, as it's always asking fro the drivers...
[Magisk] :
In LG G2 with CM13 official with Xposed official (try to install systemless version) gives Secure booting error and to repair the error must be delete Magisk.

In my Note 3 with DU 10.5 Unofficial, Xposed systemless 86.5 and SuperSu install, but I have problems.

-When SuperSu work, Xposed systemless says "Xposed Version vXXX (Systemless by topjohnwu) is installed but not active

-When Xposed systemless work and is active, SuperSu doesn't work and automatic screen rotation doesn't work and because between one to two reboots to stop work and SuperSu work again
[Magisk] KaMyKaSii:
You install Phh's SuperUser from PlayStore?
[Magisk] insaned:
Thanks for the reply.

Yeah, forgot to mention that all apks were installed...

I just edited my post with a follow up as seems that onde s7 edge only v3 is working

"I didn't update Magisk since v3 (as everything was working flawlessly) so now I tried to flash directly the v6 version. That seemed to be the problem... same with v5 and v4 as they don't seem to work on samsung s7 edge even with previous versions of phh superuser (magisk).

I doing full clean stock ROM installs over clean formatted partitions between each flash. (either way flashing the uninstall zip doesn't seem to work to downgrade to v3 and make it work again, I have to flash everything from scratch)

If I flash v3 it works perfectly (along with last versions of phh superuser and xposed)."
[Magisk] JudgeDread11:
I think it's stupid to think something is stupid just because you have different preferences :)

A module can contain just 1 script and can be created without (or at least with very little) knowledge of scripting using the template. Which for me is a big advantage over su.d.

And he doesn't use just that module, he also said that he uses systemless root with magisk.
[Magisk] topjohnwu:
I'm am aware of stock Samsung boot image will not work in the later versions. It shall be addressed in the next update.

BTW, may anyone with a Note 7 give me your 100% stock boot image dump? Thx
[Magisk] topjohnwu:
Well, Magisk is much more complicated than running "scripts"

You don't have to look into templates, just place your script into a folder, and name it correctly so Magisk will know it shall execute your scripts, in the correct time.

I might consider adding a place for scripts only, we'll see
[Magisk] fmc000:
Bootanimation.

In my efforts to better understand how Magisk works, I created a mod that should have activated the Nougat bootanimation. I say "should have" because it didn't work at all even if I found the correct /magisk/system/media/bootanimation.zip after the reboot and the file seems to be mapped correctly under /system ?

What did I do wrong?
[Magisk] Sivat:
If what I understand is correct than I think that it has to be installed to the cache/magisk so it can be mounted before anything else does. But even then I'm not sure that changing the boot animation is a guarantee with this.
[Magisk] Deltadroid:
http://xdaforums.com/showthread.php?p=68533166
[Magisk] rignfool:
No... It will wipe your magisk image... You want to retain that I assume...

Just reflashing Magisk to edit the boot.img is fine
[Magisk] fhLan:
can anyone please explain, why magisk hide breaks gello and firefox? thank you
[Magisk] Didgeridoohan:
Not without some details... We are (unfortunately) not mind readers, so you're going to have to elaborate a bit around what "breaks" mean.

Firefox works just fine on my devices with Magisk Hide enabled, I've never used Gello.
[Magisk] DodoGTA:
Post a logcat: https://xdaforums.com/showthread.php?t=1726238
[Magisk] Didgeridoohan:
Don't post the log like that, please. Attach it as a text file or use pastebin or similar...

The problem is an old one though and have been discussed a number of times throughout this thread (and a few others). You'll need to flash a boot image that hasn't been patched for SuperSU before flashing Magisk. I have a more thorough explanation in my troubleshooting thread if you'd like (link in my signature).
[Magisk] fhLan:
what log level should i post?
[Magisk] DodoGTA:
Every log level
[Magisk] 煉獄阿飄:
Oh sorry,I will notice next time

But how can I install magisk on this kernel? Or noway to install, thanks
[Magisk] Didgeridoohan:
Like I said, by first flashing a boot image that's not patched for SuperSU. Did you take a look in my troubleshooting thread, like I suggested?
[Magisk] fhLan:
is this enough? i thought this not only happen to me
[Magisk] Didgeridoohan:
You still haven't given any details as to what's actually wrong...
[Magisk] 煉獄阿飄:
Tanks for your help

but I want to use this kernel with magisk

I will try to ask the kernel 's development how to

Thanks
[Magisk] Didgeridoohan:
I'm thinking it's probably not the kernel that's the issue... Of course it all depends on what you're starting with.

If you're switching from SuperSU to MagiskSU, you need to restore your ROM's stock boot image before flashing Magisk. If you use a custom kernel, flash that after the boot image and before the Magisk zip.

If your ROM comes pre-rooted with SuperSU, you're gonna have to find a way to replace the ROM boot image with one that doesn't have the patches. Easiest is to ask in your ROM thread.
[Magisk] fhLan:
if i enable magisk hidde and reboot, gello and firefox would force close
[Magisk] superawx:
hi!

i have a galaxy s8 running BatStock ROM from here.

i am using Magisk 12.0 and every now an then when i start MagiskManager 4.3.3 it tells me, that the device is not rooted and displays a red bar in the middle, although all root functions/apps are working flawless. when i restart the device, everythings is "green" again.

is anyone else having this problem? i remember it also happened with the rooted stock rom.

greetings
[Magisk] culiacanazo:
THANK YOU!!!!!

:rolleyes:
[Magisk] ajm786:
I just installed the latest Pure Nexus ROM that was just released yesterday, and now Magisk SafetyNet check fails with CTS profile mismatch. This is with a brand new clean install. Has anyone experienced the Android security update patches for the month of May breaking anything?
[Magisk] eriedroid:
Nope, fine with my N6P, flashing PN 7.1.2, full gapps, flash kernel & magisk. Just tick magisk hide.
[Magisk] ajm786:
Which version of PN are you using? If I install the April version, it works fine; the May version, it breaks.
[Magisk] eriedroid:
The lastest..., BTW I also flash bootloader, radio & vendor image before FG flashing PN rom.
[Magisk] ajm786:
I definitely have the latest vendor image; I flashed it before I flashed the ROM. Which bootloader and radio version are you running? Only thing I can think is maybe the bootloader is old.

Edit: it was indeed the bootloader. I had 3.67; the May version is 3.68. I flashed the new one, then flashed Magisk again just to be on the safe side, then booted into the ROM and ran the SafetyNet check and it passed.

Thanks for the assist man. Much appreciated. I don't usually make PEBKAC errors, but this was one of those times I did. :D
[Magisk] eriedroid:
Maybe your custom rom doesn't support, Im using pure nexus on Nexus 6p have full access to Mandiri online and BCA Mobile.
[Magisk] Didgeridoohan:
There are a whole lot of permission issues going on in that log of yours, and of course a crash for Firefox.

I'm not quite sure as to how Magisk Hide would cause your issue (I have nowhere nere the knowledge of the inner workings of Android to make any conclusions from that log)...

What's the rest of your setup like? You haven't given any information about your device, ROM, custom kernel, etc. A Magisk log would be good as well.

Just swipe the Manager from recent apps and you should be good to go again. It might have something to do with some mind of battery optimisation (doze, etc)

---------- Post added at 06:43 ---------- Previous post was at 06:39 ----------

That sounds like a coincidence to me... The bootloader shouldn't cause that kind of issue.

My guess would be that Magisk Hide just wasn't starting properly on boot. But I guess it doesn't really matter, since you got it running again. :good:
[Magisk] seacowx:
Hi, i just installed magisk. It's a new thing for me... (previously i was on superSU).

So i found a file named "su.img" in /data

Is that file part of magisk, or not? (because i also found magisk.img) If not, can i safely delete it?

Guess it was part of previous SuperSU thing..just wanna make sure i won't messing up.

And another Q'.. what is the use of "systemless Hosts" in magisk manager..do i need to enable it? (i am using AdAway app atm)

Thanks in advance.
[Magisk] Didgeridoohan:
You're right, that file isn't part of Magisk. Did you completely unroot SuperSU before installing Magisk? Or are you still using SuperSU with Magisk, instead of MagiskSU? That's perfectly possible (although Magisk Hide won't be fully functional since it can't hide SuperSU).

The main point of Magisk is to keep system modifications systemless. Systemless hosts is just what it sounds like... Systemless modifications to the hosts file so that you don't have to look at all those annoying ads. Since you're already using AdAway, you don't really need to enable it; your system has already been modified (unless you had some other mod that made it systemless). And that might be perfectly fine, depending on your use case. Having a completely untouched system is only really necessary if you wan't to update through OTA and even then you'll have to reflash a stock boot image and possibly the stock recovery (if you don't boot, not flash, a custom recovery only when necessary) before upgrading. Myself, I use systemless hosts together with a small Tasker profile that once in a while downloads new hosts from Steven Black, even though I don't really have any need to keep my system untouched.

The main advantage to the Magisk systemless modifications (IMHO) is that they're still there after a system update. And they're real easy to reapply after a full wipe.
[Magisk] teddy0209:
su.img is for supersu as you have suspected... Systemless host for systemless adblocking for those who wants to keep their system unmodified...
[Magisk] seacowx:
Thank you sir for quick answer.

• Yeah it was my bad, i was still on superSU that time. At first attempt i installed magisk manager and flashed magisk.zip unsuccessful. but root detected as superSU 2.79. in magisk manager Then i decide to perform clean installation of magisk (flash stock boot.img - uninstall superSU.apk - flash magisk v12 - install magisk manager) and all seems work fine now. *ss 1 attached

• And found that file "su.img" (size 96mb) in /data. i was doubt to delete it, so i ran here..and now i got it. Thanks for the answer, sir.

• About magisk hide, i've enabled it. I don't know if it works or not (I think it works) perhaps you can tell me.

Also there in log listed name as unmounted [system/etc/hosts] ← this directory is where the host file names placed by AdAway app. Is that ok? *log attached

>> I opened the magisk hide within manager, and see the list of apps. And i checked/enabled 2 of them. The question is.. so those 2 apps "should not detect my magisk/root status", right?

*ss 2 attached

✓ currently settings enabled: magisk hide, systemless host, and both logging options.

Thank you so much for your time, sir.
[Magisk] seacowx:
Yes, noticed it. Thank you sir for confirmed also.

So i was wrong.. i need to disable/uncheck the "systemless hosts" to get my AdAway app running properly/modification?

(eg; Adding the ads host name into blacklist will need/ask permission to write permission on system/etc/hosts for modifications.)

So what should i do? Thank you sir
[Magisk] Didgeridoohan:
Everything looks fine. You might have some issues with leftovers from SuperSU though, since it sounds like you didn't do a full unroot... [MENTION=4544860]osm0sis[/MENTION] have a great tool for cleaning up any leftovers, his unSU script. Just flash that in recovery and you should be good to go.

Easiest way to know if Magisk Hide is working is to do a SafetyNet check in the Manager. If it turns green you're golden. :good: If it turns red, you've got some kind of issue... Might be a number of things, but luckily I've collected a whole bunch of 'em right here.

There's no need to hide those two apps you've added to the Hide list. If your goal is to pass SafetyNet, all you need to do is activate Magisk Hide since SafetyNet (Play services) are on the list by default. Any other apps that don't utilise SafetyNet to detect root and other security issues you'll need to add to the list though.

Recommended reading if you want more info about the workings of Magisk:

The release thread

The All-In-One wiki

And if you encounter issues and need to troubleshoot:

Magisk and Magisk Hide installation and troubleshooting tips and tricks (same link as the one above)
[Magisk] fhLan:
[MENTION=4667597]Didgeridoohan[/MENTION] I'm using s5 with exynos chipset and resurrection remix 7.1.2

https://xdaforums.com/galaxy-s5/gal.../rom-resurrection-remix-5-7-4-t3526192/page74

the interesting thing is if i enable magisk hide and didn't perform a reboot, everything would be fine. so before i want to reboot, i have to disable magisk hide first then reboot
[Magisk] Didgeridoohan:
You can use AdAway with the systemless hosts option. I've used it like that, but if I remember correctly there have been reports of some users having to manually point AdAway to the Magisk hosts file (/magisk/.core/hosts).
[Magisk] fhLan:
[MENTION=4667597]Didgeridoohan[/MENTION] forgot to attach this
[Magisk] seacowx:
Crystal clear. Thanks for the links..I will try flash and re-check.

Ps: SafetyNet=Passed. It's green. Thanks for the help. Have a great day.
[Magisk] Didgeridoohan:
Hm. That's... Interesting. It might be a ROM thing. I've seen some reported issues with Magisk that might be related to RR. I'm not quite sure how to move forward with your issue. What I can tell you is that I've not had any issues with Firefox on any of the devices/ROMs I've used Magisk on.

Could you provide a logcat from when it works, before the reboot? I'd like to compare...

You could try doing a reinstall of Magisk. Uninstall with the uninstaller zip from the release thread and then reinstall.

And by the way: Why have you added Titanium Backup to the Hide list? Seems a little counter productive...
[Magisk] seacowx:
From your Log.. this is the part when your trouble begins:

1# MagiskHide: Permissive detected

2# MagiskHide: Unable to set to enforce, hide the state

It should writen like this for part #2:

1# MagiskHide: Permissive detected

2# MagiskHide: Calling magiskpolicy for pseudo enforce mode

I think it's selinux thing. Do you have any scripts or app that runs at boot for (selinux permissive) ?

That might be persistent​, and also the culprit.

Try check in kernel setting for selinux option.. or simply open within terminal emulator after you enabled magisk hide.

Type in:

getenforce
(to check selinux status)

setenforce 1
(1→enforcing)
(0 →permissive)

edit: This won't persist after next reboots.
[Magisk] Didgeridoohan:
That log entry ("Unable to set to enforce, hide the state") means Magisk is applying a workaround needed on some custom ROMs/kernels for Samsung. It changes permission on a couple of files related to SELinux and is needed for those ROMs to pass SafetyNet with Magisk Hide. From the changelog for Magisk v12:

So, the two log entries you're talking about are practically the same thing where Magisk masks the permissive SELinux, in different ways.

I have no idea if the issue [MENTION=7677833]fhLan[/MENTION] is having (Firefox and Gello crashing with Magisk Hide enabled) could be related to SELinux or changing the permissions for those files. But anything is worth a shot and changing SELinux state is quite easy to check, as long as your kernel allows the change. :)
[Magisk] fhLan:
i was just testing if magisk hide really works
[Magisk] seacowx:
Understood now. There's few difference how magisk hide works on samsung devices. i see that.

For FC thing.. [MENTION=7677833]fhLan[/MENTION] you need to grab logcat, it's the only way to see whats happened. use Logcat Extreme as it's support to play/pause and an option to perform per-app logcat (firefox, etc). Send the appropriate log here and this very nice & helpful man [MENTION=4667597]Didgeridoohan[/MENTION] will help you for sure. :)

edit: I'm on custom ROM+Kernel also. it was set permissive by default. After enabled magisk hide it changed to enforcing state. Does that mean magisk permanently "hide" or "changed" selinux state? Tyvm.
[Magisk] chazarss:
hi all

it is gone be my first time with Magisk, now i am rooted with SuperSU, in installation guide it says download Magisk Manager from Play market then flash the zip provided by app. That is all. Can anyone confirm? i dont wanna break the phone :) thanx in advance...
[Magisk] DodoGTA:
If the SELinux state is permissive, Magisk Hide will hide it (by setting different permissions for /sys/fs/selinux/enforce and /sys/fs/selinux/policy files) or it will activate pseudo-enforced mode (It works by making SELinux policies permissive with sepolicy-inject or magiskpolicy, depending on the version of Magisk you're using and switching back to SELinux Enforcing mode once that process has been finished)

Note: The former method is mostly used on Samsung stock-based custom ROMs, while the latter is used on other devices (like Nexus devices, Samsung devices with AOSP-based or LOS-based custom ROMs etc.)

Note 2: This information is made with Magisk v12 in mind, and will be old with the next version of Magisk
[Magisk] teddy0209:
Yes that is right... If you wan't to keep supersu, assuming it's systemless, you just have to download the app, you can opt to install via the magisk manager or flash via recovery...
[Magisk] DodoGTA:
Magisk has some issues with systemless SuperSU (as of Magisk v12), so uninstall SuperSU completely if you want to use Magisk
[Magisk] chazarss:
You mean uninstall Su from inside of SuperSu app, and you going to be rootless then flash the zip provided by MagiskManager, right ?
[Magisk] seacowx:
Thank you for reply, sir.

Hmm i still don't get it..you can call me mooron on this one if you want.

Other words.. When custom ROM set selinux state as permissive, and magisk hide do.. let say "manipulation" to enforce mode..and it changed the selinux status to "enforcing" as it shown in kernel manager or phone status. So does it means the whole System read the selinux state exactly as enforcing or it actually remains as permissive and enforcing that shown just a 'camouflage' ?

Another example: If an app requires selinux permissive to run properly, so when magisk hide do its 'magisk' and changed the selinux to enforcing, does the app would still read selinux state as permissive instead of enforcing? (enforcing=app can't run properly). This is the part i need to understood.

Thank you for your time, sir.

✓ I'm on latest magisk v12 along with magisk manager 4.3.3
[Magisk] DodoGTA:
Answer to 1st question: The whole system reads the SELinux state as Enforcing, but denials are only logged, like in SELinux Permissive mode (in the case of pseudo-enforced mode)

Answer to 2nd question: The pseudo-enforced mode only needs to be set once