yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
As a root solution, one isn't much different from the other. If you wan't to use Magisk Hide (which most new users seem to focus on) and have a systemless installation of SuperSU already, you'll need to completely remove SuperSU and restore the stock boot image (you can try through the SuperSU app). Otherwise you can just flash Magisk and it'll utilise your systemless SuperSU (for now... Magisk v13 will remove SuperSU compatibility). If you don't have systemless SuperSU the installation script will attempt to remove it and install MagiskSU instead.

All of the above and how to go about it have been covered many, many times in these threads... I've given you some pointers, now it's up to you. :good:
[Magisk] mel2000:
Thanks again for your reply. Unfortunately the Wiki is what gave birth to my question. Are you saying that to systemlessly modify a conf file I must create a Magisk module and submit it to the Magisk Module Repo?

Certainly someone must have already created a module to systemlessly create or edit a given system conf file. I assumed it would be similar to the procedure of placing a ".sh" script into /magisk/.core/post-fs-data.d in order to add or edit a build.prop property. I'll take another hard look at the wiki.

EDIT: It seems that custom modules don't have to be added to the Module Repo.
[Magisk] Didgeridoohan:
No need to submit it to the repo. You can create a module just for yourself. Just download the module template, follow the instructions in the template, zip it up and install through the Manager or flash it in TWRP.

If you want to edit a file file in system (any file), you copy it, edit it and then add it to your module under the same folder structure in the /system directory of the module. It'll then be mounted and replace the default file at boot (as long as AUTOMOUNT=true in config.sh).
[Magisk] mel2000:
I simply want to copy the 20-dns.conf file from the XDA post (Method 3) below. My complication is that the /dhcpcd/dhcpcd-hooks/ directory and its 20-dns.conf file don't exist in /system/etc on my xt1644. I'm hoping that any module I make will auto-create the directory if I specify the 20-dns.conf file path. I'm still researching. Thanks for your help.

XDA post (Method 3, 20-dns.conf):

http://bit.ly/2rJINh3

https://xdaforums.com/general/xda-university/guide-how-to-change-dns-android-device-t3273769
[Magisk] usvimal:
I've flashed magisk v13 on a clean install and safety net does not pass on my phone a few minutes after boot. I think it is because of kernel adiutor applying it's kernel settings on boot. Here attached is the logcat. I tried installing the universal safetynet fix but that doesnt work too. Correct me if I'm wrong but I can just modify /system without failing safetynet right? I used to do that on magisk v12 and still passed safetynet
[Magisk] fOmey:
Ah perfect, thank you.

I was actually after the BETA version, but thank you anyway.
[Magisk] gwilly330:
I just cleaned flashed a new Rom and Kernel, trying to install Magisk v13 beta but got [Error: 1] so i tried v12 but still got [Error:1]! From what i understand, i need to flash stock boot.img to fix this?? And where would i find a stock boot.img for a custom rom??

Samsung Note 3 N900T

MagNa UX 8.5 Rom (6.0.1)

TWRP 3.1.1.0

Phantom Kernel

Log is in attachments (pretty sure its the right one :p)
[Magisk] veez21:
From the looks of it, magisk.img not mounting is the cause of the prob.

Not the boot.img patching
[Magisk] Akhilesh S V:
Just extract ROM's zip you'll see boot.img

But you're trying to flash a Custom Kernel so you need to flash the boot.img located in the Kernel zip
[Magisk] km2442:
Hello, I have problem with Magisk V12. My bank app (pl.ing.mojeing) is detecting that my device is rooted and I can't enable HCE payments despite green SafetyNet and turned on Magisk Hide for this app. What should I do?

PS. Android pay is working well...

Thank you for help.
[Magisk] Spencervb256:
Someone correct me if I'm wrong but some apps check to see if the package name for magisk is installed on that device. Much less advanced than safety net, but as of know there isn't really a way to get around this. I can't say for sure if this is the issue but that's what it sounds like.
[Magisk] Didgeridoohan:
It's quite likely that it could be what [MENTION=7782701]Spencervb256[/MENTION] said. Other possibilities could be that you might have a custom ROM that have certain prop values set to values that the app doesn't like. A usual suspect is ro.build.tags=test-keys. It's also possible that it looks for busybox (but that's not very usual). Or... It just can't be fooled like many other apps looking for root.
[Magisk] Gerard15799:
If it's ro.build.tags=release-keys?
[Magisk] mel2000:
I followed instructions to create my DNS changer module but it didn't work. I believe it might have been due to the following config.sh setting:

REPLACE="

/system/etc/dhcpcd/dhcpcd-hooks

"

The /dhcpcd/dhcpcd-hooks directory didn't exist in /system/etc beforehand, and it looks like Magisk didn't create it.

Although 20-dns.conf was placed in /magisk/system as expected, the module description displayed the following:

system

(no info provided)

(no info provided)

(no info provided)

The following module files were placed in the root /magisk directory and were not removed after I uninstalled the module, so I did so manually.

module.prop

/common/post-fs-data.sh

/common/service.sh

/common/system.prop

Any troubleshooting advice will be greatly appreciated. Thanks.
[Magisk] Didgeridoohan:
Then you're in some deep, deep trouble and probably have a NSA trojan on your device.

Sorry... That was the whiskey talking. :D That's the way it should be. :good:

---------- Post added at 21:17 ---------- Previous post was at 21:15 ----------

Sounds like you haven't quite set up the module as you should. The replace part is only needed if you want to empty out an already existing folder on your device. Upload your module and I'll take a look at it...
[Magisk] mel2000:
Thanks for the offer. See attachment below.
[Magisk] Gerard15799:
Lol for a second I thought I was in deep s***....ahahahahah..
[Magisk] yochananmarqos:
As you noticed, you can't replace a file that didn't exist to begin with. What you'll want to do is create the directory path in the /system folder in your module ZIP and place your 20-dns.conf in it.
[Magisk] adrman:
I'm pretty sure TWRP doesn't support the new File Based Encryption yet. I remember seeing a post from someone that had tried it and TWRP saw all the files in encrypted format. The new Pixel devices will have it as standard, but I think for the short term, FBE is best avoided on existing devices until it becomes more widespread.
[Magisk] steveo17:
i'm running the new TWRP build on my 6p with the most recent factory image and it decrypts my data fine
[Magisk] aliabkad:
I need help here everytime I install xposed systemless, it breaks AP, with stock rom, without xposed install it works flawless
[Magisk] adrman:
But did you wipe data and reencrypt with File Based Encryption? The standard encryption on the 6p is image based. Converting to FBE requires a data wipe.
[Magisk] steveo17:
i must have misunderstood. I am using image based i guess
[Magisk] westeight:
Thank you. That works. :)
[Magisk] CHAMAVELI:
I haven't had any issues with xposed deactivating. You may have soft rebooted which from my experience won't allow xposed to run, even on official versions dating back to dalvik versions.
[Magisk] JRJ442:
I've been having that on my 6p as well. Another reboot works for me. I haven't had to deactivate Xposed or anything like that.
[Magisk] Didgeridoohan:
Nah, nothing like that. Only hard reboots.

Besides, turns out systemless Xposed didn't have anything to do with the density problem. I uninstalled Xposed - density got set properly. Yay. Rebooted and density goes back to stock, even though magisk.log show the post-fs script being run.
[Magisk] CHAMAVELI:
Are you encrypted?
[Magisk] Didgeridoohan:
Yeah, I am. And I've also got a password set up to start my device. I've had a thought about that interfering, but haven't gotten around to testing it yet.
[Magisk] CHAMAVELI:
I'm also encrypted but without the password, so rule that out.

Might unencrypt and see if that's the issue.
[Magisk] Hiyaslalabs:
What can we use instead of synapse? Thanks.
[Magisk] lancespahr:
How would I switch from phh to supersu? Phh doesn't work well with my device :/
[Magisk] djjohnnyblaze:
Hi everyone,

I am trying to get ARISE Numbers 3.5 working with Magisk V6 and am having issues. Please see the below for summary of actions/problems.

- The .zip installs correctly and places the correct files in /magisk/arise

- /system/su.d scripts added to post-fs-data.sh

What happens after I boot:

- System take a long time to boot

- Magisk Manager reports no root

- SuperSU (Magisk version) reports no root

- Xposed (Magisk version) reports no root

- Files that were placed in /magisk/arise/system are not being mounted (at least it seems like it)

- System locks up after 1-2 minutes and I am forced to hard restart

Would anyone be willing to examine the mod?

https://mega.nz/#!oFJhFKgS!QimsSzjHeBASh0fYATCphg9cDGoHF-iAaqu0f7SkMsI

Thanks!
[Magisk] Artim_96:
... Why is it tampering with the post-fs-data.sh? That's something it has to keep it's hands off. So it's not surprising that bootup takes long and nothing works anymore.
[Magisk] djjohnnyblaze:
They were added manually by myself.

I also tried it without touching the post-fs-data.sh file and it yielded the same results. This mod uses /system/su.d scripts.
[Magisk] Artim_96:
Try it without them. Just install it the way described in the template. Nothing should tamper with post-fs-data and also for all I remember it was not recommended to use su.d scripts
[Magisk] djjohnnyblaze:
/magisk/arise/system/su.d folder removed and lines removed from post-fs-data.

Same result.
[Magisk] Artim_96:
Jeesus... Just looked inside the zip... What the hell have you done? It looks like you just took a normal mod that you would flash through recovery and added a few things. I doubt that that could work that easily. At the moment, Magisk mods are made to place/replace files in /system in a systemless way. You should ask someone who really understands how Magisk works, but from what the insides of the zip look like it's not possible that it could work in any way.
[Magisk] Didgeridoohan:
First of all you were using an old module template...

Second, you need to put the same folder structure under the /system folder in the module as you want it to look like in the /system directory on your device. You were mounting the file directly under /system.

Lastly, the REPLACE part in config.sh is only used if you have an existing folder you want to wipe (for example if you want to pseudo-debloat system apps).

I think that was it. Anyway... Here's a fixed version, it might work...
[Magisk] Iradj:
Hi Guys

I made a simple module for testing purposes but it won't install the zip it says the zip file is no Magisk Module.

How i can i solve that ?
[Magisk] Didgeridoohan:
That's usually caused by putting the module files inside a folder in the root of the zip. Don't do that... They need to be directly in the root of the zip.
[Magisk] Iradj:
Ah ok good to know thanks for that. :)
[Magisk] Spencervb256:
So I hope this is the right place to ask, but I would like to try out this on my phone https://xdaforums.com/android/apps-games/app-lenovo-snapit-camera-redmi-note-4-t3608065

I would guess that it is not systemless and would break safety net, so I wondered how I could go about modifying this to be a magisk module? Running v13 beta if it matters. I've downloaded the templates and wondered if that's all I need?

Thanks in advance!
[Magisk] Didgeridoohan:
Systemless modifications is not about passing SafetyNet...

Anyway... About the module; it should be enough to just copy the files over to the module template and do the necessary edits of config.sh and module.prop (follow the instructions in the template).

Edit: Clarification - It's the systemless part of Magisk that makes Magisk Hide tick (and thus passes SafetyNet), but the act of modifying system is not what triggers SafetyNet.
[Magisk] Spencervb256:
Ahhh ok thanks for the clarification. So flashing any zip doesn't necessarily trigger safety net? I do understand how magisk hides root though. Thanks for the clarification about the module, I'll try it out tomorrow or the next day if I have time, thanks!
[Magisk] mel2000:
Thank you so much for all your help, Didgeridoohan. And sorry for the delayed response.

Your revised module installed fine but unfortunately the DNS did not change, according to the Network Info II app. However, I don't think it's the fault of the module, I think that my Moto XT1644 simply doesn't support DNS changes by any 20-dns.conf file mods. The 20-dns.conf DNS mod certainly worked for my Samsung T989. It's worth noting that the Magisk module "Google Domain Name System" didn't work for my phone either. That module changed DNS via build.prop edits. In any case, I think the learning experience was worth it.
[Magisk] EncryptedCurse:
I cannot for the life of me figure out how to get ViPER4Android working on my Galaxy S6 (stock Nougat ROM). I've already tried reinstalling the module multiple times, installing Audio Modification Library & Universal deep_buffer Remover, replacing the audio_effects.conf in /data/magisk/v4a, and a few other things. It still shows that NEON is disabled, status is abnormal, audio format is unsupported, etc.
[Magisk] mel2000:
Sorry for the delayed response to your reply. Thanks for your response. Your advice converged perfectly with that of Didgeridoohan. However, it appears that my Moto XT1644 simply won't allow DNS changes via either build.prop or the 20-dns.conf edits. Still, I'm grateful for the assistance with learning how to create a Magisk module.

I've decided to move on and use the Android DNS Forwarder app to accommodate a DNS change. It doesn't write to the system, it just intercepts DNS requests and routes them to a user specified DNS server. It appears to work but I can't tell since the Network Info II app doesn't show the forwarded DNS.
[Magisk] yochananmarqos:
I was curious to see if it would work for you. Since the file didn't exist in your system to begin with, I wasn't sure if it would work.

The Google DNS module only sets the custom DNS once on boot and does not survive a network change.

To check your current DNS servers, run this command in a terminal emulator:

getprop | grep dns

I'm not sure if DNS Forwarder will work as it hasn't been updated since Kit Kat. Myself, I use the Adguard DNS servers with Override DNS.
[Magisk] mel2000:
I got the same result on my XT1644 after using the AdGuard DNS changer module, and after using The Google DNS changer module.

athene_f:/ $ getprop | grep dns

[net.dns1]: [192.168.1.254]

[net.dns2]: []

[net.rmnet_data0.dns1]: []

[net.rmnet_data0.dns2]: []

athene_f:/ $

Thanks again for all your troubleshooting help. I don't think there's a problem with either module.
[Magisk] Michilon:
Why does Magisk manager say my phone doesn't have the root ? How do I fix it ? Please help me
[Magisk] LOCKhart:
Try Flashing magisk again
[Magisk] dannythetwo:
Nothing happens

After flashing the latest magisk image, I click reboot and the screen goes dark. It does not reboot. I am on Moto G4 plus, Android 7.0, using TWRP custom recovery. I have tried using different versions of TWRP and Magisk. I can not do anything with the phone expect get unto the bootloader, where I can run the uninstall file and then the phone works perfectly normal again. I've read the release notes, known errors, etc. to no avail. Any help is appreciated.
[Magisk] mel2000:
I jus t purchased Override DNS and got the following results at the terminal for AdGuard DNS:

athene_f:/ $ getprop | grep dns

[net.change]: [net.wlan0.dns2]

[net.dns1]: [176.103.130.130]

[net.dns2]: [176.103.130.131]

[net.rmnet_data0.dns1]: []

[net.rmnet_data0.dns2]: []

[net.wlan0.dns1]: [176.103.130.130]

[net.wlan0.dns2]: [176.103.130.131]

athene_f:/ $

Hope that's good news. Network Info II still doesn't show any changed DNS servers
[Magisk] Michilon:
With Magisk manager ?
[Magisk] LOCKhart:
It doesn't matter from where you download. Just flash it through twrp
[Magisk] yochananmarqos:
Yes, those are the Adguard DNS servers.

Network Info II hasn't been updated since 2013, so no it's not going be able to read DNS values.
[Magisk] mel2000:
That's good to know, yochananmarqos. Thanks again.

Too bad about Network Info II since it still gets acceptable reviews. Guess it's time to uninstall it though.
[Magisk] Aid777:
Great app.

I have flashed the latest build of Resurrection Remix on my LG G3 D855. I was unable to get Magisk to work when I flashed the zip, so I installed the apk file and it worked fine. Several hours later my phone did not have root. It was on charge and after I unplugged the USB cable I was going to go to TWRP recovery and noticed the phone was not rooted and therfore no rooted apps worked.

I restarted the phone and then I had root again. This has also happened with another RR user.
[Magisk] Exile1975:
Try disabling the magisk busybox, this might fix the issue
[Magisk] rignfool:
There is a module somewhere... That allows you to use the evil (I think) theme thingy... Similar to VR theming...

But you have to know what you're doing... And I don't... And it is nothing like gravity box

---------- Post added at 10:31 PM ---------- Previous post was at 10:28 PM ----------

I THINK... That resetprop allows you to set DNS servers... I use it... I use Google dns... And I think it's working... I dunno
[Magisk] mel2000:
Thanks for your reply. I added the following AdGuard_DNS_servers.sh script to the /magisk/.core/post-fs-data.d folder, then rebooted:

#!/system/bin/sh
resetprop net.dns1 176.103.130.130
resetprop net.dns2 176.103.130.131
resetprop net.wlan0.dns1 176.103.130.130
resetprop net.wlan0.dns2 176.103.130.131

But I didn't see a DNS change for those build.prop properties when entering the following at my phone's terminal app:

getprop | grep dns

Perhaps my syntax is wrong. Downloaded Magisk scripts and modules seem to work on my XT1644, but my own scripts fail. Anyway, the Android Override DNS app works well enough on my phone for those DNS. But I'd rather use a Magisk script instead.
[Magisk] Didgeridoohan:
The script looks fine. Does it have the correct permissions (755)? If you're using a Magisk v13.0 beta I've noticed a bug where the permissions for the boot scripts doesn't get set properly. You can do it manually...
[Magisk] m1kh41l:
Anyone play Fate/Go game? I don't why Fate still read me as root user.

Magisk Hide = enable

Safety net = all green

Log:

https://pastebin.com/raw/V3pAma1Y
[Magisk] Didgeridoohan:
Because it's using other means of detecting tampering.

It might detect the Magisk Manager itself (a solution for that is being worked on), it might look for certain prop values, it might use other means of detecting root that Magisk Hide can't bypass, etc.
[Magisk] lhrt:
In my Redmi 2 (Custom rom ASOP extended Nuggut) facing some issue. with Magisk. Camera and torch app crashes but without Magisk work flawlessly.

Any thoughts?
[Magisk] Heisenberg92:
Hey. Somebody can look to my log? I using Magisk v12, module universal-safetynet-fix-v2-beta-1.zip and dont pass SafetyNet :/ My phone Xiaomi Redmi Note 4X (snapdragon 625, 3/32) soft xiaomi.eu 7.6.22
[Magisk] yochananmarqos:
Again, even if it does work it will only set DNS once. As soon as there's a network change, that network's DNS will be set. Override DNS will automatically set DNS when the network changes.
[Magisk] mel2000:
Good to know. I'm staying with Override DNS for now. But Override DNS doesn't auto-start at boot, and I have to manually press the "Apply" button to change the DNS after a reboot. Not very accommodating for a paid app.
[Magisk] yochananmarqos:
It has a connectivity receiver so it doesn't really need to start at boot. It will change eventually at boot, it just takes longer.
[Magisk] mel2000:
Again, good to know. Thanks. I'll remove it from my AutoRun app list and see what happens after a reboot.

EDIT: After removing Override DNS from the startup app and rebooting, it didn't provide a connectivity notification after five minutes. Still didn't provide one after opening Google Chrome. Finally provided one the moment I opened the Override DNS app. Perhaps I missed a setting, but I decided to move it back to the AutoRun app.
[Magisk] mel2000:
Again, good to know. Thanks. I'll remove it from my AutoRun app list and see what happens after a reboot.
[Magisk] yochananmarqos:
There are no disadvantages. It doesn't affect root functionally.
[Magisk] mel2000:
Great. Thank you for your prompt reply.
[Magisk] tropicanapure:
Works like a charm. I was able to go from super su + twrp on my OnePlus 3 to magisk without using a PC.

My device now passes safety net and am able to use all the perks like android pay etc. Something I was unable to do the day I rooted my device (2 days after purchase).

Thank you, thank you and thank you![emoji92]
[Magisk] fake2die:
U use module??

Try disable 1 by 1 and see if that work..

I got that camera error too,,but after disable folder_mount module and restart my camera work again..

AOSP Ext 4.3,,magisk v12..
[Magisk] lhrt:
Yes, the issue was because of the Unified Ad Block module and I had to disable it.
[Magisk] lhrt:
The issue was caused by the Unified host adblock module and I had to disable it. Logcat attached.
[Magisk] DodoGTA:
Did you enable Magisk Hide?
[Magisk] _MartyMan_:
On the OnePlus 5, Magisk is working until i decrypt. Is Magisk compatible with decryption at all, or it's just with the OP5?
[Magisk] Didgeridoohan:
Shouldn't matter.

Details, lots of details needed...
[Magisk] otyg:
Wonderin if anyone can help me out, I have a Amlogic s912 tv box (H96 Pro) but Magisk cannot detect the boot image location (cannot auto detect)

And lists these partitions

mmcblk0

mmcblk0boot0

mmcblk0boot1

mmcblk0prmb

mmcblk1

mmcblk1p1 ( ^ thinking this is my sdcard)

what one should I select, btw this device has android 7.1.1

Edit:

Magisk 13 can detect more partitions and seems to work with /dev/block/boot
[Magisk] _MartyMan_:
Sorry i can't post anything, Magisk flashes fine when my data i encrypted, booting up, no issues at all. But when i decrypt, it flashes fine but i can't boot any ROM.
[Magisk] lhrt:
No not enabled. From the locat I can see it is not able to see some libraries.
[Magisk] sgkul:
Magisk wasnt working on my s6 which has nemesis. So I wanted to try reinstalling so I uninstalled it from the shop and now I'm getting a root not installed properly message. Plz someone help
[Magisk] Artim_96:
You have to reinstall Magisk, not just the app
[Magisk] altera011:
Magisk Hide doesn't work sometimes and I really wanted to Play Fate/Grand Order.
[Magisk] doctorm89:
Need help here please!

Problem: Root failure after flashing update of ROM.

I use Resurrection Remix on my Nexus 6P. Once a week I would flash their OTA zip to update to the latest version.

But every time I flash new zips, I lost my root! And Magisk just showed me the red "×" every ****ing time!

I've tried reflashing Magisk_12.0.zip,

or flashing the uninstaller and then reflashing magisk,

or dou-wipe or tri-wipe in TWRP and then reflashing magisk.

All of these did no work.

Hell.....

I googled, but was told that it was "accidentally" or "have a certain probability"...

Anyone knows how to fix it? I really hate to reset my entire Nexus to re-root it.
[Magisk] xUmaRix:
Device : Mi5s

ROM : MIUI 8.6 by xiaomi.eu 7.6.22 | Beta

Magisk V12 + Audio Modification Library v1.4

Busybox and systemless hosts disable.

Currently magiskhide works and i can launch app com.First which is my Telco postpaid app.If magiskhide not working I got error from the app my device is rooted and it quit.However if magiskhide work and I can launch the app but upon signing in my login I got error from the app
[Magisk] xUmaRix:
Attached some screenshots and logs
[Magisk] kramer04:
I don't know RR but Maybe you flash kernel with update.

Extract boot.img from zip rom and install it.

Boot your system.

Install beta magisk in recovery.

If doesn't works fine install universal safetynet fix