yashsingh1/xdaforums huggingface dataset:
[Magisk] washwash:
thx i'll try, adb doesn't work at the moment.

i have a suggestion for [MENTION=4470081]topjohnwu[/MENTION], an option to disable magisk or the modules if a certain file is present on the SD or internal memory, so i just can put the magiskbadnonoyoubad.file on the SD and problem solved without recovery or adb and so on.

looks like a good idea to me, what do you think?
[Magisk] jcmm11:
Except that you can't read internal memory until it's been decrypted, which would happen later in the boot process.
[Magisk] washwash:
SD is not encrypted by default (mine is not at the moment), don't know how it works with internal memory, i'm quite sure my older lollipop internal memory isn't too.
[Magisk] FlaimeR:
+1 same issue

Where to locate the log file ?
[Magisk] J.Michael:
Those are the instructions I used. I *did* try to install Magisk in recovery. I wasn't expecting to see a Magisk recovery menu, but I'm seeing something, and it's not the tablet's original recovery menu.

I finally convinced myself the overwritten line said "Back to previous page". I clicked it and more was written on the screen, starting just under the original mystery menu. It wasn't formatted well -- maybe it expects to be written starting at the top of the screen instead of in the middle of a line in the middle of the screen -- but it said

Start>

Continue boot
​

< More options

press VOLUME keys

Your device has loaded a different operating system

Visit this link on another device:

g.co/ABH

ID:

If no key pressed:

Your device will boot in 5 seconds

and then a repeat of the options menu.

If I hit "Back to previous page" again, it scribbles right off the end of the screen and piles up on the last line.

That web page (g.co/ABH) is a Google page explaining that I got the warning because I changed the operating system, so apparently it's a standard Android menu, just one I've never seen. Maybe the fact that I'm seeing it now means I didn't install Magisk in recovery. I'm sure I checked "Recovery mode" in Advanced Options in Magisk Manager before patching the AP.tar.md5, so I don't know what I could have done wrongly.
[Magisk] martyfender:
I believe you should not be patching the AP.tar.md5 file, but the AP.tar file. I think the AP.tar.md5 is just the checksum file for the AP.tar file. Someone please correct me if I am wrong.
[Magisk] jcmm11:
Do you have TWRP available for your device? If so just go in with TWRP and delete the relevant modules
[Magisk] zgfg:
Most of the fuss is about (O) P and Q, where Internal storage is encrypted.

And for certain devices there is no TWRP or TWRP cannot read encrypted Data and Internal memory.

In that case, you could create/copy 'a certain file' (to command to Magisk) only once you boot to the system - which you cannot, if you have bootloop

Btw, many devices don't have external SD card, but OTG USB could also be a possible place for 'a certain file'

Btw, the whole idea has been discussed here, but instead Magisk is made to support ADB commands to remove modules.

However, that ADB approach unfortunately does not work for all phones
[Magisk] J.Michael:
Samsung chose to slap a ".md5" on the end of the filename to indicate that they had slapped a record containing the md5 hash onto the end of the original file. I think you're right that anyone else in the world would have used the ".md5" extension to indicate a file that contained nothing *but* the MD5 of something else.
[Magisk] J.Michael:
why/when wipe/reset after install Magisk using Odin

Why do the instructions for installing Magisk in recovery on a Samsung with system-as-root say to do a "wipe data / factory reset" after Odin completes?

How critical is the timing? Is it essential that the next thing that happens after leaving Download Mode be the wipe in the stock recovery menu?

I keep fumbling the buttons. It doesn't help that suddenly there is a timeout in some states, so if I take too long finding the buttons, the tablet has gone ahead without me. So far, every time I finish with Odin and try to get to the recovery screen, the tablet boots to the "Let's get started" Android Welcome screen. Is it too late by then? Has some damage already been done, and there's no point in trying to figure out whether I succeeded in installing Magisk?

---------- Post added at 14:17 ---------- Previous post was at 14:08 ----------

Odin one file at a time

The instructions for installing Magisk emphasize the importance of flashing a set of files, not just one file. Is it important that Odin be given all four files at once? Would it be just as good if Odin were given one file at a time, as long as the complete set of files is flashed before ending the Odin session?
[Magisk] Fry-kun:
If I installed Magisk using fastboot, can I get it to store stock images manually? I'd like to use OTA update and not have to re-root by hand..
[Magisk] dcarvil:
Some devices can use OTA update. See https://github.com/topjohnwu/Magisk/blob/master/docs/tutorials.md
[Magisk] Fry-kun:
My device can get OTA updates; the problem is that because of the way I installed Magisk (fastboot), it didn't auto backup stock images.

So, the first step in that tutorial fails with "Stock backup does not exist!" error.

I understand why Magisk can't access stock when I use fastboot install - but maybe there's a way to "feed" it the stock image I have from full factory image?
[Magisk] xunholyx:
What device?

For me with a Pixel 2XL, I flash the factory image editing the flash-all.bat file first to avoid a wipe, then extract the boot.img and patch that with Magisk Manager.
[Magisk] Fry-kun:
Pixel 4 XL

That's what I usually do, too. But if Magisk could restore boot without rebooting, then OTA update should work (reinstall Magisk before rebooting)
[Magisk] Goncalo29:
I kept trying occasionally and it started working, I have no idea why... My advice would be to keep trying every now and then.
[Magisk] jcmm11:
You have 2 options:

1) immediately after patching the boot image you'll find a backup copy in /data/user_de/0/<Magisk Manager package name>/install/

Where <Magisk Manager package name> depends on the random name created if you hide Magisk Manager. The current name is available on the Magisk Manager home screen. (Last line under 'Magisk Manager is up to date')

Backup file is a gzipped file of the boot image named:

stock_boot_<sha1 hash of stock boot image>.img.gz

Note that this file will get deleted, at a minimum when you upgrade the Manager. Possibly in other cases as well. Which is why you should grab it immediately after patching a boot image

2) you can manually create a correctly formatted/named backup copy.

a) get the sha1 hash of the stock boot image

b) rename the stock boot image

stock_boot_<sha1 hash>.img

c) gzip the image

gzip -9 stock_boot_<sha1 hash>.img

(The -9 tells it to use max compression). The gzipped file will replace the original.

In either case drop the backup image into /data/ so you should have:

/data/stock_boot_<sha1 hash of stock boot image>.img.gz

It should be obvious why, when patching an image, Magisk doesn't place the backup here by default. You can patch a file for a different device and trying to restore a boot image from a different device would definitely lead to problems.
[Magisk] J.Michael:
ODIN fails on modem.bin or vbmeta

Trying to flash Magisk modified firmware with ODIN, the last file Odin names is modem.bin. On the tablet, in Download Mode, is the message CHECK FAILED: vbmeta.

The installation instructions say vbmeta is replaced with an empty image.

Anyone else seen this?

This is the tail of the Odin "log" window, showing that vbmeta.img was several files earlier than modem.bin:

<ID:0/005> vendor.img.ext4
<ID:0/005> system.img.ext4
<ID:0/005> vbmeta.img
<ID:0/005> boot.img
<ID:0/005> recovery.img
<ID:0/005> modem.bin
<ID:0/005> Complete(Write) operation failed.
<OSM> All threads completed. (succeed 0 / failed 1)
[Magisk] EntropyAndDespair:
Hi all. i am looking for help to install magisk.

I am trying to get root on Cubot King King Mini.

It runs on Android 9 Pie. This is a system-as-root device. NOT a A/B device.

i' ve found official cubot firmware on cubot site. It contains only .img files data folder with .edb one. i have no idea how to create a .tar from it.

I' ve tried to follow magisk instal guid but failed (i.e. Magisk/install.htm ])

I' ve tried to fastboot flash recovery magisk_patched_recovery.img - got a bootloop. Fixed it by flashing back to stock recovery.img

I' ve tried to fastboot flash boot magisk_patched_boot..img - got nothing (i expected this but still tried)
[Magisk] Didgeridoohan:
When patching an image, the stock boot should be backed up (IIRC). But, that currently doesn't work properly if you patch with a hidden Manager. I believe this commit fixes that:

https://github.com/topjohnwu/Magisk/commit/695c8bc5d0a4b3d22938e3661f54b9abc8b1b396

Meanwhile you could try the above suggestions or simply unhide the Manager when patching. Would be interesting to see if that works...
[Magisk] viercp:
I have probs with my banking pay app (Elba pay app) - cant get it to work

Download app - hide in Magisk - force app stop - delete data (i think this is the usual way) but when i open it it still show "your devices is rooted" and wont open

Maybe somebody has experience in how i can get it work
[Magisk] ktmom:
Try the canary build and make sure to get logs. You might also link to the firmware you are using.

The problem is, saying it doesn't work doesn't leave much room to help you. It sounds like you bootloop but even that doesn't narrow down the problem. Logs are generated by Magisk manager when you patch the image. It's possible there is something there. Knowing that the Fastboot flash went ok is important. And then getting some idea about the bootloop. The linked document for getting logs should help you.

This device is out on the fringes so there isn't likely to be anyone who shows up to say, "I've seen that".

---------- Post added at 09:51 ---------- Previous post was at 09:49 ----------

Hiding root from apps
[Magisk] J.Michael:
Canary won't patch

I tried using the Canary build of Magisk Manager to patch an AP.tar.md5 file. I installed Magisk Manager Canary, then clicked "Install" next to Manager to *really* install it. Then clicked "Install" expecting to get a chance to choose a file to patch. It just keeps installing the latest version of the Manager. (It's not stuck in a loop. I mean that every time I click "Install", it installs/updates Manager, it doesn't give me a chance to select a file to patch.)

Samsung Galaxy Tab A 8" (2019) (SM-T290)

I had earlier used the release version of Magisk Manager and got it to patch an AP.tar.md5 file.
[Magisk] jcmm11:
Try clicking install next to Magisk, NOT Manager

Install/Install/Select and patch a file
[Magisk] J.Michael:
Thank you. I only had to wipe three times to realize that.

---------- Post added 12-28-2019 at 00:18 ---------- Previous post was 12-27-2019 at 23:54 ----------

still SECURE CHECK FAIL: vbmeta

Using Magisk Manager Canary 7.4.1.7fa2625a, Recovery Mode checked (in addition to Preserve force encryption, and Preserve AVB 2.0/dm-verity), download to tablet with "Odin3 v3.13.3_3B_PatcheD.exe":

Odin says Fail

Download Mode says SECURE CHECK FAIL: vbmeta

7-zip says the vbmeta.img in magisk-patched.tar is Size:256, Compressed:512. (Did they switch the column labels?)

The tablet boots afterward. How is it not ruined by the aborted download? Does Download Mode *not* change anything until the session completes successfully?
[Magisk] EntropyAndDespair:
Following the magisk instructions i should:

2. Unzip the firmware and copy the AP tar file to your device. It is normally named as AP_[device_model_sw_ver].tar.md5

But there are no any tar files in device firmware. cubot(put a comma here i cant post links)net/support/firmware/kingkong-mini/CUBOT_KINGKONG_MINI_9101C_V06_20191121.html

3. Install the latest Magisk Manager

4. In Magisk Manager: Install → Install → Select and Patch a File and select the AP tar file.

And there is no option to patch a tar file in magisk manager app.

I tried to flash recovery only a recovery image but got a bootloop.

I am noob and i am stuck... What should i do?
[Magisk] dcarvil:
As [MENTION=6617276]ktmom[/MENTION] said, "This device is out on the fringes", so I know nothing about your phone. The following may not work and may brick your phone. Do this at your own risk. If your phone does not support fastboot mode, this will not work.

Do steps 1 - 3 you listed above, except replace the AP tar file with boot.img.

4. In Magisk Manager: Install → Install → Select and Patch a File and select the boot.img file from the zip.

5. This will create magisk_patched.img. Copy that file back to your PC.

6. Download and install the latest platform tools from https://developer.android.com/studio/releases/platform-tools

7. Place magisk_patched.img in the same directory as fastboot from the platform tools. If you are not familiar with platform tools read up on their usage, and usage of the fastboot mode on your phone.

8. Put the phone in fastboot mode.

9. On your PC, execute "fastboot boot magisk_patched.img" from a command window.

10. If boot is successful, open Magisk Manager and install Magisk from Manager.
[Magisk] EntropyAndDespair:
Thank you for you responce. Any reply is a bless in my situation.

I alreadyl that tried. From 2 different pc. Windows / Ububntu. Flashing went successful but it won't grant root.

Cubot Mini is system-as-root device. so i think i should follow system-as-root part in magisk instructions.
[Magisk] oky.satriawan18@gmail.com:
Mohon bantuannya magisk saya tidak bisa terinstal Mohon bantuannya,

Saya menggunakan ROM NSA MASIK V.9.11

Device Redmi Note 7
[Magisk] grhomes:
Hey gang.

I'm stumped. I've been using Magisk for years. Been using nexus/pixels for years. Flashed magisk to multiple phones. Can't understand why it's not working now.

Cracked a Pixel 3XL and ordered a replacement from Assurant. New phone arrives, unlock bootloader, extract latest boot.img from factory image, adb install magisk.apk, push the boot.img to the phone, patch it in magisk successfully, pull it back to platform-tools. Reboot to bootloader:

C:\Android\platform-tools>fastboot flash boot magisk_patched.img --slot all

Sending 'boot_a' (30372 KB) OKAY [ 1.219s]

Writing 'boot_a' OKAY [ 0.126s]

Sending 'boot_b' (30372 KB) OKAY [ 1.219s]

Writing 'boot_b' OKAY [ 0.131s]

Finished. Total time: 3.230s

Phone reboots successfully. Open magisk manager..aaaaaand

Magisk is not installed.

Interestingly, I've tried switching slots and can't get to slot b...not sure if that's related. Also tried to simply boot the patched.img and still shows Magisk is not installed. Used both beta and canary builds. Nothing.

I've updated my sdk/platform tools to latest. Even used a different computer/cable. Nada.

Magisk patch log -> https://drive.google.com/open?id=1H45jWK8n9tfl3Q7quxnYuDTt_HUhv6lT

I'm up for any suggestions as I have about 10 days left to send this cracked 3XL back before Assurant gets $2k for me not returning the cracked (but rooted, so therefore daily driver.)

Thanks in advance
[Magisk] dcarvil:
I saw a similar post where someone did "fastboot boot magisk_patched.img" (no flash, just boot), then installed Magisk from Magisk Manager when the boot completed. Hopefully that will help.,
[Magisk] grhomes:
Tried this already to no avail. Thanks for the tip though.
[Magisk] ktmom:
In the pixel forums, some people have been reporting having trouble with the December update. Try patching the image again. Or try with canary. Make sure the Magisk manager you are using is consultant with the Magisk version.
[Magisk] grhomes:
THAT'S EXACTLY RIGHT

Went all the way back to the final 9.0 factory image just to try something different. Did the same steps as above and got it working. Good to know the December update is trash lol. I wonder if it's easier to take the ota and try re-flashing the patched image after that?

edit* Gonna use this method: https://github.com/topjohnwu/Magisk/blob/master/docs/tutorials.md

[MENTION=4470081]topjohnwu[/MENTION] is a hero. Happy new year gang.
[Magisk] ktmom:
You are checking the box in Magisk manager, under advanced to enable recovery mode before patching the recovery image, correct?

If that's not it, then getting logs as described in the link I provided earlier is your only hope. It may be that a fix for your device is required.

---------- Post added at 21:28 ---------- Previous post was at 21:13 ----------

Please post in English in this forum. You can use a translator and include the original text, but the post needs to include the English translation.

If you have TWRP installed, flash the Magisk zip through recovery. Otherwise, you should patch the boot.bombing in Magisk manager then Fastboot flash it.

If you still have trouble, then you need to provide more details as to what you have done and what is not working.

It's always a good idea to try the canary build since it has fixes that are not yet in the stable release. It also has expanded debugging so when you get logs they will be more helpful.

You should also look at https://www.didgeridoohan.com/magisk/HomePage which contains helpful troubleshooting information.
[Magisk] brown1178:
Hello, I recently updated my OP6 to OOS 10.3.0. Magisk is installed and works just fine. Only thing is after a reboot, Magsik Manager opens by itself about 4 -5 times. Then shortly after the reboot when opening an app with root granted, Magisk Manager opens again. After some time this doesn't happen. Any ideas why this happens?
[Magisk] EntropyAndDespair:
My main frustration is that there is only one way in /topjohnwu/Magisk/blob/master/docs/install.md Instructions for system-as-root devices. And those are for samsung!

And it includes patching .tar files. And i dont have one. And there is no option to patch a tar file in magisk menu!

Should i patch both boot.img and recovery,img and flash them at the same time ? Do i need a factory reset before / after it?

from magisk Instructions : If you don't need to patch the full firmware, you can manually create a tar file with at least vbmeta.img, boot.img, and recovery.img to let Magisk Manager patch your images in the proper way

vbmeta.img patching fails!
[Magisk] rcky844:
I installed the stable version of Magisk and it doesn't work. It stuck on the boot splash.vWhen I restored the boot image, it worked alright.

It is a Lenovo Phab Plus / Lenovo PB1-770M
[Magisk] Didgeridoohan:
There's definitely instructions for other devices than Samsung...

Starting here:

https://topjohnwu.github.io/Magisk/install.html#getting-started

Which will lead you to here (using the recovery image):

https://topjohnwu.github.io/Magisk/install.html#boot-image-patching

And here:

https://topjohnwu.github.io/Magisk/install.html#magisk-in-recovery

The specific Samsung section is there because Samsung is, let's say "special". If you don't have a Samsung device, don't follow those instructions but the ones I've linked above.
[Magisk] EntropyAndDespair:
Eh... i ve tried that. Got a bootloop.

Thank you for trying to help me.

Solving other people problems by internet is more frustrating than what i am trying to do.
[Magisk] warrencoakley:
Latest Magisk update is not unistalling modules completely.
[Magisk] Badger50:
Did you check off the trash can, or just the circle?
[Magisk] warrencoakley:
I tried both and it keeps coming back the same.
[Magisk] Badger50:
Does the module in question still show up in /data/adb/modules? If so, then delete it there with your root explorer type app.
[Magisk] warrencoakley:
Yes that worked but must be a bug with canary build I'd say. Thanks for your help.

---------- Post added at 01:37 PM ---------- Previous post was at 01:35 PM ----------

One more question. Have you had any issues with the volume of Bluetooth audio when listening with headphones? When sting on the device it all seems good but when listening by Bluetooth audio the sound is very low. Could this be a kernal issue. Can't seem to find what the issue is.

---------- Post added at 01:38 PM ---------- Previous post was at 01:37 PM ----------

One more question. Have you had any issues with the volume of Bluetooth audio when listening with headphones? When sting on the device it all seems good but when listening by Bluetooth audio the sound is very low. Could this be a kernal issue. Can't seem to find what the issue is.

---------- Post added at 01:39 PM ---------- Previous post was at 01:38 PM ----------

One more question. Have you had any issues with the volume of Bluetooth audio when listening with headphones? When listening on the device it all seems good but when listening by Bluetooth audio the sound is very low. Could this be a kernal issue. Can't seem to find what the issue is.
[Magisk] Badger50:
Can't help you out there my friend. I don't listen to music with bluetooth headphones. :confused:
[Magisk] warrencoakley:
Ah ok. Mmmm something is a miss. Not sure if it's a module or the Kernal installed. Thanks anyway
[Magisk] DoctorSubtilis:
my first time with magisk

This is the first time I try to root my android smartphone (I have already "rooted", so to say, my tablet with kingroot, but I'm not suer of the result...), an Asus Zenfone 2 (Z00ED) with Android 6.

I have downloaded from a github site two img, whose name are:

stock_recovery_Z00ED_WW_Phone_13.10.7.1.img (32 mb)

twrp-3.0.2-0-ze500kl.img (15 mb)

Installed Magisk Maneger and patched two img:

the first (from stock_recovery_Z00ED_WW_Phone_13.10.7.1.img) is now about 11mb

the second twrp-3.0.2-0-ze500kl.img is still about 15 mb.

But you already told (on github) me that I should flash "neither" of them.

So my question is: where can I get a suitable boot image of my Asus Z00ED so that I could patch it with Magisk Manager? All the apps which can backup the boot img, indeed, require root.

Besides: There is a risk to make the smartphone unusable?

Thank you
[Magisk] Didgeridoohan:
It's uninstalling the module, but the directory isn't removed. I can confirm and have let [MENTION=4470081]topjohnwu[/MENTION] know.
[Magisk] Didgeridoohan:
The recovery image is only to be used for SAR A-only devices. That's not the case for your device so you have to find the boot image somehow.

I would check your device's forum for further advice:

https://xdaforums.com/zenfone2
[Magisk] ktmom:
Have you tried installing the canary build? It has fixes that do not yet exist in the stable build.
[Magisk] Omutooro:
Hi guys. I flashed my PixelExperience ROM and after boot, I flashed Magisk zip but the manager app still says no magisk installed. Is there something I did wrong?
[Magisk] garylawwd:
Device? Android version? Twrp logs? You can't just say it doesn't work and provide no information at all
[Magisk] Omutooro:
I am Using Galaxy A50
[Magisk] ktmom:
And the log from flashing in TWRP?
[Magisk] Omutooro:
Galaxy A50, PixelExperience Android 10.

---------- Post added at 04:24 PM ---------- Previous post was at 04:20 PM ----------

All the file types I try to upload fail. I don't know what's wrong with this app

---------- Post added at 04:25 PM ---------- Previous post was at 04:24 PM ----------

All the file types I try to upload fail. I don't know what's wrong with this app

---------- Post added at 04:25 PM ---------- Previous post was at 04:25 PM ----------

All the file types I try to upload fail. I don't know what's wrong with this app

---------- Post added at 04:26 PM ---------- Previous post was at 04:25 PM ----------

All the file types I try to upload fail. I don't know what's wrong with this app

---------- Post added at 04:26 PM ---------- Previous post was at 04:26 PM ----------

All the file types I try to upload fail. I don't know what's wrong with this app

---------- Post added at 04:27 PM ---------- Previous post was at 04:26 PM ----------

All the file types I try to upload fail. I don't know what's wrong with this app

---------- Post added at 04:27 PM ---------- Previous post was at 04:27 PM ----------

All the file types I try to upload fail. I don't know what's wrong with this app