[Magisk] pndwal:
Not my intention at all...

Only sought to clarify why it worked out that way (my take on it) in view of:

... Sorry it got long-winded too... Just to many aspects...

Yeah, but instructions were probably not official, and probably included tarballing recovery just to cover A-only A9 LV (Ramdisk=No) devices... Other devices would only patch /boot and /vbmeta and AFAIK /boot isn't touched for A-only A9 LV devices (w/ Recovery mode selected), so still only 2 internal images are patched... And now late devices require/init_boot patching instead of /boot...

Also, since 2SI refactoring vbmeta patching may actually prevent booting on some Sammy devices, but this PR:

Patch vbmeta flags in Samsung tar firmware packages optionally #7181 by XDABlackMesa123 closed on Aug 29, 2023

never got merged and issues with it were still not resolved after last OP comments in October so it appears that /vbmeta is still always patched for Sammy and that users of certain devices (Galaxy A51, Galaxy Note 10 lite, Galaxy Tab Active 3) actually need to un-patch /vbmeta to bypass vbmeta hash mismatch error... Ie, processing AP should have patched only 1 internal image and therefore further flashing is needed to fix the issue.

Back to the device in question: I assumed it was a Galaxy A12 as member said, but actually that's SM-A125x... SM-A127M is actually A12s or A12 Nacho... A12 launched with Android 10, but A12 Nacho with Android 11... Anyway, /recovery definitely should NOT be Magisk patched!

That's strange... I assumed you'd done it with HOME_CSC (to keep user data)... CSC should have worked...

... Are you using correct ROM?... Device is NOT Galaxy A12!!! It's A12s or A12 Nacho as stated above!... So did you use A12s/Nacho (SM-A127x) ROM, not A12 ROM (ie SM-A125x)?... Also, correct regional variant etc?...

Otherwise, perhaps /vbmeta isn't flashed without some specific setting in Odin?? I assume it should be... (/vbmeta would have been altered by previous Magisk installation.)

I explained this already... Patching on another device probably won't work w/ Magisk 26+ due to detecting and setting wrong selinux rule directory... It would most likely have worked with older Magisk...

This change in 26104+:

Ignore userdata.img in Samsung tar firmware packages​

XDABlackMesa123 authored and topjohnwu

committed 9 months ago

... and this PR comment:

https://github.com/topjohnwu/Magisk/pull/7129#issue-1779006020

Seems no issue with that was picked up...

Presumably that worked as /vbmeta was patched, as I said (flashing AP should restore/vbmeta to stock)... Patched/stripped vbmeta flags disables AVB checks for correct partitions... I still have doubts now you're using correct ROM variant due to initial failure using binaries incl CSC...

This is quite normal even if TWRP matches... TeamWin/TWRP instructions (check official ones for your device or a similar one) discuss ways to override ROM protections including overwriting changes detected in recovery partition... Generally this simply requires booting directly to recovery immediately after flashing (not booting to Android first), sometimes more... Either way, beware of flashing mismatched custom recoveries as that may mess with partition tables and more... Personally, I'd avoid TWRP when using Magisk unless installing a custom ROM...

Still trying to patch on different device???... I already told you why that won't work with post 26.0 Magisk...

As I said, patching with 27.0 should work if done on your device... If patching on another, use older than 26.0...

AFAIK, and I'm not a Sammy users, it simply means patching all binaries with CSS rather than HOME_CSC... Just don't know why it didn't work cos you said you already tried... Suspect wrong ROM or regional variant...

So either trying late Magisk patched on a different device, or there's an issue with 27.0...

Again, cos vbmeta is still patched...

Wow...

But you did that in the first place!... What changed?... Were you previously using wrong ROM (ie for A12, ie SM-A125x instead of A12s/Nacho, SM-A127x) or regional variant?...

Please say if you were still patching on different (Galaxy A32) device... In that case 25.2 should work while 27.0 (26.0+) should not...

👍PW