yashsingh1/xdaforums huggingface dataset:
[Magisk] andrea0807:
Hello, on android 9 which version of magisk should I install?
[Magisk] HerrPoetry:
Modules: see attached screen shot. (This was all configured for me, and I have no experience tinkering with it. Happy to do so with guidance.)

getprop output: LM-V350
[Magisk] zgfg:
Both USNF and MHPC modules might be changing ro.product.model

You could try disabling them and test does it fix your problem (however, you will most likely fail SafetyNet then)

Btw, I'm not familiar with your device and is that LM-V350 your genuine model name or not - for example, for my Xiaomi 11Lite 5G NE the model name is 2109119DG but for you (with another phone, even from another vendor) it doesn't mean anything (and you could not judge is it genuine or changed by some module)🙂
[Magisk] zgfg:
One more comment

My question/suggestion about ro product.model was about the second part from your original post - that Google Play does not recognize your phone as LG

However, I can not comment about Google messaging. I don't use them.

And, first of all, you must be sure did they work before you rooted the phone

Maybe something else blocks their notifications.

Maybe you should disable Battery optimization for the app (you need to find in your native Settings) to prevent that when phone goes asleep, that messages are not received.

In short, I doubt it is related to Magisk

---

Btw, you wrote that you run stock ROM.

For stock, you usually don't need MHPC (to pass SafetyNet)?!
[Magisk] pndwal:
@zgfg, @HerrPoetry

Model = LG V35 ThinQ

Smali patcher raises my eyebrows... I've no experience, but guess patching (mock location / provider?) is a likely cause... PW
[Magisk] zgfg:
You can not read what he patched by Smali. But yes, most users patch for mocking locations

However, I have not heard that Smali affect Google Play and so

I patch Secure screenshots (Smali), for two years on one phone and since I rooted my second/new phone, and never ever had any side effects

But @HerrPoetry should disable all modules and test - all the listed modules are systemless.

And if it helps, then to disable one by one module to find the culprit
[Magisk] HerrPoetry:
Noob Q's before I proceed with this advice:

Can disabling/reenabling these mods cause loss of root (or anything that will take hours to fix)?

Do I need to reboot after each disable/enable, or are effects immediate?
[Magisk] HerrPoetry:
build.prop sounds like it might be important. Here are the complete contents of the build.prop file on the phone:
[Magisk] Meooowww:
Indeed. Installing Magisk on klte fails with 24.3 as well as with 24.2.

With 24.0 (didn't try 24.1) it just works.

Thank you and @fubo73 for hinting me to the solution of my problem.

There is probably another new bug on 24.3 that 24.0 lacks.

Magisk app refuses to run if LOS was instructed to use the sd card instead of internal memory.

My attempt being helpful by posting an issue on Github was unsuccessful, as @topjohnwu 's bot instantly closed it.

Seems like what @topjohnwu wrote "I have lost interest in fighting this battle" might indeed apply if he has made a bot just to close incoming bug reports...

Which is a bit sad, as I highly appreciate his wonderful app! Thank you very much, @topjohnwu !

And now trying to get busybox installed on klte with LOS... seems also not that easy.
[Magisk] dr4go:
Because you always need to report issues using the latest canary build - quite understandable if you're asking me.
[Magisk] Meooowww:
Oh well... I understand well... but the problem is that these latest versions fail to start up, aborting directly after showing that message box.

Thus the newer versions do not reach at the point of displaying the version details at all.

But, maybe @topjohnwu reads this thread and so gets aware of these issues...
[Magisk] dr4go:
I'd rather cheat in this case by providing wrong information in the GitHub's issue version number by simply putting the latest canary version there and in the explanation - first line in bold: Please excuse me, I'm using latest stable as latest canary refuses to boot and just shows the message "blah" when booting up.

Might be better as I would not count on XDA in this case so that they don't ignore that bug.
[Magisk] fubo73:
Well, let's just try to flash from twrp, it should abort immediately. In case it works, reflash 24.0 before reboot. I'll try.
[Magisk] HerrPoetry:
I took a quick look at MHPC. The fingerprint for the phone is changed (see attached image). Could this cause any miscommunication with Google Cloud Services?
[Magisk] zgfg:
Yes of course, could be

If stock ROM is certified by Google (usually they are, otherwise GApps will not work properly on the stock, not rooted phone), you don't need MHPC (to cheat fingerprints or whatever).

You need only USNF to pass SaferyNet

I asked you to try with all modules disabled (always must reboot).

For your question: Magisk provides root, not the modules
[Magisk] pndwal:
No, just re-enable...

May need to wipe data in GPay / some bank apps (and set up cards etc again) however... GPay for one can detect security changes that occurred even when it wasn't running...

Yes, not...

Yup, may cause issues; Devs have various choices re. what properties app checks; we can't always know... Changing values for no good reason is asking for issues, even changing for a good one can be a trade off...

Only exception I know of where changed fingerprint is needed on stock is if it's an uncertified ROM, generally China region... PW
[Magisk] pndwal:
No root apps run on adopted / USB / other external storage. 😜

John is inundated with non-issues; he's even closed issues to public for periods of time and indicated that dumb issues are putting strain on his mental health... Moreover, he said he was prepared to close issues permanently and just consider recommendations / bugs / regressions from Magisk collaborators if people didn't start following the rules...

Some issues are actually closed prematurely, but usually by his eager collaborators. 😕 The bot was set up to ensure the template is followed for good reason;

- Devs cannot waste time reading issues already fixed which occurs when users are not using latest Canary.

- Canary integrates verbose logging, and muct time has been wasted getting users to migrate to Canary and understand reasons, not to mention users having to diagnose and collect logs a second time...

- basic details are needed.

Also, non-issues (like yours) should really be resolved in this (or other) Magisk General Support / Discussion thread(s).

Here you are really misapplying John's words. Which is a bit sad...

He was specifically speaking of the game of cat and mouse that has now become 'not enjoyable' and a 'battle' for him, maintaining MagiskHide! He was explaining why he finally 'sunsetted' this function... 😕

🙂

Dead easy...

Use @osm0sis' Busybox for Android NDK (systemless) Magisk module! Nb. basic busybox is also integrated in Magisk...

🤠 PW
[Magisk] pndwal:
If this occurs with latest Canary then pertinent issue is with latest Canary!... And you can report that version / and issue!...

John won't fix early versions anyway. Regressions are addressed in downstream builds.

Just report and let Magisk Devs tell you how to proceed with log taking etc...

If he does its seldom... He has said he is thankful to his information 'distillers' who keep him informed re. XDA comments... PW
[Magisk] Meooowww:
Thank you!

I'll try @osm0sis Busybox Magisk Module, which luckily is available built ready-to-use :).

Originally, I tried to install Stericson's Busybox from PlayStore, but that one fails to install.

Then I tried "Busybox for Android" (which is just annoying with its ads and seems to leave garbage after deinstall) also do not work like I was accustomed to... years ago I used Stericson's Busybox on CM and that just worked, so I got a Linux console on the phone.

From what I read in the Magisk documentation about Busybox, it looks to me as if it only is accessible via adb, not as console on the phone?

I browsed through the github page and did not find a download for the canary build. :(

If I'd have seen any download for that, I definitely would have tried it!

Does there exist any download for the current canary version, or does it need to be built by the user? (sadly, I don't have an android dev environment, so I cannot build it)
[Magisk] m0han:
is this what you're looking for?
[Magisk] fubo73:
Here it is. It always points to latest.
[Magisk] zgfg:
For BusyBox, you have module(s)

Look through Fox Magisk Module Manager

On Magisk GitHub page you do have Canary download - screenshot
[Magisk] Meooowww:
Thank you, @m0han, @fubo73 and @zgfg :)

I'll try the canary build when I got time later today!

I guess I missed the link because usually I only look at the text, and not at colorful things... (probably some mental issue like iconophobia :) )

Already curious for the results and for trying Fox Magisk Module Manager :)

Will report back!
[Magisk] fubo73:
Note that I searched the Web for, I didn't find it on github directly.
[Magisk] m0han:
new canary. md5: d6ce5d2ec3ef60de73c91fa768efa2b1
[Magisk] pndwal:
Latest Official TJW debug Canary Magisk:

Magisk (704f9154) (24305)​

[App] [MagiskSU] Properly support apps using shared UID

[Zygisk] Fix function hooking on devices running Android 12 with old kernels

[BusyBox] Add workaround for devices running old kernels

Diffs to v24.3​

[MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)

[MagiskInit] Introduce new sepolicy injection mechanism

[App] [MagiskSU] Properly support apps using shared UID

[Zygisk] Fix function hooking on devices running Android 12 with old kernels

[BusyBox] Add workaround for devices running old kernels

https://github.com/topjohnwu/magisk-files/blob/3450b32d550ed2752a171899955f69c90410a6fc/notes.md

👍 PW
[Magisk] lapwat:
Hello, the module NFCScreenOff has been updated to version 0.3.3 ==> https://github.com/Magisk-Modules-Repo/NfcScreenOff/blob/master/module.prop

Any idea why the Magisk Manager App is still showing it as version 0.3.2 ?
[Magisk] m0han:
all good this time
[Magisk] zgfg:
Not using that module but under the Releases, 0.3.2 is the Latest, isn't it?
[Magisk] pndwal:
You may misunderstand. Magisk configuration and overlays (all modules etc) are physically located (installed) in /data/adb for convenience (correct permissions, largely unaccessed etc).

You can call busybox from CLI on device; use a terminal emulator app.

With @osm0sis' module installed (at /data/adb/modules/busybox-ndk), for usage simply call:

busybox

:/ $ busybox
BusyBox v1.34.1-osm0sis (2021-10-02 04:33:49 ADT) multi-call binary.
BusyBox is copyrighted by many authors between 1998-2015.
Licensed under GPLv2. See source distribution for detailed copyright notices.

Usage: busybox [function [arguments]...]
or: busybox --list[-full]
or: busybox --show SCRIPT
or: busybox --install [-s] [DIR]
or: function [arguments]...

BusyBox is a multi-call binary that combines many common Unix utilities into a single executable. Most people will create a link to busybox for each function they wish to use and BusyBox will act like whatever it was invoked as.

Currently defined functions:
...

For integrated busybox we need:

su

/data/adb/magisk/busybox

:/ $ su
:/ # /data/adb/magisk/busybox
BusyBox v1.34.1-Magisk (2022-03-22 04:11:29 PDT) multi-call binary.BusyBox is copyrighted by many authors between 1998-2015.
Licensed under GPLv2. See source distribution for detailed
copyright notices.

Usage: busybox [function [arguments]...]
or: busybox --list[-full]
or: busybox --show SCRIPT
or: busybox --install [-s] [DIR]
or: function [arguments]...

BusyBox is a multi-call binary that combines many common Unix
utilities into a single executable. Most people will create a
link to busybox for each function they wish to use and BusyBox
will act like whatever it was invoked as.

Currently defined functions:
...

Aside from options mentioned above, official download for installer is in OP at:

'[TOOLS][ZIPS][SCRIPTS] osm0sis' Odds and Ends [Multiple Devices/Platforms]' https://xdaforums.com/t/tools-zips-scripts-osm0sis-odds-and-ends-multiple-devices-platforms.2239421/

Second item in

Flashable Installer Zips

.

Link to latest Canary (John only wants you to use latest for debug purposes) in Downloads on main page has been clarified, but recent builds are in repo here:

https://github.com/topjohnwu/magisk-files/commits/canary

🤠 PW
[Magisk] lapwat:
Ah yes I forgot the release should be created by hand. Thanks!
[Magisk] zgfg:
Still, when he releases you will probably not see as updatable in Magisk app.

Since its old module.prop did not include update.Json mechanism, hence you will have to download/install manually (or through Fox Mmm)
[Magisk] CobalTitan:
Magisk-704f9154(24305) not work for me with galaxy S7e at android 9. Lost root after migrate to 24303 to 24305.
[Magisk] pndwal:
Did you previously use Hide the Magisk app function?...

If so, check Magisk app called 'setings' (default) or something you choose is gone from Device settings, Apps... PW
[Magisk] CobalTitan:
No after reboot phone it now very slow to start,

No have used hide app magisk
[Magisk] HerrPoetry:
I disabled all modules (and rebooted). Same problems with GCM & FCM. I re-enabled Universal SafetyNet Fix (and rebooted). Same problems. (Added bonus: I use BitDefender AV, and have a subscription; but BitDefender app on phone does not detect my subscription; meanwhile, my BitDefender account on the web shows me this phone -- the LG we're talking about -- and says it's "unprotected". How bizarre can this get?)

Re: ROM -- How could I tell if the ROM is uncertified? (See attached "About Phone→Software" screenshot.)

With Universal SafetyNet Fix enabled and MHPC disabled, SafetyNet passes "Basic integrity" but fails "CTS profile match".

I'm beginning to wonder how I can tell whether the phone's hardware itself is defective, or whether the problem could be fixed just by flashing a different ROM (which I would need some guidance on how to do).
[Magisk] m0han:
i had similar issues, which got resolved when i flashed a newer build of the rom i was running. you could seek/get guidance on your device's forum/thread.
[Magisk] pndwal:
Are you sure you didn't update with previous app hidden?... You can have two competing apps in this case, and no installed Magisk showing as in your screenshot... PW
[Magisk] dohanin:
After updating to canary 24305, Zimperium zips is detecting "App Tampering" when it's started. Not sure if anyone else is experiencing this? Before the update, I didn't get any "threat" detection from zips, and this app itself has not been updated since early March. I haven't reverted magisk back to 24304 because I'm worried installing older version will mess things up, and since zips still allows me to continue, not as bad as root being detected.

I've already tried clearing the app's storage, re-adding it to the denylist, re-installed Shamiko, etc, but it still detects "App Tampering".
[Magisk] Fry-kun:
After updating pixel 6 pro (raven) to latest firmware, spa (sounds like this is Android 12.1) -- flashing Magisk24.3-patched boot in no longer sufficient. Phone boot loops.

Tried flashing with --disable-verity/-verification, flashing vbmeta with same. Also tried downgrading back to previous version (sq1d), which used to work fine. All I get is boot loops.

Might try with Magisk canary next or just run without root for a while, hope someone figures this out 🥲
[Magisk] pndwal:
Did you disable all modules before Android update? PW
[Magisk] Fry-kun:
I don't think that's relevant..?

I only had a couple enabled -- systemless hosts, safetynet fix & that's it, I think.. and upgrades always worked without these being disabled

Notably, downgrade doesn't work even before applying Magisk (stock boot.img).
[Magisk] J.Michael:
In general, mashing the old boot.img back into your device does not qualify as downgrading. If you let them update your system, you have no idea what they chose to modify.

Have you been using the old stock boot.img to try to install Magisk into the updated phone?
[Magisk] Fry-kun:
Not at all.

I usually use the stock images to upgrade, with flash-all.sh (less the -w to keep my data). After that, apply patched boot always from the same package. Not my 1st rodeo 😜

Seeing how the patch failed, I thought I'd reinstall the previous full image while keeping the data. Sq1d flash-all ... and very surprised that this failed, even before messing with its boot (i.e. vanilla, but with unlocked bootloader)
[Magisk] kramer04:
Samsung note9

android 10

Tried magisk canary 24305 but always same issue

it bootloops on samsung logo

How to take log when device bootloop ?
[Magisk] pndwal:
Well I just asked if you did disable to rule modules out, but you are quite right, this will not be relevant if you know all your modules are compatible with Android 12 on your device...

Still may be good to disable till troubleshooting is done...

Which makes me suspect way you upgraded OS... Did you apply full ROM or full OTA? (Doubtful that the latter is an option for pixel, but I may be wrong...) Or did you take standard OTA? If standard (delta incremental) OTA, did you restore all images to stock (eg use Magisk Uninstall, Restore Images option, either w/ standard instructions, or following official OTA, Install to Inactivate Slot guide)?

Please don't take this wrongly if you would never overlook these basics; just want to cover bases. (Rodeo casualties are often old hands!)

Of course, if altered partitions (not sure exactly which on late pixels, but don't assume only boot.img... could be vendor, vbmeta, more) are messed up, simply downloading and dirty flashing up to date (current) complete stock ROM should allow you to downgrade (and hopefully upgrade) Magisk again and keep data incl. Magisk settings / overlays (incl. modules). You'll need to patch / flash Whichever Magisk you install.

Whether the above applies or not, if you still suspect bug / regression in 23.0, I'd certainly try Canary 24305... It has many regression fixes / enhancements that may help you.

Worth noting that Magisk Stable users are actually testing beta changes/fixes in any case... While core Magisk may be Stable, Zygisk is still in Beta for all users, so we should all be aware that issues / regressions still need to be ironed out... True 24+ Stable Magisk is yet to come. 😝 PW
[Magisk] Homeboy76:
Are these instructions still applicable for Google Pixel - 6/6 Pro, 5/5a, 4a5(G}/4a, 4XL, on Android 12.1?

I searched "Canary" "pndwal" for answer but didn't find an answer.
[Magisk] pndwal:
Yup! 😛

As per note there, this was broken since September 2020 but just recently fixed / working again! PR for updated notes still not merged however...

Noted here:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86600573

🙂 PW
[Magisk] Homeboy76:
The reason I asked is the instructions:

...Magisk

NOTE: Install to Inactive Slot is disabled in newer builds of the Magisk app due to changes that Google introduced to the OTA process:

https://twitter.com/i/web/status/1303574238796808192

OTA Upgrade Guides

Magisk does not modify most read-only partitions, which means applying official OTAs is much simpler. Here are the tutorials for several different kind of devices to apply OTAs and preserve Magisk after the installation (if possible). This is just a general guide as procedures for each device may vary.

NOTE: In order to apply OTAs, you HAVE to make sure you haven’t modified and read-only partitons yourself (such as /system or /vendor) in any way. Even remounting the partition to rw will tamper block verification!!

Prerequisites

Please disable Automatic system updates in developer options, so it won’t install OTAs without your acknowledgement.

When an OTA is available, first go to (Magisk app → Uninstall → Restore Images). Do not reboot or you will have Magisk uninstalled. This will restore partitions modified by Magisk back to stock from backups made at install in order to pass pre-OTA block verifications. This step is required before doing any of the following steps written below!

Devices with A/B Partitions

It is possible to have the OTA installed to the inactive slot and have the Magisk app install Magisk onto the updated partitions. The out-of-the-box OTA installation works seamlessly and Magisk can be preserved after the installation.

After restoring stock images, apply OTAs as you normally would (Settings → System → System Update).

Wait for the installation to be fully done (both step 1 and step 2 of the OTA),

do not press the “Restart now” or “Reboot” button!

Instead, go to (Magisk app → Install → Install to Inactive Slot) to install Magisk to the updated slot.

After installation is done, press the reboot button in the Magisk app. Under-the-hood, the Magisk app forces your device to switch to the updated slot, bypassing any possible post-OTA verifications....

When you go to Settings → System → System Update you see Restart now to download the update, but the instructions read

do not press the “Restart now”...
[Magisk] pndwal:
I'm not sure what actually happens with Pixel OTA's... Strange if it does want to restart before downloading update though...

However it seems clear John meant don't agree to

final

restart after ota step 1 and step 2 are 'fully' completed before you also install Magisk to the updated slot... Guessing you just need to differentiate restarts!

Hope a Pixel user can clarify this further... PW
[Magisk] Homeboy76:
Appreciate your input, thank you.

I think the Restart now may start the download.

I agree topjohnwu meant don't restart/reboot until the OTA is downloaded and Magisk is installed to the other slot.

I too "hope a Pixel user can clarify this further..."
[Magisk] Lughnasadh:
Yes, you are both right. The first and only time you restart is in Magisk AFTER you have installed to inactive slot.
[Magisk] Lughnasadh:
Additionally, as stated earlier and in John's instructions, you must be pretty much stock before doing this method. Sometimes just restoring the stock boot image is not enough. For example, custom kernels on the Pixel 6 series not only modify the boot image, but also the dtbo, vendor_boot and vendor_dlkm images as well. So for those on these devices using a custom kernel you must also restore the stock images of theses in addition to the stock boot image before proceeding with this method.
[Magisk] zzz2002:
Can someone point me at "scheck".

TIA
[Magisk] Homeboy76:
<Edited>

So, for members that are using a Custom Kernel

on their Pixel 6/6 Pro they must do the following before downloading the OTA:

Open Magisk and Restore images

fastboot flash dtbo dtbo.img

fastboot flash vendor_boot vendor_boot.img

fastboot flash vendor_dlkm vendor_dlkm.img
[Magisk] Lughnasadh:
This is only for those who use custom kernels that modify more than just the boot image. On the Pixel 6 series these other images are usually modified in custom kernels because of the device structure (for lack of getting into specifics). I'm not sure about the Pixel 5 series and what the kernel developers do there. Pretty sure on the Pixel 4 series and below they only modify the boot image, but it's best to confirm that.

Anyway, to flash back to stock a custom kernel that modifies these images on the Pixel 6 series (and any other applicable Pixel):

adb reboot bootloader

fastboot flash boot boot.img
fastboot flash dtbo dtbo.img
fastboot flash vendor_boot vendor_boot.img

*Of course, using the Magisk app to "Restore Images" should restore the stock boot image and other partitions modified by Magisik as well (but not necessarily the other images mentioned).

vendor_dlkm must be flashed in fastbootd, not fastboot, so

fastboot reboot fastboot (will put you in fastbootd)

fastboot flash vendor_dlkm vendor_dlkm.img

fastboot reboot

No need to flash to both slots. After this your kernel (boot image, etc.) should be in the "stock state" required to use the "Install to Inactive Slot" OTA updating method.

What restoring to the stock state does is allow your device to pass pre-OTA block verifications to be able to take the OTA. Otherwise, the OTA will fail.