yashsingh1/xdaforums huggingface dataset:
[Magisk] zgfg:
Never had any issue like that.

Mounting does not mean that filesystems are duplicated, hence it must not result with any lost in space (besides the minamal for Magisk /data/adb stuff and Manager apk)

Maybe you have a problem with your File Manager, how it counts
[Magisk] Slim2none4u:
Gotta agree with zgfg on this one. I've never seen any literature or seen any post that says anything like this in the entirety of magisk's life. If you have partition our double apps or whatever you got going on, it's on your end and not a Magisk issue.
[Magisk] djsolidsnake86:
magisk 21.2 and mi9 lite with latest android 11 rom xiaomi.eu not working, stuck at MIUI logo
[Magisk] Wolfcity:
More information needed.

Install method? Patching boot.img or flashing by TWRP?

Update or first install of magisk?

Any logs available?
[Magisk] DiamondJohn:
NB: the following is based on my simpllified way of understanding it all.

Symlinking is in a way, the opposite of duplication. Its a tiny POINTER to a file.

As for duplicating data, any modules (and only the modules you install) you have that replace existing system files, then that will be a kinda duplicate under /data/adb/modules/* in that the replacement (which logically is actually different) will be here, as well as the original in the unmodified /system/* or wherever.

So, the major duplication (which is really commonly a replacement when not an addition) are the files under /data/adb/modules/* the symlinks mounts themselves take up absolute minimal storage. i.e. no, your storage is not halved.

Anyone please feel free to correct or clarify anything I have said above.

====================

EDIT: By symklinking, I should clarify that magisk does its voodoo using mounts.
[Magisk] Tiemichael:
How to uninstall Magisk?

I have installed Magisk by flashing a patched boot-image using fastboot ( I have bad experiences with TWRP) - and everything is working fine.

As I am expecting an OTA update of my ROM, I wonder what is going to happen. My concern and question: where is the original boot-image saved?

I read it's saved in /data but could not find anything. When / how was it saved there?

I had to perform a Factory Reset after patching and copying the patched boot-image to my PC. (others download it from somewhere)

So what is my safe way of an OTA-update?

A clean solution could be:

load the Magisk_Uninstaller.zip into Magisk and apply

fastboot flash the original boot.img

OTA-update

patch the new boot-image

Fastboot flash the new patched boot.img

Any comment?

Thanks!

(Xiaomi Poco F2 Pro, Android 11, Magisk 21.02)
[Magisk] J.Michael:
Have you read Magisk OTA doc?
[Magisk] Tiemichael:
Yes, I did - but frankly speaking it confused me so I decided to ask here:

The doc states: 'When an OTA is available, first go to (Magisk Manager → Uninstall → Restore Images)'

===> how is my original boot.image restored? where is it saved?

My device is a "Non A/B" Device", so what I get from this doc for my device / setup is:

Magisk root will not be preserved

Statements referring to Recovery are not applicable as I patched my boot-image

it says 'If you have a copy of your stock image dump, install Magisk by using Magisk Manager's "patch images" feature':

===> so I am re-patching the stock boot.img before the OTA-update? why? to save a copy of my original boot-image? where is it saved (I did this, but when I checked under /data but it's not there)?

it says 'Once you restored back to stock recovery and other images, download the OTA ..'

===> is this 'restore' done in the step before or do I have to do a 'fastboot flash boot ...'

The doc does not mention using 'Magisk-uninstaller.zip' : when is 'Magisk-uninstaller.zip' used?

I want to avoid having the install the entire ROM from scratch, so I seek clarification ...

Thanks!
[Magisk] zgfg:
Perfectly working for me on Xiaomi Mi 9T, with Xiaomi.eu 21.1.6 (yesterday updated to), and previously with 20.12.28 and 20.12.9

You didn't specify how do you install.

I don't kbow if you have proper TWRP, hence suggesting:

- extract boot.img from the downloaded firmware

- install Magisk Manager Canary from the Magisk Github

- from Magisk Manager patch the extracted boot.img, make sure to un-tick Recovery option

- reboot to Fastboot and flash Magisk_patched_*.img to boot

If not familiar with patching method (unfortunately, people mostly still flash Magisk zip from TWRP), consult the Magisk Github docs and Wiki

If you first need to unbrick, just flash the (clean) extracted boot.img from Fastboot
[Magisk] zgfg:
You say that you originally installed Magisk by patching the boot.img

Hence just use once again that same old boot.img (or extract it once again from that same firmware before OTA), and flash that boot.img to boot from Fastboot.

Restore also original recovery.img if you overwrote by TWRP or custom Recovery

If you only used (systemless) Magisk modules, you didn't affect System and so on, hence after the above you will have the firmware clean from Magisk and ready for OTA

And upon you update OTA, patch and flash the its new boot.img, you wil again have your old Magisk modules installed and working

PS: Suggesting you one thing:

Before reflashing that old boot.img, disable (no need to uninstall) all modules.

Upon OTA and flashing the new patched boot img, enable your modues one by one
[Magisk] Tiemichael:
@zgfg :

Thank you!

I wonder why this simple solution is not mentioned in the docs ....
[Magisk] Vixian:
My /data and /system folders are pefrectly mirrored under

/sbin/.magisk/mirror/data

and

/sbin/.magisk/mirror/system which is a symlink to /sbin/.magisk/mirror/system_root

But they are not symlinks it seems, or at least ncdu and ls don't think so. And both the original and the (re?)mounts count towards my storage size.

There's a mention of these "partition mirrors" in https://topjohnwu.github.io/Magisk/details.html, that's why I wanted to ask if this a normal function.

Does it work differently on your phones?

I am running Lineage OS 17.1, with OpenGApps, and Magisk, installed using TWRP.

df reports:

Filesystem Size Used Avail Use% Mounted on
/dev/root 2.9G 2.7G 178M 94% /
tmpfs 1.7G 884K 1.7G 1% /dev
tmpfs 1.7G 0 1.7G 0% /mnt
tmpfs 1.7G 0 1.7G 0% /apex
tmpfs 1.7G 4.0M 1.7G 1% /sbin
/dev/block/bootdevice/by-name/userdata 22G 3.0G 18G 15% /data
/dev/block/bootdevice/by-name/dsp 12M 6.9M 4.5M 61% /system/vendor/dsp
/data/media 22G 3.0G 18G 15% /storage/emulated

But it doesn't report any used size under /sbin.
[Magisk] zgfg:
My mount points on the screenshots, I don't see that /data is mirrored (neither I think it needs to be)
[Magisk] aringler:
somehow I'm note able to get root working.

I do it the usual way, installling the canary apk, patch the boot.img file from the latest factory image in the magisk app, but somehow it creates a strange name of the patched boot image: magisk_patched_li0Ey.img. When it was working it just created a magisk_patched.img.

Then in fastboot, flashing radio, bootloader and the image without reboot, flashing the patched boot.img, resulting in a boot loop.

Is it the same for you guys?

Pixel 5

Januar release

Stock
[Magisk] jenslody:
The name is okay, that's how it is done in recent releases, so older (knowing to work) patched images stay intact.

Besides this, there is not very much information in your post (device, old version, version to flash, installed modules, ...).
[Magisk] aringler:
Sorry yeah, I just heard that magisk might be not working for many people. Just wanted to get this confirmed or not.

Pixel 5

January realese

Installed modules: none, before an update I didn't deinstalled some modules, but this hadn't been a problem.

These were:

- Viper 4 android

- systemless

- busybox
[Magisk] J.Michael:
There is a difference of opinion about what "mirror" means.

Those items in /sbin/.magisk/mirror are *hard* links. I only checked "data" (and yes, I have a "data", I don't know why that varies between devices), but it has the same inode number as "/data". (Use "ls -il")

It is *not* eating up your storage. "du -hs" shows a lot of storage, but that's indirect. "du -hsx" shows 0 used.

"df" doesn't mention "sbin" because "sbin" is not a filesystem, it's just a directory.
[Magisk] J.Michael:
I have read in this thread that Magisk (probably Magisk Manager) saves the original boot.img, I'm sure someone says where, but that's a copy for Magisk's use, not yours. Maybe it gets deleted the first time it's used to "uninstall".

I think various .zip files are only used by TWRP. If you don't have TWRP, you will never use one of these .zip's.

My sense after reading the OTA doc, and having no intention of ever using it, is that the only reliable procedure requires restoring the device to the state it was in before Magisk was installed. Them accept the OTA update. Then install Magisk on this new system. If installing Magisk for the first time required a factory reset / data wipe, this new installation will also require wiping data.

I have read about update procedures that did not result in data loss. I may be confusing updating Magisk with updating the operating system. The requirement to wipe data when Magisk is installed may be limited to stinking Samsung. I just don't know.
[Magisk] zgfg:
1) This new name was already discussed like few days ago, how and why (new feature, for good).

People, why do you think the other should spend time reading your posts and answer ing you, for whatever reason, don't read what the others wrote?!

2) Name does absolutely not matter. You can rename the patched img to ntzggkfiggezuj466tgjkfk.img and you can still flash it from Fastboot (or TWRP)
[Magisk] J.Michael:
Do you know if the suffix is truly random? Or is it an encoded provenance?

Do you know if the suffix is such that a toc sorted by name will list the patched image files in the order in which they were created?
[Magisk] zgfg:
Pretty simple, patch an image five times in the raw and analyze the random suffix

Btw, I would more like that the patched image name contains (also) the Magisk version it was patched by

E.g., when I extract my boot.img I rename it to know to which firmware it belongs, like:

boot-xiaomi.eu_multi_HMK20MI9T_21.1.6_v12-11.img

When I patch it, I rename it to contain also the Magisk version:

boot-Magisk_Canary_21201-xiaomi.eu_multi_HMK20MI9T_21.1.6_v12-11.img

I keep my last/relevant ones on the OTG stick, and when I play with root/no-root, this or that Magisk version, changing firmware - I just hook the OTG stick, select the right img and flash from TWRP
[Magisk] DiamondJohn:
I am on the beta channel, running Magisk 21.2 with 8.04 manager (the latest beta), all running on a Pixel 4a with the latest Android 11 stock rom.

I tried to use Magisk to replace the boot animation, and the it appears to fail, in that the file is still the original not the replacement.

The boot animation in A11 is located in /product/media/bootanimation-dark.zip.

Is it by any chance a known thing that this locatioon can't be modified? All my other rmodules which replace/add/hide all work flawlessly, and I used similar module to replace my boot animation in Oreo using v20.1 which was located somewhere like /system/media/bootanimation.zip
[Magisk] HippoMan:
Forgive me if this question has been answered. I have searched and can't find the answer, mostly because it relates to something specific related to A/B devices, and trying to search here for "A/B" gives me every message that has an "a" or a "b" in it. Maybe there is a better way to search here, but I haven't figured it out yet.

I asked this question a few days ago, but perhaps my question got lost among the other messages that were also posted around the same time ...

I have an A/B device (OnePlus 7 Pro, GM-1917) running Android 10 and TWRP 3.5.0_09. I'm currently running Magisk 20.4. It has been recommended that I move to version 21.2, but I want to make sure that in doing so, I don't lose a certain capability that is important to me.

Under 20.4 on my A/B device, I can load the "TWRP A/B Retention Script" Magisk Module to help me more quickly upgrade my OS to a new A10 version. Its use speeds up and simplifies this OS upgrade process significantly, and I'm hoping I could still use "TWRP A/B Retention Script" for this purpose on my A10 device.

Does anyone know whether "TWRP A/B Retention Script" is still available and usable under Magisk 21.2?

I know that I can upgrade to Magisk 21.2 and test this, but if I do such an upgrade, discover that this module is not available to me, and then go back to 20.4, I don't want to find out that I have problems booting or operating my device because of some side effect of the Magisk downgrade. This is why I'm asking here first if anyone knows whether "TWRP A/B Retention Script" will indeed work under 21.2 on this A10 device. If I am told that it is known for sure not to work under 21.2, then I can save myself the time, effort, and risk of upgrading to this Magisk version in the first place.

Thank you in advance for any info that any of you might be able to provide.
[Magisk] zgfg:
Magisk mounts (systemless changes) when it initializes.

IMO, it is too late for your replaced boot-animation

But for your A11, system-as-root is read-only, and you could not make real (hard) changes to /product (i.e. /system/product)
[Magisk] DiamondJohn:
It worked perfectly in Oreo. The noteable difference now is the location (and the new bootanimation forrmat). If it was a timing issue, at worst I would of expected the bootanimation to play the old one, but once booted, the file would be the new/replaced one. But that is not the case. Its the unmodified one.

I remember a few version back when I first tried using Magisk to replace the boot animation, the first few seconds played the old/original animation but then half way through, it switched to the new/modified one.o_O
[Magisk] zgfg:
Check if your module for changing the boot-animation keeps the new bootanimation-dark.zip file in

/data/adb/modules/<MODULE-NAME>/system/product/media folder (according to the bootanimation path from your first post)

That should be the correct way.

I don't know if your system is A/B, but even then, it should 'work' - in a way that UPON rebooting you see your new bootanimation-dark.zip in /product/media folder, instead of the original one from there
[Magisk] HippoMan:
Well, I have some spare time this weekend -- in case I would need to do an unbrick -- so I decided to take the plunge. I backed up my device, crossed my fingers, said a prayer, switched to the beta channel, and installed 21.2

It came up with no problem, and the "TWRP A/B Retention Script" is still available, as well as the associated "Install to Inactive Slot (after OTA)" option of "INSTALL".

So, it looks like I'm indeed OK with 21.2.

I'm assuming that the post I vaguely remember about this option no longer being available must have pertained to A11, not to Magisk 21.2. Since I have no desire to go to A11, I guess I'll be fine.
[Magisk] J.Michael:
guides.md says:

│ ├── product <--- A symlink to $MODID/system/product

so I think the new animation should be in system/product/media/bootanimation-dark.zip

and there should also be a product -> system/product
[Magisk] zgfg:
We were talking about A11 with read-only system - you cannot do any changes on /product (by symlink equiv. to /system/product

Hence I was talking about the systemless changes, and the /data/adb/modules... path I mentioned is the way how to do it

If needed, consult Magisk docs and/or go to /data/adb/modules and inspect how the other modules similarly do when they need to prepare for Magaisk to add/change/delete over the /system
[Magisk] zgfg:
Test (problems with XDA)
[Magisk] zgfg:
What is going on with XDA, any attempt to answer reports an error, both from browser and XDA app (trying from two phones, the same)

Writing from XDA app, there is no such thing there as browser console

This new XDA server and app is TOTAL DISASTER

The other thing that makes me crazy is searching. You can only search once in the thread. Change the word to search for, and then there is no more an option to search in the thread, only the useless searching all over XDA and "everywhere".

Must restart browser to be able to search the thread again

If I want to search 'everywhere', I will use Google, not this crippled app. But for the forum, organized into threads, it is topmost important that one can easily search through the old posts in threads.

I can't believe that this is not understandable to the XDA admins.

Otherwise, we can better all go to Telegram and ask the same things hundred of times again, nobody there dares to read/follow what was previously written. What was posted yesterday is forgotten as if it was posted in prehistoric era
[Magisk] asripath:
The only thing which it does well is...Ads.
[Magisk] nowster:
Well that's the end of it, I suspect.

My phone had been passing all tests with Basic integrity this morning, using Force BASIC key attestation in MHPC. Some update just now has invalidated that, meaning that fails all tests.

EDIT:

I've now redone MagiskHide Props and set Basic Key attestation to a Nexus 5X and things are verifying again. Odd!
[Magisk] HippoMan:
I spoke too soon. Although 21.2 works in general, something about it keeps the current version of GravityBox from remapping the navigation keys. Other GravityBox features are still working for me, however. I use GravityBox in that manner because it's important to me to be able to perform this navigation key remapping, and so until I can figure out how to get this remapping to work, I have now gone back to 20.4.

I know this is probably a GravityBox issue and not a 21.2 issue, and I'll be soon reporting it in the GravityBox thread. Once I can get GravityBox to work the way I want under 21.2, I'll go back to that version of Magisk.
[Magisk] J.Michael:
With md=/data/adb/modules/<MODULE-NAME>

@DiamondJohn put the new animation zip in ${md}/product/media/bootanimation-dark.zip

@zgfg said put it in ${md}/system/product/media/bootanimation-dark.zip

@J.Michael says *in*addition* create ${md}/product as a symbolic link to ${md}/system/product

I thought it likely that @DiamondJohn did not already have that symbolic link in his module directory.
[Magisk] kebong:
Can i downgrade from v21. 2 to v20. 4 simply on the magisk manager itself, without uninstalling and flashing in twrp?
[Magisk] Didgeridoohan:
│ │ *** Auto Generated, DO NOT MANUALLY CREATE OR MODIFY ***
│ │
│ ├── vendor <--- A symlink to $MODID/system/vendor
│ ├── product <--- A symlink to $MODID/system/product

Source: https://topjohnwu.github.io/Magisk/guides.html#magisk-modules
[Magisk] DiamondJohn:
A bit more info.

Firstly, /system/product is a symlink to /product My original Module did a replce of what is in /product. But the mention of /system/product gave me hope that maybe I just need to do a replace of that one explicitly. But no, that did not change the boot animation that actually ran. However, in the live system, checking the replaced zip DID show the replacement file, not the original. But, as I said, the original was the one that played. :mad:

I also tried having both in the module, but that didnt change anythoing.

Where it does get interesting, is that I had a random reboot (Pixel 4a A11 is buggy!), during the reboot, it played the modified animation!! o_O

I havent tried adding a symlink in the module itself, as I expected that it would reeplace the one in /product and then the symlink would occur later in the boot sequence, and thereby include the modified version. I will try adding the symlink, which is kinda strange, as the folder is what is symlinked in the live OS, not that specific file. But, i'll give it a go.

One thing to remember, is that in a previous version of Magisk (one of the 19 stable releases) It would play the first half of the original, and then mid stream, start playing the replacement animation. This was then "fixed" in the very next stable release. I'm hoping that @topjohnwu also gets a chance to update this little annoyance.:whistle:

PS: I also replaced the light version as well, just in case. It didnt change anything
[Magisk] Robotu:
Hi guys.!

There is a bug in Magisk Manager - when you try to modify the "Request Timeout" (in any way; so better not touch it...) you will not have a request timeout at all (or you will have 3 seconds but it will be blanked so you can just watch as you can not give any root acces), after that the only way is to go in Magisk Manager and you actually will find the app that requested root acces (denied...) and you can change it to allowed.

This was on multiple devices, with Android from 6 to 10...!

The only solution i have found right now (today) was to delete all the data for the app Magisk Manager, and in the future to not touch at all the option "Request Timeout"...!

I hope this will help every one of us...!

Thank you anyway for Magisk.! :)
[Magisk] Robotu:
Maybe in the future can be fixed...!
[Magisk] nostromo12:
Update magisk manager to 8.0.4 fails

I am in the standard channel 20.4 (with LOS 17.1) and opening magisk there is always the message: Upgrade zum vollständigen Magisk Manager, um das Setup abzuschliessen Herunterladen und installieren?

download starts and finishes. But the message box still comes back. I can not open Magisk. Everything was fine before the upgrade. ACC module is active
[Magisk] zgfg:
Disable ACC - (later play with and report them errors if you find)

Uninstall Magisk Manager from Settings, Apps (MM is only the management app, not the Magisk itself - Magisk will remain installed)

Perhaps, you previously did Hide Magisk Manager (there were users with that syndrome who similarly had problems to update) - you must know how you renamed it, uninstall that renamed MM as well. Go one by one through all apps in Settings/Apps, check their names and icons to identify which one it might be (user gives his name to the app, package name is random - there is no better way to identify)

Download the new MM apk from Magisk Github and install - good luck
[Magisk] Splice_9:
The latest update of Magisk, 21.2 from 20.4 has caused my screen to refresh slower with a yellow tint on my Moto G Stylus. I would like to downgrade back to 20.4, but I can't figure out how to do it.

I've searched the forum and still am not sure what to do. I know I need to uninstall Magisk via Magisk manager, but how to I reinstall Magisk-v20.4? The install procedure on the Magisk website uses Magisk Manager to flash the boot.img, and it always defaults to the latest version of Magisk which is currently 21.2.

Thanks.
[Magisk] zgfg:
Magisk Manager Settings, Update channel

If you want to install Magisk Stable 20.4, you must set the channel to Stable
[Magisk] Splice_9:
Thanks. But I am on the stable update channel, and as of this morning it updates to v. 21.2.
[Magisk] knipp21:
Since we are on v7 now.. And I haven't seen it covered.. How do you switch from phh superuser 266 over to chain fire?

Its not a magisk install of phh so I assume I'll need to basically wipe system and start all over?
[Magisk] soder:
What I did a couple of days ago was:

Flash the remove magisk zip.

Boot I think.

Flash SuperSU (the latest beta).

Boot.

Flash Magsik v7.

Boot

Flash suhide 0.53.

Today I flashed suhide 0.54.

/Söder
[Magisk] westeight:
I can confirm that all is working fine with the latest suhide, 0.54:

Magisk 7

SafetyNet

Pokemon Go

Android Pay

Xposed 86.6

Viper4Android

:cowboy:
[Magisk] Captain_Throwback:
Just flash your stock boot.img, and uninstall the Superuser app. That's it. System doesn't get touched, so there's no reason you should wipe it.
[Magisk] dreamland2000:
With the suhide from cf can that be used with phh superuser or does it have to be supersu?
[Magisk] Captain_Throwback:
Go read the OP of the suhide thread ;).
[Magisk] dreamland2000:
That was my next place once the hamster runs faster on my internet lol.
[Magisk] soder:
Not that I need it now, but how do I flash the boot.img?

What file is that my rom's .zip?

/Söder
[Magisk] Captain_Throwback:
boot.img
[Magisk] soder:
And that isn't flashed with flashing the .zip as normal?

/Söder
[Magisk] Captain_Throwback:
Of course if you flash a rom zip the boot.img will get flashed. I'm not sure where you're going with this?