yashsingh1/xdaforums huggingface dataset:
[Magisk] Genericxx:
Yeah i knew that. I fiddled with it for about 3 hours yesterday and was not able to make it Work.
[Magisk] chrcol:
A hint for others who might get confused by the term "boot.img", just reinstall your kernel when you are asked to do that. In my case all my nandroid backups had supersu patched boot.img so obviously restoring those backups would be useless.

Magisk will not even attempt to activate MagiskSU if it detects a SuperSU patched boot.img, this isnt explained in the documentation or the installer log which in my opinion is a bad decision from the dev and can lead to confusion, I also dont see it in the FAQ either. I only knew because some people suggested to me. Also in my case the unSU zip did not unpatch the boot.img, I had to as I said reinstall my kernel which meant Magisk could then patch it for MagiskSU. Of course still run the unSU zip tho as it cleans up other parts of superSU.
[Magisk] joeyddr:
So if anyone else had the issue I did with constant force closing after flashing 11.6, after flashing the latest magisk my webview implementation was gone, I had to go into dev options and select chrome beta for webview the other options vanished.
[Magisk] Didgeridoohan:
After doing some more testing on a different ROM I found I could open the app by just changing ro.build.flavor so that it matches "<device name>-user" rather than "<whatever>-userdebug". Apart from what Magisk Hide changes by default.

On that ROM I could also open the app after it had found root by just force closing it.

In other words... Hiding root is not an exact science. :D
[Magisk] miyorineko:
Installation Failed

I attempted to install Magisk on my Huawei Mate 8 (NXT-DL00) with TWRP an d failed. While flashing, phone reboots automatically. Any ideas to export the log files?
[Magisk] joeyddr:
I installed chrome beta, went into dev options and chose chrome beta as my webview implimentation, for some reason 11.6 removed chrome and system webview, once i chose chrome beta everyhing worked again.
[Magisk] amar2cool99:
Magisk not working for miui
[Magisk] phoberus:
Didn't made a reboot since safetynet passed, but now it fails again. But I'm pretty sure now, that the deamon is'nt running. Because MagiskHide for the apps is also not working, if safetynet not passes.

But anyway, here are the logs.
[Magisk] Januh:
Tell me you flash your boot.img on where? system? boot?
[Magisk] tamer7:
still troubleshooting why MagiskHide doesn't work.

Looking at Magisk Manager log and looking at the code, I think I found the issue.

I think MagiskHide Process monitoring doesn't work, because the PID of the listed process is never printed out in the Magisk Manager log.

https://github.com/topjohnwu/Magisk/blob/master/jni/magiskhide/proc_monitor.c#L70

I read the code of magiskhide/proc_monitor.c more carefully. I think it is failing at this line:

https://github.com/topjohnwu/Magisk/blob/master/jni/magiskhide/proc_monitor.c#L30

because when I run the following command from (su) terminal:

logcat -b events -c

I get the following error:

Unable to open log device 'events'

I think it is the default Phantom Kernel v1 that has logd disabled.

This is Phronesis Note7 ROM v5.1 on Samsung Note 3 (SM-N9005)

---

Edit:

Switched to LSS Kernel , reflashed Magisk 11.6, now able to use logcat commands, but MagiskManager still doesn't show pid of MagiskHide-listed process.

I verified the command it uses works (though it keeps monitoring, doesn't return to shell prompt, so not sure why in the magiskhide code it does a infinite while loop):

logcat -b events -v raw -s am_proc_start
[Magisk] AfterShöcK90:
THIS is what I wanted to read here. Thanks for the heads up.
[Magisk] jhedfors:
boot.img --> boot
[Magisk] joshiameya:
I tried this didn't work, I will revert to 11.1
[Magisk] andrew2432:
Make a back up and flash that isshhhhb
[Magisk] Jaime albino:
Hey guys, i'm using an optimus g pro, i'm on stock lollipop without custom recovery, i do have root beacause i rooted it whit king root, can i use magisk too?, unfortunately i can't install a custom recovery because my micro usb is broken, but i love this phone and i would like to use magisk in it.

thanks in advance.
[Magisk] Jfelips:
Can someone advice me with this? I never heard of this app until now I wanna play Mario Run on my rooted device. Anyway, I'm not sure if I understood what "systemless" means but I already have (regular) root, Xposed framework installed, running Android Marshmallow. How can I install Magisk? The instructions I see says I have to have systemless root and it will delete Xposed ??? I don't wanna do anything I don't know for sure and end getting a bootloop. (My device: Moto X Play 6.0.1)
[Magisk] ShadySquirrel:
Ex G Pro owner here: answer is no. You need a) custom recovery, b) flashable install of Magisk with loki support for modifying boot image, and I think that's an requirement G Pro won't ever meet.
[Magisk] sblonci65:
Hey guys,I have a big problem,I can't flash anything,when I download with magisk manager unfortunately magisk crashed,OK I download magisk modul with chrome and I install with recovery but Dolby atmos and viper 4Android don't work,Dolby crashed and with viper I got a black screen.My device HTC One m9,Ice 5.0.0,Magisk manager 2.2.7,latest magisk.Thanks in advance.
[Magisk] Artim_96:
Best start with flashing your firmware to completely remove root and XPosed. Then get a custom recovery, install the provided zip it get the manager from PlayStore and install it over that.

But be warned: you most likely face bootloops if your /data partition was formatted with F2FS and Norris didn't fix a bug preventing Magisk to work. Then you'll need to get a custom kernel with the fix first, then install Magisk (it contains root), XPosed can be installed afterwards from within Magisk, but it can't be hidden from apps that detect it, only disabling it and reboot will help.

And better don't enable busybox in manager settings, known to big around with root
[Magisk] tag68:
Just in short: systemless means that system partition is not modified. Probably your original root was done systemless (maintaining two X Play by myself I guess so). But once you modified something on system partition, you need to flash system partition from original ROM to get back to a state where OTA is possible and system partition is not modified.
[Magisk] tamer7:
Solved it, but I had to patch Magisk v11.6 process monitor

https://github.com/topjohnwu/Magisk/issues/132#issuecomment-289124501

Now Magisk passes all Safetynet checks on Phronesis N7 ROM v5.1 with lsskernel 3.8UX
[Magisk] Jfelips:
About getting OTA back... After rooting I received a notification yesterday of a security upgrade, can I install it normally? Will it be the same when Nougat comes to Moto X play? Or how can I flash that system partition you said (p.s. I still have stock room, nothing modified but root and Xposed)
[Magisk] tag68:
My answers for Moto X Play are in the noob friendly X Play thread, where you asked the same questions ;)

(I'm not really sure what xposed modifies, long time ago that I used it, but I guess it's system)
[Magisk] J73:
I've started playing a game called Fate/Grand Order and it won't run on rooted devices. I'm running AICP on my device with Magisk baked in. I already enabled Magisk Hide and checked the game from the Magisk Hide menu but it still detects that I'm rooted. Did anybody also encounter this? I'll really appreciate any help. Thanks!

Edit: I'm also on a Gapless setup, if that is of any help.
[Magisk] ebrahim jaber:
install Magisksu but i have problem with long time for bootup
[Magisk] francyesco:
i'm on miui....
[Magisk] kaodd:
Magisk and TB

i'm on galaxy tab t800, AICP 7.1.1 rom with magisk included.

there are some problems with titanium backup and i blame magisk superuser for the issues. somebody else with tb problems?
[Magisk] Pkt_Lnt:
Probably not magisk but this.

https://www.xda-developers.com/psa-...broke-titanium-backup-substratum-heres-a-fix/
[Magisk] kaodd:
actually it's not about substratum (never used it), i can't delete apps with tb. i can freeze and uninstall.
[Magisk] biggdevon:
I'm trying my hand at creating a module but am not having much luck. I've downloaded the latest template and followed the instructions to the best of my ability but when flashing through the mgr I get "Not a Magisk module" error. I'm attempting to automate the set ro.build.selinux prop to 0 at boot. I'm using the previous module listed in this thread called release-keys (https://xdaforums.com/showpost.php?p=71232668&postcount=9773) as a reference on the new template. Anyone care to look it over and point me in the right direction?
[Magisk] jhedfors:
That's mine!:)

Instead of selecting the folder to archive, select the CONTENTS of the folder - go inside the folder, select all -> archive.

Hope this helps.

P.S. I actually set the property in my module you attached.
[Magisk] Pkt_Lnt:
That article says it is caused by Google Play Services and it causes issues with TiBu and Substratum. Did you try that fix?
[Magisk] LazerL0rd:
For Android O, root just needs to be delayed.. could the developer make a mini version that delays the start of root...?
[Magisk] biggdevon:
I used your module on 11.1 and some of the 12betas without issue but it's not working on 11.6. Figured it needed updated to the new template but wanted to create one myself. Archiving it the way you suggested did show it to flash but received an installation error.
[Magisk] jorgis1:
Can someone dumb down magisk for me? I recently just tried this on the OP3T having always done the regular SuperSU type root/systemless. My main question is the magisk partition being ext4 and the storage f2fs. Does the magisk partition affect app load times and whatnot?

Thanks for helping!
[Magisk] MaurixMystic:
Magisk does not install superuser, I want to hide root app (pokemon go) help please

i have sultan rom cm 13 (one plus one) selinux permissive
[Magisk] amar2cool99:
One problem i am facing basic intergerty is true but CTS profile match is false using magisk hide, i am on stock miui
[Magisk] jhedfors:
Ah, yes. 11.6 sets these properties natively (so you should not need my module). However, there is a bug where it always set the selinux value to 1 instead of 0.

The change that is made in the attached zip are in the "/common/magiskhide/enable" file as follows:

Commented out these lines:

#chmod 640 /sys/fs/selinux/enforce #chmod 440 /sys/fs/selinux/policy

(Unless you have a Samsung)

And changed these lines (swapping 1 for 0):

[ ! -z "$BUILDSELINUX" -a "$BUILDSELINUX" != "0" ] && \ log_print "`$BINPATH/resetprop -v -n ro.build.selinux 0`"
[Magisk] kaodd:
yepp i did, but still don't work as tibu should. found out that restart tibu helps! now i blame the app and trump ?.

thx for ur fast response and magisk ?, will buy u one next time i meet u.
[Magisk] Didgeridoohan:
That's awesome! Like [MENTION=1162986]Captain_Throwback[/MENTION] says on GitHub, how about submitting a pull request. Could possibly fix SafetyNet check failing for a bunch of other users as well...

Way to little information you give any useful advice. At least provide a recovery log from the installation.

Google probably just doesn't trust your device/ROM. As far as I've seen on these forums, there might not be much you can do... Edit: You could check your SELinux, if it's enforcing (might be that pseudo-enforce is incompatible with your device). Run the command getenforce in a terminal emulator. If it reports permissive, try changing to enforcing (run the command setenforce 1, as su).

CTS profile matching involves a server side check to see if your device is recognized as a Google certified device. Difficult to spoof... Basic integrity check is done on the device side and is a lower level of security that is a lot easier to mess with.
[Magisk] tamer7:
I've been researching for hours to try to find out when this change in format of am_proc_start happened, as I just mentioned on the github issue, as to have checks for backwards compatibility. I still cannot find any record of when this change happened, or even any documentation on this new format.

Both lsskernel 3.8UX and Phantom Kernel v1.x for 6.0.1 Touchwiz roms use this new format, probably since both kernels are version 3.4.113, and the latter is based on the former.

I'd love to make a patch to help others and not break things, but I still need time and/or help :)

BTW, my S-PushTan app still FC's and redirects to webpage about root found. :laugh:

All props you mentioned are safe, all safetynet checks pass, RootBeer detects no signs of root, but .. ugh!
[Magisk] Didgeridoohan:
Sounds like you're on top of things. I'd love to help, but alas my programming skills are slim to none... :p

And BTW: bloody stupid app! :D
[Magisk] hachiroku:
hi guys, so i have searched through this forum for possible solutions. My question is in regards to the same as many, the usage with Tasker and root.

per guidance i have proceeded with the steps below.

I have confirmed that Magisk Superuser has added Tasker to the list of super user applications. I actually had to run the shell command within tasker and add the build.prop mod. without the build.prop mod tasker wouldn't let me check the use root box for kill app.

The issue I am seeking guidance is that with all of this complete, tasker doesn't seem to be requesting root to actually kill the app.

I did attempt to remove the build.prop entry and this is what was returned through tasker. With the build.prop line added, no messages are returned nor is Superuser being requested.

01.16.17/E kill app: com.tomtom.gplay.navapp root: true canRoot: false
01.16.17/E killApp: can't root
01.16.17/E result: stop task (error)
01.16.17/E Error: 1
01.16.17/MarcoEdit action finished exeID 1 action no 0 code 18 status: Err next 0

Seems that this is an issue with Tasker itself not detecting specific files which SuperSU would have placed. Not really sure how to proceed here. Any help would be greatly appreciated. Thank you.
[Magisk] Didgeridoohan:
Try using using a Shell command:

su -c am force-stop <process name>

The next update of Tasker will have MagiskSU support.
[Magisk] amar2cool99:
Its already enforcing dude, magisk hide made artificially trusted emulator rom, but i don't know why not in my case.
[Magisk] sblonci65:
Hey guys,I have a big problem,I can't flash anything,when I download with magisk manager unfortunately magisk crashed,My device HTC One m9,Ice 5.0.0,Magisk manager 2.2.7,latest magisk.Thanks in advance.
[Magisk] Artim_96:
Latest manager is 4.2.7, if Magisk manager crashes, just dish through recovery
[Magisk] peanutbutter144:
SafetyNet Check failed even though rooted with MagiskSU and running franko kernel

Can someone please help me with this?

Device: Nexus 6
[Magisk] Didgeridoohan:
What ROM? Does Basic integrity pass? Did you enable Magisk Hide? If you did, did you make sure it started correctly if you've happened to reboot (check the logs and if it didn't, toggle it off and on again). And so on... So many questions, but your post gives so few answers.

You can also start by looking here for some tips:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] BootloopedMillennials:
Basic Integrity is where the phone is viewed as certified or uncertified? Play Store has my device certification status as uncertified but it passes SafetyNet.
[Magisk] Soheil_70:
~~~~~~~~~~~~~~~~~~~~

↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓↓

does magisk work on 7.1.2

↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑↑

~~~~~~~~~~~~~~~~~~~~
[Magisk] Karls0:
11.6 Update

I have a question about v11.6. I'm on 11.1 now, and I have doubts whether or not update it. Here I've read lot of reports about problems with this version. What do you think? It is safe to install or better stay with v11.1 and wait for next release?
[Magisk] Jaime albino:
Thanks for your answer, so i'll continue with what i have :) , and i think that i'll need to buy a new smartphone soon if i want to use magisk and similar solutions , i hope that i can get a Mi Mix :fingers-crossed:
[Magisk] SDMU:
Update it , there were problems in 11.5 .

11.6 is supposed to fix the 11.5 problems.
[Magisk] yochananmarqos:
An easier way is to install the phh superuser app and freeze it with Titanium Backup. That way you can check the Use Root box and don't have to edit your Run Shell actions.
[Magisk] Captain_Throwback:
Just wait if v11.1 is working for you.
[Magisk] bigknowz:
How I upgraded:

Flash ROM boot image

Flash magisk 11.6 zip

Flash kernel

Profit

Hope that helps.
[Magisk] jhedfors:
Still issues with 11.6 for some people...

Agreed.
[Magisk] misfiremind:
This is probably a silly question but I haven't been able to find an answer anyplace yet. My Nougat is acting squirrelly so I'd like to do a factory wipe and reset. Will I lose root and need to TWRP flash Magisk again or will I maintain root and just need to reinstall Magisk Manager when I'm setting my phone back up? Sorry if this has already been answered.
[Magisk] yochananmarqos:
Magisk is installed in /data, so you'll lose Magisk completely including modules.
[Magisk] biggdevon:
Yes, I'm one of the many Samsung users but as of late I'm strongly considering getting a Nexus. My N920T is a solid device but these inconsistencies can be maddening. So are there any changes I can make to your zip to make it compatible?
[Magisk] jhedfors:
Not an expert on this - just a tinkerer...

As I understand, those commented-out lines were supposed to bring more compatibility to Samsung devices - but were causing issues with non-Samsung devices. The other change was just about the selinux status showing incorrectly.

If the only issue with 11.6 for you was the selinux status, you could just make that one change to the enable file (un-commenting-out those lines, and keeping the selinux change).
[Magisk] Karls0:
Ok, so I will not hurry with this updates ;).
[Magisk] peanutbutter144:
I am using Lineage OS, I enabled Magisk Hide and I don't know what basic integrity is
[Magisk] wordlessecho:
Redmi 1STD, install failed, can not auto deleted boot partition.
[Magisk] MaurixMystic:
I had supersu 2.79, then delete it .. next step installed magisk flash zip 11.6 and app manager with the playstore app, but the root (magisk su) does not activate me.

Installation in twrp is correct

any solution?
[Magisk] metrize:
When will magisk be fixed so it stops losing root and we can install modules without it losing root?
[Magisk] westeight:
Works fine for most people. Me included.

If and when JohnWu has the time, Magisk will be updated.
[Magisk] Artim_96:
At least with busybox disabled, yes. Otherwise root disappears somewhen between a few minutes and a few days
[Magisk] westeight:
Installed on a brand new HTC U Ultra last week. Busybox enabled. Haven't lost root once...
[Magisk] Artim_96:
Lucky you. Ever since v11 I can't keep root for more than a few days with it enabled, even running an AOSP ROM
[Magisk] westeight:
No problems on my other phone either (HTC 10). Let's be fair to JohnWu: there are obviously going to be some compatibility issues given the multitude of phone / ROM combinations.
[Magisk] joshiameya:
The magisk keeps losing root capability after a while, tried reflashing, restarting the app, it doesnt work.

How can I get the logs, any help /guidance will be great
[Magisk] tag68:
No, enough is enough. He should have done better! [MENTION=5578634]metrize[/MENTION], please reduce your monthly salary payments to topjohnwu to the amount of 2500 Dollar until the issues are fixed! Completely!
[Magisk] topjohnwu:
Just got some idea why things are broken on Samsung devices.

Fixes shall be done soon. Also, some small but really neat changes would come along

On the sideways though: Google dropped Nexus 9 support, which leaves me lagging behind the cutting edge of Android.

I would buy a cheap Nexus 5x, just to fill up the blank until the Pixel 2 is out. At least that is the plan for now :)
[Magisk] jhedfors:
LOL :laugh:
[Magisk] oakley470:
You are one of the few so don't go acting like everyone else is the one with the problem. This is a very widespread problem across many devices, I guess you can chalk this up to the first time your pos device has it better than others ??
[Magisk] Thet619:
I am also having problems running Magisk 11.6 properly on a Samsung device (SM-T715). I wiped System, Data, Dalvik and Cache before flashing latest Stock ROM (6.0.1). I then installed TWRP, afterwards flashed Magisk 11.6. After reboot I installed the latest Magisk Manager but unfortunately Magisk Hide does not show up in the menu. It says "Rooted but no root permission, not allowed?" Is this a common problem or somebody has any suggestions?

With Magisk 11.1 device was properly rooted (unfortunately MagiskSU did not work with 11.1, this is why I wanted to try 11.6).
[Magisk] RagingHarry:
Got no problems at all o my SM-T819 @ stock rom.
[Magisk] Thet619:
Could you let me know your installation routine? T819 is also 2016 version which comes with Snapdragon CPU (I am using 2015 version with Exynos CPU).
[Magisk] westeight:
Oh look, another entitled idiot who thinks he has a right to have a functional Magisk.

Newsflash, simpleton: if Magisk doesn't work for your $100 imported Chinese lamerphone you have two choices: develop your own rooting solution, buy a decent device or... even easier... stfu... :cowboy:
[Magisk] Nomelas:
Try to Disable either busybox or masgiskhide they interfere on some devices/Roms. Having both enabled causes me to lose root.
[Magisk] Captain_Throwback:
Then buy [MENTION=4470081]topjohnwu[/MENTION] all of the devices with issues so he can test first hand and actually fix them. It's VERY hard to find competent remote testers - unless you're saying you are one and are volunteering?
[Magisk] RagingHarry:
Flashed the twrp.tar, flashed magisk 11.1, and updated yesterday to 11.6 and that's it.

Just got this tablet for 1 week.
[Magisk] Thet619:
Really strange. I used essentially the same procedure. But in my case, MagiskHide doesnt even show up in the menu...
[Magisk] pietrucci:
+1 on not working 11.6 on Samsung S6E+ Nougat. Version 11.1 works though. OP seems to have an idea of the cause, see few posts back...
[Magisk] tamer7:
Re: S-PushTAN

I think v1.0.12 of the app (the latest of date) is super paranoid and detects root even when there's no root and phone passing all safetynet checks, other banking apps, android pay, etc.

So, I uninstalled S-PushTAN 1.0.12, then downloaded and installed v1.0.9 from here

Finally, made sure S-PushTAN is ticked in MagiskHide list, and it all works :victory:

Edit: Also tested v1.0.11 (download here) and it works.
[Magisk] oakley470:
Nope actually you took that incorrectly, I was simply telling the other fella that just because he has no issue does not mean there isn't actually an issue, nowhere in there did I complain about the fact there are issues with it. Of course there will be otherwise we'd all have iPhones!

---------- Post added at 10:59 PM ---------- Previous post was at 10:58 PM ----------

Lol oo someone got their panties in a bunch. I have no issues, and my device is plenty capable and functional, in fact I do believe I insulted you for buying the not-decent device. Don't worry though, you're a pretty cool cat in my book
[Magisk] Finchy11:
Did someone managed to use xposed and still pass safetynet?

Wysłane z mojego SM-N930F przy użyciu Tapatalka
[Magisk] Artim_96:
Of course not, that's impossible.
[Magisk] str8str:
On n6 here and aicp I'm experiencing the same loose root issue. Something's a reboot will fix it but it's definitely tied to busy box being enabled. If I disable it root will stay. Haven't tried the disabling magisk hide. Trying that next as I'd rather have my busy box I have apps that use it.

---------- Post added at 12:49 AM ---------- Previous post was at 12:05 AM ----------

Nothing is impossible

I posted everything I could here except logs as you can post em without root when this happens and they are no good after. I don't believe aicp is lineage.
[Magisk] ben999_:
aaron, see this post for a magic module I've just created to achieve this task. Tested on my MotoX XT1575. http://xdaforums.com/showpost.php?p=68402931&postcount=52