yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Assuming you have A-only legacy SAR (launched 2018, 2019ish w/ A9) device Ramdisk=No is correct... Any (and only these AFAIK) single 'slot' device launched with Android 9 (ie. A only legacy SAR) is a Ramdisk No device, ie OEM didn't supply generic ramdisk in boot partition (although there may be vendor/other ramdisks there), so that indicator is correct since RN7 is single 'slot' and launched with Android 9.

For Xiaomi and some other devices, you don't need Recovery Mode Magisk (Magisk patched to recovery ramdisk) since bootloader invariably supports Ramdisk in boot partition and Magisk will add one to support magiskinit... I put details on this here recently:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-89004095

However Magisk was misidentifying devices / erroneously detecting from 26105... This was fixed with Fix device detection scripts and logic and Always check mounts to detect legacy SAR on bootmode in 26202, but a related Recovery mode user setting retention issue (regression) got missed... The Only issue now is that Recovery Mode reverts to selected which causes the reboot and patching issues if care is not taken to un-check the box whenever using or closing Magisk App on Ramdisk=No devices...

@canyie has already responded to my GitHub issue (see below) and a fix has already been produced but it's not yet merged...

Meanwhile, as the Recovery Mode check box is still reverting to checked (selected) in 26.3, 26301 in these cases, users are often leaving it checked (as they don't know better) and Magisk is then patching ramdisk in /recovery partition when taking Direct Install, and recovery.img in Samsung AP binaries when patching these...

Taking Reboot will also cause many devices to boot via recovery (as it's trying to boot system with magiskinit in recovery ramdisk) where Recovery Mode is left checked...

If you/others here tried updating, you likely have both Magisk-patched boot.img and recovery.img now... You may need to start fresh with restored stock recovery.img or unpatched AP binary (if Samsung) to correct erroneous patching before installing 26202+ (... Unless you have an A-only legacy SAR device like Galaxy S10 that actually does need Magisk in /recovery partition).

You will also need to go to Magisk Install in App and uncheck Recovery Mode whenever using App for patching etc, and particularly before rebooting or closing App until this remaining user selection issue/regression is fixed... GitHub Issue I made for this is here:

App loses Recovery mode user setting for A-only legacy SAR devices

Hope it helps... 🤠 PW
[Magisk] mkcs:
Thanks for the detailed explanation! Leaving options by default is quite common when users are not very sure😂
[Magisk] pndwal:
As I said, proper carrier unlocking won't be affected this way AFAIK... I've wiped and reinstalled full factory fastboot ROMs on several devices that were originally locked to providing carrier... If carrier locked this state always persisted, and if carrier unlocked this state always persisted too... Irrespective of root, mods etc...

However I am aware that there are hacks, 'cracked unlocker' apps and code generators (sometimes a universal code can unlock a certain model which shouldn't work either) for carrier unlocking or lock bypassing, and it's impossible to know whether each of these modifications will persist with changes to a system setup... Ie. I suspect that your device was never properly carrier unlocked...

I suggest you determine original carrier if you haven't already and investigate cost of official unlocking which generally involves entering a code obtained from the supplier... Some may give you this over the phone... Some will never allow unlocking, some will change a fee and some will waive the fee after a period of so many months under their contract but may require a valid reason to give you such a code...

In my experience (with Three and Vodafone), after 6 months on a carrier locked device reps would happily give the code if I simply informed them I was going to travel overseas and wanted to be able to use different carrier services while abroad...

🤠 PW
[Magisk] pndwal:
Yeah... In short it shouldn't happen however...

It's part of a larger regression (already fixed) that's also fixed but still awaiting merging and release... I have confirmed that for our unusual (even for Type III devices here: https://topjohnwu.github.io/Magisk/boot.html#piecing-things-together ) devices the CI build fix from this action run: Fix $RECOVERYMODE from config being incorrectly overridden works well... PW
[Magisk] zgfg:
Phone model from 4-5 years ago, Magisk showing Randisk NO?

If so - it has been described, how, why, what to do

Every time you open Magisk app, open Install (Magisk), untick Recovery option.

Then, when you take Reboot from Magisk v26.3, it will reboot to System, not Recovery
[Magisk] J.Michael:
What T-Mobile SIM card? Was the original SIM card that you reported wasn't working a T-Mobile SIM card? Do you now have two SIM cards?

What is "HiddenMenu" and why do we care what it says?

As @pndwal keeps telling you, "updating Magisk and/or modules" is almost certainly *not* the cause of your problems. You told us that your SIM card functions were working after you had installed Magisk. You said that they suddenly stopped working. You *never* said that you updated Magisk or modules on the Saturday on which things suddenly stopped working.

You have tried every random thing you can think of other than what you were advised to do. Now, call somebody associated with the people from whom you bought the phone. Get them to admit that the phone was carrier locked. Get them to tell you the circumstances under which they will help you unlock the phone. Stop deciding for yourself what they know and what they will tell you and actually try talking to them.
[Magisk] zgfg:
Did you Factory reset or just dirty flash ROM?

In the first case, there is no guarantee that a particular ROM installation resets any of the previous settings you had. Therefore, your previous dara, settings, incl that carrier lock persists
[Magisk] GreenDotBlue:
Magisk is not actively developed anymore, it's becoming abandonware. Switch to Magisk Delta.
[Magisk] WhoIsJohnGalt1979:
lol thats a loaded statement to make especially after you being in XDA for less than a week. I hope you didn't post it to increase your post count haha.
[Magisk] GreenDotBlue:
No, of course not. But Magisk Delta is now where the active development is going on. Regular Magisk is coming buggy. It increasingly has compatibility issues with some root apps. And fork like Magisk Alpha is closed source.
[Magisk] zgfg:
About various configurations regarding the Recoveries (on Xiaomi phones/Snapdragon chipsets, but applying also generally). Showing also why developing TWRP (OrangeFox and other custom ROMs) slowed down and why there are so many half-baked unofficial custom recoveries ported to particular phones. And why is generally recommended to install Magisk by patching and flashing (independently of custom recoveries) - take additionally into account the corresponding differences regarding to Boot/Ramdisk

Installing a Custom Recovery

All custom recoveries come in the format of an IMG file (some are released as a flashable ZIP, like OrangeFox, but there's still an IMG inside). However, installation method will differ, depending on where the recovery ramdisk resides on your device specifically. Failing to install the custom...

xiaomi.eu
[Magisk] TheSamOfTheDay:
Im not sure tbh but I had my computer connected to my phone through a USB cable while the assistant was downloading the ROM and then it flashed the ROM into my phone, everything was reset.
[Magisk] TheSamOfTheDay:
I thought you were the person that told me to flash the stock ROM and I did exactly that. Now as soon as that didn't work, I realized that this is something else. Plus that phone I bought off Amazon they won't give a rats ass what I do with the phone, wasn't even warrantied anyway.
[Magisk] pndwal:
This is certainly not true... Magisk gets consistent PRs and actions to test and commit by numerous Devs incl. prolific contributors from the LSP camp and others incl countless translation helpers...

The Delta Dev @huskydg does what he can between Uni studies... Delta is a personal fork maintained by one guy who often can't devote the time others want due to real life (😃) so development and updates actually have often lagged behind...

There always have been issues and fixes...

For the sake of clarity, Alpha, Delta, Metagisk and other active forks build a few alternative commits on base official Magisk, and all 3 named above endeavour to remain in sync with official master branch, ie they build all the updated commits in TJW Magisk and then some...

TJW Magisk has been undergoing radical refactoring for some time now to improve device compatibility as well as module functionality (eg improved overlay/mask mounting ability) etc with a focus on moving code from C++ etc to rustlang... Please see recent changes here:

https://topjohnwu.github.io/Magisk/changes.html

and also see commits and PRs in the pipeline accessible from Magisk main page...

The Devs for all the forks above and more know that maintaining their own master branches without syncing with latest official would leave their builds incompatible with many devices, behind the 8 ball in terms of functionality, and at risk of becoming irrelevant... Official Magisk development is as active now as its ever been which is why it keeps up so well with Google's boot changes/shenanigans, now largely due to Treble, Mainline, GKI etc... Makes me a bit sorry for Dee's Troy and team...

FWIW, seems Lygisk may not be keeping up so well now, but it may be that addon.d fixes in official Magisk have made it superfluous(?)

🤠 PW
[Magisk] J.Michael:
Do you make any effort to read what I write, and answer my questions?

You have not answered any of my three questions about SIM cards.

I don't care who you actually bought the phone from (although he is probably the only person who can answer questions about how the phone was unlocked). The phone is a product, the Lenovo Recovery Assistant goes somewhere (we hope to an official Motorola source) to find ROMs. I want you to talk to someone in the Motorola supply chain to get an official statement about whether the phone was ever "locked" and, if so, whether there is an official path to unlocking.
[Magisk] rodken:
Kind of reminds me if 'Big Red' will ever consider going down that road of charging a nominal fee for unlocking a bootloader which leaves me to only believe in wishful thinking.
[Magisk] TheSamOfTheDay:
All the SIM cards I have dont work, my old phone doesnt work with T-Mobile SIM cards anymore it seems. Also, I tried numerous websites to get the IMEI number checked but like I said, its all behind paywalls, and maybe if there was a way to find out how to unrestrict carriers on my phone when it was already rooted through ADB or something, I wouldn't be here asking for help.

I dont know how many questions you need to ask either, it seems like thats all you've been doing. I literally just said multiple times that my SIM card doesn't work, my phone is carrier locked, and I just want to figure out how to get my SIM cards to work again but also figure out why this happened because it's deterring me from ever wanting to root a phone again.
[Magisk] SebaS-DG:
so many things haha

Man this shell box app is getting me crazy
[Magisk] J.Michael:
Instead of dropping hints and waiting to see if I can figure it out, how about you come right out and say:

My original SIM card was T-Mobile

My phone originally worked with a T-Mobile SIM card

My SIM card is still T-Mobile

My phone no longer works with a T-Mobile SIM card

The store where I went to check my SIM card was a T-Mobile store

I have no idea what carrier is supposed to work on my phone

You talk about wanting to get your phone "unlocked". I keep saying you do not know that your phone is locked. I keep saying you should talk to someone in the phone's supply chain to find out if the phone was ever locked. You say you tried numerous web sites "to get the IMEI number checked" -- what does that have to do with "locked"?

You should be able to contact Motorola and ask if the phone was ever locked. They would also be a good place to start to ask how to unlock it.

YOU DO NOT *KNOW* THAT YOUR PHONE IS LOCKED.
[Magisk] TheSamOfTheDay:
I'm positive that it is "locked" or whatever you want to call it because theres no other reason why my SIM card stopped working on it if the SIM card isn't the problem itself. I've looked up the "Invalid SIM card" error a million times and they all suggested multiple options like factory resetting my phone or just clearing SIM Toolkit storage for example.

I mean, thats why Im here to get advice after all, to figure out what the hell happened to my phone. I guess it is my last resort to try and contact Motorola themselves to see whats wrong with my 2021 Stylus. If I get an unfavorable response, off to the pawn shop it goes.
[Magisk] zgfg:
Related to Momo reporting:

Restrictions to Non SDK Interfaces not working

Restrictions on non-SDK interfaces | Platform | Android Developers

developer.android.com

See also the screenshots attached

Btw, Momo usually reports this detection for Xiaomi.eu ROMs. It seems that enforcing to the Restrictions gets verified by CTS, hence this detection should not be an issues on the certified, stock MIUI Roms but specific to the custom Xiaomi.eu ROMs
[Magisk] m0han:
Like to know more about what is meant by '.... specific to the custom Xiaomi.eu ROMs'. This 'Restrictions to Non SDK Interfaces not working' is reported on my earlier device running AICP 12.1 ROM too. Is there any way to avoid those detections?
[Magisk] zgfg:
By specific to Xiaomi.eu (and not general to Xiaomi/MIUI) I meant (but cannot test since I don't have) that detection should not show on the official/stock Xiaomi ROMs

The reason: by the document, enforcing of the Restrictions (that apps cannot use undocumented/deprecated and particularly blacklisted SDK Interfaces) appears to be part of CTS testing - hence the official stock would not pass CTS (but it does/has to)

On the other side, Xiaomi.eu is custom ROM (and depending on the phone and Xiaomi.eu version) they may or not pass CTS - thus the need to root and use PIF/SNF modules to spoof (to downgrade from Strong/Hardware backed to Basic CTS testing and spoofing it's results)

The same could also apply to other platforms and custom ROMs. Seems it's part of the way how the ROM is configured (and devs probably allow it bcs they need for some of their apps to use those additional, not publicity documented/whitelisted SDK Interfaces)

But Momo does not test (spoofed) CTS. In my understanding, it tests directly (by trying to call itself?) could the apps use blacklisted SDK Interfaces ('Non SDK Interfaces'). Hence I don't see how could you spoof to Momo (and others who may test similarly - but hopefully not). But IDK, maybe it could be spoofed by the Zygisk or LSPosed techniques (I don't know of such a module?)
[Magisk] EthanG01:
Hey everyone,

I'm new to all of this and could use some guidance. I'm wanting to know how to get the Halifax banking app to work on the Moto X40 using the Displax Universal Safety Net method through Magisk. I am currently waiting for the device to be delivered as I've ordered it, but in the meantime, I'm doing some research to understand the whole rooting process and the tools used, etc.

Could someone walk me through the process? Also, do I need to add Google Play services and Google Wallet to the enforce denylist and clear the cache for both of them for it to work afterward?

I'd really appreciate any help. Thanks in advance!
[Magisk] m0han:
This probably explains it. (y)
[Magisk] Kelden:
I've updated my OnePlus 10 Pro with the newest September patch and somehow I lost root access in Magisk.

I had still root in Total Commander so I was looking for the config and somehow I messed up with magisk.db

Now I don't have root anymore in Total Commander. How can I reset and delete magisk.db now?
[Magisk] zgfg:
You could but with TWRP.

Otherwise only by wiping Data

I don't understand what were you doing - you probably had a hidden/repackaged old Magisk app (common issue, tons of similar posts here) and you simply needed to delete that old app and reboot

Now, you will need to root your phone once again from scratch

But yeah, also find that old 'hidden'/renamed/repackaged Magisk app before going over, otherwise you will again have the same problem

So, when hiding Magisk app from itself, one has to remember what new name was it given and how/where to find it that he can uninstall it before future updates of Magisk.

Or better use HMA, it hides better and and there are no troubles when updating/reinstalling Magisk

Those troubles with the old/hidden Magisk app is present for long, it was 'fixed' but never really (for everybody), hence don't count that it would ever be and rather do manually as above😁
[Magisk] Kelden:
After leaving my phone running for 24 hours, somehow I got root access back by Total Command and could delete the broken magisk.db. Everything is working again.
[Magisk] zgfg:
For the record - I suddenly realized that I was running without root (PS: and with WLAN disabled?!)

I rebooted and root and everything was all ok again. I think (I was astonished and didn't believe then, thinking that maybe I did something wrong) that it happened to me also a couple of weeks ago (Canary v26301, several modules I usually use - don't know whom to blame)

Seems nothing (terrible) happened when I was 'naked' - device is still certified, detached and debloated apps did not update, etc
[Magisk] trieuanh21:
Anyone help me create 1 module magisk replace this file .kl into system/keylayout.

I can not understand english guild magisk.

My phone is rooted.

my file:

retrogame_joypad.kl | Powered by Box

app.box.com
[Magisk] J.Michael:
Put a copy of the file at "/data/adb/modules/pick-a-name/system/keylayout/retrogame_joypad.kl"

Read the Module Designer's Guide. I think it is important that you set the owner, group, and permissions of each directory (and the final file) to match what is already on your system.
[Magisk] zgfg:
I can't find any file with that name on my phone - screenshot

There are keylayout files, like qwerty.kl in the folder:

/system/usr/keylayout

but none of them matches your name:

Spoiler content hidden.

Find that file on your phone - do you have it as:

/system/usr/keylayout/retrogame_joypad.kl
[Magisk] trieuanh21:
Meaning i have copy file retrogame_joypad.kl to folder data/adb/modules/pick-a-name/system/keylayout/ buy root eplorer?

Copy done and i have to do what next? :cry:
[Magisk] trieuanh21:
I have that file retrogame_joypad.kl in folder keylayout. But it config wrong L1 R1 L2 R2 bution when conect gamepad, i edit it to right and can not copy back that folder.

I google: "it just do it by make a module magisk can replace 1 sysyem file." :cry:
[Magisk] zgfg:
First, test would it work

Do you have (Magisk already properly installed and) Systemless hosts enabled?

If not enabled, open Magisk app, Settings, scroll down and tap to Systemless hosts option

After reboot you shall have a folder (use root explorer like MiXPlorer, or TWRP if you have, or Terminal emulator/ADB and shell commands - whatever you're familiar with):

/data/adb/modules/hosts/system

There, you'll have a subfolder named etc with the file named hosts - eg, AdAway writes into that file and Magisk then mounts it over the /system/etc/hosts

So, you will try the same mechanism

In parallel to that etc subfolder (not inside the etc subfolder) create subfolder (exact letters, case sensitive!):

usr

And then inside that usr, create another subfolder - see the screenshots:

keylayout

Copy your retrogame_joypad.kl into the keylayout subfolder to have:

/data/adb/modules/hosts/system/usr/keylayout/retrogame_joypad.kl

and reboot

---

Before rebooting check eg the size (or md5 hash) of your original:

/system/usr/keylayout/retrogame_joypad.kl

After reboot, when Magisk mounts it there, size (hash) must match the size (hash) of your replacement

/data/adb/modules/hosts/system/usr/keylayout/retrogame_joypad.kl

PS: Actually, .kl are text files, just open them and inspect
[Magisk] trieuanh21:
Thank you verymuch, it work. You save my 3 day life! :love::love::love:
[Magisk] vandyman:
With the new Pixel 8 out now with android 14.

Is there anything different that needs to be done besides patching the boot. img?

The reason I am asking is.

After using fastboot flash boot magisk_patching. img. It flashes but still no root.

Odd, I am coming from a Pixel 6.

If I remember right. This would happen if you install the full factory update without removing the magisk modules.

But this is a fresh magisk install.
[Magisk] badabing2003:
you patch init_boot not boot, and you flash init_boot not boot
[Magisk] vandyman:
Neitherr works.

boot. img flashes and boots the os with no root.

init_boot. img flashes and errors to the bootloader. And I needed to do a flash-all (without the - w) to get things going again.

Maybe I need to flash both slots with the factory image before trting to root??
[Magisk] sawdoctor:
Have you tried using pixelflasher? I think it's been updated for the pixel 8 and will simplify the process
[Magisk] vandyman:
Yep, no go.
[Magisk] Lughnasadh:
I would suggest you go over to the Pixel Flasher thread and provide badabing with a support.zip so he can look at it.
[Magisk] vandyman:
YEAH! Inow have root. Flashing both slots worked. Here is what I did using Pixelflasher.

First, the active slot was b. And no matter what I tried I could now get root.

Using Pixelflasher:

Flashed both slots with the full factory image without wipe.

I let the os boot up to make sure all was good.

Next, Pixelflasher showed the active slot now was a.

I than flashed the patched image.

So I guess slot b must be corrupted somehow.

I believe something may have happened when I unlocked the bootloader. The system must have did something to slot b. Who knows...
[Magisk] sawdoctor:
I had a very similar experience with the pixel fold. No matter what i did i couldn't get root think i ended up flashing both slots. On a positive note I've flashed several OTA with pixelflasher since (Obviously changed slot) and always managed to keep root
[Magisk] prisillain:
Hi, i have a rooted Samsung A34 device already. I want to add apk file to /system/priv-app and i cant chmod or mount /system folder. i have installed overlayfs but dont know how to use. pls pls guide and i am stuck here
[Magisk] Uluru25:
Upgrading fom v25.2 to v26.x?

I am wondering if there are (good) reasons to upgrade my running magisk. I own a Redmi Note 8T (willow) which was sold with A9 but is meanwhile running A11 (LOS18.1). Flashing magisk v25.2 was easily possible via the recovery as renamed .zip file. I am using zygisk and LSposed to have AFWall, XPrivacyLua, AdAway, and ACC working, nothing else.

Although I appreciate "never change a running system", I am nevertheless curious and want to increase my knowledge.

Thus, more general than related to my current phone and setup:

1) are there strong needs to upgrade magisk if everything "seems" running?

2) what are the limitations of 25.2 that may have motivated you to upgrade (e. g. compatibility with higher android versions) to 26.x?

3) any other considerations or experiences you like to share with me and others?

Thx!

🤠
[Magisk] zgfg:
I suppose, for your device Magisk app reports Ramdisk NO?

If so, better wait to be fixed, v26.3 has now even more serious troubles with - you should not update Magisk by Direct Install or through TWRP but only by patching the boot.img and then by taking care that you first disable Recovery option before patching (v26.3 thinks that for your device Magisk must be patched/updated/installed from TWRP to Recovery, not to Boot)

Even when you later install some module, pressing to Reboot would reboot you to Recovery (TWRP). To avoid, every time when you open Magisk app, tap first again to Install Magisk and then un-tick Recovery, before going to install some module and then taking Reboot
[Magisk] zulu88:
No, there is no reason to update if everything works.