yashsingh1/xdaforums huggingface dataset:
[Magisk] osm0sis:
:/ # ps -Af | grep -v 'grep' | grep -oE 'root_seclabel=.*' | grep -q 'u:r:su:s0' || { stop adbd; start adbd; }

I've mulled over the above, which could sort of work to guarantee adbd is already running as root, but it is too slow to be adding to each call of adb.

Maybe I could get away with just a blind call to `start adbd` and then ensure the adb command is always run as root. 🤔🤓
[Magisk] osm0sis:
@zgfg can you change the contents of /data/adb/modules/adb-ndk/system/bin/adb to:

#!/system/bin/sh
# adb: wrapper to run adb from terminal
# osm0sis @ xda-developers

dir="$(cd "$(dirname "$0")"; pwd)";

export HOME=/sdcard;
export TMPDIR=/data/local/tmp;
start adbd && $dir/adb.bin "$@";

And see if all still works as expected?
[Magisk] zgfg:
Will try but I'm on the go tomorrow and on Monday back to work, hence after that
[Magisk] shoey63:
@zgfg is busy so I tried it.

Rog3 > Pixel 6

Changes work perfectly 🤓
[Magisk] shoey63:
@osm0sis

I presume trying to sideload a full ota.zip is asking a bit much?
[Magisk] osm0sis:
Yeah can't say I've ever tried that. You might get away with pushing the zip to the device and flashing from there.
[Magisk] zgfg:
OTA is probably a lot. But you can try copying by MTP

I flashed (fastboot patched-boot boot.img) 192 MB with no problem
[Magisk] shoey63:
No different to downloading the ota.zip directly on the P6 and attempting to flash it in stock recovery (no TWRP yet - if ever).

Unfortunately the apply update from sdcard option does not work at all for Pixel 6 series.

Nice scenery @zgfg.

Enjoy what's left of your break👍
[Magisk] ands2:
I try to install Magisk on an Unisoc T618 device.

1. I flash the Stock firmware via SPD tool.

2. Go to fastbootd and flash vbmeta, vendor and boot.img.

3. Reset and Reboot

Magisk is active and I have root support.

But after installing Magisk I have two process causing a high CPU load.

It seems that the android process "com.android.modemnotifier" is crashing in a loop. But only after installing Magisk.

I can't get the connection between Magisk <=> modemnotifier and I wasn't able to solve it.

Can anybody help please?

TOP result:

LOGCAT
[Magisk] pndwal:
Latest Magisk Beta:

Release Notes

2023.8.27 Magisk v26.2​

[MagiskBoot] Support extracting boot image from payload.bin

[MagiskBoot] Support cpio files containing character files

[MagiskBoot] Support listing cpio content

[MagiskBoot] Directly handle AVB 1.0 signing and verification without going through Java implementation

[Daemon] Make daemon socket a fixed path in MAGISKTMP

[resetprop] Support printing property context

[resetprop] Support only printing persistent properties from storage

[resetprop] Properly support setting persistent properties bypassing property_service

[MagiskSU] Support -g and -G options

[MagiskSU] Support switching mount namespace to PID with -t

[MagiskPolicy] Fix patching extended permissions

[MagiskPolicy] Support more syntax for extended permissions

[MagiskPolicy] Support printing out the loaded sepolicy rules

[App] Support patching boot image from ROM zips

[App] Properly preserve boot.img when patching Samsung firmware with init_boot.img

Full Changelog: here​

2023.8.27 Magisk v26.2

The Magic Mask for Android

topjohnwu.github.io

👍 PW
[Magisk] pndwal:
Latest Magisk Canary + Debug builds:

Magisk (e47e869f) (26201)​

Sync with public release

Diffs to v26.2​

N/A

https://github.com/topjohnwu/magisk-files/blob/canary/notes.md

👍 PW
[Magisk] pndwal:
I'm probably missing something, but can you say why you're flashing /vendor and /vbmeta? (Nb. Vbmeta patching is no longer needed for 2SI devices since magiskinit injection refactoring)... Also is standard fastboot available, or only fastboot.d? PW
[Magisk] sawdoctor:
Thanks for the heads up on the updates. So if we are currently running the canary build it's now the same as the latest beta ? Or am i being really stupid and missing something
[Magisk] eXtremeDevil:
I'm getting "found magisk" in Momo out of nowhere, did not changed or update Magisk, momo or Shamiko. Also, one of my bank apps has detected root. I have no TWRP folder.

I did clean file with SD Maid.

How is the magisk detection working, can I hide it again? Thanks!
[Magisk] pndwal:
Essentially the same (synced)... Build channel and nomenclature differ, and while Canary is built with release flags, Debug is produced in parallel with debug flags...

Nb. xxx01 builds are always synced with public release commits... First Canary builds to get ahead are always xxx02... 🙂 PW
[Magisk] ands2:
Without the vbmeta and vendor I'm always stuck in the bootscreen or in a boot loop.

It was the only way to boot it up at least. But then with the high cpu usage.

I think I only have fastboot.d.

Do you see other steps to try?

My steps at the moment:

1. Flash stock firmware and boot

2. Enable USB debugging

3. Reboot to fastboot.d

4. Flash vbmeta, vendor and boot.img

(Magisk 23 and 24 work. 25 and 26 don't boot at all)

5. Hard reset

6. Reboot

7. Magisk installed and working, but 2 processes with high cpu usage:

system_server

zygote64

(logcat: com.android.modemnotifier crashes too many times and restart every second)

Edit:

The stock firmware is only Android 11 by the way.
[Magisk] zgfg:
At the time when new Stable gets released, usually (Beta and) Canary are aligned with Stable

You can see that by checking ChangeLog for Canary - it says "Sync with public release"
[Magisk] pndwal:
Beta and Canary aligned with Delta?... Perhaps you mean Delta (which isn't a TJW build anyway) gets aligned with Canary etc (eventually)?

To be clear, when public Stable or Beta are released, synced Canary (release build but not 'public') and Debug (debug build, also not 'public') builds immediately follow. PW
[Magisk] sawdoctor:
Looks alpha got updated as well, i know it's a completely different project but do they use the new release as a base or just coindence? Been out of the loop for so long trying to get up to speed with everything
[Magisk] zgfg:
Lapsus - aligned with (public release of) STABLE

As ChangeLog for Canary saying "Sync with public release"

And there is not much use of Beta - during the last years, Beta gets released only in sync with Stable. Hence if staying on Beta it practically means staying and updating with the Stable code
[Magisk] pndwal:
They do...

Alpha is now an unofficial LSPosed testing build, ATM building Shana's (@yujincheng08) LSPosed Metagisk/zygisk WIP commits as well as extras from @vvb2060 and others... Of course these are principal official Magisk Devs (see Magisk App main page) and most commits are in official Magisk PRs (pull requests) and Continuous Integration test builds for Metagisk branches are also found in official Magisk Actions tab... PW
[Magisk] pndwal:
🤔... Well, if you want the latest public build you will offen need Beta (Beta channel set) as is currently the case...

Sorry, it gets released only when Stable isn't published...

Well staying on Stable (setting Stable update channel) means staying and updating with the Stable code...

Beta is published when John wants to push a 'public' build but it is still not considered fully stable (there may be new features, refactoring etc that may still need fixes or 'tweaking'), so it really means updating with something less than stable code...

👀 PW
[Magisk] zgfg:
Works excellent, thx

Btw, tested adb push and adb pull for 192 MB files, worked fine (didn't test adb sideload)
[Magisk] n.p.:
I upgraded the Magisk app to 26.2 on a Samsung Galaxy Tab 2, and when I went to update Magisk, the app showed "Installed N/A" (but it does show "Zygisk: Yes"). Magisk appears to work correctly (I have root and get notifications when apps use it), but with a limited menu (only "Home" and "Logs" appear as icons on the bottom of the interface). When I select install, I get "Installation failed. Unable to detect target image." I have never had any problems before upgrading this device (unlike some of my other devices). Any advice on what I should do from here?
[Magisk] Nergal di Cuthah:
Likely you had magisk hidden before upgrade and did not turn it back when you upgraded. It is also likely that you now have two magisks fighting for control. Uninstall the hidden one
[Magisk] n.p.:
No, I have never hidden Magisk on any of my devices.
[Magisk] RelaxDA:
I updated magisk to 26.1 on OnePlus 7 Pro and now i'm getting qualcomm crashdump on boot, is there a reason why and a way to fix? Or should I just stay with 25.2, read that minimal version is Android 6 so I assumed it's safe for my device running OOS11
[Magisk] osm0sis:
Awesome! First module update with my fixed (cursed) laptop is pushed then. 😁
[Magisk] n.p.:
I uninstalled the 26.2 .apk file, and reinstalled 26.1. The app could now showed Magisk as installed again (including "Ramdisk: Yes"). With 26.2, the logs tab showed no logs, but with 26.1 restored (without rebooting the device) I can see the logs again.
[Magisk] amk316:
hi...i can access "Phone Info" menu throw NetMonster app. is there any way to access it directly (throw the phone dialer or shell command)?
[Magisk] vMAC:
Just updated and now my XPrivacyLUA is no longer working. Anyone else have this issue?

2023-08-28T21:27:11.582
2023-08-28T21 :27:12.854
2023-08-28T21:27:12.858 uri content: //some_table/some_property with null where and where args uri content: //some_table with query name=? and single name as arg uri content: //some_table with query name=Some_name and null args but got - uri:content://settings/system, where:pkg = ? AND uid = ? whereArgs: [android, 1000] at com. android.providers.settings.SettingsProvider$Arguments.<init>(SettingsProvider.java:2618) at com, android.providers.settings.SettingsProvider .query(SettingsProvider.java:604) at android . content.ContentProvider.query( ContentProvider.java:1455) at android. content . ContentProvider .query (ContentProvider.java:1551) at android . content .ContentProvider$Transport.query(ContentProvider.java:285 ) at android.content .ContentResolver.query (ContentResolver.java:1219) at android. content.Content Resolver. query (ContentResolver.java:1151) at android . content. ContentResolver .query (ContentResolver.java :1107) at eu. faircode.xlua.XLua.hookPackage(SourceFile:5) at eu.faircode .xlua.XLua.access$000 (SourceFile:1) at eu.faircode .>xlua.XLua$1 .beforeHookedMethod (SourceFile:4) at MgBb.HYMsKh.NSEX.KTZLE.XposedBridge$AdditionalHookInfo.callback(Unknown Source:79) at LSPHooker .svstemReadv(Unknown Source:14)
[Magisk] zgfg:
I see, you added cases for help, version and must be root (fastboot) - frankly, I didn't realize they were missing👍
[Magisk] pndwal:
Please say device and ROM... Especially interested if you have have custom ROM or kernel... PW
[Magisk] J.Michael:
Why do you consider the phone dialer app to be more direct than the NetMonster app?
[Magisk] n.p.:
I said device in an earlier post (Samsung Galaxy Tab 2). It has the last available version (for the device) of LineageOS (13.0-20180211-NIGHTLY-espressowifi).
[Magisk] pndwal:
Re. strange detection of devices as Ramdisk = No (Only A-only legacy SAR, ie. A-only Android 9 launch version, devices should be) etc, a number of fixes for detection issues incl. LEGACYSAR=true/false, vbmeta patching etc are now merged upstream... See:

Fix device detection scripts and logic

topjohnwu committed 7 hours ago

Also:

Disable boot vbmeta patch when found vbmeta.img

and

Do not allow user to configure boot vbmeta patching

... So hopefully this and other strange issues with new Beta build will be fixed with a maintenance update or Stable build soon...

🙂 PW
[Magisk] pndwal:
Ah, suspected this... Seems it's a custom kernel issue... Occurs since refactoring from Magisk 26.0... See this pinned Wontfix issue:

Custom kernel erroneously hides magisk su file

Edit: could also be issue with device detection logic (fix linked in post above) which may relate to (fix) the issue reported below:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-88938575

🙃 PW
[Magisk] pndwal:
This:

Add canyie to developer list

👍 PW
[Magisk] DerivativeOfLog7:
Issue on GitHub: https://github.com/topjohnwu/Magisk/issues/7264#issue-1870517265
[Magisk] m0han:
OT:

Spoiler content hidden.

I'm missing it badly now.
[Magisk] DerivativeOfLog7:
Spoiler content hidden.
[Magisk] osm0sis:
Yep yep! 😁

Add canyie to developer list by canyie · Pull Request #7260 · topjohnwu/Magisk

The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.

github.com
[Magisk] n.p.:
I suspect the latter given that 26.0 and 26.1 worked perfectly (although version numbering often doesn't indicate major changes or new incompatibilities).

Thanks for that. I have subscribed to notifications for that issue.
[Magisk] HippoMan:
Revisiting this earlier topic: I have checked in numerous places over the past couple weeks or so, and it doesn't seem like there are any Xiaomi devices which will provide fully functional 5G coverage with T-Mobile in the U.S. out of the box.

I am not willing to purchase a Qualcomm-based Xiaomi device that only *might* be able to be modded in order to fully conform with the U.S. cellular bands that are offered by T-Mobile.

As I have mentioned above, the reason I have been thinking of Xiaomi in the first place is because it was recommended due to being a relatively straightforward and reliable process to mod such devices and get recent versions of Magisk working under recent Android releases. I don't have time to be spending long periods configuring, reconfiguring, reflashing, etc.

But if I have to mod the Xiaomi firmware just to get the device to *maybe* be fully functional under T-Mobile in the U.S. -- before I even start to mod it for Magisk -- then it isn't worth the effort for me, nor worth the money.

So ... can anyone recommend the *second-best* device(s) which can run a recent Android release AND be relatively easily and reliably rooted via Magisk and otherwise modded in order to hide at least most root apps ... with a low probability of bootloops, wiping, reflashes, confusion, headaches, etc.?

And with such a recommendation, I would also ask for the recommended version of Magisk (standard? alpha? delta? etc.?) which seems to be the easiest to use for rooting and modding that specific recommended device.

Thank you in advance.
[Magisk] zgfg:
FYI - test carefully, existing LSPosed modules could have issues
[Magisk] WhoIsJohnGalt1979:
Any direction as to which ones you have had issues? Just asking. Attached are the ones I have and they are working fine.
[Magisk] vMAC:
As I posted before I am having issues with Xprivacylua
[Magisk] vMAC:
Any pixel device
[Magisk] Legoman6:
Where can I find these URLs for previous versions of Magisk?
[Magisk] WhoIsJohnGalt1979:
Releases · topjohnwu/Magisk

The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.

github.com
[Magisk] Legoman6:
These are previous versions of Magisk. I'm looking for the URLs to set a custom channel pointing to a previous release.
[Magisk] m0han:
Had issues. Resolved with the newest update. Folks interested can check this post: https://xdaforums.com/t/xposed-edge-pro.3525566/post-88941295
[Magisk] pndwal:
... Bravo @canyie! 👏 PW
[Magisk] pndwal:
Go here:

https://github.com/topjohnwu/magisk-files/commits/master

Click a build commit and note version

Go back and find build you want from list (you'll need to narrow it down)...

When you have correct build (version in green text) click Browse files, click correct JSON file, click Raw and copy URL address for that... Nb. You need address for raw JSON file...

👀 PW
[Magisk] pndwal:
Latest Magisk Canary + Debug builds:

Magisk (de00f1d5) (26202)​

[General] Fix device information detection script

Diffs to v26.2​

[General] Fix device information detection script

https://github.com/topjohnwu/magisk-files/blob/bfb230a95f5acb0b2f5a113c8e12f6e7a05c892f/notes.md

👍 PW
[Magisk] pndwal:
... So we have a maintenance Canary build (see post above)... Some Beta users may want to move to Canary for these fixes...

Wanna try Canary?...

👀 PW
[Magisk] V0latyle:
So 26.2 natively supports OTA patching? How does that work?
[Magisk] pndwal:
Please say where you saw that... 👍 PW
[Magisk] V0latyle:
Previously, we had to use Payload Dumper or similar to extract the contents of an OTA to then manually patch the boot or init_boot image
[Magisk] pndwal:
If I'm not wrong, I think MagiskBoot tool still only supports extracting boot image from payload.bin of full OTA/ROM... This was added from 26102...

I don't think it means 'natively supports OTA patching', at least not as far as extracting a boot image from a stock delta (differential/incremental) Over The Air update is concerned...

@osm0sis built a fix for this so may clarify usage further... 🙂 PW
[Magisk] shoey63:
Pretty sure it means exactly that.

Just tried it on a Pixel 6 payload.bin on my Rog 3.

Patched it in seconds.

Edit: Used Alpha 26201
[Magisk] pndwal:
Sorry, please say procedure... Guessing you used a full OTA/ROM?... Or do you mean it somehow works on standard delta (true Over The Air) updates?... PW
[Magisk] V0latyle:
Pardon the ignorance, I'm not clear on what the difference is?

Previously, we only had "patch to inactive slot" on A/B devices; does this mean that Magisk will only perform the function of Payload Dumper by extracting the boot image, or that it will also patch and repack or flash that patched image to the updated slot?

Or am I confusing two different things, and this feature is only meant for A only devices (extract, patch, repack boot image)?

The Magisk documentation has not been updated to explain how to use this and what it does.

Educated guess: it is the former. A/B devices can be patched post OTA by patching "inactive" updated slot. A only devices (Samsung etc) cannot be patched in this way as update is installed in recovery, so boot image must either be patched and installed with OTA, or flashed post OTA. Incidentailly it still seems like this would work on OTA updates for A/B devices as well as a "universal" OTA patch method
[Magisk] shoey63:
I used Install > Select and Patch a File and pointed to an extracted payload.bin.

Profit.

Then for good measure I tried It on the full OTA.zip.

Profit.😁
[Magisk] zgfg:
Yeah, that makes easier, user does not need to use Payload Dumper to extract eg 192 MB boot.img from 9 GB payload.bin

Just unzip the OTA and copy out payload.bin - that can be done on the phone with eg MiXPlorer (while dumping payload bin in practice requires the PC)
[Magisk] shoey63:
It circumvents the need for the use of a payload dumper to extract the boot image by performing that function itself, and then immediately executing the patch operation, and then placing the patched boot.img in /sdcard/Download.

Install to Inactive Slot (After OTA) function remains the same.
[Magisk] V0latyle:
Oh okay so this provides no benefit to A only devices. Why was this implemented? Problems with the direct patch? The way I see it the end result is the same, regardless of which way the process is done:

Direct patch: OTA is downloaded, unpacked, and installed to inactive slot. Magisk is then used to directly patch inactive /boot and commands a reboot to that slot.

Indirect patch: OTA is downloaded, unpacked, Magisk extracts boot.img from payload.bin, OTA is installed to inactive slot then...what? Magisk directly writes patched boot image to inactive /boot?
[Magisk] shoey63:
It even extracts the payload.bin from the raw OTA.zip for you. Just point to it and Magisk works it Magic😎
[Magisk] pndwal:
That's what I understand it to mean... Can patch in-app now... No need for third party dumper...

I think it isn't yet capable of building a complete boot image by combining active slot image with incremental (delta) data... I believe I read that Devs hope to make it work for delta OTAs in future...

So it's really for any full ROM payload.bin rather than delta OTA files...

Yes, IINM, two different things... Not for Magisk survival (preservation) thru OTA update using 'install to inactive slot' method, which is still fraught/partly broken...

But it can still be used for both A-only devices (if any happen to use payload.bin files) and A/B devices to patch/flash current slot...

Yeah... But seems you just point to .bin file from 'Select and patch a file' just as you would an .img or .tar file... PW
[Magisk] shoey63:
Install to Inactive Slot (After OTA) is broken on some devices. (Hasn't worked on Pixel 6 for quite a while)

This way you can patch the new boot image and fastboot it later after taking the OTA or sideloading it.
[Magisk] zgfg:
Why no benefit - the benefits were explained above

A only or A/B device, you can have stock or custom ROM that provides boot.img inside payload.bin in the OTA zip

As @shoey63 explained how he made, he did not extract boot.img from payload.bin, he even did not extract payload.bin from OTA zip - he provided the whole OTA.zip for 'patching'

Hence it perfectly helps for devices with custom recoveries, and for custom ROMs where you usually download the 'OTA' zip package directly on the phone (or the built-in Updater does it for you)
[Magisk] Arcline:
Can confirm the latest canary fixes the ramdisk issue.
[Magisk] zgfg:
At the moment I didn't have OTA zip with payload.bin but more classical OTA.zip with boot.img directly inside

So I pointed to the whole OTA zip, 4.5 GB file and Magisk patched - screenshot shows:

- processing zip file

- extracting boot IMG

- ...

As a result I have magisk_patched.. boot IMG 192 MB file in Download folder
[Magisk] V0latyle:
I'm still wondering what the point of this is, because unless Magisk repacks the patched boot image, you'd be left without root after applying the OTA and rebooting, so you'd need external means to flash the patched boot image, unless you have a custom recovery.
[Magisk] zgfg:
Yeah, it would be even better to automatically repack, but that would consume a time and memory

As I tested with the OTA zip containing boot.img (not further archived in the payload bin), this new/additional step processing zip file took couple of seconds
[Magisk] J.Michael:
How do you "apply the OTA"?

Can't you flash the patched boot image immediately after applying the OTA, before rebooting?
[Magisk] V0latyle:
Sure but then what's the difference between that and patching the image in place? It still would only benefit A/B devices. A only devices would require the image to be repacked, but I suspect the OTA would fail w/o custom recovery due to signature verification, and if you're at the point where you're using a custom recovery, you'd just install OTA via that and reinstall Magisk immediately after before rebooting to system
[Magisk] zgfg:
I usually do it (with Xiaomi.eu custom ROM, hence through TWRP):

-I flash OTA zip

-I flashed its prepared patched boot IMG

Then I reboot to System
[Magisk] zgfg:
And the following screenshot shows:

- processing zip file

- processing payload.bin

- extract boot.img

- etc

Hence here I pointed to the downloaded official Xiaomi OTA zip, containing the payload bin (that further contains all images)