yashsingh1/xdaforums huggingface dataset:
[Magisk] victoryo:
I cant get it working with Safety net passing :(

My device is a Xiaomi Mi5.

Did exactly as suscribed but still NO luck.

Installed a clean rom without root.

Installed the magisk V10.2 zip and manager.

IT detected NO root and installed phh superuser.

After boot manager shows all green and correctly installed.

So went to settings, enabled magisk hide and rebooted.

After reboot manager indeed showed the magisk hide enabled so I tried to pass safety net.

But nope.... Still red....

Here is the magisk log
[Magisk] spida_singh:
Do you need to reboot each time you add an application to magisk hide

I already had magisk hide enabled and working.

Just not SN

Only after checking the play store app and gms in the hid menu is when this started working

---------- Post added at 05:41 PM ---------- Previous post was at 05:39 PM ----------

I was in the exact same position as you.

Just try this, it may or may not work

In the magisk hide menu check / tick gms and playstore

Reboot and retest safety net

If all ok, remove them reboot and re test safety net
[Magisk] victoryo:
Yea. It must be the problem. Because in the magisk log I see com.google.gsm.unstable as if it is checked.... But cant find it in the applications and dont know what IT is :(
[Magisk] Didgeridoohan:
No. The only reboot needed is after Magisk Hide has been enabled the first time.

That's Magisk Hide doing it's thing to hide Magisk and root from Safety Net. It's enabled by default, so the only thing that should be needed to pass SN is to enable Magisk Hide.

Of course, there are other things that break SN: https://xdaforums.com/showpost.php?p=70426733
[Magisk] Filip013:
[MENTION=1644742]victoryo[/MENTION]

First I have to say that I currently don't use Magisk but I tried Magisk v10.2 on my Redmi Note 3 Pro running MIUI as did other users of my device. I think there's a problem with MIUI and Magisk Hide. I think that some users reported that Magisk v9 passes SafetyNet but not v10.

Another important thing, I could never get my phone or even a Redmi 1S to get a green CTS result, even though it passes SafetyNet. Download SafetyNet Helper from Google Play and see what result you get. If it passes SafetyNet, it will be green or red (for me it's always red), if it fails it will be blue.

You could then uninstall Magisk v10.2 and try v9 and report what you find.

Edit: Yup! I tested it once again just to make sure. Flashed Xposed uninstaller, suhide-rm (pre-November patch ROM), Magisk uninstaller (I use it to remove SuperSU), Magisk v9 and phh r2. Then rebooted, installed Magisk app from Play Store, enabled Magisk Hide and rebooted. Success! SafetyNet pass (red as always). Then updated to Magisk v10 from the app. SafetyNet fail (blue).

I guess I should file a bug report. (With Magisk log and boot.img extracted from the ROM’s .zip file, right?)

Also, [MENTION=4470081]topjohnwu[/MENTION] if you're reading this, maybe update Magisk Manager to provide more SafetyNet info than just CTS profile mismatch because I get that anyway even when I pass SafetyNet.
[Magisk] felipe.vella:
There is Axon 7 compatibility?
[Magisk] MBariya:
anyone tried New system.prop feature??

it is not working for me.

Module shows active but no folder created in /magisk. Even not showing in log file.
[Magisk] zerosource:
thank you magisk. your su hide works flawlessly.

7.1.1
[Magisk] Captain_Throwback:
You enabled PROPFILE in config.sh? And you created a system.prop in standard prop file format?
[Magisk] MBariya:
Sorry. My mistake. My zip file was currupt.

Working ok.
[Magisk] Didgeridoohan:
Probably not at the moment... Source: https://github.com/topjohnwu/Magisk/issues/43

You could give it a try and report your findings in the same issue.

And there's no need to cross post, it just creates confusion and makes the answers difficult to track. One place is enough...
[Magisk] ABotelho23:
Brilliant that it roots during installation. Saves me time when installing new ROMs. And then with Xposed being in-app install, you've streamlined the process so well!
[Magisk] JohnCorleone:
Did you reboot after enabling the Magisk hide?
[Magisk] mGforCe:
Yes, did same couple of times.. but didn't work for me :(
[Magisk] Ssbroly:
Salut ! J'ai installer le module " no check device ", grâce à lui, safetynet passe en vert. Et sur les rom Samsung avec le kernel stock apparemment Magisk hide ne fonctionne pas donc déjà la connexion à snapchat ne se fait pas.. Il faut flasher un kernel, j'ai pris le kernel "superkernel". Il faut flasher Magisk phhs' et xposed après le kernel. Et la Magisk hide fonctionne. Donc pour ma part, j'ai tout intégrer à ma rom custode, j'utilise snapchat, ça marche en activant Magisk hide et en désactivant xposed. Pour une application comme "pokemon go" ou "banque" je ne sais pas. Quelle application qui ne passe pas utilisez vous ? Désolé d'écrire en français. Je ne suis pas très fort en anglais.. Lol
[Magisk] Didgeridoohan:
I'm sorry, but English is the language of xda... If English isn't your forte, use Google Translate.

Nice that you've got things working though. :)
[Magisk] Ssbroly:
Yes il use translator for read messages but for write it's difficulte ^^ bad translator when i Write a message. Thanks :)
[Magisk] RandomPooka:
The native English speakers can usually figure out what you mean, and will try to be clear in their responses when we see someone who doesn't speak English well.
[Magisk] Ssbroly:
It's OK ! Thank you :)
[Magisk] Iradj:
Guys can anybody tell me why Magisk 10.2 bootloops on my S7 Edge with official Nougat 7.0 ?
[Magisk] waylo:
Odd, I can't even get this one to install. Any thoughts?

EDIT: Installed v1 from Magisk v1, then uninstalled, and then the latest version worked. So odd.
[Magisk] sansnil:
For anyone who didn't think to uninstall the Magisk Manager app BEFORE flashing the uninstaller or flashing the new version like me... You can use adb to uninstall the leftover app and then the new apk will install:

adb uninstall com.topjohnwu.magisk

The trouble appears to be that the app isn't uninstalled cleanly when flashing either the uninstall/install .zip's so uninstalling it with adb cleans up the uninstaller app so there new one can be successfully installed.
[Magisk] gohamstergo:
Of note, I installed/uninstalled the old one, still wouldn't work, so I reinstalled and went into the app's listing in Settings. uninstalled from there and noticed that somehow it was still installed under "another user" even though i only have one user. so, click menu and "uninstall for all users" and now the new one installs fine. just fyi for future people...
[Magisk] Captain_Throwback:
Wrong thread. And I don't know what root explorer you're using, but Root Explorer and Solid Explore work just fine with phh's Superuser.
[Magisk] TheManii:
[MENTION=4470081]topjohnwu[/MENTION]

I think the installer has issues with my ramdisk. There are no errors in the install logs, it seemingly installs correctly though it takes longer then usual to go from "- Patching ramdisk" -> "- Repacking boot image" -> "- Flashing new boot image" It simply bootloops, but it seems to bootloop so early that it cannot even create a log in cache.

My phone works fine with supersu's systemless mode, but not an empty magisk container. I did fully clean out supersu and xposed, it boots correctly with both installed and both uninstalled, so the issue is likely specific to the magisk installer.

I used the same install steps on my N4 and 2013 N7 and magisk works correctly on those, so that's also not an issue. My N4/N7 run 6.0 with TWRP 3.0, but this is 5.1 with TWRP 2.8. Could it be more issues with TWRP 2.8? Your previous scripts had issues with it in the past.

Details:

Device: Samsung Galaxy S4 Google Play Edition (GT-I9505G/jgedlteue)

ROM: LMY47O.S008.160601 (5.1)

Recovery: TWRP 2.8.4.0

Magisk-v4
[Magisk] RandomPooka:
I may have to bite the bullet and do a clean install of PureNexus on my N6 to try this out
[Magisk] elreydenj:
Root explorer does not work on Magisk version of phh on DP5. Fails to open. FX works. Any ideas as to why if you have it working?
[Magisk] Captain_Throwback:
I just installed Root Explorer and when I opened the app, the Superuser prompt immediately popped up. Then the app popped up in front of it and I had to press back twice to get back to the prompt. Maybe that's what happened to you? Because it works fine, like I said - it always has.

EDIT: Unless your issue is specific to your ROM or Android version. I don't see why it would matter, though, especially if it's working for other apps.
[Magisk] benwalburn:
I installed v4 on a fresh CM13 install, after removing su from /system/bin and /system/xbin. Then I installed Phh's root and systemless Xposed, rebooted and installed the apps needed to control them.

For some reason they're not working. Phh's app says I need to update my superuser binary, Xposed says the framework isn't installed, and Magisk Manager says that I'm not rooted and Selinux is permissive, and the toggles are grayed out. During installation I did not get any errors.

I'd attach the log files but I apparently don't have permission to do anything with them, so I'll have to figure out that.

Edit: fixed the permissions, log is useless. Both say the same thing.

Magisk post-fs mode running...

Magisk post-fs-data mode running...

Preparing bind mounts

Bind mount dummy system

Bind mount module items

Bind mount system mirror

Bind mount mirror items

Magisk late_start service mode running...
[Magisk] elreydenj:
You on Android N?
[Magisk] Captain_Throwback:
I'm not. Someone who is will need to chime in and confirm if it works for them.
[Magisk] dimm0k:
looks like I'm updated to v4! was already in TWRP when news of Magisk was released so I downloaded all the goodies to a USB and mounted it in TWRP. flashed the uninstaller for Xposed and Magisk, then installed Magisk, phh superuser, reboot, installed Magisk Manager in those steps. didn't work out so once I was back into my home screen I issued "adb uninstall com.topjohnwu.magisk" followed by uninstalling the interface for phh superuser, uninstalling Magisk Manager, boot into TWRP, flash uninstall for Magisk, flash Magisk, flash phh superuser, reboot, install interface for phh superuser, install Magisk Manager. now that I'm rooted I went back into TWRP to flash LiveBoot and Xposed... anyone know how to dim the background for LiveBoot so the text is more prominent?

[MENTION=4470081]topjohnwu[/MENTION] being that I uninstalled Magisk v3, installed Magisk v4, installed phh superuser, uninstalled Magisk v4, installed Magisk v4, is the backup copy of my bootimg still a virgin bootimg?
[Magisk] bigknowz:
Thanks

Nice work [MENTION=4470081]topjohnwu[/MENTION], all root working and passing SafetyNet with phh. I tried to use modified SuperSu, but it didn't ask Magisk app for superuser access. Any idea what I'm doing wrong? Also, for anyone having issues with Tasker, see here. Adding modversion to build.prop had it recognizing root again.
[Magisk] reekotubbs:
Could not get v4 to work. After uninstalling v3, then installing v4, pph superuser zip, pph superuser apk, then v2 manager, I received the message about needing to update binaries.

So I just reverted back to v3. Works again now.
[Magisk] skanadian:
Soft reboot is making xposed go yellow.
[Magisk] Droidphilev:
Hi,

Gave v4 a short try on a fresh installed debloated stock rom on Nexus 6. THe root toggle is not sticking again.
[Magisk] dimm0k:
using v4 and trying to add a certificate to the /system/etc/security/cacerts directory, so I created /magisk/system/etc/security/cacerts. after putting the cert file and rebooting, I don't see this file merged into /system/etc/security/cacerts. am I missing something?
[Magisk] smohanv:
TiB doesn't work with phh's rooting. It says system not rooted. As of I could see, TiB and CF Lumen are not working with phh's root as these apps doesn't recognise that the device is rooted.

PS: My device us Huawei P9 running on EMUI 4.1
[Magisk] John`:
Edit: ignore post
[Magisk] waylo:
Works perfectly fine for me. Did you install phh superuser from the market?
[Magisk] gordonk654:
can anyone tell me if i can use Magisk in emulator or virtual machine?

I tried to install it to an virtual machine with android 6.0 but after i install Magisk Manager and after the downloading the Magisk v10.2 package it says "installation error" - "...... manually flash".

P.S - I am noob :(
[Magisk] culiacanazo:
Believe me (I'm an ESL teacher), neither Google nor any translator for that matter can work the way languages do, it's incomprehensible if you don't speak two or more languages, yet unnecessary to explain if you already do... What do i suggest? I dunno! I just thought i let you know. (I'm available for Spanish, but then again so are a thousand other ppl) :p
[Magisk] Didgeridoohan:
[OT]Yes, I know. My wife teaches both English and Spanish and we sometimes talk about the different tools available. But if you don't have anything else it kind of works. I don't really speak French, but Google Translate made the message quite readable and understandable. But of course, sometimes it just doesn't help at all... :D[/OT]
[Magisk] westeight:
What is the name of this process...?

Magisk Hide can find no 'com.google.android.gms.setup' when I search for it?
[Magisk] Captain_Throwback:
It's not necessary to add any process to Magisk Hide for SafetyNet to pass. Simply enabling it will take care of it (unless you have "other things" that cause SafetyNet to fail).

This has been stated over and over, time and again in the thread.
[Magisk] westeight:
I'm well aware of that. Magisk Hide is enabled, but I am curious why I have no 'gms' process to check... :cowboy:
[Magisk] Xyntiah:
Well, I did a full swipe then installed magisk and shh supersu twice. And I could never pass safetynet and play PokemonGo, I don't know what I did wrong.
[Magisk] Didgeridoohan:
https://xdaforums.com/showpost.php?p=70426733&postcount=7120
[Magisk] Captain_Throwback:
Because "gms" is a bunch of processes and subprocesses. The only one that matters for SafetyNet is the gms.unstable process. It's not a separate app; it's just a part of Play Services, like many other services are. Magisk Hide automatically adds that subprocess to the list, but since there's no app associated with it, there's nothing specific to that process to display.
[Magisk] duowing:
I tried flashing this on my Honor 8 and it seems to work, boot, and pass safety net, the only issue is it seems to break the fingerprint reader. The Fingerprint ID menu gets removed from Settings. It can be found by searching, but will not let you add a Fingerprint to it, and also removes some of the other features tied into Fingerprint ID, such as swiping down to open notifications. The button itself still works as I can still set and use that. I then flashed stock boot.img back and everything was working again. I don't know if it's something such as a prop that is getting set that disables it based on security or if it's just in the way that it modifies the boot.img and is breaking something in Huawei's implementation. I grabbed two logcats, one before flashing magisk and one after. Unfortunately I don't know enough about where to look or what I'm looking for exactly to try and figure it out. If anyone could help out that would be greatly appreciated, if not, it's not a big deal as I have my HTC 10 with Magisk working quite nicely.
[Magisk] westeight:
Thanks for clarifying. Got it now :good::cowboy:
[Magisk] Captain_Throwback:
Exporting the output of "getprop" from a working and non-working setup would also probably be helpful for comparison, in case it is a prop that's getting set. That should be easily reversible with resetprop, if that's the case.
[Magisk] yochananmarqos:
Not without at least a TWRP log.

No.
[Magisk] samnaction:
I am on 2.79-SR1 Android 7.0 OOS 4.0.1, Can I directly use magisk manager from playstore ?
[Magisk] luckylui:
Hello everyone,

What applications are you guys hiding root from? I have everything installed correctly, but the SafetyNet still fails. Only thing disabled is the gms in the list.
[Magisk] Artim_96:
It's Samsung... So I bet they f***ed up the complete system once again. Maybe Magisk needs a complete redo for Samsung N.

PS: did you had the beta? If so, was it running there?

---------- Post added at 08:51 PM ---------- Previous post was at 08:46 PM ----------

Only that, nothing else.

SN failing will be caused by incompatible ROMs (if it fails before installing Magisk or any other modification, it will most likely fail afterwards too), SELinux on permissive, leftovers of system-based SuperSU and/or XPosed or supersu or XPosed on general
[Magisk] spida_singh:
Try this
[Magisk] duowing:
I did not know that I could do that. I'll reflash and see what I can come up with. I'm hoping it's something as simple as using resetprop
[Magisk] logo20heli:
I uninstalled Magisk using the Uninstaller and then the OTA worked fine. I was under the impression that you could apply OTAs even if Magisk wad installed. Maybe that doesn't work if the boot partition needs to be updated by the OTA. I will now reinstall Magisk. Thanks for your help.
[Magisk] Didgeridoohan:
Did you try to just flash your stock boot image (that's what happens when you uninstall Magisk, apart from removing everything else that has to do with Magisk). That way you'll just have to flash the Magisk zip after the update, and not all your modules as well.

And by the way... How did you manage to mess up the quote like that? :D You quoted my post, but as X46X...
[Magisk] tag68:
Does a list of compatible devices/OS exist? In my case is the current question: Would Magisk work fine out of the box (root via internal phh) for Marshmallow on Moto G2, G4 Play, X Play and Z Play?

I know I can just try. But that's an hour of backup before I even start (boot twrp, do backup, transfer to some safe hard disk, maybe additionally backup all via Titanium Backup). Yes, I'm a coward in these things ;). If I don't get an appropriate answer, I will try. But I'd also like to look up the device before I'd recommend Magisk to someone.
[Magisk] Kr47os:
To solve this uninstall SuperSU and flash phh superuser then install phh superuser and in Magisk Manager option check Magisk hide and reboot. Enjoy
[Magisk] teddy0209:
Just try, waiting for someone here with the same device as yours might even take forever... Don't worry, just flash your backup boot.img if things go wrong after flashing magisk.
[Magisk] Nonononoki:
I can confirm that the latest version works with the ZUK Z2 running ZUI 2.0.093_ST_16081!

Finally able to use online banking and PoGo! Thanks a lot!
[Magisk] BarrySamuels:
Xperia Z running LineageOS 14.1 (Nougat)

I have, today, installed Magisk, Magisk Manager etc. and all appears to be working as expected except for modules. I see a heading 'Downloads' which has numerous entries and above that a heading 'Modules'. If I touch 'Modules' it takes me to a new screen which shows one module 'phh's SuperUser' which is enabled.

If I tap the + sign at the bottom of the display it shows 'Flash Module Zip' with an orange icon next to it. If I tap those I go to a new screen which shows 'Magisk-v10.2.zip' at the top. If I long press that I see a message '1 Selected' and then if I tap 'Open' it downloads a zip, installs it, then asks me if I want to reboot. I say 'yes' and the phone reboots.

When it restarts and I open Magisk Manager nothing has changed. There are no more modules in the list. Am I doing something wrong? :confused:
[Magisk] teddy0209:
Update the manager via playstore.
[Magisk] BarrySamuels:
I downloaded Magisk Manager earlier today from the Play Store and there is no further update available.
[Magisk] teddy0209:
What exactly is the problem, can you not download modules from the download tab?
[Magisk] BarrySamuels:
I'm not referring to the 'Download' tab. What is the difference between 'Download' and 'Modules' ?
[Magisk] victoryo:
Yeh. I got it working with Safety net passing on my Xiaomi Mi5 :D.

Had to use magisk V9 and everything is working fine. Very strange!
[Magisk] Filip013:
Glad to hear it. Also, nice to hear that a Xiaomi device can pass SafetyNet without CTS profile mismatch, I didn't know that. BTW, hit that thanks button if I helped you. :good:
[Magisk] Didgeridoohan:
"Downloads" is where you download modules from the repo and "Modules" shows your installed modules and where you can also manually install a module by clicking the "+" and navigate to where you have the zip stored on your device.
[Magisk] BarrySamuels:
That does make it more understandable, thank you.
[Magisk] 3dawg:
Hello. On any device which doesn't have an official Nougat, I have been unable to pass safetynet when using Magisk. N5 with purenexus, Moto G with CM14.1, and most recently LGG3 D855 when using CrDroid 7.1.1.

I am flashing zero extra mods, simple the rom followed by magisk. Why is it that all of these roms fail to pass?

I have included a log for the G3 which could hopefully provide you with some insight. Thank you for any help!

** Magisk post-fs mode running...

** Magisk post-fs-data mode running...

* Preparing modules

* Stage 1: Mount system and vendor mirrors

* Stage 2: Mount dummy skeletons

* Stage 3: Mount module items

* Stage 4: Execute module scripts

* Stage 5: Mount mirrored items back to dummy

* Enabling systemless hosts file support

Mount: /magisk/.core/hosts

* Enabling BusyBox

Mount: /magisk/.core/busybox

** Magisk late_start service mode running...

service: /magisk/phh/service.sh

phh: Live patching sepolicy

phh: Moving and linking /sbin binaries

phh: Mounting supath

phh: Starting su daemon

* Removing tampered read-only system props

* Starting Magisk Hide

MagiskHide: Update process/package list:

MagiskHide: [com.google.android.gms.unstable]

Zygote(0) ns=mnt:[4026534792]

MagiskHide: com.google.android.gms.unstable(PID=6925 ns=mnt:[4026534852])

MagiskHide: Unmounted (/sbin)

MagiskHide: Unmounted (/magisk)

MagiskHide: Unmounted (/system/xbin)

MagiskHide: Unmounted (/system/etc/hosts)

Do you perhaps know what causes safetynet to pass or fail on a ROM by ROM basis? Magisk works great on the N6/6p/5x/Op3 from what I've tried but then fails here. The one thing they all have in common is official builds of Nougat. Is it something related to that?
[Magisk] logo20heli:
I figured that uninstalling would restore my stock bootloader since the installer saves a copy. After the OTA, I went into Magisk Manager and it was missing several menu items. I was unable to get it to install Magisk again from the Manager. So I booted TWRP and installed 10.2 from there. I am back to fully functional now.

As for the quote, I just used the quote function in my XDA app. The thing is that you had two quotes in your reply to me. So it quoted your second reply. I manually pasted your reply to me into the quote.

Thanks!
[Magisk] Didgeridoohan:
The log looks fine. Except for there being nothing under the "* Removing tampered read-only system props", but that might just mean there's nothing to remove...

Leftovers from built-in root and/or SELinux being set to permissive. Those two would be my best bets...

For root you could try osm0sis unsu script. Search for osm0sis odds and ends thread and you'll find it. After running it you'll have to install Magisk superuser again.

SELinux state can be found by using the command "getenforce" in a terminal emulator. If it reports permissive you'll need to change it to enforcing. I believe you can use the command "setenforce" for that, but you'd better Google it.

Other than that, as you've found out, it's tricky when working with custom ROM's.