yashsingh1/xdaforums huggingface dataset:
[Magisk] 7wells:
Sorry, I do not understand this. I have Magisk Manager 7.5.1 installed but not the Magisk framework. Is this what you meant?

When I start Magisk Manager, it tells me that Magisk is not installed (which does not surprise me, of course).

So what am I nos supposed to do? I do not see a way to install/flash the framework from the app, and the phone is not rooted.
[Magisk] zgfg:
Don't you have the option "Install" at the top - press on that and follow, it will ask you do you want to patch...

Btw, at the end you have also link to the GitHub where you can find the link to the Guide, describing how to patch

---------- Post added at 03:41 PM ---------- Previous post was at 03:35 PM ----------

Actually I don't see an issue already reported to GitHub for this new "Image file is too big" problem - somebody with the problem should report

There is only one there about low memory condition when patching (that might be triggered now more often than earlier)

And ofc, additional checkbox to opt for the padded zeroes or not would be IMO the best bet
[Magisk] zgfg:
New page 471, with a single post that was deleted - resulting with 404, that last page cannot be opened

Hence, adding this dummy post to keep going (otherwise, it's pretty nasty with XDA app, thread cannot be opened at all)
[Magisk] HippoMan:
Could this XDA "functionality" be related to the fact that this thread is huge, with tens of thousands of messages? If so, perhaps a new thread is in order.

.​
[Magisk] CSX321:
I think it's just a vBulletin bug, and not related to thread size.
[Magisk] zgfg:
It happens also on the thread with one full page and the new/second page with a single post deleted by the moderator (they can only fully delete a post)

Btw, new XDA 2020 forum is supposed to come this month:

https://www.xda-developers.com/big-changes-to-xda-forums-are-coming-soon/
[Magisk] pndwal:
I often get back to thread by clicking (known / accessable) link from another thread, which works.

Labs app truncating / losing post at spaces copied and pasted is s bigger problem. (I ALWAYS copy whole post before posting, just in case.)

I really hope XDA finds their new open-source Labs Dev team, and some Devs are interested and have PMed re that. Sorry for OT! :silly: PW
[Magisk] pndwal:
John's commits:

https://github.com/topjohnwu/Magisk/compare/v20.4...master

Commits on Sep 27, 2020

-Support modern Samsung AP.tar patching

-Pad images to original sizes with zero …

- Add new --install-module command …

Commits on Sep 29, 2020

- Skip image padding on Pixel C

John's problem:

'Wrapping up releases always take an insane amount of effort; so many minor things to test/check/hotfix. Being a perfectionist (and also having a day job) makes public release a pain in the a a a a a... posterior.'

John's needs:

A team

A break

Sleep

Thanks. PW
[Magisk] PoochyX:
Yeah these things they do are not easy [emoji817]
[Magisk] zgfg:
Did you have a time to try
[Magisk] Frost90:
Hello, one of the last remaining things I can try from this list in my effort to make MagiskHide work is trying the Magisk Canary build. I see that the Magisk Canary thread is closed and the download link to the latest version is broken, so my question is is this still something I should try and how? Is the Canary Magisk Manager (Debug) version the one I should try?
[Magisk] zgfg:
Canary thread is closed but its second link Canary Magisk Manager debug points to the correct place on TJW GitHub for downloading the latest Canary Magisk Manager (currently 301)

https://raw.githubusercontent.com/topjohnwu/magisk_files/canary/app-debug.apk

You can get to the same link from your Stable Magisk Manager by taking the link to GitHub and find it there

Download and install Canary Magisk Manager, open its Settings and change the Channel from Stable to Canary - then Magisk Manager (main page) will offer you to update the Magisk from your Stable 20400 to the latest Canary 20427 (all through the official GitGub links)
[Magisk] Bob1900:
Magisk disappearing

Magisk started disappearing for no apparent reason. I noticed that I hadn't upgraded it in a long time (was running v15.3), so I installed the latest version (20.4). It worked, but Magisk disappeared after a while. After reinstalling, again it worked for a few minutes, then disappeared.

Running a very old and unmaintained version of ResurrectionRemix on Che2-L11 (Cherry Plus). A phone which for the last two years or so has not had an existing ROM that is maintained.

Obviously, I'm seeking advice for how to make Magisk work again.
[Magisk] mariodm1:
Ulefone mix

I have an ulefone mix, I wanted to put magisk, with twrp to put I see that it is complicated because the system is forced on the cryptography of which I do not have the password. If I use the procedure without changing the recovery I did not understand if I have to patch the boot.img or the recovery.img with my phone that has android 7? does anyone know something? thank you
[Magisk] 7wells:
Hello, I come from LOS 15.1 on a Google Nexus 4 (mako, arm architechture) with OpenGapps (pico, with GoogleTTS excluded) for Android 8.1 and Magisk 20.4 working fine.

Immediately after flashing LOS 17.1, I flashed OpenGApps (again pico, again with GoogleTTS excluded) for Android 10.

After rebooting to system, Magisk was not installed anymore (only the app), so I though that I could get it back by simply flashing the Magisk zip file via TWRP (3.4.0-0). I did this, and there were no error messages. However, after rebooting agaon to system, Magisk Manager tells me again that Magisk is not installed. When I click the button for installation, there are 2 options: 1. to only download zip file (but I have that already on /sdcard, so that makes no sense to me), and 2. to select and patch a file. However, I have no boot.img to select. Why does Magisk Manager not offer to flash the boot.img file directly, as it was possible a while ago, if I remember correctly?

I rebooted again into TWRP and flashed Magisk 20.4 once more. The log told me that a Magisk patched boot image was detected, so the previous flash obviously worked. So why does Magisk Manager now tell me that Magisk is not installed?

Is it necessary to unhide the Magisk Manager before upgrading from e.g. LOS 15.1 to LOS 17.0? Or to uninstall Magisk (and app) completely before such an upgrade? Or are there other measures necessary that I was not aware of? In the current state in my case, the Masgik Manager has no option to unhide itself.

Which logs shall I share?

Thanks for sharing your thoughts and your help.
[Magisk] J.Michael:
Did you uninstall v15.3 before you installed v20.4?

Did you have v15.3 running under a different name? (I do not know if "rename manager" was an option in v15.3.)

Are you able and willing to completely wipe and install ROM? (original phone ROM or custom ROM you have been using.)
[Magisk] Frost90:
Hey [MENTION=7786725]zgfg[/MENTION] I saw that you reported an issue with the magisk repackaging on Canary, any news on that? I encountered something similar on the latest Canary version, the error I get is "Hide Magisk Manager failed". I attached zip file with screenshot of error message and logs (file sizes too large to upload individually)
[Magisk] 7wells:
After rebooting once more to sytem, I see 2 Magisk Manager apps, one called Magisk (showing that Masgik is not installed) and then the other one (which I renamed to something less suspicious), which tells me that Magisk is installed. I think that there was just some kind of a hiccup, because after switching the display off and back on, the first (non-hidden/masked) Magisk Manager app is gone - as it should be. And to my utter delight, SafetyNet tests were successful (ctsProfile true and basicintegrity true). :)
[Magisk] Bob1900:
Good idea. I realize now I should have flashed the uninstall file first. I found an old uninstall (from 2017, around the time of v15.3) and flashed it with TWRP. It exited with an error, but after rebooting to system, Magisk seemed to be installed (v20.4). Magisk Manager asked me to run a setup file, which I did. It seems that the uninstall file uninstalled the old 15.3 version but not the newer version. If I don't report back, the issue is solved.

UPDATE: Well, the Magisk issue was solved, but something else is wrong with the phone. It is rebooting spontaneously every 5-10 minutes. Spontaneous reboots have been a problem for the last few weeks, gradually increasing in severity. I thought it might have something to do with Magisk being outdated. Another possible reason is something related to Apps2SD and the microSD card. I've been getting errors that my SD card is corrupted, but after replacing the card with a brand new one, the error persisted. A "corrupted" brand new card? Hm. Might be a false error message. But I suppose this is beyond the scope of the Magisk message board.
[Magisk] zgfg:
Please check Instructions Guide, it describes how to probe by getprop is your system SAR, do you have to patch boot or revovery, etc:

https://topjohnwu.github.io/Magisk/install.html

Also, patching by itself does not hurt, it just creates a patched image file in the Download folder. Patching cannot brick the phone, hence you can even try patching both the boot and recovery images, then monitor to the Magisk Canary screen does it report an error or not.

If you attempt to patch a wrong image, it would not find the ramdisk in and it would immediately report an error

It will be also easier if you go for Canary Magisk, bcs Canary Magisk Manager shows itself do you have SAR, A/B, Recovery mode

Once you obtain the patched image you will have to flash. Be aware that (except on the ancient phones) it requires to have the Bootloader unlocked

Unlocking Bootloader is phone specific (how to apply for, from vendor or 3rd party, free or paid service, which tools to use) and obviously not covered by the Magisk guides.

Also, for patching the image (boot or recovery) you will first have to obtain the image - this is also phone specific (where to download your stock firmwares, how to extract the images, etc) - for all that you need to consult some forum dedicated to your device.

On such forum you may also find the whole guide (by others who already rooted) how to install Magisk to your phone (answering also to the questions should you patch the boot or recovery, etc)

---------- Post added at 04:35 PM ---------- Previous post was at 04:15 PM ----------

You could also find that I had reported that the problem was later fixed?

It was a problem more or less specific to MIUI. At the time I submitted the issue to GitHub, collected logcat logs and later helped to TJW since he didn't have a (newer) Xiaomi device to experiment with the potential fixes

Edit: Before all that, make sure to give to the Magisk Manager permissions for Storage and to install the app (for repackaging, it must download and install).

Try also with disabled Play Protect (with the latest Canary versions I didn't need to disable but previously it was mandatory, hence just in case)
[Magisk] mariodm1:
ulefone mix magisk is ok with patch on boot.img

thanks for the answer, yes I had already unlocked the bootloader, but the cell is in orange mode and I get a warning every time it is switched on that lasts 5 seconds, how do you remove it? Then I tried with boot.img also because it is android 7.0 so without A / B. It works, magisk installed!

do i see an option in magisk that allows you to remove forced encryption? so i could put twrp without deleting everything?

thanks,

Mariodm
[Magisk] zgfg:
Excellent

Some kind of warning while booting (by the Bootloader itself) that BL is unlocked is usual - (smallest) price to pay for. Cannot be fixed by Magisk

Rather check in Magisk Manager (Canary gives you more info) if you pass the SafetyNet - e.g., if Google Services detect (in run-time) that BL is unlocked, CTS and the whole SafetyNet will fail and you may have problems with Playstore, certain apps, etc

Btw, it's unusual that you see problems with TWRP and storage encryption on Nougat. Maybe you just need to type in your Android screen unlock pin when you boot to TWRP, or flash some VBMeta for your device
[Magisk] mariodm1:
options in magisk?

CTS in safety had failed, but then I activated an option in hide's magisk and it went into success !! I had read about cna adb script to remove orange mode, but maybe it's not worth it.

I didn't have an unlock pin, but the cryptography is forced and does not take off, but what are the 3 advanced magisk options for? I also see advanced cryptography enabled there, what are VBmeta instead? thank you!
[Magisk] zgfg:
Which 3 advanced options - name them or give a screenshot.

Anyway, to remove encryption from Storage you would need to Format /data and that must be done from TWRP, nothing for Magisk (but that would also wipe the Magisk's own database, modules, etc, stored in /data/adb folder)
[Magisk] mariodm1:
[IMG]https://images.app.goo.gl/m4Dzbwbk7UZyU3UF9[/IMG]

are the advanced options on the home screen.

see image, they are however these:

-Preseeve he forced encription (which is already inhabited by me)

-Preserve avs-dm verification

-Recovery mode

the latter two are uninhabited

sorry for the perhaps trivial question and thanks
[Magisk] rodken:
+1
[Magisk] zgfg:
Ok, you are on the (old) Stable, not on the Canary - first two options in Canary (Canary will be the basis for the upcoming new Stable) are already removed to avoid confusion, misusing, troubles (and unnecessary questions)?

You can check in the Guide but as a rule of thumb: Keep the first two On (since you have e.g. encrypted storage) and Recovery mode Off (since you are patching boot, not recovery image)
[Magisk] PoochyX:
Canary magisk manager always has to max canary for overall function which is frustrating

([emoji88]Omni Rom[emoji88])
[Magisk] timmylog:
Support for Tecno pouvoir three air

Hi everyone!

Pls ive tried using magisk to root my phone but it seems like its not successfully rooting my device, ive tried most of the stable, beta and canary builds but none if them seem to work.

Im hoping that someone here could help me out cause im really confused about what to do again right now

Im using an a-only system as root device that was launched with android 9.

Ive flashed an android 10 gsi to it. Havoc os specifically. (the latest build)

Ive tried flashing magisk zip file and patching and flashing boot image on both my shipped android version and the gsi too but none if them gets rooted.:rolleyes:. Pls id really appreciate any help/assistance and i just joined the xda forum by the way but im pretty familiar with all the android, custom recoveries, etc stuff

Device name:Tecno pouvoir three air

Thank you all in advance:)
[Magisk] Philnicolls89:
Here are the instructions from topjohnwoo for installing magisk.

Im not familiar with your specific device so i won't try to give you any potentially false tips or instructions!

https://topjohnwu.github.io/Magisk/install.html#knowing-your-device
[Magisk] timmylog:
Ive actually seen that site a long time ago, that was around the beginning of this year and according to the manual, it says all a-only SAR device should install magisk to the recovery partition. That was until the magisk developer made support for these kinda devices @ https://www.google.com/url?q=https:...FjACegQIBxAB&usg=AOvVaw3yYT7XjD96aAZd96DJee_H

But unfortunately, none of those builds still root my phone. :(

But thanks for the suggestion by the way.:good:
[Magisk] zgfg:
It says but for Xiaomi phones (a-only SAR), both Stable and Canary must be patched to boot

Anyway, things are very simple and you can safely try all combinations:

- If patching Recovery, Recovery mode must be On, otherwise Off

- If patching Boot (Recovery), flash to Boot (Recovery)

- Always have the stock Boot and Recovery images ready, and flash them back in case of bootloop

- While patching, watch the screen. In case of wrong file/image it will report an error and won't produce the patched image. See screenshots

On some devices you can even try to boot to, without really flashing (if it doesn't boot correctly, no need to flash):

>> fastboot boot magisk_patced.img
[Magisk] 7wells:
Hello, why does Freeandroid Root Checker find SU, when it is hidden in Magisk (20.4)? And the Magisk Manager app (7.5.1) is also hidden. The checker says that there is no root access (I of course permanently denied root access to this app from within the Magisk Manager app), but shows: SU: SU found - and under SU info:

Device: Google Nexus 4 (mako)

ROM: LOS 17.1

Thanks for your hint!
[Magisk] zgfg:
Instead of Denying SuperUser, you must checkbox that app in the Magisk Hide list of apps - then, its request for SU should never come
[Magisk] 7wells:
Oh, I did it the other way around, i.e. I first ran the root checker, denied its access, and only later thought about hiding it. So what does this mean now? The root checker is meanwhile ticked in the list of hidden apps, but it nevertheless sees SU as I quoted before. Is it too late now? If yet, I only need to know, because I can clean-flash and start over.

A little bit OT: Why does the root checker need internet access when executing the safety net check on the 2nd tab? Likewise, Magisk also downloads something for the similar function. What is it exactly?
[Magisk] zgfg:
1) In the SuperUser list, long press on the app and take Revoke - should be deleted from the list.

You also better go to Settings/Apps and Delete Cache and Data for the checker.

In the worst case, uninstall that checker app and reinstall

2) For SafetyNet, an app actually calls to Google Services API. Google Services submit local Basic Integrity and CTS findings to Google server who provides final verdict are you safe or not. Google Services authenticate whether the verdict was really from their server or not.

Hence no SafetyNet attest without Internet and you can't cheat with the final result (Magisk can only cheat while Google Services are collecting local data)
[Magisk] 7wells:
Thank you so much! (for some unknown reason, the "Thanks!" button does not work in my browser, sorry)

PS:

Stopping root checker, deleting cache and data, and even deinstalling and reinstalling the app did not help. I.e., it still finds the Magisk SU, despite I hide the root checker in Magisk before I execute root checker the first time and despite I deny it root access. I have now uninstalled root checker, restarted the phone, and will install root checker again to see what happens.

Well, it still finds the Magisk SU. I don't understand it. :confused:
[Magisk] timmylog:
Ive already done those and my phone ONLY gets rooted in recovery mode but it's actually the normal boot type of root I need, mostly cause of I need my mobile data and there's no network access in recovery magisk mode. Or less if you're saying I should patch my recovery img without ticking recovery mode and flashing it to my boot partition. Is that what you mean?
[Magisk] zgfg:
So your phone requires patching to Recovery?

In that case you must boot through recovery for Magisk to initialize.

Normal boot bypasses the Magisk patch in recovery - that's all also described in the Magisk guide

Btw, you can take it for good:

- You can always boot notmally, without the key combo for recovery, and avoid troubles with apps finding the root (unfortunately, it can't hide the unlicked Bootloader)

- In case of bootloop with Magisk modules,, you can continue using your phone as a daily driver
[Magisk] zgfg:
Sorry, no idea. Maybe it's something with your (custom) ROM, that checker reads /sbin/su (didn't it report for that)

I installed the same Checker, configured Hide as described, tested and posted my screenshot (Checker did not find anything)

Btw, that folder is actually mounted. Maybe you could play with and its privileges, but for me chroot makes no restrictions (777) and there was no ptoblem
[Magisk] J.Michael:
What do you mean by "phone ONLY gets rooted in recovery mode"? What can you do in recovery mode that you interpret as meaning it is rooted?

My device is Samsung. There were special instructions for installing Magisk. The hardest step was holding buttons while booting so I *started* going to recovery, but letting go of buttons before it *got to* recovery, so that Magisk would take control and boot the "regular" system, but with Magisk active.
[Magisk] mariodm1:
Magisk works on old archos 45 helium 4G with cm11 android 4.4.4

Now that everything works on ulefone mix with magisk, even if I don't know whether to put a twrp, but which version? always not supported ... In addition I recovered to practice with magisk an old qlive 4725 4G which is equivalent to an archos 45 helium 4G on which long ago I had put cm11 and already with the root, so it was very easy to put magisk and magisk manager , I realized that however twrp does not work well there is a version 2.8.6.0 which is perhaps already too large for its recovery memory, on the official website it is not supported. I don't know which one to flash on. Anyway magisk works but does not download the modules, I guess why there is android 4.4.4 and the modules are for new android? also the safety check goes ko how do i put it ok if i can? perhaps with cm11 it is not possible, but I do not think it is convenient to put back the official 4.4.2, also I should find the firmware that perhaps is installed with obsolete tools such as the infinity chinese 2 ... bah ... in fact the play store did not already work and also downloading the gapps didn't work, but there are apks around, yalp store doesn't seem to work anymore ... advice?
[Magisk] Wazakindjes:
Update problems

Magisk Manager kept crashing on open, so I tried to update it but then it started complaining that it doesn't support the actual Magisk version in use (which is quite odd). When I tried to update that, everything broke:

ALL settings and modules are lost

The /system partition seems to have vanished: mount: can't find /system in /proc/mounts

Link2SD can no longer mount my second partition usd for app storage, I can mount it just fine manually but that doesn't help if it's expected to be there at boot time

These are pretty major issues. I had to restore a backup from both the boot and system partitions to get a working Android again.

Also, the Manager has a lot of trouble starting up. It will be stuck on the splash screen and I have to close it and reopen it twice/thrice before I actually get to the app. And then I have to get lucky and not have the Manager crash on me.

A logcat from around the crash:

10-01 22:24:28.512 6877 6948 E AndroidRuntime: FATAL EXCEPTION: AsyncTask #4
10-01 22:24:28.512 6877 6948 E AndroidRuntime: Process: com.Ni.i.X.CSKtdIpsA, PID: 6877
10-01 22:24:28.512 6877 6948 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.indexOf(int)' on a null object reference
10-01 22:24:28.512 6877 6948 E AndroidRuntime: at a.ql.a(Unknown Source:78)
10-01 22:24:28.512 6877 6948 E AndroidRuntime: at a.ql.b(Unknown Source:19)
10-01 22:24:28.512 6877 6948 E AndroidRuntime: at a.ql.lambda$l2fFZC2Jq4qpiuFgxpU9uWDPuvs(Unknown Source:0)
10-01 22:24:28.512 6877 6948 E AndroidRuntime: at a.-$$Lambda$ql$l2fFZC2Jq4qpiuFgxpU9uWDPuvs.run(Unknown Source:4)
10-01 22:24:28.512 6877 6948 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1162)
10-01 22:24:28.512 6877 6948 E AndroidRuntime: at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:636)
10-01 22:24:28.512 6877 6948 E AndroidRuntime: at java.lang.Thread.run(Thread.java:764)
10-01 22:24:28.517 2219 2747 W ActivityManager: Force finishing activity com.Ni.i.X.CSKtdIpsA/a.b