yashsingh1/xdaforums huggingface dataset:
[Magisk] Kal-El7:
Ah.....give up. I'm going to wipe my phone completely clean in a few moments via ADB (Motorola Nexus 6) & installed the January 2017 Marshmallow Google Factory Image.

From that point, while I'm in ADB, I'll flash TWRP but will *not* flash any SuperSU.

Once I log back into my phone unrooted, this is where I'd like a humble tip:

Am I installing Magisk from the Play Store at the this point or am I downloading the Magisk flash zip in TWRP?

My understanding is that Magisk will root my phone automatically with topjohnwu's phh's SuperSU, although I did also find his phh SuperSU XDA thread and am wondering if his phh SuperSU needs to be flashed separately.

Keep up the fantastic work in here, folks - a lively & active thread.
[Magisk] Didgeridoohan:
I'm running a stock Nexus 6 with 7.1.1, january update, and I use Franco Kernel (r61 currently). From my experience you shouldn't have any problems getting Magisk up and running.

It doesn't matter if you download Magisk Manager and phh's superuser app before installing Magisk (and soon you won't need phh's superuser app). Just flash v10.2 in TWRP and it should automatically install phh's superuser topjohnwu version (you'll see it in the script output). On the other hand I always keep a zip for the superuser module on my device as well, just in case. And a clean boot image from the factory image (can be flashed in TWRP).

Just as a heads-up: you flash TWRP in fastboot, not ADB (fastboot flash recovery nameofyourfile.img).

---------- Post added at 17:05 ---------- Previous post was at 16:51 ----------

You were trying to get Airwatch to work earlier, right?

Why do you need to flash the boot image? You should be able to pass SafetyNet on LineageOS by default (I've seen users report success)...

When I talk of "stock" boot image I mean a boot image untouched by any other root solution. It can be your ROM's boot image, or the boot image from your OEM. As long as it's clean when you start.
[Magisk] gewe:
The status display of Magisk Manager is now reporting it as "topjohnwu".
[Magisk] morfinrider:
That's correct sir! Well I did a clean flash - system, data, dalvik and cache wipe. Flashed LOS and Open Gapps. Installed Magisk Manager and phh superuser from Play Store. Flashed Magisk v10.2. Enabled Magisk Hide and after a reboot hid Airwatch Agent + Settings. No luck there. Safetynet still fails and while Agent allows me to enroll, cannot setup corporate email or WiFi. Thought fixing Safetynet will work.

I tried flashing boot.img from OOS 3.5.6 (MM) flashable zip after LOS, (N7.1.1) and Gapps via fastboot but ended up with a boot loop. [emoji17]

Will try flashing and posting some logs tomorrow.
[Magisk] Didgeridoohan:
Yeah... Be careful mixing boot images between different ROMS.

I'm guessing Magisk Hide works otherwise? As in, you can hide root from root apps not using SafetyNet.

After that, I believe it's just the usual suspects of making sure SELinux is enforcing and turning off USB Debugging left to try.
[Magisk] Kal-El7:
lol - I don't know why I said ADB - yes, I meant fastboot. Been flashing with Fastboot about million times since 2014 - my apologies. My phone is completely now Factory imaged and, like you, Iike to make a Nandroid of a clean stock image for restore with my Google Accounts already activated. The reason for me doing a Factory Image wipe & deleting my stock nandroid that I had was because I wanted to get January's image (I had an older image from a few months prior).

Sweet - so I'll get the v10.2 flash zip flash in TWRP, which should automatically flash topjohnwu's phh SuperSU. However, I read somewhere that if I were thinking of doing a custom kernel (which you appear to be on - Franco r61), then the kernel should be flashed **first** then Magisk v10.2 should be flashed afterwards. So my question is this - is your Franco r61 kernel compatible with MultiROM v33? Because everyone's talking about ElementalX. I was aiming to install a custom kernel that is compatible with MultiROM v33 while, at the same time, have Magisk installed with SafetyNet passed. All on stock Nexus 6 (no 3rd party ROMs installed).

Now that my phone is imaged, I'm gonna install my Blacked-out apps first, and then the rest. :)
[Magisk] Didgeridoohan:
Yes, the recommendation is to flash the custom kernel first. I like flashing stuff cleanly, so I keep a clean boot image that I flash in TWRP when I update, followed by kernel and then Magisk. Probably unnecessary... I have no idea if it's compatible with MultiROM. Sorry. Hopefully the MultiROM feature of Magisk isn't too far in the future.
[Magisk] morfinrider:
Lesson learnt the hard way!

Oh yes, I tried Boeffla Kernel (no Franco for OP2) and set Selinux to strict. I also used Selinuxmodechanger to keep it enforcing - both these need root to work with.

Tried with debugging off too.

Going to try flashing kernel before Magisk tomorrow. Fingers crossed. Will share logs.
[Magisk] Kal-El7:
Perfect, kind Sir - thank you so much. :)
[Magisk] bhanuprasad1981:
Weirdly in latest 10.2 version none of module's show up except superuser and Google Assistant enabler, whatever I flash shows up in list but after reboot nothing is there, please help
[Magisk] Didgeridoohan:
Recovery logs from flashing would be useful... And which list are you talking about (there's a couple)?
[Magisk] hapa8o8:
Thank you [MENTION=4667597]Didgeridoohan[/MENTION] for referring me to this sub-forum.

I've been keeping up with the updates and now that I'm seeing it works with customizable ROMs I am willing to take a dive into this new method/platform of rooting. Note: I've been rooting/dev'ing since the G1, so I do enjoy new methodologies.

That being said, when I read the instructions on the main (locked) page, and on this thread, I am still confused as what to do when coming from a custom ROM. Are we now able to simply flash the Magisk via Recovery and download the respective manager? Or do we still have to flash back to Stock and then follow the instructions given?

I have read through this support forum (about 500 or so pages; reading every page would be mad), and used our beloved "search" function to find that others had success flashing over their Custom ROM (dirty flash), which is the approach I'd like to take since it seems the easiest.

Question, again: Can I dirty flash Magisk over my existing ROM without running into any catastrophic issues?

I would like to refrain from bricking my phone, is all.
[Magisk] H4X0R46:
Hey guys, I'm having an issue with passing safety net on a custom rom. Every custom rom I've tried even with built in SU removed (if it's even gone completely) the safety net test in the Magisk Manager never completes, just hangs on the loading circle. No pass and no fail. What could the issue be?
[Magisk] jhedfors:
There is very little risk. I would suggest downloading the magisk uninstaller I the release thread, just in case it causes trouble. Also, you should have a recent nandroid backup. If something goes wrong with the uninstaller (very unlikely), all you will need to do is restore boot, as that is all Magisk touches.
[Magisk] Kal-El7:
Thank you everyone for all your helps, tips, time, effort, selflessness, etc. The world is a better place because of you.
[Magisk] biggdevon:
I'm having some issues getting SafetyNet to pass. I've flashed stock 6.0.1 via Odin. Flashed TWRP and arter kernel. Wiped, booted system. Flashed v10.2 from recovery, booted system. Installed phh from play store. Log from app attached.
[Magisk] H4X0R46:
Had this issue before, go into the settings of the Magisk Manager app and tick Magisk Hide. Also wanna point out that there's an option for systemless host for AdAway, not relevant but I love the feature! Lol
[Magisk] Kal-El7:
Systemless host AdAway? WHERE? [emoji4]
[Magisk] H4X0R46:
In the settings, just tick it reboot, and install AdAway normally ;)
[Magisk] Kal-El7:
Oh snap....sweet. I didn't even bother to take a look there. Once activated, with what adblock apps would you use it with? I know there's the timeless AdBlock (Plus) app & others like it. What about the AdBlocking host module within Xposed Framework?
[Magisk] Domanshi:
I currently have linOS for Z00A and am rooted using the tool provided. I flashed Magisk 10.2 in recovery and it went without a hiccup. However, it only boots me back to recovery. What seems to be the issue with this?

Edit: Nah, nevermind. Found a fix while searching the thread.
[Magisk] Didgeridoohan:
You won't pass SafetyNet with Xposed active.

---------- Post added at 06:12 ---------- Previous post was at 06:08 ----------

There won't be any catastrophic issues. Worst case you'll have to dirty flash your ROM.

Having said that, custom ROM's can be finicky. There's been both success stories and great frustration... Give it a go and let us know.
[Magisk] Kal-El7:
This will cease to exist if Xposed were installed? Even if installed via Magisk's module?
[Magisk] Didgeridoohan:
Yup... But, I believe you'll pass again if Xposed is disabled.
[Magisk] Kal-El7:
Interesting, thank you.
[Magisk] biggdevon:
Does magisk re-install modules from old installs? I wiped and deleted magisk manager folder but it still managed to find previously installed modules. I removed Xposed and rebooted. Still no pass
[Magisk] Didgeridoohan:
Depends on what you wiped and how you uninstalled Magisk. The modules are kept in the Magisk image on /data, so unless you completeley wiped your device or used the Magisk uninstaller zip they will remain.

I saw you're using arter97's kernel. It's been reported to work with Samsung and Magisk Hide, so that might not be the issue. Does Hide work in hiding root from other root apps (that don't use SafetyNet)? Also, go through all the things that trigger SafetyNet and make sure you pass them all. I can't be bothered to get the link right now, but search this thread for "public service announcement" and you'll find some tips.
[Magisk] adrman:
This seems to be working great on my Nexus 6p. Since I don't really care about running Xposed, I just installed using SuperSU 2.76. I was running Franco r25, so first I fastbooted the stock boot.img, booted to recovery and rerooted with SuperSU. Then I booted to android to make sure I had root. Next, back to twrp to install the updated SuperSU and Magisk from post #2. Next, booted back to android to make sure things were working and I was able to pass a SafetyNet check. For fun, I decided to try Franco r25 again, so flashed that from recovery. Everything is working properly and I've passed the SafetyNet check. Thanks for your excellent work! :good::good::good:
[Magisk] hofopds:
Same issue, Nexus 6P running PureNexus. Flashed stock boot, Magisk, XPosed and phh-SU. Everything installed great, SU is working, XPosed is working, but the "Root Mount Toggle" re-checks itself as soon as I click on it.

Keep up the great work, VERY excited about this new development!! Just bit the bullet re-install XPosed after not having it for a while, and was missing Android Pay... This is the perfect compromise!

Regards-

hofopds
[Magisk] ShapeShifter499:
I see, I let [MENTION=5423715]YashdSaraf[/MENTION] know on his thread here http://xdaforums.com/showpost.php?p=68040711&postcount=64. Is there anything about his version of BusyBox you rely on, a extra binary that his includes or something? If not I may try to replace with Meefik's BusyBox since everything was working with that one.
[Magisk] Echo_2000:
Do i have to reflash Magisk after a rom update?
[Magisk] tikizondo94:
Running on latest chroma. Amazing work dev! Absolutely awesome. Root works, Xposed works, substratum works and magisk app work normal. Thanks for all your hard work! Amazing
[Magisk] Jariway:
Bootloop

Bootlooping on a Huawei Asceng G7-L01 with CM 12.1 :(
[Magisk] topjohnwu:
You need losetup, support for lazy unmount (umount -l), copy files reserving se contexts (cp -c), and maybe more.

Older Android versions lack a lot of built-in commands in Marshmallow(also the -c option for cp is super rare), that's why I need a complete busybox to provide consistent functionality.

I'll check it's repo.
[Magisk] KaMyKaSii:
[MENTION=4470081]topjohnwu[/MENTION] it would also be nice if you did a modified version of Liveboot for users to take logs in case of bootloop. And the purpose here is working perfectly (Magisk + PHH's SuperUser +Xposed). Only problem is the toggle itself activate as has been reported and LuckyPatcher not detecting busybox but Termux, yes. By the way, where is saved busybox binary?
[Magisk] Alex2x3:
I read through the thread and it seems a bit over my head. Can I use this to enable Android Pay on a rooted stock Nexus 6P? I recently deleted xposed after my phone was getting progressively more laggy.

I see that it specifically deals with systemless root. I'm currently rooted "systemed" is this a deal breaker? What exactly are the difference between systemless and regular root? Does being systemless change anything? Is it the better option now?

I can't live without root but would love to have android pay again.
[Magisk] Skuggo:
Facing some issues with this. Made a clean install of PhoenixRom for my S7 Edge with stock kernel. flashed magisk, then supersu magisk version and finally systemless xposed last version. This leads to a bootloop. Not sure what could be wrong, followed the instructions. If I can provide any further info please let me know!
[Magisk] LLStarks:
So...

My OPO is running Official CM13, Systemless SuperSU, and Systemless Xposed.

What's the most painless way to proceed and get Magisk running.

Additionally, what can't I flash once I get it running?
[Magisk] swipp3r:
Bootlooping for me to on my S7
[Magisk] topjohnwu:
Updated the OP with troubleshooting information.

People with issues please try to report bugs with logs, thanks a lot!!
[Magisk] steveo17:
love how easy this was to do. thanks

can i flash the systemless adaway package with this? or do you think it will not work?

http://xdaforums.com/showthread.php?t=2190753
[Magisk] :
Someone give this guy R&D!! Systemless Xposed worked like a charm for me and now this! I'm blown away. Amazing work [MENTION=4470081]topjohnwu[/MENTION] ! :good::good::good:
[Magisk] KaMyKaSii:
No, systemless Adaway and other systemless mods is based on SuperSU. We expect versions for Magisk
[Magisk] smohanv:
Don't know where to find "Magisk Manager" apk. I can't see this app after flashing zip files. Also tried in play store and can't see. Sorry if i am dumb not looking in detail in the thread. Thanks.

I found the app "Magisk.apk" in folder "common" in Magisk-v1.zip. I extracted it and copied in to Priv-app folder. It works. I am using with Huawei P9 EVA-09.

I was using 86.2 systemless xposed and supersu 2.76 (systemless). I didn't uninstall anything., I took a chance to flash Magisk-v1.zip then flashed phh-superuser-magisk.zip and xposed-v86.3-sdk23-topjohnwu.zip. Everything is working good except a little issue.

If i unmount root status it is not mounting again unless i restart my phone.

Unmounting root status doesn't make AndroiPay to work. Someting wrong.
[Magisk] harpin14789:
I am confused on how to flash this I am on nexus Resurrection Remix 5.7.2 6.0.1-52r MOB30R running SuperSU 2.76. I want to move to phhroot. Please help. Do I have to go back to stock factory rom?
[Magisk] topjohnwu:
Actually I AM a RD :p:p:p

My application was accepted for like a week, but XDA still refuse to update my status :D:D
[Magisk] LLStarks:
Will Android Pay work with AOSP or CM-based roms using Magisk?

I thought SafetyNet will fail no matter what.
[Magisk] bojiokia:
I have some quick question:

As nougat 7.0 is round the corner. I am on nexus 6p factory, with current latest xposed and magisk..

During a OTA to nougat available, can we just OTA to upgrade, while all existing systemless apps and hacks still remain intact in the magisk.img?

Or we have to use the magisk remover to remove everything, reflash recovery, and reinstall magisk and apps from scratch? How systemless help when we perform OTA?

And also, since v2, post has stated that it support ad block, but what it means? Example, adaway, there is 2 version available, systemless but not with magisk or normal. With v2 onwarss, meaning we need not care whether if it is systemless? We can just install the any ad block apps that's writes to etc hosts and magisk will do the job?

Or we still have to wait til developer adapt magisk systemless before we can use?

- Add systemless host support for AdBlock Apps (enabled by default), what this line really means, as to my knowledge.. hence next time developer have to put "MAGISK systemless" then we can use? Since the word systemless is widely used, but not indicating if its following magisk systemless template or so.

Feeling blurred.
[Magisk] KaMyKaSii:
It's just you install stock boot.img before applying ota, and then install Magisk again. All your mods saved in /data/magisk.img continue there

The Magisk already mounts host file automatically. So any AdBlocker appointed to work with /system/etc/hosts will work perfectly and the modification will be forwarded to the systemless hosts file, then your /system partition remains intact
[Magisk] waylo:
There are many differing reports on how to get adblock, specifically Adaway, to work.

1. Some say altering the normal /system/etc/hosts file does not affect SafetyNet regardless. So Adaway can edit that file as it usually does with no repercussions.

2. Some say flashing the systemless-root .zip, found in the first post in the Adaway thread, works just as well. This makes a file BIND that connects the /system/etc/hosts file to another one located outside /system (/su/etc/hosts)

2a. Some say because the systemless root adaway.zip is made for SuperSU, not phh-superuser (does su/etc/hosts exist in phh-superuser?), it won't work the same way for a phh-superuser. Unclear.

3. Some say you can just edit the preferences in Adaway to direct it to a different host file, provided there is an externally created bind/symlink. I believe with earlier versions of Magisk, it was /magisk/hosts. Now it looks like with v4+, it would be /magisk/.core/hosts. I had previously done this with v3. It seemed to work.

3a. Some say if you set it up this way in Adaway, when it asks to create the symlink, to hit NO.

4. There's another thread, http://xdaforums.com/android/software/mod-rps-systemless-ad-block-t3433672 by [MENTION=6320543]RatchetPanda[/MENTION] where you can flash a .zip file to add entries to the host. This is fully compatible with Magisk, as this came about as a direct result of Magisk's release, and is updated accordingly.

EDIT: 5. The boss has chimed in and confirmed that /system/etc/etc/hosts is not touched by system requests! (see next post)
[Magisk] topjohnwu:
You have to uninstall Magisk before upgrade.

That's an issue with your adb, I cannot help you with that

You can also use terminal emulator on your device and use the same command, removing the "adb shell" part

I just OTA my Nexus 9 with Flashfire. You have to flash your stock image back (flashify is a good choice, it also supports auto download stock boot for Nexus devices), and without rebooting, go to Flashfire and remove the "SuperSU injection", then add flash Magisk zip to the action. By doing so you can have Magisk installed along with the OTA in the next reboot. This method is good for the monthly security updates.

However for massive upgrades like Nougat, keep in mind you have to make sure all mods currently installed works on the new Android version if you want to use this method (an obvious case is that Xposed will not work on Nougat), or else your device might get stuck into a bootloop.

So a better way is to delete /data/magisk.img, restore stock boot, stock recovery with apps like Flashify , then apply OTA. After OTA, flash custom recovery and flash Magisk, along with mods that are compatible with the new Android Version.

The systemless host file support means that when you modify /system/etc/hosts, it will not actually touch the system. Instead it will modify the file in Magisk.
[Magisk] mastarifla:
Unfortunately no go with the Moto X 2014 on v5

The boot still fails with the fall through, but the Uninstall seemed to work well!
[Magisk] cge_95:
Hi [MENTION=4470081]topjohnwu[/MENTION]

I'm not sure I get correctly the OTA concept here !

You said that you just OTA your Nexus 9 but you had to flash factory image back, so this is not an OTA ?

If we need to download the full factory image every month and flash it, where is the systemless concept advantage ?

What about TWRP, let Flashfire handle it ?

Christophe
[Magisk] adrman:
I was just playing around with this and tried to just let Adaway apply to system/etc/hosts and the changed hosts file was reflected in Magisk/.core/hosts. I reverted to the original hosts file from adaway and the Magisk/.core/hosts file was also reverted. I'm concluding from that behavior that Magisk is applying a bind somewhere. In any case, I'm passing Safetynet with this setup, (N6P, stock, no Xposed, phhusson's superuser). I have not attempted a payment yet however.
[Magisk] topjohnwu:
I said restore boot image, not factory image :)

Your stock boot image is backed up to /data/stock_boot.img.

In Flashify, you can either restore your boot image from the path above, or use Flashify's built in feature to download the stock boot image of Nexus devices. This only applies to Nexus devices, and you seem to own one :)

For some devices (like my HTC 10), the boot image do not matter, so I can just apply the OTA without an issue.

I will add more info regarding OTAs in the OP when I got time. But you should get the idea.
[Magisk] stokholm:
Does that happen without any setup? Because that would mean you could flash Magisk, root and just apply AdAway with default configuration. Correct? And that would work systemlessly?
[Magisk] Captain_Throwback:
It happens as soon as you flash Magisk. There's nothing you have to change in Adaway. And yes, it's systemless.
[Magisk] Mar-cel:
Why is it not working?
[Magisk] jhedfors:
[MENTION=4470081]topjohnwu[/MENTION] or anyone else have an answer for this? Thanks.
[Magisk] Captain_Throwback:
Just use the mod template.
[Magisk] Cares:
On Magisk v4 with Android Pay 1.5 with Xposed. Failed payment.
[Magisk] dimm0k:
how does one get an app into priv-app?
[Magisk] Captain_Throwback:
Wrong thread.
[Magisk] Captain_Throwback:
Use the mod template.
[Magisk] :
Hey thanks for the mention :good:

I can add that my ad-block does much more than AdAway and a better job of it in my opinion. :)

---------- Post added at 12:12 AM ---------- Previous post was at 12:10 AM ----------

Well it says specifically in the mod template that it cannot add new items to system. There is a much needed guide on adding new items into system.
[Magisk] Artim_96:
As long as you only want to unmount root and not disable XPosed, for hiding one app from another try SudoHide. It prevents that app a is seen from app b (so your case you would go into the app, tap on XPosed installer and then on the app that should not see it and afterwards kill that app). It's not working for 100? (I hide Snapchat from PlayStore because of Snapprefs and from time to time it still shows up, after the next restart of the PlayStore is hidden again) but since it doesn't request root it might do the job.
[Magisk] wilder_mason:
I followed the instructions for installing viper4android, but when I start is it still has the popup to install the driver and the driver says it isnt enabled. http://imgur.com/a/NCnmG

Any advise?
[Magisk] biggdevon:
Didn't know it saved module data in more than one location, only deleted the folder before flashing the uninstaller and wiping cache.

Hide does work for other apps, tried a root checker. It toggles based on status in hide. I'll browse your PSA post again, maybe I missed something.

Anyone ever report Android Pay working with SafetyNet failing?
[Magisk] Didgeridoohan:
If you flashed the uninstaller all modules should have been deleted...
[Magisk] biggdevon:
Alas, they were not. I did what I could to come from as close to stock as possible. With the exception of the recovery and kernel that is.