yashsingh1/xdaforums huggingface dataset:
[Magisk] BigMacca:
Hi mate, thanks for the help.

I didn't even think about excluding Magisk Manager from battery optimisation (which I should have done as I was in there excluding my Podcast app earlier today!).

Magisk Mangaer is now excluded from battery optimisations - Force closing Magisk Manger and reopening it didn't work, but I've rebooted now and we are passing safetynet again.

I'll leave it for an hour or so and check again.

Cheers

Macca
[Magisk] arcticnights:
Thanks! Should I install the phh superuser app then?
[Magisk] bluedragon38:
can you give me apk please? or tell me the revision number before this update? thanks
[Magisk] djb77:
[MENTION=4470081]topjohnwu[/MENTION]

Came across something strange today.

Device: Samsung Galaxy S7 G930F

ROM: TGP 10.10

Kernel: TGPKernel 4.31

Magisk: 11.1

Magisk Manager: 4.2.5

As we all know, Pokemon GO (PoGO) is one of those apps that would require Safetynet to be completely passed you think.

Well, today I thought I'd give Magisk Hide / Safetynet a try with my latest ROM + Kernel.

Even though Safetynet still came back as not passed (CTS Profile Mismatch), PoGO still works AND I'm able to log into Android Pay.

It was suggested I try another Safetynet checker, and it still shows it fails, but only the Profile mismatch, other portions pass.

So, it's like my devices passes, but it doesn't. Strange... :confused:
[Magisk] Didgeridoohan:
Not any settings... The Settings process. You'll find it in the Magisk Hide list.

No. Magisk Manager manages root with MagiskSU.

PoGo only requires basic integrity to pass, a lower level security than CTS Profile match. And I really doubt that you'll be able to actually pay with AP, because that'll require CTS to pass.
[Magisk] djb77:
Cool, thanks for the information :)

The strange thing is I have seen it all lit up with 3 greens (back on DQB3), now I'm DQB7 and it just didn't seem to do it for me.

I have heard reports that other ROMs / devices pass without any problems, and I have tried a few different ROMS (even a stock ODIN).

It makes me think partially it may be something to do with my actual device itself, not a common issue on every device.
[Magisk] royal_eagle:
Not any settings... The Settings process. You'll find it in the Magisk Hide list.

-----------------

Don't have this on the Magisk hide list Sir?
[Magisk] jcrompton:
I'm not sure how helpful my comments are but I'm using SM-935F. I've found using Magisk and passing SafetyNet to be quite finicky. Shutting down Android Debugging, checking SystemUI (on a few ROMs) , making sure system is mounted read only ,,, to name a few. I never had to do any of those things on my Nexus 6.

But that said I have pretty much been able to get every stock based ROM to eventually pass .... And that's even after upgrading to the DQB7 .. SafetyNet ...... My issue is with the non stock ROMs (AOSP, Slim or Lineage based ). Somehow the kernel or boot image isn't playing nice with the Magisk modification and once Magisk gets activated I can no longer pass SafetyNet.
[Magisk] Didgeridoohan:
You don't have an entry in the Magisk Hide list called "Settings"? In that case, I don't know...
[Magisk] jrk190:
Either that or safetynet got updated. I'm having issues passing CTS as well
[Magisk] royal_eagle:
i've ticked everything related to samsung settings on the magisk hide :):) just to be sure but Airwatch still detect root :(
[Magisk] BigMacca:
Ok, it worked for a while but is gone again :)

Force closing the magisk app didn't help either.

Latest log is attached

Cheers

Macca
[Magisk] iubjaved:
I'm exactly on the same boat as you are. I have read this thread thoroughly and so far in my understanding, magisk doesn't work on custom rom ( lineage, RR, slim) as users reported, unless some reported they made it working by flashing boot images and reinstalling magisk. Some recommended to unSU, install magisk 10.2, install phh superuser, upgrade to the latest magisk via magisk manager, install reboot but none of this worked by me so far. Hopefully someone comes up with a working solution. I'm currently using latest RR on note 2 n7100
[Magisk] Didgeridoohan:
Passing fine on my Nexus 6, Pure Nexus 7.1.1_r21, Franco Kernel.

It could be a case of Samsung incompatibility... Could you upload your Magisk log?

Was worth a try... But, looking at your log makes me think you've got an issue with Magisk Hide. Try disabling and see if that fixes it.
[Magisk] jrk190:
Pure Nexus with ElementalX. Going to try pixel ROM and see how it acts, and might play around to see if I can get it working again.
[Magisk] royal_eagle:
It could be a case of Samsung incompatibility... Could you upload your Magisk log?

----------------------------------------------------------------------------------------------

here's it Sir
[Magisk] twcobra:
Just found this on another thread. Worked for me. Turn off USB debugging and the CTS mismatch went away and safetynet now passes.

https://xdaforums.com/showpost.php?p=71122244&postcount=12
[Magisk] Didgeridoohan:
You've really gone crazy with the Hide list, haven't you? :)

Anyway... You found the Settings app. It's the one with the process name com.android.settings. Add that one together with Airwatch to the Hide list (and remove everything else, it's just clutter and may even cause instabilities) and you should be fine... Should be, I say, IF your device also pass SafetyNet (I realised you haven't touched on this subject yet). If you can't pass SafetyNet, trying to find the correct things to hide is a bit of a moot point...

Tips for passing SafetyNet:

https://xdaforums.com/showpost.php?p=70426733

You can also try if your Magisk Hide is working properly by adding a root checker to the Hide list. If it can't find root (but can if it's not added to the list), you've got a functioning Magisk Hide.
[Magisk] biggdevon:
Have you tried paying with Android Pay yet?

---------- Post added at 05:03 PM ---------- Previous post was at 05:00 PM ----------

Have your tried hiding your phone apk? Try looking at the permissions of AirWatch and hiding the corresponding apps
[Magisk] BigMacca:
Hi mate,

With Magisk hide disabled, I can't get safetynet to pass even straight after a reboot.....
[Magisk] Didgeridoohan:
Facepalm...

I was confusing your problem with a loosing root problem... Sorry. :p

Edit: But yeah, from the log you posted there seems to be an issue with Magisk Hide. Might be that topjohnwu need to look at it... Maybe you should open an issue on GitHub.

---------- Post added at 17:11 ---------- Previous post was at 17:07 ----------

From previous reports in this thread it should be enough to add AirWatch and Settings. But, of course they might have upped their game so I guess it's worth a shot.
[Magisk] jcrompton:
Just to be sure ..... I have absolutely no problems with Magisk and Safety Net with custom ROMs in general. It's just the non stock ((Samsung)) ROMs on my S7 Edge that I'm having trouble with ......

I've essentially never used anything but custom ROMs and for months successfully used Magisk , Magisk Hide to pass SN

I think in my case it's something to do with the patching of the non stock boot image for my device
[Magisk] royal_eagle:
yeah sure :)

safetyNet passed on my device and do it the test with root checker right now and it's ok, Magisk is wroking when i'm hiding root checker, thanks for this test.

last question please :), Airwatch is working on your device with Magisk 11.1?
[Magisk] Fild5x:
I don't know if it will but the version is 4.1
[Magisk] Didgeridoohan:
Glad to hear that part at least works.

Never used the app myself, sorry. :D I believe [MENTION=1162986]Captain_Throwback[/MENTION] have previously reported success with Airwatch and the described method (hiding Settings).
[Magisk] iubjaved:
Have you flashed the boot.img of your rom and check if the safetynet passes? I have seen many reported that as a workaround.
[Magisk] jcrompton:
It sure enough works ...... But then I lose root
[Magisk] iubjaved:
yes. I believe its a compatibility issue since i have experienced it as well. I checked with root checker just to make sure, but the problem i had, even after a reboot it still says root is not properly installed which was working just fine hours ago. And dev's recent post confirmed Samsung device users are having these various issues comparing to others. :(
[Magisk] MichaelGK:
[MENTION=4470081]topjohnwu[/MENTION]

Hi, i saw that Magisk have something like its own cache and dalvik partition. I need to clean this. How to do it?
[Magisk] RandomPooka:
If you're not even sure that it exists, how do you know you need to clean it?
[Magisk] jrk190:
I did and it still failed.

I switched Roms and now magisk won't install. The app has detect boot partition greyed out and the zip exits with error 1
[Magisk] royal_eagle:
Thanks a lot Sir for youe help

---------- Post added at 08:23 PM ---------- Previous post was at 07:44 PM ----------

Not tested yet but will try
[Magisk] 101_North:
Got frustrated with losing root and ad-away not working consistently on 11.1 so I installed v12 170217 from the unofficial thread to try it out. So far it's been 4 days without losing root and no issues with ad-away. Android Pay is working great. I don't have busybox option enabled as I don't need it. Happy so far but I'll keep an eye on it and report back if I notice anything.
[Magisk] jcrompton:
AICP 2-20-17 Build

This log is from SM-935F AICP 2-20-17 Build , which interestingly has Magisk built into the ROM (but it apparently is not functioning upon initial install)

If Magisk is not working and no root then SafetyNet passes with nothing but disabling Android Debugging

After install Magisk and trying to turn on Magisk Hide I get three things:

Successful root

FC'ing of Google Play Services

And unable to pass SafetyNet (takes long time to finally go red)

Attached is log
[Magisk] Filip013:
I have a dumb question. I have experienced loss of root a few times with Magisk, but is there a way to intentionally cause loss of root? I'm just curious because I'd like to do some experiments.
[Magisk] FlintStoned-:
Hi [MENTION=4470081]topjohnwu[/MENTION],

Would a fix for Sony xperia be possible? When running 11.1 it crashes almost instantly when using phone. No problem with this on 10.2.

Kind regards,

Flint
[Magisk] Robot76:
I have no crashes with 11.1 on Xperia z3c

Magisk so far is flawless on my Xperia...

CarbonROM 7.1.1 and on SLiMM
[Magisk] Artim_96:
Well, only if an app ticked on the Magisk hide tab is open since Magisk hides the modules by unmounting them before the app can detect it
[Magisk] biggdevon:
What's your setup? Been trying to get pay working.
[Magisk] bunta126:
I see that xposed will fail SafetyNet checks even when installed as systemless module in magisk.

I have some modules that I require in Xposed however.

I don't understand entirely what the difference is between xposed and magisk (don't they both just modify system files?) but I would expect magisk can do everything xposed can do.

Is that right, and if so how do I port an xposed module to work in magisk so I don't need to install xposed and break safetynet?
[Magisk] 101_North:
LGG3 D855, LineageOS 20170213-Nightly, Unofficial Magisk v12 170217 / Unofficial Magisk Manager v5. Magisk hide enabled, systemless hosts enabled and busybox disabled.

I had to install the fix from here to get Android Pay working on my device due to a problem with the LineageOS NFC driver.
[Magisk] Captain_Throwback:
You have it all wrong. You really need to read up on what Magisk is all about. Hint: Start with the link in the OP.
[Magisk] Artim_96:
Oh Jesus, you really don't know anything about both. Maybe you should use neither since you are not able to even read the OPs.

In short: XPosed is made to modify the Java written code of every app in Android in terms of look and functions. It has to extremely modify the system to be able to work. That's why the systemless version can't just be unmounted like Magisk does it with root.

Magisk is just made to manipulate files in the system partition (which basically just means adding or replacing them with some simple tools to edit build.prop and run some scripts on startup), without really touching the system partition. So you could replace system apps with modified versions, but for that you still need to decompile, translate, modify, recompile and sign every single app, you can't just change them "on the fly"
[Magisk] bunta126:
Actually, I basically had it right for Magisk, what I had wrong was what Xposed does.

Thanks, that clears things up.

I knew I needed those products for the functions they were providing but hadn't really investigated how they were doing their jobs other than that they were manipulating other files.

So theoretically, if I was using an Xposed module that was editing a system file (such as core.jar or framework.jar) that could potentially be ported to Magisk?

Although I expect Xposed will be able to edit that jar dynamically whereas magisk would only be able to replace the file with one that has been pre-modified?

Have I got the theory right?
[Magisk] chas123:
The issue on the ZTE Axon 7 is that the su binary is not being installed (neither is the Magisk apk stub). I suspect this is the problem for all those who are installing and seeing the 'rooted but no permission' on the status screen.
[Magisk] teddy0209:
You really have to read mate... there is a system xposed and systemless xposed... xposed for magisk is systemless and no need to port any xposed module to magisk as magisk has its own xposed. ???
[Magisk] bunta126:
Maybe you need to read, the whole point is that Xposed breaks SafetyNet checks so I want to port some functionality into Magisk without using Xposed.
[Magisk] teddy0209:
Oh... sorry about that!... That's actually interesting, kindly share it if you manage to do so... ?
[Magisk] iubjaved:
If you mean you want to unroot, use unSU script.
[Magisk] topjohnwu:
Regarding the Xposed talk, I do have something in mind that should behave similar to Xposed.

As you may know, Xposed can be seen as "Code Injector", while Magisk is "File Injector". I have a concept that should behave as code injector, but it's still only a concept. It will take a long time for me to do some study and research. It's just something I find interesting.

However, I'll have to stabilize Magisk before I branch out to too many stuffs lol
[Magisk] montenell:
Whenever I flash the latest magisk my phone bootloops to recovery
[Magisk] kerbiii:
thnx for this info i really need to know this ?
[Magisk] FlintStoned-:
Hey man thanks for the reply. I do think it's xposed that is causing it, did you had that running while using 11.1 on slimm? I'm using latest systemless v87
[Magisk] Robot76:
Oops, I did write SLiMM, my bad!, I haven't used 11.1 on SLiMM...[emoji16] I was only focused on the word Magisk...

**I'm on a roll of terrible posts...
[Magisk] kartikb:
Hi, will you be remaking the v4a module? The current one always puts my stock nexus 6p 7.1.1 on Magisk v11.1 into bootloop but works fine with Magisk v10.2.

Any help would be great..

Thanks ?
[Magisk] Apollo-74:
Same problem, help pls.
[Magisk] bunta126:
I'd like to work on a solution to my immediate requirement while you are working on the Xposed functionality.

I'm not sure if it's possible if Xposed is injecting code on the fly, but if I could copy off the modified system jar files that it creates I expect I could use those to create a "file inection" module with Magisk, eliminating my need for Xposed.

Do you have any reference material for how to create Magisk (and Xposed) modules so I can determine how it all works?

I might need some assistance as I work through things, but I'm fully capable of working things out on my own with some references to help.

(I also have an Xposed module that no longer works so if there is some reference material that will let me reverse engineer it to fix it that would be very handy)
[Magisk] Didgeridoohan:
The Magisk All-In-One Wiki have good information on how to make a Magisk module. Creating a module that replaces a system app or file with a modified version is quite straightforward.

Modifying an app or system file though, that's a whole different story. I'd say you should head over to the Xposed and Xposed Development forums and see if you can find something there.
[Magisk] lostreal:
Is there a way to grant root authority to the LineageOS file manager with Magisk?

LineageOS 14.1 Official Nightly

Magisk v11.1 and MagiskSU

Magisk Manager 4.2.6
[Magisk] BigMacca:
I did think it was odd at the time :)

I've opened a log on GitHub - Fingers crossed [MENTION=4470081]topjohnwu[/MENTION] can crush it !

Thanks for your help

Macca
[Magisk] yochananmarqos:
As another user found out, symlinking the su binary to where the CM / LOS File Manager is looking for it works:

ln -s /sbin/su /system/xbin/su
[Magisk] leolawliet:
Hey guys, remember that [MENTION=4470081]topjohnwu[/MENTION] can't squash the bugs that are present unless we provide logs. I know he'll be grateful for the cooperation and it helps everyone on the long run. It's better than complaining and not having anything to back you up.
[Magisk] tag68:
It makes no sense to me running a system like Magisk to keep system partition untouched, and then directly create a symlink altering system partition. Did I miss something? Is there some mount I'm not aware of, making this link managed by Magisk?
[Magisk] Nomelas:
You could probably make a module for it :)
[Magisk] reis1996:
Flashed the uninstaller on a phone (micromax a311) it bricked the phone. Can't boot up its stuck. The uninstaller wouldn't finish so I force shut down by pressing power. Phone is spoilt because of magisk. Black screen comes n it goes off thats it
[Magisk] jhedfors:
Just restore your backed-up boot partition. It takes just a second to flash.
[Magisk] lostreal:
Is there no other way?
[Magisk] yochananmarqos:
Not that I know of other than Lineage updating the File Manager. The su path is hardcoded.
[Magisk] jhedfors:
I have tried to respond to your PM's, but they keep disappearing...

Do you have TWRP installed, and can you boot into recovery? If you don't have a backup (you only need the boot partition), TWRP allows you to flash an image instead of zip, and the boot.IMG can be found in your ROM's zip.
[Magisk] jcrompton:
Magisk and AOSP ROMs for SamsungGalaxy S7 Edge

I'm hoping that someone here can help me ,,, by directing me in the right direction ,,,, to help the AOSP type ROMs for the SM-935F S7 Edge. As I have posted here several times in the last few days .... Magisk and Magisk Hide works wonderfully on the stock based Samsung ROMs that are out there for this device (so it's not completely "device incompatibility").

For the non stock ROMs ,,, Magisk is working for root but Magisk Hide seems to not be functioning fully or properly. SafetyNet takes for ever to finally give red error and Google Play services keeps Force closing after enabling Magisk Hide

So basically it's only partial funtionality

Can anyone lead me to steps that might help me to fix this or at least tell the ROM/kernel developer guys what might be needed

My logs are posted a page or 3 back

THANKS!!
[Magisk] Captain_Throwback:
I have the same problem on my M8.
[Magisk] jcrompton:
oh CRAP

so coming from you .... does that mean there is no solution ?? That will suck since I love my newly acquired S7 Edge but NOT so fond of the TW Sammy ROMs --- would much prefer AOSP

So is the problem with the kernel? Or is it something that could be eventually solved on the the Magisk side of things ?
[Magisk] bigeddthemonk:
Kept failing safety net. Spent about an hour uninstalling things and getting creative. I forgot to disable adb debugging, lol. Good to go now
[Magisk] bunta126:
Terrific, that's perfect!
[Magisk] Telperion:
My Honor 8 doesn't yet have a fully functional TWRP on Nougat -- that is to say, it can't mount the /data partition. I do have root from flashing a phh superuser zip (SuperSU failed to install).

My conundrum is that the Magisk zip fails to install in TWRP, and fails to install after boot from the Magisk Manager. I figure my next move is to attempt to install it and set appropriate permissions using a root terminal or ADB root shell after the OS is booted. Can anyone give me details on how to do that? I've unpacked the update-binary but naturally it's designed to be fairly universal so there's a lot of code I may not need. I'd need things like where each file should go, boot image patching, etc.
[Magisk] Artim_96:
I doubt it's possible to patch the boot image from within the running system. Even manually in TWRP won't be possible, but I'd guess you wouldn't be able to access it in the system
[Magisk] Telperion:
True, but if I can modify the installation script to modify everything but /data, then I can write what needs to go in /data from a booted system. Or if I can modify the paths inside Magisk, Huawei uses another partition (/cust) which I could use instead of /data.

Not saying it's easy, but there's no telling when we'll get a fully functional TWRP so I'd like to try what I can in the mean time.
[Magisk] Artim_96:
Ah, wait, there are already modifications which let Magisk store is stuff somewhere else, e.g. because of (Motorla) devices with faulty f2fs handling. Maybe take a look into their forums, maybe someone made already what you need
[Magisk] Captain_Throwback:
Magisk should flash fine without access to /data - it stores the files in /cache as a temporary location unless /data is available. If it's not installing properly, then you need to post a recovery log.
[Magisk] Telperion:
That's what I'm trying now, like this:

https://xdaforums.com/htc-10/development/root-magisk-autoroot-magisk-phhs-t3507505

I used that method to extract my current boot image and patch it, but the modified boot image caused a boot loop so I had to reflash the stock boot image. Is there a current version of that tool for v11.1 or do I need to assemble one?
[Magisk] ryan42680:
deleted
[Magisk] Telperion:
Alright I found the problem, the Honor 8 kernel doesn't support loop mounts. Seeing as that seems to be a fairly fundamental piece of how Magisk works, am I SOL? Is there any way for Magisk to function without loop mounting?
[Magisk] lalitjoshi06:
I m using mokee ROM 7.1 for my le2. Same problem cts mismatch. With Google saftynet it says basic integrity true but CTS false.

On stock ROM it was working but with this mokee custom ROM or I tried so many other custom ROM.

Same problem always CTS false.

Someone pls help.
[Magisk] Didgeridoohan:
That means the ROM makes it so that your device is no longer recognized as a Google certified android device. I have no idea if or how it's fixable (never looked into this issue)... Could be that you need to find a ROM that's closer to stock.
[Magisk] littlenux:
WARNING: linker: su: unused DT entry

hi, i want to ask about new update 11.1

every time use su command in terminal, get this message :

u0_a113@libra:/ $ su

WARNING: linker: su: unused DT entry: type 0x6ffffffe arg 0x1c20

WARNING: linker: su: unused DT entry: type 0x6fffffff arg 0x1.

never get this message in version 10.2

my device mi5s plus, rom miui 8.2 stable, recovery twrp 3.0.2

already try flash fastboot stock rom then flash magisk but still su message appear.

thanks
[Magisk] Artim_96:
No. That is just THE fundamental part of Magisk, that's how it mounts the stuff from Magisk.img over the system partition. Seems that you need a custom kernel
[Magisk] dagoban:
Same here, Magisk 11.1 + Titanium Backup doesn't work.

TB still gets full root access and doesn't show any errors, but backup / restore / freeze doesn't work at all but worked with 10.2

Moto X 1st gen

---------- Post added at 11:59 ---------- Previous post was at 11:56 ----------

Also Magisk Hide has never worked on my phone, did everything as explained, stock image, TWRP + Magisk Manager systemless xposed.

Safety net passes after TWRP install

after I install Magisk I already get safety net error.

Moto X 1st gen Android 5.1 (latest official release)