yashsingh1/xdaforums huggingface dataset:
[Magisk] zgfg:
Google Play (aka Playstore), Settings, About, down at the bottom - as on the screenshot

But you mention MicroG, maybe you don't use Playstore

Generally it requires that you pass SafetyNet, do you

Anyway, I cannot tell you anything more about spoofing Device certification (and SafetyNet API) with MicroG (I'm using GApps, never played with MicroG)
[Magisk] pndwal:
👍

You would know if you did... It's set in Magisk App settings...

Yes.

If needed, however, assuming root functions enough (it's not clear) and you see Direct Install option, take that.

No, but there have been some 65 commits (read changes, fixes) since 24.3, and last Canary built some 58. So odds are favourable...

You can just delete w/ latest Canary installed (from a root explorer if your setup allows it), don't remove the app (of daemon will try to install stub app on reboot), then reboot and Magisk Daemon will rebuild database & config files in /data/and...

Last resort... Better to open an issue ticket on GitHub for this, but will require patience and perseverance...

Good sign... Do root apps work / ask for grant root access?

👍 PW
[Magisk] pndwal:
As mentioned above, but if not certified, clearing Play Store data should fix it as long as SafetyNet fully passes.

Very likely... MiroG is a whole different animal when it comes to passing Safety net...

I've never used MicroG (I like some of the rationale behind this, Duval's /e/ OS etc however) and can't help with fine points, but what I do know will likely help.

MicroG was passing SafetyNet (with some special configuration), before June 2019 when Google apparently made changes to DroidGuard and the attestation failed again for the next 2+ years.

3 months ago Devs fixed this again in new microG GmsCore 0.2.23.214816...

So you'll need a ROM updated with a very recent version of this component, and likely some other special considerations. See this:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86481921

Well, bank apps that require SafetyNet pass effectively require attestation to TEE through a Google server since SafetyNet API is part of Google Play Services. This means that your OS must necessarily include Google Play Services / Google Mobile Services (GMS); you CANNOT have a truly Google-free (ie. free of G proprietary code) phone w/ most bank apps working! 😝

Also, since this is a cryptographically-signed attestation (bound to a 16 byte variable nounce provided by the caller app) to the device's integrity, it can't be spoofed. What we currently have to bypass proper attestation is a loophole we can exploit where certain mismatched props etc cause a fallback to a basic evaluation type for key attestation, but the signed attestations received are still genuine ones from a Google server... Some light reading:

https://developer.android.com/training/safetynet/attestation

... more?:

https://developer.android.com/training/articles/security-key-attestation

👀 PW
[Magisk] Khiem Ba:
Hi, I'm using redmi k30 pro with the lastest miui.eu 13 rom

For some reason I can't install unoff TWRP (can't mount storage, tried a lot but I just can't fix it), so I installed Magisk by patching boot.img, I installed successfully but I thought I wasn't (silly me). Then I got an idea: I copied the patched boot.img and REPLACED THE ORIGINAL FILE FROM THE ROM INSTALLER, then I reinstall the rom again. The rom with magisk work very well but now I realize my device can't be recognized in fastboot mode (there is a "connected sound" but no device code after typing "fastboot devices" command, same happen in mi_flash). Basically I will stuck forever with this miui.eu rom, how to get out of this, can my device be OTA updated in future?

Many thanks!

PS: If I lucky enough in the next OTA update there is a check file integrity process, hope miui automatically fix it for me lol :)))
[Magisk] J.Michael:
My first thought is that a factory reset will put you back to where you started, before you first installed Magisk.

DO NOT FACTORY RESET until you hear from somebody else.

I do not understand the significance of "copied the patched boot.img and REPLACED THE ORIGINAL FILE FROM THE ROM INSTALLER, then I reinstall the rom again." If you originally extracted the boot.img from the full-ROM file, patched the boot.img, then either shoved the patched boot.img back into the full-ROM file, replacing the original boot.img; or extracted all files from full-ROM, replaced boot.img with patched-boot.img, and then built a new patched-full-ROM -- I don't see how anything changed between the time you installed the patched-boot.img and the time you installed a patched-full-ROM.

I do not think it will help you, but I would like to understand why you think *that* is where you went wrong.
[Magisk] zgfg:
Some reason = the fact that TWRP still does not support A12, and exactly bcs it doesn't support yet the new Data encryption.

It's not specific to your K30

And that's the reason why Xiaomi.eu distributes MiUI 13/A12 ROMs as Fastboot ROMs, not Recovery ROMs

(Recovery ROMs would require TWRP to install - stock Recovery does not recognize their custom ROM - but for the reason as above, appropriate custom recoveries are not available, hence they switched to the Fastboot ROMs that must be flashed through Fastboot)

----

Since you messed up your Fastboot, and you cannot flash (either Xiaomi eu or stock) any other way than through Fastboot, I'm really out of the ideas what could you do now

Except the well known, seek for the authorized EDL support
[Magisk] Khiem Ba:
Sorry for misunderstanding, firstly I extract rom zip file to install and there is a boot.img inside install folder, then i replace with a patcher boot_patched.img (renamed to boot.img) from magisk then reinstall the rom. So basically when I uninstall magisk, if I click to the "restore image" promt there is no change bcs my saved image is the patched img. I know I made a big mistake.
[Magisk] Khiem Ba:
To install my rom simply go to fastboot then run the .bat file. Ya I should not mentioned TWRP bcs it's unrelevant to my question, my bad. Thanks for the EDL suggestion.
[Magisk] zgfg:
Yeah, I know how you install Xiaomi.eu Fastboot ROM A12 but I have no idea how could you fix your Fastboot now

But are you really sure that it's bcs how you flashed - since your system boots (and Magisk works with that patched boot img)

Maybe it's all about the USB cable or drivers.

Does adb work - adb devices?

Did you try Fastboot from another PC
[Magisk] Khiem Ba:
Ya checked all driver and cable issue, I installed many roms smoothly with my setup before. System play a "connected sound" but there is no adb device detected.
[Magisk] zgfg:
Previously you said that fastboot does not recognize your device

Now you say adb doesn't work either?!

Btw, did you check Developer menu/options, is USB debugging enabled?

If yes, and if cables and drivers are ok, then adb must work

For fastboot check also in Developer options if OEM unlocking is enabled
[Magisk] mingkee:
Again, do those subscription based streaming app (Netflix, Amazon, Discovery+, cable TV) work with rooted A12?

Now I have Edge 2021 reverted to A11 due to playback issues
[Magisk] pndwal:
re. Redmi K30 Pro/POCO F2 Pro (lmi) on MIUI.eu 13 custom.

Are you saying you can put the phone onto fastboot mode (have fastboot splash screen), but just can't connect? Did you ever use fastboot w/ this device on Android 12? ... (And can you still boot into TWRP?)

If this is the case, something in my next post may help you get a connection... It will likely be the last point re. universal drivers for A11+. (As mentioned, TWRP will probably not help with Android 12 ATM.) PW
[Magisk] pndwal:
@Khiem Ba:

Seems you may have a fastboot driver / connection issue... (ADB and Fastboot drivers / setup are different.)

Traditional fixes:

A common issue: USB 3 doesn't work (ever?) - you need to use a USB 2 PC or hub connection... Some poor quality data or charging-only cables won't work either...

Assuming you have disabled signature verification in Windows 10 you can also try setting up drivers again. Connect your phone in fastboot mode & open Device Manager on Windows & look for Other > Android device. If found, fastboot driver is not set up properly... Find bootloader device update driver and install...

You can also try this (for Xiaomi devices): Download Mi Unlock Tool, extract the files, run MiUsbDriver.exe to install the driver.

And some users, after checking in Windows updates, found they needed to select 'Android boot' driver update in "other" updates to get working fastboot.

Android 11+

Since Android 11 there are apparently no more vendor specific drivers needed (since they are unified in Google's Android universal drivers).

You may need to install the updated universal Android ABD/Fastboot drivers. (Apparently there is no need to disable Windows signature verification for this now.)

👀 PW
[Magisk] Khiem Ba:
ADB is detected but not fastboot

Accidentally connected in my friend latop, then same as my lap, I have no idea what happend, guest there is some change in boot.img that lead to connection issue but the system solved itself lol, I have been flashing in the same setup in a year but this is the first time I saw this. Thanks for your answer anyway
[Magisk] pndwal:
Still pretty unclear to me... Please say plainly, can you boot to Fastboot screen? Did you ever have fastboot working on this device since update to Android 12? ...

Also what do you mean "guest there is some change in boot.img that lead to connection issue but the system solved itself lol"... Do you mean current issue, or an earlier one?... and what "solved itself"... did fastboot 'come back'??... 🤔 PW
[Magisk] Khiem Ba:
everything back to normal when I plug my device to my friend's laptop (same when I plug back into mine), also the common TWRP mount storage issue in android 12 also automatically solved without red code, we both don't know what is going on, his laptop is magic somehow @@
[Magisk] F308:
I am not deep in the subject but such things happen when you have any sort of protection software, antivirus or other blocker, and he does not.

It's of course only one of many possible reasons.
[Magisk] pndwal:
Guessing you mean 'false alarm - fastboot was never corrupted and is working' and also 'mount storage in TWRP is fine too thanks to a magic PC'!? ... Well I hope so... 😛 PW
[Magisk] Oswald Boelcke:
Off-topic posts removed from this Magisk thread.

Regards

Oswald Boelcke
[Magisk] wfred:
The bootlocker startup warning is the price you pay for rooting.

Open magisk>go to settings (gear in upper right)

Hide/rename magisk

Turn on zygisk

install universal safeynet module

Turn on enforce deny

Open configure deny

Select the apps you need to hide root

(There will be some reboots during this)

should take care of it
[Magisk] pogo-airsupport:
Anyone running into issues with Magisk and LSPosed Zygisk on Android 13 public beta 1?

Doesn't seem to even run
[Magisk] Galaxiez:
I'm using this app which basically replaces the stock emojis. What's up with the error when I try to flash the module?
[Magisk] martyfender:
Try v1.8.3 with Android 13 compatibility.
[Magisk] Peter0x44:
Trying the "canary" build downloaded from github actions worked! I'm no longer prompted to reboot every time I open magisk, and all apps requesting superuser permissions seem to work correctly.

I guess it must be a bug in the release that was fixed later.

Even though I think I possess enough patience (after all, I have enough to put up with this decade old phone...), I'm still glad I didn't have to do this.

Thanks for your support, even though the solution seems a bit painfully obvious now. I definitely wouldn't have thought of it on my own.

One last thing I'd like to clarify, if I ever flash the rom again, due to an update for instance, I will need to follow this same process to install magisk again, right?
[Magisk] pndwal:
Hot off the press is 1.8.3-6538...

## Supported Versions

Android 8.1 ~ 13 Beta 1

https://github.com/LSPosed/LSPosed/actions/runs/2231949337

(You'll need a GitHub account for this (easy 🙂), or get from TG... PW
[Magisk] pndwal:
Is it an app, module or both?...

May be quite old (I'm guessing here)... Are you running Android 11+?

Usually in Android 11+ magisk tmpfs mount path is no longer /sbin. That was the usual path previously... Type:

su

magisk --path

in terminal emulator to check path; that's where you should find .magisk/busybox and those files, and where your module should point for busybox... PW
[Magisk] pndwal:
Great!...

Seems you may have an even later test build than Canary release I meant... Which actions build did you use? ... I'm guessing Canary (from Magisk main GitHub page, Downloads) would work too...

Yup; scores of fixes since as I think I mentioned...

Some are test runs in unofficial forks linked in actions, others in actions are John's own commit tests. These are to be considered essential untested however, and can be downloaded immediately after they are built w/ GitHub account.

Next, John releases debug Canary builds quite frequently compared to public Beta / Stable... These may be a few weeks old, but have undergone some minimal testing. No account needed however.

My pleasure...

Yup; after LOS full ROM flash images will be returned to 'stock' (unpatched)... You'll need to do initial patch / flash again.

Meanwhile you should have no issues taking Direct Install option for Magisk updates as you'll have root. (Nb. as you have a test run build, even with Canary Channel set you will likely be downgrading until a new Canary is released.)... 😛 PW
[Magisk] Peter0x44:
I downloaded what seemed to be the latest available one on github actions, it is 134508193dc1c0416fbd7141fb66d4202658a33b.zip

I think it corresponds to the same commit, "Mock selinuxfs load with regular file"

The one I first downloaded that didn't work, was on the releases page, here:

Release Magisk v24.3 · topjohnwu/Magisk

For those coming from v24.1, check the full changelog for changes introduced in v24.2. [General] Stop using getrandom syscall [Zygisk] Update API to v3, adding new fields to AppSpecializeArgs [App...

github.com

Thanks. Also, through flashing the rom, all of my apps data, etc should still remain?

Altogether, for my first experience with android root and custom roms, this was both less and more painful than I expected. Thanks to everyone helping, otherwise I would have no useful phone at all!

It's nice to know the support of my device basically ends with me.
[Magisk] pndwal:
Ah... At least this actions run builds official TJW master branch (11 days old)... Later ones build vvb2060, Shana, Rikka and other unofficial forks...

Latest Canary is v24306 (19 days old). Need Canary apk from Magisk main page for that as I said..

But this is latest public build, (not debug Canary 😜) - 49 days old!...

Flashing ROM is not part of Magisk's scope, but basically a 'dirty' flash retains data, 'clean' flash means a full data wipe...

Magisk data (settings - denylist, superuser list etc, modules...) is retained during dirty flashing and magisk updates even if Magisk app is uninstalled as Magisk data is in /data/adb rather than in app data. PW
[Magisk] Peter0x44:
OK, well this build should be able to automatically update to the new canary when it releases, right? Is there a good reason to change the build right now, considering everything seems to be working OK?

I need to make sure I do a dirty flash from twrp then, I think I understand.

I shouldn't have to do this too soon though, I would think.
[Magisk] pndwal:
Automatic Update alert anyway if Canary channel is set... And I believe it should jgo fine when you take it...

No... unless curiosity is a good reason! 😜...

Yup; don't do data wipes / factory reset / format data... Generally you just flash. PW
[Magisk] PokeRekoP:
Magisk Canary 24306 misbehaving. Common problem maybe, but too many hits about "additional setup" to find the tree in the woods.

Samsung S10+ with a recent A12 stock-based rom ("Beyond rom"), freshly installed, magisk patched AP and recovery etc.

I reboot (pressing the magic key combo Bixby+VolUp until phone comes on and goes "brrr"), and get into the booted rom just fine. Open Magisk Manager app.

Several issues:

1) "additiona setup" over and over without anything happening: It shows Magisk installed (24304) and asks permission to do the "additional setup". I press OK. I seem to remember (it's been a while since I last did this stuff; guess Magisk 22 or something was the last I used) that usually it then just gives a smaller message about doing things, and then goes to a reboot countdown of 5secs, and then reboots automatically. Not so here. It goes to the screen where one can install magisk itself (i.e. where you select "recovery mode", "next step", "direct installation", "let's go". IS this how it should be with these most recent versions?

Anyway, tried the magisk re-install through that screen, but doesn't change anything after next reboot.

I tried flashing the latest canary apk (24306 I believe) in twrp directly (renamed to zip of course). Also no change in behaviour.

2) Magisk manager shows 24304 for Magisk, and 24306 for the App. I pre-patched the rom yesterday on a 2nd device (when mine was "sick" ;-) ), maybe got a different latest canary there yesterday.

3) The Superuser List is empty in Magisk Manager, even though I have granted SU to several apps.

What am I doing wrong?
[Magisk] J.Michael:
I think maybe stop beating on Magisk and focus on the Manager app.

Maybe the Manager app has the wrong update channel.

Do you have wi-fi enabled when you tell it to go ahead and do the additional setup?

Or maybe you were right to question the installation of Magisk. If you patched AP with 24306 and the app reports Magisk is 24304, it looks like it didn't take. Was your first installation via Odin? Did you make sure to go directly from the download screen to recovery to wipe data?

Try installing unpatched ROM. When you boot, do you already have a Magisk Manager app? Does it already say Magisk 24304 is installed?

If you don't already have a Magisk Manager app, install just an app, then check if it says Magisk is already installed.
[Magisk] rodken:
I encountered the same exact issue until I reverted back to a earlier build [possibly a build in mid-March] and performed the update from that build.
[Magisk] pndwal:
You have this issue, marked as regression but not yet fixed:

https://github.com/topjohnwu/Magisk/issues/5673

- Likely it's from recent major sepolicy changes...

Suggest you read / watch that thread, perhaps help with a fix... Canyie has just started working on a proper fix...

Direct install is broken w/ recovery mode for these Galaxy S10, S5 series Sammy devices.

Initial patch/ flash method is working, so you can work-around by repatching AP tar...then flash Flash AP + BL + CP + HOME_CSC together per official instructions...

👀 PW
[Magisk] zgfg:
It looks exactly like the same issue that has been stretched out through the couple of pages before your post, as reported by @Swordfishx86 and by @pndwal who was helping him

EDITED:

I removed mentioning the case reported by @Peter0x44 - his issue was differenrt (my mistake)
[Magisk] pndwal:
Yup.

His is different; not using Magisk in recovery mode... PW
[Magisk] Peter0x44:
I believe my issue was in fact not related to the open one, it only applies to much newer devices than mine. Though, it did exhibit very similar symptoms, so they seemed related.

Mine has been fixed in canary versions, as discussed above. I presume since that issue is not yet closed, that it hasn't been fixed, canary or not.
[Magisk] PokeRekoP:
@rodgen, @pndwal, @zgfg thanks for your responses.

I saw the exchange on Peter0x44's problem but didn't get that on Swordfishx86's then.

In the exchange on the latter pndwal says:

I've read that thread, and will watch it, but can't contribute anything that isn't there already (lack of skills...).

Re the last line bold-itallic (I marked that) part:

The instructions for my rom say to:

1) patch stock AP with canary magisk (done)

2) patch latest twrp.img with canary magisk

3) *substitute* the stock recovery.img *inside* that patched AP with the patched twrp.img

(actually, as there's recovery.img.lz4 in AP, I lz4'ed the patched twrp.img (after renaming it to recovery.img of course).

4) Odin-flash patched stock AP, BL, CP, HOME_CSC

5) Reboot into TWRP

6) flash multi-disabler and then the actual custom rom and reboot again to recovery (so that magisk is activated)

If I wouldn't "mess with discrete recovery img" (skip 2+3), I will have stock recovery, right? IS doing the extra twrp-patch+injection into patched AP okay with respect to "our" problem of the regression-affected canary magisk? Or can we only work around the issue if we stick to "stock" recovery in patched AP?

About to re-flash it all - once I know I can keep my twrp (who can live without that ;-) )
[Magisk] m0han:
screenshot from 'lsposed' channel on telegram
[Magisk] pndwal:
Well, that was a comment to @Swordfishx86 to indicate that he should simply patch the AP binary he has, and flash all binaries rather than discreet images as is done for non-Sammy devices... He hadn't mentioned TWRP; just asked:

The mportant thing is - Direct install is broken for your device, but initial install (patch / flash) is not.

In the case of TWRP + Magisk in recovery partition on A-only SAR Samsung, you may well be able to patch TWRP.img before swapping out stock recovery for this in AP binary. Those instructions likely work but may be over complicated...

It's worth noting that many customised methods of installing Magisk were evolved as installation wouldn't work without the likes of multi-disabler etc... Magisk has come a long way, and John / others have added a number of Samsung specific compatibility fixes... I'm not sure that the method you found can't be simplified. Eg official method for this from TWRP.me is simply -

1) Root device with Magisk

2) Pre-root a TWRP image before flashing it to recovery.

It further notes:

https://twrp.me/samsung/samsunggalaxys10plus.html

I'm guessing -

1) Substitute the stock recovery.img inside AP (unpatched) with twrp.img (unpatched).

2) Patch this customised AP with Magisk

3) Odin-flash patched AP, BL, CP, HOME_CSC

may also work, but I have absolutely no evidence that even swapping out images can be done, and I may well be missing something vital! 😝 ... Usually it's best to follow official methods...

Please note I've only ever had old legacy ramdisk Sammy, not SAR... Please do your due diligence... 😛 PW
[Magisk] J.Michael:
@PokeRekoP I especially liked @pndwal's suggestion that you replace the "recovery.img" in the original AP with "twrp.img renamed to recovery.img" before using Magisk to patch AP.

I wanted to add: I don't think compression is mandatory, or that it must be consistent, so long as you observe the naming conventions. So, if the stock AP contains "recovery.img.lz4" and you have a "twrp.img", you do not need to compress the twrp image, you just need to delete the "recovery.img.lz4" from the AP.tar along with inserting the "twrp.img renamed to recovery.img" into the AP.tar.
[Magisk] PokeRekoP:
"Naming convetion" - clear; recovery must be called recovery.

I also like that suggestion of injecting twrp.img (renamed as recovery.img) and then patch the pre-injected AP in one go. Only... I'm not brave enough to flash the result afterwards to my baby. Rather do it in a few more steps known to work (at least not brick). Only bricks I like are those plastic ones with the "L..." on top of their studs...
[Magisk] J.Michael:
I meant to emphasize that the suffix ".lz4" should appear if and only if the file had been LZ4 compressed. (I can imagine some program ignoring the name and figuring out the presence or type of compression from the file contents, but why take a chance?)

I think the "patch in one go" is *less* likely to cause a problem. I get the impression more than one file within AP.tar is patched, and Wu may take the rest of the tar file into account when deciding how to patch recovery.img.

You could prepare both ways and see if there's any difference. (So could I. I probably won't.)