yashsingh1/xdaforums huggingface dataset:
[Magisk] VD171:
The README in MAGISK OFFCIAL WEBSITE is enough for expert and newbies.

See "Building and Development" section and good luck !

As @zgfg said, try to do the easy steps.

If you need more help, you need to find it by youself and not in general support thread.

Magisk Official Website:

GitHub - topjohnwu/Magisk: The Magic Mask for Android

The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.

github.com
[Magisk] dimm0k:
a little late now, but any idea how it differs than flashing using fastboot? would the android flash tool save me from wiping?
[Magisk] pndwal:
mmm; this is updated Magisk... 😄 It's only the new commits that may fix bugs / regressions introduced since your 24302... That's the point; you must update to profit!

If you are stuck on 'how', simply extract app-debug APK from zip archive in Artifacts and install / treat this like a Canary build.

Just be aware that such action run builds were available hot-of-the-press, untested, and may be more buggy that Canary releases which are in turn less tested than public Beta, in turn less tested than public Stable... In this case the build works / seems stable and is free of issues on my device... Of course your mileage may vary. 👍 PW

Edit: Log in to GitHub to download 'artifact' archives with action run builds. 👍
[Magisk] m0han:
just curious: is it only after logging in that one gets to see/download the 'zip archive'?
[Magisk] pndwal:
This may be where some confusion lies; Magisk DenyList DOES bypass root access; AFAIK! ... It will actually "revert all Magisk changes" incl. permissions and access...

Apart from reverting / preventing root access, which is actually enough for some 'hiding purposes', Magisk DenyList does NOT hide root access further... I think bypassing (circumventing, disabling) and hiding ('attempting to manipulate other signals on the device') are two different things.

In some cases, such as hiding root from Safetynet process, simply 'bypassing' may be enough for hiding purposes and John directly facilities this... But 'hiding' per his definition of 'attempting to manipulate other signals on the device' is what has been removed from Magisk and where he draws the line.

We should appreciate however that John has at the same time considerably improved the framework needed for other 'passionate' Devs to do presicely such 'hiding'. Pertinent comments from John:

www.twitter.com/topjohnwu/status/1445598597521633285

Please put me straight if I'm wrong... 🙃 PW
[Magisk] VD171:
Just click on its zip name.

Direct link for file you want: https://github.com/topjohnwu/Magisk/suites/5752238929/artifacts/191046703
[Magisk] VD171:
Magisk needs more than just reverting its own actions to hide itself.

Magisk can be detected even enforcing denylist.

Just it, my friend.

You don't need to write a new book to say same thing for every new reply.
[Magisk] pndwal:
Ok... It's hardly a new book but... And DenyList DOES bypass root access, no? PW
[Magisk] pndwal:
I can see it, but it doesn't work as a download link to zip archive when not logged in. 😉 PW
[Magisk] VD171:
That's so confusing now.

If you select any process to denylist, the process automatically never can gain root again.

I mean "bypassing" as any type of avoiding any type of detection.
[Magisk] VD171:
Really? I didn't know it.

Let me attach the desired file by @m0han

Md5sum: affaf897e5640aab3b4f0f1f311d74e8

Action #1625: Magisk Build

Commit #5620: Replace realpath to BSD implementation (by yujincheng08)

Artifact direct link: https://github.com/topjohnwu/Magisk/suites/5752238929/artifacts/191046703

Commit: https://github.com/topjohnwu/Magisk/commit/b1faa5eed4f5c52cc60a90ca74744a77fde07575

Pull: https://github.com/topjohnwu/Magisk/pull/5620

Action: https://github.com/topjohnwu/Magisk/actions/runs/2021986845
[Magisk] pndwal:
Exactly... But what you said was "Magisk DenyList does NOT bypass root access"... 😉 PW
[Magisk] m0han:
@pndwal, @VD171, fyi: page not found at https://github.com/topjohnwu/Magisk/suites/5752238929/artifacts/191046703. i suppose login is required to get the .zip file. @VD171, thanks for the attachment.
[Magisk] VD171:
I just said "bypassing root access" is like as "avoiding root detection".

Exactly speaking "bypassing root access" can be meant as root exploiting.

But in magisk context, bypassing root access, means hiding root.

Denying access to the root is not hiding the root.

If you deny root access, magisk keeps detectable.

If you want to hide magisk completely, you will need more than just denying root access or enforcing denylist.

There is nothing to discuss here, just disable the enforcing denylist, install Shamiko and everything is solved as a magic.
[Magisk] pndwal:
Not sure about Android Tiramisu (13 Developer Preview) issues, but:

It seems you just need to find correct means to hide root from that app (circumvent that 'authentication error') as per banking apps...

Basics: App in denylist, have Zygisk enabled, zy-USNF, zy-Shamiko, denylist NOT enforced, passing SafetyNet (check in YASNAC), Play Protect 'Device is certified' (check I Play Store settings, about)... Clear apps data AFTER all this... Likely missing Shamiko is your issue, but app may also use customised advanced detection needing further hiding...

Actually you are lucky you have normal camera operation with unlocked bootloader!... Some late Sammy devices launched with or updated to One UI 3 0S would disable the camera fully (read back screens / crashing apps) if bootloader was unlocked; they cited security w/ camera used for biometrics etc... Fortunately Samsung (like Sony earlier) ceased crippling the camera very recently with updates to their One UI 4 OS, so most Sammy custom modders now have camera back!

😜 PW
[Magisk] pndwal:
Well ok... But I'll take this as a new book / take on the subject! 😅

To me access is access, detection is detection...

Sure, I know this well... I only stated, like John, that 'denylist CAN be used for hiding purposes'. Period.

And this too... the first mentions / descriptions of Shamiko in this thread are mine after all... But you know it's no solve-all! You run a MIUI device... you must know everything is not solved... things may be solved with updates however, while hiding lasts...

We're largely on the same page. I just want to avert confusion when I try to be accurate... Truce! 🙂 PW
[Magisk] zgfg:
Yes, see my post, I wrote that you MUST have GitHub account (without acc you cannot login, and I assumed that if you have acc you will login🤣)

And I outlined you the whole process you asked for (saying also that bcs of diff signing keys you will have to uninstall your current Magisk app - not Magisk itself, etc)

But I said, it's not for newbies (ie not for those who would need additional questions🙂) because things may go wrong and then that one would certainly need additional help to recover - it's easier to wait for the next Magisk (Canary) that will include these fixes and that you can install as usual
[Magisk] pndwal:
Likely Magisk daemon didn't detect safe mode... Safe mode itself doesn't do anything; Magisk is just detecting user key combo input and this often fails; it's still an issue at least on Xiaomi devices:

https://github.com/topjohnwu/Magisk/issues/4624#issuecomment-1077747785

Even when safe mode properly boots modules are not disabled when this occurs. Fix for MIUI (possibly many more) devices is to hold down vol- well before animated icon/logo appears as I described in issue above.

If I'm right (and I may not be), modules would have been disabled after you flashed boot image, not before, as this will remove Magisk...

Guess you mean update didn't start?

If you can use official software to dirty flash

current

full ROM you should restore boot with data...

Issue booting is likely that Magisk has altered more partitions than boot.img on your late device to gain root... So you may also need vbmeta, vendor, or other partitions restored in your case...

If you can't access proper flashing modes, an EDL mode may work or Pixel users / threads will likely be of more help!... I've never had one. 🤠 PW
[Magisk] m0han:
all i wrote was:

just curious: is it only after logging in that one gets to see/download the 'zip archive'?

and off you go, bending over backwards to 'help'. thanks for that. for all practical purposes, the issue was closed here: https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86638821. and, i believe both @pndwal and @VD171 acknowledge that. don't forget, other 'newbies' have also asked about that 'actions'. but, all said and done, your enthusiasm is top-notch. keep it up.
[Magisk] pndwal:
Ok, LOS 18.1, Android 11...

Guessing you came from 23.0? - not clear...

Yes, a number of issues have been fixed for Sammy since that, and I've mentioned a number here...

Not clear if you mean you got to 24.3 from 24.0 using patch / flash boot image method...

If not, I suggest you try Canary 24303 which has many fixes...

Canary 24304 seems to be buggy across the board. FWIW, Some (all?) of these issues are fixed in this later experimental build but are still downstream of any official builds as yet:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86619257

🤠 PW
[Magisk] fubo73:
I was running LOS and magisk 24.3 regularly. I came to 24.3 by updating using magisk app, and no issue so far.

Then I updated twrp from to latest flashing img package in recovery, and system didn't boot anymore, stuck in download page. Old story, I needed to use odin to restore BL partition. System restarted, but magisk was not running (another old story, sometimes update of ROM from settings does not inject back magisk). So I wanted to flash 24.3 by twrp and got the error.

Initially I believed that latest twrp has issues, so I tested previous release of twrp and got same error.

Then I tried to flash magisk 24.0. It worked flawlessly. I rebooted, opened the app and updated from there both app and magisk. Now everything is up and running, but for me the latest 24.3 zip install has a regression compared to 24.0.
[Magisk] zgfg:
NP. If play with that and then later cry how to go back to official, how to fix this and that, etc

All instructions anybody needs was alao in my response, however, users who tweak their phones with Magisk and want to go even deeper to unofficial Actions build must be willing and capable to learn and experiment themselves, and to find answers through the already posted posts. Same things cannot be hundreds of times repeated

Even if exact abcxyz case was not covered in the previous posts, then also by googling and trying to find answers on the Net.

All that is the only way to grew up from a newbie to an experienced user - otherwise it makes no sense to keep staying a newbie after playing for months with the Magisk
[Magisk] pndwal:
But he's clearly not a newbie modder! ... Maybe newbie on GitHub? - He just asked me for one confirmation. 😜
[Magisk] zgfg:
In the original question yesterday, when he asked first time how to use Actions build, he said he was a newbie. In my original answer (where the while procedure was already described in short, incl. also the need to have GitHub acc) I kindly advised that for newbies is better to wait for the next Magisk (Canary) that will include the fix, without all the complications to switch from official to Actions and later back (that requires uninstalling the previous bcs of diff signatures and potentialy turning of Play Protect when switching to Actions)
[Magisk] traversone:
..same story at my end, LOS 18.1 on Samsung S4.

edit: Magisk-b1faa5ee(24304) test release solves this issue (again, thanks to PW)
[Magisk] pndwal:
Yup, saw that... the self-confessed 'Newbie' was asking me specifically how to 'install actions without updating magisk'! 😄... Just wasn't @m0han...

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86636409 😜 PW
[Magisk] m0han:
afaik, people don't 'play' with magisk and then 'cry'. asking for help is not crying. ignore, rather than 'repeat' and trumpet that. everyone starts a 'newbie', but nobody would want to 'keep staying a newbie'. sad to see you're on a cautioning/admonishing/rubbishing spree. peace, dear 'fellow user'. wish you a nice weekend.
[Magisk] m0han:
had some free time, so.... cts profile match is still snafu, ofc.
[Magisk] xunholyx:
I've scrolled back and have seen the bootloop issue with the latest Canary. Being tied to music modules isn't the problem for me. I have none and still bootlooped when updating Canary. This is on a Pixel 5 Android 13 DP1.

Flashing the last patched boot.img from DP1 fixed it and rolled me back to Magisk v24102

I then patched the boot.img from DP2 and edited my flash-all.bat to not wipe and not reboot and flash vbmeta disabling verity and verification, then flash the patched boot.img I made with v24102.

I bootlooped again. Flashing the patched .img from DP1 fixed it. That surprised me because I've never had an issue with that version until now.

This post is both to see if anyone knows what's going on with that, and also as a guide to fix it for anyone else who's on Android 13 DP2
[Magisk] pndwal:
Might want to try this:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86619257

I think Proper support multiple modules adding same dir does the trick for me... PW
[Magisk] xunholyx:
Yeah, but the thing is I don't have any audio modules as stated in my original post. Both of these links lead me to posts about audio mods.

Also, even after reverting to v24102 by flashing my previous patched boot.img I got the bootloop again.
[Magisk] TheOTO:
Have issue when updating to the latest canary build. I flash in magisk app then reboot but it gets stuck on splash screen. Device is OnePlus 5T. Here are some logs. Let me know if you need more. Thanks.
[Magisk] klemi71:
Does restart in safe mode help?

After that you could reenable modules step by step to check if it's caused by an incompatible module.

To avoid trouble, you could install this module at first (screenshot).
[Magisk] zgfg:
Btw, today I decided to test the Artifacts, took the latest build as of today (screenshot) and tried on both my Xiaomi phones

Confirming, all my audio modes that I used on one or another phone (V4A, AML, 320 kbps, JamesDSP) work again with the latest fixes from master

As expected, I had to uninstall my old Magisk Canary app and switch off Play Protect to be able to install debug APK 24304 from the Artifact zip

And a question - did you try to Hide that Artifacts app?

I'm wondering since the download zip contains also the stub apk - but I'm not sure how could I submit that stub while hiding
[Magisk] pndwal:
Yup, hide app works fine... artifacts is like GitHub repo; contains stub but you don't need it... Stub is called via Json if online, and stub built into .apk is now used if offline. It hasn't been touched anyway; still v27. PW
[Magisk] pndwal:
You may have different multiple modules that add the same dir., so basic bootloop regression may be fixed...

Your DP2 issue is not clear to me:

So kernel for DP2 here... You did also update system to DP2 at this point too right?!... either full ROM dirty flash or OTA after restoring all images to stock DP1?... You don't say... 😬...

You mean you had to downgrade system (flash DP1 ROM) also to fix?... or were we always on DP1???

...no surprise if you were on DP1 with DP2 kernel before this as your description indicates. 🙃

Please fill in the gaps, but, unless you actually flashed DP2 ROM (not indicated), mismatched kernel (it's in boot.img, as well as ramdisk) is likely you problem... PW
[Magisk] pndwal:
Good tips... Those trying safe-mode disabling should be aware of this issue:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86639035

@huskydg's Magisk Bootloop Saver is a great idea too (I use it)... Ambulance at top of cliff... PW
[Magisk] pndwal:
Much discussion here has been about this...

Seems it's already fixed in a test build for most. I linked this again just above your post:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86643021 🙂 PW
[Magisk] pndwal:
For Devs / anyone with root app issues:

Next TJW builds will fix some root services issues with libsu 4.0.3 (March 22) support.

👀 PW
[Magisk] m0han:
yeah. my screenshot here is an indication, i suppose (i'm on #1625). thanks for the additional info.
[Magisk] pndwal:
Yup. App Installed ... (27) indicates stub installed (app is hidden / obfuscated). (xx) is not appended when not hidden... PW
[Magisk] pndwal:
🤔 I don't think that's right.. Bootloader (Sammy BL) shouldn't be touched by flashing recovery even on old devices like yours... (Bootloader also is seldom updated by OEMs, and version rollback is often not possible when this is done.)...

Am I right in guessing that you actually flashed AP as well as BL, and likely CP / HOME_CSC also, to fix boot here?... This is recommended... Otherwise bad / interrupted flash?

Some Technical Information about Bootloader in Android:

Generally on Android the bootloader consists of several partitions. The primary ('locked') bootloader is /rpm. The secondary bootloader is typically /sbl1 and the application bootloader is /aboot. Unlocking bootloader is really just bypassing /rpm (still 'locked') so Android boots on instructions from secondary bootloader ('unlocked') and the application bootloader. On a bootloader locked device, the primary bootloader works with the application bootloader to boot Android. In this case “bootchain” is verified 'locked' and secure.

These partitions should never be touched by flashing recovery or boot partitions.

Well that would be normal if flashed stock AP...

So did you also update ROM at some point here?? Which point? ... And exactly how?

But maybe you didn't flash AP as TWRP is still there... Or did you reinstall? Or have a twrp-patched AP file!

Yup, could well be / sounds like a regression... Glad Direct install to update works...

If you fill in the blanks above I'll comment further. 😉 PW
[Magisk] fubo73:
We are going OT, but let me resume my experience.

Firstly, thanks for lesson. I am not a big expert of, but I presume that things slightly differ between different mobile producers. Things that I do on Samsung I do not do on Xiaomi.

When I used Samsung, I always used Odin to flash stock. For custom, I do everything from TWRP. But the first time that I tried to update TWRP from TWRP itself using IMG format, at reboot the phone started booting always in Download (Odin) mode. I found somewhere on the web that this can be easily fixed by flashing BL partition back with Odin. I did and magic! LOS restarted. After, using Odin I needed to flash .tar TWRP package in AP section to use TWRP again.

So:

- on klte, TWRP cannot be updated using IMG format (on PocoF1 no problems).

- you are allowed to flash a single partition in Odin.

Coming to magisk, occasionally when I do OTA from LOS I lose magisk. In theory this should not happen, but it does. So I need to reboot from TWRP, reinstall magisk and reboot. This always worked in the past, but now with 24.3 this is not working anymore as 24.3 fails in TWRP. Instead, 24.0 works perfectly. So now, in case it would happen again, if LOS update removes magisk, I need to flash 24.0 from TWRP and then update it to latest directly from Magisk Manager. For me it is a regression. I hope it will be fixed.
[Magisk] m0han:
https://xdaforums.com/t/module-magi...p-edits-and-more-v6-1-2.3789228/post-86645813
[Magisk] pndwal:
OT is just a matter of perspective. 🙂...

We are trying to troubleshoot an issue flashing / updating late Magisk... in Magisk General Support / Discussion!

According to official instructions TWRP .img install should work... I'm wondering if that was working previously?... Did this happen to change with Android 10?

Good find!... Can I assume you flashed BL on it's own? In this case I'm certainly missing something critical!... Something to do with conversion to 2SI? (see below.)

mmm. had system replaced recovery with stock on booting?... I forgot what twrp patches in 'ROM' to prevent this...

Well, one 'binary'... BL contains multiple partitions however...

Yup, apparently two regressions... 1) Can't install from TWRP, also 2) regression with Magisk addon.d survival script for supported custom ROM updates. I replied with info on this recently to a user who noted it is failing in LOS 18.1:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86529647

Also, @osm0sis (it's his creation / innovation) responded to confirm this:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86530903

It's worth noting that ROMs above Android 10 automatically convert your 'clasical' device from Legacy ramdisk boot type to up to date 2SI boot type (something not possible for Legacy SAR devices). This is a whole new way of booting both system and Magisk, and I still haven't gotten my head around the changes it brings. I'm suspicious that .img flashing may not be handled correctly in twrp because of these changes, or older .img files themselves are no longer compatible, or there's another issue... I just don't understand ramdisk->>2SI well enough.

Here's John's first observations about this huge and relatively recent change for anyone interested:

www.twitter.com/topjohnwu/status/1174392828828372992

and

www.twitter.com/topjohnwu/status/1245246110966231040

😬 PW
[Magisk] fubo73:
TWRP and Samsung WoW are OT :)

I don't know. The issue is systematic. I'd need to check if affects also magisk installation, I didn't check if flashing back BL removes Magisk injection.

No, TWRP is always there. Just magisk could disappear.

I don't know if second one is magisk regression or LOS regression. I'll try to experiment more if I have time.
[Magisk] rbouza1:
It would if you don't check any boxes.
[Magisk] rbouza1:
Sorry but does same thing just easier imo.
[Magisk] J.Michael:
You are "allowed', as in "Odin doesn't care and will download whatever it is told to". And download mode on device doesn't insist on a particular set of partitions.

You "should not", as in John Wu warns that failing to provide all four file types can result in your data partition appearing to be smaller. There is probably a much more restricted case that is responsible for the problems that have been observed, but he felt that "provide Odin with all four types" would avoid the problem.
[Magisk] pndwal:
...Custom recovery installation (incl. TWRP) still has Magisk support (if 'maintained with minimum effort') as do Samsung devices...

Whether Sammy wielding sports fans can obtain Olympic results and schedules in real-time is no business of Magisk... You are correct that WOW is WOT...

I asked as you said:

... so just corrupted / failing, or missing?

👍 PW
[Magisk] salman.khan1:
Thanks for all of the replies but can anyone tell me how can I avoid my app's root check from being bypassed by magisk ?
[Magisk] pndwal:
Remove Magisk?... May be many other options too, depending on your devices (completely unknown) configuration. 😝 ... PW
[Magisk] HerrPoetry:
Need help diagnosing a problem. I have a new-used Magisk24.3-rooted LG V35 running stock 9, that works beautifully, except it can't seem to handle Google Cloud Messaging registrations.

I've learned this because I regularly read and send SMS on my Macbook Pro, but this phone resists. PulseSMS, MightyText, Join, and even Google's own Messages app all fail to maintain sync with cloud for more than a few minutes. Join's diagnostics showed the GCM errors. The general pattern is that the sync appears to work -- SMS messages appear in whichever computer/web app I try, but as soon as I try to read or send a text, GCM is lost and error is thrown.

Also, strangely, Google Play works fine on the phone, but the Play Store on the web doesn't list the LG as one of my devices.

I can supply more info if needed, but don't want to bombard off the bat.
[Magisk] zgfg:
What modules do you use?

Test in the Terminal app:

getprop ro.product.model

If the answer is not your correct phone model, then Playstore cannot properly recognize your phone

Magisk itself does not change to.product.model or other props. But there are modules that do it, helping you to pass SafetyNet