yashsingh1/xdaforums huggingface dataset:
[Magisk] jonh42:
I need help, I just upgraded my Oneplus 6 from lineage 18 to 19 (Android 12) and when I want to flash magisk, I always end up in a bootloop with the both of the methods, the one with apk renamed as zip and the one with the recovery flashed as boot (I followed this tutorial btw)
[Magisk] zgfg:
Probably you have Magisk modules, not compatible with A12, that you didn't disable/uninstall before upgrading. They are installed at /dara/adb, hence they were not removed if you didn't ask for Factory reset

This problem has been discussed here several times, you can check in the previous posts

Actually, on Magisk GitHub, Wiki, there is a chapter on how to resolve
[Magisk] jonh42:
Thank you so much, I'm sorry I didn't check the previous post before asking my question!
[Magisk] zgfg:
NP but did you resolve?
[Magisk] jonh42:
Yes, I removed the modules in /data/adb and it worked, thanks to you!
[Magisk] pndwal:
Yeah, I noticed this too, but some time back; doubt you'll see it for any device now... Maybe changed in this?:

https://github.com/topjohnwu/Magisk/commit/ca9f9fee9a9197b6a56f4bf5ed3d4ae26a7a6dd7

... did we lose encryption (cryptotype) info even earlier?

Seems John likes to simplify Magisk (for good reasons). My guess is that SAR, A/B, Crypto etc. states may now be considered confusing and largely irrelevant for Magisk purposes, and have been dispensed with in favour of Ramdisk and Zygisk state info... PW
[Magisk] pndwal:
Yup, Magisk daemon will restore (rebuild) Magisk config files on bootup if deleted, and has similarly, for some time now, detected if Magisk app is missing and restored stub app at boot time if necessary.

In recent months I've noticed this has stopped functioning (removed / regression?), and I actually searched to see if it was removed on purpose... Couldn't find a commit, so guessing it was a regression, and it has been fixed or reinstated again here in any case:

Install stub if necessary

(topjohnwu committed 7 days ago)

So sorry, this is a feature, but I wondered myself if it is really necessary for the same reasons as you... I don't know how it can be easily bypassed... 🙁 PW
[Magisk] Kilolo:
i'm just wondering, does my device doesn't support the current version of magisk? because i can't open the menu to download the magic modules at all. i had to download it manually from external site and i read the solution online and it said i should downgrade it to version 21.4

i just wondering if there's a way to access the menu without downgrading it
[Magisk] martyfender:
As has been mentioned many, many times here, the module repository was closed long ago. Use this instead:

https://github.com/Fox2Code/FoxMagiskModuleManager
[Magisk] Kilolo:
Thanks :D

sorry about that, i tried searching at this thread but there's just too many replies about different topic 😅
[Magisk] m0han:
if you're cool with using gestures, try this. (i'm not sure if it works with the standard navbar.) i started using it since there is no gravitybox yet for Android 12.x. (there was a lot of discussion of this on this thread :D)
[Magisk] amk316:
the rebooting is not the problem, i do it once a week and delete magisk app stub

but now every time i run an app with root access the stub appers without rebooting my phone

and some banking apps didactic that my phone is rooted
[Magisk] Huyqwerty:
Hello, I heard that Magisk is systemless so I cannot modify file permission, am I correct ?
[Magisk] zgfg:
You cannot modify if FILE SYSTEM is read-only on your phone (mostly for the phones released with A11 and newer, for the system partitions)

If File system on your phone is not read-only, you can still modify everything on the phone with root.

Hence if you have an old device,with old Android, sky is your limit

Hence it's not a 'defect' on the Magisk side. Magisk just provides Systemless mechanism (mounting over instead of overwriting) on devices where system-as-root comes read-only (not just that but there is no free room left) to overcome that limitation.

Because with root, you can still not change the SAR filesystem characteristics

But even if you have that old device/Android, you can still use the Systemless mechanism (all new modules use it, you like it or not), because it's safer - your real system partitions will not be affected - just boot without Msgisk

The whole story is not so easy but you can further search, read, etc
[Magisk] Huyqwerty:
So is there any way I can overwrite files ?

Or disable scoped storage ?
[Magisk] Compgeek316:
I can confirm that Android Pay payments work with Magisk v2. Only disabled root in Magisk Manager app. Xposed and modules were active during payment.

Lg G4 h811 Stock 20o Rom

Magisk v2

Phh's Superuser for Magisk v2

Xposed for Magisk v86.3 topjohnwu
[Magisk] elreydenj:
I have seen many reports of it not working. I can confirm it not working with V2 on a Nexus 6P stock and completely clean flash. Maybe it has something to do with being on Android N?
[Magisk] datafoo:
Is this a typo or did you mismatch Magisk V2 with xposed 86.3 instead of 86.4?

Side note I regressed to Magisk V1+xposed 86.3 because V2+86.4 was unstable and caused my device to become non responsive and randomly reboot.
[Magisk] bojiokia:
Is this the normal behavior?

After a fresh install to Stock, flash TWRP recovery, flash magisk v2, no SUPERSU/no xposed, just stock with magisk, the default phone encryption is gone.

Without encryption unable to use my Office exchange email, or have to search for bypass email security.

I am on Nexus 6P. I try to do a encryption now, and been waiting for 2.5 hours, and not sure if it is hang or still encrypting.
[Magisk] Captain_Throwback:
In the OP it states that Magisk will patch the forceencrypt flag so yes, that is expected.
[Magisk] dimm0k:
[MENTION=4470081]topjohnwu[/MENTION] I'm curious about this one as well
[Magisk] rtthane:
Thought i would share my experience here;

Using Tupac-4u Debloated MTC20F Stock+ on Nexus 5x - stock Kernel with a clean flash

Flashed Magisk v2

Phh's Superuser for Magisk v2

Xposed for Magisk v86.4

Phh's Superuser apk from appstore

DVDandroid's Xposed Installer

Android Pay doesn't work, even after disabling Xposed and rebooting

Started from scratch with the above, leaving out Xposed and just installing Magisk v2 and Phh's Superuser for Magisk v2.

Android Pay still doesn't work.

Clean flashed the ROM again and tried the following;

Flashed Magisk v1

Phh's Superuser for Magisk v1

Xposed for Magisk v86.3

Phh's Superuser apk from appstore

DVDandroid's Xposed Installer

Android Pay works just by disabling root; didn't even have to disable Xposed.
[Magisk] johnhazelwood:
Same result, failed on stock 6P running N. Passes safety net, but purchases fail, detected root.
[Magisk] shuckeru:
after all the hoo-ha about v2 and 86.4 systemless i'm kind of glad i held off this one time instead of being my usual early adopter self :P
[Magisk] topjohnwu:
Magisk v3 is now live!!

This update fixes many fundamental functions of the Magisk infrastructure, the most important is Samsung devices are now fully supported!

Changelog

v3

- Fix bootimg-extract for Exynos Samsung devices (thanks to [MENTION=1915408]phhusson[/MENTION]), should fix all Samsung device issues

- Add supolicy back to patch sepolicy (stock Samsung do not accept permissive domain)

- Update sepolicy-injection to patch su domain for Samsung devices to use phh's root

- Update root disable method, using more aggressive approach

- Use lazy unmount to unmount root from system, should fix some issues with custom roms

- Use the highest possible compression rate for ramdisk, hope to fix some devices with no boot partition space

- Detect boot partition space insufficient, will abort installer instead of breaking your device
[Magisk] topjohnwu:
Note: This post is posted here because more people look at this thread.

However, Android Pay and root discussion should be in this thread

The new disabling method will now not only kill the background process - su daemon, but also kills all possible processes that has acquired root access.

Root shells and root apps will "NOT" survive after switching to disable. "Nothing", seriously, is able to gain root access, or has root access at that period of time.

The results of Android Pay is mixed with some success and some failure, but in these few days I've kept in touch with several people testing actual transaction for me.

The result is positive, Even with Magisk Xposed (v86.3+) installed!!

As you can see, Google has no possible way to check if your device is rooted or not, and no single trace and background process has root privilege.

If this update still don't work, then Google is definitely detecting other factors, not root itself.

One thing I suspect is boot image detection. All failures seems to be Nexus devices.

The reason I think of this is the fact that Nexus device checks your boot image when receiving OTA updates.

So people unable to get Android Pay working, please try to delete "/data/magisk.img" through custom recoveries and reboot.

This will disable all Magisk functions, but your boot image is still modified. See if Android Pay still refuse to work.

If that's the case, I still have ways to bypass this. But first of all I need to know the actual point why Android Pay fails before I can start fixing the issue.

Thanks a lot!
[Magisk] g2uzer:
So do we need to still use the Terminal commands before we flash magisk root? I read a while back that was needed to get AP to fully Work.

Thanks for the great work! Flashing as soon as i get home
[Magisk] Captain_Throwback:
Those commands have zero effect on Magisk or phh's root, so I don't see why you'd need them.
[Magisk] allen099:
Thanks for updating, [MENTION=4470081]topjohnwu[/MENTION]. After updating to v3 and reflashing phh superuser v2, I'm at the same place on my N6P with not being able to pay. I removed the magisk.img as you suggested, but got a message that my device is not rooted. I tried to reflash just the superuser from TWRP and it didn't let me, so I reinstalled magisk v3. Let me know if I can help with testing. Thanks for the hard work!
[Magisk] spartan018:
Still seeing "Boot up failed" from the bootloader immediately on startup on my Moto X 2014 with v3. [MENTION=4470081]topjohnwu[/MENTION], how can I help you debug this?
[Magisk] topjohnwu:
Yes, deleting magisk.img will remove root.

Please try to use Android Pay in that condition.
[Magisk] Skanin:
Hi!

Trying to flash Magisk, but can't succeed.. My device is a Xperia Z2, with this stock kernel and this Magisk version. When I flash this two together, the device won't turn on and the led is flashing red.

I've also tried to flash with this custom kernel, but I get stuck at the SONY logo when booting up..

Any help? :)

Edit:

Decryption key for Stock kernel:

!S7ONQs8BPfx6_I2-X_RrnIEf6m_LTG3Bj-XdVT9VHgE

Decryption key for Magisk:

!5zeoU5D4LZ3F71215eVcHl1_-NYQd_ITGnw-CuiwqNg

Decryption key for Custom kernel:

!PaPGsAd2j1p682SU4rmYgogcu7OB3OZrRuGUGoI3ntc
[Magisk] topjohnwu:
Android N is still in beta, I won't support it for now (even though Magisk works)
[Magisk] topjohnwu:
I'll take a look when I got free time

Thanks for providing the boot images, but please do include a code in the link (switch to the one with code included into the link)
[Magisk] allen099:
It worked [MENTION=4470081]topjohnwu[/MENTION]. Removing that .img does allow me to pay.
[Magisk] joshuaw84:
PoGo Discussion
[Magisk] rfgamaral:
I fixed the problem I mentioned above by remove the /magisk/googleassistant folder followed by a reboot.
[Magisk] cridtohs:
before installing everything Safteynet passes green, magisk does not hide from apps that try to get root to show that there is root access. Example Telus Optik-TV asks for root priv. Comcast TV apps. Saftey Neti is NOT working, PoGo NOT working, It USED to work fine, Safteynet now detects these magisk installs, optik tv once you log in and try to play it detects root by asking for root. even with all latest updates magisk root hide checked in settings, su deamons shutdown in rootswitch 1.3.3.3 , latest phh superuser for magisk 259, latest v8 magisk, mod1 magisk, mod2 magisk, magisk manager 2.0 .

suhide 0.55 flashed causes bootloop, but it is not mentioned as a method for [MENTION=4577747]zapahacks[/MENTION] , who seems to only have working on alexis with arter kernel.

Hydra Rom s7 edge 1.3.5 (with or without magisk preinstalled, without preinstalled i then obviously reinstall the latest versions of everything)
[Magisk] Captain_Throwback:
Did you add the apps to the magiskhide list?
[Magisk] cridtohs:
? what list?

theres modules and if the module is present it is enabled
[Magisk] Captain_Throwback:
You need to read the Magisk release thread - specifically the part about magiskhide.
[Magisk] AbiDez:
Curious, everything runs fine... But when I enter Magisk Manager then comes Stopped... But for 1st start is good can set my options...

CarHDRom V.25 by Carotix S6edge
[Magisk] edyny1:
I followed your steps and passed safetynet but with magisk v8 mod2 i couldn't install at all xpoxed 86.2 so what i did uninstall magisk v8 mod2 and flashed the original magisk v8 and xposed 86.2 installed in one shot.

SafetyNet : Green

Xposed 86.2 disabled thru root switch and my modules are working.

PoGo: Working

See Screenshots....
[Magisk] mrxtc89117:
Isn't root switch redundant just to disable xposed. You can disable xposed thru the xposed installer. You need to reboot just the same.

Edit: xposed 86.2 is for supersu and 86.6 is the magisk version. By forcing the install, you are probably doing something not good to your device.
[Magisk] edyny1:
If i install 86.6 and disable it thru xposed installer will the modules still work like it's doing now?
[Magisk] mrxtc89117:
No, it won't work. At least not that I know of. I don't have many modules as I don't play Pokémon Go. But as I mentioned. 86.2 is for the supersu version so I'm not sure how it obtained root. Let us know how it goes.
[Magisk] edyny1:
Ok i installed 86.6, i disabled it thru xposed installer did soft reboot, when it rebooted the switch is disabled but still saying active and in root switch its grayed out and can't disable it plus i failed safetynet blue screen
[Magisk] edyny1:
Update: i switch back to 86.2 and Safetynet back to green, xposed disabled thru root switch and modules working.

However i did took a screenshot in TWRP flashing xposed framework 86.2 and this what it says.
[Magisk] mrxtc89117:
Not sure. When I disable mine it turns yellow but I've only installed 86.6. Never had 86.2. I tried some xposed modules and it does not run when then installer is disabled. But, I pass safetynet.
[Magisk] Vinnom:
Just to update that v8 still not works here =P
[Magisk] cridtohs:
I see the list. It also says "safteynet is hidden automatically". So I should be able to pass safety net. I Will add PoGo and check. Can you just add apk as the name or do you have to use the data-dir name? Thanks for the help
[Magisk] sebastienbo:
Magisk beeing detected?

Hi Everyone, I noticed that many apps got a new root detection method

I have two apps that I can't hide with xposed mode rootcloak

be.belfius.directmobile.android

and

be.telenet.yelo

They seem to check if they can find magisk or xposed files on the system

Do you guys have another way of hiding root?

I'm on superman 1.15 rom which comes with magisk 8 and xposed preinstalled

I download the roatcloak module and added these two apps and reboot the whole thing
[Magisk] CryMasK:
I think I found the trick.

If you want "Root your device" and "Pass the safety net", just follow the Magisk thread.

But if you also want to install Xposed framework, you must use RootSwitch(Latest version is 1.3.3.2) and SYSTEM Xposed(or install systemless xposed in system mode),

systemless xposed v86.6 would detect Magisk and auto-install in systemless mode, so I use v86.2 that only detect SuperSu file (I don't have enough time to flash file and test others combination)

* Why don't use systemless xposed? Because the feature about Xposed in RootSwitch don't support systemless xposed

* If you haven't root you device by SuperSu, just flash systemless Xposed v86.2, it will auto install in system mode

* If you flash SuperSu before, DON'T just flash boot.img (or ROM) back, use the "Unroot" feature in SuperSu app

***important*** This method is not support all xposed module, some module like "Flat Style Bar Indicators" is not working for me
[Magisk] exodius48:
Does xsetprop only for HTC devices? Can i use it on another device? I'm using Cm13 in my Redmi Note 3 Pro.
[Magisk] wadeintn:
First - thx for all your hard work. Much appreciated. I installed v8, Phh SU and Xposed ARM SDK 23 and got a green light on it all which remains. Problem is my connectivity. My device is an unlocked s-off AT&T HTC 10 still running the Stock Sense ROM. My WiFi drops in and out. Often I have too toggle off and right back on to continue on the Web or doing anything requiring a connection. My settings always show a good connection although it inoperable. Data connection is also an issue. Device shows its been registered via APN and all systems appear good, but I can't connect when I turn off WiFi to test knowing I had a potential issue. I've tried all my knowledge has available to troubleshoot. I'm at a loss.

I have not installed the template however. Is that needed and does it effect connectivity in any way? I also changed the install location of the BusyBox you prefer as you directed. I just don't have any idea what I've done wrong at this point and have no solutions. Any help or assistance would be greatly appreciated.
[Magisk] zgfg:
As I said, the whole story is more complicated than yes or now

Pls read my edited prev answer
[Magisk] J.Michael:
If you have Magisk installed, you can get the effect of "replacing" or "inserting" files. I think if you make your own copy of an existing file, and change the permissions on the copy, it will have the effect of changing the permissions on the original.

For your own use (i.e., not for distribution), there is very little to making a module: just pick a name, make a directory "/data/adb/modules/m-name", then reproduce the directory structure of the file you want to replace or insert.

Read the document on creating a module.
[Magisk] Huyqwerty:
Ok, thank you for your support😍😍😍
[Magisk] Huyqwerty:
Thanks for the advice🥰🥰
[Magisk] m0han:
not sure if these apply to your case. wouldn't hurt to check, i suppose

https://xdaforums.com/t/script-andr...-superrw-featuring-makerw-read-write.4247311/

https://xdaforums.com/t/tool-win-li...ake-partitions-rw-in-super-partition.4120963/
[Magisk] pndwal:
Definition of rumor

(Entry 1 of 2) 1 : talk or opinion widely disseminated with no discernible source. 2 : a statement or report current without known authority for its truth. 3 archaic : talk or report of a notable person or event. 4 : a soft low indistinct sound : murmur.

- Merriam-Webster

eg, Magisk 25 coming... PW
[Magisk] pndwal:
Latest Official TJW Canary (release) & Debug (debug) Magisk builds:

Magisk (bf04fa13) (24314)​

[App] Fix language switch

[MagiskSU] Handle system_server restarts to prevent UID reuse abuse

Diffs to v24.3​

[MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)

[MagiskInit] Introduce new sepolicy injection mechanism

[MagiskInit] Support Oculus Go

[MagiskInit] Support Android 13 GKIs (Pixel 6)

[MagiskBoot] Fix vbmeta extraction implementation

[App] [MagiskSU] Properly support apps using shared UID

[MagiskSU] Fix a possible crash in magiskd

[MagiskSU] Prune unused UIDs as soon as possible to prevent UID reuse attacks

[MagiskSU] Verify and enforce the installed Magisk app's certificate to match the distributor's signature

[MagiskSU] Handle system_server restarts to prevent UID reuse abuse

[Zygisk] Fix function hooking on devices running Android 12 with old kernels

[DenyList] Fix DenyList on shared UID apps

[BusyBox] Add workaround for devices running old kernels

https://github.com/topjohnwu/magisk-files/blob/4cc20a9dfb66ddd96b88499c0f4fffeee357afe8/notes.md

👍 PW
[Magisk] pndwal:
D is for disambiguation:

👍 PW
[Magisk] ipdev:
Just for the record. 🙃

Indicate debug builds - commit.

Closes issue 5,859.

Nice one pndwal 👍

Cheers all. :cowboy:
[Magisk] MDG-VN:
Guys, after i was flashing magisk patched, my phone restarted and open up download mode again, and it shows vbmeta error on top left conor. I was panicked until i reflash a stock rom. Is this a bug or my fault? My phone is Samsung Galaxy A30 (SM-A305F)

(unlocked bootloader)
[Magisk] m0han:
If you can, please include md5 checksums in your posts about new magisk releases.

8f28251215f99a3e185b7759abdc18cf is what I got for the latest release.
[Magisk] Stillhard:
Yes, saw that, and a quick one too, never happen to his other issue(s)/request(s)

Let's call him Gandalf from now on, he'll help us to keep away from 'the tower of telemetry' pull
[Magisk] pndwal:
Thanks Doc... Bit more where that came from, coming soon:

More debug indication in UI …

D is for done deed.

POC:

... It's all happening now it seems... Not like me to spread rumors but. 🙃 PW
[Magisk] ipdev:
You are a commit behind. 🙃

Interesting..

It does not recognize my custom update channel as debug. 👀

My update channel is a fork of magisk-files.

So not quite D is for done deed yet. 😛

Cheers Mate. :cowboy:
[Magisk] pndwal:
Mmm... You sure?

TJW's link in last (not fully fixed) debug JSON:

"link": "https://cdn.jsdelivr.net/gh/topjohnwu/magisk-files@4cc20a9dfb66ddd96b88499c0f4fffeee357afe8/app-debug.apk"

Yours:

"link": "https://cdn.jsdelivr.net/gh/topjohnwu/magisk-files@4cc20a9dfb66ddd96b88499c0f4fffeee357afe8/app-debug.apk"

This is Zachery same! 😉... (gotta edit JSON to make it call your hosted fork doc.)

----​

There seems to be one small issue remaining however; Debug Stub may not be properly indicated.

If user doesn't un-hide App before moving to Debug, stub isn't always (ever?) updated. (Currently retains (29) instead of fetching (30).) Since debug built stub now differs from release build, clearly with:

App Installed bf04fa13 (24314) (29) (D)

Stub installed is still release build while App is debug, but there is no seperate indicator for stub. 😬

Here, I have same actions build installed, set channel to Stable and took Hide the Magisk app, so Stub is release build:

This has debug built Stub:

There is no clear distinction between Stub build types, and clearly the common (D) does not apply despite appearing to.

I did note this inconsistency in last issue as side note.

😛 PW
[Magisk] ipdev:
Yep.

My fork includes (and updated) with the official links. 🙃

Did you notice the additional file. 😛

Spoiler content hidden.

The stub version only shows if magisk (apk) is hidden (renamed).

Since the stub is only used when the full app is not installed, there is no reason to show the stub version of the full app.

Cheers Mate. :cowboy:
[Magisk] pndwal:
😕 Sorry - clearly was looking in master branch! 😬 ... see your channel is correct... I'll look closer when have time... Guess installs from there are working... Custom channel thing?

Of course...

But you're not getting this. 🤪

In both examples above (screenshots shown) App is hidden (uninstalled), stub installed (and updated with full App's binary data), and Stub version therefore shows.

It seems that the full complement of debug built components should be installed for properly working debugging...

My initial issue report included a suggested means to indicate if any discrete component is built as debug. (With new Debug builds, Stub is also built in debug mode, and is nearly twice the size.

WIth

App Installed xxxxxxxx (2431x) (xx) (D)

solution, it appears that Debug App is installed, whether as full app or embedded in Stub app data.

In the first instance, Debug App is indeed embedded in data of Stub app (itself 45kb) also built in debug mode. In the second, only the app data embedded in stub is debug while the Stub app (27kb) itself is built as release.

There is no indication when Magisk is configured with these mixed debug and release components. This is why I suggested this format:

App Installed xxxxxxxx (2431x-D) (xx-D)

Anyway we're even. 😝 PW
[Magisk] pndwal:
Here comes the translations! PW