yashsingh1/xdaforums huggingface dataset:
[Magisk] PokeRekoP:
Sure, wouldn't have compressed it if the original recovery.img.LZ4 wasn't ending in .lz4

Just been through the entire procedure again:

Patched with magisk canary 24306 the stock AP, inject patched twrp, flashed the whole thing again, installed the custom rom on top.

As there's no magisk app after installing the custom rom, I installed canary 24306. Start the app, and it wants to complete the extra steps. I thought it shouldn't ask? Didn't let it. Should I? Thought I shouldn't as that would break things (if they weren't already...)

Installed titanium backup, requests root, granted root, seems normal.

A minute later I go back into Magisk App, to the "root" tab, and the list is empty. Same for the "log". Root gone. Known regression, I read, deamon crashing.

=> Snafu, same game as the other day.

Someone said using a canary from mid march worked for him. Where do I get older canaries from? Couldn't find my way to them on github. Well hidden? Not archived anywhere?
[Magisk] J.Michael:
How "installed the custom ROM on top"?

From what I remember, when Magisk patches AP.tar, it patches boot.img, recovery.img, and vbmeta.img. If you did not Magisk-patch the custom ROM, you lost whatever patches Magisk had made to boot.img.

I don't understand "no magisk app after installing the custom rom". I thought that nowadays, if Magisk does not see an app when it boots, it injects a stub, so you should always have a Magisk app if Magisk is active.

If installing a custom ROM involves wiping /data, it makes sense that Magisk would need to run its setup again. Your mot running the setup might have something to do with later failures.

Older versions *are* on Github. They *are* hidden. I've seen enough of a description either here or in the Zygisk thread that I've found them 2 out of 5 times I've tried. Not this time.
[Magisk] pndwal:
Why install ROM 2nd? - that will overwrite patched recovery (and any other partitions patched as required by ROM setup)...

NB. addon.d survival script (in some custom ROMs) both for Magisk and TWRP (not compatible w/ Android 12 of course) only works when ROM or Magisk is installed using.zip installer. (This is not compatible w/ your A-only SAR device since there is no ramdisk in boot).

So installed ROM with wipes? (Clean install?) - in this case it is also assumed you will do initial Magisk install again, 1) install App, 2) patch / flash recovery image.

If it asks, you should...

Could be part of the same issue, or maybe you just didn't do the 'extra steps'?

Likely you don't need to do this, but older Canaries are (as always) here:

https://github.com/topjohnwu/magisk-files/commits/canary

😜 PW
[Magisk] doniedogawa:
I don't know when I post my problem.

Yesterday I updated the magisk from v23 to v24.3 (24305) on my LG V20 with stock Oreo. After successfully updated, I restart the phone and it got kernel crash like what I attached on this post.

I hope there are updates for fixing this issue.
[Magisk] pndwal:
Canyie already answered you here:

https://github.com/topjohnwu/Magisk/issues/5773#issuecomment-1113926421

Please follow her instructions and try latest Canary... Issue may be re-opened... PW
[Magisk] martinklaus:
Root hide was perfectly with v24. Now I found the first app with new way of detection. Anybody an idea how to fix it? I tried already Shamiko.

FATAL EXCEPTION: main
Process: com.rise_world.epa.sbk.qu, PID: 11966
java.lang.RuntimeException: Unable to create application com.rise_world.epa.ProtectedEpaApplication: com.rise_world.epa.MessageGuardException_RFA6IDc2OCBbMjAyMjA0MDctMjAyMjA0MTExMzM1IGI3OmFybTY0LXY4YSAzMCBPbmVQbHVzL09uZVBsdXM3UHJvX0VFQS9PbmVQbHVzN1BybzoxMS9SS1ExLjIwMTAyMi4wMDIvMjExMjEwMTc0MTp1c2VyL3JlbGVhc2Uta2V5c10: DP: 768
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6991)
at android.app.ActivityThread.access$1700(ActivityThread.java:274)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2093)
at android.os.Handler.dispatchMessage(Handler.java:106)
at android.os.Looper.loop(Looper.java:233)
at android.app.ActivityThread.main(ActivityThread.java:8010)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:631)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:978)
Caused by: com.rise_world.epa.MessageGuardException_RFA6IDc2OCBbMjAyMjA0MDctMjAyMjA0MTExMzM1IGI3OmFybTY0LXY4YSAzMCBPbmVQbHVzL09uZVBsdXM3UHJvX0VFQS9PbmVQbHVzN1BybzoxMS9SS1ExLjIwMTAyMi4wMDIvMjExMjEwMTc0MTp1c2VyL3JlbGVhc2Uta2V5c10: DP: 768
at com.rise_world.epa.ProtectedEpaApplication.wrsg(Unknown Source:49)
at com.rise_world.epa.ProtectedEpaApplication.onCreate(Unknown Source:51)
at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1208)
at android.app.ActivityThread.handleBindApplication(ActivityThread.java:6986)
... 8 more
Caused by: java.lang.RuntimeException: DP: 768
at com.rise_world.epa.ProtectedEpaApplication.AFfDwyn(Native Method)
at java.lang.reflect.Method.invoke(Native Method)
at com.rise_world.epa.ProtectedEpaApplication$ProtectedEpaApplication$EpaApplication$d.hwuvBCo(Unknown Source:31)
at com.rise_world.epa.ProtectedEpaApplication$ProtectedEpaApplication$EpaApplication$d.wEtn(Unknown Source:472)
at com.rise_world.epa.ProtectedEpaApplication.AFfDwyn(Native Method)
at com.rise_world.epa.ProtectedEpaApplication.onCreate(Unknown Source:46)
... 10 more
[Magisk] pndwal:
Looks like major libsu release is now imminent; most fixes are now merged.

Should see major stability improvements in Magisk and root app implementation... Should see new commits for Magisk proper again soon too!

John has made some major libsu changes (see libsu GitHub).

Here are extra comments on vvb2060 fixes from her TG (Chinese translated:

April 16

April 20

I (and many Chinese users also) thought that the following announcements may have been an April fools joke. Apparently they weren't:

April 1

April 1

PR ref. to fix these:

April 22

👀 PW
[Magisk] Danny94:
Id like to setup google pay for my device unluckily im not able to as YASNAC still reports 'cts profile: fail'.

Device: Redmi k20 pro

Rom: xiaomi.eu 10.3.16 (android 9)

Magisk: 24.3 , zygisk yes, ramdisk no

Magisk app hidden

Zygisk beta: enabled

Denylist: enabled

Google pay added to denylist (play store, play services not available)

Modules: ACC, Debloater, Systemless host, Universal SafetyNet Fix 2.2.1 by kdrag0n, gms doze (at the moment disabled)

Edit: play store says im not play protect certified

Tried already to clear data for playstore, play services, aswell for cloned one

Edit2:

My fingerprint seem to be:

Xiaomi/davinci_eea/davinci:9/PKQ1.190302.001/V10.3.7.0.PFJEUXM:user/release-keys

Version.security_patch:

2019-07-01

Build.description:

davinci_eea-user 9 PKQ1.190302.001 V10.3.7.0.PFJEUXM release-keys

Product.manufractur:

Xiaomi

Product.model:

Redmi K20 Pro

Product.device:

Raphael
[Magisk] pndwal:
I believe XiaomiEU (custom) ROMs now generally spoof a passing fingerprint, but older ROMs (incl. some in 2021) used original fingerprints or didn't properly align these w/ security patch dates...

Assuming you have basic integrity pass, install MagiskHide Props Config Magisk module and a terminal emulator app, and configure a working fingerprint...

😉 PW
[Magisk] Mr. GAMB:
hello, help advice please.

I'm trying to port the nfc service from one firmware to another, but simply creating a module with a set of necessary files in system|system_ext|vendor does not work, because there are a couple of * .rc files in vendor. There are imports of these files in *vendor_init*.rc of the firmware itself, but when this very init is executed, magisk has not yet placed the ported files in the correct path.

can you tell me how can I match my *.rc files in /vendor/etc/init/ before *vendor_init*.rc is executed? or maybe you can somehow independently execute the code from the ported *.rc files and it will work?
[Magisk] zgfg:
The earliest you can go in the module is from post-fs-data.sh shell script, see:

Developer Guides

The Magic Mask for Android

topjohnwu.github.io

However, modules are now extended to use the optional Zygisk functionality (seems only with native code), I don't know could it help/apply to your case:

GitHub - topjohnwu/zygisk-module-sample: A sample project for building Zygisk modules

A sample project for building Zygisk modules. Contribute to topjohnwu/zygisk-module-sample development by creating an account on GitHub.

github.com
[Magisk] zgfg:
Seems that is an old Xiaomi.eu Stable with MIUI 10/Android 9 from 2019, hence too old to have SafetyNet fix (taken from the USNF open source code, but USNF development started in 2021) built-in to the ROM (I have Xiaomi.eu 12.5.2 A11 Stable on my K20 Davinci and it passes SafetyNet right-away without Magisk, while with Magisk I only need to enable Zygisk and DenyList and to checkmark Google Play Services aka GMS in DenyList - no need for USNF)

That means you would need to use USNF (Universal SafelyNet Fix) module to pass CTS and to have Device Certified.

However, I'm not sure if USNF supports A9 - probably @pndwal would know
[Magisk] pndwal:
libsu 5.0.0 is out!

libsu/CHANGELOG.md​

5.0.0​

Check the updated Javadoc and the example app for details on how to use the remote file system in the new nio module.

New Features​

Introduce a new module: nio

Includes file system implementations for local and remote processes

New FileSystemManager class to access either local or remote file system implementations

New ExtendedFile class to extend functionality of the old Java File API

[core] New API Shell.isAppGrantedRoot() returns a nullable Boolean:

true if a root shell has been created

false if it has been determined that root access is impossible to get

null if the library has not, or could not determine the current root grant state. Future invocations of this method may return a non-null value if the library gained more information during shell creation.

[core] New API Shell.Builder.setContext(context): allow the developer to explicitly provide a Context object

[io] SuFile is updated to also extend ExtendedFile, which adds some new features and APIs

Deprecation​

Version 5.0.0 will be the final release of the busybox module. If you cannot remove the usage of the module, you can pin the busybox module to version 5.0.0, as it is updated to be fully self contained, making it guaranteed to work with future libsu versions.

Usage of SuFile/SuFileOutputStream/SuFileInputStream/SuRandomAccessFile is discouraged. Although these APIs will remain for the foreseeable future, please migrate to use RootService + the nio module for all root I/O operations.

Shell.rootAccess() is deprecated. Please switch to use the more accurate Shell.isAppGrantedRoot() API

New readme etc. Read how you can Attach Debugger to Android Process in Root Services and more!

https://github.com/topjohnwu/libsu

👏👍🥳

... Back to regular Magisk programming... PW
[Magisk] Danny94:
He has adviced me already to change fingerprint. I have used magisk hide props and choosen a fingerprint there (xiaomi mi 9t pro china android 9) and that worked perfectly.

Thanks.
[Magisk] pndwal:
v2.2.1 (Zygisk)​

Latest

Changes​

...

Add check to prevent installation on unsupported Android versions (7.x and older)

Readme.md:

• Android versions up to 13 Developer Preview 1 are supported, including OEM skins such as Samsung One UI and MIUI.

Also: Some 7.x devices were reported to use Hardware Key Attestation, but generally the strong attestation HKA in Android 8 launch version (Keymaster 3) seems to be the level needed for current Google's Hardware backed attestation testing / implementation.

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86248407

🤠 PW
[Magisk] persmash:
Hi everyone,

I am trying to uninstall Magisk on my Samsung S9 with stock ROM and TWRP installed.

When I press complete uninstall on Magisk manager, the system goes to bootloop. The only way to boot it again is reflash magisk with TWRP.

What I am doing wrong here? How can I completely uninstall without losing my data?

Best Regards.
[Magisk] pndwal:
Latest Official TJW debug Canary Magisk:​

Magisk (cc79a96f) (24307)​

[App] Update libsu with 100% new I/O layer

[MagiskInit] Mock enforce file with regular file to prevent possible race condition

Switch normal NDK with ONDK, preparing the toolchain to introduce Rust

Diffs to v24.3​

[MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)

[MagiskInit] Introduce new sepolicy injection mechanism

[MagiskInit] Support Oculus Go

[App] [MagiskSU] Properly support apps using shared UID

[MagiskSU] Fix a possible crash in magiskd

[Zygisk] Fix function hooking on devices running Android 12 with old kernels

[BusyBox] Add workaround for devices running old kernels

https://github.com/topjohnwu/magisk-files/blob/a66dfce1bf88a70e86bf86c5427b1c58e71a4fc2/notes.md

👍 PW
[Magisk] aliak122:
The magisk online server for installing various modules has been down for me for a long time and I do not have access to any modules. Does anyone know what the problem is? Does anyone have a place to install the modules manually to give me the address?
[Magisk] m0han:
try fox's magisk module manager
[Magisk] m0han:
md5: 68eca2737ee7b5a16904f284b7b559e3
[Magisk] pndwal:
Please confirm if you are on Android 10 ROM.

I think this is your problem:

Important Notes​

Never, ever try to restore either boot, recovery, or vbmeta partitions back to stock! You can brick your device by doing so, and the only way to recover from this is to do a full Odin restore with data wipe.

This is from official Installation Instructions,

Samsung (System-as-root) section.

I believe that there are issues with (errors in) these instructions that affect you, assuming you upgraded to Android 10:

1) The prefacing comment:

If your Samsung device is NOT launched with Android 9.0 or higher, you are reading the wrong section.

Yours is an Android 8.0 Launch Version (LV) device, but on updating to Android 10, Legacy Ramdisk boot type devices are converted to 2SI SAR boot type. (Nb. no conversation to Legacy SAR takes place on updating to Android 9; Legacy SAR booting is effectively skipped.)

Because such legacy devices convert to a form of SAR w/ Android 10 upgrade, I believe John's prefacing comment is in error; the Samsung (System-as-root) section does now apply to your device...

I opened an issue about this situation some time ago (after several users reported Samsung SAR related issues on S9 and other old Sammy devices), and it was unfortunately closed:

https://github.com/topjohnwu/Magisk/issues/5573

If you can confirm this applies to you I'll open another / take it further...

2) You are able to recover by re-flashing Magisk. - It may be that this not possible for devices using Legacy SAR (mostly Android 9 LV devices with some exceptions w/ earlier Android LVs), but assuming I'm correct about you having late 2SI SAR, the statement "the only way to recover from this is to do a full Odin restore with data wipe" is clearly in error.

In any case, as with Samsung devices launched with variations of SAR, it seems you cannot now restore boot, recovery, or vbmeta partitions back to stock (fully 'un-root') on your upgraded device without a full Odin restore with data wipe.

Sorry. 😬🙃 PW
[Magisk] pndwal:
Bleeding edge...

Seems there's an Application Not Responding (ANR) issue with Magisk App 24307 on non-rooted devices:

https://github.com/topjohnwu/Magisk/issues/5787

👀 PW
[Magisk] m0han:
latest is 0.4.5
[Magisk] jonathanjr321:
can someone help me please why this is happening

N900 SAMSUNG GALAXY NOTE 3 (SM-N9005)

Magisk v24.3.apk = .zip from here https://github.com/topjohnwu/Magisk/releases/tag/v24.3

rom MagMa_NX_UX10_Ultimate_XDA.zip from here https://xdaforums.com/t/rom-nxteam-6-0-1-n7-n8-s8-port-09-apr-2018-magma-nx-vx-pce.3508672/
[Magisk] persmash:
Hi,

I can confirm that I am on Android 10.

As far as I understood, the only way for now is full Odin flash. Even with that approach, what instructions I should follow? I want to go back to stock completely even with removing TWRP.
[Magisk] pndwal:
As I understand it, since A10 moves your device to 2SI 'SAR' boot type, John's Samsung System As Root notes apply to you despite stating they're only for LV A9 devices. Please read those notes.

Unless I'm missing something, John indicates that the only way to restore stock images on Sammy w/ 1st gen SAR or new 2SI 'system-as-root partition layout' ('unroot') involves full Odin restore with data wipe since restoring images will otherwise result in a soft brick.... Read 'in app Magisk Uninstall (restore images etc) options don't work for Samsung w/ SAR implementations'.

If you had remained on Android 9 (Legacy Ramdisk booting), I imagine options to unroot w/o data wipe should work fine, but new Samsung architecture took much work for John to support, and is a special case... PW
[Magisk] drasterlx:
Hello

i have a LG G4 with A11 Havoc..

Magisk app 24.3(24300) (27)

package fyhmut.go

Zygisk yes

Magisk hided

Added to the list

google play services for AR

google pay

google play store

google play services

universal safety fix module 2.2.1 active

removed data of google play services, google play store and google pay

restarted...

but no luck with google pay :(

something that i saw... every restart google play services go out of denied list.

Any suggestion or help?

Thanks
[Magisk] martyfender:
Don't add the play store and play services to the denylist. By design, USNF removes them from the denylist. I also recommend using the Shamiko module. With it you configure the denylist then disable enforce denylist. However, don't add play store or play services to that list. Although I have gpay on one of my tablets, I don't use it since the tablets don't have nfc. You may also need lsposed and enhance mode for hidemyapplist modules properly configured, I'm not sure.
[Magisk] pndwal:
Others already told you in USNF thread not to put Google stuff other than GPay app in denylist w/ Zy-USNF... That does all necessary hiding of root from SafetyNet process (ie. com.google.android.gms.unstable process) etc.

Good...

So did you check for SafetyNet pass? - use YASNAC app... Also, did you check for Play Protect 'Device is certified' result?...

You were told this too...

https://xdaforums.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-86838279

Basics, as I told you here:

https://xdaforums.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-86838985

Please report SafetyNet / Play Protect status... PW
[Magisk] aliak122:
thank you. Excellent performance. The online server was also active.
[Magisk] drasterlx:
both modules at same time?

i disable USNF and installed shamiko... disble enfoce denylist... added google pay and play services...

deleted data from google pay and play services

reboot

and issue continue :(
[Magisk] martyfender:
Yes, you need to use both USNF and shamiko. Only add gpay to the denylist.
[Magisk] drasterlx:
@martyfender @pndwal

no way :(

USNF and shamiko enable

only google pay in denylist

fail and YASNAC app fail too :(

play protect is ok
[Magisk] pndwal:
USNF and Shamiko are two different things.

USNF basically causes fallbacks to basic attestation types (instead of Hardware key attestation) in order to pass S/N using prop mismatches and registering fake keystore provider... It also adds back some other MagiskHide functions removed from Magisk like hiding root from S/N process in GMS and editing sensitive prop values to safe ones... This (passing S/N) is needed for GPay...

Shamiko hides other 'advanced' traces of root that some bank apps etc may detect like Zygisk hooking, isolated process leaks etc... This is not needed for GPay...

Both can exist together if you wish... Shamiko alone won't achieve basic attestation fallbacks (at least two types) needed for passing S/N on most A8+ LV devices...

You need to get SafetyNet passing, but you're not giving many relevant details... Eg Evaluation type, Basic Integrity, CTS match results... PW
[Magisk] drasterlx:
evaluation type: basic

Basic Integrity: failed

CTS match results: failed

thanks for your time
[Magisk] pndwal:
Good

Bad

Do you see Zygisk = Yes in Magisk app?

Disable all modules other than USNF 2.2.1, reboot and check Basic Integrity to eliminate bad modules (some break B/I)... (Some custom ROMs may break this too).

Can't pass without B/I...

🙂 PW
[Magisk] mathochist:
The official instructions say, "If your device has boot ramdisk, get a copy of the boot.img." My device has boot ramdisk. I'm guessing that this boot.img is the installer file to flash for whichever ROM I'm using (LOS 19.1 for OP6T fajita in my case), but I want to be sure before I proceed. Where specifically do I find a copy of the boot.img?

Edit/Update: I realize now that the installer is a .zip and not a .img, so now I definitely need clear instruction on where to get boot.img. Thank you for any help.
[Magisk] zgfg:
Usually both the stock and custom ROMs come in zip files (maybe tgz for some devices) where the archive contains boot.img

For some devices, there might be payload.bin and you have to use payload extractor PC tool to extract img files

You must make 100% sure that you are taking the zip/package for your device and your current ROM

If you have TWRP, you can take and use backup of your current Boot partition instead of the boot.img file for patching
[Magisk] J.Michael:
If you are on the verge of reinstalling the stock ROM with a full data wipe, what do you have to lose by trying stock AP, BL, CP, with HOME_CSC?

I think HOME_CSC does not wipe data.

I don't remember you saying why you want to uninstall Magisk; or how you installed originally; or where Magisk is installed (boot vs recovery).
[Magisk] mathochist:
I think I understand. When I extract the contents of the .zip I used to install LOS 19.1, it does contain a payload.bin file. So I rename that to payload.img (or boot.img? or anything.img? Does it matter?) and then proceed with the official instructions, patching it with the Magisk app, yes? Or am I missing anything?
[Magisk] zgfg:
I said to use Payload extractor for payload.bin, NOT just to rename that file

Search on XDA for a thread about Payload extractor (you may find under various devices). Must be PC tool, read OP instructions, Readme - whatever

You install to the PC, import payload.bin, it will extract you various img files, one must be boot.img
[Magisk] mathochist:
Ok, got it. I'm on Linux and was hoping not to have to boot into my Windows partition, but since I need to I will. Thank you for the help.
[Magisk] zgfg:
I think somebody recently posted here a link to XDA thread with Payload extractor for Linux (I found and used one for Windows). Hence seems to be available also for Linux
[Magisk] drasterlx:
Zygisk = Yes

possible as is a custom ROM is generating the issues... any log to take a look?
[Magisk] zgfg:
Sorry, it's called Payload Dumper
[Magisk] pndwal:
What Magisk modules are installed? Did you try Disable all modules other than USNF 2.2.1, reboot?... PW
[Magisk] drasterlx:
installed:

shamiko

systemless hosts

universal safetynet fix 2.2.1

enable only universal safetynet fix 2.2.1

testes with reboot and with/without enfoce deny list

with google play services v21.48.57 and 22...

every time integrity and cts fail :(
[Magisk] zgfg:
Ok, what is your ROM?

Eg, do you remember (and if the question is applicable), did you ever pass SafetyNet with your current ROM (eg, if that's the stock ROM, did you pass SN before you unlocked Bootloader)

Asking because some Chinese stock ROMs and so might not be certified. Also, custom ROMs are not certified.

In that case you would need to spoof the ROM fingerprints by use of Magisk Hide Props Config module
[Magisk] Nightf0x_007:
Magisk alpha 24307 here , shamiko usnf zygisk, my device passes yasnac tests but recently some of my apps starts to detect root and not working and also i cant get my device certified in play store, idk why they stopped working
[Magisk] pndwal:
Yup, I'd mentioned this to him in USNF thread... But this is B/I fail (+ CTS)...

Can failing fingerprint cause Basic Integrity fail? PW
[Magisk] pndwal:
Full S/N pass?

Try clearing Play Store data... PW