yashsingh1/xdaforums huggingface dataset:
[Magisk] 73sydney:
I would read up the page where @pndwal gives the basics here:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85300227

I would add that i have some very fussy banking apps, and all i currently use is:

Magisk-Alpha from here (With MagiskHide enabled for banking app, and Magisk app renamed

): https://github.com/vvb2060/magisk_files/tree/alpha

Riru: (from Magisk Repo)

Riru-Momohider (my own mod for easy setup) from this post:https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85187739 (thanks to @pndwal for the introduction to this module, i got my sanity back because of it)

Nothing else. If people want to install Xposed stuff, thats up to them, there are some cases where this is the only way, but as a general rule, im not for that stuff...

As per @pndwal's above post, theres a Magisk-Lite (basic and doesnt allow loading modules (without hacks)) which is your best bet if all else fails

Top extra tips:

Some ROM's will by themselves give up root detection (out of maybe 8 ROM's for my device, only 3 of them the above works on effectively - identical setup, identical apps backup restored to each),

Be careful what other Magisk Modules you load, even something you think of as being benign such as a font or emoji module can/likely will trigger root detection (check with Magisk Detector before and after if you dont believe me).

OnePlus for some reason has a long history of hating unlocked bootloaders and root...and i thought Samsung and Knox was bad...i used to Samsung for years but they just got ridiculous, now i Pixel, where life is (relatively) easy
[Magisk] zgfg:
About locked bootloaders and 'custom' ROMs:

XDA member unknowingly bought a Pixel phone with an FBI backdoor

The FBI reportedly sold backdoored Pixel phones to criminals, and one of those phones found its way to an XDA member.

www.xda-developers.com
[Magisk] Ahmed we3:
Alcatel 3x 2019 r
[Magisk] 73sydney:
Yup, they and the Australian Federal Police in a joint venture were pretty damn successful at convincing criminals to use these "encrypted phones". The Australian criminal that convinced all the other criminals to use that system is believed to be hiding under a rock in parts unknown as his life is worth nothing these days. He's been advised by our authorities to hand himself in as its probably the only way he will see the year out alive. Hate to be that guy. Serves them all right. They nabbed about 300 criminals in one hit here, over 800 worldwide. Most successful raid in policing history here.

You think criminals would get smarter, how unbelievably easy was it for the FBI to penetrate TOR...no one thought they might just set up their own node...

Its like people using VPN's for "security"...where do think the people youre trying to avoid are going to look, at my humble PC or the VPN companies servers...i promise you, despite all the sales pitches that they will never log their customers, they absolutely do, and will hand those logs over in less time it has taken me to write this sentence when its a choice between obstruction charges and handing over some logs and keeping your money. But if people want to give VPN companies money for a false sense of security........go ahead...
[Magisk] pndwal:
Yes, interesting about AVB and signing process...

Also, I think it's not only Pixel bootloaders that can be re-locked with a custom ROM.

Heres an old recommendation by "Tech Lead for Android hardware-backed security subsystems":

www.twitter.com/shawnwillden/status/1238131039844864000

😉 PW
[Magisk] ipdev:
You forgot one of the best parts.

The criminals actually helped to fund this operation. 🤣

Anom was not a free service.

The criminals were paying a subscription to use the service.

I do not remember what the price was but, Anom was making more than enough to keep the servers up and running. ;)

If I remember correctly it was between 200 and 400 USD a month.

Multiply that by ten thousand accounts.​

Cheers. :cowboy:
[Magisk] pndwal:
Basics:

Please say if you

- have fully passing SafetyNet check in Magisk App.

- have 'Device is certified' PlayProtect status in PlayStore settings.

- Hid Magisk App in App settings.

- hid (bank) app from root in MagiskHide list.

- tried toggling MagiskHide off, then on again in Magisk App and rebooting.

- wiped (bank) app's data, set up & tried again AFTER all above.

- read this wiki.

https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot#

👍 PW
[Magisk] Lucky1071:
Its work on tcl l t770h ?
[Magisk] pndwal:
Alcatel 3x 2019 rotten / rubbish / ridiculous device?

Alcatel 3x 2019 rugged / radical / refined piece of kit?

Alcatel 3x 2019 rooted, but tooted and booted?

Alcatel 3x 2019 rIP?...

How can we help? 🤔 😁 PW
[Magisk] ipdev:
@Ahmed we3

Hi. :)

Not sure which model corresponds with Alcatel 3x 2019 r

These are the Alcatel 3X devices on Google's public certified list.

TCT (Alcatel)	Alcatel 3X	A3A_PLUS	5058A
TCT (Alcatel)	Alcatel 3X	A3A_PLUS	5058I
TCT (Alcatel)	Alcatel 3X	A3A_PLUS	5058I_RU
TCT (Alcatel)	Alcatel 3X	A3A_PLUS	5058J
TCT (Alcatel)	Alcatel 3X	A3A_PLUS	5058T
TCT (Alcatel)	Alcatel 3X	A3A_PLUS	5058Y
TCT (Alcatel)	Alcatel 3X	Milan	5061A
TCT (Alcatel)	Alcatel 3X	Milan	5061K
TCT (Alcatel)	Alcatel 3X	Milan	5061K_EEA
TCT (Alcatel)	Alcatel 3X	Milan	5061K_RU
TCT (Alcatel)	Alcatel 3X	Milan	5061K_TR
TCT (Alcatel)	Alcatel 3X	Milan	5061U
TCT (Alcatel)	Alcatel 3X	Milan	5061U_EEA
TCT (Alcatel)	Alcatel 3X	Milan	5061U_TR
TCT (Alcatel)	Alcatel 3X	Venice	5048A
TCT (Alcatel)	Alcatel 3X	Venice	5048I
TCT (Alcatel)	Alcatel 3X	Venice	5048U
TCT (Alcatel)	Alcatel 3X	Venice	5048U_EEA
TCT (Alcatel)	Alcatel 3X	Venice	5048Y
TCT (Alcatel)	Alcatel 3X	Venice	5048Y_EEA
TCT (Alcatel)	Alcatel 3X	Venice	5048Y_RU
TCT (Alcatel)	Alcatel 3X	Venice	5048Y_TR
TCT (Alcatel)	Alcatel 3X Plus	TokyoPro	5029A

Is this a statement?

Magisk is working with your device.

If you have a question..

I will quote pndwal.

Cheers. :cowboy:
[Magisk] ipdev:
It might. 🙃

Someone will need to get a factory image.

Compatible boot image at the least.

Make sure to keep an eye on the TCL 10L forum.

TCL 10L - xdaForum - Link

TCL 10L Questions & Answers - xdaThread - Link

Note:

You might be able to get the OTA URL from a logcat when the device checks/downloads an update.

You can then use that URL to download the OTA to your computer.

Then unpack the OTA and hopefully get a full boot image.

Without a boot image, custom recovery or a way to gain temporary root.

Normally there is no way to gain permanent root.

Cheers. :cowboy:
[Magisk] zigbye82:
good day. i was testing some kernels and every time i install a kernel i would flash magisk right after. my internal storage was getting filled up. turns out there are dozens of magisk_backup folders in data folder. could these magisk_backup folders be deleted?
[Magisk] zgfg:
They are created for the purpose of potential uninstallation. You can really safely delete all but the latest one
[Magisk] DiamondJohn:
I know nothing of what I am about to ask but just a stab in the dark, but would the last one possibly be a failed attempt? and hence the current attempt?
[Magisk] zgfg:
I don't know how/when they are created - you can search in the thread, it was already discussed

I always patch the boot images (hence I don't have 'failed' attempts) and from timestamps I see that folders more or less coincide to the days when I patched

For me, those folders contain only the compressed images before patching, and since I'm maintaining my own store of the original and patched images (those, still of interest to me, incl. the last/actual one), I simply delete those Magisk backup folders from time to time
[Magisk] ipdev:
I just double checked on my OnePlus 5T (Lineage 18), when I use the Select and Patch a File option, no backup is created.

Are you booting a patched image, then using the Direct Install option to install?

Cheers. :cowboy:
[Magisk] ipdev:
In a previous post, I mentioned it under a hide tag.

If your boot partition was borked before Magisk dumped it, the backup will be the same borked image. ;)

Cheers. :cowboy:
[Magisk] pndwal:
FWIW, @vvb2060 Magisk Alpha will also:

• Delete the backup file after restoring the boot image.

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85226785 PW
[Magisk] zgfg:
No, I don't take Direct install but I had some regrets and I wrote "more or less":

Now, I checked and indeed, patching by itself does not create backup

However, by the end of every week I update my Xiaomi.eu weekly. I download the new zip ROM, extract boot.img, patch it and then I flash (from TWRP) the new ROM and immediately afterwards the patched boot img as prepared in advance

Xiaomi.eu ROMs always come with the new boot.img (and reflash over the Boot partition), that's why I have to patch that new boot.img and flash it to get the Magisk installed again (Data is not affected hence Magisk database, modules, etc remain).

And the ROM does not have /system/addon.d and the script (refering to another your post, if I understood it correctly) to regain Magisk automatically after the update, but I must flash the patched img manually as described

Hence, my /data/magisk_backup_* folders correspond to those days and time but (rethinking now) not to the times of patching, but (likely, how else?) to the times of first booting after the updated ROM and its patched boot img were flashed

I will pay attention next time when updating my Xiaomi.eu weekly, hopefully by the end of this week
[Magisk] pndwal:
Are you still on Alpha or back to John's Canary atm? PW
[Magisk] zgfg:
All the time on Alpha Jun, 23 (except those two short journeys to Lite last month)
[Magisk] Tom_Scott:
Hi together,

it's currently running Magisk 21.4 very well on my Motorola X4 with Lineage OS 16.1.

Now I am planning to upgrade Lineage OS to 18.1 and my question is does Magisk also be working well on Lineage OS 18.1? If yes, do I have to perform some special steps to get running it with Lineage OS 18.1 coming from Lineage OS 16.1?

Thanks a lot

Tom
[Magisk] pndwal:
Actually, I think my question is irrelevant now. 🤦🏻

I was thinking your mileage may vary from that of others re. backed up images because of this:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85319027

Should have thought a bit longer however; I was thinking it meant 'will delete the backup file after restoring rooted boot image.' (My misunderstanding; doesn't say that.)

Fairly sure now it simply means 'will delete the backup file after restoring the un-patched boot image.'

This may mean after using Uninstall Magisk option to do Complete Uninstall (and may include zip uninstaller option too) or Restore Images only, or both; have no idea yet.

It may also mean that topjohnwu builds failed to remove these files after Complete Uninstall. Again I haven't tested this, but if it's so a less-than-Complete Uninstall would have been an obvious bug for vvb2060 to fix.

Just checked, and backed up images still seem to be accumulating on my device w/ Alpha each time direct Install is used to update, so I now think general behaviour of vvb2060 and topjohnwu builds (Uninstall excepted) is similar at this stage. 😜 PW
[Magisk] PickRickle:
Hello,

I was wondering if it was possible to get Magisk root through TWRP without installing Magisk Manager. Even if that means installing Magisk non-stealthily or modifying Magisk installation scripts. There is a whitelist and we cannot install the app.

TL; DR => Does the system have to be booted to properly install Magisk?

Magisk's documentation has been read, but nothing explicitly mentions this. We're digging through the code, but if anyone is familiar with this issue, it would be a lot easier.

To facilitate research, what does Magisk do in addition to its installation when it is improved by installing Magisk Manager?

One should only "if" it is possible, no matter how difficult it is to achieve it.

(Generic questions, we have a lot of phones)
[Magisk] zgfg:
It must be mentioned in the Magisk documentation and in the Magisk relesse notes

It has also been discussed here many times - hence please, search and read before asking

In short:

- download Magisk application (there is no more Magisk manager but Magisk app since v23)

- rename that apk file to zip file and use that zip file to install Magisk through TWRP (do not rename it to uninstall.zip because in that case it will be used for uninstalling Magisk)

That is the procedure for TWRP for v23

Before v23, Magisk Manager apk and separately Magisk zip were released for each Magisk version, and for the installation through TWRP you had to use that zip file (additionally, there was also uninstall zip file for uninstalling Magisk through TWRP)

As you see, it's now a single file, depending on how you rename it, you can use it for different purposes

Installation by patching is now the recommended method (although it's absolutely not new, it has been described and in use for several years - I personally almost always patched the image and flashed since 2017 or 2018, on several my phones) because there are no (appropriate) TWRP ports for all phones

For example, there are TWRP ports for some devices that do not properly handle encryption on Data and Internal memory, causing users to fail flashing the Magisk through TWRP.

There are also phones where Magisk must be installed to Recovery (not to Boot), hence you obviously cannot have both TWRP and Magisk in the same Recovery.

Not to mention phones for whom TWRP might not be ported yet

However, it doesn't mean that users who do have proper TWRP for their devices with Ramdisk support - i.e., where they can have TWRP in Recovery and Magisk in Boot, could not continue flashing the Magisk through TWRP (on their own risk)
[Magisk] PickRickle:
I thought what I was saying was trivial, but there is a lot of misunderstanding in the answer.

If I install Magisk with the .zip (or flashing a patched boot through fastboot), on our phones I would only have a half installed app that doesn't give me root. We are forced to press in the user interface on the broken Magisk icon and put "install". I spoke about Magisk Manager to make the difference between the application visible in the user interface and the files installed via flashing.

Root is only available if you install the app and grant SU.

I don't know if this behavior is similar on all phones, but on ours it is. In our context, we can't install the app and we can't get root without doing so.

Please, if anything is unclear, say so.
[Magisk] zgfg:
I don't know what 'your phones' are

But I'm saying again, the app is not called Magisk Manager but Magisk App now - if you still have Magisk Manager you certainly did not download and install from the latest v23

I really don't know if Magisk app now installs when you still flash (the renamed apk file to zip file) for v23 through TWRP, or now in that case you additionally have to install Magisk app (since I'm no more using that method, and as said, use TWRP on your own risk)

But there are to many unclear things in your post, so please be clear when asking:

- what is exactly your phone and e.g. Android version (for those who are familiar with your phone, info about the ROM will be much more useful to help you)

- did you previously have Magisk installed (and which version) and did you just want to update Magisk now

- furthermore, maybe you previously had your Magisk Manager hidden/renamed/repackage and you did not unhide before updating Magisk (your problems sound similar to what can happen in that case)

Finally, which Magisk version you're flashing now through TWRP (since, if you did not know about renaming the v23 apk to zip, you're are maybe installing and older version of Magisk or something downloaded from an unofficial source)
[Magisk] PickRickle:
Fairphones 3 and Fairphones 3+. Magisk v23. Android 10. Fresh install.

There is no Magisk Manager, like I said, it was my way of calling Magisk app to make a distinction. Forget Magisk Manager now please. ===> Magisk App.

I'll explain all the steps. I hope this time it will be good.

(0) Reflashing stock firmware if the phone has been used before.

1. Flash the phone with the magisk .zip (downloaded through https://github.com/topjohnwu/Magisk/releases/tag/v23.0) via a temporary TWRP boot. (Or by patching the stock boot.img through Magisk App on the same Fairphone model. Then flash it with fastboot)

2. Reboot to system. (Sometimes wiping caches)

3. adb shell su doesn't work.

4. Touch the Android app icon called Magisk. ===> As you can see, it is this step that not everyone has.

5. Press install

6. Allow installation of unknown application

7. Reboot

8. adb shell su pops up to allow su

9. root available.
[Magisk] zgfg:
Ok, this is about the stub. First time you install the Magisk app (the same on hiding it and unhiding), it asks you to download and install the stub.

But that's really not a big deal - in few weeks you will forget did you have or not to install that stub and all details about :)

(Similarly, if you take Check SafetyNet it will also ask you for one-time downloading what is needed)

Btw, some of us are using Magisk Alpha that was not realeased by TJW but by one of his 'followers', in that case (again, if I recall correctly), there was no need to confirm for downloading and installing the stub

Putting simply, if it asks to do this or that to finish the installation, just do it (and no need to wonder about) - only then the installation process will be finished (before completing that, installation was not finished, hence things do not work as 'expected')
[Magisk] PickRickle:
Aaah first thing I read that put words on the process.

Unfortunately our case is not that simple and I forgot to mention it. There is a whitelist (company fleet) and a factory reset just before the implementation of this whitelist. So there is never a chance to do that "first time" to install the stub.

On the other hand, the Magisk Alpha looks very very interesting for our case. :) I will inquire.
[Magisk] zgfg:
Managed devices is another thing (but not depending on new Magisk

For Magisk Alpha search about here - you will need to install Magisk app Alpha and then (if doing that way) patch again by Alpha - modules and everything will remain

Alpha is again showing as v23001 but it's actually upstream by several commits
[Magisk] mrjuniork:
reddit link shared by John Wu:

reddit post

Especially interesting a comment by the leader of the Android Security team:

Spoiler content hidden.
[Magisk] rodken:
What are the advantages in using the Alpha variant?
[Magisk] HippoMan:
So now we better understand that we have a significant financial incentive to help Google invalidate our attempts to bypass SafetyNet!

Wonderful news! Woohoo! :)

(Because Poe's Law is going so strong these days, I feel that I have to make it clear that my seeming excitement about this is facetious.)

Byebye SafetyNet bypass.
[Magisk] HippoMan:
PS: Because Google is offering so much reward money to help defeat the bypassing of SafetyNet, we can be sure that they are currently making meaningful profits by offering app developers increasingly difficult-to-override SafetyNet protections.

More and more, the difference between Android and iOS is narrowing, with regard to customization capabilities.
[Magisk] ipdev:
Hi. :)

Yes, it is the same on all devices.

Even in the old days of system root, there was some kind of management.

Might have been a system settings sub-menu or a separate app.

This is the same regardless of root access used.

Magisk, SuperSU, phh's SuperUser, ...​

This will be a problem.

The Magisk app is the management for Magisk root and all the Magisk bits.

---

Is this a problem only when you try to install the app using the Magisk stub?

Can you install the Magisk apk file using a FileManager or adb?

You mention using fastboot so, I assume your bootloader is unlocked and have adb enabled.​

1. Flash the phone with the magisk .zip (downloaded through https://github.com/topjohnwu/Magisk/releases/tag/v23.0) via a temporary TWRP boot.

When flashed in recovery, an install script is run. This will patch the boot image along with a few other things including installing the Magisk stub apk.​

1. (Or by patching the stock boot.img through Magisk App on the same Fairphone model. Then flash it with fastboot)

This will only replace the boot image with a patched image. It will not install the Magisk stub apk.​

A stub apk is just a place holder, it is not the full app.

When you select a stub app, it normally requires you to download the current version of said app.

Google uses a YouTube stub apk in their Pixel builds.

The stub is installed into system.

This allows them to set YouTube as a system app even though the full app is in userdata.

[Google goes a step further on their factory builds but, that is even more OT.];)​

The stub app will normally direct you to the full (current) version.

This would normally be PlayStore, or the server for the full app.

4. Touch the Android app icon called Magisk. ===> As you can see, it is this step that not everyone has.

Magisk uses jsDelivr for updates.

jsDelivr - WebSite - Link​

Maybe https://cdn.jsdelivr.net is being blocked on your device?

Hope something in all this gives you a few more ideas to explore. 🙃

Cheers. :cowboy:
[Magisk] DiamondJohn:
Just a random question. If one was to install Magisk & app, assign root permissions to appropriate apps, and then uninstall the Magisk app (where superuser permissions can be turned on and off once a request has been made), would the SU permissions stop working on the assigned apps?
[Magisk] zgfg:
No. You can uninstall Magisk app, but root grants (and Magisk Hide, modules) will continue working.

Of course, you will not be able to grant root to additional apps (there will be no pop-ups).

And you can again install Magisk app, no problem

Magisk db (root grants, Magisk Hide) and modules are not affected by uninstalling Magisk app (or by deleting its cache or data). Magisk app just provides the user interface to manage root grants, Magisk Hide, modules
[Magisk] J.Michael:
Are you in a position to reflash the stock firmware?

Is the whitelist process baked into that firmware?

What do you know about the whitelist? (Where is it implemented? What is it? A list of app names? A list of approved web sites?)
[Magisk] zgfg:
Additional commits by vvb2060 (he started off from TJW v23). He already provided two 'releases' (they still show v23001 like Canary and you have to manually download from his Github)

For Stable and Canary there are no new releases since v23000 (Stable) and v23001 (Canary) - as released by TJW little before he joined the Google security team