yashsingh1/xdaforums huggingface dataset:
[Magisk] fhLan:
sorry for late respond
[Magisk] Didgeridoohan:
I just want to make sure I follow you correctly. Right after flashing Magisk, su works as it should. But after dirty flashing your ROM, it doesn't. Is that correct? Did you reflash the Magisk zip after dirty flashing? Flashing your ROM most likely replaces the boot image, where the Magisk modifications are... You'll need to reflash Magisk after a ROM flash.

If you've wiped everything and reflashed your stock ROM it's no longer Magisk that is causing an issue. Two culprits that come to mind are an unlocked bootloader and/or that you've most likely triggered KNOX. I know next to nothing about Samsung devices (wouldn't touch one with a 10-foot pole), but from what I've seen I do know they're a pain in the bee-hind to modify and tinker with... I wouldn't be surprised if they've upped their game even more with the S8.

About your issues with Magisk Hide: You never said anything about making sure Magisk Hide actually worked. This can easily be tested by adding a root checker app to the Hide list and see if it still finds root ([MENTION=3615867]teddy0209[/MENTION] do we sound a litte like a broken record :D) . Also, check the logs (in the Manager) if everything is starting and unmounting correctly. It's also a good idea to provide said logs when asking for help.

Check my troubleshooting thread for more advice on making Magisk Hide work: https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828

([MENTION=3615867]teddy0209[/MENTION] again: broken record :silly:)
[Magisk] njk45h6:
I've wiped data,cache and dalvik. Is that enough? Magisk Hide worked because I tested it with the SafetyNet and it worked fine. Didn't test with other apps, though. I can't provide any logs now, since I have flashed the stock ROM without any modification, at all. But it still says I have installed unauthorised software.

The bootloader is the stock one and I've also disabled the OEM unlock.

I even tried to use Smart Switch and did anemergency software recovery initialisation and chose device reinitialisation on the smart switch menu bar. It downloaded and installed the firmware but it still says I installed unauthorised software. What should I do? :crying:
[Magisk] Didgeridoohan:
With all the uninstallations, wipes and reflashing of your ROM I can pretty much guarantee you don't have Magisk on your device anymore.

Many apps look for more than just root and some things that Magisk Hide doesn't hide out of the box (see the link in my last post), or can't be hidden at all. I'm suspecting that you have KNOX issues... Check with a KNOX app from the Play store. If it's triggered, I believe you're out of luck. I don't think there's currently any way of reverting a triggered KNOX counter. Your device forum might have more info.
[Magisk] njk45h6:
OK. I found out what the problem is.

The problem is that I have WARRANTY VOID: 1 (0x030c), even though the system status is "Official". This is because I've rooted my phone previously. Now, I contacted Samsung and they said that value cannot be changed because it depends on a motherboard's chip and the only way to solve it is to send it to them and replace the motherboard (out of warranty).

Do anyone of you know if this can be solved otherwise?
[Magisk] teddy0209:
Lol... Yeah, that's why sometimes I just stop replying... You have a better temper dealing with them than I am... ???

---------- Post added at 08:48 AM ---------- Previous post was at 08:42 AM ----------

If your problem is returning to stock to be able to take an update... It is better to go to your device's forum...

Edit: though I have an idea, it might not hold true to your device since you have a samsung, I have got my hands on most oems except this one... Just do a research, I'm sure something will come up...
[Magisk] njk45h6:
I tried searching but there's not so much info since the s8+ just came out.
[Magisk] DEVILOPS 007:
Yes, I reflash Ed everything. Although, the first time I booted up I flashed the rom, gapps, kernel and magisk. I did that to see if it worked. After it worked I dirty flashed but flashed some extra stuff like v4a and busybox.
[Magisk] Kireto00:
Pls help me

pls help me
[Magisk] Wire1122:
Can't flash magisk on lg h840 with nougat 7.0 through twrp. Can't mount data ecc... This is my log
[Magisk] teddy0209:
Is data mounted in twrp?...

---------- Post added at 11:36 AM ---------- Previous post was at 11:35 AM ----------

Try flashing modules in twrp...
[Magisk] Kireto00:
Must i back data first with nanoback or that wont be dangerous ?
[Magisk] Wire1122:
Mount data in twrp is greyed out, can't select to mount
[Magisk] teddy0209:
Mounting data should not do any harm.... Backup before you flash anything...

---------- Post added at 12:04 PM ---------- Previous post was at 12:02 PM ----------

Then just go to your device forum/twrp dev for further help....
[Magisk] Kireto00:
Must i mount zip or flash zip with twrp ?
[Magisk] teddy0209:
Flash... ?
[Magisk] rignfool:
Ok...

You are so far off topic... It's disgusting...

TO YOUR DEVICE THREAD HEATHEN!

And I think what you have is a tripped Knox...
[Magisk] langkhack18:
Is it this one?
[Magisk] elektm:
I already flash magiks V12 in my custom ROM Samsung S5 , i already tick magiks hide and reboot my device, after that i test safetynet is still on failed, can some body help to give me a solution ..:confused:
[Magisk] culiacanazo:
Didge, someone's at the door for you. I think he wants your signature
[Magisk] elektm:
There are only 1 supporter petition signature..haha:eek:
[Magisk] DodoGTA:
:D, Señor Miembro (#googletranslate)
[Magisk] elektm:
All by custom ROM Finally Note 3 done... But another phone S4 uncertified, CTS mismatch
[Magisk] teorouge:
Hello guys, sorry if that's been answered before but I'm on mobile and couldn't find anything relevant.

Now, I have latest Magisk working fine on a 5.1 CM12.1-based ROM, only issue is I have to activate root for advice and apps when I reboot the device (LeTV X800). No modules loaded, MagiskHide active. Thanks for any help!

Inviato dal mio One utilizzando Tapatalk
[Magisk] DodoGTA:
Go to Settings > Developer options (They need to be unlocked, though: http://www.greenbot.com/article/245...-options-on-your-android-phone-or-tablet.html) and change "Root access" option to "Apps and ADB"
[Magisk] dantexaiver:
What if I want to continue using Chainfires root can I still use magic?
[Magisk] DodoGTA:
Yes (Magisk Hide isn't compatible with SuperSU, though)
[Magisk] TanByv:
leet number of pages. Well hello!

1337
[Magisk] Didgeridoohan:
That needed some backtracking to figure out... Would have been good if you had posted some context to that. :laugh: Had to look through your profile to see your previous posts in the other thread before I figured out what was going on. :p

Yeah. You've got issues... I'd flash the Magisk uninstaller, restore your ROM's stock boot image (just in case) and then reflash Magisk. Save the recovery log from that installation and post it if there are issues. With some details this time, please. :D

Where do I sign? :silly:

---------- Post added at 20:39 ---------- Previous post was at 20:35 ----------

And your post is #13365. If you divide 13365 by 1337 you get 9.99 which divided by 3 is 3.33.

Half Life 3 confirmed!
[Magisk] ken_0200:
Root access not properly installed

So I rooted my phone the normal way i.e. Not systemlessly. Root was properly installed because I've checked with root checker multiple times before and after installing Cyanogen Mod and I've been rooted for roughly 2 years now. I also have xposed framework installed (again, not systemlessly) on my phone and it's working properly. I installed the magisk manager (xposed was also installed on my phone) just to see what it was all about. After installing magisk, I discovered that there aren't too many modules and that I'd have to install xposed systemlessly for more modules. Because my phone is rooted the normal way and because I already have xposed, I uninstalled magisk from the manager app. But after the reboot, magisk manager said that root is not properly installed on this device. So I thought its a bug or something and deleted the manager. To make sure I still have root access I installed root checker and sure enough, it also said root in not properly installed on my device. This is the first time I've seen this. But xposed and all the modules are working, which I assume means I'm still rooted, right? So why is root checker saying I'm not rooted? Help?

I have a Samsung Galaxy S3 and cm 13 (Android 6.0.1) if that helps.
[Magisk] DodoGTA:
Xposed doesn't require root to function (but installling Xposed requires root)
[Magisk] langkhack18:
Tks for your respond :D sry for not much information. This happened after the lineage os build with new firmware (i lose root after flashed this which didn't happen before). Before that i used the su addon and magisk still worked fine.

Btw after I flash the magisk uninstaller, do i have to dirty flash the current build i'm using? (How to restore rom boot image as well? T.T)

Thanks for your help :highfive:
[Magisk] Didgeridoohan:
When you installed Magisk it replaced your system root with MagiskSU. Magisk works with it's own root solution or with systemless SuperSU, take your pick (you inadvertently did when you flashed Magisk with system root installed). Uninstalling Magisk also uninstalls MagiskSU = no root.

---------- Post added at 21:14 ---------- Previous post was at 21:12 ----------

Dirty flashing your rom should work. You can also extract your boot image from the rom zip if you wan't to flash it separately (in recovery). Also, there's a known issue with Lineage OS where you might lose root if you enable Magisk busybox in the Manager settings.
[Magisk] FlareHeart:
Apologies if this has been asked already, but my searching didn't find it.

I am using a Nexus 6p running stock 7.1.2

I flashed stock bootloader, boot, and system (just to be safe)

Then I flashed TWRP 3.1.0.0

Booted into TWRP

Flashed Magisk 12

Now somehow I have Magisk installed but no root? What did I do wrong?

I got it to work. For some reason reflashing it (for the third time) but actually clearing the cache this time fixed it. So for anyone else that stumbles on this problem, clear your cache!
[Magisk] ken_0200:
So now i either re root my phone the normal way or I systemlessly re root it. Anyways thank you!
[Magisk] n3kf:
Running an old Nexus Grouper with a custom Nougat ROM. Magisk roots fine. If I hide Magisk and run the safety net check, get the CTS mismatch error or sometimes the safety net check never completes. The ROM developer is fine with adding changes. What is needed to be posted here to help determine what the problem is. Thanks.

This is the ROM thread by the way

http://xdaforums.com/nexus-7/development/rom-android-7-aosp-grouper-t3467514/page134
[Magisk] langkhack18:
I flash the magisk uninstaller, then dirty flash the latest lineage build (the one i'm using), then flashed magisk v12. Still no root this time. The log is below
[Magisk] ajm786:
I thought the same thing, so I decided to test the theory. I downgraded the bootloader to the older version (3.67 from April), and booted into the ROM. What do you know: it broke. Same thing happened in Magisk Manager: CTS profile mismatch. Android Pay removed all credit cards and had an error that it couldn't be used on the device.

Rebooted to bootloader, upgraded to 3.68 May version, booted into the ROM, and it's fixed: Magisk Manager passes SafetyNet and Android Pay works.

So it's definitely the bootloader causing this issue. Bottom line is to make sure that if a security release happens to include an updated bootloader/modem, install it.:D
[Magisk] teorouge:
Unfortunately this didn't work, when I reboot I always have to re-enable superuser access in Magisk settings. :/

Inviato dal mio LeTv 1 Pro utilizzando Tapatalk
[Magisk] elektm:
I have a same problem also, after I flash uninstall magiks.zip in recovery mode, that is no root for my device, I try to uninstall magiks manager in PlayStore and reflash latest SuperSU version 2.79.zip then my device root come back again.

Then i come back to install magiks manager reflash magiks v12.zip, reboot and tick in setting magiks hide, reboot again, check back magiks manager, magiks install pass, magiks sure pass , safetynet pass , PlayStore certified, and SuperSU still can run that's only can't not update binary on SuperSU, my exposed also no problem, my device is note 3 SM -i9500 , Android 6.0.1 ,using darkwolf ROM S7 edge.

But i try to my Galaxy S4, that only Safetynet failed, still in root, now I try to find the solution to this problem, don't know what happens:confused:
[Magisk] teddy0209:
It's clearly stated there, root was not systemless... So what happens then? Magisk is systemless and requires systemless root... So if you install magisk, it will remove the system root and replace it with systemless (magisksu)... If you uninstall magisk, then that will also remove magisksu at it is part of magisk, so you have to re-root... From where you downloaded magisk, all are written there, it just means you skipped the readings...
[Magisk] elektm:
Loo

Now the problem is not skip reading(This thread got thousand post to read +others thread ) or whatever, just want a straight forward solution, now my problem is same procedure to install Magiks Su, one of the phone is no problem as and the other one failed
[Magisk] teddy0209:
No need to read a thousand post... It's just a few pages.... But yeah, I've read these thousand pages since I followed it from the very beginning, it won't hurt if you read just the release notes by the OP...

Edit: magiskhide only works with magisksu, so if you have rooted with supersu, you have to properly remove it prior to flashing magisk (to avoid any problems)... Whatever method (manually, from app, unsu zip)... You won't be needing the supersu app, as magisk manager manages magisksu, so might as well remove it...

---------- Post added at 06:03 AM ---------- Previous post was at 05:36 AM ----------

Can you post a screenshot of the magisk manager?... Try wiping data of the manager, then flash magisk again in twrp..
[Magisk] Didgeridoohan:
Cool! :good:

Thank you for taking the time to test it. I had planned to confiscate my wife's N6P to replicate the exact circumstances, but now I don't have to (and she won't kill me when I mess up her phone).

Now I'm gonna have to torture my old N6 a bit though to see if I can replicate the issue there...

Edit: No issues on Pure Nexus 7.1.2_r8 with earlier than May bootloaders. Investigation will continue... I might have to steal my wife's phone. :eek:

---------- Post added at 08:00 ---------- Previous post was at 07:41 ----------

Looking at your log it seems like you have some kind of issue with the Magisk image (creation or mounting, I'm not qualified to say). I've seen that before, but can't remember right now if we managed to find a solution.

In TWRP, use the file manager to navigate to /data. Confirm that the Magisk image is there (magisk.img).

Flash the Mount Magisk script from the Collection of modules thread and see if you can navigate to /magisk and if it contains anything.

Don't forget to save (and share) the recovery log if you need more troubleshooting help.

You could also try one of the latest beta snapshot from the unofficial snapshots thread, to see if they work. Disclaimer: The snapshot builds may not be stable... And as always, if it doesn't work as expected and you need more help, logs. :D

Start by going here:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828

Take a look at the various tips collected and try the one's you find to be applicable to your case. If you can't get it to work, come back with a thorough report as to what you've tried and logs, lots of logs (at least a Magisk log).
[Magisk] Wire1122:
with lg h840 3.1.1.1.0 twrp magisk install perfectly
[Magisk] :
Hi guys, sorry for the noobish question, but is it normal that as soon as i install a module the CTS check fails? With no modules it passes. LG G3 + Latest Fulmics Rom + Magisk v12.0.
[Magisk] Didgeridoohan:
Depends entirely on the module in question. Might be that Magisk Hide doesn't start properly on boot. Check the log and toggle Hide off and on again in settings.
[Magisk] langkhack18:
Hi the 1st one didn't work out. There's file magisk.img and some files in /magisk as well

The second method using snapshot, i did get root, but the magisk manager said that the magisk is not installed (v13)

The log is below thanks

Update: if i install v13,i'll get root but magisk manager said the magisk is not installed. If i install v2, there's no root but the manager said the magisk is installed. Also there's a notification: Install superuser. The su binary is out of date
[Magisk] swa100:
Wiping batterystats.bin with this app: https://xdaforums.com/android/apps-games/root-battery-charge-limit-t3557002 does not work with magisksu installed. Anyone knows how to fix this? Would be much appreciated!
[Magisk] Didgeridoohan:
The app probably needs to be updated to work with MagiskSU. Meanwhile, you could try this: https://xdaforums.com/apps/magisk/magisk-suxinbind-t3564673
[Magisk] teddy0209:
What date of the v13 did you use? Some of the builds are not working correctly... You mention the update binary, do you have other superuser app? You have to remove that...
[Magisk] swa100:
Thanks for the tip! Installing that module causes safetynet check to fail unfortunately. And wiping the battery stats still doesn't work.
[Magisk] langkhack18:
I'm using the v13 1205 build. I removed it tho, but the manager still say magisk is not installed. But when i check the safety net is passed?
[Magisk] teddy0209:
You have to download the 0512 apk too...

Edit: I'm currently on that build with MIUI dev rom, but I still can't figure out how can I enable magiskhide... Lol...
[Magisk] Didgeridoohan:
In that case you should probably ask the app developer if the app can be updated to work with MagiskSU.
[Magisk] langkhack18:
The latest apk i can find is 0225 lol:?

Anyway i can still pass safetynet?

---------- Post added at 10:26 AM ---------- Previous post was at 10:07 AM ----------

Edit: so now i have root w v13 0512, but i can't have magisk installed T.T
[Magisk] teddy0209:
I thought you passed?... It is there, just scroll down...
[Magisk] Didgeridoohan:
Try this: https://xdaforums.com/apps/magisk/u...beta-built-t3521901/post72277148#post72277148
[Magisk] Skeleth:
Hi

I wanted to get rid of my root on Desire 820 (bad buy) but I couldn't find the stock ROM for it to flash and unroot so I tried to use Magisk

Installed it from Magisk Manager, still cannot pass the certification

Tried to use this guide but when I try to flash magisk v12 I get error 1 and cannot continue. Still cannot pass the certification even though I unrooted. Help please.
[Magisk] langkhack18:
Ayy everything works now, thanks you guys a lot :D i wonder why the v12 doesn't work :|
[Magisk] DEVILOPS 007:
Can I have some help please. Basically, I flashed magisk and updated the app and root wasn't working. I then enabled the busybox option in settings and rebooted and root worked fine. However after doing a dirty flash to an updated version of my rom and nothing else root no longer works even after a reboot. Am i missing something?
[Magisk] Svirusx:
Is there in Magisk module like Fake Wifi Connection in Xposed but for hide VPN connection from apps? I need something like "Apps thinks they are connected to internet without VPN"
[Magisk] olbc:
I have a problem with Magisk Hide. I enable an app for hide and if I start next time Magisk and have a look into Magisk Hide, the App is disabled. I found no way to safe the setting. What is to do?

Android is Nougat, Magisk ist Version 11.6, Xposed is not installed. Phone is a Moto G5.
[Magisk] teorouge:
Hello those are my specs and logs, as I mentioned before I always have to re-enable root access in Magisk Manager after a reboot; I've been suggested I check in Developer Settings for superuser access so I fiddled with that setting, I reboot and now it disappeared in Developer Settings completely. Thanks for any help!http://cloud.tapatalk.com/s/59184b018c9a6/magisk_error_20170514_141143.log.zip

Inviato dal mio LeTv 1 Pro utilizzando Tapatalk
[Magisk] teddy0209:
Good to know it's working for you on LOS... The hide function does not work on MIUI...
[Magisk] langkhack18:
Tks.. it seems like the busybox function has been removed in 0513 apk..
[Magisk] teddy0209:
???... You need to reflash magisk, just magisk... Flashing an update/rom over your current will replace the boot.img, does removing changes by magisk...

---------- Post added at 01:32 PM ---------- Previous post was at 01:28 PM ----------

Does the app appear in the log? Does it still detect root?

You can also try manually adding it to the list...

---------- Post added at 01:34 PM ---------- Previous post was at 01:32 PM ----------

Yes it was...
[Magisk] DodoGTA:
Busybox is automatically installed in Magisk Manager v5.0 snapshots
[Magisk] seacowx:
Just flashed the "Mount-Magisk.zip" from magisk module collection thread.

Flash successful within twrp, but i couldn't find the "magisk_mount" folder in /cache/magisk nor /data/magisk.

I've used search also, no such folder exists. *log attached

Do i missed something?

> Since magisk_mount not exists, I need to change my bootanimation. Can i just manually replace bootanimation.zip over the current one in /system/media/ ? Thank you.

Edit: sorry, convert log to .jpg for quick view.
[Magisk] olbc:
---------- Post added at 01:32 PM ---------- Previous post was at 01:28 PM ----------

Does the app appear in the log? Does it still detect root?

You can also try manually adding it to the list...

I can´t see the app in log. Yes, root is ok. How can I adding manually an app to the list?
[Magisk] teddy0209:
Magisk Mount is used to mount the magisk.img in twrp, so you can remove a problematic module... ?... About the boot animation, you can use magisk to set a new one... Manually or through the module template...
[Magisk] seacowx:
Thank you for quick answer.

Oh, my bad. i must be misread the OP in magisk v12 main thread. Or.. do i need create the folder manually in dir /cache/magisk_mount/system/media/ ?

It says:

"Magisk no longer let you install cache modules, you have to manually add the files you want to replace, which is actually super easy.

You can place your new files into the corresponding location under /cache/magisk_mount, Magisk will automagiskally manage selinux contexts, permissions and the mounting for you.

For example, you want to replace /system/media/bootanimation.zip, copy your new boot animation zip to /cache/magisk_mount/system/media/bootanimation.zip with any root explorer, Magisk will mount your files in the next reboot."
[Magisk] mg_jishad:
Anyone send me link for v13.
[Magisk] fmc000:
That's what i thought too and I actually enabled $CACHESUPPORT . It seems that it's not enough and that I should have played a little more with the update-binary script and possibly something else.

I'm looking for hints ;)
[Magisk] serubin323:
Removing deep_buffer did the trick. I modified the Viper4Audio script to remove it. See the attached zip.

[MENTION=4470081]topjohnwu[/MENTION], if you want to update your module in the OP with this, feel free, I modified your original module so the changes are just for deep_buffer. It'll clear up a lot of issues with audio processing.
[Magisk] rignfool:
Only problem with your script is it modifies the system partition...

I'm no edify master... But if you were to copy then edit the audio_policy.conf... In the magisk directory... It would leave system untouched...

Just food for thought...

Also... Removing deep buffering solved the processing issue for me as well... Thanks for the heads up

---------- Post added at 11:00 PM ---------- Previous post was at 10:58 PM ----------

@topjohnwu

How about some kind of backup for our magisk partition?

On a clean flash, magisk is wiped... And well... Modules don't always work on the first try and require editing...
[Magisk] serubin323:
Did you look at the script? It doesn't touch /system