yashsingh1/xdaforums huggingface dataset:
[Magisk] CrazyCypher:
You are kidding, right? I can understand how Chainfire take this as an insult but come on... Are we all 12 years old? People who are mature solve things like this through "I am sorry" and the other one say "Appology accepted, dont let it happen again" And they move on. I always admired Chainfire but to immediately hold a grudge seems a bit...i dont know. I bet it is just current anger..

I am in the architecture bussiness and if I create a project that has some flaws that I dont know how to fix or I dont have time to, sooner or later those issues will be fixed by others. And after that new projects will emerge that include best of my project and best of theirs. And I cant complain, it was my fault that this happened and I know that I should have thought things through better :)

The only way to really achieve the true potential of you guys, amazing developers, is if you work together..dont be egoistic but help each other!

Like you wrote, I also hope you will work together in the future and develop some amazing things for the world of android :)
[Magisk] siren_shadows:
What the hell? Why are you apologizing for doing great work that Chainfire didn't do before you were here? I prefer your solution to dealing with Android Pay, and I use it all the time. It's been really helpful at university. I have one question relating to the manager, though. Is there a way to set it to disable root by default at startup? I prefer keeping root off unless I expressly need it, for security purposes.
[Magisk] zozotintin:
Bro keep it up!
[Magisk] benwalburn:
Drama like this doesn't belong in Android development. You did a great job from the beginning, you don't owe anyone an apology. I don't see you trying to get Chainfire to apologize for using your work in creating systemless SuperSU. Modifying someone's work for compatibility isn't wrong, it's a service to the original developer. Chainfire is dead wrong here and should reserve his drama for Nexus Mods or the Jailbreaking scene.

Most of us understood from the beginning that any attempt to fix Android Pay would not last. We all appreciate your work, especially since you can't even use Android Pay yourself. Seeing as you're doing all this for free, you shouldn't view any part of it as a waste. Development like this is it's own reward, and can serve you later in life.

You put a ton of work into this, and maybe it didn't work out perfectly but sometimes the work is more important than the results. If you're done, we'll all come to terms with it. It was a good run. I just hope you don't see your work as a waste because in the end it's only your opinion that decides the value of this type of work.
[Magisk] JudgeDread11:
[MENTION=4470081]topjohnwu[/MENTION], I have been using magisk almost from the start not because of Android pay but because it has great potential as a framework.

Android is popular because of the ability to customize. YOU brought that ability to a while new level.

Where chainfire and rovo where looking for solutions to benefit their work you looked for and found a solution to benefit the whole XDA community.

If some members of that community can't appreciate that then they should look at themselves and rethink what they are doing and how they started.

In my personal opinion SuperSU has had a monopoly on root management for way too long already. It is time that other solutions get some focus. A bit of friendly competition keeps development active and creative. I also dislike the Apple marketing Chainfire uses. Apps that only work with his solution, which goes completely against the flexibility Android stands for.

Like you i admire his work and can only say that he has excellent developing skills, but I feel he seems to have lost the connection with what most of the XDA community stands for.

You might not have his developing skills yet (our maybe you're just to modest) but you have the creative mind and the week to work for your community rather then just for yourself.

Only 1 person invented the wheel, the rest of the world based their ideas on ideas of others. Don't blame yourself from learning from others.

I hope you won't give up on this great project completely.
[Magisk] Droidphilev:
[MENTION=4470081]topjohnwu[/MENTION]

Don't let anyone or anything bring you down! Many people have much respect for you and all the things you made!
[Magisk] xdddd23:
Snapchat can detect the xposed systemless?
[Magisk] Kris6699:
Yes, snapchat doesn't detect xposed, it detects the framework files themselves.
[Magisk] Dyspr0sium:
I much prefer Magisk to suhide, [MENTION=4470081]topjohnwu[/MENTION]! In my opinion it's a much cleaner solution.
[Magisk] ianmacd:
Apart from the small detail that systemless SuperSU predates both Magisk and systemless Xposed, you don't actually see Chainfire trying to elicit an apology either, do you?

My point is that whatever Chainfire communicated to topjohnwu, he did so in private, which is as it should be.

I don't see anything at all from Chainfire on this subject, dramatic or otherwise, so I would say that it's best to reserve judgement about the content of a private conversation one has no knowledge of.
[Magisk] Fedroid:
Please continue Magisk, Is the only solution I found to use my bank app having root.

Have you based your work on other's work? So, what's the matter?

Your concept and your idea is yours and always it will be.

I have a dream, an advanced version of Magisk with mod installer, etc...

Don't leave the project. Focuse on this:

Is the only way to receive Otas and update keeping everything, like xposed etc

It was amazing when I changed my Rom and saw how everything was still there.

No words can express my feelings.

Never give up.
[Magisk] serubin323:
I just want to add in addition to what everyone else has said: What you have done is not only create a way to allow for the android system to be modified without actually changing /system. But you've created a way to modify a device that is far far less dangerous than if you were to flash directly to the system.

This way, if you flash and bootloop, all you have to do is revert the Magisk to a previous version and you're all set to go. The downtime is far less and it means that flashing mods won't break your phone requiring you to reflash the entire system.

You're a university student - you're new at this. Everyone makes mistakes, learn from them and keep doing the amazing work you are doing.
[Magisk] gohamstergo:
Not necessarily a good thing that [MENTION=631273]Chainfire[/MENTION] is silent. He could have just wanted this quiet so he wouldn't look like a villian, which he currently does. Big dev using small dev's work without credit, big dev making small dev want to quit (whatever was said). So, if he was smart, he'd give his side since the pitch forks are already on standby. Not saying I think he's a bad guy, he's done amazing work. We just don't know and that's a risky thing...people not knowing...
[Magisk] radii:
please continue to develop this software....it is great.
[Magisk] culiacanazo:
Sorry, about what?

---------- Post added at 04:41 AM ---------- Previous post was at 04:32 AM ----------

Yes it can. It has. I've shown it here before.
[Magisk] crazyc78:
Hello I'm currently running V11.6 on a rooted LGV20 my model is the H918 T-Mobile version. I'm having issues updating to V12. When I update through Magisk manager, I get the prompt to reboot my device and it does not reboot. I have an advanced power menu that utilizes root and I also cannot use that after installing V12. So since I can't reboot through software I do a battery pull. Usually after install it has never taken long to reboot the phone after installation. I will hit the reboot button and the device reboots and I'm good to go. If anyone has any suggestions or tips I'm all ears. Thanks
[Magisk] Xennet:
A general question

A have tried this multiple times and failed

I am on OnePlus 3t with twrp 3.1.0-1

I need OOS STOCK ROM ROOTED WITH MAGISK

I first flashed stock full ROM via twrp

Then without rebooting I tried installing magisk zip but each time it fails

Then I am forced to reboot which triggers DM Verity because I have not rooted

After booting up and then rebooting to recovery twrp I am able to flash magisk zip

But that triggers DM Verity

Each time I do this same thing happens, cannot flash magisk immediately after flashing stock ROM

But I am able to flash supersu immediately after flashing stock ROM

In short with magisk I am having DM Verity triggered

But with supersu no DM Verity message

Any ideas to get root with magisk on stock ROM immediately after flashing so that I can have root before the first boot
[Magisk] dodendemise:
If anyone is interested PlayStation Vue works on 11.6. I updated to 12 and it stopped working then went back and it worked again. I'm gonna stick with 11.6 now.
[Magisk] marbertshere:
On that same note, do you think it would be possible to toggle Magisk hide with Tasker? Only reason I ask is because when I had it enabled in the past I would lose root.
[Magisk] mchapa489:
Thank you that helped a lot. How do I get the safety net to pass?
[Magisk] AtlasRedux:
Basically, there is absolutely no reason to update if it works.

12.0 has a lot of problems for many, but also fixes it for many. 11.6 is the ONLY version I've EVER gotten to work on my Z3+ :P
[Magisk] siri21:
Before? What ver. of magisk? How long ago was that? Safety net API do update to detect systemless xposed if Im right...
[Magisk] culiacanazo:
Next tasker update addresses it, I've heard

---------- Post added at 07:03 AM ---------- Previous post was at 07:01 AM ----------

Not too long ago, I've got two roms in my device, right now on 7.1.1, so i can't tell... Anyways, not that many pages ago
[Magisk] teddy0209:
No place for that here...???

Disable it...
[Magisk] Didgeridoohan:
Several LG V20 users have reported issues with Magisk v12. Might be an incompatibility, but I don't think I've seen anyone open a GitHub issue about it with logs and a boot image copy.

I'm having no issues flashing Magisk v12 on my OnePlus 3T with stock OxygenOS 4.1.1. I've tried both with the stock boot image and with Franco Kernel... I only get the warning about an unlocked bootloader, nothing else...

You can use a the Run Shell action to run the enable and disable files in /magisk/.core/magiskhide

He's talking about using Tasker to enable and disable Magisk Hide. I believe you're talking about Tasker not recognising MagiskSU. That'll be fixed in the next version of Tasker.

Don't... Just, don't... That's not allowed here, and for good reason...
[Magisk] FantasyFlow:
Hi guys,

Just fyi, V12 is working well for me so far.

*SafetyNet passed, Magisk Manager all-green.

*Titanium Backup freeze and defrost features work.

*Pokemon Go ok.

I'm on Samsung Galaxy S7 (sm-g930fd dual sim)

Thanks to the team and cheers!!
[Magisk] reversegear:
Hey there

your problem is solved now...?

can u upload the safetynet helper screenshot.
[Magisk] bland.life:
Just experienced a relapse of the missing webview problem with v12 but it solved itself with a device reboot.

During the relapse Developers Options is still there but the Webview option is empty.
[Magisk] crazyc78:
Ok thanks for the response. It's happened to me four times trying to update to v12. I am not a noob been flashing roms for some time now just never have done a logcat file bwfore or boot image copy if you could pm on how to do that would be awesome. For now I'm staying on 11.6 until it's confirmed working stable for the V20. Thanks for your input I appreciate it. :):good:
[Magisk] rajbsn:
Did any one able to use Balckberry Work App with Magisk? I badly need this app on my rooted V20 and any leads will be greatly appreciated.

https://play.google.com/store/apps/details?id=com.good.gcs&hl=en
[Magisk] aer0zer0:
[MENTION=7182553]culiacanazo[/MENTION]
[Magisk] biggdevon:
So far you are the only one that I've seen. Jealous...
[Magisk] teddy0209:
We know it can't be hidden with just magisk... ???
[Magisk] Captain_Throwback:
No, it can't. You coming in here and telling people you've done it isn't helpful, and is just confusing.

It works for you because you're using microG, and that's the real reason you can pass with Xposed enabled, not Magisk Hide. So let's please stop playing this game? [MENTION=4470081]topjohnwu[/MENTION] has already stated that Magisk Hide cannot hide Xposed. It's not designed to be able to do so. That's a fact. I've mentioned to him that perhaps he can figure out a way to disable Play Services and emulate microG to get it working for everyone, but that's a long shot right now. It's also not high on the priority list, as many devices are on Nougat now and Xposed isn't yet available for Nougat.

So can you please stop telling people it works, when it really doesn't without some heavy modifications?
[Magisk] sonysingh1983:
I don't use Android pay and have never tried to pass safety net so I can't help with that. But there should be some tutorials if u look in XDA or even utube.
[Magisk] ali nz:
How can we use multirom with magisk? Is it possible?

Sry for noobiness
[Magisk] Didgeridoohan:
https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] culiacanazo:
What's who where?
[Magisk] m1kh41l:
Stuck at "Starting Magisk Hide"

How to fix this?
[Magisk] culiacanazo:
Did i make it a secret i was using microg? Uhm, no.

Have i lied in all I've said? Uhm, no.

Can i stop? Yes, i hate seeing grown men cry.
[Magisk] Didgeridoohan:
Over there.

No idea... Try flipping your phone clockwise three times next Thursday. Sorry... Bad sense of humour...

We'll need some more info or it'll be hard to help. Device, ROM, Magisk version, recovery log from installation. Those are a good start.

Edit: And a magisk log with verbose logging enabled.
[Magisk] m1kh41l:
My device is kenzo, Nitrogen OS rom 7.1.1

And how to get recovery log from installation?

Thanks in advance
[Magisk] culiacanazo:
[MENTION=3615867]teddy0209[/MENTION] [MENTION=2437714]biggdevon[/MENTION]

For the first two guys, read the third...
[Magisk] culiacanazo:
Yes, Sir!
[Magisk] Citizen_Snips:
Just stop. They said, in general terms that Magisk cannot hide Xposed (which is true). Your reply was "Yes it can. It has. I've shown it here before."

Your post implies that Magisk is able to hide Xposed on a general basis. It cannot. 11/10 times people are not going to sift through your post history to see it is only 1, very specific setup. This is XDA, after all. They'll see your reply and spam the thread on how to use Magisk to hide Xposed. Unless someone is on that exact setup, they cannot.

That counts as spreading misinformation.
[Magisk] culiacanazo:
Aye, aye, officer!
[Magisk] UltraGamerHD:
Can't seem to get V12 of Magisk to work correctly. I'm using a Samsung Galaxy S6 running 6.0.1 stock. I flashed Magisk V12 after a Clean Flash and I get no root. Is there anyway to fix this?
[Magisk] hgoldner:
Just want to say that I rolled all the way back to pure stock on my Verizon 10 to take the Nougat OTA and found, much to my frustration, that Android Pay didn't work on stock! Switched back to TWRP Recovery, flashed Magisk, enabled Magisk Hide and everything works just fine, thank you very much. It's a strange world when stock is broken and the dev's work fixes it, aint't it?
[Magisk] Clandaries:
G935F (Galaxy S7 Edge) DBT Open Germany working nicely with Magisk 12.

Thank you :)
[Magisk] Nuhro:
To use Magisk for systemloss Root.

To flash the Magisk.Zip (Version 12) is sufficient? Or do i have to flash SuperSU or PHH also?

Thanks
[Magisk] Jolt151:
Does anyone know of a short tutorial or something similar to get started on making mods for magisk? I don't really have any experience with making my own mods, but there is an Xposed module called Remove Battery Saver Warning Color that I want to try to get working on magisk. Alternatively, could someone create something like that for magisk for me? :P Thanks
[Magisk] biggdevon:
https://xdaforums.com/apps/magisk/magisk-details-dummies-to-developers-t3473486/

Edit: didn't mean to link a direct post
[Magisk] culiacanazo:
Sufficient

---------- Post added at 08:07 PM ---------- Previous post was at 08:06 PM ----------

Are you on marshmallow or lollipop?

Edit, my bad, i meant to quote [MENTION=8184943]Jolt420[/MENTION]
[Magisk] Mezabaru:
Anything passed the 28th beta snapshot to official v12 gives fail for switching from permissive to enforcing, has anyone had this issue as well. 11.6 official and the March 27 beta are only two I don't have this issue with currently. If you have any clue please tag me and I'll get back to you with any requested dumps.

I'm using an SM-G930W8 Samsung S7 on latest superman ROM and Superstock kernel
[Magisk] Jolt151:
Marshmallow, but I want to update to Nougat soon, because I found magisk replacements for the main modules I use - YouTube adaway and YouTube background playback.
[Magisk] nadim365:
I have a Nexus 6p running nitrogen os which has superuser installed by default and want to remove it and install magisk so how do I install it ? Just like the normal method or is there any process ?
[Magisk] gk1984:
delete... fixed the issue
[Magisk] dimm0k:
one of the reasons for me to use SuperSU is because of the way it handles the prevention of the device encrypting the data partition. not exactly sure what the proper terminology is other than after rooting I need to format the data partition in TWRP so that it's usable in TWRP. is it possible to cleanly remove SuperSU and switch to MagiskSU while still having this capability?
[Magisk] aer0zer0:
wait, so stock .12 is broken as well?
[Magisk] hgoldner:
I am not prepared to say that this is so without qualification. I was originally on Marshmallow with ElementalX and Magisk, using [MENTION=1331268]santod040[/MENTION]'s "stock 1.85.605.9." My device reported that the update from .8 to .9 had failed. While I took the Nougat OTA, installation failed, even though I had restored 'stock" recovery and boot. So I used [MENTION=3472611]dottat[/MENTION]'s RUU to roll back to .8, took the .9 OTA update, then took the Nougat OTA update both of which worked directly from Big Red. The result, however, was kludgy, so I did a full factory reset. After the factory reset I found that I could not add a credit card to Android Pay (it gave the usual warnings I have encountered on other devices and test devices which never run Android Pay). At that point, the only way to get it to work (thanks to [MENTION=1162986]Captain_Throwback[/MENTION]'s suggestion) was to flash TWRP and Magisk, then use Magisk hide which, as I said above, works.

YMMV if you are coming from a "pure" unmodified stock device. I can't definitely blame anything in particular for the anomaly, except to say "problem solved" and "thanks to the devs."
[Magisk] Artim_96:
... So you mean that you don't want Android to reactivate device encryption? Just install Magisk. Especially if you install it through Magisk manager and don't explicitly activate "keep force encryption", it won't reencrypt on the next bootup
[Magisk] dimm0k:
I'm not exactly sure if it is device encryption? I thought device encryption would require a password to use, but I'm never asked for a password. Going into TWRP it does ask for a password to access the /data partition even though I never set one. I also don't see the option for "keep force encryption" in Magisk... can you give more details?
[Magisk] Doc Franky B.:
I'm on magisk v12.0 with an Note4 official with March security update..

Sammy issue with selinux still exists for me..

I can't toggle to permessive modus. See attached pics. SELinuxToogler didn't also work.

Can anyone look at the logs please?

Sry for my bad english

http://cloud.tapatalk.com/s/58e2dc5469851/magisk_error_20170403_184133.log

http://cloud.tapatalk.com/s/58e2dc8972795/logcat_sel.txt

Recovery log comes if needed

Send from Note4 - 6.0.1
[Magisk] gk1984:
Ok, I thought I fixed the problem I had but not quite... Seems Magisk will only allow root with stock, unmodified tomorrow. Flashed the ARISE sound mod and now Magisk Manager says I'm rooted but haven't allowed permission... Is this normal?
[Magisk] aer0zer0:
I have been using magisk on the .6, and it has work, i just assumed it was fixed .12, hence the wait.
[Magisk] TotallyAnxious:
I'd assume the stock kernel reported the unlocked/soff bootloader resulting in a failed safety net pass.
[Magisk] BigBxcks:
Is magisk compatible with KitKat 4.4?
[Magisk] BigBxcks:
Oh that makes sense ???*♂️
[Magisk] Lost Dog:
I tired making a mod for dnscrypt-proxy but it end with a boot loop. If I find a good reference I'll post it here.
[Magisk] teddy0209:
Lol... I know your setup is microg... You posted a screenshot, rember?... ???
[Magisk] Didgeridoohan:
1 - Have you tried it with Magisk Hide disabled?

2 - Have you tried it with Magisk Core Only Mode enabled?

3 - Does it work properly without Magisk installed?

4 - What is that "yourfile.txt" in your post-fs-data.d?
[Magisk] Artim_96:
... In the install tab?

And all devices released with Android 6.0+ are encrypted by default, the "password" is normally the same as your lockscreen unlock method
[Magisk] kyzn:
Thank you Jesus. I was going crazy and thought I was the only one. I didn't flash anything new or different from my age old setup and was shocked to find CTS Profile Mismatch error. Went back to 11.6, SafetyNet is once again green.

And this was me coming from a total clean flash of Pure Nexus. Wipe everything, no restore of anything.
[Magisk] smohanv:
Here is my way of saying thanks.

Purchase details

Receipt number: 8C092604YC6042334
[Magisk] Citizen_Snips:
It's a Pure Nexus thing then. I'm using Vanilla ROM on my 6P with v12 and I pass. AP works.
[Magisk] bushwakko:
Magisk Said it didn't have root, so I reinstalled it from recovery. Now it finds root again, and passes safety net. However, apps that require hidden root, blue didn't work anymore... Ideas?
[Magisk] torekiki:
Hi,

I have MIUI Rom on Xiaomi redmi 4 Pro.

Magiskhide won't work. It's enabled from toggle but not recognized, even after this fix: https://github.com/topjohnwu/Magisk/pull/149

I need to disable and re-enable from shell and it works!
[Magisk] MaurixMystic:
xposed is the cause ?

---------- Post added at 10:25 AM ---------- Previous post was at 10:07 AM ----------

Any version of xposed will give problems with magisk?
[Magisk] soder:
Great idea. I did the same.

Purchase details

Receipt number: 0BG82145Y9816741R

/Söder
[Magisk] stephendt0:
Hey guys. I have a Lenovo K3 Note, running China Dev Android 6.0 ROM. I had SuperSU, decided to install Magisk. Did it via the app and now my phone is stuck on the boot animation. I just tried the uninstaller zip and it just throws an Error 1 message. Any ideas? I'd like to avoid doing a factory reset, didn't make a backup :(
[Magisk] MaurixMystic:
I feel that after flash magisk v12 my battery drains fast , I have xposed by topjohnwu
[Magisk] amageek:
It was working great with my Huawei P8 Lite, but then I upgraded it to newer build and SafetyNet Test failed.. I flashed the uninstaller and the nre-flashed both phh's superuser and magisk v12, but still it could not pass the SafetyNet Test.. Then I flashed the boot.img (extracted from the Updater) again and while it was rebooting, it stucked on Huawei's Boot Logo... It didn't pass it.. I somehow managed to go into recovery and fastboot mode but whatever I try, I could not get it past the boot screen... I tried to restore the system through TWRP backup too, but that didn't work too... At one time, I was able to boot it up but the WiFi module was not working so I reflashed the system again... Once again, stuck at boot screen...

I guess the problem arose when I uninstalled the MagiskManager app without flashing the uninstaller.zip... Is there any way I can bring it back to life??
[Magisk] A$h!$h:
plz build sensor disabled module
[Magisk] teddy0209:
Restore your boot.img, if it's the same, wipe data partition...
[Magisk] amageek:
in fact, I did both... when I first stumbled upon the boot screen, I booted into fastboot and re-flashed the boot.img, but that didn't work... Then, I wiped everything in a sequential way, starting first with data, then data-cache, formatted the device, also wiped the whole frikkin system... nothing seems to work
[Magisk] culiacanazo:
I do! ;)