yashsingh1/xdaforums huggingface dataset:
[Magisk] eberhardweber:
Another Samsung user (SM-T800) on a stock Marshmallow rom (6.0.1.) with stock kernel reporting in. Everything else works except for Magisk Hide;

Tried both SuperSU (2016.12.15 V2.79) and phh's superuser (magisk-r266-2.zip) and both produce the same error:

Even with verbose logging, the only error message is "Error occurred...". I think the point about Samsung devices is probably right.
[Magisk] andrew2432:
On my galaxy touch wiz ruins pretty much every mod ever :( i always had a kernel warning with magisk on boot and havent been able to use the new magisk, aosp roms seem to work better
[Magisk] JEANRIVERA:
could anyone that successfully has compiled magisk from source with the latest commits after v9 could share it here please or PM
[Magisk] waylo:
I think you're absolutely right! I installed the necessary Windows addon and it runs fine now. (Or maybe the reboot did the trick?)

For anyone else trying to build the latest updates but without any compiling knowledge (that includes myself), topjohnwu has made it quite simple. It's listed on the github actually:

How to build Magisk

Download and install NDK
Add the NDK directory into PATH
To check if the PATH is set correctly, try calling which ndk-build (where ndk-build on Windows) and see if it shows the NDK directory
Unix-like users (e.g. Linux & MacOS) please execute build.sh through shell
Windows users please execute build.cmd through cmd
The scripts will show you further details

To simplify each step, for Windows users:

1. Go to the github here: https://github.com/topjohnwu/Magisk

In the upper right, click the green 'clone or download' button and download the .zip. This is the magisk-master.zip.

However, for me, this file does not download the contents of EVERY subfolder, for some reason.

Specifically, the /jni folder contains subfolders which are empty in this original .zip, but not in the github.

So, navigate into each of these folder within /jni in the github:

resetprop @ 9694956

selinux @ 91e9179

sepolicy-inject @ f760a9d

su @ 8475cec

and download the .zip contents of each.

2. NDK is the Android development kit, found here https://developer.android.com/ndk/index.html

Download and unzip into a working folder.

This takes a LONG time as the zip is 600mbs but contains tens of thousands of files. Even on SSD it took a surprisingly long time.

3. Add the NDK folder to the Windows PATH.

Go to control panel>advanced system settings>environmental variables.

In the System Variables box in the bottom half find the Path variable. Edit the value and add ";C:\NDK directory" to the end. Obviously change out your directory for the one I listed. You may need to reboot after this.

You can check if this is done right from a DOS console with the commands listed above by topjohnwu, "where ndk-build"

4. I made a magisk-master folder within the NDK folder. I unzipped the magisk-master.zip into this folder. I then took the 4 other downloaded subdirectory zips and unzipped them into the corresponding folders inside /jni.

5. Make sure you have Powershell v3 installed. That info is found here:

https://msdn.microsoft.com/en-us/po...indows-powershell?f=255&MSPPError=-2147217396

6. Run build.cmd from a console in the magisk-master directory. It will list several options. You need to specify a new version # to get it to build though. I used 9.1.

So, to build binaries, zip and sign everything, 'build.cmd all 9.1"

To build the uninstaller, "build.cmd uninstaller"

An output .zip will end up in your magisk-master directory. Done!

Take notice of any errors in the progress log. These will show up as RED.
[Magisk] savi0023:
Same here on Xperia XZ Android 7.0

**edit : seems ok after a few times of reboot, but safetynet not pass
[Magisk] JEANRIVERA:
i have tried your advice but something still wrong i can't compile it my self could you please share your build?

this is my output

PS C:\NDK> ./build.cmd

The system cannot find the batch label specified -

build.cmd all <version name>

Build binaries, zip, and sign Magisk

This is equlivant to first <build>, then <zip>

build.cmd clean

Cleanup compiled / generated files

build.cmd build

Build the binaries with ndk

build.cmd zip <version name>

Zip and sign Magisk

build.cmd uninstaller

Zip and sign the uninstaller

PS C:\NDK> ./build.cmd build

************************

* Building binaries

************************

C:/NDK/build//../build/core/build-binary.mk:660: Android NDK: Module su depends on undefined modules: mincrypt pcre

C:/NDK/build//../build/core/build-binary.mk:673: *** Android NDK: Aborting (set APP_ALLOW_MISSING_DEPS=true to allow missing dependencies) . Stop.

! Magisk binary tools build failed....

PS C:\NDK>
[Magisk] AntholifeV2:
For the 3rd time I would like to have an answer !! After having flasher magisk, my phone bootloop ...! What is the problem ?? HELP I use SUPERSU
[Magisk] Didgeridoohan:
We don't know what's the problem... It's hard to know without more information, like logs. Also I had to look up your previous post(s) to know what device you use... If you at least can provide a recovery.log from TWRP after flashing there might be some information there.
[Magisk] AntholifeV2:
I use a SM-G928F with Audax Rom and SkyHight Kernel, I install supersu RC5 (beta), then I flash magisk ...Here are the logs. The problem is boot image I'm sure
[Magisk] andrew2432:
If you're mixing I'm pretty sure its magisk first because magisk isn't root, magisk enables phh to work I THINK its the same for other root methods
[Magisk] Didgeridoohan:
I concur about it probably being a problem with the boot image/kernel. Have you tried with another or stock kernel?

According to the Samsung compatibility thread, the SM-G925F works with both stock and custom kernel. I don't know what difference is to your device... Might be that your custom kernel is the culprit.

---------- Post added at 15:52 ---------- Previous post was at 15:43 ----------

Yup, it's the boot image (unknown ramdisk). Have you tried using the current build, as in v10 beta? If you can't compile yourself it can be downloaded here:

http://xdaforums.com/apps/magisk/unofficial-magisk-v10-beta-built-t3521901

SuperSU can be installed previous to installing Magisk. It'll automatically make the required patches to the boot image for SuperSU to work...
[Magisk] AntholifeV2:
I did not know there was a v10; Yes I will try. If its work still not I will flash a rom stock. Yes magisk adjusts SuperSu. THANKS I'll keep you informed

EnvoyÃ© de mon SM-G928F en utilisant Tapatalk
[Magisk] AntholifeV2:
I have an error in flashing v10 ... Moreover I saw with the developer of the kernel, it is compatible no problem so!... the log...
[Magisk] Didgeridoohan:
Well... It seems like the installation is working as it should, at least. As in: the script isn't flashing a messed upp boot image anymore, so I'm guessing you're not getting a bootloop after flashing v10. I guess your best option would be to open an issue in GitHub and provide the log and a copy of your boot image...
[Magisk] AntholifeV2:
Yes I get an error directly in the recovery!

How to recover our boot image boot?
[Magisk] Didgeridoohan:
From the Announcement thread:

:D
[Magisk] AntholifeV2:
Thank you ! But I post his where? And on Github where his? Sorry for my questions but I'm lost lol
[Magisk] Didgeridoohan:
Ok... I think you need to to some reading dude. :)

The Announcement thread is stickied in the Magisk forums: http://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445 If you haven't already, read the whole thing... Lot's of good information. In there you'll also find a link to GitHub, under "Sources".
[Magisk] AntholifeV2:
LOL ; thanks !
[Magisk] Nekromantik:
Weird issue im having, I am running Nexus 6P on Dirty Unicrons 7.1.1 ROM.

It came with SuperSU 2.79 which I unrooted and then flashed magisk 9 and then magisk phh su latest.

Rebooted and installed phh app and magisk manager. It worked fine and I was able to enable hosts and magisk hide.

However after reboot Magisk Manager no longer detects root.

All other apps see root fine.

Only other thing I did was to flash new kernel which was flash kernel which uses anykernel patcher.
[Magisk] Znuf:
Hi, small problem on my phone. I do a factory reset to retrieve a brand new phone. and i'm not able to install magisk anymore.

I had flash SuperSU with no probem. I install magisk with magisk manager. Everything seem to be good. I can download module and activate them. But when i reboot magisk disapear. If i flash in TWRP everything seem to be ok but magisk manager say that is not installed. I lookd for a log but in /cache folder i don't have magisk.log.

Thanks for the help
[Magisk] AntholifeV2:
If you want to follow the problem :)

https://github.com/topjohnwu/Magisk/issues/27
[Magisk] rignfool:
[MENTION=1162986]Captain_Throwback[/MENTION]

So... I'm having a hell of a time here...

I want to override all the neat space saving thing [MENTION=4470081]topjohnwu[/MENTION] put it and make my image bigger...

But... I don't speak edify...

I managed to mod the installer to create a 256 MB image... But... Everytime I flash a mod... It tries to shrink it back down to 64...

Got any ideas... Or what should I snip and run from TWRP to manually grow the image?

EDIT: I should say I'm putting Gapps on magisk...

Before you ask why... Because I can...
[Magisk] Captain_Throwback:
My image grows perfectly fine, as long as I flash the zip in recovery. If it shrinks back down, it's because the files didn't get written properly (usually). But currently my magisk.img is 256MB and works fine.
[Magisk] rignfool:
Interesting... I couldn't get it past 100 meg...

With one meg free
[Magisk] Captain_Throwback:
Don't know what to tell you. Working fine here.
[Magisk] yochananmarqos:
You need to flash Magisk & phh again after updating your kernel.
[Magisk] Nekromantik:
thanks
[Magisk] rinart73:
So what about Magisk Hide feature? It doesn't work!

There is no 'su' file in /system/bin and /system/xbin (deleted)

Flashed Magisk, pph-superuser. Installed Magisk Manager, pph-superuser.

Granted root access to Magisk.

Enabled 'Magisk Hide', chose PoGo and Terminal.

PoGo won't authorize and when I type 'su' in the Terminal, it acts like usuall.
[Magisk] husky69:
Hi all!

Just install a Nougat AOSP ROM on my Xperia Z5 (C6653), working beautifully so far, installed Magisk v9 and phh's SU (266-2) and the corresponding SuperSu Manager app, but i can't get Titanium Backup to request ROOT in a way that it would get recognized.

The SuperUserManager app's log won't ever show notice of Titanium Backup requesting root, and Titaium Backup complains about not finding SU binary.

Searched this thread as best I could, but didn't find a solution.

How to solve?
[Magisk] Artim_96:
Tried deleting app data or reinstall it? Am on a 7.1.1 ROM too with no problems with TB
[Magisk] husky69:
PixN is Android 7.0 only, but nevermind...

Whatever made it work now, suddenly Titanium requested root suddenly and got it. I didn't change a thing AFAIK :confused::confused::confused:
[Magisk] waylo:
It looks like you don't have everything needed installed? There are some .net updates that need to be installed on your Win computer. Hard for me to tell since this was the first time I've attempted it myself.

Regardless, here's a thread someone started which has the builds for download.

http://xdaforums.com/apps/magisk/unofficial-magisk-v10-beta-built-t3521901
[Magisk] laggardkernel:
There is no need to enlarge the image size. 64M is just the default size. Each time you're flashing a Magisk module, the script will try to calculate the space this module needed, the available free space in the magisk.img and the total size needed after copying all your file into the img. After the calculation, a resize will be made on the magisk.img to enlarge itself, if that's needed, before the module copy it's files into it. When your mod delete some file from Magisk.img, the script will calculate again and try to shrink the size. The process is totally automatic. If your img shrink back to 64M, I guess it's not big enough to trigger the resize process.

I use some of the theme ready gapps, which needs about 180M additional space, and it was flashed into the magisk.img without problem.
[Magisk] reddv1:
Have you tried rebooting? You have to reboot after enabling magisk hide to take effect.
[Magisk] laggardkernel:
Pity. If this is device specific, you can try the latest build of Magisk, which made a refactor of the mount script, maybe you could get some good result. Just maybe.

I'm using xposed, so I'm not clear about the Magisk hide.

Make a nandroid backup, or use multirom to create a secondary ROM to test. Magisk works on the secondary ROM and I use it to have tests sometime.
[Magisk] oreo27:
Thanks! If you have Netbeans IDE, you can simplify the process by cloning the git, which will then ask you if you want to also clone modules (the folders you've mentioned with no content).

I wonder if we can do the same with Magisk Manager.
[Magisk] zzzhead:
Anyone has any idea where to modify the mounting parameters, my /magisk is mounted as ro
[Magisk] grep_i:
Yes that's right the installer can't determine the compression of the RAM disk.

Can you try and restore your device back to stock kernel if any and repeat the process.
[Magisk] rignfool:
Currently... My magisk image is about 512 MB...

After 3 hours I got it to grow... But I had to manually resize the image in TWRP... And had to e2fsck over and over since post-fs-data would run out of time while still working and corrupt my image...

[MENTION=4470081]topjohnwu[/MENTION]
[Magisk] Captain_Throwback:
Ah I bet that's why it only works for me when flashing in TWRP - my image kept getting truncated and I didn't know why. If you're correct and it "runs out of time," maybe that's something [MENTION=4470081]topjohnwu[/MENTION] can fix. Nice work.
[Magisk] WILMANS2M:
Hi,

I am currently building a custom rom using aroma and want to include magisk. But when flash is done (with magisk v9 flashed), my phone reboot as always but got an error: Invalid kernel lenght.

I wiped all (except internal sd) and flashed stock kernel before flashing magisk.

I have a samsung galaxy s5 neo.

If someone know how to resolve it....

Thanks in advance.
[Magisk] rinart73:
Reboot doesn't help.
[Magisk] Artim_96:
Strange. Solid explorer shows it as drwxr-xr-x. Is it only ro from the view of the system so only Magisk or a file manger could edit it?
[Magisk] jhedfors:
Does anyone know of an easy way to disable installed modules? I just spent quite a bit of time trying to recover from a misbehaving module that I had just installed. It would be great if there was a zip that could be flashed that disabled all modules --- like a safe mode for Magisk.

I had installed a "Pixel Experience" module, and it seemed to remove my PHH superuser module, so it was showing that I was not rooted (so I could not disable/remove the module). I recovered by reflashing ROM, keeping stock root,and Magisk.

I had searched for the module location to delete it, but could not find it. It would be great to have a "safe mode".
[Magisk] laggardkernel:
Since you have lost your superuser, you have to delete the module in recovery manually.

1. Download the MountMagisk.zip here, http://xdaforums.com/apps/magisk/collection-magisk-modules-t3445257/

2. Reboot into recovery

3. Flash the zip above, to get /data/magisk.img be mounted to /magisk

4. Delete the module you want through deleting folder /magisk/MODID(MODID means the folder name corresponding to the module)

5. Optional. Flashing an existing module zip to make magisk.img be unmounted from /magisk.

6. Reboot.

This should work. Good luck.

---------- Post added at 05:31 PM ---------- Previous post was at 05:18 PM ----------

Mine is also 512M, no problem on rebooting. What do you mean by post-fs-data running out of time, any detail?
[Magisk] jhedfors:
Great. Thanks a bunch. I will use that next time!

Still would like a "safe-mode" zip though... ;)
[Magisk] rignfool:
I am using the app systemizer module...

It copies apks from data to system...

There is not enough time to copy more than 2 or 3 apks before post-fs-data is "over"... If you are in the middle of something as that is going on... It stops... DEAD... Like -9

And causes corruption of the image
[Magisk] Little Nugget:
Stock but no safetynet anymore...
[Magisk] allen099:
I have a Nexus 6P and installed Magisk + superuser 266-2 and I lose root EVERY TIME I reboot. I'm on stock otherwise, with nothing happening. It's the strangest thing. Anyone know why this is? Thanks!
[Magisk] darksaber79:
May be a silly question as I think I know the answer..... But is superuser required for magisk hide to work?

I haven't been able to hide root for a few apps no matter what I do.

I am running magisk v9, apps are selected in hide.

Phone runs custom ROM resurrection remix (marshmallow)

This has privacy guard for root access and now superuser.
[Magisk] Artim_96:
Of course. It only hides Magisk modules, anything else is unsupported... Including XPosed
[Magisk] darksaber79:
So if I install superuser from the playstore, does it simply overwrite/disable privacy guard?

There are many superuser apps on playstore..... Is there a specific one to install?

My reason for installing magisk is that I want to run some apps that don't work on rooted devices. I thought that was magisk's hide feature?
[Magisk] jsaxon2:
Use this one from here. It is beta 10 and works for me. http://xdaforums.com/android/software-hacking/wip-selinux-capable-superuser-t3216394/page214
[Magisk] Artim_96:
Of course not. You have to completely remove the built-in root (probably the UPDATE_su.zip should do the job), restore stock boot image, flash the SuperUser module and of course the SuperUser app by phh
[Magisk] _litz:
Running into a couple of issues ... see if anyone has any ideas ...

Stock Nexus 9, Magisk v9 + phh superuser. Magiskhide, Busybox, and Adaway/Hosts all enabled.

Has two issues ...

1) SU disappears ... all of a sudden, it'll just go "no su binary", and you have to reboot to regain root.

2) the Magiskhide screen inside the Magisk Manager bears no resemblence whatsoever to the apps actually inside the magiskhide directory in the magisk folder ... items check and uncheck randomly, and changes are not saved. To set apps to be hidden, the shell commands have to be used.

Anyone got any ideas?
[Magisk] ammar18:
1. this has been reported many times. it is a known bug. disable it if you dont want rebooting

2. idk about that. i didnt use magiskhide because of the known bug

hope its fixed in magisk v10
[Magisk] darksaber79:
When you say stock boot image..... Do you mean the Samsung boot loader or the stock loader within the custom ROM I am running (RR)
[Magisk] ammar18:
bootloader and kernel (referred as boot image) are different. he meant the boot image or kernel of the rom. the 'boot.img' to be exact
[Magisk] _litz:
Sadly, I tried the v10 unofficial, and the SU behavior is the same.

Is this a problem within magisk, or within phh ?
[Magisk] ammar18:
magisk.

well we just need to wait for the official. hope its fixed
[Magisk] nikexv2:
Everytime i want to install a module it downloads and then magisk manager Forceclose, im one Resurection remix 7.1.1 on one plus 3.
[Magisk] Artim_96:
Make a catlog log. Otherwise we can't see what's the problem
[Magisk] nikexv2:
Done :)
[Magisk] culiacanazo:
What benefit would playing with the unofficial v10 bring, at this point?

Kindly, thank you sir.
[Magisk] Artim_96:
Satisfaction of your curiosity.
[Magisk] chrisc93:
I used phh modified for magisk.
[Magisk] rtthane:
Are you using Magisk v3? After a clean flash of Pure Nexus, AP works for 1 transaction then fails for every one after that. This has happened before on stock, can't work it out.
[Magisk] chazall1:
Using Magisk v3 on my N5 AP working on PN Rom. WOW great work.
[Magisk] :
I cannot test AP actually paying but I can pass SafetyNet with Xposed still active.
[Magisk] gohamstergo:
That's the easy part and works for anybody who installs everything properly. Paying is the hard part.
[Magisk] reekotubbs:
deleted
[Magisk] GTDarthYoda:
I Haven't updated to v3 yet but I'm working with xposed systemless v86.4, magisk v2 and phh's v2

AP works great at Meijer!

So now I ask

Is there any reason to update to v3 if everything seems to be working fine?
[Magisk] gambit1091:
I've tried installing Magisk V3, PHH's Root, and Magisk Xposed.

I'm always stuck at Huawei Logo even after uninstalling the Xposed Framework. I guess the problem is with the Magisk V3 itself.
[Magisk] Jammol:
The issue is not with the app.
[Magisk] teddy0209:
Post some log, must be the boot.img patch...
[Magisk] Max88888:
Hi guys,

How I can mount my custom cpuinfo to /proc/cpuinfo?
[Magisk] MNoisy:
HTC 10 us unlocked

Ice rom 2.1.3

Supersu for magisk

Magisk v3

Elementalx v.14 kernel

Xposed systemless 86.4

All is working perfectly including all xposed mods.

Thank you!!!!
[Magisk] dimm0k:
say I'm unhappy with phh superuser, is it easy to switch back to chainfire's supersu for this reason or if chainfire's supersu comes out with a fix?
[Magisk] LLStarks:
You need to use UnrootCM.zip or manually delete /system/bin/su and /system/xbin/su before Magisk will work properly.

You cannot have any system SuperSu or system root method on your device.
[Magisk] :
Lol it literally does the exact same thing along with the benefit that it's not owned by a for profit company.

---------- Post added at 08:21 PM ---------- Previous post was at 08:12 PM ----------

Well let's say you custom cpuinfo is located at /magisk/cpuinfo

So your going to make a shell script

Mine that would mount /magisk/cpuinfo to /proc/cpuinfo

#!/system/bin/sh

mount -o bind /magisk/cpuinfo /proc/cpuinfo

you'd save this as cpuinfobind for example and place it in /magisk/post-fs-data.d
[Magisk] Mattski:
This is really so cool! Thank you so much for creating this!
[Magisk] Artim_96:
Works now perfectly on Note 4, thanks!
[Magisk] nicolap8:
No! Dont touch it.
[Magisk] dimm0k:
is there anything special that needs to be done to get GSam's root companion working? I finally have Magisk v3 running with systemless Xposed, however the only thing that doesn't work right now is the GSam root companion. the root companion app sees that it's installed properly, but GSam for some reason doesn't.
[Magisk] knpk13:
Ugh I've had a lot of trouble with that in the past. (Not because of magisk, it's just a gsam quirk or something)

The root companion is not systemless AFAIK.

Best way is just wipe system before dirty flashing your next nightly. Then flash rom , gapps, custom kernel if any, magisk, any other mods. Clear data from gsam once too so you can start fresh. I personally like this method of dirty flashing since it seems cleaner and is a more universal method (works across more devices without remembering device specific flashing rules or worrying about addon.d scripts)
[Magisk] shrazy:
So guys I have a question.

I need to get my banking app (s-puhstan) to work but because of root or whatever it forcecloses immediately everytime.

I've spent like 10 hours in 2 days to read and understand everything but it doesnt work either.

I set up a new system and then do following steps:

My setup is:

- Magisk V9 + phh superuser r266 + phh's superuser app + Magisk Manager 2.5 + systemless xposed (through Magisk) + active Magisk Hide for my banking app

Root access works fine like xposed and every other module.

But I can't pass safetynet neither start the banking app. Is there something I do wrong? How can I solve this problem?
[Magisk] rignfool:
Broken things for me...

Manually resizing the image doesn't make it from recovery to OS... e2fsck issues... A really short post-fs-data window...

Also... No need for a root solution as magisk is packed with phh... Still need the app though...