yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
The addon.d survival script can be a bit wonky on some setups.

You could try deleting the script after each update (/system/addon.d/99-magisk.sh). If that works, you could even let Magisk take care of that for you (as long as you don't wipe /data)... Add something like the following to a file (name it whatever you want), place it in /magisk/.core/service.d and give it execution permissions (755):

#!/system/bin/sh
if [ -e /system/addon.d/99-magisk.sh ]; then
mount -o rw,remount /system
rm -f /system/addon.d/99-magisk.sh
fi

That should remove the addon.d survival script if it's found (will be installed each time you flash Magisk).

You'll then have to manually flash Magisk after a ROM update.

---------- Post added at 20:07 ---------- Previous post was at 20:06 ----------

There is none. Android 5+ only (and even Lollipop support can be a bit tricky).
[Magisk] Bwangster12:
I don't have a /magisk/.core... folder. I have a /magisk folder, but inside that there is just a folder for the iYTBP addon and a /lost+found folder.

Also, what extension do I put on the end of that text file.
[Magisk] Didgeridoohan:
You'll have set your file explorer to see hidden files and folders (that's what the dot in front of core means). And the file doesn't need an extension.
[Magisk] Base2:
Magisk with File Based Encryption?

Has anyone successfully installed Magisk with Android Oreo 8.0.0 encrypted using file based encryption? I tried it on a Nexus 6P with opr6.170623.017 and Magisk-14.0 and it never went beyond never ending boot animation. (and no, I didn't try this on top of SuperSU, I started from an unrooted stock bootable image.)
[Magisk] brown.beaver:
Updated to magisk v14 on zenfone 2, suddenly it went bootloop. Tried uninstall and reinstall magisk v13.3 but nothing worked. Had to reinstall ROM so it can boot again. Any idea why this happen? I only installed greenify and adblock modules, no xposed.
[Magisk] nathanchance:
It's being worked on due to Pixel support. No ETA for when it will be done but keep an eye on the beta thread.
[Magisk] onliner:
Logs?
[Magisk] gorman42:
Total newbie with Magisk, coming from MM with Xposed. I would like to understand if the uninstall option in Magisk Manager (the trashcan icon) works the same way as Xposed uninstall.

Meaning, if I use that, the system will be back the way it was before the module's installation? If there's a newbie tutorial somewhere that I could/should read I'd gladly do that. Thanks in advance.
[Magisk] Artim_96:
Exactly. It will remove Magisk including all modules
[Magisk] gorman42:
Sorry, I see my question wasn't clear. I'm not asking for what happens if I select Uninstall from Magisk Manager. I'm asking what happens if I use the trashcan icon on a specific module in Magisk Manager. In Xposed it was just a matter of uninstalling a module if it didn't work correctly. With Magisk I see many reference to terminal use, etc.

So... I'm kind of scared of experimenting. Even more so considering that I'm on Oreo now and Magisk Manager does not check compatibility of modules in the repo with your OS version.

I said I was a newbie... be kind. :)
[Magisk] jenslody:
It removes the modules folder on next boot, if the modules installer did not do any evil things, like putting or changing files elsewhere on your device it should be removed completely.
[Magisk] Artim_96:
If you got the trash icon the module is deleted and will be gone on next reboot. At least as long as they work as they are supposed. In theory they could make changes that are deeper but that would oppose the sense of Magisk, so there shouldn't be any leftovers.

Terminal is often just used for applying settings. Otherwise those modules would need to bundle an app for that. That would bloat the module and unnecessarily complicate the support for the module.

And of course there aren't really compatibility checks since they aren't need in most cases since modules aren't that software specific. But at least the XPosed modules should throw out an error if installed on the wrong SDK version.
[Magisk] Rom:
I just forget an question :p

post-fs-data.sh file support all Unix commands ?
[Magisk] jenslody:
I asked you to try it via "adb uninstall", it should also work from "adb shell".

That was intentionally, because adb has more rights as a normal user.

Removing MagiskManager from terminal emulator does not work here either, but via "adb unsinstall ..." (or from "adb shell") it works.
[Magisk] cthulhu1987:
I installed the most recent Magisk version (v14.0) on my Galaxy S5 (SM-G900F, Android 6.0.1, PDA G900FXXS1CQD4) and "everything" went OK except two big problems: Pokémon GO sends the device into reboot from time to time and after I installed and subsequently removed the Magisk F-Droid extension (due to strange errors, crashes and stuff), I have problems with the battery: When I plug the charger cable into the phone, the phone seems to charge "unnaturally" fast and when I use the phone later, it seems to drain "unnaturally" fast, too (especially when I play Pokémon GO, it seems, even faster than than it's normal for the battery hog), even though the battery indicator claims 100% battery charge even when I don't boot up the phone. What could be the problem? I've attached two logcat files (from the TWRP copy-to-sdcard function and from /cache/recovery/log via TWRP adb), if I need to post other log files, let me know.

I don't think it belongs into the Pokémon GO thread as the problems doesn't seem to be related just to Pokémon GO (SafetyNet is being fooled just fine and Pokémon GO works fine except the reboots), but a (possible) problem with either Magisk, TWRP or something else and Pokémon GO just being an especially resource-hogging app.
[Magisk] Milous98:
Yes, I already tried these commands from my PC using adb shell to unhide, install / uninstall but with no result !

Do you have any other ideas or adb commands I can use to solve it ?

Thanks
[Magisk] jenslody:
Both logs are recovery logs, just from starting recovery and copying the recovery.log to the sdcard.

I don't see how they can help here.

Maybe this tutorial helps to grab a meaningful logcat.
[Magisk] csmyka:
Hi,

Can someone help me install magisk on my Sprint Samsung Galaxy S7 (Nougat)? I have tried but it keeps bricking the phone.
[Magisk] Legendary Cryptid:
[MENTION=290898]Dig[/MENTION]deridoohan I took screenshots of the images saved on XDA. Are any of these possibly boot images, or do I have to look elsewhere?
[Magisk] cthulhu1987:
Thx, I've used the "adb logcat -v" option and got an about 3MB big text file, it's attached (zipped). Could you take a look at it, please?
[Magisk] kushman:
I keep getting process issue when I try to download any modules any ideas how to fix?
[Magisk] Didgeridoohan:
Should work as any standard shell script on Android.

The boot.bin file looks like a good candidate (but I don't know anything about LG's stuff)... But, again: these are questions that you'll most likely find the answer to in your device's forum or Google/duckduckgo/etc.

---------- Post added at 06:40 ---------- Previous post was at 06:38 ----------

Search or read back a couple of pages in the thread.
[Magisk] kushman:
Got it working thanks
[Magisk] k0m3n9:
Meanwhile.. I've just tried a different method: install Magisk 14 via TWRP. I didn't flash TWRP image via odin (just to avoid knock from been tripped). I flashed it via TWRP Official App (after i did backup patched boot img + stock recovery). Magisk Manager shows Boot Image location is (Auto) dev/block/mmcblk0p20 (Not like when installing Magisk via patched boot img for the 1st time where it shows Boot Image location cannot be found). After succesfully installed some modules, without removing Magisk i've managed to replace TWRP with patched boot img via Odin. Since TWRP was still there, i restored back stock recovery img via TWRP Official App that was backup before. Now with patched boot img reflashed, Magisk Manager shows Boot Image location still (Auto) dev/block/mmcblk0p20 and I still can install any additional magisk module after that. Only that when i try to update system it fails with message "The Operating System on your device has been modified in an unauthorised way.. bla bla bla".

I know this is not the total solution with issue i've been faced, but 1 question.. could it be the reason that caused fail to install any magisk module before is because of "Boot Image Location cannot be found" when install Magisk via patched boot image? Just wondering..
[Magisk] Milous98:
Can't unhide magisk manager

Still trying to unhide Magisk Manager. So I tried again via adb command using

adb uninstall com.topjohnwu.magisk

got

/sbin/sh: pm: not found

Every command I tap, got the same error, I'm quiet noob with adb shell so maybe there is something I got to do before using the command ? Already in adb shell, I try to go to an other directory like cd /data to find magisk but same error with sh and pm not found :/

Edit : to give some more info, I'am able to access the 'data/data/' directory where 'com.topjohnwu.magisk' is located. I can see the file using 'ls' command, so tried 'adb uninstall' / 'pm uninstall' even 'am start -a android.intent.action.DELETE -d package:com.topjohnwu.magisk' but always the same error, definitively did someting wrong, but can't figure it out... what's actually wrong .. please help me ^^
[Magisk] ketwi15:
Any ideas on why Bluetooth doesn't work with Xposed module active? S6 Edge with Xposed SDK 24 downloaded from magisk.
[Magisk] Rom:
Hello,

I have tried to flash my big Magisk Module (it contain many stuffs), the TWRP flash return me that:

I have search with the giving number in my "post-fs-data.sh" file for the line 78:

ABI=$(grep_prop ro.product.cpu.abi | cut -c-3)

But i don't think its about that.

In wich file/commands this error could come from ?

apparently the error could from "/data/magisk/busybox/" folder because in my phone it doesn't exist but now Magisk have busibox pre-installed.

Have u an idea ?
[Magisk] Didgeridoohan:
That's the location of the internal Magisk busybox on v14.0. And it's not referring to your post-fs-data.sh file (that merely gets copied to the module folder during installation and then runs on boot). The error is referring to line 78 of the update-binary. Did you mess any with that file?
[Magisk] Rom:
Ah ok, so the 78 line of the update-binary file:

so no modifications making in that. I haven't make any modificaitons in the META-INF folder.

I think it could come from my post-fs-data.sh file because i have copy/past and edit many command, u can check it in attachment please, thanks:good:

(and yes i have put the "yes" argument at the "POSTFSDATA=true" value).
[Magisk] Didgeridoohan:
So it's running the recovery_actions and adding Magisk's internal busybox to PATH is a part of that function. If it can't find it it means that either Magisk isn't installed properly or your recovery can't properly mount /data (but then it should error out earlier in the installation script:confused:). Do other modules install ok for you through TWRP?

The module's post-fs-data.sh file has absolutely nothing to do with the installation of the module. Here's the only thing that happens with it during installation (a bit later in the script than where you get the error):

# post-fs-data mode scripts
$POSTFSDATA && cp -af $INSTALLER/common/post-fs-data.sh $MODPATH/post-fs-data.sh

It is simply copied to the module folder.

If you haven't touched the update-binary file you should be getting this error flashing any module in recovery...

I'm sure we're missing something simple. :laugh:
[Magisk] Rom:
Ok, so for others modules i haven'g get any error, all modules i use works successfully.

About the post-fs-data.sh filei thinked that it was interpreted at the flash step and at the android boot so its just execute at each android boots.

About the final error, i search it :p

The log not give me necessary explanations too..
[Magisk] Didgeridoohan:
Hm... Like I said, I'm sure it's something simple. You could try just copying over the system files and the post-fs-data.sh to a fresh 1400 template, edit config.sh and module.prop and see if it works then. There's always a possibility something got messed up by mistake along the way. Wouldn't be the first time... :D

And if you don't mind, you could upload the module somewhere and pm me the link. I might see something with a somewhat fresh pair of eyes.
[Magisk] Rom:
So i have refresh my module folder and build again my zip but same flash error:

- Mounting /system, /vendor, /data, /cache
/tmp/updater: line 77: /data/magisk/busybox: not found
! Unable to extract zip file!
- Unmounting partitions

I begin to review all the install process.

If i don't find the error, i will upload you my zip and send u the link via PM :)

Thanks again :good:
[Magisk] enzzo28:
Can someone help me, please?

I tried to install a systemless xposed on my OnePlus 3T, running OS 4.1.7, unfortunately after installing the module, my phone ended up in a bootloop, and the uninstaller doesn't work.

I can uninstall Magisk and my phone works, but when I reinstall it, it gets into a bootloop again because of the xposed addon.

I don't have root access because Magisk is not installed, and when I tried looking for the addon using twrp file manager, I couldn't find it.

Could someone help out by telling me were the addon path is?

Thanks
[Magisk] Didgeridoohan:
You could also try completely uninstalling Magisk and the Manager and do a clean install of v14.0.

Flash the Mount Magisk script in TWRP (from the Modules collection). Then you'll be able to navigate to /magisk and delete the Xposed module folder.
[Magisk] jad88:
Zenfone 2 needs to have a signed magisk version. Probably your rom has it and it works when you reflash your rom.

Try this:
[Magisk] sirwin44:
This may be the wrong place for this, but what is the best tablet this would work with? My Samsung tab a has problems with anything newer then v12, so I want to move on to a different tablet. Any suggestions?
[Magisk] Rom:
Yep but now i am too tired, i have review all the originally updater-script process and check the directories, i have fix several shells commands (so arround 90% of all the stuff).

Finally i get the same error during the flash process :p

I write u my PM with the links.
[Magisk] Legendary Cryptid:
[MENTION=4667597]Didgeridoohan[/MENTION] Reflashed TWRP and Magisk. Tried making patch boot.img and it was actually there. Copied it to my computer. Clicking on the file says the disk image file is corrupted. Is that normal? If so, then I just need to flash the image with fastboot?
[Magisk] Thomas_BA:
Just a quick question regarding the BusyBox Module.

I have the problem that after flashing this "BusyBox for Android NDK" modul, xposed installer won´t recognize anymore xposed as a installed module. But xposed modules are working.

A further hint. Uninstalling busybox module alone does not help. I have to uninstall xposed also, reinstall so that xposed installer recognizes it again.

Is the module not compatible with Magisk 14? Happens on my Samsung Tab S2 with Lionage 14.1. Haven't tried it on my Moto with Stock Nougat.

Thanks

P. S.

I found on other flashable universal zip "Busybox-1.27.2-YDS-UNIVERSAL.zip" from this thread:

https://xdaforums.com/showthread.php?t=3348543

Flashed with Magisk 14, everything perfect.
[Magisk] EeeK:
Just switched to Magisk on my Samsung Note 3 running on Phronesis v4.1 rom and got this. Installed Android Pay but it's not working. Any idea to fix this?
[Magisk] rwargaski:
Does anybody know if it is safe to remove the OOS call recorder enabler module directly from root browser instead of magisk manager? For some reason it's not letting me uninstalled the module from magisk manager.

Thanks
[Magisk] jeffreymcclain:
Looks like the ctsProfile has been fixed for the Nexus 6P

http://www.androidpolice.com/2017/0...e-safetynet-android-pay-nexus-6ps-theres-fix/
[Magisk] k0m3n9:
If you have Systemless Xposed installed.. try xposed module "No Device Check". It will give you ctsProfile = true in SafetyNet Check.. atleast.
[Magisk] Didgeridoohan:
Depends on what program you're trying to open the image file... Sounds like a disk mounting program and in that case: it's normal. The image file isn't a "disk" image...

Just go for it. If anything happens (bootloop, etc) you can flash the stock boot image the same way.

But, I'm curious... Since you've now flashed TWRP on your device (and Magisk?), why do you want to use the recoveryless installation? :confused:

Don't put image files like that in your post... They're HUGE and take up the entire screen! Just use the attach feature...

https://xdaforums.com/apps/magisk/guide-magisk-troubleshooting-t3641417

That should work fine. Magisk should resize the image when you reboot.

Would be interesting to see some details (and logs, maybe) about your issue though.
[Magisk] Didgeridoohan:
I'm gonna pull you into the general support thread. This has nothing to do with the thread you were posting in...

Sounds like a conflict between the ROM's Magisk installation and the Magisk addon.d script... Does the ROM have addon.d support? If so, remove the Magisk addon.d script after each update and you should be good.
[Magisk] ananthakrshnan10:
UPDATE 1: I am getting occasional downloads as "download.bin" or files with .bin extensions from the download manager automatically. I am able to cancel is after multiple CANCEL download attempts. This is the first time i am seeing so far over all the ROMs used. Has this any thing affecting the "ctsProfile" & "bacisIntegrity" on the Magisk app? anyone please respond.

(NOTE: Apart from flashing the Recovery (TWRP Official), ROM (LOS Official), GApps (pico), Magisk 14 (Stable); i haven't installed any mod nor changed root files or setting)
[Magisk] garris_bibop:
Sry for posting for the xth time. Everey time i'm foreced to uninstall and re-install magisk, the logs look different :).

I was finally able to install the busybox module magiskhide seems to work (at least with rootbeer). Maybe someone can take a look at my logs and tell me if this amount of "text" is normal. Also, there seem to be some errors, could someone point me in the right direction?
[Magisk] Didgeridoohan:
A quick search shows that it might be related to Google backup and restore of data. I don't think it's related to your issue, but who knows...

Log looks fine.
[Magisk] ananthakrshnan10:
I Google but no proper info found. I have never used cloud backup so far and have that disabled. Should i clean flash again? Every CM Security says devices is clean and safe.
[Magisk] gudenau:
Pixel XL?

I recently got a Pixel XL from Google and I can not figure out how to install Magisk. I used the built in image patcher and flashed the boot image with fastboot and all it seemed to do was invalidate safteynet. MagiskManager did not report Magisk being installed at all. I am running Android O with the current security patch level.

I did unlock the bootloader before I even booted Android. :D
[Magisk] Artim_96:
Pixel is still not fully supported. It's planned that this is done on the next release
[Magisk] gudenau:
I didn't see any mention of that on the release post...

Oh well.
[Magisk] Artim_96:
It's in the first two lines of the release post of v14
[Magisk] Captain_Throwback:
Helps if you search the forum too...https://xdaforums.com/apps/magisk/unofficial-google-pixel-family-support-t3639262
[Magisk] Hybrid Divide:
I have an interesting Magisk issue. I have an Lenovo TB-X103F Tablet. (See here: https://xdaforums.com/general/help/req-walmart-black-friday-tablet-lenovo-t3508508 ) running an unofficial port of Lineage OS 14.1, Magisk works on it, as does the Universal Safety Net Fix module. But something between them is breaking Amazon Prime Video's app, it'll start to load, then force close. Works fine with standard root in Lineage OS, but Safety Net is still broken. I THINK It's magisk, rather than the Safety Net module, as after a module uninstall, Amazon Prime wouldn't load. I do have a logcat file I captured while trying to open the app a few times, and I'll post that here.

Oddly enough, this doesn't seem to happen everywhere, as I have Magisk on my LG V20 running a modified stock rom, and Amazon Prime Video works fine there. (Though I don't need the safety net fix there. Really hoping you can help get amazon prime video working again! Thanks in advance!
[Magisk] Eddie1506:
Hi!

Can Magisk 14+ be installed with SuperSU already installed?

Thanks!
[Magisk] Eddie1506:
So I need to fully unroot with stock boot image to install it?
[Magisk] FurySh0ck:
I've added the log file. From twrp, it says installation success, but practically, no root nor magisk is installed. I do lose my safetynet privilege though.
[Magisk] soufsouf:
Hello,

Any news on this ? did you manage to get your app working ?

Same situation here :(
[Magisk] olivercervera:
You mean Barclays app, right? I gave up. They have found a smart way of detecting Magisk + they are targeting Magisk Manager anyway. Since the app runs also in the background, hiding the Manager temporary is not a solution. Luckily an old version of the app still works, I don't know for how long but at least I'm fine.
[Magisk] mean_liar:
LG G5.

As of today, I've installed SuperSU/PurifyOS Xposed and got it installed/active, but got "com.android.internal.policy.impl.globalaction" errors in my Xposed log, so I assume things weren't going well behind the scenes. I reinstalled a factory image and went with Magisk/Systemless Xposed and now that is installed/active, but once again the modules seem non-functional and I'm still getting "com.android.internal.policy.impl.globalaction" errors in the log.

I've also tried installed BusyBox, but for some reason it refuses to. It might be that Magisk's ToyBox setup blocks it out. Meanwhile, I can't get Magisk Manager to successfully install anything it downloads ("process error").

Any help would be, well... helpful.
[Magisk] Didgeridoohan:
It's Xposed... What do you expect? :p And this looks like a question best suited for the PurifyOS Xposed thread.

There are a couple of Magisk modules around for busybox. Have you tried those?

https://xdaforums.com/search/thread/3432382?query=process error
[Magisk] mattiadj:
I have magisk 14 and xposed on nougat and I can't pass safety net. Any advice?

Inviato dal mio SM-G935F utilizzando Tapatalk
[Magisk] Didgeridoohan:
Disable Xposed when you need to pass SafetyNet.
[Magisk] kaitozaki:
Hi everyone, I need help to install magisk with custom recovery, why you ask? Well because I'm using a xiaomi mitv 2 55" and it does not or I have not found a proper custom recovery for it, I used to install Xposed by using terminal emulator APK and till today it still works... I was wondering if there was a way to install magisk the same way?
[Magisk] Didgeridoohan:
You mean without a custom recovery right?

As long as you have a copy of your device's boot image and a way to manually flash it (like fastboot) you can use the installation instructions in the release thread.
[Magisk] thatOneWeeaboo:
Xposed always trips SafetyNet, regardless if it's systemless or not. disable/uninstall it
[Magisk] lotrando77:
Ok. so kernel 3.18 is newer version than 3.80. This is the heck :) So is there a solution to boot a clean version of operating system? Now i figured out, that the app is not starting, not because the root but because of the xposed alone... Even when the xposed is suspended and rebooted (in the xposed installer app), the app is refusing to start, citing lack of security... So is there any chance to avoid this with magisk dualboot please?