yashsingh1/xdaforums huggingface dataset:
[Magisk] topjohnwu:
The phh superuser zip is now properly fixed to support spaces in paths.

I'll investigate how to incorporate the phh's hidesu tool into Magisk version later today
[Magisk] loserskater:
I wrote an app for Chainfire's suhide: https://play.google.com/store/apps/details?id=com.loserskater.suhidegui
[Magisk] ibrokemypie:
what is the usecase for this?

---------- Post added at 05:33 AM ---------- Previous post was at 05:28 AM ----------

you sure it works this way? from what i have read the options for xposed are still either disable and restart or use supersu and suhide with xposed 86.2
[Magisk] ryaniskira:
V7 does not work, Nexus 6P

Flashing Magisk V7 from the app on the Nexus 6P causes bootloop, and uninstalling and reinstalling via recovery causes endless systemUI FC's and makes the phone unusable.

EDIT: After a data wipe and restore, flashing Magisk V7 from recovery causes a bootloop just like my first flash from the app. I capped a logcat during the bootloop here: https://drive.google.com/open?id=0BxBXJxvcrfwVdnAwUEJQaV9HLUU
[Magisk] cuneyttekinay:
I think you done great job and you need to have rest [emoji6]
[Magisk] frrancuz.:
[Spoil]

[/Spoil]

Any help?

Samsung, NOTE3, 5.0.
[Magisk] Tkbf:
Yes, but must upgrade to magisk V7 and magisk xposed 86.6, then flash hidesu or suhide.
[Magisk] dimm0k:
you're referring to the 266-hidesu mentioned in this post? http://xdaforums.com/showpost.php?p=68969947&postcount=1063
[Magisk] pndwal:
Yes, saw that method mentioned by [MENTION=4667597]Didgeridoohan[/MENTION] in [MENTION=914994]hackintosh[/MENTION]'s SafetyPatch thread ( https://xdaforums.com/apps/magisk/module-safetypatcher-t3809879 )

. Glad it works for you as predicted.

However it is not an out-of-the-box solution with the need for such editing. Also, v4.01 from [MENTION=3817746]kam821[/MENTION] seems to be a bit of an obscure version if more up to date. Most have v3 which is still current in Magisk repo as we speak.

Incidentally, both versions can be made to work by manual editing as [MENTION=4667597]Didgeridoohan[/MENTION] noted.

v4.01 is here if anyone else is looking: https://github.com/kam821/safetypatch/releases/tag/v4.0.1 PW
[Magisk] Swierk:
Just tested Thai Chi and it is working with SafetyNet pass OK :)

So far testing Greenify in Xposed mode :)

Good by to EdXposed?

Sent from OnePlus 7 Pro, OxygenOS 10.0.3, TWRP 3.3.1-75, Magisk 20.4, Greenify 4.7.5, Modded Play Store 16.5.15, android core.java patched and SafetyNet pass OK
[Magisk] HippoMan:
When I use TaiChi instead of Riru/EdXposed, SafetyNet indeed passes.

The problem is that some Xposed modules have not been accepted as being valid TaiChi modules. There is a web page for submitting an Xposed module to TaiChi for consideration, but unfortunately, that web page is in Mandarin and I am unable to translate it ... so I do not know how to use that page to submit Xposed modules that I desire. This means that I have fewer Xposed module options available to me under TaiChi than under Riru/EdXposed.

.​
[Magisk] Swierk:
Try sending via email and let me know. I also miss Custom Share and L Tweaks.

Sent from OnePlus 7 Pro, OxygenOS 10.0.3, TWRP 3.3.1-75, Magisk 20.4, Greenify 4.7.5, Modded Play Store 16.5.15, android core.java patched and SafetyNet pass OK
[Magisk] oz42:
As the download link seems to have vanished: where can I download the zip file?
[Magisk] dcarvil:
https://github.com/topjohnwu/Magisk/releases
[Magisk] PolskiLewek:
Today i chacked safenet and everything is false (when i chacked last time is everything true). I think magisk hide worging. Can someone help me with that ?

Ps. Sorry for my bad english
[Magisk] zgfg:
No info about the phone, ROM, modules?!

Have you read anything that was discussed here last days?
[Magisk] Cris_1612:
Sorry i read last few pages and i still did not clear. Is there any way to pass safetynet without removing Riru so far? Already tried MagiskHide Props Config and it did not work.
[Magisk] Wolfcity:
No, not at the moment. You'll have to find alternative mods.
[Magisk] Soumy1234:
Yesterday I was completely failing SafetyNet. Now I check and I see that CTS passes but Basic Integrity doesn't. Really weird. I do have Edxposed installed, so it's probably that. Is anyone else getting the same result?

Edit: it's the No Device Check Xposed module. Disabling that causes me to fail SafetyNet completely.
[Magisk] asphodeli:
Strangely, I simply just disabled SafetyPatch and both settings passed...
[Magisk] Cris_1612:
Hi. What SafetyPatcher version you installed?
[Magisk] pndwal:
Not strange depending on device.

Native Magisk hide is enough for many with proper device fingerprint on many ROMs, but many Chinese devices etc (like MiPad4) will require fingerprint set by props to work as they were never certified in the first place. (Both SafetyPatch and MagiskHide Props Config accomplish this, but SafetyPatch now trips basicIntegrity without manually editing files.)

While originally certified devices won't need this solution with many custom ROMs and Magisk, it is needed with others. Seems in your case SafetyPatch module became a problem but was not actually needed to achieve 'Device is certified' with your current ROM. PW
[Magisk] m8980:
on my samsung s20 ultra it's not running with taichi. magisk 20.4 running. no riru xposed running
[Magisk] pndwal:
In 20.4 MagiskHide is off by default. Have you enabled it?

If yes, you may also need MagiskHide Props Config module with appropriate fingerprint selected using Terminal Emulator for Android. PW
[Magisk] m8980:
thanks man. I'm so blind. it's working now after enabling magiskhide

:good:
[Magisk] pndwal:
Haha! - thats a result you'll never normally see, but confirms that Xposed ctsProfile mods only fake the pass, which is actually FAILING simply because it needs basicIntegrity pass to pass itself.

So you'll need to disable EDXposed (which does now trip basicIntegrity - please read back here), and perhaps try TaiChi Magisk module and TaiChi Manager for Xposed which seems to be working. PW
[Magisk] Soumy1234:
I get that, lol. I just wasn't expecting that effect at all from the module. But I'm still staying with Edxposed since from what I understand not all modules work with Taichi and it's not open source. Edxposed till the grave :p
[Magisk] pndwal:
Both v3 and v4 fail basicIntegrity without manually editing files. PW

---------- Post added at 03:52 AM ---------- Previous post was at 03:46 AM ----------

Yeah, it's a choice between EDXposed or SafetyNet pass presently, but someone may find a fix for Xposed basicIntegrity tripping yet, or a better alternative to TaiChi. PW

Edit: EDXposed is now fixed in Canary builds!...
[Magisk] thunderteaser:
The fact that Riru + EdXposed started tripping Safetynet is a matter of fact, but there should be more going under the radar since i'm getting mixed results (pass/fail) everytime i check Safetynet. Plus, after a while some apps like FEH and Mario Kart will throw the Safetynet error and lock you out, so back and forth deleting deviceaccount.xml like the old days (until It happens again after a while).

Is it happening to anybody else? I assume you uninstalled edxposed and riru, while i just disabled them. Is there anything else i should be looking for?
[Magisk] pndwal:
Yes, I noticed random fails (both basicIntegrity & ctsProfile) when clicking SafetyNet check several times in succession in Magisk Manager. It often fails on first try, but comes right after that, so I hadn't taken much notice, putting it down to a glitch / false fail, but it may well indicate something clandestine... PW
[Magisk] eg1122:
Looks like edxposed 4.6.3 passes safety net for now
[Magisk] PolskiLewek:
Samsung s8 havoc os (the newest)

Modules:

Libeomcrypter disebler

SeftyPatch

SystemHosts

Viper4android fx

Xmlpak
[Magisk] zgfg:
So if you read back you will find posts about SafetyPatch causing the problem and how to fix
[Magisk] njtony:
0.4.6.3 (4532) works fine on 3a xl，safetynet passed
[Magisk] hackermssharma:
Is this canary bulid? But canary build is (4535) where u get 4532? In my ed exposed manager canary build showing 4535. Please suggest
[Magisk] Soumy1234:
They probably updated it. That's why you don't see the (I'm assuming) older 4532 version.
[Magisk] njtony:
Every updated version is here

https://ci.appveyor.com/project/ElderDrivers/edxposed/history
[Magisk] hackermssharma:
Confirmed latest canary build (4536) is passing SN successfully. Now no need to go to taichi stay with ed.
[Magisk] pndwal:
Great stuff!

So is Riru Magisk module still needed? PW
[Magisk] hackermssharma:
Replace stable one with canary in magisk.
[Magisk] thunderteaser:
Indeed, it fails on the first try many times, then passes like 6 or 7 more times, then fails again once, then passes for many more times. If this inconsistency shows a pattern, then maybe SafetyNet is checking for different things on the first check of a set of checks. However, just failing once will have many apps trigger their security measures nonetheless and that is terribly annoying. I tried setting SeLinux back to Enforcing and disabling USB debugging and developer options but it seems it's not checking for those. I am on an older version of Magisk (19.3) but I tried 20.3 and my mileage did not vary, so... Let's wait for further developments
[Magisk] Gruber008:
If there are any Snapchat users you should know that Justin also updated his version of edXposed so it also supposedly passes SafetyNet now.
[Magisk] PolskiLewek:
1 i did what is writen back (update sefty patch and do everything what somone writen)

2 i dont have xposed ( so it dont the rison of fail)

Still 2 fails
[Magisk] paarnoutse:
Does anyone know a method be able to hide Magisk Manager (repackage with random package name) immediately after (re-)installing Magisk from within TWRP, so *before* next system reboot?

Why is this an issue for me?

Some of my apps will detect that my device is rooted when Magisk Manager isn't hided (repackaged). When it detects root, my device will also immediately be blocked (unenrolled) for my work company (for company VPN, email, OneDrive, SharePoint, etc.). Hiding Magisk Manager via its Settings prevents these issues.

However, my problem is that when I've to perform an Android upgrade by a full reflash via TWRP, it must be followed by a reflash of Magisk *before* next system reboot. Reflashing the standard Magisk.zip installation will also re-install Magisk Manager, but unfortunately always using his standard package name 'com.topjohnwu.magisk'. As a result, at first system reboot afterwards these apps will immediately detect root, causing my device to be blocked by my company. Therefore hiding (repackaging) Magisk Manager via its Settings after system reboot it too late...

Anyone any ideas?
[Magisk] Gruber008:
I have tried TaiChi and all the modules which I used worked just fine. But I came back to edXposed just a few hours later.

The thing is, TaiChi has great concept (in my opinion) but many recognized developers don't want to make their modules available there simply because it's not open-source and no one knows what the hell is going on there (security concern), that's just something people should know when switching over to TaiChi.
[Magisk] HippoMan:
I agree about these TaiChi security concerns.

Their justifcation for not putting their code under open source is fallacious. They claim that they keep it private because of security concerns, but it is well known that open-source code is generally able to be kept *more* secure, because the world's developer and security community can vet the code and the algorithms that are in use.

Furthermore, keeping the code out of open-source status raises the question of whether it contains back doors. Given the Chinese government's "Big Brother is watching you" policies, I will guess that TaiChi probably does have government-accessible back doors.

And even if you don't care about security, TaiChi has a couple other drawbacks. Many of the TaiChi support pages are in Mandarin and are non-translatable via Google Chrome. The page for requesting apps to be added to their list of available apps is one such site. And they haven't responded to any emails I have sent them about anything, and they don't seem to want to respond much in the XDA TaiChi forums.

They seem to have a "take it as is or leave it, don't bother us, and tough XXXX if you don't like it" attitude.

.​
[Magisk] thunderteaser:
I'll throw my 2 cents here:

1) Make a copy of your repackaged Magisk Manager apk, it should be in /data/app

2) When you flash magisk, don't reboot just yet. Use TWRP to navigate to the folder where Magisk Manager is located (still /data/app I presume) and delete it

3) Reboot

4) Install your repackaged Magisk Manager apk
[Magisk] DiamondJohn:
I have NO IDEA what I am talking about, but have you tried doing your first boot in safe mode?
[Magisk] Syoenth:
I installed this version and can't pass SN, using Xiaomi Redmi Note 7
[Magisk] JudgeDread11:
You can try making a backup of the repacked app and pack that into a flashable zip file. Or even a magisk module maybe (but that way updates require recreating your module). Then after flashing magisk delete the normal magisk manager and install your zip.

I haven't tried this myself.
[Magisk] H4X0R46:
[MENTION=4470081]topjohnwu[/MENTION] I found an issue with 20.4. My phone just won't pass safety net with 20.4 installed. With no modules, it fails CTS but passes basic integrity. With ANY modules installed, it fails both? Going back to 20.3 and everything works as expected.

OnePlus 7 Pro running OxygenOS Beta 11.

---------- Post added at 09:20 PM ---------- Previous post was at 09:19 PM ----------

[/COLOR [MENTION=4470081]topjohnwu[/MENTION] I found an issue with 20.4. My phone just won't pass safety net with 20.4 installed. With no modules, it fails CTS but passes basic integrity. With ANY modules installed, it fails both? Going back to 20.3 and everything works as expected.

OnePlus 7 Pro running OxygenOS Beta 11.
[Magisk] :
https://github.com/topjohnwu/Magisk

latest magisk uninstaller zip link missing from github. :(
[Magisk] zputnyq:
It's still on github.

Here's the link for v20.4 uninstaller

https://github.com/topjohnwu/Magisk/releases/download/v20.4/Magisk-uninstaller-20200323.zip
[Magisk] BillGoss:
Tap on the link under Releases and then tap on Assets
[Magisk] thunderteaser:
I have the same device and I'm "passing". I mean not really, one check will give both failed and the following one both passed. Try checking multiple times if you can pass. Some apps are still being triggered though, as in some games i delete the deviceaccount.xml and log back in as a workaround.

---------- Post added at 05:12 AM ---------- Previous post was at 05:09 AM ----------

Try checking multiple times. If the first time fails but the other ones pass, you're in my same spot. Some app are still detecting Safetynet once in a while though.
[Magisk] dbjungle:
Help Installing Magisk

I'm having trouble getting Magisk to boot on my Mi 9 SE running a Pixel Experience (Android 10) GSI from ExpressLuke. I can install Magisk and it results in a bootloop at the Mi logo before the PE boot animation. This will happen forever until I run the Magisk uninstall. This happens if I manually patch boot.img as well. I have attached the log of my TWRP Magisk Canary Debug installation.

I tried to boot with /data/adb/post-fs-data.d (did chmod 755), but no log is generated, kmsg and last_kmsg both empty also after cold boot. The ROM appears to run without any problems other than the Magisk install. Any help would be greatly appreciated.
[Magisk] H4X0R46:
Same, can't pass. On OnePlus 7 Pro for me. 20.3 is working for me though.
[Magisk] Didgeridoohan:
What modules did you test, and could you provide logs (with the Canary debug build, for more verbose logs)?

GSIs can often be quite troublesome. I believe [MENTION=1915408]phhusson[/MENTION] has a modified Magisk for that... You would likely find more info on this in the ROM thread.
[Magisk] dbjungle:
Thanks, I will check on phhusson's thread. It doesn't appear to be a wide spread issue on the ROM thread. FWIW I did try the phh Magisk and had the same problem.
[Magisk] alex00006:
Hi guys

i have OnePlus7T and upgrade magisk manager to last version and now i can't open modules!

after open modules force close magisk manager !!

why ?

how can I fixed ?
[Magisk] warrencoakley:
Just go to stable version of Magisk. Less headaches.
[Magisk] pndwal:
In 20.4 MagiskHide is off by default. Have you enabled it?

Read back last pages here to acquaint yourself with new Google checks tripping basicIntegrity fail. Most modules still ok. PW
[Magisk] guest4711:
How about blocking WLAN and Mobile Data before rebooting? Or freezing these apps? Or using a firewall?
[Magisk] Swierk:
About SafetyNet pass and only metter of time when Google update detection of modules like EdXposed again...

Did someone successfully prevent Google Services from self update?

Sent from OnePlus 7 Pro, OxygenOS 10.0.3, TWRP 3.3.1-75, Magisk 20.4, TaiChi Xposed 6.1.8, Modded Play Store 16.5.15, android core.java patched and SafetyNet pass OK
[Magisk] pndwal:
But hardware key attestation means Google's server end can directly query bootloader for its state. Afraid it will occur irrespective of updates, Google services or other, which is why even John Wu is 'over it'. :( PW
[Magisk] Swierk:
Miss old android days when you have all updates turn off and update by hand only things you really want without thinking if something fu*k up with no reason from day to day...

Sent from OnePlus 7 Pro, OxygenOS 10.0.3, TWRP 3.3.1-75, Magisk 20.4, TaiChi Xposed 6.1.8, Modded Play Store 16.5.15, android core.java patched and SafetyNet pass OK
[Magisk] zgfg:
Preventing from updating Google Play Services locally on your phone will not save your green SafetyNet.

Part of SafetyNet checking procedure is purely on Google servers

Three weeks ago when SafetyNet was failing because of detecting unlocked Bootloaders it was due to the sudden change on Google servers (and few days later it came back to 'normal' again due to another change/reverting on Google servers)
[Magisk] Swierk:
I am in a need of Magisk or Xposed module for limit share options in apps when you click share button.

Earlier was using Custom Share Xposed module but it's not working for Android 10 anymore. Any suggestions?

Sent from OnePlus 7 Pro, OxygenOS 10.0.3, TWRP 3.3.1-75, Magisk 20.4, TaiChi Xposed 6.1.8, Modded Play Store 16.5.15, android core.java patched and SafetyNet pass OK
[Magisk] drezz2:
thanks

finally after a time of testing it seems to work well, it takes a while to make the change due to the time I put it, but well thanks

The script only runs at startup, right? It is that I have noticed an increase in battery consumption, and I suppose that this has nothing to do
[Magisk] demonoidmaster:
For me magiskhide works and is on by default regardless of having updated to 20.4 (since as of now magiskhide is supposed to be off because apparently it doesn't work anymore)

But you should remove the script and test to see if magiskhide works right on boot with 20.4, you could also update your magiskmanager to the test builds instead, but i doubt it would change anything.

As for your question about "is it only on startup" i don't know, you'd have to make sure your script turns off magiskhide, have a slight delay then turn it on again, then exit (have a line of code that tells the script to end once it did the job)

Edit: i looked at the thing you posted and that script has no exit command, although idk if it would even need one but this is how I'd have it be

#!/system/bin/sh
sleep 120
/sbin/magiskhide --disable
sleep 1
/sbin/magiskhide --enable
exit

If the manager is repackaged and installed, if you flash magisk it'll install the normal manager only upon reboot to homescreen, however the repackaged manager will still be installed, upon tapping it's icon the regular manager will be uninstalled, making what you wrote pointless.

Besides, from flashing magisk , it doesn't overwrite the repackaged managers apk folder with it, because they aren't the same package name

---------- Post added at 10:06 PM ---------- Previous post was at 09:55 PM ----------

If your repackaged magisk manager is installed and you reflash magisk (or update magisk) it will install the manager, your repackaged manager will still be there.

Once your device boots, look for the app called "Manager" (or when you repackage give it a name to avoid confusion) and open it, upon opening it the default normal magisk manager is uninstalled

Or better yet, in the magisk.zip go to /common folder and delete the magisk.apk from inside, that way whenever you flash that magisk zip it will not install the normal magisk manager. Making the replaced manager that you already have installed the sole one on your device, that way there's no interference
[Magisk] HippoMan:
A proposed way to get around safety checks

I'm wondering if the following proposal might outline a path that allows us to override Google's safety checks ...

Unix and its derivatives such as linux have a facility called "chroot". It allows a program to be run while using a special directory as root. It works like this ...

chroot /fakeroot /path/to/program [ args ... ]

Anything under /fakeroot will look like it resides under root (i.e., under "/") when "program" is being run.

For example, if there is a directory called /fakeroot/usr/bin, then when "program" is invoked as shown above, all references to /usr/bin/ANYTHING that the program references will actually access /fakeroot/usr/bin/ANYTHING.

My proposal is to set up some sort of fake root filesystem that contains the entire Android file system of a non-rooted device without EdXposed or anything else which might cause a safety check to fail. Then, to create a utility which uses chroot to run any given APK with that fake root filesystem appearing to be root. If this could be implemented, then when the Google safety checks take place, they will be performed against what looks like a non-rooted, non-EdXposed-enabled device.

Does anyone who understands the inner workings of Android better than I do know whether such a procedure might work?

.​
[Magisk] thunderteaser:
Sometimes Magisk Manager screws something up when multiple versions are installed (like not detecting Magisk), and since of course they have different package names, you can have both of them (or even more) installed. That is why I told him to delete the original one first. However, if the manager is installed upon reboot, it is indeed pointless, as it is what you suggested next. If his company measures run at boot time, they could detect the original magisk package file installed, and he wants to prevent that from happening. I guess he should screw a bit around the install script: if the manager installation script Is in plain text, he could delete it (but i honestly don't know as I haven't checked myself what's inside the zip)

EDIT: I realized i was not very clear... Of course when you open original MM and select to hide it, the original one will get uninstalled leaving you with just the repackaged one (no need to click on the original one again as there won't be any, unless your drawer didn't update the app list). But if you reflash Magisk on top of that, you will end up with 2 versions installed and it may cause problems.
[Magisk] drezz2:
I'm not using 20.4 yet, I still have 20.3

I have not seen the changelog and I do not know if it would have any benefit to update or not, I really updated to 20.3 because the one that had did not pass the safetynet, at the moment with 20.3 yes

Looking now, I have seen that in the magisk log, only "stopping magiskhide" and "starting magiskhide" appear the time I turned on the mobile, so it doesn't seem like the script is running every "x" time