yashsingh1/xdaforums huggingface dataset:
[Magisk] Philnicolls89:
Ok I know that this topic has been discussed many times in this thread but I haven't been following it closely of late so I don't remember specifics.

Also since the search in thread function is broken it is quite difficult to try and find answers within the thread. (I also know the broken search function, always returning results for *, has been discussed but I also can't search for a solution to that either lol!).

I'm still on stable magisk v23 as I don't see the need to update until my device receives android 12 update.

My question is; now that support for the magisk repo has been officially turned off, is there another popular centralised repo to browse and download modules? Or do we now need to download modules and updates directly from a devs github? Of course modules that are already on the official magisk repo will still be allowed to update for the meantime but there are no new submissions of modules allowed.
[Magisk] Lughnasadh:
You can use this...

GitHub - Fox2Code/FoxMagiskModuleManager: A module manager for Magisk because the official app dropped support for it

A module manager for Magisk because the official app dropped support for it - Fox2Code/FoxMagiskModuleManager

github.com
[Magisk] GabbyWC:
Leaving "patch vbmeta" unchecked in Magisk Alpha did not result in a boot loop on my device. The problem I encountered after restarting, however, is that both "basic integrity" and "CTS profile" immediately failed SafetyNet. Even enabling the MagiskHide option in Magisk Alpha did not solve that problem. There was a DenyList but no MagiskHide list in that app. I ended up uninstalling Magisk Alpha, restoring the ROM's stock boot image and patching it with Magisk v23.0 stable. That configuration works properly and passes SafetyNet with MagiskHide enabled on Pixel Experience 12.0.
[Magisk] Philnicolls89:
Just what I was looking for, thanks mate. Let's hope the alt repo really takes off and becomes the new standard!
[Magisk] pndwal:
Well, that all sounds quite normal for builds post John's commits killing off MagiskHide! - Even basicIntegrity fails w/o additional solutions like Universal SafetyNet Fix (USNF). 😜 (- Your SafetyNet issues are not related to vbmeta etc!)

You need USNF Zygisk (2.2.1 is latest) in Canary or Alpha etc w/ Zygisk.

You need USNF Riru (2.1.3 is latest) for public Stable (pre MagiskHide removal) or Alpha etc custom builds w/ MagiskHide functionality restored. (* Nb. denylist functions like old hidelist in Alpha w/ MagiskHide enabled after Zygisk is disabled, but Google Play Services processes including SafetyNet process required for MagiskHide will need to be manually added in denylist.)

Nb. There is no proper USNF solution for TJW Canary builds lacking MagiskHide.

Nb.2. Older 1.x series USNF can still work on devices not affected by Google's September server end changes with MagiskHide enabled or the requisite Google Play Services processes manually added in denylist.

* Please see note above.

Well I'm fairly certain this is because your up-to-date PE ROM integrates USNF!

However, this will either be old 1.x series solution or 2.x series requiring Riru. This means you are covered for Magisk with MagiskHide, but not for later builds w/ Zygisk.

Being a custom ROM, it will also be spoofing a certified fingerprint for ctsProfile which otherwise would require a solution like MagiskHide Props Config module...

😝 PW
[Magisk] BlackSoulxxx:
Does anybody have issue with hiding the magisk app? On MIUI 12.6 21.12.20 A12 (Redmi K30 Pro) I have a weird bug which make my placeholder renamed app not update to full magisk (after prompt ), instead it will install regular magisk? Tried latest canary and alpha
[Magisk] zgfg:
As you can see on the screenshot, latest Magisk Alpha app was repackaged (Hide Magisk app) - pay attention to the randomized package name, but it is still Magisk Alpha

On your side, make sure you use correct Update channels (Alpha when working with Magisk Alpha and Canary when working with Magisk Canary) and that you allow all needed permissions to the Magisk app (MIUI 12.5+ by default blocks creating desktop shortcuts, etc) before repackaging
[Magisk] BlackSoulxxx:
I fixed the issue, turn out you have to repackage the magisk twice to hide it properly and manually uninstall the previous renamed one. Which is kinda strange.
[Magisk] rdmitry0911:
In my case (redmi note 8 + miui 12.0.2 Global) I can't make momo happy. The best scenario as for now is when momo unhappy with abnormal mounting. It is when at least first and last processes are checked in denylist. However I can't make momo completely happy like you did. Because of that (I think) ubs is unhappy too

To make changes in denylist I first enable enforce denylist and disable shamiko, than make changes in denylist, than disable enforce denylist and enable shamiko and than reboot. By the way, did your environment ever make momo unhappy because of abnormal mounting? If yes, what was the reason?
[Magisk] BlackSoulxxx:
I have issue with my banking app (https://play.google.com/store/apps/details?id=vn.com.techcombank.bb.app) detecting root, altho Im using Magisk Alpha in zygisk mode + shamiko. Momo only detecting bootloader unlocked and restriction on non-sdk interfaces not working on my phone (MIUI 21.12.10 Android 12). Every other banking apps I can bypass easy but not this. Can anybody give a shot?
[Magisk] iankelly2001:
It is a custom ROM - ArrowOS version 12.0 for star2lte (SM-G965F) (Android 12), latest 27/12/2021 build.

I didn't turn off Zygisk and had Universal SafetyNet Fix (Zygisk) v2.2.1 installed.

After the problems with passing SafetyNet attestation, I decided to uninstall all modules from Magisk Canary 23016, to see what was causing the problem. To my surprise, the phone then passed SafetyNet WITHOUT a changed fingerprint and WITHOUT Universal SafetyNet fix. However, Zygisk and DenyList were enabled, and now, choosing the two options for Google Play Services in DenyList were retained following reboots.

I did reinstall the Hide Props Magisk module though, as I was unable to get the phone to be certified in the Google Play Store, to enable me to use Google Pay and my banking apps. This time, I chose a certified device fingerprint specifically for my Samsung Galaxy S9+ (even though the only one available is for Android 8.0), instead of the fingerprint for a Google Pixel model I had chosen before (which had always worked before I installed the above ROM under Android 11). The phone still passed SafetyNet attestation. The problem was attempting to use a Pixel device fingerprint, which had always worked in the past with a different setup.

I got the phone to be certified in the Google Play Store by then clearing storage in Google Play Services, Google Play Store and Google Services Framework, then rebooting. It then became certified in the Google Play Store. Note, after deleting storage in those Google services, you delete your phone's Google account backup, so you have to do a Google backup of your Google account again, but that's no big deal.

Now the phone passes SafetyNet attestation, Google Pay is working and my banking apps (Santander, Halifax and Barclays in the UK) are not detecting root and working. I'm managing this WITHOUT the Universal SafetyNet Fix Magisk module being installed at all! I'll reinstall that if anything breaks!

A final note, I'm using Magisk hidden under a different package name and my TWRP folder on internal storage is renamed TWRP1, as I've read some banking apps will detect root by looking for a folder named "TWRP" in internal storage.

Hope these notes help others having any problems with passing SafetyNet and certifying your phone in the Play Store.
[Magisk] pndwal:
Yes, there are anomalies restoring Magisk App even when not hiding it, and even when not hidden to begin with, at least with recent Alpha builds.

Nb. John introduced a feature to restore the App on reboot if it is uninstalled some time ago, however it behaves strangely / with issues, at least in recent Alpha.

The App generated after such uninstall / reboot is very small (stub?), 100kb app size, and for me / on Alpha, this is the only one that prompts "Upgrade to full Magisk" but has some issues, so it may be you uninstalled / rebooted also.

Observations:

- With App NOT hidden, uninstall and reboot

--> Magisk app w/ app version 1.0, app size 100KB is installed w/ empty (grey) icon.

- Open this

--> "Upgrade to full Magisk to flnish the setup. Download and install?"

--> Downloading

--> "Please manually relaunch the app"

- Open this

--> "Add shortcut to home screen.

After hiding this app, its name and icon might become difficult to recognize. Do you want to add a pretty Shortcut to the home screen?"

- Selecting OK gives option to add shortcut in app drawer also. Select both.

--> Get pretty shortcuts on home screen and see both pretty (Magisk mask icon) shortcut and Magisk app empty (grey) icon (unchanged) in app drawer. Magisk app still version 1.0, app size 100KB, but user data is now 12.92MB.

This seems strange as installation behaves here like the process for hiding the Magisk app using stup APK. 🤔

However, any of the three icons open App which behaves as expected EXCEPT:

On selecting 'Hide the Magisk app' -

--> "Upgrade to full Magisk to flnish the setup. Download and install?"

--> Downloading .........

This never completes / fails! (Eliminated network issues also).

On the other hand, no such issues are experienced if full APK is downloaded:

- Uninstalled any Magisk app first.

- Install downloaded Alpha APK.

--> Magisk app w/ app version 0c1f6881-alpha, app size 23.62MB is installed w/ 'pretty' Magisk mask icon.

- Open this

--> app is fully installed and working as expected from the get go!

For me, hiding the app works fine and in ONE STEP only as long as ANY hidden app is uninstalled BEFORE manually installing latest APK, or RESTORED (un-hidden) before taking App Update within app. - Nb. While this is supposed to work even w/ app hidden, my experience has been that it fails 50% of the time with dual conflicting apps resulting.

Nb.2, as noted above, I have NOT succeeded in Hiding the Magisk app from the app Magisk self-generates after an uninstall / reboot (although it works as expected in other respects)... PW
[Magisk] pndwal:
Interesting!

Since it works even w/o USNF modules, clearly ROM integrates it's own means of passing SafetyNet, and spoofs a certified fingerprint also. You could see original print ROM uses/spoofs in MHPC, or current one in apps like DRM Info.

I believe USNF Zygisk (or other solutions) may well not activate at all if it detects an integrated solution, and I'd Hazzard a guess that only this commit is needed for your device (ie it's likely not affected by Google's September server end changes):

android_frameworks_base: base: keystore: Block key attestation for SafetyNet

https://review.arrowos.net/c/ArrowOS/android_frameworks_base/+/15118/

You can see it's a straight implementation of @kdrag0n's code from his Proton ROMs:

https://github.com/ProtonAOSP/android_frameworks_base/commit/13dc7d28c12d

I suppose there is no problem here as gms processes must only be removed from denylist for USNF-Zygisk, and it seems this wasn't starting anyway... PW
[Magisk] pndwal:
Can't hide it either with simple test on Zygisk setup like yours.

I can only suggest this (w/ Magisk App hidden of course) if you haven't already tried:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86160105 PW
[Magisk] Eng.Raman:
UBS Access and most banking apps search ( especially ) for the ( Bootloader unlocked ) flag/detection.

I have tested UBS Access app with another phone ( magisk canary installed with modules: busybox, shamiko, lsposed, USNF, and systemless hosts ) which has only ( Partition mounted abnormally ) flag / No suspicious traces found, added only the first process of UBS Access to the denylist ( as i did with my phone ) and it works well.

Yes with magisk alpha build 23015.
[Magisk] rodken:
Food For Thought: Any ideas on how to overcome the dreaded Bootloader unlocked flag/detection in order to take OTA's?
[Magisk] zgfg:
Please be specific, for which phone the unlocked Bootloader prevents OTA.

I'm not saying its not your case (if I recall correctly you might have already been discussing here) but it is not a common case or something to be taken for granted that everybody should know/understand about

Things are very different between the phones, ROMs and Android versions, between banking apps, etc - and general considerations do not apply

Btw, Momo for me also detects Bootloader unlocked and Pattitions mounted abnormally, but so far I have no problems except for the unhappy Momo itself
[Magisk] rodken:
From what I discovered over the months on the OP8 5G UW, the unlocked bootloader won't prevent getting the OTA but it will prevent it from installing.

In order for the OTA to install, I have to be 100% stock system, kernel, recovery, and radio. If I've modified any of those [which I did] I'll have to return to stock before the OTA will install.

Again, it all depends on any specifics of any modifications I've done to my device.
[Magisk] Eng.Raman:
This banking app worked for me by hiding both the magisk random package name and HMA app ( Using HMA lsposed module ), In addition to enabling the DenyList for the app main process.
[Magisk] rdmitry0911:
I've never had from momo "No suspicious traces found" message. All the time I have "The environment is abnormal. Modifications to the environments are detected" followed by "Partition mounted abnormally."

Without magisk installed, ubs app works fine with unlocked bootloader. So, it just does not like rooted devices
[Magisk] pndwal:
Just tried this (added HMA app itself to apps invisible to techcombank), but it still fails on my Redmi Note 8T w/ Zygisk / Shamiko.

Please say device / Momo detections / any other considerations. 😛 PW
[Magisk] V0latyle:
I apologize if this has already been asked, and I'm asking simply for the purpose of general information:

With the recent change to Zygote, in what circumstances would a module need to be ported to Zygisk? I understand that Riru doesn't work with Zygisk, so modules that depend on Riru have to be ported to Zygisk...but what about the ones that don't depend on anything else and interface with Magisk natively?
[Magisk] Eng.Raman:
It worked on my device ( details in my signature ) with happy Momo and hiding ( as i mentioned using HMA ) only 2 apps ( HMA app itself and the magisk repackaged app ).

Magisk alpha build 23016 installed with modules: Busybox, Shamiko, LSPosed, App systemizer, and systemless hosts. :)
[Magisk] pndwal:
Are you saying you need to relock bootloader to take OTA?

Yes, all partitions must be stock due to use of 'delta' incremental (differential) OTAs.* John outlines this requirement here:

https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md

Magisk app's Uninstall Magisk, Restore Images function with attempt to restore any stock images Magisk has altered (usually boot, sometimes recovery, vbmeta etc) for OTA updates while leaving Magisk settings / modules etc in /data. Other altered partitions (recovery, system, vendor mods etc) will need to be restored separately by user as John warns.

*Nb. Delta OTA's expect only certain corresponding and unaltered previous ROM build installations as they employ simple binary patching of data at specific addresses to minimise OTA package size. This means that they effectively package only code changes and may therefore be very small in comparison to any complete file altered, but bit-perfect specific sequential version images must be used / found. The OTA likely requires stock recovery functionality in addition.

I haven't heard of an unlocked bootloader preventing OTAs from installing however. PW
[Magisk] pndwal:
Ah, thanks; thought it might be your fantastic Realme device!

Sadly for @BlackSoulxxx problem / obstacle seems to be MIUI / Xiaomi related. ☹️ - Perhaps other MIUI users could give it (Techcombank) a shot, eg with Riru / MomoHider in addition to your HMA setup. 😛 PW
[Magisk] zgfg:
No need for panic.

Using myself five other modules, incl. V4A, and they all continue to work just fine with the new Alpha+Zygisk (and Shamiko)

Btw, you can easily install Canary and Alpha yourself and test the modules of interest.

Or you can monitor what others report here, on other forums or TG channels.

There is no general blackout affecting all modules

However, it is always possible that certain modules might have problems (not neccessary exclusively due to Zygisk but generally due to changes in Magisk, new A12, etc), but Zygisk itself affects only Riru and the Riru based modules
[Magisk] V0latyle:
I only use Universal Safetynet Fix and MagiskHide Props Config, I'm asking more for my own knowledge and to be able to answer questions.

Thanks for the explanation.
[Magisk] zzz2002:
Shamiko?
[Magisk] ipdev:
The basic difference is how the modification is done.

Zygote + Magisk = Zygisk

You will have to ask John if the "g" comes from Zygote or Magisk. ;)

Regular Magisk Modules are not affected by Zygisk.

They do not need that level of access.

---

Once the initial (early) boot is done, Zygote takes over and finishes the boot.

Zygote is in charge of processes after it takes over.

Zygisk gives the ability to modify at the Zygote level.

Think of Xposed.

---

Basically the addition of Zygisk is just another tool that a Magisk Module can use.

A good example is kdrag0n's USNF module.

Magisk alone was not enough so Riru was used to do the extra work.

Once Zygisk was implemented in Magisk.

kdrag0n was able to use Zygisk to do the same as he did with Riru to modify the Google Play Services process as it is loaded.​

---

During the initial implementation of Zygisk there were some issues with Riru core active.

They both modify at Zygote level.

Currently Riru is disabled if Zygisk is active.

Note: This is on the official side.

Unofficial builds might allow Riru and Zygisk to be active together.​

---

There are other modules that required Riru and being ported to Zygisk.

LSPosed for example.

[Releases] - GitHub - Link

---

Hope it helps more than confuse. 🙃

Cheers. :cowboy:
[Magisk] pndwal:
Bit further:

Official Developer Guide for Magisk Modules remains the same:

https://topjohnwu.github.io/Magisk/guides.html#magisk-modules

New notes for Developing Zygisk Modules are here:

https://github.com/topjohnwu/zygisk-module-sample#developing-zygisk-modules

TJW builds allow a choice of either xHook in Riru or in Zygisk but not in both till now. I cited a comment (clarification) on conflict / compatibility / coexistence here (alliteration unintended):

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86126067

👀 PW
[Magisk] pndwal:
Great summary!

At least two Alpha builds allowed this; vvb2060 added a commit to revert John's restriction, but this was reversed again and LSPosed compatibility was cited at the time. Post linked in my post above illustrates potential for conflict where coexistence is allowed. PW
[Magisk] zgfg:
I have (also) MIUI (Xiaomi Mi 9T, Xiaomi.eu Stable, A11, MIUI 12.5.2)

Magisk Alpha 23016 latest, Zygisk, Shamiko

And my Momo is pretty unhappy (screenshot) - off the suspicious items I can only disable USB debugging (but didn't mind to because I cannot overcone Bootloader Unlocked, Abnormal partitions and Non-SDK interfaces)

But I installed both UBS Access and Techcombank (I don't have accounts) and from the initial screens they don't complain anything about root or so (screenshots)

- Installed the apps

- Re-enabled DenyList (it was disabled because of Shamiko)

- Added both apps to DenyList

- Added both apps to HMA to hide from them Magisk app, LSPosed and all my LSPosed modules

- Rebooted

- Disabled DenyList (Shamiko to take over)

- Rebooted

Only then opened the two banking apps for first time

Btw, I didn't repackage Magisk app and my TWRP folder is renamed to TWRP.bak. Nothing else special
[Magisk] BlackSoulxxx:
Yup, confirm HMA will do it job and bypass the Techcombank apps easily. Thanks guys!!!
[Magisk] pndwal:
Well done proving this is do-able on MIUI, especially with Zygisk / Shamiko! 😛

Just tried these two apps again w/ your reboots since I hadn't done that; still no dice. ☹️

I suspect my Momo's differing sadness is a clue:

- So I have 'Found Magisk' and 'ART Parameters are abnormal' in addition to your Momo's ailments.

I believe you may have discussed countermeasures for these before, but please remind me...

Guess it could also be something to do with my A10 stock MIUI - Does custom XiaomiEU MIUI or A11 make the difference?

I also get 'xposed modules: Found' (but did hide both from bank apps in HMA):

- Do you get similar or can we hide here?

I'd love your help to thwart these detections... PW
[Magisk] zgfg:
I had Found Magisk and solved by renaming TWRP folder
[Magisk] pndwal:
Ta... sounds strange Momo assumes Magisk root from custom recovery!

Anyway, I have stock recovery... Just looked and can't see any residual TWRP folder either... PW
[Magisk] rodken:
This topic has been discussed before in many ways that I can keep track of. I just cannot wrap my head around as to why it is so and/or is there a work-around besides using factory images [which are not in the wild] for the OP8 5G UW.

Even restoring the stock boot image to mitigate the process was to no avail.
[Magisk] pndwal:
Ok... But I'm still not clear if you're saying you must lock bootloader every time you take an OTA... You seem to indicate this... Can you confirm? 🤔 PW
[Magisk] rodken:
It has been confirmed that on the OP8 5G UW, I would have to utilize the MSM Tool which reverts the entire device to factory [locked bootloader and all] which in turns allows me to install OTA's.
[Magisk] pndwal:
{Mod edit: Quoted post has been deleted}

OK... Ta...

I would have thought that you could avoid flash tool using John's instructions however. (ie, as long as no partitions - recovery, system, other - other than those altered by Magisk flashing are modified, taking Uninstall Magisk, Restore Images from within app should allow successful OTA update)...

I guess Restore Images option must be broken on your device... PW
[Magisk] DiamondJohn:
Not really a specific answer to any question, but since I have always run with an unlocked bootloader, rooted and custom ROM's, except for my current phone which runs stock rooted A11 on a Pixel 4a. As expected, I did not get auto notifications of the monthly updates for A11, but was really suprised as I now have constant nagging to update to A12. It occurred to me recently that the A12 upgrade would be a full complete flash, whereas the A11 would of been incremental, so not offered by Google as they dont know what state my ROM is in at the time. Whereas, the A12 is basically a cleaner/complete flash while keeping data thus blowing away any dodgy things I have done to my phone..
[Magisk] HippoMan:
As for me, I have been avoiding upgrading my OS (OOS 10 on OnePlus 7Pro), because I love all the dodgy things I've done to my phone.

All this A11/A12 and recent Magisk stuff is a huge rabbit hole that I won't go down, unless compelled by forces beyond my control.