yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Fair points. I did say "Can't quite see how these could cause [MENTION=7786725]zgfg[/MENTION]'s issue" but I suspected TWRP simply due to its buggy nature / lack of development / warnings about improper detection of modern devices & unmet recovery environment expectations by John Wu.

Still, it's likely MM related as you say, considering corruption was in /data... (or not...) Guess I should do less thinking out loud... Take it you fixed by deleting database?

Yes, as I mentioned "My guess is that something may have gotten messed up when booting unrooted by flashing standard boot.img only, since some unexpected/incompatible Magisk files/settings will remain if Magisk is not uninstalled using proper cleanup scripts." Don't know why this might occur though.. I was just 'throwing it out there' as Manager may be confused by files/settings associated with Magisk root because ordinarily they would have been removed by uninstall cleanup scripts whether run from MM or recovery zip.

My hunch is that you mightn't have had any such problem if you'd performed same test using proper uninstall methods, so it may not be fault of MM either; rather, quite possibly, related to (unanticipated) incomplete Magisk removal... thinking out loud again. :rolleyes:

Yes, but this case may still be no fault of MM if we consider incomplete cleanup.

Having said all that, although I had previously checked SafetyNet Check results unlocked / unrooted and didn't get your surprising ctsProfile ✓ result, I decided to reproduce your 3rd test on RN8T

As before, I get basicIntegrity ✓, ctsProfile X, and evalType BASIC (despite always showing HARDWARE w/ bootloader locked).

This is as expected (if we disregard BASIC evalType), but it makes me wonder if your ctsProfile ✓ result is actually true...

I'd say it's highly likely that your MM failure actually indicates an inconsistency in the test; database may have actually been corrupted already when you got SafetyNet ctsProfile ✓, and may have (I'd say probably) caused / account for this (unheard of) result.

The only other control that differs in my test (apart from device model), is use of approved Fastboot flashing method, but I doubt alternative use of TWRP actually has a bearing on the result, although I didn't suffer any Magisk Manager failure to launch / database corruption on restoring root...

Anyway, my bet is that if you were to to repeat the test, but this time uninstall Magisk using MM uninstall function, or recovery magisk_uninstaller.zip, you'd get ctsProfile X ...

Hope there's something worth digesting here. :D PW
[Magisk] cnoevl21:
is edxposed working for others? I installed riru, but when i try to install edxposed it keeps failing, saying i need to install riru-core first. Another member mentioned that riru-core was recently updated and changed to just riru and that may be why edxposed is failing. And to wait for an update of edxposed. Does this sound about right? or am i doing something wrong?

I really just wanted to run gravity box. Or is there another way to make it so that I can change function of buttons? I really just want to do stuff like long press back button kill app and long press recent apps button to take screen shot. All stuff id usually do in gravity box.
[Magisk] Lord Sithek:
Something is messed up with your message since it appeared 4 times :D I suppose it isn't the right place to ask (rather in the EdXposed thread), but as far as I know, at the moment you need to use EdXposed Canary with Riru 22.1 +

EDIT: It may depend on your device though if EdXposed Canary will run properly with Riru 22. It's working flawlessly on my Mi Note 10, but I had issues on Samsung Galaxy Tab S5e (some modules weren't loaded properly) and I decided to stay with Riru 21 until EdXposed get stable update
[Magisk] dope77:
[MENTION=2391685]cnoevl21[/MENTION] either downgrade riru to v21 (you'll find it on riru's Github) or flash EdXposed canary (might cause bootloop on your device). It's up to you, anyway if you decide to flash EdXposed canary, make sure to download the uninstaller first and flash it through twrp in case something goes wrong.
[Magisk] zgfg:
[MENTION=4667597]Didgeridoohan[/MENTION], [MENTION=7550078]pndwal[/MENTION], [MENTION=7280276]ipdev[/MENTION]... happy end of journey

Unfortunately, deleting /data/adb/magisk.db (and rebooting) did not help - Manager was still halted on splashscreen

At the end I flashed (all again from TWRP - sic!) magisk-unistaller.zip and my same old, boot image previously patched by Magisk v21101, rebooted - and I was finally able again to install and use Magisk Manager

Two minor observations:

After the all-through-github reorganizations, now it's become a little bit complicated to find the latest magisk-uninstaller.zip (Canary brand, newer than Stble uninstaller).

Aml and mhpc leave their folders at /data/adb upon uninstalling those modules. IMO, corresponding uninstall.sh scripts should be taking care to remove everything remaining from the modules
[Magisk] Didgeridoohan:
They both already do:

https://github.com/Magisk-Modules-R...219aa6e2014193e58f663a442105/uninstall.sh#L12

https://github.com/Magisk-Modules-R...e045b715bc11ea48626ce566525f/uninstall.sh#L16

Great that you got things working again.
[Magisk] pndwal:
But what's changed? Still just as it always was for me:

John's GitHub, magisk_files repository, canary branch, 'go to file' for all latest files or commit history (clock) symbol for all builds...

Happy to hear magisk-uninstaller.zip did the trick. PW
[Magisk] zgfg:
There used to be an announcement thread on XDA where all the latest Magisk, Managers, uninstallers (per channels) were easily available from the OP post #1

You can count the number of clicks you listed - consider a first-time user who is not familiar with the Github design and then honestly say is it really convenient

Btw,, it would be good to have on the main Magisk Github page, alongside the links for Magisk and Manager downloads, also a direct link to download the uninstaller, to avoid 'go to file' and all that stuff

I hope we are not dogmatic here that heretic comments are not allowed?
[Magisk] pndwal:
:confused: You said:

But this has NOT changed, even with John's fresh documentation and 21 series builds! Latest are still where they were.

Apparently the old pre-21 canary builds have been removed however, and he's started fresh... don't know where the legacy builds are now. Earliest is now 03/10/2020.

Re Announcement thread on XDA, that thread/OP is still linked from OP here, and points to 'Magisk's GitHub page' for 'all up-to-date info and links', same page as linked from Magisk Manager main page.

All links for public Stable/Beta use are at ones fingertips there, as is latest debug Canary Manager to get bleeding/cutting edge users started. Secondary files like magisk-uninstall.zip for Magisk and stub-release.apk for Magisk Manager are easily found at end of this page in 'releases' (click this, select build, click assets). Public release builds back to May 2007 (Magisk 7.0/Manager 3.0) are archived.

GitHub structure may not be as easy as an XDA forum w/ well maintained OP, but it's Hobson's choice for us as OP decided to host exclusively on GitHub due to his own understandable frustrations with XDA...

At the end of the day, even first time users are custom modders, and should be able to adapt to GitHub where needed... Could be much worse; I find John's methods fairly efficient, logical and orderly.

Aside from this, I grant that debug Canary users will need to discover magisk_files repository in root of topjohnwu GitHub to find canary channel w/ other non-public builds/files. This requires a bit of searching/asking, but these users should NOT be first-time-users, and should be familiar with this forum community.

Seems to me the extra steps to access are probably by design/intended for same reasons Canary channel has been removed from 'public' Magisk Manager builds.

I'd go for that. :good: (not heretical :) )...

I guess John may have his own reasoning, but with OP AWOL and no Asterix fans in sight, who's being Dogmatix? :silly: PW
[Magisk] chowceal:
where r the modules

running magisk v20.4 & manager v8.0.3. haven't really looked for modules in a while. wanted to browse today, and dont know where the modules went! when i select the puzzle piece, it takes me to the mods i have installed . how can i browse the repositiory?? when i search for a module, nothing comes up and it just goes back to the installed list.
[Magisk] pndwal:
I'm on latest Canary, but it's working for me w/ Manager 315, which I think is identical to yours (314) save for Canary Channel.

Have you ensured you have internet and manager is connecting? (eg Check SafetyNet option is showing) Tried Refresh Local Data icon at top of Modules page? Cleared Repo Cache from Settings?... If none of these work, Try clearing cache/data for Magisk Manager. PW
[Magisk] J.Michael:
Where are "amldir" and "MHPCPATH" set?
[Magisk] Didgeridoohan:
In customize.sh and util_functions.sh respectively.
[Magisk] chowceal:
yes, internet working. Check SafetyNet option is showing. Tried Refresh Local Data. Cleared cache/data for Magisk Manager. the only thing is i dont see repo cache in settings.
[Magisk] pndwal:
Second-last item under 'Manager' in settings for me. If that's not showing, something may be messed up. Could try uninstall/reinstall Manager, or even uninstall/reinstall Magisk (Uninstall Magisk button on Manager home page).

Aside from this, "Switch to the new Magisk Module Repo setup in preparation to allow 3rd party repos" was a major update in this version. Don't know of problems with it, or of any additional settings for it as yet however.

https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post83920269 PW
[Magisk] Wolfcity:
Just to give you guys some information about how CTS Profile safety net behaves on my clean stock install, bootloader locked, device Xiaomi Mi 9t, MIUI 12.0.3.0 (QFJEUXM)/A10.

I just installed latest MM to check SN.

As you can see, hardware attestation asks for HARDWARE, not BASIC.

Bootloader ist locked and never has been unlocked.

Hope that helps for troubleshooting.
[Magisk] chowceal:
i just went ahead and down graded the version. everything is working. thanx for your help!
[Magisk] Moto_Fan:
FYI : I believe Magisk is throwing off "False Negatives".i dont think it has to do with Magisk but with Magisk Manager. so i been playing with different versions of Manager. i think its Manager throwing off false negatives. i have gotten all combinations to read TRUE/FALSE and FALSE/FALSE, just by going into Manager Settings and backing out and rerunning safteynet...
[Magisk] pndwal:
Thanks for confirmation... That's exactly what I got with RN8T for some 10 months locked.

This gives expectation that model prop mismatch as achieved by MHPC will be needed 'force'/cause a fallback to BASIC Key Attestation in order to pass SafetyNet after unlocking bootloader.

I'd be interested if your evalType state changes to BASIC before rooting if you do unlock bootloader.

I'm fairly certain it will (at least at present).

I don't understand why this occurs, but it means that for affected devices forcing BASIC by changing model prop(s) turns out to be unnecessary (for the present). PW

---------- Post added at 10:58 PM ---------- Previous post was at 10:49 PM ----------

Yes, this has been observed regarding basicIntegrity, especially when variables like EdXposed or other mods/Magisk modules are involved. And more likely intermittent/random tripping rather than false negatives...

https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post82166469

However, evalType showing BASIC on devices having/listed by Google to utilise Hardware Key Attestation is quite a different thing. :) PW
[Magisk] zgfg:
Magisk Manager does not gives the results by itself - it jcalls SafetyNet API from Google Play Framework to do the attest part.

Install in parallel another SafetyNet checker from Playstore and compare the results

Btw, I see on both your screenshots being consistent and your Basic Integraty is failing. It might be that SN is finding your root (did you enable Magisk Hide in Manager Settings), but it maybe also due to Edxposed, etc - it just means what it says, that your system does not meet the required integrity criteria.

Although for you or me having root (which means having changes in the boot or recovery partitions) does not mean that we lost integrity of our systems - for Google and their SafetyNet it means so, hence it's not false negative

False negative SafetyNet would be that you have stock firmware (certified by Google), Bootloader locked (and therefore no Magisk, Edxposed, etc) but that SafetyNet check would be showing a failure
[Magisk] Wolfcity:
I will let you know the status of evalType when I'm going to unlock BL and before rooting (if big G doesn't do new crazy things until then and we may have new and different problems.....).
[Magisk] Moto_Fan:
No I did not enable hide I never do I'm actually never worried about safety net cuz I never use anything that requires it I just took move myself up to the next Android level if you will started getting deeper into the subject and looking more into things switching from Windows to LIX, like learning a new languauge. Free up on DoS and Will Windows, 1st LIX machine I touched was a Moto G4 Plus ROM Overlay and Kernel, and one day Windows crashed and my only option was to flash Ubuntu 20.04. so be gentle.... Been an Android user since July of 2010 tho ? anyway these screenshots were taken WITHOUT anything added what so evet added, and only update factory or Google apks, not 1 app with Root Access.

ALL Day I been fukcin with it and it was positive negative, I keep hitting "try again" same result. I go into settings, back out of settings and throughs them both negative. so I figured out that part which throws them both negative trying to figure out how I get one negative one positive and then I'll work on getting two positives

... Believe me I'm far from worried about it I did forget to mention the model Android version probably build number and all that good stuff so I'll list that here and I'm not the only user of this device that came up with the two negatives:

-Motorola Edge XT-2063-2 codename:racer

-Stock Motorola Android 10 (August/October 2020 Security Patches)

-Build # QPD30.114-80

-Rooted using booted, not installed TWRP
[Magisk] zgfg:
With Magisk v21 you must manually enable Magisk hide - that is the major change

Earlier, Magisk hide was enabled by default. If you don't enable Magisk Hide you may have all sorts of problems like Device not certified in Playstore, GPay and some bank apps not working, etc
[Magisk] Moto_Fan:
Honestly, I never had any issues with any apps I use complaining about ROOT, so I never cared nor bothered. Just trying to learn a little more about what I'm actually doing and how it works and why or what changed.

It doesn't explain, why going into settings would cause them both to be negative. And again NO MODS.... I'll try a different safety net checker....
[Magisk] zgfg:
You never had, but people do have - you can read what the others ask, discuss in this thread (my banking app this and that, doesn't open, etc)

But anyway, enable Magisk hide (if you didn't), then experiment and check if you have more consistent results

Theory behind the SafetyNet has benn many times linked in this thread (but yes, Google make exceptions, and they chnge things probably trying to balamce):

https://developer.android.com/training/safetynet/attestation
[Magisk] Moto_Fan:
Yo go figure....
[Magisk] pndwal:
With Magisk v20.4, v21 you must manually enable Magisk hide - that is the major change since 23/3/2020 public Beta, 28/3/2020 public Stable.

Earlier than this Magisk hide was enabled by default... ;)

https://topjohnwu.github.io/Magisk/releases/20400.html

Supplementary related history ONLY nostalgic Magisk History buffs will appreciate. (Others, NO NEED to read on. ;) ):

Seems he got bored with Star Wars, so...

...Interestingly, on the same date as 20.4 was released John clarified why he no longer updates his XDA threads:

Man, don't time fly!

Tempus Fugit, PW
[Magisk] pndwal:
MediaTek device incompatiblity:

Some insight:

:( PW
[Magisk] geokilla:
I enabled Magisk Hide and I still can't get my banking app to work (Tangerine). I guess the only way is to remove Magisk?
[Magisk] JudgeDread11:
There is often more then just enabling Magisk hide.

If you search this thread you'll find a link to a website with many tips to try.
[Magisk] wallace108:
So does that mean we are hopeless? Or is there still hope?
[Magisk] iamrance.asa:
I would try patching the boot.img with Magisk then flashing only the patched boot.img through SP Flash Tool or Fastboot.[If your bootloader is unlocked!] If it doesn't work, then just flash back the stock boot.img via methods above.

If it's a newer version of Android/MTK Kernel it probably won't work as of John Wu's statement about it but if you're lucky, your device won't be one that is patched.

It's very likely someone will come up with a method to get Magisk working on the patched kernel MTKs since there is a big market of MTK devices that would highly benefit from having Magisk. However, it will most likely not be soon.
[Magisk] pndwal:
A very good question. And I ain't sure either...

I'm not across all the relevant difficulties, or even if this recently discovered one precludes Patching Boot Image method, but it seems even this will need some refinement for affected MTK devices to flash Magisk successfully.

Good answer above; give stuff a go if you haven't already... And I agree "it's very likely someone will come up with a method to get Magisk working on the patched kernel MTKs", that 'someone' being John Wu... perhaps with a clue or two from his esteemed colleagues.

He eats, sleeps and breathes this stuff! We'll likely just have to wait for him to dream something up...

https://mobile.twitter.com/topjohnwu/status/1245263151089639424 PW
[Magisk] wallace108:
Thanks pndwal, This seems promising. I won't hold my breath but won't lose hope either. :good:
[Magisk] pndwal:
Yep.

Or just click GitHub symbol (last under [MENTION=4470081]topjohnwu[/MENTION]) on Magisk Manager home page, and you will see it (Magisk Troubleshooting Wiki) along with other essential reading (under Useful Links).

You'll want MagiskHide - Hiding root and passing Safety Net section, especially Hiding root from apps, and More hiding tips. :good:

Nb. Removing Magisk will very likely only work if you also restore full stock and relock bootloader. PW
[Magisk] ipdev:
Quick question.

Has any one run into this before?

I do not remember seeing this comment before and a quick search did not seem to show anything.

Showing results from Magisk General Support / Discussion

No Results Found

Search all of XDA for SafetyNet check missing from manger

Magisk is working, root, magisk hide was working when I first installed magisk and checked safetynet.

Now the Safetynet check option is just gone.

Legacy device, Nexus 7 (2013) LTE version testing custom lineageos 18.

Magisk canary.

Cheers. :cowboy:
[Magisk] zgfg:
SsfetyNet option (and Uninstall Magisk) do not show when Magisk Manager thinks there is no connection)

But yours show the latest available versions for Magisk and Manager (it would show N/A for them when there is no connection

Nevertheless, I think somebody reported the opposite issue - SafetyNet and Uninstall Magisk options were available but latest Magisk and Manager versions not

Try cleaning Cache and Data for Manager or reinstall the Manager
[Magisk] pndwal:
Do you have GApps?

LOS (Custom) without GApps (ie. no gms / Play Services)?

Try searching SafetyNet, GApps, gms... Think you'll work it out! :D :good: PW

Info:

The SafetyNet API is part of Google Play Services.

https://android-developers.googleblog.com/2017/11/10-things-you-might-be-doing-wrong-when.html?m=1
[Magisk] cubzfan68:
Magisk Canary

Not sure if i'm missing something obvious but, Is there a way to flash modules on Canary? I'm trying to flash A11 which I'm guessing only Magisk 21 will work but can't flash modules..... I did search this thread before asking and found nothing, any help would be appreciated......
[Magisk] JudgeDread11:
You can find the modules page on the bottom bar (puzzle piece). The bar his, so you might have to scroll up to show it. On the top of the modules page there is a button install from storage
[Magisk] Regys:
Hi,

Why does magisk not ask to grant certain applications ?

When I open an app I don't have the pop-up that asks me to grant it.

thanks !

---------- Post added at 06:36 PM ---------- Previous post was at 06:36 PM ----------

Hi,

Why does magisk not ask to grant certain applications ?

When I open an app I don't have the pop-up that asks me to grant it.

thanks !
[Magisk] dope77:
Are you sure magisk is properly installed?

If yes,

Open magisk and check if the app is denied supersu (because the prompt won't show if the app is denied su permission). If it's denied , simply turn it on.

You could also try this, go to settings and set magisk to auto grant su permissions without prompting. This might solve your issue
[Magisk] DiamondJohn:
Which version of Magisk are you running?I have seen many times where early canary builds have this behaviour.
[Magisk] Sanzium:
Sorry for bringing this up again, but I tried the patching and flashing method in Android 11 (cepheus, Revengeos 4.0 Android 11) and it did not work too. Just like flashing canary or the latest 21.1 zip through TWRP, it reboots directly to the bootloader, not even a bootloop (no boot logo is shown).

I am very intrigued by the fact that the supplied "magisk-debug (2).zip" (which actually says "Magisk MODDED 42069" when flashing) is able to root the rom and, after installing that, we can flash official Magisk (either canary or 21.1) and everything works. I tried to ask for the source code of this mod, but the rom dev does not have it.

If anyone have any info about this "modded" version, specially the source code, I would be happy to hear.

Likewise, if anyone was able to root Android 11 on a Xiaomi phone without flashing these "we have no idea where it came from" zips, it would be very nice too.

Thanks!
[Magisk] Didgeridoohan:
[MENTION=5895812]Sanzium[/MENTION]

When you track down whomever created that zip, link them this:

https://twitter.com/topjohnwu/status/1320778190411821058?s=20
[Magisk] Sanzium:
I feel his pain, so much work for someone basically stealing his code.

Unfortunately I don't think it's really traceable. I've seen it mentioned on 4pda and in other threads here on XDA.
[Magisk] pndwal:
Have you tried flashing w/ stock recovery intact? There are many reports of rooting A11 failing with TWRP loaded due to TWRP incompatibility problems. (You do have partial compatibility, ie with partition scheme, as device launched W/ A9 (A10 Launch version have dynamic/logical partitions) however.

https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post83725859

Try Patching method first.

Tip: Try w/ Patching boot.img even if Ramdisk: No is reported as many Xiaomi devices have ramdisk compatible bootloaders despite no stock ramdisk, and Magisk now property patches boot.img w/ ramdisk.

Some have also had success booting to TWRP VIA fastboot (NOT flashed, stock recovery intact), and flashing Magisk zip from there...

At least one user in that forum reports success without modded Magisk. Possible clue: he didn't use disable encryption zip etc...

https://xdaforums.com/Mi-9/development/rom-revengeos-4-0-mi-9-cepheus-t4173859/post83669915 PW
[Magisk] zgfg:
I don't have A11 beta for my Mi 9T, but I read a lot and they say patching does not work either for Xiaomi A11.

Again, it's NOT about incompatible TWRP!

Actually, they all claim that it WORKS for them by TWRP, but if they flash that additional zip before the Canary Magisk

I also searched around where the Magisk-R.zip is coming from, even joined the Telegram group (hundreds of mostly useless messages a day) but all just copy/paste the same steps, cannot track the origin, even does R stands for A11 or ru

Just sending the MagiskR.zip to TJW