yashsingh1/xdaforums huggingface dataset:
[Magisk] hokiealumnus:
I'm on a vs985 G3 with TWRP 3.0.2-0 official. I keep getting an error 1, failure to extract zip file. I have downloaded the v9 file and tried to flash it six different times. Anybody else having this issue?

Edit - I've tried three more times, using both the link in the post and the attachment.

Edit 2 - Got it sorted using magisk manager to install. Expected, but warning to others: G3 users will get a secure boot error if you don't bump after letting it install!
[Magisk] westeight:
Magisk v9 + Xposed fails SafetyNet:
[Magisk] andrew2432:
Magisk hide within settings

It's xposed that's the issue. Did you use the magisk nodded version or a system version? Did you try root switch? Not sure it's compatability with magisk root but would like to know if it does...
[Magisk] westeight:
Magisk version, 86.6. Failing with or without Root Switch:
[Magisk] fink.nottle:
tiny.cc is blocked by some adblockers. The magisk manager gives no indication of the fact that the download failed.
[Magisk] andrew2432:
Root switch can only hide xposed installed within the system. Are the model specific xposed not compatible magisk?
[Magisk] mrxtc89117:
I believe you can disable xposed from the xposed installer app and reboot. Of course, any xposed modules will not work until you enable it again.
[Magisk] thomasswan5547:
what is resetprop exactly, and how do you go about enabling and using it? thanks thomas
[Magisk] H4X0R46:
I don't know how I missed that ._. thanks man!
[Magisk] Shaglok:
Adaway can't find su binary. Any tip to fix it, please?
[Magisk] phuhcue:
Was using v8 and phh. After last SN update I flashed magisk Uninstaller and was able to pass. From that state, I flashed V9 zip and newest phh. Installed newest manager. Fail SN. Toggle hide, reboot. Fail SN. Flashing Uninstaller and reboot passes SN.

Have I missed something? I notice there is nothing checked in magisk hide list. Shouldn't there be some items checked by default?

Tmo Note 5 SM-N920t. Darkstarker v11 DPG1, Skyhigh kernel.
[Magisk] HamsterHam:
How did you flash the superuser module within magisk? Were you rooted then flashed superuser in magisk and then unroot?

Edit: All working now. Cheers! Safetynet passes.
[Magisk] jsaxon2:
You need to check Google Play Services Iin the hide list. It wasn't check by default for me.
[Magisk] waylo:
Wonderful work as always! Donation incoming.

EDIT: 7XM959360T297491F

Just for anyone else, I disabled the separate xsetprop module made by nkk71 and captain_throwback before I rebooted. It's built in now, so who knows what kind of weird conflicts will happen with both running.

---------- Post added at 05:24 PM ---------- Previous post was at 05:23 PM ----------

That's not checked for me either, but I still pass. Odd. Must be device specific?
[Magisk] garthybarthy:
Clean install on S6 Griffin ROM, Magisk V9, PHH 2

66-2. Safetynet CTS Profile Match: False :(

Checked options in magiskhide, no xposed currently installed.
[Magisk] badabing2003:
He's talking about OTA, you can't modify OTA, it will fail AVB.
[Magisk] J.Michael:
He said "no OTA updates for me. So I download them from the Google site", which I took to mean he downloaded a full ROM.

I don't understand your reference to "AVB". If he can flash a patched boot image after the system is updated, and if he does indeed have a full ROM corresponding to an updated system, why couldn't the first flash of the updated system be with the boot image patched? (Unless this is one of those systems where Magisk cannot do a complete job of patching unless it is currently running on the target system.)
[Magisk] tim1aust:
J Michael,

My bad, I did in fact mean I download the OTA and flash that because Google knows my phone is rooted or bootloader unlocked or something else, but never pushes updates to my phone. But I am certainly not an expert in all this, I am assuming badabing2003 is referring to a signature check or somesuch failing if I replace the boot image in the OTA zip with the magisk_patched one.

I do appreciate your input, thanks! I'm learning...
[Magisk] pndwal:
Generally, new partition digest checks are what prevents recent delta (incremental/differential) OTA Pixel updates from working with 'Flash Magisk to inactive slot' method (to preserve Magisk) on P6 and P7 series even after restoring unpatched images since the new checking is done by the update engine after reboot, although @Lughnasadh has confirmed that it (inexplicably) still works in some cases...

I suspect @badabing2003 may know this already, but I don't know if newer full ROM downloaded OTAs incorporate the same post reboot checks... Either way, you could try the method as outlined here:

https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md#devices-with-ab-partitions

1) with proper stock delta OTA from 'over to the air' (small chance if you have P6+), or

2) with full downloaded OTA ROM to find out...

If 2) works, I'd be interested to know if you actually need to restore images first too... You probably wouldn't as pre-reboot checks should not really be needed w/ full OTA, and I suspect the post-reboot checks would only have been added if pre-reboot checks exist...

Nb. I have no practical experience with Pixels or A/B, and others may already have determined that this full OTA ROM approach is impossible. 🙃 PW
[Magisk] shoey63:
I'm finding of late on the p6 that trying to take an OTA update after restoring images aborts before it even starts. It will only take after restoring images and rebooting.

This makes installing Magisk to inactivate slot after OTA an impossibility on latest firmware.
[Magisk] pndwal:
Guessing standard delta over the air update?... Sad...

But what I'd like to know is whether it is possible to apply full OTA ROM download before reboot either with or without images restored on Pixels with late updates. 😛 PW
[Magisk] shoey63:
You mean on the pc?

Well, yeah, how else are you going to apply it?

You can flash the full factory images ROM zip in fastboot, or sideload the full OTA image zip in stock recovery.

The Magisk patched boot partition will be overwritten without issue.

You then, of course patch the new boot image and fastboot it.

(Or just let @badabing2003 's Pixel Flasher do all the work for you)
[Magisk] badabing2003:
My small interests in OTA is primarily for two benefits OTA could offer.

1- Performing it on the phone without needing a PC

2- No phone modification is required (no root)

3- Active partition is kept intact.

1- In the context of your question, I don't know if it is possible and if it is, how it's done, how does one apply a full OTA all on the phone? assuming that you would need to download it and apply it.

Doing so on the PC, would offer no benefit compared to Factory flashing, unless #2

2- If the OTA image is modified in any way, than it will fail, and I'm thinking in the context of injecting a patched boot to gain root access on a phone that has the bootloader locked.

3- I don't know how to interrupt Full OTA sideloading to stop making it boot to system after completion, to gain an opportunity to flash a patched boot image before booting to system (of course bootloader needs to be unlocked for this) but the benefit here is that the previously active slot is not touched and system partition is not overwritten by system-other image as is the case for factory image flashing.
[Magisk] tim1aust:
#1 is what I would love to have also, but have been unable to find any information anywhere how to do this. If one could download the OTA and have the standard "Update is available" process allow you to specify the downloaded OTA image, then the process @pndwal referred to at https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md#devices-with-ab-partitions would allow the OTA update be applied with stock images restored, then use Magisk "install to inactive partition" be used *before* rebooting. In fact, my Moto Z3 is running PixelExperience ROM and I get streaming OTA updates on that phone, and follow @pndwal's referenced process without a hitch, each month.

I can't suss out why Google insists on "streaming" OTA updates, and forbid local OTA updates. I suspect the reasoning is based somewhat on they don't want to encourage rooting. Which I suppose is not unreasonable from their view, but if someone has a rooted phone/unlocked bootloader they have already voided their warranty, so IMHO it should be left to the owner of the phone to make these decisions.
[Magisk] pndwal:
Actually I meant using updater engine...

On MIUI devices users can select available delta updates or download full latest package or choose one downloaded separately and updater engine flashes... Here are the options:

Does Pixel not have options to flash full OTA ROMs from booted system?

Yup ... But you're talking about flashing current partition... I was guessing that full OTA from updater engine might write to inactive partition without issues (because blocks from images on active partition are not needed unless OTA is delta) if options available on pixel...

(Or would patch Magisk to inactive partition if possible...) 👍 PW
[Magisk] badabing2003:
I have never seen it, it does not mean it doesn't exist, just that I have never seen it, besides my exposure would be super limited when updated friends' family's phones, my phones have not been going through that for ages.

I would hope and expect not, otherwise it would defeat the purpose of OTA, what if something goes wrong, how would it be able to revert?

PF supports that, but am not sure how's we're making use of that if we can't skip the reboot.
[Magisk] shoey63:
Ah ok, a bit like One Plus.

Yeah nah, no such thing on Pixel devices.

It's Delta OTA or off to the PC/Laptop.
[Magisk] pndwal:
Yup, 1 is ideal...

I don't know what's available on Pixel, but w/ MIUI we can download latest full OTA package within Updater or select others as shown in post above... Though it might be the same...

Nb. In MIUI the extra options are hidden; users must tap MIUI logo in Updater 5 times to get access... 😜

True...

That's certainly true of delta (streamed incremental) OTAs since they need bit-perfect previous ROM images installed to generate the new images from the tiny quantity of differential data blocks... I wasn't sure if it's true when applying full OTAs or if the same checks are made, but you may be right that AVB will break installation in any case...

Meaning delta (partial, differential only) factory images as opposed to full OTA images here?... Of course both types are still factory images ...

But looks like this should simply work like delta OTAs in Xiaomi A/B devices by following the official doc linked above, and with the advantage of not unrooting the current active partition as you mention. 😛

I can't test this as I have only two A-only Xiaomi devices... 🙁 PW
[Magisk] Lughnasadh:
It's been a while since I sideloaded an OTA, but if I remember correctly once the sideloading is complete you'll still be in recovery mode and you have to choose "Reboot to system now" (or something like that) before it reboots. But like I said, it's been a while...
[Magisk] pndwal:
😁

Sorry, meant the inactive slot will be written to without issue of course! 🙃... My bad, corrected post... PW
[Magisk] badabing2003:
Right, I had forgotten as well,

I just tested this,

When you sideload OTA, you have the option to reboot to bootloader or system. (y)

And when you successfully reboot to system, the slot is switched.

I will test next to flash a patched image before rebooting and see if it will complain.
[Magisk] pndwal:
Streaming updates are supposed to make for a seamless easy update experience for the user... Update uses little data and images are created on the fly from active partition blocks + any updated block data from delta OTA, and all while user still has access to phone... Reboots should also be very quick it all went well, and if not phone simply boots again to original slot...

There are various uses for full OTA images but these are really outside the purpose of the A/B seamless update engines purpose... PW
[Magisk] tim1aust:
Thanks PW. So I guess the "full" OTA updates that are downloadable from the Google site (and sideloaded) are different from what is served up for the streaming, "seamless update engine". I didn't know that. Still learning...

Tim
[Magisk] badabing2003:
Update:

On a Pixel 5 device, I managed to have both slots bootable.

One slot rooted, and the other not, both on the same 2023-05 firmware.

The process is as follows (which PF will support OOB in the next release)

- Sideload full OTA

- Reboot to bootloader

- Flash patched image.

- reboot to system (observe root)

- Sideload full OTA

- Reboot to System (no patching, observe no root)

- Switch slot (observe root)

With Pixel 5, one is able to make changes to boot after sideload but before reboot.

It still needs to be tested if this works on Pixel 6, 7 * devices

I find flashing full OTA is slower than flashing full factory, but the benefit of having both slots bootable is a big bonus.
[Magisk] Lughnasadh:
Okay, did some testing on my Pixel 6 Pro:

Started with:

Platform Tools 33.0.3

A14 Beta 2.1 (installed using flash-all.bat)

Rooted with Canary Magisk 26102

Active slot=b

Sideloaded the A14 Beta 2.1 OTA

Booted up

Not rooted (of course)

Active slot=a

Then rooted with Canary Magisk 26102

Switched slots to b

Did not boot (as expected)

Booted back into bootloader

Set slot back to a

Sideloaded the A14 Beta 2.1 OTA

Booted up

Not rooted

Active slot=b

Then switched slots to a and booted successfully

Slot a still rooted

Then switched slots to b and booted successfully

Slot b still not rooted

Then switched slots again back to a and booted successfully

Slot a still rooted
[Magisk] badabing2003:
Thanks for the test, we can take advantage of this to carry to bootable slots,

I find it interesting that after flashing OTA, factory flashed slot was no longer bootable, that's a bit surprising considering that OTA could not have changed it.
[Magisk] Lughnasadh:
Looks like after years & years of using flash-all.bat to update I'll now be sideloading the OTA instead.
[Magisk] Lughnasadh:
Same test on my Pixel 7 Pro running A13 (May) with same results (this time I did not try to switch slots and boot into the slot that had the OS still installed via flash-all.bat (Step 2) 👍
[Magisk] Lughnasadh:
On a side note, crap, forgot to disable verity and verification before booting up after each sideload 🤦‍♂️
[Magisk] badabing2003:
Ouch, sorry to hear that, now you need a wipe?

So at what point you should have done that?

When flashing the patched image? just add the extra flags?
[Magisk] shoey63:
Did that affect anything?
[Magisk] Lughnasadh:
Yeah, if I want to run a custom kernel (Pixel 7) then I need to wipe. Should have sideloaded (not booted up), then gone into bootloader and run fastboot flash vbmeta --disable-verity --disable-verification vbmeta.img to that slot. Once booted after sideload/flashing the firmware it's too late as it's enabled after booting. Don't think it matters if you do it before or after flashing the patched image, just as long as you do it before you boot up. Oh well, lol...

Nothing to do with what we were testing, just custom kernel related. Seems to also help to avoid getting the red eio corrupt message when things may not go as expected.
[Magisk] Lughnasadh:
No. Only needed on the Pixel 7 series if you want to flash a custom kernel.
[Magisk] badabing2003:
Thanks, I realize it is only needed for custom Kernel cases.

I should add extracting vbmeta from payload.bin then in addition to boot.img / init_boot.img so that the step can be performed if the options are selected.
[Magisk] roirraW "edor" ehT:
Thanks for the test results and extremely fascinating information.

I wonder why, exactly, this works - presumably it's related to how the OTA treats the data that the factory image normally stores on the inactive slot. And it's also interesting that the full OTA and factory image would have different results.

Hopefully I notice the notes I've made on this the next time a Stable update comes out. :)
[Magisk] sawdoctor:
So as well as making it easier to keep root with an ota we can have the same firmware on the device one rooted and one not? So if magisk hide/safetynet/etc aren't working we can boot to the non rooted firmware to use wallet/banking apps etc and then boot back to rooted. Or is it a bit more complicated than that? Never had a pixel device before
[Magisk] badabing2003:
I'm afraid that won't help you for that usecase.

Unlocked bootloader alone will trip the detection.
[Magisk] sawdoctor:
At least you can relock bootloader and go back stock I guess. On Sammy once you trip Knox that's it something's will never ever work again. Still a pia though
[Magisk] pndwal:
Well there are some apps that detect root only and don't complain about Play Integrity verdicts or B/L unlocked...

In the case of Starling:

https://xdaforums.com/t/banking-app-starling-detecting-magisk.4576421/

dual boot to root/unrooted alternatively would be quite helpful since users apparently get a 2 week grace period after app detects root before app is disabled. Dual boot would allow them to log in fortnightly w/o root to continue using the app (even with root).

ATM there's no way (even with native bridge loading) to bypass Zygisk or Riru hooking/zygote injection detection, so many users are currently disabling Zygisk and using old p-trace MagiskHide implementations to hide root in order to log in once a fortnight.

👀 PW
[Magisk] pndwal:
There's no problem relocking on Samsung either...

You will lose special Samsung secure 'business platform' B2B (Business to Business) features (+ device enrollment for Knox solutions) incl. use of the Knox Security Container when Knox fuse (warranty bit) is blown.

Several Samsung apps and utilities use Knox Security so these will be also be broken including:

- Samsung pay*

- Samsung Pass

- Samsung Health

- Samsung Secure Folder

*Nb. There should be no issue for G Pay/Wallet.

I believe warrant may still be intact depending on local law, but in many lands the warranty will be voided.

Basically:

https://docs.samsungknox.com/admin/knox-platform-for-enterprise/faq/

Likely most users never use the Knox enterprise features and might not need S Pay, S Health etc but need to realise that those features will be lost by flashing custom mods (not simply by unlocking bootloader)... Otherwise they can simply re-lock if and continue using device as before if they wish.

👀 PW
[Magisk] Lughnasadh:
Others have already addressed your question, but for me, the biggest benefit here is to have a safety valve in place where your inactive slot is bootable (without first having to flash the firmware) in case you get into a hairy situation where your active slot becomes unbootable for whatever reason. May be useful in some situations.
[Magisk] shoey63:
Does anyone know if there is a way to switch slots on the device itself, as opposed to jumping on the PC to change via fastboot?
[Magisk] immortalwon:
If you have a custom recovery like TWRP, it allows change of slots.
[Magisk] notoriginal10:
Hey there,

apologies, if this has been addressed, but it didn't came up after a lengthy search. (At least not with a solution that worked).

Anyway, I want to run GrapheneOS on a Pixel 7a, rooted with Magisk and a unlocked bootloader for now.

I did flash GrapheneOS and booted it afterwards.

Then I took the boot.img included in the same factory image zip and patched it on device with the latest Magisk app.

I flashed the patched boot.img from fastboot (fastboot flash boot boot.img, I even tried with "--slot all"), but after rebooting the Magisk app shows "Installed N/A".

It simply looks like it doesn't get installed, but every step finishes successful without any error.

Did I miss anything? What else could I try?
[Magisk] roirraW "edor" ehT:
Probably not the answer you're looking for, and this is from an Asus thread, but this may apply to some other devices, such as my Pixel:

There is also another method mentioned in that post (details there):
[Magisk] roirraW "edor" ehT:
I don't know specifically about GrapheneOS, or the 7a for that matter, but on the Pixel 7 and 7 Pro, init_boot.img is what needs patched with Magisk to get root, not boot.img.
[Magisk] shoey63:
Thanks

I have Rog 3 (with latest TWRP) and P6 so I have a few options to try.
[Magisk] sawdoctor:
Unfortunately I use everyones of the apps you listed which is why i never rooted my zfold 3. The one think Knox gives you is adhell 3 and other similar apps. You can use the Knox firewall as a pretty effective adblocker and to disable system apps/remove permissions and receivers.
[Magisk] notoriginal10:
Ooohh, will try that, thanks.

I would therefore need to

fastboot flash init_boot <patched_init_boot.img>

correct?
[Magisk] roirraW "edor" ehT:
You're welcome! That is exactly correct.
[Magisk] DaOldMan:
I must say that I totaly hate that warranty bit. No idea why, when relocking the device and wiping the device completely that bit is not reverted to 0x0 to allow the full experience. It's one of the biggest things that I dislike about Samsung devices as I like to root my devices and make roms for them :) .
[Magisk] zgfg:
Does anybody know what (actually, why it) happened to magisk --path?

AFAIK, it used to point to /dev/<something> but now, with Canary 26102 it points to /debug_ramdisk

Indeed, I can execute the following (commands and responses) on Magisk Delta 25210:

Spoiler content hidden.

Ie, you see the path to /dev and that I can write to the subfolder

However, on Magisk 26102 it responds with a different path and eventually the subfolder is read-only:

Spoiler content hidden.

---

I'm asking because I cannot make AML module to work.

It installs but doesn't create and/or populate it's folders with audio conf and xml patched files from eg V4A:

/data/adb/aml

/data/adb/modules/aml/system

It's because its post-fs-data.sh and service.sh scripts at zillion places try to write to the (now) read-only path:

$(magisk --path)/.magisk/modules/aml/system

Even worse, post-fs-data sh strictly assumes it is on /dev/<something>, hence it looks for:

Spoiler content hidden.

and therefore it obtains a complete b...sht - path to the not-existing folder:

Spoiler content hidden.

where it cannot read nor write to

Today I tried to adapt the AML scripts and got my modded AML module creating the folders, picking up audio conf and xml files but it breaks me then the V4A

---

Actually, I wanted to install JamesDSP (alongside with V4A and AML) - JamesDSP is also broken on Magisk v26 (reported in the JDSP thread by several users)

Unfortunately, JamesDSP does not have scripts but the logic is in the Java JDSP manager app and I assume (both modules are from the same developer and btw he had disabled reporting of Issues to GitHub 😁) that it must be a similar problem with the now changed magisk --path on Magisk v26 (JDSP also works fine with Magisk Delta)

However, JamesDSP fails to work on Magisk v26 even if installed as the single/only audio module (hence, without the need for AML)

It creates /data/adb/modules/ainur_jamesdsp/system but doesn't populate with the patched audio files, and when you try to run JDSP manager app, it immediately crashes

---

If some power users could try please the quoted code on their Magisk v26, and maybe also on Alpha v26 (assuming, the wind of change was blowing again from that direction 😁)

And/or, please try AML and JamesDSP modules on your Canary and Alpha v26

Edit:

Script attached for easier testing. Run the script in Terminal, with root privileges
[Magisk] sawdoctor:
Not the answer but have you tried the rootless jamesdsp apk? You can use that with or without magisk and can switch between the 2
[Magisk] zgfg:
No I didn't

I have root and I'm not interested in rootless solutions😁

(And I'm interested to see how/why some things are constantly changed in Magisk in a way that one thing is fixed but the other changed and introducing troubles to the other modules - we are experiencing that since Canary v25207

Although, troubles are dragged here by the code in the AML scripts)