yashsingh1/xdaforums huggingface dataset:
[Magisk] Spookymyo:
I just got the notification for the latest update to magisk manager. So I installed it. I'm on the canary build because I have a pixel 4 Android 11. But when I did and tried to open it the magisk boot up screen popped up and disappeared over and over. I tried clearing cache and restarting. That didn't help. I redownloaded the canary apk and installed that. But now magisk isn't showing as installed. Non of the modules show up either. When I click install it only gives me select and patch a file. Also when I use a root verify app it tells me I'm still rooted. What happened?
[Magisk] Didgeridoohan:
Bug in the latest app release... Just uninstall the hidden app and the regular app you installed should take over.

If you really need the app to be hidden there's a workaround in the Github issue that was opened for this problem:

https://github.com/topjohnwu/Magisk/issues/3850#issuecomment-778726683
[Magisk] jenslody:
Same here with hidden app.

Uninstalling the hidden app and reinstall it works. But trying to hide it again, leads to the same behaviour.
[Magisk] DiamondJohn:
On each upgrade of android, Google have made it more and more difficult to customize my phone. But the choice is my own to stick with the old versions of android, or learn the new (mostly more complex) mods required or accept its no longer an option. I am sure google are doing the changes as they think/know its in my best interest (even if I liked the old way). Again, its my choice to accept or move along with them, knowing I have possibly more work.

I am on A11 and I have found a way that is acceptable for me to apply upgrades. As its a Pixel 4a, these have been or are monthly (i.e. often). On a related note, I will be on v21.4 until others have confirmed Viper works. That's my deal breaker. And its no big deal.
[Magisk] HippoMan:
I'm pretty sure that Google's choices are not driven by any considerations, whatsoever, concerning the ease of rooting devices and upgrading the OS's on these rooted devices, espcically with regard to getting these rooted devices to pass SafetyNet.

In any case, I understand and accept that it's my choice as to whether I install upgrades or stay with older and perhaps easier-to-utilize rooting and OS upgrading procedures.

I guess I'm soon going to have to bite the bullet and learn a more complex procedure for upgrading my OS, without that OTA feature.

My device is a OnePlus 7 Pro (GM-1917), currently running OOS 10.3.8, and I am using TWRP 3.5.0_9-0. Could anyone point me to instructions about how to upgrade my exact device to the next OOS 10.x.x version under the latest Magisk, but without that OTA feature?

And if I ever decide to go to Android 11 and use Magisk, are the instructions for doing so on my specific device outlined anywhere?

Thank you very much in advance.
[Magisk] zgfg:
Look at your device forum, and forums for other models from the same vendor
[Magisk] HippoMan:
My device doesn't have such a forum, and I am indeed searching for this info, which I have not yet found for my own device. I'm specifically talking about a procedure that utilizes post-21.4 versions of Magisk. I was just hoping that someone here might have gone though this for the device I mentioned and could point me to the steps that they took.

The fact that such info is not easy to find (at least not for my device) is yet another reason for my avoiding any Magisk upgrade beyond 21.4.
[Magisk] asanford:
OP7Pro doesn't have a forum...

https://xdaforums.com/t/roms-kernels-recoverys-firmwares-tools-guides-videos.3931126/
[Magisk] harddisk_wp:
I've tried the latest Canary, still does not work. What I've done and discovered so far:

The proper way to enter ODIN mode on a SM-T575 is not "adb reboot download" - this ODIN invocation won't print much debug information. Power the tablet off, then hold VolUp+VolDn, then plug in the USB cable.

The way to Recovery is hold the red Bixby button and VolUp, then press power to boot (and with unlocked bootloader, you may need to press Power again - but keep holding Red/VolUp!

The way to Safe Mode: press and hold VolDn.

KG State is "Prenormal" (probably "Knox Guard"), FRP LOCK is OFF, OEM LOCK is OFF (U), Secure Download is Enabled (whatever that means)

Replacing the vbmeta.img and vbmeta_samsung.img with an empty one (created with avbtool info_image --image empty.img) doesn't help, still the same error about "only official released binaries allowed to be flashed

A really nasty problem: removing super.img and userdata.img to reduce the file copy and flash times from the stock AP image and to prevent ODIN from wiping out all user data (and thus, also from the Magisk patched image) leads to a corrupt system. Here's what I did: a flash of the full stock AP image, followed by booting into Android, doing the first-time initialization, rebooting to ODIN mode, and then flashing stock AP image sans userdata.img / super.img yields a prompt_and_wipe_data reason=set_policy_failed:/data/misc error in last_history. So, then I wiped the data in recovery, completed the install assistant - suddenly, it crashes and goes to recovery again, this time with a postrecovery_failed / rason=dataresizing_failed / RecoverySystemdataresizing_failed in /cache/recovery/last_history.

Removing only userdata.img seems to work, but of course it takes *ages* to copy files between my Windows machine where Odin runs and my Mac

I'm at a complete loss on what to do now. Has someone maybe already documented why Samsung uses two separate vbmeta images and what's the difference? Or how one can enroll one's own signing keys into the bootloader?

Is there anything I can do to help?
[Magisk] HippoMan:
I also said this: "I'm specifically talking about a procedure that utilizes post-21.4 versions of Magisk." I have yet to find such info in the forums mentioned.
[Magisk] asanford:
I've been on magisk canary since upgrading to A11 and haven't changed any procedure from A10 other than TWRP not supporting A11 yet.
[Magisk] HippoMan:
But you aren't using the OTA A/B feature, correct? ... given that this feature is no longer supported in Magisk.

So, I guess I should just do the "long form" upgrade methodology (i.e., without that OTA A/B utility), correct?

PS: and I *do* want to use TWRP, which I guess is still possible as long as I stay on A10.
[Magisk] asanford:
I did when I installed OB2. Haven't had to try it since today's canary update. But the option to flash to inactive slot is still there for me. Is virtual A/B different from the A/B that's been around for years? Don't have a new update to flash otherwise I'd experiment
[Magisk] HippoMan:
I'm not sure about the answers to these questions.

In the past, I was always willing to play around and experiment with my device. But these days, I need my phone for work, and I don't have the luxury of being able to try things and then possibly have to take the time to unbrick and restore my device.

I'll get around to that eventually, but unless/until I can find definitive information about this, I think I'll just stick with 21.4 and use the OTA A/B utility.
[Magisk] 73sydney:
I got hit too...thats a real showstopper lol

I'm sure it'll get fixed soonish
[Magisk] MECH_TECH:
I have a S9 SM-G960F/FD on android 9 rooted and Magisk 20.4 installed and Manager 8.0.7 (4834) its asking to update to 21.4 (21400) Is it safe to let it update using the Manager?
[Magisk] J.Michael:
From posts here, you can use TWRP on A11 by "fastboot boot TWRP.img", you just can't replace your recovery with TWRP.

(They may have said you can install TWRP if you don't use Magisk.)
[Magisk] HippoMan:
I was imprecise. I just meant to write that I can't use TWRP as my recovery under A11.

Thank you.
[Magisk] ipdev:
Odd question.

Did I miss how adb is handled in Magisk?

The current canary (8476eb9f : 21409), I have adb root?

---

I did a clean install on a device testing something else.

I had to acknowledge and allow the computer to connect via adb just like it should.

When I started adb shell, I was root. No prompt from Magisk to grant root?

adb does not show under Superuser settings in Magisk.

adb shell is deftly root since it shows as root and I can navigate and list all restricted directories without issue.

[ip@lost 20210213]$ adb shell whoami
root
[ip@lost 20210213]$

Clean flash was on Nexus 7 (2013) flo[WiFi] and deb[LTE] using TWRP.

- Complete wipe and format in fastboot

- Complete format and wipe in TWRP (reboot to recovery in there also)

- Flash Lineage 18.1

- Flash OpenGApps

- Flash renamed Magisk canary

- Reboot to system

Cheers. :cowboy:

Edit:

Same with new current canary (b76c80e2 : 21410).

If this is intended behavior I am fine with it.

If it is not intended, then there is a problem and I will open a GitHub issue.

[ip@lost 20210214]$ adb shell whoami
root
[ip@lost 20210214]$
[Magisk] newkydawg:
Just updated to Magisk (21410) after having the "hiding Magisk" issue with (21409). Hiding magisk is working fine now on my Pixel 3 XL.
[Magisk] pndwal:
Latest Canary Changelog incl. Release Notes:

Magisk (b76c80e2) (21410)

[App] Fix crashes after hiding the Magisk app

[MagiskSU] Fix incorrect APEX paths that caused libsqlite.so fail to load

How to Use the APK for Recoveries

In general, it is recommended to install and uninstall Magisk through the Magisk app. However, if you insist to use custom recoveries, rename the Magisk APK's .apk file extension to .zip. TWRP should then be able to directly flash the zip file. If you have trouble renaming the file extension on PC, rename the file with TWRP's built-in file manager. To uninstall in recovery, rename the zip file to uninstall.zip before flashing it.

Diff from v21.4

[General] Magisk and Magisk Manager is now merged!

[App] Rename the app "Magisk Manager" to "Magisk"

[App] Support hiding the Magisk app with advanced technique (stub APK loading) on Android 5.0+ (it used to be 9.0+)

[App] Disallow re-packaging the Magisk app on devices lower than Android 5.0

[MagiskHide] Fix a bug when stopping MagiskHide does not take effect

[MagiskBoot] Fix bug when unpacking lz4_lg compressed boot images

[MagiskInit] Support Galaxy S21 series

[MagiskSU] Fix incorrect APEX paths that caused libsqlite.so fail to load

👍 PW
[Magisk] DiamondJohn:
My statement stands, as Google would see rooting as NOT being in my best interest. And in Googles eyes, somehow faking / working around safetynet or having a weakness to allow workaround it, would definitely be considered contradictory to my best interest. Remember, they are producing for the mass public, not for the small percentage of knowledgeable people.
[Magisk] pndwal:
A little insight into the 'crashes after hiding the Magisk app' fix:

Re. 'Support Galaxy S21 series' fix:

👍 PW
[Magisk] HippoMan:
I don't disagree with your statement that this is what Google sees as being in the best interest of the mass public, even though it isn't in the best interest of people like me who want to root. I'm not accusing Google of having bad intentions; it's just that they are not working to promote functionality that happens to be desired by me and by others who want rooted devices.

And therefore, as time goes on, my life gets more complicated as I try to live in the Google world with a rooted device. And my desire to avoid this complication as much as possible is why I am holding back on upgrading to A11 and to the post-21.4 Magisk.
[Magisk] pndwal:
I found John's new issue template here (in commits), after trying to find a link on GitHub:

https://github.com/topjohnwu/Magisk...39042fd576a820c2c2c6d05ad18973bb9c7dce77267c5

https://github.com/topjohnwu/Magisk...0aa3ae03/.github/ISSUE_TEMPLATE/bug_report.md

https://raw.githubusercontent.com/t...0aa3ae03/.github/ISSUE_TEMPLATE/bug_report.md

It seems to update the 'Bug Reports' section on Magisk main page, but this still lacks the new detail.

Please let me know what I'm missing... Is there a link, am I just stupid, or has the commit not been properly applied? Thanks, PW

Edit:

I finally found a proper instance after clicking 'Get Started' in 'Issues', but I'd missed it previously as it DOESN'T show when a user clicks 'open a blank issue' instead.

This likely accounts for many other users 'ignoring' the template also. 😬

It would be good if the main Magisk page was updated at least (or a link provided there), so users can be made aware of prerequisites before creating issues.

I've created a new issue to this effect.
[Magisk] dobi3:
Latest Magisk-b76c80e2(21410) working fine when you hide manager on OnePlus devices (1, 2, 3/3T, 5, 6, 7 Pro 👍👍👍

Thanks for quick fix @topjohnwu
[Magisk] pndwal:
Yep, quick fix! Who'da thought?

Hiding Manager fine on RN8T also. 👍 PW
[Magisk] Doman2011:
Hi,

I can confirm; successfully rooted S21+ 5G (SM-G996B / Exynos / G996BXXU1AUAB) with Magisk (Canary, 21410). No additional steps were required (AP image patch, flash, additional setup with reboot) - all is ok.

BR, Doman.
[Magisk] asanford:
Reporting back. Having an issue on A11 where I can't sign into chrome sync, so I tried reflashing OB2. Didn't solve that issue for me, but I can confirm flashing to inactive slot still worked for me on 21410.
[Magisk] pndwal:
Closed... Well I tried... PW
[Magisk] prot-:
Google Pixel 3XL still gets intermittent freezing evey few days even without systemless hosts (which we initially thought was the issue). Even with no modules enabled at all but only when magisk is installed.

I've tried everything and waited a few weeks of various testing . Anyone else have this?

Most time it's noticed after unplugging from charge and waking screen but sometimes random in middle of day. Have to hard reboot. I can't pick wtf is going on . I'm at a point where I need to remove root but gpay doesn't work unless bootloader is Locked.
[Magisk] Didgeridoohan:
It's a F2FS driver bug. You need a custom kernel that has it fixed.
[Magisk] prot-:
Can you recommend a kernel?
[Magisk] Wolfcity:
I'm not a Pixel user but I would say that ElementalX kernel is a good choice:

https://xdaforums.com/t/kernel-september-8-pixel-3-xl-elementalx-3-06-android-11.3868373/

Check the thread if the f2fs bug is fixed for your device, it is for the most and the kernel is known to be stable.
[Magisk] Lughnasadh:
This is the developer who discovered the f2fs bug. He's reverted the commit that was causing this in his kernels.

https://xdaforums.com/t/kernel-05-0...-aka-bluecross.3864563/page-147#post-84230135
[Magisk] jcmm11:
Magisk|Settings|Superuser Access

(It's towards the bottom)

Default is (and AFAIK always has been) Apps and ADB
[Magisk] jcmm11:
Kirisakura is a great kernel. Highly recommended.
[Magisk] J.Michael:
Maybe you should try filling out the new template to report the need for an easier link to the new template.
[Magisk] pndwal:
Haha, quite.

This was 'closed without explanation', but I don't know what rule I broke.

Anyway, here's the template/rules for the asking:

https://github.com/topjohnwu/Magisk...0aa3ae03/.github/ISSUE_TEMPLATE/bug_report.md

I'd say John's just a tad overtaxed trying to keep up with all the bugs/issues. 😁 PW
[Magisk] J.Michael:
I hadn't looked at the template, I just assumed I knew what a template was. Having looked at it, I'm not sure what you have to do to be using the new template, but I'm pretty sure you didn't use it. And I thought you reported that @topjohnwu said he would burn before reading any issue that did not use the template.
[Magisk] pndwal:
Yeah, I think 'Template' means different things to different people, but John probably just has in mind the rules and logs that will assist him debugging and not waste his time.

To be clear, this 'Template' applies specifically to bug reports, and the 'issue' I raised can hardly be considered a bug. However, I thought it was a still a significant issue as users can lodge new 'issues' and never see the 'template' by clicking 'open a blank issue' instead of 'get started' as I had... So I guess I didn't use the 'template'. 😛

Significantly, after John complained about users 'ignoring' the 'template' on his Twitter, one user pointed out the same root (excuse the unintended pun) cause I did, and suggested GitHub structure is the problem:

... and users are still posting bug reports without the requisite logs as well as 'ignoring' the 'DO NOT' list! 🙄

My suggestion was a 'workaround' of sorts and I think John's put it in the 'wasting my time' basket after a cursory glance, but it might have helped... this young man simply has bigger fish to fry! 😐

... I hope posting the 'template' for new issues here helps.

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84501005 PW
[Magisk] GalaxyBaker:
Hello I have an issue.

Using S8 HorizonRom.

I flashed a smalipatcher module from previous rom installation and didn't even think about it. I dirty flashed rom and system runs fine.

When I flash magisk in TWRP it causes bootloop until I dirty flash again, seems infant get root without uninstalling this module.

Can't access magisk in /data because no root.
[Magisk] pndwal:
You can uninstall module from recovery:

https://www.didgeridoohan.com/magisk/MagiskModuleIssues#

Scroll down to 'Uninstall/delete/disable modules from recovery'.

Also, booting your device into Android Safe Mode will disable all modules and also disable MagiskHide and allow you to boot normally again. See 'Safe Mode'. 👍 PW
[Magisk] nowster:
For those with Pixel 3a and 3a XL, I can recommend the MVK kernel https://xdaforums.com/t/kernel-android-11-v11-2-mvk-maximum-velocity-kernel.3995613/ The latest release has the f2fs patch in it.

From having to hard reboot twice a day, my Pixel 3a is currently at 70 hours uptime. That reboot was to install the latest Magisk canary. (And unlike ElementalX, you can build the current kernel yourself if you can work out what build tools you need and how to combine them.)
[Magisk] pndwal:
Breaking:

🍦 Magisk root on Android Snow Cone (A12) ...Already! 💪

Seems @MishaalRahman, Editor-in-chief of XDA was the first to report this; well done Mishaal!

Can't lick that! 😛 (Seems transition to Android SC for Magisk users may be less fraught that it was for RVC.)

... But here's a bit more goss on A12 from John:

Also, from Mishaal:

Android 12’s dessert name is confirmed to be Snow Cone

The dessert name for Android 12 is confirmed to be Snow Cone. However, Google doesn't use dessert names anymore so this is just a fun tidbit.

www.xda-developers.com

Google is working on a “One-Handed Mode” for Android 12

Android 12 may introduce a one-handed mode feature, letting you use your tall phone with one hand just like Apple's Reachability for iPhones.

www.xda-developers.com

More OT:

Extensive feature review from Aamir Siddiqui:

Android 12: Everything you need to know about Google's new big update to the popular OS!

Android 12 will be the latest version of Google's new Android OS when it releases later this year, but here's what we already know about it!

www.xda-developers.com

Android 12 for Pixel users (who want to try it w/ root 😉 ) from Skanda Hazarika:

How to install Android 12 and 12L on Google Pixel and other Android devices

Google has just released Android 12L beta for the Pixel lineup. Here is how you can install Android 12 (or 12L) on your smartphone!

www.xda-developers.com

PW
[Magisk] cognitivedissonance:
Is it recommended to Magisk Hide Google Play Services? If so, are there only specific components that should be hidden, or should all be hidden? The components I'm seeing are:

com.google.android.gms

com.google.android.gms.feedback

com.google.android.gms.learning

com.google.android.gms.persistent

com.google.android.gms.room

com.google.android.gms.ui

com.google.android.gms.unstable

com.google.android.gms:car

com.google.android.gms:snet

Additionally, for banking, payment and password storage apps, how do we know which components to hide?

Example: Venmo has 3 options:

com.venmo

com.venmo:MiSnap

com.venmo:playcore_missing_splits_activity

Example 2: Microsoft Authenticator has 2 options:

com.azure.authenticator

com.azure.authenticator:auth

Example 3: Chase has 2 options:

com.chase.sig.android

com.chase.sig.android:remote

Example 4: Citimobile has 2:

com.citi.citimobile

com.citi.citimobile:MiSnap

You get the picture. Any guidance on this would be much appreciated!
[Magisk] morpheus620:
Android 12 Pixel 5 magisk not working. after flash the patched boot.img reboot to bootloader.
[Magisk] snickle:
Lenovo TB-x606f. I have tried flashing the patched_boot.img from magisk 8.0.7 without luck. It just boot loops. Any suggestions? Other people seem to managed.

Android 10
[Magisk] pndwal:
Mishaal Rahman reported Magisk works on the Pixel 3 XL running A12 DP1.

I guess there may be issues to iron out with other (later) Pixel models, but your best chance of compatibility will be using latest Canary build (not beta/stable) due to recent fixes included. You haven't indicated what build you tried.

@MishaalRahman, did you use Canary Magisk build? Thanks, PW
[Magisk] pndwal:
Assuming you have Magisk 21400 (public stable/beta), and I see yours is a fairly recent device.

What Ramdisk status is displayed in Magisk Homescreen?

Also, how are you flashing patched image exactly?

Nb. also recent fixes in Canary 21410 (not merged to public builds yet):

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84493077 PW
[Magisk] pndwal:
I've had root hidden from all Google Play Services components in the past, and noticed no I'll effects. However, as this may cause unforseen problems, I'm back using MagiskHide's default setting (which is selected automatically when toggling MagiskHide in settings) of hiding only com.google.android.gms.unstable service. This is also working fine for me, allowing SafetyNet pass and giving Play Protect certification.

For security centric apps (banking etc), I've hidden root from all components and not experienced problems, but I may be lazy; it's likely only one component actually detects root, and you could experiment to find (enable all services, get app working, then disable one at a time to identify) which that is. I also have G Pay working fine with root hidden from its two services fwiw.

See officially endorsed tips on hiding root from apps, including why you shouldn't simply hide everything, here:

Hiding root from apps:Magisk and MagiskHide Installation and Troubleshooting guide

www.didgeridoohan.com

Skip down to The Hide list, and see also System Instabilities. PW
[Magisk] snickle:
Using Canary fixed the issue.
[Magisk] martyfender:
by default Magisk hides: com.google.android.gms.unstable and no other in Google Play Services.
[Magisk] pndwal:
Strictly, Magisk doesn't hide root by default since 20400 (20.4), but com.google.android.gms.unstable appears in MagiskHide list if MagiskHide is toggled on (in settings). 😉 PW
[Magisk] pndwal:
Re. Problem mounting System (from Recovery):

Finally a properly reported bug / issue!

Bug in util_functions.sh mount_apex function · Issue #3871 · topjohnwu/Magisk

Magisk 21410 (and previous versions of the new format) Recovery log attached. recovery.zip Line 333 of util_functions.sh (in function mount_apex) currently reads: DEST=/apex/$(strings apex_manifest...

github.com

with solution included. 👌

I'm sure this issue (since 21407) will get fixed ASAP (or I'll eat my hat). Well done @BillGoss! PW
[Magisk] pndwal:
... John Wu's giving it a go on Pixel 4 XL now anyhow.

PW