yashsingh1/xdaforums huggingface dataset:
[Magisk] J.Michael:
Wouldn't boot_patch.sh produce a boot image corresponding to the version of Magisk already installed?

I thought that the original problem was: Magisk and manager app v23 installed and working; Magisk Manager app v25 won't run. Maybe problem will be resolved by replacing Magisk with v25, but how to patch boot image to v25 without being able to run manager app v25?

I thought @rodken's suggestion to reflash stock, then install manager app v25 was likely to work. I didn't see how just uninstalling the manager app could advance the situation. I still do not.
[Magisk] zgfg:
Yeah, manual procedure will reflash the currently installed Magisk and that's v24.3 in his case

But apparently the user has a problem with Magisk APP v25.1 (Stable, supposed) not launching

It should have nothing to do with patching Magisk. Pndwal yesterday responded, see also a post right before yours (already three users reporting the same here - seems they have to try installing Canary v25101 APP instead, and then proceed with updating Magisk)
[Magisk] huskydg:
Feature request: Extend CLI to show Zygisk status · Issue #6064 · topjohnwu/Magisk

CLI supports a lot, eg (partially) managing modules and DenyList but seems that even Zygisk status Yes or No cannot be checked through CLI Even better, it would be good to additionally have the opt...

github.com
[Magisk] zgfg:
Thanks for your hint to use --sqlite:

Set Zygisk On:

magisk --sqlite "REPLACE INTO settings (key,value) VALUES('zygisk',1);"

Set Zygisk Off:

magisk --sqlite "REPLACE INTO settings (key,value) VALUES('zygisk',0);"

Check Zygisk status:

magisk --sqlite "SELECT value FROM settings WHERE key = 'zygisk';"

Btw, Magisk.db can be also easily managed from MiXPlorer (incl. Denylist and Root grants)
[Magisk] rodken:
There were instances where I suffered the same fate [twice] and simply reflashing a previously patched image would solve the dreaded 'stuck on splash screen' conundrum.
[Magisk] DiamondJohn:
You forgot Plan Z. Make backups before doing anything that may trash your setup, and have a restore plan.

Id be careful with using MiX. Although I use MiX, editing dB's can have issues. It was a while back, but what I think I saw happen, is that MiX makes a copy of the database, makes the change to its own copy, and then copies back over the original. That can fail if there is another app using the dB or has the same plans.

Another option is to use SQLite directly from the command line, or use the app I built TeMeFI, which also edits the dB in-situ; its literally has a GUI to SQLite command line. MiX is closed source so its hard to know, but it failed to update a major db in android (I think the MediaDB), where the other options worked.

But the 1st option is without question the best option. ie have Magisk mess with its own database. Database concurrency is a hard taskmaster.
[Magisk] ipdev:
Looks like vvb2060 is against adding zygisk to the CLI. 🙁

Would be nice if we could check zygisk status just like we can the denylist.

Check the Zygisk status when you are installing a Zygisk module.​

magisk --denylist status 2> /dev/null
if [ $? -ne 0 ]; then
ui_print " "
ui_print " The Denylist is not enforced."
fi

'Denylist is not enforced' returns as error (1).​

'Denylist is enforced' returns as success (0).​

This would be nice. 🙂

magisk --zygisk status 2> /dev/null
if [ $? -ne 0 ]; then
ui_print " "
ui_print " Magisk Zygisk is not enabled."
fi

Assuming zygisk status returns the same as denylist status.​

'Zygisk is not enabled' returns as error (1).​

'Zygisk is enabled' returns as success (0).​

Guess we can work with the sql method. 🙃

if [[ $(magisk --sqlite "SELECT value FROM settings WHERE key = 'zygisk'" | cut -d '=' -f2) -ne 1 ]]; then
ui_print " "
ui_print " Magisk Zygisk is not enabled."
fi

Thank you for nudging me in the direction of the command to check Zygisk. (y)

Cheers. :cowboy:
[Magisk] dl200010:
I just did the update. I disabled the only module I have, which is the "Systemless Hosts" from Magisk itself. I downloaded the OTA incremental from Oxygen Updater. Restored Images in Magisk (25.1). Installed the update with the System Update APK that OnePlus had out for the A12 betas (because you cannot do local updates anymore in settings). I than went into Magisk and installed to inactive and rebooted from Magisk. It came up just fine. I think there must have been an error in 24.3 or I have to disable even "Systemless Hosts" module. I am now fully up to date. Thanks @pndwal
[Magisk] Fif_:
That is more than annoying. That means you have to boot once into Android with Magisk off after an OTA . If you have debloated apps, you can end up with the debloated apps reappearing when Magisk is not installed, getting updated, then having the system package pulled under the updated debloated apps. I've had instances where if I then remove the updated app, the system will refuse to boot again because expected libraries are missing. I was able to recover by editing /data/system/packages.xml, which I do not recommend for the faint of heart or noobs.

Anyways, you should do that magisk-less reboot in Airplane mode anyways, that prevents the problem from occurring in the first place, and saves you from losing certified status.
[Magisk] dl200010:
Well, I am now up to date. It might have been a bug in Magisk that was fixed in 25.1, or because I never disabled the one module I have in Magisk. I was able to use "Install to inactive" in Magisk after the incremental OTA just fine. I don't do anything special with bloat, just disable it in settings, and Neo Backup can disable those that settings tries to prevent you from doing. Even if I flash stock boot the bloat stays disabled.
[Magisk] pndwal:
Apparently Magisk 'repository owner' doesn't want GitHub members to offer any help / clarity after issues are closed without proper resolutions...

https://github.com/topjohnwu/Magisk/issues/6072

This already closed issue was effectively killed within minutes of my comments. ☹️ PW
[Magisk] dl200010:
Unfortunately, many many devs are like that, not just these. Don't know why, but they are.... This seems to be completely vvb2060 doing it because they didn't like being wrong.
[Magisk] pndwal:
Not saying she's wrong... It's a fair response to a misleading issue description...

But I would like to see Devs (especially more than one LSP Dev) being more respectful of others' time / efforts, and also of users who battle w/ magiskbot & submit the same issue 5 times before getting it right and it's accepted... Bit frustrating for all involved, and has alienated a few...

And we do have some good l o n g s u f f e r i n g role models... Perhaps @osm0sis could make a pull request for a an internationally acceptable magisk-manners code for dev / modding community relations... 😜 🙃 PW
[Magisk] 73sydney:
Sadly not the 1st time the dev has gotten "spicy"

Really responses like "ignore it" to an issue are beyond less than helpful

And yes @osm0sis is a good egg, went to bat for me to get my feature request for magisk manager to stay on Install tab after local module install, upsold that one twice if my memory serves....
[Magisk] dl200010:
My opinion is "ignore it" should be banned as a response, especially from a dev.
[Magisk] J.Michael:
I interpreted "ignore it" as advice to the original poster to ignore the error messages. I couldn't follow the process well enough to tell if/where files were being copied, but I think the error message occurs when a copy is done with the "preserve permissions, time, owner" flag, and the destination filesystem does not support one or more of those attributes.

I was more annoyed when the "response" to @pndwal's request for clarification was just a repeat of a section of the log.
[Magisk] dl200010:
The response should have been more of "this message can be safely ignored" instead. I also take issue with how they closed down the issue and locked it, because @pndwal was trying to help. Also take issue with how they hid his last comment.
[Magisk] BlueMan_86:
Is it possible that Magisk v25 bricked my device? I updated to latest miui rom Mi10T Pro, before that I used v24.. BUT, when I intalled v25, phone caused to bootloop, that is not strange at all, most weird thing is when I back my original boot.img, phone stuck in bootloop and that was it... My phone have "vbmeta" so I selected that option on install... What is going on there... How is posible that original boot.img want work and phone bricked...

Any ideas whats happened and what was causing that? Also I deleted magisk modules folder over TWRP, but nothing.. just dead bootloop... Thanks..
[Magisk] zgfg:
Boot with that original boot.img but having Magisk v25 APPLICATION installed.

From Magisk app, chose Install (Magisk) - main window, on top, right; Select and Patch, navigate to the original boot img file, do not tick Recovery option; Let's go

When done, youl'll have the patched boot img (in Download folder)- from Fastboot or TWRP, flash to Boot (and do not play with vbmeta)

Reboot to Magisk

That's the way Magisk installation works on all Xiaomi devices, MIUI 10/11/12... (btw, I have two of them, and do it as above since 2019)

Try first that way. If it won't work,then bootloop could be due to the incompatible Magisk module that was not disabled (but that usually happens when you upgrade ROM, not Magisk like you). That can be also fixed, but try first as above
[Magisk] pndwal:
I'm assuming you mean you did this:

(Optional) If your device has a separate vbmeta partition, you can patch the vbmeta partition with command:

fastboot flash vbmeta --disable-verity --disable-verification vbmeta.img

So likely your device needs AVB (Android verified boot) intact and you have disabled it by patching vbmeta to disable-verity & disable-verification...

Instructions don't say to do this; they simply say it's an option & you can...

I believe this method has been added for the relatively few devices, eg (perhaps only) those running custom kernels, that require disable-verity & disable-verification... My guess is that most modern stock ROMs will normally require working AVB...

Since you've patched vbmeta in addition to boot image, you'll need to restore this image from ROM package also... or can dirty flash complete ROM... PW
[Magisk] pndwal:
Did a bit or playing with modern Magisk, and it seems we can no longer 'downgrade' the App to a version earlier than running Magisk daemon in 25100+...

Force app version not lower than daemon

vvb2060 authored and topjohnwu committed 22 days ago

So with Magisk 25101 loaded, there is no way I can downgrade the App to Stable 25100 (despite the binary being in sync), or run any earlier app (Including old Manager app) on my device. ☹️

Whether calling apk package from App by setting Channel to Stable (App not hidden), or by downloading this or earlier Apps (previous App uninstalled), all the packages will simply install the stub app which in turn prompts:

and this always fails with never ending:

until it is force-closed.

(I guess Build dynamic stub resource APK at runtime … topjohnwu and vvb2060 committed 17 days ago

or Fix app state, vvb2060 authored and topjohnwu committed 7 days ago

may fix some broken behaviour.)

At present, the only Magisk App I can seem to install successfully (w/ 25101 binaries loaded) is 25101!* ... This installs the full App (not stub) as expected.

... It seems we must at least remove root injection and do an initial re-flash again just to install synced Beta/Stable App, and that any other 'downgrade' is also precluded...

*Further, I've found I can no longer even install a CI App, even one later than my Canary build (these actually use the same last app version, ie. also 25101), from Actions (Continuous Integration test build) runs with 25101 Magisk binary installed! ☹️ ... Same behaviour as above... I'm guessing this is due to app signature checks.

If anyone wants to try, or is able to downgrade the Magisk App from current Canary or Debug to Stable, or to upgrade this to a CI build w/o restoring unpatched images (removing root), please report... I'll reward you with some happy faces... 😁 PW
[Magisk] pndwal:
@osm0sis has changed "ignore it" to "ignore the errors"...

https://github.com/topjohnwu/Magisk/issues/6072#issuecomment-1178394392

Users being met ½ way? ... 😁 PW
[Magisk] samhhmobil:
Hi,

does somebody knows, how the german health insurance app "TK" does detect root?

My configuration:

LOS 19.1

Magisk 24.3 (app hidden),

Zygisk, Shamiko 0.5.1(115),

MagiskHidePropConfig is set,

Safetynet is passed! CTS is passed.

No TWRP folder.

What am I missing?

samhhmobil
[Magisk] pndwal:
TK-App 4.9.0

Xiaomi Redmi Note 8T, stock MIUI, Android 10.

Magisk 25101, Zygisk, USNF, Shamiko.

Magisk App hidden

TK in denylist:

CTS profile match (SafetyNet) pass.

Play Protect Device is certified

Your TK in denylist?

Cleared app data since?

🙂 PW
[Magisk] samhhmobil:
On that Level it works, yes. But after Login and after entering personal security code, during the latest stage of login, it detects root.

samhhmobil
[Magisk] pndwal:
Oh.. can't test then... Momo detector result may give you some clues...

Assume TK is in denylist... PW
[Magisk] osm0sis:
You should still be able to install CI builds using Canary Debug, per https://github.com/topjohnwu/Magisk#signing-and-distribution

If that's not the case anymore then that's clearly a regression from the intended behavior as described by topjohnwu.
[Magisk] samhhmobil:
Yes, I know, you can't test it. You need at first successful login with insurance-ID, password, security code (sent via snail-mail), and password again, and after this successful login it detects root and stops working.

Momo 4.3.1 shows:

Device is running a custom ROM.

Found Zygisk.

Bootloader unlocked.

Nothing else...

Google Play shows: Device is certified.

YASNAC passes both,

Basic integrity and CTS profile match.

SafetyNet-Test passed.

But...

"S-Check" (Security Check, by HCE Compliance Experts, PlayStore) detects root... (see screenshot)

Any idea more?

Maybe, it detects TitaniumBackup and/or AFwall+ and/or AdAway?

Thanks a lot,

samhhmobil
[Magisk] martyfender:
You can try zygisk-lsposed with hide my applist and enhance mode for hidemyapplist and the app added to select effective apps. However, if the app is detecting zygisk, this may not work.

Another option is to use the @huskydg build with zygisk turned off and magiskhide turned on. you may also need riru and other riru modules such as riru momohider and others.

This is a quote from @huskydg github documentation:
[Magisk] dohanin:
My setup is similar to yours (big difference is that I'm using Stock rom) and I passed S-Check.

Stock A12

Magisk 24.3 (app hidden and disabled),

Zygisk, Shamiko 0.5.0(110), USNF
[Magisk] pndwal:
Many thanks!... I missed the May 24 update to main page (readme.md)...

https://github.com/topjohnwu/Magisk/commit/edb76503d36f05a757fa4e652a2dfbbb471695ad?diff=split

This confirms app signing is the issue here...

No regression... can confirm installing Debug build (Magisk binaries flashed) allows CI signed builds to install... Clearly this property bypasses this:

Enforce package signature verification

topjohnwu committed on 20 May

In fact, it fixes this issue too:

While this remains true, installing Debug build (Magisk binaries flashed) allows downgrading to any earlier App build...

Clearly Debug binary bypasses both app signing and daemon version checks. 🙂 (Does this mean that certain commits are skipped in builds w/ debug flag, or are they just bypassed somehow?)

Of course, changing app through the Magisk App, or with it installed, will fail in both these cases... System app version and signature checks will still prevent downgrading and updating to builds signed with different keys. This means users must uninstall the Magisk App and manually install downgrade, CI or unofficial distribution builds.

other applicable commits:

- Skip cert check on debug builds

topjohnwu committed on 24 May

-Enforce dyn APK signature in stub app

topjohnwu committed on 24 May

-Set version comment in apk

vvb2060 authored and topjohnwu committed on 18 Jun

-Force app version not lower than daemon

vvb2060 authored and topjohnwu committed on 18 Jun

... Your due sir; really appreciate it!:

☺️

🌞😁

😂😃😄

😊🥳😹😺🙋

🙂🙃😛🤠😜😝

😷😀🤪😀😃😄😁😆

😅😂🤣😉😍🤩🥰😋😊😇

🌝😻🙉💇👩‍✈️👸👶👱👴🏻👩‍🦰🧑🐸

... For a good 🥚, 😜

----------------------------------------------​

Unrelated: I do see that this anomaly remains:

Hiding the Magisk app (and restoring it) often fails with a message saying 'root is lost; you need to reinstall Magisk', 'request superuser permission for Magisk app' etc...

Actually the issue is that the previous App is not successfully uninstalled, and two conflicting apps are left installed...

The workaround is to ignore the various messages completely... Close everything, and if you were taking Hide the Magisk app, simply uninstall the full app manually; if you were taking Restore the Magisk app, simply uninstall the obfuscated (stub) app manually...

🤠 🐣 PW
[Magisk] IronStorm84:
hi all,

i have a problem to reinstall magisk.

iam runnning a galaxy s9 with soldiers rom with android 9 (y i know very old but working)

twrp is installed. magisk was installed. for one app i uninstalled magisk once. now i have the problem when iam install the 25er version that i have no options like su or modules because app says magisk is not installed.

i dont want to wipe everthing. install magisk v25 with twrp was succesfull (via renamed zip) but the app told me that magisk is not installed.

how to reinstall the app to hide some apps from magisk without losing data or wipe it?
[Magisk] nu11ptr:
Um, Didn't quite follow you.

So the app said "magisk is not installed". It probably means, the app tried to execute "su" binary but cannot find it. Check if the "su" binary exists.

Sorry for my English.
[Magisk] zgfg:
As said, try with su from Terminal. And/or even better, check what version of Magisk you have with the command:

magisk -c

Most likely, Magisk is there but your new Magisk app does not find it.

If you did Hide Magisk app/mngr with your old Magisk app/mngr, you had to unhide THAT OLD Magisk app before upgrading

That's the common mistake many do, resultimg with the problem like yours

Check as above, we'll see then
[Magisk] 73sydney:
Worth pointing out the actual app name is Security Check - Device compliance for payments

Security Check - Device compli - Apps on Google Play

Check your device readiness and compliance for Mobile Payments

play.google.com

I mention this only because when i searched for S-Check, all i got was an Australian Hospitals app for meth users to track their meth addiction :)

fwiw, i dont have a meth problem, and * my device doesnt pass root detection

*quite possibly due to the fact im spoofing just the manufacturer prop of my S20+ 5G as Google to get Samsung Health working

life is like a box of ponkles
[Magisk] zgfg:
Stock MIUI, I put S-Check to DenyList (using Shamiko).and enabled hiding in HMA but still root detection error 107/204/606
[Magisk] 73sydney:
If i enable it in DenyList with DenyList Unmount (all i use currently, gave up HMA for UpdateLocker (Lsposed)) it wont even open :)
[Magisk] zgfg:
I use Shamiko
[Magisk] huskydg:
after your "mental masturbation" to crappy comparison apps (momo, magisk detector, ...), you'll want to say "well anyway I just expect my banking app to work fine"
[Magisk] huskydg:
An old Chinese story called The Man who Sold Spears (momo) and Shields (shamiko).

In the state of Chu lived a man who sold shields and spears.

"My shields are strong," he boasted, "that nothing can pierce them. My spears are so sharp that there is nothing they cannot pierce."

"What if one of your spears strikes one of your shields?" someone asked him.

The man had no answer to that.🤣
[Magisk] pndwal:
Did same yesterday... (Nearly signed up on meth program too.😜 ... By accident I mean...)

If you touch failed result you get error codes... No ideas of meaning, but may be worth comparing...

Modding is just a fun diversion / 'sport' for some... Some take it too seriously...

For the players, at least Momo is current; Magisk detector is deprecated... PW
[Magisk] zgfg:
Error codes do have meaning

First, I forgot to Save in HMA, hence effectively I didn't have it enabled in HMA and error was 107/204/245

Then I configured again in HMA and saved (and edited my post), with HMA error is now 107/204/606

I tested and have the same errors on Mi 9T (Xiaomi.eu but also A11), also Canary 25101, Shamiko - however, on Mi 9T I don't need/run USNF

Btw, I disabled now S-Check in DenyList and error code changed - it's now 107/204/251
[Magisk] pndwal:
There was an old man from Chu

who said "I sell shields that are true

And I test them with spears

that I sharpen with tears!

- such is my devotion to you."​

Still, a bat and ball (sport) analogy may be more apt since it's just a game to me.

... And some balls will always hit the wicket.

Those intent on winning a (serious) battle are already doomed.

Some spears will always make their mark...

👍 PW
[Magisk] HippoMan:
My preferred analogy is "cat and mouse game", and it applies to this entire root-hiding effort, not just the Momo/Shamiko issue.
[Magisk] pndwal:
Big G was the cat of the house

and John the omnipotent mouse...

Now the cats are the banks;

other devs have John's flanks,

but the game's still a test of your nouse!​

😉 PW
[Magisk] Stillhard:
Should i put my test result?

Nah, you all know i'll passed everything 'cause i'm with Ponkles
[Magisk] Detonatte:
Can u help me? I can't update Magisk 25.1, my phone Samsung Galaxy Note 9 enter in bootllop.

I have Dr.Ketan ROM Q19 (Android 10) with Magisk 24.3. Tested all variants, nothing work, why?

P.S: Activated Magisk Hide for Bank Apps. Restore the Magisk app first update Magisk? Try, nothing!
[Magisk] edyny1:
Snorlax is working for me after xposed is disabled and some other modules works too then they will stop working if you reboot the phone, if you do then you have to uninstall then reinstall xpoxed 86.2 then they will work again, well for me it is.
[Magisk] justmiike:
Thanks, I was following your posts because you had somewhat of a similar setup to me.

But alas, I could get 86.1 installed, no cigar, so now I have just settled on 86.6, and when I need Xposed, I'll just reboot.

Until a fix is found.
[Magisk] mew1033:
So... I'm a genius. I completely forgot that I need to install a superuser app. Didn't do that. No wonder Magisk kept complaining about not having root access.... :)
[Magisk] CryMasK:
As [MENTION=4334293]mrxtc89117[/MENTION] said,

v86.6 is for Magisk, and v86.2 only works for SuperSu.

So, first time you flash v86.6, and that detect your Magisk module, auto-install in systemless mode(But RootSwitch DON'T support systemless Xposed, the toggle is gray and disable).

After that, you flash v86.2, but you didn't install SuperSu, it couldn't detect any SuperSu file, and install as system mode;)
[Magisk] :
Modules not actually activating

I have the current version of Magisk, Magisk Manager, and phh's Superuser. I have tried to install modules through the downloads page of the manager, but none have fully worked. Google assistant module always says it will update on next reboot, no matter how many times I reboot. Pixel launcher module has installed the wallpaper picker, but not the pixel launcher itself Edit: it was installed, just only showed up from the default app settings, not the app list in settings. Google assistant module is still an issue.I am running nougat build NBD90Z on a nexus 6. Any and all help is appreciated!
[Magisk] henderjr:
Bummer. 86.1 is working for me with root switch to disable (and soft reboot) but sometimes it'll come back and the modules I want to work (mainly Snorlax for PGO) doesn't. I probably tried 3 reboots and disables last night and it wouldn't work. Then I wiped dalvik/cache, disabled xposed in root switch, and it's working again. Kind of a hack since only some modules work after disabling. Oh well I'm about done with PGO for a bit anyway. Only missing one to catching them all.
[Magisk] edyny1:
Hmm ok, now i understand what i did. Thanks for the info