yashsingh1/xdaforums huggingface dataset:
[Magisk] zgfg:
Who can please give me the URL from GitHub for Magisk Canary v20422 (and onwards)

In fact, I'd need json (in the good old days json for Canary was coming with the URL for the particular Magisk version, not pointing to the at-the-moment-latest version), that I can simply test patching v20422 and onwards by use of Custom URL

Apparently, Xiaomi.eu MIUI 11 beta builds can be rooted only if you start with v20422, and only upon you initially install that old version you can then update to the latest Magisk

Now I have Xiaomi.eu MIUI 12.3 /Android 11 on my Mi 9T and indeed, I was not able to root with the latest Canary/Beta 21100/21101, neither by flashing the zip through TWRP (various TWRP versions, and OrngeFox), nor by patching and flashing (Fastboot or TWRP) the patched image.

No matter how I did it always rebooted to Fastboot, and to recover I had to flash the original boot.img.

Spent a good hour and more trying this and that, always the same

However, it worked flawlesly and at first attempt when I flashed the so-called MagiskR.zip (floating around under that name with the comment 'it is an older Canary release").

When I flashed (by TWRP since I could not use the zip for patching the image) it showed me that I installed Magisk 20422 - then I updated Manager and Magisk flawlessly (by patching boot image with v21101), and everything works fine, Magisk, root, hide, modules, etc

That is the procedure repeated like a mantra elswhere (XDA, Telegram, Twitter) for the Xiomi.eu beta A11 builds - first to install "that old" Canary (distributed as zip under the various names), then to update to the latest

Now I want to find what was the latest version of Magisk (MagiskR=20422 ?, or newer) that can be installed directly to possibly help debugging and fixing what went wrong with the newer Magisk versions causing the bootloop if you install them directly

PS: I don't want to discuss about TWRP not supporting A11 (although obviously it still does on particular phones), hence I want to patch images and flash (by Fastboot). Patching is also safer, if anything goes wrong I can just reflash the original boot.img or my boot image with 21101, instead of possibly reinstalling the ROM if TWRP makes the mess when fladhing the zip)

Also, I don't want to get into discussions about distribution of Magisk versions (specially regarding the old Canary versions) through Github - in the past I was also able to find in the Github URLs for the old versions, and to help people here but now those jsons have changed and I just cannot find through the Files and History the proper one for the particular Canary (btw, it's easier for Stable, but they are not applicable for A11)

Maybe I'm too stupid (I have no problem with), but just please give me the URLs if possible (specially if so simple), or just disregard😷
[Magisk] Dr. Neuhaus:
Manager was reinstalled several times.

Here is a logcat from beginning of module installation process.
[Magisk] Didgeridoohan:
I took a quick look at the log, but I couldn't see anything obvious (and my logcat reading skills are limited at best). There's this small nagging thought that I've seen something similar reported earlier, but I can't recollect anything about it at the moment (I'll let you know if that changes). You might be able to find something with a search.
[Magisk] Didgeridoohan:
@zgfg I believe the old jsons you are looking for are gone with the Canary branch restructure in early October. You'll probably have to find someone that has saved the old zips (I checked; I haven't), or build yourself from the relevant commit.
[Magisk] zgfg:
Exactly I was afraid about. IMO, I could even find and download the zip for the particular Canary version 20422 and onwards, but not the Canary json files with the corresponding URLs - hence I would need to setup my own Web server with my own json, to use it for the Custom channel (as I pointed out, I don't want to flash Magisk zip through TWRP, but to patch boot.img starting from the not-rooted phone, just with the Manager app installed)

Unfortunately, I don't understand that logic, why to break something that was useful and to 'eorganize' into the not-useful way. What better was achieved than forcing users to access only the latest release (AFAIK, that was the intent of the reorganization) - but what about the case when latest release has some issues and users need to go to the older one

Btw, I reported that issue (latest Canary causing bootloop with Xiaomi.eu A11 beta builds - but 'custom' MagiskR works fine) and I was asked to help debugging by testing the older versions to find when/where was the issue introduced. With the pretty rude comment that I should "know" how to test with the older Magisk versions from Github, as if that's obvious to get them one by one

Now, few weeks later I finally dared to flash my daily-driver to that Xiaomi.eu A11 beta and wanted to help about that (frankly, being also curious myself) but...

Btw, once I flashed first that MagiskR (being supposidely v20422) and then updated to the latest, everything is fine - hence there must be only a simple issue introduced into the installation part

Btw, soon those MIUI with A11 will be officially rolling out for several models, hence it would be useful to get it fixed into the Canary
[Magisk] pndwal:
Yes, it seems John swept house w/ new 21000 series, and started fresh with canary builds... (Legacy stable are preserved however.)

Other users have the same/similar problem as you, and can't find official legacy canary builds either:

Can't boot to system with Magisk v21 installed · Issue #3413 · topjohnwu/Magisk

Hello, I tried Magisk v21 with Atom OS v2.8 Android 11 ROM, but it reboots to Fastboot mode. Please fix this. If you need any logs or kind of, please tell me where to get them. regards

github.com

Nb. The issue above is still open, and very similar to the one you opened, but for Atom OS. Hope it helps... PW
[Magisk] Didgeridoohan:
No idea if this is gonna make any sense, but I just want to share some thoughts...

No need to setup your own server... You have a GitHub account, create a json and upload the zip there.

While I agree that it could be useful to have that kind of access to previous json files in some situations, John isn't interested in working with anything but the latest release. All official stable and beta releases are in the "Releases" page of the Magisk repo, and if you need older Canary releases (for testing stuff) you can always build from the corresponding commit (which is a much more precise way of bughunting). John has made building Magisk pretty straightforward:

GitHub - topjohnwu/Magisk: The Magic Mask for Android

The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.

github.com

Canary releases has never been meant as anything else than development releases to find serious bugs and are not really meant for the average user (other than testing if issues with the current stable or beta release, that as previously stated are all available on Github, already has been fixed). But I doubt this is news to you...

From my own experience, the main problem with having users that are experiencing issues to just go back to a previous release is that bugs risk not being properly reported or fixed.

Just to clarify, it was not John who asked for debugging or made that comment (and John is the only one that actually matters when it comes to the issues posted to the Magisk repo, apart from @osm0sis). It looks like there's some good news regarding that particular issue though since it's apparently been solved (but not yet merged/released).
[Magisk] zgfg:
Everything could be "easy" but it requires to setup this, that (the PC with the whole building environment, just to be able to get an older version)

I really don't understand why was that necessary move, but indeed If I go to:

GitHub - topjohnwu/magisk_files: (Deprecated) Magisk File Host

(Deprecated) Magisk File Host. Contribute to topjohnwu/magisk_files development by creating an account on GitHub.

github.com

and choose Canary branch, select magisk-debug.zip (browser on the PC or desktop site must be enabled), History, then it shows only the last six versions, starting from v21001 (Oct 3).

Clicking to the button Older brings nothing - seems that older Magisk Canary zips are gone from the Github

Same for the other files in Canary branch there.

Hence, I'm not really convinced that even branching that older Canary 204xxx source would be possible (to build the zip myself), but Im not really going to try

Will see about the fix when released
[Magisk] Didgeridoohan:
Of course the old source is available. It was only the Canary branch of the magisk_files repo that was reset, not the main Magisk repo.
[Magisk] pndwal:
Just for my understanding, would fix be among these ("patch collection") commits being pushed?

Patch collection by vvb2060 · Pull Request #3533 · topjohnwu/Magisk

github.com

... Any way to know which one? 👍 PW
[Magisk] Didgeridoohan:
I don't know enough about the issue to be able to tell, but I guess it could be among those. Easiest way to find out would be to ask, either in the RP or the issue...
[Magisk] bobbyp1086:
I'm sorry I didn't read all 2100 pages before asking. I need help.

So everything was smooth in manager 7.5.1 magisk 20.4 my issue is 2 games I play and cts. Well luck had it in for me in terms of humor. Most recent magisk cts pass, game 1 plays, game 2 ain't opening. Add in magisk hide, props edit, and BusyBox. Cts pass, game 1 and 2 fail. Unroot and cts fail, both games play.

Anyone know how to fix this? Also core only mode seemed to work, but they took it off. I am on moto g stylus. Android 10.
[Magisk] xdausernotdev:
Hi,

Can you help me plz?My problem is that i want to use Magisk! But flashing the Zip with twrp doesnt work! I got Error 1 then i tried flashing the magiskboot.img i extracted from the Magisk.zip i installed earlier but failed! Flasching that boot.img destroyed my boot. I fixed that by wiping and reinstalling! Well i made out of 1 problem 2 i think thats an achievement right? Someone has some idea to get that lovely piece of software working? Also i got the idea maybe pulling the right boot.img from my working device directly maybe that will help? I cant download the boot.img for my device (htc 10) from any website. I can only download a weird exe(official htc site). Does someone know any others ways to spoof or change imei and all that stuff other than edxposed? That would be cool to know aswell

Greetings linus
[Magisk] pndwal:
@multiversepersona

@wallace108

@droidzer1

@Dixietiger

From what I've gleaned, this dev (vvb2060) has made good progress fixing issues preventing booting on some custom ROMs w/ A11, no SIM recognised and WiFi/BT MAC issues, and especially problems rooting MTK (MediaTek) devices in his Magisk fork.

I understand some have been able to root MTK devices using his latest builds, but there have been issues with SIM/MAC addresses w/ his Master builds. Apparently even these issues may be fixed in his Alpha branch.

Some, especially MTK users, may want to try his builds (incl json files) before fixes are merged w/ official Canary builds. Many commits have already been merged, others still being reviewed.

Here are his Alpha builds:

https://github.com/vvb2060/magisk_files/tree/alpha 👍 PW
[Magisk] pndwal:
Mate, you DON'T extract anything from Magisk zip!

Either flash zip from recovery, or extract appropriate boot/recovery image from your current ROM's Installation zip package, patch THIS using Magisk Manager on your device, transfer patched image to PC and flash it to device using ADB Fastboot...

Use Magisk Manager to determine which method to use for your device type (from Ramdisk, A/B, SAR status). READ official Installation Instructions linked on main Magisk page:

https://github.com/topjohnwu/Magisk 👍 PW
[Magisk] papperlapapp:
I hope this is finally the right place to ask for help....

I installed LineageOS 17.1 on a Motorola G7 Plus. Installation succeeded well.

Then I installed the latest

Magisk 8.0.3

Manager.

The G7 Plus is a RamDisk and A/B device with encryption.

Then I created the patch file magisk_patched.img ( I tried both stable and beta channel ) and installed it with fastboot flash boot

I created the magisk_patched.img from

lineage-17.1-20201215-recovery-lake.img

that comes with LineageOS.

Creating the magisk_patched.img gives no error, flashing magisk_patched.img gave no error either.

Then after rebooting I get to the login with PIN entry, after typing the PIN seconds after the phone just shuts down and reboots to LineageOS recovery saying "Can´t load Android system", please factory reset.

When rebooting I just get to the PIN entry again, entering the PIN and phone reboots/shuts down again.

To get a log I tried the logcat boot script from https://www.didgeridoohan.com/magisk/MagiskHelp

but I cannot install it, I went to recovery and used adb shell but there is no directory /data/adb/post-fs-data.d visible, actually /data/ is empty in recovery adb shell.

When in recovery adb shell, there is no logcat command at all.

To get the device working again I can only fastboot flash boot the LineageOS lineage-17.1-20201215-recovery-lake.img image file.

I do not use TWRP, just the LineageOS recovery.

Thanks for any help, I have no clue how I can provide any log currently.
[Magisk] xdausernotdev:
Hi ok i already followed that toutourial! I got stuck at this error https://freaksterism.blogspot.com/2018/10/solved-cannot-mount-vendor-magisk.html i found this toutourial for that! But now i am stuck at finding twrp with a ''vendor'' ( i dont know what that means) so it will work!
[Magisk] xdausernotdev:
I have a htc 10 and need a twrp with vendor. Someone knows where to download?
[Magisk] zgfg:
Best to check and ask on the forum for that phone
[Magisk] xdausernotdev:
Do you think i found the right soulution if i got the twrp installed?
[Magisk] Didgeridoohan:
Just to be clear: are you getting the actual error "cannot mount vendor", or are you only talking about "error 1"? The distinction is quite important, since "error 1" is just generic and can mean all kinds of things... To know exactly what the problem is you would have to look at the recovery log (after receiving the error).
[Magisk] xdausernotdev:
Oh yeah it said Cannot mount Vendor!
[Magisk] xdausernotdev:
https://www.file-upload.net/download-14400355/recovery.log.html that is the log file
[Magisk] Didgeridoohan:
Then you can either follow the advice already given and look in your device's forum for the proper TWRP (or for a general solution), or make a backup of the boot image in TWRP and patch that in the Magisk Manager (as per the official instructions linked earlier).
[Magisk] Didgeridoohan:
@papperlapapp Have you tried asking for help in the ROM thread? That's usually a good place to start.
[Magisk] xdausernotdev:
Oh yeah i already tried that! I already flashed my device with lineage os! i looked inside the .zip and found the boot.img i then went into the app and patched that boot.img and then installed the magisk-patched.img in twrp and then tried installing magisk! The same error reoccured!
[Magisk] Didgeridoohan:
If you've patched and flashed the boot image you do not need to flash the zip in recovery after. Those are two different methods of doing the same thing... Pick one (the one that works).
[Magisk] xdausernotdev:
ok i just try doingt that!
[Magisk] xdausernotdev:
It didnt work! This is what i did ----> got the boot.img from the rom.zip ----> used magisk manager to make magisk-patched.img out of boot.img ---->went into twrp and installed magisk-üatched.img----> booted into system to check whether magisk is installed---->magisk says: Installed: N/A? Any ideas?
[Magisk] xdausernotdev:
Oh i also tried dowloading magisk.zip from from app---->went into twrp---->try installing magisk.zip---->failed!
[Magisk] Didgeridoohan:
To verify if Magisk is active or not you can go back to TWRP and see if there's a magisk log in /cache.

It could be that the Manager just doesn't have access to the Magisk internals. A common issue for that is if the Manager has been installed to external or adoptable storage. Check that.

If I were you I would stop focusing on the TWRP error and try to get the boot image patching working (that's the recommended installation method anyway).

Checking through your ROM's thread for if someone has managed to install Magisk is also a good idea (use the search function, it's quite good on the new forum).
[Magisk] zgfg:
When patching, did you uncheck Recovery mode option (since you are patching boot image, not recovery).

Also, looking into the Magisk Manager, does it say that Ramdisk was found and patched or it reports some error

After flashing the patched boot img, booting to system and then rebooting to TWRP, do you see Magisk database (it will be only created if Magisk was initialized on boot) /data/adb/magisk.db

If you do see, then try to reinstall Magisk Manager (maybe it didn't see the db for some reason)

Generally, stick with one method (patching or TWRP), trying to debug it - jumping from one to another you never know if something resulted by one or another

To avoid possible problems with TWRP, you can flash the patched boot img directly from Fastboot
[Magisk] pndwal:
Sounds like you have issues with TWRP for your device in any case. Installation Instructions say to use PC and Fastboot to flash patched image for this (common) reason.

I would be trying this, and ensuring Manager is on Internal memory as mentioned... PW
[Magisk] papperlapapp:
Oh, btw, is it required or recommended to disable the screen PIN prior to installing Magisk? I read somewhere, someone recommended to disable the PIN prior to installing Magisk...?

thanx!
[Magisk] zgfg:
Generally, it should have nothing to do with Magisk

Be aware, when people say "rooting" some think of the whole process like unlocking Bootloader, installing custom Recovery (TWRP), even installing custom ROM

I have never disabled screen unlock for Magisk but yes (just in case!) I do (+ I remove Google account) before I install custom ROM or even go for Factory resetting (being also part of Bootloader unlocking process)

Plus, on some devices/some TWRP do not properly support storage encryption (do not prompt for pin or pattern or do prompt but do not decrypt), hence if you install Magisk by flashing in TWRP (as most people still do) then you may need to disable screen unlock not because of Magisk but because of TWRP (its access to Data and Internal memory)

All together, consult the forum for your device why is it really recommended (if it is), but be carefull, is it really for Magisk (?!) or for TWRP, custom ROM installation, etc - there are tones of copy/pasted "guides" that may requure you to drink a glass of milk before "rooting" or something like that but with no technical ground for
[Magisk] xdausernotdev:
i tried now everything i will try to find the ORIGINAL boot.img and try patching and flashing that with fastboot! Also what do you mean by the last thing you said?

Also thx so far i really aprreciate that youre taking the time to help me and others thats very nice!
[Magisk] zgfg:
If you have device with removable SD card, do not install Magisk Manager to SD card - alwys install to Internal memory
[Magisk] xdausernotdev:
I have not sdcard inserted! But my storadge for some reason is called sdcard its where the DCIM is on
[Magisk] zgfg:
Then don't worry
[Magisk] J.Michael:
Can Magisk always be installed in recovery?

I know there are devices/systems on which Magisk *must* be installed in recovery. I want to know if you are always free to install Magisk in recovery, even if you could install it in the boot image.
[Magisk] pndwal:
After just a brief perusal, pre 21000 series Magisk Canary builds, from late September 2019 thru late September 2020, seem to be intact and available from here:

https://github.com/AnErW/magisk_files-1/commits/canary

... and likely from other (numerous) GitHub Magisk forks also.

json files seem to work with individual builds as hosted when raw file address is pasted for custom channel in Manager also. PW
[Magisk] pndwal:
If you mean Patching Recovery image, I imagine you can, w/ normal caveats re. need to boot to recovery for root and recovery unavailable for Magisk install/update, etc.

If you mean using custom recovery to flash, then no... Actually, the Patching image method is now the norm:

The reasons are also given in the Installation Instructions linked from Magisk main page:

https://github.com/topjohnwu/Magisk PW
[Magisk] Didgeridoohan:
It all depends on where the ramdisk is, and that's were Magisk needs to be installed. If your device has the ramdisk in boot, patching the recovery will do nothing...
[Magisk] lamjed001:
I Installed Magisk In PhoenixOS virtual machine (virtualbox) using method patching boot image and then i changed ramdisk.img after unpacking patched boot image but the problem when i try to install modules installed but not loaded see the photo for my prooblem and how to solve it ?

Note : im using magisk v8.0.3
[Magisk] pndwal:
Mm..

I know boot.img lacks ramdisk in many legacy SAR (A only) devices like mine, but Magisk actually now adds this ramdisk (initramfs) to boot.img when patching, and this will also work as long as bootloader supports it (eg many Xiaomi devices). So this means there are effectively two 'ramdisks' on my device. Magisk will work whether recovery or boot image is patched.

Traditional structure also includes ramdisk in both recovery and boot partitions also according to John Wu:

Android Booting Shenanigans

The Magic Mask for Android

topjohnwu.github.io

So I imagine patching recovery should also work for these.

I know it gets more complex on 2SI ramdisk "SAR" (John/Magisk Manager describes as modern form of SAR, Google says it isn't) devices w/ hybrid ramdisk. Some of these with A/B actually have recovery A/B partitions also, so (I'm guessing here) potentially 2 extra 'ramdisks' to patch! (recovery a, recovery b, real partitions separate from dynamic Super partition.) These otherwise have boot.img containing normal boot kernel and recovery-ramdisk (BOARD_USES_RECOVERY_AS_BOOT := true). Recovery-ramdisk is used to boot into both recovery and Android, but it seems recovery.img may be lacking altogether.

Ramdisk partitions | Android Open Source Project

source.android.com

There are a number of other configurations also where there may or may not be a recovery.img w/ ramdisk to patch, and it gets very confusing, but it's safe to say that many devices can successfully load Magisk to both recovery and boot partitions!

Still, the original question was

So it seems the answer is no, NOT always... 🙃 PW