yashsingh1/xdaforums huggingface dataset:
[Magisk] badabing2003:
Sorry for the late response, thanks

How do you patch a .zip ROM, you patch the zip or you extract boot.img from it and patch that?

If you feed .zip to Magisk, then all we're missing is needle button to support accepting .zip files, and can we assume that if it is .zip then it must be recovery?

Or are there cases where you patch a zip but it is not a recovery ROM?

If it is always recovery when it is a zip, then PF can set the recovery flag and just invoke the rest of patching process.

If you need to extract boot.img and patch that, then it's just a matter of recognizing the package and extracting it properly, which it probably already does if you load it as ROM, in which case I suppose the patching dialog would need to have a checkbox for the user to select Recovery.

If this is the way, do you pack it back into the zip? PF can do that if that is what's needed.

Working on supporting it.

They are huge, and nested compressed files, which takes time to process. I'm trying to optimize.

tgz -> tar > folder -> images -> boot.img

I saw your other post, just to confirm,

if the folder is extracted

boot patched

flash_all can be called

just one line in flash all needs to be changed

fastboot %* flash boot %~dp0images\boot.img || @echo "Flash boot error" && exit /B 1

if stock boot.img is kept intact, or replace stock with patch, name it the same boot.img, and just run flash_all

(y)

I still have to read up,

Does your device support Live booting?

Have you tried to boot with the pf created patch file and see if it works as normal?

1 or 2 should do.

Thanks
[Magisk] zgfg:
I didn't open your logs (btw, there are no Magisk/LSPosed developers here who would study your logs - for that, you would need to submit Issue on GitHub)

Have you enabled Zygisk and does Magisk app show Zygisk Yes on the main screen?

And are you running Zygisk-LSPosed module?

See the screenshots
[Magisk] bunta126:
yes, yes & yes :)

I also tried installing the riru module and riru lsposed but it had the same effect.

I'm not sure its related directly to just LSPosed. The other modules don't appear to be working properly either but I can't test them as easily.
[Magisk] zgfg:
Be aware, Riru is incompatible with Zygisk
[Magisk] LittlePro:
1. I also thought about that : It says : Enable

2. Its not an Duos & not an LTE model & the only available latest firmware 5.0.2.

Thanks.
[Magisk] pndwal:
I'm not sure you understand; .zip ROMs are what PF already accepts, but for Xiaomi and some other devices, OEM supplies .zip ROMs for flashing from recovery only and they are termed 'tecovery' ROMs... Xiaomi also supply a more complete 'fastboot' .tgz ROM that is required for flashing from PC/fastboot...

In Xiaomi parlance, a Fastboot ROM is a .tgz archive while a Recovery ROM is a .zip archive.

I now see that Pixel 'fastboot' ROMs are supplied as .zip archives ROMs however, so understand the confusion... It seems that even Pixel / Nexus used this convention previously and would use .tgz archived ROMs for fastboot flashing though:

-Old Nexus:

https://forums.androidcentral.com/t...how-do-i-use-twrp-to-go-back-to-4-1-1.262830/

-Another Nexus (see 'direct download' link):

https://xdaforums.com/t/factory-image-7-0-0-nrd90m.3446142/post-68327112

-Several devices:

https://9to5google.com/2017/08/21/h...l-nexus-5x-nexus-6p-nexus-player-and-pixel-c/

With either archive type we follow Magisk Instructions and extract boot.img or recovery.img for patching as needed... We never 'patch a .zip ROM'; I think patching whole binaries is only done for Samsung...

As noted above, we simply extract and patch per Magisk instructions...

👍

Not sure about 'flash&all'... Aren't we just flashing patched boot or recovery image?

👍

fastboot boot only?; I believe so... Haven't tried with A11...

No; took you at your word. (... "You won't need to flash anything".) 😜

Welcome. 🙂 PW
[Magisk] Thehaluzer:
Hello!

That app is a hidden version of Game Guardian. See picture i added

Mr sibil in växjö sweden. Is the name of the company.

You don't happen to know how to find the version of magisk they used?

Is it maybe stored in rom or system folders?

There are no other magisk app that i find
[Magisk] ctcx:
Didn't you explain some time ago that, even when directly running the script as root, all flags should be set either one way or another?

App UI uses its own mechanisms to call the other scripts for setting flags, but here

reinstall-magisk-on-lineageos/reinstall-magisk-on-lineageos at main · NicolasWebDev/reinstall-magisk-on-lineageos

Small bash script to reinstall magisk after each LineageOS update - NicolasWebDev/reinstall-magisk-on-lineageos

github.com

I see nothing neither flag- or addon.d-related...

This is completely independent of running firmware.
[Magisk] Thehaluzer:
Hello!

Thanks good to know.

I don't know how to enable zygisk. It shows no.

I guess no.
[Magisk] Thehaluzer:
Hello!

Thanks I'll check them out!
[Magisk] Thehaluzer:
It's game guardian in it's hidden form there are 2 of it. Value changing tool for editing in game values

[/QUOTE]
[Magisk] Thehaluzer:
[/QUOTE]

GameGuardian

Overview: Play games your way! “GameGuardian” is a game cheat / hack / alteration tool. With it, you can modify money, HP, SP, and much more. You can enjoy the fun part of a game without suffering from its unseasonable design. Requires Android: 2.3.3+ GameGuardian Features Summary Runs on ARM, x6...

gameguardian.net
[Magisk] J.Michael:
When you had Magisk and its manager installed, you could have seen what version of each was installed by opening the manager.

Is it out of the question to ask Mr. Sibil?
[Magisk] zgfg:
Open Settings in the Magisk app (top/right) scroll and find Zygisk, enable and reboot

Study what else you have in Settings
[Magisk] J.Michael:
I'm pretty sure @pndwal said the "recovery" of "recovery ROM" is from where it is flashed, not *to* where. "boot.img" is going to be written to the boot partition. No matter which file format the ROM is in, "boot.img" will never be the recovery.

If someone is determined to install Magisk in recovery, you will need to find a "recovery" image -- probably "recovery.img".

You really need to track down someone who has installed Magisk in recovery on a non-Samsung device. My Samsung experience is that a few partitions have small changes made to them, in addition to the primary change of injecting Magisk into recovery.img.

If you have the phone that matches the recovery ROM ZIP, see if it has a partition named "recovery". Then check the flash script to see what file gets flashed to it.
[Magisk] molitar:
My Magisk is being detected by several apps. Safety Net passes. So first I guess I need to know the channel for Canary so I can update to that. Second is there a new module I need to use to replace the Universal Safety Fix? Thank you.
[Magisk] badabing2003:
Thanks, in that case, I'll drop the idea of supporting patching recovery, considering that I don't encounter it and it is highly discouraged with current Magisk.
[Magisk] Human Person:
Hello I'm still only able to make it to the Motorola boot logo after using twrp to uninstall magisk, using the uninstall.zip method. What else could be at play after doing a direct install from 25.2 -> 26.1?

Basically my steps have been:

fastboot boot twrp.img
adb shell
phoneName:/ # twrp decrypt myPassword

From there I simply used the method John put in his guide to uninstall via custom recovery since I'm unable to enter safemode on this device.

-https://topjohnwu.github.io/Magisk/install.html
[Magisk] bunta126:
This is because your phone does not have a separate recovery partition. The recovery image is actually a ramdisk which sits inside the boot partition. The boot.img file contains the ramdisk recovery image within it.

In magisk, you need to patch that boot.img file and ensure you have unselected the option to patch recovery (since it is not a recovery image).

You may find however that when you flash that boot img via twrp that you lose twrp from recovery, and if you try to install twrp to the boot image again it will lose magisk capability. If that is the case, install twrp, do a backup of the boot partition from TWRP and then use the backup file (will be called boot.emmc.win which you can rename to boot.img) to patch in magisk so you keep both twrp and magisk. This method can also be used if you can't find the separate boot.img file you need.
[Magisk] J.Michael:
How do you install TWRP if you have no recovery partition?
[Magisk] zgfg:
Recovery is integrated in Boot partition. TWRP replaces stock Recovery in Boot partition

Usually you install custom Recovery to those phones the following way:

- fastboot boot <recovery img file>

- once you boot into the custom recovery, it gives you the option to install the running custom recovery permanently

- it installs (replaces stock Recovery in Boot partition) and you can reboot

As said in a post above, then you take a backup of the Boot partition (either from that custom recovery or by disk-dumping) and use that as your boot image file to patch Magisk and flash it again to Boot partition

As a result you have Boot partition with both custom Recovery and Magisk

In future you can update Magisk by Direct install (or again by patching and flashing)

Patching Magisk (or Direct install for Magisk update) does not affect the part of the boot image with the stock or custom recovery

You only need to re-do custom recovery installation as described above upon OTA system update or custom recovery update. And then you loose Magisk and have to re-patch and flash as above

From the side of using and booting it works just like a 'normal' case: you boot either to Android (with Magisk) or by key combo to (custom) Recovery

---

Btw, instead of taking a backup of the Boot partition and patching and flashing, you can also install Magisk by flashing the Magisk apk file from the custom Recovery

For the modern custom recoveries it is not needed to rename Magisk apk file to zip - apk file is already a zip archive and custom recovery finds the META-INF folder inside and it uses the Magisk apk file for flashing just as if it was renamed to the zip file (apk files are by definition special zip archives that are named apk, not zip - when you rename apk file to zip, you do not change the file structure, it was and still remains the zip archive - Magisk apk file in its zip archive contains both what is needed for package installer to install Magisk app and what is needed for TWRP to flash Magisk)
[Magisk] Thehaluzer:
I can't scroll further down this are all the settings i have.
[Magisk] Thehaluzer:
Hello!

Yeah well you don't really go and remember versions of magisk at least I don't

Here is a screenshot of my other phone which was rooted by same company and it's working
[Magisk] J.Michael:
Then I think you should be trying to install 25.2
[Magisk] pndwal:
Official twrp.me has instructions for each device it supports... Installing TWRP in recovery ramdisk in /boot partition is fairly simple, sometimes needing temp boot from fastboot before flashing from temp booted TWRP and sometimes flashing directly flashing from fastboot...

If rooting, pre-rooting is often recommended to disable several protections, next TWRP is installed which will often remove root (since Magisk and TWRP reside in the same recovery ramdisk in /boot), then Magisk is flashed again.from TWRP as .zip or a TWRP backup of (twrp-patched) /boot can be made and patched in Magisk App to get twrp+magisk-patched-boot.img before flashing. 🙂 PW
[Magisk] pndwal:
I think it would be good to support, and I posted disambiguation due to some confusion above.

Rather than being 'highly discouraged' (it's not; it's plum necessary 🤪) patching recovery partition is actually the only option for most A-only devices launched with Android 9 (legacy SAR, circa 2018, 2019) other than Xiaomi models!

Hope you reconsider... 👍 PW
[Magisk] pndwal:
Probably don't need, but main Magisk GitHub page, click red 'Canary' button under Downloads...

If you mean official USNF then yes; you need a modded (fixed) one:

https://xdaforums.com/t/module-mod-universal-safetynet-fix.4553699/post-88149053

👀 PW
[Magisk] zgfg:
It seems we are back at square one

Do you have Magisk (not Magisk app) installed now or not?

Screenshot of the main screen Magisk app, top part?

If Magisk app shows Magisk No on top on the main screen, then you don't have Magisk installed and obviously you cannot turn on Zygisk and you cannot proceed with LSPosed and you cannot do anything!!! - and sorry but no need to waste time on discussing Zygisk or LSPosed, etc, until you will patch and flash your boot.img to install Magisk

Or maybe you consider paying to that 'company' again... or postpone the Magisk journey if you cannot find where to download the ROM for your device to be able to extract the boot.img
[Magisk] Thehaluzer:
Hello!

Alright I'll do that. And just normally uninstall the one i have right?
[Magisk] Thehaluzer:
Hello!

How do i find the exact ColorOs version?

I only find that i have 12

Same as android version 12.

But there are version 12.5 and such and on the picture there is even more version. How to find exact version i have?
[Magisk] J.Michael:
Look at Android Settings -> About Phone, maybe click item that says "Software"

I don't remember what your original problem was. If you originally had Magisk and some Magisk modules installed, you might have had a problem booting after you installed the latest Magisk, because the modules are still there, and they are not compatible with the newest Magisk.

If you uninstall the Magisk app, and install the 25.2 Magisk app, and never click "Update", and really use the boot image for your current ROM when you patch with Magisk and flash, then you should not have a problem with the modules.

Please pay attention to what you are doing. If you do not download exactly the software already running on your phone, then you will be patching and flashing the wrong boot image. It could work. It could fail. I think this mess started with you updating the software on your phone. Make sure you download the ROM corresponding to the updated software.

One approach, especially if you can tolerate wiping your phone, is to flash the entire ROM you download. Then you know that that ROM is what is running on your phone.
[Magisk] zgfg:
I don't know are you aware. All of us here are just users like you. Everybody helps by spending a time of his own private life

Hence people will help you by some extent and give you directions but then you are supposed to get your hands dirty (if not, after that people will probably ignore further endless questions)

So, I'm really not an One Plus user and I'm not familiar with its ROMs and everything. Frankly, I'm also not interested about - if I would have my own One Plus I will dive in and spend days and nights until I find, and first of all I would take time to find the right places to look for and to ask (places with the users of the same phone)

Hence if somebody else can help you, good for you. This is here General Magisk forum and you cannot expect from the users of Samsung, Pixel and other brands to give you credible answers which ROM to download for your One Plus phone - in case of a not credible answer and wrong ROM, you could brick your device🤔

Hence good luck

PS: And one more advice, all in a good will. Please see that you and your questions are not alone here. Maybe your first post is already buried under the later five or six other topics, tens of posts and several pages

You cannot expect that we will additionally spend our time trying to find your original report or problem. Hence when asking something, please better repeat all relevant information (eg, we just wasted a time trying to help you with your not working LSposed but it turned out then that you are again the user with Magisk not installed - I thought that you maybe installed Magisk in the mean time and that you now wanted to proceed with LSPosed)

Anyway, good luck

Also if you expect that people will continue helping you, better like their answers (even when when they are not fully helpful - if people who ask don't do that, the others will sooner or later reasonably stop bothering with trying to help.them)

And try to think about the opposite situation. If you would be trying to help to somebody, what would encourage or discourage you to continue
[Magisk] badabing2003:
Your wish is my command :)

Although with one caveat,

Yes I can tell if it is Ramdisk yes or no by running a script, but that requires unpacked Magisk, (for not rooted phone, I would need to unpack)

And although it is true that PF eventually unpacks to create a patch, but within the workflow, that stage is much later, and that stage is dependent on choices a user makes in the above screen.

Of course it could be worked out and workflow changed to automatically offer / not offer the choice.

Considering that the target audience is really minute if at all existent, specially considering that the tool has Pixel in its name, and people who have Pixel phone don't need it, and people who need them wouldn't be looking to tools for Pixel Phones ... lol

I decided the leave it up to the user the choice to have that option visible or not. (no auto detection)

The tooltip on option suggests not to turn it on unless ...

I hope that should be enough.
[Magisk] zgfg:
Back, by the end of 2019, I had such a phone (Huawei, Mate 9) where Magisk had to go to Recovery

I read and knew everything about (there were some other tricks related to, eg, rooting caused some problems with dialer or so if I recall correctly now but there was also a cure for that) but I was unable to unlock the Bootloader to start with

I bought that phone a second hand and the previous user already updated EMUI (just before selling) to the brand new version where Huawei made unlocking the Bootloader impossible and attempts to downgrade EMUI would result with hard-bricks

A year later it became possible to unlock the BL but only for 30 or so bucks. I had to open the phone and shortcut the pins on the motherboard and the guy over TeamViewer was supposed to unlock the BL

He did not succeed to unlock (I still paid half the price for his service) and I partially damaged my phone (physicall) when assembling (?!) it back

Anyway, thar was my only phone that I didn't root (I started to play several years earlier with SuperSU, Kingo and that stuff). And my third and last Huawei. Btw, Trump also stood up then with his sanctions against Huawei, causing them issues with updating Android, etc
[Magisk] Thehaluzer:
Hello!

I don't have software

Modules are working like they should. It's just root is gone.

So updating magisk app is not good?
[Magisk] J.Michael:
Did you read what @zgfg said? You need to read a lot. You need to check whether you can click on something to get to another page. If there is truly nothing under "About" that identifies the version of software installed, I am out of ideas.

I said I do not remember what problem you had when you tried to install Magisk. I imagined a problem you might have had, and I suggested that you might avoid that problem if you use Magisk 25.2 instead of using a later version of Magisk.

How can you claim that modules are working if you do not seem to have Magisk installed?

If you can really see that a Magisk module is working, then we are back to "you still have Magisk, but the manager app does not see that, so you should look again to see if you have more than one manager app installed."
[Magisk] shoey63:
Root is gone?

You probably unintentionally uninstalled Magisk from within the app itself, restoring the stock boot image and thus losing root.

Go Here and download your firmware.

Then extract the boot image from the payload.bin (plenty of payload dumper tools out there), patch it with the installed Magisk app and fastboot it.

You will be rooted again.
[Magisk] pndwal:
XDA etiquette 101... the place where everyone follows the golden rule and gets along in perfect amity... 🤗👍... PW
[Magisk] pndwal:
👍 🙂

Yes, target audience seems to be unnecessarily restricted by the app name.

Perhaps your tool would become more ubiquitous with a name change... How about "NJPFA"?...

Or Maybe keep PF (simplified options for Pixel users) but make new NJPFA available with other per-device options for a wider audience...

Oh, and that would be "Not Just Pixel Flasher Anymore", of course! 😆...

Looks fine to me!...

---------​

An aside:

I thought you were trying to increase compatibility beyond Pixels; you seemed to be soliciting advice and adjusting your code for that reason...

FWIW, if that's your intention I think you could really do yourself and others a favour by rebranding the app (of course NJPFA above is a joke, but not entirely unfitting I it appears), and I think you'd find that even the number of interested users with older A-only first gen SAR devices needing Recovery mode Magisk would not turn out to be "minute" at all!... Many are still using these devices.

To take just Samsung as an example, all their gen 1 SAR devices were A-only AFAIK, so users of all the following phones and tablets would need/value Recovery Mode option in your App:

Samsung Galaxy S10,

Galaxy Fold,

Galaxy M10s, M30s, M40,

Galaxy Note 10, Note 10+,

Galaxy Tab S5e, Tab S6,

Galaxy A10, A10e, A10s, A20e, A20, A20s, A30, A30s, A40, A50, A50s, A60, A70, A70s, A80, A905g,

Galaxy Tab A 10.1 2019, Tab A 8.0 2019, Tab A 8.0 Kids Edition 2019

... Some are just on 4 years old now but I bet many are still in use... 😀 PW
[Magisk] badabing2003:
:ROFLMAO::ROFLMAO::ROFLMAO: I was trying to figure out what it stood for.

When I first started working on PF, it was primarily to simplify my monthly update routine (I've been on the Pixel wagon since Nexus 6P, and the process of the update hasn't changed). Yeah call me lazy

It started as a simple Powershell script, and I shared it in case others would find it useful.

Soon after, it became obvious that a UI to select firmware / Platform Tools, ... would be more user friendly then passing arguments to a script file.

I switched to Wx.Python (I'm not sure if it was the right choice as I didn't know much about it then) and it grew from there.

I added features like package manager, apk installer ... and others out of my needs, they don't directly relate to Pixel phones and are more generic utilities, but PF had all the scaffolding (not exactly in reusable form), so adding to PF was easier than refactoring that into a new App, (did I mention that I'm lazy?)

Rebranding is a possibility, if I make the functionality fully compatible with the older phones.

I have a test One Plus 5, which I flashed with Lineage, and I don't think the recovery part of the steps can be automated, yeah I can reboot to recovery, but then the user has to flash, erase partition / wipe ... the steps, and that would be half baked for me.

In the interim, what I've been doing is adding low hanging fruit features, and when the collection of them becomes more baked, then I would consider rebranding or decoupling, either of the two is probably too much work for my lazy ass ;)
[Magisk] HippoMan:
That reminds me of the wise words of a friend of mine when I mentioned my dysfunctional family: "*Every* family is a dysfunctional family."
[Magisk] Nekromantik:
So it looks like Zygisk is causing the problems with Starling bank app. If you disable Zygisk then the app works.

Maybe the devs can investigate this.
[Magisk] badabing2003:
I recall reading somewhere that if you block a certain outbound address it works,

They're using an external service.

I'm sure if you search you will find it as I don't have it handy.
[Magisk] Nekromantik:
that used to work not anymore. we all already have that blocked.

hoping someone can take a look as if its only detecting zygisk then maybe a module or something else can hide it
[Magisk] Nergal di Cuthah:
That bank, starling, gives lots of issues (they have a spy in XDA 😜 ) maybe it needs it's own just that bank thread.
[Magisk] pndwal:
https://xdaforums.com/t/banking-app-starling-detecting-magisk.4576421/

👍 PW
[Magisk] Thehaluzer:
Hey thanks alot for providing the link. Do you know if ne2211 is indian coloros?