yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Well seems you did; said installed Canyie's Dreamland... It's not entirely systemless like LSPosed... Did you read this?:

so system partition is not stock it seems...

You could check if Dreamland keeps backups to restore /system but I doubt it... (Don't know why you'd risk this with your level of knowledge, especially when systemless stable LSPosed is available... Anyhow...)

Not sure if update tried to write to new slot or just failed before reverting to initial slot; update engine is supposed to verify images are stock first... Either way, 2nd slot is old or corrupt it seems...

I think Magisk may suppress update messages on some devices to avoid issues, but I'm not sure about that... Safe mode is a different beast...

So you probably need to flash whole ROM again to remove Dreamland (apart from its data) and restore stock /system... After that you should find OTA succeeds...

So corruption should be fixed as above... If you update, you'll need boot.img matching update OTA to root...

There are ways to get this, but generally need root or temp. root to dump from device where TWRPs isn't available (that can simply back up boot.img and the resulting .win file is useable)... I'm guessing you could update then use fastboot (assuming you can access this with a PC) to switch slot back to original older system, root that with old boot.img and then dump boot_x.img from inactive slot=x... @osm0sis may be able to chip in here; I believe he has utilities for dumping images...

There's also a good chance that your older patched boot.img will also work to boot updated slot with root. If so you'll likely have hardware issues (Sim, WiFi etc) as boot image contains kernel which usually gets updates corresponding to some in /system, but you may then be able to locate and use the stock boot.img backed up when first booting with root in that slot located at /data/magisk_backup_xxxxxx... Next, patch and flash that to fix issues...

Hope it helps... 🤠 PW
[Magisk] newbie1113:
@pndwal it was my bad i didn't carefully read it. Actually in Lsposed we need to manually select apps which is troublesome that's why i was looking for a similar alternative to Edxposed and found dreamland which supports a12 too but didn't thought this would happen 😞. Next time onwards i will read warnings carefully.

Good thing is i have my os as properly working (it somehow boots directly into the old os as i enter fastboot mode manually as i don't have root i can't backup app data but anyways i can backup the entire internal storage to my pc and use some app some like super backup to do the rest, so i can safely flash back stock rom).

Ok so, flashing stock rom will fix the boot slots and clean the other slot and fix the dm-verify corruption right?

PS. I somehow rooted back my old os and took all app backup

And many thanks to you good person for helping me and help me identify my mistake.
[Magisk] HippoMan:
I have an issue with the ancient, Stone-Age version of Magisk which is running on my device:

Device: Pixel 5

OS: crDroid-7.28 (Android 11)

Magisk version: 23.0

Before I describe the issue, I just want to make it clear that I do not want to upgrade to any version of Android newer than 11.x, and I do not want to upgrade to any version of Magisk newer than 23.0. My reasons for this are ...

(1) ... that I can easily use TWRP under this set-up for nandroid backup/restore, and I want to continue being able to do that;

(2) ... that it's very quick easy to install ROM updates and do Magisk re-installs without going down the crazy rabbit hole that's nearly unavoidable with newer versions of Android and Magisk;

(3) ... that I use my device for work and my everyday life, and I can't afford to be without the use of my phone for an extended period while wasting time dealing with the boot loops, wiping, re-flashing, etc. that are very likely and almost inevitable if I attempt to upgrade Android or Magisk.

My goal is to try to fix my issue under my current OS and my current version of Magisk, if at all possible. The following describes my issue ...

When I first installed crDroid and Magisk on my device 8 or 9 months ago, everything worked fine. That was crDroid version 7.21 (still Android 11). Everything worked with no problen regarding being rooted, including the fact that when I installed and opened a new app that requested root, I would properly get the pop-up from Magisk asking if I indeed wanted to grant root to the app, and that worked fine.

Since then, I upgraded to crDroid version 7.25 and later to version 7.28, and there were no problems, and everything worked fine.

However, I haven''t installed any new root-requesting apps for several months. Then, recently, I tried installing some new root-requesting apps ... but for each of these new installs, when they run for the first time, instead of the root-confirmation pop-up appearing, all that happens is that I get directed to the Home page of Magisk ... no pop-up. Therefore, I can no longer grant root to any newly installed root-requesting apps.

I didn't make any changes at all to Magisk nor its configuration. And all of the Magisk modules that I use were initially installed along with Magisk, and none of them changed nor were re-installed.

To be clear, my device works fine with all the already-rooted apps. I just can't grant root to any new apps any more.

Here's what shows on the Magisk Home page ...

Oh, and yes, Magisk is indeed hidden, and there are no other Magisk versions anywhere on my device, neither "normal" nor hidden.

Has anyone seen this kind of situation with this old, Stone-Age version of Magisk? And could there be any way to fix it without my having to re-flash my ROM or anything like that? The furthest that I'd prefer to go would be to uninstall and then re-install Magisk, but I'd even like to avoid that ... unless it's unavoidable.

Thank you in advance.
[Magisk] J.Michael:
Is the Magisk manager app refusing to do anything until you update it? So you can't use the manager's "SuperSU" section to check the status of these new root-needing apps?

I don't know why you never had trouble before, but maybe you need to set the update channel in a way that will stop the manager from considering itself (or Magisk) to be out of date. If you can't do anything with the manager, I don't know how to do that. Maybe @zgfg has posted how to "manually" edit the Magisk database (using sqlite in a terminal, rather than by using the Magisk manager).

You could try unhiding the manager.
[Magisk] HippoMan:
I can use the super-su section to see the status of all the other rooted apps with no problem. I just can't add new rooted apps.

Oh! Un-hiding Magisk fixed the issue! After un-hiding, I get the root-confirming pop-up, and it works fine! Thank you!

... and re-hiding once again disables the root-confirming pop-up. So, I guess I just need to temporarily un-hide before enabling root on any new apps, and then re-hide.

As for another update channel, does anyone know of a channel in which I can find the Stone-Age Magisk 23.0 flagged as the "latest" version?
[Magisk] dcarvil:
Go to settings, update channel, custom and set the following URL.

https://raw.githubusercontent.com/t...4e59f631280cc26ccc6d40a7cf04f7f37/stable.json

This is the URL for 23.0.
[Magisk] HippoMan:
Thank you for this!

After changing my update channel to "custom" and with this URL, Magisk is now indeed showing that my 23.0 version is the latest.

However, I still get the same error when trying to assign root to an app.

It still seems like the only way this works is for me is to un-hide Magisk before assigning root to any app.
[Magisk] zgfg:
Setting custom channel to a different URL only affects Magisk update mechanism, it should have nothing with popping up for the root grants

Maybe some permissions (to pop up over other apps) for the repackaged (hidden) Magisk app are missing (it has different package name than the original Magisk app hence the permissions from Settings/Apps given to the original Magisk app package name are not applying)
[Magisk] HippoMan:
That sounds plausible.

How can I examine and possibly change the permissions which get assigned to the renamed/repackaged version? That version doesn't show up anywhere in the Settings.
[Magisk] zgfg:
I never use Hide Magisk app from Magisk app, I use HMA (in which case the app is not repackaged)

But the repackaged app must still show in Settings, but under a different name (the name you gave it, Setting or so but that default name might have been different for v23)

If you have its icon on Home screen, long press and tap to App info to go directly to the Settings/Apps for the given app (I don't know would it work on your ROM)
[Magisk] pndwal:
Un-hiding and re-hiding often used to fail after a number of updates were available because later version stub apps were incompatible and Magisk was still calling stub online per update JSON (that was not fixed until we got "• Make stub patching 100% offline" with 26.0, ie. stub began to be called from installed binaries) rather than the stub version packaged with the earlier Magisk version. Even when hiding succeeds, changes in updated stub often caused issues, and you too have observed that these are absent without Magisk hidden...

Nb. I know this stuff because I submitted an issue detailing anomalies that occur when Magisk App is restored, then hidden (uninstalled after binaries are transferred to stub app data actually) again after more recently versions are available and user fails to update immediately. The issues are due to stub being called from online update JSON rather than installed binaries, and this was resolved with the 26.0 change noted above.... I also posted various raw JSON URLs for use with Custom channel and old Magisk versions to fix the issues for users not updating back then...

It appears that you have lately un-hidden and re-hidden Magisk as you have indicated that your hidden stub iteration is now v33 (made for/supplied with

25.2)

so I think this will be your problem since stub released with 23.0 originally was v21 and there have been various stub app repackaging and loading method changes (some will need supporting changes in main binaries also) between 21 and 33...

Having the 23.0 archive JSON https://raw.githubusercontent.com/topjohnwu/magisk-files/afe2c304e59f631280cc26ccc6d40a7cf04f7f37/stable.jsonj set as Update Channel using Custom channel (instead of having default latest Update set; nb. stable is always simply https://raw.githubusercontent.com/topjohnwu/magisk-files/master/stable.json) should solve you issue if you simply take Restore the Magisk app, then Hide the Magisk app again... You should also observe App info, "Installed 23.0 (23000)

(33)

" becomes "Installed 23.0 (23000)

(21)

".

----------​

If that doesn't resolve it, often something in Magisk config files or database can become corrupted, but it is possible to force a rebuild of clean configuration...

You don't need to reinstall to effectively get a clean installation of Magisk; simply delete everything in /data/adb, then reboot and magisk.d (daemon) will rebuild configuration files there... You'll then need to configure modules, Denylist, Superuser list etc again but corruptions are gone and issues often fixed this way.

You can also retain modules by only deleting /data/adb/magisk directory and /data/adb/magisk.db database file... This is usually sufficient to fix issues.

🤠 PW
[Magisk] zgfg:
If it didn't pop-up or you didn't click to grant, open the (hidden) Magisk mngr, SuperUser tab, find the root app you need and toggle to grant the root permission
[Magisk] pndwal:
As long as current slot is completely stock, whatever is on inactive slot shouldn't matter for the purposes of taking a delta (stock 'incremental' differential) OTA update as update engine builds all data by combining the 'differential' update data with current (previous OS) slot data...

Nb. Devices are not normally shipped with an OS installed on second slot; it's loaded with app optimisation data for one-time use with opposite slot when user first boots and configures devices... This data is completely overwritten with the first OTA update.

Well done...

Nb. When you want to update and try to dump the newer boot.img (I suggested ways to do so in post above) for rooting (or locate updated ROM online), you should be able to restore images simply using Magisk Uninstall, Restore Images option next time as long as you haven't reinstalled DreamLand or any other mod that writes to partitions included in OTA updates...

Nb. 2. Using 'Install (Magisk) to inactive slot' method for seamless updating with root preserved may still be fraught due to new Google post-boot partition digest checks or other changes that break this in newer devices...

Updating after fully un-rooting (ie after rebooting) should go smoothly however... Dumping boot.img should be your next challenge...

Pleasure... All best with it. 🤠 PW
[Magisk] HippoMan:
Thank you. However, in the SuperUser tab, the only apps which are shown are those which already have superuser permissions. Therefore, the only toggling which is permitted is to toggle apps' superuser permissions to off.

Remember that this is the Stone-Age version 23.0 of Magisk, not some newer version which might show all apps -- whether or not they're superuser-permitted -- in the SuperUser tab.
[Magisk] newbie1113:
@pndwal I successfully applied the ota. Now root is gone. But still I cannot get rid of the dm-verity corruption. So isn't there any way to disable or bypass it because everything seems ok from my side even though the system partition has been altered in some way by dreamland. (Lol i used to think that magisk modules are supposed to revert everything back to normal after removing them)

It would be much easier to extract the boot.img with a custom recovery but since this is a A/B device it doesn't have any recovery.img. So idk how can i build a twrp for this thing, somewhere i read in these devices the recovery.img is inside the boot.img. So, long ago i tried and patched stock boot.img with magisk then use carliv image kitchen to build a new boot.img (out of it) but it refused to flash with some error (which i don't remember)

I have no idea how to extract stock boot.img without a custom recovery.
[Magisk] HippoMan:
Thank you. As I mentioned above, the renamed/repackaged app doesn't show up in Settings.

However, I followed your advice and long-pressed the renamed app's icon in my launcher (Nova7), and I was then able to see its settings entry by selecting the "info" item that was offered.

All normal settings are already set to "Allow", but also, an addional "Advanced" setting is shown: "Install unknown apps". That setting was disabled, and I enabled it. I then rebooted, just in case, and afterwards, the renamed/repackaged Magisk started properly offering the root-enabling pop-up when a new root-requesting app is installed and opened for the first time.

So, apparently that "Advanced" permission is needed ... either that, or more likely, I think the mere enabling of any setting might have caused the app's state to be somehow reset or cleaned up.

Thank you again (!!) for alerting me to the fact that I could get to an app's settings via long-press.

Problem solved.

Excelsior!
[Magisk] HippoMan:
Thank you for all this. It increases my understanding, and is very helpful!

As you can see from my message above, I solved the problem once I learned how to access the renamed app's settings and then toggled an Advanced setting to "Allow".

I'm guessing that this reset the app's state in the same way that your manual procedure would do.

Thank you again!
[Magisk] pndwal:
Possibly fixed by permission related changes, but I'm wondering if you actually completed stub installation (Hide the Magisk app) this time with custom channel set for archived 23.0 Magisk per 23.0 stable JSON...

If this is the case you should see that stub version 21 is now installed rather that 33, and this was the real fix...

If you still see App Installed = 23.0 (23000) (33) on Magisk App home page, the issue was not the later stub app and the fix was other... Please let us know... 👍 PW
[Magisk] pndwal:
So updated system is booting from new slot it seems (?)... Please say how/where you see 'dm-verity corruption' showing...

... I thought you reflashed one slot with older ROM, then took OTA and changed to other, no?... If so, DreamLand patches to /system_x (x is flashed slot) would be gone and that partition should be stock again...

Well no... Makes backups and restores partition(s) Magisk patched, but it can't know what changes you made using unrelated mods. 🤪 ... And it's covered here too:

https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md#ota-upgrade-guides

Yup, boot_a/b.img contains recovery ramdisk (except on some a/b devices like OnePlus that sport dedicated/recovery_a/b partitions) and TWRP etc are built to reside in /boot in these cases... You must know what your doing with partition tables and can't simply port another devices twrp or you risk corrupting many partitions...

That's why I suggested to you ways that don't involve custom recovery, ie dumping it with root in older OS/slot, or booting with older patched boot image which may well work well enough to let you find the backup of proper updated boot.img Magisk makes... Personally I'd be pulling customer recovery building in the too-hard basket! 😜 PW
[Magisk] newbie1113:
It just appears as i reboot/switch off-on my device then the phone keeps on turning on-off with the same message until i press power button then to boot the device then long pressing the volume down key i am able to boot my phone.

No what i did is just simply uninstall magisk and restore images (i did multiple times maybe thrice just because magisk was still showing as installed, however in the youtube tutorial that i followed the guy also had it showing as installed so probably magisk doesn't instantly remove root with the restore image option). After the ota is installed it asks to reboot now but then i go to magisk and install it to inactive slot and rebooted it from there. Everything was supposed to work fine just that dreamland modified the system partition and that's why i got dm-verity corruption.

Anyways i will not take any risks right now as i have my exams nearby, i will try to fix this crap once my exams get over.

Anyways thanks a lot. See you later.
[Magisk] Vovan2k:
After patching boot.img with magisk 26.1 it returns empty file 0 KB in size.

Its under CarbonROM,

Spoiler content hidden.
[Magisk] HippoMan:
Yes, I did start seeing (21) after I switched the channel, un-hid, re-hid, rebooted, reinstalled (direct), rebooted again, etc., and the (33) reference disappeared.

But even then, the root-granting pop-up still didn't appear after installing and opening root-requesting apps.

But when later I did the other thing with the settings, that fixed it, as I reported.

My guess is that it wasn't that particular advanced setting per se which fixed it, but probably some sort of standard reset or clean-up process that takes place whenever any new settngs (perhaps just advanced ones) are enabled.

In any case, all's well that ends well, and thank you again!
[Magisk] J.Michael:
You should download a ROM and confirm that you can install that ROM and it runs properly. Then you should extract the boot image from the ROM you downloaded and use that boot image, knowing that it is the boot image being used by the unpatched system.

If it is impossible to find a full, downloadable, ROM corresponding to the updates, and you want to have Magisk, I say do not try to update.

(If you can get to the point where one slot has the old system with Magisk, and the other slot has the updated system without Magisk, then, as @pndwal said, you can use the old system to read/dump/capture the boot partition being used by the new system.
[Magisk] J.Michael:
There's an issue on Github describing failure to hide the Magisk app when the Magisk app does not have the Install Unknown Apps permission. Maybe the hidden app also needs the permission to complete its own installation.
[Magisk] HippoMan:
That seems plausible. Thank you.
[Magisk] pndwal:
... Just looked back at your posts and seems 'hidden app didn't start properly until set Alow install unknown apps'... Of course you need this to sideload apps, so I think original v21 simply hadn't installed until you set that properly (so you still had v33) but after installation actually worked with Custom Channel set to archived JSON for 23.0 Magisk/21 stub, things started working as expected again...

I'm still pretty sure the fact old Magisk allows stub app to be updated to a later (mismatched) version due to use of latest update JSON is the underlying issue...

It would be an interesting experiment (now that you know how to fix) to set channel back to Stable, un-hide and hide app again and see if you get this again/consistently with mismatched (33+) stub... In my experience the inexplicable use of latest stub with archived Magisk builds (occurs with pre 26.0 builds) has always caused various issues. 🙂 PW
[Magisk] HippoMan:
I'll try that test in my not very ample spare time.

Thank you!
[Magisk] HippoMan:
PS: I ended up having some unexpected spare time, so I tried that suggestion. The problem never recurred.

And before that, I turned off "Allow install unknown apps" for the renamed/repackaged Magisk, and the problem didn't recur, either.

And at that time, I even uninstalled Magisk, reinstalled it, set the custom 23.0 channel, and then did the rename/repackage without setting "Allow install unknown apps", and the problem didn't recur, either, even after repeating the direct Magisk reinstall procedure.

And now I'm running with "Allow install internal apps" turned off, and everything is working fine.

Therefore, I'm sticking with the hypothesis that my problem had been caused by the internal state of Magisk 23.0 having somehow gotten corrupted, and that my original setting of "Allow install unknown apps" simply may have resulted in this internal Magisk state being reset or cleaned up as part of the standard Advanced-option altering procedure.

This proposed internal corruption might have been related to the "33" versus "21" issue, which never showed up again after doing any of these things that I've described here.

In any case, I don't have time (nor much interest, I confess) to do further digging or investigation concerning this issue for the time being, and I'll just accept my "All's well that ends well" conclusion and move on.

But at least I have a better understanding of this issue and of the Stone-Age Magisk 23.0 now.

And thanks again to all of you for your valuable help!
[Magisk] DawoodSahi:
That's exactly the issue here. All the modules just get unmounted. Like magiskhide hides magisk itself and root/other functions are lost.

I've a nexus 5 device too. Just tried on that, rebooted and now magisk is gone. I'll try the magisk mouting method from recovery now.
[Magisk] cohiba90:
I am with V9 and it is impossible to hide magisk.

Why is that?

Thanks
[Magisk] Didgeridoohan:
D'uh! Of course, should have thought of that. And the results are interesting. I'm attaching both magisk.log (from a few minutes ago) and last_magisk.log (from a couple of hours ago).

They are quite different, but there was no difference in the procedure of the reboot and with Magisk the only difference was that I had tried adding and removing a couple of apps from Magisk Hide between the reboots. After both reboots I had perfectly functioning Magisk and root.
[Magisk] Abhi142:
Can anyone tell me how to install on android 7.1? Thanks in advance

---------- Post added at 10:50 AM ---------- Previous post was at 10:45 AM ----------

Will it work? If yes then link plz
[Magisk] Maxamillion:
Does any one know how to bypass safety net with Xposed activated
[Magisk] putridfoetus:
Wow all three logs are so different in the magiskhide sections, I really have no idea lol. Far as I can tell, the only difference in our setups is the kernel. Wonder if that makes any difference with magiskhide...
[Magisk] Warkeyx:
How to login on snapchat using magisk hide