yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Covered, but just wanted to add that while methods for Magisk Installation (especially initial install) on modern devices have certainly become more complex due to device architecture changes, John has only been keeping up with / accomodating current needs. Patching method is very much needed were TWRP support is lacking / broken / impossible. Ramdisk support is actually ALWAYS needed to install Magisk, but where support for Ramdisk in boot partition is missing (and Magisk is Installed in Recovery partition ramdisk), installing from Custom Recovery has NEVER worked. Devices with ramdisk in custom partitions (eg Huawei Ramdisk partitions) also require new methods.

John Wu himself takes pains not only to update, improve and keep Magisk device compatibility way ahead of practically any other software solution (currently supports any device with unlocked bootloader from Android 5 to present), but also to keep anyone interested informed about progress / what it means / how it works / how it affects existing users.

Of course, many changes have had to be introduced to add compatibility with so many changes in OEM system architecture, as well as Google's requirements to move to higher API levels. But, as stated, John has purposely retained legacy Custom Recovery zip Installation support for devices with compatible TWRP (Nb. latest v. 3.5.2 does not yet support Android 11+). But he states:

https://topjohnwu.github.io/Magisk/install.html#custom-recovery

Regarding challenges overcome making Magisk compatible with evolving Android architecture, see:

https://topjohnwu.github.io/Magisk/boot.html

This lists four distinct Android Device types using various Boot methods, the first being "Good old legacy ramdisk boot", the next three requiring major innovation to accommodate System As Root, A/B partitions, Dynamic Partitions, Two Stage Init, USES_RECOVERY_AS_BOOT, Recovery partition ramdisk only, etc. Great technical read.

Incidentally, for anyone interested in general Magisk history:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-83707709 PW
[Magisk] pndwal:
Yes, at present time in combination with Universal SafetyNet Fix Magisk module, and, if Rom does not include a Google Certified fingerprint, MagiskHide Props Config module w/ a certified fingerprint selected.

Someone else?

Works fine if checked in MagiskHide list. (May need to clear data after hiding root.)

PW
[Magisk] pndwal:
Good advice above.

New Magisk App is not compatible with old Magisk Manager. It should be unhidden (restored) or removed before new App is installed.

https://topjohnwu.github.io/Magisk/releases/22000.html

Your general Magisk settings / modules etc will be preserved if you do it afterward too (remove App AND Manager if both installed before new Install), as uninstalling Manager / App only does not remove these from data/adb/ 👍 PW
[Magisk] pndwal:
Don't know the app, but generally:

Check you have full SafetyNet pass. If not, see my post above:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85013583

Check Google Play Services as well as your app is in MagiskHide list. If not, toggle MagiskHide off then on again in Magisk App Settings and check again.

Next, clear your apps data (to reset flags) and try it again.

More here:

https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot# 👍 PW
[Magisk] ValeV008:
Thank you, I did that and it works like you said. :)
[Magisk] Elmarigo:
On my my Galaxy A40 Magisk shows "A/B" as "No", despite the phone being partitioned as A/B (but with B partition unused).

I wonder if that's the reason, why te last Magisk update killed my phone into a state, where only an complete Odin stock reflash could recover.

Not even restoring the all partition backup I had through TWRP could help around the issue.
[Magisk] 73sydney:
Just a quick FYI, when i tested the most recent Proton for Pixel 2XL, it did not pass SafetyNet

Dev is aware. (Dev is also dev of https://xdaforums.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/ , which is built into his Proton ROMs and now built into others as well)

The older build: proton-aosp_taimen-ota_11.3.3.zip did pass fine, and from memory it passed out of the box, no fiddling needed, other than the standard install of the latest version of Magisk (v23) and Magiskhide toggled on in Magisk Manager > Settings.

You can grab the previous 11.3.3 taimen (Pixel 2XL) builds (G-Apps included or G-Apps free) here:

Releases · ProtonAOSP/android_device_google_wahoo

Contribute to ProtonAOSP/android_device_google_wahoo development by creating an account on GitHub.

github.com

OR

Dev has a web based installer (Chrome best) here: https://protonaosp.kdrag0n.dev/install/web/

Though ive never used it, so i cant tell if you that earlier 11.3.3 is a choice via that method.

If you get stuck either way, manually, or via the web installer, reply in the Proton thread.

I used 11.3.3 for a long while, and waiting for the dev to fix the recent issues before i go back to it
[Magisk] beejkitsune:
I've searched the thread to no avail and wondered if anyone could advise.

After updating to the latest version, upon rebooting my phone gets stuck at "Phone is starting" message and doesn't progress further no matter how long I leave it. I had to then flash the original boot img and even trying to flash a patched img, I still get the same error message.

My only other resort would be to completely wipe and start from fresh but if anyone could suggest something else I could try first I would be very grateful. TIA!
[Magisk] 73sydney:
Which device are you using?

What ROM?

Custom recovery?

How did you get the original boot img?
[Magisk] beejkitsune:
Apologies, should have mentioned that. Pixel 5, stock ROM and latest security patch (May 2021), stock recovery and I got the original boot IMG from developers.android.com.
[Magisk] 73sydney:
Okay so from the stock ROM (im assuming its similar to my stock Pixel 2XL one), youre using the boot.img from inside the nested image zip inside the main stock ROM zip and not the bootloader image in the main zip?

Have you tried flashing boot.img to both slots?

In fastboot mode...

fastboot flash boot_a boot.img

fastboot flash boot_b boot.img

Beyond that nothing is really rattling around the old brain pan here after 19 hours of being awake, and im about to head to bed as its just hit 6am here
[Magisk] beejkitsune:
Yeah, I've tried that as well but the same issue. I'm thinking I might just backup and wipe all data. Thanks for your suggestion regardless!
[Magisk] pndwal:
Source of boot.img used is a concern.

Please consider downloading complete currently used ROM and extracting image(s) to ensure they are a proper match as per official Installation Instruction method. Nb. mismatched boot.img may still work, but often with issues such as wifi problems, etc.

Could be recovery.img has also become corrupted, especially if Magisk App on your device shows Recovery mode option.

Extract image from current stock ROM package and flash from PC using fastboot just as for boot.img. This often fixes 'Your system is corrupt' and other similar errors.

More details:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84944727

Hope it helps. PW
[Magisk] DiamondJohn:
I am subscribed to a Magisk module developer thread, which to my annoyance (mostly due to the new forum interface) I cannot find right now. Does a anyone have the link to the developer thread handy?

Spoiler content hidden.
[Magisk] Tlamaki:
anyone else finding the latest update (23) super laggy? Even the power menu es very laggy, is there a way to downgrade to 22?
[Magisk] Tanvir Rezwan:
Its not pubg also my system gets lagged without restart my device with in 24 hours.. And then my system ui is not responding showed

My module iam using are

In the ss
[Magisk] 73sydney:
The Pixel official ROMs have a zip which contains some files, including bootloader, and then a nested zip which contains all the img files, and he was definitely using the correct boot.img file

main zip:

nested zip within main zip, containing all the img files

Its one thing i really like(d) (because of course the Pixel 2XL is now out of support) about the stick ROM, it was simple to get at the various img files if you borked something, none of the payload.bin nonsense :)
[Magisk] 73sydney:
My first thought: bin the LSpeed module

Ive never met a "speedup/optimizer" script or module or app yet post-Marshmallow that does anything but make a device slower, warmer or chew more battery

My second thought is always going to be: bin Xposed :)
[Magisk] Didgeridoohan:
This the one you're looking for?

https://xdaforums.com/t/announcement-help-thread-assistance-for-magisk-module-developers.3846678/

(I don't have an answer for you, I've never played around with that stuff...)
[Magisk] DiamondJohn:
Yep, thats the one. And ironically. I was the last person to post on the thread! :LOL:
[Magisk] Danny94:
Can you please help me getting root passed on my stupid bank app. This guys trying annoyingly hard to destroy my nerves...

Raiffeisen-ID – Apps bei Google Play

Raiffeisen Online Banking – einfach, schnell, sicher!

bit.ly

When i open it, i instantly got redirected to a webpage which claims im rooted.

RootbeerFresh, SafetyNet Test, magisk all report im "not rooted".

No clue what this app is checking...
[Magisk] e33et:
Hello, I've got a strange issue, my fingerprint scanner and pattern lock worked fine on stable v22.0, but after I updated to v23 it's start to behave itself strange if I had pattern and fingerprint as my security lockscreen, it wont boot up proberly, it just boot to the lockscreen and then reboot itself. and if delete locksettings files in TWRP recovery then it works fine without phone's security. Is there a known bug or issue with the new version? I've got OneUI 2.5 android 10 Exynos [SM-N960F] rooted with boot.img
[Magisk] Jonas336ts:
Are you able to use adb or fastboot, if so, then just flash a ROM to your phone with your desired modifications.
[Magisk] Didgeridoohan:
From what I can see it's detecting the Magisk app, even when repackaged and hidden. Seems to be more and more common... Solution, for now: freeze or uninstall the Magisk app when you need to use Raiffeisen.

Edit: if freezing uninstalling works you can very likely use an app like Island or Shelter (open source, yay) to put the app in a work profile to prevent it from detecting other apps.
[Magisk] pndwal:
Issue will probably prove to be Universal SafetyNet Fix module which is known to break biometrics and other functions on heavily skinned ROMs, especially Samsung One UI.

A test SafetyNet Fix module is linked in a pull request thread. It tests "Shim the keystore service instead of replacing it", and is designed to test the following scenarios and issues:

- 32-bit ARM devices

- Heavy OEM skins

- Samsung One UI

- MIUI

- Broken biometric authentication in apps

- Unstable system (i.e. rebooting and/or crashing)

https://github.com/kdrag0n/safetynet-fix/pull/13

Download link:

https://github.com/kdrag0n/safetynet-fix/pull/13#issuecomment-767863635

This test module will likely fix your issue, but doesn't always work because of this:

https://github.com/kdrag0n/safetynet-fix/issues/33

Other solutions (eg. users have binary patched and used keystores from various Samsung devices) are found in closed issue threads for USNF, some of which are linked from that pull request thread including a number of modified USNF modules in this one in particular:

https://github.com/kdrag0n/safetynet-fix/issues/6

Hope this helps. PW
[Magisk] Danny94:
Thanks for your answer, freezing doesnt seem to work, it does not trigger the same "your device is rooted" problem, but another error afterwards. Probably it still detect su and magisk binary..

I dont know. I really wont completly unroot my device to use it :(.

If there is no other option i will change my bank...
[Magisk] Didgeridoohan:
If freezing it doesn't work, try uninstalling the Magisk app (you of course need to put the bank app on the Hide list first). You won't unroot by doing that and can just install the app again afterwards.
[Magisk] jenslody:
You can use a tool like shelter to create a workprofile and place the app there.

Make sure Magisk app is not cloned to the workprofile.

Works for me with DKB Tan2Go and a quick test shows, that it seems to work for the Raiffeisen app also.
[Magisk] Mew:
I'm done messing around with it.

Decided to go with a regular root method and regular Xposed
[Magisk] Alxoom33:
Congratulations!!!
[Magisk] Trel:
Ok, so I'm a little confused now.

To be clear, I'm good on everything with Magisk itself and phh's root.

If I want to use v7 and xposed, what should I be using for xposed if the systemless one is kaput?

(I'd prefer to use phh's root not Supersu)
[Magisk] negroxxx:
no update of safetynet?

Supersu 2.78 sr1

I magisk v7

Xposed 86.6

suhide 0.55

I can not play pogo
[Magisk] :
Xposed 86.2 not the magisk version works I'm pretty sure.
[Magisk] teddy0209:
Does 86.2 with suhide still work?... 86.6 with magisk and suhide works until just now...
[Magisk] Captain_Throwback:
An update broke the stuffs again.
[Magisk] :
Google going down hill, started making iPhones and now its fighting loyal users.
[Magisk] mobileman88:
Please post this in the Pogo thread.

http://xdaforums.com/apps/magisk/discussion-pokemon-magisk-discussion-t3465722
[Magisk] Rhoban:
How are the Pixel phones different from Samsung, LG, Sony etc?

Fighting loyal users? What are you talking about?

They're not trying to stop people from rooting their phones, they are just trying to stop people from using Android Pay on rooted phones.
[Magisk] nodiaque:
If it was only Android Pay that could use Safety Net, that would be a start, but more and more software are using it. Seriously, it's just a stupid fight. Why aren't they fighting Admin User on windows then? Or root user on linux? Android was suppose to be an open platform, but the more time pass, the less open it really become with all the fake safeguard getting up.

This said, it seems something changed overnight since I can't get safetynet check anymore :(
[Magisk] foongwk:
Its strange that i have not do any flashing till yesterday where i did a safety net test and passes per image and today i did a test again it was fail. Can anyone help me.
[Magisk] soder:
I think they have changed something again. Nothing you can do about it.

Also, I've read that it might be that Google's server for this is down...

/Söder
[Magisk] Captain_Throwback:
So, it seems we're back to only being able to use phh's superuser+hidesu in order to circumvent SafetyNet (as of October 13, 2016).

Magisk is tripping SafetyNet (unless you're using magiskhide).

SuperSU + suhide is tripping SafetyNet.

Xposed is tripping SafetyNet (and has been for a while).

Magiskhide would be a great solution if having a framework mod didn't bork everything (which it currently does). Hopefully once [MENTION=4470081]topjohnwu[/MENTION] has more time, he can make some updates to it so I can continue testing it. Right now, I think I have to go unrooted, since I can't use Airwatch with root :rolleyes:.
[Magisk] ataraxist:
Is airwatch relying on safetynet too?
[Magisk] Captain_Throwback:
No. But suhide and magiskhide both work to hide root from it.
[Magisk] grandpajiver:
Yup. New update, pogo won't go. Android pay seems ok. But, now my device fails safetynet checks. Sigh.

Horray for the company issued iPhone. Bleh.
[Magisk] mobil11030:
I have a 6P rooted with superuser-r266-hidesu.zip, no Magisk, no Xposed... passes SafetyNet, PoGo works, Android Pay purchase confirmed still working. Back to basics...
[Magisk] gonytj:
Realme UI2.0 facing a problem.

The current version on my phone is v22.1. I Installed the latest magisk manager v23, used direct install method to update magisk app to v23. But after installation (shows succeeded) and reboot, it's still v22.1.
[Magisk] pndwal:
Just guessing, but is Recovery mode option shown when click Magisk Install on your device? If so, how was this set? Do you have Magisk in Boot, or in Recovery partition? What does Ramdisk status (App home screen) indicate?

Other than this, please post magisk_install_log, model, ROM version etc. PW
[Magisk] gonytj:
Pls see the attachment. I saw some other guys facing same problem.
[Magisk] pndwal:
Bit further, I see factory and full OTA images available from RD1A.200810.020, Oct 2020, to RQ2A.210505.003, May 2021.

Have you definitely download latest (May) archive, and extracted and patched this boot.img?

This is important if you did an OTA update (not clear) as if so, original patched boot.img will no longer be a sure match. PW
[Magisk] Didgeridoohan:
You need to post at least the installation log.
[Magisk] pndwal:
Ok, you have boot ramdisk (& I assume no Recovery mode option).

I see there are still issues with realme / Magisk and many closed (resolved?), but yours is different in that you can boot. (Issues I can see cause boot loop.)

Other than this, can't say much without log(s), model, ROM/Android version etc, except 'interesting'. PW
[Magisk] pndwal:
Please confirm that you have wiped bank App's data (AFTER selecting it in MagiskHide list and rebooting), to clear any cached flags for various indicators of 'modified environment'.

Nb. You'll need to do wipe each time you test, both to allow for successful detection bypass, and to ensure error results are current - not cached flags from previous triggers.

You could try this w/ cache only, but likely data wipe is needed, and you will need to restore any lost settings.

Also, you may want to try removing Magisk App as suggested (you can uninstall / Install this at will without losing any settings or modules) if detection triggers errors again, but clearing data first will ensure result will be current with that also.

Lesson here is you may actually solve the basic problem and never know it if you fail to wipe apps data with each new attempt! PW
[Magisk] DiamondJohn:
I have no need to hide root from any apps. I dont do banking on my phone nor play pokomon. However, as someone who develops root apps, one thing I do note, but have not checked if it is traceable, is: The first time my app requests root, if its on a rooted device, the SuperUser request comes up on the screen, and my app patiently awaits to be allowed or denied. If there is no root, the root request comes back instantly, as denied. Now, if I wanted to, I could time how long it takes for the very first root request to respond, and assume if its not near instant, its a rooted device. I would then record that, as the next time the root request denial would be instant. It was simply a thought I had. If an app would use this technique, then the user would know, as there would be the root request window in the users face, so it wouldn't be a hidden method. Just a thought, and by the sounds, none of the posts I have seen even mention a root request pop-up on any of these apps.
[Magisk] Didgeridoohan:
It's not common, but it happens that apps use this as a method of detecting if an app is rooted. Easily circumvented by adding the app to the Hide list, making the device seem unrooted.
[Magisk] DiamondJohn:
Again, no use to me, but to clarify to others. You would have to hide the app before the very first start.
[Magisk] zgfg:
Just a question/confirmation:

If you use Magisk hide to hide Magisk from your app before you FIRST time start your app (asking for root access), then root denail should be instant (and with no pop-up to user)?

You could retest by deleting data for your app and enabling it for Magisk hide

However, your observation holds. Many users do not use hide before they first time start a banking app but they never see a root grant pop-up request, meaning that those banking apps do not use that technique (asking for root access and investigate response time to conclude is there a root or not). Besides, after deleting their data and listing them for hide, the apps still detect root
[Magisk] Didgeridoohan:
Just clear data for the app and start again...
[Magisk] pndwal:
Or clear Data as I've mentioned.

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85023487

Nb. this will actually be needed after any 'modded environment' flag is set in bank Apps data, observed or not; ie. data wipe is therefore necessary every time a user tests a change aimed at detection circumvention. PW
[Magisk] supermax:
Hi everyone

I have mi note9 lite with xiaomi.eu 12.6 version 5.12

I always used magisk with no probem

after last system udate I instaled magisk 22.1 with twrp with no errors

I installed the Magisk Manager app but it says NO MAGISK present

I try to upgrade to 23.0 with twrp with success but Magisk Manager always says not present

All previous app that needed root still works...so I think magisk is present

I tried with Terminal to run line command

magisk magiskhide status

and the answer was magiskhide is active

Any suggestion to make magisk manager working?

Thans a lot
[Magisk] pndwal:
Seems you moved from pre 22 series Magisk to 22.1 when problem began. Correct?

You really should read Release Notes before updating (Updates sometimes incorporate major changes):

2021.4.9 Magisk v22.1

This release is focused on fixing regressions and bugs. Check the v22.0 release notes if coming from older releases ...

https://topjohnwu.github.io/Magisk/releases/22100.html

2021.2.23 Magisk v22.0

RESTORE THE EXISTING MAGISK MANAGER BACK TO NORMAL BEFORE UPGRADING IF HIDDEN! ...​

... App Hiding​

Another major breakthrough in this release is that devices lower than Android 9.0 can now also use the advanced app hiding technique to hide the Magisk app. Due to this incompatible change, RESTORE THE EXISTING MAGISK MANAGER BACK TO NORMAL BEFORE UPGRADING IF HIDDEN! ...

https://topjohnwu.github.io/Magisk/releases/22000.html

As it seems you didn't do this originally, you need to locate the conflicting incompatible old hidden Magisk Manager (whatever name you assigned it), and uninstall both this and new Magisk App before re-installing newer latest App.

If this diagnosis proves incorrect, aside from my having to eat my hat, there's this:

https://github.com/topjohnwu/Magisk/issues/4174

But this unresolved issue seems limited to Samsung on Android 6 or 7 at present. PW
[Magisk] DiamondJohn:
Thnks to everyone for trying to help, but i have no issue/problem, it was basically a thought experiment/question. Sorry for any wasted time or effort.
[Magisk] pndwal:
Yes (it was relevant too), and I'm sure what a data wipe achieves is all obvious to you anyway! 😉

My comments incl. earlier post were really to alert @Danny94 and others w/ app detecting 'modded environment' to importance of wipes, not only after first hiding, but after each change while testing detection bypass methods.

This may well be obvious to @Danny94 also, but as yet he hasn't confirmed he has done any wipes since experiencing at least two apparently different types of triggering, both of which could be cached in app data, and be obscuring any subsequent fixes. PW
[Magisk] pndwal:
Man John, the suspense is killing us! 😉

www.twitter.com/topjohnwu/status/1393650963072778246

😛 PW
[Magisk] dlewando:
hi folks,

i made a magiskhide and the icon disapeared from screen for whatever reason. so i installed magisk v23. i'm not asked for root access if i request it by any app. two apps have root access so far, but i'm not able to add more now. i made some attempts to remove magiskhide from my phone, but all not succeeded.

1. flash stock boot.img

2. upgrade stock firmware to newer version

3. install magisk v23, flashed new boot.img, magisk app working but at magisk start screen there's still "n/a" at installed info.

4. magiskhide is still there, because my two apps have still root access (qick disable & qick boot app)

5. i have no root access to terminal/shell or filemenager (that's what i wanted to add)

so how can i get rid of magiskhide? or get access to old magiskhide?
[Magisk] supermax:
Hi

first of all thanks for your time

You gave me a correct solutuin.

I thought to have uninstalled hidden app but I forgot!

I unistalled both and reinstalle new an all is ak

Thank yoy!!!