yashsingh1/xdaforums huggingface dataset:
[Magisk] palmbeach05:
So if the issue has been fixed, and the vol up method is no longer needed, don't worry about it. As long as you can boot up into your rom and have magisk support, you are good to go.

Actual recovery i think translates into factory/stock recovery. Bottom line, custom recovery trumps stock recovery all day
[Magisk] Didgeridoohan:
I managed to find version 1.10.2 of that app to test and have no issues hiding root from it (unless it also checks at other times than at startup)... On Android Pie, Canary release 19307, with hidden Manager and the app on the Hide list. Nothing fancy...

You might have something else about your setup, that Magisk can't hide, that's triggering the app.
[Magisk] ale32thebest:
Thanks for the info! I will try to disable modules/format my phone, thanks! I'm actually using a custom rom based on LOS, I hope it is not rom related as I really like the one I'm on right now
[Magisk] Didgeridoohan:
The ROM being the culprit would actually be my first guess... Could of course be something completely different.
[Magisk] ale32thebest:
I just did some test, with latest canary if I have magisk manager with a random package name and I disable the module I use to apply the theme overlay it does not detect root, so it looks like the module touch something that breaks root hiding for that app, I will try to send an email to the theme developers, hope they could do something about that, the theme I use is "swift installer" but unfortunately it's a paid app :/ the module should be open source tho, anyway I will send an email to them

Edit: disabling and re-enabling the Swift installed module gave me a situation when I have the theme and the app works due to root being correctly hidden??? I'm a little confused but happy with that, looks like removing and adding the module again fixed everything
[Magisk] eierfrucht:
Well my current experience with my setup is super positive for like 99,99% of the time, but every time I need to do a clean factory reset / wipe data and/or caches, I need at least stock recovery. If not being able to boot into Stock Recovery is a trade-off for "no longer need to boot with Volume Up", I'm fine with it. But I just thought it might be a bug.

Exactly. A Magisk-patched stock recovery is meant to check -- at a very early point into the boot process -- if Volume Up is still being pressed. If it is, the regular codepath is executed and you basically get into Stock Recovery. If it's not, Recovery GUI is skipped and Magisk & OS are chainbooted. My Magisk-patched Stock Recovery now always chainboots Magisk & OS with no chance to pause and actually show up the Recovery GUI...

I tend to agree, but... Firstly, I was very lucky to grab a TWRP customised to run well on the combination of my particular device & Android Pie, I grabbed it from a cheesy Google Drive link in a forgotten thread... Not every combination of Huawei device and Android version ever gets enough TWRP love, mostly because Huawei are being dicks and no longer provide Bootloader Unlock Codes, and the unofficial providers all went belly up a while ago. This kinda averts the community from dealing with Huawei.

Secondly, Magisk on EMUI9 devices can only reside inside the Recovery Partition, and Magisk Manager does not provide an option to embed Magisk into a TWRP image. So you basically have to flash TWRP every time you want to **** around with your phone then flash back the Magisk-patched stock to continue using your phone. I'm well aware of the fact that as of July '2019, you can flash almost any .zip using FK Kernel Manager's "Manual Flash" feature, with the sole exception of NanoDroid. It would throw errors as long as you try flashing it with anything but TWRP, so every time I have to update NanoDroid I'm forced to do this little dance of switching between TWRP and Magisk-patched stock...

I'd be so much obliged to anyone who'd point me to a guide on how to embed Magisk into TWRP on EMUI9 devices that don't offer a better place to install it.
[Magisk] palmbeach05:
Twrp has a way to factory reset. There is an option to wipe those paritions and system and internal storage. All should be able to be wiped if the twrp builder did it right
[Magisk] eierfrucht:
But you can't have TWRP and Magisk at the same time on an EMUI9 device. Magisk loader can only be "implanted" into a Stock Recovery image. Not into TWRP. Not into entirely different partition like on most other devices. There's no boot image partition on EMUI9 phones. There's only the Recovery partition, and it MUST have a patched Stock Recovery image to enable Magisk in the operating system. You can't patch a TWRP image that way (would be a fantastic thing to have)
[Magisk] palmbeach05:
Ah, ok. Thats a setup i've heard of, but never encountered before
[Magisk] myxdaaccount:
I'am having the same problem, the latest version of YAP-APP v1.10.2 is able to detect root with latest Magisk 19.3 on Optimized LineageOS v16.0 and also tested with official Lineage OS v14.1 on Samsung S4 i9505 jfllexx. The thing is I forget to save the apk of the previous version that was working with Magisk Hide, [MENTION=5194918]ale32thebest[/MENTION], could you please pass me the apk of the older version, so I can use it until they force on me the new version, hoping meanwhile somebody will find a fix?

Edit: Oh, sorry I didn't see your latest posts, I was quoting your post from the thread search (only there was the key word it.nexi.yap). So with the latest canary Magisk is working for you? I will try myself ...
[Magisk] ale32thebest:
yes, latest canary worked for me, but the culprit was swift theme module, I removed that module and YAP started working again, I also switched back to magisk stable and the app is still working fine, try magisk core only and see if it helps, I was able to use Yap with core only and then I started enabling modules one by one until I found which one gave me problems. if you still have problems message me and I will provide you the old apk, no problems (don't forget to hide magisk manager, YAP started detecting that one too with the latest update)
[Magisk] mehanik6:
Who could get root on the arm 32bit chip mt6580 android 9.0?
[Magisk] myxdaaccount:
Ahh, turning off and then on Magisk Hide from Magisk manager settings did the trick. But effect is lost on reboot, so every time you reboot, you have to turn off and then on Magisk hide to be able to use YAP app. Thanks for your reply!
[Magisk] Didgeridoohan:
Having to toggle MagiskHide off and on at a reboot is a known bug. Will be fixed.
[Magisk] BavoV:
I have problems updating to 19.3m. In magisk manager 7.3.2 I can only select download zip or select and patch a file.

As my device is an encrypted Samsung A520F, I wonder what to do best? Can I sideload the zip in twrp or would that break things for magisk. A's the device is encrypted during recovery, magisk can not update any file within the encrypted I pressume.
[Magisk] ajp_anton:
No hope for my problem with new versions? Link to post
[Magisk] JudgeDread11:
I'm sorry, but I don't know how to help you. The only advice I can give is to ask in your device forum as it seems a very device specific bug.

To help you'll probably need to submit a logcat. Didgeridoohan has a good guide on how to provide logs.
[Magisk] fulgura91:
Sorry. Wrong post.
[Magisk] rtmreza:
Hi

my device is xiaomi redmi 7 or codename : onc/onclite

I have a problem / when i flashed magisk and

i turn off phone and connect to charger the display doesnt show charging process and it doesnt turn off stuck at boot logo but when i remove root or flash stock boot.img its be ok

this picture doesnt show after root

Just show this stuck at boot logo
[Magisk] Didgeridoohan:
Here's the guide [MENTION=5993745]JudgeDread11[/MENTION] is talking about:

https://www.didgeridoohan.com/magisk/MagiskHelp

https://github.com/topjohnwu/Magisk/issues/906
[Magisk] AHE_XDA:
Tab S5e (SM-T720) - Unable To Flash Patched July Update

Key Details:

Device Model: Galaxy Tab S5e - SM-T720 (WIFI)

Odin Ver: Odin3 v3.13.1.exe & Odin3 v3.13.1_3B_PatcheD.exe

Magisk Manager Ver: 7.3.2.apk, app-release.apk & app-debug.apk

Build Date: Tue Jul 09 18:08:10 2019

Build Fingerprint: samsung/gts4lvwifixx/gts4lvwifi:9/PPR1.180610.011/T720XXU1ASG3

Filename Used: SM-T720_1_20190710151453_dv8it96bce_fac.zip

CSC Tested: XAR & KOO

Recovery Used: N/A - No form of recovery exists for this model.

Summary of Issue:

With the July update of Android 9, the ability to introduce root via Odin, after patching the necessary files via Magisk Manager-v7.3.2, fails while attempting to write 'boot.img'.

The error displayed on the tablet reads:

Only official released binaries are allowed to be flashed (boot).

Reverting to the previous month and using the same method works.

I have tested using the currently released build of Magisk, Canary and, finally, debug to capture details.

I am including a copy of the Magisk debug log for review.

If more is required, please ask and I will be happy to assist.
[Magisk] jcmm11:
Before I say anything there's a huge caveat - I don't do Samsung so don't know if this is even possible.

Try installing the July update with the June bootloader. I suspect that the July bootloader has some new signature checks built-in and if you can install the June bootloader you can install the rooted boot image.
[Magisk] ajp_anton:
Ok, thanks, I'll post there. I just thought that since 16.3 works, it might help to narrow down what changed in 16.4 that made it stop working. Didn't think logs would help, as I'm not doing anything in Magisk when the problem occurs.
[Magisk] smartfaune:
Couldn't install Magisk on a Pixel 3a ...

Hi everybody,

Today I got a new Pixel 3a

1st thing was trying to install Magisk, scrupulously following the indications I found here:

https://android.gadgethacks.com/how-to/root-your-pixel-3a-with-magisk-0198663/

but It didn't work at all...

Method 1 gave me a loop on reboot at the end of installation

Method 2 gave me an error message asking me to either "Try again" or "Factory Data Reset" (pix in attached file)

Both "Try again" and "Factory Data Reset" gave nothing and I had to flash factory image found here:

Sargo 9.0.0 (PQ3B.190705.003, Jul 2019)

I also check here with same results:

https://www.xda-developers.com/google-pixel-3a-xl-twrp/

https://xdaforums.com/pixel-3a-xl/how-to/how-to-root-pixel-3a-3a-xl-twrp-t3928868

Config is :

Pixel 3a, Android 9, Magisk 19.3, Magisk Manager 7.3.2, TWRP 3.3.1-1

I also have a Nexus 5x/android 8.1 with exactly the same Magisk/TWRP configuration installed on it and I works like a charm...

I really don't know what's happening and would certainly appreciate a little help ;)

Thanks

P.S.: dmesg & recovery log in attached files
[Magisk] palmbeach05:
Did you encrypt your device at all?
[Magisk] smartfaune:
It's a brand new mobile with factory setup

I guess encryption is on by default as it is also in my Nexus that works perfectly with Magisk
[Magisk] Gravs:
Is there a fix for wifi breaking after installing magisk?

Using LineageOS on Samsung A320FL.
[Magisk] boogiepopfred:
Magisk Manager keeps "uninstalling" itself like once a day, in the sense that I lose Superuser functionality and if I open the Magisk Manager app there's a message saying "Magisk in uninstalled". Re-patching the boot file from recovery is the only way I've found to restore funcionality. This is on a rooted Android 9 device.
[Magisk] guest4711:
When running it on your local device you should omit "adb shell". You may put your commands into " service.sh" in your magisk module.
[Magisk] wilsonhlacerda:
Go to the Magisk Github and read the documentation, specially the boot stages section. It is short and not complicated.
[Magisk] ilsaggio73:
ok

the "hide" function does not work with this bank app

https://play.google.com/store/apps/details?id=it.gruppocariparma.nowbanking
[Magisk] Jay lalwani:
error executing binary

pls help me guys i am getting this error "Error executing binary in zip" while installing magisk through twrp on resurrection remix 7.1.2 5.8.5 final rom pls guys.
[Magisk] wilsonhlacerda:
Ok. Read this link and other threads about root hiding, banks,.....

https://www.didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps

And first of all try the app with a clean device, with only the ROM you are running and default settings, to be sure it is not ROM related. Then step-by-step go changing/adding your settings, apps, then Magisk core only, then finally your Magisk modules.
[Magisk] Didgeridoohan:
Sounds like your version of TWRP isn't up to the task. If you can, update it. If you cannot update it you might have to go the "patch boot image" installation route.

Either way, providing the install logs is always a good idea.
[Magisk] smartfaune:
Could Magisk 19.3 (released on june 5) has been broken by Pixel 3a's last security patch OTA update (released on july 5) ?
[Magisk] Didgeridoohan:
Don't think so, as it seems others are rooting it just fine:

https://xdaforums.com/pixel-3a/how-to/root-3a-t3929053
[Magisk] boogiepopfred:
Couldn't find anything about this on the Troubleshooting guide.

This has been happening every few days for a month now, the only way to fix it is to repatch the boot file from recovery.
[Magisk] Didgeridoohan:
Made a few additions to make it easier to find, but here you go:

https://www.didgeridoohan.com/magisk/Magisk#hn_Randomly_losing_root
[Magisk] boogiepopfred:
Thanks a lot, I have disabled battery optimization for Magisk Manager and hopefully that will do the trick.
[Magisk] m saif khan:
Docomo f01f
[Magisk] paarnoutse:
As additional info to prevent that Magisk Manager may be killed:

Some devices (especially OnePlus, Xiaomi and possibly more) have implemented specific and aggressive additional 'features' to improve battery life, which may kill background processes *even* when Battery Optimization for the related app is disabled. To prevent that apps running in background (like Magisk Manager) would be killed at such devices, you *also* need to 'lock' them in your Recent Apps list.

For more info see https://xdaforums.com/showpost.php?p=78588761&postcount=7

(which describes same solution to prevent that Titanium Backup schedules may fail, because it may have been killed at such devices for same reason when not 'locked').
[Magisk] wilsonhlacerda:
If running some kind of Xposed, the module Eternal Process Lock may be of interest:

https://xdaforums.com/xposed/modules/mod-eternal-process-lock-v1-0-t3797243
[Magisk] paarnoutse:
Sorry, but in my opinion not a good idea to start using a method that may cause much of other problem (eg. SafetyNet not passed anymore when Xposed is installed) if a simple one-time action that takes 2 seconds (just once lock the app in your Recent Apps) will already resolve the issue...
[Magisk] mkdante381:
Check if not installed on sd card memory
[Magisk] Florhoff:
Bug on S10 G973F ?

Hi. I've installed 19.3 Magisk and 7.3.2 Manger with RiruCore and Riru Edexposed 0.4.5.1 beta, for having EdexposedInstaller and modules. I've chosen Firefds P. But each time I configure it, after reboot, Magisk seems uninstalled and EdExposed doesn't work anymore. I have to restart all each time..

Is there a way to fix that? Thanks for help..
[Magisk] eliezerjk90:
You can use edXposed and still easily pass safetynet...
[Magisk] wilsonhlacerda:
But when the method is much more effective..... And there are ways not triggering SafetyNet if this is a concern (EdXposed for instance).....Well, may be useful for someone. I use it for some critical apps and works very well.
[Magisk] alvintimothyjr:
Since when?
[Magisk] Didgeridoohan:
The question should probably instead be: for how long?

EdXposed, as opposed to regular old Xposed, doesn't trigger SafetyNet. It's likely just a matter of time until Google starts looking for it though...
[Magisk] alvintimothyjr:
My apologies. I misread the comments. I thought the topic was in reference to Xposed. I had no idea edxposed existed.
[Magisk] smartfaune:
Everything is working fine now

More details here:

https://xdaforums.com/showpost.php?p=79974245&postcount=452

Sorry for the noise...

Long live Magisk
[Magisk] hackermssharma:
Magisk hide is not working in obc banking app. In older version of my bank app it is working. But the older version of banking app is forcing me to update to latest. But after updating to lattest it is detecting root and not opening. Whereas in non rooted other mobile it is working fine. I have latest magisk 19.3 + ed exposed + xiaomi.eu rom + saftynet passed. How to run the app now please suggest
[Magisk] Didgeridoohan:
I'm guessing that OBC means Oriental Bank of Commerce. If so I tested two apps from them that detects root at startup and could easily hide root from them. In other words, Magisk can hide just fine and it's most likely something about your setup that is triggering the app.

Tips and tricks on how to hide root:

https://www.didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps
[Magisk] hackermssharma:
I dont know what is going wrong ? But why the older version works and new version of oriental app bank not working? For older version magisk hide is worked fine but for new version it detects root.
[Magisk] Didgeridoohan:
They updated their root detection... Simple as that. Take a look at the link and try some of the tips there. My first guess would be UDS detection.
[Magisk] hackermssharma:
I tried the command in terminal but still the app is not allowing to access. ☹️
[Magisk] Didgeridoohan:
Then it's something else. Go through the list and try different things. You'll find what it is eventually.

You've hidden the Manager, right?
[Magisk] wilsonhlacerda:
Before test, better uninstall app, reboot, install it again. Or at least force stop it and clear data.

Read and do step by step all the tips previously suggested on link.
[Magisk] hackermssharma:
I force stop cleared the data then enters the command in terminal then i opend it again but not worked. Manager is hided from.manager setting i also tried core only mode. But non of this works

Edit - thanks man after rebooting and again hiding magisk manager. The app worked. Thank you so much man for help. ??
[Magisk] wilsonhlacerda:
Current Magisk has a bug that hide is not working just after boot. You have to toggle the Hide settings manually.

As a workaround now to do it automatically, put the bellow lines to automatically run after boot somehow (for instance on /data/local/userinit.sh if your device implement it):

#!/system/bin/sh

sleep 120

/sbin/magiskhide --disable

sleep 1

/sbin/magiskhide --enable

chmod 440 /proc/net/unix &>/dev/null
[Magisk] boogiepopfred:
Unfortunately none of these tricks have worked, I guess I'm gonna have to post a logcat.
[Magisk] zgfg:
Please read back, everyday somebody asks similar. You will find links what to read and suggestions.
[Magisk] Didgeridoohan:
Just want to clarify that this is not a universal issue. From the number of reports I would actually guess that the number of users not affected is greater than those who are. That's just a guess though...
[Magisk] pragyan52yadav:
Try hiding root from YAP from terminal

Type

Su

Magiskhide --add (app name it would be like com.something.something check app details from your phone settings)

It should work

Because it worked for me with Pokemon go

You can also try safety patch module by hackintosh5
[Magisk] hackermssharma:
Hiding magisk manager from magisk setting was worked for me.
[Magisk] Nimueh:
Coming back to this since it's still happening - with no rhyme or reason, sometimes Magisk stops responding every day and sometimes it goes 2, 4 or 6 days without issues.

I've attached today's bootlog - I had to pack it because at 758 kb XDA refused to attach it :angel:

I hope the log clears things up, I'd LOVE to squish this annoying bug :D :fingers-crossed:
[Magisk] optimizer+:
Hello [MENTION=4470081]topjohnwu[/MENTION] I have important requests and reports to make.

1. Magisk can create a folder for module downloads and magisk manager apk on internal SD card, so you can quickly delete old zip files, or quickly reinstall when installing a new rom, example: in download I have more than 1500 files it is difficult to find the zip for magisk.

2. I tried magisk uninstall in recovery, but when I tried to give terminal "uninmod" the terminal gives me command not found, but at least uninstall magisk. (Galaxy Note 9 Exy)

3. You can create an official Telegram group, even if you don't actively participate, you can have a quick chat between developers and users and maybe report problems or solve them, and then telegram is cool you can put all the rules you want. Make the community even more alive.

:cool: :highfive:
[Magisk] JudgeDread11:
Please don't, not more folders in the root of the sd please. Seems like nowadays every app needs is own folder on my storage. (Storage redirection works as a work around, but it would be nice if it wasn't necessary as it's requires a app and 2 magisk modules)

Keep stuff apps download in the download folder, that is what is there for.

Suggestion to optimizer+, find a way to manage your own files or you'll end up with not only 1500 files in your downloads folder but also 100 folders in the root of your sd card. Your suggestion is not solving the problem it's contributing to it.
[Magisk] Didgeridoohan:
1 - There's already a feature to pick your own download location upstream. Will be in the next release.

2 - The uninmod command has nothing to do with the official Magisk uninstaller.

3 - I believe John already has all the discussion channels he needs. If he wanted a telegram group, he would create one...
[Magisk] guest4711:
I have an important answer for you: This feature is implemented already. To try it you should either wait until it is in official release or

change to custom channel and put https://raw.githubusercontent.com/ianmacd/MagiskBuilds/master/updates/ianmacd.json into it.
[Magisk] optimizer+:
Honestly if you can choose I don't see why you shouldn't do it. apparently the dev have the solution ready to improve the manager, good. in any case I use 10 modules for each time you update 20 30 files are created out of 1700 files scattered in the. The need is real.

Hello [MENTION=4667597]Didgeridoohan[/MENTION]

1)... Good ...

2) I followed the official magisk uninstallation guide and the individual modules, then the guide is wrong I followed each step carefully. Even a beginner makes no mistake because the guide is simple in steps.

(see the screen..) (https://magiskroot.net/uninstall-magisk-module-twrp/)

3) My idea is that, if he wants, he can give the developers more chances to get quick answers and expand the community.

This my idea will evaluate the owner.

Greetings, good work.
[Magisk] guest4711:
That description is not an official guide to uninstall magisk. It is a description of a module made by someone for uninstalling modules...

For uninstalling Magisk you should use either MagiskManager's uninstall function (at the bottom of MM's screen) or flash the official uninstaller

from github: https://github.com/topjohnwu/Magisk/releases/download/v19.3/Magisk-uninstaller-20190604.zip

(see also https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445/post68966662).
[Magisk] Didgeridoohan:
[MENTION=7410472]optimizer+[/MENTION] You already have your answer, but I just want to add that the only official places to get downloads and information is here on XDA, on John's GitHub and Twitter, and my troubleshooting guide.

And John already has channels to discuss stuff with other developers and with testers.
[Magisk] optimizer+:
okay good job .. damn magiskroot.net seemed real official. I will follow the official channels now.

[MENTION=8010004]guest4711[/MENTION]

I have already solved the uninstaller was official it worked, I was planted in bootloop
[Magisk] jlovelo:
Viper module caused bootloop

Mate 9 OpenKirin RR 7.0.1 Magisk 19.3

All running beautifully until I installed Viper module from MM - phone now bootloops when booting from recovery (for root). I can still boot OK to system but no root. How can I uninstall the Viper module as the module settings in Magisk are not available without root? Is this possible with adb from my PC? Any suggestions? Thanks
[Magisk] feltan29:
Is magisk zip file common for all android devices. I'm using Moto g5s XT1795