yashsingh1/xdaforums huggingface dataset:
[Magisk] t3chg33k:
I am running the patched stock Android 11 ROM on Samsung S5e. While I don’t use the tab for financial apps, I still need to use it for work apps which don’t work with MagiskHide. Of course MDM doesn’t work either with Knox tripped so I need to be able to boot without root whenever needed.

In the past, I could boot without Magisk with a normal power on and boot with Magisk using the Vol+ key. However, now it seems to always boot with Magisk enabled. Is there any way to temporarily boot without Magisk when using work apps?
[Magisk] t3chg33k:
Figured it out. After flashing the ROM, I installed TWRP from Odin to flash few patches and then reinstalled the patched stock recovery. Then I booted using the Vol+ combination which caused root to persist.

On booting to stock recovery and selecting Reboot to system, I was able to get back the old behaviour of switching between the rooted and unrooted systems based on the key combination. All’s well now.
[Magisk] Nanolo:
Ok, the SafetyNet_fix module worked like a charm, indeed thanks! :)

So, if it properly works installed in the boot partition, I suppose I could reflash the recovery that I want, without any risk, am I right?

Yes, indeed we have the same behavior about the uninstallation, except the fact that if do Restore images I don't get any error, even if i think it doesn't do anything, because it keeps on working normally..😅🤔
[Magisk] alexandarpb:
Thank you for your answer !

I am with fully functional device. All apps that have previously granted permission for root access still have it. But newer apps can not be granted.

I have not tried booting into safe mode, i have not even tried to restart the device.

I am having troubles backing up my data, (80+gb) and that stopped me from some full magisk uninstall.

For now i am having problems only with Magisk manager( app). I am having a black screen or magisk logo only when run Magisk app.
[Magisk] pndwal:
Yes, sure. But you may have no real need for TWRP if running MIUI stock, unless planning to move to a custom rom. And (as noted in my post above), stock will need to be restored to take OTA updates safety.

You don't lose root on reboot after running Uninstall? ...log should clarify what is actually found / happening.

Re. 'Xiaomi Anomaly' 🙃, here is a pull request from@Didgeridoohan for improved documentation on this:

https://github.com/topjohnwu/Magisk/pull/4130

This and other comments there may give further clarity... or not...😬 PW
[Magisk] wfred:
You have to write slowly for me 🙂
[Magisk] JimZiii:
EDIT:

Had some issues screen mirroring and solved it by adding "wlan.wfd.hdcp=disable" to build.prop

How can i put this in a magisk module and use it systemless? Does it matter?
[Magisk] Elcosomalo:
Yes sir, you are correct

Correct, now the only way to reboot into recovery in a Samsung Note 10 with the new android 11 and ui 3 is to do the key combo (same than the old one) BUT you need to do it with usb C plugged.

Yes, but it doesn't work like that anymore. After the update to android 11, you need a USB C connected.
[Magisk] valunthar:
running into a bit of an issue with magisk currently. I installed a magisk module that didn't agree with my phone (pixel 5 running lineageoS) and my phone is currently stuck in limbo where it keeps trying to load the phone and eventually fails back into recovery. I've tried several different methods to try and recover it, from safe mode, to adb shell, to switching from lineage recovery to TWRP but nothing works. the phone is currently stuck on the TWRP splash screen with no other movement. Is there any way to recover the phone without wiping the data?
[Magisk] zputnyq:
Probably manually removing / deleting module could help. Most modules location is in /data/adb/module, you could go there by using recovery's file manager if ther's any then delete the module.
[Magisk] HippoMan:
But the phone is stuck on the recovery splash screen, according to the poster. In this case, there is no way to use any file manager, neither in recovery, nor in Android itself.

PS: I wish there was some sort of file manager which could be booted into directly from the bootloader via "fastboot".
[Magisk] valunthar:
yes that's correct it's currently sitting on the twrp recovery screen and has not moved since I made the post. I can still access adb thankfully so I do have some options, should still be able to get into fastboot as well assuming I can get it to recognize the command. I read somewhere that in theory reflashing a patched boot.img would remove all magisk modules and let me boot into the system. Is that correct? if so what would be the best way of doing that especially since I can't patch my own image currently due to the phone being out of commission.
[Magisk] pndwal:
If you've tried everything applicable in this wiki:

https://www.didgeridoohan.com/magisk/MagiskModuleIssues#

especially 'Disabling/uninstalling modules manually' options, simply reflashing unpatched boot image extracted from LOS package (use PC / fastboot) will likely recover device (root is removed, modules won't load, etc).

Data won't be affected. Even Magisk settings / modules will be preserved / restored when root is restored, as these are all in /data.

In case you have Direct installed Magisk (or patched image) from Magisk App with Recovery mode checked, restoring unpatched recovery.img will also likely help. 🤠 PW
[Magisk] pndwal:
As I mentioned above, I'd flash UNPATCHED images.

I'm guessing you have Magisk in boot ramdisk, not recovery, but either way I'd try flashing both Recovery and Boot images to get access to System, then remove problem module(s) using a removal method from wiki. PW
[Magisk] pndwal:
Well, actually there is if you have a compatible TWRP.

You can fastboot boot TWRP.img (not flash) and use TWRP file manager.

This could be another option. Thanks for the reminder. 👍 PW
[Magisk] zgfg:
Three options, starting from the simplest:

1) Install Magisk Hide Props Config module (from Repo, it has also its thread on XDA).

Run props command from a terminal app, choose option 4 (Add/edit custom props) and follow the command line instructions to set your prop: wlan.wfd.hdcp to the value: disable

2) Use a root explorer like MiXplorer (or do it from TWRP if applicable for your device), go to /data/adb/modules and create a new folder, name it like jimzii (choose a name you like) and put inside a text file system.prop (exactly as that).

Into that file put the line:

wlan.wfd.hdcp=disable

Reboot and Magisk app (former mngr) will show that you have Magisk module jimzii installed

3) Read Magisk Documentation from Github, Developer Guides, Modules chapter to learn how to turn (2) into the jimzii.zip file flashable as a Magisk module
[Magisk] JimZiii:
Thank you. Since the second option should basically be the same as an installed module I'll go with that one for now.

Definitely gonna have to look into magisk hide props config, might come in handy
[Magisk] valunthar:
Thank you that solution worked. however i'm having a bit of trouble removing the problematic module, in the sense that I can't find it, any ideas on where to look or how to clear the module config without magisk being enabled? the magisk app loads fine but the option to clear the modules isn't there. i've also searched my data folder for anything related to adb,modules etc with no luck. I was using magisk hide before so that's likely part of it. Also I know there's something still left over as once I got back in I did try reflashing with a new patched version of the boot image but I ran into the same bootloop issue as before.
[Magisk] pndwal:
Have you tried methods in wiki under 'Uninstall/delete/disable modules from recovery'?

Nb. You will still need to do this before restoring root as modules won't show in App / App can't access modules in /data/adb without root. And of course, as the bad module is still installed, you will have issues if you re-root without removing it.

Nb.2. You originally asked "is there any way to recover the phone without wiping the data?", and I gave you the best solution for this, but it still won't fix the bad module, although, of course, a factory reset would (since it resides in /data )!

If you haven't, I'd probably boot only to twrp (unless you've already flashed it) as per my last reply above, and use the first method listed, or third (delete folder) as a last resort.

Did you find the specific module folder in /data/adb ?

If the worst comes to worst, you could backup all your data / media now that you have bootable device, factory reset, and then root and restore your data. 🤠 PW
[Magisk] HippoMan:
Yes, I know. However, there are cases where even fastbooting the TWRP image causes a crash or a bootloop. In those instances, a plain, garden-variety file manager that is bootable via fastboot could be quite useful.

PS: I also would like to see a DFE module that is flashable via fastboot. This way, a system where A11 and TWRP were installed without DFE could potentially have its resulting bootloop eliminated, simply by installing this hypothetical fastboot-flashable DFE module.
[Magisk] pndwal:
I don't really have a proper understanding of things-encryption, except from likes of the three articles linked from this summary:

https://source.android.com/security/encryption

However, it seems clear that the only encryption available in Android 10, 11 (&12DP) is FBE (w/ or w/o Metadata Encryption).

John say's he already disallows Keep ForceEncrypt on FBE as it won't work:

www.twitter.com/topjohnwu/status/1297833910320021504

Wouldn't this mean that where A11 and TWRP were flashed without DFE, ForceEncrypt has effectively been disabled upon rooting with Magisk (I'm assuming Disable ForceEncrypt and disallowing Keep ForceEncrypt are effectively equivalent), at least using any Magisk build from 21000?

Just guessing again, but since formatting data partition is also required to remove encryption, wouldn't doing that therefore work / recover from bootloop?

Also, given the above, can applying DFE WITHOUT formatting data fix bootloop anyway? (ie. could this method help recover user data?)

Please let me know what I'm missing here, as I sorely lack practical experience with encryption settings. 😬 Ta, PW
[Magisk] zgfg:
Find the attached JimZii.zip as a flashable module

You can edit description files README.zip and module.prop

system.prop contains your prop (re)definition, you can add more changes

Leave the META-INF folder as is
[Magisk] Nanolo:
Ok, good to know that I could without any particular risk..Yes, it would be nice if was be able to install OTA without doing anything, but seen everything, I'd be surprised if this will happen..😅

Exactly, when the restore finishes, after reboot, everything is as before. Thanks, I'll post the log as soon as I can and give a look at the docs! Have a nice Sunday everybody in the meanwhile! :)
[Magisk] HippoMan:
Well, the procedure for using DFE is to install TWRP after formatting data, install the A11 ROM, install Magisk, and install DFE. If someone has already done the first three steps and ends up in a boot loop, a flashable DFE via fastboot could (theoretically!) complete the process and perhaps could eliminate the boot loop.

If the initial format of data was not done, it could possibly also be done as as an option of this hypothetical fastboot-flashable DFE module. Of course, the user's data would be wiped out, but people should be in the habit of backing up before trying any kinds of ROM and Recovery flashes, anyway.
[Magisk] HippoMan:
Hmm ... I'm wondering ...

If someone gets into a bootloop because of flashing an A11 ROM along with TWRP -- without DFE -- could perhaps a different Recovery module serve as a temporary way to get into the device and fix it?

For example, in this case, could someone perhaps do a "fastboot boot orange-fox-or-some-other-recovery.img" and then clean things up with this recovery's file manager, install DFE, possibly format the data partition, etc., before simply booting back into system? If so, would the earlier installation of TWRP still be intact and available for future use?

Note that I'm suggesting "fastboot boot" in this case, and not "fastboot flash".
[Magisk] HippoMan:
Oh, this doesn't work. My "testing" device is a OnePlus 7 Pro on which I have now got OOS 11.0.0.2 running with DFE and TWRP 3.5.2_9-0. It can boot in and out of Recovery just fine from the advanced restart menu, as well as being able to reboot to System.

However, if I go into the bootloader and run "fastboot boot twrp-3.5.2_9-0-guacamole.img", it just hangs at the "Fastboot Mode" splash screen.

If I try the same with "fastboot boot OrangeFox-R11.0_5-Unofficial-guacamole.img", I get the same behavior.

So, at least on my device, "fastboot boot some-sort-of-recovery.img" does not work when A11 and DFE are installed. My other device is also a OnePlus 7 Pro running Android 10. Doing a "fastboot boot some-sort-of-recovery.img" from that device works fine. So, this is related to DFE and/or A11 ... or at least OOS 11.0.0.2.
[Magisk] indishcurry:
hi, there are some discussions ongoing about intune company portal app from microsoft discovers root, see https://xdaforums.com/t/module-microsoft-intune-company-portal-hider-intune-hider.3780451/

edit: issues seems to be solved by hiding magisk app itself
[Magisk] ipdev:
A flashable DFE (Disable Forced Encryption) file needs to mount partition(s) to modify the encryption flag(s).

You can not mount partitions in fastboot.​

You can flash a pre-modified image with fastboot.

If encryption is in vendor, you would need to flash a modified vendor image.

Then use fastboot's erase and format commands to clean up.

Might have to replace the boot image also depending on the device and setup.​

The only way to duplicate a DFE flashable zip in fastboot would be to make a bootable image.

You would have to boot into an android environment and run the same commands as the DFE script.

This would be device specific since, the android environment would need a kernel and file structure to boot.​

I highly doubt anyone would do that, since all you would be doing is creating your own recovery just to run one script.

Who knows, someone might take it up just for the challenge. ;)

--

If you are disabling forced encryption, you would need to flash the DFE zip after you install the part that forces encryption.

I haven't used a DFE script in a while.

Normally I would flash the DFE zip (if needed) before flashing Magisk.

This way magisk should not find the force-encryption flag when patching the boot image.

Clean install: TWRP | Format Data | ROM | DFE | Magisk.

To update rom (if backup scripts run): ROM | DFE.

To update rom (if backup scripts do not run): ROM | DFE | Magisk.

Cheers. :cowboy:
[Magisk] HippoMan:
Thank you for all of this!

I didn't realize that partitions can't be mounted in fastboot mode.

I now understand why this would have to be some sort of specialized recovery program.

Well, in my not-very-ample spare time, I'll try to educate myself about writing a recovery module, and maybe some day I could come up with this.

In any case, since I can't even do "fastboot boot some-sort-of-recovery.img" when OOS 11.0.0.2 and DFE are active, maybe this hypothetical specialized recovery module wouldn't even work for solving this kind of problem, anyway.
[Magisk] pndwal:
I just don't understand why step 4 should help. ☹️

Isn't Disable ForceEncrypt now always done with step 3 (at least on Magisk builds released since John 'removed useless / confusing options' in Aug 2020) as he no longer allows Keep ForceEncrypt to be selected on FBE because it won't work?

I believe Keep ForceEncrypt would need to be enabled to cause these problems, or for DFE to fix it, but apparently John has fixed this for File-Based Encryption devices by removing the option anyway! (The option should still be there on supported legacy devices w/ Full-disk encryption)

But perhaps I'm missing something?

I'd love to know if Disable ForceEncrypt and disallowing Keep ForceEncrypt are actually two different things. 😮 PW
[Magisk] GolfislikeLife:
Hi all and here is my dilemma or problem that needs fixing. I am on Lineageos 18.1 for the OnePlus 8 Pro and not sure how it happened but lost root and now though going through all the steps with no error's can't seem to get it back. The Magisk app is on Canary 22104 but I still have N/A for Magisk though I did the process like I normally do. I have tried both booting and flashing the Magisk img file I made myself and though technically I should have root still comes back with nothing installed. Have been at this process for hours so whoever can help me I would really appreciate it. Thanks, Kevin
[Magisk] NaabKing:
EDIT: NVM, i got it to work :D I can't delete the comment
[Magisk] pndwal:
Please check if you still have an instance of hidden / renamed Manager from previous Installation.

Especially if coming from pre 21402, unhiding is critical due to incompatibility between old Manager and new App, as per release notes.

There are also issues extant causing similar symptoms to yours. Eg:

Magisk 22101 (22.+) not detected by Manager ("N/A"), but SU still working on Android 6.0 (+) Marshmallow with Samsung Note 4 SM-N910F TouchWiz, armeabi-v7a and other devices · Issue #4174 · topjohnwu/Magisk

Device: Samsung Note 4, SM-N910F, armeabi-v7a Android version: Android 6.0, Marshmallow Magisk version name: f623b98 Magisk version code: 22101 Full Magisk Version Information: f623b98 (22101) (20)...

github.com

Could be worth checking if 3rd party root checking app report you actually have root. PW
[Magisk] GolfislikeLife:
Thanks PW for your help and upon checking no previous manager installed and I am for sure not rooted for already checked with root checker basic. I also don't have any modules for I don't use them. If it helps I don't need to be on Canary for Lineageos is picky about rooting and lots of people on that thread are having troubles with root. If you could help me to solve this it would meant a lot and in the meantime I will read the link you sent me. Kevin
[Magisk] pndwal:
OK. Please say Ramdisk, A/B, SAR, as per Magisk App home screen... 👍 PW
[Magisk] GolfislikeLife:
OKay Yes to all of them and my device has both A and B partitions. Hope this is what you meant. Thanks, KI
[Magisk] Sketzu:
My magisk hide is gone after updating to latest version..what should I do?
[Magisk] pndwal:
Magisk not installed / 'n/a' is your problem!

Which build did you come from?... Direct Install to update? PW
[Magisk] pndwal:
C

Check: NO custom recovery installed?

Recovery mode NOT checked while patching?...

Bit further, what does log say when patching image? How have you obtained image? How are you flashing it?... PW
[Magisk] pndwal:
Interestingly, I saw this issue... It's still open! ... Might want to watch that space:

https://github.com/topjohnwu/Magisk/issues/4093 😉 PW
[Magisk] 3dwizzard:
J5 2016 doesn't work with magisk since version 22

I just can't install it. It gives an installation failed, unable to check signature...

The last version that works flashing is 21.1

Anything newer doesn't work.

I'm on a stock rom of Nougat 7.1.1

I tried flashing 22.0 and 22.1 and it either fails parsing the pacage after I allow it to download itself or if I try to update it from an earlier version, it gives me the unable to check signature installation failed error.

Anybody has any idea what's wrong?

I even reinstalled the firmware from scratch, I did uninstall flashing of magisk, I tried everything and it won't work.

I'm stuck at Version 21.1

At this point I have reason to believe it's not my fault and it's a problem that has started appearing since version 22.
[Magisk] pndwal:
Just to be clear, is that Samsung Galaxy

J5

(2016)? PW
[Magisk] 3dwizzard:
It is J5 2016! Sorry for writing j6 above! I'm blind as a bat today...
[Magisk] pndwal:
Guessing you tried Direct Install from Magisk App? Or are you flashing from TWRP?

What happens when you try Patch image only?

This open issue may be similar, not sure, but problem may be affecting you too:

https://github.com/topjohnwu/Magisk/issues/4285 PW
[Magisk] 3dwizzard:
I tried flashing it and after I flash it I get the stub that asks me if I want it to download the latest version but it gives me the failed parsing package.

If I try to install directly, I get installation error failed to check signature.

As for patching the recovery, I tried it and it failed.

Later edit: I feel that somebody developing Magisk didn't test it on older phones with Nougat 7.1.1 or on j5 2016 in particular.

I could do the testing if nobody else wants, just ask me.
[Magisk] Homeboy76:
I don't know if j5 2016 in particular was tested for but but Android 7 was probably tested.
[Magisk] hackwerk:
Anyone??

(Same keeps happening with canary versions; Nothing seems to work on my A3 but stock?!)
[Magisk] pndwal:
Ok. May be getting a our wires crossed.

Do you mean you flashed Magisk (mask), or simply tried to download / update App (apk)?

If just can't install App, try uninstalling Manager / App, then downloading / installing from Magisk main page. Nb. You only need Magisk-v22.1.apk from 'assets':

https://github.com/topjohnwu/Magisk

So you mean direct Install from older Manager / App here? (That won't work.)

Yes, that is only for devices w/ Ramdisk = no. (Ie. cannot install Magisk in boot.img.) Never use Recovery mode on your legacy device.

Did you try simply flashing as zip (change apk extension to zip) from custom recovery?

Nb. Don't forget to UNHIDE / RESTORE Magisk Manager before updating anything (unless you uninstall it) as per release notes! 👍 PW
[Magisk] pndwal:
Patching boot.img with Recovery mode UNCHECKED?

What does log say when patching? PW
[Magisk] lhooipg:
I can do testing for SM-N910C Android 6.0.1 as well, just ask me....thank you.
[Magisk] Teracotta:
Why is Magisk checking updates even if check for updates is disabled? I don't want Magisk to communicate with anything outside my device.
[Magisk] ipdev:
Hi.

The canary builds are the open test builds.

If you use the canary builds, you are in the open test group. ;)

Didgeridoohan's guide has a great section about testing and how to gather the information you need to open an issue.

Asking for help/reporting bugs - WebSite - Link

Magisk's note on Bug Reports - GitHub - Link

Also, take a look at the open issues and see if one matches your device/issue.

Take a look at recently closed issues also to see if the problem was reported and fixed already.​

Magisk Issues - GitHub - Link

Cheers. :cowboy:
[Magisk] pndwal:
Are you getting notifications without running Magisk App (in the background)?

I think Magisk App will always check channel set in settings for latest available when run, but there may be a problem if it's actually checking in the background when Check Updates is off.

If you wish to prevent Updates or Latest builds from appearing in Magisk App home screen, setting Update Channel to Custom Channel and leaving Custom Channel blank appears to achieve this. 😛 PW
[Magisk] pndwal:
Best Unlock:

www.twitter.com/osm0sis_xda/status/1385961995653029890

😁 'n thanks for your help making it so worth while Chris! 💪👍 PW
[Magisk] pieceofphil:
After I updated magisk to the newest version from in app updater (APK from initial installation came from developers GitHub), Miui security gives a warning for it being a Trojan virus threat.

Is that normal, especially when I disguised the app because of my banking apps not working with magisk hide alone? Therefore the cryptic name and icon.
[Magisk] pndwal:
There have been MANY instances of malware in unofficial Magisk builds, some even hosted on PlayStore in the past. Eg:

https://www.google.com/amp/s/androi...on-google-play-contains-malware-20180130/amp/

The only official source is repositories on John Wu's GitHub, linked from here:

https://github.com/topjohnwu/Magisk

Are you sure you downloaded from here?

I don't know how MIUI security works, but I haven't seen such a notice on my Xiaomi devices with Magisk root.

Nb. Approx 3200 forks of Magisk are also linked from this page, but are hosted in GitHub repositorys of other users. Of course, there is NO guarantee that none of the modified builds there contain malware. PW