yashsingh1/xdaforums huggingface dataset:
[Magisk] Stillhard:
Latest Magisk Changelog after last Canary release:

- Update VN translation

- Update Portugueses Translations

- Update French translation

- Update RU strings

- Update build scripts

- Move things to the correct location

- Update zh-rTW translation

- Update zh-rCN translation

- More debug indication in UI

- Avoid non-blocking I/O

- Make SYSTEM_UID a special case

- Prune unused UID at boot

- Proper package state management

- Fix incorrect use of compare_exchange

nightly.link Download
[Magisk] faknit:
Hey all,

I have a Pixel 5 with LineageOS for MicroG 18.1, running:

Magisk 24.3

MagiskHide Props Config 6.1.2

Shamiko 0.5.0

USNF 2.2.1

I have dev mode turned off. I'm running a specific application in Shelter, and yet I can't find a way to hide root from it to save my life. Some of the logs that seems to correlate are:

2160 103 I Infrastructure sbm: .[103] SuFinder#run: Device rooted - shell which commands

103 I Infrastructure sbm: .[103] RwChecker#rwPartitionExists: Found rw(10300 10185 0:36 / /system/bin rw,relatime master:38 - tmpfs tmpfs rw,seclabel). Reporting device as rooted!

103 I Infrastructure sbm: .[103] RwChecker#run: Device rooted - RW partitions

2160 103 I Infrastructure sbm: .[103] c#a: Extra data contains: {"rootedTypes":["rootedRWSystem","suFileFound"],"SUFileFound":true,"suFileDetection":"checkWhichSuCommand","suFileOutput":"/system/bin/su","PartitionWritable":true,"rwPermissionOutput":"10300 10185 0:36 / /system/bin rw,relatime master:38 - tmpfs tmpfs rw,seclabel","DMVerityChanged":false,"SUPartitionAdded":false,"UnixSocketOpened":false,"MagiskHideDetected":false,"SystemRootProperties":false}

84 I Infrastructure sbm: .[84] PropertiesRetrySendMsgHandler#getDeviceProp: start running properties detectors: 11 05-31 15:28:40.320 2160 84 I Infrastructure sbm: .[84] PropertiesRetrySendMsgHandler#getDeviceProp: running detection: [ ADB-ENABLED ]​

Any insight on where to look to get this application to work would be greatly appreciated!
[Magisk] pndwal:
YASNAC results? PW
[Magisk] xerves78:
i have lineage 19.1 official and want to install magisk

i patched the boot.img from the lineage 19.1 image and flashed it

but now i get a lineage Boot loop

why ?
[Magisk] pndwal:
no information here such as Android version, device, whether Magisk was previously installed...

why not?! PW
[Magisk] faknit:
Sorry, should have included that. All green.
[Magisk] pndwal:
Here comes Stable Zygisk!

Move Zygisk out of beta

🥳👏🎇 PW
[Magisk] pndwal:
Can you link the app? PW
[Magisk] RandomPooka:
Crap. This means I'm going to have to finally read about Zygisk and what/how/why it works and is for LOL
[Magisk] heinhuiz:
It's only 85 pages yet.
[Magisk] pndwal:
Actions test 'Magisk Build' out last hour ... Things hotting up. (Guessing John's putting it thru paces on the old Z Fold 2!) I can smell 25 ... 😛 PW
[Magisk] pndwal:
New In-app contributor credits (nice touch John!):

topjohnwu (John Wu),

vvb2060(南宮雪珊, 'Nangong Xueshan')

yujincheng08 (LoveSy, Shana),

RikkaW (SHAAAAARK!)

diareuse removed!?

Update contributors in app

topjohnwu committed 38 minutes ago

Actions test preview:

👀 PW
[Magisk] pndwal:
Latest Official TJW Canary (release) & Debug (debug) Magisk builds:

Magisk (2106751e) (24315)​

[MagiskSU] [Zygisk] Proper package management and detection

[Zygisk] Fix Zygisk's self code unloading implementation

[App] Many many fixes, especially on older Android devices

Diffs to v24.3​

[MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)

[MagiskInit] Introduce new sepolicy injection mechanism

[MagiskInit] Support Oculus Go

[MagiskInit] Support Android 13 GKIs (Pixel 6)

[MagiskBoot] Fix vbmeta extraction implementation

[App] [MagiskSU] Properly support apps using shared UID

[MagiskSU] Fix a possible crash in magiskd

[MagiskSU] Prune unused UIDs as soon as possible to prevent UID reuse attacks

[MagiskSU] Verify and enforce the installed Magisk app's certificate to match the distributor's signature

[MagiskSU] Handle system_server restarts to prevent UID reuse abuse

[MagiskSU] [Zygisk] Proper package management and detection

[Zygisk] Fix function hooking on devices running Android 12 with old kernels

[Zygisk] Fix Zygisk's self code unloading implementation

[DenyList] Fix DenyList on shared UID apps

[BusyBox] Add workaround for devices running old kernels

https://github.com/topjohnwu/magisk-files/blob/fa95b510ce952dcbd45c54bd4b429d31ed847af3/notes.md

👍 PW
[Magisk] pndwal:
Hiding the Magisk app is broken for me (Xiaomi Redmi Note 8T) in this build. PW
[Magisk] Stillhard:
Becasue of this? :LOL:
[Magisk] martyfender:
I

I just switched over on on one of my devices from the alpha and I couldn't get hiding to work either. I ended up with the regular app and the hidden app named settings. Only the regular app will launch.

The hidden app will not launch, even after removal of the unhid app.
[Magisk] zgfg:
Supposidely, hidden app was older - then you had to uninstall that one

Anyway, uninstall both Magisk apps (not Magisk itself) and install only the correct one, corresponding to the new/current Magisk branch and version

Once, that will be working correctly, then hide it
[Magisk] deep_raman:
Company Intune Portal no more working with magisk root. Configure deny list but i think app got an update and outlook teams and intune no more working now. It says device unhealthy. Please help
[Magisk] pndwal:
Same experience... OS almost freezes, hiding doesn't complete, two apps when interrupted...

Working for you? Both devices?...

Seems broken for many devices ATM.

Repackaged Magisk app 24315 won't open #5905

I played with previous Debug debug builds too; there was no issue here before this... PW
[Magisk] zgfg:
Ok, didn't know for the new bug(s)

I didn't have time to update yet and btw, not hiding the app 😁
[Magisk] traversone:
same experience here..due to updated Intune Portal app (I downgraded it and hidden from Play Store with HMA Xposed module)
[Magisk] deep_raman:
is it working now?
[Magisk] tjsynkral:
I installed the Magisk update today and then my Google Pay detected root. I unrooted and tried installing the old Magisk canary I had working before and it didn't work, tried installing latest again, still didn't work. Am I the idiot or is this a problem for other people too? YASNAC reports clean before I launch Google Pay, and then it reports CTS profile match fail. (Pixel 6)
[Magisk] dohanin:
Have you tried this guide? basically you have to check all the boxes in denylist

https://xdaforums.com/t/tutorial-ro...t-intune-to-make-it-work-with-magisk.4402273/
[Magisk] dohanin:
Oh sorry, the latest from the thread also has reports that it does not work since the latest version of Intune (31May).
[Magisk] martyfender:
Nope, I actually did that from the start, removed the old hidden one, then installed the app-debug.apk, launched it and patched my boot.img, flashed it and rebooted, then finally relaunched and hid the app. No dice, I had the same problems as @pndwal.
[Magisk] deep_raman:
Yes, all are checked for intune, outlook, teams, google play services etc
[Magisk] pndwal:
I've actually had the same / similar issue for last 3 days; Contactless failed, removed and set up cards again etc. (Redmi Note 8T)

I haven't had any SafetyNet failure however...

Haven't been able to put my finger on the exact issue; above card image I have

- Wasn't sure if it meant card removed, but I called bank and was told cards were set up and fine for GPay on their end...

Since GPay itself is working / not complaining about root, it seems something is simply breaking Contactless function or NFC detection or hardware..

Does this match your experience?

Haven't had much time to dig further into issue... Suspect it's an issue with late Canary, but haven't tested...

Any suggestions would be appreciated... 🙂 PW
[Magisk] m0han:
this is serious. i'm just plain lucky that i didn't try Magisk (2106751e) (24315).
[Magisk] traversone:
yes, in current scenario, it works like in the past
[Magisk] pndwal:
Resolved. See two posts from:

https://xdaforums.com/t/discussion-google-pay-magisk-discussion-thread.3906703/post-86981113

👍 PW
[Magisk] the_arxyn:
Please Help Me

https://xdaforums.com/conversations/magisk-bootloop-error-in-redmi-9a.14730135/
[Magisk] pndwal:
I think we cannot access your conversation link! 😬 PW
[Magisk] dohanin:
i've updated Intune to the latest version 5.0.5533 and it's still working fine.

Did you use Shamiko? I'm using v0.5 (build 100).
[Magisk] the_arxyn:
I am having trouble to install magisk in my Redmi 9A device I tried from Orange fox custom recovery and fastboot mode also but in both cases I faced bootloop magisk cause bootloop in my device to fix boot loop I have to reflash stock boot image I am confused in dm verity and disable force encryption what to enable what to disable

Someone please help me 🙏🙏🙏

Device info

Model - Redmi 9A

Android version - Android 10 (Q)

MIUI version - MIUI 12.0.23

Bootloader - Unlocked

Ram - 3.00 GB

Orange Fox Custom Recovery

Magisk version - 24.3
[Magisk] rogers11:
Hello, I wasn't really able to get logs but installed today's update of my Samsung Galaxy S5e from LOS Recovery. I got this:

A not decrypted data partition was mentioned but I was able to install Magisk immediately from recovery (after confirming the signature).

So it isn't really a problem of encrypted data?

Thanks

Roger
[Magisk] samhhmobil:
I see exactly the same trouble.

Model: Xiaomi Mi10T lite 5G (gauguin)

Bootloader unlocked

ROM: LineageOS 19.1

Recovery: Lineage Recovery

Gapps: MindTheGapps 12.1

Magisk: 24.3, hidden

Just flashing Magisk newly with "adb sideload", immediatly after system update, is the workaround.

samhhmobil
[Magisk] rogers11:
You do not have to use PC and adb. You can install Magisk from within the LOS Recovery.
[Magisk] traversone:
Canary 23.015 has a bad behaviour to me (I think it is on Manager side):

a) updating within the (hidden) 23.014 Manager makes new Manager unresponsive (it never starts) and mobile gets boiling....soft reset is needed

b) installing a fresh 23.015 Manager leads to same behavious once trying to hiding manager (it never starts, 2 managers are shown in the drawer)--> mobile hangs up --> reboot/reset is needed

c) without hiding 23.015 Manager, all is working as expected and Magisk is correctly updated within Manager

thanks to who could comment on this

Hades ROM 3.0 for Samsung S8 - A10

EDIT: just released Canary 24.316 solves this issue!
[Magisk] pndwal:
Latest Official TJW Canary (release) & Debug (debug) Magisk builds:

Magisk (34b2f525) (24316)​

[App] Fix stub app on older Android versions

Diffs to v24.3​

[MagiskInit] Update 2SI implementation, significantly increase device compatibility (e.g. Sony Xperia devices)

[MagiskInit] Introduce new sepolicy injection mechanism

[MagiskInit] Support Oculus Go

[MagiskInit] Support Android 13 GKIs (Pixel 6)

[MagiskBoot] Fix vbmeta extraction implementation

[App] [MagiskSU] Properly support apps using shared UID

[App] Fix stub app on older Android versions

[MagiskSU] Fix a possible crash in magiskd

[MagiskSU] Prune unused UIDs as soon as possible to prevent UID reuse attacks

[MagiskSU] Verify and enforce the installed Magisk app's certificate to match the distributor's signature

[MagiskSU] Handle system_server restarts to prevent UID reuse abuse

[MagiskSU] [Zygisk] Proper package management and detection

[Zygisk] Fix function hooking on devices running Android 12 with old kernels

[Zygisk] Fix Zygisk's self code unloading implementation

[DenyList] Fix DenyList on shared UID apps

[BusyBox] Add workaround for devices running old kernels

https://github.com/topjohnwu/magisk-files/blob/b4869a2d900721c508c974e5288edf29aee25e01/notes.md

👍 PW
[Magisk] pndwal:
This is basically fixed for my A-only legacy SAR device w/ Android 10, but setup is still flawed:

I started with no Magisk App installed and took install Magisk Canary (24316) from GitHub Magisk DownloadsApp, then took Update Magisk (mask) and rebooted first.

All seems good. 👍

Then took Update Magisk (mask) via Direct install...

Seems process fails to uninstall the full app, and I get this:

Turns out root is lost due to the classic issue of dual apps competing as I suspected (took a look to confirm this), so I simply ignored this, uninstalled the complete Magisk App, opened Stub App and all is good...

... So this is vastly improved, but I'll open a new issue if no-one else does first.

Also strangely, Restore the Magisk app fails to remove the stub app as well on the first attempt. (Full app remains missing), but trying a second time it succeeds; Zygisk is 'No' despite toggle set On in settings... Closing and reopening App restores Zygisk.

After this, Hide the Magisk app works without a hitch, as does Restore...

I just tried to reproduce the initial behaviour by uninstalling App, downloading and setting up fresh again before taking Hide the Magisk app, but now this continues to work normally and so does Restore, so I've concluded that there was likely some anomaly with magisk.db or other config files due to testing Actions builds...

It now seems the fix is good. 👍

😜 PW
[Magisk] zgfg:
Sorry, I'm lost about the latest Canaries now

I still have 24314 and I didn't see any issues about hiding Magisk app (except that - IMO, everybody SHOULD BE aware of, one must unhide Magisk app before upgrading)

Hence, do we have now new bugs related to hiding the Magisk app?

Also, how about SafetyNet, GPay and so - are we good in 24316 with all that, something better or worse than how it was previously with 24314 or so
[Magisk] pndwal:
This was broken for many (failed completely) including my RN8T, but apparently it was Android version dependant... I still have Android 10...

Seems this is properly fixed now (for Android 10 and below?).

I thought there were still issues, but probably not... I've edited my post above...

S/N, device certification all good, GPay still ready so I'm assuming no more issues...

Since my recent GPay glitch (I found wiping Google Play Services, Play Store and Google Pay data wouldn't fix

but uninstalling / reinstalling Google Pay app did (strangely), I've had no problem making any contactless payments, however I get this:

when viewing Activity...

I read reports where this just occurred randomly but 'fixed itself' within a day... For me this has persisted for several days now despite many successful payments...

Any insight into issue / help to fix GPay Activity would be appreciated! PW
[Magisk] pndwal:
www.twitter.com/topjohnwu/status/1533771129256439808

👀 PW
[Magisk] rodken:
After you were able to get GPay to behave utilizing the uninstall method - rewipe Google Play Services, Play Store and Google Pay data [of course reboot].

It usually sorts itself out after a few hours [1 - 24] of your device hand-shaking with the servers.

N.B.: Remember to check your phone number to be certain that it is correct within the app.
[Magisk] Gerdje_:
Hi y'all,

Sorry if this problem have been posted before, but haven't found an solution yet after a few hours of trying.

Issue: after latest Lineage 18.1 OTA update I suddenly lost root. Magisk is no longer installed. Only option is Install within the app=>choose and patch a file after choosing the existing Magisk-24.3(24300).apk on my phone I get an error:

! Unsupported/Unknown image format

! installation failed

I have downloaded the Magisk v23.0, 24.1v and v24.3, giving me the same error.

With TWRP I get:

! cannot mount /system

- Unmounting partitions

Updater process ended with ERROR: 1

Previous OTA updates were no problem and I haven't changed/updated Magisk the since 24.3 (24300)

My device: Samsung S4 Value Edition

Lineage OS 18.1

Zygisk: No

Ramdisk: Yes

Any ideas? Cheers
[Magisk] m0han:
i went 24314 » 24316. things seem fine on A12.1. no op to test gpay payment atm.
[Magisk] pndwal:
Thanks... Did you have same issue?

Not sure how to do this. 🤔

Edit: Guess you mean in Google Account... tis correct. 👍 PW
[Magisk] pndwal:
Seems LOS 18.1 may force LOS recovery on A-only devices. Addon.d survival script requires decryption. Seems this may be your issue if you also lost (needed to reinstall?) TWRP w/ decryption...

https://github.com/topjohnwu/Magisk/issues/4655#issuecomment-924517921

Is simply flashing magisk.apk as .zip installer (old method) not working? (per official instructions)... This should still work fine on pre-SAR devices...

Sorry, but are you trying to patch Magisk APK?!...

This isn't clear, but if that's your mistake you need to extract boot.img from current ROM and patch that... If it's official LOS I'm guessing you may need a payload dumper app to extract it from ROM package... (Official way.)

Alternatively, patching a TWRP backup (.win file) of current boot partition should work...

😜 PW
[Magisk] pndwal:
This is different... installation from recovery should work either way. Addon.d (for auto reinstall after OTA) needs decrypted data to see the script... (See related post above also.) PW
[Magisk] pndwal:
Did this, and can confirm it did the trick 👍 ... I think the reboot made the difference; without it

never completes (and after circumventing this by uninstalling / reinstalling previously, Activity wouldn't update despite payments working fine).

Many thanks! PW
[Magisk] 73sydney:
Confuzzled, do you mean the usual

* Airplane mode on

* Wipe data of Play Services, Play Store and Google Pay

* Reboot

* Airplane mode off

didnt work...you had to fully uninstall pay as well?
[Magisk] pndwal:
Replied here:

https://xdaforums.com/t/discussion-google-pay-magisk-discussion-thread.3906703/post-86992241 👍 PW
[Magisk] Gerdje_:
Thanks. I still have TWRP (v. 3.5.2_9-1), so LOS recovery wasn't forced.

Noop, not working. I get the same error.

Yes. this is the only option, no direct install available. I didn't notice this and went on but it didn't cause the initial problem.

Will try that.

Edit: not sure if I need the payload.bin because my device doesn't support seamless updates. In this case the boot.img is enough?
[Magisk] pndwal:
So looks like LOS boot image may have become incompatible, or there may be some regression in Magisks handling of boot image compression formats...

Sorry, but patching Magisk apk is NOT an option as it's NOT a boot image... it will necessarily result in 'Unsupported/Unknown image format' for same reason. 😬...

No, but you must patch a boot image... Please read official Installation Instruction...

Ah yes; if you can see boot.img in ROM archive you can just extract / use that...

If you still face issues, try latest Canary; one of the many regressions fixed since last Stable may be for you device... PW
[Magisk] Gerdje_:
Apparently I can't patch the boot.img using fastboot, as my device is not being recognized during fastboot: waiting for any device. Seems to be an issue with older Samsung devices: https://android.stackexchange.com/q...work-at-all-on-my-samsung-phone/187573#187573

Is there another way to flash a boot.img?

Edit fixed: flashed boot.img within TWRP. :)
[Magisk] pndwal:
Latest Official TJW Canary (release) & Debug (debug) Magisk builds:

Magisk (cacf8736) (25001)​

Sync to public release

Diffs to v25.0​

None

https://github.com/topjohnwu/magisk-files/blob/c049c2f500e269818645e8eb85606343aae6ac00/notes.md

👍 PW
[Magisk] rodken:
I had to replicate the same issue - and perform a series of trial and error before I hit paydirt.

It's funny how the airplane mode trick works for some, but not for others.
[Magisk] pndwal:
You mean flash. 😉

Apart from using custom recovery I believe you can also flash standard boot.img using Odin...

Worth noting that despite launching with 4.4.2 KitKat (😛), and John stating

much of that section does in fact apply to your device 🤪 (hypothetically all of it no doubt would if Samsung were supplying stock Android 10+ updates for S4 Value) because, since updating to Android 10, it has actually been converted from Legacy ramdisk to 2SI ramdisk SAR boot-type...

Since Sammy devices w/ SAR can't use fastboot - they use a Download (Odin) mode - I'm pretty sure this accounts for 'broken' fastboot...

If I'm not wrong, the proper way to flash patched boot.img in the absence of an AP tar binary file (used by stock SAR/2SI ROMs) on your device is now via Odin...

Well done... PW
[Magisk] pndwal:
Appreciate the effort! 👍

- For others with this persistent Contactless setup security issue with Google Pay, I've amended my fix (which broke Activity list) and reposted in proper thread:

https://xdaforums.com/t/discussion-google-pay-magisk-discussion-thread.3906703/post-86992241

Can't beat a reboot w/ Aeroplane mode, Airplane mode, or w/o... Submarine mode didn't seem to fix the issue for me either... PW
[Magisk] Bookcake001:
Does anyone have an all inclusive guide to snapdragon 855 overclocking/under clocking, increasing voltage, decreasing voltage, and all sorts?
[Magisk] m0han:
Running the latest Magisk Canary [cacf8736(25001)] and Momo (v4.2.0). Momo reports something more - 'Code injection'. Worth tackling? How?
[Magisk] martyfender:
I get that if I enable more than just system framework lsposed manager, hide my app list. Instead hit the enhance mode for hidemyapplist gear icon button and add momo there in select effective apps. However, with this new momo I am still showing zygisk found. I am trying to figure out how to hide that.
[Magisk] JustinChase:
Does this new version make it possible/easier to hide root from banking apps?

is this something a module/modules still need to do?

I specifically want to run Revolut and/or Western Union apps on my phone, for international travel. Both balk at being rooted.

thanks!
[Magisk] andreipaval:
Hello, did an issue with Magisk hiding arrise ?

I have a Pixel 6, rooted with Magisk+Zygisk+Props Config+Shamiko+USNF, SafetyNat passed, GPay working.

But yesterday, after 2 of my banking apps got an update, they began detecting root, and nothing can stop them.

It's these 2: https://play.google.com/store/apps/details?id=com.ebankit.com.bt and https://play.google.com/store/apps/details?id=ro.ing.mobile.banking.android.activity from Romania.

Until yesterday they worked flawlessly.

What happened, is there a new root detection method ?
[Magisk] Timmmmaaahh!:
We're having the same problem with a Belgian authentication app called itsme (dedicated thread here, any assistance is most welcome! :)). Can you check with Applist Detector and/or Momo what errors it throws at you? No LSPosed? Might be a solution for you.
[Magisk] dvhttn:
I'm on 24.3 at the moment and have had to 'hide' (rename) Magisk to get my banking app to work. Can I just upgrade with this in place or do I have to 'unhide' Magisk before any upgrade?

Thanks
[Magisk] zgfg:
Not sure how is it now with v25 (I didn't upgrade and I don't hide the app) but rather ALWAYS unhide the app before upgrading because people USUALLY had troubles with (one of the MOST FREQUENT questions for help when they install the new Magisk app and it reports that it doesn't see Magisk/root because the old hidden app 'blocks' the access)

Or try upgrading without unhiding but then if you would have the problem as above, go and find your old, hidden and renamed Magisk app and uninstall it

IMHO, it's easier to avoid potential troubles and unhide in advance (and take that as a good practice before every Magisk upgrade)
[Magisk] Timmmmaaahh!:
I've experienced a pretty major issue with this as well in the past so I also used unhide prior to updating for a while until someone here told me they fixed that so been updating 'dirty' for the past few months now and working flawlessly every time. My 'MagicalUnicorn' updates just fine 😅

The biggest upside of not unhiding is that I don't need to set up all my hiding measures again after every Magisk update. But you're right, it's best practice not to be as lazy as me and just unhide first.