yashsingh1/xdaforums huggingface dataset:
[Magisk] agustincordoba:
I can see that for rom safety I should unlock the boatloader and flash TWRP, first - that should enable me to store a copy of the rom, just in case something goes wrong.
[Magisk] Sum1992:
First run root beer sample and check the results. Then apply modules/ tweaks for that.
[Magisk] NovaViper:
Ok.. I had to reset back to my Renegade ROM since TitaniumBackup started acting up and won't restore my apps automatically (the backup had the Renegade ROM and my apps downloaded). So I'm stuck with that bug that won't let me install Magisk v10.2 and beyond
[Magisk] Badger50:
Enable airplane mode, then your TiBu should work.

Sent from me :)
[Magisk] NovaViper:
Hey you happen to know ow to fix the status error 7 when installing Magisk?
[Magisk] Didgeridoohan:
Recovery log?
[Magisk] NovaViper:
I thought I placed it here, look at the next post I made
[Magisk] NovaViper:
Its here
[Magisk] Didgeridoohan:
Ah, you're talking about the same old problem about the installer not being able to restore the ramdisk when detecting a boot image patched for SuperSU.

You wrote "Error 7" in your post, so I thought it was something new. The only error I see in your log is still old error 1. Back to square one... :p
[Magisk] NovaViper:
Ah, you're talking about the same old problem about the installer not being able to restore the ramdisk when detecting a boot image patched for SuperSU.

You wrote "Error 7" in your post, so I thought it was something new. The only error I see in your log is still old error 1. Back to square one... :p[/QUOTE]

Oops, I thought it was 7 <_>
[Magisk] Yeradon:
Try to deinstall su first.

Gesendet von meinem ONEPLUS A3003 mit Tapatalk
[Magisk] NovaViper:
How do I uninstall it?
[Magisk] yochananmarqos:
Please edit your post instead of posting multiple times.

You will not be able to use Magisk without TWRP.
[Magisk] Yeradon:
https://xdaforums.com/showpost.php?p=63615067
[Magisk] Badger50:
Sorry bro, I don't use Magisk. I have no idea :crying:
[Magisk] karthik km:
Hello guys

Is it necessary to unroot the device to get saftyNet feature?
[Magisk] Yeradon:
Magisk will install its own su bin. But the installer normally replaces the old su with its own. So if you use SuperSu no. But if you get problems during installation you should remove su manually. After installing magisk you will have a working root.
[Magisk] Didgeridoohan:
Depends... If you're using MagiskSU you might have success with Magisk Hide. In that case the answer would be: no, not necessary. If you're using SuperSU I guess you could use suhide to hide root, but I've never used it so I don't really know.
[Magisk] karthik km:
I am using magiskSu and also magisk hide working fine on some apps

But safetyNet check give me error

Please look at the attachment once
[Magisk] Yeradon:
Do you pass SN without magisk and any other root installed?
[Magisk] Didgeridoohan:
There's a few things you can try. If you haven't already, look here:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828

Do you pass SafetyNet's basic integrity (use SafetyNet Helper or similar app to check)?
[Magisk] karthik km:
I will try
[Magisk] NovaViper:
I used SuperSU to root (the rom automatically roots with it actually)

---------- Post added at 05:38 PM ---------- Previous post was at 05:36 PM ----------

I looked st the link but I can't figure out how to get my rom's boot image

--Edit--

Nvm, I figured out how to get the boot image, but I think its modified already
[Magisk] toopty:
Google has pulled the Nexus 6 7.1.1 (n6f26u) March update from it's servers. I found some posts about it breaking Android Pay and Safetynet on stock un-rooted devices. I believe this is the root of all the issues I am experiencing, and not a Magisk issue.
[Magisk] Didgeridoohan:
Yup... I concur.
[Magisk] NovaViper:
I just finished doing this.. and it didn't work at all. I got the phone to turn on and my mobile data was off for some reason

--Update--

I'm trying again, this time flashing the SuperSU uninstaller, then flashing the stock rom, then flashing SuperSU, then Magisk (and it successfully installed). Right now my phone's booting up

-Update 2--

It.. Somewhat worked.. But I have no mobile data
[Magisk] Karls0:
I'm on systemless SuperSU (SR3, by Chainfire). Can I install magisk through Magisk Manager or do i have to unroot and do it manully through TWRP?
[Magisk] Didgeridoohan:
If you want to keep SuperSU, just install. If you want MagiskSU (required for Magisk Hide) you'll need to unroot and flash in TWRP.
[Magisk] Telperion:
Trying asking again in here... Is it conceptually possible to create a fork of Magisk that uses a ramdisk block device instead of a loop mounted block device? This would extend Magisk functionality to devices with no loop mount support, such as Nougat on the Honor 8.

Something like this which works on Ubuntu (modified slightly), unsure if it would work on Android:

# mknod -m 660 /dev/block/ram3 b 1 1
# chown root:disk /dev/block/ram3
# dd if=/dev/zero of=/dev/block/ram3 bs=1k count=64k
# /sbin/mkfs -t ext4 -m 0 -O ^has_journal /dev/block/ram3 65336
# mount -t ext4 /dev/block/ram3 /magisk
[Magisk] Captain_Throwback:
You don't have to keep asking. I'm sure [MENTION=4470081]topjohnwu[/MENTION] has seen your post. Have you tried applying this to the Magisk code yourself to see if it works?
[Magisk] Telperion:
In no way am I trying to be a demanding pest -- the extent of my code skills are reading, Googling, and adapting, so I don't have the expertise at this point to try it. I asked multiple times only so that if it wasn't possible I wouldn't waste my time trying to do it myself.

If it's possible, I can certainly Google away and try it on a fork. To use an analogy, there's no sense in me running down a 2 mile jagged alley only to find it's a dead end, when there may be someone standing at the entrance who can preemptively tell me it's a dead end.
[Magisk] Captain_Throwback:
I'm not sure how to know if it's possible without actually trying it, lol. This is software development, not a premapped road.
[Magisk] Telperion:
True, although we know certain things are impossible. For example it's impossible to use Magisk on a device with no loop mount kernel drivers. So while perhaps nobody can say it's definitely possible, they may know it's definitely impossible.

That said, it's a fair point, so I'll give it a shot.
[Magisk] Captain_Throwback:
I just tried your commands and I am able to create a ram block device and mount it to system root. I'm wondering how unmounting would work i.e. Magisk Hide using this method, though. Definitely interesting, but I guess this can be limited by the amount of available RAM a device has. Also, my magisk.img is around 1GB in size, and I wouldn't want to spend that much RAM to run Magisk - the performance hit would be catastrophic.
[Magisk] Karls0:
I need Magisk Hide. So can't Magisk Manager replace SU?
[Magisk] agustincordoba:
Not quite sure what that is, but I'll look it up. Thanks for your help.

---------- Post added at 09:51 PM ---------- Previous post was at 09:43 PM ----------

Sorry, I hadn't realised I was repeating the full post.

Thanks for replying, in any case.

Yes, it is clear I would have to flash TWRP, so maybe I'll wait a bit.

I was just mildly interested because of wanting to hide the root status from certain applications, but it is not important enough to warrant my breaking my main phone due to my ineptitude. Thanks again.
[Magisk] Didgeridoohan:
No. It's built to work with either systemless SuperSU or MagiskSU. If the former is already installed, the latter won't be.
[Magisk] Telperion:
Interesting, that's good to know. My Magisk.img is only 64MB, so I can comfortably run it in RAM. On my Honor 8 I've never seen less than 800MB free, so we should be able to hold even 128MB or possibly 256MB image with no real issue depending on what minfree settings are in use.

Magisk Hide should work the same way, just dismounting slightly differently. From my reading up on linux ramdisks and loop mounts, loop is the only way to get an img mounted to a block device. So when using a ramdisk using this method, instead of a magisk.img which is mounted, resized, etc, the magisk files would need to be stored in a folder somewhere on the device. In the case of the Honor 8, the /cust/ partition is where Huawei writes some region-specific update data so I'd likely use that to hold Magisk since it's off the beaten path so to speak. As to whether that would allow it to continue to pass SafetyNet -- anybody's guess.

The ramdisk portion can be generalized to any device, whether it passes SafetyNet and where Magisk is stored -- that's likely to be highly device specific.
[Magisk] joshiameya:
I can't find that option in titanium app settings, or are you guys talking about magisk app?
[Magisk] Spacedementia87:
Ok, I have decompiled the app, but what now? I have even found a file called RootCheckBean.smali

I don't seem to see anything in there that actually looks for anything. Maybe I just cannot understand the code, but it just looks to me like it calls itself again and again. Can't see any if statements or anything like that. No references to any props.
[Magisk] de.er:
For all that have issues with Titanium Backup, it seems the problem may not be Magisk related, but rather Google Play Services update, see link for explanation and solution. While it's not ideal in terms of security, it does make TB function properly.

https://www.xda-developers.com/psa-...broke-titanium-backup-substratum-heres-a-fix/
[Magisk] Valiante:
I assume others are still having problems with root being recognized in certain apps? Is there a way to flash the legacy phh's superuser to get things working again or will it conflict with the built-in supersu now?

If it's safe, could someone please provide the zip file?
[Magisk] Didgeridoohan:
There's a few options...

You can change root method.

You can try installing phh's superuser app and freeze it (this apparently works with Tasker).

You can symlink the su-binaries to /system/xbin

You can use the Su_xbin_module (that does the above for you). https://xdaforums.com/apps/magisk/magisk-suxinbind-t3564673
[Magisk] harsh.dhakar:
I m using latest magisk 11.1 and i am unable to pass safetynet check. It have magisksu and magisk hide is also enabled in setting and usb debugging is also turned off and busybox is also not installed.I tried every possible solution but evry time getting same error

SafetyNet Failed:CTS profile mismatch
[Magisk] Didgeridoohan:
Does your device pass Basic integrity? You can check with an app like SafetyNet Helper. If it does, Magisk Hide is working and you have some other issue causing Google not to trust your device/ROM.

Look here for some tips:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] Valiante:
Thank you, dear giver of blessings! This module worked like a charm ?
[Magisk] Maxxxel:
Galaxy S6

LineageOS

Magisk 11.1

MagiskSU

Magisk Hide working for other apps

But Safety Net gives Mismatch error.

Also basic integrity: false.

What can i do?

Edit: after disabling USB Debugging my integrity Check is true now but still mismatch.
[Magisk] karthik km:
Same here
[Magisk] Didgeridoohan:
[MENTION=3481427]Maxxxel[/MENTION] [MENTION=6429574]karthik km[/MENTION] Have you guys looked here and checked if any of those tips work?

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] karthik km:
Oh uh Whats happening with Magisk Hide

Is it really changing my SELinux from permissive to enforcing

Please look at the attachment once
[Magisk] Maxxxel:
Yea, also the chmod on those 2 Files but i Can only Pass Basic integrity
[Magisk] Didgeridoohan:
No. It's called pseudo-enforcing. It's used to hide a permissive SELinux from SafetyNet.
[Magisk] karthik km:
Thanks for the useful tips
[Magisk] gk1984:
Is there a way to verify the lines in a system.prop worked? Trying to troubleshoot a module that doesn't work for me...
[Magisk] Didgeridoohan:
Ah... But in your previous post you wrote that Basic integrity was false. If you can pass Basic integrity with the Samsung SELinux file modifications, I'm gonna say it's LineageOS causing your device to not be recognized by Google and thus getting a CTS profile mismatch.
[Magisk] Maxxxel:
Yeah could be true.

i guess more people are to come hear in near future now
[Magisk] Didgeridoohan:
In a terminal emulator, write (without quotations) "getprop prop_name" (example: getprop ro.build.tags). That should tell you if it worked or not.

On some props I've found that the lines added to system.prop doesn't fully work though. Those times "getprop" would show the changed value, but apps looking for it would report the original value. For me, the solution to that was using post-fs-data.sh instead of system.prop in my module. The syntax is a bit different, but it has the same effect. Take a look in the All-In-One wiki for the resetprop command options (example: /data/magisk/resetprop ro.build.tags release-keys).

Edit: I've yet to open a GitHub issue about this, but it's on the todo list... :)
[Magisk] icxj1:
Works good on alial04's AICP 12 M7vzw build. ?
[Magisk] gk1984:
Thanks, I'll try that. The getprop hasn't worked right for me so far. It's only returned the original values from what I can tell. What's weird is that another module that

is

working also modifies the system prop and is not listed from getprop. This is why I'm asking. This is unrelated to my issue though, just why I'm confused.

But perhaps instead of wasting time trying to troubleshoot, I'll for a little help so I can eliminate some trial/error methods. My experience with this sort of stuff is basically zero. I've done websites, so I'm familiar with basic syntax rules and such, but the extent of anything Android development I've done is change values in what's already there.

A module I'm trying to use won't let my Nexus 6 boot. An earlier version worked fine. Trying to determine if a line in the system.prop is causing a conflict, or if the way it's written is causing the issue. But I'd also prefer not to call out the developer, either. The earlier version that worked did not use = signs in the prop. Worked meaning my phone booted. Hard to tell they actually did anything. Getprop didn't show them at all. The newer version is now using = signs before the value. Now my phone won't boot. Comparing to another module, = signs are used. But unfamiliar if the other way is valid too.

I'll explore the wiki in the meantime, but perhaps someone could share proper syntax.

Examples (not the real lines in the module, just examples):

ro.sfi.lcd_density 320 ----- will boot

ro.sfi.lcd_density=320 ----- won't boot
[Magisk] karthik km:
All success but CTS profile mismatch why?

Any one tell me what is CTS profile
[Magisk] Captain_Throwback:
For system.prop, the syntax should look just like your build.prop.

ro.sfi.lcd_density=320

If using post-fs-data.sh to set props, either setprop for standard props or resetprop for read-only props should be used, with standard "setprop" syntax.

setprop ro.sfi.lcd_density 320

or

/data/magisk/resetprop ro.sfi.lcd_density 320

Both of these methods work fine for me with Magisk v11.1, and checking the output of "getprop" for any of the props set via either method should and does result in the expected output.
[Magisk] Didgeridoohan:
The proper syntax in system.prop is with a "=". What props are you trying to change? If "getprop" doesn't show anything at all, the prop doesn't exist.

The one you're using as an example is wrong, by the way. It's supposed to be (without quotation) "ro.sf.lcd_dencity", but maybe that's just a typo in this post... I'm using that one myself in one of my modules' system.prop. If you use post-fs-data.sh the syntax would be "/data/magisk/resetprop ro.sf.lcd_density 320", without "=".

Edit: Too slow... :D

---------- Post added at 16:53 ---------- Previous post was at 16:46 ----------

Your device/ROM is for some reason not trusted/recognised by Google. It doesn't match up to any known CTS certification...
[Magisk] gk1984:
Thanks, it was likely a type. I just pulled that from the template and typed it. Your info as well as Captainthrowback's was very helpful. It'll help me narrow down what's wrong. Most likely a conflict with a prop setting and my phone by the sounds of it.
[Magisk] icxj1:
Try turning off Android debugging and unknown sources? Worked for me. Can turn back on after first pass.
[Magisk] pappschlumpf:
I've switched from SuperSU to MagiskSU and well, now init.d isn't executed and it looks like /etc/init.qcom.post_boot.sh could not start mpdecision service that is declared in the kernels ramdisk, too. ROM, kernel, everything is the same, except rooting method. Any suggestions?
[Magisk] Didgeridoohan:
With Magisk and MagiskSU you should be able use the General Purpose Boot Scripts instead, talked about here. Or possibly make a Magisk module.
[Magisk] karthik km:
Thanks for that I have already tried that but finally test gives me error
[Magisk] arrrow:
So everytime I reboot(I think, I have to reflash it every day since every time I wake up it's unrooted again), it unroots itself somehow again. Is this a known issue and what can I do to fix it?
[Magisk] Artim_96:
Is a looong known issue. Either try with disabling busybox/Magisk hide/both our try the beta

---------- Post added at 06:20 PM ---------- Previous post was at 06:18 PM ----------

CTS=compatibility test suite. The software pack ROMs need to pass before OEMs are allowed to publish it with Google apps. Profile mismatch means your ROM is not trusted. Either it passes with the stuff posted just a few posts above your post or it just can't pass that. No way to change at the moment
[Magisk] Karls0:
MagiskHide couse reboot in just 1 min if mobiledata is on. How can I fix it?
[Magisk] Artim_96:
Can't tell without any information.

But that sounds like something on installation went wrong. Maybe you first make a fresh start
[Magisk] Karls0:
I did manual install via TWRP. What you mean about fresh start? Push uninstall zip, reboot, install again?
[Magisk] Artim_96:
Flash uninstaller and maybe flash the stock boot.img even if Magisk should restore it itself.

Does it happen without Magisk too?
[Magisk] Karls0:
Before Magisk I had systemless root by Chainfire and all was fine (I just need this hide option). I have only backup of stock image before unroot, so if I restore it i think I will restore SU.
[Magisk] topjohnwu:
Just a small update regarding recent progress.

School has been extremely busy, I'm also in charge of other extracurricular activities, so free time is extremely limited, thus the little activity and support lately.

However, I still squeeze out my time doing some groundwork for the future of Magisk, which will eventually mean MUCH better compatibility, and should bring more ways to install Magisk on devices with nearly no community support e.g. no custom recovery, or no root at all.

The completely written-from-scratch boot image tools, now renamed to "MagiskBoot", is pretty much done. People interested into it can take a look at the latest source code on Github.

A brief list of the new features: Sony ELF support, proper MTK support, support many common compression methods apart from gzip, and much much more.

Huge shoutout to [MENTION=4544860]osm0sis[/MENTION] for answering many questions I had, and his wonderful AIK project that gives a clear idea how various boot image formats looks like.

Keep in mind though, the flashing scripts are not ready yet. They need to be adjusted to work with the new tool.

For developers and hobbyists, I'm sorry for keeping the master branch unusable for quite some while. I'll work on a separate branch on new and experimental features in future releases, right now I have nearly no time (and lazy) to manage the repo in a more appropriate way.

There are still some stuffs I'd like to finish before pushing out a new update. The long waited "Superuser system mount issue" fix will also be bundled with the upcoming release.

However due to limited time, I cannot give a clear idea when the update will drop, but I'll do my best to squeeze as much time as possible!
[Magisk] Artim_96:
Well, then you have leftovers of that systmless supersu. Try to get your boot.img from somewhere else. Normaly you should find your devices update files on your devices forums. How the boot.img is inside it, of you can extract it or something similar depends on your device, you need to ask in your devices forum
[Magisk] Karls0:
[MENTION=5125527]Artim_96[/MENTION] - This rom is pre-rooted systemlessly by default, so they will give me the same boot.img with root:). I can only reinstall whole rom and unroot again but I think it's ponitless. I used SuperSu option to completely unroot and I think it restored clear boot.img.
[Magisk] Artim_96:
If it's pre-rooted you can't do anything. You would need a different ROM or at least a different kernel that includes it's own ramdisk.
[Magisk] Karls0:
[MENTION=5125527]Artim_96[/MENTION] - it's rooted when instalation is done, but i'm not sure if it is rooted in .zip or it get rooted during instalation. If the second one - i have boot.img. Is it possible to flash img file by TWRP?
[Magisk] Artim_96:
Of course, under install there is a button in the lower right.

But I'd bet if it's pre-rooted systemlessly the boot.img was altered too, sadly I have no idea how to find out that, think you need to ask your ROMs dev
[Magisk] Karls0:
[MENTION=5125527]Artim_96[/MENTION] - I can't ask, he is not very active because he is busy in his life. But I see that inside of rom package is super-su instalator so i think it mean that the boot.img is clear, just patched during installation. I extracted it, we will see how it works after reinstall.

Edit: Still bugged. So it's not about the clean install. Any other sugestions?
[Magisk] bluemond:
After a bit of tinkering I managed to install Magisk on my LG G2 (D802) with stock rom/kernel (lollipop 5.0.2). I haven't tried any modules, but i have proper root access.

Now to the problem: magiskhide is not hiding root at all. The daemon seems to be started all right, but even apps that are not explicitly designed to detect root or check safetynet report that I am rooted. Because of that, safetynet doesn't even have a chance to pass....

I think i tried everything from the troubleshoot thread, but most of the tips actually only cover safetynet issues, not root hiding issues.

Attached you will find 2 logs from magisk manager and the stock kernel image. To install magisk, I used Ramdisk Compression Exchanger, because the stock image uses lz4 (and that is only supported in the next vesion). I also had to use a bump script, because ro.product.device is "g2" and not "d802", so the magisk install script didn't recognize it as an LG
[Magisk] Didgeridoohan:
Sounds like a plain old compatibility issue... There's nothing in the logs about Magisk Hide actually unmounting any of the necessary files/folders. Have you enabled verbose logging in the Manager?
[Magisk] clodoux:
Is it possible that a modded google play is responsable of the safetynet not pass anymore ? Because i have superman rom 2.3, and my SN is good. I install the modded GP and now i can't pass SN?
[Magisk] Karls0:
Bug Report

Description:

Everything works well, root access is granted, system is stable - as long as MagishHide is turned off. When I turn it on and try to check SafetyNet, the phone reboot. First I thought it is related with internet connection but after some investigation I can say that bug occurs even if wi-fi/mobile data are off. I did succesfully check of SafetyNet but only once, then it always reboot.

What I did so far:

1. Reinstalling magisk with additionally restoring clear boot.img before new instalation, to be sure.

2. Investigating if some app may cause conflict - I removed root checker.

3. Clearing Magisk Manager data

So far, the bug is still here. (Android 6.0, AOSP ROM)

My procedure to reproduce bug:

1. Open Magisk Manager and turn MagiskHide On.

2. Press SafetyNet check (also in Magisk Mager).

3. Phone reboot.

It's rather short way, i hope you will find a solution for me :).