yashsingh1/xdaforums huggingface dataset:
[Magisk] Captain_Throwback:
I'm sure this question has been answered many times...did you search first?

P.S. A bunch of people are using it on Nougat with no issues...
[Magisk] immi803:
Yes i did

But like you said some are running on nougat without issues and others not, so couldn't clarify myself regarding this, that's why asked it again :eek:
[Magisk] HamsterHam:
Cheers. Here's a screenshot of the error and apk. I tried without any adblock running and got the same issue.
[Magisk] Captain_Throwback:
In RootDetector.smali in the APK, there's a line looking for the Superuser app, installed in /system:

const-string v1, "/system/app/Superuser.apk"

I'm assuming your Superuser app isn't installed there, right?

EDIT: It's also checking for whether you're using a release ROM or not by confirming it doesn't use "test-keys" as indicated below:

const-string/jumbo v1, "test-keys"

Those appear to be the only things that it detects as "root."
[Magisk] HamsterHam:
Nope, it's wherever magisk puts phh superuser.
[Magisk] Captain_Throwback:
I added another note to my post - maybe your ROM is the issue?
[Magisk] HamsterHam:
Hmm, strange. That's the only app that detects root. Magisk hide works for other apps. ROM comes unrooted. It's the Angler build of ABC.

Sorry just read your edit. Nice, I'll ask in the ROM thread.
[Magisk] Captain_Throwback:
You can just look in build.prop - or getprop ro.build.description or ro.build.fingerprint
[Magisk] HamsterHam:
# Do not try to parse description, fingerprint, or thumbprint ro.build.description=angler-user 7.1.1 NMF26F 3425388 release-keys ro.build.fingerprint=google/angler/angler:7.1.1/NMF26F/3425388:user/release-keys
[Magisk] Captain_Throwback:
Then I have no idea - but I don't see how the issue could be related to Magisk, based on the APK's detection method. It's also possible I'm missing something, but not sure what that could be.
[Magisk] HamsterHam:
Okay, cheers for looking! If you're ever bored have another butchers if you can please.
[Magisk] cimenta:
help how to use?

someone would be able to help me? I don't know how to make Magisk work.
[Magisk] mrxtc89117:
I have a Sprint Note 3 with Temsek rom 6.0.1. Unrooted it passes safetynet. I installed Magisk and enabled MagiskHide and it passes safetynet. But when I do a nandroid backup using twrp 3.0.2-1 then I can't pass safetynet after. Is it a problem with my twrp recovery? Or is it because it is Samsung?
[Magisk] Captain_Throwback:
Well it isn't related to Magisk, it seems, so I'm not sure what we could tell you. Maybe search in your device forum or ask in Q&A over there.
[Magisk] Artim_96:
Yes, that was asked more than often enough, do a search.

On Substratum themes, I actually have no idea how they even work, the only ones I know are for CM's theming engine or the RRO themes used by Sony and more or less usable in such Android.

But I know that (at least partial) support for those themes is built into my ROM, which comes pre-rooted. So I don't think there should be a problem with systmless root, but I don't even know if they where ever mentioned here.
[Magisk] X46X:
Hi, can anyone tell me how to install xposed in V9? I tried it in magisk manager but with no luck.. It says that it no magisk module..
[Magisk] Artim_96:
Then flash the zip from the link in the first post via recovery
[Magisk] X46X:
If you mean zip from github, I getting an error in recovery if I try itstall it..
[Magisk] Artim_96:
No, the Magisk-v9.zip from the link in the first post of this thread
[Magisk] Cavaler:
I need help with Magisk and Magisk Hide.

I have Redmi Note 3 Pro (kenzo), with Android 6.01 and MIUI8. I had systemless SuperSU installed and working.

Now, I wanted to add Magisk v9. I installed Magisk Manager 2.5, but could not install Magisk from manager since it couldn't download anything.

I installed Magisk via zip from TWRP - it wrote that SuperSU was detected, installed accordingly.

But now it seems as if all SuperSU-related stuff has disappeared along with su binary. From TWRP I see both su.img and magisk.img in /data.

I'd prefer using SuperSU - what could I do wrong, and how can I rollback?

UPDATE: I reinstalled SuperSU. Now root access works from other apps, but Magisk still says "No root access, functionality limited"

And also it crashes when I enable Magisk Hide from settings and then enter Magisk Hide from menu.
[Magisk] X46X:
Why? I have Magisk manager and Magisk v9 installed through Magisk manager..
[Magisk] Artim_96:
Oh... I've totally overseen the XPosed part. Then you are already wrong here, you have to go to the Magisk XPosed thread. There you'll find the zip fit manual flashing. Flash it through TWRP and report errors there
[Magisk] KaMyKaSii:
You could remove integrated SuperSU with osm0sis unSU script before install Magisk

http://xdaforums.com/apps/supersu/2014-09-02-supersu-v2-05-t2868133/post63615067
[Magisk] Captain_Throwback:
System-based Magisk? :confused:

I think you don't understand what Magisk is...:rolleyes:
[Magisk] culiacanazo:
You beat me to it ??

---------- Post added at 12:23 AM ---------- Previous post was at 12:20 AM ----------

I'll tell you how to get a systemly Magisk.

Just remove it. Profit
[Magisk] Artim_96:
That just explains that you have no idea what Magisk does.

It was made because from Android 6.0 up devices will refuse OTA updates of you mess around with the system partition. So Chainfire made SuperSU systemless in order to have root without breaking OTAs. Then topjohnwu started with making XPosed systemless and ended up with Magisk in order to have an easy tool to let everything run systemlessly. That's the only reason it exists. Hiding it's modules (including phh's SuperUser, excluding XPosed) from SafetyNet is a side project which is a losing game.

So of course it's impossible to have Magisk system-based because that defeats what it does.

And no, out can't get any more potential or anything easier configured when installing it as system-based.

So before posting such nonsense again, learn to follow the forum's rules (which probably apply for every existing forum) and first read, then write. If you would have read at least what's behind the link in the first post you should have seen that what you want makes absolutely sense and so will never ever be made
[Magisk] KevinX8:
Magisk is a framework to apply system mods without actually writing to the system partition. Nothing else, it's not xposed, it thosent give you the ability to do something you can't already do with system mods (apart from pass safety net). Magisk those not stop you from getting a bootloop if you mess up or anything like that so people who are afraid of such things have no use for magisk. It's main use is to allow ota updates and the ability to have root and xposed but still pass root checks/ safetynet. You are still flashing stuff so I have no Idea how this ruins anything. If you want to apply a magisk module straight to the system just extract its zip and place it in the correct directory simple
[Magisk] oreo27:
What is it that you're trying to achieve exactly? I seem to be missing your point.

1. What makes system-less root crappy? From my understanding, SuperSU defaults to system-less from Android 6.0 onwards due to the requirement of boot.img patching.

2. I'm not sure that Xposed can do the same exact thing. I personally use some mods for my mixer_paths.xml, framework-res.apk, boot animation etc; all systemless-ly installed. If I were to flash these mods on the system manually, every update of my ROM would require me to re-flash them.

3. You can certainly get into a bootloop by flashing or otherwise installing Magisk or an incompatible mod. So no, it's not for the faint of heart. Just read this thread which you've posted on.

4. People being lazy is rather subjective but I agree with you on that on other aspects, not modding. Ruining the fun of flashing? It's the same thing minus the risk of wrecking your system partition. Both require a reboot and Magisk Modules can also be flashed if you'd like to see your recovery partition once in a while.

-Flash a Magisk module incorrectly? Flash mount_magisk and delete the mod, problem solved.

-Flash a mod incorrectly? Manually replace each file you wrecked. Manually replace each file you deleted. Or manually dirty flash your ROM and delete all your other mods. :)
[Magisk] Krunk_Kracker:
Does anyone have the Phh supersu module zip? The download is failing through the app.
[Magisk] JEANRIVERA:
https://xdaforums.com/apps/magisk/magisk-phh-s-superuser-android-pay-t3435921
[Magisk] Krunk_Kracker:
I flashed that in recovery before I posted and it didn't do anything. Magisk got an update and I lost root, trying to reestablish root now.
[Magisk] culiacanazo:
I have others if you need them, let me know now because i don't know how drunk I'll get later i don't wanna send you something else :laugh:
[Magisk] Krunk_Kracker:
That one did it! Thank you so much!

---------- Post added at 01:59 AM ---------- Previous post was at 01:56 AM ----------

Well wtf... It did, until I rebooted again... Not sure what's going on...

---------- Post added at 02:07 AM ---------- Previous post was at 01:59 AM ----------

Well, I used osmosis's unsu zip and then reflashed phh's superuser, and it seems to be working as of now.

---------- Post added at 02:09 AM ---------- Previous post was at 02:07 AM ----------

Edit: and root is gone again,thus time without rebooting. Dafuq? Maybe I'll do a dirty flash. This all started with the magisk update, not sure if that's the cause.

---------- Post added at 02:21 AM ---------- Previous post was at 02:09 AM ----------

Edit

And root is gone again. Going to uninstall the most resent version of magisk and go back to the older version and see how that works.
[Magisk] Didgeridoohan:
Are you aware that v9 has a Magisk Hide bug that will disable root, seemingly at random. I've also lost root on v9 without having Magisk Hide enabled. It'll be fixed in the next version... There's a unofficially built v10 by stangri that you can try. It's been rock solid for me.
[Magisk] Krunk_Kracker:
I knew of magisk hide, because I hide it from Pokémon go for the daughter, but I didn't know it could cause issues.
[Magisk] culiacanazo:
Reflash rom and start again and you should be good to go, I've never had any problems with the file. When i did was back when cm wasn't readily working with the SuperSU - WiFi - root combo thingie... but it certainly wasn't the file. And by the way, i currently have neither disabled cm's built in not removed binaries, but do (besides reflashing if you do) manually look for ".img" remains in /data.

In reality I'm not really sure what the background to your particular problem is, but I'm telling you mine hoping it helps you, and if not, at least someone else.

Let us know. I'll be around. At least we can definitely be sure that the file did get recognized after reboot...

Ok, i did a little background on you (saw your profile) and i apologize for trying to walk you as if a baby, just trying to be helpful.

Anyways, i think that the first thing you mentioned above is a better bet, as i once read something advising against using older versions (here on xda, mind you)... But it was just coming across it, as i wasn't looking for that.

Unless your device is in a class of its own (kinda like Sammies when it comes to xposed), I'm positive that will help and be an overall faster fix

---------- Post added at 03:02 AM ---------- Previous post was at 03:00 AM ----------

I'm sorry, disregard my previous post of you did have MH enabled...
[Magisk] darksaber79:
I had installed magisk, but haven't got time to unroot, and root with superuser etc.

I now want to just remove magisk.

I have downloaded the uninstaller.zip twice but on both, when attempting to flash with twrp 3.0.2.0 it says error can't extract the file.

Is there something I am doing wrong?

Do I have to wipe device and reinstall clean?

Cheers
[Magisk] tiendat1295:
Is there anyone here using crDroid rom? I'm using crDroid v1.8 (latest) on my G3 d850 and Magisk and phh's supersu refuse to work. It causes almost every app forced close, previous versions or the rom worked fine though. Do you have problem using magisk on latest version of your rom?
[Magisk] Artim_96:
Go to your ROMs thread to discuss problems with it

---------- Post added at 01:21 PM ---------- Previous post was at 01:20 PM ----------

Delete /data/magisk.img abs flash your systems stock boot.img
[Magisk] vekenti:
I got an error "Could not do normal boot. Invalid id KERNEL LENGTH" while trying to boot after flashing magisk, does this mean that it is not compatible with my phone?
[Magisk] culiacanazo:
I think you have to flash your boot.img in addition (after you remove Magisk)
[Magisk] Artim_96:
Since nobody here is psychic you should at least tell us which device you own... And maybe look on the list with known incompatibilities. I think it was in the thread linked in the first post of this thread
[Magisk] Didgeridoohan:
As already stated, no-one here can read minds... But I'm gonna take a wild guess and say you have a Samsung device and that you might need to install a custom kernel. If the above is true you can check the Samsung compatibility thread for advice.

And just as a heads up, that's as far as I can help with that particular problem since I don't deal with Samsung.
[Magisk] Biz92k:
Hi guys, I was just wondering why there's no trace here on XDA of the 3.0 version of the magisk manager spawned in the play store just yesterday (which has actually updated my magisk manager )...
[Magisk] waylo:
Neat find, first I heard of it too and I follow these magisk threads several times daily! Looks like topjohnwu is rolling things out in rapid fashion.
[Magisk] Artim_96:
Could you share the PlayStore Link here? Because it won't show up for me in PlayStore and apkmirror doesn't has it yet.
[Magisk] waylo:
https://play.google.com/store/apps/details?id=com.topjohnwu.magisk

I just searched for 'magisk'

It overwrites/updates your existing Magisk manager app which is nice in that the signatures match. For now, it does not register any v10 magisk update existing. There are some new added features like where to install Magisk boot image, as well as options to keep dm-verity or encryption (not sure if they work with v9). It also adds safetynet checking directly in the app which is appreciated.
[Magisk] Artim_96:
Thanks, now it shows up.... Anyway. SN checking seems to be not working, only loading without showing a result.

But the options for flashing should probably asked work. That's what Magisk already does. But maybe someone should explain how to find out which partition is the right one. The Linux command lsblk seems to be not working and I don't remember which one does the job on Android.

And what exactly was the benefit of turning off dm-verity in contrast to keep it on/which devices profit of it? I know that it was disabled for some reason but I don't really remember why
[Magisk] Biz92k:
Sn check is working for me, even if sn itself can't pass
[Magisk] darksaber79:
If I was to do a clean install of my ROM, wiping the device completely, this would remove it?
[Magisk] Artim_96:
If you wipe /data too yes
[Magisk] darksaber79:
Too? As in another step in required not just wipe data?
[Magisk] Artim_96:
if you wipe /data too = if you include it in wiping process as you said. Because just flashing a new ROM should make Magisk unusable, but to really delete it you need to delete the magisk.img in /data too
[Magisk] darksaber79:
Right I understand now.

Yes. My process to reflash my ROM is to always do a clean install, that is wipe the partitions, first then install custom ROM.

Cheers and thanks for your patience

---------- Post added at 02:05 AM ---------- Previous post was at 01:53 AM ----------

Right I understand now.

Yes. My process to reflash my ROM is to always do a clean install, that is wipe the partitions, first then install custom ROM.

Cheers and thanks for your patience
[Magisk] culiacanazo:
Of course, but it isn't necessary unless you're looking at something else i don't know of. However, when having nothing to lose, it's a lot quicker and easier

EDIT: hadn't read all the answers given you, as i didn't close my app so it must have been it not refreshing
[Magisk] Pauls57:
Since updating to version 3.0 via the play store, when I open the app, the safety net part of the status page shows a spinning circle but never completes.
[Magisk] Captain_Throwback:
That means your Play Services crashed at some point, so SafetyNet got broken. That's not caused by the app, but Play Services itself. If you go into Developer Options and stop the Google Play Services process, it should fix that problem. But it will also kill location services and require a reboot to fix (at least it did for me).
[Magisk] Pauls57:
Right as usual Captain, Thanks for helping. ?
[Magisk] Magz Heaven:
Safety Net Failed

Will this break my Xposed or what? I'm new to this systemless ****. Haha. Someone help me please. The thread is to long to backread. :( I installed magiskv9 with the latest phh su, also installed xposed zip. Thanks
[Magisk] chudy_85:
Install official xposed and root switch to disable xposed and pass safety net
[Magisk] Pauls57:
Running Magicsk w phh version 266.2 on HTC 10, seems to be losing root frequently. Not certain, but it may have gotten worse after the update to Magical manager 3.0
[Magisk] Didgeridoohan:
It is a known bug that has been found and will be fixed.

[SLIGHT ANNOYANCE]Doesn't anyone search for information anymore!? Asked and answered many, many times...[/SLIGHT ANNOYANCE]
[Magisk] rignfool:
It's sooo much easier to post a question then wait for the email to let you know someone has taken time out of their busy day to respond...

To search... Would take time... And require reading...

Something you won't find on XDA these days...
[Magisk] andrew2432:
I want it now, then I want YOU to fix it. I've asked some dumb qs but there's nothing like acquiring the tools yourself and then utilizing them to achieve a goal...sorry that was so corny
[Magisk] Pauls57:
Wasn't really asking for help, or looking for information, simply reporting my experience after the app update.
[Magisk] culiacanazo:
Agreed, but there's a search function where you type in one or a few keywords, and most likely than not, your problem will have been discussed, takes you to that read, so you don't have to backread 700 pages, and bingo!

In case you don't find it, then there's also the "whatchamacallit" function (you know, where you can ask a question)
[Magisk] andrew2432:
Use "" and + and -, then you can find your exact problem :)
[Magisk] FlintStoned-:
Hi all. I installed magisk 10 using the manager 3.0 but now I get notification from superuser that the binary is out dated and lost root. Any ideas?
[Magisk] finiterex:
SU in xbin

Hi all, firstly apologies if this has been answered before, I have searched for some hours and not been able to find anything... also I'm relatively new to Android / *nix / etc... so any help greatly appreciated.

Here is my boggle...

I am running CM13, Elemental X Kernel and Magisk v9 with PHH SU Magisk version. SU is working great for those apps that need it, Titanium backup etc.. however I had some recent issues with CM that resulted in performing a dirty flash of the last CM13 nightly (before CM servers were off-lined). This, of course, brought back the in-built CM root which I tried to remove by using chainfire's SU management app from the play store. This failed, crashed during removal, so I reverted to TWRP and flashing the SuperSU removal zip. This seems to have worked. I then flashed Magisk v9 and PHH SU Magisk version. The problem I am having now is that I am failing safety net which I didn't used to do before having to dirty flash CM13. I fully understand Magisk isn't designed to evade safety net but this seems a little strange being that nothing else has changed. The only "oddity" I can find is that su exists in xbin (but not bin).
[Magisk] yochananmarqos:
I got the same notification after flashing Magisk v10, but root is working. Post your Magisk log.
[Magisk] FlintStoned-:
I see that magisk gets granted but other apps say that they do not have root access.

Thanks for looking in to it.
[Magisk] yochananmarqos:
The log looks normal. I would uninstall & reinstall Magisk without Xposed and make sure everything is working before installing Xposed again.
[Magisk] android_htc:
Wow... this is amazing, finally SafetyNet passes on Samsung stock!

[MENTION=269445]flintstone[/MENTION]d - I've had the same error, but resolved it by unstalling Magisk and installing Magisk and latest version of SuperUser
[Magisk] Thomas_BA:
Just to let you know.

Updated to Magisk 10 and Manager 3.0.

Running smooth and with no problems. Will have a look at the new features and documentation later.

Thanks

P. S.

Just one suggestion

In the Manger under the tab "Install" it says *install Magisk 10 * even version 10 is installed. Better would be that the Manager detects the installed version and states something like *Magisk 10 (latest version) installed*
[Magisk] FlintStoned-:
thank you. I uninstalled it and flashed magisk and phh superuser zip again. I still get the out of date binary but the apps have root access.

Unfortunately I don't pass safetynet 'Cts profile mismatch' :(
[Magisk] radar-a:
Update Magisk 10 but Menager don't want to save settings to use magisk hide.

WysÅ‚ane z mojego HTC 10 przy uÅ¼yciu Tapatalka
[Magisk] yochananmarqos:
Magisk v10 includes an updated phh superuser module, there's no need to flash the old one.
[Magisk] android_htc:
I flashed the latest version from here and passed SN:

https://goo.gl/cUXdrO
[Magisk] FlintStoned-:
I also flashed phh-superuser-topjohnwu-r1
[Magisk] FlintStoned-:
Screenshot
[Magisk] android_htc:
I had similar issue at first.. did you use the latest Magisk uninstaller?
[Magisk] knpk13:
Hope that everyone who's reporting a safety net error has checked all the other triggers that can cause safety net to fail. For example, having an unlocked bootloader will cause safety net to fail. Flashing a custom kernel with the safety net patch will fix that. Edit: Magisk includes the safety net patch, no custom kernel needed.

Or any other system mods that may interfere? Or you have Xposed?
[Magisk] jsaxon2:
You will not pass SafetyNet with xposed enabled.
[Magisk] finiterex:
I sure did... And have now fixed by I stalling magisk v10 again... No I do not know what exactly caused this but am investigating
[Magisk] Captain_Throwback:
Magisk patches the unlocked bootloader check (no custom kernel needed), so that wouldn't be the issue in this case. But other triggers, yes.
[Magisk] lover:
Guys i have magisk v10 and systemless xposed but not installed SUHide. As i have read if i flash SUHide after xposed i will get boot loop but in magisk v10 say if i choose magisk hide option is passes SN? Does it even with xposed and no SUhide?
[Magisk] knpk13:
Oh, excellent. But in that case, I'm failing safety net too. Updated magisk and phh su from within the app and enabled magisk hide. Stock OP3T Nougat, only mods are magisk and the following magisk modules: phh su, viper.Can't think of any other triggers.

Edit: I have decrypted my storage, and I have multirom installed. Could those be triggers?

---------- Post added at 10:36 PM ---------- Previous post was at 10:31 PM ----------

Magisk hide does not hide Xposed.
[Magisk] lover:
that's what I thought. So i have forgotten to flash suhide before xposed and there is no way to install it afterwards.

I wonder if RootSwitch v1.3.3.2 could do the job without suhide flashed
[Magisk] darkeyes22:
Will multirom work on custom roms? I'm on ASUS ZenFone selfie.
[Magisk] RoFrie:
I ended up with the same result on two phones: Nexus 6P and Pixel C.

Used magisk app version3.0 and installed Magisk V10. But after activating hide in the settings and reboot the setting is gone.

Both phones run an Android 7.1.1 with SU 2.79 SR1.
[Magisk] DrunphO:
Just a follow up... installed magisk 10 and manager 3 and is running smooth.

Btw, to pass safenet SELinux mode must be Enforced, use SELinuxModeChanger to set it.

Great job topjohnwu, many thanks to you and everyone that contributes.