yashsingh1/xdaforums huggingface dataset:
[Magisk] JimZiii:
Just got a galaxy s9 exynos, is it worth rooting? I've had magisk on all my other phones but my last phone honor 8 tripped safetynet with Google's update. So I'm basically wondering if safetynet still works on s9 exynos.

Also wondering if there's any way to root it without tripping knox, custom rom or any other way?

On twrp for s9 exynos it also said i got dm-verity which i need to disable, either through a kernel or one in a custom rom or a patch i found but that patch seems to disable factory restoring the phone.

So i need some advice on how to do this the right way.

Worst case scenario i can live without knox but not being able to factory restore my phone isn't really something i want to give up. I also read there might be custom roms that won't trip knox.

How did everyone else root their s9 exynos? Successfully and will safety net still work since i know plenty of phones still worked after my honor 8 failed.

Do how's the best way to get past my dm-verity, root and get magisk working.

Damn i wish i had a phone i could dual boot one with root and one without lol.

Also for clarity, i tried the s9 forum with little to no response or help which is why I'm here
[Magisk] monicaONxda:
Yes, I know, but I was wondering why I should hide BusyBox (have no problems with other apps re. detection...) it in the context of a backup...
[Magisk] Philnicolls89:
There are still ways to pass safety net on most devices, that is until we are no longer able to force 'basic' for googles safety net check. Unlocking your bootloader will trip knox, there is no way to root it or install a customer rom without an unlocked bootloader.

Below i have linked the thread for twrp s9, there are simple flashable zips that will disable dm-verity (no need to install a custom kernel or rom) and you will not loose the ability to factory reset your phone.

https://xdaforums.com/galaxy-s9/samsung-galaxy-s9--s9-cross-device-development/twrp-exynos-t3763464
[Magisk] bumpaneer:
[MENTION=4470081]topjohnwu[/MENTION]

Just wanted to take a minute and say thanks for v2. My HTC M9 now boots correctly (got stuck in a bootloop on v1), and both root and xposed are working as expected. Thanks for all your hard work!
[Magisk] grep_i:
Yes indeed.

You don't have to reflash anything if all goes well when flashing v2 over v1
[Magisk] bornlivedie:
Not working with Moto X 2014 (Victara).
[Magisk] steveo17:
just as you said. thanks!
[Magisk] joeyddr:
Still cannot toggle with purenexus rom.
[Magisk] devilloki:
so sadly!i am in stuck on RECUSE MODE after flash Magisk v2,,,,boot load is failed!

my phone is huawei honor7 PLKTL01H

fireware is emui 4.0.1 6.8.1

android ver is 6.0

in log file ,i found "when flash boot,no enough space"

upload log file,and boot parition info.
[Magisk] dtective:
Which banking app were you able to do this with?

Has anyone managed with Barclays?
[Magisk] kraoc:
On my S4 i9505 LTA I tried to upgrade v1 to v2 and my ROM (Cyanogen Optimized 13) fail to load.

I get Samsung boot logo, then ROM boot logo, then black screen... Must shutdown and reboot to recovery to flash v1.

Any idea why ?
[Magisk] Captain_Throwback:
Did you flash the updated superuser zip? The new app doesn't have a toggle....
[Magisk] nomadism:
Woops, my bad, please see my other reply.
[Magisk] joeyddr:
it kinda does.... when i click disable nothing happens and it stays mounted.

http://xdaforums.com/android/software/magisk-phh-s-superuser-android-pay-t3435921
[Magisk] garthybarthy:
V2 Magisk not booting on S6 Flat, stays on Samsung galaxy powered by screen, doesn't even boot to loading screen.

Understand from the OP post that S6 or later has been having problems with booting. V1 booted even though buggy.

Think I'll wait till its more stable.
[Magisk] nomadism:
OMG my bad. I had a brain fart and misread my own post. I have a Korean bank app (Shinhan bank, if it means anything) that detects all kind of hacks very aggressively, but now the bank app works flawlessly. Previous rely deleted. Srry.
[Magisk] topjohnwu:
Can people stuck at boot PLEASE

PLEASE provide the correct bug report for me to debug.

Instructions are in the OP, I think it is simple to follow.

I don't have your device so I cannot fix it.

If I cannot fix, how can I make it stable?:p
[Magisk] Captain_Throwback:
It'll never be stable if no Samsung user steps up to help get it working....:rolleyes:
[Magisk] dtective:
Hm. I am having the same issue with a British banking app. It just crashes; I have rootcloak but I don't think that's helping. Anyway, I'll keep looking for solutions.
[Magisk] garthybarthy:
Feel free... I'm sticking to system based, more straight forward and no messing around worrying if it's going to boot or not.
[Magisk] Chahk:
Flashed Magisk v2 and phh's Magisk compatible Superuser v2 over v1, and cannot find the Magisk Manager app. Tried extracting the apk from zip and installing via adb, only to get the error "Failure [INSTALL_FAILED_UPDATE_INCOMPATIBLE]".
[Magisk] Captain_Throwback:
Feel free to what? I'm not a Samsung user. If I was, of course I'd test.
[Magisk] topjohnwu:
Uninstall the old version then install the new one.
[Magisk] kotlin:
I think it's done automaticaly now, there is no switch in Magisk Manager 2
[Magisk] Rhoban:
Only SafetyNet is blacklisted by suhide automatically. For anything else you have to add the UID manually if you want suhide to work for that particular app. Read more in the suhide thread, first post.

---------- Post added at 09:39 AM ---------- Previous post was at 09:38 AM ----------

It is not done automatically. The switch has been removed.

There will be a different method in the next version.
[Magisk] WeirdSoup:
OF COURSE I DID. I'm not fool lol

Edit: if I add an app, then the app cannot call the su binary, but it seems it still can detect SuperSU itself and the xposed. (Of course, I reboot the device every time. I always read the description carefully.)
[Magisk] soder:
If you read it again, suhide say's to reboot again after being added to the list. I understand that as it will hide SuperSU.apk for the listed app.

About Xposed I don't know. What apps are looking for both root and Xposed? I thought it only was the SafetyNet that did that?

/Söder
[Magisk] LiviiYS:
Magisk manager 2.0 does not open on miui en mm version
[Magisk] Vivacity:
Lol seems like Google is attacking your work directly now, hope you hit them back hard for this :D:D:D you have all our support. waiting impatiently for it.
[Magisk] WeirdSoup:
I said I always reboot to apply the changes. Yes I can read the OP, as you can. But still many banking and game apps can detect the supersu. I don't know how they can do that.

So many Korean banking and game apps detect both root & xposed.(For example, if you want to play Nexon mobile games, you have to unroot AND uninstall the xposed also, or hide both very well.) They don't use the safetynet, using there own techniques.
[Magisk] soder:
I just noticed that info from http://xdaforums.com/apps/supersu/suhide-t3450396 about suhide and blocking apps wasn't correct for me.

"If you know the package name, ls -nld /data/data/packagename will show the UID - usually the 3rd column.

Similarly, for running apps, ps -n | grep packagename will also show the UID - usually the 1st column."

It wasn't the 3rd column, and I will now try to update my list with the correct UID's for my apps.

Maybe someone else has done the same mistake..

Edit: Now at least my CMore video app crashes or give me an error. Before it was just loading..

Also, I blocked the app Root Validator. This is how it says after blocked with Chainfire's SuperSU and suhide, Xposed enabled in Magisk.

EDIT: Also found this.. https://play.google.com/store/apps/details?id=com.loserskater.suhidegui

/Söder
[Magisk] negroxxx:
thank you very much for your work and dedication to magisk, admire your work from Argentina. thanks thanks
[Magisk] santajulia.ego:
Hi, first, tnx cos with this excellent app if you let me say it, (I don't know if I need said app or mod or something) y install it in the phone of my son, coz he want it to play pokemon go and still being root, I install the v6 and the phh-superuser, and all work fine till yesterday, he try to play and can't login, he try in the phone of a friend and login in to his account, then he came here and see the new v7 version, he download the magisk manager v2 and work fine, he said: the manager shows the current version and the available version, he chose the update, and the installation ask the reboot, he reboot and the phone crash in bootloop, hahaha, OK then my question is, he can use the v7 version to play pokemon or not?

And sorry if my English is to poor or if I can't express well, I really appreciate your patience and support.

Enviado desde mi Lenovo K50-t5 mediante Tapatalk
[Magisk] alexpower:
Pogo Actually only without magisk and xposed.

For me works phh r266 superuser beta.

Have root and can play pogo

Gesendet von meinem HTC 10 mit Tapatalk
[Magisk] Captain_Throwback:
Just to post/clarify this one more time -

On October 5, 2016, SafetyNet was updated. It now detects both Magisk (any version) and SuperSU/suhide. It was previously updated to detect Xposed. The only working way to have root (right now) and pass SafetyNet is to uninstall Magisk, SuperSU & Xposed, and install phh's superuser-r266-hidesu zip and Superuser app.

There is no way to use Magisk and pass SafetyNet.

There is no way to use SuperSU and pass SafetyNet.

There is no way to use Xposed and pass SafetyNet.

I hope this clears things up for everyone and helps cut-down the repeated questions in the thread.

[MENTION=4470081]topjohnwu[/MENTION] has stated that he is already working on a bypass for these latest SafetyNet updates for Magisk. Your patience is appreciated as it's being worked on and thoroughly tested.

NOTE: With the next (future) update, Magisk will pass SafetyNet, but Xposed still won't as it requires more than just simply hiding it to avoid detection.
[Magisk] CrazyCypher:
Thanks for the clarification.. So if he successfully complete the module, the Xposed framework 86.6 will also work and pass safetynet, correct? Because Xposed is magical module in this latest version right?
[Magisk] Captain_Throwback:
No. Xposed itself is a different type of modification, Magisk module or not, that cannot simply be hidden to bypass SafetyNet.
[Magisk] soder:
Will that bypass work with SuperSU, or shall I already prepare myself with switching to phh's root instead?

Also, the phh's hidesu, is that "root+hide" all in once, or like to zip's, one for root, one for the hiding?

/Söder
[Magisk] CrazyCypher:
So the Xposed will not be able to pass SafetyNet no matter what? To disable it and reboot will always be an option right?
[Magisk] devilloki:
thank u. it work fine.
[Magisk] Captain_Throwback:
The bypass *should* work with either root method. Testing is ongoing.

Disable and reboot will be an option, yes. I don't know if the Xposed situation is impossible to overcome (yet) with the new solution. Testing is ongoing :).
[Magisk] CrazyCypher:
Great :) I keep my fingers crossed :)
[Magisk] Andr3w151:
With the new Magisk Manager how do I toggle root?
[Magisk] J.Michael:
I think: You mentioned Busybox as an app you thought might allow you to make a backup. (I don't think of Busybox as an "app", but we're pretty deep in interrupts as it is.) [MENTION=7786725]zgfg[/MENTION] was just pointing out that, if you have to install Busybox (as opposed to already having it on the phone), you should do it by using the Magisk module "Busybox NDK", so that you could hide Busybox. Hiding Busybox isn't part of the backup process. It's to keep you from failing security checks you are currently passing, after you add something to your phone to allow backups.

As far as using Busybox to make a backup: I don't think Busybox includes a comprehensive backup solution. If it includes "dd", you should be able to make copies of all partitions. That would be an ugly job, and you would need to be rooted when you make the backup, and again when you restore the backup. And I'm not positive it would work, it just seems like it *should* work.

---------- Post added at 22:06 ---------- Previous post was at 21:55 ----------

Maybe it would help if you would explain why you want to install Magisk from the command line, instead of using the more common procedures.

If you use one of the more common procedures, I think it is made clear in the instructions at which point you must format /data to remove encryption (probably after making sure you uncheck the "Keep encryption" option at an earlier step). Once you have done this once, maybe your command line install will succeed.

If you want to pursue your current approach, explain in more detail what this "last step" is to which you want to be pointed. I looked at "get_flags" just enough to see that the variables you named are set based on the state of your machine. That is, while I initially assumed they were just flags saying what you wanted (like checkboxes in a GUI), I now believe they are reporting what is already the case, so just changing them doesn't change anything meaningful.

Have you tried formatting /data? (Are you prepared to restore your phone if you ruin the current installation?)
[Magisk] H113408:
First of all, thanks for taking the time and digging into the source code. In my case I learn a lot through this process.

The common procedures, Magisk Manager or Custom Recovery (twrp) both works well when updating Magisk and don't need the user to format /data after the update. I'm 100% sure about MM but not so sure about Twrp, but I think it should be the case.

I would like to challenge the status-quo and be able to do it myself without relying on other tools. Because 1 I don't have a custom recovery and 2 it's possible to do it without one (Magisk Manager is a normal app that can do it)

I think the last (or maybe first?) step is to remove the encryption from the current image. I know this is possible because I've found the likes of "disable-no-verity-forceencrypt.zip" files. By looking into there code, it seems as they check on FSTabs entries and replace the encryption. From the code of [MENTION=5672995]jcadduono[/MENTION]:

#!/sbin/sh

. "$env"

print "Disabling forced encryption in the fstab..."

found_fstab=false

for fstab in fstab.*; do
[ -f "$fstab" ] || continue
print "Found fstab: $fstab"
sed -i "
s/\b\(forceencrypt\|forcefdeorfbe\)=/encryptable=/g
" "$fstab"
found_fstab=true
done

$found_fstab || print "Unable to find the fstab!"

exit 0

This is a flashable zip, but I believe I could translate this part of code to run it from ADB. So far I'm able to get the location of the fstab. (I think :/)

:/ # [ -L /system/vendor ] && VEN=/vendor || VEN=/system/vendor
:/ # FSTABS="$(find $VEN/etc -type f \( -name "fstab*" -o -name "*.fstab" \) | sed "s|^./||")"
:/ # echo $FSTABS
/vendor/etc/fstab.qcom

If I format /data it works of course but it's not what this is about. I just want to replicate what MM is capable of in another way. I have a phone just to solve this issue and ruinning/repreparing it is what I spend most of the last few days doing :o
[Magisk] Didgeridoohan:
[MENTION=5904560]H113408[/MENTION] Just to be clear, Magisk or those zips you're talking about do not remove encryption. They disable enforced encryption and make it optional. You still have to format data after to remove encryption.
[Magisk] H113408:
Thanks for making that clear. I'm still curious to know how Magisk Manager is able to update magisk without the need to format data afterwards.

[MENTION=4470081]topjohnwu[/MENTION] declined to help me figure it out, I'm guessing it's because it can be used in bad way ?
[Magisk] KrautHolg:
Magisk Update to Magisk to 20.4 (20400) and Magisk Manager to 8.0.2 (307) (11)

Deleted
[Magisk] zgfg:
Why should be a problem. You boot to TWRP, it asks you for your Android sccreen unlock pin, and by use of that, TWRP properly sees Data, Internal memory and can work with them (backup, installing zip files, etc). Ofc, you must have TWRP supporting that for your device. That way you don't need to remove encryption and format Data

Regarding your approach for modifying /vendor/etc/fstab* via adb - be aware that on e.g. read-only SAR devices, /system/vendor is read-only and you can not make permanent changes (only systemless overlays by use of Magisk)

Therefore, system will reboot reading unmodified fstab files (before the Magisk mount takes place), hence no use of your changes

Check in the same fstab file if /vendor (or /system if vendor is not a filesystem) is ro=read-only
[Magisk] Groover_0815:
Hi everyone,

I am running in Magisk 8 / Module v20.4 and I have Problems to Install v21 on my op8 pro with Android 11.

Have anyone a solution for me??

Best regards
[Magisk] H113408:
After number of tries: flash -> brick -> reflash origin -> repeat. I was able to flash the same magisk version (19.3) with $KEEPFORCEENCRYPT= false and $KEEPVERITY=false without the need of formatting /data. Technically it is a different boot.img (before these 2 environment vars were returning true). However even with KEEPFORCEENCRYPT returning false, when I flash the other version of magisk (20.4) I still stuck on the Logo and see that /data/data is encrypted.

It's been just few days since I got into this topic, am I missing something ?

I thought by having the existing image with KEEPFORCEENCRYPT=false, I would be able to flash anything without the system complaining ?
[Magisk] zgfg:
As answered by others as, it's not enough to change the option

I always use patching and flashing and as it long it was available (recently the options were removed from MM patching, noe they are "hardcoded') I used Enforce AVB and Enforce Encryption.

I have also TWRP asking for Android screen unlock pin, hence I could also flash there, and I was never interested in removing encryption from local sorage (on my current phone - two years ago I did it on my previous phone to be able to fully use TWRP, did it also by editing fstab, then reformatting Data, reflashing my stock firmware and restoring things from various backups as much as possible - on that phone my /vendor was not read only)

I don't get why you need to remove encryption - usually you only need when switching to custom ROMs, but then there is a procedure how-to (not using Magisk)
[Magisk] westeight:
Has anyone managed to get their S20 Ultra to pass SafetyNet using the latest Magisk + Manager?

Even using the Magisk Props Module, all I get is:
[Magisk] Didgeridoohan:
Funny... I just replied to a similar query in my module thread:

https://xdaforums.com/apps/magisk/module-magiskhide-props-config-t3789228/post83679103#post83679103
[Magisk] J.Michael:
more likely because he's up to his ass in alligators
[Magisk] J.Michael:
You start with Magisk installed. Is /data encrypted?

(While we're at it, how do you tell if /data is encrypted?)

When you said "command line", I thought you meant a terminal emulator on the phone, not ADB.

Maybe try a terminal emulator on the phone.

Maybe set user to Magisk Manager's UID.

Is [MENTION=5672995]jcadduono[/MENTION]'s code the disable-no-verity-forceencrypt.zip file? Is this supposed to be run (flashed?) in TWRP after "flashing" the Magisk install zip?

Are you sure you understand the environment when TWRP is running a zip file? I mean, TWRP is an Android system, doesn't it have its own "/system" and "/data"? Whose "fstab" are you modifying?

What is "env" set to?

Is that line setting "FSTABS" really right? You don't have to escape the quotes in the "find" command to keep them from interfering with the quotes around the "$()"?

What happens when you let Magisk Manager reinstall/update/replace Magisk? Does it reboot? Or does it tell you it's done, but you have to reboot?

When you run in an ADB shell, can you capture a log file? (Use "set -x" to get a full display.)

I know, I'm all over the place.
[Magisk] zgfg:
Hiding Magisk Manager 308 Canary:

1) If on Xiaomi, enable Install via USB in Developers menu, see:

https://www.didgeridoohan.com/magisk/Magisk#hn_Cant_hide_the_Magisk_Manager.

This is a new requirement and it will probably stay for the future Manager releases

2) No matter on Xiaomi or not, the following bug prevents hiding the Manager Canary 308:

https://github.com/topjohnwu/Magisk/issues/3297

As long as not fixed (probably the next Canary Manager release), you can use the following workaround:

- Uninstall Magisk Manager (don't worry, you will not loose your modules, SuperUser or Magisk Hide settings)

- (Temporarily) install Manager Beta 307 from:

https://github.com/topjohnwu/Magisk/releases/download/manager-v8.0.2/MagiskManager-v8.0.2.apk

Just switch Manager to Beta, keep your Magisk on Canary 21002.

If popped-up to allow Install from unknown sources, confirm

- Now, take Hide Magisk Manager from the just installed Manager Beta 307.

If (on Xiaomi and if) popped-up to allow to Install via USB, allow

- Once the stub is installed, follow the instructions (to manually open the stub and to continue with download and installation).

I didn't disable Play Protect (took Install anyway) and didn't have a problem.

You don't need to install the offered Shortcut at the moment, we'll do it later

- Once it completes the installation of repackaged Manager Beta 307, change the Update channel to Custom:

https://raw.githubusercontent.com/t...400981629877a5bab9afcc55507ae9a1f1/debug.json

It will show you the Update for Manager to 308, take it

- Once it updates to Manager 308, change Update Channel to Canary.

If Magisk hide not enabled, enable (mine was enabled).

Also, from Manager Settings, you can now take Add shortut to home screen, to obtain the second icon with the usual Manager look

-As a result, you will have properly hidden/repackaged Canary Manager 308 with your Canary Magisk 21002, all your previous modules, apps previously given SuperUser grants, and apps enabled for Magisk hide.

If you click on SafetyNet check, you will have to (just for this first time) to allow downloading the code

Notes:

a) All GitHub links are to the official GitHub Magisk project

b) Repackaged Manager comes with an unusual, Android default icon. Use the mentioned Shortcut to obtain the usual Manager icon. This thing with the icons is a new 'feature', not related to the workaround hiding procedure (2)
[Magisk] killerBRs:
After Installing 21.0 Magisk Manager App, Bank Apps like C6 Bank, Next/Bradesco/Inter, and Others doesn´t open, even the device is not rooted.

After Unistalling Magisk Manager App, Banking Apps Back to work. This is normal?
[Magisk] zgfg:
It just means that you have to hide Magisk Manager - the apps look for, find and conclude that Magisk must be installed (thinking that otherwise, why would you install Magisk Mansger) - more about how some apps may guess that your phone is rooted can be found in the Guide:

https://www.didgeridoohan.com/magisk/HomePage
[Magisk] H113408:
From a clean install, no custom recovery, no magisk, I created a patched boot.img and patched recovery.img using ADB (patched = Magisk). During the patch, I supply KEEPFORCEENCRYPT=true and KEEPVERITY=true. Then I flash these 2 files + vbmeta.img using Odin. Remark, depending on the device, the images can differ. After the image is flashed I reboot into recovery (stock recovery), and do a factory reset.

After rebooting to the system, I have Magisk on the phone :), The problem is when I try to update the magisk version. As I mentioned before, even when I'm able to change KEEPFORCEENCRYPT to false, flashing a new version requires me to do a factory reset.

To tell that /data is encrypted, I just ls inside /data/data and instead of seeing folders as com.xyz.app I see +QECsa2LLM0NdVAXtKUM2u4LdYruxQzXJLMWkTalQSK

This would not change much. I run as Su through ADB and have ALL the rights :cowboy:

yes [MENTION=5672995]jcadduono[/MENTION] code is supposed to be flashed through custom recovery after being stuck in the recovery. Not all TWRPs are able to decrypt /data partition.

My guess is that most of the things that can be done through TWRP, can also be done from the system itself. There are many projects regarding this point (and some available APPs)

Regarding Magisk Manager, I will try again tomorrow and keep you updated.