yashsingh1/xdaforums huggingface dataset:
[Magisk] IronTechmonkey:
Yes, which is to the point of why I mentioned it. If that didn't work that way I would have been in this thread asking for more advice long ago. :)

Ahhh, I thought I had noticed that yours and @J.Michael's instructions could be done on the device without PC which is indeed helpful for this type of testing and work, but in my case with access to the same computer which regularly connects to the device and has previously been used to refresh, it might be best for me to stick with the work routine I'm familiar with. Thanks for the details which helped make that decision.

I don't understand the workings and history of Magisk development as well as you; I mentioned Zygisk because the change log indicates a change to a component of Magisk (Zygisk) which is required for the functionality which happened to break after the update. A logical although admittedly unproven possible connection.

Here is the catch regarding testing. Although I'm familiar and comfortable with this sort of bug testing, after having reviewed change logs, github reports and XDA threads I updated to a release version expecting no break in functionality. To be clear, this is not a complaint since we know such things can happen, but I'm not presently prepared (specifically with availability of device) to test from a debug build or switch to beta channel on this device at this time. That being said, before reverting back to 26.4 I could do some general testing and logging in the stable version, share it here, then see if it lines up with any other reports. Thanks again for your advice.
[Magisk] pndwal:
Mmm... You said "which incidentally removes root and then I reinstall magisk..." Comment was just to explain why that's a given.

FWIW, Magisk does actually recommend bypassing app signing checks by using direct install (retaining root) via a Debug build:

https://topjohnwu.github.io/Magisk/build.html#signing-and-distribution

... Version check bypassing (for downgrading) just happens to work the same way...

Use of .zip installer (install as module) isn't mentioned but is a useful option too.

Well the change you refer to is refactoring to use native bridge device to load Zygisk, and it's doubtful that this is really your issue... Here's the PR: Refactor zygisk to use native bridge to inject, core enhancement, yujincheng08 opened on 2 Mar 2023...

And commit: Refactor zygisk to use native bridge to inject Co-authored-by: vvb2060, topjohnwu, 3 people committed on 7 Nov 2023.

I've been following this development in Shana's Metagisk Zygisk test fork over the last year and running Alpha (which built her NB-Z commits) until this was merged in TJW Canary 26402 (at which time I moved back to official Canary), so I know it works well with Shamiko and other LSP Dev mods and haven't experienced issues personally...

To check if Zygisk is the issue in 27.0, suggest you try 26402, first build with

[Zygisk] Introduce new code injection mechanism

but lacking these major changes since 26.4

[Zygisk] Support new signature introduced in U QPR2

[SEPolicy] Update libsepol to properly set some policy config bits

[MagiskBoot] Support compressing init so Magisk is installable on devices with small boot partitions

[ResetProp] Add new wait for property feature resetprop -w

... Could well be an issue/regression related to one of these...

Sure... But if you're up for a small challenge, please consider downgrading to selected Canary builds as suggested above (using .zip as module it's a pretty simple process) to narrow down problem commit(s)/change(s).

👍 PW
[Magisk] Frans:
@pndwal, you asked for this info. Any idea why I cannot update (or what I should do to update)
[Magisk] badabing2003:
This happens when you uninstall Magisk App, but the root portion is still there, it automatically installs the stub.

And because the root portion is 26.4 it installs the 26.4 stub, and when you launch, it asks to install the full version, which ofcourse is going to also be 26.4

After it shows 26.4 it should also detect that there is the app update, why not update there and end up having 27?

What exactly are you trying to do? upgrade from 26.4 to 27?
[Magisk] Frans:
@badabing2003 I am trying to go from 26.4 to 27.0 and I have tried virtually everything I could think of, except for uninstalling magisk itself.

If I press the update button within magisk manager (by pressing update) it downloads 27000 but nothing happens.

If I fully uninstall 26.4 manager(so both the manager and the stub and then install 27.0 from the 27.0 apk from TopJohhnWu github it installs the stub. If I then click on that stub it asks me if I want to install the full manager,. I select yes and it installs the 26.4 manager.

I'm totally confused what is happening. Could it be that there is an update to the apk for 27.0 but that the full manager version 27.0 is not available for my architecture (I'm using a 2016 Samsung SM-T580 tablet running LineageOS 19.1)

PS: Earlier I used the update button before to go to 26.4
[Magisk] J.Michael:
The one you have vs. the one you are installing: both stable? both debug? Which update channel is selected in the installed manager?
[Magisk] badabing2003:
If you're up to it, do two things (also @J.Michael 's question is relevant)

1- Uninstall Magisk app

2- Install TB Checker (From Play Store) and run Xposed Check, and see if it detects any magisk, and see what package name it displays.

3- Uninstall every Magisk it detects, it will also detect any hidden ones and tell you the package name, uninstall them all

4- Reboot

Check again, the root portion should reinstall the stub, just launch it, and it should ask you if you want to install full version

Choose yes, then launch it.

Take a screenshot.

Optional but would give us details about your setup

Run PixelFlasher (from my sig) connect your phone to the PC and scan for devices, and select your phone

Create a support file.
[Magisk] Frans:
Afaik both are stable, note that I also installed the manager from scratch.

In the manager the installed channel is empty, I set it to stable but still update does not work
[Magisk] Frans:
I already did all of this as suggested by @pndwal , screenshot is here https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-89344456

I'll do the pixel flasher thing tomorrow

Oh I used root checker basic instead of tb checker. Uninstalled all. And I never used hidden magisk
[Magisk] badabing2003:
Please check with TB Checker

And what happens when you click on the Update button in Magisk?

It doesn't get updated to 27?
[Magisk] Frans:
as mentioned before if I update using the button it does download but not install.

Somehow if I uninstalled everything TB checker and Applist detector would say everything is gone.

However if I then rebooted the 26.4 stub got installed again.

Eventually I decided to remove magisk completely using the app; then downloaded and installed the 27.0 app,

That showed magisk was gone so I patched boot.img and flashed it and now I am good.

Everyone: thianks for your support!
[Magisk] IronTechmonkey:
Points taken. I made the association based on seeing the word zygisk on the screen - not exactly a solid diagnostic connection to anything. :D

Drool, (as Homer Simpson would drool when dreaming of donuts). I love a good process and you've laid it out so well, with a framework and discrete targets for testing; I almost feel guilty that I cannot do all of that at the moment, almost guilty, but in going back to Magisk 26.4 I may have learned something useful. With a bit of background...

There are only two apps from which I've ever hidden Magisk and or or used the deny list. One is a widely used banking app which is a good citizen regarding root restrictions as it reported limitation when it encountered it. The other app is a security camera app which has been a bad citizen on the device in many ways including failing without notice on the root devices after a particular app update. Since that moment, a year or two ago, the deny list and or hiding Magisk have been required for this app to run. It was not required to also hide root from any Google apps or services. The point of all this being: this is a small sample size for testing and involves an app which already behaves a bit badly.

Here's what I noticed after the re-installation.

- Magisk app > complete uninstall (after unhiding).

- Immediately upon uninstalling Magisk and removing root the security app started working. This was important to determine because of the untrustworthy nature of the app, not any concern about Magisk.

- Installed Magisk app 26.4, patched boot for matching set at 26.4, reboot.

- Enabled Zygisk, reboot.

- Restored the security camera app from SBU.

- Magisk app > Enabled deny list and found the security camera app selected in the list.

- Tested security camera app expecting it not to work until after magisk was hidden and device was rebooted but it worked fine after simply enabling deny list.

In the past, at this point I would also hide Magisk and reboot as instructed but now only had to enable deny list and confirm it was in list.

As for more testing of 27, I might have a slightly older android 10 device (cracked screen) which could be used to attempt reproducing the issue, time permitting. Thanks again for providing such detailed and well organized advice.
[Magisk] pndwal:
Doubt issues is to do with 'architecture'... I've noticed that update app from within app often simply fails (may be device related) and one needs to fully close (not uninstall) the older app, find the new apk in download directory (or download fresh) and install from file explorer... In this case running Daemon shouldn't try to force stub installation (matching old Daemon/Magisk version) and app should open and allow you to take Direct Install to update Magisk core/mask after that...

Having said that, I'm not sure why existing Magisk is forcing "complete app" installation after installing new apk... Seems opening the app is triggering the daemon but it can't recognise the updated full app, so there may be other issues... Not sure why Zygisk is disabled either... Can you enable that or is it broken?...

If the above method (install from file manager with app closed but w/o uninstalling it) doesn't work, suggest you try the following (assuming working 26.4 installation):

1) Reset Magisk configuration by deleting /data/adb/magisk.db file and /data/adb/magisk directory contents and rebooting... Magisk configuration files will be rebuilt (modules will persist, but need to set up superuser apps, denylist etc fresh; alternatively, deleting everything in /data/adb will remove all configuration data incl. modules)... Try to install 27.0 from file manager (with 26.4 app closed but w/o uninstalling it) again...

2) If still no dice, flash Magisk 27.0 (core/mask) from within App as a module (method 2. I outlined here: https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-89168686 )... After that, you should be able to update the Magisk App without any drama even if daemon forces stub installation.

Hope this helps, 🤠 PW
[Magisk] pndwal:
Haha, just saw this!...

Yup, that's what it's supposed to do... But not force stub after updated app is installed however...

Glad you got it sorted/bypassed the issue... Hope something in post above may help you understand that issue anyway... Also, the post I linked may be useful for upgrading or changing versions using existing root when issues are encountered in future... 👍 PW
[Magisk] traversone:
but has anyone checked if its kernel makes PlayIntegrity fail (due to Google ban) ?
[Magisk] pndwal:
Issue was with upgrading Magisk, so not sure why failing PI DEVICE_INTEGRITY might have anything to do with the price of fish... 🤔 PW
[Magisk] J.Michael:
What kernel? What Google ban?

Are you talking about @Frans' situation?
[Magisk] Cipcino81:
Maybe he was referring to the previously discussed lineage 18.1 / shamiko 1.01 incompatibility (that should have nothing to do with magisk) and got confused ? 🤷🏻
[Magisk] traversone:
my fault, sorry !!!

I wanted to post in separate Hades ROM development who suffers from the kernel ban, nothing related to Magisk itsel!

sorry again, my fault
[Magisk] Cipcino81:
No problem 👍🏻
[Magisk] Frans:
Not sure if this was aimed at me, but yseterday iTB Checker said that play integrity was unevaluated.

Today TB checker just reports an error...

Zygisk was not enabled. Apparently this is the default. I could enable it. (not fully sure what it does and how it would help me though)

Also it could be that my original issue was caused by interference between Magisk and TRWP (or the order they were installed).

I'm nuw running 27000, it did not mention that the update to 27001 is available on stable.

I'm curious to learn if that upgrade would work.
[Magisk] pndwal:
Needed for many modules that inject code (into app zygote) like PIF module... Could explain why you're not passing DEVICE_INTEGRITY, but unevaluated is likely caused by another issue... I just wondered if it was broken as could be an indication of corrupted configuration, but maybe not....

Perhaps... especially if both recovery and Magisk are in /boot or in /recovery together... Need to follow instructions for recovery installation properly... What tablet is it?...

xx001 versions generally just syncs Canary commits with public releases so it's not really an upgrade... 27002+ would be a proper upgrade... You can move to Canary at any time however, but since public releases lack Canary channel in app you need to manually install Canary app from GitHub main page first... 🤠 PW
[Magisk] Frans:
The tablet is a Samsung SM-T580 (TAB A 10.1 from 2016). The tablet is running LineageOS 19.1 (Android 12)

No idea if I made a mistake installing TWRP and Magisk.

Wrt play integrity

TB Checker says

Basic Integrity Fail

Device Integrity Fail

Strong Integrity Fail

Virtual Integrity (Device is emulator?) Fail

Play Licensing UNEVALUATED

PLAY Recognition: UNEVALUATED

wrt the 27001 version: I'm not planning to change the channel, will wait until 002 comes out and report back if I again hava a failure.

Thanks again for your help and info

Frans
[Magisk] pndwal:
Doubt it now... Old legacy ramdisk boot type device... TWRP will be in /recovery partition and Magisk in /boot... Should be no conflict...

So try enabling Play Store Developer options (click Play Store version 5+ times) and run General, Developer options, Check Integrity... This isn't subject to the call quota restrictions 3rd party apps normally have...

27002 will be Canary, not a public build... You'll be waiting for 27.1 (27100) for updates on public channels.

👍 PW
[Magisk] Frans:
Enabling Play Store Developer did not result in different behavior.

If I am not connected to VPN I still get the fails.

If I am connected to VPN (PIA) I get

Something went wrong

Error request to server.

Guess the IP address of the VPN server is blocked.

Anyway, it is unclear if/how this would be a problem for me

I have no problems with the Play Store or the apps installed on the tablet.

And yeah, it is old, that is why I installed lineage on it so at least it would be more recent wrt Android and security updates, However my use of the tablet is light so as long as it is working, there is no need to upgrade ;-)
[Magisk] shohabmsk:
I'm sad this issue is still present in Magisk 27 and Delta. I've tried issue reporting in github but can't take logs on boot because I don't have TWRP and adb doesn't work at boot time on stock firmware. Also don't know more. My issue automatically closed.

I've also asked few devs to report to official magisk devs but maybe they forgot.

Please if anybody has contact to original devs would be helpful if he reports to them. This issue is happening with A12 users too, I've checked with Telegram group of Exynos 850.

Thanks anyway.
[Magisk] pndwal:
Suggest you copy issue and open a fresh one with "version code: 27001" in the text body... Bot will always close it if you don't follow the template / use Debug version code... Also, install Debug from main Magisk GitHub page, check you have the same issue and save logs from the Magisk app, then locate and attach them... Don't supply logs from other builds, only from Debug (has verbose logging) or Devs will close your issue... 👍 PW
[Magisk] SerjP:
Hi guys,

Sorry, noob here. Can someone point me to the right direction (RTFM or anything like that) about the thing that Magisk resets the value set by

shell settings put system screen_auto_brightness_adj -0.3

I'm on LineageOS20, when I set brightness adjustment value on clean system that's works good. But once I installed Magisk (tried 26.1, 27.0, Kitsune) and rebooted I noticed my screen become brighter and the next line

adb shell settings get system screen_auto_brightness_adj

started to return 0.0.

Tried to change value under root, tried adb root / remount / shell, all with no luck. Do I really need to put that shell command into Magisk's 'service.sh' or anything like that? Why does it reset to zero?

Thanks!
[Magisk] J.Michael:
Don't you have a brightness slider under Settings -> Display, or at the bottom of the notification shade when you pull it all the way down?

How is that not as good for you as setting the brightness from the command line?

Have you explored "properties"? Look for a command "getprop".

I've seen references to a Magisk module that changes properties. Search the thread.
[Magisk] SerjP:
Yes slider is here. I can reduce brightness with it. But after some time (or lock/unlock) slider get back to its initial position. I suppose that adaptive brightness algorithm should learn my preferred brightness levels I set manually with slider and over time it should adopts auto-brightness accordingly. Unfortunately that does not work. Every night I move slider to lower the brightness at night because it doesn't learns. Not sure if it a device specific or Lineage specific issue.

setting the brightness from the command line - well, can do that (I found some brightness property) but auto-brightness algorithm will overwrite it on next environment light conditions change. While using auto-brightness we should avoid manipulating brightness property directly, but should somehow affect auto-brightness algorithm. And that 'screen_auto_brightness_adj' is specially made for that.

yep, tried to export all props to txt file and then search it for 'brightness'. Only found that:

[debug.tracing.battery_stats.brightness]: [0]
[debug.tracing.screen_brightness]: [0.16584474]

it is simple brightness property that will changed constantly by adaptive brightness.

will look into it. Still not really understand what 'screen_auto_brightness_adj' is? Is it a property? getprop does not returns it. Therefore magisk module for properties won't help? If not property then is it a system variable?

BTW, thanks for the suggestions!
[Magisk] Nergal di Cuthah:
I don't think it does, if you want a certain brightness turn off adaptive brightness; which, to my knowledge, uses the ambient light sensor and doesn't learn.

I maybe wrong

I've not experienced it doing anything on my p6 but making the brightness too much
[Magisk] J.Michael:
As @Nergal di Cuthah said, I don't think adaptive brightness learns, it just sets screen brightness according to what it perceives of your environment. I always disabled it because I hated the screen suddenly dimming. Then I tried to use my phone in bright sunlight. Now I leave it on on the phone.

I have no idea what this thing you are trying to set is. I was just saying that if it is a "property", I expect "getprop" to be able to display its value, and you might get some use out of a module I remember reading about.

I also do not recognize the command line you quoted. I had never heard of a "settings" command. You'll have to research it to find out what it means by "settings". (Turns out I have the command, it apparently requires privilege to execute it, and it does not provide any "help" when run with the "--help" switch.)
[Magisk] SerjP:
nope, if adaptive brightness is turned off then phone always stays with the same brightness regardless of lighting. Just checked it.

yes exactly what I read about adaptive brightness from Google. Not sure if it really works or only declared as working, lol.
[Magisk] Nergal di Cuthah:
just settings or settings help no -

Spoiler content hidden.

Can't @SerjP use tasker for this?
[Magisk] SerjP:
you can try this to see all the system settings:

adb shell settings list system
[Magisk] SerjP:
Not sure if this question is for me or for J.Michael.

Actually setting the 'screen_auto_brightness_adj' for freshly installed LineageOS works as it should and don't resets over time / over reboots.

But installing Magisk somehow breaks it. So I'm trying to figure out how Magisk works. And is it expected Magisk behavior or not. I did not tried anything from Magisk Boot Scripts section. Not even understand should I try that or I'm doing something wrong.

Not sure if tasker (whatever it is) is overkill or not, as Magisk already supports some kind of configuration during boot, so I can use that instead.
[Magisk] Nergal di Cuthah:
Installation of magisk should not touch your settings, do you have any modules installed?
[Magisk] SerjP:
Nope. Tried clean experiment: Installed Magisk app only, did not even patched the boot image. And after reboot the 'screen_auto_brightness_adj' reads as zero.

Spoiler content hidden.
[Magisk] ZG_DEV:
Hi, I have a problem with updating magisk.

I was trying to upgrade from magisk 26.1 to 27.0

I have installed magisk using patching boot.img method. Trying "Direct install" to upgrade just does nothing, the log is fine but magisk 27.0 isn't installed on my boot.img for some reason.

When I open magisk after a reboot, magisk simply shows up this message:

Tried again after this message appeared, the update wasn't applied.

Tried to patch stock boot.img then flash, it made my phone goes into bootloop. Got fixed by flashing the previous boot.img that was patched by magisk 26.1

Any solutions??

+ I was thinking about taking the patched boot.img by magisk 26.1 and patch it manually using magisk 27.0, then flash it manually, but will this cause a bootloop or a brick ? Or it is safe ??
[Magisk] J.Michael:
Do you have any modules installed?

Disable all modules before flashing the newly patched boot image.
[Magisk] J.Michael:
This is the first time I picked up on the fact that you are getting the setting changed when you install the Magisk manager app, not when you install Magisk into your boot image.

Doesn't do you any good, just makes it screwier than it already was.
[Magisk] pndwal:
There are clearly peculiar upgrade issues with latest Magisk, but symptoms vary wildly... Please say device... Did you ever see "Recovery Mode" offered in Magisk App for your device?... Ever take Direct Install to update with that selected?...

Somehow 26.1 binaries are still showing after update so re-flash can't update, and message may be in error anyway... This recent issue shows boot image isn't recieving 27000 (27.0)/27001 binaries properly or at all in some cases: Root not found after flashing patched boot img... May be another issue too... Please give details of device/ROM anyway. 👍 PW
[Magisk] ZG_DEV:
Ok

Device : OPPO A5s

Codename : CPH1909

Rom (UI) : ColorOS v5.2

Android : 8.1.0
[Magisk] ZG_DEV:
Yes, a lot

Ok, will try (y)
[Magisk] ZG_DEV:
Disabled every module I have, reflashed, didn't work.
[Magisk] SerjP:
Updates on my issues with auto_brightness:

Flashed stock again, then LineageOS20 - and got the same strange behavior - 'screen_auto_brightness_adj' value get reset to zero once clean system boot to launcher :rolleyes:

Now it is clear it is not Magisk issue any more. Sorry, I don't understand the way it worked before on my LOS20+microg ROM. Need more experiments, but now it looks like offtopic for this thread.

Thank you all who tried to help!
[Magisk] Caniv:
Last time i used "update after OTA" I bricked my One Plus 7 Pro.

What's the best way to backup everything before i do this again? And what's the current way to use that update method?

Thank you!