yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Yup, Hide the Magisk app function removes full Magisk app, installs a tiny stub app and populates it's data with the Magisk binaries etc... You had opportunity to rename it from 'Settings' (default) to a custom name and It has an obfuscated (random) package name...

Yes, Weird...

Stock Android began using shared blocks / dynamic partitioning since Android 10 and generally lock system as ro... Best solutions use Magisk's (recently reworked/improved) Magic Mount which uses overlayfs to allow modules to 'modify' partitions... Of course Magisk is a 'systemless' solution as really doesn't (need to) touch /system...

There are Super Image tools available to 'Universally Mount System read write for Android 10+ ROM w/ SUPER or NO_SUPER' partitions / extract or make partitions RW in super partition... Things have clearly continued to get harder and harder to write to /system, but you can check this:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-86243253

FWIW, I found older info I posted re. problems getting r/w /system at least w/ stock Android 10 or later any more due to shared blocks implementation:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85049195

... and re. Magic Mount, the way to 'write' to /system w/ Magisk systemlessly.

You could possibly rebuild whole filesystem to overcome OEMs locking /system to read only (by using an automated bash script by XDA member @lebigmac to "Universally Mount System read write"... BUT (big but), you MUST be adventurous / maverick / a 'Power User' / know your stuff as mentioned.

However you should be able to make just about any needed changes to /system systemlessly using Magisk

without the myriad issues/pitfalls inherent in R/W mounted /system

... Of course for simple property manipulation @Didgeridoohan's MagiskHide Props Config module is probably all you need, but you can overlay /system (hence Magisk description 'The Magic Mask for Android') with just about any files / code using Magisk Tools provided.

Interestingly, the link following refers to how John Wu has even overlayed a stock system with an entire custom ROM as Proof of Concept for a projected Universal MultiROM (Magisk powered custom ROM)... Unfortunately he didn't take that much further...

I posted (earlier) info on these two methods here:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84859571

🤠 PW
[Magisk] flesheatingbeatles:
Ahhhhh now I totally get it. Part of the rooting part of my brain is literally still in 2015. I really need to do some updating.

yeah I got this to install courtesy of module manager from androidacy like a good little open source development supporter. It copies .apk to a directory under /data/adb/modules parallel to where busybox is but I still haven't seen my apps running as root. I still have to learn how to execute them from there as root, and whether to delete the originals. Thanks

Quite the gem, isn't he? Whether he stalled on something or not. Rogue Genius Googler times infinity.
[Magisk] J.Michael:
Could you explain what "terminal_systemizer" is supposed to accomplish? I can't make sense of your comments.

Creating a subdirectory of "/data/adb/modules" *is* installing a module. (I know, some modules actually have initialization code / scripts, but just creating the directory provides the file overlaying function.)

I don't understand the "seeing apps running as root". If an app is capable of requesting root privilege, it will request root privilege. At that point, you should get a pop-up asking if you approve the request. An app getting root privilege has nothing to do with the app being installed under "/data/adb/modules". In fact, I don't think apps get installed under "/data/adb/modules".

To just what directory under "/data/adb/modules" have you copied apk files? If they are the apk files for Magisk modules, you're supposed to tell the Magisk manager app to install the modules -- just putting the apk file under "/data/adb/modules" doesn't do anything, and it is not necessary to put the apk file under "/data/adb/modules" in order to install a Magisk module.
[Magisk] pndwal:
🤣

Yup... But never rogue Googler!... 🙃

A former 'hacker' maybe, but got the Android security job no doubt because of showing willingness to 'play by the rules' (respect Google proprietary code, avoid manipulating expected device signals and subverting Google security model etc) and afterwards the Magisk project itself was approved as appropriate for a Googler to maintain after a (fairly lengthy) review of his management chain, copyright, legal, code of conduct etc (and he thanked his managers "as they take the majority of the credit on all the communication involved during the review process").

Nb. Google are not against root/Magisk at all, and most likely many Google engineers make use of Magisk as the fantastic testing/development tool (for apps etc) that it is, as do other Devs, security researchers, penetration testers etc...

Magisk enables a plethora of testing scenarios, eg using custom SELinux and any number of other patches, prop changes etc... Even DenyList (along with Zygisk) is really a very useful development/testing tool (allows testing in rooted environment while reverting / denying Magisk/root modifications in an app being developed at will, etc) despite it's origins in MagiskHide and modders in general often misunderstanding it's real function/purpose... (Denylist may provide very basic root/Magisk hiding, but actually gets in the way of many better hiding solutions and breaks modules that inject into any apps code that happens to be in denylist... Root hiding modules built for the purpose don't do this.)

Re Universal MultiROM (Magisk powered custom ROM), it is pure genius!... Sadly a dev like John only has only so much free time and no doubt must prioritise even viable/useful projects carefully; it seems that's the real issue there...

...Any other genius Devs wanna challenge? 😛 PW
[Magisk] Lindex:
Thank you. I have Parallel app installed, right. And multiple attemps of intalling magisk. I dont think tho I have many instances of Magisk intalled on my device.

This is what I have in Terminal.

Should I delete Parallel app, magisk and try to install one more time magisk 26103?
[Magisk] pndwal:
You'll only have this issue if you have taken Hide the Magisk app option in Magisk App settings (or possibly installed Magisk app in some "parallel app-space" like workspace etc. (Not familiar with 'Parallel app', but should be able to what apps are installed if it's similar)... As I mentioned just above, Hide the Magisk app function removes the full Magisk app, installs a tiny stub app and populates it's data with the Magisk binaries etc... You will have had opportunity to rename it from 'Settings' (default) to a custom name and It has an obfuscated (random) package name...

However Termux is NOT a normal terminal emulator for Android; it installs a separate Linux environment and behaviour is quite different... The response you got is expected even with Magisk installed unless you call su and superuser privilege is granted in which cast it works, but with Magisk App conflicts that will simply not happen if not previously granted...

If in doubt, try again using Terminal Emulator or similar normal terminal emulator and you'll get correct result without su as it uses current environment... If you then still get magisk: inaccessible or not found etc. you can assume Magisk is really not running. 🙃 PW
[Magisk] Lindex:
thanks for reply.

this is what it says with SU

I don't remeber selecting any "hide" option anywhere, and for sure didn't install magisk as second app in such parallel apps.
[Magisk] badabing2003:
Try TB checker from play store and run the tests, it will identify hidden Magisk package name,

Uninstall the package.

Rinse and repeat until there are no more Magisk installed.

Reboot.

Install Magisk.
[Magisk] pndwal:
... So you do have Magisk installed ('Magisk' with capital M won't work of course... Try capital V it get version) and must have granted superuser to Termux previously...

It's either 1) a (known) issue I linked (or very unlikely, an unknown one), 2) you have an obfuscated stub app installed in addition to full Magisk app (as you took Hide the Magisk app option), or 3) you have another Magisk full or stub (hidden) iteration in a second space like Workspace (maybe your Parallel space app) or within sandboxed environment (Island etc)...

If it's a hidden stub app, you should find package name as described using Applist Detector etc (can use @badabing2003's preferred app too), and simply uninstall and check again... If one or more are found problem should be solved... Your 'Parallel app' setup may also be the problem. (If you can't check apps in that maybe you should uninstall it)... 👍 PW
[Magisk] Lindex:
thank you. I was able to find Magisk manager and some app called settings offering me to install magisk. Deleted both.

after that I installed 26103 magisk and now it works.
[Magisk] badabing2003:
Glad it worked.

As for best way to hiding from banking apps, unfortunately there is no one size fits all solution.

There are dedicated threads that discuss in details the various methods and tools to use to hide from specific banking apps.

You definitely want to start with universal safetynet fix mod module by @Displax , pass the basic stuff and see what fails and take it from there.
[Magisk] rodken:
Yes, I agree that the willingness to "play by the rules" was likely a major factor in topjohnwu's hiring at Google.

By agreeing to respect Google's proprietary code and avoid manipulating expected device signals, topjohnwu showed that he was committed to using his skills for good. Not to mention the willingness to work within Google's existing security framework.

The fact that Magisk was eventually approved by Google after a lengthy review process further supports the idea that topjohnwu was willing to "play by the rules." This shows that Google was confident that Magisk could be used safely and responsibly.

I suppose that he was grateful for their support and understanding. It's likely that this positive attitude also played a role in the hand-shake with Google.

Overall, it seems clear that topjohnwu's willingness to "play by the rules" was a major factor in his hiring as an Android security engineer at Google. As long as he is using his skills for good and his willingness to work within Google's existing security framework made him an attractive candidate for the position.
[Magisk] pndwal:
Actually he was already doing this, having moved such code out of Magisk already and complied with the proper GNU (copyleft) General Public License already in place...

Yes, seems this adjustment was only fully made when commencing work as a Googler although he hadn't been adding such code for some time anyway, and had several times indicated that he was tiring of the cat-and-mouse game (with Google, banks, game makers etc).

I think Google is supportive of many custom mod projects implicitly... It's a hallmark of Android as Google's mobile OS and they understand that Android modding need not be limited to OEMs and corporate players only. And yes, OEMs are Android modders too; we all benefit from Google's AOSP gift.

OEMs must play by the rules to licence GMS (proprietary GApps) of course, but it's also a two way street for custom (as opposed to stock rom/skin) modders; Google want to help them survive (as the showed when they offered Kondik the "custom modders can sideload GApps individually" olive leaf after he thought CyanogenMod was dead when they served him a cease-and-decist order for bundling the same), and many (eg LineageOS) take the same pains John does to comply with the wishes of their benefactor...

I imagine any maintainer of official LineageOS could become a Googler whereas a maintainer of CRDroid and many other custom ROMs probably could not do both...

I'm sure Google scout for recruits for internship of John's calibre, and it would be a dream job for Many modders like him... Win win win (no one loses really!)

Yup... While it may be a niché 'market', customisability is a selling point for Google and many innovations have filtered into the general Android ecosystem from custom Devs... Of course Google wants such talent...

We want Google to continue to innovate and produce new AOSP iterations and milestones too. Modders who think otherwise should consider the alternative(s)... Two way street...

Realisticly I'm sure few Googlers agree with every corporate decision or strategy, but I'm sure they're team players and that there's a mutual respect between Google and the best Android modders. PW
[Magisk] zgfg:
Canary v26103 still does not mount /odm to /system (1+ phones, A13 and so)?

AFAIK, last Delta v25210 from 2 (if not 3) months ago, supports that
[Magisk] pndwal:
Issue seems to be that previously magic mount created its own mirror devices and mount mirror mount points. With those, magic mount could get the original files and directory trees. However, some devices use overlayfs to modify some mount points, and thus after magic mount, the overlayed files are missing because the mirror mount points do not contain the overlayed files. To address this issue and make magic mount more compatible refactoring how magic mount work is needed.

Much of this work is already done, however while the issue Request for root directory partition support: odm (all), optics and prism (Samsung), my_* (OPPO/OnePlus), vendor_dlkm (Android 12+) Core #3338 opened on Oct 14, 2020 by exocetdj addresses mounting extra partitions, that is still not resolved.

A fix for mounting /odm was apparently working with Refactor magic mount to support overlayfs #6588 (Feb 26) from 25207 per comment:

https://github.com/topjohnwu/Magisk/issues/3338#issuecomment-1447703504

but some support was later reverted, including for mounting /vendor_dlkm, /system_dlkm, /odm and /odm_dlkm, due to disagreements regarding limitations of this fix (see discussion there) with Remove support of partitions w/o symlink in /system #6682 (March 7) from 25210 per comment:

https://github.com/topjohnwu/Magisk/issues/3338#issuecomment-1453925427

and the (somewhat heated) comments following...

So support for 'writing to' /odm etc was only very briefly restored and seems we are now still awaiting the new API mentioned... 😬 PW
[Magisk] pndwal:
... Further, I recently began to fear that the 'heated' comments I alluded to above (resulting in that issue being locked for outside responses) may be at least partially responsible for the long wait for an alternative fix / new API per this (hidden) response from Shana:

https://github.com/topjohnwu/Magisk/issues/3338#issuecomment-1454409076 🙁 PW
[Magisk] zgfg:
With that Zygisk for KSU, both Shamiko and LSPosed can then be installed (per info I've seen around, don't run KSU but never say never), hence the modules for LSPosed should then work, too

Latest AML and James DSP also support KernelSU:

GitHub - Zackptg5/Audio-Modification-Library

Contribute to Zackptg5/Audio-Modification-Library development by creating an account on GitHub.

github.com

(there is no Releases but install.zip is available from View Code)

GitHub - Zackptg5/JamesDSPManager: ainur_jamesdsp

ainur_jamesdsp. Contribute to Zackptg5/JamesDSPManager development by creating an account on GitHub.

github.com

(also, look for install.zip under View Code)

And there is 'Systemless" hosts for KSU:

GitHub - symbuzzer/systemless-hosts-KernelSU-module: Required module to use applications such as AdAway on KernelSU and APatch

Required module to use applications such as AdAway on KernelSU and APatch - symbuzzer/systemless-hosts-KernelSU-module

github.com

KSU Org (alpha and omega):

A kernel-based root solution for Android | KernelSU

A kernel-based root solution for Android GKI devices.

kernelsu.org
[Magisk] Pandemic:
Hello why it keep hang in this latest stable magisk 26.1 when i wanna flash a magisk font zip ? Android 13 xperia 1 iii user, because i never had this before.

Edit:

@topjohnwu

Its a magisk 26.1 issue and i downgraded to 25.2 and it works fine, please fix it
[Magisk] pndwal:
Font modules break w/ Android 12+ and denylist... I put comments/links here recently:

https://xdaforums.com/t/module-mod-universal-safetynet-fix.4553699/post-88723775

👀 PW
[Magisk] zgfg:
TJW does not read here.

Issues must be submitted to the Magisk GitHub page

But it can be also issue on the module side - that module was not updated to support new Magisk (indeed, there are important changes under the hood), if so, it has to be addressed to the module's dev
[Magisk] gevo354:
Hi, I followed all of the steps in the guide from unlocking the bootloader to flashing the right boot.img with magisk. After I flash boot with the magisk boot.img and reboot the phone, magisk says Installed: N/A and root checker says root isn't properly installed. My phone is a 2023 Moto Edge Plus running Android 13 on the latest update. I'm not getting any bootloops or bricks so that must mean my boot.img is the right one. Can anybody help with this please? Thank you
[Magisk] badabing2003:
You know this is a two step process.

1- You patch the boot image in Magisk (on the phone)

2- You flash the patched image using fastboot (on the computer)

Just checking because your statement of flashing with Magisk suggests that you probably have done #1 as you can't flash with Magisk unless you're already rooted, otherwise you can only create a patch and have to do #2
[Magisk] zgfg:
Because it's not necessary. As you stated yourself, you can install Magisk without custom Recovery. Modules should be flashed from Magisk app, not through TWRP, hence TWRP is only a goody to have but not a must

On the other side it is a LOT of work and you practically need a customized port of TWRP for each particular phone and definitely for each new version of Android

Go to the official TWRP.me site and try to imagine how big team they have to support only a fraction of devices. And they still don't have a release for A13 at all

You have developers or groups of developers who forked the code and who work on porting the TWRP (SHARP, or Orange Fox) for the phones they own, and they already released less or more stable versions for eg A13

If TJW and few developers around him would go to work on custom Recoveries, they could work 24 hours a day and they would cover only a small fraction of devices (and Magisk project would be fully dead)

Besides, they would first go after the most popular phones - hence most likely not your phone (if your phone was a popular one, there would already be developers owning that phone and working on and updating the custom recovery for your phone)
[Magisk] gevo354:
I do flash and it comes says success. Then I fastboot reboot and when the phone turns on and I check Magisk, it says N/A for installed. To clarify, I already got the boot.img, moved it to my phone, patched it with Magisk, then I put the patched boot.img to the platform tools folder on my PC. I do the usual fastboot check devices spiel and proceed to flash magisk_patched.img successfully. But after that, root checker says my root isn't properly installed. I followed the instructions afaik.
[Magisk] J.Michael:
Could it be that your Android 13 is one of the systems where the ramdisk is not in the boot image, but rather in some other partition (like "init_boot.img")?
[Magisk] badabing2003:
Sounds like you're doing it correctly.

Which version of Magisk are you using?

Try 26.1 stable
[Magisk] badabing2003:
@gev354

An easy way to check for that would be to connect the phone to your PC, and launch PixelFlasher (see in my sig)

Set Android Platform Tools (use 33.0.3) and scan for devices.

It should show in the console details about your device.

See if it says Has init_boot partition: True

You can also just open the firmware zip and check if there is init_boot.img file in there.

Update:

Come to think of it, @J.Michael isn't it more of a device thing than an os thing?

See Pixel 5 above does not have it even though it is on Android 13.
[Magisk] Lughnasadh:
It's devices that are launched with A13 where the init_boot,img is patched.
[Magisk] pndwal:
@gev354

Yup, These devices (A13 LV) have generic ramdisk moved out of boot.img to init_boot.img to comply with new Google/Android requirements for GKI, so flash the latter (incl Motorola Edge+ 2023). 👀 PW

Edit:

Nb. Installation Instructions do cover this properly.
[Magisk] ipdev:
It is the difference of "patching" and building.

Magisk only injects a small amount of code into the boot ramdisk of the boot image (init_boot on newer devices).

This "patch" is what allows Magisk to start during the boot process.

Recovery is basically a mini-android system.

It is built as part of a system (ROM) build, custom or OEM.

So Magisk would have to build a recovery for every device.

⚠️ This would be way outside the scope of the Magisk project.

A custom recovery like TWRP is built the same way.

You sync the TWRP build branch (Android version) you want to build.

Include your device build tree (same Android version).

Make the changes you need to and run a build.

Then keep going back to fix what is broken until you have a proper working version of TWRP for you device. ;)​

Older ("non-slot") devices, recovery is a separate image (partition).

Newer ("slot") devices, use what is called "recovery as boot".

- Recovery is part of the boot image instead of a separate image.

---

Even if Magisk "patched" the recovery on the device to give root access.

It would do no good since stock (OEM) recoveries:

- Do not allow full adb access to the device.

- No option to mount (decrypt) the data partition.

- No file manager.

- Do not allow flashing anything that is not signed by their (OEM) signing key.

Custom roms (lineage for example) recovery:

- Allows full adb (root) access to the device.

- No option to mount (decrypt) the data partition.

- No file manager.

:cowboy:
[Magisk] gevo354:
Yep. Flashin the init_boot.img did the trick. Thanks guys, y'all some sexy mofos.
[Magisk] zgfg:
Few more words about troubles with custom recoveries

FBE provides three types of encryptions. Small part of Data is not encrypted that System can support Emergency calls immediately upon booting, before you entered the pin

Second for the most part of Data - for user 0. And third for user 9 (dual apps, second or work space)

So far I have never seen any custom Recovery (official TWRP or OFox or unofficial ones) I used with A10, A11, A12, A13 that could decrypt for user 9

When you boot to custom Recovery it asks you for pin/pass (or pattern). And it decrypts for user 0 but fails for user 9, it will shortly print that usually in red

Then, when you try to backup Data it may come to 99% but fails then with error 255. And that incomplete backup is useless

One must actually manually delete (empty) /data/extm folder to be able to backup Data

But if you use dual apps or second/work space, you must not delete it bcs it contains data for user 9. And hence you can not backup Data

Eg, I use only dual Whatsapp (when too boring, I can chat with myself between my two WA accounts :) ), and my /data/extm is 3GB (probably not used all 3GB but reserved space)
[Magisk] J.Michael:
@zgfg Did you really mean "both Magisk and TWRP in the same Boot partition"?
[Magisk] J.Michael:
See if you can "fastboot boot TWRP.img" -- i.e., run TWRP without installing it.

Some people can do this to get TWRP when they need it, without installing it. The discussions were usually in the context of having Magisk installed in the recovery partition, and having trouble jamming both TWRP and Magisk into one recovery partition, but in principle it could work even if Magisk is installed in the boot partition. Whether you can run this way might provide information about what you really wanted to do. Even if it doesn't solve your original question, if you can run TWRP this way, it might be good enough.
[Magisk] zgfg:
Yes I did. On this phone, with A11, A12 and now A13
[Magisk] heslo.rb26:
No, SUhide hides SuperUser/root, Magisk hide hides Magisk