yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
Ok... I understand.

It's quite simple to make your own module. Grab the template from GitHub, add your sysctl.conf file in /system/etc (in your module folder structure). Add your command line to service.sh under /common and finally edit the config.sh, module.prop and readme.md according to the instructions (in config.sh and readme.md). Zip your files, install and voila!

It'd be interesting to see if it works...
[Magisk] leolawliet:
I'm gonna try this when I get home. Thanks for the info!
[Magisk] HamsterHam:
Anyone else passing safetynet but android pay won't work when paying? First time this has happened.
[Magisk] biggdevon:
Yes. Can play PoGo but can't pay with AP. Was able to add a card but getting errors when attempting to make purchase
[Magisk] HamsterHam:
Same. What phone? I'm on Nexus 6P running ABC ROM. I paid earlier in the day and it worked. Very odd.
[Magisk] biggdevon:
Note 5. Not sure why your functionality is bouncing but so far I've yet to be able to pay using AP. I've heard people having success after a factory reset and fresh root with Magisk but haven't tried it yet
[Magisk] jhedfors:
Are you on LineageOS 14.1, and does your device use the NfcNci chip? If so, you might want to check this thread for the workaround:

https://xdaforums.com/oneplus-one/help/android-pay-cm14-1-t3504989/page33
[Magisk] HamsterHam:
Not this issue as I'm running an aosp ROM on angler.
[Magisk] westeight:
LeeDroid HTC 10 :svetius:
[Magisk] DarkAlpha.Sete:
I'm kinda stuck with this, because I don't understand the order of flashing in case I have a pre-rooted ROM (RessurectionRemix)... How do I install Magisk??
[Magisk] yakie996:
I hided this bancontact (https://play.google.com/store/apps/details?id=mobi.inthepocket.bcmc.bancontact) app in your app and it still says my device is rooted I also rebooted my phone and it still could see it
[Magisk] M4rt1n94:
I finaly managed to catch the moment when Magisk stopps hiding my banking-app.

I got both CatLog & Magisk-Log

[MENTION=4470081]topjohnwu[/MENTION] : hopefully this helps locating the 'bug' or however this is called.

Note that as far as I think this is not related to "how many" or "how often" you open Apps you wanna hide I got the feeling this is based on time. but maybe I'm just stupid... :D

CatLog was to big for uploading here, pastebin & textuploader..

Here it is: https://paste.ee/p/Ke2gd

What it catched: about 7-8 times it worked properly then once the root does not get hidden. Then it worked once more and then about 5 times detecting the root.

Used App: "VR SecureGo" ( de.fiducia.smartphone.android.securego.vr )

Also if you close a App which you cloaked you have to wait about 10 seconds until you can reopen it and expect it to get cloaked. Some people may thing its not working but an indication for when Magisk is ready again would be great ;)
[Magisk] ahrion:
So magisk is great but I've noticed weird issues when installing mods over a certain amount of mb. It's almost like magisk doesn't intelligently make the magisk.img larger proactively and sometimes mods can have issues with installing if a large module is installed.

The next issue I've noticed is if said large module is installed, it takes forever to boot like the Android manufacturer logo stays up for a long time. I noticed that liveboot will not work during this time and post-fs-data scripts fail to boot as well. I'm thinking it's trying to run a bunch of processes but does it at wrong times who h causes this.
[Magisk] Buffydamion:
Version?

Hi,

I hope the question is not too dumb, but:

I thought version 11.1 is the newest, have it on my Helios 7.1 Samsung S7 ROM.

But now the integrated 4.2.6 in version 7.8

Is 11.1 totally different from 4.2.6 or from another developer, or what is the difference?

Big thanks
[Magisk] Didgeridoohan:
The Magisk framework is currently at v11.1 and the Magisk Manager at version 4.2.6. Two parts of the whole, everything as it should...
[Magisk] chrcol:
doing some more testing now, the synapse error is actually related to missing UCI, so I think it doesnt even get to the stage of requesting root. With SuperSU synapse works fine. With magiskSU I get "No UCI Support detected"

Can you guys confirm with working banking apps if you have xposed active or not, I am now testing with xposed module unticked in magisk.

Safetynet is now passing with magisk su enabled.

tesco banking works

lloyds displays "you are now logged off" 910002

my ee isnt working, detects root

barclays initially shows it detects root but the screen quickly changes to get started (so works)

barclaycard detects root and fails

from the FAQ of kernel (superkernel)

Q: Synapse shows no UCI support!

A: Reflash kernel, a script of you may overwrite my synapse config

multiple people have the issue

https://xdaforums.com/showpost.php?p=71121917&postcount=901 and posts below.
[Magisk] Didgeridoohan:
Are you saying that you've been having Xposed active the whole time up till now? There's your problem... Magisk Hide can't hide Xposed (too complicated) and a lot of apps concerned with security look for Xposed as well as root.

Could be that Magisk might be messing up parts of the kernel necessary for Synapse support... Open a GitHub issue maybe? With all necessary details and a copy of your boot image both before (assuming it's compatible with Synapse) and after Magisk have been flashed.
[Magisk] HamsterHam:
Android pay worked for me this morning. Very strange but glad it works again.
[Magisk] chrcol:
Right is fixed.

It is both busybox related and synapse app issue in how it works.

1 - When you install the busybox zip in recovery, if busybox is already enabled in the magisk app, you have to toggle it off and then back on again, and then busybox works properly.

2 - synapse runs at boot, the root request does not geenerate a prompt as its in the background, however it remains running so when you launch the app, it will just say root access denied without a root access prompt (this is after busybox is fixed), so you then forcefully kill the synapse app and then when its relaunched the root request prompt will appear.

So regards to #1 above I was installing a fresh copy of my kernel to wipe superSU patched image which trashed the existing busybox setup, I reinstalled busybox as tkkg instructs, but have to do what I said in #1 to actually have busybox working.

Didgeridoohan yeah I did originally have xposed running except before when I mentioned it was off after installing the kernel again, all my new testing now is with the xposed module in magisk disabled. I cannot live without xposed its vital for my everyday use but if I can find a setup where it can be temporarily disabled so can use online banking from phone and then turn on again afterwards I will be satisfied, this is what I am working on now, still 3 apps refuse to work even with safetynet passing and xposed disabled, but I am working on it. Two of them are fixable with my selinux changes tho.
[Magisk] Didgeridoohan:
Awesome that things are progressing. Disabling the Xposed module in Magisk Manger should work. Just a bit cumbersome...

Just one more question: What busybox zip are you talking about? If you're using Magisk built-in busybox, there's no separate zip to flash, and if you're using another busybox, the toggle in Magisk Manager settings should have no effect.
[Magisk] zeugme:
[MENTION=4470081]topjohnwu[/MENTION]

Sorry to ask again, but did you have anything new regarding Google Pixel support ?

Please let me know if I can help for testing?

Thanks and kind regards
[Magisk] Captain_Throwback:
I've said it before and I'll say it again - if you REALLY want to help, donate a Pixel to [MENTION=4470081]topjohnwu[/MENTION]. That's really the best/fastest way for him to be able to add support. Otherwise, there's no need to keep asking. You already know that it's on his list.
[Magisk] DD3Boh:
I tested magisk for the fist time a week ago and it is fantastic, a lot better than SuperSU because it has the magisk hide. Thanks a lot to the creator
[Magisk] deepu458:
Hi folks, i am currently using RR-5.8.2 With Magisk and Lightning Kernel OOS(Persmissive Mode). My current magisk version 11.1 and manger is 4.2.6. But i cant see Resetprop in modules section or anywhere in magisk manager?

So kindly help me if i do anything wrong, i am new to Magisk.
[Magisk] jhedfors:
Download the template here, and read through the files:

https://github.com/topjohnwu/magisk-module-template

I am far from an expert, but looking through existing modules helped me a lot.

Attached are a couple that I made that deal with resetprop. They do the same thing but in a slightly different way. Might help...
[Magisk] Didgeridoohan:
Apart from what [MENTION=2091002]jhedfors[/MENTION] said, there's also some good info in the Magisk All-In-One Wiki, especially if you want to make some more advanced modules later.
[Magisk] chrcol:
There is a busybox systemless magisk module which dev of my kernel. Says has to be flashed. Will link to posts when back on pc
[Magisk] Nazariyhuhalo:
need help finding a solution to this problem that I'm facing
[Magisk] Didgeridoohan:
Hard to know, could be a number of things. Log looks ok...

Take a look here if any of the tips in this thread could help:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] deepu458:
Check ur Android debugging option under developer options. If enabled make sure u disable it and then run the safterynet status check i think this time u will pass it for sure.
[Magisk] staygreen420:
help! i flashed the latest magisc 11.1 via twrp on my galaxy tab a sm-T230 and now its stuck on boot screen been sitting on it for over 30 mins
[Magisk] Didgeridoohan:
Boot back into TWRP and flash the uninstaller. Your boot image may be incompatible.
[Magisk] staygreen420:
hmm on the tutorial they used magisk v7 is there a differnce between them.

https://xdaforums.com/galaxy-tab-a/development/recovery-samsung-galaxy-tab-a6-sm-t280-t3475381

thats what i did but instead of v7 i used v11.1

---------- Post added at 10:09 PM ---------- Previous post was at 10:05 PM ----------
[Magisk] Didgeridoohan:
Yeah... no... You might have messed something up there... I wouldn't flash a boot image modified for Magisk v7 over a v.11.1 installation... If you can't get to recovery to flash the uninstaller you might have to reflash your system... Hope you have a backup.

From here on out I think you'll get a lot more help in your device's forum... Good luck.
[Magisk] staygreen420:
oh i skiped the step where you flash the boot img anyway. ive done some looking and cant seem to find a boot img for v 11.1 and v7 seems obsolete. :( i want root but use it for pokemon so need to pass seftynet

why not use the v7 img with v11.1
[Magisk] Didgeridoohan:
Magisk v7 is obsolete. Don't use it... There's been tons of changes between v7 and v11.1.

Magisk installation instructions, if you wan't to pass SafetyNet:

1 - Don't have any other root solution installed.

2 - Flash Magisk zip (currently v11.1) in your favourite custom recovery (like TWRP).

3 - Install Magisk Manager.

4 - Enable Magisk Hide.

5 - Enjoy.

If installing Magisk doesn't work, your boot image might not be compatible. You could try a custom kernel (flash before Magisk) or you could try installing the latest beta snapshot of Magisk: https://xdaforums.com/apps/magisk/unofficial-magisk-v10-beta-built-t3521901

You can also go here for some more tips and tricks:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] yakie996:
is there a place to report apps that not get hidden?
[Magisk] Artim_96:
No, because if only these apps won't pass the is Lottie to no way that can be fixed. Therefore we would need to know how their detection works, that's almost never possible
[Magisk] Didgeridoohan:
You can always try right here... Might be someone who's successfully hidden whatever app you're talking about.
[Magisk] yakie996:
the Bancontact app we use in Belgium it still detects root (also debugging mode)
[Magisk] Didgeridoohan:
I'm guessing it complains about root when trying to pay? Because I managed to start it just fine as soon as I turned off ADB debugging. There's a few things an app like that could look for, apart from root. ADB/USB debugging is one of them, Busybox, certain prop values, etc. It can also be dependent on other apps or processes to detect root. I know of other banking apps that require the Phone Services (com.android.phone) to be added to the Hide list as well as the app.

There are a couple of examples of common props and other stuff in my collection of tips and tricks here:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] chrcol:
ok so regarding the busybox zip file

https://xdaforums.com/showpost.php?p=71174628&postcount=905 <-- kernel dev reports flash the busybox linked in Q&A

The Q&A is here under "questions about kernels"

https://xdaforums.com/showpost.php?p=66298118&postcount=5

busybox file he links to is in this post by osmosis --> https://xdaforums.com/showpost.php?p=40409356&postcount=1

I guess it be interesting to see if busybox is fixed by me just toggling the setting "without" installing the zip but no time to do more work on the phone today.
[Magisk] Didgeridoohan:
You shouldn't have to flash osm0si's Busybox, the Magisk built-in version should be enough. But, no guarantees...
[Magisk] yakie996:
so you can get past the setup tutorial? after I press activate the app it says security error.. I hid phone too disabled debugging and tried the busybox setting in magisk but once I do that my root gets removed I'm on nougat lineageos
[Magisk] culiacanazo:
We still talking about knox in this time and age?

Gracious goodness. Magisk wouldn't, it would be the recovery, but you can also use the time bomb

EDIT: Well not you, but the dude you quoted

---------- Post added at 01:19 AM ---------- Previous post was at 01:16 AM ----------

Lol loved it! I know it's been a week, but I'm just now getting to it.

Ok, I'll stop it.
[Magisk] ClaudioJuniorBR:
Whay Magisk does not work for Samsung devices?

My config :

Galaxy S7 edge

Rom SuperStock 1.2 MM (best rom)

Karnel SuperStock 1.6

Magisk 11.1

Magisk 4.2.6

MagiskSU

Magisk hide ON

Systemless ON

Magisk SYSTEMUI check

Buuuut CTS fail (safetynet don't work)

Whayyyyy Jesus Crist? I gonna cry :( :(
[Magisk] jhedfors:
There is a thread for that:

https://xdaforums.com/apps/magisk/magisk-discussion-thread-t3467229
[Magisk] DarkLanternX:
Could be due to the selinux status .. is it enforcing or permissive. I faced this problem on lineage os.
[Magisk] Didgeridoohan:
Yeah, I got past setup just fine... It's not busybox, cause I have that and I hadn't hidden Phone. It's probably looking for prop values, as well as USB/ADB debugging, because I have a module active that hides a bunch of usual suspects. Actually the same set of prop values I've mentioned in the thread I linked you. Try that...

You can try first by just changing one prop at a time with the resetprop tool, in a terminal emulator, and start the app after each. That way you'll know which one, if any, that triggers the app. You'll find the syntax in the Magisk All-In-One Wiki, and in the linked thread as well.

After you find the culprit you can make a module to change the value. That's also explained in the Wiki.

---------- Post added at 06:30 ---------- Previous post was at 05:51 ----------

I'm not so sure it's a device specific issue in this case...

Use SafetyNet Playground or SafetyNet Helper (they're in the Play store) to check your basic integrity. If basic integrity is true Magisk Hide is working just fine and you've got some other issue. In that case there's something about your setup that causes Google you not trust/recognise your device.

If basic integrity is false, you can still check if Magisk Hide is working by trying to add a root checker app to the Hide list and see if it detects root.

Check here for some more tips and tricks:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828

Oh yeah. Almost forgot... When asking for help, it's good practice to supply some logs with your post. In this case, at least a Magisk log...
[Magisk] olvrick:
Magisk Hide not working on Xiaomi mi 5 with latest Xiaomi.eu rom: xiaomi.eu_multi_MI5_7.3.9_v8-7.0

Magisk 11.1
[Magisk] Didgeridoohan:
Not at all or is it just SafetyNet?

Tips:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] olvrick:
Not at all, magisk hide not working, root is still visible to selected apps.

Safetynet also not passing
[Magisk] Didgeridoohan:
Ok... Take a look in the link I posted for requirements and things to try. There are many apps that rely on more methods for detecting root than can be hidden with Magisk Hide alone. What apps are you trying to hide root from? It can also be useful to know if you can pass basic integrity even if CTS profile is a mismatch. You can test this with apps like SafetyNet Playground.

And you haven't mentioned if you're using MagiskSU or SuperSU. Magisk Hide only works with MagiskSU.

Last but not least, please upload your Magisk log. With verbose logging enabled (if you haven't had it enabled before it might take a reboot for it to take effect).
[Magisk] yakie996:
When I do this '/data/magisk/resetprop ro.build.selinux 0' nothing changes in my buildprop file first I set su than entered the command and I dont know how to put it in a module too? maybe you can send me the module that you have since the app works for you?
[Magisk] Captain_Throwback:
Nothing is supposed to change in your build.prop. You can tell if it worked by running getprop on the prop you just set.
[Magisk] ClaudioJuniorBR:
Thanks for help man.

i try this tutorial and have worked for me :D

https://xdaforums.com/galaxy-s6/general/guide-bypass-safetynet-mm-custom-rom-t3534709

step 6 and step 7 is very important for work safatynet.
[Magisk] yakie996:
https://goo.gl/photos/sxjtZDPxHgDErUW47 here is a screenshot
[Magisk] Captain_Throwback:
Sorry, I meant getprop.
[Magisk] Didgeridoohan:
Like [MENTION=1162986]Captain_Throwback[/MENTION] said, you won't see the change in build.prop (unless you use a Magisk module to replace the entire build.prop file). That's kind of the point of Magisk, not to change the system...

You don't want my module, since it contains quite a few more device specific changes... Go to the Wiki thread. There's a link to the module template there and there's plenty of instructions in the module (in readme.md and config.sh). Basically you'll just have to add the resetprop commands in post-fs-data.sh and do some alterations of config.sh and module.prop before zipping the files and installing (through Manager or TWRP).

---------- Post added at 13:54 ---------- Previous post was at 13:50 ----------

No worries, glad you got it working.

If you'd read the link I sent you though, you'd have seen that I have step 6 and 7 covered among my tips and tricks to try... I guess it's a case of TL;DR. :D

Edit: I was wrong... It was Samsung specific, as usual. :D
[Magisk] yakie996:
I set this 3 since the others are not in my buildprop file I tested them all with getprop and they where all set correctly still says Im rooted. safetyNet says Im safe..

ro.build.type=user

ro.build.tags=release-keys

ro.build.selinux=0
[Magisk] MrHomebrew:
Disable USB debugging in developer settings.

Might do the trick.
[Magisk] Didgeridoohan:
IIRC ro.debuggable and ro.secure aren't in the build.prop, but in default.prop. Run getprop on those two as well to see what it reports back.
[Magisk] ClaudioJuniorBR:
it's the trick Magisk Safetypass ON SAMSUNG S7 EDGE

Thanks for help!
[Magisk] MrHomebrew:
No problem at all. It's a great accomplishment, no limitations.
[Magisk] ClaudioJuniorBR:
Yes, you help me a lot man! thanks

now i recreated post o magisk forum for s7 edge users.

i hope to help with this post. Link for the post is here!
[Magisk] yakie996:
hi, Ive set everything now but sadly still sees im rooted.. I dont know how... seqr also sees that i am rooted

ro.debuggable=0

ro.secure=1

ro.build.type=user

ro.build.tags=release-keys

ro.build.selinux=0
[Magisk] Didgeridoohan:
Ok. I did a test and tried the Bancontact app again. You said you couldn't get past the initial setup?

Without any props changed, without adding the app to the Magisk Hide list and with debugging enabled I get a security error when trying to activate the app. If I disable debugging, but keep props unchanged and not adding the app to Hide, I can get past activation no problem. Of course I can't verify that anything else works.

So it seems like it's not the props after all. Sorry for wasting your time... There's something else going on though and I'm real curious as to what it could be. You could try decompiling the app and search through the code to see if you find what it's looking for...
[Magisk] zeugme:
I thought he wanted to borrow on Pixel device to a friend of him...
[Magisk] Captain_Throwback:
I'm pretty sure he'd prefer just having one, rather than having to wait until his friend lets him borrow one for a limited amount of time...believe me, it's much easier to work with a device you own/don't care as much about breaking versus one that you have to be a bit more careful with because it belongs to someone else.
[Magisk] yakie996:
I am not that good at identifying code I will try but I doubt I'm going to find it :p
[Magisk] pintu gti9300:
How to pass safety net

Device GT i9300

RR 5.8.2
[Magisk] kessaras:
hi. i decided to write here after i searched a lot and i couldn't find something.

here in this thread of course i didn't search, i can't search 1032 pages and the search results are too many.

Well, i'm on latest RR build on both my phones. G4 h815 and OP3T.

First problem is the cts mismatch. i did hide magisk but.... nothing.

Second problem is the new su.d that replaces the old init.d.

Asking in kernel threads i got no answer, asking in RR threads, also no answer. Asking in supersu, also no answer. My only source of information comes from a random guy in a random xda thread that sais to set permissions to 700 at both folder and script in /system/su.d/. Nothing. It's not working.

So where in the whole XDA i could get this piece of information ? In magisk that suggests the use of su.d ?

In supersu that also suggest the same ?

in kernel threads ? in rom threads ? nobody answers. Google only gives me one page of information that doesn't help at all.

All those that suggest the use of su.d ignore the questions about su.d. So then wtf..... -_-
[Magisk] Didgeridoohan:
Many things to try. Disabling USB debugging, changing permissions for selinux files, etc. Check this thread for a collection of tips and tricks:

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828

Sounds like you're using SuperSU with Magisk. Magisk Hide won't work if you don't use MagiskSU.

What is it you're trying to do? It's not quite clear... If you're trying to run scripts at boot you can make a Magisk module (explained here) or use Magisk's "General purpose boot scripts" (explained here).
[Magisk] Artim_96:
https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828/page4

On the first question see above. On the second, Magisk don't need to use su.d/init.d. just put your scripts into a Magisk module (just paste​ the scripts text to common/post-fs-data.sh and configure the module) and done. Nothing to worry about permissions etc, it will just work
[Magisk] kessaras:
If I understand right, su.d is on pair with only supersu? Because many devs that have pre-installed magisk in their builds, they suggest su.d. Anyway, I will see when I have time, those links you gave me. They might help.

What I wanna do is execute my tweaks on boot just like we did with init.d

---------- Post added at 08:53 PM ---------- Previous post was at 08:51 PM ----------

Aha. I understand. You both told me about modules. Got it.

So I wonder why the devs that have magisk in their build they suggest su.d....... Thank you too.
[Magisk] Artim_96:
Ask them... Magisk modules are by far the easiest way doing stuff.