yashsingh1/xdaforums huggingface dataset:
[Magisk] fOmey:
Force close on Samsung Galaxy S6:

02-20 20:32:08.121 13998-13998/? E/AndroidRuntime: FATAL EXCEPTION: main
Process: com.topjohnwu.magisk, PID: 13998
java.lang.RuntimeException: Unable to start activity ComponentInfo{com.topjohnwu.magisk/com.topjohnwu.magisk.SplashActivity}: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources android.content.Context.getResources()' on a null object reference
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java)
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java)
at android.app.ActivityThread.access$1100(ActivityThread.java)
at android.app.ActivityThread$H.handleMessage(ActivityThread.java)
at android.os.Handler.dispatchMessage(Handler.java)
at android.os.Looper.loop(Looper.java)
at android.app.ActivityThread.main(ActivityThread.java)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java)
at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:102)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'android.content.res.Resources android.content.Context.getResources()' on a null object reference
at com.android.internal.policy.multiwindow.Docking.<init>(Docking.java)
at com.android.internal.policy.MultiPhoneWindow.<init>(MultiPhoneWindow.java)
at android.app.Activity.makeNewWindow(Activity.java)
at android.app.Activity.attach(Activity.java)
at android.app.ActivityThread.performLaunchActivity(ActivityThread.java)*
at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java)*
at android.app.ActivityThread.access$1100(ActivityThread.java)*
at android.app.ActivityThread$H.handleMessage(ActivityThread.java)*
at android.os.Handler.dispatchMessage(Handler.java)*
at android.os.Looper.loop(Looper.java)*
at android.app.ActivityThread.main(ActivityThread.java)*
at java.lang.reflect.Method.invoke(Native Method)*
at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java)*
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java)*
at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:102)*
[Magisk] ¿GotJazz?:
Sorry for the basic questions, but I'm a n00b to Magisk, and didn't find the answers while searching through all the various threads. I understand that Magisk is a new way to root my devices as a replacement to chainfire's SuperSU. Magisk has been included in one of the OP3T ROMs I am using.

I have a few questions:

If a pre-rooted Magisk isn't already "baked in" to some other ROM on an older device, how do I root that device? I used to install a SuperSU_xx_yy.zip in Recovery Mode after installing the O/S to root. Do I just install a MagiskSU_aa_bb.zip in Recovery Mode now after installing a new ROM?

When unlocking my OP3T Bootloader, the instructions said I had to install (chainfire's) SuperSU at one point to prevent a bootloop. I think this had something to do with dm-verity. Is there anything different I would do with the Magisk rooting method?

Does Magisk-v11.1.zip just install the framework for Magisk, with a separately loadable MagiskSU.zip that I would get from somewhere? Or, does Magisk-v11.1.zip include MagiskSU within the installation package, and MagiskSU is just enabled/disabled with Magisk Manager?

If MagiskSU is separately loadable, where do I get the package to install it?

Thanks!
[Magisk] Didgeridoohan:
Simple answeres:

1 - Just flash Magisk zip in recovery.

2 - Magisk patches dm-verity.

3 - Magisk zip installs MagiskSU as well.

4 - See 3.

You'll need Magisk Manager from the Play store as well.

The release thread has lots of good info. https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445
[Magisk] Dafriss:
i read some comments about that igf you install magisk v11.1 that it deletes TWRP from your phone and cant do anything anymore with it... is this true?
[Magisk] ¿GotJazz?:
I didn't install Magisk v11.1 separately (it came built-in to my ROM). However, I do have Magisk v11.1 working, and TWRP was never affected from that ROM installation.
[Magisk] Didgeridoohan:
No.
[Magisk] bunta126:
OMG, 900+ pages to search through... couldn't find my issue... hopefully someone is monitoring this thread to reply...

I'm using Magisk 11.1 and MagiskSU on my CM12.1 ROM (my favorite one) however the root option changes to disabled every time I reboot and I have to re-enable it.

This is a real pain for my firewall app as it cannot apply rules on startup.

I've tried it on LineageOS 13 and 14.1 and it doesn't have a problem, only when I use my favorite Android 5.1 ROM...

Any idea how to keep root enabled on reboot?
[Magisk] Artim_96:
It should be automatically. Otherwise just start fresh and remember to revive the build in root (osmosis unsu.zip)
[Magisk] bland.life:
Is Magisk Hide suppose to hide root from any app?

I have SafetyNet pass and Android Pay seems ok.

But the app of my telco still detects root with Magisk Hide enabled for it.
[Magisk] Didgeridoohan:
Some apps still can detect root, even though they're added to the Hide list. There might be a dependency on another app that isn't hidden, though... As an exmple, Airwatch Agent requires Settings to be hidden as well and I know of some banking apps that require the Phone app to be selected (those app have Phone permissions and requires it to function). It can be tricky to find the dependency, but if your app requires any permissions, that's a good place to start.
[Magisk] tag68:
For that functionality you don't need Magisk. Just do unroot.

There is a list of apps which shall not see root. You should keep it small, if it gets too big Magisk hide may stop working properly.
[Magisk] pranayysharma29:
Attaching log files found in cache in twrp file manager.

Hope it helps.

Also attaching screenshot from previous post.
[Magisk] chas123:
Magisk 11.1 detects the stock boot as being su patched on the ZTE Axon 7. It will, however, install over 10.3 beta, but says root detected no permission, and there is no Magisksu manager accessible through the app. My ROM module is still active after the flash, and safety net passes. Just no root. I think that the problem might be that ZTE's boot has dm-verity disabled stock.

[MENTION=4470081]topjohnwu[/MENTION] worked w/ a member of our ROM team (OMJ- Badboyz) to come up w/ 10.3 beta when build.prop edis weren't writing correctly.
[Magisk] Didgeridoohan:
I'm gonna assume you're referring to my post #9346 about boot image being patched for SuperSU. Right?

From what I've gathered (from this forum), Axon 7 is a quirky device when it comes to Magisk. So, I'm not at all surprised... The post in question though is directed towards a user with a Google Nexus 6 and I can assure you that the stock boot image has no such issues on that device.

Or am I wrong and you're referring to something else? :confused:
[Magisk] oreo27:
Just wanted to update you folks that Magisk 11.1 when flashed after SuperSU on the latest Global Stable MIUI 8.2 for Xiaomi devices is working perfectly along with Magisk Manager 4.2. I haven't tried the Magisk SU implementation yet as I still see some people having problems with it.
[Magisk] Nomelas:
Do you hav ViPER4Android module installed? That seems to be the root cause I think. I disabled it on mine and seems to be stable now
[Magisk] chas123:
Didn't see anything referring to Nexus.

I edited the boot and got it 11.1 to install. Still not root or root manager. Magisk 10.3 hasn't been quirky at all on the Axon 7. Works perfectly. I guess the binary in 11.1 is not compatible.
[Magisk] pranayysharma29:
I do actually. I'll try your solution out. And see for a couple of days. Thanks
[Magisk] 2ddssa:
Maybe I will ask again. available:

Sony z1c

full stock firmvare, android 5.1.1 ( .236 firmware)

repacked stock kernel unmodified

Without magisk - SafetyNet passed.

After installing magisk (11.1 / 10.2) SafetyNet - is failed (mismatch cts)

If I activate magisk hide - after some time, the test is failed anyway

If I remove magisk - test again passed

to bypass restrictions forum logcat, dmesg, magisk log, and kernel and packaged in zip archive
[Magisk] ken2802:
lately the magisk manager always crashes on launch again
[Magisk] Didgeridoohan:
Come on guys... Logcat!
[Magisk] jcrompton:
SM-935F S7 Edge and non Samsung ROMs

I have posted before but I wanted to keep myself and those that might be able to help up to date.

Magisk and Magisk Hide works on this device with Samsung ROMs (it requires Magisk Hide enabled, USB Debugging turned off and SystemUI checked in Magisk Hide) -- this allows SafetyNet to pass.

However on some of the newer non Samsung ROMs it won't work.

The latest update is that on the 2-20-17 version of Res Remix ROM for the Galaxy S7 Edge I tried again and got SafetyNet failure with red (after letting the wheel spin for like 2 minutes --- that was unusual). BUT if I uninstalled Magisk with the Magisk uninstaller and then tried SafetyNet it PASSES. So it would seem that the ROM and kernel have potential for things working.

I reinstalled Magisk 11.1 and got the attached logs in hopes that someone can help further. Someone had told me that they thought I would have to get the ROM developer involved but since the ROM passes SafetyNet with Magisk uninstalled I thought there may be a chance you guys could help.

THANKS inadvance
[Magisk] kyzn:
Jeez, basic bug report procedure. (Come on!)

For reals. Upload logcat so people can help you better.
[Magisk] jhedfors:
Easily offended? The comments were not rude at all - nor were they meant to be. If you are offended at being reminded of basic rules, then that is your issue, I am afraid.
[Magisk] ken2802:
in attachament
[Magisk] Didgeridoohan:
At a quick glance the log looks fine. From your description I'd guess it's simply a compatibility issue with the ROM. One developer or another (ROM or Magisk) would probably have to take a look at the boot image.
[Magisk] jcrompton:
Hey thanks

The non Samsung ROMs for the Galaxy S7 Edge are still a WIP for sure. And I get the same described behavior for Lineage based (like the Lineage ROM or Res Remix) or another ROM that the developer describes as AOSP but I think it may still be off the Lineage base.

So are you saying that maybe it's how the boot image gets rebuilt by Magisk upon flashing?

How do I troubleshoot this or how do I help the developer troubleshoot it?
[Magisk] kerbiii:
magisk manager 4.2.5 still crashed
[Magisk] igorinolw:
Magisk not working on xiaomi.eu rom

i'm using a redmi 2 pro

device boots but screen is black
[Magisk] Artim_96:
OK, just to make it short and to say what was just mentioned a site ago:

LOGS!!!!!
[Magisk] thelangosta:
I think you meant "LOGS!!!! or GTFO!!!!"
[Magisk] Wesley_NL:
Updated magisk.apk crash on opening
[Magisk] BryanByteZ:
Guys i just posting it because that can help someone, like some people here after updating to 11.1 (from 10.2) I lost root and xposed tried a lot of things but the only thing that worked is this:

In ROM Uninstall

Magisk manager and phhSU

In Recovery flash

unSU by osmosis

Magisk uninstaller

ROM

Kernel

UnSU by osmosis

Magusk uninstaller

Magisk v11.1

Xposed magisk

My mods ( ARISE,DOLBY AND A FEW OTHERS)

Reboot

In ROM Install magisk manager and you're ready to play!
[Magisk] _litz:
So far, v4.2 Magisk Manager is behaving correctly ...
[Magisk] zeugme:
Thanks for great Magisk!

What is the status for Google Pixel support? (I have a Google Pixel since today...)

Let me know if I can help for testing or anything for Google Pixel! I just installed Magisk Manager 4.2.5 on my device (unlocked bootloader and TWRP), but the boot image location is not detected...

Cheers!
[Magisk] Nomelas:
This seems to have fixed root breaking for me after a day of not losing root.

EDIT: Spoke too soon :/
[Magisk] jcrompton:
Hey guys this is really irritating me ... please help ! Sorry I'm too intense sometimes ....LOL

If I install any AOSP or Lineage based ROM on my Galaxy S7 Edge (SM-935F) I get functioning Magisk but no SafetyNet pass

If I reflash the original Boot image ... I get no root but I can pass SafetyNet

What can I do to the boot image to make it work with the changes that Magisk makes to it ?? None of the "custom kernels" for this device seem to work with AOSP ROMs ... only the sammy ROMs
[Magisk] ken2802:
to add a bit more to my "case", magisk manager worked fine before but suddently it just keeps crashing on launch. Log is at https://xdaforums.com/showpost.php?p=71117685&postcount=9388
[Magisk] seraphg:
got the same issue, keep crashing and I am on Samsung S6 6.0.1, pls, help!
[Magisk] yochananmarqos:
Have either of you updated to Magisk Manager 4 2.5 yet? It may resolve the issue (see changelog). If you updated and it's still crashing, post a logcat.
[Magisk] livaye:
v11.1 does not work on my samsung note4 9108v stock rom 6.0.1

after flash, it does not recognized and ask for flash again
[Magisk] FlintStoned-:
Hi all,

I still have the problem that magisk 11.1 won't run on my xperia z3c with unlocked bootloader, elitekernel and xposed. It crashes everytime. I have no problem with 10.2 but would like to be able to update.

Any thoughts?
[Magisk] Didgeridoohan:
[MENTION=4470081]topjohnwu[/MENTION] needs your help: https://xdaforums.com/apps/magisk/dev-samsung-crash-help-required-t3560421

There's also a little something in there for you... :)
[Magisk] spartan018:
Systemless SuperSU and Systemless Xposed have always flashed without an issue on the stock boot image for me.

[MENTION=4470081]topjohnwu[/MENTION], I have an XT1095, dev experience, and plenty of free time at the moment. I'd be more than happy to work with you to get it working on these devices.
[Magisk] benwalburn:
I modified the template to update a /data app to /system/priv-app. Really useful for things like Action Launcher which has a Google Now page if you make it a system app. I did my best to make it into a template expanded from the existing one, without interfering with the normal function. As far as that goes, it works fine. Set DATAPPDIR to the folder in /data/app that contains your app and the script will convert it to a Magisk system app.

My only problem is that I tried to copy the "if ($CACHESUPPORT); then" line with "if ($DATAPPDIR); then" but it just caused my portion of the script to fail. I'm not sure what's causing this.

The script works fine. You can use it normally, or update apps to system apps. Nothing out of the ordinary happens if you don't do one or the other. All I did was add a DATAPPDIR and DATAPP variable for my script addition. (The only thing you might want to change is setting line 305 to "mv" rather than "cp" to save a few mb)

I'd appreciate it if someone could find out why my if statement doesn't work. I left it commented out on lines 303, 304, and 306 . It's been a while since I worked with bash.
[Magisk] adrman:
I'm not sure I'll be of any help with the script, but when I have some time, i want to try this as I use AL. It might be a day or two, but I'll post back my results.
[Magisk] Artim_96:
From your signature I would guess you have a Samsung device and it sounds like you have a kernel that forbids switching to permissive mode like all recent versions. So unless you flash a kernel allowing it is impossible. But the Magisk manager says already
[Magisk] SirVilhelm:
Any have suggestions on getting android pay to work? I am on a stock Nexus 6P, just flashed the latest system image including everything except data. Flashed a custom kernel them magisk. I pass safetynet but cannot make any AP purchases. Think it could be the kernel?
[Magisk] CrazyCypher:
Today I finally decided to try Magisk and compatible systemless xposed and phh superuser... Because I had already installed systemless xposed v85.7 and SuperSU v2.76, I had all the modules already enabled and installed..

This is what I did, step-by-step:

1. Downloaded all the files (XposedInstaller_by_dvdandroid.apk, Magisk_Manager_v1.2.apk, Magisk-v6.zip, phh-superuser-17-magisk.zip, xposed-v86.5-sdk23-topjohnwu.zip, ElementalX-HTC10-0.14-Sense.zip)

2. I updated my already installed XposedInstaller and also installed Magisk_Manager.

3. I booted in the recovery and restored system image and stock boot.img... system mounted as read-only.

4. Because I have custom kernel, I flashed ElementalX kernel first, as it is written on the first page, after that I flashed Magisk-v6.zip, then phh-superuser-17-magisk.zip, after that xposed-v86.5-sdk23-topjohnwu.zip.

5. I rebooted the phone, it said "Updating apps x of xxx"

6. After reboot, I opened phh superuser and apps Recently, Macrodroid automatically asked for permission :)

7. I uninstalled SuperSU app from Chainfire that I used before

8. I opened XposedInstalled and all the modules were already enabled and everything seems to be working perfectly. I also went to Magisk Manager and there is also all OK! :)

I also have encryption enabled like before, I did not loose it. I opened AdAway which requested root, I did not change any settings but just downloaded hosts and apply it. Seems to be working, there is hosts file in Magisk folder :)

Even though I have everything working perfectly and without ANY problems, I have two questions I dont know answer to...

On the first page it says "All previous mods are NOT compatible! Please download the latest version of the mods you use" which scared me that my phone will bootloop/brick/freeze because I did not uninstalled all xposed modules but I left them enabled... But they all work from previous xposed I had installed... So what does that mean that previous mods are not compatible, which mods? Also under instructions on first page it says "Installer will patch system verity and forceencrypt" which I thought that means the encryption is removed? But I see everything is intact and identical like before I installed Magisk... I dont understand, could anyone explain maybe? :) Thank you, I appreciate it
[Magisk] jhedfors:
I think as of version 5 this was fixed for me. I am on stock.
[Magisk] Captain_Throwback:
This is the Magisk thread, not the Xposed thread, so the "previous mods" refers to Magisk mods created with the mod template on the first page. It has nothing to do with Xposed.

Patching forced encryption doesn't remove encryption - it never has. If your device was previously encrypted, it will remain so.
[Magisk] waylo:
The other thread has the recently undiscovered answer (we hope). Go to page 26.
[Magisk] CrazyCypher:
Oh, my bad... I guess I understood wrong.. So what does this patching really do for the encryption? Or what is changed so that it is necessary?
[Magisk] Captain_Throwback:
It just makes it so that if you decide to remove encryption, the device won't automatically re-encrypt on boot.
[Magisk] CrazyCypher:
Thanks for the kind and fast replies, I appreciate it.

Anyway, everything is working perfectly, so far I have no problems whatsoever. Magisk, superuser and xposed all work without issues.

I have stock rooted rom
[Magisk] Kusoo:
Can Magisk be installed on latest Android Nougat?
[Magisk] SirVilhelm:
Oops, that's what I get for having a dozen XDA tabs open :)
[Magisk] Small_Ku:
When I use Flashfire with Magisk v6 and Phh superuser(Magisk version),it turn off the phone and normal boot without flash anything.

PS:I already set the SELinux to permissive

Sorry for poor English :p
[Magisk] JudgeDread11:
For anyone who uses "SD maid", by default it deleted the files in the cache directory. So if you have and cache mods it will delete the scripts.

In SD maid change the filter for system cleaner to not clean the cache directory to have cache mods survive the cleaning.
[Magisk] henry_gale:
To uninstall a mod, do I just delete the folder from /magisk/? For example - /magisk/liveboot/?
[Magisk] Small_Ku:
Refer to the post of Magisk Structure,

you can create a file called "remove" under the mod folder to remove your module in next boot.
[Magisk] linyuhc001:
hi there!I flashed magisk v6,but my oxygenOS still encrypted? how can I decrypt it?thx
[Magisk] kerbiii:
i dont know to get the logs since the moment i clicked on the app it immediately force close saying there was error. i would if i could and i know how to
[Magisk] koko115:
4.2.5 still FC. Galaxy S7 MM
[Magisk] pappydapimp:
I installed a magisk enabled rom that had and older version of the manager installed. I used the hide magisk option and after reboot it says no root. So I tried to uncheck it and reboot but it wouldn't let me. When it boots back up it's rechecked and saying no root.

I upgraded the manager to latest version and still shows no root. Now it also has no options for downloads or modules. It says latest magisk is installed, but the only option in manager is to install magisk.

Very confused. Any ideas?

HTC 10

Bad boyz magisk rom
[Magisk] bunta126:
It doesn't, the root options are set to disabled every time the device reboots and I have to enable it each time.

Clean built the phone a couple times and the issue still exists but works fine if I use a newer CM13 or higher ROM.

Possibly it is an issue with Android 5 because the systemless root options previously were unavailable for that model (although the Magisk instructions only say SuperSU requires Android 6 or higher).

Anyone else using this OK on Android 5?
[Magisk] Didgeridoohan:
I put a link on how to logcat in the linked thread...

https://xdaforums.com/apps/magisk/dev-samsung-crash-help-required-t3560421
[Magisk] bluedragon38:
About Magisk and Samsung crash :

When I press the logo on my menu, the application start (just the logo appear I mean splash screen of Magisk) and crash directly.

I have Samsung s7 edge + hydra Rom.
[Magisk] Fild5x:
Updated magisk through playstore, but it is crashing on lauch. Back on the old one.
[Magisk] slink_59:
Here's my logcat about magisk 4.2.5 fc on Samsung Device:
[Magisk] bluedragon38:
How you did it? because I don't have option to "come back to previous version"...
[Magisk] Artim_96:
The Magisk logs are in /cache, for everything else use logcat...for exapmle catlog from PlayStore. Just open it, start recording and open the Magisk manager.
[Magisk] Hackforever:
Hello I am under nanorom 7.0 I have magisk to activate but the modules result from an error during the installation. And safety net finally I have not understood too much but this one goes red on magisk manager
[Magisk] arcticnights:
Hi guys!

Just installed Magisk for the first time today by flashing the v11 zip. Sorry if this is a dumb question, but is the default root installed (MAGISKU) the same as phh superuser's? Is there a benefit to switching? If so, how do I go about switching to phh?

Thanks a lot.
[Magisk] BigMacca:
Hi all,

I'm having a bit of a strange issue, just wondering if anyone can help?

First off, I'm running jgcaap's 14.1 ROM ruining on a one plus one.

Full clean flash using magisk v11.1 and the latest magisk manger from the play store (I also ran the super su uninstaller after the rom flash for good measure)

So, everything is installed, configured and working ok.

I pass safetynet checks and android pay is happy.

However, I seem to lose the ability to pass safetynet after an undetermined period of time. The only way to get things up and running again is to reboot the phone.

I can't track the change in behavior down to any single thing.

For example, today everything was working fine when I got to work (safetynet passed), I then left my phone for two hours without using it and now safetynet is failing due to a CTS mismatch...

After a reboot, we are all good again...

I've attached the log.

Anyone got any ideas?

Cheers

Macca
[Magisk] Fild5x:
Sorry, I had a backup
[Magisk] Didgeridoohan:
MagiskSU is a fork of phh's superuser and only systemless SuperSU or MagiskSU are officially supported.

When/if it happens, try force closing Magisk Manager and opening it again. Also, remove Magisk Manager from any and all battery optimization.
[Magisk] royal_eagle:
hi,

please which settings i need to hide to have Airwatch working with root with Magisk ?