yashsingh1/xdaforums huggingface dataset:
[Magisk] culiacanazo:
Once upon a time, in a far away land, where happy people actually searched, researched, and read things up.... And then everybody lived happily ever after!
[Magisk] djb77:
[MENTION=4470081]topjohnwu[/MENTION]

I seem to be encountering a problem with the v10 version of magisk regarding some modules I create exclusively for my ROM. The issue is with implementing the 3minit battery mod.

On v9 everything works perfectly, but on v10 it causes major issues. It seems to do real crazy stuff with my phone like changing permissions that shouldn't be changed, you cant use the keyboard etc. The other 2 mods that I create work perfectly (5 way reboot module and custom sound mod module written for TGP) but this particular one messes everything up.

It injects 2 new apks to /system/app, but the one that seems to have the issue (I'm thinking) is SystemUI (located in /system/priv-app). Here's some tests I did and the results:

- Hard-implemented the mod (physically copied to /system) -- WORKS

- Include the 2 apks and the 3minit version of SystemUI into the magisk module -- FAILS

All I did previously in v9 to get it to work was change the module id in config.sh, and adjusted the changelog.txt and module.prop files. Is there something else I need to be doing for v10, further edits to config.sh ??

Thanks in advance, I hope you can help me here.

UPDATE: dont worry, figured it out, had to add /system/priv-app/SystemUI to the REPLACE list

UPDATE #2: It didn't fix it, I forgot to check the keyboard. All I know is that whatever I did in v9 for this to work doesnt work in v10. It does resize magisk.img for this mod too if that helps.
[Magisk] xXCoolGuYXx:
In on a lg v10 h901 20j Okay it happen again when I flash it because it gave me a bootloop but I got the error code 1 if that helps any and do you have a email I can send the log to because it won't let me send it on here .

OKAY FOUND OUT HOW TO DO THE LOG THING AND HERE MY LOG

http://pastebin.com/1LvkK99q
[Magisk] Kal-El7:
- 7.1.1

- 10.2

- v4a......sweet. One question, since you're on 7.1.1 with Magisk working, - would the Xposed Framework magisk module would alright & the Xposed modules?

Thanks so much. =)
[Magisk] Captain_Throwback:
There is no Xposed for Nougat.
[Magisk] Kal-El7:
lol....I didn't notice your question to my enthusiasm for this thread. It's just that Magisk is awesome - I'm new to it. And this community is swell. Thanks for being great!

---------- Post added at 05:28 PM ---------- Previous post was at 05:26 PM ----------

That's what I thought and wanted to make sure. I'm on MM (reverted back from Nougat) just for Xposed combined with Magisk.

Thanks so much. =)
[Magisk] Artim_96:
SafetyNet is part of Google play services. So there is nothing you can install.

And yes, it does, but it won't be able to hide it from SafetyNet
[Magisk] culiacanazo:
Yeah, grab a chair and let me go try
[Magisk] Didgeridoohan:
Ok, good. You can stop trying to flash Magisk until you've done something about your kernel. It's not compatible...

Maybe go to your device's forum and see if anyone there has a solution. https://xdaforums.com/lg-v10
[Magisk] xXCoolGuYXx:
Try looking for it on my device forums but couldn't find anything and when you try and are going to fix it let me know and I'll help test it for you, if you like and thanks for getting back to me .
[Magisk] Alucard:
Thank you but in manager it says a big X and safetynet failed gts profile mismatch,how do i make it work and turn green so that everything work as it should be?Also i installed viper4android but i cant find the app to change the settings.
[Magisk] Artim_96:
Well, that's a topic discussed very widely in this thread, so just search. But start with what you have to do in every thread: read the first posts by the dev... In this case what's behind the links in the first posts, maybe except the repo one.
[Magisk] xXCoolGuYXx:
Well here a log from when it flashed good from your magisk app. http://pastebin.com/eZbzkdGS

An when I work the zip installed and everything but I didn't get any new apps
[Magisk] Alucard:
I searched but didnt find what i was looking for and what about the viper4android,how do i use it?
[Magisk] Artim_96:
Open Magisk manager, go to the download section and tap on the v4a entry. Three symbols will show up underneath, tap on the question mark
[Magisk] Alucard:
Oh thank u man,what about the safety net i searched but didnt understand a thing,i got lost.
[Magisk] Artim_96:
Well, if you don't understand it, ignore it since it probably means that you didn't had disadvantages from not pressing it yet. And that's not what Magisk is made fur in the first place
[Magisk] Alucard:
I understand that its about a systemless android device that makes the advantage of having root priveliges but not being recognized by other apps,safety net is a feature of google play services so if i have modded paly store and patched core.jar that means i dont have safetynet priveleges is that wright?Its been years since i rooted and im a little left back on news.
[Magisk] churchey360:
I have everything passing just can't seem to get safety net to pass.. Any help on what I can do to get that working so I can play pokemon lol?
[Magisk] novren:
Hello,

First of all, kudos to the developer, this is an amazing tool and so far it has worked flawlessly for me. But, to the point.

I've read this thread and related ones to no avail, so at this point I feel like I have to ask.

I'm currently running official 7.0 on my oneplus 3, with magisk and phh superuser, plus systemless AdAway, without a problem, and passing safetynet. I have installed viper4android from magisk manager, and as per instructions on the app, downloaded the app from Android file host from the link provided.

My issue is, I open viper4android and load a profile, driver status shows as normal, but it is not processing. I have tried disabling the equalizer from shuttle+ (the player I use), to no avail. Viper has always worked for me with shuttle on marshmallow, although I've never used it systemlessly. Could it be that shuttle needs to be updated to support it? I have it from the amazon appstore, from a promotion, and I think it is slightly outdated (apps on Amazon appstore always are a version behind).

I have read on reddit to delete a file from /system/vendor, but 1. I am not sure if that is safe since is a system modification after all (I've read that safetynet still passes) and 2, since there isn't any twrp for nougat that decrypts data on op3, I am afraid that I won't be able to revert the file if I delete it and after all it's not the cause of the problem.

I really enjoy having v4a and would not like to lose it or roll back to marshmallow.

Thank you for reading this and your patience.
[Magisk] Link_of_Hyrule:
[MENTION=4470081]topjohnwu[/MENTION] is there any way you can add the option to change the download folder location for Magisk Manager to a custom location?
[Magisk] Alucard:
Thats what i wanna know too.
[Magisk] novren:
If your system is stock, and you flash the newest magisk zip (10.2 at the moment), which includes phh superuser, and afterwards enable magisk hide from magisk manager settings, you should be good to go.
[Magisk] Alucard:
Thats what i did and am able to play,but i wonder how to enable the final option with the safetynet.
[Magisk] Captain_Throwback:
I've already asked [MENTION=4470081]topjohnwu[/MENTION] for this. I'm sure it's on his list, but some stability fixes are necessary first ;).
[Magisk] novren:
If you can play pokemon go, then safetynet is passed
[Magisk] doki81:
i am on V10.0 and saw the magisk app prompt for upgrade to V10.2...can i use app to upgrade or better to flash it from TWRP?
[Magisk] Link_of_Hyrule:
This is no problem I understand it takes time to get things done. I just like having all my downloads and such going to the same folder.
[Magisk] AXelzero1:
Is it possible to use magisk modules to add substratum OMS support to any ROM?
[Magisk] jhedfors:
Ooh, that is good question! I want to know too!:)
[Magisk] ali nz:
A simple explaination of magisk is that it's something like exposed?
[Magisk] DAGr8:
So I went full stock flashed Magisk phh r2 and phh from playstore. Safety net kept spininning it never resolved.
[Magisk] doki81:
did you install phh superuser from play store? and then go into magisk app to toggle root hide from setting..?
[Magisk] mobileman88:
That's about the closest there is however it's not exactly the same. You can install Xposed as systemless within Magisk.
[Magisk] novren:
Oh, and by the way, since I can't access the data from within twrp, neither can I access cache or dalvik partitions, so I can't wipe them.
[Magisk] yochananmarqos:
No. Read the release thread. Different aims to accomplish things.
[Magisk] lulli1:
If SafetyNet is something within Google Play Services, I must have passed it by hiding root for the play services. But that didn't do the trick. If I enable the hide function within Magisk, what Apps do I have to hide root for, please? I can't find any usefull and understandable docu or tut for this "how SafetyNet works, and how to set it up correctly" thing. Just thousands of questions and answers in this thread that all seem to fail. I would be very thankful, if somebody could make such a SaftyNet tutorial, Which describes all background and setup parameters. ?
[Magisk] teddy0209:
There's no need to do anything, it was set to pass SN by default. Just enable magisk hide.
[Magisk] Songine:
After installing v10.2, my device has lost root permissions,on RR5.8(Android 7.1) cm-su.

And I think you should not install superuser through the install zip without my permission.
[Magisk] rav101:
Hi all,

I have an International unlocked HTC 10 currently using an unofficial version of SlimROM Nougat 0.5. I have Magisk 10.2 with Magisk Manager 3 and phh Superuser r2 from topjohnwu. I am getting all passes on the status screen and have hidden Sky Go in Magisk hide but it still fails. Anyone else having this issue and able to help me figure out what to do?
[Magisk] Oki:
Magisk v10.2 is still not working in the ZTE Axon 7. After Flashing the zip file in TWRP, Magisk Manager doesn't even detect it is installed!!! I can provide the boot images before and after patching it along with logcat and dmesg. If you are willing to solve this issue just let me know what you need, I can share those files with you and do further testing.

I am eager to see this working in this excellent device.

Thanks!
[Magisk] Alucard:
I can play pokemon but safety is not passed,i dont know how.
[Magisk] Boosik:
Hello I have Huawei Mate 8 and I'm unable to flash magisk on Nougat (official stock build B573). While flashing, phone reboots automatically (tried to flash from internal memory, sd card and sideload).

Everything was fine prior to Nougat update.

Any ideas? Should I provide BOOT.img for testing?
[Magisk] Didgeridoohan:
If you'd read the instructions you'd known that only systemless SuperSU or the included phh's superuser is supported.

It's also clearly stated that unless you root with systemless SuperSU prior to installation it will automatically root with phh's superuser.

If you don't read the instructions things might happen without your knowledge, but as long as you're flashing this by your own free will nothing is done "without your permission".

True, the flashing script might not recognise cm-su and that might cause issues (no idea what happened during flashing since you didn't provide any logs), but that's just a great opportunity to help the community by submitting a proper bug report.
[Magisk] hokiealumnus:
Likely because SELinux is set to permissive. Change that to enforcing and you should pass Safety Net too.
[Magisk] Didgeridoohan:
If you could flash Magisk prior to updating to Nougat, it probably means something changed in the boot image... A recovery.log from the flash would be a good first step. Possibly also open an issue on github if it turns out to be an actual issue with the boot image.
[Magisk] DAGr8:
Thx for the help.

But u asked if I installer phh from play store. And you quote me saying so. What is root hide ??? Magisk hide was checked yes.
[Magisk] Lost Dog:
How or why could you hate phh superuser? It's an actively developed open source root solution. That's like hating a room full of puppies and free candy.
[Magisk] Artim_96:
If hiding it from play services you have some modifications that let it fail. Maybe XPosed, supersu or leftovers of system based installations of them. Or your SELinux is set to permissive
[Magisk] thezet:
Question

I have recently played around with Magisk/MagiskHide and phh SuperSU. Excellent work.

I am running a system on a Sunvell T95ZPlus Amlogic S912 Android TV Box. After some digging, I was able to accomplish the following.

1. Run TWRP

1. Install SuperSU

1. Install Magisk

I had to make changes to the code (for both SuperSU and Magisc) in order for it to detect the boot partition - Thanks Abdul_PT!.

However, I seem to have a problem of getting Magisk Hide to remain installed after reboot. I can enable it in the Manager App (says reboot required), and then execute magic_mask.sh service as root to avoid the reboot and get things working. But how can I make it persistent even after a reboot?

Feel free to ask clarifying questions, as I am somewhat of a Noob in this.

Thanks,

Alex
[Magisk] Fild5x:
Installed v10 on galaxy a5h cm14.0 and so far so good
[Magisk] mo2002:
Deleted
[Magisk] Thomas_BA:
Hi folks,

I made a simple module which containes a apk file, a framework and a permissions file. Every thing is working fine. But just had a look on the log. It seams Magisk now mounts all apps of the stock system /etc and system /framework folder.

What did I do wrong or is that normal behavior?

Log attached

http://cloud.tapatalk.com/s/586fc7458a68c/MagiskManager.zip
[Magisk] lulli1:
Im on a Nexus5 stock 6.0.1. So normally SELinux has to be enforcing by default. Thats why I'm asking for a simple but claer tutorial for this SafetyNet stuff.
[Magisk] Artim_96:
Magisk hide does not work with supersu. If you have Android 6/7 with november patch you need is phh's SuperUser, otherwise you need suhide. Magisk hide can only hide Magisk modules and won't work without phh's SuperUser.
[Magisk] -Happy Feet-:
can you tell where can i find this Magisk patch?
[Magisk] Captain_Throwback:
I don't understand the question. It's done automatically. I'm not sure what you're looking for :confused:.
[Magisk] Captain_Throwback:
This is a Magisk thread, not a SafetyNet thread. You'll have to search elsewhere for those answers.
[Magisk] Artim_96:
There is none. It's just trial end error. There is absolutely no way to find out what it's finding (fit all I know). You can just try to add anything with the same UID as the play services to Magisk hide. To do so you need a terminal app.

Type

Su
ps -n | grep com.google.android.gms

To get the UID of the play services (starts with 1, often with 100, has 5 digits and should be the first number in the three columns.

Then use

cat /data/system/packages.list | grep UID

(Obviously replace UID with the number you got in the first step) and your get shown three different package names. Just search them in Magisk hide and add them.

But anyway, I can't pass it too, but I'm running a custom ROM and the might be something left over they added which is detected by SN. Like I said, the isn't really any chance to find out what exactly is detecting, only that it's detecting something. But working against it was always a loosing game

---------- Post added at 06:05 PM ---------- Previous post was at 06:03 PM ----------

He didn't knew that it's included... That's happening when absolutely nobody reads anything anymore
[Magisk] -Happy Feet-:
Okay thanks. Ich try to Pass sn with AOSP 7.1.1.
[Magisk] grandpajiver:
I posted a reply here, hopefully this will help you:

https://xdaforums.com/showpost.php?p=70425258&postcount=352
[Magisk] Mr.Fearless:
After the installation of magisk 10.2 by recovery, the phone (S7 Edge Nougat) goes in bootloop. Any way to install it?

Thanks
[Magisk] Andreasworks:
sorry you can install Magisk of RR 58 7.1.1 on HTC m8 to take advantage of some features that are not possible with the root? thank you
[Magisk] grandpajiver:
I posted a possible solution here... get the App Systemizer module.

https://xdaforums.com/showpost.php?p=70425258&postcount=352
[Magisk] ptit developer:
Hi,

I haved a OnePlus 3T.

I haved a fresh install of lastest "Magisk" and lastest "SuperUser" (phh).

I activated "Magisk Hide" and check "Root Checker" to test it.

But "Root Checker" continue to say me "I am rooted".

And I continue to have a SafetyNet error : "CTS profile mismatch".

So "Magisk Hide" does nothing !

- Link to my full problem

https://xdaforums.com/apps/magisk/issue-magisk-hide-t3533171/post70424852#post70424852

Thanks in advance.
[Magisk] mo2002:
I thought the ElementalX kernel was resolving stuff but it hasn't. I just want to make sure these are the correct steps withoutrelocking the bootloader

1. Uninstall su

2. Stock kernel

3. Flash magisk

4. Phh Su

5. Profit?

I have magisk v9 installed with the latest beta su. Do I simply need to set permissions or follow the instructions above?
[Magisk] ptit developer:
Hi,

Do you speak to me mo2002 ?

I have full stock phone, I just open it.

Unlock OEM and install TWRP.

Thanks in advance.
[Magisk] thezet:
Reply

The issue is that the image came with SuperSU, but I thought that after installing Magisk, it removed the SuperSU and installed phh's version. In the SuperSU app, I see that systemless is enabled. It says that I am properly rooted. Also, from the manual procedure, I know that Magisk Hide is working.

Is it possible that the launch_daemonsu.sh remained in the system and is incorrectly informing the script to disable hide and phh?

I will try to restore and start from scratch, uninstalling SuperSU first, before proceeding with the installation of Magisk.

Again, thanks for the help.
[Magisk] ptit developer:
Hi,

I haved a fresh install of lastest "Magisk" and lastest "SuperUser" (phh).

/!\ Not SuperSu because "Magisk Hide" will disable itself after reboot !

I activated "Magisk Hide" and check "Root Checker" to test it.

But "Root Checker" continue to say me "I am rooted", so "Magisk Hide" does nothing !

And I continue to have a SafetyNet error : "CTS profile mismatch".

Thanks in advance.
[Magisk] mo2002:
No I'm facing the same discrepancy as you. I'm asking if setting the permissions corrects it or if you have to unroot, install magisk, root with phh, then profit
[Magisk] Artim_96:
Like I said, it's not compatible. Remove SuperSU or use suhide.
[Magisk] ptit developer:
Hi,

Suhide not work anymore since the November update, you will bootloop or stuck at boot screen !

So use Magisk with phh superuser.

Thanks in advance.
[Magisk] DAGr8:
I would very much like for someone to explain to me what is the goal of system less root if it's not to hide root itself? If I'm right then it's fair to say safety net is the main reason 99% of users use Magisk in the first place
[Magisk] ptit developer:
If I try to use Magisk is espcially for SafetyNet.

My problem link

https://xdaforums.com/apps/magisk/issue-magisk-hide-t3533171/page2
[Magisk] Artim_96:
Systemless modifications of /system where developed by Chainfire and adopted by topjohnwu in order to be able to perform OTA updates. That SN wouldn't detect it was just a side effect. Now it does detect it, so a side project is to try to be one step ahead of Google to have at least root and SN. But if app developers like of banking apps or games make too much pressure, for all have to detect those again.

So in the long term there won't be a way to pass SN with too heavy modifications, unless Google manages to split the system in different parts, where one part would be fur the users free to modify, the other part is for apps that really need protection, like banking apps. Sure, I have some ideas how it could be done, on desktop Linux that can ahead be archived (kind of, think about Docker), which could also be used for updating the core Android without the help of the OEMs but it would probably need too much ressurces... And we get quite OT here.
[Magisk] ChokingHazard91:
After enabling Magisk Hide and rebooting you need to select the apps you want to hide root for. If Root Checker is not selected there, root won't be hidden for that app so obviously it'll say you are rooted.
[Magisk] Didgeridoohan:
Public Service Announcement!

Hiding root and passing SafetyNet with Magisk

I've moved this to it's own thread. Go there instead...

https://xdaforums.com/apps/magisk/magisk-magisk-hide-troubleshooting-tips-t3561828
[Magisk] ptit developer:
Hi,

I correct my problem on the thread I opened in correct section.

Thanks everybody.
[Magisk] Artim_96:
Well, here you go. I can say for sure that there shouldn't be any leftovers of the preinstalled root (uninstalled with osmosis' zip, restored boot.img afterwards). Every app with play services UID is added to Magisk hides blacklist, SELinux is enforcing, XPosed is no question under Android 7.
[Magisk] budbay:
I found that the magisk manager app will crash when opened when running microg and Xposed module Fake Gapps to enable signature spoofing. If I disable fake Gapps module then magisk manager app will work as intended but when fake Gapps is reenabled magisk manager immediately crashes. I am running the latest magisk v10.2 with the inbuilt phh superuser, Xposed 87.1 magisk module, on OnePlus 3 stock 6.0.1 ROM. If logs are needed let me know and I can try and get something. Everything else is working great. Thanks.
[Magisk] Captain_Throwback:
A few questions:

- Why are you installing AdAway as a system app? Have you tried not doing that and see what happens?

- Are you confident that Greenify isn't making some modification that is breaking SafetyNet?

- Why have you added additional Play Services items to Magisk Hide? That won't change whether or not SafetyNet passes, but will add unnecessary unmounts to Magisk.

- Have you disabled your modules and checked whether SafetyNet passes?

- It doesn't appear that any of the "tampered" props were detected in the log. Is your bootloader not unlocked, or are you using an older device?
[Magisk] Captain_Throwback:
Logs are ALWAYS needed.
[Magisk] Artim_96:
I'd guess that that is what had to happen. It had built in SN detection, since SN is part of Google play services it will use something from it. If your module is enabled, it thinks the play services are installed but won't get SN checking so it crashes. If the module is disabled, it sees there is no play services
[Magisk] Kr47os:
Hi I'm new on Magisk I have installed latest version 10.2, SuperSU 2.79 sr2 and a custom kernel to fix boot image on my zenfone 2 z00a. I'm on RR5.8.0 custom ROM. When I open Magisk the third box is marked in red white the written "SafetyNet Failed: CST file mismatch". How to solve it?

Thanks to everyone answer, sorry for my english
[Magisk] budbay:
Yes, this is what I thought. I think this should have the relevant info.
[Magisk] Artim_96:
- AdAway comes preinstalled as system app and I made a module that replaces it's folder with an empty one. That's what you are seeing there

- I'm about 95% sure. For all I know the only thing it can do is to be installed as system app for higher privileged, that's why Greenify gets mounted as system app

- I added every app with the same UID as the play services to make sure that every part of them gets detected.

- Samsung bootloaders can't be unlocked and I wouldn't say that a Note 4 is an older device.

---------- Post added at 09:13 PM ---------- Previous post was at 09:12 PM ----------

... You are in the middle of such a discussion, so just read.
[Magisk] Alucard:
I changed it to enforcing with SE Linux mode changer v3.2,and still its not enabled.
[Magisk] budbay:
So you reminded me that microg project has another app for when SN is needed. I installed microg DroidGuard Helper app and now magisk manager app works again. So for anyone running microg with fake Gapps Xposed module make sure to also use DroidGuard Helper. Thanks for pointing me in right direction.
[Magisk] hokiealumnus:
Sorry, that was my best (heh, only) shot. I got nothin'.