yashsingh1/xdaforums huggingface dataset:
[Magisk] Artim_96:
It might break magisk through its way it modifies the boot.img. so just flash your stock boot.img, flash SuperSU and then Magisk and you are good to go
[Magisk] eXtremeDevil:
Could I do that without rebooting? My ROM's zip have a boot.img inside. That's the one? TWRP asks me if it should flash it on boot or recovery partition. I guess it's the first one, but may that file be only a recovery?

---------- Post added 28th November 2016 at 12:17 AM ---------- Previous post was 27th November 2016 at 11:22 PM ----------

OK, so I flashed boot.img to boot partition, rebooted, flashed SuperSU, rebooted, and magisk was there, with it's configs and modules untouched. Custom kernel was lost though. Can anyone tell what happened? xD

Thanks!
[Magisk] 3dawg:
Android pay and safetynet helper are still working/passing even when not adding them to the magisk hide list. Why is that? Is magisk+phh supersu sufficient to hide root on 6.0.1 - without the use of magiskhide?

No complaints, I'm just trying to understand why it's working when I don't expect it to.
[Magisk] andrew2432:
If using susr1-4, rootswitch turns off root just like magisk v6. My lgg2 runs cm13, sr3, rootswitch, xposed 86.2 topjohnwu and passes with root turned off, modules work. Not sure what happens if you use magisk in the mix!!

Edit: rootswitch IS compatible with system xposed versions with magisk and cfsu...I THINK.
[Magisk] waylo:
The process used by SafetyNet is automatically added without any user intervention. The magiskhide list is for adding other apps, such as a banking app, that might need more help.
[Magisk] Artim_96:
Of course not since you have to boot to recovery.

And of course you have to flash it to boot, not recovery, it's a boot.img. and no, the file is not a recovery, then it would be called like that
[Magisk] eXtremeDevil:
I meant from recovery, but without rebooting after each flash.

What about what happened with Magisk?
[Magisk] Artim_96:
You'll have to see if you have to reboot. If you get bootloops you should reboot after every step to find out what's causing it
[Magisk] eXtremeDevil:
OK, and why didn't I have to reflash Magisk? How it survived??
[Magisk] Azlun:
I can not found anybody success to use Magisk for data partition descryption purpose,

anybody success like this even it is not on Pixel XL?

http://androiding.how/disable-verity-force-encryption-pixel-xl-decrypt/
[Magisk] 3dawg:
So adding androidpay to the list is redundant? Since safetynet would trigger if it was detecting root anyway so by bypassing safetynet, it's also bypassing root detection. Is that right?

Thank you.
[Magisk] Didgeridoohan:
I would NOT follow those instructions! I'm not quite sure what you're asking, but Magisk is not yet compatible with Pixel. Of course, it might be that flashing Magisk actually works to a degree on Pixel, but I wouldn't try... To much that can go wrong.

If you're asking if Magisk disables forced encryption the answer is yes. Quoting the official Magisk thread (link in the post you quoted):

Hint: Read the instructions... :p
[Magisk] gwaupogxd:
I'm running Exodus ROM on my angler and wanted to know if theres a way to get Android Pay working for the Nexus 6p
[Magisk] Artim_96:
Luck? Just be happy that it survived
[Magisk] pcfree:
Bugs in v9 script (flash_script.sh / update-binary)?

I've tried to install Magisk v9 to my old Samsung Tab 8.9 AOSP 5.1.1 ROM by TWRP 3.0.2.0 but got fail message "Unable to detect boot image". Although I am not familiar with Linux script, after comparing with v8 script and investigating recovery.log, I guess I might find 2 minor bugs in the update script file.

Line 89 in function find_boot_image():

[ -f "$FSTAB" ] BOOTIMAGE=`grep -E '\b/boot\b' "$FSTAB" | grep -oE '/dev/[a-zA-Z0-9_./-]*'`

This line misses '&&' after condition checking and causes "sh: missing ]" error message in my recovery log. Not many people experienced such error so I think it might be an incompatible issue only to some shell implementation or the script didn't go here but solve BOOTIMAGE variable in previous code for most devices. However, adding '&&' should work for all:

[ -f "$FSTAB" ] && BOOTIMAGE=`grep -E '\b/boot\b' "$FSTAB" | grep -oE '/dev/[a-zA-Z0-9_./-]*'`

Another minor bug is in line 252:

chmod -R 755 $CHROMEDIR/futility $BINDIR

The CHROMEDIR variable is not initialized yet here. It causes "chmod: /futility: No such file or directory " in my recovery log. It seems not cause severe problem so I guess these utilities already have executable flag after unzip. However, it did generate error in log.
[Magisk] ahb83:
I'm having a weird problem:

Every time I update my ROM, I always use TITANIUM BACKUP to remove the bs that comes with the update (bubbes, pico etc etc). When I reboot they didn't really uninstall. Everything is fine, root works, and I tried it again. Same process same result. I ended up removing phhsu and flashed supersu, did the same process, and it was removed after a reboot.

Seems to be that phhsu and using batch uninstaller with TB does not remove it. Anyone else experiencing this? Would this be TB problem or something with the magisk ecosystem?

OnePlus 3

Sultan's CM 13 11/26/2016

Magisk V9

phhsu r266-2

TB 7.5.0.3 (Pro)
[Magisk] MrBrady:
Anybody know if SafetyNet updated in the past 24 hours? Yesterday morning I was passing SafetyNet and making Android Pay transactions. But then last night I reinstalled Gapps and now can't get SafetyNet to pass again.
[Magisk] Captain_Throwback:
Nope, SafetyNet still passing fine here.
[Magisk] MrBrady:
Thanks. I must have borked something
[Magisk] pcfree:
[MENTION=4470081]topjohnwu[/MENTION]

The uninstaller-20161115 has the same bugs as post #6073 with missing "&&" and not initializing CHROMEDIR variable.
[Magisk] waylo:
For many apps, they use Safetynet only to detect root and other modifications. Those should be bypassed by Magiskhide.

There are other ways to detect root though, so some apps use SafetyNet plus another method.
[Magisk] alatnet:
so, while i was on the november security patch for nexus 6, did anyone else have the problem where magisk would just "unroot" everything?

I.E. when opening the Magisk Manager, it reports that there is no root even though root is installed?

I have phh su 266-2 version.
[Magisk] Didgeridoohan:
Magisk Hide enabled? If so it's a known bug and root will return on a reboot.
[Magisk] olivercervera:
I know everybody Is aware of the "loosing root" issue, but I have something to add.

I have noticed that is happening every 2 days or so, but today occurred in a different way.

Apps lost root access as usual, but Magisk Manager still had root access granted correctly, Magisk Hide logs were stuck. Maybe the Magisk Service got stuck?

Rebooting fixed the problem...

Nexus 5X running Android 7.0 Pure Nexus ROM.
[Magisk] Didgeridoohan:
I've had a similar issue. It's been reported on GitHub, so topjohnwu knows about it.
[Magisk] 089man:
Hi, in magisk I have only 10 or 11 modules listed, is that normal?
[Magisk] rignfool:
If it will not return...

Reflash your stock-to-the-rom boot.img... Then reflash the magisk zip overtop of it...

It seems disabling any module causes magisk to freak out and unmounted itself... Or it did to me... And this was my fix
[Magisk] olivercervera:
Yes, it will return, I meant as a temporary fix.

I am not using any additional Magisk module.
[Magisk] AforAnonymous:
The Nexus 6 issue is a bit more complicated than this, there's multiple issues, I think. I'm using Franco's Kernel, r52, on the last update not affected by the previously mentioned issues (unless Franco included the kernel patches that cause these issues in r52 and I overlooked that):

Magisk Manager fails to detect phh's superuser (the 2.0 beta 9 apk.) correctly, even when /magisk does remain mounted and doesn't get unmounted by the bug. As do all other apps at this point - EXCEPT for CF.Lumen (no other apps by chainfire find it) and Lightflow, they still manage to request root, somehow. This seems highly odd. Edit: Addendum: I have DM-Verity on, my /system is completely unmodified and, due to dm-verity being on, cannot even get modified. Maybe this is where the bug sits, *somehow*? I seriously doubt it, tho.
[Magisk] rignfool:
Well...

This would be just you then...

Been using magisk since v3 on pure Nexus and DU with no issue that wasn't bad coding on the part of the app developer...
[Magisk] Didgeridoohan:
I also have a Nexus 6, but running Nougat and Franco Kernel r57 and have no issues with Magisk, apart from if I activate Magisk Hide (the dreaded "no root" bug).

And since Magisk disables verity by default, how come you've activated it?
[Magisk] huhu1030:
Hey guys, I try to enable Magisk hide but I got an fc.

I flashed lasted magisk zip and then phh super user r266. Any idea?

Envoyé de mon SM-G935F en utilisant Tapatalk
[Magisk] Syoenth:
I have a issue with hide magisk, i have activated but when i do the safetynet test it fails... any ideas why is this happening? I'm running Magisk 9 con a Samsung S3
[Magisk] Didgeridoohan:
Did you reboot after activating Magisk Hide? I think I got some FC's when I forgot to do that...

No idea. I know nothing about your setup apart from what you just wrote (very little). A number of things might cause SN to fail. Unlocked bootloader, Xposed, remnants from previous roots and/or mods, and so on... Are you using Magisk phh's superuser r266-2? Are you sure everything is working like it should? Can you provide some logs (magisk log, recovery log from flashing)?

The more information you provide, the easier it is to get help...
[Magisk] Syoenth:
I just made a clean install of RR 5.8 (7.1 Android), i installed the last phh superuser,all is working and the Samsung S3 is bootloader is stock unlocked, i'm adding the last log
[Magisk] Didgeridoohan:
last_magisk.log is actually the older of the two... :) The latest log is magisk.log (the previous one is saved as "last"). Can also be exported from Magisk Manager...

The provided log looks fine though, but... I see you have v4a installed. Doesn't that usually mean setting SELinux to permissive? I believe it needs to be enforcing to pass SN.
[Magisk] huhu1030:
The problem is that I cannot activate Hide feature. As soon as I check the box I got a fc :/

Envoyé de mon SM-G935F en utilisant Tapatalk
[Magisk] Didgeridoohan:
Then you've got some other issue, I guess... What have you tried doing to solve the issue so far (rebooting, reflashing magisk, making sure root is functioning, and so on), if anything?
[Magisk] Syoenth:
I thought that too, I set the kernel to enforcing and still get the blue screen
[Magisk] Didgeridoohan:
Ok... Next suggestion: Does RR have built-in root and if so, have you completely removed every trace of it?
[Magisk] Syoenth:
I did that just after install Root Explorer and recover my apps on TB, maybe SN got updated? I add the very last log of Magick and a screenshot of SN helper
[Magisk] huhu1030:
The problem was coming from the root but i still got an issue. I tried to install Magisk because of Snapchat (yesterday i cleand data and cache). So basically I wiped everything, internal storage, system, cache... everything except external SD. No root is installed yet i'm still not able to login to this bloody app ! I dont know what i'm missing here. Maybe some residual files/folder from previous root ? But what's the point of wiping everything then ?

Any help is highly appreciated :(
[Magisk] AforAnonymous:
Security reasons. Android supports relocking the bootloader even with a custom kernel, assuming each partition was signed correctly. I haven't done this yet, as the ecosystem lacks stability. The idea is this:

If malware and/or an attacker compromise the system while online, either a reboot will eliminate the attack, OR the attack immediately makes a factory reset necessary.

If an attacker gets physical access, well, the only thing they can do is perform a factory reset.

I'm running with dm-verity enabled to identify whether this can currently work, or not.
[Magisk] Didgeridoohan:
OK, cool... You're even more paranoid than me. :D
[Magisk] Ikzy:
I'm stuck with trying to change my dpi.

I creating my own Magisk module to change the DPI of my screen. I figured I need to use the new resetprop tool, but cannot really find the documentation on where to put the command:

/data/magisk/resetprop ro.sf.lcd_density 280

should i put it in config.sh somewhere? or add files to it, and how are they called then? It feels like i'm missing a little step, but I cannot get it to work.

thanks in advance,
[Magisk] turkobr:
Does Magisk work for 32 bits roms? I can't get root using phh systemless root.

I'm on a Moto Z Play running stock.
[Magisk] htb2050:
It does. Are you using latest magisk 9. Have you flashed phh magisk zip and have you installed magisk manager and phh super su which you can get from playstore.
[Magisk] turkobr:
I tried it twice. Did the whole procedure the first time and it didn't work.

Then I uninstalled magisk and tried it again, but after flashing both and installing phh superuser I didn't get root so I didn't bother installing Magisk Manager. Is Magisk Manager is also necessary to get root, I would try it one more time.
[Magisk] eVil_9:
Do magisk improve android performance? i just want to know its benefit other than root mask :confused:
[Magisk] Captain_Throwback:
Maybe you should read the OP?
[Magisk] Artim_96:
Well, in Magisk manager you'll see if Magisk is even running and if phh's SuperUser is installed since the zip from this thread installs it as a Magisk module. Otherwise try if it works with SuperSU.

But asking if Magisk runs on 32 but system when using a Moto Z play with stock system is a bit senseless. The Moto z play uses the Snapdragon 625 which is 64 bit. And I doubt Lenovo made the system 32 bit.
[Magisk] turkobr:
Lenovo made ir 32bit. Probably because of the 3gb ram.

Enviado de meu XT1635-02 usando Tapatalk
[Magisk] DodoGTA:
It can be used to hide root (by enabling Magisk Hide in Magisk Manager settings and rebooting your device, of course) as well as doing mods to the /system partition without actually doing that (useful for OTA updates and some other stuff)
[Magisk] Artim_96:
Then probably Lenovo messed something up by doing that and Moto Z is not supported. Maybe someone with the same device can tell about any experiences
[Magisk] turkobr:
I asked on the device forums too, but no answer yet.

Thanks

Enviado de meu XT1635-02 usando Tapatalk
[Magisk] Razor1973:
I have a T-Mobile LG G4 (model H811) on which I have what I believe to be a systemless root (still learning many of the terms) with phh's SuperUser, a custom ROM (close to stock) and Magisk installed. Isn't this all I need? Android Pay isn't working for me. I am attaching the following screenshots:

01 : SuperSU screen

02-05 : RootCheck app that shows my device is rooted, some system properties, etc.

06-08 : Magisk home screen and hide settings

09 : Android Pay error

What am I missing or doing wrong?

Thanks in advance!
[Magisk] silvercat:
I have Moto Z with no problem in gaining root but I'm not able to flash suhide and systemless xposed by topjohnwu, it give update error 1 while flashing in twrp.
[Magisk] Didgeridoohan:
Ok... You've messed up a little. :)

You claim to use phh's superuser, but your screenshots show Chainfires SuperSU... Two different root methods. If you want to use Magisk Hide with Android Pay you cannot use SuperSU, only phh's superuser (Magisk version).

There are several things that can trigger Safety Net and cause Android Pay to fail. If you want to use Magisk, the least thing you'll need to do is to completely remove every trace of SuperSU, or SN won't pass.

If you haven't already I'd recommend reading the official Magisk announcement thread. A lot is explained there.
[Magisk] Link_of_Hyrule:
My two devices that have Magisk and phh superuser keep saying they are not rooted and I have to reboot to correct it. Is there a way to prevent this from happening?
[Magisk] Alxoom33:
That appears to be fairly common with phh Superuser and Magisk. Reroot and reboot.
[Magisk] Didgeridoohan:
Usually this happens with Magisk Hide enabled. As you've noticed, a reboot activates root again. Disabling Magisk Hide also works.

It's a known bug and it's being worked on...
[Magisk] harpin14789:
Would it be possible to make a magisk module that enables background playback and screenoff playback for YouTube app like on Xposed or would that not be possible.
[Magisk] laggardkernel:
Please read the official release thread, I don't think you have understood what Magisk is yet.

http://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445/page1
[Magisk] harpin14789:
Thanks. I understand a bit magisk a bit better now. :)
[Magisk] andrew2432:
[MENTION=1524420]Rozo[/MENTION]r1973

When you installed your new Rom did you boot and remove the superuser access it had within?
[Magisk] me7tarfeek:
Can someone please help?

I need to know if magisk can be used with LG V20 (H990ds) locked bootloader....

Thanks in advance
[Magisk] Razor1973:
I know this may sound a little stupid (and probably is), but I didn't know if the SupeSU application only managed SuperSU. I figured that if you had phh SuperUser, the SuperSU application would be able to manage it too. Later on, I found an unofficial phh SuperUser management application and realized I was wrong. That said, I did have phh SuperUser installed, not SuperSU. Actually, I had SuperSU first, but then, installed phh SuperUser. I found no way to uninstall SuperSU, so I assume that flashing phh replaces SuperSU. Does it not? The latest one you flash is the only one you have, correct?

I am not sure if my statement above answers this, but I think it does.

All this out of the way... I also read towards the end of this thread that Magisk is no longer working with SecurityNet and the only way to get Android Pay to work is now RootSwitch, which I also tried unsuccessfully. I've seen posts on suhide, Xposed, Magisk, RootSwitch, etc. and I'm not sure what to try at this point.
[Magisk] Captain_Throwback:
You uninstall SuperSU using the "full unroot" option in the SuperSU app. If you didn't do that, then you still have remnants of SuperSU on your device. Installing phh's Superuser doesn't remove SuperSU. On that point, you are quite mistaken.

Additionally, SafetyNet passes fine with the latest Magisk and Magisk-compatible phh Superuser, if you enable Magisk Hide. I'm not sure where you got your information, but most of it is incorrect.
[Magisk] AforAnonymous:
New information:

Magisk Manager registers for the app usage statistics data permission (I don't remember what the permission is properly called right now), but doesn't actually request it. I was hoping granting this permission manually would solve the force close issue related to Magisk Hide - unfortunately it does not...

Here's my current environment:

Nexus 6

Android 6.0.1 MOB30W

Franco r52 Kernel

Magisk v9 (not v9.1, I suspect v9.1 would solve the issue, but it's only available for HTC devices right now...)

Magisk phh superuser v266-2

ViPER4Android FX v2.5.0.5

Magisk Xposed 87.1

After updating to the Magisk Xposed Module 87.1, my phone (still) seems to randomly boot either with Xposed, or without Xposed. There does not seem to exist a pattern to this. And I always do a proper power off to avoid the infamous Soft-Reboot issue. So, it looks like there's *some* race condition going on here.

*If* my phone boots with Xposed enabled, root works in all apps EXCEPT Franco's FKUpdater. If Xposed does (for whatever reason) not activate, root only works in CF.Lumen & Lightflow.

If Xposed DOES activate, I get tons of force closes from all kinds of apps - UNLESS I manged to first wipe the ART cache partition - at which point Android recompiles a HELL of a lot more apps than it does if I don't wipe ART, and takes way longer to get to this point (and the Xposed triggered recompile already takes ages *without* that). There's only one exception, as mentioned above: Franco's FKUpdater does not recognize that it has root, although phh's superuser logs that the root requests (and logs them as granted, after the root was granted.).

Whichever race condition exists when using Franco's kernel on a Nexus 6 alongside with phh's superuser, Viper & Xposed, it's a highly annoying one, and I assume this does not happen with the stock kernel.
[Magisk] Razor1973:
Did that and, as you can see below, I now have phh's SuperSu latest version installed, Magisk latest version installed, Android Pay and Play Services checked in the hide settings, but Android Pay still doesn't work. I even restarted after setting everything up and tried again... Nothing. Any other ideas?

Thank you!
[Magisk] MrBrady:
As of today I'm getting SafetyNet failures. Did Google update something in their end to detect Magisk 9 and Superuser 266-2?
[Magisk] Didgeridoohan:
There's something on your system registering with Safety Net, obviously. There's a couple of things I can think of, of the top of my head:

-There are still remnants of SuperSU

-You have SELinux set to permissive

-Xposed (you didn't say if you have it installed, but it's worth mentioning)

-Something else :p

The easiest way for you to try to pass SN would probably be to completely wipe your device (not a factory reset, a compete wipe) and start from scratch.
[Magisk] Razor1973:
I'm trying to avoid wiping the phone and having to start all over installing and configuring all apps, custom ROM, etc.

I used SuperSU's "Cleanup to use a different SuperUser" and "Fully Unroot" options and, on top of that, I flashed the SuperSU uninstaller ZIP I found somewhere. I figured this would leave no traces of SuperSU.

I don't know how to check SELinux. I searched and it's supposed to be in the Settings>About menu, but I don't have such thing.

I did have Xposed in a previous configuration, but have since used the Xposed uninstaller. I'm assuming that one's gone too.

At this point, all I can think of is the custom ROM I have installed. Is that possible?
[Magisk] Captain_Throwback:
Did you flash your original boot.img before starting over? Does the ROM you're using come with some root method built in, and if so, did you remove it? As was previously stated, clearly it's something on your device, and if you're not willing to start over to get it working, then you may just have to live with it.

EDIT: I see one of the features in the ROM thread that you're using says "Rooted System" which is the first most obvious thing that will break SafetyNet.

EDIT 2: SELinux might also be running in permissive mode, which SafetyNet doesn't usually like. You'll have to check that via Terminal or adb shell using the "getenforce" command.
[Magisk] audiobyaqstica:
Why Isn't Systemless A Solution For MIUI?

I flashed magisk on the concept that I could get ota update done without any issues. Everytime when an uodate is available, I had to restore the stock. But with Magisk, the story was different. Every MIUI update checks for modified boot.img and itself contain boot.img patches. So It fails everytime with Magisk. I removed boot verification lines from the update script and I had left over boot.p, which is the boot patch in the zip itself and flashed the compressed zip, just to end myself in bootloop.

With Magisk v9, I couldn't find a Xposed Systemless, which gets completely working.

Sadly, Is MIUI compatible with Magisk?
[Magisk] yochananmarqos:
No, Magisk does not have the ability to flash OTA's while rooted like FlashFire does. Magisk & the phh superuser module patch your boot.img. You need stock boot, recovery & system before an OTA will succeed on any device.
[Magisk] armando_rod:
I'm using Resurrection Remix Nougat 7.1 with Magis v9, I have checked Magisk hide but after a while the ROM loses root access for all apps and I have to restart the phone, it would be a ROM problem or Magisk?

TlDr ROM loses ROOT after like 20 hours when Magisk hide is ticked. Dont know if its Magisk or the ROM (Resurrection Remix N)
[Magisk] Jinded:
This issue has been posted many times... it's a Magisk issue that is being looked into. Just have to restart.

---------- Post added at 03:11 PM ---------- Previous post was at 03:07 PM ----------

I used Android Pay at Whole Foods about 10 minutes ago, so might be something on your system. I'm using the same setup.