yashsingh1/xdaforums huggingface dataset:
[Magisk] zgfg:
You can try:

- backup boot img from TWRP

- flash SuperSU uninstaller zip (there used to be available)

(Or try uninstalling SuperSU by SuperSU mngr app, but I'm not sure could it clean-up once SuperSU was built-in to your ROM)

- backup this new boot img

- still from TWRP, restore the first backup

- boot to system, install Magisk Manager and patch both boot images (maybe patching the first would fail) - patching does not need root and SuperSU does not intefere

(You can directly patch the backed-up boot.emmc.win files)

(Ofc, if you could grasp somewhere the boot image for your ROM without SuperSU, then use that one - but I assume SuperSU was built-in to your custom ROM)

- reboot to TWRP and experiment by flashing the patched boot images - if neither would work, restore the first/original backup

(You could also flash from fastboot but for me there was never a difference if I flashed boot or recovery images from TWRP or from fastboot - I observed differences only when flashing some custom system images - they really required flashing from fastboot)

- when you boot with the Magisk patched img, root programs should start asking for root privileges, grant them and they should hopefully work

- wiping cache before booting the patched image(s) could also help
[Magisk] pndwal:
Sure. Magisk can be installed with NO custom recovery. This method is usually less fraught too.

Best to follow official method for this. Regarding Custom Recovery, it says:

See Installation Instructions:

https://topjohnwu.github.io/Magisk/

Main page (downloads, info):

https://github.com/topjohnwu/Magisk PW

---------- Post added at 09:55 AM ---------- Previous post was at 09:11 AM ----------

In addition to suggestions from [MENTION=7786725]zgfg[/MENTION] above, a Stock boot image is likely no good if you're running a custom ROM. You need to extract boot.img from (unrooted) custom ROM and use Patch Image method after installing Magisk Manager. See my post above.

I'd also suggest following the now up-to-date official Installation Instructions and flash the patched image from ADB Fastboot (PC), not from TWRP, unless you absolutely have to.

If not able to use / locate clean image, you should also try all Cleanup / SU removal options in Official SuperSU apk (Manager) (download: https://supersuroot.org/download/ ) and check system boots before installing Magisk. PW

PS. Judging by the photo, your whole problem is probably just the way you're holding your mouth. :p Cool costume though. You'll go far! :laugh: (Dancemonkey?)
[Magisk] zgfg:
Edited/extended my previous post regarding to these points.

I hope by little salt, he could make it?
[Magisk] pndwal:
But it's apparent this ROM isn't prerooted. OP says root can be added:

https://xdaforums.com/samsung-a-ser...7-1-2-aosp-extended-4-6-t3771822/post76088864

So should be a simple matter of extracting boot.img from AospExtended-v4.6-a5y17lte-20180331-2043-UNOFFICIAL.zip etc, and following official method for patching image and flashing.

Alternatively, flashing extracted boot.img in TWRP should also achieve successful unrooted boot, after which Magisk zip installer could simply be flashed from recovery also.

I agree this probably presents no problem on legacy devices where TWRP is fully compatible, and John says as much in Official Installation Instructions.

However, this user had bootloop, and others have reported errors flashing boot / recovery image files with TWRP (implementation ranges from buggy to good, especially for non-official builds) and no such problems using fastboot, even on older devices.

Also, while John prescribes using custom recovery to flash zip installer on Legacy Devices, he does give the rider I mentioned before:

He instructs users to flash patched images using fastboot. (This method "is guaranteed to work 100% of the time.") Use of TWRP to flash these is not even suggested.

So it seems TWRP is fast becoming irrelevant, at least for Magisk's purposes (it has not been made compatible with any devices shipping with Android 10 or 11), and while it will probably work here, I prefer personally not to bring unknown factors into the equation, and to follow best practice, especially when troubleshooting / brainstorming.

That said, there will be extenuating circumstances. Eg. some users simply can't get fastboot going, so these will certainly be happy to have the TWRP option. (- Of course, these still shouldn't need to flash patched image in TWRP as they are also able to use traditional and official zip installer method.) PW
[Magisk] robbayani:
thankz for the tips.. next time when clean flash rom + magisk i'll added manually via terminal..
[Magisk] HippoMan:
That's great news! Do any of those banking apps happen to be for Chase bank, by any chance?

.​
[Magisk] zgfg:
As a couch potato I use TWRP as much as possible (+ MiXPlorer, Hex editor...), everything just that I don't need to go to the other room to rev up the PC

Btw, my Xiaomi Mi 9T, MIUI 12 is Android 10 (SAR, not A/B, and not read-only although a free space on root is very limited, hence systemless is really needed) but there is even the official TWRP 3.4:

https://dl.twrp.me/davinci

It fully supports the device - e.g when booting to TWRP, type in the Android screen unlock pin to have full access to the local storage (Data and Internal memory)

I don't use the official but a Russian custom 3.4.0.2 where I can manipulate with more partitions like Persist, Vbmeta, Dtbo, etc.

There is also OrangeFox (no more officially supported but probably better supported now) for those who like different UI

And AFAIK, that's the case for the other Xiaomi phones with MIUI 11/12, Android 10 (at least, I see in threads for the others from Redmi K20/Mi 9 lineup) - some don't have the official TWRP and/or the official OrangeFox but do have custom versions
[Magisk] HippoMan:
Would you be willing to share a reference to that Russian custom 3.4.0.2? Private message is fine, if you prefer.

Thank you very much.

.​
[Magisk] zgfg:
https://xdaforums.com/mi-9t/how-to/recovery-unofficial-twrp-3-4-0-1-t4135159

There is 3.4.0.2 in the OP, maybe there are even newer versions on Telegram or 4pda.ru
[Magisk] Mirardt:
Hello there, this time in this thread (:

Do I understand it right that I just flash this zip with twrp and it will give me a whole damn lot of space on system partition? And if my device bootloops, I can just restore a backup and all will be fine?

Sounds too good to be true.
[Magisk] wbercha:
Hi guys, is there any way to remove this app isn't compatible with your device anymore? I have magisk hide installed.
[Magisk] zgfg:
Nope. First, as a module, it has to be installed from Magisk Manager.

It works systemlessly, it does not remove any system apk but mounts and overlays dummy app over.

But you can see which apps are safe to remove in MIUI 12 - although, your Chinese firmware may have more.

See also the answer (I think it was) in MHPC thread
[Magisk] odlaw2020:
patch image with older version

Is it possible to persuade Magisk Manager to patch my boot.img with an alternative version of Magisk?

I'm told that 20.4 is not compatible with my hw/ROM combo (moto g6 and Lineage Resurrection Remix) so I'd like to try patching boot.img with a version that I'm told should work (20.3). However MM is only offering to download and patch with 20.4.

many thanks

G
[Magisk] zgfg:
Yes, go to GitHub, stable.json

https://github.com/topjohnwu/magisk_files/blob/master/stable.json

go to History, find 20.3 (you will need some time to figure out? - to learn for the next time), take the link to Raw

https://github.com/topjohnwu/magisk_files/raw/5cd6569c6439fdf67f0261806927f89e304b5a6f/beta.json

(easier to give you the link than to describe the sequence of clicks - but ppl, take your excersize)

put that link to Update channel, Custom and then do Install/patch
[Magisk] jaythenut:
just got me a pixel 5 installed canary and done the boot.img just fine but got bootloop so guess i was jumping the gun lol
[Magisk] pndwal:
'May' work now, but looks like you're a guinea pig:

https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post83692687

https://mobile.twitter.com/topjohnwu/status/1315582825081364480 PW
[Magisk] jaythenut:
sweet, is there a new build or not yet :D
[Magisk] martyfender:
If I'm not mistaken, Samsungs are not capable of fastboot. One. must use Odin in download mode.
[Magisk] pndwal:
Yes, but Mi 9T SHIPPED WITH ANDROID 9 and likely lacks dynamic/logical partitions. So you're lucky... but you'll probably need to be prepared to get off the couch when you get your next device!

As discussed, TWRP still does not support devices that shipped with Android 10:

https://www.xda-developers.com/twrp...s-support-legacy-devices-upgraded-android-10/

Latest TWRP 3.4.0 arrived in June 2020 w/ support for devices upgraded to Android 10 (only). There's been no further versions.

So this will depend on partition structure too I guess, and these will therefore necessarily be unsupported if shipping w/ Android10.

But I quite agree - TWRP was / is great while compatible. Seems Team Win are just not getting enough Dev support to meet the challenge of ever changing Android device architecture though... Took an age to support just Devices updated to Android 10, like yours! :(

Of course, like most custom development, this is purely a volunteer effort by developers with real lives that take priority. Please see post below regarding the fantastic service Team Win and associated developers have rendered this community:

https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post83727153 PW
[Magisk] Muledeer:
21004 worked for me

downloaded 21004 from this thread and worked for me - pixel 3 with october update android 11 (clean first time install)

21000 did not work for me

thanks everyone for the thread of information

Now just have to figure how to make magisk do its magic

Mule
[Magisk] pndwal:
Latest is 21004. PW
[Magisk] dope77:
Dude, whenever i set the update Channel to Canary, the manager would lose internet connection, it just shows me N/A as latest version (it works fine for beta and stable) and it wouldn't install any modules because of networks issues. But anw turning on DNS over HTTPS from the settings solved the issue. Anw thanks for help
[Magisk] Muledeer:
Help after magisk

guys - I have Magisk running fine on my Pixel 3 with October update android 11

root is working under Magisk but I cant seem to copy an APK to system\priv-app - is Magisk blocking me and is there a solution?

I have Root Explorer running with root access - it tries to copy after granting r/w access but fails

Thanks

Mule
[Magisk] bradical711:
You can't modify the "/system" partition on android 10 or higher I believe, that is why you're getting that error. You'll need to use a magisk module to put an application in "/system/priv-app" what application are you trying to move in there and why.?
[Magisk] Muledeer:
thanks for the help - the application is a fake gps apk. I never used magisk before - I'll research magisk module
[Magisk] bradical711:
You're welcome, and oh okay I see. So Magisk is a basically a "systemless" implementation of root with universal "modules" that allow you to modify your /system "systemlessly". Newer versions of android greater than 10 no longer allow the modification of the "/system" partition. Because of this, the "modules" are the only real way of modifying anything in /system and magisk does this all "systemlessly" through the modules. I also went ahead and linked the magisk module guide so you wouldn't have to spend time searching for it. It'll be at the bottom of this post. In the link I have listed is a guide to help you create your own magisk module from magisk's author himself, topjohnwu, posted via GitHub. https://topjohnwu.github.io/Magisk/guides.html
[Magisk] pndwal:
As has been mentioned a few times in this thread now, Team Win Recovery Project (TWRP) still does not support devices that launched (shipped) with Android 10 or later. However, TWRP has been / is a great and invaluable tool while compatible.

TWRP has clearly given impetus to custom Android development for many years now, and Team Win Lead Developer Ethan Yonker [MENTION=912474]Dees_Troy[/MENTION] as well as contributers like [MENTION=299139]bigi[/MENTION]ff, [MENTION=4544860]osm0sis[/MENTION], [MENTION=4898097]arter97[/MENTION] and [MENTION=4712355]mauronofrio[/MENTION] have undoubtedly performed an invaluable service improving it and adapting it to ever changing Android device architecture.

However, as observed, TWRP seems to be fast becoming irrelevant, at least for Magisk's purposes due to incompatibility. Why is this happening?

Apparently Team Win are just not getting enough Dev support to meet the challenge of keeping up with changing Android device architecture.

Like most custom development, this is purely a volunteer effort by developers with real lives that take priority. This time last year [MENTION=912474]Dees_Troy[/MENTION] said:

https://twrp.me/site/update/2019/10/23/twrp-and-android-10.html#

So Team Win's Lead Developer now has pressing and growing family responsibilities, and, of course, something must give!...

It seems to me TWRP is now an endangered species.

I do hope more Dev support comes, challenges are tackled, and this Great Custom Recovery is not relegated to the annals of history. :crying: PW

Edit:

Interestingly, [MENTION=2638973]bigbiff[/MENTION] is making headway with TWRP 3.4.0-0 (Test builds) for Pixel 4/4XL (flame/Coral; both apparently share same mainboard named 'floral') on Android 10:

- https://xdaforums.com/pixel-4/development/twrp-flame-testing-t4110641

- https://xdaforums.com/pixel-4-xl/development/twrp-coral-testing-t4111017

It's working with kernels that support R DTBO and LZMA ramdisk, so I guess it will still take much work to make it work on devices with stock kernel only (lacking this support), but good for devices w/ custom kernels available.

Other incompatibility to solve:

This bodes well for TWRP. :good: :)

OP says:

PW
[Magisk] daktary:
No, but bank apps uses different ways to detect root, so could work for you. Let's try
[Magisk] pndwal:
Seems this is correct. :good:

Guess [MENTION=5565528]PistolSlap[/MENTION] could flash Magisk patched tar image using Odin, etc, as described in extensive special section for Samsung, even though this method is specified for devices launching with Android 9 and above. (This device launched with Android 6.)

https://topjohnwu.github.io/Magisk/install.html

0r keep searching for button combination to enter twrp to flash Magisk zip installer, or alternatively boot to recovery from System using Advanced Reboot in settings, Developer Options... If this doesn't appear, type Advanced Reboot in Playstore and download an app such as RebootManager to do the same. PW
[Magisk] HippoMan:
Thank you. But I have tried all those things, and Chase still detects root.

There is an entire thread about Chase's detection of root: https://xdaforums.com/apps/magisk/chase-app-detects-root-t4099627

I was just hoping that a way to bypass their root detection has been found. Oh well ...

.​
[Magisk] dahawthorne:
I'm being offered an upgrade of Manager from 310 to 311 (and Magisk 21004 to 21005, but it's greyed out until Manager is updated), but the install button and changelog button both do nothing. I've rebooted twice and it's been like this for a couple of hours now.

Just me...?

I did as [MENTION=8010004]guest4711[/MENTION] suggested (thanks) but I was really asking if there was a problem, as this has never happened to me before. Still, all now ok; Manager manually updated, normal Magisk update worked from there.
[Magisk] guest4711:
Welcome to the club. I have that problem on some devices (klte) but not on others.

If MM is not hidden update it by downloading it from github and installing manually.
[Magisk] pndwal:
Thanks. Just updated fine for me.

But isn't this normal? - Latest Magisk generally needs latest Manager, so 'Install' (Magisk) doesn't work, and 'Install' (Manager) has become 'Update'. After updating Manager, you should see working 'Update' button for Magisk. PW

Changelog:

Magisk (4e0a3f5e) (21005)

- Support new lz4_legacy compression format (previous lz4_legacy format is renamed to lz4_lg)

Magisk Manager (4e0a3f5e) (311)

- Significant smoother Magisk Manager hiding experience on Android 9.0+ (stub hiding). We utilize ContentProvider to sync with the original app at initial launch.
[Magisk] zgfg:
Updated Canary 21004/310 to 21005/311 and everything looked ok.

However, then I downloaded Canary Manager 311 apk and installed (over the already installed 311 !!!)- and then I had:

-Latest Magisk: N/A

Installed 21005

-Latest Manager N/A

Installed 311

?!

Then I uninstalled Manager and installed the same apk again, it now correctly shows the Latest versions
[Magisk] pndwal:
Looks like internet connectivity problem... except Check SafetyNet still shows... PW
[Magisk] zgfg:
No way.

Everything was fine just until I re-installed 311 from apk - downloaded a second earlier with no "Internet connectivity problem" from Github.

Restarted Manager twice - still the same

In parallel I was still in browser on GiTHub, and to be sure that there is no connection problem (towards the GitHiub) I browsed through the history of app-debug.apk with absolutely no connectionn issues

Then immeaditely when I uninstalled Manager and installed from the same apk again, 'Internet connectivity problem" dissspeared

Edit: During the same "Connectivity" problem, I opened Modules and it didn't crash (put Airplane on and try to open Modules tab - 310 and 311 will immediately crash, there is an Issue opened on GitHub).

It didn't crash and I was also able to browse through the Repo
[Magisk] xunholyx:
I have a question which is super OT......

Why do you end every post with "PW"?

We can all see who you are without that.

Not slagging, just curious.
[Magisk] pndwal:
Yeah, that's why I commented 'looks like it EXCEPT for SafetyNet showing', as the 'N/A's appearing is a symptom of this, but of course the Check SafetyNet appearing (screenshot) suggests an anomaly... Anyway, as expected you've considered it. Sorry to state the obvious. PW

---------- Post added at 01:47 AM ---------- Previous post was at 01:20 AM ----------

Haha. - I'll allow it. ;)

It's because I'm horribly conceited. (I am as mad as he,

If sad and merry madness equal be.)

Really, just my way of signing off, and I've made it a habit. (I also talk to myself out loud... but don't have hairs on my palms, at least when I checked.) :D

It does have a practical use though.

If I search back for a post I know I've made on an issue here, including my initials is far more effective for bringing up the posts in order than typing my user handle, both because it appears in the post body (search seems to find user handles very randomly), and because it's short and unique. At least, that's how it works in Labs App for me.

I find this useful as I use XDA to keep track of stuff I may need to revisit myself, as much as I do to try to assist others... I could use my Photographic Memory for this, but it needs developing. :laugh:

Hope it satisfies your curiosity. PW
[Magisk] AndreM962:
Okay, so I have bought a Galaxy M31. I have enabled OEM unlock in the developer options. I have gone to download mode and found no RMM state message. Is it okay to install Magisk at this point? Have I forgotten anything?
[Magisk] daktary:
if you run the latest version of Magisk, check the SafetyNet in Magisk, but also in GooglePlay.

I added module MagiskHide Props Config, and choose a valid model of phone with the same OS.

Maybe is that module necessary?

good luck
[Magisk] HippoMan:
Thank you very much. I'm running the lastest Magisk, and SafetyNet passes in Magisk, as well as in GooglePlay. The Chase app goes a lot further than simply checking SafetyNet, and it still detects root. Many of the details of Chase's procedures are described in the other thread that I referenced.

I'm hoping that some day there will be a way to hide root from Chase's more intrusive detection methods.

.​
[Magisk] AndreM962:
I have tried to install Magisk via ODIN, but I had to remove it immediately, because afterwards it kept going into download mode and telling me there was something wrong with 'vbmeta'. I don't know what that means. Here's the full message:

ODIN MODE (AVB Fail)

vbmeta: Error verifying vbmeta image: HASH_MISMATCH (3)

vbmeta: VERIFICATION_DISABLED bit is set.

CUSTOM VBMETA

VBMETA M315FXXU2ATIB, 34585361R

Oh, also. Will I lose Magisk if I factory reset the phone? I want to wipe all my data so I can give my old phone to one of my cousins.
[Magisk] dr4go:
Sorry for the late reply. Yes, exactly... But I just wanted to mention, that in my case it's a pure data app and not a system app. That's why I find this mount -bind thing even crazier, because it basically doesn't serve any purpose in my case and just breaks things (more easily - in case it even works).

[MENTION=4667597]Didgeridoohan[/MENTION] Thanks a lot for the hint, that it can also break SafetyNet, which really is then (even more) a no-go for me.
[Magisk] xNotta:
Bootlooping

I am going to regret posting this so hastily but I'm hoping that my issue is a known problem or an obvious mistake that has an easy fix. I am about 6 hours into reading and trying things and am very frustrated, apologies in advance for this hasty post.

I'm on a Pixel 3a on October's Android 11. I used the Beta Magisk to patch my boot (then later tried the canary).

It was up and running then I enabled a module and rebooted, then bootloop.

I tried pulling dmesg but my output file is empty. I can grab an ADB logcat but it said for bootloops, adb logcat isnt useful.

I've tried the remove module command and it reboots to "No valid slot to boot" (adb wait-for-device shell magisk --remove-modules)

The Pixel 3a does not have TWRP and I can't access the modules folder without su.

Re-flashing the stock boot.img return the phone to normal., unrooted.

What info I can gather to diagnose my issue and what else can I try?
[Magisk] AndreM962:
Not to sound annoying, but any help here?
[Magisk] xunholyx:
wut?
[Magisk] astracd:
I searched around but could not find if someone already asked this question.

With newest magisk manager - how can you see if some of your modules have updates that need to be installed?
[Magisk] pndwal:
Really, you need to provide more details to get help with this.

Please let us know what model, whether device is A/B, SAR, uses Ramdisk, if patching boot image or recovery image, using tar image etc. Please confirm you're using correct method for your Samsung device ( https://topjohnwu.github.io/Magisk/install.html ), and any other relavent information.

Then maybe a member like me could give general pointers, or better, a Samsung user (having experience w/ Odin etc) may be able to give device specific advice.

Sorry, but the description as it stands, is just too vague. PW
[Magisk] zgfg:
Question and answer with a screenshot:

https://github.com/topjohnwu/Magisk/issues/3337
[Magisk] astracd:
I didn't look there that is for sure. :silly:

Thank you. :good:
[Magisk] Didgeridoohan:
https://github.com/topjohnwu/Magisk/issues/3295

Factory resetting will wipe /data, and all Magisk files reside in /data/adb. So yes, the Magisk files will be deleted. But, the boot image modification will still be intact.
[Magisk] Didgeridoohan:
If it's a module that's causing your issues you can boot to Android Safe Mode (usually something like: hold the power button until the manufacturer logo appears, then press and hold volume down until the device starts up in Safe Mode, your Google-Fu will help you find the answers you need :cool:). That will disable all modules and they'll remain disabled when you reboot again to get out of Safe Mode.

https://topjohnwu.github.io/Magisk/faq.html#q-i-installed-a-module-and-it-bootlooped-my-device-help
[Magisk] soder:
Send a PM if you want some help with testing. I don't know anything about coding though. =(

/Söder
[Magisk] dtective:
You can't, the feature has been removed. Read the update notes posted on this thread.