yashsingh1/xdaforums huggingface dataset:
[Magisk] cnjax:
Is anyone really surprised by this? , at magisk's beginning topjon, stole chainfire's work to get magisk to work. Don't believe me search XDA threads that document what took place.
[Magisk] Didgeridoohan:
Two wrongs make a right? No...

What you're talking about was a very interesting episode in Magisk's history. Basically, because of his inexperience [MENTION=4470081]topjohnwu[/MENTION] made a mistake and used [MENTION=631273]Chainfire[/MENTION]'s code without his knowledge or permission. Things ensued and Magisk almost died right there, but in the end they talked it out and worked through it. John had a massive learning experience and likely came out the other side a much better developer.
[Magisk] Sanzium:
I totally agree with [MENTION=4667597]Didgeridoohan[/MENTION].

That's the point, two wrongs definitely don't make a right. The episode where John used Chain fire's work without his consent was a bad thing, but John apologized (and it seemed sincere, it really looked like a silly mistake by a newbie developer he was back then) and removed all of Chainfire's work from Magisk, making his own implementation with the help of phh's supersu. Since then, there is no "stolen work" in Magisk. Everybody's work besides John's has the authorship kept in GitHub.

Maybe "stole" was a little too harsh of my part, these modded zips are actually breaking GPLv3, under which Magisk is licensed, by not providing the source code. This, in my opinion, is not only damaging to the open source community but also potentially dangerous for the users, as no one knows what has actually been coded into these modded versions.
[Magisk] cnjax:
I wasn't defending either situation, was simply pointing out that it has happened previously, and your account is correct but it should be pointed out that topjohn had to be called out publicly before he made things right with chainfire.
[Magisk] pndwal:
Sure, but still seems it may be... Seems there are a number of problems w TWRP & A11 aside from partition scheme, as indicated by TJW:

and because many Xiaomi mi 9 users/threads/ even Devs (including for 9T I think) seem to concentrate on methods using TWRP, I wonder if many (any?) have actually tried patching boot image/fastboot method with STOCK recovery intact. I therefore thought (still do) that it's well worth trying. I certainly would if faced with such a problem...

Many will recall discussions here re. Magisk w/ early A11 adoption. Some were adamant that Magisk would not work with TWRP loaded. This proved false respecting a number of devices, but restoring stock recovery was the only way many pixel users and others were able to root successfully... PW

---------- Post added at 03:42 AM ---------- Previous post was at 03:17 AM ----------

Well said.

Not sure what this means though:

... re source code, Jorrit's work was closed source, but John's is all open AFAIK... PW
[Magisk] Sanzium:
Sorry, it's probably the language barrier. English is not my main language. What I was trying to say is that the GitHub system keeps the name of everyone that submitted pull requests to the Magisk repository, so everybody who contributed actually has his credit maintained. Yeah, Chainfire's work was closed source, but that's not what I was mentioning, I was mentioning the present state of Magisk after John solved the trouble with Chainfire's private works.
[Magisk] zgfg:
Sorry for distraction but anybody able to use this new forum?!

When I open this thread in browser and tap to go to the Newest, it opens me posts from Nov 2 (a month ago) and I cannot see any newer message

Even worse, in XDA lab app it shows me for Subscribed and Participated threads Network error and cannot open any of my favorite threads from there

On the other phone I logged out from XDA app and cannot login anymore - it always says wrong password

Completely USELESS

Edit:

-Even worse, in this thread I can only see page 1 and this last page 2139

I click on 2138 or <, it halts for a minute or more and then opens page 1 from 2016

Click again to 2139, it takes minutes to open

-All info previously watched threads are lost (must mark them Watch now) and all posts, threads, forums are marked New (must mark them as Read)

-All previous likes given to the posts are gone

-When I'm writing here and tap to Enter, it opens new line but does not jump to that new line

Cannot believe that XDA (some experts/hacking platform) will now have this

total bu...hit
[Magisk] Didgeridoohan:
@zgfg Moving one of the largest forums in the world is not an easy task. There will be hiccups, but I'm sure they'll get sorted.
[Magisk] lolovato:
Hi, I encountered a problem with SafetyNet after updating Magisk that I do not know how to resolve.

First of all my specs: I have a Samsung Galaxy A5 2017 SM-A520F with Android 8.0 and TWRP Recovery.

I was running Magisk 20.4 and SafetyNet was fully passing, then yesterday I updated to Magisk 21.1 and SafetyNet started not passing fully (both basicIntegrity and ctsProfile now fails).

These, in order, are the things I tried to fix the problem:

Rebooted the phone.

Cleared the cache of Google Play Services, then rebooted.

Turned off/on MagiskHide, then rebooted.

Disabled Debug USB, then rebooted.

Installed MagiskHide Props Config to change the fingerprint, then rebooted.

Unistalled Magisk completely via recovery, unistalled Magisk Manager, then re-flashed Magisk 20.4 and re-installed Magisk Manager.

Updated again to 21.1 and re-did all the past points.

All this failed and SafetyNet still fully fails, so I re-unistalled everything and re-flashed Magisk 20.4.

I should also note that after re-flashing Magisk 20.4 I think the system unrooted itself because all

the superuser requests were starting to get denied, the phone bricked and got stuck in bootloop

, so I had to re-enter recovery mode to flash again the unistaller and the installer for Magisk 20.4.

After that I reinstalled BusyBox + MagiskHide Props Congif, but I can no longer use the last one. If I try to call it this is what I get:

$ su
a5y17lte:/data/data/com.termux/files/home # props
/system/bin/sh: props: not found

What other things can I try to pass again the SafetyNet? I need to pass it to use some apps that I am now locked out of.

I will also attach the log of Magisk, in case that helps.

Thanks in advance to anyone that will help.
[Magisk] bignu77:
Good morning,

Im having the same issue. I dont see where anyone replied. Have you been able to solve this issue if so how?

PLEASE AND THANK YOU :)
[Magisk] ImTukiin:
Whats the current stable version of magisk?
[Magisk] zgfg:
Old v20.4, from May or so, not for A11 (use Canary or Beta v21.1 for A11)
[Magisk] zgfg:
Please did you:

- go to GitHub (link from Magisk Manager)

- scroll to Wiki

- look to the content

- find about troubleshoting, read thr whole chapter about possible tricks to prevent apps finding the root and experiment with
[Magisk] pndwal:
Failing basicIntegrity is usually due to mods applied that have become incompatible w/ SafetyNet, incl many (probably most) EdXposed builds, and other Magisk modules.

Try disabling all modules, clear Google Play Services cache, reboot and check if SafetyNet passes. Then enable one by one to eliminate. (If you're using MHPC to pass ctsIntegrity, just worry about basicIntegrity first as ctsIntegrity won't pass without it anyway.)

I'd link more information, but I'm having difficultly searching in new XDA 2021... PW
[Magisk] lolovato:
Thanks for your reply pndwal, I tried but unfortunately this didn't work.

As of now I don't have any mod installed (not even EdXposed builds) and no Magisk Module installed. Only Magisk 20.4 and Magisk Manager, but basicIntegrity still fails.

There is perhaps some other log or stuff I can give to you guys to try and find the problem?
[Magisk] zgfg:
Search is just one more thing they totally messed up in XDA 2021 - one cannot search inside the thread (you can only search Elswhere, for Forums, for Threads and for Tags).

Put e.g. SafetyNet and it will give you useless results from elswhere on XDA, although there were zillions of posts about SafetyNet right here in this thread

Unfortunately, it is not a hickup - it is a serious lack of functionality
[Magisk] BostonDan:
One thing I have found, when you clear gms (Google Play Services) 1) put your phone in airplane mode before clearing and 2) force stop before you clear gms. Also, make sure magisk manager is hidden prior to clearing and remove the APK from your sd card. I have found certain programs look for the APK due to the potential of renaming of magisk manager (e.g. Samsung pay), which trips the program to declare root (even if the device is not rooted). Also delete any edXposed modules from your sd card (same reason as programs searching for magisk manager APK).

Good luck.

Cheers,

B.D.
[Magisk] lolovato:
Thanks for the suggestion, however this didn't work.

Magisk Manager is hidden. I had already cleared the memory from all the Magisk files (apk, zips and modules files).

I really dont know what else could I try. It came to my mind that I could try and format the phone, but I wish I could avoid this option.
[Magisk] Didgeridoohan:
Come on dude, don't be like this... They are working extremely hard on making sure the forum starts functioning properly again. The hiccups will be ironed out.

Have you checked the Welcome to XDA 2021 thread (that was linked in the notice when you first logged on the new forum)? If you find issues with the forum, that's the place to post (but make sure to check the known issues first, one of which is in-thread search).
[Magisk] pndwal:
Did you happen to have EdXposed etc installed when problem first occurred? Many have had problems restoring basicIntegrity pass even after uninstalling, but clearing G Play Services cache usually fixes it:

Check MagiskHide is toggled on in Magisk Manager settings. (Sometimes toggling off and on again helps too), uninstall mods, reboot, clear Google Play Services cache, reboot, check SafetyNet.

Guess if that fails you could try clearing data for G Play Services, G Play Store and G Services Framework. May possibly help.

Nb. Hiding Manager etc should not be needed simply to fix basicIntegrity.

Sorry, I don't know much more than this, except that basicIntegrity should be a simple fix. (Unless some previous mod (Xposed module etc) has left changes that haven't been properly removed.) 😬 PW
[Magisk] pndwal:
Yes. It's been reported and they're looking into it:

https://xdaforums.com/t/welcome-to-xda-2021.4197018/post-84037503

https://xdaforums.com/t/welcome-to-xda-2021.4197018/post-84038783

It now appears on Known Issues list in Opening Post in thread above, item 4. PW
[Magisk] Kaarifyudi:
[QUOTE = "topjohnwu, pos: 68034103, anggota: 4470081"]

Ini adalah tempat untuk dukungan umum dan diskusi tentang "Rilis Publik" , yang mencakup rilis stabil dan beta.

Semua informasi, termasuk panduan pemecahan masalah dan catatan, ada di Announcement Thread

[/ KUTIPAN]

Mohon bantuanya untuk unlock & root realme c17 rxm2101 ada yang bisa membantu saya belum menemukan solusinya
[Magisk] lolovato:
Thanks again for you help! But even this time it didnt work :/

I never installer EdXposed or any other Xposed stuff. The only particular thing I had installed was Smali Patcher that got unistalled the first time I unistalled Magisk (the module disappeared).

MagiskHide is toggled on in settings. I unistalled all the modules. I stopped and cleared data for the three G Play things you said but with no fortune.
[Magisk] pndwal:
Sorry...

Seems you have something strange going on w/ basicIntegrity...

I'm suspecting something in Magisk is messed up, especially since you can no longer call MHPC from terminal w/ 'props' command.

I'd use a root explorer and check if any removed modules have remained (even partially) in /data/adb/modules. Also, could try removing all Magisk related stuff incl. magisk and modules folders and magisk.db (database) from /data/adb before running Uninstall from Manager. (This may be better than recovery uninstall zip in the event that TWRP fails to execute uninstall zip script properly.)

Can't think of much else at present, but @Didgeridoohan or someone else may have more ideas... PW
[Magisk] lolovato:
Leftovers of modules files were indeed still in /data/adb for some reason. I deleted all the files and folders there and tried to unistall from the Manager, but partially unsuccessfully because the phone would not reboot itself and I had to reboot manually. After the reboot the phone was successfully unrooted tho.

I tried to check SafetyNet with another app but it still fails (both Basic Integrity and CTS). I still can't use some apps (like Secure Folder or Samsung Pay). I guess I will wait for Didgeridoohan or any other user's advice, and maybe after that I will reset the phone and will report back if that worked.

Thanks again for all your help anyway pndwal.
[Magisk] pndwal:
Good!

But you haven't reinstalled Magisk? You'll need to, and to enable MagiskHide in Manager settings to pass SafetyNet again...

Removing remnants / database before uninstall may have fixed issues however... And maybe not.

If not, try flashing module(s) you found remnants of using Manager again, before uninstalling same (but this time properly, through Manager). This should remove any changes these may have made to system that previously remained because proper uninstall script was never run... PW
[Magisk] pndwal:
Search in Thread is fixed now! (sort of)

https://xdaforums.com/t/welcome-to-xda-2021.4197018/post-84046517 PW
[Magisk] pastorbob62:
I have spent the last several hours trying to find an up to date procedure that shows where to find and how to install modules with Magisk Manager 8.0.3. Are the modules incompatible with the latest versions of Magisk and therefore not available? I would love to install EDxposed on my tablet. I am currently running stock firmware (latest version) rooted with Magisk 20.4 and using Manager 8.0.3

Any help would be very much appreciated.
[Magisk] Didgeridoohan:
From the log you posted earlier it looked like you were having Core Only Mode active. There's a bit of a discrepancy until Magisk v21 goes stable, where Core Only Mode can be active, but can't be turned off from Manager v8+... That's probably why the props command wouldn't work.

But, anyway... Now that you've uninstalled everything you definitely can't pass any SafetyNet until you've installed Magisk again and activated MagiskHide. Hopefully the full reset should get things working again.
[Magisk] Didgeridoohan:
You find modules by clicking the puzzle icon in the bottom nav bar (see attached screenshots).
[Magisk] pastorbob62:
Thank you very much!
[Magisk] lolovato:
Yeah lol sorry, I forgot to re-install Magisk like a moron.

Now I reinstalled it, activated Magisk Hide, cleared Google Play Services cache and rebooted but SafetyNet still fully fails.

At this point I guess I will just reset the whole phone and hope for the best.

I will report back if this worked as soon as I do it. If this does not work I will just throw away the phone and go back to using a Nokia 3310.
[Magisk] pndwal:
Did you try re-installing / re-uninstalling modules you found not uninstalled properly?... (Remember, these were only partially removed on updating Magisk.)

... But wait! Why are you messing with a cheap Korean phone when you have such a fine Finnish one sporting a Texas Instruments SOC? That phone has real character, and won't be half the trouble! Just throw the A5 in the river now, and save your sanity! (and you'll gain plenty of time to play Snakes... it's a no-brainer. 😀 ) PW
[Magisk] lolovato:
The modules were fully unistalled and I re-installed them to check if they works now (well just BusyBox+MHPC to be honest) and everything is working properly now, as Didgeridoohan pointed out I had messed with the Core Only Mode and that probably disabled the props command.

Still SafetyNet is not passing. I will probably reset the phone today (or tomorrow at worst).

Ha-ha! I will go back to using the Nokia when I'll be albe to like memes through it. Please Nokia, please.
[Magisk] pndwal:
Goodoh.

I checked module thread

https://xdaforums.com/t/module-smali-patcher-6-9.3680053/

and according to OP it is enough to "Navigate to: data -> adb -> modules -> select the module directory (in this case "fomey.smalipatcher") -> Folder icon (bottom right of screen) -> Delete" to uninstall, so that should be fully reset too. Complex little mod!

Unless you installed any mods that actually modified system partition (quite possible flashing from TWRP), or edited system files (with write permission), I have no more clues...

You don't have a Nandroid (TWRP) backup? At least you'll likely make one before the next time you make a major update... (best laid plans of mice and men.)

All best w/ reset or restoring full stock.

Re the 3310: indestructible daily driver for 2020, just try it...

No need to Like memes from it either; you'll be able to Thank commenters for ALL the memes... in person! (Thankyou Nokia, Thankyou.) PW
[Magisk] Keksdroid:
Works now, thank you! Had to dirty flash my Rom again, I guess the boot image was still modified :)
[Magisk] teddy0209:
Just restore your boot.img

Edit: boot.img of the rom you're using
[Magisk] ashyx:
Why would you need to flash the bootloader? No modifications are made or even possible to the bootloader.

Just restore your twrp backup or flash the stock firmware. I don't see how the system partition has been affected.
[Magisk] Ch3mist:
Nood question, what do you mean by edit ?

---------- Post added at 11:11 AM ---------- Previous post was at 11:10 AM ----------

The rom wont work without the updated bootloader from what i read, even after i flashed it i was stuck at the bootlogo
[Magisk] ashyx:
You're either being very cryptic or I've missed something. Which rom?

Why can't you just flash the stock firmware with odin then restore your backup?
[Magisk] Ch3mist:
sorry i have flashed stock rom which im currently using. I'm trying to mount system so i can put my backup onto it so i can restore but i'm unable to do so. The reason why i want to place it on the system is because i only have an 8gb sd card while the backup is 10gb. I would get error msg " failed to mount data invalid argument " or something to do with not being able to mount. Twrp backup folder isnt even showing up on system, i cant even backup to system.

superman rom for the s7 edge

each time i try to backup to internal i get "unable to mount storage...Failed to mount '/ data ' (invalid argument) "
[Magisk] mathy007:
[MENTION=4470081]topjohnwu[/MENTION] here's a backup of my boot.img after successful flashing v7 my phone bootloop on HTC logo but v6 is still showing unable to detect boot image so I take a look at the updater binary script and found a new line you added to v7 so I copied the line to v6 updater binary script and this time it flashes successfully but still bootloop so I don't know if you can take a look at the boot.emmc.win and help me get pass bootloop thanks for your hard-work . FYI am using HTC one M7 dual SIM 5.0.2http://cloud.tapatalk.com/s/57f77846a7e8b/boot.emmc.win1.zip

And the boot img backup after flashing v6
[Magisk] utbf:
Hello,

i just want to make sure that i understood that many posts correctly.

There will come a new Magisk Version providing hide (itself) form safetynet?

Does this will include a module which can also hide root?

I am not sure that i understand that thing with modules correctly:

I have already installed Magisk Manager 2.0, Magisk v7, SuperUser (from the module) and no xposed. But there are only a few modules and none of them includes hidesu. Will this come in the future?

I can wait for this so take your time. I just want to know if this is correct and will be part of magisk in the future.

Thank you so much for all of your work
[Magisk] grep_i:
Hidesu belongs to phh superuser.

Just search for it on this forum or even with Google.

The way I have understand it by reading the posts here you don't have to use Magisk for it you can even remove Magisk if not used for anything else of course.
[Magisk] Rhoban:
Not necessarily from SafetyNet, but from other apps that are supposed to detect root.

SafetyNet is hard to bypass and Google are intent on keeping it that way.
[Magisk] störte:
Hi.

I came across this interesting development.

As my kids an me :) play Pokemon go we are not able anymore to use it on the custom roms. All of them are rooted the classic way by SuperSu.

I tried this v7 on my Note 7 and followed the instructions. The only difference is that it isnt systemless.

Somehow after flashing all and installing the Magisk Manager. I dont have root at all.

Did i overlook something ?

Would it be possible to include it out of the box in my Rom instead of SuperSu ?
[Magisk] Tesla:
If you want Pokémon to work again.

http://xdaforums.com/apps/magisk/discussion-pokemon-magisk-discussion-t3465722
[Magisk] kraoc:
Magisk Manager v2

Hello,

I'm on a Samsung Tab S 10.5 Wifi.

I uninstalled Magisk v1 then installed Magisk v7, phh's SuperUser v259 with success :)

But when I tried to install Magisk Manager v2 it says "app not installed"

I also noticed that Titanium Backup Root won't perform as it dont detect root.

Did I do something wrong ?
[Magisk] androidmonsta:
Safetynet detecting Magisk? Still using v6. Payload verification failed even after uninstalling xposed. When is Safetynet gaining self-awareness? LOL
[Magisk] Captain_Throwback:
Yes. It's been stated many times. Please read.
[Magisk] Captain_Throwback:
Quoting myself again as it continues to get lost in the madness....
[Magisk] Didgeridoohan:
You probably have a too old Magisk Manager installed. Check the faq in the official announcement thread (link in the OP of this thread).
[Magisk] grep_i:
Great summarization but I'm quite sure you will have to repeat it a couple more times.

Maybe you have to quote again at every 10 posts [emoji12] .

People around here just not read/search they don't even read the rules of the forum.

They create an account and start asking questions immediately most of the time the answer to their question is already posted within 10 posts before theirs[emoji4]
[Magisk] alroger:
Please don't. Not in this thread. It's not Magisk related.
[Magisk] kraoc:
How can I remove old manager if I can't use a computer to proceed with adb ?

Thanks :)
[Magisk] digger16309:
Hi, sorry if this has been asked and answered. I performed a search but that function wouldn't let me search the thread in the new format.

Pixel 5 (A11, Nov Patch) rooted w/ Magisk 21.1 beta, Manager 8.03.

What is the best procedure for downgrading to 21.0 stable?

Is it just an uninstall of 21.1 and install of 21.0? Is it uninstall, boot, install, or is no boot required? Will I need to re-patch my boot image?

Sorry for all the questions, but without TWRP, which I'm used to, it's a new process for me. I don't want to lose my data or get stuck in a boot loop pushing me to factory reset and lose all my data.
[Magisk] Didgeridoohan:
@digger16309 The current stable is v20.4. Magisk v21.0 was also a beta release, and since v21.1 is a beta bug fix that also introduces support for the Pixel 5 boot header I suggest you stay with v21.1.
[Magisk] digger16309:
Ah, thank you! I thought v21.0 was stable for A11. I guess I'm stuck then because the latest Viper4Android module doesn't play nicely with v21.1, and it seems like I need 21.1 on a Pixel 5, though others seem to be able to get it working on Pixel 5.

I will take your advice and not do anything, but out of curiosity, what is the correct procedure for downgrading Magisk versions, or changing from beta to stable?