yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Yes (it should be gone) so long as ROM flashes kernel as is normal. PW
[Magisk] pndwal:
If you mean asking to update, then yes, it's normal, but where did you get 20.3 zip? With so many unofficial / modded (read Unsecure) Magisk builds floating around, you are well advised only to download from official Magisk GitHub pages. Main page offers public stable 20.4 or public beta 21.1. PW
[Magisk] Listerine:
Thanks! Just one point of clarification: when you say "yes" do you mean

Yes, as in it will remove all traces of Magisk, or Yes, it will persist like TWRP?
[Magisk] pndwal:
Well it is interesting that this seems to work for you... To conform to Google's requirements, devices launched w/ A10 are supposed to have new dynamic/logical partition scheme which is incompatible with TWRP according XDA and Twrpme sources, although latest 4.3.0 is compatible with A10 RV (Running Version) if LV is A9 or lower... I assume gsmarena is correct stating Moto G Stylus launched w/ A10?

Still, I wouldn't trust OFFICIALLY Unsupported TWRP functions! ... although there seem to be less problems with TWRP on A10 than A11; A11 won't even boot w/ Magisk installed for many unless stock recovery is restored.

Nb. Some are still able to use TWRP booted only (using ADB Fastboot from PC) with stock recovery intact even w/ Android 11.

Here is some further reading on the TWRP dilemma, if you are still trying to get your head around stuff! 🤠 :

XDA article about TWRP incompatibility w/ Android 10 LV (Launch Version) Dynamic/Logical partition scheme:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-83725859

Problems for Dees Troy/Team Win development, Some progress with Pixel devices with Android 10 LV:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-83727153

Google Official takes:

Implementing Dynamic Partitions

Implement dynamic partitions | Android Open Source Project

source.android.com

OTA for A/B Devices without Dynamic Partitions (read retrofitting updates for dynamic partitions)

OTA for A/B devices without dynamic partitions | Android Open Source Project

source.android.com

PW
[Magisk] pndwal:
Yes, it should be removed completely (as long as it was set up as Magisk in boot, not recovery).

TWRP persists because custom ROMs don't (normally) touch recovery partition.

Magisk configuration is stored at /data/adb, Magisk itself must be installed to a boot image with ramdisk, either boot.img or recovery.img (also a boot image), besides which there is Magisk Manager and it's normal app data.

A clean install (ie w/ data wipe) will wipe /adb, custom ROMs generally replace boot.img (incl. kernel) so Magisk root will be gone unless you patched recovery.img (I neglected to consider this), and M Manager app and data will be gone from data partition.

So if I'm not mistaken, clean flashing ROM will remove Magisk completely unless you have non ramdisk A only late device w/ Magisk in recovery. In this case, I guess flashing unpatched recovery will remove SU.

Of course, there are two official methods to run uninstall scripts to completely remove Magisk if you're not convinced in any case. PW
[Magisk] J.Michael:
The installation notes say Magisk needs to do additional setup. That's after flashing Magisk, after installing Magisk Manager, the first time you run Magisk Manager it will tell you it needs to do additional setup. The notes say let it do them.

This note is in the section for Samsung devices that need to have Magisk installed in recovery. It isn't clear whether that's the only situation where the additional setup is required. I've only installed Magisk once, and that was on a Samsung tablet. Being told I needed to do more setup was a great victory: It meant I had at least succeeded in flashing magisk_patched.img.
[Magisk] pndwal:
Ah, Sammy device (Galaxy Note 9), well spotted! I'll have to look at this (legitimate) extra setup (just out of curiosity). 👍

Nb. There's a few unique cautions for Sammy modders there (under Additional Notes) too.

I'm still wondering why @pupido used older 20.3, not stable 20.4 or beta 21.1 however. PW
[Magisk] flroots:
Thanks again for all your help. I think my primary confusion was being unaware of the distinctions between Legacy and Modern devices. Yes, my Moto G Stylus was received with A10.

My primary use of TWRP is for the Nandroid backups and restores. I am unaware of alternatives

Hopefully this works for me when A11 is released for the Moto G Stylus. It is on the list to receive it at some point. I will now tackle the new homework. BTW, here is the link where I found the TWRP version that does work and supports touch (all the other versions I tested failed touch operation):

https://xdaforums.com/t/recovery-unofficial-twrp-3-4-0-0.4155041/page-4#post-84046045

Thanks again.
[Magisk] pupido:
Anyway, I solved it.

I did the additional configuration and finally my phone is rooted.

I thought version 20.3 was the latest.
[Magisk] ‬1‬:
I don't have Safetynet on Magisk. Any idea why?
[Magisk] pndwal:
Do you have GApps?

Chinese or Custom ROM without GApps (ie. no gms / Play Services)?

Info:

The SafetyNet API is part of Google Play Services.

https://android-developers.googleblog.com/2017/11/10-things-you-might-be-doing-wrong-when.html?m=1 PW
[Magisk] J.Michael:
I think the question is, Where were you looking that 20.3 was offered and seemed to be the latest version?
[Magisk] zgfg:
Check SafetyNet is not showing if there is no connection.

However, MM should also show then N/A for the latest versions of Magisk and MM (not on your screenshot)

If I recall correctly, there were other users who reported a similar issues (IMO, also for Beta). The same or the otther that Latest versions were not showed although the phone was properly connected to Internet

And if I recall, problem was solved by uninstalling Magisk Manager app (not Magisk).

Maybe wiping Cache or Data for MM app would also help (you can try).

Once you wipe Data for MM (or uninstall and reinstall), don't forget to enable Magisk hide

You can also consider installing MM Canary (nevertheless, first uninstall your current MM to get rid of the problem), it is well ahead of Beta
[Magisk] tramp20:
Hi,

Merry Christmas to all.

I need help installing Magisk 21.1 on my Sony Z1c with Lineage 18.1 (Android 11).

I have some experience with Magisk 20.4.

1. Installing Magisk 21.1 with TWRP 3.4.0-1amami runs without error but neither M nor MM are installed.

2. Installing MM 8.03 alone succeeds and shows

Latest 21.1 A/B no

installed N/A SAR yes

Ramdisk yes crypto N/A

3. As installing with TWRP failed I tried patching the boot.img method.

I took the boot.img from the lineage 18. 1 package, selected patch this file and flashed it with fastboot to my device:

F:\FastBoot>fastboot flash boot magisk_patched_R11.img

fastboot: error: Couldn't parse partition size '0x'.

Because of this error I tried this command line:

F:\FastBoot>fastboot flash:raw boot magisk_patched_R11.img

Sending 'boot' (8520 KB) OKAY [ 0.270s]

Writing 'boot' OKAY [ 0.584s]

Finished. Total time: 0.869s

F:\FastBoot>fastboot reboot

Rebooting OKAY [ 0.002s]

Finished. Total time: 0.003s

Finally I could reboot without boot loop but Magisk is N/A again.

In the Magisk_install_log file I found this error:

rm: can't stat '/cache/magisk': Permission denied

boot_patch.sh: line 574: magisk: not found.

I attached the whole logfile.

I spent many hours on this problem :-(
[Magisk] zgfg:
Try using Canary - it's a month and more ahead of Beta and with additional fixes
[Magisk] Blitzenta:
Anyone know what happen? My magisk can't instal some module manually, I've tried to install it through pitchblack recovery, but the module still won't show up, not even in the root directory folder. Pardon my English. I'm using Redmi Note 5 (Whyred)

here's the vid
[Magisk] tramp20:
Thank you.

I did this already (installing the canaries with TWRP) but this failed too (see point1).

The last Magisk version I could install with TWRP, was 20.4.

All versions after 20.4 showed the same behavior (in Android 10 and now 11). So I assumed it is perhaps a bug in twrp-3.4.0-1-amami. Therefore I tried the patch in MM :-(

I hope didgeridoohan can help me.
[Magisk] flroots:
Magisk newbie here. It's my understanding that when you first install Magisk you need stock boot.img to patch. That makes sense I guess. What I don't understand is that when using Magisk to remove root prior to an OTA update, how do you restore root without a new stock boot.img corresponding to the new firmware?
[Magisk] bartleby999:
You'll have a new boot image with your new firmware - You patch that.
[Magisk] Abhiniit:
I installed Magisk on my SamsungGalaxyS9 Plus with Android 10. I liked it. Have few questions.

1 how can I restore back to full stock ROM with working Knox

2 S Health, Secure Folder and Samsung Pass stopped working after installing Magisk. Please help.

3 After installing Magisk, it worked like charm for first few hours but later it got inactive. Safety etc check failed. Not hiding Magisk any more. Getting slower system and reboots.

4 can I reinstall Magisk without Firmware Reset. HOW?

5 I wanna spoof my location and play Pokémon Go. Please help.

Sorry if I broke any rule.

It was all too easy on S3 and Note2.
[Magisk] pndwal:
1 I understand this can't be reversed on modern Samsung devices. Can be on some older models.

https://en.m.wikipedia.org/wiki/Samsung_Knox#e-Fuse

https://docs.samsungknox.com/admin/knox-platform-for-enterprise/faqs/faq-115013562087.htm

2 May be related to 1, to safetynet, to detected mods etc

3 Possible causes:

"- Copy the patched tar file to your PC with ADB:

- adb pull /sdcard/Download/magisk_patched.tar

- Do NOT use MTP as it is reported to corrupt files."

"- Reboot to download mode. Open Odin on your PC, and flash magisk_patched.tar as AP, together with BL, CP, and CSC

- Never just flash only AP, or else Odin can shrink your /data filesystem."

4 "- Never, ever try to restore either boot or recovery partitions back to stock! You can easily brick your device by doing so, and the only way out is to do a full Odin restore with data wipe."

https://topjohnwu.github.io/Magisk/install.html PW
[Magisk] pndwal:
Not at all sure if it will help, but some (Pixel and other users) have only succeeded flashing Magisk on Android 11 with stock recovery intact (even when not using TWRP to install Magisk), so you could try with this restored.

This may be related to TWRP only being compatible (officially) with devices launched with Android 9 or earlier, due to later devices having dynamic/logical partition scheme and other changes. PW
[Magisk] bartleby999:
1. You cannot restore Knox. Knox isn't software - It is hardware. Once you trip Knox you blow a fuse, it's literally broken components - s it's irreversible.

2. Samsung Pass will not work without Knox. So that is gone forever.

Samsung Secure Folder is recoverable - You'll need SmaliPatcher.

S-Health I'm not sure of - You used to be able to get it working again but you'll need research it.

3. SafetyNet is failing because it is detecting root - Likely based on Hardware. You can fix that by using MHPC to spoof a different device. I'd suggest a Galaxy S10+

4. Not sure on that one.

5. Like #2 SmaliPatcher would also allow you to spoof location. Just select that option when you create the patch.
[Magisk] adeptustech:
Thanks that's helpful to know.
[Magisk] golf60:
A solution for banking apps fail in the 21.1 on Oneplus 8pro with newest OOS11?

Magisk hide activated.
[Magisk] pndwal:
Have you selected app in MagiskHide list also? (Also, check Google Play Services is selected too, and that Playstore Settings Play Protect says Device is certified.):

Check/Select (bank) app in Manager Hide list. Toggle MagiskHide off and on again in Manager Settings (sometimes helps). Reboot. Check if root is detected now. If still detected, clear App data and check again.

If still detected, many more tips here:

https://www.didgeridoohan.com/magisk/MagiskHide PW
[Magisk] jacopastorius82:
hi guys i have android 11, magisk 20.1 and latest manager. I can't find donwload module section like in older versions. How can i download and manage modules?
[Magisk] pndwal:
20.1 is from Nov 2019! Don't know why you'd run that w/ latest Manager... It's certainly incompatible w/ A11! 🙃😉

Anyway, modules run fine on A11 w Magisk 21.1... Swipe down on home screen and select puzzle piece icon on floating menu that appears at bottom of the screen... think you manage from there.

Tip: Shield symbol for Superuser and MagiskHide list. 👍 PW
[Magisk] pndwal:
... Just a thought - you didn't patch boot.ing with initial Recovery Mode option (for Magisk in Recovery, not Boot) checked by any chance did you? Because that's definitely not needed for your device.

I doubt you did, but it just crossed my mind that you may not have read the instructions. 😬 PW
[Magisk] jcrompton:
Thank you ! and thank you for the continued work that you and others do.

Hopefully I haven't missed anything in this lengthy thread.

Pretty much as per what you are saying here I went yesterday to a Stock based rom (just a Lite version). After flashing the ROM, I made sure to "unroot" by doing a full unroot with SuperSu from the playstore. I even deleted the supersu folder in TWRP and made sure that su was removed from /system/bin and /system/xbin (there wasn't anything there, but I made sure)

I then flashed the mentioned phh superuser file and installed the apk

Safetynet ... still fails --- get CTS profile match : false

The weird thing is that when I reboot to recovery I still have a /supersu folder

If I go to File Manager and delete the folder and then reboot to recovery .... voila .... there it is again -- the /supersu folder

Why does delete not persist? I apologize for my probable ignorance.

If I reboot the system and look in Root Explorer I do not see the mentioned /supersu folder

:confused::confused:
[Magisk] Captain_Throwback:
That folder is part of TWRP. It doesn't exist in Android. That's not your problem.
[Magisk] Captain_Throwback:
UPDATE: Chainfire has updated suhide to circumvent the latest SafetyNet update. I have a report that this also allows Magisk to work, but I haven't tested yet myself. About to do so now.
[Magisk] mrxtc89117:
Let us know what version of Magisk you use. V7? and also if you are trying xposed. Thank you.

According to this post, xposed works too.

http://xdaforums.com/showpost.php?p=69022676&postcount=1608
[Magisk] Captain_Throwback:
I only use the latest versions of everthing.
[Magisk] mrxtc89117:
Thank you. Seems xposed is working too according to this post:

http://xdaforums.com/showpost.php?p=69022676&postcount=1608
[Magisk] Prowler:
Magisk v7 + Xposed 86.6 + SuperSU 2.78 SR1 + suhide 0.54 works flawlessly here!

And yes, SafetyNet passed!
[Magisk] Captain_Throwback:
That's using 86.2, though. I'd like to confirm whether Magisk and 86.6 are working, as this is the Magisk thread ;).
[Magisk] mrxtc89117:
One post above yours says it does. I will test.
[Magisk] silvercat:
Yes it work [emoji2]
[Magisk] Captain_Throwback:
Leave it off and install another Busybox.
[Magisk] Blauhasenpopo:
So Busybox is installed with Magisk, could i install another on top?
[Magisk] Captain_Throwback:
That's exactly what I just said to do.
[Magisk] ericotena:
[MENTION=1162986]Captain_Throwback[/MENTION] Just a noob question as i don't know how safetynet works. Does google update safetynet regularly or they update it because some developers find a way to bypass it?
[Magisk] Captain_Throwback:
I don't work for Google, but I assume the answer is both.
[Magisk] ashyx:
Either you or I are getting confused here. [emoji54]

You can't copy a backup to the system partition. Where is this backup stored and how did you create it?

If it's a twrp backup then you either need to copy it to an sdcard, internal storage or use a USB stick via OTG.

If you are encrypted you won't be able to mount internal storage.

The backup needs to go inside the TWRP folder.
[Magisk] knipp21:
Nice thanks for the update.
[Magisk] mrxtc89117:
I believe it self updates and is part of Google Play Services. It also does self checks to see that it is authentic and not tampered.
[Magisk] soder:
I just updated to suhide 0.54 (just flashed that) myself. Works great. I find it strange that suhide also manage to hide Magisk and Xposed, but I'm glad it does. =)

/Söder
[Magisk] flroots:
I'm still confused. When rooting for the first time, Instructions say to download stock firmware, extract the boot.img file and copy it to phone. Magisk then patches that img file. Once rooted and wanting to do an OTA, there is no mention of downloading the firmware corresponding to the OTA to get an updated boot.img. My question then is why is it necessary when rooting for the first time, but not after an OTA? Hope I clarified my question.
[Magisk] pndwal:
Once you have root you can use direct flash method to update Magisk subsequently since boot image now gives necessary SU access.

You obviously can't do this if you unroot and reboot with unpatched boot image!

... So "downloading the firmware corresponding to the OTA to get an updated boot.img" may possibly be necessary in this case, but only if you cannot use a custom recovery either installed or booted using Fastboot. This is because you will effectively be starting fresh, and need to use initial root method again since boot image no longer contains Magisk SU, requiring currently used and unpatched boot image to be re-patched.

However, by selecting Uninstall Magisk, then Restore Images (NOT Complete Uninstall) and applying OTA before re-installing Magisk (Install, Install to Inactive Slot), then, FINALLY re-booting (through Magisk!), it HAS been possible (until recently) to apply OTA updates while retaining root on A/B devices!

Nb. This has been disabled at present while John works around Google's new OTA changes, so it seems ALL devices must be unrooted to apply OTA updates presently.

https://twitter.com/i/web/status/1303574238796808192

Methods, though disabled in current Magisk Manager builds, as well as cautions, are given here, as are official instructions on applying OTA updates and re-rooting non A/B devices:

OTA Upgrade Guides

The Magic Mask for Android

topjohnwu.github.io

Interesting, John states here (for non A/B devices):

Once it’s done you will be left with an upgraded, 100% stock, un-rooted device. You will have to manually flash Magisk back. Consider using the methods stated in step 1. to flash Magisk without touching the recovery partition if you want to receive stock OTAs frequently.

And the methods include:

If supported, use fastboot boot <recovery_img> to boot the custom recovery and install Magisk.

If you have a copy of your stock image dump, install Magisk by using Magisk Manager’s “patch images” feature

Hope it helps! PW
[Magisk] asripath:
Have a peculiar problem.

Upgraded from A10 to A11.

Downloaded and Installed

new Magisk canary d0896984 (21102) and

Manager d0896984 (316) (14)

from github topjohnwu/magisk_files/tree/canary

SafetyNet passes and everything works ....except

have to manually download and install modules from

github /Magisk-Modules-Repo or from XDA etc.,

Magisk Manager in the Modules Screen does not seem to connect

and download the Modules List.

Searching for Modules also fails.

Clearing Repo Cache action and

Reinstalling Magisk and retrying also does not populate available repository modules list.

Edit:

If the query has been asked before, my apologies.

It is very difficult/not possible to search in a thread in the redesigned

XDA.

Appreciate guidance.
[Magisk] Abhiniit:
Thanks a lot. Still have some problems. Did all the steps corectly but still Magisk SafetyNet check failed and none of the modules are working. Checked for Root and its working like charm
[Magisk] jenslody:
Just a wild guess:

does MagiskManager have storage permission ?

Or do you have some kind of firewall/network blocker, that blocks Manager from accessing github ?
[Magisk] pndwal:
Tried to reload the modules list (the small icon in the top right corner of the "Modules" window) also? PW
[Magisk] asripath:
Permissions shows as

No Permissions Requested.

and greyed out ie i cannot change it.

yes use Afwall+,

manager has net access and no issues in manager for downloading safety net related files and version check for update on main page
[Magisk] pndwal:
Sorry, but you've not given much info. Please say basicIntegrity, ctsProfile, evalType for SN.

And what does 'modules aren't working' mean? Do they load? Please give examples of what fails at least... PW
[Magisk] asripath:
tried that too...still does not load modules from repo
[Magisk] pndwal:
Then possibly firewall (or adblocker) conflict as mentioned by other member.

I'd try disabling your Afwall. And try disabling Systemless Hosts if you have it too. It's a known issue on some devices. PW
[Magisk] asripath:
not using systemless hosts or adblocker.

tried with disabled firewall..still no luck.

i can access github fine from any browser

with/without firewall.

Manager works in all aspects...except in online repo module listing.
[Magisk] Didgeridoohan:
Make sure that you can access https://cdn.jsdelivr.net. That's the service used to download Magisk and modules. If you can't access it you'll have to whitelist it wherever it's being blocked on your system.
[Magisk] AndreM962:
I'm looking at the official instructions for installing an OTA update on a non-A/B system. As I have only rooted my phone once, I would like some advice on how to re-root it afterwards (specifically, how to do it without losing data, if that's possible.)

My phone is a Samsung Galaxy M31, for the record.
[Magisk] asripath:
Can access the site.

Didn't have this issue on A10 with Magisk stable.

It's occuring in A11 with magisk canary, as this is the only version which reportedly works without bootloops on A11.

Everything else works on canary,

only Repo listing/refresh.

Enabled install unknown apps,

removed battery optimizations etc., in permissions.

Does Magisk require any other permissions in A11? which are greyed out as not requested.

Edit:

Update

Issue does not occur on mobile network.

It appears either the router/firewall/dnscrypt-proxy(multiple resolvers) are preventing the connection to cdn.jsdelivr.net

Thanks for all your help.
[Magisk] MECH_TECH:
I have a SM-G960F/FD with Android 9 G960FXXS7CTA1. I unlocked the bootloader installed TWRP and the no encript and rmm patches. I installed Magisk manager 8.03 and extracted the boot.img.lz4 from the AP file and renamed it to boot.img copied it to the phone SD card. I ran magisk and tried the the install patch img. Not sure if the Preserve AVB 2.0/dm-verify needs checking or not but did not check the box. Picked select and patch. picked the boot.img file. Then i get a failed message. I am attaching the log file.
[Magisk] bartleby999:
If you have a working TWRP installed then you do not need to patch AP. Unless something has changed? You should just be able to boot to TWRP and Flash Magisk zip when you have TWRP.
[Magisk] pndwal:
Not sure you can re-root without losing data w/ OTA after un-rooting as official instructions say to wipe data for initial root (flashing CSC along with patched AP tar etc). Sammy users may know better...

If you have the new firmware package, seems it is quite possible to do this by flashing HOME_CSC (instead of CSC) along with patched AP tar etc.

See official Installation Instructions, Samsung (SAR) section, Additional Notes:

https://topjohnwu.github.io/Magisk/install.html PW
[Magisk] Didgeridoohan:
A bit OT, but it's perfectly possible to search in a thread on the new and improved XDA...

Attaching an example screenshot (mobile website, but it works basically the same on desktop). Click the cog wheel and pick where you want to search...
[Magisk] Didgeridoohan:
I currently do not have anything useful to add towards getting you up and running with Magisk. That error is interesting though and I'll be in the lookout...
[Magisk] Anikscha:
Magisk 20.4

I'm using it on eROM and Lineage 16 MicroG without any trouble.

Excellent app !!

Thanks a lot @topjohnwu for your continuous hard work.

My Donation is on the way...

My best wishes for 2021 🌈✨