yashsingh1/xdaforums huggingface dataset:
[Magisk] badabing2003:
Honestly I have not tested yet 25209 (I will dig into the details soon)

The way PF works is you select the factory firmware, and hit the process button.

It extracts boot.img / init_boot.img files and shows you in the list of boot images.

You then select it in boot images and hit the patch button.

If the patch is successful, then it shows up in boot images (with a patch icon)

This way you can select either boot image to flash to your device.

You can not select a patched boot and try to patch it again.

The user was running into the following error when patching with 25208 or 25209

VBMETA
- Checking ramdisk status
Loading cpio: [ramdisk.cpio]
- Stock boot image detected
- Patching ramdisk
fopen stub.apk failed with 2: No such file or directory
Loading cpio: [ramdisk.cpio]

Notice the fopen stub.apk failed

I just tested 25209 on bluestacks (taimen) and it succeeded in patching. :unsure:
[Magisk] m0han:
PSA(?) from Telegram:
[Magisk] pndwal:
Still confused... Seems you patched package already rooted with 25206, which I'd expect to succeed since root is preserved fine with binary update...

If user did the same it would be surprising, but my guess is that they patched a clean package which is expected to fail to acquire root...

My guess is that if you try with that first package in your screenshot, the unpatched one, patching with 25209 will also fail as expected... Please let me know...

... I just haven't seen any indications that it

, ie. a previously rooted image, fails to retain root when updating Magisk binaries...

🙃 PW
[Magisk] badabing2003:
Sorry for the confusion.

The first entry is the one I used to patch it on a device taimen

When you select the first entry, which is the factory init_boot for cheetah Feb release, the patch button is enabled and you can create a patch from it.

So I selected that, PF warned me that I'm on device Taimen and am trying to patch a cheetah image, I accepted and proceeded.

PF created the 3rd entry from it (see the date)

Notice the Patched with Magisk version and Patched on Device

The 2nd entry if you select it, the Patch button is disabled.

PF does not allow you to patch a previously patched image.

That was created back in February on p7p, it shows up in the list because it is from the same firmware.

Another clue in there is the first two columns.

The first column SHA1 is the SHA1 of the row item

The second column Source SHA1 is the SHA1 of the image used to create the patch, which in this case shows that it is the first row (first row both columns are the same because it is unpatched)

Lastly PF uses one of the two methods to create a patch.

If the device is rooted by magisk and adb shell access is granted to /data/adb/magisk it can use the boot_patch.sh in there and would use it by default, unless there is a newer Magisk Manager installed, at which point it would give you the choice to select either

If the above is not granted / detected, and Magisk Manager is installed, it will unpack the necessary components and use boot_patch.sh from it to create a patch. (If no Magisk Manager is on the device, it would give you the choice to install one.

In the above case the second method was performed because the boot image of taimen was not patched with Magisk.

Hope this makes it clearer.
[Magisk] pndwal:
Yup, that's the confirmed issue @huskydg thought meant Devs were going to recommend .zip flashing in recovery be removed... Seems that's not happening, and part of the actual fix was posted above by @osm0sis ...

Logs are still being gathered / analysed in in "The Rock Revolution of Pochi and Kita" (formerly Alpha discussion) TG thread as I've mentioned in posts above also, so there will likely be further commits in official Magisk... PW
[Magisk] m0han:
Since Magisk 25207+ changes the way of mounting sepolicy.rules partition.... and Magisk Delta doesn't apply this changes, so this problem will not be happened, can it be deduced that flashing Magisk Delta from recovery (for supported devices, ofc) is still possible & safe?
[Magisk] pndwal:
Ah, clearer which files are handled now, thanks...

So seems user patched clean package which fails as the issue predicts...

You have found that patching a clean package with your setup (P Flasher) can also succeed... Seems as you describe its using boot_patch.sh from Magisk App installed on device... Can you confirm that it's actually 25209, matching the one shown in PF? (Again I'm only guessing that you have builds both in phone and on PC)...

Anyway, despite the above, I still haven't seen the indications that it

, ie. a previously rooted image, fails to retain root when updating Magisk binaries... Seems both your attempts and user's are with clean (unrooted) packages... 🙃 PW
[Magisk] pndwal:
Yes, we've seen these issues... @zgfg first flashed from recovery which failed due to Fix SYSTEM_ROOT not passed to boot patch... He overcame this by temp. booting a different patched image, then taking Direct install for 25209... Said Magisk reported SE Policy rules folder was not found, but that Magisk seemed to work fine after a reboot...

He may say if he's had any further issues due to this...

Anyway, .zip installation in 25209 is broken it seems for clean (unpatched) ROMs in any case so may only work if updating Magisk binaries... I'm not sure if Delta works for both...

If you really need to update using .zip I guess Delta could be considered, but why not just take Direct Install to update (and avoid the selinux issue)?

As I said, part of the fix for this is already merged and it seems Devs are holding off on the next update to add other needed commits... I'd say odds are good that the issue will be fixed in 25210 (or 25.3?)... But then this is (bleedin' edge) Canary!

🤪 PW
[Magisk] m0han:
Was that Delta?

I'd like to know too.

Not that I really need to, but there have been occasions in the past when I've had to do just that. I'm fine with Direct Install for now, though. I'm on Magisk-91842209-delta(25209).

Looking for thoughts to elucidate this matter.
[Magisk] zgfg:
It was official TJW Canary, my original post is in this thread on the day when it was released
[Magisk] traversone:
good evening all

is anyone experiencing regression between 25206 and 25209 in hiding root? I mean: simply upgrading the boot, my system fails in all root checks and shamiko (0.6.126) reports some kind of error (I guess) not in english instead of usual "shamiko is working as blackilist mode". Actually I did not try intermediate versions since they were not 100% working to some extent.

thank you
[Magisk] HippoMan:
As we get older, our memory is the second thing we lose.

"What's the first thing?" you might ask.

I forgot.
[Magisk] zgfg:
It was reported in several posts that patching the original boot.img does not work (Magisk not installed) with 25209

Do Direct install (upgrade) or re-patch the already patched boot.img
[Magisk] traversone:
actually all seems working fine, Magisk is installed and modules working.

By the way, I will patch the already patched boot, thank you.

EDIT: it still does not work, as before
[Magisk] badabing2003:
I have Pixel XL (marlin)

It was running Magisk 25206, and was working properly.

I installed 25209

Created a patch with 25209, it succeeded in creating the patch.

Flashed it.

Device is no longer rooted.

Flashed back the boot image prepared by 25206.

Upon reboot, Magisk tells me it needs additional setup.

Cancelled that.

Clicked on Update and direct Install.

Rebooted

Device is rooted.

So it looks like the patch file created by 25209 is no good, but the direct install is good.

Dumped the boot partition, and compared with the created patch.

They were different.

Now that I had Direct Patch working with 25209, attempted another patch creation, and this one was using the /data/adb/magisk (25209)

Flashed it, and it was again not good, no root.

Flashed the dumped partition from before and the phone is rooted again.

Update:

Compared the good and the bad boot files.

The ramdisk portion of the two are identical.

The kernels are different.
[Magisk] zgfg:
Yes, exactly like that. Discussed above and the opened Magisk issue already closed by commit, but newer Canary was not released yet

See eg:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-88234875
[Magisk] pndwal:
Ok... So still exactly as expected AFAICS!...root can be retained where previous root binaries are simply updated, but initial root flashing fails due to need for Fix SYSTEM_ROOT not passed to boot patch...

... Still can't see where 'even rooted ones' fail to flash properly. 🤪 PW
[Magisk] Captain_Throwback:
Restore your stock boot.img.
[Magisk] DawoodSahi:
Restored

Flashed custom kernel

Magisk v8

Phh 259

xposed systemless

v4a

Everything is working just fine but it's just something to do with phh and and magisk hidesu, it all to started from there. Although phh su is working, asks for permission etc but it's only working upto a certain extent. Like if you see the screenshot I posted above when I've opened magisk manager.

Plus could it be something related to busybox?
[Magisk] RodMY:
I've read here many times and it seems that uninstalling everything (SU, Xposed, Magisk etc.) and restoring stock boot.img makes SafetyNet to pass, but I've restored my stock boot and system image (not system, system image) also and still failing to pass the last test (CTS profile match, red screen). However, Pokemon Go works.

I'm with stock ROM and kernel. What could have happened?
[Magisk] CrazyCypher:
Same thing happened to me, I ended up wiping data... Really annoying that flash able .zip or even better a list of folders/files to remove if we want to get /data partition like it was prior flashing... Not only Magisk, but phh superuser zip, suhide and SuperSU are missing something like this.. Everyone leaves something behind...And I don't understand why we cannot use uninstaller zips to remove latest Xposed if we don't have Magisk installed..? If I flash Magisk uninstaller and I forgot to flash Xposed uninstaller before that, I have to re-flash Magisk just to be able to flash Xposed uninstaller? Wat? :)
[Magisk] imthekuni:
Some phones aren't passing SafetyNet due to an unlocked bootloader. There are kernels that have found a way around this though (Franco, ElementalX, etc.)
[Magisk] Little Nugget:
Stock TW DPH2
[Magisk] jeremeel2015:
Works fine on my sm-g900f using RR v5.7.4

Can bypass Pokemon Go, but this game called Summoners War can't bypass it, any of you got a workaround?
[Magisk] logitechor:
I have a question with xposed and magisk. I am using both a Nexus 7 2013 with Nitrogen OS 7.1.1 and a Nexus 6P with NPF10C build number. Both have Magisk installed. I am fully able to add modules with Magisk Manager with the Nexus 7 for some reason I have to manually add to the Nexus 6P in TWRP. It works. My question has to do with Xposed. Has anyone been able to add it either through Magisk or Twrp. So far I have received an error message that the modified versions for magisk are not for my phones. It seems only for version 6 of android. Is this still true even with the modified versions for magisk.
[Magisk] Captain_Throwback:
There is no Xposed for Nougat. It doesn't exist (yet).
[Magisk] Ashtrix:
Okay I tried to Install V4A (v2.5.0.5) but It does show enabled and all but not processing, Doesn't work and also the version I flashed from the repo says the same version number but the driver version in the app says 2.5.0.4.

Does it work for Enforcing SELinux ?
[Magisk] schwarzerfleck:
It does not work with enforcing SEL. If everything is enabled, but it does not process, it could also be your media players fault.
[Magisk] Ashtrix:
Oh okay,

I tried on Blackplayer / Youtube. So everything is related to this SELinux, I get it now even the Dolby Atmos port doesn't work.

Thanks.
[Magisk] CrazyCypher:
How is the info..is Magisk even gonna be updated to pass SafetyNet or there is no plan like this?

Thank you for answers
[Magisk] bearzi:
Samsung Galaxy S7 Edge

Superman Rom 1.15.5

Xposed OFF

Magisk Hide SU ON

some help please?

i want to play POGO :P
[Magisk] Captain_Throwback:
http://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post69411809

Patience.
[Magisk] schwarzerfleck:
Yes. I think so! Try activating the terminal app. I see, you are on CM13. Do it in the dev options. (local shell)

Type

su

setenforce 0

Your SELinux will be moderate or permissive now, both works well. :)
[Magisk] CrazyCypher:
So for new SafetyNet pass we will need phh's root app...I have a question though: Will we still be able to use suhide to hide Xposed or suhide will not work without SuperSU?

---------- Post added at 12:03 AM ---------- Previous post was at 12:01 AM ----------

Thanks, I guess I've missed that :)
[Magisk] Captain_Throwback:
Read the suhide OP. It tells you what the dependencies of it are ;).
[Magisk] CrazyCypher:
Yeah totally forgot about it... Well, I guess when Magisk update comes we will need the suhide update too..or Xposed won't be able to hide.. x)
[Magisk] Captain_Throwback:
And there's no guarantee that there will even be an suhide update at all...:rolleyes:.
[Magisk] pndwal:
Hahahaha.. ha...ha

... Did you know there's 3 benefits of Alzheimer's?...

1) Jokes are always funny,

2) You keep making new friends,

And 3) ... What was 3)?...

🤔...

... Oh yeah! - Did you hear about the 3 benefits of Alzheimer's?... 😃 PW

PS, to make this relatable:

We can still have fun fixing the same dumb mistakes configuring Magisk just a week after we discover what we did wrong...

... 6 months later the fun starts an hour after...
[Magisk] osm0sis:
Yeah, @canyie is an excellent contributor, always enjoyable to work with, and has almost triple the commits of Rikka even, so not sure why isn't listed in the app. 🫤

Hopefully John or someone rectifies that soon. 🙂
[Magisk] pndwal:
Issue with installation using Magisk apk as zip installer in custom recovery since 25207 selinux rule refactoring

For any who updated Magisk (to 25207+) using .zip install from recovery, while this works partially, .zip installation is broken due to major selinux refactoring.

You will have 'Magisk/root in a limited state' but need to re-patch Magisk in app and flash.(just take direct install*) to fix this...

This issue occurs because we now need target partition to be mounted by system when writing module rules so it writes safely. This allows Magisk to find a partition that can store module rules consistently because some devices have cache/metadata partitions that are not mounted after booting...

.. Some (2) fixes are merged already but more may come before next release...

We particularly need a fix for the problem of module rule writing being dangerous before system is booted because while mount partition parameters are set as read/write until booted the correct mount parameters are not known until boot completes. In addition there is the issue of some devices having recovery environments completely different from normal boot environment...

* Nb. For some Mediatek (and other?) devices that don't allow modification of boot.img after system boot as they are mounted read-only (and flashing via recovery has been the traditional solution):

Patch clean boot image in App and fastboot flash. If you 'insist on using a custom recovery' 😜, you can patch boot in App and flash it in recovery... 😉

... Most of the details above/conclusions have been lifted from GitHub issue thread:

Refactor sepolicy.rules resolve

#6684 opened yesterday by vvb2060

*** Important Note ***

All this will likely mean boot images can no longer be (reliably) patched on a different device, at least unless users can be confident that partitions used for sepolicy/module rules and their mounting parameters match...

👀 PW
[Magisk] pndwal:
My Shamiko (same version) looks like yours but is evidently working... I assumed it changed with 0.6.126...

Can others say if "shamiko is working as blackilist mode..." message still shows with 0.6.126?

However, if you updated to 25209 using .zip install from recovery (ie over boot image with earlier root patch version), while this works partially, .zip installation is broken due to major selinux refactoring from 25207...

You will have 'Magisk/root in a limited state' but need to re-patch Magisk in app and flash.(most can just take direct install) to fix this...

See post above for technical details...

🤠 PW
[Magisk] pndwal:
Mmm... Her first Magisk PRs were actually a spin-off from helping Rikka and Shana fix code breaking Rikka's Sui... she then also discovered a p-trace issue breaking MagiskHide...

Maybe her age?... (Just became an adult 😉)...

Probably began as the youngest Magisk contributor ever... Wait... How old was John? 🤔

... Reminds me; she started in a similar way too, cutting her teeth on her own (Dreamland) XPosed framework (first GitHub public commits up as 15yo in 2020!... (My daughter's 16))...

That's how you train your brain for life! 😁...

Building your own XPosed may be the best prevention for Alzheimer's too... (Mental note: Gotta encourage my daughter to code...)

🤯 PW
[Magisk] traversone:
thank you, PW.

Actually I patched and flashed an original boot in Manager 25209 and patched and flashed an already 25206 patched boot.

Same result: root is working but shamiko seems not able to hide it anymore
[Magisk] pndwal:
Thanks!... Please say your symptoms of root not hidden...

Shamiko is definitely hiding root for me, and a little better than denylist...

Using DenyList (enforced):

Using denylist list as Shamiko-hidelist:

Nb. Zygisk traces are hidden, but something's changed...

Previously:

... So new refactoring (from 25207) does appear to break Shamiko's Magisk and su file hiding but not root hiding entirely...

Guess we should see LSP team playing catch-up w/ Shamiko code soon. 😃... At least they're the same team that broke this hiding in Magisk code (it appears)... 😁

... And we can at least ping @canyie here! (Shamiko is her brainchild)... PING!...

🙂 PW
[Magisk] pndwal:
Also, @canyie, please can you say if this is the new normal:

Many thanks, PW

Further, this makes my head spin:

🙃
[Magisk] pndwal:
Latest Canary (+Debug) Magisk:

Magisk (981ccabb) (25210)​

Fix Magisk app hiding when Zygisk is enabled

Fix a patching boot images on system-as-root devices

Diffs to v25.2​

[General] New magic mount backend. It supports loading modules into system with overlayfs files injected

[MagiskPolicy] Fix minor bug in command line argument parsing

[Zygisk] Prevent crashing daemon in error

[Zygisk] Rewrite zygote code injection with new loader library approach

[Zygisk] Release new API version 4

[App] Make stub patching 100% offline

[App] Support patching init_boot.img for Samsung ODIN firmware

[MagiskInit] Support replacing existing *.rc files in overlay.d

[MagiskInit] Rewrite sepolicy.rules mounting and loading implementation

https://github.com/topjohnwu/magisk-files/blob/canary/notes.md

👍 PW
[Magisk] pndwal:
... 25210 Direct install worked fine for me with App hidden... deviceIntegrity verdict good, etc...

Shamiko root trace hiding going from bad to worse however w/ abnormal ART now detected too:

... Hope we see some LSP/Shamiko attention soon!... But this is life on the bleedin' edge... 👀 PW
[Magisk] canyie:
The new canary build (25210) completely breaks all modules so the new "Abnormal ART parameters" can be ignored.

The missing Shamiko status is also expected and will be fixed in the next Shamiko version.

But, denylist seems to be broken on your device since 25207, which also causes Shamiko not working properly. Will take a look into it
[Magisk] zgfg:
Oops, we see - hoping, 11 will come soon with your fix:

25210 breaks module loading · Issue #6688 · topjohnwu/Magisk

Device: Pixel 7 Pro Android version: 13 QPR2 Magisk version name: v981ccabb Magisk version code: 25210 With the latest version, mounting all mounts fails saying No such file or directory, i.e. moun...

github.com
[Magisk] canyie:
I have tested Shamiko and Denylist on my device and everything work well. Can you install the latest Debug build and send me a magisk log?
[Magisk] pkgnex:
I just direct-installed 25210 - it broke adaway (says no space available to save hosts file). I tried re-adding systemless hosts module to no avail.

Pixel 4XL, latest stock A13.
[Magisk] zgfg:
Posts #54615 and #54616 above

Generally, mounting/overlay by Magisk is broken in Canary 25210

Eg, I see also that /system/xbin is missing (with couple of modules that install there)

I flashed back my boot.img patched by Magisk Canary 25209 (and installed 25209 Magisk app) to have all the modules properly working back
[Magisk] pndwal:
Many thanks!

RN8T log attached... 👍 PW
[Magisk] zgfg:
Re posts #54615, #54616

Regarding to Magisk modules that I use, the following do not work with official Magisk Canary (981ccabb) 21210:

- Systemless Hosts (AdAway root)

- https://github.com/programminghoch10/ViPER4AndroidRepackaged

- https://zackptg5.com/downloads/jdsp_v4.6.zip

- https://zackptg5.com/downloads/Audio-Modification-Library_v4.2.zip

- https://github.com/adrianmmiller/AppDataIsolation

- https://github.com/Magisk-Modules-Alt-Repo/BuiltIn-BusyBox

- https://github.com/Magisk-Modules-Alt-Repo/ToyBox-Ext

- https://github.com/Magisk-Modules-Alt-Repo/SystemlessDebloater

For all of them, mounting systemless changes to /system/* fail

However, all those modules work fine with Canary (2717feac) 25209 and earlier Canary versions 252xx

Also, all those modules work fine with all Magisk Delta 252xx, incl. the latest (2304d221) 25210

---

I did not observe any anomalies with Magisk Canary 25210 regarding to Shamiko

Also, for my ROM I don't need to use USNF, hence cannot test that part

Regarding to Zygisk-LSPosed, Momo for me also reports Partitions mounted abnormally with Canary 25210 (not with the other Magisk versions mentioned above) - but LSPosed and its modules (eg HMA) work fine
[Magisk] canyie:
Ah, I know the reason, already fixed internally I think. The next Shamiko version will work!

And the reason why Denylist also doesn't work is that you are using Android 10, so isolated services will have the same mount namespace as zygote's so denylist can't handle it. I had internally asked John about it and he said he won't fix it :( ...
[Magisk] zgfg:
Then pndwal, you'll need to use MagiskHide module (to replace DenyList)

GitHub - HuskyDG/MagiskHide: Portable MagiskHide

Portable MagiskHide. Contribute to HuskyDG/MagiskHide development by creating an account on GitHub.

github.com
[Magisk] Tirofog:
After updating to latest canary build 981ccabb (25210) the systemless hosts module isn't installing, whether intentional or not 🤷🏻
[Magisk] zgfg:
Please read posts above, since yesterday - how, why, what
[Magisk] Tirofog:
Thanks, I did a thread search for 'systemless' but it's a bit tedious as results are not in date order..