yashsingh1/xdaforums huggingface dataset:
[Magisk] zgfg:
On my Delta I have:

- Zygisk ENABLED (yours is disabled)

- Magisk Hide Enabled

And my HMA is configured accordingly to the mentioned guide (the guide was actually based on my earlier guide but he added many details, better explained and updated to UI/friendliness improvements in the newer versions of HMA).

Hence I stick to the point that HMA must be configured accordingly to the guide - btw, see also what the other users commented in that thread

Btw, since I saw some issues reported on TG related to Zygisk with the latest Delta, I'm still on Delta 9a69ab92 (25205) from a week ago. I don't know if you're using the newer Delta and if there are reasons to not enable Zygisk there
[Magisk] huskydg:
John is having his vacation and doesn't have time for Magisk
[Magisk] xShx72:
Hey again,

I've rooted my device with a locked bootloader, and I am wondering is there any way to install a spoofing method (Smali patcher, or Systemize the spoof app?) without dealing with the system partition, because my root is on the data partition entirely. I'm not sure whether tampering with system would brick my device.
[Magisk] huskydg:
This is POC from AppGuard that recently some banking apps are using it
[Magisk] m0han:
Like I mentioned earlier I am (almost always) on the latest Magisk Delta Canary. The HMA that I am using is the older v2.3.2. Not sure if these make the difference between your results and mine. I shifted from Zygisk to Riru sometime back (don't remember why exactly, tbh). It is, now, a bit of a hassle going back to Zygisk. When I saw @pndwal's post, I started looking for an easy way to, hopefully, change the location of the modules and resolve the issues. But I now understand that it is beyond my comprehension/capability.
[Magisk] pndwal:
Well it does detect if we use specific timing, ie. hold down vol- well before boot animation...

The issue is that safemode works if we wait for boot animation to depress vol- and instructions often say to press this when boot animation occurs... A number of users have thought modules must have been disabled since safemode was triggered per john's FAQ... They have therefore done clean ROM installs etc thinking the issue was more serious...

Yes...

No...

The problem is timing as stated in issue... Till now this apparently only used persist.sys.safemode and it did work with early vol- keypress...

Shana seems confident it's fixed, and I said I look forward to testing...

Regarding how this could work (and I'm only guessing here since fairly unfamiliar with device property usage):

Since system properties prefix can be ro for properties only set once or persist for properties that should still exist after a reboot, I'm guessing that ro.sys.safemode will be set directly by key-combo detection or shut-down menu selection in android, then persist.sys.safemode set so that safemode from shutdown menu persists through a reboot. (It may be that key-combo triggering also employs a reboot also, I don't know.)... If this is the case, then Magisk's bootstages safe_mode = true would be triggered (slightly?) earlier by ro.sys.safemode...

On my two MIUI devices, if I wait for animated logo to start holding vol-, I get safemode w/o Magisk detecting it... (Holding vol- earlier results in safemode w/ Magisk detection.)

I'm guessing it may be that while setting persist.sys.safemodeis occurring too late in bootstages for bootstages.cpp's safe_mode = true to trigger
disable_modules();
disable_deny();, setting ro.sys.safemode may occur occur early enough for Magisk to react...

AS I mentioned, this is guesswork on my part, and it does seem that there may only be nanoseconds between the setting of these props, so I'm actually equally sceptical that this will be a proper fix... It still looks to me as if Magisks critical bootstage checks may simply have timed out by the time the animated logo appears on some devices while Android system seems to set the props early but continue checking vol- until animated logo and revert settings unless vol- is still depressed at that point...

So we shall see... I'm happy to see at least some early work on this... PW
[Magisk] osm0sis:
You guys ever get the feeling you're arguing for the soul of Magisk? 😔

Nothing installed in Lineage /system/addon.d/ via Magisk app Direct Install + fix_env · Issue #3820 · topjohnwu/Magisk

I installed Magisk by using the "patch boot.img and flash with fastboot" method, since the installation instructions say that using the installer zip via a custom recovery is no longer recommended....

github.com
[Magisk] osm0sis:
I've been running official Magisk CI builds via hidden Magisk App and my CI installer script (since I wanted to use my recent addon.d-v2 fix in prod): https://xdaforums.com/t/tools-zips-...ices-platforms.2239421/page-155#post-86189083

Working well currently.
[Magisk] pndwal:
I feel your pain...

Just got reminded of your issue by @Stillhard ...

Glad someone has the... the gumption... Passive aggressive, love that! ...

Was already watching that space... Getting interesting! [Edit: different issues of yours actually...]

And I had noticed a now almost ingrained dismissal of issues affecting custom ROMs occuring... Bit sad, especially w/ all your work to support custom... 👍👍👍 PW
[Magisk] pndwal:
So I was actually looking at a different issue... This one takes the cake now... 😕🙃👏 PW
[Magisk] osm0sis:
Yeah they basically have open contempt for custom ROMs and/or me.

They're the ones with John's ear lately though, so I fear this is a losing battle.

It's depressing honestly.
[Magisk] 73sydney:
i just saw all the spice

while i can see valid points on both sides, they would be 1000% easier to debate if there wasnt the history of utter dismissiveness on one side that is unnecessary
[Magisk] 73sydney:
Me too, i assumed the one i was looking at was spicy enough....this is really a new low
[Magisk] pndwal:
This comment (Custom ROMs "can't even be called Android" if they don't meet CDD):

https://github.com/topjohnwu/Magisk/issues/3820#issuecomment-1364679527

reminded me of a conversation I posted here between Shawn (Tech Lead for Android hardware-backed security subsystems) and Luca (Director for LineageAndroid & Developer):

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-83281243

... Not much parity between those w/ Android in their titles (and I note the mutual respect also) and main Magisk Devs AFAICS sadly... Really hope John respects the legacy left by the likes of Steve Kondik and others more...

FWIW, Google never said they want to stop modifications to android, ie custom mods / ROMs... Actually they love it!... They know a good thing, even if they've made mistakes before...

Just when Kondik though CyanogenMod was dead cos Google told him to cease and desist packaging GApps, they basically said "no... don't stop with you project... Just don't package our code... but let's do this; let's allow users to 'sideload' GApps themselves cos they've got licenced devices... And someone can package them to make your life easier too... as long as these are separate from your ROMs, OK?... And very sorry to scare you mate!... You're doing a wonderful job... (ouch!)".

Why do they even allow non-certified devices to be white-listed to enable owners to load their proprietary GApps quite legitimately, but stipulate that this is only for custom ROM use?... Cos they're not against modders! ... or custom ROMs etc... (The measures that led to this were only to styme unscrupulous re-sellers etc... The whitelist showed they count those running legitimate modded Android ROMs or custom Android ROMs as just that; legitimate).

So proposals to get CDD compliance for LineageOS, concessions regarding/tacit approval for proprietary GApps on custom Android, a whitelist especially for customer ROM users (so even lack of device certification in China won't break GApps packages on custom Android)... What more evidence could one need that Custom ROMs ARE as legitimate Android OS's as commercial AOSP derivatives, even in Google's eyes... 🤪

Hope you will keep arguing for the soul of Magisk Chris... Nb. Nothing in this post is copyrighted... 👍 PW
[Magisk] osm0sis:
And to think I used to think yujincheng was the reasonable, approachable one...
[Magisk] huskydg:
About rw system, magisk still setrw blocks on boot and allow users to remount system as root
[Magisk] GPSSlovakia:
How to install Magisk on MIUI 14 (Android 13) ?
[Magisk] zgfg:
Extract the boot.img from the ROM zip file, install Magisk app, take Install Magisk from the app to patch boot.img, transfer the patched img to PC and flash by Fastboot

Test first with

fastboot boot <patched img>

If working ok, flash permanently:

fastboot flash boot <patched img>
[Magisk] GPSSlovakia:
I have tried with Magisk 25.2, but it does not work. After flashing patched img the phone does not boot - it is stuck in first screen with miui logo.
[Magisk] Clandaries:
Isnt the best way a working custom recovery?
[Magisk] zgfg:
Applicable only if custom recovery (official TWRP does not support A13) supporting MIUI 14/A13 on that device exists

Usually not yet, hence Xiaomi.eu ROMs, requiring custom recoveries to flash, are distributed as fastboot flashable ROMs for now
[Magisk] zgfg:
Are you sure you are using correct boot.img

Test with the not-patched boot.img, does it boot correctly:

fastboot boot boot.img

Boot.img must be from the same phone, same MIUI version, same flavour (eg, China if your ROM is CN, EEA if your ROM is EEA, etc).

Otherwise phone will not boot with that patched or not patched img

As I suggested, do not flash permanently but just boot through Fastboot:

fastboot boot <img>

If anything goes wrong you can simply reboot back to your working system

---

Also when you patch, does Magisk report correctly finding the stock boot ing, finding Ramdisk, patching successfully?

Try with Magisk Canary 25205 (newer than Stable 25.2=25200)
[Magisk] GPSSlovakia:
It works with Magisk Canary 25205 !!! Thank you very much !!!
[Magisk] ipdev:
The only adjustment I would suggest.

Is to use Magisk's Direct Install option to make it permanent instead of flashing the patched boot image after test booting it.

Test boot using fastboot boot magisk_patched-boot.img.

If it boots and Magisk is active, use the Magisk app to install Magisk.

I am not sure when or why I originally switched to it. 🙃

Besides Magisk making a backup of the current (non-magisk) boot image, another example of why whould be..

If you are using a device that includes recovery in the boot image.

You can patch and boot the stock boot image with Magisk.

When you use the Direct Install option, it will patch the installed boot image with Magisk.

If you are using a custom recovery (twrp) that also patched the installed boot image, you will have both Magisk and TWRP.

Cheers. :cowboy:
[Magisk] ipdev:
The more I look at it the more confused I get. 🤔

By transferring Magisk's restore-after-update into a module, it will only work with the system OTA updater (maybe).

Would not the post-fs-data script run every time you (re)boot?

That seems more wrong (dirty), not cleaner.​

Custom roms will still use addon.d (even if broken) regardless.

What about those that update via recovery?

Recovery is not going to magically recognize and mount Magisk modules.

What would be the benefit to making Magisk's addon.d support into a module?

¯\_(ツ)_/¯

---

Keep up the Fight brother. 👍

Cheers. :cowboy:
[Magisk] zgfg:
Yeah, true. It saves from the second time rebooting to Fastboot

I overlooked that bcs I suggested the procedure to test the patched boot IMG before flashing permanently since he reported bootloop, although, I myself rarely do it - I just flash permanently and take the risk😁
[Magisk] pndwal:
Age may be a factor... 'brashness of youth'?...

Shana (yujincheng) was still a uni student in late 2018... vv seems to be a similar age (but can't be sure)...

I'm sure the heady days of CM, SuperSU won't mean much (or at least as much) to them, nor the efforts of many of those who've built the bridges since...

... I did notice that Canyie (while not a main Magisk dev) who recently turned 18, reacted to your merry-swear comment w/ 👀 emoji... maybe she likes that kind of thing?:

https://www.dictionary.com/e/emoji/eyes-emoji/

😝

... Wonder who's in John's Slack group now... and if Jorrit (@Chainfire) took up John's offer to join some years ago... He might be more of an old school influence (in a good way) on Magisk... And I think John, for one, did learn lessons re. taking other Devs work for granted both quickly and well... At least I hope he did... PW
[Magisk] huskydg:
I guess you are fan of them because I always see you talk something cool about them

So... If you love them, can I screenshot this and send to them? I believe they will love you too 😉
[Magisk] pndwal:
Tell you what... I'll respond to that if you do me the decency of responding to my genuine queries...

I've responded to all questions you've directed to me to date... You seem to ignore mine as a rule... PW
[Magisk] pndwal:
Latest Canary (+Debug) Magisk:

Magisk (831a398b) (25206)​

Fix support on Linux < 3.6

Several minor under-the-hood improvements

Diffs to v25.2​

[General] Fix minor bug in module files mounting implementation

[MagiskPolicy] Fix minor bug in command line argument parsing

[Zygisk] Prevent crashing daemon in error

[Zygisk] Rewrite zygote code injection with new loader library approach

[App] Make stub patching 100% offline

https://github.com/topjohnwu/magisk-files/blob/5b2934603f979d7133e67bbc30c6ce3fa0d8e31e/notes.md

👍 PW
[Magisk] pndwal:
... Short vacation? 😶 PW
[Magisk] pndwal:
Re. 25206 on Xiaomi RN8T, stock A10 MIUI...

App update (with Magisk App hidden) went lightening fast w/ no issues. 👍

Same for Direct Install mask update... Everything good as before... 🙂 PW
[Magisk] martyfender:
Is anyone else seeing high cpu usage with this update? It is on Android 9 with shamiko, zygisk lsposed, USF mod and hide my applist. this is after a couple of reboots and deleting the cache and dalvik cache.
[Magisk] martyfender:
so does anyone have any thoughts on the above?
[Magisk] huskydg:
Few users in my group are facing same problem
[Magisk] martyfender:
Yes, on my other almost identical Onn 8 1st gen tablet, I always have your latest builds and I don't see high cpu usage on it. The previous tablet has topjohnwu's latest released debug build on it.

The only thing I see on your latest build is that with momohider when I disable magiskhide now I do not pass safetynet with the USF mod unless I turn on magiskhide. Is this a change you made without telling us or is it a bug? You had stated previously to disable magiskhide when using, I think, momhider, after configuring the hide list.This seems to now not be the case on several recent builds.

The modules I use on the huskydg debug build:

App Systemizer (Terminal Emulator)

Busybox for Android NDK

Riru 26.1.7.r534

Riru -Enhanced mode for Magisk Hide 2.0

Riru Momohider 0.0.13

Riru LSPosed 1.8.5 (6695)

Universal SafetyNet Fix 2.3.1 by kdragOn modded by Displax

Hide My Applist 3.0.6-386

I can provide logcats and magisk logs if needed.

I can post on telegram if it is more appropriate. I do read there frequently but post there can be very confusing with lots of people getting banned.

Thanks
[Magisk] martyfender:
Usually I get the same, no response.
[Magisk] martyfender:
logcat for my previous post: #54,151
[Magisk] zgfg:
Today I tried to test with Safe Mode on my Xiaomi Mi 9T running MIUI 12.5 (A11), with the latest Canary 25206

Two times entered to Fastboot (probably I executed the key-combo too early), third time it rebooted normally - not to Safe Mode

(I remember how long ago when I similarly tested on this or on my other, newer Xiaomi phone, it took me many times to eventually succeed to enter the Safe Mode [by pressing earlier or later], but unfortunately I do not remember did Magisk then disabled the modules or not)

Hence, now, Android booted normally but all my modules were disabled. I rebooted one more time, now normally and all the modules were still disabled - until I re-enabled them one by one and rebooted again

Somehow my key-combo timing for MIUI to catch for the Safe Mode was not good but nevertheless the Magisk caught it

Or maybe checking that new prop propelled Magisk to think it was the Safe Mode

Anyway, even as that it can be helpful to disable the boot-looping module(s)
[Magisk] pndwal:
It seems you're saying you were able to get Magisk disable modules when Safe mode wasn't actually triggered (as I mentioned can happen in GitHub issue)...

As I described re. my tests, if you start holding vol- too early, Safe mode isn't triggered... Nor is it triggered if vol- is released more than a second or two before the animated (2nd) logo appears...

Early depression of vol- may trigger disabling in Magisk but not Safe mode itself in either of these two cases... I believe if you release power key immediately after startup (vibration) begins, wait several seconds, then hold vol- continuously until device boots, you'll get both Safe mode and detection in Magisk... If all instructions for MIUI Safe Mode prescribed this, the module-disable function might work as expected... but not all do...

So more to the point, by releasing power key immediately after startup (vibration) begins, waiting until animated (2nd) logo appears, then immediately holding vol- until device boots (as some instructions prescribe), I previously got Safe mode without detection in Magisk...

This is the real problem as the result causes users to believe that modules must have been disabled so bootloop must be due to more serious issues when, in fact, a module is still causing it...

Your may wish to test that; I haven't done so yet, but I suspect that the issue may well still be there... Like you, I'm not confident about the recent 'fix'. PW
[Magisk] zgfg:
Ok, thx, I may try with your testing how-to later

Actually, I have a problem with the test - by disabling the modules, LSPosed gets disabled and hence the HMA (new 3.0.6 Beta)

Then next time when I enable the modules, HMA does not work. I even waited 10-15 minutes but still no hiding was in place, I had to make some 'changes' in HMA and reboot again, to get the HMA working

I'm still not sure was my HMA put back to work by one more rebooting, by disabling it and re-ebabling throug LSPosed mngr or by making 'changes' in the HMA Templates and/or App managing but it's pretty tedious - better not to disable LSPosed, ie not to disturb the working HMA

The old HMA (pre-Beta 3.0.*) was much more robust (although the UI was less intuitive and one everywhere had to press Save)
[Magisk] pndwal:
Not sure, but guessing it may be we simply need 2 reboots for LSPosed modules if LSPosed needs reboot (1st) prior to XPosed modules (2nd reboot)... May test later... PW
[Magisk] pndwal:
The above may be a case of loose English...

Rather than "Few users in my group are facing" the problem, I think he meant "

A

Few users in my group are facing" the problem...

I'm not assuming he means users running Delta fork either; it could be that users of latest Canary have reported there, but it's also unclear... Possibly meant users reported such issues prior to latest Canary update also...

As someone who hasn't noticed/tested for this in the past, please let me know how to test abnormally high cpu usage... Does this indicate acceptable range?:

👍 PW
[Magisk] martyfender:
I used Simple System monitor. After further testing I am guessing the high usage (97-99%) is caused by services or processes running at startup and or wakeup from doze. I am now seeing this behavior also on my device with Magisk Delta debug with the updates released in the last couple of days.

The official Magisk debug is now at 65-96% cpu usage and Magisk Delta is at 96-100% cpu usage soon after reboot.
[Magisk] vulcanrvn:
Those were my thoughts exactly, I actually ended up doing this for a few of the modules. That said there's two of them that I cannot find anywhere in any of the files in the modules or the installers of where it determines where to create the folders which is kind of annoying but regardless I appreciate the help thank you.
[Magisk] martyfender:
I don't usually test them, but the latest artifact build may have solved this. The device is also more responsive and I suspect the battery life is better. The faster battery drain was also a side effect I did not mention. The boot time is much faster, also.
[Magisk] martyfender:
Forgive me if this was already stated somewhere, but I have limited time before a doctors appoinment to search.

I have read various places both on xda and on telegram groups to enable both zygisk and magiskhide at the same time in the Magisk Delta. This doesn't entirely make sense to me because when you do this, magisk disables any riru modules automatically. Can someone provide some insight into this?

Thanks
[Magisk] zgfg:
Yeah, of course, don't enable Zygisk if you want Riru modules

However, I'm happy with MagiskHide and Zygisk, with Zygisk-LSPosed, without Shamiko, and of course with no Riru
[Magisk] martyfender:
Thank You

this actually seems to work pretty well. However, I don't have any banking apps etc to test, because Chase here in the US is not available for my device, S well as most of the international banking you all mention.

They just simply are not available on the playstore in the US.

I only have root detection apps to test with. If anyone has regular root foiling apps available in the US playstore, please let me know and I will test them.
[Magisk] zgfg:
You can test with checkers like Ruru, Oprek, SCheck, TB-Checker

Releases · byxiaorun/Ruru

An android sample app of detecting suspicious apps like magisk manager - byxiaorun/Ruru

github.com

Oprek Root Detector - Check De - Apps on Google Play

Apps to check devices health, root, or xposed framework.

play.google.com

Security Check - Device compli - Apps on Google Play

Check your device readiness and compliance for Mobile Payments

play.google.com

TB Checker - Play Integrity - Apps on Google Play

All in one tools check android devices

play.google.com

But why would you bother with them if you don't have real problems
[Magisk] pndwal:
Chase Mobile app?; (JPMorgan American national bank) It shows in Play Store in Australia!... (App itself doesn't detect with my bypasses either; apparently adding cards etc gives issues for some users.)

Can I assume you have passing PI deviceIntegrity and have cleared Play Store data?

What device / OS? PW
[Magisk] martyfender:
Yes, I pass both. It is an Onn 8 1st gen tablet with Android 9. Could it be because it has no NFC? It downloads and works on my Samsung XCover Pro work phone. In the US it is called the Chase mobile app.
[Magisk] pndwal:
Sorry, both? (what)... Did you clear Play Store data?...

Just checked and they only mention access to Google Play on Android 8.1 and above (guess this could be out of date since A8.1 security patches ceased?) but does say "Some devices are not supported due to hardware limitations":

https://www.chase.co.uk/gb/en/support/downloading-the-chase-app/

Could try sideloading if Play Store issue can't be fixed... PW
[Magisk] martyfender:
Thanks

I did try side loading but the only place I found the apk may have been questionable sites and the apps did not run. I didn't find it on apkmirror, the one legit site I know of.

So my guess is that this Android 9, mediatek device, arm8A device is not supported. This strange though as the app worked on my old, Nextbook Ares 8A, Android 6.1, Intel x86-64 devices in the past.
[Magisk] pndwal:
Still guessing about this... Does both mean PI deviceIntegrity (I asked about) and S/N CTS Profile match?... Other?...

And most importantly, you still haven't confirmed:

🤔... Could be as simple as that!... PW
[Magisk] martyfender:
Why guess when I stated that I passed both. Maybe passed was the wrong term. Safetynet passes also.

Thanks
[Magisk] pndwal:
Cos I only asked re deviceIntegrity verdict... Had no idea what both meant... And still don't know if you cleared PS data (4th time)... 🥴 PW
[Magisk] martyfender:
Play Integrity API checker :

MEETS_BASIC_INTEGRITY,

MEETS_DEVICE_INTEGRITY

Device is certified in the playstore settings, that is what I mean by passes both, to clarify.