yashsingh1/xdaforums huggingface dataset:
[Magisk] sawdoctor:
The rootless jamesdsp apk works either with root or adb so it is also a root app. I meant try it to see if it works with magisk or not, if it works at least you can use the module until magisk issue is resolved and you can easily switch back from within the app itself
[Magisk] ipdev:
"New magisk tmp dir: /debug_ramdisk"

Magisk - [GitHub] - commit

Example: Pixel 3a Lineage 19.1

bonito:/ $ magisk -v
c79bc8327-ip:MAGISK:R
bonito:/ $ magisk -V
26102
bonito:/ $ magisk --path
/debug_ramdisk
bonito:/ $ ls -la debug_ramdisk/
ls: debug_ramdisk/: Permission denied
1|bonito:/ $ su -c ls -la debug_ramdisk/
total 1408
drwx--x--x 5 root root 260 2023-05-30 20:21 .
drwxr-xr-x 26 root root 4096 2023-04-22 18:55 ..
drwxr-xr-x 11 root root 260 2023-05-30 20:21 .magisk
drwxr-xr-x 2 root root 80 2023-05-30 20:21 dex2oat
lrwxrwxrwx 1 root root 10 1974-02-05 10:08 magisk -> ./magisk64
-rwxr-xr-x 1 root root 164200 1974-02-05 10:08 magisk32
-rwxr-xr-x 1 root root 259984 1974-02-05 10:08 magisk64
-rwxr-x--- 1 root root 657224 1974-02-05 10:08 magiskinit
-rwxr-xr-x 1 root root 345584 2023-05-30 20:21 magiskpolicy
lrwxrwxrwx 1 root root 8 1974-02-05 10:08 resetprop -> ./magisk
drwxr-xr-x 2 root root 80 2023-05-30 20:21 shamiko
lrwxrwxrwx 1 root root 8 1974-02-05 10:08 su -> ./magisk
lrwxrwxrwx 1 root root 14 1974-02-05 10:08 supolicy -> ./magiskpolicy
bonito:/ $

Not sure if it helps but, that was the change.

¯\_(ツ)_/¯

Cheers. :cowboy:
[Magisk] pndwal:
Still, you said

which is just not true.

Edit: Seems I've misunderstood the members meaning here (as pointed out in next post), sorry! 🙃

FWIW however, you can both re-lock B/L and use stock ROM again and you will have Android like other devices. Samsung just disable their proprietary special knox-based features after device is tampered...

Old Sammy devices did work that way, but now soc makers include e-fuses that utilise physical burn-in on the substrate... I put info on use of q-fuses (Qualcomm) here:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85146255

Samsung says

I put a number of links here (incl. ref. above):

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85755893

Yup... It's a choice... Much like Google's device integrity APIs and key attestation models really... They're doing that because they must compete in the secure Mobile OS arena in today's climate, and are loosing to IOS in the enterprise/corporate marketplace because of the (justified) perception that Android is largely insecure...

Samsung want to position themselves as a credible alternative to IOS/iPhone and as the leading manufacturer of property secure Android devices in this market too as the (somewhat outdated) links above show...

The difference in these approaches (ie. Google doesn't penalise modders by making the restoration of some device features impossible while Samsung does) may indicate that Google is more supportive of the modding community than is Samsung... I don't know if Sammy encourage custom modders in any way other than allowing B/L unlock... But it's still far more generous that what IOS will offer you!

😜 PW
[Magisk] sawdoctor:
What I said was once you root something's will never work again which is 💯 CORRECT. Of course you can relock bootloader but it won't fix the apps that will never work again and that was my point ffs
[Magisk] pndwal:
Ah... Sorry. 🙁

I'd read

to mean you 'can't relock bootloader and go back to stock on Sammy once you trip Knox, and that's something that will never ever work again' rather than 'If you relock bootloader and go to back stock on Sammy, once you trip Knox some things will never ever work again'!... 🤪

I probably should have asked you to clarify that, sorry mate... PW
[Magisk] chazall1:
https://xdaforums.com/t/platform-to...r-root-pixel-7-pro-cheetah-safetynet.4502805/

VERY IMPORTANT - On the Pixel 7/Pro, we use Magisk to patch init_boot.img, NOT boot.img AND we flash the patched init_boot to the init_boot partition - do not flash it to the boot partition.​
[Magisk] zgfg:
Apparently, there was also a change in the $MAGISKTMP variable (available during the Installation of Magisk modules):

In Magisk v26 it points to magisk --path (the new path), in the older Magisk versions it pointed to the subfolder .magisk of the old magisk --path

Nevertheless, I made the modifications that both AML and JamesDSP modules can now work also on Magisk v26 (zip installations attached in the quoted post):

https://xdaforums.com/t/jamesdsp-audio-manager-mmt-ex.3607970/post-88598223
[Magisk] paper88:
Hello together

If I tick some apps in the denylist and leave magisk app, some apps untick it themself: Android Auto, Cell Broadcast Service, Google Services Framework, Networkmanager and Tethering. If you wondering why I hide this apps, I just hide all Apps from google. Are there any limitation of hide apps in the list?
[Magisk] J.Michael:
You are not supposed to "hide all apps", you are generally advised to hide as few apps as possible; hide an app only when necessary.

I don't know whether "hide all apps from google" means "hide from Google all apps" or "hide any app you think was produced by Google", but both are bad ideas.

In particular, hiding some Google processes can cripple Android.

There have been posts about USNF or Shamiko (not necessarily both, I just don't remember the details) removing some Google process from the deny list because it (the module, USNF or Shamiko) handled that process specially. I do not remember reading about those other processes you say are getting unticked.
[Magisk] paper88:
Thanks for feedback, i just heard somewehere that google could recognise root over other google apps. I check again and will untick all unnecessary apps
[Magisk] klodfor:
confirm not work 16.7+ above
[Magisk] klodfor:
same question
[Magisk] Nergal di Cuthah:
These posts are from 2020 magisk has evolved greatly since then.

Please layout your question for a modern audience. State your device, magisk version android version and issue clearly.

Thanks it'll be good to provide help to you.

Especially since the first post you quoted refers to a post that at that time hadn't been created
[Magisk] m0han:
Shamiko v0.7.3 (174), 06/04/2023

What's new:

Requires Magisk 26000+ / KernelSU 10940+

Follow root profile on KernelSU
[Magisk] Mowca:
After updating magisk and restarting the phone, the phone goes into bootloop. No update method works... inatall .apk, twrp, directly from the app.Does anyone have a way to update correctly?

Galaxy s10e

Lineage 18.1

Magisk 23.0
[Magisk] alexandrew74:
Hi! I have POCO M3 Pro 5G (Camellian). The only easy way to install Magisk for me is to replace the stock boot image with Magisk's repacked one and flash it together with the new firmware through fastboot (including empty verity file, by editing flash_all_except_data_storage.bat) - tried both stock MIUI 12.5 and the last 14 (Global).

But after this Magisk is continuously asking for an "advanced installation", but the "direct install" option has no effect on the phone: Magisk asks and asks for the "advanced install" and also can never update to newer versions.

Though everything that requires root works fine yet, I'm very curious why Magisk considers it's own installation as inferior and how to overcome this issue.
[Magisk] kullurumanoj:
Hello All, Is anyone able to use nfc feature on cred or paytm? In paytm app it says the functionality isn't available due to security reasons. I'm using hml, I'm not a developer, lsposed and xprivacylua setup. Please help me in debugging the issue
[Magisk] zgfg:
Please , for the beginning, find a thread about Google Pay and read about USNF module and Play Integrity attesting (OP posts)

It will not work with XLua. You must even manually remove XLua remaining folder (apps detect it)
[Magisk] J.Michael:
How was Magisk 23 installed? Did it come as part of Lineage 18?

If you were running with Magisk 23, and you have modules installed, it is likely they are not compatible with newer Magisk.

If you can restore your original configuration -- Lineage 18 and Magisk 23 -- I think you should stick with it.

If you are determined to update Magisk, start by uninstalling, or at least dissbling, all modules while you have a working system. Then see if updating Magisk gives you a working system. Then, very slowly, find replacements for your old modules.
[Magisk] ipdev:
I have run into it (every now and then) updating Magisk using a previously patch image.

- Magisk patched boot image detected

Bootloop and/or a forever (infinite) boot.​

If it is just updating Magisk, use a clean (stock) boot image.

In your case, the stock Lineage 18.1 boot image.

For me, if the update failed..

- I normally flash the stock boot image back and reboot.

Since I still have the newer Magisk app (Manager) installed.

- Push the stock boot image to the device (if it is not already there).

- Use the "Select and Patch a File" option to patch the stock boot image.

- Stock boot image detected​

- Pull the new Magisk patched boot image.

- Flash (install) the new patched boot image.

---

To complicate my reply.

Depending on the device..

I use the hardware key-combo to boot into bootloader.

- Flash the current stock boot image to the device.

- Use fastboot to 'boot' a previously patched boot image.

- Then use the "Direct Install" option to install.

- Stock boot image detected​

Hope it helps more than confuse. 🙃

Cheers. :cowboy:
[Magisk] baselmagdy:
hello, magisk isn't showing me themed icons when in shortcut mode any fix?
[Magisk] ipdev:
I have run into if once or twice.

Sorry I do not remember exactly how I fixed it. 🙃

Might have been fixed in Magisk.

The message comes when the current Magisk (demon) is out of sync with Magisk.

The last time I ran into it, I do not remember what fixed it. 😥

Try clearing cache and data of the Magisk app.

Assuming it is the same version that is patched into your boot image.

Clear the cache and data of the Magisk app and uninstall the app.

Reboot and install the Magisk app again.

Delete /data/adb and let Magisk recreate it.

This will kill all modules and Magisk settings.

Good luck. 👍

Cheers. :cowboy:
[Magisk] m0han:
;) Key Attestation app update v1.4.1

Security vulnerability fix: https://github.com/vvb2060/KeyAttestation/commit/c3cf23694e41ab374744559839bd86ed468f952c
[Magisk] pndwal:
Yeah, I tried that last night... Either the fix is incomplete or I'm missing something as B/L status is still bypassed using LSP TEE Hide module... 🤔 PW
[Magisk] zgfg:
Null pointer exception for me with this latest v1.4.0 and v1.4.1
[Magisk] chiteroman:
The old module TEE Hide just throw an exception in getCertificateChain method, so apps can't know if bootloader is locked or not. I will try to update AttestationSpoofer to bypass (again) the locked bootloader. They are using another cert class, because it doesn't call this method like previous versions.
[Magisk] shoey63:
Doesn't like ROG 3
[Magisk] chiteroman:
They uncomment the code finally XD.
[Magisk] pndwal:
Interesting that results vary...

Still, despite KA app adding "Support for saving and loading proofs; Save to file from the menu, send to other devices and load the proof file, thus simulating the normal server authentication process", as I said TEE Hide / AttestationSpoofer is still bypassing B/L status properly in that app on unlocked Xiaomi RN8T:

🤷 PW
[Magisk] DaOldMan:
If I use Magisk 26.1 in my rom every app in denylist crashes.

The rom is ViperOS, Android 7.1.1, latest security patch. The log is a follows:

Spoiler content hidden.
[Magisk] zgfg:
Generally, in DenyList must be only apps you want to hide Magisk from them (banking apps and so)

And GMS (Google Play Services) - although, when using Zygisk and USNF, USNF will remove GMS from DenyList

If some banking apps still crash (or complain) although in DenyList, then they require additional treatment to hide Magisk, root, unlocked BL - USNF, Shamiko, maybe HMA, etc

Hence first, which apps do crash (and before that, remove 'normal' apps from DenyList if you have them, and reboot)
[Magisk] pndwal:
I just realised that the two 1.0 apps are actually different... I just downloaded AttestationSpoofer expecting it to be an update. Instead I now have both showing in LSPosed manager...

TEE Hide gives "Bootloader Locked" on my device as stated...

AttestationSpoofer gives:

👀 PW
[Magisk] klodfor:
To tell long story short..

My device ZTE Blade A6 (A0620) Android 7.1.1 Mifavor 4.2

Many other ZTE device users stuck on old 16.7 Magisk. Newer ver. causes Bootloop or DFU.

Problem is Magisk incorrectly patch ramdisk of stock boot.img.. It is 100% not vendor side problem.

According to CHANGELOG after 16.7 Magisk was Hotfix v17.1 where topjohnwu wrote

Since then flashing/patching on stock boot.img magisk newer than 16.7 don't work.

Uninstalling previous 16.7.. Flasing on stock... Patching via last Magisk-v26.1.apk.. still the same problem(

There are a lot of other feedback besides me is the net.

Pleasefix bootloop/ DFU.

I attached all possible logs and kernels + working ones on v16.7 >> Before and after incorrect ramdisk patch.
[Magisk] J.Michael:
I don't think you are going to get anything fixed by posting details here. And I don't think you will get much sympathy on github with a problem that cropped up between Magisk 16.7 and 17.1.

What problem are you hoping to fix by updating your Magisk? (I.e., why not stick with the one that works?)
[Magisk] DaOldMan:
Tnx mate for the reply.

1. I have no modules installed.

2. I have put just one app in denylist to demonstrate. Any app (all of them) in denylist will crash, so I can't use denylist at all :-( .

3. Magisk 25.2 works just fine, I don't even need to hide apps to pass safetynet. No crashes at all for apps in denylist!

Any ideas what's wrong ?
[Magisk] zgfg:
No, I have no idea.(other than what I answered earlier).

And still no idea which app you tried in DenyList that it crashed

Btw, if you want to access developers (and give them the logs), you will need to submit an Issue to Magisk GitHub
[Magisk] pndwal:
I'm confused by you Magisk versions... Old 5.2 and 6.1 don't even have denylist!... Not available till 24.0+...

Have you tried up to date Magisk? 🤔 PW
[Magisk] DaOldMan:
I ment 25.2, sorry mate you are correct.

The one that crashes any app is 26.1.

Cheers
[Magisk] pndwal:
Tried Canary?...

Strange issue (may be fixed already though)...

However denylist is not really for hiding, rather it's a development/testing tool...

Suggest using a proper hiding solution like Shamiko; uses denylist as hidelist for convenience (with DenyList actually disabled)... Much better hiding (akin to/improved on MagiskHide) and doesn't break Zygisk modules that inject into apps in deny/hidelist...

Personally I'd give Canary a shot first... You can't even make a GitHub issue without trying latest builds (nb. Canary release and Debug debug are synced builds)... PW
[Magisk] pndwal:
Seems DFU is Device Firmware Upgrade mode in IOS devices... Guess you mean fastboot or download mode?

Checked, and seems nothing's been reported in GitHub issues for your device... Very little for ZTE at all...

If you want to make an official issue, Devs will likely close it if it's related to an unofficial ROM or kernel, so you'd need to have tried latest Magisk builds (they won't bother testing with older builds/logs) w/ clean Magisk configuration on stock (recommend latest available) ROM (I think your Mifavor ROM is custom?).

If you haven't already, I suggest a simple test:

Uninstall any Magisk App/Manager, wipe everything in /data/adb using file explorer in TWRP (to remove possibly corrupted Magisk configuration), dirty flash your current ROM to restore any changed images incl. /boot partition (you can keep or restore TWRP as recovery) then download latest Canary Magisk, change file extension from .apk to .zip and flash this from TWRP, boot to system and check if Magisk App or Magisk stub app has been installed an either open it and follow prompts to complete installation and re-flash Magisk from booted system (now needed to set up selinux/module rules directory), or restore package extension from .zip to .apk, install App and follow prompts to complete installation...

if it doesn't work, flash stock ROM (Preferably back up data an clean install) and try again...

if still no dice, extract the stock boot.img (must be from current ROM), patch this in App and flash using PC/fastboot and complete steps above...

If nothing works, repeat using Debug Magisk (needed for proper verbose logs when making an issue) and take logs, then make an official GitHub issue taking care to follow the prescribed template or issue may be closed...

🤠 👍 PW
[Magisk] klodfor:
I've tried everything in your list (have full experience, I'm advanced user). Please check my attached dmesg in ZIP = ZTE_magisk_xda.zip carefully!

I've attached stock/working 16.7/last patched boot.img and logs, so you can disassemble them using osm0sis AIK for example to see what is wrong.

As I can understand starting from 17+ Magisk ramdisk patch is differ from 16.7 ver.

My firmware is stock. I've also patched stock untouched boot.img (from same stock official QFIL firmware ZTE for blade a6)

in latest canary build apk/ flashed zip using TWRP >> device run into ZTE Handset Diagnostic Interface (DFU) (COM11) and nothing else.

I've repeated everything using wanted Debug Magisk procedure in app-debug.apk and here you go again:
[Magisk] pndwal:
Had a quick look, but I'm only an amateur sleuth... Seems to be many Selinux context issues...

Only changes that seem possible culprits are

v17.0/17.1​

[Script] Enable KEEPVERITY when the device is using system_root_image

... Can I assume your device does not have a separate vbmeta partition and that you see and are checking the “Patch vbmeta in boot image” option?

Also

[MagiskInit] Move all sepolicy patches pre-init to prevent Pixel 2 (XL) boot service breakdown

but it's beyond me to know if your selinux issues are related to this change...

If you have specific information, perhaps you could say how 'ramdisk patch is different' in 17.0+... 🤔

Generally users here can only offer tips and ensure your 'i's are dotted and 't's crossed, and seems you haven't been sloppy...

I really suspect selinux issues (regression due to Pixel 2 fix?) so I'd urge you simply to open a Magisk GitHub issue and submit your logs from debug build... Be sure to follow template and include "Magisk version code: 26102" in body of first post so bot doesn't close the issue immediately...

Experienced Devs will take a look for you (I'd list all affected ZTE devices you are aware of that are similarly affected too*) and you'll be doing others a service... 😜 👍 PW

*Edit: Many appear to be listed here:
[Magisk] DaOldMan:
As I said it doesn't matter which app I put in the denylist. If I try to put "google play services" it will crash over and over after boot (as it's invoked a lot). If I put in there some banking app, I can't run it anymore - it will allways crash. Any app in the list crashes every time you run it. The minute I remove it from denylist or stop enforcing the denylist, the apps run just fine again. I went back to Magisk 25.2 and the denylist works normaly again, nothing crashes anymore and I can pass safetynet.

Hope it's understood.
[Magisk] zgfg:
Another consequence of that change with magisk --path and $MAGISKTMP between Magisk v25 (or earlier) and Magisk v26

With Magisk v25, /system/bin (and /system/xbin - if the latter folder was available on the particular phone/ROM) were mounted by Magisk as read-write.

Eg, (and that was useful for modules) for the service.sh scripts

Now, with Magisk v26, if a service.sh script attempts to writes to /system/bin or /system/xbin, it will fail

That was useful when service.sh scripts from some modules wanted to link or mount certain changes to the given folders (eg, to install some executable applets), usually with ln -s ... or mount -o bind. ..(there is another way to do that but at an earlier stage of booting, from post-fs-data sh scripts, but that might be too early for some modules)

Indeed, you can test with the script attached below. Put it to /data/adb/service_d folder, make it executable by chmod 755 and reboot

On Magisk v26, the script will fail to write a temporary test file to /system/(x)bin. Script prints the log service.log (in the same folder) and by the end of the log file it will be printed:

+ touch /system/xbin/testFile_123456789
touch: /system/xbin/testFile_123456789: Read-only file system
+ ls -l /system/xbin/testFile_123456789
ls: /system/xbin/testFile_123456789: No such file or directory

To the contrary, on the same phone but with Magisk v25, the same script won't fail to write and it will log:

+ touch /system/xbin/testFile_123456789
+ ls -l /system/xbin/testFile_123456789
+ CheckForTestFile='-rw-rw-rw- 1 root root 0 Jun 6 21:33 /system/xbin/testFile_123456789'

showing how the creation of temporary test file failed on Magisk v26 vs succeeded on Magisk v25, from the script:

TestFile="$SDir/testFile_123456789"
touch $TestFile
CheckForTestFile="$(ls -l $TestFile)"

Here, $SDir points to /system/xbin or /system/bin, as defined at the beginning of the script and logged at the beginning of the log file
[Magisk] J.Michael:
On your device, is /system mounted rw?

I would have thought that a proper Magisk module would never try to write to /system directly. I thought one of the points of Magisk was that all changes were "systemless", so a proper module should put whatever it wants in /system in the module sub-tree, to be mounted over /system by Magisk at run-time.
[Magisk] ipdev:
I have not read the instructions in awhile. 🙃

Magisk will mount a tmpfs directory to store some temporary data. For devices with the /sbin folder, it will be chosen as it will also act as an overlay to inject binaries into PATH. From Android 11 onwards, the /sbin folder might not exist, so Magisk will randomly create a folder under /dev and use it as the base folder.​

The preset Magisk varables aparently were changed before the new /debug_ramdisk/ temp directory was set.

# In order to get the current base folder Magisk is using,
# use the command `magisk --path`.
# Binaries like magisk, magiskinit, and all symlinks to
# applets are directly stored in this path. This means when
# this is /sbin, these binaries will be directly in PATH.
MAGISKTMP=$(magisk --path)

# Magisk internal stuffs
INTERNALDIR=$MAGISKTMP/.magisk

# /data/adb/modules will be bind mounted here.
# The original folder is not used due to nosuid mount flag.
$INTERNALDIR/modules

# The current Magisk installation config
$INTERNALDIR/config

# Partition mirrors
# Each directory in this path will be mounted with the
# partition of its directory name.
# e.g. system, system_ext, vendor, data ...
$INTERNALDIR/mirror

# Root directory patch files
# On system-as-root devices, / is not writable.
# All pre-init patched files are stored here and bind mounted.
$INTERNALDIR/rootdir

Magisk.io - [github] - Paths in “Magisk tmpfs directory” - Link

Not sure if it will help on your endeavor.

Cheers. :cowboy:
[Magisk] bnsmb:
I also thought that /system is now always mounted ro ... but I just tested it on my ASUS Zenfone 8 with OmniROM 13 and Magisk v25.2 in the boot partition

ASUS_I006D:/sdcard/Download # magisk -V
25200

ASUS_I006D:/sdcard/Download # touch /system/bin/testFile_123456789
ASUS_I006D:/sdcard/Download # ls -l /system/bin/testFile_123456789 -rw-r--r-- 1 root root 0 2023-06-07 07:57 /system/bin/testFile_123456789
ASUS_I006D:/sdcard/Download #

ASUS_I006D:/sdcard/Download # mount | grep "/system/bin "
tmpfs on /system/bin type tmpfs (rw,seclabel,relatime,size=3700224k,nr_inodes=925056)
ASUS_I006D:/sdcard/Download #

But It's mounted to tmpfs so all changes to /system/bin will be lost after the next reboot

regards

Bernd