yashsingh1/xdaforums huggingface dataset:
[Magisk] Homeboy76:
magisk-files/notes.md at canary · topjohnwu/magisk-files

Magisk File Host. Contribute to topjohnwu/magisk-files development by creating an account on GitHub.

github.com
[Magisk] curiousrom:
Thanks but that won't fix @pndwal's bad habit of not including a link to the source when quoting changelogs. ;)

Edit: Maybe this one is better: https://github.com/topjohnwu/magisk-files/tree/canary

***
[Magisk] zgfg:
The changelog is always visible in the app (ofc, you must be on Canary channel for Canary updates)

Otherwise, everything, incl. the Changelog is on Github, take the link from the Magisk app to explore
[Magisk] curiousrom:
I stick to the stable channel @ the present but Canary info may be interesting.

Of course but if one goes to a page to copy a changelog then how difficult is it to also copy the URL?

Sorry but lack of attribution and/or link to source is a pet peeve of mine.

***
[Magisk] Homeboy76:
If you press View Code or Go to file -> notes.md on the link you posted you go to the link I posted. :)
[Magisk] pndwal:
I have taken time to respond to your opinion at least twice now, CLEARLY EXPLAINING my reasoning / method, INCLUDING source for John's current material / releases / notes.

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84312597

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84817221

You have not once done me same courtesy, or even acknowledged responses... You just keep repeating 'You forgot..." ☹️

Should I keep saying "No I didn't"? ... or keep responding when you don't? 🙄

... I've told you I didn't forget... Whether or not it's a 'bad habit' is purely subjective, especially if the reasons are not considered.

To be clear, when I've quoted from other sources, or old postings from John's Twitter and GitHub pages, I HAVE been at pains to cite source pages.

I have also explained that the generic link to canary/notes.md is not static (it won't show notes for build referenced if link is used after a later Canary release). This is another reason not to include it.

Of course, I could go to the trouble of locating the static link to a particular Canary build file, but why, when it will seldom be needed (and anyone needing it retrospectively will also likely need to understand how to locate all the files for that build). See below for repository for Canary builds.

For those here who are unfamiliar with John Wu's channels for CURRENT documentation / files / comments, I have happily supplied this generic information when asked, and noted changes when these occur.

For instance, I included this in my reply to you (link above):

FOR CANARY USERS WANTING TO ACCESS BUILD FILES:

I hope repeating this particular information regarding repository for debug Canary build files will help other debug (Canary) build users locate both current and old debug build files and information.

Nb. User must select Canary branch in John Wu's /magisk-files repository, then (for older builds at least) the commit history (clock) button, then a commit selected by date, then Browse files, then either View code or Go to file (from menu), then select a file to view or download. PW
[Magisk] Tanvir Rezwan:
Using magisk 22.1 (22100) in

Sony xz premium g8142.

everything was ok but suddnly

riru lasposed got error *Sepolicy not loaded properly

Also *safety net check got error

Riru v25.4.2

Lsposed v1. 3.5
[Magisk] pndwal:
This fix may help with your issue, and is already merged in Canary release:

- [MagiskPolicy] Remove unnecessary sepolicy rules

Fix for this is merged too:

- [App] Update snet extension. This fixes SafetyNet API errors.

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84846949

If you don't wish to switch to debug (Canary) release, next public (Stable / Beta) release will include fixes, and may be imminent.

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84847033 PW
[Magisk] BobbyHoggatt:
Alright Im new to XDA but not new to rooting. I'm hoping to get some answers with a glitch I have found. I have passed safety net no problems (I am rocking a oneplus 8 pro and its been rooted since I got it!) Until now! Magisk say api error , and other safety-net apps fail too! The weird thing is Netflix and my baking apps work no problems so I'm not to worried but it bugs the crap out of me! The troubleshooting steps I took was, I factory reset and rerooted (after hours of trying to find out what change) I went back to stock ROM and rerooted the phone and still cannot figure it out! I went ahead and put lineage 18.1 back on and hope I can find some answers later. Maybe I can get someone to check there safety net through magisk and see if its a me problem or a magisk problem. Thanks guys!
[Magisk] Lughnasadh:
Just read the previous page or two. Everything has been explained.
[Magisk] BobbyHoggatt:
Thanks pndwal I got my safety net up and going!
[Magisk] BobbyHoggatt:
I
[Magisk] pndwal:
No worries, but its really thanks to John Wu's tireless attention to current issues that we have this fix!... And I'm not sure you quoted relevant post. 😉 PW
[Magisk] pndwal:
Mate, that's not the correct apk! Its for hidden Magisk App only, and not generally needed alone.

Latest Canary build should be obtained from Magisk Canary link on Magisk main page:

https://github.com/topjohnwu/Magisk#downloads

File needed is app-debug.apk 👍 PW
[Magisk] Tanvir Rezwan:
Thank you

Thank you

But in first when i started using magisk myb v22, in option there was canary beta stable.

But now only have beta

Is there any link to download canary apk in my sony xz premium?
[Magisk] zgfg:
In the Stable and Beta builds there is no option for Canary

To have Stable, Beta and Canary Update channel options, stay in Canary app
[Magisk] pndwal:
Yep, that's the generic link that's good for most. 👍

As I've mentioned though, it's not static (always points to latest), which is partly why I don't cite it for specific build notes.

Static link for latest FWIW is https://github.com/topjohnwu/magisk-files/blob/ea57c9b33b3a6ce2e0e65ce4c33dfb1c01552fcb/notes.md 🤠 PW
[Magisk] curiousrom:
Re: Linking to the Source of the Changelogs

Bad reasons.

If one goes to a page to copy a changelog then how difficult is it to also copy the URL?

Sorry but lack of attribution and/or link to source is a pet peeve of mine.

***

BTW are those huge headings really necessary? And they get quoted in the right column in a PC browser if Liked as seen in the attachment.

Maybe just simply bolding them would be enough. For example:

For example:

FYI from https://github.com/topjohnwu/magisk-files/tree/canary > notes.md @ the present:

Latest Debug (Canary)

Changelog and Release Notes:

Magisk (f49966d8) (22103)

***

This link goes to a page that besides giving the user a chance to explore de source includes a download link.

And if there is a new Canary release, that page is automatically updated.

Win-win-win. ;)

***
[Magisk] pndwal:
Further to @zgfg's comment, see post above yours:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84852149 👍 PW
[Magisk] Lord Sithek:
Actually SafteyNet was passing all the time... It's just Magisk-side issue
[Magisk] midgo12:
Flashed this...

Latest De Bug Canary​

Changelog and Release Notes:​

Magisk (f49966d8) (22103)​

Still have the API error,,,

Oneplus 7pro on OOS10.3.8...
[Magisk] pndwal:
At least you acknowledged my response for once... but not sure you understood / read it carefully.

I go to generic Canary notes.md page, with non-static link (read 'if I cite that URL and anyone checks it after future Canary releases, it will NOT show the relevant release notes').

I could go through a few more steps to reach the static (unique) URL each time and get link, but really feel it's more useful for users to appraise themselves of / use the links for John's current files / info.

More pet peeves? I'm trying to help people with Magisk! 😮

I haven't altered the fonts copied from https://github.com/topjohnwu/magisk-files/blob/canary/notes.md at all, and when I type, heading lines at top match pasted text.

Besides, I like John's formatting, otherwise I'd 'paste as plain text'!

Wouldn't know; I do all this from a mobile, often from a rooftop in the bright Sydney sun... Copy, paste, add a description and boom... It's up, looks good, and party time for Canary users watching!

Just checked, and can't bold with John's Heading text formatting... Guess I could change text type to normal, then reduce and bold it...

Man you want me to work hard...

Nah, that's just messy... It'll still be confusing when citation links release notes for a completely different build...

Tell you what: I'll meet you half way (since you at least responded / discussed it this time):

I'll keep John's

Attention Grabbing​

headings, but I'll locate unique static URL and cite that for Canary / other GitHub documentation / files etc. in future. (Might have to come down from a roof.) 😛

Win-win? 🥳​

Do I have to cite threads for John's current Twitter comments also? PW
[Magisk] pndwal:
If Magisk App actually shows 'Installed f49966d8 (22103)' under Magisk (not just under App), both basicIntegrity and ctsProfile are failing, and SafetyNet is really NOT working (ie, showing 'FAIL' in external SafetyNet checking apps), you may actually have this known issue:

https://github.com/topjohnwu/Magisk/issues/4231

If otherwise, please give more information. PW

Edit: issue closed minutes ago. May go nowhere now.
[Magisk] duvuao:
Any ideas on why isn't the F-Droid distributed Magisk App 22.1 working?

It fails install with "Unable to extract files".

Environment:

- ASUS ZenFone Max Pro M2

- Android 10 (stock beta)

- Magisk App 22.1 (F-Droid)

Got it to work by downloading from Magisk itself and reinstalling the APK.
[Magisk] midgo12:
Here are screen shots of the app with 22103 installed.

Any ideas...
[Magisk] zgfg:
The idea is very sumple - commented since yesterday several times.

To get rid of SN API error, you need Magisk app Canary 22103 (not 22100 as your screenshot shows)
[Magisk] pndwal:
Just to be clear (as mentioned already), seems while you have flashed Magisk 22103, you haven't updated Magisk App.

As per Changelog, snet extension update is an App fix, as opposed to a fix in the Magic Mask itself.

As a general rule, App should be the same version or newer than Magisk itself to maintain compatibility.

Recommended Patching / Fastboot flashing Image, and Direct Install methods ensure this, but legacy Custom Recovery zip Installation requires attention to this detail.

If a Magisk App is installed before flashing zip, it's probably best to check it is up to date / updated first from .apk package. Otherwise, as official Istallation Instruction page says:

👍 PW
[Magisk] martyfender:
If i'm not mistaken, F-Droid is not an official source for Magisk.

https://github.com/topjohnwu/Magisk/releases/tag/v22.1
[Magisk] loshabih:
I've strange thing here with app root detection , below steps i followed :

1- TWRP factory reset

2- wipe data and storage in twrp (where you type yes)

3- install this app https://play.google.com/store/apps/details?id=ae.damanhealth.daman&hl=en&gl=US

4- app works fine

5- install magisk app

6- app detect root despite i didn't flash magisk.zip

7- remove magisk app and the app started to work again.

8- i flashed magisk.zip

9- app didn't work and it detect root

10- I tried to hide it from magisk hide, change magisk app name

still this app detect root, i don't know if the app detect root from boot partition or from where
[Magisk] pndwal:
Please try this:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84743225

Much more here also:

https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot 🤠 PW
[Magisk] midgo12:
Thanks for this info.

I have uninstalled the old app and reflashed Magisk 22103 again and the safety net API has now passed.

Thanks again for the help given...
[Magisk] Justinmbenedict1:
I have a OnePlus 7t pro McLaren (T-Mobile HD1925). I am using newest magisk app 22.1 to patch my boot.img pulled using dd. I am having a hard time finding the usual checkbox for preserve dm-verity. Can someone tell me if this feature has been removed or is for some reason not available on my device. I really want to be able to just modify my device as much as i want without a "soft brick" into fastboot mode. There is no working TWRP for the device. Is it possible to make a magisk module that overlays an entire "systemless" system image that i can run and edit at free will without tripping some sort of verity that causes a Boot loop?

just to clarify... Device is fully rooted with magisk. Issue is.. I cant hardly do anything with root! Everything that i used to do in older versions of Android , if you do those cool types of tricks and mods now you get a bootloop! Everything has to be done as a magisk module. How do i make my device less secure lol.
[Magisk] zgfg:
That checkbox is no more present in Magisk app
[Magisk] BillGoss:
Maybe it's time to bite the bullet and learn about Magisk modules and make your own - it's not that difficult. See https://topjohnwu.github.io/Magisk/guides.html
[Magisk] J.Michael:
How are you pulling boot.img using dd? If you are rooted because you have installed Magisk into the boot image, you are pulling a copy of the patched boot image. I've read that it is safe to patch a patched image, but why? Why not use the image you patched when you originally installed Magisk?

If the things you want to do involve fiddling with files in /system, you only need as much module as a tree under /data/adb/modules. If you screw it up, you can boot to Safe Mode (an Android concept), then on the next boot Magisk will come up with all modules disabled, giving you a chance to fix your "module", or disable it more permanently.
[Magisk] pndwal:
Should still show on supported legacy devices:

www.twitter.com/topjohnwu/status/1297833910320021504

Commit: https://github.com/topjohnwu/Magisk/commit/e437ffdbae065b5a08456412a8e036c191a3903e

Interestingly, John HAS overlayed a stock system with an entire custom ROM as Proof of Concept for a projected Universal MultiROM (Magisk powered custom ROM)!

Unfortunately, this ambitious project ground to a halt due to lack of time. 🙁

The details (and potential) are very interesting however:

https://xdaforums.com/t/magisk-the-magic-mask-for-android.3473445/post-69226527

https://xdaforums.com/t/magisk-the-magic-mask-for-android.3473445/post-70155585

https://xdaforums.com/t/magisk-the-magic-mask-for-android.3473445/post-70363391

https://xdaforums.com/t/magisk-the-magic-mask-for-android.3473445/post-70897029

Systemless Solutions

Magic Mount is the way to do this systemlessly using Magisk. It's essentially what Magisk modules do to load:

https://topjohnwu.github.io/Magisk/details.html#magic-mount

Root Directory Overlay System:

https://topjohnwu.github.io/Magisk/guides.html#root-directory-overlay-system

Nb. Systemless options have advantages over solutions that alter system. Eg:

1) Ease of recovering from systemless mod failure causing boot issues. There are several methods to prevent these 'system overlays' from being applied, hence allowing system to boot normally.

2) Only Boot and/or Recovery partitions need restoring to take OTA updates (because actual system partition is unaltered). Also, as modules / Magisk settings are stored in /data partition, after flashing Magisk patched images again the mods / settings are restored.

Shared Blocks and other Difficulties with System read write

www.twitter.com/topjohnwu/status/1259039809361739776

Universally Mount System read write

Are you adventurous / maverick / a Power User? - If answer is 'no' to any of the above, I recommend you ignore the following, which may be fraught...

ONLY if 'yes', here you go:

Since most stock ROMs are locked to read only due to new Shared Blocks (incl. Super partition devices) implementation, it may be of interest to many 'Power Users' here that a mod has been developed that can 'Universally Mount System read write for Android 10+ ROM w/ SUPER or NO_SUPER'!

It does this by dumping existing super OR system / product / vendor partitions, extracting embedded read-only partitions, then flashing images back to device as read-write partition(s).

Description:

A script for all Android power users that wish to make their read-only Android 10+ system read-write-able again to remove bloatware and make more thorough customizations to their device.

https://xdaforums.com/t/script-android-10-universal-mount-system-read-write-super-no_super.4247311/

See also John Wu's initial comments on EXT4_FEATURE_RO_COMPAT_SHARED_BLOCKS, ext4 dedup filesystems:

www.twitter.com/topjohnwu/status/1170404631865778177 😏 PW
[Magisk] exillity:
Hello!

How to revert back from canary version to the stable one? I just can't install stable version again: it says "app not installed" after I try to install the release version.
[Magisk] pndwal:
Yup, most systems will refuse to load an app's apk package if a newer one is already installed.

Since latest stable Magisk App is actually a version DOWNGRADE, you'll likely simply need to uninstall newer (Canary) App first.

The Magisk-22.1(22100).apk package will be in your Download path (Magisk Settings), probably [storage]/Download Folder, from your first attempt. Tip: sorting by Modification time will bring it to the top of the list.

Nb. Settings / modules will survive this, as they are stored in /data/adb, but do check MagiskHide remains toggled on in settings before and after doing Direct Install Magisk downgrade.

Nb.2. Update Channel may be set to Beta by default in public release App.

In short, just uninstalling Canary App before installing Stable App should work. 🤠 PW
[Magisk] zgfg:
Uninstall Canary Magisk app, and install Stable.

Be aware, Safety Net will fail you in Stable with API error

This way you will only downgrade from Canary Magisk app 22103 to Stable 22100.

If you also want to downgrade Magisk, you will need to patch your stock boot/recovery img from the Stable Magisk app once you downgrade the Magisk app
[Magisk] pndwal:
Direct Install to downgrade Magisk works for me. I think only the App refuses to load with newer version installed. PW
[Magisk] zgfg:
Did you check Magisk target version (you can try also patching)?
[Magisk] lundakj:
Hi all,

I am little lost, may I please some advice? On my old, but managed Onelus3T magisk stop working. No visible reason. No update, or something. I am abble to run/update manager, but magisk and all childs not.

So I try to boot in recovery, and install/flash app file renamed to zip. (22.1). Install seems ok, but after reboot no change, magisk not working.

I also read new install guide, so I download latest FW for my phone, extract boot.img, and patch it. But flashing this is really mine last resort.

Any other way left to ty? Maybe unistall/install or something?

Someone with simmiliar problem?

Only manage is wornig from this 5 magisk icons:

In manager seems magisk as N/A:
[Magisk] hackwerk:
As I wrote in another thread;

I have an A3 EU with stock unrooted V12.0.5.0.RFQEUXM (security update 5th of march 2021).

Magisk (22.0) patched img is making my phone not bootable.

It gets stuck in Recovery telling me something like "Can't load Andoid system. Your data might be corrupted." and to Retry (not working) or Factory Reset (never!).

Same happens when I myself patch the stock img with Magisk 22.1 and flash that to my phone (boot_a).

What is happening, and how can we fix this and use Magisk (22.1)?!

Any ideas why I cannot use Magisk anymore?! Is it the A/B stuff? I dont get that at all (switch or put it on the active (A) or?).

Used to use Magisk all the time without any problems...
[Magisk] zgfg:
You can simply check is it A/B or not (btw, documented on Magisk Github):

getprop ro.build.ab_update

True means yes, otherwise no

Stock img - what do you mean, (stock) boot.img or recovery.img?
[Magisk] hackwerk:
It is A/B (my Mi A3) and I know that. I just dont understand it.

Active was A so I flashed it to A. Or do I have to do switches etc?

Yes boot img. I dont have or saw or used recovery.img for my phone.
[Magisk] WillyRy:
Man, who knew Dave & Buster's were security experts! Root detected with magisk hide!

Op 7 pro, lsposed, safety net pass, Gpay & ADT pulse passes...
[Magisk] hypern0va:
Hello everyone, I just discovered a second app among those installed on my phone which are crashing if Magisk Hide is on for them, while they work perfectly ok when I turn it off. I don't remember this happening before the last update, is it a known issue?

The just discovered app is my main banking one - which gets mad when it detects root - so it's a pretty big problem for me atm. I'm on LOS 17.1 btw (Android 10).

Also I'm sorry if this has already been discussed, I'm on my phone and gave a quick look at the latest thread pages but found nothing. Thanks.
[Magisk] HippoMan:
What is your banking app? Some banks put extra checks into their apps which go beyond standard SafetyNet checking. If your bank has done that, it might be impossible for Magisk to hide root from the banking app.

The bank that I use, Chase, has this characteristic, and I cannot hide root from the Chase app. Some people have reported this with certain other banking apps, as well.
[Magisk] hypern0va:
It's definitely not the apps doing in-depth checks as the same apps (with the same app versions) did work before.

Anyway, I got some updates: interaction between Magisk and Webview Manager seems to be the problem. I installed the latter lately so this, and not the Magisk update, could be what introduced the change.

I noticed that both of the apps which are giving me problems produce logs before crashing reporting the lack of the Chromium Webview. In fact, I currently only have the Bromite Webview installed.

Anyway, I'd definitely not say that Magisk is completely innocent since disabling Magisk Hide make the apps work again, even in lack of the Chromium Webview.

I'll report on eventual updates for possible readers facing my same problem, in the meantime suggestions are well accepted.
[Magisk] CounterC:
I got this error since the last version. Anyone has an idea?
[Magisk] HippoMan:
See the recent discussion, above, espcially this post:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84846949

... and note this, within that post: "[App] Update snet extension. This fixes SafetyNet API errors."

Magisk incorrectly shows SafetyNet failure when it is actually passing. This fix in the latest canary version corrects this error.
[Magisk] CounterC:
Thanks for the fix