yashsingh1/xdaforums huggingface dataset:
[Magisk] topjohnwu:
Has anyone of you waited a little further after booting up?

You might not have root immediately after a reboot. After a while it will be started.

I see a lot of people complaining. Non of you have provided a single log......

For the busybox thing, it detects whether ANY busybox is installed. If your rom has busybox box included, it will show as "enabled"

You cannout un-enable busybox on it. I think I'll need to change the detection method in MagiskManager to prevent confusion.

Edit: Magisk Manager v4.3.1 is now live, fixed the above mentioned issue
[Magisk] Didgeridoohan:
To everyone having issues with v12:

Did you try clean flashing Magisk?

At the least, try flashing your stock boot image, then any custom kernel and last Magisk zip.

If that doesn't help, try flashing the uninstaller and start over. If it doesn't work properly on the first boot, try rebooting a couple of times.

If you still have issues, just saying "fix v12, it doesn't work" without any other information and logs (Magisk log, logcat, etc), is completely and utterly useless!
[Magisk] Tkbf:
Update new version of Magisk Manager through Play store, followed by download and install v12 within the new manager, but end with an "installaion error!" message.

However reboot to TWRP and flash v12 manually resolve the issue.

Everything is working as supposed now, thanks.

ASUS Zenfone 3 deluxe ZS570KL.
[Magisk] Clandaries:
I have a question, is it possible to root the Galaxy S7 Edge /Exynos) without tripping Knox?

Thank you
[Magisk] Artim_96:
No
[Magisk] GuwopMontana:
When I first installed v 12 I lost my root . I had to install 11.6 then install 12 again to regain root

UPDATE: Randomly lost root AGAIN, reinstalled 11.6 for now.

Moto G 2015 , Android 5.1.1 Stock
[Magisk] turbo1781:
Everything ok here
[Magisk] BustedFly:
Working on S7 edge with Superman Rom 2.3 without Problems
[Magisk] jugoslavpetrovic:
Im new to magisk, so pls dont go hard on me, yet, cuz I didnt read all thousand+ pages here.

Im trying to figure out but seems I need a guide to point me to the right direction.

Im on stock based rom which is not rooted but I rooted it with cf supersu. I also flashed and installed latest magisk, but not magisksu. What do I need to do to get android pay work?

Nexus5X, PixelRom, franco kernel…
[Magisk] Genericxx:
I'm curious if there will be any trouble with Banking Apps and kinda sort of, since Sepolicy live patch has been moved with the latest Magisk V12. Anyone checked latest RootBeer for SELinux Experimental Flag?
[Magisk] tamer7:
Magisk v12 working on Samsung Note 3 hlte (N9005) running Phronesis Note7 port v5.2 (MM 6.0.1, kernel 3.4.113 Phantom v1.2d final), and should be working on all other Note7 ports running Idle / lss / Phantom kernels, thanks to [MENTION=4470081]topjohnwu[/MENTION] for accepting my proposed patch for this support to be possible in v12.

Also thanks again topjohnwu for improved Samsung support. Indeed now my boot time is much shorter in duration (back to near-stock boot-up speed).

---

for those with busybox problems (like unable to keep busybox disabled), please check first if your ROM ships with its own busybox binary (very possible), in which case you need to remove busybox with Busybox cleaner flashable zip from here. "Rootbeer sample" app from play store should not be able to find busybox.

Then, install magisk and test again.

---------- Post added at 08:14 AM ---------- Previous post was at 08:10 AM ----------

Indeed, with v12, and latest rootbeer, it detects SELinux Flag Enabled (Experimental), but otherwise says "Not Rooted" because everything else checks green.

Now my banking app (S-pushtan) doesn't work.
[Magisk] frrancuz.:
[MENTION=5946138]tamer7[/MENTION]

Magisk11.6 mod - PoGO works well

Magisk 12 - PoGO does not work

MagMa + phantom 1.2e
[Magisk] Genericxx:
I was afraid of that. I am still using a Snapshot of Magisk V12 (Magisk-v12-170322) and S-PushTAN still works. Later snapshot versions already have that Sepolicy stuff moved and doesn't work anymore. So i'm either staying at an outdated snapshot or drop Magisk completely and use lineageos-SU with iSu again, which is working but not that comfortable.
[Magisk] kopitalk:
[MENTION=5946138]tamer7[/MENTION] in rootbeer app I used to pass the "Test Keys" flag with Magisk v11.6, but now it's red in v12. Do you know why? I'm on LineageOS 14.1 unofficial btw.
[Magisk] AntholifeV2:
Version 12 seems to root the phone randomly ... indeed magisk does not detect the root once on 2; In addition I do not pass the safety net unlike version 11.6..

Envoyé de mon SM-G928F en utilisant Tapatalk
[Magisk] tamer7:
/**
* Release-Keys and Test-Keys has to do with how the kernel is signed when it is compiled.
* Test-Keys means it was signed with a custom key generated by a third-party developer.
* @return true if signed with Test-keys
*/

from the code of rootbeer
[Magisk] kopitalk:
I'm aware of that; I used to edit my build.prop to change from test to release-keys in v11.1 and previous, but in v11.6 I was surprised that I didn't have to do that and I thought it was automatically masked by magisk.

Anyway thanks for responding.
[Magisk] ghbuur:
i usually don't play pogo but I tested on v12 and it works. even good for enterprise (business mail) works since v11.6, which is stunning. safetynet green of course.

s7e, superstock, updated to v12, rebooted, enabled core only, rebooted again and everything is fine...
[Magisk] newbreedsoftware:
The skinny:

I was running MOAR with Sickness v2 kernel on my Sprint Note 5 (SM-920P, I think?). I read a few posts on here that said if you are running a custom rom, I could just full unroot via SuperSU and then flash Magisk via TWRP. That's exactly what I did, making sure to flash SuperSU BEFORE Magisk and mentioned in the OP..

The issue:

Device would get to setup screen and then bootloop

Troubleshooting steps taken:

Wipe cache partition

factory reset

full reset

stock rom flash via odin

'Home' and 'Emergency' flash at Samsung Experience kiosk in Best Buy. Emergency flash failed with an error involving 'PIT?", the rep pulled the phone away before I could read the full error.

Possible resolution?

I had a similar issue with an LG G Pad (v410) and I resolved it by re-partitioning the storage via ADB. To do this I would need a screenshot of a stock partition list If I am on the wrong path please let me know, I am HOPING I can get it fixed on my own instead of sending it into Samsung and being SOL for 7-10 business days. Any ideas/suggestions would be much appreciated!
[Magisk] tamer7:
it's gone from the /magisk/.core/magiskhide/enable script in v12

but you can readd it
[Magisk] Riku Azhurlar:
So on my oneplus3 when I use anything but magisik 11/11.1 it breaks my wifi....... Any ideas?
[Magisk] jhedfors:
Try placing the attached file in this directory:

/magisk/.core/post-fs-data.d

/data/magisk/resetprop -n ro.build.selinux 0
[Magisk] tamer7:
to pass the selinux flag check in rootbeer sample, i had to add the following lines to the enable script in /magisk/.core/magiskhide/enable

BUILDSELINUX=`getprop ro.build.selinux`

[ ! -z "$BUILDSELINUX" -a "$BUILDSELINUX" != "0" ] && \
log_print "`$BINPATH/resetprop -v -n ro.build.selinux 0`"

but my banking app s-pushtan still won't work
[Magisk] Genericxx:
Dialer App checked in Magiskhide?
[Magisk] tamer7:
I didn't need to do that in Magisk 11.6, because I was (and still am) sticking to the previous S-pushtan version 1.0.11
[Magisk] Didgeridoohan:
Better to use a script (like the one [MENTION=2091002]jhedfors[/MENTION] posted above) or a module to do this. That way you won't have to edit the enable script after every update...

Edit: And Magisk Hide no longer hides ro.build props by default. You'll have to change any relevant props yourself, with a script or a module. I have the usual suspects listed in my tips and tricks thread.
[Magisk] psygarden:
Everything working as intended on latest v12 Magisk. Thanks.

Device : Kenzo

ROM : RR 5.8.2, Stock Kernel.
[Magisk] RomikB:
Magisk v12

Samsung Galaxy Note 3 (SM-N9005) Latest Stock 5.0 Android

Safety Net failed (stuck in check).

Safety Net success for stock Samsung kernels was not supported before Magisk v11, is it now supported.

Please fix or add a "known issue" again.
[Magisk] jaybz:
Magisk Hide not working on Moto Z

I have a Moto Z on a modified stock Nougat (7.0) ROM and I've installed Magisk v12 (also previously using 11.6) and rooted with MagiskSU. I can't get Magisk Hide to work, however. I've attached the Magisk log. One thing I noticed was the last line on the log:

MagiskHide: Unable to watch /magisk/.core/magiskhide/hidelist

I browsed to that directory with root and found that the file is missing. I also noticed that the filesystem is mounted as read-only so I could not create the file manually either. I compared this to my other phone which currently has Magisk v12 and working Magisk Hide. The filesystem on my other phone is mounted as read-write and the hidelist file is present and contains the apps I have checked in Magisk Hide. I also noticed that none of the apps I manually check on Magisk Hide stays checked after I close and re-open Magisk Manager. I assume this is because it can't create the hidelist file.

I also installed Pokemon Go and attempted to log in since it is checked on Magisk Hide by default, however, it is giving me a "Failed to log in" error. The error message is the same whether I Magisk Hide is enabled or disabled. Pokemon Go works ok after I flash the Magisk uninstall zip.
[Magisk] RomikB:
And this feature is useless: "Another is faking KNOX to 0x0 if MagiskHide enabled". Because only thing that depend on KNOX bit is KNOX and it still not working.
[Magisk] Didgeridoohan:
If the check never completes, that might be an issue with your Play services. Try force closing them, clearing data and rebooting.

---------- Post added at 10:08 ---------- Previous post was at 10:06 ----------

How about helping the developer and the community by posting some details and at least a Magisk log instead of just another "it doesn't work" post...
[Magisk] creeperlwd:
Safetynet passes on v11.6 but not on v12.0

Moto X Style (clark) RR-N 7.1.1 03/10 build
[Magisk] soder:
OnePlus One with LineageOS beta 0327 and Magisk 12 working great.

OnePlus 3T OOS 4.1.1 (latests update) and Magisk 12 working great.

Got root and passing SafetyNet.

/Söder
[Magisk] RomikB:
Play services cannot be stopped, closed, disabled or data cleared. I can only clear cache but it do nothing. Reboot not help too. If I disable magisk hide Safety Net check goes red. So it possible Magisk issue, not Play Services.

The main point for SafetyNet is - "should it work"? If yes I create an issue on github with logs and other.

Same for KNOX - should it work when KNOX bit faked or no?
[Magisk] mieru:
OnePlus X with latest Validus rom Magisk V12 doesn't works. On start no sim card error and system process stops. Tried to flash with Magisk Manager and manually in the recovery (TWRP).

Edit:

After a clean install of Validus 13.8 (released today) i would able to install Magisk V12 without any errors. So a clean install can solve the problem.
[Magisk] Didgeridoohan:
Start by uploading a Magisk log here.

I've got no clue about KNOX (I wouldn't touch a Samsung device with gloves and forceps). From what I understand though, the new feature should hide a triggered KNOX counter. Have you checked with a KNOX status app if it works?
[Magisk] psychomaniac189:
Got the latest update I tapped install and reboot and nothing happened. Now when I try again I get an error but says on the bottom where the file is stored. Can I just flash that file via TWRP??
[Magisk] adamshumpisxxx:
Nexus 6 / Android 6.0.1 / Build MTC20F

Previous version of Magisk worked flawlessly. Version 12 will not pass SafetyNet with error "CTS profile mismatch". Tried completely removing all traces of Magisk and starting again from scratch. No difference. Is this a known bug and if so is there an ETA for a fix?

Log:
[Magisk] SavageRobot:
Updated to 12 this morning, Magisk, Root & Safety all working fine. However, there are no modules in the download tab anymore. Does this mean that the few that were in there are actually all outdated or do other people have them in there? My current modules still working fine though.
[Magisk] chucky8:
Changelog says outdated modules are now hidden. Can't say anything about functionality though.

Gesendet von meinem Redmi 3S mit Tapatalk
[Magisk] dahawthorne:
Nexus 6, Pure Nexus March 7.1.1 NOF27C, ElementalX kernel 4.18.

Magisk 12 working perfectly, including SafetyNet.
[Magisk] lover:
I used to use systemless SypeSU + Magisk but After v12 i completely removed Super and using MagiskSU but now LiveBoot is not working. I understand in LiveBoot says:

but i wonder if there is a work around it to make it work properly?
[Magisk] Didgeridoohan:
Reload the list (pull down in downloads). You might possibly also have to clear the repo cache in settings.
[Magisk] dahawthorne:
The same with me. It looked as if I temporarily lost root, since QuickBoot also didn't work. However, after a manual reboot (via the power button) it all works fine. If there is a temporary loss of root, as I suspect, that might explain why Magisk was unable to issue the reboot command.

Edit: Just installed it on my Nexus 5 and it rebooted fine. Maybe a pecularity of the Nexus 6 or a combination of variables.
[Magisk] Ikzy:
Xperia X compact with nougat and genesis kernel gets stuck on boot animation with Magisk 12.0.

Last magisk log contained:

** Magisk post-fs mode running...

That's it. Magisk 11.6 works great and passes SN
[Magisk] Didgeridoohan:
As far as I know, not currently. [MENTION=4470081]topjohnwu[/MENTION] made a module a long time ago for using LiveBoot with Magisk and it's superuser (then a version of phh's superuser). It does not work anymore... But, that might mean it is possible to get it working again, but it takes some work from someone knowledgeable.

---------- Post added at 11:18 ---------- Previous post was at 11:15 ----------

Have you tried toggling hide off and on and rebooting (maybe rebooting a couple of times even). I haven't updated to v12 on my Nexus 6 yet, but it's working beautifully on my OnePlus 3T.
[Magisk] RomikB:
Magisk log have nothing intresting:

** Magisk post-fs mode running...
** Magisk post-fs-data mode running...
* Running post-fs-data.d
* Loading core props
* Preparing modules
* Stage 1: Mount system and vendor mirrors
* Stage 2: Mount dummy skeletons
* Stage 3: Mount module items
* Stage 4: Execute module scripts
* Stage 5: Mount mirrored items back to dummy
** Magisk late_start service mode running...
* Linking binaries to /sbin
* Starting MagiskSU
* Running service.d
* Starting MagiskHide
MagiskHide: Moving and re-linking /sbin binaries
MagiskHide: Removing dangerous read-only system props
MagiskHide: resetprop by nkk71 & topjohnwu
Initializing...
Modify data structure: 'ro.boot.warranty_bit'='0'
Existing property: 'ro.boot.warranty_bit'='1'
Recheck property: 'ro.boot.warranty_bit'='0'
Done!
MagiskHide: resetprop by nkk71 & topjohnwu
Initializing...
Modify data structure: 'ro.warranty_bit'='0'
Existing property: 'ro.warranty_bit'='1'
Recheck property: 'ro.warranty_bit'='0'
Done!
MagiskHide: Killing com.google.android.gms.unstable
MagiskHide: Starting MagiskHide daemon
MagiskHide: Update process/package list:
MagiskHide: [com.google.android.gms.unstable]
Zygote(0) ns=ѓ

MagiskHide: com.google.android.gms.unstable(PID=3621 ns=[0 3621 10016 com.google.android.gms.unstable service com.google.android.gms/.droidguard.DroidGuardService]
)
MagiskHide: Stopping MagiskHide daemon
MagiskHide: Killing com.google.android.gms.unstable
MagiskHide: Removing dangerous read-only system props
MagiskHide: Killing com.google.android.gms.unstable
MagiskHide: Starting MagiskHide daemon
MagiskHide: Update process/package list:
MagiskHide: [com.google.android.gms.unstable]
Zygote(0) ns=џ
MagiskHide: com.google.android.gms.unstable(PID=8526 ns=[0 8526 10016 com.google.android.gms.unstable service com.google.android.gms/.droidguard.DroidGuardService]
)

It is full stock rom and before magisk safety net was green.

"Phone INFO" aplication shows KNOX status 0x0.
[Magisk] NATO66613:
Updated to magisk 12.0 root Works for 5 sec then it's gone and safely net now fails
[Magisk] Didgeridoohan:
It does actually. It shows that Hide isn't unmounting as it should... Could you try hiding root from a root checker app to see if it can detect root even if added to the Hide list? And post a new log after that... (and a tip is to use pastebin or something similar when posting logs, they can make posts unnecessarily long).

KNOX status 0x0 means KNOX isn't triggered. In other words, it works...

---------- Post added at 11:32 ---------- Previous post was at 11:29 ----------

I'm sorry, but this is just another useless "it doesn't work" post. Details and logs are necessary to help. If it's an issue with loosing root you're talking about, have you tried the suggestion from the official Troubleshooting FAQ in the release thread? Disable busybox in Manager settings if it's enabled?
[Magisk] kopitalk:
I'm using LiveBoot with v12 and it's working just fine with its init.d script workaround.
[Magisk] NATO66613:
I don't see need to insult others

By the way here you go magisk log
[Magisk] NATO66613:
Test app
[Magisk] lover:
What Work around? I uninstall script from LiveBoot and reinstalled but didn't work
[Magisk] jaybz:
Ok looks like I'm answering my own report. I can confirm that the fact that hidelist is missing is what's causing problems for me. I created it manually and put it into magisk.img. I'm now passing Basic Integrity on SafetyNet checks. I'm still failing the CTS profile match but I think that may be my ROM's fault. The problem with the read only mount may also be my ROM's fault. I had problems creating the hidelist file while booted into the OS. I had to boot into TWRP to create the file.
[Magisk] Didgeridoohan:
I'm not trying to insult anyone, but you're making it really hard to help by not giving enough details about your problem. I'm still not sure if it's the losing root issue you're taking about or just SafetyNet failing.

If it's losing root, your log shows you probably didn't take my advice about disabling Busybox.

---------- Post added at 11:43 ---------- Previous post was at 11:43 ----------

And you're using MagiskSU or SuperSU?
[Magisk] jugoslavpetrovic:
Unrooted super and tried to flash 12.0 magisk, but during flash it said there was still some supersu patch so it failed. What can I do now?
[Magisk] :
Can anyone check what's going on in my log? Getting high cpu usage with all cores active after updating to v12, and CTS profile mismatch as well. Games are also detecting root even with Magiskhide. Log attached below.
[Magisk] teddy0209:
Flash your roms boot.img then flash magisk...

---------- Post added at 10:53 AM ---------- Previous post was at 10:49 AM ----------

Try reenabling magiskhide...
[Magisk] jugoslavpetrovic:
Tried that as well, the same error. I will try earlier magisk to see if it helps. Thanks.
[Magisk] culiacanazo:
Here's this for those who ask "is such and such working on this or that setup?"

You're welcome ;)
[Magisk] :
Still not working, guess I'll have to wait for OP to check the boot.img
[Magisk] RomikB:
I install "Root Checker" application. There is no differences between checked or unchecked this application in magisk hide setting (root request window appear).

log: https://pastebin.com/CE1A6YXK

Setting KNOX status 0x0 worked but as I say before is useless.
[Magisk] teddy0209:
Then maybe you have a prepatched boot.img...
[Magisk] Didgeridoohan:
Same thing. Hide isn't unmounting as it should... I think it's time to open that GitHub issue you were talking about, with all the relevant details, logs and a copy of your boot image.

Not for users that want to use any service that depends on KNOX not being triggered...
[Magisk] culiacanazo:
You can say that again! :)
[Magisk] jugoslavpetrovic:
Nope, its stock based not rooted rom.
[Magisk] Didgeridoohan:
Not for users that want to use any service that depends on KNOX not being triggered...

I'm sorry... I'm so, so sorry... :p
[Magisk] Alex_K_Black:
Install RR 5.8.2, update Magisk to 12.0, reboot and haven`t SafetyNet. What can I do to fix?
[Magisk] kopitalk:
Make sure your init.d is working and liveboot has an entry in init.d folder, i.e. "0000liveboot".

MagiskSU of course.
[Magisk] Didgeridoohan:
Awesome! Thank's for the information.
[Magisk] teddy0209:
Then the patch should have been removed after restoring your boot.img.

Edit: or maybe you restored a backup boot.img which is still patched?
[Magisk] oxymarrow:
Hi, did I made something wrong? I installed the magisk12.0.zip through the recovery and now my phone boots only to the recovery mode.
[Magisk] Didgeridoohan:
It's impossible to know since we're missing some vital information. These could include (but are not limited to), device, ROM, what recovery you're using, and so on. A recovery log from the installation would be really useful.
[Magisk] oxymarrow:
Oh sorry, it's a Zenfone 2 with CleanStockMM and with twrp 3.10, I'll try to get the recovery log.
[Magisk] jugoslavpetrovic:
Nope, I extracted boot.img from zip. Im kinda frustrated right now, lol.
[Magisk] SavageRobot:
That's the ticket thanks, I was going to clear cache anyway, hindsight probably should have done that before asking. :good:
[Magisk] Didgeridoohan:
It might be an Asus issue. This is from the Troubleshooting FAQ in the release thread:
[Magisk] oxymarrow:
Thanks, fixed by downloading the rom I use and flashed the boot.img from it.
[Magisk] NATO66613:
Magisk su and when roots is gone magisk app don't show any log or debug option it's looks like I don't got magisk installed sorry but right now I can't replicate issue. But safety net remains disabled bussy box (I am using magisk core mode) same results
[Magisk] Didgeridoohan:
Enabling Core Mode still keeps Magisk built-in Busybox working. Do you have the Busybox toggle enabled or disabled?
[Magisk] SavageRobot:
Pretty much same as me, all working crDroid 7.1.1 only on G4

I had update in Play Store too for app and now is 4.3.1, how are you on 5.x?
[Magisk] culiacanazo:
Unofficial
[Magisk] RomikB:
I think Samsung knox software do not use this flag to detect triggered knox, so only third-party software that check only this flag can work.
[Magisk] Didgeridoohan:
Like I said, I don't deal with Samsung so I've no idea... Still. Even if that's true it doesn't sound useless to me. I think the final test is if someone can try Samsung Pay with this new Hide feature.
[Magisk] Alpine-:
V12 all clear on Samsung devices? Any early issues reported?
[Magisk] culiacanazo:
I had it earlier, all good on my setup
[Magisk] kopitalk:
Tested on SM-N9005 Galaxy Note 3 running LineageOS 14.1 Unofficial.
[Magisk] Andi46:
I'm on Lineage OS 14.1 unofficial wth both devices.

my S4 mini works fine - passes every SN check - since 11.6 where i first tried...

my S5 mini doesn't - SU function yes in v12 but SN check fails :(

There's a curious Request timestamp from the '70s at S5 mini in SafetyNet Helper sample while from today in S4 mini
[Magisk] ToHellWithGA:
Attempt 3, Nextbit Robin (ether) on OmniROM, this time with Magisk 12.0. What am I doing wrong?
[Magisk] dahawthorne:
Have you ticked Magisk Hide in Settings? I don't see an answer to this:

https://xdaforums.com/showpost.php?p=71504750&postcount=10475

although I know you've read it because you gave a thanks.
[Magisk] BootloopedMillennials:
Can someone kindly explain how Magisk works with root apps that require init.d?

App in question is DNSCrypt. My ROM doesn't support init.d by default fwiw but there are apps that enable it..
[Magisk] bland.life:
Installed Magisk 12.

Happy to say that the the "Developers Options missing" problem is gone, SEpolicy is shown as Enforcing too.

No crash on webview apps here too.

All is well so far, 3 green ticks too.
[Magisk] NATO66613:
disabled