yashsingh1/xdaforums huggingface dataset:
[Magisk] IronTechmonkey:
I see that your other two posts are in the new threads you created for questions you have about Magisk. FYI, creating a new thread for questions like that will not necessarily attract the most people who know the answers because they will not be searching the threads. This thread here would be a good place to research and ask your question. I couldn't answer it but there are people around who might.
[Magisk] 13Sullo80:
Thx. I did not know what is the best approach. I could not delete this. Sorry for the confusion.
[Magisk] pndwal:
Not a Sammy user, but I know many older Sammy devices had a fastboot mode (eg Galaxy Note 8, Kona)... However it seems many use their own Download (Odin) mode also; perhaps after updates(?)... Newer Sammy never had traditional fastboot mode.

So it could be a driver issue, but if Odin is working, that should work for Magisk. So should renaming Magisk .apk package to .zip and installing via recovery on legacy ramdisk devices at least.

Bit confusing... Did you patch discrete boot.img or whole AP binary?

Recommend you patch complete AP (transfer using ADB pull, NOT MTP), then reboot to download mode, open Odin and flash magisk_patched.tar as AP, together with whatever binaries you have of BL, CP, and HOME_CSC. - I'm guessing you won't have them all on your older device. Nb. If you use CSC instead of HOME_CSC, you'll fully wipe/data.

Nb if you previously had Magisk hidden (Hide the Magisk app), you may find new App simply can't see Magisk due to competing apps; check in device settings, Apps for old hidden app ('settings' or whatever you named it) and uninstall it if found...

Hope this helps... PW
[Magisk] 13Sullo80:
Thx for the note. I never had Magisk on the tablet.

I just flashed boot.img. I also pulled the patched image via MTP vs ADB.

Given this is a custom OS. How do I pull AP BL and CP?

Steps:

1. Pull the patched boot.img via ADB

2. What else should I pull and the command I should use?

3. Flash using ODIN via download mode

Thx

thx for the details. I do not have Magisk installed on the tablet.

I pulled patched boot.img via MTP vs ADB. Will pull using ADB.

I renamed the patched boot.img as boot.img.tar and used ODIN. Looks like that was wrong as well.

I need help to pull the right files from tablet for BL AP and CP. can you please help with the right commands and what to pull using ADB.
[Magisk] pndwal:
I wasn't aware this is custom ROM... 🤪

If you have package with images rather than Samsung binaries I'm guessing these should be fine; Sammy users could give better advice, but I think Odin can flash images... (??)

I believe it should work...

MTP is usually ok for small (image) files AFAIK; large (AP binary etc) files are often corrupted...

I think that's likely... Will it flash as an image?... This could well have been your issue...

No, if traditional zip ROM archive, I think you just patch / flash boot.img as mentioned...

Also, there's no reason you shouldn't rename .apk archive to .zip and flash in TWRP on your legacy ramdisk device... This should work fine up to Android 9 if updates become available. (If updated to A10, Legacy ramdisk devices are converted to 2SI and new patch/flash installation is then recommended)...

If none of this helps, please give custom ROM details... 🙃 PW
[Magisk] J.Michael:
@pndwal Have you ever seen an MTP transfer corrupt a file, or are you just repeating the advice I have seen elsewhere?

I always used Windows Explorer to transfer files. I checked the md5sum at both ends, never saw a mismatch.
[Magisk] J.Michael:
@13Sullo80 If you want to flash a single image file in Odin, I think you should make a tar archive containing that one image file. Renaming is not the way.

The AP, BL, CP, and CSC tar files are the way we've seen Samsung ROMs packaged. You won't find them on the phone.

How did you get this custom ROM? What assortment of files? How did you install it?

Installing a Magisk-patched system should follow the same pattern as the installation of the unpatched system.

Find the forum that deals with the ROM. And the forum that deals with the phone. If you are lucky, there is some overlap.
[Magisk] 13Sullo80:
Thx for the note. I never had Magisk on the tablet.

I just flashed boot.img. I also pulled the patched image via MTP vs ADB.

Given this is a custom OS. How do I pull AP BL and CP?

Steps:

1. Pull the patched boot.img via ADB

2. What else should I pull and the command I should use?

3. Flash using ODIN via download mode

Thx

thx for all the help. I gave up on the custom OS.

Used TWRP to install LineageOS and Magisk. Now the app installs successfully.

Now on to figuring how to configure Magisk to ensure safetyNet passes.
[Magisk] ipdev:
Years ago, I had some corruption issue with MTP and a Kindle Fire 7(?) using MacOS.

Since then I have just used adb to push and pull using Linux, Mac, and Windows.

I might test the MTP connection for a device but, that is about it.

Spoiler content hidden.

Cheers. :cowboy:
[Magisk] ipdev:
@13Sullo80

Not a Sammy guy per say but, I have played with them though the years. 🙃

Most recently I found a SM-580 tablet for my brother a few months ago.

After wiping and updating it.

I unlocked it and used odin to install TWRP.

From there I used TWRP to install an unofficial lineage 19.1 and OpenGApps.

Once booted, I installed the Magisk app and patched the lineage boot image (pulled from the lineage zip file).

Rebooted into recovery (TWRP) and flashed the magisk_patched boot image.

Update Magisk by the direct install option.

When it is time for a ROM update..

- Pull the new boot image and patch it.

- Update rom and flash the new magisk patched boot image in TWRP.

Not sure if this works on newer Samsung or when running a stock Samsung rom.

What do you think @pndwal ?

Cheers. :cowboy:
[Magisk] pndwal:
Yes, I tried to help several (3?) members here who confirmed that various issues disappeared (sometimes corrupted image would flash, sometimes not) after using ADB pull... The first couple of times the members themselves found the fix; I hadn't thought of it...

I only know it's common w/ Sammy's large binaries however; don't recall similar reports for other devices. 😉 PW
[Magisk] ipdev:
Shifting the discussion to this thread.

We will need to know your setup to help more.

Spoiler content hidden.

Cheers. :cowboy:

Edit:

Attach ScreenShots.
[Magisk] 13Sullo80:
My next area of help is safetyNet failure with LineageOS 14.1 ROM

1. Have Magisk setup and hidden

2. Have downloaded UniversalSafetyNet fix and it shows under modules in Magisk

3. YASNAC fails Basic Integrity and CTS checks.

Have reviewed the posts but not able to fix. Is this ROM so old that I cannot get it to pass?
[Magisk] pndwal:
Glad it worked... But what app?

We'll, you didn't I give up on the custom OS... LineageOS is the penultimate, definitive custom OS! 😉 PW
[Magisk] pndwal:
Search in USNF thread for USNF mod from @Displax and install it... Is spoofs a very old fingerprint that should kill two birds; 1) need for fingerprint / security patch date matching in custom and other uncertified ROMs (always in official LOS due to their policy not to alter expected signals), and 2) new Play Integrity MEETS_DEVICE_INTEGRITY failure.

Traditional solution for CTS Profile match in official LOS etc was to configure a passing fingerprint/patch date combination using MHPC module, but this shouldn't be needed w/ @Displax modded USNF... PW
[Magisk] pndwal:
Ahh!

So ..9-1 fixed adb?... (It isn't self-evident). PW
[Magisk] pndwal:
Looks good to me... I'm a bumbling advisor... Only ever owned one (old) Sammy...

Not sure (guessing all the way actually) about newer devices either (especially where patching of other partitions is done and other caveats discussed by John apply), but I think your advice is pretty safe for Android 7 etc. 😛 PW
[Magisk] ipdev:
OT for this thread but..

The update to TWRP 3.6.2 broke adb sideload and partitions formatted with fastboot were not recognized by TWRP, when using newer/current versions of Platform Tools.

The fix (9-1) for adb sideload (using newer builds of Platform Tools) was a revert of a previous commit.

Spoiler content hidden.

The revert fixed adb sideload but broke MTP. 😥

So currently, we have to use older adb/fastboot builds to be compatible with TWRP 3.6.2.

Spoiler content hidden.

Cheers. :cowboy:
[Magisk] pndwal:
mmm.

Pertinent for Sammy users...

... but even if MTP can work partially with errors after bad TWRP install (guess that's what you're saying), it seems that MTP corruption is still likely even w/o TWRP w/ large files... But I guess it's still possible all affected users had TWRP... Just never saw this connection... PW
[Magisk] ipdev:
No connection to anyone/anything.

I only noted it as another example of MTP failing and only with (recovery) TWRP.

The device in question is not a Samsung device.

Rather the one Google is trying hard to forget. 🙃

Once the device is running in system..

I never checked if the unofficial lineage 19.1 build has working MTP.

I got pulled into testing TWRP for the device. 😛

Cheers. :cowboy:
[Magisk] zyhk:
Although people here don't have any interest any more, I succeeded in making the ALSA hardware driver on A12 to read "ro.audio.usb.period_us" property by replacing this property string in a USB related library with "vendor.audio.usb.perio". The ALSA driver on A12 cannot read "ro.audio.*" properties, but can "vendor.audio.*" ones because of SELinux enforcing and its rules.

If you like, try my magisk module audio misc. settings with a USB DAC and popular music streaming apps.
[Magisk] jm1981:
Hello,

I ran recently magisk app on my tablet and it showed me there is a new version.

So I downloaded it :)

I updated magisk app to 25.2 and when I launched it, it crashed with only a small message : [xxxxx] failed to get root access

And app is uninstalled...

Could someone please help me ?
[Magisk] pndwal:
Was previous Magisk App hidden?... Please check in Device settings, Apps for app whatever you named it (default is 'settings') and uninstall it if found... PW
[Magisk] jm1981:
What do you mean by "hidden" ?

I have to check in the settings, in the application list, if I find Magisk, and uninstall it if I find it ?
[Magisk] pndwal:
In Magisk App settings is Hide the Magisk app option. This uninstalls the full app and installs small stub app and it's data is populated with Magisk app binaries to obfuscate it. By default it is renamed simply to 'settings', but user can choose any name...

Experience shows that if App is hidden (user didn't take Restore the Magisk app before updating), update fails to recognise hidden app in 50% of attempts, leaving user with two apps competing for root and access to Magisk core functions...

Did you ever take the Hide the Magisk app option?... PW
[Magisk] jm1981:
Indeed, I think i did hide the app.

So I have to uninstall this stub app and then install again Magisk app ?
[Magisk] 13Sullo80:
I tried but cannot find the post.

Also I have the current GA USNF installed and it does not work
[Magisk] pndwal:
https://xdaforums.com/t/magisk-module-universal-safetynet-fix-2-3-1.4217823/post-87198517

What's GA?... PW
[Magisk] pndwal:
Perhaps... But full app often works fine after simply uninstalling hidden app (or renamed stub)... 😛 PW
[Magisk] rodken:
Never sell yourself short when sharing good/decent advice in a detailed aspect.

-- At least some folks on XDA will express or share further details in context from sometimes reliable sources.

-- Unlike certain users of Social Media channels that are profoundly disconnected when it comes to sharing details.
[Magisk] pndwal:
No-ones paying... but I'll take that as a compliment paid. 😛 PW
[Magisk] CSX321:
Sometimes GA = General Availability (meaning the shipping or production version). If that's the case, I guess they mean the "official" USNF, and not the modded one.
[Magisk] Homeboy76:
Release v2.3.1-MOD · Displax/safetynet-fix

SafetyNet & Play Integrity API workarounds for Magisk - Release v2.3.1-MOD · Displax/safetynet-fix

github.com
[Magisk] pndwal:
Well there's a thought!

www.twitter.com/topjohnwu/status/1555338330530689024

... They couldn't be i-missiles could they?

🚀🚀🚀 🙃 PW
[Magisk] jm1981:
It worked.

Thanks !
[Magisk] zgfg:
Btw, they probably run HMS = Huawei Mobile Services (not GMS)😁
[Magisk] jm1981:
Update :

Now I can open Magisk app without crash.

But when I try to update to 25.2 (from 24.3), it fails : boot image kernel_dtb was patched by old (unsupported) magisk

I don't have an unpatched boot image as asked in the message...

What should I do ?
[Magisk] J.Michael:
@pndwal already explained, sometimes there's a boundary version, direct install cannot cross that boundary.

If this ROM comes with Magisk already installed, you need to contact the distributor, or wait for him to release a version with a later Magisk.

Otherwise, you must have an unpatched version of the ROM -- whatever you started with.

Flash stock system. You will lose Magisk. Make sure system works. Then install the newest Magisk, using instructions for initial installation.

If initial installation involves wiping data, wait until you hear from someone who knows what he's talking about -- there may be a way that avoids losing data.
[Magisk] pndwal:
As mentioned, get unpatched boot image and patch / flash that. (Flashing the whole ROM is optional / not needed.)

Here are latest stock 8.1 ROMs for Mi Pad 4:

https://xiaomifirmwareupdater.com/miui/clover/

Please say if you use custom / other ROM.

Make sure you download ROM matching currently installed and extract boot.img.

There are also other options if you use TWRP... PW
[Magisk] jm1981:
I'm running LineageOS 17.1, available on another xda thread.

And initially I used TWRP for Magisk first install.

It would be easier to flash Magisk 25.2 from TWRP, if it was possible with no risks 🙂
[Magisk] pndwal:
I have 18.1 on Mi Pad 4, but think I'll move to 19.1 from sabar_op soon...

Ok, so you can simply extract boot image from that ROM and patch with Magisk App, then flash w/ fastboot or TWRP... I'd do that...

You can also take Magisk App option Uninstall Magisk, Restore images (no need for Complete uninstall - Magisk config, modules etc can be present) after which custom recovery installation of Magisk as a zip installer should succeed.

Nb. Your issue is the refactoring of magiskinit injection in Magisk 25+ affecting many 2SI devices ... I put info about it here around June 23...

Your device used legacy ramdisk boot method originally, but was converted to 2SI booting w/ update to Android 10... PW
[Magisk] jm1981:
I take boot.img from LineageOS ROM, then I flash it with TWRP.

At that time, I reboot and launch Magisk to proceed to the upgrade ?
[Magisk] zgfg:
If you boot with boot.img not patched by Magisk - you will boot without Magisk and you would not be able to (Direct) update

You can (re)install Magisk through TWRP or you can patch that boot.img and flash through TWRP or Fastboot - for more details please read Magisk Documentation on GitHub, link is in Magisk app

When you next time boot with new Magisk, all your modules should be still there, etc

However, if some of the modules is not compatible with updated Magisk, you could have problems to boot - while still on the old Magisk, disable your suspicious modules to avoid potential bootloop
[Magisk] J.Michael:
Maybe the first question should be, why update Magisk?

If you are determined to upgrade Magisk, you need to get into a state where Magisk is not installed.

If you can do that, and have no version of Magisk manager app installed, then install the latest Magisk manager app apk. Use it to patch the boot image. If you can flash the patched boot image with TWRP, then when you reboot, you should have Magisk.

I don't know why we're talking about patching a boot image and flashing it with TWRP. If you can get to the point where Magisk and all Magisk manager apps are not installed, and you have TWRP, there is an option to take a copy of the Magisk apk, rename it to have extension ".zip", and flash *that* with TWRP. You will have to read a thousand posts to find when that works, but it seems like the easiest thing to try first.
[Magisk] pndwal:
No...

I've outlined this and other option quite clearly, and I've just edited it a little to make it clear what is meant by patching...

Please go back to get options/steps clear in your mind... PW
[Magisk] jm1981:
You're totally right about why updating.

In addition, with pwndal remark on LineageOS 19.1 on clover, I'm seriously thinking about flashing : https://xdaforums.com/t/rom-12-1-clover-lineageos-19-for-xiaomi-mi-pad-4-unofficial.4425319/

:unsure:
[Magisk] pndwal:
Well no he doesn't... Only does if using install as zip from recovery method... Please see my notes...

... Same reason... 🙃 PW
[Magisk] jm1981:
Ok, I got "patching" thing with the install instructions (https://topjohnwu.github.io/Magisk/install.html)

Thanks (y)
[Magisk] Johnassel:
Not sure if I missed something in this huge thread but I'm having issues with latest Magisk (25.2) with LineageOS microg on a Pixel 4a:

Everything is ok with the last version of v24 (24.3). But any version of v25 causes the phone not to boot anymore.

When 25.x is installed it doesn't get past the "Google" splash screen where it stops for a few seconds and reboots, until the "Google" screen appears again with a reboot and so on. Since it doesn't boot Android I can't get a logcat of the crash.

When reverting to 24.x everything is working without problems.

I tried installing 25.x through sideloading and patching + flashing the boot.img directly on the device.

Am I missing anything here?
[Magisk] rodken:
You might want to consider utilizing this method.
[Magisk] Johnassel:
Thank you!

I' not sure if I understand it correctly:

When upgrading to 25.x and it bootloops I simply reflash the patched boot.img again?
[Magisk] pndwal:
Yup... And we've just been discussing this same issue again... here's some options/reason:

👀 PW
[Magisk] Johnassel:
Hmm, does this apply for clean installs, too?

I just tried to get Magisk 25.x running with LOS without 24.x previously installed by flashing the patched boot.img. It still bootloops.

With "normal" LOS (without microg) it works without problems.
[Magisk] pndwal:
Please see post above re. 2SI refactoring...

Only previously patched images are rendered incompatible due to changes with magiskinit, so Direct Install is broken. Patching and flashing an unpatched image should work fine however, and later Direct Installs will work... PW
[Magisk] pndwal:
Clean install should be fine...

If one LOS works and another doesn't, something may be borked in failing LOS ROM...

Are you certain you are patching and flashing the unpatched boot image from that ROM package? PW
[Magisk] pndwal:
No. - You need to load 25.x App (ie. 25.x binaries for installation) and patch unpatched original boot image from package matching current ROM... PW
[Magisk] Johnassel:
Yes. I flashed the unpatched image before the upgrade and in another try I reflashed the whole ROM just to be sure. Magisk App then didn't show any Magisk version installed. Then after flashing the patched image from that ROM (or doing a sideload) bootloops began.
[Magisk] pndwal:
So wiped or formatted data? PW
[Magisk] Johnassel:
Yes, device was completely clean.
[Magisk] pndwal:
So take it you restored original boot image, flashed Magisk from recovery as zip package(?) which failed, wiped data from recovery at this point (factory reset) and flashed ROM again before installing App again, patching boot.img from same ROM and rebooted --> bootloops?... PW
[Magisk] Johnassel:
Yes, that is what I did.

Now since LOS without MicroG is working without problems I assume it is a problem with the ROM itself.
[Magisk] pndwal:
Seems so if you're sure you have boot.img matching that ROM (eg. didn't muddle these on PC)... I did suspect borked Magisk configuration .db / files in /data/adb but wipes would have sorted that...

One other possibility especially if a non-official LOS (but slim chance) is that maintaining dev is using a non LOS standard kernel... Custom kernels requiring AVB stripping using Magisk are also failing post 25.0 due to refactoring... PW
[Magisk] J.Michael:
What is MicroG? A Magisk module? An Android app?

Why isn't anyone suggesting that there is something wrong with MicroG? (There, I just did.)
[Magisk] pndwal:
MicroG implementation is gms core components + spoofing to allow use of some apps etc requiring Play Services (including S/N API) in place of GApps (Ie. a GApps substitute for those intent on 'de-Googling' Android)...

S/N implementation was broken for some 3 years, but some months ago users have again been able to pass S/N with MicroG component updates...

All this is immaterial to issues rooting ROM with Magisk however; Magisk should install on systems with or without either GApps or MicroG even if S/N API returns errors...

Issues with kernel implementation or other are the likely cause of bootloop issues etc. PW
[Magisk] zgfg:
Since MagiskHide was removed from Magisk Alpha, now MagiskHide detection has gone public (see attached screenshot from Telegram channel)

Indeed, go to the GitHub and take Translate (Chrome):

MagiskDetector/README_ZH.md at master · vvb2060/MagiskDetector

Contribute to vvb2060/MagiskDetector development by creating an account on GitHub.

github.com
[Magisk] Stillhard:
Is it?

Spoiler content hidden.
[Magisk] zgfg:
Noted a post before yours

Anyway, it could affect Magisk Delta users if/when root-fishing apps implement now the known code to their apps (probably they won't bother since MagiskHide was removed from official Magisk v24)
[Magisk] Johnassel:
Yes, it is strange. My solution for this is now official LOS+Magisk 25.2+microG module. Seems to work!
[Magisk] pndwal:
Yup... Saw yours when first posted and couldn't edit mine further due to XDA down/outage... Again!.. 🙄 ... Removed duplicate post now ...

Guess it could... Don't know if similar detection works for denylist... Still, a fair trove of info now public... Could help modders too. PW
[Magisk] pndwal:
Is it made public?...

Chinese info translated:

MagiskDetector/README_ZH.md at master · vvb2060/MagiskDetector

Contribute to vvb2060/MagiskDetector development by creating an account on GitHub.

github.com

👀 PW
[Magisk] Stillhard:
this 'R.I.P MagiskHide'

Or that girl just 'masturbate' again?

Here i tried her 'codes' (not her hands), even w/o adding it to MagiskHide's list, no detection or whatever she calls that makes 'R.I.P MagiskHide'
[Magisk] pndwal:
🙁

This:

... Are you using 1735a713-alpha?

According to @huskydg however, 'original MagiskHide' is just replaced with 'logcat method based MagiskHide'...

https://xdaforums.com/t/discussion-...orks-by-vvb2060-support.4424845/post-87262393

Anyway, we were simply reporting the TG message re. "MagiskHide detection method and code used by momo have been made public"... And I don't use or test Alpha currently... PW
[Magisk] 73sydney:
Im just going to bake some cookies and sit back and wait for people to start posting in hysterics, like what happens when anything happens in magisk userspace...
[Magisk] huskydg:
I hope they don't public all momo detection

If they public all detection, the community will be hard to use root
[Magisk] huskydg:
@pndwal Thing you didn't know, low Android users (Android 9 and bellow) and MomoHide or other code injection users are unaffected by this detection
[Magisk] Stillhard:
I too never use her/their injected telemetry releases, i was just referring to her wording 'R.I.P MagiskHide' as you quoted and tested her newest Magisk Detector v3.0 with said, but no prove that MagiskHide detected as promoted

Edited: Added the link to the source of the apk (it's inside the artifact file)
[Magisk] huskydg:
For riru users, this can be bypassed with MomoHider so this detection is meanless btw

Release 0.0.9 · HuskyDG/riru-momohider

Initial commit

github.com