yashsingh1/xdaforums huggingface dataset:
[Magisk] Artim_96:
1. You have to reflash your boo.img after using unsu

2. Yes, that's a weird bug, I think it's inside TWRP. Reboot TWRP, flash your boot.img and then try it again
[Magisk] Karls0:
[MENTION=4526560]Sc4ryB3ar[/MENTION] - I think that you flash pre-rooted kernel. Look at the warning "Super Su patched boot detected". It's not likely that UnSu could break something as suggested above.
[Magisk] hopelives:
My Note 4 Exynos (N910C) running SimplROM (6.0.1 Based light ROM) with SuperSU. I installed material design xposed installer and after that I installed Magisk Manager but couldn't instal Magisk. It downloads the latest v12 but while installing it says error and doesn't install.
[Magisk] DodoGTA:
Please post your recovery.log
[Magisk] houston_:
I installed LineageOS 14.1 in my HTC m7 now.

Flashed everything together: Rom + Gapps (micro) + Magisk.

Working without problems. Passing SN without problems.

Still 12.1 was better suited for my device ?
[Magisk] Sc4ryB3ar:
Did that, and all is good with the universe now. Thank you both for replying
[Magisk] topjohnwu:
Hmmm.... finally got my Nexus 5X today.

Testing out Android O, pretty sweet :)

Oh, and regarding some "well known developer" claiming that starting daemon early leads to crashes, it doesn't seem to be the case here.

The WIP unified daemon started just fine in all boot stages, Magisk will 100% work on Android O DP1 once it's finished
[Magisk] Perseus:
I see that last report for Pokemon Go is from April 8th, of this year on this thread. Has anyone been able to successfully been able to log into very latest Poke Go version 0.61.0 ?

As of this post, whenever I try to login, I get "Unable to Authenticate, please try again" error with Magisk hiding the root. From what I can tell, there are no server issues at this time, as I get instant response for entering wrong password.
[Magisk] hopelives:
In magisk manager there isn't log file.
[Magisk] Codebucket:
I have a question about MagiskHide, how can I pass SafetyNet test with SuperSU installed, is there any way to achieve that? Or does it only work with MagiskSU?

Thanks anyways for the great mod, topjohnwu!
[Magisk] Artim_96:
Recovery.log, not Magisk.log. the log of you installing Magisk in TWRP. Go to /cache/recoverye and copy last_log.
[Magisk] hokiealumnus:
Working fine here on 0.61.0, fwiw. Pixel XL currently stock with elementalx kernel and magisk (while we get 7.1.2 prepped for crDroid).
[Magisk] Artim_96:
Mask hide can only hide Magisk modules
[Magisk] hopelives:
I was trying to install magisk via magisk manager, not TWRP. Should I try through TWRP?
[Magisk] PhilD41:
I just installed Magisk 12.0 on my Moto Z Play with the March security patch. I am curious how I would know if I need the f2fs? I booted (via fastboot) into TWRP and just flashed Magisk. It booted back up fine and I have root. I can't install modules. They say they do, but nothing is ever installed and Magisk Hide is not working. Would either of those be cause by not having the f2fs patch in place? Anyway... I thought I might be able to verify if the March patch has the f2fs fixed or not... and maybe get some assistance with Magisk Hide and the modules. Thanks!!
[Magisk] Artim_96:
Still it will use TWRP for first installation, I don't think it shady can do without.

---------- Post added at 11:15 PM ---------- Previous post was at 11:11 PM ----------

Not having the patch would mean Magisk wouldn't work at all. It prevented loopback devices to work. So your problem must have another cause. Have you tried installing modules through TWRP?

Otherwise we would need some logs
[Magisk] PhilD41:
That is what I was thinking regarding the f2fs, so this does seem to be fixed in the March patch. As for the modules, I have tried installing them through the download function in Magisk. It says they install and asks me to reboot. When I do there is nothing in the modules list though. I have also tried to install a downloaded zip via the "+" in the module screen. I get the same behavior. I am not seeing errors in the Magisk log, but I would be happy to provide them. How do I get them out of my phone? I don't see them in the MagiskManager folder on my sdcard, or a way to export in the app.
[Magisk] Tesla:
Works for me.

Note 4

Magisk 12

Stock 6.01

Modest Kernel

Try reinstall magisk.

Btw. do you pass safetynet in magisk?
[Magisk] aik.nayan:
My phone is G531H(Nougat)

While I flash Magisk it found error!
[Magisk] Artim_96:
1. Try to install them through TWRP. If it shows errors, upload the logs (/cache/recovery)

2. Magisk logs are in /cache. Otherwise tap on the save button in log overview, then try are saved to the Magisk manager folder
[Magisk] PhilD41:
I will give that a try. So I can just flash a Magisk module zip file from the recovery? I did not know that.
[Magisk] minary:
I tried to install Magisk but got a error.

- Unpacking boot image
! Unable to unpack boot image

And that was all. I tried removing /data/magisk.img before installing, restoring stock image, etc but it didn't work.

I use TWRP and tried to install Magaisk v12 ZIP from official xda forum.
[Magisk] Tlailaxu:
On my S4 with RR-Rom and Magisk 12.0,i have no problems passing Safetynet and playing Pokemon-Go. However, on my GF´s S3LTE, i can install whatever ROM i want, can´t pass SafetyNet check with Magisk or ISU (even total unroot doesn´t do the trick this time). Kinda weird and nobody knows an answer regarding how to fix that
[Magisk] DodoGTA:
-deleted-
[Magisk] Didgeridoohan:
Why the cross posting? Sigh...

Well, you already got your answer in the other thread: remove SuperSU properly. This means you'll need to flash a boot image that doesn't have the SuperSU patches. If your ROM comes pre-rooted with SuperSU, this might be tricky and you'll need to find a clean boot image somewhere. Ask in your ROM thread if this is the case.

I'm sure there was more to the logs than that. That error means your device's boot image isn't compatible...

If you're asking for help, more details would be useful. Device, ROM, the recovery log, etc.
[Magisk] Clandaries:
I can not log into PoGo but i can use my Bankingapp (HVB Banking) on my Galaxy S5 with Magisk 12. It is just funny :)

Greetings
[Magisk] tamer7:
[MENTION=4470081]topjohnwu[/MENTION]

I have been reading about (WIP) "native hooking" (via LD_PRELOAD) as a method to to fake some system calls in android and it seems possible:

https://github.com/devadvance/rootcloak/issues/62

This, I think, would allow us to hide root even from pesky apps (like banking apps) that use native libs to detect root (ex. libshield.so, libtool-checker.so)

What do you think?

Edit:

Even better; Frida. You run the frida-server binary as root on your Android device, and the client then allows you to hook any function at runtime.
[Magisk] TechNova:
[MENTION=4470081]topjohnwu[/MENTION]

Whenever i enable any module(like adblock, dolby by ahrion, v4a or any module available) all of my system and user apps start crashing (like 35-40 force closes)

Tried both v 11.3 and v12 of magisk

(I Always try to quickly open magisk and disable those modules n reboot in order to prevent fc)

Device is redmi note 3 snapdragon aka Kenzo with DU based on 7.1.2, AEX 4.0 based on 7.1.1, on both the roms i am facing it (both are based on AOSP).

By the time i actually take logs using matlog or adb, system Hot reboots and when i try to take log again, these same stuff loops again n again...

Any fix?
[Magisk] Artim_96:
Yes, you actually can.
[Magisk] hopelives:
I can't get it mate, how it uses TWRP? There is no reboot because manager doesn't install magisk since error occuring.
[Magisk] teddy0209:
Reboot to twrp and flash the downloaded zip file... Should in internal under magisk folder, or just download it from the official release thread.
[Magisk] poleG17:
I have a question, i have a original ROM un a wiko pulp, and i rooted It by kingroot and nos hace a supersu like a root manager. So, can i change magisk for supersu? And what os better, magisk ir supersu.

Thaks
[Magisk] Codebucket:
Oh ok, thank you for the quick response. Do you know maybe an alternative app for FolderMount, since it won't work with other SU than SuperSU?
[Magisk] teddy0209:
GL2sd
[Magisk] 135Shadowsoul:
to those who have problems with magisk + adaway, i may found a solution:

1. setup magisk to pass SN.

2. change following props with terminal or any proper working buildprop editor (requires root):

ro.build.type: user-debug -> ro.build.type: user
ro.build.tags: test-keys -> ro.build.tag: release-keys

3. reboot

4. install adaway (but do NOT enable sysemless hosts!) and initialize it

5. reboot

6. be happy and ad-awayed

at least on my phone (setup see signature) it is working fine.

€dit: please do not copy/paste the "code" part of my post to shell/prop editor...
[Magisk] shoey63:
But you are editing a system file directly!

Doesn't that defeat the purpose of Magisk?
[Magisk] Codebucket:
Seems to be outdated, but I've read that Apps2SD has some kind of feature in its PRO version. I will try that and report if it worked.
[Magisk] Didgeridoohan:
Hmm... I wouldn't call it a solution, but a workaround. A solution would be finding why you can't seem to pass SafetyNet with systemless hosts enabled.

I can't recall: do you have the same problems with the Unified Hosts Adblock module from the Magisk repo, rather than using Adaway? Or did you have issues just from enabling systemless hosts?

---------- Post added at 15:00 ---------- Previous post was at 14:58 ----------

It does...
[Magisk] 135Shadowsoul:
well... it works... so... i thought i share this workarround, like [MENTION=4667597]Didgeridoohan[/MENTION] it called, with others.

and i think those 2 props are not too dangerous to edit. there was some android wear update, that needed an edit on props, too cause it did not want to work on a debug/test-keys version.

€dit: before editing, i had the problem, after "some time" (more or less random intervalls), SN failed after passing. after this edit it seems to be fixed. => maybe a problem in magisk prop-"manipulator"? (i dont know how to call it, but i hope its understandable what im talking about) no, it did not solve it :(

i did not try unified hosts adblock module. did not even know that it exists.

enabeling systemless hosts let SN fail on my device, even without adaway.
[Magisk] bigknowz:
Drain

CPU stats looked fine, however there seems to be unusually high drain on v12. Went back to 11.6 and battery is back to normal - N6P, DU 11.3, Kylo Kernel.
[Magisk] Didgeridoohan:
If you'd like to keep your mods systemless (the purpose of Magisk), it doesn't really matter. If you've edited a system file, your systems been "compromised". You can easily make those prop edits systemlessly with a Magisk module or a script instead. In the future you'll be able to do it directly in the Magisk Manager.

Another thing I'm not sure if you've stated before: what's your device and ROM?
[Magisk] 135Shadowsoul:
i just want to have my root (+adblock, security, personalization, and so on) and passing SN. i do not realy care about systemless/non-systemless modding. maybe i just abuse magisk, but as long as its working im happy.

if there will be a chance to do it with magisk manager, it would be nice, ofc. less other tools required :)

im using a Samsung Galaxy S4 (GT-I9505) with JDCTeam Opt. LOS 14.1 (Android 7.1.2), stable2 version. Link to rom you will find in my signature.

if you want any more information, just ask :)
[Magisk] Didgeridoohan:
That's right... Samsung AND Lineage OS. Not exactly the mod-friendliest combination around. :p

My bet would be it's a ROM issue, where it just doesn't play nice with parts of Magisk. The wonderful diversity of Android can be a bit of a pain for developers...

A GUI in the Manager for changing prop values is on the to-do list for upcoming features.
[Magisk] Codebucket:
Well, in some cases it does work, on my phone it passes SafetyNet when I enable systemless hosts, but not when I enable Magisk Busybox.
[Magisk] 135Shadowsoul:
well, the LOS builds are quite good, JDCTeam does good work. in stable2 they even enabled some improvements in rom for magisk. i do not know what exactly, but saw something in changelog.

sounds nice with the prop editor :)

long time i tried to avoid magisk... but after using it for a short time, im realy starting to like it :P

just wondering why sometimes after a bit using (or even not using) the phone SN fails after passing... after reboot its fine, for random time interval :( dont know if its a magisk problem or a rom problem. maybe mix? even tried to manually enable hide again (follows the link in your signature), but only reboot helps.

are there any logs i could provide in order to solve (or workarround :P) it? :)
[Magisk] Codebucket:
Well wait, Magisk does support executing scripts at boot, so I could make a mount script which would remove the need of FolderMount, right? :D
[Magisk] Tesla:
I would like to say THANKS to [MENTION=4470081]topjohnwu[/MENTION] and all of you who help people in this thread.

You are fantastic. The time and effort you put in.

Thank you all so much.

:good::good::good::good::good::good::good:
[Magisk] Didgeridoohan:
Should be perfectly possible. Place any scripts you want executed either in /magisk/.core/post-fs-data.d or service.d. Check in the wiki for when different scripts get executed. Or make a module with the script in either post-fs-data.sh or service.sh.
[Magisk] Codebucket:
Thanks, I already found out when this script should be executed :D So just a simple script written in bash should work, right? Anyway, I will test out with a simple echo script :silly:
[Magisk] SacredDeviL666:
i am unable to use citrix hub(secure hub xenmobile)/mdm with magisk installed device... security flags and doesn't let me log on... where in on a supersu device i was able to do so by uninstalling supersu and then installing citrix hub/mdm account of my company...

tried with magisk hide and hiding the apps from magisk... now going to try after using the magisk uninstaller and see if it lets me through.

op3t device.
[Magisk] Ubimo:
Where can I find the latest beta?
[Magisk] Didgeridoohan:
Do you mean the snapshots by [MENTION=2226076]stangri[/MENTION] found here?

I don't know if they've been setup to build from any other branch than master. Development has been done on a different branch lately... Which looks really interesting, by the way.
[Magisk] Codebucket:
Do you had only Magisk Hide enabled? Because I noticed that Snapchat (does not use SafetyNet, but other methods of root check) and co won't let me login when I had Magisk Busybox enabled.
[Magisk] liver20:
Is possible one magisk module for double tap to lockscreen in any where of screen or double tap in lockscreen?

Enviado desde mi ONEPLUS A3003 mediante Tapatalk
[Magisk] SacredDeviL666:
magisk hidden, busy box disabled, hide citrix/secure hub xenmobile from magisk supersu disabled...

and now my device has been blocked in mdm console panel so i have requested the system admin to remove my device from block if he/she does then i can try further... i highly doubt they would unblock my device from the console :( fingers crossed....

i am using it fine on hammerhead M with supersu disabled
[Magisk] Daedulus Minion:
Hello everyone. My device is a Oneplus One running Tugapower rom based on LineageOS 7.1.2. I am using MagiskSU. Today I tried installing an app named SecureTask (https://play.google.com/store/apps/details?id=com.balda.securetask) which is like an alternative to Secure Settings for Tasker. One of the steps for setting up this app requires this app to be made the device owner. I followed the method 3 mentioned here (http://baldapps.altervista.org/deviceowner.html).

Now, my issue is that there is a file needed to be copied to /data/system directory. It copies successfully but gets deleted after reboot. I jumped into recovery instead of direct rebooting and could still see the file through TWRP. But couldn't after I boot into the system.

My guess is that Magisk is somehow preventing changes to the system to let SafetyNet pass. I may be wrong though. Any suggestions please?
[Magisk] tamer7:
[MENTION=4470081]topjohnwu[/MENTION]

Magisk v12, RootInspector v1.0

Magisk v12 (passing safetynet) passes all rootinspector checks, except the java check for su in 'ps'. See attached screenshot.

Can we do anything about this? any ideas?

Edit:

just saw the branch 'unify_daemon' on github.. very exciting changes.. looking forward to build and beta-test :D
[Magisk] rocky78:
this is getting pretty tricky now.

im on aosp extended 7.1.2 and doesn't work for me neither, but on 7.1.1 and magisk v11.1 it worked. didnt passed safety net naturally.

give it a try and if you still get blocked then your admin needs to unlock you on the server's console.

good luck and if you find a way let us citrix user's know.:good:
[Magisk] Didgeridoohan:
Magisk does not prevent changes to your system, and most system changes have no impact on SafetyNet.
[Magisk] smileyhead:
hi, when I try to flash the ZIP, it reboots the phone on the second step, and doesn't root it.

recovery: TWRP 3.1.0

phone: Huawei P9

ROM: EMUI 5.1 - Android 7.0 (stock)

bootloader unlocked
[Magisk] Karls0:
It would be hard to guess what happend without any logs. Could you do a screenshot from TWRP after end of installation for example?
[Magisk] PhilD41:
So I tried from TWRP and the module (App Systemizer) installed fine. There was no error log in /cache/recovery and the install went fine. On reboot it does show on the loaded module screen. It doesn't seem to be functional though. I use it for Action Launcher. Also, I grabbed the magisk log. I had missed the save button earlier. It is a little hard to see with the night theme. It is below. The log is attached.

The last line is interesting, but I don't know what it means. Thanks for the help!!
[Magisk] Artim_96:
1. never write the log inside the post. attach the file!

2. even if TWRP doesn't show errors, the logs show more than what you are shown on installation. And the logs are always created in /cache/recovery. Otherwise they should be in /tmp as long as you don't reboot to system or somewhere else

3. obviously your magisk installation is broken, it can't read the magisk hide blacklist. so maybe reinstall it
[Magisk] jhedfors:
[MENTION=777861]PhilD41[/MENTION] Acutely painful on mobile.:cowboy:
[Magisk] PhilD41:
Sorry, will do for number 1. There was an error log in /cache/recovery but it was zero bytes. I will check in /tmp. I will try a new install and see if that helps.
[Magisk] Artim_96:
it's much more painful to have to scroll to the logs on mobile. Since even the hide-element is not working in the XDA labs app, that is an absolute no-go
[Magisk] jhedfors:
Very odd that the app does not support some of the (seemingly) basic functions. :)
[Magisk] Artim_96:
Well, from what I hear from others, other apps don't even have a search function. That's true explaination for reposting what was just asked
[Magisk] Daedulus Minion:
[MENTION=4667597]Didgeridoohan[/MENTION] Oh. Any suggestions in that case about why this auto delete could be happening?
[Magisk] Danny94:
I finally found a working miui build for my mi4c. With deleted root now i pass safety net and pogo is just working fine.

After installing magisk and magisk manager + enable magisk hide + reboot the game just won't start up anymore...

Mi4c | multirom.me 7.4.11 (miui) | latest magisk latest manager | twrp 3.1 | nougat firmware | android 7.0

At all it looks like as the magisk hide doesn't work correctly. Magisksu looks fine.

Any idee someone ?

I tried to use older versions of both some different combinations but with no success.
[Magisk] Tesla:
Are you sure you don't auto root when you reboot? That is not uncommon.
[Magisk] Danny94:
[MENTION=4901223]Tesla[/MENTION]

100%. PokemonGo was working withouth magisk. (complete unroot)
[Magisk] Tesla:
So if you uninstall Magisk, reboot. Check for root there is no root and then again efter a new reboot.?

Just checking here so we are 100%
[Magisk] Danny94:
[MENTION=4901223]Tesla[/MENTION]

Flashed uninstaller reboot, pogo working. Reboot again pogo still working.

Edit:

to prevent other question, after eneble magisk hide i rebootet several times + shut off several times.

Pokemon go is ticked in magisk hide.

Safety net tester is red. cts profile...

Installed magisk already 20-30 times and was always working on other custom roms.
[Magisk] Tesla:
I don't now then.. clear magisk app from all data, unistall, reboot, install magisk app again?

Maybe something to do with your kernel/Boot.img?
[Magisk] Danny94:
[MENTION=4901223]Tesla[/MENTION]

i did that already often enough =). Installed older versions and different combinations.

If the problem would be kernel/boot.img related it won't even work withouth magisk.
[Magisk] yochananmarqos:
AppSystemizer can't copy the apk's to the /magisk directory and MagiskHide is not working. Have you tried uninstalling / reinstalling Magisk?
[Magisk] djb77:
Modified Magisk Module with EvilTheme Patcher

Just released my modified version of the Magisk Module Template.

This has EvilTheme integrated into it, which will let you copy files from /system, patch them, then build it into your module.

Here's the URL, hopefully some of you will find this useful :)

http://xdaforums.com/showthread.php?t=3590766

[MENTION=4470081]topjohnwu[/MENTION], unfortunately this isn't the really nice patcher that osm0sis has started developing, when I get some time I'll look into that one. But this one is still practical atleast :)
[Magisk] sheyac:
I am experiencing exactly the same thing (same rom too). SN passes then after a random amount of time and nothing unusual happening (e.g. just charging phone) SN fails. Disabling /reenabling magisk hide doesn't fix, only a restart helps. I enabled magisk hide for all Google/android apps but that hasn't helped either.

Any ideas on what's happening? Anyway of logging?
[Magisk] Didgeridoohan:
No idea.

Sounds like Magisk Hide doesn't start properly after the reboot. Have you tried toggling Hide off and on to restart the daemon?
[Magisk] Gawd:
Hello,

I have a few simple questions:

1) Since I'm using a custom ROM, and there is no OTA, is achieving everything systemless-ly pointless for me? This is because I pass Safetynet even if I make changes to the system partition (considering I'm hiding root, and my custom ROM passes Safetynet out of the box), and according to my understanding, achieving systemless is for OEM/ stock ROMs so that they can update via OTA.

[I know that Magisk is not at all just about passing Safetynet]

2) How can I check if I've left the system partition untouched, is there an App or something for it? This is just curiosity.

Thanks in advance!
[Magisk] smileyhead:
it doesn't end. it restarts by itself midway.
[Magisk] Didgeridoohan:
1 - Yes, update via OTA is one of the advantages of keeping your /system unmodified. You'd have to restore your stock boot image and also the recovery of you've permanently flashed it to update via OTA though.

The main advantage to the systemless modifications, in my opinion, is that after a system update they're still there and even if you've done a clean update with a wipe, it's just a matter of flashing a couple of zips to get them all back.

Most system mods have no impact on SafetyNet.

2 - No idea.
[Magisk] Karls0:
Does it restart twrp in mid of installation? Even if package is totally broken it should just end with error but that's all. Even if you flash recovery update, and it fails, it should keep old version of twrp until you will do a reboot manually.
[Magisk] smileyhead:
no, it restarts the phone and boots into the OS. it's easier to show it:

[YOUTUBE]https://www.youtube.com/watch?v=NyihgfSq4jQ[/YOUTUBE]

if the video doesn't play, here's the link: /watch?v=NyihgfSq4jQ
[Magisk] Danny94:
Yes i tried but no success, but in my opinion you have right there must be a problem with magsik hide.

How i can fix it otherwise ?

My problem descibed on previous site (1234), first post.