yashsingh1/xdaforums huggingface dataset:
[Magisk] Tulsadiver:
Never mind. It is kind of busy and I didn't see the button to push.

Maybe a few things being a different color would help.
[Magisk] CMBoii:
Which option should I use in order to update magisk?
[Magisk] hw-schrauber:
OK, I have it. But there is some other thing. If I compare the original boot.image with the patched image with a hex editor I see, that in the beginning of the patched file there are 3 bytes are changed from $00 $00 $00 to $DC $A7 $05 located at address $10 to $12 nothing else is change in the beginning of the file. But then there was something what is maybe the reason for the problem.

The original file use the space $000000 to $6A05DB and $6A1000 to $6A11B7. After the patch the filespace is $000000 to $6A05DB and $6A0800 to $6FAF97. And this confused me. The second part of the patched file overwrites the second part of the unpatched boot.img. Can this be right?

My thought to cover the problem is, to move the magisk part from $6A 08 00 to the startaddress $6A 18 00. I think I have to change more bytes to show the new location. Also I think, I have to change the 3 bytes at the beginning. But I'll don't know the way to calculate the new value. The $DC A7 05 points anywhere in the unchanged original part.

Can someone confirm my thinking or have a better way for me?
[Magisk] ROMfan:
Is it just me or the latest UI update looks kinda ugly?

Its boxy and asymmetrical.
[Magisk] khuatquan94:
I' ve got magisk manage but when i chose module icon magisk manage is out. please help me and thank you very much. Pixel 2xl
[Magisk] Avisadius:
I have redmi 5a with latest beta xiaomi europan rom for redmi 5a, and when i am install magisk v2.30 always make my device bootloop, using twrp 3.3.2.0
[Magisk] Avisadius:
A pict for details
[Magisk] krzysiek1984:
Someone tested on Xperia XZ2 Android 10?
[Magisk] warrencoakley:
When I unistalled a Module and rebooted when I press the Module button on the new UI it keeps crashing Magisk.

Happening to anyone? [MENTION=4470081]topjohnwu[/MENTION]

---------- Post added at 05:33 PM ---------- Previous post was at 05:13 PM ----------

Yes i am after uninstalling a module and then trying to reinstall it, it just FC's

Have you found a fix?
[Magisk] Jiggs82:
Originally Posted by padraigdoran View Post

TRICK TO ACCESS MODULES IF CRASHING:

Open Magisk.

At the bottom click the modules shortcut.

Now, very very quickly, tap the shortcut at the bottom just to the left of modules to get to the Superuser page.

Next click back into modules and it will load fine.

FYI use 2 fingers when clicking on superuser and modules section in order for it work...
[Magisk] warrencoakley:
Also when you unhide Magisk Manager and try to re-hide it keeps coming back with an error. See attached. [MENTION=4470081]topjohnwu[/MENTION]
[Magisk] warrencoakley:
Not for the new UI. When I click modules it closes immediately. [MENTION=3367894]Jiggs82[/MENTION]
[Magisk] DiamondJohn:
Its a Canary build; not all the cute little birdies make it out alive:crying: thats the whole concept of a "canary". These early builds will have ideas thrown into the mix, that are not going to be in the final. Its good to know everyone's thoughts of course, but I think we should all also expect these early builds to be rough around the edges. I don't know if it would be appreciated, but maybe someone in the community with some UI design skills could propose something better?
[Magisk] kiwigi:
TWRP

[MENTION=7423542]dcarvil[/MENTION]

I have done a TB backup though would also like to have a nandroid backup. Is it possible to flash TWRP when magisk and magisk manager are all installed and working?

Thanks
[Magisk] grep_i:
You could always install busybox and terminal on your device.

That way you can use tar xzf boot.gz to extract in terminal app. No PC needed at all
[Magisk] kirby2ig:
I modified the Magisk installer to copy the modified kernel to the file /data/boot_magisk.img instead of installing it. If you run this we can verify that the Magisk installer is working correctly.

You can download it here.
[Magisk] ianmacd:
He said his phone doesn't boot, so that's not an option.
[Magisk] grep_i:
But still when in recovery he can use the terminal and do the things I described on his device.
[Magisk] topjohnwu:
Hype hype hype...... :)

Transaction confirmed working with the new method!!!
[Magisk] mng777777:
I don't know much about the technical side of getting past safety net and getting AP working but I work in payments processing and may be able to shed a little light on part of the process I see some confusion about across multiple threads.

In AP, when adding a new card, some banks(more everyday) cooperate with Google to use tokenization to randomize all your sensitive info, meaning that neither your phone nor Google stores sensitive info, rather the bank stores it and AP uses a randomized token in its place to obtain authorizations. This means that for anybody testing AP that if you get as far as transmitting a transaction, AP is working. For those getting that far then experiencing a decline, it's not due to an issue with AP, it's an issue with the bank expecting a token for authorization and getting something different. This is probably most likely caused by having used AP with the same card loaded before you started modifying your phone(or possibly even on a different phone entirely) then without deleting that card, completing some version of the mods mentioned herein, successfully getting AP working again, but failing to generate a new token through your bank. For anybody experiencing this issue it can be fixed by calling your bank and having them update the card's AP record or in some cases, deleting the card and adding it as a new card.

As an additional point, some users may experience the same issue when dealing with trying to add an updated card for an existing account(ie. Current card in AP expires, bank issues new card with same account updated expiration: existing card needs to be deleted, replacement is added as a new account/card)
[Magisk] efrant:
Very informative! Thanks for sharing. I'm sure that clears up a lot of things for many of us.
[Magisk] bobby janow:
Yes, very. One additional factoid, on my Amex card they only allowed 5 additions to AP and the 6th time it was declined. When I called them they saw 5 devices (actually same device, 5 different rom flashes) and had to manually go in and delete all the devices since there was no way to tell which was which, they all said the same thing. Then I was able to go in and re-add the card and successfully transact. But the initial rep didn't know that but the second tier person did. You just might need to be a little persistent in getting resolution.

Now all I need is the N version of this. :angel:
[Magisk] dlabadie:
Oops

Sent from my Moto X Pure XT1575
[Magisk] ParadingLunatic:
I'm not sure what I'm doing wrong. I just updated my 6P to the most recent build downloaded directly from Google. Flashed boot, system, cache, bootloader, and vendor images (did not flash userdata as I'd like to keep my config), then flashed Franco's kernel because I don't want my phone encrypted. I did not root nor install Xposed. Ran a safetynet test and it passed. Loaded Magisk, then flashed the Magisk compatible SU. Unmounted root and ran a safetynet test again, and it failed. Always fails with Payload Validation Failed.
[Magisk] DarkN3ss61:
To use Tasker, Create new task, search for "Intent" Click on "Send Intent"

To enable root

Set the action to: com.topjohnwu.magisk.ENABLE

Set the package to: com.topjohnwu.magisk

Set the target to: Broadcast Receiver

To disable root

Set the action to: com.topjohnwu.magisk.DISABLE

Set the package to: com.topjohnwu.magisk

Set the target to: Broadcast Receiver

Here is the link to how I have got my tasker set up. (ASB is our country's equivalent to Android pay) http://imgur.com/a/LA3lR

After you have done that you can assign that task to a tasker widget

P.S Make sure you are using my build for this at the moment as the main build does not support it

https://github.com/DarkN3ss61/MagiskManager

Here is the compiled APK: https://github.com/DarkN3ss61/MagiskManager/releases/download/0.1/MagiskManager_DarkN3ss.apk
[Magisk] steveo17:
So with this then you can have it so that when you open android pay root is disabled? And when it's closed rooted will be enabled again?
[Magisk] DarkN3ss61:
Yep, if you set it up to do that, then it should work fine. I don't have access to Android pay in my country, So I set it up and instead of Android pay I used ASB virtual as thats our equivalent and it works fine for me
[Magisk] steveo17:
Sweet. I'll try it out. Do I have to build the apk myself from your code or am I missing it somewhere on git
[Magisk] DarkN3ss61:
Don't have a APK yet, you will need to build it yourself from the code, but if you want I can upload one in about an hour or so when I am back at my computer?
[Magisk] steveo17:
Yea that would be great being that I don't know how to build it myself
[Magisk] joeyddr:
Where did you delete them?
[Magisk] DarkN3ss61:
Here is the link to the APK: https://github.com/DarkN3ss61/MagiskManager/releases/download/0.1/MagiskManager_DarkN3ss.apk
[Magisk] xd4d3v:
There seems to be an issue with Magisk and Huawei devices (in their stock form)

I have the same problem as you on my Mate 7, and like you said, earlier superuser versions worked well, the newer ones don't

(I'm not sure whether this is the same problem as Magisk)

[MENTION=4470081]topjohnwu[/MENTION]

Would you be able to help us Huawei users get this to work?

happy to provide logs, etc. just tell me what you need. Thanks
[Magisk] bobby janow:
Re: AP authorized devices. You can't delete them yourself. The bank has to on the back end.
[Magisk] putridfoetus:
Yes it would be backed up with everything else as a regular file, since it isn't mounted as an image or partition.
[Magisk] killbox.kb:
Thank You for the info and help :good:

Can you provide a compatible boot image which I can use?

Thank You
[Magisk] ammar18:
try flashing CM based roms. I personally dont use magisk yet.
[Magisk] JudgeDread11:
I have posted this before:

How to install magisk:

Magisk requires an unlocked boot loader.

If you are on a custom ROM with root baked in you will need to uninstall root first.

To do this several tools come in handy:

Root validator (get it on Google play store) and the unSU script (get it from osm0sis' bits and ends thread: http://xdaforums.com/showthread.php?t=2239421&page=86)

Before you do anything run right validator and write down the locations root and BusyBox are installed in.

If your ROM includes SuperSU use the SuperSU app to fully unroot. You can find this option in the app's settings.

Boot into TWRP

And flash the unSU script

Then in TWRP use the file manager and check the locations you have written down before for left over traces of root. If any, remove them manually. (Some people reported the magisk manager root toddler only worked after BusyBox was removed too)

If you're not on a prerooted ROM you can skip the above steps.

Now you can flash in this order:

Magisk v6

Phh's superuser 17 for magisk (download from the OP)

Xposed 86.5 for magisk (download from the systemless xposed thread: http://xdaforums.com/xposed/unofficial-systemless-xposed-t3388268/page202 )

Restart your device

Install:

Magisk manager (download from the OP)

Phh's superuser app (get from the Google play store)

Material design Xposed installer by DVDAndroid (get from its own thread: http://xdaforums.com/xposed/material-design-xposed-installer-t3137758/page152 )

When you use the root toggle in the magisk manager for the first time it will ask for root permission and switch back. After you have given the permission it will unmount root. (To pass safety net you'll need to disable xposed in the xposed installer app and reboot your device. Then unmount root)

Most problems with magisk that people post on this thread are caused by failing to follow part of these steps.

Then there are some incompatible devices. (See the OP)
[Magisk] lRemainl:
I installed magisk on a Moto G 2014 with Lexodus Xperience Rom 5.0.2 and calls does not work after doing this. Does anyone had this problem before?
[Magisk] stefanowall:
Hi to all! I've been reading the whole post for some time, but I have not found what I was looking for...so, I ask it directly: does Magisk work on moto x ghost? Before doing a lot of work, I'd really like to know! Thank you
[Magisk] ibrokemypie:
if you have twrp and an unlocked bootloader then probably
[Magisk] KyeWalker:
I think you've missed read what I said. I have already done this, I was asking if the OP could put a tutorial in first post for custom ROMs. I have already successful done what you have posted. Many users are still asking for help. Just merely I suggestion for a detailed explanation in first post. Maybe you could ask him as you've gone through the effort of telling me what I already know ;)
[Magisk] crackers8199:
the part that confuses me is that making a backup shouldn't be making any changes to the actual file system....right? that's what i find so strange...it should just be backing up the existing system. it shouldn't be changing anything...
[Magisk] bundysoat:
Hi guys! I see this method of root, but I preferred this for is possible to use monetary/banks apps as Twyp cash by ING. This is an app to pay in supermarkets and get some money in the same operation. But the app recognize the root and not work. Maybe.... SuperSU let many modifications that survive after "complete unroot"?.

Thanks
[Magisk] JudgeDread11:
SuperSU doesn't work with the root toggle for all devices and setups. Try phh's superuser instead.

Also disable xposed if you're using it.
[Magisk] grsmagik:
Magisk After installation, the phone stops on the boot

Hello, I installed Magisk on my phone Jiayu S3 - Extreme ROM 2.4 (v.5.1.1)

Telephone installation of the log stops at startup. (BOOT) - bootloop

How to properly install it?
[Magisk] Didgeridoohan:
I also have Nexus 6 with MOB31E and Magisk. The only difference in our setups that I can see is that I'm not using Xposed. I'll see if I can replicate your results, but first a couple of questions (did a quick look through your posts but didn't see the answers).

Is your device encrypted and what partitions are you backing up?
[Magisk] cadkey:
Have you read first post?

Answer is probably not
[Magisk] grep_i:
Don't know about your reading skills but it is clearly stated in first post.

What follows is a direct quote of the first post (OP).
[Magisk] EducatedPossom:
On a Nexus 5x NRD90S and this works great thank you!
[Magisk] Didgeridoohan:
Yup... Had an opportunity to try this out and I can confirm. On my Nexus 6 (build MOB31E, encrypted, TWRP 3.0.2-0, Magisk v6 with phh's superuser 17 magisk version, no Xposed) Magisk is disabled by creating a backup in TWRP (backed up System and Data partitions). Had to reinstall Magisk to get it working again.

Since I never really use TWRP for my backup needs, I'll leave my investigations there. If I were you and wanted to get to the bottom off this I'd flash another superuser after making the backup to investigate what's happened to the Magisk files, check the magisk.log, and so on. Other than that I'd say it's up to someone with a lot more knowledge about Magisk (@topjohnwu) to find an explanation... Maybe as well wait for v7 to see if it makes any difference.

Just realised I forgot to pull a recovery.log. Bugger...
[Magisk] protin.rock:
magisk not install.

I am running Resurrection remix android 6.0.1 on xolo q700s plus.I fully unroot my phone and in install closed.but when I try to flash magisk through philz recovery it says can not find boot image..installations aborted..what will I do??can any one suggest me .thanx in advance..
[Magisk] Ather:
i've always rooted the traditional way on my previous Note's, just got me a new Note7 Yesterday and thinking of going systemless this time to try it out...i have the International version (930FD), it has unlockable bootloader and twrp so am i correct to assume it'll work normally or is it still unsupported?
[Magisk] matt4321:
Say's in OP: Newer Samsung devices (Note 7 or maybe more): sepolicy issues + kernel issues, still investigating, should be fixed in v7

I don't have the device and haven't tried but by the looks of things I'd wait til v7 is out which hopefully fixes everything. From reading the thread it should be released pretty soon.
[Magisk] Badger50:
Ddepending on your device, you'll just need to flash the magisk.zip again after you install TWRP :good:
[Magisk] kiwigi:
Thanks [MENTION=3730810]Badger50[/MENTION] :)
[Magisk] kamikaze702k:
Not just u, several ppl myself included are not a fan of the new ui as expressed in previous posts and no doubt there will be future posts about it too. hope it doesn't become final, no disrespect to the dev but the new ui is irritating
[Magisk] rOck4n:
Everytime I try to install a module it gets stuck at flashing and nothing happens. I'm on Android 10 latest stable. No FC's or anything. After rebooting the phone the module appears under the section with no description, like it's installed but it's not
[Magisk] Didgeridoohan:
Does it happen with every module, or just one on particular. If it's just the one, that points to it being a problem with the module in question and you'd have to take it up with the module creator.

If it's all modules, logcat?
[Magisk] osm0sis:
8-12 is the size of the kernel. This is expected to change slightly since Magisk decompresses, patches, and recompresses it. Same goes for the ramdisk; the size should change, the rest of the header should be the same.

https://github.com/osm0sis/mkbootimg/blob/master/bootimg.h

If the size difference is as drastic as you wrote then that is a bit concerning and sounds truncated. More importantly l assume the patched boot.img doesn't boot?

Please upload your untouched stock boot.img and the magisk_patched.img so I can take a look.
[Magisk] warrencoakley:
I believe John has fixed the modules crashing issue. Can any confirm as I rolled back?
[Magisk] hw-schrauber:
You right, I can't boot with the patched magisk image.

Both wanted files in the boot-images.zip uploaded.

Thanks in front.
[Magisk] warrencoakley:
It seems some modules are culprits for the FC on Canary new UI. Found Viper, Dolby don't like it. If you have these installed go delete them in explorer
[Magisk] sumejorpista:
Hello: congratullations for work.

In the last version 7.5.2 I put install and get error.

Install zip and get bootlop.

I have S7 Edge whit port Note 8 whit Android 9.

If I install Modules MagiskHide and BuxyBox I get bootlop.

Which is the Fix.

Thanks.

Enviado desde mi SM-N950F mediante Tapatalk
[Magisk] osm0sis:
Okay it drops from 16mb to 7mb, that's no big deal.

What is likely screwing things up for you is that crazy bunch of sh*t before the ANDROID! header. It is named boot-sign.img, so is that a signature? Is there a signing tool available? What device is this? Presumably Magisk has never worked on this device because of this.
[Magisk] BigJeff:
Ya it's fully unlocked, the signage may be an issue, don't know.
[Magisk] Intex12345:
Certainly new UI of Magisk Manager is eye sore. Earlier It looked very nice. Many users have reported that current UI is cluttered and bad looking.

I wish, the earlier UI is restored.
[Magisk] RandomPooka:
Weird. It shouldn't be an issue with the unlocked bl, but I dunno
[Magisk] zxspectrun:
Worked, thanks ❤️
[Magisk] Didgeridoohan:
If you could be a bit more detailed in your descriptions it would help us help you.

For example: What are the errors you are seeing? You describe different situations leading to a bootloop. Does that mean you can actually boot at some point?

And of course, logs are always useful. Take a look here for tips on gathering those:

https://didgeridoohan.com/magisk/MagiskHelp
[Magisk] heru.sodong@gmail.com:
Magisk Canary Debug, crash in Modul Section..
[Magisk] wangdaning:
I would not call a handful of canary build users many. It is very, very few. It is a perfectly fine UI. I would suggest they separate the downloads and installed modules, but it is a WIP. Grid select one makes it much nicer, remember, people on tablets use magisk, too. It looks great with larger grid that way. Only other thing is it would be cool if it could adopt, it looks like where they are going, the system setting for the colors. Overall though, it is refreshing and nice to see people moving forward. You can always build it with the old UI interface :D

My only thing is the module tab crashing, but I think that will get sorted for all devices soon.
[Magisk] DB126:
Change is difficult for some to adsorb; patience. Trying to estimate how much total time I have spent staring at the Magisk UI. Maybe an hour over the past 3 years?? Yeah, definitely a hot button.
[Magisk] kamikaze702k:
Language is jacked up even when English is selected, certain areas show other languages

Also a suggestion for the theme section

Please add the old ui as a theme then
[Magisk] hw-schrauber:
Hi, you wanted the original boot.img. Yes, everything before Android and everything after $ 1000040 is part of the blessing. I once attached a boot.img to you. I flashed the boot-sign and read it back without booting the device. I then patched this file. But also here the rearmost area of ​​the boot partition is overwritten. Maybe check it out again.

And yes, you're right, I don't know if the device has ever been rooted. By the way, the device is a Lenovo M7 (TB-7305F) with kernel 4.9.117+. The CPU is a MediaTek MT8321 (32Bit).

The signature is the original from Lenovo. I don't have a signing tool.
[Magisk] osm0sis:
So the only thing you can try is to paste the stuff from before ANDROID! in the original boot.img to the beginning of the magisk_patched.img using a hex editor to see if your bootloader will accept it. If not then you're out of luck unless someone can reverse-engineer the signature.
[Magisk] dope77:
Not sure if this was reported earlier,

But after flashing latest canary,

My phone no longer charges when it's turned on, i have to plug it in charger after turning it off and keep it powered off till the battery is full, that's the only way.

And no it's not the charger's fault, also tried different usb cables/chargers.

Phone:

J610f, stock Android 9 and have latest canary installed
[Magisk] hw-schrauber:
I think that's not the problem. I can flash the read back boot.img again without problems. When flashing there is no error message and the system starts without problems. And this boot.img, without the signature, is also patched incorrectly. After the main block there are still small blocks in the original boot.img after about 500-1000 bytes. When patching, these areas are overwritten with MAGISKmanager.apk. That should be the reason why the patched doesn't start. I think the patch routine should be adjusted. Alternatively, it would be interesting to know that the boot routine and then the MAGISK patch are run through or vice versa. At some point there must be a jmp address (or call / lcall), which then refers to the MAGISK block. Can anyone say anything here?
[Magisk] rodken:
Complete factory reset should fix your issue. Do not flash the Canary version until you have determined that the Canary version is not the culprit.
[Magisk] dope77:
Found out it was caused by nfs injector.

All good now
[Magisk] wangdaning:
It would help if you said what area showed a different language. Is it within a module description or in the actual UI? If in the UI, where? I have not seen anything but English. The select download folder does squash the text so you cannot read it, as the poster asking about it before mentioned, but nothing is showing in another language for me.

Want to add, the old UI is not a "theme" it is the old UI. That is an impossible thing to ask for. If you want that, grab the source and build your apk based on the old UI.
[Magisk] martyfender:
Or install the older version of Magisk Manager.
[Magisk] wangdaning:
This discussion should really be in the canary thread. This is magisk manager canary, meaning it is pre-beta. I am sure it was much easier when a slash through a circle meant the same thing though, right?
[Magisk] warrencoakley:
Couldn't handle the new Canary build. Too many issues and bugs and stuff not working. Stable it is.