yashsingh1/xdaforums huggingface dataset:
[Magisk] Homeboy76:
:oops: Opps, I left out the word temporarily.

This is why I said temporarily install lineage 17.1...recovery...img to the boot partition on my Pixel XL (marlin): Install LineageOS on marlin

I do understand your point, because it makes sense to temporarily boot the recovery using fastboot boot lineage17.1...recovery...img.
[Magisk] pndwal:
Aside from above advice:

FWIW, if you simply want to avoid large download each time, this should work (if you have TWRP):

Unroot, flash OTA update, do TWRP backup of boot image, rename resulting boot.emmc.win file to boot.img and patch that. Flash to re-root.

Have a properly extracted boot.img on hand the first time you try this to recover device in case it doesn't work for you. PW
[Magisk] pndwal:
Mmm. And more seriously "fastboot flash boot lineage-17.1-20210303-recovery-marlin.img will install (flash) the recovery image to the boot partition on the device" (causing boot failure) as pointed out!

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84612929

😬 😉 PW
[Magisk] Homeboy76:
Never had a boot failure following the instructions: Install LineageOS on marlin . I do understand your point and I <edited> my post. 🙏
[Magisk] ineedroot69:
unless if you got fetish having bootloop then go on 😉

adb shell > cat /proc/mounts

or this android app https://play.google.com/store/apps/details?id=me.kuder.diskinfo
[Magisk] pndwal:
Well, you're right... That guide prescribes 'fastboot flash boot <recovery_filename>. img' for temporary boot to recovery!

This makes no sense to me... are you sure you used that?

Official instructions properly prescribe 'fastboot boot path/to/twrp.img'

https://twrp.me/google/googlepixelxl.html

PW
[Magisk] pndwal:
Latest Canary Magisk Changelog:

Magisk (45e0df9c) (22002)

[App] Prevent multiple installation sessions running in parallel

[App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images

[General] Proper cgroup migration implementation

[General] Prevent possible deadlock in logging code

[MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images

👍 PW
[Magisk] pndwal:
PW
[Magisk] pndwal:
Just had an 'Oh No' moment after flashing this!

Re-booted fine, but not fully; clock widget wouldn't appear, apps wouldn't open, or open and hang... Thought I'd be reflashing last patched boot.img...

Decided to try second reboot:

Fully booted this time, and all seems fine now...

Root is intact, settings preserved, SafetyNet passing fully. 👍

So be aware, you may have issues till second reboot. (Some are also getting 'unable to repack boot Image!' error.)

- Redmi Note 8T, Magisk in boot.img (despite ramdisk = no). PW
[Magisk] pndwal:
Latest Canary Magisk Changelog and Release Notes:

Magisk (bf80b08b) (22003)

Rebuild executables (fix boot image repacking issues)

Diffs to v22.0

[App] Prevent multiple installation sessions running in parallel

[App] Prevent OutOfMemory crashes when checking boot signature on PXA boot images

[General] Proper cgroup migration implementation

[General] Prevent possible deadlock in logging code

[MagiskBoot] Preserve and patch AVB 2.0 structures/headers in boot images

👍 PW
[Magisk] pndwal:
Well, that was a quick fix John! 👍 PW
[Magisk] pndwal:
Much better too!

Seamless flash, only one reboot needed.

Root intact, settings preserved, SafetyNet passing fully. 👍

- Redmi Note 8T, Magisk in boot.img (despite ramdisk = no). PW
[Magisk] Homeboy76:
Yes, decided to give fastboot boot ... a try the next time I update. Also posted a question to Dev about it.
[Magisk] capitarider:
Hey there,

I am currently struggeling with my Samsung Galaxy S7 (Exynos) device, running on superman rom (Android 8).

What happened?

For root I´m using Magisk Manager and for banking apps I have Magisk hide running. Then the program told me that there is an update (Magisk App) available. So, as always and recommended, I choosed "Direct Install" but that failed for some reason. OK I thought´, no problem. Later I wanted to reboot my phone but it didn´t. The screen says "Downloading.... Do not turn off device!". I only can enter "Download Mode" and "Recovery Mode via TWRP".

What I tried so far:

1) Wipe cache/dalvik --> not successful

2) Tried to do a factory reset via twrp --> not successful

At this time I realised that the same problem occured to my Galaxy Tablet SM-T580. So I came to the point that I did something wrong with updating magisk on both devides.

What I also tried next:

3) Tried to delete magisk modules via twrp --> not successful

4) Tried to uninstall magisk through twrp by downloading the latest Magisk app and rename it to "uninstall.zip" as recommended in installation guide --> Not successful because of Error installing zip file: Unsupported /Unknown image format

What can I do next?

Please help me
[Magisk] boxemall:
Device: Xiaomi Mi9t /Redmi K20

Updated to "https://xiaomifirmwareupdater.com/firmware/davinci/weekly/21.1.28/"

&

Flashed "https://build.aospa.co/prerelease/davinci/pa-ruby-beta-1-davinci-20210202.zip"

After reboot all worked fine without any errors. I then went on and rebooted into TWRP (twrp-3.5.0_9-0-davinci.img)

I followed instructions and patched the above twrp-3.5.0_9-0-davinci.img which got successfully patched & renamed into the process.

following that, i flashed the patched recovery. system rebooted fine but without root, which was expected due to not pressing any key combos during boot.

also worth mentioning: once rebooted after flashing the patched recovery magisk app won't show magisk as installed. is that due to the "normal" boot? it will probably only show in the app when the key combo is executed properly during boot, right?

the issue here is that no matter what key combo is pressed the device ends up in fastboot mode. using fastboot commands, it won't reboot normally (fastboot reboot) and neither into recovery (fastboot reboot recovery).

reoobting without key combos won't reboot into system either.

the only thing that helps is re-flashing the unpatched twrp image over fastboot.

if there is anything i can help with, plz do tell and i'll do anything possible to me!

regards
[Magisk] zelitrex36:
just waw

Thank you so much for the spent to help me. It worked like a charm.

I had a hard time finding if my NFC was working but a phone tester app made its tests with a credit card to test the NFC. From there I could run everything you said.

Unfortunately, I have one last problem and I found it as already been described here :

https://xdaforums.com/t/discussion-...cussion-thread.3906703/page-108#post-83776951

The OP could solve it by wiping datas... That doesn't work for me. Any idea of what I could do ?

Anyway thanks again that was veeeeeery kind to help me like that and taking the time to describe step by step what to do :)

Edit : I realized that I did that not correctly :

If you have PlayProtect certified device, Install Gpay (if necessary), open Magisk app and toggle on Google Pay in MagiskHide list, then reboot. Next, clear Data for Google Pay, then open it and try setting up card(s) / NFC payment.

I did :

Got PlayProtect certified device, opened Gpay, clear Data for Google Pay (and play service and Playstore again). Only then I got what "open Magisk app and toggle on Google Pay in MagiskHide list, then reboot" means and actually did it.
[Magisk] CapnShitzhu:
So through the process of hiding magisk through inapp settings, magisk crashed. And now I only see the Home screen of magisk app only. All the other tabs are gone. So I boot to recovery and reflash the magisk zip but still its the same. So I tried the Uninstaller and it fails too. I think the hiding process crashed before finishing so some stuff are messed and could not be Uninstaller. Anyway to fix this

Magisk. 21.4, Twrp 3.4.0, oneplus 5.
[Magisk] Homeboy76:
Disregard, human error.
[Magisk] pndwal:
I'd forget using Magisk in recovery, at least till you've tried patching boot.img.

Try method I gave @zelitrex36 (after restoring unpatched recovery):

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84614357

It worked for him; see post after yours. PW
[Magisk] pndwal:
Yes, uninstalling Magisk won't fix this as uninstall can't see hidden app.

Just locate and uninstall BOTH hidden manager/app(s), and current manager/app (which are conflicting), then reinstall app for current Magisk root Installation. PW
[Magisk] pndwal:
Restore a previously patched, or unpatched boot image for your ROM. PW
[Magisk] pndwal:
Yeah; If you have any further problems, ensure you toggled on Google Pay in MagiskHide list and rebooted BEFORE clearing GPay's data. PW
[Magisk] J.Michael:
I think even if unrooted, you can install a terminal emulator and run "mount" from the command prompt. The line for "/system" will tell how it is mounted ("ro" vs. "rw").
[Magisk] J.Michael:
I haven't tried it, but I would have thought flashing recovery.img to the boot partition would just give you two recoveries installed. Not a great way to have the device, but I wouldn't expect boot failure.
[Magisk] pndwal:
Yeah, that crossed my mind too...but I don't know, and have never heard of this done in practice.

It could actually be useful, but I don't have an A/B device... PW
[Magisk] zelitrex36:
Hi there, I still have some issues :rolleyes:

But someone told me to never give up so I won't^^

My Gpay problem is still not resolved but I'll post that specific subject in the proper thread to avoid confusion and stick to magisk here.

I have one question and one issue :

Question : when I read "hide magisk" does that refer to :

1)

OR

2)

My issue is : My phone is now rooted and and can't connect to Teams anymore because it detects my phone as rooted. I don't know if it's Teams apk or "portail d'entreprise" which I also tried to hide as you can see on picture one.

Am I missing a module or did I make a mistake ?

Thx for you help. This is actually a bigger problem than my previous one lol (Gpay)
[Magisk] ineedroot69:
you can try using xprivacy lua
[Magisk] Marwan112004:
I want to get the boot.img file necessary for the magisk patching for the Xiaomi redmi note 6 pro
[Magisk] pndwal:
Good you don't have TWRP then!

Answer to 1st question: Without knowing where you were reading, I'm guessing neither. It's probably option Hide the Magisk app, --> Settings / App, last option.

Best tips on apps detecting root / custom mods:

https://www.didgeridoohan.com/magisk/MagiskHide#

-scroll down to Hiding Root from Apps. PW
[Magisk] pndwal:
Actually, it now seems that this method may be reasonable practice for Legacy A/B devices as 'fastboot flash recovery twrp.img' will fail ('fastboot boot twrp.img' works however) as there is no recovery partition for these (although later A/B devices w/ 2SI & boot type ramdisk may include recovery _a / _b partitions), whereas flashing to boot_a / _b works! (until boot image is reflashed with a new OTA etc it seems).

https://android.stackexchange.com/q...rite-to-recovery-using-fastboot-on-a-b-device

Not sure if flashing this way will replace both ramdisk and kernel (don't know how new TWRP builds implement 'Install Recovery Ramdisk' option (which now utilizes Magiskboot to allow repacking boot images)) or the consequences, but only ramdisk (not kernel) should be replaced on these devices it seems. (Ramdisk in boot image is only used for recovery in these devices anyway; kernel is used for both system and recovery.)

https://topjohnwu.github.io/Magisk/boot.html

PW
[Magisk] CSX321:
FWIW, I've never had a problem running Teams on my rooted Pixel 3, even without ticking it in Magisk Hide. It's running right now, and working fine.
[Magisk] HippoMan:
DELETED - I found a more appropriate and "on topic" thread in which to discuss my issue.
[Magisk] Homeboy76:
Thanks for the information, I am going to edit my post (fastboot flash boot lineage17.1...) based on this information.

If the dev replies to my post with a change to the instruction I will modify the instructions and post his reply.
[Magisk] HippoMan:
On my legacy A/B device (OnePlus 7 Pro - GM-1917), I always do this to initially install TWRP:

1. boot phone into bootloader

2. connect phone to desktop via USB

3. (on the desktop machine) fastboot boot twrp-recovery.img

4. (in TWRP) Advanced->ADB Sideload

5. (in TWRP) swipe the "Swipe to Start Sideload" slider to the right

6. (on the desktop machine) adb sideload twrp-installer.zip

7. (in TWRP) reboot to recovery

I never had any problems with this TWRP installation method.
[Magisk] djsolidsnake86:
hello, mi 9 lite and latest miui

i installed magisk 22 from zip (by renaming apk) and now my phone boot only in twrp

also installing 21.4 by zip file it boot to recovery

what do now?

also installing the uninstaller it boot to recovery
[Magisk] gudenau:
Again, I am not using a file manager. :-/
[Magisk] blastagator:
Magisk works fine on cm-13. As Aptiva stated, you need to remove the su binaries located at

/system/bin/su
/system/xbin/su

After that, you need to re-bump the /boot image any time you modify it. An easy way to do this is to flash:

http://xdaforums.com/lg-g2/developm...boot-image-t3325186/post65570427#post65570427

There was another flashable zip that does the same.
[Magisk] slapyhin:
what is magisk?? i cant seem to understand it, even though i read all the posts regarding it, etc...
[Magisk] gnex4us:
Hi everyone.

You all tell that PoGo works. how you do that?

- > flash TWRP

-> terminal echo"SYSTEMLESS=>true"/data/.supersu

-> Flash SuperSU

-> flash suhide

-> xposed

-> magisk

that are all steps i have to do? Or did I forget something between?
[Magisk] Giblet-dono:
As far as my understanding goes:

Magisk a an extensible systemless module platform to replace (system) resources on the fly. =D

Basically, it hooks systemless into the system and can dynamically replace files.

If you decide to "replace" file X, Magisk will hook into the system and anytime file X is asked for it will instead offer your replacement

And it does this all, without the system beign any the wiser

---------- Post added at 07:57 AM ---------- Previous post was at 07:53 AM ----------

As I have said a few times already:

Make SURE you start from a working state (safetynet green)

1. Flash SuperSu 2.78 SR1

2. Reboot to android

3. Flash Suhide 0.54

4. Flash Magisk 7

5. (Optional) Flash Xposed 86.6

6. Reboot
[Magisk] Adromir:
I am trying to build my own rom, which comes with Magisk preinstalled. Its CM 13 based, but I don't get it to work. I have removed CM SuperSU from build and SuperSu 2.78 SR1 is flashed in systemless mode. If I only use that, rom boots fine, whenever i Install Magisk v7 the phone is stuck in a Bootloop. No Matter if I flash magisk during rom installation or later with the Magisk Manager. Does anyone have an Idea what can cause the Bootloop? The Rom is for an HTC m7 (s-off)
[Magisk] Iceyogurt:
Hi, I did just what you said here and passed the safetynet. But dalvik-cache was not generated and some system app crashed because of this. Did dalvik-cache be generated correctly on your device?
[Magisk] Rhoban:
You're not making sense. You said you tried installing it with adb, which didn't work.

Then I asked why you don't download it on your phone and install it normally, like any other apk, and you replied that it didn't work either.

Which I assume means you've tried.

And now you say you don't use a file manager. Well how did you try to install the apk downloaded on your phone if you don't have a file manager? How did you navigate to it?

I have a feeling you are overcomplicating things.
[Magisk] Giblet-dono:
For me dalvik cache works without a problem, might be somethign in the rom you use?
[Magisk] gnex4us:
Sorry for that question. Magisk v6 has rooted the Phone - v7 doesnt do that. Is it right?
[Magisk] JudgeDread11:
Magisk, doesn't root your phone. You'll need phh's superuser or chainfire SuperSU for that. Both with v6 and v7.
[Magisk] gnex4us:
But i can Root t with CF-Root ?
[Magisk] JudgeDread11:
Only systemless root. I don't know if cf roof is systemless.
[Magisk] Artim_96:
You don't need any file manager to install a downloaded apk. You normally get a notification when the download is completed. When you tap in it, the installer opens up. Otherwise most devices had an app preinstalled called "downloads" which lists all downloads. When you tap on an apk there about 99% of the time it opens the installer
[Magisk] ericotena:
Looks like i've found the problem. Im not using the latest twrp. Just flashed the suhide in flashfire. Now the safetynet helper flashed green.
[Magisk] grep_i:
Glad you finally find it.

You could have found much sooner if you followed instructions better.

55 posts ago it was asked you to tell about software versions of everything you use to flash but you fail to answer it properly that's almost 2 days lost bro.

So now your problem is solved can we stay on topic again and let this thread be filled up with questions and discussions about Magisk ?
[Magisk] ariminvm:
I've a similar problem whit my zenfone2.... Magisk v6 works well, but after upgrade to v7 my phone start only in recovery!

what is my mistake??
[Magisk] Sillik:
Hello,

I tried the above steps on a freshly flashed stock rom (without wipe), and it works until step 4 (safetynet included), but if I flash Xposed, the phone seems unable to boot. After the optimisation of the apps, I get system UI force close, then it reboots in a bootloop. The only solution so far is to uninstall xposed.

Has anyone experienced this? Is there any solution?

I should probably ask in the Xposed thread but I thought I'd ask here since I followed the guide above.

Thanks.
[Magisk] drmpk:
samsung galaxy note 4 N910C stock rom.

1. flashed TWRP latest (reboot)

2. flashed SuperSU v2.78 SR1 systemless (reboot)

3. installed magisk manager v2

4. Installed Magisk as prompted in the application (reboot)

5. flashed suhide v0.54 (reboot)

6. Installed the latest version of Material Design Xposed Installer

7. Installed Xposed in Magisk Manager's Download section SDK 23 (reboot)

voila... i get a bootloop

what did i do wrong here?

i dont get a bootloop If i skip step 5, that is if i dont flash suhide

is this my phone issue? most have reported suhide and xposed 86.6 working fine together.

Didnt know where ask for help. so i have posted the same request here too http://xdaforums.com/apps/magisk/magisk-discussion-thread-t3467229/page6#post69060709
[Magisk] Sillik:
It seems to be a Note 4 specific issue! :(

I posted something similar right above...

My phone is a Note 4 SM-N910F.

EDIT: I posted in the Xposed thread about it:

http://xdaforums.com/xposed/unofficial-systemless-xposed-t3388268/page297#post69061290

Also, did you flash the "alt" of xposed?
[Magisk] pndwal:
Yes, seems it should work as stated, and may even have advantages, but I'm not sure what they are, and this is for temporary twrp anyway as Dev indicated.

I'd therefore still favour the well documented boot-only method (which won't alter ramdisk or kernel at all) as long as it works for temporary TWRP booting (; can't see why it wouldn't). PW
[Magisk] Homeboy76:
<edited for clarification>

The instructions are for a Custom Recovery and applies to twrp and the lineage recoveries. This is way Off Topic for this thread so I suggest we wait for the developers response. :)
[Magisk] pndwal:
Try flashing (unpatched) boot.img extracted from your ROM package (check version) from here:

https://xiaomifirmwareupdater.com/miui/

This is the proper way, but if you did a TWRP backup BEFORE attempting root, you could try renaming boot.emmc.win file to boot.img and flashing that.

If flashing using twrp still fails, twrp may be incompatible with your Android version / device. What is Android version & TWRP version?... You may need to use official method (Fastboot flash).

Also, are you sure Magisk in boot works for your device?... What did Magisk app say for 'ramdisk'?... If = no, you may need Magisk in recovery, although it works in boot.img despite ramdisk = no for many Xiaomi devices. PW
[Magisk] pndwal:
Yeah, Pretty much official method for you device too (apart from ADB sideload).

https://twrp.me/oneplus/oneplus7pro.html

A variation of step 4 (or ADB push file) may be a good way to use Magisk zip installer on legacy A/B devices without flashing twrp too. Eg, after taking OTA update, this would eliminate need to download new ROM to extract boot.img for patching. PW
[Magisk] pndwal:
Well, in the context of correct methods (and avoiding unnecessary problems) using Custom Recovery to gain Magisk root on legacy A/B devices (and a still supported method for such devices), are you sure it's not right on topic?...

OT or OT, which is which anyway? 😆 PW
[Magisk] Facebooook:
I am on OnePlus nord magisk show error unable to repack boot image.
[Magisk] ineedroot69:
try changing update channel to Canary also the common cause of Segmentation Fault error while patching your boot.img is that you have incomplete/bad/corrupted boot.img being patch or mismatch file type such as you just renamed boot.zip to boot.img which ofcourse wouldn't work out ...
[Magisk] dope77:
the latest magisk canary is kinda broken on my device (j610f stock 9,0).

first of all after updating and restarting, my phone now takes up to 5 minutes to finish booting,

also magisk isn't loading any modules (core mode not enabled),

i have to restart my device like 3 times for magisk to load the modules.

any advice or logs that could figure out the cause of this problem?

EDIT: forgot to add that system ui is constantly crashing
[Magisk] cloudleon:
J7 Prime with H-Rom A7 Port V6.0(10.0) update Magisk 22.0

Problem

- All application wont start normally and just freeze at start app

- Need to reboot several time to able boot OS

- Using LiveBoot app, can see lots of error from magisk make os take a long time to boot

Once revert back to 21.x, no problem at all
[Magisk] DualJoe:
I have a bootscript in post-fs-data.d to bind mount (overmount) my internal sdcard (with external sdcard/ext4). It worked for years (with edxposed) but recently it prevents magisk modules to work. Its either the bootscript or the modules (bootscript disabled) but not both. The modules (lsposed) just say "not installed". Lsposed also doesn't install the manager app automatically (i have to do it manually) with active bootscript. I also tried service.d folder.

I guess Magisk is still looking at the old mounts when it comes to modules. Is there a more compatible or proper way to overmount /data/media?

bootscript:

#!/system/xbin/bash
chmod 755 /mnt/media_rw
mkdir -p /mnt/media_rw/sdcard1
mount -t ext4 -o rw,noatime /dev/block/mmcblk1p1 /mnt/media_rw/sdcard1
chmod 755 /mnt/media_rw/sdcard1
mount --bind /mnt/media_rw/sdcard1/sdcardint /data/media

LOS18.1

Magisk v22

riru v23.9

lsposed v1.2.2
[Magisk] dethknite:
Same issues here on Pixel5 and 22003. Apps requiring root won't open or open blank. Magisk won't open. Latest fix 22004 seems to work good..
[Magisk] DiamondJohn:
I only glanced over your script, but your path stuck out a mile.

My SDCard is mounted at:

/data/media/0

Since I upgraded to Android 11, the mount at /mnt/media_rw is kind of "funky". If I browse to /mnt /media_rwI cannot see any, but if i access it directly via the shell, it is accessible. But even then, its not under "sdcard" anymore.
[Magisk] seanbaggey:
Anyone have any idea how to resolve magisk somehow getting installed as a system app? It definitely didn't come with the rom I'm running for my Samsung Tab S3. I'm pretty sure it was just a simple zip flash in TWRP, followed by installing a canary version of the manager apk then updating within the app. I'm trying to start over and uninstall/reinstall, but because it's a system app I don't know how to get rid of it. I've tried uninstalling from within the app, and I've tried renaming the apk to uninstall.zip and flashing in twrp, but after flashing and booting the app remains.
[Magisk] ineedroot69:
you issue with boot image repacking is being fix just wait till it get release as Stable or you can try changing magisk update channel to Canary