yashsingh1/xdaforums huggingface dataset:
[Magisk] topjohnwu:
I think you misunderstood my intention. What I mean is that since SuperSU will not work, I believe people will start to flood your thread with requests for Magisk support. I don't want this to happen, because my SuperSU is not working as you expect it to be, there is no need for users to report bugs about Magisk support.

I said that I would contact you once you're back from vacation with the details. It's my bad not to leave you a message, since I don't know when your vacation is over.

The first thing I tried to work on is SuperSU, however because the solution is too complete by itself, it is difficult for me to do any adjustments to the solution. (I'm aware that I'm not allowed to do so without your permission, learned the lesson.....). That's why I started to look on the other root solution. And things went well and I got excited and released the first version of Magisk, that recommends phh.

The biggest misunderstanding here is that the supolicy patch is for Magisk itself to work properly (especially Samsung devices), it is not to fix phh's root. phh's root is working on its own (the inclusion of supolicy stated in the 2nd post is not true currently, I removed it soon after the release as I found out it's inappropriate but didn't edit the post), it's just one of my demo projects to showcase the potential of Magisk.

I know all these are excuses, and I have to say again that I'm sorry for not being aware of the things I've done is actually harmful.

Thanks for the kind words :)

Actually, in my Magisk version v3 v4, I do kill all processes and the su daemon, because at that time some people has positive report, some have negative reports, so I went aggressive and kill everything and set a countdown to initialize root after the timeout is finished. Right now thanks to more people testing, it's clear now that Android Pay checks root access in the background regularly, and sometimes it requires users to manually add a card (just need to press the add card button) to trigger AP to refresh its cached root check.

However it involved the open source root and I know it's not welcomed to you so I'll stop here.
[Magisk] teddy0209:
Good to hear that!!! ???
[Magisk] AndroidGee209:
Anybody?
[Magisk] hua_wuxin:
Have you added any new file (not just replacing) into /system or its sub folders via magisk?
[Magisk] AndroidGee209:
Only thing I've done was flash magisk and phhs' superuser, and after boot I check my camera and I just get a pop-up saying " Warning camera failed". I've tried this on both a touchwiz from and AOSP rom and still the same l.
[Magisk] soder:
Great. Thanks.

I'm right now on SuperSU 2.77 (but will reflash stock COS13.1.2 on my OPO before trying all this). Will that work, or do I need to install some kind of modded SuperSU version or something else? I don't really understand what I need to do..

EDIT: I found the modded SuperSU 2.76. Running Xposed systemless now. Still haven't been able to use it in any nice way though. Also, installing the new Nexus launcher with .zip will make changes to /system any way I guess. =(

/Söder
[Magisk] CrazyCypher:
[MENTION=4470081]topjohnwu[/MENTION] and [MENTION=631273]Chainfire[/MENTION]

Now that I read things from both perspectives, I think you both overreacted somehow :) The way I see it topjohnwu included the binaries just for temporary solution and I agree it was not pretty correct but otherwise systemless xposed and Magisk are two amazing products that should be developed further..

If I am honest I really hope you two will work together so that systemless xposed and Magisk will be compatible with systemless SuperSU so we wouldnt need phh superuser... And that those three will be in harmony in the future :)
[Magisk] AndroidGee209:
Here's another logcat for the camera issue I'm having.... I see something about an invalid cameraid? But if I Uninstall Magisk everything goes completely back to normal
[Magisk] mykenyc:
I absolutely love when people can hash out things and move on, i friggin' love magisk though.
[Magisk] CrazyCypher:
Hy topjohnwu, I need your advice.. I have latest Magisk, phh's superuser and systemless xposed fully working along with elementalx kernel. Now, because i have unmodified system and can receive OTAs, will all of those be still installed after OTA? I know ElementalX will be gone but what about Magisk, phh's superuser and systemless xposed?

Thank you for answer, I appreciate it :)
[Magisk] teddy0209:
I think you're right, only the boot.img will be replaced and everything will still be there, except that you might need to reflash magisk itself (without reflashing all magisk mod superuser/xposed etc.).
[Magisk] CrazyCypher:
yes I know boot.img is replaced but what exactly is on boot.img that needs to be reflashed? I dont know if I have to flash phh's superuser zip or not, or magisk zip, etc.. :)
[Magisk] AndroidGee209:
So I've tried flashing a stock camera zip and still the same, so something in the magisk zip is breaking my camera.
[Magisk] Tkkg1994:
On boot.img is: magisk, supersu/phhs root, xposed

Sent from my SuperMan powered SM-G930F
[Magisk] rgawenda:
No.

Only Magisk is on boot partition, modules are installed on /Magisk (/data/Magisk.img). When boot is rewriting and you flash Magisk again, it'll find your previous modules there, as /data was untouched.
[Magisk] KAsp3rd:
All you would need to flash again would be the magisk zip. Everything else is stored in /data/magisk.img
[Magisk] soder:
Yesterday I managed to flash magisk and the systemless version of Xposed and correct version of SuperSU (the modded version).

How ever, I still couldn't use the video streaming apps I had problems with before, with licensed movies not being able to play on my rooted device.

Also, reading this, https://twrp.me/faq/officialota.html means that I'm still not able to use the OTAs that my phone receives.

Root-Cloak module in Xposed has never really worked for my apps to hide root (at least not for the video apps I said).

I know there was some other kind of root to use if being able to use Android Pay. Since I'm on COS13.1.2 and in Sweden I guess I will never be able to use that, but should I use that other kind of root also if I want my video streaming apps to work? And, with this systemless root and all this, is then Root-cloak unnecessary?

Thanks.

/Söder
[Magisk] Artim_96:
Yes, try phh's SuperUser. Then, before opening one of those apps, go into Magisk manager and disable root.

And no, for all I know AP should work even on custom ROMs with Magisk, as long as it's available your country
[Magisk] tdunham:
Sure thing thank you.

http://www.mediafire.com/file/2ndejun3mmv563g/Note5_Boot_images.zip

Just to be certain I get what you need, I am pulling patched boot img with adb shell command:

dd if=/dev/block/platform/15570000.ufs/by-name/BOOT of=/sdcard/boot.img
[Magisk] Raijin:
Thank you! ?
[Magisk] tdunham:
Just a sidenote, if a system app has taken an update, uninstalling will uninstall the data/app update only, it still wont remove the system/app though.
[Magisk] fhk:
I've seen the same. Have roor-hiding abilities been impaired in v12 as compared to v11.6? I have DME (corporate mail app) working perfectly on v11.6 (root effectively hidden), in v12 it detects root... So I've had to revert. Any workarounds for this?
[Magisk] Didgeridoohan:
With Magisk v11.6, Magisk Hide also changed a few ro.build prop values by default. This was reverted in v12 because it can cause to many issues. Better to leave it to the user...

Your app probably looks for props such as ro.build.tags being set to "test-keys" and if they are, refuses to work. This is probably why v11.6 works and v12 doesn't.

You can change prop values with a script or a Magisk module. You can find some more details from the link in my signature (look for "Dangerous props").
[Magisk] ew:
I noticed that under downloads in the app there a few xposed frameworks that are available. I know that this is not the forum to discuss xposed. Is there a place to find out more about the xposed frameworks - or for that matter any other downloads that are available for Magisk?
[Magisk] Didgeridoohan:
Most of the modules have a bit more information in the readme, if you click the module in the list. There's also usually a link to the support thread or GitHub for more info.
[Magisk] Rymek0:
Hi i know it isn't directly Magisk but we need to do something about AP and google **** moves trying to stop xda forums members from using AP. Recently i tried to make AP work on Magisk and failed. Then i tried to wipe all but sdcard and i've installed only 7.1.1 PureNexus rom without root and it still won't work i think what we need it's strong social media campaign using memes and hashtags to make google treat us with love we deserve. #loveforxda make it trend
[Magisk] Didgeridoohan:
[OT]Did you lock your bootloader after installing PN? SafetyNet won't pass with an unlocked bootloader without using some way of masking it (Magisk or a kernel that doesn't report the bootloader state).

And... What you're talking about is not gonna happen...[/OT]
[Magisk] Clandaries:
OK, Magisk hide 12 on my G935F does not work with my banking app.

But on my G900F it is working.

Just want to say :)
[Magisk] Artim_96:
It's already well known that especially banking apps can't be bypassed. And since you don't even mention the apps name for others to search for and find that, hoping that it prevents hundreds of others asking the safe thing over and over again your post says absolutely nothing relevant and you just managed to waist your and the others time writing respectively reading this post. Congrats.
[Magisk] wz68XDA:
My root is now disappearing when changing networks... I guess I only had a temporary fix...
[Magisk] enzoevo:
Try installing ElementalX or Franco kernel. I have 7.1.1 PN with root and am passing safetynet and am using Android Pay to make purchases. Make sure you install the kernel after flashing Magisk. Good luck and happy flashing.
[Magisk] yochananmarqos:
How is Magisk going to patch the current boot.img if you flash a custom kernel after? EX does not modify the ramdisk, so it might not make a difference but Franco does.
[Magisk] enzoevo:
You're right I misspoke about Franco. I was actually thinking of Elite Kernel which like ElementalX doesn't modify the ramdisk. I've been using ElementalX for a while now and always flash it last.
[Magisk] nathanchance:
EX definitely patches the ramdisk on almost every device it is made for... However, the modifications do not conflict with the ones that Magisk does. That's why you can flash Magisk before or after and it doesn't really matter (unless you want a clean boot image backup, in which case flash Magisk first). In fact, no custom kernel should conflict with those modifications.
[Magisk] culiacanazo:
Ok I got lost, when do you flash magisk first and when last, again?
[Magisk] teddy0209:
Flashing magisk after is ideal... Flashing the other way will depend on the kernel format (might work, may not work)...
[Magisk] culiacanazo:
Cool, thanks!

And the latter would be good (if applicable) because...? :confused:
[Magisk] teddy0209:
There would be no difference...
[Magisk] culiacanazo:
Ten four!
[Magisk] xNotta:
Could someone look into porting MinMinGuard to a Magisk module?

It is an xposed module that is an incredible ad remover. I don't think it uses the host file at all. I can't find anything else like it.

http://repo.xposed.info/module/tw.fatminmin.xposed.minminguard

https://fatminmin.com/pages/minminguard.html

https://xdaforums.com/xposed/modules/xposed-minminguard-v1-7-0-cancelled-t2597332
[Magisk] Clandaries:
My post says that...

On my G935F it is NOT working.

But on my G900F it IS working.

So it says nothing... OK ;)

Both are running Magisk 12 with MagiskSU and MagiskHide.

Banking App is HVB Banking Germany.

Greetings
[Magisk] teddy0209:
Magisk and xposed are two different things... If you're on N and therefore cannot use xposed, you can use other adblock apps as alternative..
[Magisk] xNotta:
I know they are different and I am currently using Adaway (systemless hosts). I still get ads despite having every current list and dns ad blocking.

MinMinGuard actually removed ads, not just blocked them causing the ad to fail to load.

I just wanted to put the idea out there to show that there might be significant interest in a similar Magisk module if it's possible.
[Magisk] kyzn:
I use Adguard in HTTP proxy mode and that pretty much works as AdAway + Minminguard.
[Magisk] teddy0209:
I don't think it's possible without xposed...
[Magisk] xNotta:
Thank you, that's what I was thinking too.

It is open source and I forgot to include the repo:

https://github.com/chiehmin/MinMinGuard
[Magisk] teddy0209:
Yeah, I've used minminguard before (still installed), I switched to adblocker reborn + systemless host...
[Magisk] xNotta:
Do you see ads in Tapatalk or at the bottom of eBay saved searches?

Those are the ones that I can't get blocked.
[Magisk] robgee789:
hey guys does magisk affect any ota updates?
[Magisk] Didgeridoohan:
Yes. You'll have to restore your stock boot image before updating through OTA. Possibly also the recovery.

And if any of the root apps you use have made any kind of modifications to the system, the OTA will fail.
[Magisk] Artim_96:
Then they are probably build into the app. Some apps seem to bring their own ads to be able to show them even when they can't load the normal ones. That probably can't be removed by ad blockers
[Magisk] Jean_85:
Since a few hours ago the SafetyNet check started failing :( Magisk says that the CTS fails, using the SafetyNet helper, it says that even the basic integrity check is failing now.

Inviato dal mio Nexus 5X utilizzando Tapatalk
[Magisk] Didgeridoohan:
Have you made sure that it's not just Magisk Hide not starting after a reboot? Easy to see in the logs and fixable by toggling Hide off and on again.
[Magisk] Jean_85:
Toggled and rebooted, the logs are ok:

** Magisk post-fs mode running...
** Magisk post-fs-data mode running...
* Running post-fs-data.d
* Loading core props
** Magisk late_start service mode running...
* Linking binaries to /sbin
* Starting MagiskSU
* Running service.d
* Starting MagiskHide
MagiskHide: Moving and re-linking /sbin binaries
MagiskHide: Removing dangerous read-only system props
MagiskHide: resetprop by nkk71 & topjohnwu
Initializing...
Modify data structure: 'ro.boot.verifiedbootstate'='green'
Existing property: 'ro.boot.verifiedbootstate'='orange'
Recheck property: 'ro.boot.verifiedbootstate'='green'
Done!
MagiskHide: resetprop by nkk71 & topjohnwu
Initializing...
Modify data structure: 'ro.boot.flash.locked'='1'
Existing property: 'ro.boot.flash.locked'='0'
Recheck property: 'ro.boot.flash.locked'='1'
Done!
MagiskHide: resetprop by nkk71 & topjohnwu
Initializing...
Modify data structure: 'ro.debuggable'='0'
Existing property: 'ro.debuggable'='1'
Recheck property: 'ro.debuggable'='0'
Done!
MagiskHide: Killing com.google.android.gms.unstable
MagiskHide: Starting MagiskHide daemon
MagiskHide: Update process/package list:
MagiskHide: [com.google.android.gms.unstable]
Zygote(0) ns=mnt:[4026536579] Zygote(1) ns=mnt:[4026536580]
MagiskHide: com.google.android.gms.unstable(PID=10305 ns=mnt:[4026536597])
MagiskHide: Unmounted (/sbin)
MagiskHide: Unmounted (/magisk)
MagiskHide: com.google.android.gms.unstable(PID=14728 ns=mnt:[4026536711])
MagiskHide: Unmounted (/sbin)
MagiskHide: Unmounted (/magisk)
MagiskHide: com.google.android.gms.unstable(PID=19016 ns=mnt:[4026536666])
MagiskHide: Unmounted (/sbin)
MagiskHide: Unmounted (/magisk)
MagiskHide: com.google.android.gms.unstable(PID=20382 ns=mnt:[4026536649])
MagiskHide: Unmounted (/sbin)
MagiskHide: Unmounted (/magisk)
[Magisk] alego500:
[MENTION=4470081]topjohnwu[/MENTION]

Do you have any plans to implement Root Cloak like features to Magisk Hide?

I for example have a banking that which from what I can discern checks for things like apps with the word root or xposed in the package name, and therefore I still have to enable xposed to use rootcloak.

Would it be possible to build this kind of functionality into a Magisk Module?
[Magisk] Didgeridoohan:
And does SafetyNet pass now or not?
[Magisk] F8X:
I tried to install Magisk v12.zip in TWRP ,but it fails , saying

LOG :

]First lines dont matter, i believe.]....

! SuperSU image mount failed ...

! Magisk scripts are placed correctly

! Flash SuperSU immediately to finish installation

Updater process ended with ERROR : 1

Error installing zip file 'sdcard/Magisk-v12.0.zip'

Updating partition details

. . . done

Tried both with and without root,If that's even an option.

{ S6 EDGE -Android 6.0- Custom ROM (CardHD) , with SuperSU
[Magisk] 135Shadowsoul:
Hi,

2 question:

1. does MagiskHide still works with latest (today) SN update?

2. does magisk install falsh-zip remove LOS built-In root? currently using this rom with LOS "stock" root.

thanks for answer :)
[Magisk] Didgeridoohan:
Have you tried doing what it says and flash SuperSU?

What's your version of Google Play Services?

Magisk Hide is working for me and I can pass SafetyNet, but that might just mean I haven't gotten any update yet, if there is one.

The Magisk installation script attempts to remove any root that isn't MagiskSU or systemless SuperSU.
[Magisk] 135Shadowsoul:
there was no Play Services update, just SafetyNet API update as far as i know. currenty play serv. v10.5.45 (438-150087156)

as far as i know, SN does not require play services update.because even if they are auto-updated, with Sophos i get noticiation if anything auto-updates, cause it scanns all installed apps, but i did not get any notification arround today/yesterday (sorry for german link...).
[Magisk] Didgeridoohan:
Well, that's a newer version of Play Services than I have (on this device at least, I'll look at my other ones when I get the opportunity). Looks like there was an update released 6 April. It takes a while for it to roll out though...

I guess we'll see over the next few days if Magisk Hide won't be able to make SafetyNet pass anymore.

Edit: or you could install Magisk and see if you pass SafetyNet...
[Magisk] Jean_85:
Nope, still failing. The reply above seems to suggest that SafetyNet just updated today, so maybe that's way now it's failing :(

Inviato dal mio Nexus 5X utilizzando Tapatalk
[Magisk] Didgeridoohan:
Could be.
[Magisk] 135Shadowsoul:
do i fully uninstall magisk and revert all its changes if i just (dirty) flash current ROM (with gapps, as there is no script to backup/restore them)?
[Magisk] Didgeridoohan:
That would work. You could also flash the uninstaller zip.

Edit: Of course, you'd have to reroot after flashing the uninstaller...
[Magisk] 135Shadowsoul:
in-magisk SN test and SafetyNet attest both tell me CTS-Profile mismatch. Added play services + test to hide-list and even rebooted. no chance :(

i will reflash rom to have "rom stock root" :(

€dit: Samsung Galaxy S4 GT-I9505 with LOS 14; Magisk Root
[Magisk] YoshiFrance:
I try to install Magisk on my N7 2013 and Moto X 2014.

On my N7 : uninstall SU binaries (LineageOS) and install Magisk. Safetynet pass

On my Moto X : uninstall SU binaries (LineageOS) and install Magisk. But Safetynet fail (cts profile mismatch : false)

I try clean install (wipe data / factory reset) : flash last release from LineageOS, flash OpenGapps and flash Magisk. But Safetynet fail again (cts profile mismatch : false).

I disable Busybox, hosts systemless, ADB and activate Magisk Hide, but no change.

Why my N7 can pass Safetynet but no my Moto X ?

Moto X :

ROM : LineageOS 14.1 / Unlocked bootloader

Kernel : stock (by LineageOS)

SELinux : Enforcing

Nexus 7 :

ROM : LineageOS 14.1 / Unlocked bootloader

Kernel : ElementalX but Safetynet work with stock kernel

SELinux : Enforcing
[Magisk] culiacanazo:
#@$%&! Google!
[Magisk] YoshiFrance:
I'm not stupid, I use Google, I test a lot of solutions found on Google, but no solution work.
[Magisk] Didgeridoohan:
I think he means there might be a possibility that SafetyNet has been updated to bypass Magisk Hide...

Talking about that what's the Play Services version on your two devices?
[Magisk] barret95:
has anyone had any issues with the stock camera?

since i installed magisk on eXisten N on XZ the error "Camera in use by another application" .

Before i had magisk the camera worked completely fine
[Magisk] gk1984:
Haven't been following for a while so not sure of the context entirely. But still passing on my Nexus 6 with stock rom and Magisk hide enabled. Possible I didn't get a Play Services update that might be causing this though. Just wanted to chime in.
[Magisk] YoshiFrance:
N7 : 10.2.98

Moto : 10.5.48
[Magisk] Didgeridoohan:
Yeah, I can pass as well, but I don't have the latest play services on any of my devices yet...

---------- Post added at 17:06 ---------- Previous post was at 17:06 ----------

Yup... That points to a SafetyNet update...
[Magisk] culiacanazo:
:laugh:

I'm cursing google, not issuing a command!

:silly:
[Magisk] Jean_85:
My N5X: 10.2.98 and it's failing...
[Magisk] YoshiFrance:
I installed 10.2.98 on my Moto, but no working.
[Magisk] 135Shadowsoul:
like i have said, SafetyNet calls are not dependiung on play services version. they are implemented ofc, but i think, they do not create the CTS-Profile.
[Magisk] sscsps:
My safetynet Checks are passing...

Who all are facing the fails?

we've been having some issues with safetynet on custom roms for our device(LeEco 1s) but on stock, with magisk, its working fine, I checked 10 minutes ago and it passed.

Attached is my check from 10 minutes ago.

[MENTION=3562931]Jean_85[/MENTION] are you still facing it?
[Magisk] Didgeridoohan:
Well... Until anyone can confirm a SafetyNet update all this is just hearsay and conjecture anyway. I'm gonna have some dinner. Peace, out!
[Magisk] tag68:
You don't need to add anything to the list. SN gets hide by default and gets green with empty list. But you need to enable Magisk hide under settings. Did you do that?
[Magisk] teddy0209:
Still passing here...[emoji6]
[Magisk] rjyoung00:
Failing here as well.

Moto X Pure 2015 Resurrection Remix Rom

Android 7.1.1

Play services 10.5.48
[Magisk] Karls0:
I'm on android 7.1.2, april security updates. Still passing SafetyNet ;).

Why you think play services itself has something to do with SafetyNet? I think it is in security patches.
[Magisk] Didgeridoohan:
The SafetyNet API is a part of Google Play Services. That's how Magisk Hide passes SafetyNet, by adding the Play Services to the Hide list by default.
[Magisk] Karls0:
That's true, but I think that main part of SafetyNet is connected with security patches. It would explain why on older patches you can hide Xposed but on new not.
[Magisk] Didgeridoohan:
Nah... From what I understand, that's all about security measures introduced with the November 2016 security patch, not SafetyNet. And think about it: If SafetyNet was tied to the monthly security updates, how would Google have any control over it if the OEMs don't push the updates?
[Magisk] 135Shadowsoul:
did, but no chance. and as i read in this thread, im not alone.

the dev of iSu mentioned something iSu thread. You may have a look at his post. maybe some1 has an idea how to solve this. (maybe the idea helps magisk dev, too).

He also mentioned a idea, how to still pass with magisk. (Full clean wipe/installation of rom, play services and magisk before first boot)
[Magisk] Jean_85:
Yeah I'm still failing the check..

Inviato dal mio Nexus 5X utilizzando Tapatalk
[Magisk] masteruniverse:
I reboot my S7 than Synapse have no root permission all settings normal then with SuperSu didnt have those problems
[Magisk] Artim_96:
And what does the manager say? Do you have root? If not, send since logs
[Magisk] teddy0209:
With both enabled, i get none, including in apps... With just the host, some still appears...
[Magisk] mims1979:
A few people have asked but I've yet to see an answer.

How do I remove system apps with v12. Rom toolbox, etc all don't remove system apps despite having root access.
[Magisk] SDMU:
https://play.google.com/store/apps/details?id=com.jumobile.manager.systemapp

Did you try this ?
[Magisk] mims1979:
Just did, no love...

---------- Post added at 03:32 AM ---------- Previous post was at 03:28 AM ----------

For that matter, I can't even modify/delete files in /system