yashsingh1/xdaforums huggingface dataset:
[Magisk] ipdev:
Hi all. :)

As I have mentioned before.

With today's (Dec. 14 2021) commits.

Magisk - GitHub - Building and Development - Link

Besides fixing the Google December update root issue on the Pixel 6 series.

It seems to fix the Android 12 issue that affects..

Pixel 4a (5G) [bramble]

Pixel 5 [redfin]

Pixel 5a [barbet]

Pixel 6 [oriole]

Pixel 6 Pro [raven]

No need to disable verity, verification and wipe data. ;)​

I do not have a 4a (5G) [bramble] or a 6 Pro [raven] to test on.

Did a rapid-fire test tonight on my 6 [oriole] and 5 [redfin].​

Note:

My rapid-fire testing is just looking for one result.

I do not gather logs or fully configure devices.

It is more a speed run, so as little steps as needed to test one thing.​

Example of steps from my 5 [redfin]

Using the full Factory Image builds.

Did a full clean flash of the last Android 11 (SDK30) build.

No modification to the flash-all script.

fastboot -w update image-redfin-rq3a.211001.001.zip

Skipped though SetupWizard.

Installed Magisk canary debug 23001 (f822ca5b) [May 2021 build].

Did a quick setup, enabled MagiskHide and Systemless Hosts module.​

Reboot to bootloader and updated to November's Android 12 (SDK31) build.

Modified the flash-all script to remove the wipe.

fastboot update image-redfin-sp1a.211105.003.zip

Uninstall the Magisk app.

I knew I would have to do this because of app signing key.

Those using John's builds will not have to do that step.​

Install the current (a4faa3f3) Magisk (personal build) app.

Patch the sp1a.211105 boot image.

Reboot to bootloader and boot the magisk patched boot image.

Used the Direct install method to patch the installed (stock) boot image and rebooted.

I hope John releases canary 23016 soon. ;)

Cheers all. :cowboy:
[Magisk] Lughnasadh:
Great work and info! I've been casually following the work that is going on about not having to disable verity and verification or wiping data on the Pixels 4a5G and later on GitHub (e.g. capntrips). Saw this commit and was wondering if it made it into John's test build of this morning and whether that was the commit that removes the need to disable verity, verification and wipe data? Could you shed some light on this? Looking at the timing it seems that that commit might not have made it into the test build that fixed the fstab problem on the Pixel 6 series.

EDIT: Just saw that Canary has indeed just been updated to 23016 so I guess that makes my question about whether that commit made it into John's test build of this morning obsolete 🙃

Thanks again for all the great info 👍

https://twitter.com/i/web/status/1470993874923388933
[Magisk] ipdev:
Thank you for pointing out some more Magisk confusion. 🙃

I added a note about it to my rough draft.

I will word it better later. ;)

Cheers. :cowboy:
[Magisk] ipdev:
I did not have time to check to see if I have a device close enough to yours to double check.

It has been a long time since I remounted as RW while booted into system.

One command that someone suggested to me years ago when I was having an issue remounting system.

mount -o rw,remount,rw

Remount Read Write.

mount -o ro,remount,ro

Remount Read Only.

Not sure if it will help.

I do not remember the root method, device or Android version I was running at that time.

Cheers. :cowboy:
[Magisk] Utini:
So if I already rooted my P6 Pro last month (which needed to disable verity, verification) would I now have to completely wipe, flash december and then root without disable verify & verification?
[Magisk] pndwal:
Latest Canary Magisk:​

Magisk (92546e8a) (23016)​

Fixed a possible AVB header misalignment

Add new env variable PATCHVBMETAFLAG to configure whether vbmeta flags should be patched

Only hijack unshare calls with CLONE_NEWNS bit set

Improved support for devices with oplus.fstab (OnePlus/Oppo/Realme)

Support loading fstab from /system/etc (Pixel 6 Dec. Patch)

Various Magisk app fixes

Diffs to v23.0​

[General] MagiskHide is removed from Magisk

[General] Support 64-bit only systems

[General] Support Android 12

[General] Update BusyBox to 1.34.1

[Zygisk] Introduce new feature: Zygisk

[Zygisk] Introduce DenyList feature to revert Magisk features in user selected processes

[MagiskBoot] Support patching 32-bit kernel zImages

[MagiskBoot] Support boot image header v4

[MagiskBoot] Support patching out skip_initramfs from dtb bootargs

[MagiskBoot] Add new env variable PATCHVBMETAFLAG to configure whether vbmeta flags should be patched

[MagiskInit] Support loading fstab from /system/etc (required for Pixel 6)

[MagiskInit] Support /proc/bootconfig for loading boot configurations

[MagiskInit] Better support for some Meizu devices

[MagiskInit] Better support for some OnePlus/Oppo/Realme devices

[MagiskInit] Support init.real on some Sony devices

[MagiskPolicy] Load *_compat_cil_file from system_ext

[MagiskSU] Use isolated devpts if the kernel supports it

[MagiskSU] Fix root shell if isolated mount namespace is set

[resetprop] Deleted properties are now wiped from memory instead of just unlinking

[App] Build a single APK for all ABIs

[App] Switch to use standard bottom navigation bar

[App] Downloading modules within the Magisk app is removed

https://github.com/topjohnwu/magisk-files/blob/b368d20076a30879ccd289b8a4766ba3b88da547/notes.md

👍 PW
[Magisk] pndwal:
Latest vvb2060 Alpha Magisk (Unofficial Build - for mavericks only!) Translated:

alpha update log​

Magisk (0c1f6881-alpha)​

[App] Support SharedUserId

[App] Delete the backup file after restoring the boot image

[App] Built-in current version update log

[App] Use local version when unable to download stub

[App] Modern time API using Java 8

[General] No longer automatically unlock the device block

[General] Use MagiskHide to hide when Zygisk is closed

[App] Delete markdown rendering

[General] Do not execute scripts that have ignored loading modules

[App] Fix that the second time tapping the hidden app button may be unresponsive

[App] Enhance the function of repairing environment

[App] Support setting PATCHVBMETAFLAG flag to process vbmeta in boot image

[App] Adapt to Android 12L

[General] Magisk is not loaded when entering DSU, it is not compatible

how to install?​

Install and uninstall Magisk through the Magisk application. Generally, it should be done directly in the application. In special circumstances such as the first installation, the image should be patched and then flashed in with the fastboot/odin tool. Customizing Recovery is not a supported way.

Complete changelist incl. Upstream update log here:

https://github.com/vvb2060/Magisk/b...fd56bf78bc6/app/src/main/res/raw/changelog.md

👍 PW
[Magisk] Rumsfield:
Just open magisk and install latest canary build of manager and then update your boot.img with the in-app flasher. That is if you are already on the latest P6PRO firmware.
[Magisk] Utini:
I am right now on a Android Firmware which has veritfy disabled.

To updat to december firmware I have to either flash with verify disabled (no wipe) or with verity enabled (this wipes the devices).

Which state do I need for future magisk? Verity enabled or disabled?
[Magisk] Rumsfield:
fastboot update --disable-verity --disable-verification "image-codename-buildnumber.zip"

At this point it should always be disabled when you flash the next monthly firmware.

From another post:

Open the folder you extracted the Factory Image to and Edit the

flash-all.bat file

with a file editor i.e.,

DroidEdit app or NotePad++.

Change this line:

fastboot -w update image-"image name.zip goes here"

to this: fastboot --disable-verity --disable-verification update "image-codename-buildnumber.zip"

Note: If you do not remove the

-w

your internal storage will be wiped.

After, you have edited the flash-all.bat file. Copy/Move these files to the Platform-tools folder:

bootloader-....img

flash-all.bat

image-....zip

radio-...img

Open a Command Prompt on your computer in the Platform-tools folder and type: flash-all at the Command Prompt and press enter.

The phone will reboot when flashing is completed.
[Magisk] replica9000:
I don't know if my phone ever lost it's certification status. Banking apps haven't stopped working. Netflix is from the play store. It's always reported L3, but this is the first time the Play Store refused to update it. I did put the Play store and carrier services in the Deny list, and Netflix updated. Device still reports L3 though.
[Magisk] Utini:
But the magisk changelog states that --disable-verity is not required anymore?
[Magisk] pndwal:
Interesting trick!... I have nothing Google in denylist other than GPay...

Widevine L3 may simply restrict you from streaming HD and not inhibit updating etc, I'm not sure. (You'd need to search if your device ever supported L1; low spec devices didn't anyway AFAIK.) I note @BillGoss has L1 on same device with Magisk root however.

However... I just checked Netflix (I have it installed but don't use) in Play Store search, and lo, I had the same problem; refused to show, device still 'certified'!...

I suspected Play Store had cached some flag while I played with Magisk / SafetyNet / Shamiko recently, so I cleared Play Store data and walla! - Fixed and showing again. 😛

I suspect this may be what has occurred on your device / all you need to do... May want to try it and remove Google stuff from denylist (other than GPay 😉). PW
[Magisk] pndwal:
Bit more clarity on Pixel 6 issue / fix here and insight on general issues re device complexity for both Android AOSP and other Google Devs as well as custom solution Devs like TJW:

www.twitter.com/shawnwillden/status/1470875909162889216

Conversation between John, Shawn and Luca. Worth noting their job descriptions!

👀 PW
[Magisk] Lughnasadh:
Yep, already saw that conversation 👍
[Magisk] vandyman:
Is it still necessary to uninstall Magisk before updating the the firmware?

I have not seen anything mentioned on this topic for awhile.

It has been known that some modules could interfere with a monthly update.

I am currently on the December update w/canary16 and no issues on my P6. And I did the Magisk uninstall as usual.
[Magisk] Lughnasadh:
It's not necessary to uninstall Magisk before updating, but it is always wise to disable Magisk modules until you know they work on the newer build or they are updated, especially ones that modify System UI, framework and similar.
[Magisk] Eng.Raman:
Finally, My Happy Momo. :giggle:(y)
[Magisk] klemi71:
If you hide magisk app, better unhide it before updating, too. So: unhide, disable modules, reboot, update, reenable modules. Hide again.
[Magisk] rodken:
I suppose this same method can be applied whenever updating Magisk itself, considering the variations [forks] of Magisk out in the wild - you can never be too careful.
[Magisk] mrjuniork:
Does anyone have any idea why hiding the Magisk app (repackaging) wouldn't work? A new app is successfully created but won't open and the setting itself within the Magisk app is still showing me that I can tap to hide.

(I'm on 23001)
[Magisk] zgfg:
Are you on the old Canary 23001?

There is probably a missmatch when downloding the stub (if it finds the stub for new Canary 23016)

IMO, either replace Canary app 23001 with the Stable app 23000 (in case you're still on the old Magisk v23 from the spring this year). In that case you can stay using Magisk Canary 23001, switching only the app to Stable v23

Or update to the latest Canary 23016 (assuming you are fully aware what are the news - everything was 100 times mentioned here but if not familiar with, then don't jump into)
[Magisk] mrjuniork:
Yeah I'm on the old canary.

I just switched the app to stable 23 and it finally works. Thanks a lot!

I have been following this thread for quite a while now, so I'm aware of the possible risks jumping into it. For me personally, there is no need (yet) to upgrade.

Again, thx for steering me in the right direction, highly appreciated 👍🏼
[Magisk] zgfg:
Also, double check/switch the Update channel to Stable - otherwise you might have a similar problem if/when you would try to restore the repackaged Magisk app
[Magisk] pndwal:
I'm a little confused here: you can see hide option in which app?... do you have dual apps installed? PW

Edit: Shoulda refreshed!.. see you've solved it. 👍
[Magisk] zgfg:
Already resolved (I know, Australia is far away🤪)

Btw, if there were issues with hiding the app for 23016 - in Alpha 0c1f6881 it works seamlessly (back and forth)
[Magisk] pndwal:
I've waited till now to update (Alpha) also, and strangely had the same issue, but while updating.

I updated with app hidden (I recommend restoring first; just wanted to test as fails w/ many builds / configurations) and could still see original hidden app + partially installed 'Magisk' that asks to allow download to complete setup, but always fails to do so (ie had dual apps even if not complete).

I simply uninstalled original 'hidden' app (both icons disappeared at once) then installed new app from Magisk download path (initial attempt leaves this there) and walla! - App (not now hidden) opens fine!...

Note for Alpha users: There have already been 2 23016 builds. The second (version I posted release notes for above) fixed Hide the Magisk app issue.

Note.2. Australia can appear small in your rear-view mirror, but beware!... It may be closer than you think... n don't be fooled by the size of NZ either... PW
[Magisk] Parasol_Monsters:
Hello everyone.

How can I install and older Canary build (23014)? The last 2 have been bootlooping for me.
[Magisk] moocow1452:
Followup:

Managed to get Write on root with the Oculus with 'echo 0 > /sys/fs/selinux/enforce'. ty @pndwal and all. ChinaLinda on GitHub managed to get SuperSU working on hers per

https://github.com/ChinaLinda/OculusGoEthernet/blob/main/add_super_su.md , but when I tried to push a new default.prop, it's stuck on boot screen and I have to reflash. Is there a particular Chmod I have to set on the new default.prop, or once I disable selinux, Magisk should install aok?
[Magisk] pndwal:
Repo here; search by date and check versions:

https://github.com/topjohnwu/magisk-files/commits/canary. PW
[Magisk] replica9000:
I'm not really sure why my phone doesn't have L1. Some poking around leads to me to believe OnePlus dropped the ball on an update, or that i never had it to begin with on my 8T. 95% of the time, i only use Netflix to search for things anyway, so no big deal.
[Magisk] pndwal:
Mmm. @BillGoss or other OP8T user may know something re Widevine L1 restoring...

Did you ever try clearing Play Store data w/o hiding it to see Netflix in Play Store? PW

Edit:

Quick search shows many OP users had widevine issue incl. 8T for last couple of years. Some fixed simply by using EU fingerprint or flashing EU ROM. Eg:

https://xdaforums.com/t/fixing-widevine-state.4242873/post-84668723

Didn't work for others... But does seem to be ROM, often ROM update, related w/ OP devices...
[Magisk] BillGoss:
On my OP 8T I'm using Magisk Canary (23015,6), and USNF 2.2.0, Zygisk enabled, Enforce Deny List, and only my banking app in the Deny List.

DRM Info (https://play.google.com/store/apps/details?id=com.androidfung.drminfo) shows Widevine L1.

I don't use Netflix.
[Magisk] deusfaux:
no longer needing to disable veri x2 - is this only for existing rooted ppl whom are updating? that is, is it still required for first time root?
[Magisk] moocow1452:
Check in. Disabling selinux and remounting with root gives me write to root, so I can change the default.prop, chmod it, and it boots with the changes persisting. If I try to flash a Magisk boot onto it, still does the same behavior of sitting on the No Command area until something times out and reboots without root, but maybe with adb bugreport, something changes?

Have some bug reports here.

Magisk fails to handle special sepolicy on Oculus Go · Issue #4914 · topjohnwu/Magisk

Device: Oculus Go (pacific) Android version: 7.1.2 Magisk version name: 258e89c Magisk version code: 23013 Oculus released an unlocked build for the Oculus Go that allows user access to boot and sy...

github.com
[Magisk] m0han:
have you switched from Custom Magisk to Alpha?
[Magisk] ipdev:
With Android 12 you only needed to wipe data the first time after disabling verity, verification.

Then updating (or reflashing) as long as keep verity and verification disabled you did not need to wipe data again.

With Magisk 23016, you do not need to disable verity and verification.

No need to wipe data even if you update from Android 11 to 12.

Cheers. :cowboy:
[Magisk] deusfaux:
edit: apparently it's not required, as I'm up and running, using Magisk 23016, didn't manually disable those flags or anything, just the normal magisk flash procedure.
[Magisk] ipdev:
Some might see it as a backwards step.

That does not mean it is not a step forward.

Sometimes you need to go back to make a new path forward. ;)

The current (and continuing) changes make the core of Magisk stronger.

The stronger Magisk core allows modules and root apps to be able to do things on their own.

Instead of relying on Magisk's inbuilt functions to attempt to make the changes work. 🙃​

Cheers. :cowboy:
[Magisk] zgfg:
Yes, when Shamiko (for hiding Zygisk) was released

Hence, Alpha + Zygisk,DenyList + Shamiko + Zygisk-LSPosed, etc
[Magisk] Fry-kun:
Is there some way to get back MagiskHide functionality now that it's not supported in core?

I have 23016 installed (for pixel fixes)

Edit: seems that Zygisk takes care of this, trying it
[Magisk] pndwal:
Actually Zygisk builds remove much of it, but some of it is still in place with denylist. The rest is added back by Universal SafetyNet Fix since 2.1.0. See notes:

https://github.com/kdrag0n/safetynet-fix/releases

Also, I believe you can see the sensitive prop values needing changes in MagiskHide Props Config module / docs. PW
[Magisk] Fry-kun:
I have SafetyNet fix & Zygisk denylist, and it's working for Play store.

It looks like some apps are not happy with Zygisk, though, namely amazon app store (appears to detect root)
[Magisk] replica9000:
I have the same setup. Wiped all data for Netflix, but still shows L3. Netflix doesn't show as an option in the Magisk DenyList. I did add DRM Info in the DenyList, but that all also shows only L3. So it must be an issue not caused by Magisk. I haven't added any financial apps to the list, but they all still work.
[Magisk] pndwal:
Do you have EU ROM, or other?

FWIW, it's in and selected for me. (Xiaomi RN8T)

Yup, it's not detecting root, but DRM certification.... Widevine Content Decryption Module certified security level specifically.

Yup, many have issue on OnePlus after bootloader unlock only, some after ota update with no customisation and w/ BL locked... PW
[Magisk] pndwal:
Yup: Please understand that MagiskHide never did a lot more than properly hide Magisk and prevent Magisk from breaking Safety Net features by hiding all Magisk modules' files and mounts from target processes (e.g. Safety Net)... In future however, "Magisk will not spoof/alter/manipulate any non-Magisk related signals or traces to circumvent any device state detection"

Many apps always needed more than enabling in hidelist / denylist. Some simply detect Magisk app (John introduced Hide the Magisk manager/app for this) or other root associated apps.

Detecting applist should be prevented in theory since Android 11, but in practice some are still able to do this using some trickery, eg using Intent queries instead of API requests. Also, some like Sparkasse bank S-PushTAN can detect the hidden ('fully obfuscated") Magisk App by detecting the classes.dex code which does not change (unlike the package name) and can be used to identify the app. Their protection engine (Promon) seems to employ simple pattern matching on installed apps.

I am able to properly hide the already 'hidden' Magisk app (with Intent query hiding set) from S-PushTAN (and it will load) by using Hide My Applist LSPosed module...

Any there are many other methods used by various apps to detect broken TEE (developed due to patently unreliable SafetyNet API) with various solutions. Some are mentioned in @Didgeridoohan's Magisk Troubleshooting wiki.

vvb2060's Momo app and documentation indicates some suspicious traces & 'enviromental abnormalities' that can be used for detection purposes also.

If Apps are now actually starting to detect Zygisk (I've seen no evidence yet), we now have Shamiko (Shadow Mistress Yuko: Hide for Zygisk) solution... PW
[Magisk] Qnorsten:
Netflix comes preinstalled on the OnePlus 8T so you need to tell magisk to show system apps to see it.

There are a big thread about L1 with unlocked bootloader on the 8T.

https://xdaforums.com/t/widevine-security-level-after-unlocking-bootloader-root.4180619

I used to get downgraded to L3 when I unlocked bootloader, but I reported it to OnePlus and they fixed it in an OTA. So I recommend moving that discussion over there. As L3 on unlocked bootloader is not an magisk issue. Unless you actually have L1 with unlocked bootloader and just Netflix detect L3, cause then it is a root detection issue.
[Magisk] Qnorsten:
I doubt that any one really cares about this. But after a lot of tests and debugging I discovered that the Freja eid app works perfectly on my rooted phone if I factory reset. After restoring data with TWRP, I finally managed to find what triggered the error for me. And it is so stupid.

I had an old frida-server file in /data/local/tmp and that is what caused the issue. Just wanted to post here in case anyone else discover an app that use the same thing as tamper/root protection.

Lesson learned not every root detection error is related to magisk or lsposed.
[Magisk] Fry-kun:
Also noticed Netflix & such are unable to start with "Sign in ... with your saved password" flashing like crazy & unable to actually sign in.

logcat says

12-16 21:31:18.375 1505 3393 W InputManager-JNI: Input channel object 'aeeda26 com.google.android.gms/com.google.android.gms.auth.api.credentials.assistedsignin.ui.AssistedSignInActivity (client)' was disposed without first being removed with the input manager!

This is very likely a different issue... but present with 23016 canary.

Maybe I should try to reflash & try fresh..
[Magisk] zgfg:
I have different device: Xiaomi Mi 9T, Xiaomi.eu Stable ROM, A 11 (MIUI 12.5)

And I always had and have Netflix in Playstore, DRM L1, etc.

In short, I can happily play Netflix in FHD (screenshot)

Currently on 23016 (though Alpha, not Canary but should not matter), and previously with various other Magisk versions I was switching back and forth
[Magisk] TanakaX5:
Hey guys,

I have a question about updating the magisk app.

So I rooted my oneplus 8t kb2003 and running a bunch of modules, it works perfectly fine.

But the last time I Updated the magisk App it completely ****ed up my device.

What is the correct way to Update the app?

That's my setup:

Magisc canary

Instalked 5d6d2417 (23015)

Zygisk yes

Ramdisk yes

New 92546e8a (23016) (23)

Installed 5d6d2417 (23015)

Last time I just Hit Update and after that f*** up town All the Way, had to unbrick and everything.

So, what's the correct way or was it just Bad luck?

Greets,

TanakaX5
[Magisk] kevin01523:
Just make a script where it modifies his module then put a copy of a git clone of the repo named as gplsource.zip inside the modified module zip as the finished product problem solved.well.i think it has to do with the en cn mistranslation ,pride, inferiority or superiority complex.and i think they kinda misunderstood what gpl is as long as you didn't rewrite the and compiled the binary you provided.well the telegram group kinda toxic for ages even english as is not considered as the international language is being debated on that group best ignore provocation.they do that all the time . Too bad i didn't get a copy of your mod
[Magisk] awakener777:
It's been quite awhile since I've rooted my devices. Happy to be back want thanks again for keeping this current! The "search this thread" option seems broken but my issue today is finding modules. If my memory serves correct, isn't there supposed to be a way to browse and download modules? There doesn't seem to be this option for me. Any help would be greatly appreciated. The search button appears to only search modules installed locally.