yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Yeah, may be a bit confusing, but I think they are 2 different things:

He seems to have several branches in Magisk repo (11 repos):

master (still synced with topjohnwu) + alpha, bootconfig, lite, & patch

magisk_files repo master branch has Lite builds (Download app-release.apk), and alpha branch has Alpha builds (Download app-release.apk).

My linked 'Notes' post for Alpha links GitHub page for current Alpha build.

Nb. MagiskDetector (see this repo) may be very useful for MagiskHide issues, as I've mentioned. 👍 PW
[Magisk] HippoMan:
I don't know much about the internal workings of Magisk, and the following question is for any of you who are more familar with these details, so I can perhaps learn something and improve my understanding of Magisk:

Given that Magisk Lite claims to be better at isolating software such as banking apps, and given that this program doesn't support the use of modules, could it be that the over-and-above-SafetyNet checking that some of these banking apps utilize might involve some sort of checking for the existence Magisk modules?

If so, could there perhaps be a way to change one or more aspects of Magisk's module management which will make these modules less easy to locate and identify? ... perhaps some sort of random renaming procedure that is similar to the renaming of the Magisk package and the Magisk app itself, which is already offered?
[Magisk] pndwal:
To whom it may concern:

https://xdaforums.com/t/lucky-patcher.3383603/post-66960894 😉 PW
[Magisk] pndwal:
Yes, but issue is with flaw in MagiskHide mount points hiding for such isolated processes ('mount leaks'). And it seems it's not going to be an easy fix:

For example, 'leak' from same mount point(s) may be exploited for detection on Xiaomi devices, but not on Pixels.

Please read this issue as well as some closed issues linked from it to confirm the above / get an overview of the problem:

https://github.com/topjohnwu/Magisk/issues/2406

Nb. @vvb2060 makes several comments about his 'Magisk Lite' solution here also. 👍 PW
[Magisk] koberulz:
I've just rooted my new Pixel 3, and the "Hide the Magisk app" button is greyed out, so I'm unable to rename the app. Any ideas why this would be?
[Magisk] HippoMan:
Thank you very much.

I wonder of these big plans might have anything to do with utilizing a chroot jail under Android. That works well under "standard" linux/unix/etc. for setting up isolated environments. In my not-very-ample spare time, I'm now going to do some investigation about utilizing chroot under Android.
[Magisk] Renate:
I have 22.1 installed on an Onyx Boox Poke 3 (no A/B, yes SAR) from a recovery I extracted.

su on ADB works fine.

I manually made a test Module with just 2 files, /data/adb/modules/Bogus/module.prop * /data/adb/modules/Bogus/system/hello.txt

hello.txt does not appear in /system

The log says Bogus: loading mount files

The modules page shows Installed and slider On, but nothing under Online.

What about those symbolic links in /data/adb/modules/Bogus that the documentation refers to?

They are not there. Who/what/when creates them?

Thanks!
[Magisk] zgfg:
Just to make sure:

-Upon installing your Bogus module, did you reboot?

-You must check with a root explorer like MiXplorer (i.e., when booted to Android with Magisk active), not in TWRP

Edit:

@Renate, don't use /system/hello.txt but put hello.txt to an existing folder like /system/etc/hello.txt

(I just tested and realized that mounting directly to /system did not work - was not aware but it probably makes sense)
[Magisk] Renate:
Say what???

You're right of course. /system/etc/hello.txt works fine.

So you can't override /system/recovery-from-boot.p ?

I guess that I have to block /system/bin/install-recovery.sh instead.

Is this a bug or a feature?
[Magisk] Didgeridoohan:
Feature, and has been like that since very early in Magisk's history. Magic mounting files and folders to the root of /system, that doesn't previously exist there, can cause all kinds of weird issues.
[Magisk] pndwal:
@xdaggg

Not sure how you guys could give any fewer clues!

Device, ROM, Magisk App home page screenshot, logs? 😬 PW
[Magisk] DiamondJohn:
Things have lightened up in recent years. I use to report when even a mention of the app was made (and thye post was "cleaned"), but the ;ast timeI reported it, I was told by the mod that it was no longer considered completely off-limits. I would guess the it has something to do with the fact that not all the functions were warez style actions. From memory, I think my rejected report was regarding people using it to disable signature verification when installing vanced YouTube, and could be discussed on XDA. I am also assuming if you explicitly discuss disabling payment to a dev, then that would still be regarded poorly here.
[Magisk] pndwal:
Well, a user was simply asking about why option to install LP module was greyed out, and post was removed from here within minutes, soon before my post.

I was using both XDA app and web browser (app has too many issues to use exclusively), and noticed post was removed on browser after refresh, so I copied post from app (hadn't refreshed), and did quick search re. why post re. LP might 'disappear' inexplicably. Found info. above, and posted in case that poster was also none the wiser! 😬 PW
[Magisk] x-pve:
You're right - Lineage 18.1, Magisk 23 on Oneplus 7T pro - Hide the Magisk app disappears when I turn off wifi and mobile data.

I didn't try to allow network access to Magisk.
[Magisk] pndwal:
Well, seems getting things completely offline was still a work in progress.

Local version of stub unavailable, ie. stub needs to be downloaded, is your issue, and fix hasn't been merged in John's builds.

@vvb2060 did much (most?) of the work on new stand-alone package already introduced in all John's builds, but hadn't done local stub fix before John apparently got his hands tied by his current employer (our nemesis?).

He has merged this recently in his Alpha builds however.

I'm guessing things will need to change somewhat before we see such improvements and fixes in John's builds, although @vvb2060 has created a pull request (unrelated) in recent days, so perhaps he knows something (or is just optimistic).

https://github.com/topjohnwu/Magisk/pull/4384

As I've mentioned, I'm now using latest @vvb2060 Alpha build. I just checked 'Hide the Magisk app' on my device, and can confirm there is no such restriction w/ WiFi and mobile data off using current @vvb2060 Alpha. 👍 🙂

Here is Changelog note (translated from Chinese):

"- use the local version when you can not download stub, can be completely offline now Magisk"

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85103975

Not sure what you mean here.

I think offline patching has been available in John's builds at least since public 22.0!

Also, versions 19.x etc still required internet, and patched from server using set channel [+ json file] AFAIK. 😛 PW
[Magisk] dd805bb:
https://twitter.com/i/web/status/1394679855879364609

Magisk from TopJohnWu is over. The inevitable happened after being hired at Google. Magisk is now basically over. Get ready for the repos to close soon. Download what you can. FYI
[Magisk] koberulz:
Like I said, it's a Pixel 3. Stock, latest Android 11. The home page doesn't seem to have much of interest on it, just says I've installed version 23.0 and has "Yes" for A/B, Ramdisk and SAR.

I'm not sure what a log would help with if the option is greyed out, therefore no action can be taken to trigger log entries, but I've also no idea how to find the log, so...

It's not an online/offline issue, I've been online the whole time.
[Magisk] zgfg:
Still, it can be a firewall, adblocker, private DNS blocking - try with all of them disabled
[Magisk] koberulz:
It's been a problem since literally the second I rooted the phone. Magisk and Root Checker were the only apps installed, all settings were default.

Since then I've added AdAway, but that's it. No firewalls, DNS, that I'm aware of.
[Magisk] 73sydney:
As for banking apps i had a massive couple of days with mine, my banks app and Google Pay verification ended up killing my Google Pay account by sending flawed data after their sneaky bloody app recently updated and started detecting root (thanks to Google Pay folks for the 48 hour turnaround on that)

I just tried this - using Riru & Riru Unshared - (with the new vvb20260 alpha instead of Johns canary) and was the only thing that got all the app functioning again:

https://xdaforums.com/t/magisk-hide-still-detected-fix.4284877/

So far working well....and i get to keep my modules...you will pry my modules from my cold dead Pixel 2XL :)
[Magisk] 73sydney:
I used to mash the report button too, but i just go with the simpler put fear of god into them :) Otherwise known as gentle reminder its generally verboten.

I use it for 2 apps (a local TV guide and Gumtree - local classifieds, owned by Ebay, im sure theyre not going to suffer), not to deprive anyone of a licence fee, but to remove obnoxious ads from free apps that id just block in the backend anyways.....whenever those 2 apps get updated i install it, rebuild the apk without ads, then remove it again until next update

But dont let me catch any of you kids using it :P
[Magisk] zgfg:
Magisk app uses particular analytics site (maybe JSDelivr, more info can be found by digging through the posts in this thread).

If blocked by WiFi/Net firewall, private DNS on the phone or firewall, some hosts sources for AdAway, whatever, you may have problems to see the latest available Magisk version, and/or to hide/unhide Magisk app, and/or to see modules from the Repo.

Again, it's been discussed here in the thread and more info can be found by searching/reading the old posts
[Magisk] koberulz:
Yes, but as I say, it's been greyed out the entire time. Default settings, no other apps installed.

So I have no idea what could be preventing it from connecting, if that is indeed the issue. I've not set up any firewalls, DNS, or anything else. All I've done is install AdAway, but that's not the issue because the issue predates that.
[Magisk] pndwal:
Is there anything amiss other than that? You see latest version for App for channel selected, etc? Stub version shows? Uninstall button & Check SafetyNet buttons? Floating menu? (Screenshot?) 👍 PW
[Magisk] lazostat:
I check safetynet and i get an API Error. Both basicintegrity and ctsProfile have error and evalType N/A

Is there a problem if i leave it as it is? I think it's like this for weeks.

I have oneplus5 with xxx nolimits and Magisk 21.4 with magisk manager 8.0.7
[Magisk] koberulz:
Not sure what you mean by 'stub version'.
[Magisk] zgfg:
Commented many times that SN API key for the old Magisk is no more valid, hence SN test cannot execute - thus API error.

Stable v23 was released with the new and valid key

But if you don't mind executing SN test from Magisk mngr/apk, you can leave as that (there are other SN checkers available from Playstore) - it's not a problem with the SN itself, just a problem with the old Magisk mngr/app whose key for checking the SN had expired
[Magisk] Didgeridoohan:
You've got "Latest = N/A", which means that there is no connection. You've got something that is blocking access for those parts of the Magisk app, and a very common reason for that in the past has been a custom hosts file. Try disabling it and trying again...
[Magisk] pndwal:
Well, you do seem to have connectivity issues. N/A also showing for App, Latest. Should show 23.0 (23000) (21)

Magisk version is 23000, Stub version (for hiding Magisk App) is 21. This is what 'Hide the Magisk app' function needs to download. 😬

You seem to have wifi only. Is result the same with network data?

I'm guessing there is some kind of filter / firewall on WiFi hotspot (ie. on modem router, etc). PW
[Magisk] centodue:
Using your referring I used which su and the I find /sbin/su. Now what can I do to understand if it is a superfluos su and I can I remove it ?
[Magisk] martyfender:
yes, I agree and Adaway's default host sources work fine with Magisk. If you have some other custom host sources, that could be the reason, or as pw mentioned:
[Magisk] zgfg:
Btw, Smali patcher (less functionality) has its own thread, therefore seems not considered a warez on XDA:

https://xdaforums.com/t/module-smali-patcher-7-3.3680053
[Magisk] pndwal:
Yes.

I have no personal experience with either, but SP does seem to be aimed at simply making other patches compatibile with device framework, although these do facilitate various (innocuous?) forms of spoofing.

LP goes MUCH further, explicitly stating that it 'is a free Android app that can mod many apps and Games... backup apps before and after modifying... remove license verification from paid apps and games, etc.', and claims to be 'a ‘modifier’ app for unlimited access to games and the play store...as well as the best app to get any paid apps for free.'

So seems to me 'warez' may well be a fit for LP. PW
[Magisk] koberulz:
Same result with WiFi and AdAway turned off.
[Magisk] pndwal:
But I mentioned trying mobile data, or else checking hotspot filter / firewall configuration (on WiFi device)... or try another wifi service! PW
[Magisk] HippoMan:
Thank you for all this.

I'm confused about one point. You refer to "vvb20260 alpha instead of John's canary", but the only vvb20260 that I could find is the Riru Unshared module, not any Magisk version.

I might be searching incorrectly, however ... ???
[Magisk] koberulz:
Well yes, if I have WiFi off then obviously it's using mobile data.
[Magisk] J.Michael:
try

ls -l /sbin/su

to see if it seems to be Magisk's.

"which" does not search your system, it just looks in the PATH. You could try

find / -name su

, but it will probably drown you in error messages, making it hard to tell if it finds something.
[Magisk] pndwal:
... And still N/A for Latest App? PW
[Magisk] pndwal:
https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85098469 🙂 PW
[Magisk] koberulz:
Correct.
[Magisk] pndwal:
Good to know.

Interestingly, I installed Riru and Riru Unshared (Riru - Enhanced mode for Magisk Hide) just for fun when I installed @vvb2060's Alpha Magisk. Don't think my bank is detecting 'root' yet, but I may never know with this; seems it must be effectively 'allowing Magisk Hide to handle isolated processes' as per description!

Seems Nangong Xueshan's the new John Wu! ... at least for now. 😛

Interestingly however, his MagiskDetector is still detecting 1) SU file in path, and 2) init.rc modified by Magisk. So MagiskHide is still not fully effective with this setup.

I'm guessing that hiding 'root' from banks exploiting these flaws may be the province of @vvb2060's Magisk Lite builds, or may not be possible (yet). 😐 PW
[Magisk] HippoMan:
Ah, there was an extra "2" in the string I was using for the search :) Thank you!
[Magisk] pndwal:
Are you developing nukes? In Perth?

I have to make this conclusion since Magisk builds (incl. stub apk) are hosted on GitHub, and you're the only one without access! 😉

GitHub blocked my account and they think I’m developing nuclear weapons

OK. I know that sounds crazy, but bear with me.

medium.com

😜 PW

[Edit: Of course, this post has no serious value!...]
[Magisk] koberulz:
I can access GitHub just fine, that's how I installed Magisk in the first place...
[Magisk] zgfg:
Check in your native Settings that you didn't block/limit data for Magisk app
[Magisk] koberulz:
I did not.
[Magisk] centodue:
ls -l /sbin/su

lrwxrwxrwx 1 root root 8 1970-01-01 01:00 /sbin/su -> ./magisk

find / -name su

/system/xbin/su

/sbin/su

/sbin/.magisk/mirror/system/xbin/su

and many folders with "No such file or directory"
[Magisk] J.Michael:
Check the one in /xbin to make sure it's not another link to magisk. Then wait for someone else to express an opinion about trying to remove it.
[Magisk] F308:
Run: which su

BTW:

In Android 11 Magisk changed location.

I had problem to find it, but with root and terminal finally found.

Kinda weird.

It travels.

I had it in /dev/IDKT day or two ago, today it is in /dev/VzxB.

More weird yet.

I don't see /sbin directory.

Phone - Samsung Galaxy A41.
[Magisk] zgfg:
Ok, also jumped now to Alpha 1eb83ad8 (23001):

- downloaded and installed his Alpha app-release.apk (I needed to uninstall Canary apk because of Alpha apk having a different signature)

- changed the Update channel to Alphap and patched and flashed my boot img

Few screenshots attached

With Magisk Alpha, YouTube Vanced root kept crashing but upon reinstalling YTV it works fine now
[Magisk] zgfg:
Indeed, with Wb2060 Magisk Alpha 1eb83ad8 (23001), Hide and Restore Magisk app works even in the Airplane mode

Maybe @koberulz should try 🤩
[Magisk] pndwal:
Yes, interesting.

On Mi Pad 4, LOS18.1 A11

I have no /sbin either; do have /system/xbin

Magisk in /dev/a8g

SU directory: /system/bin/su

On RN8T, stock MIUI A10

Magisk in /sbin

PW
[Magisk] 73sydney:
Thanks as always, doing my work for me :)

Funny you should mention Youtube Vanced, for the first time i got an error trying to install it (cleanly installed after new ROM flash, and Magisk and Riru setup), a reboot and it installed find post install...
[Magisk] DiamondJohn:
And thats what I wanted to check; what the system is finding in the path, which is most likely how it is finding and reporting on an extra su. Its not the only/final check, just a quick and simple acid test.

Well, its a starting point, as when I run mine with a standard Magisk install (v22.1) I get /system/bin/su ie. different to you.

Now, when I check the details of my location, I get the following in MiX

Clearly mine is linked to Magisk. I also do not have one in /sbin/su, I dont even have an /sbin (Im running A11)
[Magisk] pndwal:
It was a joke / trivial info. 😉 ... Except that app is somehow not able to access these GitHub hosted files, as others mentioned too.

People are trying to help you here... You just may just track down the wily fox, but red herrings just make the game more fun! 😛 PW
[Magisk] ipdev:
The /sbin directory was depreciated.

Some manufactures and custom roms might still use it on Android 11 (SDK30).

Magisk Internal Details - topjohnwu.github.io - Link

This directory will change ("randomly create a folder under /dev") when you (re)boot.

Example:

Mine was /dev/6xvSO and after a reboot it is currently /dev/o1e4Nm

Cheers. :cowboy:
[Magisk] koberulz:
Got it.

Changed from Canary to Stable, and it's working now.
[Magisk] pndwal:
Thanks for heads-up ! Great what can be done with a magic overlay. (Of course, /data/adb files and permissions are real).

Good that John was able to update these Docs before going AWOL... 😬 PW
[Magisk] pndwal:
That is interesting.

Thought you were on stable 23.0 already from screenshot...

23001 Canary is essentially identical (other than verbose logging for debug purposes) anyway (it's a 'sync with public release' build)...

Perhaps something got messed up and reinstall fixed. 😆 PW
[Magisk] koberulz:
No, it wasn't a reinstall. Just changed the channel in the settings.
[Magisk] HippoMan:
Thank you again. I seem to have done something incorrectly regarding the use of the Custom Channel.

I followed the links from the page you pointed me to (above) and got to the alpha.json file for this vvb2060 version of Magisk. I created a copy of that file on my web server and put the URL for accessing that file under Custom Channel. Then, under the "App" indicator on the main Magisk page, I see this:

To the right of that, I see "Update", and I clicked on it. I then got the module description and top-level change log (half in Chinese) in a popup, and then I clicked INSTALL on the bottom right of that popup. But then, I get a notification stating "Error downloading file", and Magisk does not get updated.

Is there perhaps something wrong with that alpha.json file? The current contents of that file can be seen here:

https://github.com/vvb2060/magisk_files/blob/alpha/alpha.json

When I go to the URL for the copy of that file which I created on my web server (which is the same URL that I put into the Custom Channel field), I see the exact, same JSON that I see in that github file. This is that JSON:

{
"magisk": {
"version": "1eb83ad8-alpha",
"versionCode": "23001",
"link": "app-release.apk",
"link64": "app-release.apk",
"note": "https://cdn.jsdelivr.net/gh/vvb2060/Magisk@fe8e2abb688421fe5f8a938235cee66fb47d77df/app/src/main/res/raw/changelog.md"
},
"stub": {
"versionCode": "21",
"link": "stub-release.apk"
}
}

Can any of you see what I might have done incorrectly?

Thank you in advance.

PS: I also got the URL for the raw version of that JSON file from that github site, and I put that URL into Custom Channel. I got the same error when trying to install. This is that raw URL:

https://raw.githubusercontent.com/vvb2060/magisk_files/alpha/alpha.json
[Magisk] pndwal:
Equally strange... Anyone else have issue with canary chanel (fine for me, but I'm on Alpha build)? PW
[Magisk] zgfg:
Please send a screenshot from the Magisk app - showing Installed Magisk version, Latest and Installed Magisk app.

Please a screenshot (not description)
[Magisk] pndwal:
Didn't try custom channel / json, although it's contents look ok.

Just download Alpha App apk [Edit: "as I said in my linked notes" whoops, didn't put this in that post... Mentioned it only in later post... Editing linked post now] and Install. You'll have extra Alpha channel.

I updated App w/ no problems, but understand @zgfg need to uninstall John's first... PW
[Magisk] pndwal:
His older one:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85109529 PW
[Magisk] zgfg:
Long ago they have changed that links in Canary jsons are no more URLs (proper URL is only for Note).

If you want to play with json and your own server, put the proper URLs for Magisk (and stub), not just file names

Btw, I simply installed the Alpha apk, then changed the channel to Alpha and patched the boot img. Screenshot how Magisk app (version, etc) looks now was also included:
[Magisk] zgfg:
I want his new screenshot, after he 'changed the channel' (to decrypt what he really does / what he really has now)
[Magisk] HippoMan:
Thank you! After posting my previous message, I also tried downloading the APK's, putting them on my web server, and putting full URL's into the JSON. But that failed also. And I even tried directly installing the APK, which also failed. But your comment about this alpha version having a different signature made me realize that I need to do what you did and first uninstall the current version before installing that alpha.

I'll try that in the morning.

But this also raises the question of what URL to use for the Custom Channel if I want to use that installation method for this alpha. Is there a valid URL which I can use for installing thst vbb2060 version from some existing repository other than the one which I created on my web server? Given that this alpha version has a different signature than the stable and canary versions, and given that Custom-Channel-based installations are performed via Magisk, it seems to me that it's impossible to install that alpha via the Custom Channel, correct?
[Magisk] zgfg:
For me (Xiaomi.eu, A11) which su points to /system/bin/su, that is actuallyl inked to /system/bin/magisk

I don't have /system/sbin.

In /system/xbin, I have only BusyBox (hence without su)

And I don't see random folders in /dev
[Magisk] koberulz:
This is still the same. Literally all I did was change Update Channel in the settings from "Custom" to "Stable".
[Magisk] pndwal:
Further to this:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85113173

Since new single package delivery builds, custom method is no longer so important as one can now change build types, update or downgrade by running corresponding App. Previously, only updating was possible without custom channel / json other than for zip Installation.

Something here may help re. custom channel:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84825153

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84550467

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84332287 😜 PW