yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Did you uninstall the hidden app before installing unhiden app?.... Or do you mean you had both installed simultaneously?...

You cannot have dual Magisk apps installed; they'll conflict... Looks like you still have hidden app preventing other app seeing root... Remove hidden app in Device settings, Apps (named 'Settings' or 'yourcustomchoice')...

If that's not the whole issue, you may have had this issue:

Root accidentally disappears (daemon crash) in some cases #5681

Fix merged April 7

Try patching with latest Canary; many fixes since last stable.

😛 PW
[Magisk] QuietMountains:
I had both installed. I'll uninstall both versions later today in case it bootloops my phone. Thank you for the ad

Yeah I had both installed, reinstalled completely and it works now. Thank you!
[Magisk] pndwal:
When you have dual apps competing, you won't get bootloop just by uninstalling (apps only), and no need to touch Magisk (mask) itself to fix 'Installed - N/A' etc. 😜 PW
[Magisk] aadeshiscool:
Hi all, quick doubt. I'm on 2017 HTC u11 running 8.0 Oreo with latest magisk 24.3 (safety net passed), I'd like to install exposed but unfortunately lsposed minimum req is 8.1 so can't use that.

From what I understand if I install riru and edexposed module then the denylist won't work since it's based on zygisk, magiskhide which was based on riru is now deprecated and removed so I won't be able to hide banking apps. Is there any way I can install exposed now?
[Magisk] Event_Horizon:
@pndwal Hii, Yes I have raised an issue https://github.com/kdrag0n/safetynet-fix/issues/176

Waiting for @kdrag0n to reply.

I have checked a lot of apps in denylist so that these app should behave as in there is no magisk, now I have selected only Google Play Store, Play Services, Play Services Framework, Google app from Google, rest are Bank Apps, Streaming apps Prime Videos, Hotstar Disney, PUBG only.

Yes, w/o UNsF Yasnac says basic attestation failing, when I open the Netflix it throws the same error. Google Play Store saying device isn't certified & Netflix isn't compatible with this device in Play Store, manually installed Netflix throws the same error, after clearing data and restoring UNsF device got certified, hence Netflix available in Play Store.

I tried disabling all modules, once including UNsF & excluding UNsF both the time Netflix error is same. I was cleaning the Netflix data each time I change the combination & reboot the device.

Yes I use adaway for adblocker, hence I tried disabling the same but Netflix error remained same.

After I patched boot image & rooted there are no further OTA received, hence the patched boot.img is same as original boot image for the ROM, yes my ROM is a stock one for OnePlus 10 Pro.

Now I'm wondering if the error remaining the same w/ or w/o UNsF or Denylist or Module then where is the catch!! This is weirdest behaviour by any app I have ever seen.
[Magisk] zgfg:
Of them, you only need to have Google Play Services in DenyList (GMS).

It's clearly described many times in the thread.

All these other Google apps/services use GMS (ie, its SafetyNet API)

However, if you use USNF, than USNF will remove Google Play Services from DenyList because it takes care of GMS (SafetyNet) by itself

You can remove Google, Google Play Store, Play Services Framework from DenyList and test again and you will see that all your results about certification and Playstore will remain the same

Edit:

However, be aware that Device Certification in Playstore acts with some delay

Ie, If I disable USNF and reboot, SafetyNet will instantly fail, but Playstore will still show me that Device is certified for some time - that's why I'm not afraid of doing a short tests with USNF disabled, knowing that if I keep SafetyNet failing only for few minutes, it would not affect Playstore

On the other side, if Playstore was previously showing that your Device is not certified because you didn't properly configure things yet, then when you configure Magisk and USNF, Safely Net will start passing but it may still take time for Playstore to start showing that Device is certified

Ie, If you play with enabling/disabling USNF, be aware that SafetyNet will instantly show the new status passing/failing (upon reboot) but that Playstore may still be showing the previous/old (opposite) state not certified/certified (needing some time to get in sync)

Hence also the availability of some apps in Playstore (whose availability depends if device is certified or not) may take time to get in sync with the current SafetyNet status

However, if that app, when you run the app, checks itself the SafetyNet status, then the result (eg. failing to run) will be immediately in sync with the current/new SafetyNet status
[Magisk] Event_Horizon:
That I understood, but if I keep Play Store & Google apps and all in denylist does that make Netflix not work or anyway does it impact any other app to not work??
[Magisk] zgfg:
On my phone (as I stated) earlier, I have no issues with Netflix and L1 with root

In your case, apparently, mileage differs - follow what @pndwal was answering you

My point was about which Google apps you need to have in DenyList and which of them not - both on your phone, my phone and others.

Putting or missing eg Google app to DenyList will not make anything better or worse, hence it will not help for your Netflix either

But generally, it is better for the initialization of Magisk, that you don't clutter DenyList with tons of unnecessary apps. Ok for one or two and on a powerful phone, but some users may have issues when they clutter the list with tons of unnecessary apps
[Magisk] pndwal:
True... Riru and Zygisk can't coexist, so Zygisk must be disabled to run Riru (core).

False... MagiskHide never needed or used Rikka's Riru framework module, but was somewhat limited because of this...

John's Zygisk framework (native implementation of XHook injection into Zygote app processes) was inspired largely by Rikka's Riru however, and originally conceived as a a powerful embedded function to provide for better ('proper') hiding...

John has spruiked Zygisk's benefits for making Magisk more powerful for general purposes more recently, but as a framework it does actually enable hiding by module Devs (Danny Lin, Canyie, others) better than MagiskHide could achieve.

True. Riru is also deprecated...

Sure you can... Many, like mine, work with only SafetyNet passing... More work after enabling Magisks 'Hide the Magisk app' obfuscation feature... Still more work using Canyie's / LSPosed group's Shamiko to hide 'root' (ie. Zygisk, Isolated process leaks etc).

Other solutions include removing / renaming folders, etc (TWRP etc) bank apps detect, using sandboxing apps (Island, Shelter, Insular) and so on....

Guess you could use / try closed source solution Taii Chi. Apparently supports Android 5 to 12. No idea how versatile it is, or whether or not security concerns many have are real / valid, but I see reasons for them ... And devs can't check code...

... Or just update OS to Android 9.0 (seems you have stock 9.0 Sense UI for HTC u11) and have everything! 🤪🤔😁

FYI: Quick catch-up on XPosed:

ElderDriver edXposed has broken safety for some time now, and was superseded by LoveSy's LSPosed fork (after differences between Shana and her sister MlgmXyysd over whether Shana's major changes should be adopted or edXposed should remain consistent with original Xposed)...

LSPosed has emerged as the innovative and well supported way forward...

🤠 PW
[Magisk] pndwal:
USNF will remove Play Services processes on reboot anyway...

Also, I'm not sure things are not entirely different with Zygisk; Magisk denylist may well now "hijack app_process (Zygote)", but I'd urge caution with denylist usage until this is confirmed, especially as John says "The new "DenyList" feature of upcoming Magisk versions is me preserving portions of the of hiding codebase" and:

https://xdaforums.com/t/magisk-the-magic-mask-for-android.3473445/post-70363391

Also:

https://twitter.com/i/web/status/1039528958289760256

👍

👍

Now you're doing some better analytics!...

This is why I said it seems "cannot reach Netflix service" / 'Network issue' may be your best clue; it certainly doesn't seem to be USNF related now...

Could it be you haven't got latest Netflix?... Or perhaps a Magisk issue / regression w/ Android 12 if all other network blocking candidates have been eliminated as culprits...

If you haven't, definitely you should try latest Canary build; some fix may just have sorted it out... Next, submit a Magisk Issue perhaps?...

😜 PW
[Magisk] Swordfishx86:
@pndwal worked :)

Just to be sure. Theoretically i could update the Firmware the same way and call it dirty?
[Magisk] Swordfishx86:
@pndwal https://github.com/topjohnwu/Magisk/issues/5673#issuecomment-1106681080

> Just to be sure: Theoretically i could update the Firmware the same way and call it dirty?
[Magisk] pndwal:
So you actually flashed all 4 files, AP(patched) + BL + CP + HOME_CSC right? Nb:

Actually, this is the given dirty OS update procedure for Sammy w/ Magisk:

One reason you can't take an OTA on A9+ Sammy devices is that you can't restore stock images like on other devices:

Of course, flashing stock AP restores partitions to stock, so you can no longer do that; it must be Magisk-patched:

... Sammy is tricky but doable! ... More tricky w/ Magisk in recovery and need for special key combo, and I imagine a pain-in-the-neck tricky w/ need for key combo + USB connected to boot system w/ Magisk since A11. 😬

Well done. PW
[Magisk] Peter0x44:
Hi all,

Recently, the power button on the phone I was using fell off, and I started pressing the pad underneath with my nail - then this pad rubbed off, and I can't turn the phone on at all.

That's not really what I came to ask about, though

Because of the aforementioned circumstances, I had to start using my old samsung galaxy s2 sgh-t989, that I went and installed the rom in this thread on:

https://xdaforums.com/t/unofficial-lineageos-14-1-celox-feb-24-2022.4244373/

After some struggle and trial and error, I managed to get it flashed successfully, and it works OK

Then, I went to install magisk to achieve root

I looked at the instructions on https://topjohnwu.github.io/Magisk/install.html and tried to follow them to the best of my ability

I tried the "deprecated" method at the bottom of the page first, since it seemed the easiest

After renaming the magisk apk to a zip, and trying to flash it from twrp, I received this error message:

"Updater process ended with ERROR: 1"

"error installing zip file '/external_sd/Magisk-v24.3.zip"

So, I then went and proceeded to try the non-deprecated method

I installed the magisk app, and determined ramdisk was yes

I extracted the boot.img from the rom, and then patched it using the magisk app. I then proceeded to flash it using twrp, and it did seem to work... with a few problems

Every time I open the magisk app, I am prompted to reboot

"your device needs additional setup for magisk to work properly, do you want to reboot?"

Even if I do reboot here, this message never goes away, I keep getting prompted every time I open the magisk app

This doesn't seem right to me - does anyone have any idea if I possibly did something wrong, or am encountering a bug of some sort?

The actual superuser access seems to work - if I run `adb shell` and then `su` I am prompted that the android shell is trying to use superuser, and I do indeed get a shell where running `whoami` shows root

Thanks for your time, and I hope you can help me.

If there is any other detail I should provide, please tell me.
[Magisk] Swordfishx86:
@pndwal a simple "yes" would have been sufficient ^^

flashing the full firmware and ap magisk-patched is well known.
[Magisk] Swordfishx86:
@Peter0x44 It could be the same bug (to be fair: regression) as in my case with current Magisk Canary. See https://github.com/topjohnwu/Magisk/issues/5673 I'm too unfamiliar with that old Samsungs to tell for sure to be honest.
[Magisk] humpty321:
I had downloaded it from the LineagOS page for my device: https://download.lineageos.org/bramble

Unfortunately there is no official TWRP for bramble so far, only an inofficial one in its early stages.
[Magisk] Peter0x44:
Thanks, should I revert to a version before this regression and try? Do you have a specific version number you know is good?

I can also chime in on the issue on GitHub if you think it would help.

If the only result of this bug is a minor irritation in clicking "cancel" each time I open the app, I can also live with that. I'm not sure if that's the case though.
[Magisk] humpty321:
There is an option to reboot to recovery in Magisk app. Either way the LineagOS recovery starts up.

What is still unclear to me after all the explanations I got here: Will I need to dump boot.img from every LOS update and have it patched by Magisk?
[Magisk] Swordfishx86:
@Peter0x44 Just install the latest Magisk app, transfer the AP-File to your phone and patch that. Then flash it with Odin. Use BL, CP and CSC from the same firmware in Odin. If your Phone needs special treatment - to be honest i don't know. I'm not familiar with *that* old Samsung devices. A google search should be your friend though. There should be nothing needed but the ordinary, well known tricks.
[Magisk] Swordfishx86:
@Peter0x44 i can't tell for sure since i am not familiar with samsung devices that old. My suggestion: flash the latest stock image you can find. go through the initial setup process with skipping as many items as you can to save time. install the latest magisk app (canary). transfer the ap-file to your phone. open the magisk-app, select install, select flash a file, select the ap-file (if you have to check the recovery-checkbox ... that depends on your phone ... i am not familiar with that old samsungs, i am sure you can find that information quite easily). once it's patched transfer it back to your computer. open odin, select BL, CP and CSC from your firmware and for AP use the file you patched with magisk. You should be fine.
[Magisk] pndwal:
Then I've completely missed the purpose of your question... There's simply no other way to update the firmware on Sammy w/ magisk, whether 'dirty' or 'clean', at least AFAIK.

Also, I read your GitHub post before your last edit clarified that you had patched with all 4 binaries, and it looked as if you may have missed the importance of doing this... PW
[Magisk] Swordfishx86:
@pndwal i feel sorry for You. You seem to keep supporting noobs in this thread and to be honest, i wouldn't have the nerves to do that in the manner You do. You're doin' a great job and most people comming here for "quick answers" don't have the insights to even understand.

Just to be sure: never go beyond your limits! You know what i'm talking about. Thank You for Your input, Sir! :)
[Magisk] Swordfishx86:
@pndwal why that shocked-face reaction on my last post?
[Magisk] pndwal:
Don't underestimate yourself. I think you've got plenty of nerve...

You got a quick answer to an issue you couldn't resolve / didn't understand, and moreover it worked, so am I only supporting noobs?

And this one: "Never look a gift-horse in the mouth"...

You don't get it?... Then I'm sorry for you. PW
[Magisk] zgfg:
Generally yes. New LOS will have it's new boot.img in the payload.bin

Who can guarantee that boot.img will be the same.

You can compare the checksums - if old (unpatched) boot.img and the new have the same checksums then you could continue with your old (patched) boot.img
[Magisk] Peter0x44:
Sorry, I'm not sure I understand these instructions.

What is BL, CP, and CSC? When I initially used odin to flash TWRP, I only selected a file for AP (I think it was the twrp tar), and then I flashed the rest from twrp itself.

What firmware or files are you referring to here?

To be completely clear, what I did to install magisk, is extract the boot.img from my rom, patch it using the magisk app, then flash it from TWRP.

My issue is I keep getting prompted to reboot every time I start the magisk app.

Thanks for your time, I really do appreciate it and please believe I am trying my best to understand.
[Magisk] rookey:
Guys, I've flashed a modified boot.img from the list here , and it seems to work ok. I've also installed the magisk.app on the phone.

Can I now re-lock the bootloader, to get rid of the startup warning message, and to be able to use apps checking for rooting (like my online banking app), so will features requiring root access still work after that, or what am I supposed to do?

thanks,

r.
[Magisk] mingkee:
Warning: NEVER, EVER LOCK THE BOOTLOADER WITHOUT REVERTING TO BONE STOCK ROM OR YOUR PHONE WILL BE BRICKED!!!
[Magisk] J.Michael:
Samsung packages firmware in tar files, labelled AP, BL, CP, [HOME_]CSC -- that's why Odin has slots with those labels. John Wu's instructions for installing Magisk include a large section dedicated to Samsung. You have to use Odin. You are advised to always specify four files.

Once you choose to install LineageOS, you are in a whole 'nother world. The software is packaged differently, it is meant to be installed differently.

The standard Samsung instructions explain being forced to wipe data as part of the initial installation. They also explain that there will be an initial setup phase in the Magisk app, and that it will reboot one or more times.

I don't know how LineageOS changes or interferes with this process. At this point, you might be better off in a thread devoted to LOS on your device. Or at least in a thread devoted to LOS.
[Magisk] pndwal:
@Peter0x44

I saw you have Galaxy w/ Android LV 2.3.5 (Gingerbread)! (RV 7.1) Magisk 24.3. Wow...

You won't have that issue on legacy ramdisk boot device; that affects only A-only legacy SAR devices, and is for Magisk in recovery partition anyway... Your Magisk is in boot...

You may well have a different issue recently fixed for Samsung, so i'd actually be trying latest Canary before older builds.

Be sure to uninstall any instances of hidden Magisk app (if you ever used Hide the Magisk app function) from Device settings, Apps...

If no dice, try deleting contents or /data/adb (in case magisk db other config file is corrupted) before trying again... You could also try old Magisk 23.0 etc.

Yup; the Samsung Instruction the member referred to is for devices w/ Android 9+ (SAR variations)... Older devices only had single binary, AP (Application Processor) in stock firmware... Later, it was split up and recent Sammy uses 4 binary files... You won't need the full wipes etc needed for SAR devices either...

Anyway, your boot.img method should be fine on an older device like yours; you can't Odin flash AP in any case unless LOS supply AP binary... If they did, you could try patching / flashing the AP file...

This applies to Samsung w/ Android 9+ (SAR variations). Please see what I've put above... PW
[Magisk] DiamondJohn:
Years ago (maybe before Magisk) I had a Nexus 5 with an unlocked bootloader, so I could get root and flash a custom ROM. The little unlock symbol bothered me, so I re-locked my bootloader. THAT was a BIG mistake. My device wasnt bricked, however, to update my ROM (or Magisk, I think it was before I used Magisk) I had to re-unlock my bootloader, and doing so wiped my phone. I lost all my data. I never re-lock my bootloader since then.

That may be a device specific scenario OR maybe thats a Magisk specific?
[Magisk] rookey:
thanks for your feedback - I wasn't aware of that, just thought it would wipe my data ... which is why I asked now, still early after setup. ;)

My concern are 2 apps that don't work when the phone is rooted (like online banking). It seems that having Magisk active doesn't help, the app refuses to work. How can I fix that?
[Magisk] lolvatveo:
I've locked OEM after root. nothing happened (don't try this at home :). and one thing i forgot: how to install module in new magisk version
[Magisk] pndwal:
Context:

Seems were speaking of OnePlus 7 Pro (Guacamole) here.

Yup, older devices won't brick; it depends on version of AVB shipped AFAIK. I believe mandatory wipe on locking goes further back still...

The subject is not simple even on modern devices. Generally devices w/ AVB v2 relocked with custom mods will refuse to load the operating system (bootloop, brick) because the list of "approved" signing keys in most phones is limited to those that the manufacturer installed before shipping.

Some phones, however, support custom signing keys, eg modern Google Pixel and OnePlus devices, allowing you to boot a custom OS signed by them with a relocked bootloader as part of the AVB v2 specification, but this is not commonly supported. Good read w/ links to custom signed LOS etc for use w/ locked bootloader on OnePlus etc here:

www.reddit.com/r/LineageOS/comments/n7yo7u/a_discussion_about_bootloader_lockingunlocking/

Also, a few older phones (like the original Pixel/XL and OnePlus phones like the 5/5t and older) that don't support AVB v2 can have their bootloaders relocked because they simply *never* check to see if the OS is signed by the vendor. Any 'valid' signature will do on these devices.

AVB2 spec also checks for modified or corrupted vendor, boot, recovery and other partitions, so this rules out locking with Magisk...

On AVB states:

https://source.android.com/security/verifiedboot/boot-flow

👀 PW
[Magisk] rookey:
thanks, so if I understand you correctly: most likely no way to get my online banking app accepting my rooted OP7pro... :-(
[Magisk] pndwal:
Why not?

Have you done basics? - Passing SafetyNet w/ USNF module, got Play Protect Device is certified, added app in denylist, used Hide the Magisk app, Shamiko module enabled, cleared apps data... 🤔 PW
[Magisk] pndwal:
If you're wondering what John's been up to lately, seems there's been some focus on libsu again; many commits in last few days...

Interestingly, vvb2060 has also made a few fixes here also.

One of 5 days ago (merging deferred while John makes / merges his own fixes?) seems to be a case for Microsoft Appcenter telemetry in debug builds. (This is already implemented on her Alpha fork but she submitted a PR for Magisk main branch late January):

https://github.com/topjohnwu/libsu/pull/119

She says in her TG channel:

(Chinese translated)

Seems the modded libsu is this one:

https://github.com/vvb2060/libsu/tree/exit_code

embedded in A609e0aa-alpha Magisk.

Fix merged in this one:

https://github.com/vvb2060/libsu/tree/initialized

which means data to fix this race condition in Magisk was gathered in just 3 days from Alpha userbase! 👍

The condition (getting the shell earlier than configuring the shell's initializer) returns code 127 and prompts the user to repair the environment...

Fix coming soon to a Magisk near you! 😛 PW
[Magisk] Peter0x44:
Thanks for the helpful and informative reply! I think I understand much better what I should do now, but I will repeat what I understood to make sure I am correct.

OK, so this issue definitely isn't relevant to me, and I shouldn't follow it.

Understood.

This is my first time installing magisk, I don't think I did anything like this (attempting to hide it). Everything I described before is everything I did.

First, I should just attempt to install the latest canary APK, then follow the patch + flash the boot.img process again, and then check if the issue is fixed? Are you sure the issue that the canary fixed is related?

If above doesn't work, I should delete that directory, and try installing again? Then if it still doesn't work, go back trying older magisk versions until I find one that hopefully does?

Also, I can get a root shell, if that means anything about whether magisk worked or not.

Thanks for your time, it is really appreciated.
[Magisk] rookey:
as far as I can tell, I did all that (except "Play Protect Device is certified", I don't know what you mean by that), but my banking app refuses to start.

MicroG self-check tells me that spoofing support is missing, and that Play Services+Play Store signatures are incorrect. I suppose that's the culprits?

(by the way, I'm happy to take this to a more appropriate thread if it is off topic here... but I'd really love to have a Google-free phone, which is why I went through all these hurdles with alternative ROMS, rooting etc.)