yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
Depends on what kind of root is baked into the kernel. If it's systemless SuperSU you're probably out of luck, because the installer script will detect that and try to adapt Magisk to using SuperSU and most likely fail. It's worth giving a try though... Nothing to lose, right (as long as you have a backup)?
[Magisk] biggdevon:
So, since I'm not currently rooted, I'm assuming best practice would be:

1. Flash kernel (gaining root) and boot system

2. Backup from recovery

3. Flash magisk v10.2

3. Cross fingers
[Magisk] RandomPooka:
Root shouldn't be "baked in" to your kernel. That's not how that works
[Magisk] biggdevon:
I'm completely ignorant to how an auto root kernel works, hence the original question. If I'm already rooted will flashing an auto root kernel replace my original root or just install the kernel due to root access already being in place?
[Magisk] Didgeridoohan:
Ah... Had to look it up and now I see what is meant with the auto root kernel. I have not dealt with that before (I don't do Samsung), so I had no idea. I just assumed it meant a kernel from a pre-rooted rom that already have the kernel patched. I'm gonna blame the cough syrup and the fever... :D

For Magisk Hide you want to remove any kind of previous root, so to flash one of those kernels would be counterproductive. Try to find something else. I know one user reported success with a kernel by arter97 when nothing else worked.
[Magisk] biggdevon:
I'm on the latest stock firmware (pk6) arter's kernel is based on an earlier fw. Would that cause any issues?
[Magisk] Didgeridoohan:
Of course it could.

But, having said that... It did work for that other user I mentioned and he also had a discrepancy in age between current firmware and arter97's kernel and it seemed to work for him.

Make sure to have a backup.
[Magisk] biggdevon:
Thanks for the help. I've seen some discrepancy over the process to install a kernel and Magisk. As I understand it, kernel first - then Magisk?
[Magisk] RandomPooka:
The idea of an auto root kernel is also new to me. Root has to do with your filesystem permissions, and that is not something that's provided by a kernel or requires a kernel to be patched.

There is more than just a kernel in the boot.img though, so certain devices might need boot time parameters set, which allow the phone to be rooted. If that's the case, I can understand how you would need a boot image that allows you to root your phone. I've never had a Samsung, and have no desire to. Everything I've heard and read about them, other than the S3, sounds just as bad as the LG devices for running custom a ROM or kernel. No thanks. I'll stick with the Nexus line, and see how the Pixel development pans out. I know HTC is still user friendly on some of their devices as well.
[Magisk] jsaxon2:
So I'm guessing you missed the part above the screenshot you took,???

Magisk Hide available with the INCLUDED ROOT SOLUTION.

Aka phh Magisk version...
[Magisk] TiZiO.Cover:
So you took a screenshot, and i took a screenshot, and both tell a story.

Don't get your point if you chose to ignore.

Anyhow, it's working for me and i'm out of here.
[Magisk] Artim_96:
Anyone any idea?
[Magisk] putridfoetus:
Is 91fixoverlays a folder or a script? Assuming it's a folder, this should work. If it's a script, you should use set_perm 91overlays.sh 0 2000 0755.

If the experiment doesn't work out, post-fs-data or service scripts would be better suited, obviously. Good luck!
[Magisk] Artim_96:
It's a script. But now Magisk refuses to install the module, in TWRP it gives me an ERROR 1. Sadly I can't see anywhere why it's failing. So maybe as a tip for a future release of Magisk manager, not just telling that it can't be installed, but why.

https://www.dropbox.com/s/y83nssno6sksmqv/disable-hw-ol.zip?dl=0
[Magisk] Didgeridoohan:
You should be able to see in the recovery log what that "Error 1" means.
[Magisk] Artim_96:
Installing zip file '/external_sd/Magisk/magisk-module-template-master/disable-hw-ol.zip'
Checking for MD5 file...
Skipping MD5 check: no MD5 file found
I:Zip does not contain SELinux file_contexts file in its root.
I:Legacy property environment initialized.
Archive: /external_sd/Magisk/magisk-module-template-master/disable-hw-ol.zip
unzip: invalid zip magic 034B5000
!Failed: Unable to extract zip file! Updater process ended with ERROR: 1
I:Legacy property environment disabled.
Error installing zip file '/external_sd/Magisk/magisk-module-template-master/disable-hw-ol.zip'
[Magisk] Didgeridoohan:
Your zip file is probably corrupt. Discard it and make a new one.
[Magisk] Artim_96:
I already did several times, I even re-downloaded the template, always the same.
[Magisk] Didgeridoohan:
Ok. Have your tried using a different program to make the zip? The log show the zip as being corrupt and therefore it can't unzip.

And about your problem: in config.sh you haven't added the path to your file when you try to set permissions, like it shows in the examples ($MODPATH/system/etc/init.d/91fixoverlays). Although that's what you show in your original post... Why the discrepancy?
[Magisk] Artim_96:
Because putridfoetus said it should be set_perm 91overlays.sh 0 2000 0755 (of course I removed the .sh since otherwise it wouldn't fit the file and no script in init.d has a file extension). And I already tried it with the path which resulted in the module being able to be installed but the permissions wouldn't set.
[Magisk] rajesh00:
Effect of factory reset

AFAIK, all mods are stored in /data/magisk.img

so, basically it has the same caveat as the systemless supersu. Like the systemless root is lost upon factory reset, all mods done with magisk module is lost upon factory reset. Isn't it true?
[Magisk] Fild5x:
Works flawlessly on my galaxy a500h running AryaMOD Note 7 rom and cynogenmod 14.0 through MultiROM. Am usinsing the following modules for now: v4a, phh superSU and xposed framework sdk 23. Thanks.
[Magisk] rignfool:
Why are you injecting init.d instead of just running said script at post-fs-data?

I haven't been following along... But I know you can take the contents of the script and put them in a mod in that script and it will run...
[Magisk] Artim_96:
Since factory reset includes wiping /data, yes. But the changes made to the boot.img will of course keep existing and the factory reset will delete the backup of the original boot.img

---------- Post added at 05:07 PM ---------- Previous post was at 05:05 PM ----------

So I would just need to paste the script's code into the post-fs-data file and enable it in config.sh, right?

What would I do with MODDIR=${0%/*}?
[Magisk] rignfool:
That's how I understand it...

However... I didn't make a flashable out of it... I just pieced one together to use as a kernel config script... It ran at the right time to set kernel parameters...

EDIT: I don't speak edify... Maybe [MENTION=2226076]stangri[/MENTION] can help there
[Magisk] Artim_96:
Ok, that actually worked. Thanks.
[Magisk] gewe:
Hello,

I installed Magisk v10.2 on my Moto X Play (Android 6.0.1, stock, unlocked bootloader, TWRP 3.0.2-r5 recovery).

I also installed Magisk Manager and phhSuperUser.

In Magisk Manager root status is "Not Mounted", Selinux status is Enforcing. When I try to flip the Root toggle to on, after about one second it returns to the off state.

The Selinux toggle behaves the same. When I try to set it to off, after one second it returns to on.

When I start AdAway is complains about not having root permission. There is no popup to give it root permission.

Googling around I didn't find a solution. Can someone tell me why this happens and how it can be solved?
[Magisk] Didgeridoohan:
There's no root or SELinux toggle in Magisk Manager. Are you talking about Rootswitch (or whatever that app is called)?

When you say you've installed phh's superuser, are you talking about the Magisk module AND the app?

Some logs (Magisk log, found in /cache and accessible through TWRP if nothing else) or at least a screenshot of your Magisk Manager would be useful.
[Magisk] mhetralla:
Reposting this for visibility.
[Magisk] jcrompton:
This is no answer ..... I have asked before as well

But my experience is that I cannot get SN to pass on secondary Roms
[Magisk] Artim_96:
Well...first of all install Magisk Installer from PlayStore, the list one including an SELinux toggle was the very first one.

If it's then still not working your device might be incompatible as many Motorola devices. Sadly I don't really know which Motorola devices even are compatible or how they could be made compatible. Motorola seems to be not that common here.
[Magisk] gewe:
This is the content of magisk.log.

** Magisk post-fs mode running...
** Magisk post-fs-data mode running...
* Preparing modules
* Stage 1: Mount system and vendor mirrors
* Stage 2: Mount dummy skeletons
* Stage 3: Mount module items
* Stage 4: Execute module scripts
* Stage 5: Mount mirrored items back to dummy
* Enabling systemless hosts file support
Mount: /magisk/.core/hosts
** Magisk late_start service mode running...
service: /magisk/phh/service.sh

Attached is the screenshot of Magisk Manager.
[Magisk] Didgeridoohan:
As already stated, you're using an ancient version of the Manager. Where on earth did you find that!? Install from the Play store instead and you should be fine.

Edit: Maybe... There might be incompatibilities. But, the correct Manager is a good start.
[Magisk] gewe:
I uninstalled the Magisk Manager and reinstalled from the play store. New screenshots attached.

According to the manager my device is not rooted, but the Safetynet check fails...
[Magisk] Didgeridoohan:
Then you need to root, right? Install the zip file from the thread about phh's superuser topjohnwu version. And don't forget the phh's superuser app from Play store.

And SafetyNet will trigger since you have Magisk installed (among other things). Magisk Hide can only be activated if you're rooted with phh's superuser topjohnwu version. And you're not... Full circle.

And when you've installed everything, activated Magisk Hide, rebooted and SafetyNet still triggers, try reading the Official thread by topjohnwu and searching this thread. Between them they've got the answer to almost any question you could ask.

Or maybe it works first time and you can rejoice in the glory that is Magisk.

Good night.
[Magisk] rajesh00:
Combination of system and systemless mod

Thanks, and 1 more question.

Say, if any of my favourite mod isn't available systemlessly as a magisk module, can i install that mod in system mode. Won't it break magisk as clearly stated in the installation procedure to remove any mod done in system mode(or better yet flash stock rom and boot.img). If yes, how to get my favourite mod running up again. And one more thing, what are the consequences if i accidentally do flash a zip mod or in-app mod that alters the system partition?
[Magisk] saggydey:
I have installed lineage os 13.1 in my Samsung Galaxy Grand 2.. I flashed magisk 10.2v and rebooted. Everything is working except safetynet CTS profile mismatch.. Why so? Lineage os is not rooted by default isn't it. Then why my safetynet is failing? Please help
[Magisk] culiacanazo:
Thought i let you know, there's a rather cool one straight from the thread...

I doubt it will help in this particular quest you guys working on, but it's more functional and eventually you'll get it, so might as well... ;)
[Magisk] Didgeridoohan:
If you take a look at the commits topjohnwu has done on GitHub in the last few days you'll see something even cooler...
[Magisk] culiacanazo:
Cool cool thanks I'll check it out
[Magisk] Kr47os:
Hi after any installation of Magisk on my ROM I have to fix boot with a custom kernel because have bootloop problem. If i don't want to install custom kernel can I backup boot folder with TWRP and restore it after Magisk installation?

Thanks to everyone answer
[Magisk] gewe:
Sorry, I misread the sentence

from the Magisk v10.2 thread. My interpretation was that Magisk would always root my device automatically. :o

In installed superuser and am rooted now. AdAway and Titanium Backup are working.

I have activated Magisk Hide (and rebooted), but the SafetyNet check still fails. I will search the threads for a solution.

Thanks for your help! :good:
[Magisk] Didgeridoohan:
No worries. It should root automatically, but I've found there are rare instances where it don't...

I made a post a while back with a few tips on getting SafetyNet to pass. https://xdaforums.com/showpost.php?p=70426733&postcount=7120
[Magisk] XAL2:
Hey there guys. I am on Lineage OS trying out Magisk to get Android pay to work. I'm having some trouble though. Do I have to pass the safety net check in order for Android pay to work? Also in the Magisk Hide what am I hiding because Android pay doesn't show up.
[Magisk] Didgeridoohan:
You have to pass SafetyNet for Android Pay to work. And you don't hide anything since SafetyNet is hidden by default. Check the post above yours...
[Magisk] More Work?:
I enabled Magisk Hide and rebooted. However, instead of failing the safetynet check, Magisk simply never finishes it. When I try any app that uses safetynet, it simply will be stuck trying to verify my phone.

Also does anyone have a mirror of the various .zip files? Currently any downloads from the official Magisk thread are unsuccessful.

Your help is appreciated! :cyclops:
[Magisk] culiacanazo:
It may come across as redundant, but due to your lack of details, an inverted check list might be just what you need... I installed the latest lineage just to check it out, fully, completely wiped, (after my nandroid of course...)

And what you read is what you get, to the dot:

•Flash ROM • Magisk 10.2 • open nano gapps...

mixed, heated, served...

Nothing more for spicing it up, nothing less to season it... TASTE WAS ADJUSTED PERFECTLY ALREADY

Unfortunately i didn't take a screenshot... Because it was last night.

Yes, gapps came later...

This is my info if it helps...

Who knows, if you depart from this it just may hold the key. Selinux set to enforcing, of course...

And that custom kernel in this info of mine wasn't part of that recipe, i only used it for this dish...
[Magisk] culiacanazo:
Ten nine!!

Disregard.

I need an assistant, apparently
[Magisk] Didgeridoohan:
Downloads working fine here.

Your Google Play services might have crashed. Reboot and/or clear data for Play Services.
[Magisk] culiacanazo:
Cheating Google in any way? Perhaps patching, microg, uninstalled "unneeded" Google files such as setup, syncing, feedback, partner, etc?, limiting it in any way, such as x privacy, etc? If everything else is per instructors, that might be the culprit right there... You have to set the little beast free!
[Magisk] gewe:
As far as I can tell, I have installed Magisk and phhSuperUser correctly. Everything seems to be working. My device is rooted, Magisk hidden, but the SafetyNet check still fails.

I am using the stock 6.0.1 ROM for the Moto X Play, with patches up to october 2016, reteu single SIM version (system version 24.201.5.lux_reteu.reteu.en.EU reteu, build number MPDS24.107-52-5).

There is no su* in /system/bin and /system/xbin. Attached are the recovery.log and magisk.log, as well as screenshots from Magisk Manager.

What options do I have to get the SafetyNet check to pass?
[Magisk] culiacanazo:
Didge, a lil sidetracking here, however it'd be odd for a pm... Just one question, where are you located? I'm curious because mostly always when I'm here which is, for me, thru the jetty part of the clock, you are too...

---------- Post added at 02:26 PM ---------- Previous post was at 02:25 PM ----------

Moto...

That sums it up.

Search incompatibility.

Something like that i caught a glimpse of (I'm a Sammy guy, see)

---- is busy box being taken care of another way?

---------- Post added at 02:43 PM ---------- Previous post was at 02:26 PM ----------

I couldn't read the logs, in fact I'm on my way out, but you'll be in good hands pretty soon here.

Really quick, i can almost guarantee it wouldn't be in the folders you mention, but in /data/ since it's systemless. And two, when i said patches i meant removing Google dependencies, or, (from the following, only the first part pertains to this, the second is a forum clarification since i had to mention this much): patching android so that the modded store will work without signature spoofing whether because of lack of it or due to incompatible (add of yet) fakegapps module... (See, i run Googleless, for the most part).

--To whom it may concern, yes, i use the unpronounceable app, just for those two Google-taming purposes, worry not... And no i won't pm it either.
[Magisk] Didgeridoohan:
Your Magisk log looks fine but your recovery log is useless. It needs to be saved right after flashing.

The only discrepancy I see is that your root is reported as "subind suinit" where it should be "topjohnwu". It might be an incompatibility with Moto. Or, are you using a custom kernel and have you flashed before or after flashing Magisk (recommendation is to flash kernel first). I've seen this before with custom kernels.

Swedish, but I'm a bit of an insomniac at the moment so I'll be on at all times...
[Magisk] culiacanazo:
Thank you!

"Mex Pat" here, lol I'm out

Phone, let me go already, damn it
[Magisk] gewe:
No, I am not using a custom kernel or a custom ROM.

As for the recovery log: would it help if I go back to stock boot image, then flash Magisk and SuperUser, save log?
[Magisk] culiacanazo:
It might, according to the OP

--- wait, there's no need to flash a separate, additional superuser zip, if you're in the latest Magisk
[Magisk] darkeyes22:
Does Magisk multirom feature works with all devices? Do I need a Rom specifically for my device?
[Magisk] jhedfors:
There is no multirom feature yet. Still in development/research phase.

What has been made is a Magisk ROM (more like a super-sized module), which is specific to a device, and running on top of a stock ROM. This confused me also.
[Magisk] tag68:
You are sure that you not using standard phh superuser.zip which is not compatible with Magisk Hide, but the topjohnwu v2 version?
[Magisk] culiacanazo:
If by any chance you happen to mean "is Magisk compatible with multirom?" Answer is yes.

Now if what you tried to convey was "will my device work with multirom?" Now there's what i call a fat chance of a big fat no, but any how, that would be in a different door, down one of these alleyways, on another building.... Same complex though
[Magisk] gewe:
Yes, I am fairly sure. The Downloads section in Magisk Manager shows the following installed:

phh's SuperUser
topjohnwu.r2
Made by: phhusson & topjohnwu

I reïnstalled Magisk (flash stock boot.img, flash Magisk). Then from Magisk Manager I installed phhSuperUser. This time I installed phhSuperUser through Magisk Manager, instead of flashing the zip.

And guess what: SafetyNet check passes!

Again: thanks all for your help. :good:

(And I must remember not to spoil the fun by installing Xposed. :eek:)
[Magisk] darkeyes22:
I meant that do I need a ROM that is specifically for my device.
[Magisk] Didgeridoohan:
That's great. Out of curiosity and for future troubleshooting: what is your root reported as now ("topjohnwu" or "subind suinit")?
[Magisk] Russiamen:
Updated post Magisk for Asus Zenfone 2 with a signed kernel

​

Download latest version

Folder with other (later) version
[Magisk] More Work?:
Thank you this fixed my never ending safetynet check.

However, I am still unable to download any of the .zip files from this thread. I am located in California. The download hangs and eventually pronounces itself unsuccessful.
[Magisk] Rom:
Hello all,

i have an lg g3 (d855 international model), and i have an MM boot img install.

I have try to install Magisk by two methods:

1: install Magisk 10.2 and phh-superuser-magisk-r266-2.zip and bumpboot-v1.0-blastagator-signed.zip.

Error 1: unable to replace the boot img, reboot in secure boot.

Fix: flash "LG-D85530B-Flashable.Modem-AutoHybrid.zip" after, flash "LG-D85530B-Flashable.Boot-AutoV2.zip" after, flash "LG-D85530B-Flashable.zip" :p

2: With the v9 of Magisk, the script works fine but i need the boot img from an KK ROM maybe: https://www.reddit.com/r/LGG3/comments/4yol47/how_to_bump_magisk_systemless_root_for_the_lg_g3/

So Magisk isn't yet compatible with LG G3 D855 MM pure stock boot img..

If anyone have a miraculous remedy i take..:)

Edit: at finally i return on the "standart" root method for MM LG stock ROM (flash any stock MM rom with make permissive zip and supersu zip to reboot normally.

But i will not fix my initial problem: after install and setting up all apps and xposed on my phone, after several hours: i lost the SU binary and so the root access, i must reboot in TWRP to reflash the permissive zip and the supersu zip (SuperSU zips are the official downloaded from SuperSU website).
[Magisk] Artim_96:
It wouldn't break magisk, but it will break OTAs and can probably be detected by various root detection methods even if an can't detect it (yet). So it would defeat the main reason Magisk was built for.

And the rest had nothing to do with Magisk and can't be discussed here
[Magisk] R324D:
Hi I want to know, should I reflash magisk from recovery when performing ROM update/ROM dirty flash?
[Magisk] Artim_96:
Well, if you want to keep it then yes, of course
[Magisk] culiacanazo:
Well, as soon as i pick up my jaw....

There!

OK, where were we? Oh, see it!

Don't we all?

---------- Post added at 07:39 AM ---------- Previous post was at 07:34 AM ----------

Wow, your closing sentence, thorough and concise, I've got a thing or two to learn, remind me to keep an eye on your posts! :)

---------- Post added at 07:42 AM ---------- Previous post was at 07:39 AM ----------

Also, adding on top of what buddy artim_96 here mentioned, that would be the only reflashing as far as Magisk is concerned (reflashing the module zips is not needed).
[Magisk] Didgeridoohan:
Ok...

Your posts the past couple of days have been a bit entertaining, if not always to the point or entirely understandable.

I have to ask: Are you high? Or is there a conversation going on somewhere that the rest of us only catch half of? :p
[Magisk] culiacanazo:
As a language teacher (English and Spanish), I've learned that pretty much people around the world have the same idioms, phrases, regionalisms, "sayings"... Just slightly different wording...

When something surprises you, you say " your jaw dropped" (stemming from the event that caused it); now, when i read if one needs a rom specific for his device, well, my jaw drops (emotion similar to 'face palm'... So after picking it up, figuratively speaking, i use a little sarcasm in my answer >> don't we all? <<<

Lol as to your assumption, we also word it something along the lines of "he who thinks nothing but food must be starving"... Meaning...

You, ponder, drugs, craving... Peace
[Magisk] Didgeridoohan:
Well, at least you make me smile... :)

Although, you could try to be clearer with your responses. Many users on xda have a lot more difficulty with the English language than you or I. And many people have difficulty with sarcasm when meeting it eye to eye, imagine how hard it is in writing...

(And no, never even tried anything heavier than alcohol.)
[Magisk] morfinrider:
Hi [MENTION=1432280]gewe[/MENTION] and [MENTION=4667597]Didgeridoohan[/MENTION], I am on LineageOS 14.1 and Open Gapps nano on my OnePlus 2. When you mentioned flashing stock boot.img, if I copy boot.img from the "OnePlus2Oxygen_14_OTA_027_all_1612271635.zip" file on OOS OTAs thread by [MENTION=2948558]Spannaa[/MENTION], do you think I will be able to pass the elusive Safetynet too?
[Magisk] rignfool:
I vote that [MENTION=4667597]Didgeridoohan[/MENTION] change his name to MagiskMan...

All in favor?
[Magisk] shoey63:
Nah, nothing like that I don't think. It's just that [MENTION=7182553]culiacanazo[/MENTION] is a cunning linguist [emoji4]