yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Yes, custom ROMs always flash a limited number of partitions, and traditionally custom recovery has been a separate custom solution, required before flashing a custom ROM (and left to user to select from a number of options generally available).

LOS recovery is also available separately for initial setup, at least w/ later builds, but is now included in ROM package also, a break with tradition!

Nb. Other non-traditional partitions are also (optionally) now included w/ custom ROMs also, Eg. OSS-vendor, basically custom vendor.

Nb.2. Recovery-type stock ROMs don't include all stock partition images a full fastboot-type ROM includes either, but included or not, they are considered stock. Conversely, partition images produced by custom modders (think Steve Kondik / CyanogenMod, LOS, unofficial modifications of official custom builds, etc, etc) are custom mods, and including such an image in a custom ROM hardly makes it less 'custom'! 😜 PW
[Magisk] ipdev:
I read the linked article.

Seems to be the normal steps.

Odd that Step 3: Flashing the patched boot image is generic, considering the title of the article is

How To Root Xiaomi Redmi Note 10S with Magisk (No TWRP required)

The Magisk links they offer seem to point to the official github releases.

One thing they did not mention, on some devices, you might need matching firmware/build on both slots.

Then flash the magisk patched boot image to both boot slots.

This normally only needs to be done the first time.

Being Xiaomi/Redmi, you should be able to fastboot boot the image.

My current way of installing Magisk is to boot it first, check and then use the Direct install option.

adb install -r app-debug.apk
adb push NameOfBoot.img /sdcard/Download/

Then use the Magisk app to install using the Select and Patch a File option.

adb pull /sdcard/Download/magisk_patched-Version_Something.img
adb reboot bootloader
fastboot boot magisk_patched-Version_Something.img

Open the Magisk app and check if Magisk shows as installed, if so use the Direct install(Recommended) option to install Magisk.

Magisk - Releases - GitHub - Link

Magisk - Canary - GitHub - Link

You might be running into issues with vbmeta. ??

--

Two common (generic) issues are the usb cable and port.

Try a different usb cable(s).

Use a USB 2.0 port.

Switch to a different USB port.

This may sound odd but, it makes a difference in the connection and transfer.

The cable I used for everything from my Nexus 9 to Pixel 5 (including OnePlus 5T, Poco F1 and F2) did not work in fastboot with my OnePlus 6T.

It would give error or appear to work (some times it did) with my 6T.​

I have switched to using the cable that works with my 6T for all devices. ;)

Older devices do not work well with USB 3.0/USB-C, some newer device also have issues.

Poco F1 only works with USB 2.0​

I never ran into this issue since I always use a USB 2.0 port.

That reminds me, need to pull out my Poco F1 and update it. ;)

Hope something in all that helps. 🙃

Cheers. :cowboy:
[Magisk] ipdev:
As for Lineage (18.x) if recovery is a separate partition, you have the option in the initial setup to update Recovery along with system update.

If it is a recovery-in-boot device, then you have no option (regardless of rom) since recovery is part of the boot image. ;)

Unless you build the rom, then you could modify the recovery build. 🙃

Cheers. :cowboy:
[Magisk] bosr:
Thank you for the advice. The issue was neither USB cable nor USB port but vbmeta :)

So I can confirm, that Redmi Note 10s is possible to root using Magisk.

The pocess I followed (besides all needed drivers, adbs, proper fasboot ROM version, unlocked bootloader, litrtle bit of fear that the phone could be hard bricked and a few more) :

- patched boot.img via magisk manager v23

- flashed empty vbmeta.img as decribed here https://xdaforums.com/t/root-gained.4290689/

- flashed patched_boot.img the latest platform-tools flashed it directly to boot_a

- reboot

Voila, Redmi Note 10s is rooted and Magisk v23 installed
[Magisk] pndwal:
Yep, just read official explanation yesterday. (For those interested I'll quote LOS recovery related changes.)

They developed recovery for A/B devices first:

https://lineageos.org/Changelog-19/

https://lineageos.org/Changelog-24/

https://lineageos.org/Changelog-25/ PW
[Magisk] pndwal:
Glad it worked... Had my money on that solution due to similarity w/ Redmi Note 10 Pro 5G MTK device. 👍 PW
[Magisk] 1dtms:
So I'm a little confused when trying to install Magisk V23. I went to the github page and downloaded the apk but when I tried to install it is asking me for a file. When reading the instructions is suppose to be a boot img from my OS/ROM. How do I find/extract that? I remember in the past I had to flash magisk from TWRP, am I missing a zip file or is that no longer the install method?

I'm running Lineage OS ROM (android 11) on galaxy S7 (Exynos)

EDIT: Nvm, I renamed the .apk file to a .zip and flashed it through TWRP and now it works.
[Magisk] Ghisy:
Hey,

I haven't had much success in the Shield TV forums so I'm asking here: does anyone know how to install Magisk on the latest Shield Experience 8.2.2 dev firmware? It comes pre-rooted from Nvidia but root doesn't work.

I either get:

- with the Nvidia dev image untouched: Magisk isn't installed and I can't seem to be able to activate it,

- if I patch the boot.img with Magisk and flash it, I'm getting this message in Magisk: "Abnormal state: An "su" command that does not belong to Magisk is detected. Please remove the other unsupported su".

Before Magisk v23, I would just install the manager and it worked.

Does anyone have any idea? Thanks!
[Magisk] 1dtms:
Is there a separate app to be able to view and download modules on Magisk? I don't see a Downloads option anywhere on the V23 app I have (Magisk 23000 is installed already)
[Magisk] Lughnasadh:
Use the button in the screenshot below to view and download modules.
[Magisk] 1dtms:
Thank you!
[Magisk] dcarvil:
Here's how I installed Magisk 21.2. https://xdaforums.com/t/how-to-root-and-install-magisk-on-nstv-2019-pro-v8-2-0.4189567/post-85247681 It will probably work with Magisk 23 as well. Also see the first post in that thread.

I believe the dev firmware root works only with adb. You'll need to flash the regular (non-dev) version of the firmware to install Magisk. Flashing the regular version will remove the Magisk unsupported su.
[Magisk] Ghisy:
I forgot to mention I'm using a 2017 Shield TV, not the 2019 model.

I was also on the dev firmware previously (version 8.0.1) and root worked fine after installing Magisk Manager. Maybe I should try v21.4 of Magisk instead of v23.
[Magisk] F308:
Observation aside.

Lucky me that I didn't know it earlier.

I remounted /system as R/W and modified /system/etc/gps_psds.conf as I wanted then remounted to R/O.

It was performed with Magisk installed of course.

Android 10, Galaxy A41.

Question for now is:

What exactly I really modified?
[Magisk] zgfg:
Do you mean that you mounted System as r/w in TWRP and you made changes there?

In that case your System is not really read-only file-system and you indeed made permanent changes

Wether the /system or / (SAR= System As Root) are really ro (read-only) or not, you can examine from /vendor/etc/fstab.*** (find such textual file there and read its content)

If your SAR would really be read-only, you won't be able to write from TWRP.

The only way will be to use systemlessly changes:

If you e.g. use Systemless hosts from Magisk, study the content of /data/adb/modules/hosts, its subfolder system/etc and compare the hosts file with the real /system/etc/hosts file.

Also, study the Magisk documentation, part for developers, explanation how Modules and REPLACE work - link to Github is from your Magisk app.

And/or, search about Systemless(ly) changes, it has been extensively discussed here
[Magisk] pndwal:
So you're still on stock, not GSI etc? PW
[Magisk] c3k:
the device that patch the image should be the same device I'm rooting?!?

background:

I have to root a S21

I patch the image on a S10

S21 stuck when I try to boot to recovery

tried a second time, same hashes, same result

I patch the image on the S21 itself (same AP file, different size when patched)

works as expected

strange that I'm sure that I patch the S10 image on a tablet, for example...I've never pay attention to this
[Magisk] F308:
Not in TWRP.

Just on normal running system.

Not first time I do that, but first time on Galaxy A41 and on Android 10.

A41 has not TWRP as far as I know.

It has SAR, yes.

/vendor/etc/fstab.mt6768 shows line:

system /system ext4 ro

Many more lines mainly point mounts under /mnt

At the moment of response I don't know what is GSI.

I am on ROM from sammobile.com, I guess they provide stock.
[Magisk] Rapier-:
I can't get K PLUS (A Thailand Banking App) to work

Link: https://play.google.com/store/apps/details?id=com.kasikorn.retail.mbanking.wap

- I'm running a custom ROM on Poco F1

- Hide Magisk app and enabled MagiskHide, checked the app and a few services I think might be related to how the app detects root

- SafetyNet passes and a few apps known to detect root works fine except this K PLUS

Thanks in advance
[Magisk] pndwal:
Official instructions seem to assume same device, but mileage may vary I guess.

I know others have done this successfully, but if I recall correctly some had issues even on the same device patching image from Android X+1 ROM with Android X installed before updating to X+1 and flashing pre-patched image.

I take it Magisk App shows Ramdisk= No on S21, you had Recovery mode checked in Magisk App on both devices, you copy patched tar file top PC using ADB (NOT MTP), and you flash magisk_patched.tar as AP, together with BL, CP, and CSC as per instructions... PW
[Magisk] pndwal:
Yep, seems you have stock then.

I don't know a whole lot about new shared-blocks file system, but seems problem remounting as r/w may stem from lack of space. Seems we need duplicated blocks for r/w.

www.twitter.com/topjohnwu/status/1170404631865778177

www.twitter.com/topjohnwu/status/1170443615077666816

www.twitter.com/topjohnwu/status/1170404633371525120

So John's conclusion was:

www.twitter.com/topjohnwu/status/1170404634604658688

Now if you really do have r/w system I'm wondering if, perhaps when there is plenty of space, some devices do retain 'e2fsck -E unshare_blocks' in Android 10+... Or perhaps you reverted filesystem somehow... Or perhaps Sammy doesn't (always) lock to Shared blocks. (Custom OS users can certainly still mount system r/w.) 👀 PW
[Magisk] pndwal:
Since passing SafetyNet, getting PlayProtect 'Device is certified' and hiding root from bank app, have you clear bank app data?

More here:

https://xdaforums.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/post-85254779

🤠 PW
[Magisk] andreidi:
I can't hide the Magisk app, it gives me failed. Samsung M30s, stock Android 11 security patch june 2021, rooted with TWRP with Magisk patched, latest version v23.0. Tried SE linux permissive, Play Protect off, Magisk props module, installing older versions of Magisk app, nothing worked. Safetynet check gives error, maybe has to do with EdXposed installed. Any suggestions?
[Magisk] YLNdroid:
@pndwal: Thank you for further expanding my knowledge.

Since I could not successfully install Magisk v23 on a SM-J510FN with Android running version: 7.1.1, due to regression, I will endeavour to test with v21.4 + Magisk Manager v8.0.7.

Where should I look to / how do I ascertain the stable JSON raw file URL of v21.4 + Magisk Manager v8.0.7?
[Magisk] pndwal:
Yes, EDXposed is failing SafetyNet now. Many users are switching to LSPosed, which is still passing.

You need internet for stub download to hide Magisk App for last Canary and Stable/Beta. Do you have any firewall, add blockers etc enabled?

Nb. @vbb2060's Magisk Alpha has completed changes to full offline installation, and doesn't need network access for this.

🤠 PW.
[Magisk] andreidi:
I see, well SafetyNet isn't a problem.

I don't have any firewalls or adblockers enabled. But it seems to be a problem (with the magisk servers?) because I can't see any modules when browsing on the Online section of Magisk Modules. I don't understand the "you need internet for stub download" part. Can you be more specific?
[Magisk] c3k:
IMHO, this is not clear enough

maybe if the software upgrade remove the ramdisk? read below

I understood what happened: I assume that for S21 I have to use "recovery mode" as S10 so I left the option checked. When I uncheck it I get the same patched file on both device.

So:

seems possibile to patch a "regular" (ramdisk) image on a recovery-mode rooted device (just uncheck recovery option)

seems not possibile to patch with recovery-mode on a "regular" (ramdisk) rooted device, since the recovery-mode option simple does not appear (I didn't even notice, this is why at first I could not explain the different result)

best is to use same device, since option will be autoselected
[Magisk] pndwal:
Just truncate the URL examples I provided; eg for archived App / Manager / zips, go to:

https://github.com/topjohnwu/Magisk/releases/ , scroll to required manager, click assets.

(Or click GitHub 'OctoPuss' cat symbol on Magisk App home page to get official Magisk home page and click Releases right at the bottom!)

Similarly, truncate example for json to:

https://github.com/topjohnwu/magisk_files/

(or change repository from Magisk to magisk_files from any page in John Wu's GitHub by clicking topjohnwu, then Repositories, then magisk_files), click history (clock) icon, scroll to required Magisk build and click, click Browse files, click View code, click stable.json, click lower menu selection, click View raw, copy this URL from browser address bar, paste that in Magisk Manager Custom channel setting. 👍 PW
[Magisk] pndwal:
Seems you have some network access problem with GitHub repos then... Are you using mobile network data or WiFi?

https://topjohnwu.github.io/Magisk/faq.html#q-after-i-hidden-the-magisk-app-the-app-icon-is-broken

https://topjohnwu.github.io/Magisk/releases/20100.html#updated-magisk-manager-hiding

https://topjohnwu.github.io/Magisk/releases/22000.html#app-hiding

Hope it helps. PW
[Magisk] pndwal:
Well, I think John has done a great job with best practice concise instructions, but he doesn't cover every contingency. 😉

You can always create a pull request for updated instructions, and many have contributed in this way! 😜

No, factory ramdisk absent in boot partition is simply the result of A-only Legacy SAR (type III) devices not requiring this as explained here:

https://topjohnwu.github.io/Magisk/boot.html

Software upgrades don't change this, and (with some exceptions like Xiaomi) there is generally no bootloader support for boot type ramdisk in any case.

Recovery mode should only be needed when (factory) Ramdisk (in boot partition) = no and you are flashing recovery.img (not boot.img).

Option will generally only be available on a Ramdisk = no device. (I understand this is only set to flag recovery.img fetching and patching for subsequent Direct Install Magisk updates. Nb. It seems I was wrong in my earlier assumptions about the function of this setting. 😬 )

WIth Ramdisk = no, users can always still try extracting / patching / flashing boot.img (uncheck Recovery mode) to test if bootloader supports ramdisk (and hence Magisk) in boot partition (Magisk now always adds basic ramdisk to boot.img when patching if missing, to contain / execute magiskinit). It might seem unexpected that this can work, but with requisite bootloader support it does on many devices, notably Xiaomi.

As mentioned, this flag may not affect manual patching; it is used to indicate that recovery.img should be patched in subsequent (root required) Direct install Magisk update installations.

Other things are likely to affect viability of patching images on a different device however. Eg:

https://topjohnwu.github.io/Magisk/deploy.html#systemless

notably, Patching (hexpatch) kernel to always use ramdisk as rootfs is only needed on SAR devices, so problems will arise patching SAR boot images on a non-SAR device and vice versa.

There are many other unseen flags set on a per device basis (vbmeta, etc) that may affect mileage when patching on a different device, OS or Android version. 😯 PW
[Magisk] zgfg:
Maybe you use an ad-blocker, private DNS or firewall.

Not sure exactly for the URL but might be you need to whitelist:

magisk-modules-repo.github.io

If using AdAway turn it off and inspect with its built-in DNS logging
[Magisk] andreidi:
Thanks for the info. I rebooted, now I can see all modules when browsing, but hide still gives failed. I don't know what the problem might be, maybe incompatible with Android 11 on my device? Luckily I can use Revolut app simply hiding magisk from it, hiding magisk manager is not needed for now. Further I don't really care about SafetyNet, I never pay for apps or services within Google or Galaxy Store and if an app doesn't show up on Play Store (like Revolut), I can always get it from apkpure or other sources. I find it a hassle to fix this for now, so I won't bother for now unless needed.
[Magisk] 3mel:
not gonna get around to rooting for a while just curious, can magisk patch an AP file that's on a pendrive or OTG storage and can Odin flash from the same ?
[Magisk] pndwal:
👍

You need Universal SafetyNet Fix module, or (more likely w/ Sammy) "Shim the keystore service instead of replacing it" test module...

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85231747

👍PW
[Magisk] pndwal:
Magisk sees USB storage, so should work.

I don't have Sammy, so no idea... PW
[Magisk] Rapier-:
Yes, I've tried clearing data, still no go.

Also I found another app that can still detects root as well; Dolfin, a payment app: https://play.google.com/store/apps/details?id=com.cjdfintech.wallet

Both these app used to work fine months ago by just hiding the apps themselves in MagiskHide (I remembered using Magisk v20.4 then), until K PLUS started detect root one day, so I ditched root.

Now I read that hiding some Google services can help (Google Services Framework/Google Play services). This works on some apps, but these two still refuses to open.

My speculation is they indeed employ custom measures like the link you mentioned.

Now the only documented case I ever see is Fate/Grand Order. Makes me wonder if there's a list of apps that are known to be tricky to hide?
[Magisk] earthbend:
i have no idea what i'm doing wrong at this point? why does it say "installed: n/a"? it won't let me access my modules or magiskhide either. i'm on oos 11.0.0.2, oneplus 7 pro.

i flashed the v23 apk, but nothing changed. please help?
[Magisk] J.Michael:
That is quite a screenshot. Please don't do that again.

It looks like you installed the Magisk Manager app, but you have not yet installed Magisk.

What do you mean you "flashed the v23 apk"?

Search for your device in this thread, and search for a device specific thread, but in general, you need to let the Magisk Manager patch a copy of the boot image, then somehow "flash" that patched boot image.
[Magisk] J.Michael:
If you can access the drive from Windows, Odin shouldn't have any problem, you'll just have to navigate to it when you're filling the AP slot.
[Magisk] pndwal:
General notes on hiding root from apps are here:

https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot#

Further, you might be interested to read this about hiding Isolated processes:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85230553

There are a number of current efforts to hide isolated processes:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85138767

They include:

- riru-unshare module (Enhanced mode for Magisk Hide by vvb2060)

- Magisk Detector app (Detection app by vvb2060)

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85082225

I recommend trying this by canyie:

- Riru - MomoHider module (aka IsolatedMagiskHider):

https://github.com/canyie/Riru-MomoHider

- Momo app (Detection app: check verbose log too):

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85161249

Also:

- Magisk Lite (If you're desperate to use banking app and prepared to forgo normal module support, you can try this experimental Magisk fork):

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85183071

Latest Lite build made public seems to be:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85103581

although he has built this also:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85226953

seems files are not uploaded to repo / posted yet.

My setup

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-85125319

🤠 PW
[Magisk] zgfg:
Maybe you already had Magisk installed, with your Magisk Manager/App renamed/repackaged (Hide the Magisk Mngr/App as in Settings).

Then you updated Magisk (App) and now the new Magisk App shows that Magisk is not installed (that was quite often, tons of similar issues reported here, discussed and resolved the way as follows below).

To avoid that problem you had to unhide Magusk Mngr/App before updating (btw, that's mentioned in the Changelog)

Now, to recover, you need to go to Settings, Apps and find your old renamed/hidden Magisk Mngr/App and uninstall it.

Then reboot or even better, uninstall also the newly installed Magisk app (not the Magisk itself), reboot and install it again
[Magisk] pndwal:
Did you extract boot.img from latest ROM, patch and flash it yet? (Nb. old zip Installation method will likely cause problems if using TWRP and A11 due to incompatibility - latest twrp 3.5.2 builds are based on Android 9 & 10 trees).

If you did, and previously had Magisk App / Manager hidden, you likely still have that installed, and it will cause conflict. Newer App won't see Magisk (mask), hence shows N/A.

Simply search for and remove old renamed app ('Settings', or whatever you named it) if that's the case.

You may also have this regression (similar symptoms / affects OnePlus 7T):

https://github.com/topjohnwu/Magisk/issues/4319

If so, you may be able to install older Magisk 21.4, then use Direct install to update from that.

https://github.com/topjohnwu/Magisk/issues/4319#issuecomment-851840533

😜 PW
[Magisk] earthbend:
sorry about that 😥

will flashing the patched boot img wipe my data?
[Magisk] zgfg:
No, Data is different partition then Boot partition
[Magisk] J.Michael:
Sometimes the instructions call for wiping data between flashing the patched image and rebooting for the first time. (Maybe that's only Samsung, maybe it's only when installing Magisk into recovery, maybe it had something to do with disabling encryption...what do I know?)
[Magisk] pndwal:
Yep, - on Samsung SAR device initial root requires full data wipe, but this is not a result of flashing boot image (in AP tar, whether in recovery or boot partition), rather it results from flashing CSC as part of the process.

https://topjohnwu.github.io/Magisk/install.html#samsung-system-as-root

As mentioned, - simply flashing a patched recovery image doesn't wipe data either.

- Disabling encryption (un-encrypting) does require data (factory) reset. 😜 PW

- I'm just a boy with a one-man show

No university, no degree...

... I'll be sitting here with a song that I wrote

Saying love could change the world in a moment

But what do I know? (Ed Sheeran)
[Magisk] lazostat:
I tried many solutions but still can't make bank apps work on my oneplus5. On unrooted tablet i have no problems.. Why? Also i can't make ads from games work.. Maybe systemless hosts option from magisk is the problem?