yashsingh1/xdaforums huggingface dataset:
[Magisk] Iceman248:
Does the stock uninstaller actually work for the Pixel? Based on changes for 13.3, it seems like I would need to use it, but I can't find anything on whether it works for Pixel, since Pixel uses special version of Magisk.
[Magisk] DodoGTA:
No, NO and NOOOOOOOOOO!!!!
[Magisk] dryness:
I initially only did it through TWRP, however using my previous discovery with Manager 4.3.3, I got root on terminal emulator in the OS, and deleted/recreated the link. Removed 4.3.3, installed 5.1 and tried again. Still no luck :( I'm not sure where (or what) the boot script would look like/go (though my google-fu might just be failing me).

And yes, I've got a nandroid backup ready to go, just in case ;)
[Magisk] Iceman248:
Figured as much. Thanks. If I'm coming from v12, would I need to uninstall first? If so, how would I uninstall it?
[Magisk] DodoGTA:
1. Yes

2. Uninstall it by flashing stock boot image from Magisk backup and removing /data/magisk directory, /data/magisk.img file and stock image backup in /data partition
[Magisk] otonieru:
It's one of your installed module that causing the hang,

All modules need to be updated to template v4

Furthermore, it need a proper module.prop set up,

Even if its v4, it would cause hang as well, if the module.prop happen to miss the exyra blank line

For now i would suggest you to uninstall your magisk, and reinstall it,

Then, check your module before re-installing it one by one

Using zip viewer, check the module prop file, and only install modules which have "template=4" in the module.prop
[Magisk] tekwyzrd:
oneplus one with lineage os 7.1: on update to magisk manager 5.1 and magisk 13.3 I encountered the freeze. uninstalled 5.1, installed 5.0.6, uninstalled the dolby atmos/viper module, and re-installed 5.1. working fine with lineage 7.1-20170717 without modules and passes safetynet check but I'll look into a compatible atmos or viper later.
[Magisk] bluegizmo83:
Magisk Manager 5.1.0 does not work on my Nexus 6p. Reverting to an older version works just fine. 5.1.0 just freezes on the green loading screen of the manager and then asks me to wait or Force close. Attached is a logcat (I had to trim it down to fit the file limit size here so it only contains lines with the word "magisk" in them).

Edit: I also have the Dolby Atmos/Viper module installed like the comment above mine here, so that's probably the issue!
[Magisk] Legendary Cryptid:
I'm using Magisk 13.3 and Magisk Manager 5.1.0 and used the temporary commands for deleting props in terminal emulator, and I still can't pass safetynet. Any idea how? I've used the UnSU and everything, disabled debugging and still cts and integrity are still showing up false. I want to install systemless Xposed at some point, but I need a fix for this first!

Phone is an LG K7 MS330, firmware 5.1.1.
[Magisk] Berko457:
I reboot my phone and now it works. I think magisk is buggy :silly:
[Magisk] prisoner1969:
Just read the thread. Answer is already there. You need to add a blank line at the end of module.prop file and it fixes it. It's in the thread already. Happened to me too. I have the dolby atmos mod and the adblock host file installed. Host file module.prop was fine but dolby atmos needed to be fixed. Once done it worked fine.
[Magisk] DodoGTA:
Go and add some marshmallows into your phone or your issue will be redirected to the black hole and it'll be seen nowhere :laugh:

And Magisk Hide doesn't work with Xposed, so don't leave your phone exposed to sexy modules and Google's crazy detection system, or otherwise it'll be able to enter that hole and eat Netflix, Super Mario Run, Pokemon Go and Android Pay with heavy amounts of pressure :laugh:
[Magisk] Didgeridoohan:
Apart from what [MENTION=6429309]DodoGTA[/MENTION] said... :laugh:

You don't need to delete those props if you've updated to Magisk v13.3, it does it for you. You have a quite old version of Android, so I'd say it's a possibility that your kernel just doesn't support mount namespace. Check your kernel version (in "about phone", or similar). It should be at least 3.8 or MagiskHide won't work.
[Magisk] divineBliss:
topjohnwu released Magisk Manager v5.1.1: https://xdaforums.com/showpost.php?p=73093229&postcount=26

He said: "Here comes the update of Magisk Manager to fix the notorious "app cannot start" issue. Fun fact: this issue is not even my fault!"

also "Magisk-v13.3.zip in the OP is re-uploaded with Magisk Manager v5.1.1 bundled, so users flashing a newly downloaded zip will not suffer from the bugs in the older versions."
[Magisk] Legendary Cryptid:
Actually, I just checked with both Root Checker and the Manager itself, and now I'm passing SafetyNet. The K7 doesn't have any Marshmallow ROMs anyway. All the sites that say they do are just malware. Anyway, about to use Super Mario Run now.

To add to this, my Kernel's 3.10, so namespace mount does work.
[Magisk] Wolfcity:
Magisk uninstaller is not needed? And I think it will be ok to flash the boot.img out of my rom too? I'm still on v12 too, so just asking.
[Magisk] moore.bryan:
I have now. ?

And Omni works; I'll have to check some others, too, as omni's not f2fs friendly & on an aged manta that's almost a requirement...

Thanks for everyone's help!

---------- Post added at 09:27 PM ---------- Previous post was at 09:26 PM ----------

It was the ROM... ?

Thanks for your help!
[Magisk] goodwin_c:
For all Google Pixel funboys/girls - let's move to separate thread https://xdaforums.com/apps/magisk/unofficial-google-pixel-family-support-t3639262
[Magisk] Gambosino:
This is my logs of the installation of magisk 13.3 on my zenfone 2, with stock firmware 352 and twrp 3.0 m4.

I don't know why, but on a certain process of the installation i have noticed on logs that the script looses the path of the /sbin files and says mkdir or chmod or chown not found.

I the installation of magisk, acuses me on magisk manager "rooted but no root permission, not allowed?"

Is there someone that elucidate me ?
[Magisk] Didgeridoohan:
I'd ask [MENTION=6034616]Kapil Tapsi[/MENTION], since that's the name on the installer...
[Magisk] Shtiff1:
Just curious about why some people are using TWRP? Can't everything be done right from the app itself? I've done everything thru app, never used TWRP, and everything works great.
[Magisk] DEVILOPS 007:
[MENTION=4470081]topjohnwu[/MENTION] 5.1.1 magisk manager is working perfectly with no issues at all and the live install thingy is also extremely cool imo. Just like when flashing a mod in twrp:D

---------- Post added at 09:57 PM ---------- Previous post was at 09:55 PM ----------

Well why not? Flashing things through twrp is always the easiest and most compatible way as in recovery mode, the os hasn't been loaded in the same way which makes installing magisk a lot better and more likely to work. Just like in the old days when I had the SuperSU app and tries to install the binaries from the app but it didn't always work but a flash in recovery did.
[Magisk] Shtiff1:
Ok thank you, I was just curious. :)
[Magisk] anttaz:
Thanks for the manager update to 5.1.1 working perfectly now :good:
[Magisk] dberthia:
13.3 is causing multiple FCs in System UI when I have a Substratum theme applied to System UI. Also had this problem in 13.2 when I temporarily had the SafetyNet fix module installed.
[Magisk] Robot76:
Substratum fine here on LOS... (OMS7 and Legacy)

[emoji7]

Λ.᪃.I.S.Ξ_Z3C_MΛGISK_SUᗱST᪃ΛTUM
[Magisk] wmg.architect:
Works great with last carbon for z3c build. I installed viper4android module.. But no effects or app appear to me? What should I do to make sound effects active?
[Magisk] John NHT:
Thanks [MENTION=4470081]topjohnwu[/MENTION] for the update to 5.1.1. Most appreciated!!
[Magisk] DEVILOPS 007:
That's the themers problem as they need to update the theme. Try a theme like flux or gravija. They work fine with magisk.
[Magisk] Angeloftheafterlife:
confirming 5.1.1 works great. Thanks for the update!
[Magisk] Wolfcity:
What theme?
[Magisk] dberthia:
Flux. It was fine for a few hours, then the crashes began. No crashes with Magisk until I installed that module fix in 13.2. I uninstalled that module when I upgraded to 13.3, but the problem persists unless I remove the Flux System UI overlays.
[Magisk] Wolfcity:
Have you tried to un/reinstall the theme completely?

I'm using flux and swift black but I'm still on magisk v12. Would check that but I'm not sure what's the best way to update directly to v13.3.

I read here to uninstall by flashing stock boot image from Magisk backup and removing /data/magisk directory, /data/magisk.img file and stock image backup in /data partition.

I'm just asking myself if the uninstaller isn't needed and if flashing my stock boot image would work too? What's the best way?

I don't mind about safety net but I use some modules.
[Magisk] appledoor:
working

Just flashed v13.3 with stock s7 sm-g930w8 (Canadian version). Confirmed works with nougat safetynet passed! THANKS SO MUCH TOPJ!
[Magisk] dastinger:
LOS on a HTC 10. 5.1.0 was working great, safetynet passed and I could install modules. Installed 5.1.1 and no root anymore. Also, when I try to launch the Superuser section of the app, it FCs. Got back to 5.1.0 and everything works great again.

Don't know what to do.
[Magisk] Peter Handless:
fixed Manager version 5.1.1 works great on LG G3 running Fulmics 7.6.

Thank You so much Topjohnwu for all Your hard work and great vision
[Magisk] HyperX66:
Mi4 with Magisk 13.3 safetynet fail

Basic Integrity fails on Mi4 on 13.3 while it used to work on Magisk 13.2 with the prop changes.
[Magisk] sudanking:
My magisk manager crash when I try to open superus tab. I used v13.3 and manager v 5.1.1

HTC m9 stock with twrp.

Edit: crash when try to install from any new modules. Crash after download and start installation.
[Magisk] Paschfire:
Logcat? Magisk log?

Cannot fix, or give suggestions to solve, on what cannot be seen.
[Magisk] satfan:
5.1.1 did it!!! oh my god, i had a lot of troubles yesterday, thx a lot to everybody who helped...

sometime just time (and an update) heals all the wounds...
[Magisk] TONGEXHISPEED:
My device oneplus 5 oos with magisk 13.3 + maneger last version

My uob banking app it notwork on magisk hide

I have screen short of setting and log

Please guide me for fix it because this app important for me in weeked!

Thank
[Magisk] BrikHaus:
Out of curiousity, for someone like me with an older phone, whom is not worried about warranty, already has a modded boot loader etc,

and already is Rooted with Xposed, is there any advantage to having Magisk?

I've been testing it this week, but so far the repos are pretty bare, and it has been more of a hindrance than an advantage.

(Not saying it's not a great bit of code, it's just doesn't appear to be for me..)

Thanks in Advance.
[Magisk] :
[MENTION=4470081]topjohnwu[/MENTION]

[MENTION=4667597]Didgeridoohan[/MENTION]

Manager (5.1.1) still auto-shuts itself down immediatelly when trying to open it from any profiles other than the owner one. This means multiuser root testing/check can't be done from manager 5.1 and up, thus far. The feature probably is not working still, but now, it can't even be checked, is what I am saying.
[Magisk] Shiva $$$:
Lenovo K5 plus 3gb one ,(A6020a46)AOSP extended+gapps stock+latest magisk manager got root works all good except ,one app is detecting root .and yes hide is on.
[Magisk] Shiva $$$:
I think I found the solution for apps detecting root in some apps it is because of su file in system/sbin
[Magisk] andmail:
The latest re-loaded Magisk v13.3 still gives an error 1 while installing
[Magisk] BrikHaus:
Yes, has to be flashed via TWRP.
[Magisk] Shiva $$$:
Delete the file in system/sbin/su this should work
[Magisk] TONGEXHISPEED:
/sbin/su

This file?
[Magisk] andmail:
Magisk-v13.0(a90e8b6) is the latest official beta can be installed on my Huawei H60-L12 without issue
[Magisk] dragonnicho:
anyone here know fate grand order ? magisk is properly installed in my sprout stock marshmallow ROM, it even pass the safetynet, but the game still detect root ( i check the game too in magisk hide ). anyone know how to play fate grand order with magisk installed ?

ps : i tried ANRC too, to hide the root but its no good ( with magisk and xposed installed )
[Magisk] Didgeridoohan:
The Superuser tab crashing is ususally fixed by clearing data for the Manager.

About the Superuse tab, look above.

Edit. Crap... I forgot to write this before posting! :laugh:

There are a couple of advantages to Magisk. The main ones (IMO):

Open-source root. If you care about that kind of stuff...

Any system modifications you do (build.prop edits, replacing ui audio, moving apps to /system, audio mods like Viper4Android, etc) will still be there after a system update. All that's needed is to flash the Magisk zip after the update and you're back in business. Even if you do a clean flash it's just a matter of flashing a couple of extra zips instead of manually editing and replacing files.

Yes, I can confirm... A logcat from the crash (on the second user) could probably be useful. I'd grab one myself, but I'm not at an adb prepared computer at the moment (at work). I'll see if I can do some testing later.

It looks though as if the Manager crashes when it's denied the su request.

Note that if you delete /sbin/su you will loose root. If your file explorer keeps active (so it doesn't have to do a root request again) you'll be able to recreate the symlink (/sbin_orig/su > /sbin/su) when you need it again, but if not you can just reboot and Magisk will recreate it.

Although... Since it's Magisk's su file, it'll be hidden by MagiskHide. In other words, there's no need to delete it.

It might just as well be that the app looks for the Magisk Manager (or other known root apps on your device). A very trivial test that isn't that straightforward to circumvent.
[Magisk] ketwi15:
Is there still no answer to this problem? It's very bothersome when everything else is working perfect.
[Magisk] nurps:
If I want to do this on a phone with Magisk:

Push the file on your device storage: adb push device_owner.xml /sdcard/
adb shell
su
cp /sdcard/device_owner.xml /data/system/
cd /data/system/
chown system:system device_owner.xml
Now reboot your phone

Should that work? After I reboot the files is gone from system, do I need to do it differently because of Magisk?
[Magisk] nemes480:
After a lot try, I succesfully updated the magisk root binary. How worked for me? First I flashed the 06xx uninstaller then reboot recovery. When I was again in , I flashed the v12 magisk zip, then wipee cache and dalvik. After these steps I did a reboot to system and installed 5.1.1 manager and used in app update what worked at least!
[Magisk] Kapil Tapsi:
[MENTION=335415]Gambosino[/MENTION] I do not know much about it.

From the logs you sent.

It seems twrp is unable to mount properly. The one you use is not the stable one either.

As the framework is systemless so the directory should be /xbin.

Magisk script is working fine without errors.

Though retrying again should do the job. If it doesn't then update twrp to 3.1 and use magisk uninstaller and then flash magisk 13.3. Contact me it if doesn't work. Though it will.
[Magisk] Didgeridoohan:
It's a known issue, yes. But there's no fix, yet.

I'm doing some testing myself and it would be easier to replicate if I had an example of an app that loses root... You have any examples?

Magisk doesn't mess with the /data partition, except for storing the Magisk image, a boot image copy and keeping some binaries and files in /data/magisk. I don't think Magisk is the issue.
[Magisk] roman.abdulmanov:
Everything works great with latest 13.3 version! Thanks.

I have only one issue: after rom restart few minutes I don't see notifications from Manager. Also some apps can't start and freeze. After few minutes everything begin working fine. I have this issue with all Magisk versions.

My rom is RR.
[Magisk] chhapil:
me too have same issues on Mi5 MIUI 8 nougat with Magisk 13.3

did some debugging from source code, it gets stuck while getting zygote ns.

// Get the mount namespace of zygote
zygote_num = 0;
while(!zygote_num) {
// Check zygote every 2 secs
sleep(2);
ps_filter_proc_name("zygote", store_zygote_ns);
}
ps_filter_proc_name("zygote64", store_zygote_ns);

opened an issues in github

https://github.com/topjohnwu/Magisk/issues/298
[Magisk] Chapter 1:
Just installed v13.3 everything works silky smooth!

[MENTION=4470081]topjohnwu[/MENTION] you are a True Master. Greatly appreciate all the time you put into making magisk.

Thx ?
[Magisk] Shiva $$$:
Ya to get root in terminal type #magisk su

And other apps which needs root the magisk pops up for granting and but there is a problem the magisk manager too shows no root.the banking apps works without any prompt
[Magisk] KenjiHannya:
Att to 5.1.1
[Magisk] BrikHaus:
Thanks for the info. I can understand how useful this would be on a new phone.

Cheers Mate!
[Magisk] matwlodek:
Nvidia Shield K1, SHIELD 5.2 Android 7.0 (stock), Unlocked BootLoader, TWRP 3.1.1-1 - Magisk Manager v5.1 and Magisk v13.3 - everything working :D

Sony Xperia Z Ultra, CM 12.1-20161016-Nightly, Unlocked Bootloader, TWRP 3.0.2-0 - Magisk v13.3 installs with no errors after reboot to system, Magisk Manager is not installed, after manual install shows No root and No Magisk installed... no idea why. (before installation full unroot was made, the v13.3 installer did not detect any root)
[Magisk] Rokotx:
Magisk Hide don`t work with ru.sberbankonline on build 13.3 and Magisk Manager 5.1.1. In perious version it works good
[Magisk] D1stRU3T0R:
Waiting to wake up tomorrow and see "download newest magisk manager" #nooffence but safetynet still doesn't work
[Magisk] Didgeridoohan:
That means there's something about your setup triggering it. I can pass SafetyNet just fine here on Magisk v13.3 and Manager 5.1.1 (and a few lower versions of Manager as well).

Have you looked in the troubleshooting guide?
[Magisk] D1stRU3T0R:
Maybe the problem is that i have august 1 security patch?
[Magisk] Artim_96:
It depends on the module. Many use XPosed so they don't need root rights. These should work as usual. Only mods constantly needing root rights will stop working while unmounting root since that kills all processes currently using root
[Magisk] stangri:
I don't think the magisk-ized systemless cerberus will survive the factory reset.
[Magisk] felipemorais_:
when I flash SuperSU (magisk version) Magisk Manager works fine. But with phhsuperuser it does not work.

Since I want to use xposed, I need the phhsuperuser to work.

I have a zenfone 2 and just cant get it to work
[Magisk] havens1515:
Awesome! Thanks! :)
[Magisk] unknown1205:
pokemon go 0.37 working with this method on my rooted nexus 6p running nougat, unencrypted.

i was on a stock debloated rooted 7.0 rom with super su installed. i went into super su to do a "complete uninstall" then i rebooted into recovery, flashed both magiskv6 and phh-superuser17.zip

rebooted and installed phh's superuser from the playstore, then i installed magisk manager. went into magisk manager and disable root, grant root access, then disable root again. bam! pokemon go 0.37 is working. everything took about less than 15 minutes.
[Magisk] anthonyg45157:
Wow this is a great profile! Works perfect
[Magisk] chris9000:
I was able to get it working with stock Android 6.0.1 and a custom kernel, but not with Nougat 7.0 for Nexus 6P. Still trying to figure out what I got wrong.
[Magisk] maiconjs:
Touch Screen issues after flash magisk on Moto X st1 !
[Magisk] alroger:
[MENTION=4470081]topjohnwu[/MENTION]

Magisk on HighOnAndroid

https://www.youtube.com/shared?ci=kvCBxvtxpfg
[Magisk] imarq24:
Tried installing the latest phh's Magisk in the second post and tried installin on my N6 on a clean install and got a failed error. I believe that I followed the op instrusrutions but still got a failed error. any help will be greatly appreciated. btw N6, rom: PN 8/21 build. thanks.
[Magisk] gk1984:
Happened to me once or twice. Just run the Magisk uninstall zip and start over.
[Magisk] TheSt33v:
Seconded. My Droid Turbo would be even more awesome with some Magisk.
[Magisk] JudgeDread11:
For everyone who has problems with getting phh's superuser to work after they have been using Chainfire his SuperSU, the UnSU script from this thread might help:

http://xdaforums.com/showthread.php?t=2239421&page=85
[Magisk] imarq24:
I tried the uninstaller and still a no go...need some insight could I be missing something that I'm not doing? BTW looking to have my systemless root again after being on chainfire form the get go.
[Magisk] lancespahr:
:/ I think I ended up removing magisk (oh well) so I reflashed magisk, then supersu magisk, then xposed magisk and it did the same as before, black screen once it booted :/ trying to uninstall xposed now, not sure the issue as everything seemed to flash fine... If it helps at all I am using an verizon htc 10
[Magisk] CanitoLagos:
Can you fix?? I think the problem are in the boot.img, maybe you update to Lenovo boot.img, if you come back to first marshmallow firmware maybe fixed the problem.

I can't comeback to stock because my moto x(2014) don't recognize my PC.. strange problem, my charging port are fine.

My question is if I can install Magisk on custom ROM like CM13, RR or Stock++? I read for long time this thread but I don't have lucky to see any solutions.

Thanks and sorry for my bad English (im in the bus and i don't have much time to use a translate)
[Magisk] GazCore:
me too

only the LED that flashes red :(
[Magisk] RandomPooka:
Did a couple different searches through the thread and haven't come up with quite what I'm looking for. Trying to get Tasker to use a root shell to send an "input keyevent 26" (power button) when certain conditions are met.

Previously, I was using systemless SuperSU on my Nexus 6 running the 8/31 PureNexus, and this worked just fine.

After installing Magiskv6 and the modified SuperSU only (This is the only mod I'm using), I can no longer get this to work without having Selinux set to permissive mode. Rather frustrating, to say the least. I'm wondering if there's something I'm missing here. Do I need to somehow enable tasker in the sepolicy? Can I use tasker to send a "permissive" toggle before trying to send the keyevent, then restore "enforcing" after?

I noticed that I also couldn't use the following without being set permissive:

wm density ### (from a terminal emulator)

enabling Substratum themes

Once I toggled permissive, I was able to change themes and window manager density, which both "stick" after toggling back and both survive a reboot.
[Magisk] xagosccp:
Same here
[Magisk] Caramon420:
Thank you

This works for my SM-G903W stock rom with phhsu plus xposed runs really nice. still works with pokemon go 0.37.0 Thank you very much.!!!!:D:D:D
[Magisk] Hassanator:
Might be a silly question... But can I install modules in Core Only Mode? Cuz I can't seem to pass safetynet without the use of core only mode even though I've not installed any modules before
[Magisk] Didgeridoohan:
Core Only Mode disables all modules. Magisk version, Manager version, Magisk log?
[Magisk] krish@3T:
Install the latest magisk it will definitely passes the saeftynet
[Magisk] ShevT:
The latest working version of Magisk for Cyanogenmod 12.1 (Android 5.1.1) - v13.0 (0b4baad)

All versions that were released later do not work. The launcher reloads cyclically.

If I try to run MagiskManager, then my phone go reboot.

If I delete only MagiskManager, then problems with the system disappear.

There is a solution?
[Magisk] MRDOCA:
Still seem to be having issues with latest manager FC. Attached log. 5.0.6 app works fine for me so I'll just roll back.

Phone:

SMG935F

Minotaurus s8 port v14

Notorious kernel 1.6.4
[Magisk] marciorssilva:
Just installed v13.3 on D851 with Fulmics 7.5 and everything works silky smooth! One more thing i have multiROM, Fulmics 7.5 as primary rom and Mokee as second rom, any idea how can i install magisk on the second rom and pass safetynet test? I have tried the normal way but the installation on the second rom won´t pass safetynet...thanks..