yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Seen this?:

https://xdaforums.com/t/pubg-crashing-fixed-on-rooted-phones.4073331/

Seems pubg now detects root, but doesn't Give any error, just crashes.

So you need to hide root from pubg like any security centric bank app. My method:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84936057

Nb. Hide / wipe order.

Additionally, seems you also need to hide Magisk App according to 'pubg-crashing...' thread OP.

Nb.2. OP there may be confused about the need for MagiskHide Props Config module. It shouldn't make ANY difference unless props are also 'configured' (added / altered) through its terminal emulator interface, but OP hasn't indicated any changes to make / configuration. (I could be wrong, but try first without it.)

Hope this one helps! 😛 PW
[Magisk] pndwal:
There have been previous issues where zero padding causes problems, but I don't see any known ones currently.

However, these two issues may (probably) be affecting you (actually seems to be one issue, first running Android 8 EMUI like you, second running Android 9 LOS16.0):

https://github.com/topjohnwu/Magisk/issues/4297

https://github.com/topjohnwu/Magisk/issues/4306

Just been labelled a Regression, and @osmosis appears to be on it. 😛

If the regression is in this commit of 4 May 2020:

https://github.com/topjohnwu/Magisk/commit/0c99c4d93f638d5cde9a232321af791c54be278b

as user indicates (and this is your problem), last working Public Stable Magisk for you will, in fact, be 20.4.

It's surprising it's taken this long to be reported!... Guess there may not be many Huawei users testing Canary. 🙄 PW
[Magisk] pndwal:
I'm guessing you didn't Restore Images to take OTA? - you need unaltered read-only partitons such as /system, /vendor, /recovery, /boot to take stock OTA.

Generally, flash stock Recovery if using TWRP, and Uninstall Magisk using Restore Images function.

Next, seems you flashed boot.img from earlier .59 build? (So you're on .61 w/ old boot image?) ... Patching non-matching boot.img may be causing latest bootloop. You need to patch boot.img for current ROM build.

Sorry if I misunderstood what you've done, but you've given very little away! 😬 PW
[Magisk] pndwal:
'And now for something completely different' ... and controversial ... and OT, except that it goes to OP's (not entirely unrelated) interests ... in a fellow techie's interests ...

... I'll just post a link:

www.twitter.com/topjohnwu/status/1390536971894751234

Sorry. (... Tried to warn you!) 😬 PW
[Magisk] SaikiK:
Hello, thank you for replying. I don't know how to restore earlier images as phone is updated. My phone is working fine, I restored new a.61 boot.img only. But after patching this file by magisk, I ran into boot loop. Then restored original a 61 boot.img and it works fine. It's just that patched boot.img is not working.
[Magisk] Xellerate:
After patching the entire ap file from stock firmware, and then flashing it, my android boots up without the touchscreen working, this can only be avoided by flashing a patched boot.img even though magic app states that i don't have a ram disk, and when I flash a patched recovery it says vbmeta not verified
[Magisk] 535iu:
Thank you. I have exactly the same problem as in the first link, the only difference is the phone model.

I assume that if the bug in the second link is fixed, it will also work for the problem in the first link.

Does the "regression" tag mean that the problem will be fixed?

Until recently, I had no plans to update Magisk. However, I need to successfully pass the SafetyNet filter. I have read that the latest version of Magisk allows to succeed with SafetyNet. It is possible that SafetyNet is the reason why other users want to upgrade Magisk after such a long time and have taken the time to report it on GitHub.

Do you think the problem will be fixed, maybe in the next release?
[Magisk] pndwal:
Ah, got it now. Sorry, misunderstood ' original boot image'.

Done some checking into your model and build numbers. Seems you have Realme C3, and Update was to Android 11.

Looks like you have a now known issue:

https://github.com/topjohnwu/Magisk/issues/4313

User @HemanthJabalpuri posted here too:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84963087

Might just have to watch that one. 😛 PW
[Magisk] zgfg:
If your 'problem' is Magisk mngr/apk showing API error for SafetyNet - simply don't mind (don't do SN tests from Magisk mngr/apk), use 3rd party SN checkers instead (available on Google Play) or just install the latest Magisk Canary apk (instead of your old Manager) but keep the Magisk that works for you

SN API error is because the SN key has expired. Every app that wants to do SN tests must register a key with Google - and that key has expired in the old Mngr.

But it has nothing with any other app that will do its own SN test (with its own key)
[Magisk] pndwal:
I think both issues, "I lose root privileges after updating" & "Magisk framework does no longer start up" describe the same problem, so my guess is that the fix will also be the same.

Means a change caused a reversion of working function(s).

Yes.

$64 000 question! 😁

Depends on colaborators time, priorities, schedule, access to diagnostic data, on John, holidays planned, covid19, the weather...

Best watch those spaces / contribute if you can! 🤠 PW
[Magisk] pndwal:
It's a Sammy? Magisk App says SAR Yes?

A checklist:

- Did you patch AP with Recovery mode selected?

- Did you do full data wipe w/ initial Magisk installation?

- Avoid MTP transfer?

- Flash the other files, not just AP?

Method:

Initial Magisk installation:

- Patch AP tar w/ Recovery mode selected.

- Copy the patched tar file to your PC with ADB (NOT MTP).

- Using Odin, flash magisk_patched.tar as AP, TOGETHER WITH BL, CP, and CSC (NOT HOME_CSC) to flash w/ data wipe.

- Allow Additional setup from Internet.

If updating ROM:

- pre-patch AP w/ Recovery mode selected.

- Copy the patched tar file to your PC with ADB (NOT MTP).

- Using Odin, flash magisk_patched.tar as AP, TOGETHER WITH BL + CP + HOME_CSC to upgrade / keep data.

- Allow any Additional setup from Internet.

... If you did do all that without success, please give details of phone / ROM, and Sammy users may chime in. 😛 PW
[Magisk] SaikiK:
No it's android 10 only and realme ui 1
[Magisk] pndwal:
Ah, I read this:

https://c.realme.com/in/post-details/1377151834564694016

and assumed again.

Problem with a.61 build is still very likely the same as issue on GitHub (both update privacy/security with latest changes, and both OTAs are incremental updates from RMX2027_11.A.59), so you may wish to comment in that issue thread.

Also, you may still have issues resulting from applying OTA without restoring images (Magisk Installed), but I'd say this is less likely. Boot image was clearly messed up by incremental OTA, but you've replaced that...

You may want to try flashing complete ROM (dirty flash) to check if it helps now that you have a.61 complete ROM package. PW
[Magisk] artyfarty:
Hi, anyone in italy have problem with Credem home banking app? App found root (and close itself) even if magisk Is hidden root ti app and with anonymous package.

I have twrp too, on oneplus nord

Thanks
[Magisk] pndwal:
Cleared data since?

This, or something else here may help:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84936057 PW
[Magisk] SaikiK:
Full stock rom of a.61 is not available on the internet rn.

Also there is no twrp for realme c3 atm iirc. So I can't flash any zips.
[Magisk] ipdev:
Hi.

I am not familiar with Realme.

I did a quick check and see there is TWRP build over in the Realme C3 forums.

[RECOVERY][TWRP][RMX2020] TWRP 3.5.2 [UNOFFICIAL] - xdaThread - Link

Looks like it has only been out for a month and I am the only one who hit the like button so far. ;)​

Quite a few custom rom threads but, I did not see a thread for Stock rom / firmware.

Realme C3 - xdaForum - Link

Hope this is the correct TWRP for your device.

Cheers. :cowboy:

Edit:

@SaikiK

I see, you device might have rollback protection.

To be safe, you might want to ask in the C3 TWRP thread before you try it.
[Magisk] zymphad:
Where is the canary build?
[Magisk] martyfender:
https://github.com/topjohnwu/magisk-files/tree/canary
[Magisk] mermaidkiller:
I use Termux. Sometimes I need a root shell, so I granted root permanently to Termux, so I can use 'sudo bash' in Termux. But, as there is no password prompt, this is actually a security flaw. So I wanted to revoke root access and grant root access only on demand, when I really need it.

Revocation succeeded, but I can only grant root access permanently and not temporarily. The latter only happens when I grant root access to an app for the very first time.
[Magisk] J.Michael:
Where does your "sudo" command come from?

I use Jack Palevich's Terminal Emulator. When I installed Magisk, I got an "su", but no "sudo". I defined an alias sudo='su -c' that works most of the time.

I told you all this so I could tell you: when I use "su", there's a pop-up asking me to grant permission. I always OK 10 minutes. I don't remember choosing my Superuser manager.
[Magisk] Didgeridoohan:
Can't reproduce. If I revoke superuser access for Termux and then run su I can pick "forever", "once" or one of the set time periods.
[Magisk] Didgeridoohan:
The latest Canary apk is always linked in the main Magisk GitHub repo:

https://github.com/topjohnwu/Magisk
[Magisk] pndwal:
Did you look?

Scroll down, or search realme C3 in page:

https://www.realme.com/in/support/software-update

Version: RMX2020_11.A.61

Release time: 26/04/2021

Size: 3.05GB

md5: DF9EA46D8595715626C4271D9B60CFA8

Also, typing C3 in search box here gives ROMs by region (for Realme C3 and Realme C3i):

https://realmeupdater.com/downloads/latest/ PW
[Magisk] mermaidkiller:
Now it worked:

Rather than turning off the switch on the right (which I did), I click long on 'Termux and click on 'Revoke' (on the right). Then it asks me for confirmation.

When I subsequently do a 'su' from Termux, the grant access prompt indeed appears.

So now it works.
[Magisk] DiamondJohn:
Just a guess as I never use Termux. I to use a standard android shell. And sudo is not supported. Its su in an android shell.

As for asking for a password, thats how linux works NOT android. This is android. If anything whatever termux is, thats what would need to wrap a password request. But again, this is android NOT linux.
[Magisk] 73sydney:
@pndwal

I haz made my first Magisk related issue, lets see how quickly it gets closed :) :)

Born out of testing 4 ROMS this week is this "issue" was driving me nuts

https://github.com/topjohnwu/Magisk/issues/4333

Its not entirely out of bone idle laziness, but having to switch back after each module install was starting to get on my nerves :)

I dont hover around github enough to know if its been mentioned before
[Magisk] pndwal:
Was about to say I think It'll be considered, but see it's more than that already. 👍

Re. idle laziness, I agree with John that Open Source is great!

Could be no coincidence that Chris is on it though; what's with you compulsive testers / gluttons for punishment? 😜 PW

https://twitter.com/i/web/status/1245139248447131649

https://qablog.practitest.com/should-all-testers-have-ocd/ PW
[Magisk] ipdev:
It is just good testing. ;)

Does it work.

No - Try to fix it.

Yes - Find a way to break it.

The next step is figuring out why it doesn't work on one device when it works on the rest.

This is the difficult step.

Cheers. :cowboy:
[Magisk] pndwal:
Quite.

I had my tongue firmly in my cheek when I said that, but fully appreciate testing efforts / methods / benefits to all of us, yours included!

FWIW, I don't think it's bone idleness or lazy to work for an easier testing setup either. After all, John happily accepted @vvb2060's Auto close issues bot. 😬

... But then, he IS lazy... Said so himself! 😜

Incidentally, I hope I speak for most of us here in saying that we do this largely to entertain ourselves (for fun). Of course, offering help to one another and educating ourselves is the main aim, but I hope we can have a bit of fun in these forums from time to time without being taken too seriously...

I make this comment after just having had a post w/ link to Monty Python's original 'I don't like Spam' sketch (along with others that inspired Python programming code) removed from 'Spam Users' thread. This, to me, is a real irony. 🙃 PW
[Magisk] ipdev:
Ignore this post.
[Magisk] pndwal:
But you HAVE figured it out. It's precisely BECAUSE they're so bad!... And nerds / geeks do still have a sense of humour (of sorts 😉), at least when they take a break. 😁

But what would I know? I have a real job 😜 n just do this for kicks... Better ask likes of Guido van Rossum...

My response in that thread has survived till now, and was appreciated by one XDA mod with a sense of humour / history. (He liked the original sketch links in less than 30 secs, and commented they are 'finally, some worthwhile spam', but his posts were expunged also). Something there may give a clue:

https://xdaforums.com/t/spam-users.306366/post-84980987

EDIT: Too late: Other mod removed it. 🙁

Thread:

https://xdaforums.com/t/spam-users.306366/

ALWAYS!

Re. OT: As the man with the wooden leg said, it's a matter of a pinion.

Eg. ONLY Download official Magisk from JOHN Wu's official GitHub! There are some 3300 other Magisk forks on GitHub alone. Some of these are DIRTY!

Surely, the need to beware of a Dirty Fork is very much ON Topic! ... Here's a subtle reminder:

😜 PW
[Magisk] pndwal:
Latest Debug (Canary)

Changelog and Release Notes:

Magisk (6b34ec3a) (22105)​

[MagiskHide] Some changes that prevents zygote deadlock

[General] Update BusyBox to use proper libc

[App] Fix issues when patching ODIN tar files when the app is hidden

Diffs to v22.1​

[App] Update snet extension. This fixes SafetyNet API errors.

[App] Fix a bug in the stub app that causes APK installation to fail

[App] Hide annoying errors in logs when hidden as stub

[App] Fix issues when patching ODIN tar files when the app is hidden

[General] Remove all pre Android 5.0 support

[General] Update BusyBox to use proper libc

[MagiskPolicy] Remove unnecessary sepolicy rules

[General] Fix a C++ bug that causes undefined behavior

[MagiskHide] Update package and process name validation logic

[MagiskHide] Some changes that prevents zygote deadlock

https://github.com/topjohnwu/magisk-files/tree/9d8ae9c501f3975a9a548a5d2dff440d9ce9b8a2

Don't you just love Mondays!

Flashed fine on RN8T, SafetyNet, modules fine incl. Viper!

Nb. Fix for image patching on Samsung devices.

Thanks to John and colaborators! 👍 PW
[Magisk] 73sydney:
Awww, i expected some sort of witty comeback after which id have to remind you that i "know where you get your coffee in the morning" :)

But no....

So disappointed :)

And yes, it was nice to have my issue greenlit by @osm0sis, its amazing what you can get through the gatekeepers ...all it takes apparently is a cogent argument or report....who knew? :)
[Magisk] JustinChase:
I think I remember seeing something a while back that Magisk manager merged with the App, but I still have both when I open Magisk. This is fine, but whenever I update the App, the Manager immediately shows an update to the same version, so I think maybe they are both not necessary any more.

Also, whenever Magisk tells me (via notification) there is an update, when I click download, it does, but the resultant file gives an error when I click on it, so I have to update from within the App itself.

Is there anything I should do at this point to consolidate, or is this just how it works now.

thanks for the help/guidance
[Magisk] J.Michael:
I am having trouble understanding what you are reporting.

There used to be an .apk file used to install Magisk Manager on a device. It was just an Android app. There was also a .zip that could be flashed using TWRP to inject Magisk into various parts (partitions) of your system. And a .zip that could be flashed using TWRP to undo the changes to the partitions.

The "merger" was of these files: Now you download a magisk.apk. Use it in Android, and it installs the Magisk Manager app. Rename it to .zip and you can use it in TWRP to install Magisk. Further rename it to "uninstall.zip" and you can use it in TWRP to uninstall Magisk (the real guts of Magisk, not the Magisk Manager app -- that's just an Android app, you uninstall it like any other app).

When you run the Magisk Manager app and it talks about the Manager, it's talking about itself.

Go through your Android Apps drawer and make sure that you do not have more than one Magisk by any name.

Someone else will have to help with the "update Magisk" problem.
[Magisk] pndwal:
Still 2 components, no longer released separately but both still needed and both require updating.

New single package delivery explained by John in Release Notes:

https://topjohnwu.github.io/Magisk/...agisk-manager-is-deadlong-live-the-magisk-app

If working from within App, seems all is as it should be with Magisk. May be a general issue with package installer (settings / other) on device. What is the error? PW
[Magisk] JustinChase:
Thanks to you both for the input.

I only have one Magisk app, but within that app, I see Magisk and App. They show the exact same for Installed (6b34ec3a (22105).

Normally, the App tells me an update is available, via a notification, and clicking download/install from the notification downloads a file, then clicking that gives this message:

"There was a problem parsing the package."

I simply open the app, then the App shows the update button, and as soon as that finishes, then Magisk shows me the update, then it needs to reboot when finished.

Based on the 'I've merged them' note and the fact that they seem to have the exact same version, and that Magisk is only shown the Update (immediately) after the App installs it, it seems like maybe this isn't quite right.

Based on both of your input, I now believe this is 'normal', so I guess there is nothing for me to do at this point.

Thanks again
[Magisk] plepew:
Yes, the app is one now and within are 2 components Magisk & App. It all looks normal to me.

Hmmm...just curious as to why my screen is a bit different in terms of the “Installed Names: (6b34ec3a (22105)”.

Are you using Stable or Canary version?

What device are you using?
[Magisk] JustinChase:
I am using a OnePlus 8 Pro. I believe I'm using Canary. I think I had to use Canary at one point to get it installed (or to get adblock installed?), and never bothered going back.

thanks again
[Magisk] plepew:
Since you're using Canary, maybe that's the reason for the naming format. I'm using Stable.

✌️
[Magisk] pndwal:
Exactly. Last Stable FULL version number is 22100, so Canary contains more fixes, but could have additional issues / regressions. PW
[Magisk] pndwal:
That means App and Magisk (Mask) are in sync as John said.

This problem is from your system, not Magisk. Often occurs if you try to run update any app while older app is still open (if run from within an app, update will usually include shutting down app in the process).

This also occurs if trying to DOWNGRADE an installed app, and therefore occurs if moving from Latest Canary Magisk build to latest Stable, which is actually a downgrade as seen by full version numbers, (even if updating from within Magisk App) unless Canary Magisk App (not Magisk Mask itself) is uninstalled first.

They are only merged in package, as explained.

It's Still a two part solution, and App part always needs updating first, BEFORE Magisk itself can be updated... Nothing has changed here, but if numbers are identical, Magisk will be the latest that the App can support.

Yep.

Nb. you do need to ping those you respond to on XDA (by quoting - Post reply button does this - or by mentioning them) or other parties will not be notified of your response. 👍 🤠 PW
[Magisk] dr4go:
Woohoo! I got a working fix! The diff looks hilarious as well... A chmod was missing somewhere... Thanks John! And pndwal for convincing me to reopen my bug report. 😉
[Magisk] zgfg:
22105 must be Canary (Stable and Beta are on 22100 and they will be updated to likely 22200 when the time comes)

However, strange that your screenshot shows only 22105 without the string version - mine shows just like from @JustinChase - and it always does for me: both the Magisk version string and number

Btw, I always stay on Canary, update the apk when notified, and then patch and flash my boot img
[Magisk] 73sydney:
This thread is a disgusting monument to activity and progress :)

Largely due to @pndwal @zgfg @ipdev

Almost as bad as @Didgeridoohan 's MagiskHide Props Config thread, continually blooming updated

Im going back to threads where people just phone things in and nothing gets done....i believe i may have even started one or two :)
[Magisk] pndwal:
Sorry mate, but which screenshot? I think he said he's using Stable.

I think abbreviated version then (full version), ie. 22.1 (22100) as shown (rather than string version (full version)), is normal for Public releases. PW
[Magisk] zgfg:
Post #45722, from @plepew, his attachement

But yes, taking glasses🥸 I see now, he has 22100 (not 22105). Sorry
[Magisk] pndwal:
Nice one! Watch out you don't make Samsung the new Pixel! ... Too late already?

Don't think there's any problem with 'Diffs to 22.1' (except that classic British usage is an interesting choice of grammar considering John is based in USA.

https://proofreadmydocument.com.au/writing-tips/grammar-different-from-to-than/

Taiwans emphasis on English education w/ teachers from both USA and GB may explain this though! 😉 )

The fix is now merged in debug Canary, but not yet in public builds, so it is rightly duplicated in 'Diffs' list. (Ie. It's a list of commits YET to be merged into public releases.)

Generally, the difference list is reset (empty) in first debug Canary build ('sync with public release') after a public release.

Probably has a lot to do with @osm0sis's analysis / labelling / giving John a push off the sofa! (It may be hard to get good help, but open source is, as John said, 'a nice thing' & seems to motivate the best!) 🙂 PW
[Magisk] zgfg:
Magisk v23 Stable released and by Release Notes SafetyNet API error is fixed in (Magisk apk) Stable as well, hence no need anymore to use (Magisk apk) Canary for SN testing

Be careful, v23 supports only Lollipop and higher
[Magisk] plepew:
Tks for the heads up! Been waiting for this! 😝

✌️
[Magisk] pndwal:
Latest Public (Stable / Beta)​

Release Notes and Changelog:​

2021.5.12 Magisk v23.0​

This release is focused on fixing regressions and bugs.

Note: Magisk v22 is the last major version to support Jellybean and Kitkat. Magisk v23 only supports Android 5.0 and higher.

Bug Fixes​

[App] Update snet extension. This fixes SafetyNet API errors.

[App] Fix a bug in the stub app that causes APK installation to fail

[App] Hide annoying errors in logs when hidden as stub

[App] Fix issues when patching ODIN tar files when the app is hidden

[General] Remove all pre Android 5.0 support

[General] Update BusyBox to use proper libc

[General] Fix C++ undefined behaviors

[General] Several sepolicy.rule copy/installation fixes

[MagiskPolicy] Remove unnecessary sepolicy rules

[MagiskHide] Update package and process name validation logic

[MagiskHide] Some changes that prevents zygote deadlock

https://topjohnwu.github.io/Magisk/releases/23000.html

Nb (some already mentioned 🙂 ):

- Fix for SafetyNet API errors (in Check SafetyNet)

- Fix for image patching on Samsung devices

- Pre Android 5.0 support is removed

👍 PW
[Magisk] pndwal:
Latest Debug (Canary)​

Changelog and Release Notes:​

(23001)​

Sync with public release

Diffs to v23.0​

None

https://github.com/topjohnwu/magisk-files/blob/4f737b70868eb3f8b71e48518f919819cbf5ad63/notes.md

👍 PW
[Magisk] pndwal:
Re public release:

www.twitter.com/topjohnwu/status/1392352347959922690

👍 Thanks again John & all colaborators! PW
[Magisk] firestoner:
im on V23 and have still safetyNet error, what can i do?