yashsingh1/xdaforums huggingface dataset:
[Magisk] Stillhard:
I get your point, we'll have to wait 😘
[Magisk] pndwal:
Haven't seen that message, but makes sense. No root apps I've had work on external storage, so if you're using adopted storage SD, or have other separate memory partition (I understand some devices do), Magisk App installed there won't have access to or see root.

Go to Settings, Apps (manage apps) and move Magisk App to internal memory. PW
[Magisk] MartinX3:
It's sad that magsik won't get any updates by its lead developer. :(
[Magisk] pndwal:
Early days, but I hope at least reins can be passed on to someone with no conflicting interests ...

Still, may be fight left in John yet; he does have a (HUGE) vested interest after all! 😬 PW
[Magisk] HippoMan:
What many of us are thinking and feeling about John's having gotten together with the alluring Ms. Google, and thanks to Steely Dan ...
[Magisk] zgfg:
One more screenshot circulating around (seems also a published but later removed)

Or, if not made by Photoshop
[Magisk] abacate123:
RIP
[Magisk] pndwal:
Well, first here was removed for a reason...

Just reading between the lines, but I'd say private communication is for colaborators at this stage. Makes sense they'd be in the loop.

I'm sure someone, John or someone in loop, will spill beans in due course.

Till then, anybody's guess... Perhaps an ownership change? Couple of Devs come to mind. 😛 PW
[Magisk] HippoMan:
I have now performed the fork, as well as some offline backups. However, I don't have nearly enough spare time to work on Magisk, nor do I have nearly the amount of qualifications that John has.

Let's more of us get forking.
[Magisk] pndwal:
3.4k of them. Probably plenty to choose from. 😋 PW
[Magisk] pndwal:
The man needs a break.

He certainly deserves one in my book. Not a lynch mob.

www.twitter.com/topjohnwu/status/1394835335096406023

PW
[Magisk] razes:
I'm trying to install Magisk 22.1 on my Samsung Galaxy S5 Marshmallow. I had before Magisk 20.4 and Magisk Manager (App) 8.0.4. I have updated TWRP recovery up to TWRP 3.5.1_9-0-klte

I've installed MAgisk 22.1 via TWRP as apk not as a zip file.

Everything was smoothly. I was able to reboot to the system. However, once I've open the MAgisk App, the App suggested to finish installation and to install some additional files. I did not follow that suggestion. So, after that the MAgisk version was 22.1, and MAgisk App version 8.0.4. I have updated the App version up to the last version 23.0. However, after the update the MAgisk seems to me stopped to recognize the version 22.1 (see screenshot).

So, what can I do now? Uninstall the MAgisk app from the phone Settings and reflash the 22.1 in recovery again and to follow the App suggestion to install additional files after reboot? Or should I completely uninstall MAgisk in TWRP and start from the scratch then? In such situation will I able to keep the root or I should root the phone again?
[Magisk] zgfg:
Uninstall all versions of Magisk apk or manager, specially if you have hiden/renamed one

Then install the latest Manager apk v23. And generally, whenever asked, finish the requested installation
[Magisk] ChewyLouis:
Hi guys,

i have a problem when trying to install the magisk_patched-xxx.img

The latest LineageOS (16.05.) and Magisk App (23) is installed. I'm on Oneplus 7 Pro.

When i'm in Lineage Recovery > Advanced FastbootD

and enter this command via cmd:

fastboot flash boot /path/to/magisk_patched.img

I always get this Error

sending 'boot' (98304 KB)...

OKAY [ 2.200s]

writing 'boot'...

FAILED (remote: No such file or directory)

finished. total time: 2.250s

Does anyone know how to fix this?

Thanks in advance, you guys are great! :-)
[Magisk] pndwal:
I don't know about advanced fastboot flash mode in LOS Recovery, but John no longer recomends using custom Recovery due to inherent problems custom recovery can introduce. So there's no guarantees here:

https://topjohnwu.github.io/Magisk/install.html#custom-recovery

Looks like your device is failing to find boot partition. Perhaps Recovery mode is not calling / switching to Fastboot mode properly, or other problem.

For official method, you need adb drivers on PC, img file in PC adb directory, phone in fastboot mode ('boot to bootloader') connected with usb, execute 'fastboot flash boot magisk_patched_boot.img'

Use of Custom Recovery is NOT part of Patch Image method referred to here:

https://topjohnwu.github.io/Magisk/install.html#patching-images

🤠 PW
[Magisk] krs360:
Has anyone succesfully rooted the Android 12 beta 1?

I've tried the latest canary build on my Pixel 3xl, but get a bootloop.
[Magisk] 73sydney:
Already tired of reading all the speculation

Speculators belong in gold mining and on wall street, not here on threads...

And for people sharing screencaps of private messages, on most forums thats grounds for a ban....just saying
[Magisk] 73sydney:
This is insanity

So many panic merchants

*sigh*
[Magisk] HippoMan:
John himself accidentally caused the panic to increase. He said, "I tweeted an assumption caused by miscommunication; I was informed it to be non factual; I deleted the tweet. That's all, really."

I'm glad it was a miscommunication, and I'm glad the tweet was deleted. Let's just see what happens over time.
[Magisk] ChewyLouis:
Thx for your fast reply,

when i follow the official method at first in cmd it looks like everything is working.

But after reboot nothing changed.
[Magisk] J.Michael:
You originally posted that you always get an error writing boot. Now you show success writing boot. What are you doing differently?
[Magisk] kafisc:
This should be the only solution as far as I know. But I didn't test it myself:

https://xdaforums.com/t/guide-flash-magisk-on-android-12.4242959/post-84605557
[Magisk] Lvsitano:
IKEA app (https://play.google.com/store/apps/details?id=com.ingka.ikea.app) is able to detect root even with Magiskhide. The app seems to work, but warns user at startup, of root being detected.
[Magisk] zgfg:
Settings, apps, Ikea, Clear Data - then enable Magisk hide for the app and then run the app

Otherwise if the app already remembered that phone was rooted, just enabling Magisk hide will not help

I didn't test with your app, the app is not available in all countries
[Magisk] razes:
Thank you.

1. Is it enough to uninstall the apk from the phone Settings (App manager) or I have uninstall completely the MAgisk in TWRP?

2. Must I place the Magisk 23.apk in the internal storage before the flashing or SD is also OK?

3. Is it OK to flash Magisk.apk or I have to rename it to zip file (I have TWRP 3.5.1_9-0 klte)?

4. Magisk 23 version is stable or it is beta?

5. I've heard to uninstall Magisk copletely it is enough to rename the apk file to uninstall.zip and flash it in TWRP. Is that correct?
[Magisk] zgfg:
I was talking about uninstalling Magisk as apk or manager, not uninstalling the Magisk (service) itself

That is, go to Settings, Apps, search for Magisk and Uninstall that app no matter is it called Magisk app or Magisk Manager

However, if you did Hide Magisk Manager (Hide Magisk App) then you had to give it a new name. E.g., if you renamed it to XYZ app - then you must also uninstall that XYZ app

After that you will have to install new Magisk apk again. This is just apk, to be installed as any other apk. Not Magisk to be patched, flashed, etc

Where from did you download? You should download from Magisk Github and there you can choose between v23 (23000) Stable or 23001 Canary - at the moment Canary is leveled up withe the Stable

Edit:

Please see my next post (new answer to your original post). The answer above may not help you because after re-reading your original post I'm no more sure do you really have the Magisk (itself, not Magisk App) properly installed, and which version of Magisk.

(The assumption was that you do have Magisk, but that you did Hide Magisk Manager/Apo and that now, your new Magisk App cannot find the Magisk)
[Magisk] zgfg:
Sorry but doyou please distinguish between Magisk App (former Manager) and the Magisk itself.

Magisk App has to be installed as an apk, and then Magisk by patching the appropriate image from that Magisk App (and then flashing), or by renaming the Magisk apk file to zip file and flashing through TWRP

You say that you installed Magisk via TWRP but as apk, not as zip - I don't understand what do you mean by that, and hence what you've got now as a result

It's a long story and doesn't make sense to repeat here (only particular details when clear about the basics from the documentation). Please go to:

GitHub - topjohnwu/Magisk: The Magic Mask for Android

The Magic Mask for Android. Contribute to topjohnwu/Magisk development by creating an account on GitHub.

github.com

and go through the Installation instructions and Installing Magisk chapter as part of Wiki

Please pay attention to the specifics for Samsung (I don't have Samsung and cannot help you for that part - which image to patch for your Samsung and how to flash it, or which TWRP to use)
[Magisk] plepew:
Oh noooo....he's gone to the dark side!! 😂😂

Oh well, it was good till it lasted...

Google hires John Wu, the creator of Magisk, for Android security team

Creator of the popular root tool Magisk, John Wu, is being hired by Google for the Android Platform Security team with his valuable skillset.

9to5google.com
[Magisk] InsaneNutter:
The days of been able to pass safetynet on devices with hardware attestation are numbered regardless sadly.

Maybe John can convince Google to work with the community so established roms can have Google certified builds which pass safetynet without the need for Magisk.

We all know its ridiculous you can be on an version of Android that hasn't been updated for years and pass safetynet, yet more up to date custom roms such as LineageOS will never be able to without Magisk.
[Magisk] Lvsitano:
Did not fixed the error. It can still detect root.
[Magisk] Didgeridoohan:
Start with the basics: app on the Hide list and the Magisk app repackaged with a random name.

For more:

https://www.didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps
[Magisk] pndwal:
... And AFTER above, reboot, clear your apps data, then try it...

Nb. This also assumes FULL SafetyNet pass, and PlayProtect 'Device is certified'. PW
[Magisk] zgfg:
I cannot install Ikea app from Google Play (n/a for my country) but I installed the following one (not sure is it the same and the same version):

Download IKEA App Apk- APKMonk

Download IKEA latest Shopping App Apk from APKMonk

www.apkmonk.com

and the procedure worked for me. First Ikea detected root, later, after cleaning its data and listed for Magisk hide, it stopped complaining

Ofc, I was fully passing SafetyNet

On the other side, my Magisk app is not hidden/repackaged/renamed and I have TWRP folder and few other root apps (it means that Ikea does not look for them when detecting root)
[Magisk] plepew:
I'm glad I at least have a version that passes for OP 6T, but I'm won't be so optimistic for my next device in the future... 😔
[Magisk] plepew:
Double posting...😜

So annoying when it happens...🤣
[Magisk] Elisacrew:
Any way to change SAR to No in android 10?

In andro8d 7.1.2 sar = no
[Magisk] pndwal:
So official flash method is working at least.

Is this on a clean OS Install? Or have you had a previous Magisk Manager installed previously? Hidden Manager?

Also, does your device show Recovery mode in Magisk, Install? And can you post magisk_install_log generated when patching boot.img? PW
[Magisk] pndwal:
Short answer: no, I don't believe so.

This requires a little understanding of evolving Android device architecture, as well as definitions of SAR. John's differs from Google's. (Perhaps that will change now 😛)

Seems yours is older 'legacy ramdisk' (original A method) device.

Method B is Legacy SAR, and Method C is what John calls 2SI ramdisk SAR, so you now have this.

Regarding why C method officially non SAR devices are regarded as SAR for purposes of Magisk:

https://topjohnwu.github.io/Magisk/boot.html

🤠 PW
[Magisk] pndwal:
He's using ADB fastboot from PC, not advanced fastboot flash mode in LOS Recovery. 😉 PW
[Magisk] pndwal:
Interestingly, this very thing (passing compliance tests and certifying Google security model is not subverted) was proposed not long ago (at the time of initial Hardware Keystore Attestation shock/horror test runs) by Shawn Willden ('Tech Lead for Android hardware-backed security subsystems'), in this conversation with Luca Stefani ('Director for LineageAndroid & Developer') on twitter. I mentioned it here:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-83281243

Not sure if that went any further, but LOS would clearly become an extraordinary boon if this could be done / interest rekindled...

Certifying LOS and other qualifying custom OS's as 'secure environments' for running proprietary code would also be a way for Google to throw an olive branch both to security conscious corporations, and to custom modders at once! 🙂

Clearly, a few issues like including GApps*, and providing signing keys for validated system images that allow for bootloader locking / verified boot (verity enabled) need resolving.

Notably, Shawn did indicate that these objectives may be achievable.

* Since the original Steve Kondik (aka CyanogenMod) cease-and-desist saga, CM and LOS have not been able to bundle proprietary Google Apps as Google allows only end users to sideload them.

It's a good point, but certified LOS has in fact been mooted by bigger players than John Wu already. So never say never! 😉 PW
[Magisk] asdasd121212:
I'm writing here to troubleshoot or even sanity check my current issue with magisk.

I have POCO X3 (surya), with pixel experience rom (PixelExperience_surya-11.0-202110419-1216-OFFICIAL) and magisk 23.0 installed.

At first glance it seems to be working - gives root access to apps that request it, installs funky packages from its store and whatnot. I can verify correct root by being able to browse system folders through explorer app etc.

But I feel like I have somekind of issue where granted priviledges are supperficial. This is because when I try to use apps that benefit from systemless nature kind of don't work.

Few examples:

adaway and systemless hosts - everything seems to be working, hosts file filled with urls, but ads are not hidden and dns logging not working

debloater - i have an issue where i can't add a contact to just sim or phone itself, has to be google account. the fix is apparently to delete GoogleContactsSyncAdapter.apk. I can only find it in /system/product/app, but this is readonly (guessing that this is the systemless part). Through debloater module I was seemingly able to delete this app, but nothing changed.

So based on these issues I feel like magisk thinks its working correctly but in reality is just modifying somekind of junk in memory, while the runtime itself doesn't register these systemless changes.

Any help or suggestions?
[Magisk] daddylonglegs:
Hey all, long time Magisk lover and even frequent donor to this great little program that makes my phone so much better to use.

Just the other day I decided to update the official OTA on my Google Pixel 3A (previously I was on the January update with no issues). Everything was running fine and I decided of course to install Magisk after the update. Ever since then, the lag on my phone has been staggering to the point where I hate using my phone.

I can basically have like one app open even after a fresh reboot and doing something as simple as typing will result in long periods of lag. I'll simply try to text someone and it will freeze up for sometimes as much as ten seconds in the middle of typing a word.

This wasn't happening before I reinstalled Magisk. I've never had this issue before so I hate to blame it on Magisk but I don't know what else it could be. I found a few people here complaining about the same thing. Some said reverting to version 21 fixed it but I really don't want to go through all that if possible.

The only modules I have installed are riru, systemless hosts, Universal Safetynet Fix, and Riru LSposed with Gravitybox.

I'm on Magsik 23.0 (23000) for both the app and Magisk itself.

I would really appreciate any insight or fixes I can try. Thanks so much in advance! I really hope this post doesn't come off like I'm anything but extremely grateful for Magisk!
[Magisk] pndwal:
Not sure of all your issues, but major changes to Android architecture may be affecting your mileage.

For example, A10+ stock ROMs are generally locked to read-only due to 'Shared Blocks' implementation. It's NOT due to Magisk, and actually means Magisk's systemless solution may now be the only practical way to 'edit' system. Magic Mount is the way this is done:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84794697

Magic Mount is effectively a mask / overlay over system, itself untouched, stored in /data/adb. So debloating modules etc, leave original files / apps, but mask or 'replace' these by means of overlay data.

More:

https://xdaforums.com/t/magisk-general-support-discussion.3432382/post-84739785

Sorry I can't help with your specific objectives; someone else may have suggestions / experience. I hope this helps with understanding need for systemless solutions. PW
[Magisk] pndwal:
I'd try disabling modules, and, if this fixes, re-enable one at a time to identify problem mod.

Systemless Hosts is a major cause of instability in kernels with f2fs loopback bug present. As you have an older device, it may still have this bug, but I believe custom kernels are available for pixel to fix this.

If your kernel has this bug there may be other causes also, especially other Magisk modules.

Also, what do you have selected in MagiskHide list? PW
[Magisk] daddylonglegs:
I am using EX Kenel manager especially for that reason (the systemless hosts bug). Everything was fine on the January pixel 3 update with Magisk 21.

I removed every module and I still get the lag unfortunately.

In MagiskHide I have the following:

Amex

Camera

Chase

Galaxy Wearable

Gear S Plugin

Google

Google Assistant (twice)

Google Connectivity Service

Google News

Google Opinion Rewards

Google Pay

Google Play Books

Google Play Games

Google Play services

Google Play Services for AR

Google Play Store

Google Support Services

Google TV

Google VR Services

Ikea

Netflix

Nintendo Switch Online

Samsung Accessory Service

Smarthings

Is anything there causing this?

Thanks so much for replying by the way!
[Magisk] J.Michael:
That's a lot of hiding. I've read that you should hide from as few apps as possible.

Try unhiding from all apps, just to see if the lag persists.

Is it really so hard to re-flash the "stock" images, to completely remove Magisk?
[Magisk] pndwal:
Good there then.

Could be... I thought you might have quite a few; the sheer quality may be the real concern, especially on an older device, and is likely your problem.

Best practice notes from John:

www.twitter.com/topjohnwu/status/1039528958289760256

https://xdaforums.com/t/magisk-the-magic-mask-for-android.3473445/post-70363391

Don't think you need any Google apps other than Google Pay (checks SafetyNet API) & Google Play services (com.google.android.gms.unstable ie. Safety Net process only) for example.

👍 PW
[Magisk] AndDiSa:
I do not even have Google Pay added to the hide list and Google Pay still working. Beside Google Play services only banking applications where I know for sure that they do not work without hiding.
[Magisk] molitar:
Help I have never seen Magisk deny a root request I get this message when I try to install Vance Youtube with the Vance Manager.

because an app is obscuring a superuser request, magisk can't verify your response
[Magisk] pndwal:
Also, I just realised you are running a custom kernel (for reasons I mentioned).

Did you restore ALL images to stock before taking OTA?... You need to restore at least stock boot.img (ie replace ElementalX kernel), possibly vendor (if you've run a custom ROM in the interim, recovery (if you used a custom Recovery), etc.

If you failed to do this to take OTA (and you could simply restore Magisk-patched ElementalX afterward), you will have corrupted any bit addresses in that kernel / boot.img that OTA updates.

This is because incremental updates simply patch data at specific addresses, and so require bit perfect specific sequential version images, and OTA likely requires stock Recovery functionality.

These requirements are outlined by John:

https://github.com/topjohnwu/Magisk/blob/master/docs/ota.md

OTA process for ElementalX kernel users is here (Scroll to Part 2: How to install an OTA system update):

https://elementalx.org/how-to-install/

😬 PW
[Magisk] J.Michael:
Maybe you can talk to SuperUser (or whatever the monitor is called) and grant privilege to Vance Youtube when it is not running.
[Magisk] zgfg:
Strange.

Open Magisk app, Superuser tab and find Vanced Manager. Simply enable for root (like the other apps you will see in the window)

If you don't find Vanced Manager, leave Magisk app opened and retry with Vanced Manager (maybe it waits too short for response from Magisk app) and pay attention to any pop-up.

Ofc make sure you didn't enable Vanced Manager for MagiskHide (then no pop-up for granting root will ever come).

If needed, go to Settings, Apps, Vanced Manager and Clear all (its) data and try again
[Magisk] molitar:
Yeah tried all them steps.. very strange error from Magisk and the pop-up does pop up and I do click Grant but than that message pops up.
[Magisk] molitar:
Tried that.. it does popup and ask me to grant.., still same error message.. so I tried to deny than went into Magisk and Magisk does not even show the app to than manually allow. It is basically saying your not getting root access with this app in any way shape or form.
[Magisk] zgfg:
I also used Vanced Manager to install Vanced root and did not have problems

But once I did have a similar problem with another app and by playing with (don't remember anymore but maybe uninstalling and reinstalling the app, keeping Magisk opened when running the app and so) I eventually solved the problem

Unfortunately, there is no way (like in MagiskHide) to manually add an app to the Superuser list
[Magisk] zgfg:
Which "that message pops up"?

Maybe it's not a root issue but something else - e.g. on MIUI, go to Developer menu and enable Install via USB (needed to install split apks as Vanced Manager does when installing the split YT apk - it will later mount over only one of the apks, the base.apk)
[Magisk] molitar:
Ok thanks for all the advice got an answer. An app that assigned itself overlay permission caused the problem. I have disabled the video players that gave themselves overlay permission so the only app I have now that has overlay is Lastpass and I was finally able to grant access.
[Magisk] zgfg:
Too many apps enabled for MagiskHide. You absolutely don't need all Google apps (you could think of)

When you first time enable MagiskHide, it will by default enable hiding from two or three activities in Google Play Services, and you don't need to add Google Play Store, Google Play Ganes and who knows.

Just wirh those enabled by default you will have Device Certified in Google Play Store and no problems there.

It should be also enough for Books, Music....

And also no need for Play Services for AR, etc

Disable all the other Google ones and check do you have any problem with those apps (detecting 'root' or so). If not, don't enlist them for MagiskHide

LESS IS BETTER

Edit:

Somebody with default MagiskHide for Google Play Services, please check if I have one activity too many enabled for Google Play Services - see the screenshot
[Magisk] pndwal:
Double post!.. Answers previous page. PW