yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
... well just come out and say it mate... 🙄

Look who's talking... I try to be succinct, but it's hard not to throw in the odd related anecdote... But I know I don't miss many opportunities to comment. 😁

... And don't click Like if you're too lazy to read a post! 😜

Since you're so lazy, probably few upsides... But so far adding Google Play Services to MagiskHide list is all I needed... And once manually added, it sticks and survives updates till removed, so that's an upside i guess...

Only general upside is running with John's most recent commits I guess; may help some w/ compatibility, but for other (what's the opposite of lazy?) people it'll no doubt help appraise mainstream Magisk changes going forward.

Well in that case my official advice is don't do it ...

Disclaimer:

If you spark thermonuclear war you are prohibited from blaming me, have indicted yourself, have violated my express instructions, were dumb to try due to inordinate laziness... all that jazz.

To be clear, I have not (so far) disclosed this users real name...

FWIW, Nigel was an overconfident mouse in an iconic kiwi cheese ad who ignored the mouse trap at his (Long lasting) peril. Still, kiwi cheese (from the mainland of course) is so good that his incredulous friend (after a loud 'CRACK!'), says "Well, it was worth a crack Nigel!..."

"... Nigel??". 😬 PW
[Magisk] pndwal:
Yup, but I'm not sure you've included all variations due to behaviour.

I learned from @zgfg that both SafetyNet (com.google.android.gms.unstable) and main (com.google.android.gms) processes in Google Play Services are added to MagiskHide list when MagiskHide is toggled on on a per device basis.

I hadn't noticed this until recently as my RN8T only sets SafetyNet process. But I recently checked settings on my Mi Pad 4, and was surprised lo see both are indeed set and reset w/ MagiskHide toggle on this device.

This ?

- Are you speaking of future MagiskHide (or "MagiskDeny") here? PW
[Magisk] zgfg:
An interesting lesson

It explains why and how MagiskHide can still be made working with Alpha (although, requiring manual setup and so) despite to TJW's announced total extinction of the MagiskHide feature

It's just a question for how long will vvb2060 keep the MagiskHide alive but hidden in his builds (branching out from the latest corresponding TJW commits) - maybe until the happy birth of the expected MagiskHide module
[Magisk] pleasetouchmenot:
Whats the latest alpha version of Magisk? Is it 9bf835e8-alpha, or 714feeb9-alpha?
[Magisk] Homeboy76:
9bf835e8-alpha
[Magisk] zgfg:
Visible everywhere: in the Magisk Alpha app, Alpha Telegram channel and on Alpha Github - screenshots
[Magisk] ipdev:
Per Device is what happens.

com.google.android.gms.unstable is always added.

com.google.android.gms is only added if Magisk does not reside in /sbin.

I assume your Mi Pad 4 does not have a /sbin directory.

So com.google.android.gms was also added to the list.

Most of what I have currently rooted is on some form of Android 11.

Since there is no /sbin Magisk resides in /system/bin.

They all have com.google.android.gms hidden by default.​

My OnePlus 5T is on stock OOS, Android 10 and still has /sbin so Magisk resides in /sbin.

com.google.android.gms is not hidden by default. SafetyNet passes without it hidden.​

I missed this change until recently.

So I dived into the commit history rabbit hole. 🙃

native/jni/magiskhide/hide_utils.cpp - Commit History

The Interesting commit labeled Alpha only: you noticed. ;)

Post 47,722

Looks like vvb2060 has re-synced a bit but, the commit is still named Alpha only.

Hopefully the not too distant future. :D

---

Cheers all. :cowboy:
[Magisk] ipdev:
vvb2060's current alpha release(s) can be found on GitHub.

vvb2060 [magisk_files] - GitHub - alpha - Link

Cheers. :cowboy:
[Magisk] pndwal:
Ah, thanks; I should have looked closely at commits you gave instead of doubting your (legal) thoroughness!

And yes, M Pad 4 running LOS 18.1.

Yeah, his re-syncs have confused me a bit; they conceal when they were actually made.

And just now - no more MagiskHide / hidelist. We now have denylist:

https://github.com/topjohnwu/Magisk...76ff6c913d2028ceafdb64ea06621a0a2d271ba47d3a8

😜 PW
[Magisk] zgfg:
Too much code to read🤓

In short, what will be the purpose of DenyList and why is that good for us?
[Magisk] pndwal:
Still early days / guesswork, but I'm still hoping my earlier supposition may prove to be on the ball (you might recall):

Seems it may go this way, but I'm not holding my breath... Shaping up ok, but there may still be more (pleasant) surprises! 😛 PW
[Magisk] Didgeridoohan:
From a quick look it looks like the only thing (pretty much, there's other stuff as well) that commit does is to rename anything hide related to deny...

Still very interesting to see how this is going to shape up.
[Magisk] zgfg:
IMHO, seems to be Deny list to deny root requests. Maybe to clean the path for the future (whoever will provide) Magisk Hide module

I.e., I didn't see sensitive props stuff in the Deny commit, meaning that at list that part must be provided through a separate module (IMHO, for the moment, they are already covered by (4) Edit MagiskHide props in MHCP)
[Magisk] Didgeridoohan:
Sensitive props were removed a month ago:

https://github.com/topjohnwu/Magisk/commit/003fea52b1857015bfc3988de56eb1a6d3049a7f

And other than that it doesn't seem like MagiskHide, or rather the new deny feature has been touched at all (I haven't checked everything though). If so, "deny" will simply be a way for making Magisk "getting out of the way" (as John put it). In other words Magisk will be able to hide itself just like it always has, only now even better because of the new Zygisk.

Speculation, of course...
[Magisk] Stillhard:
Get ready for the new Magisk

"Gettin' Zygisk With It..."
[Magisk] pndwal:
Commits on Sep 13, 2021​

MagiskHide / hidelist gone; denylist replaces,

Denylist configured in settings,

Remote Domain Name System resolution via HTTPS protocol gone,

SafetyNet check gone,

Module repo database gone.

https://github.com/topjohnwu/Magisk/commits/master:

PW
[Magisk] ldeveraux:
If he does ever release another build, I sure won't be "upgrading" !
[Magisk] pndwal:
Oh I think you might! 😜

Unless I'm mistaken, it's shaping up to have even more hiding power to leverage by 3rd parties.

The 'losses' are superficial too. - Repo can be replaced by 3rd parties down the track, we have 3rd party S/N checkers, denylist replacing hidelist may not be much more than a change in name, Zygisk will give Xposed-like powers to modules, John can concentrate on making Magisk more powerful in other ways as well...

Where's your faith?!

Have to say MagiskHide will be dead in the water as soon as Google swing the big Hardware TEE hammer anyway... MagiskDeny however may have staying power! PW
[Magisk] ldeveraux:
Until i see any evidence that Magisk progress rather than regresses, i stand by my statement. It's obvious what's going on here, but none the less unfortunate. I haven't looked too closely, is there another developer committing? Or just TJW?
[Magisk] Didgeridoohan:
Magisk != MagiskHide (even though that's how a lot of users see it)... Magisk is progressing nicely, just look at all the activity at GitHub.

John hasn't cared about MagiskHide for years...

But yeah, there's always going to be those that are disgruntled whenever there's change. But change brings new stuff and I'm confident that the community will deliver. It always does in one way or another.
[Magisk] zzz2002:
This may be a dumb question, but where do we (the average user) stand today.

John Wu's version Magisk is (understandably) heading for the trash can.

So what is or will be its replacement.

I Include in Magisk things like Magisk-Hide and other add-ons which make Lineage et al more useful to the end user.
[Magisk] ldeveraux:
I don't know how you can say that, all the seemingly good-for-end-users changes are made by other devs, all the seemingly regressive changes are by TJW. Sure, there's activity, but when half of the recent commits are things like removing Magiskhide, you can understand why that wouldn't be seen as positive by the end user.

Not caring about it and physically removing it are 2 completely different things. This is a lifeblood for many people, myself included, why rely on hiding banking apps, etc from root detection. We simply can't use Magisk without Magiskhide.

What "new stuff" has been added? From what I can tell, he's just removed features. You can ask the community to provide updates all you want, unless it's forked responsibly he won't merge/build them.

And ask the now former SuperSU users how much the "changes" helped them!
[Magisk] zgfg:
Understood that he is removing MagiskHide.

However, hoping that MagiskHide module will be developed (by somebody 😍) in the mean time

Btw (since talking here also about the history), wasn't the original name Magisk coined from Magic Mask (where masking was like hiding)
[Magisk] osm0sis:
No, the mask is the filesystem overlay
[Magisk] Didgeridoohan:
My, my... You're a bit of a pessimist aren't you?

There's been dozens of commits on the past month, of which only one removed MagiskHide code (which I've already incorporated into MagiskHide Props Config and @kdrag0n has put in the Universal SafetyNet Fix). The other commits related to MagiskHide have been about rearranging for the new deny mode (that so far looks exactly like MagiskHide when it comes to hiding Magisk itself) and introducing Zygisk that might even make the new reincarnation of MagiskHide even better than the old (but we'll just have to wait and see, and I chose to do so with excitement for what's to come).

And it's a great thing that there are so many other contributors besides John, that's a strength not a weakness (re your example of SuperSU).

And talking about SuperSU that was a very different situation...
[Magisk] bobbarker2:
You guys all know TJW was hired by Google right? He's a developer on Android Platform Security. So of course he would stop development (and Google would not allow him I'm sure) on projects that undermine his work at Google.

All the recent commits to TJWs Magisk repo have been for the removal of Magiskhide and any Anti-Safteynet features. It is correct to say Magisk != Magiskhide, however from a practical POV, Magiskhide was/is a required component of rooting and Magisk. Without Magiskhide, a device with Magisk will no longer be able to run a plethora of apps and it will not be Google Play Store Certified.

So any future development for a practical version of Magisk will have to come from other devs who fork TJW code. Fortunately Magisk is open source, so the community can pick up the project and continue developing it.

Completely different situation. Chainfire sold SuperSU to a very shady Chinese company, CCMT.
[Magisk] ldeveraux:
Believe me, I'd love to be wrong. But many people think this spells the end of Magisk and rooting in general. I simply wouldn't use a bastardized version of the software that removes key features, even if they are subsidized with others. If Magiskhide isn't replaced with something equal or greater, and I will personally judge for myself what's equal or better. Everyone else may have their opinion of course, that's mine.

I don't care how many devs work on a software kit, if it goes downhill, it will happen pretty quickly. It seems it already has.

SuperSU is a valid comparison for sure. It's something that worked quite well, wasn't developed further by the new company, was superseded by Magisk. My question is what if anything supersedes Magisk when it inevitably follows the same path. Again, I'd love to be wrong, don't see it happening. Long live Magisk, we hardly knew ye.
[Magisk] Didgeridoohan:
That is very well known by now, which is why he's removing the parts of Magisk that would conflict with that. But it should also bequite well known by now that he's got the all clear from Google to keep working on Magisk, which he's currently doing.
[Magisk] bobbarker2:
"Many people think it's the end of rooting"

Anyone who thinks that knows nothing about programming, Linux, or Android.

No, SuperSU having new ownership and TJW stopping development on Magiskhide is not a valid comparison in any way, shape or form.
[Magisk] bobbarker2:
Yes I'm sure most people knew, I was phrasing my post in a way so it wasn't attacking/singling out who I was responding to.
[Magisk] ldeveraux:
And this is something that someone who has no idea what they are talking about says. You provided nothing whatsoever to back up your statement. Just that I am wrong. OK great. Where are the immense leaps or even consistent development on the Magisk front to suggest it's smooth sailing forward?

Like above this is just your opinion with nothing factual to back it up. I was talking about the change in "ownership", not the technology. I can't think of an Android technology where the originator stopped work on it and it continued successfully. I guess we should stop here before the stalemate intensifies.
[Magisk] bobbarker2:
Rooting will end the day every developer/pentester/enthusiast/hacker stop their activities.

Look up "reverse engineering" in the context of programming and familiarize yourself with the concept of what "Root on Linux" means.

I don't need to provide evidence that the sky is blue or water is wet. These are facts.
[Magisk] ldeveraux:
I know how rooting a phone is different than superuser access in other forms of linux. You're incorrectly asserting idioms and blatantly ethereal concepts to justify your statements vagueness and outright fallacies. Have fun on the haxx0rz side of life, you clearly want to emphasize that's where you live. I try to live in the real world xxxxxx. This got real boring real fast, so I'm just going to block you and move on from this.

MOD EDIT: Unnecessary & abusive comment removed.
[Magisk] Lughnasadh:
"The amount of people saying Magisk is dead immediately is so funny TBH. It's trivial to create a whatever hiding module if you want, and I'm 10000% sure something like this will pop up as soon as possible. I'm just not in the position to lead nor assist such effort in the future."--John Wu

Furthermore, he's continuing Magisk and as far as I know he will also continue developing the actual rooting part of Magisk (which is actually a very minor part of Magisk as a whole). Rooting itself is far from dead. It's the hiding that will passed on to others. And as he's stated above, others will step in for that part, e.g. what kdragon is doing.

"Circumventing "dumb" root detections is like 5% of the effort; circumventing hardware backed attestation is impractical."--John Wu

The only worrisome part is what Google and other app developers will do in the future to make it harder, if not impossible, for developers to not only hide root, but to also tackle the hardware attestation problem. But this is totally independent of John's or Magisk's now more limited role in hiding root.

Everything will be fine...
[Magisk] pndwal:
Another developer?

Only some 215 of them! (w/ App UI pretty much maintained seperately by diareuse).

Many of these are currently committing actively and other pull requests are submitted regularly by others, often from those maintaining their own forks. (Some 4200 exist!)

It's easy to discover and impossible to miss the plethora of open source contributors who are contributing to Magisk for anyone checking progress, issue resolution, direction etc. for this project, or simply following this thread. 😜

www.twitter.com/topjohnwu/status/1433496853211844615

Users here have thanked many of these contributors, but many have done much work unnoticed, so MANY thanks for your self sacrifice and efforts with this cause to any contributors following here! PW
[Magisk] osm0sis:
diareuse has been MIA for a bit. Pinged him a couple times on the GitHub Issues, but no answer. Hopefully he's okay. 😕
[Magisk] bobbarker2:
Google was smart to hire John Wu. The best people to build security systems are the ones who are breaking into them. A decade ago I knew a couple of reverse engineers who were hired by Sony to improve a DRM called SecuROM.

It's a constant game of cat and mouse that is never going to end as long as there are parties interested.
[Magisk] pndwal:
Mmm. Nothing on his Twitter since February... That's concerning. PW
[Magisk] osm0sis:
Yeah and in a week it'll be 1 full year since his last commit to Magisk too. 😕
[Magisk] pndwal:
Isn't it already?

Universal SafetyNet Fix 2.1.0

- Fixed new SafetyNet CTS profile failures as of September 2, 2021

- Added MagiskHide features that will be removed in future versions of Magisk

May not be much different from what happens now going forward! - MagiskHide hasn't worked for most w/o 3rd party 'MagiskHide' module(s) for some time now...

Magisk still does the heavy lifting (provides the means / framework needed) but.

I'm guessing users may continue to need additional modules in some cases to pass SafetyNet. Eg user's of uncertified ROMs still need MHPC (set certified fingerprint) to pass SafetyNet in addition to USNF.

Sorry, but you may have missed the fact that MagiskHide hidelist has already been replaced by denylist... Time will tell what real world differences this will make, but commits till now indicate not much has changed other than the name.

Also, concerning other MagiskHide components removed, these are easily re-introduced by 3rd party modules (John called it a trivial exercise more than once himself!), work has already begun on these, and new Magisk features, especially Zygisk, will only make such a module (whether single or multiple) more effective / versatile / powerful / robust / foolproof.

John has as good as stated that he doesn't intend to block such development (he simply cannot lead such efforts / is no longer interested), and has expressed confidence that it will be done in short order to boot. So I say 'This is no biggie!'.

Google department heads have also stated that they view Magisk fraternity as a 'White hat community', and as such Google benefits from Magisk's existence, even from features like MagiskHide as it 'shows them what they need to do'... But I don't believe they're pressuring John, other than to comply with industry standard policy regarding a conflicts of interest.

He's gone on to say

And

Let's give 'MagiskDeny' a chance, and take John at his word that Magisk will be just as practical as a framework and then some. 😛

If this is true, we won't need unofficial forks to pass SafetyNet, Magisk will be just as practical for those who see it as a hide-broken-TEE solution along with modules from other devs just as it is now!

AFAICS, John's word has so far been good. Make that very good; he's a pretty impressive youngster.

It's others who've been quick to post and re-post what are really negative, unhelpful and outright misinformed knee-jerk reactions and rumours.

Agree! - l note that he deserved some return for his pioneering work, and that his timing was auspicious; not a moment too soon, not a moment to late! 😜 PW
[Magisk] pndwal:
safetynet-fix-v2.1.0 is public now...

Universal SafetyNet Fix

Changes

- Fixed new SafetyNet CTS profile failures as of September 2, 2021

- Added MagiskHide features that will be removed in future versions of Magisk

👍 PW
[Magisk] zgfg:
Github says released two hours ago - excellent, let's see...

Release v2.1.0 · kdrag0n/safetynet-fix

Changes Fixed new SafetyNet CTS profile failures as of September 2, 2021 Added MagiskHide features that will be removed in future versions of Magisk Donate If you found this helpful, please consi...

github.com
[Magisk] pndwal:
Public release yeah, but it's been available since Sept 6.

https://t.me/proton_projects/24788

Example of open source joint efforts - @osm0sis is supplying fixes for OnePlus etc:

https://github.com/kdrag0n/safetynet-fix/pull/90 👍 PW
[Magisk] Chandru123:
Removed the @Displax safety net mod fix and applied the latest USNF 2.1.0 from @kdrag0n.

Attestation is passed and device is compliant in company portal too with my original device name 1+8 Pro and not Pixel.

This is done over the latest Alpha Magisk.

Update: My In-display fingerprint hardware is not working anymore, I think the fix is already committed. Hopefully it will be resolved in the next version.
[Magisk] gfrank227:
Hi all. Is there any way to test at thsi time the new version of magisk which removed magiskhide and put in the deny list? Thanks.
[Magisk] Click Beetle DX:
Hello, all.

I need some help. I uninstalled Magisk and my phone is now in a boot loop.

I read that Magisk creates a backup of the original, unpatched boot image file.

I need to have access to this backup, because I did not keep the original, downloaded firmware for my phone.

And now I cannot find a download for the firmware version I have, to extract the original boot image file from.

In other words, I'm really screwed right now.

I have TWRP installed, and can boot to it. I can also access fastboot.

If someone could kindly tell me how to retrieve the backup Magisk made, so I can try and flash the unpatched boot image, I'd appreciate it. Otherwise I have to start all over from scratch, and that thought terrifies me.

Thanks in advance.
[Magisk] Didgeridoohan:
If it's available still it'll be in /data and if you have a recent Magisk version it should be in a folder named magisk_backup_<checksum>.
[Magisk] peradaban:
Hi guys, i need some help.

I just rooted my phone ( Pixel 3) with Magisk. it run smoothly and i can access the adb shell as root to confirm it.

however i cant install any modules on the magisk, even if i search for any modules it wont show anything. also i tried to install modules from storage and it says

!Unzip Error.

I have also tried to clear the repo cache but nothing change.

Kindly need your help. Thanks everyone.
[Magisk] osm0sis:
Yep, I have sent a Pull Request with the fix like an hour after v2.1.0 was released. 🤠

See my post here in the official USNF thread for getting it working in the meantime until it's merged and a new release is made: https://xdaforums.com/t/magisk-module-universal-safetynet-fix-1-1-0.4217823/page-59#post-85631613

Also may be worth everyone reading my comments at the end of that post about people doubting the sponsored testing closed-then-open development.

And then here on this GitHub issue about how it's not meant to replace MagiskHide so you can't just turn Hide off: https://github.com/kdrag0n/safetynet-fix/issues/91#issuecomment-919264624
[Magisk] Chandru123:
Overridden those 2 files and now everything works as expected. Thanks a lot @osm0sis.
[Magisk] anonxlg:
I downloaded a patched boot img to get root.

If i want to unroot, do I still use magisk's uninstall function, or am I suppose to fastboot and reload a copy of the unpatched boot img?
[Magisk] Fif_:
If you didn't use Magisk to install the modified boot partition ("Direct Install") and didn't use Magisk on your device to patch the boot image (which seems to be the case since you said you've downloaded the Magisk patched boot image), Magisk wouldn't have had the chance to make a backup.

So I doubt Magisk "restore boot image" would work in your case. I'd restore from the stock boot image you hopefully have saved somewhere with "fastboot flash boot original-boot.img" (maybe flash boot_a or boot_b depending on your device and setup).
[Magisk] anonxlg:
Yeah, that would be my guess as well. I've downloaded a copy of the unpatched boot image already. Except I don't know the right right magisk directories. So I'll just fastboot it. Thanks for the 2nd opinion.
[Magisk] Fif_:
With fastboot you can always try to boot the image before flashing it:

fastboot boot original-boot.img

Magisk should be disabled. If everything works, then reboot to fastboot and then flash the correct boot partition with fastboot flash.
[Magisk] Uluru25:
May I jump in with a question? In another channel I read that also restoring the /dtbo partition was recommended. Is this necessary or better: in which cases this might be needed?