yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
I've used Magisk root with Titanium Backup since Magisk v7 and never had any issues like you've described. On different devices and different ROMs (including PN). It works, but there's something about your setup causing it to not work. The question is just what... A clean install might fix it.
[Magisk] teddy0209:
Lol... same here, been using tibu since the first release of magisk without issues... ???
[Magisk] xd4d3v:
I figured it out.

i needed to add a line in post-fs-data.sh, thanks.
[Magisk] moozer:
Not possible because you are using software that circumvents security layers in Android. A bank's app will recognise this and not work even with Magisk hide on.

Only way around it would be to use Root Cloak, but as this only works with Xposed, you're knackered unless you're on Marshmallow and below.
[Magisk] teddy0209:
Why would it work with roatcloak and not with magisk hide?...
[Magisk] moozer:
No idea, I just tried with a banking​ app and it failed. No idea why.

This disclaimer may help you...
[Magisk] Fastrite:
Works fine here with tsb V13 (is there a newer one?) even though I have CTS mismatch (clean flash needed [emoji4] )

N6p 7.1.2 ABC & mag v12

#whiteuimustdie
[Magisk] Didgeridoohan:
Not true. There are banking apps that detect root that can be used with the help of Magisk Hide. And there are banking apps that you can't hide root from. Depends on how they detect root and tampering.

That's the disclaimer you get if you use SuperSU with Magisk rather than MagiskSU, nothing else...
[Magisk] moozer:
That would make sense. Thanks
[Magisk] cafe-creme:
If this is interesting and useful for those who use a Samsung SM N9005 (french Note 3 in my case)

I have posted a solution to make Magisk work perfectly.

https://xdaforums.com/galaxy-note-3/development/rom-magma-nx-rom-t3508672/page722

Tips on the Rom Magma NX and kernel phantom.

Thanks for your great works :)
[Magisk] patmann03:
So, not sure exactly what you're trying to say. But this is what happens with me.

Magisk will show rooted, but then after some time the app will no longer show that the device is rooted. However, the device is really still rooted, the app is just messed up. I know this because tasker is still working in root mode, greenify etc. The way to fix this without rebooting would to get a root checker. Click check for root, but do not grant the device root access forever, change to once or 10 minutes. This will cause magisksu to grant superuser rights and fixes the magisk app display and you're back having the app show your rooted along with all the other options.
[Magisk] nihilista:
And sometimes banking apps not only check root, some checks for magisc, xposed or some other settings, too. I have DKB Pushtan app which works, but after upgrading to new version not anymore. Its a neverending run between cloakers and banking app developers ;)
[Magisk] karthik km:
To work magisk properly just do this

1) uninstall magisk using Magisk uninstaller

2) reboot

3) reflash your stock boot image

4) reboot or skip to next

5) then again flash latest magisk V 12

It works fine for me

All apps detecting root properly
[Magisk] wrongway213:
Hey guys - just set Magisk up in the last two days and I'm really enjoying it. I'm only having one strange "issue" and I don't know that it's problematic - I've been reading up on various Magisk threads for 2 days now and I have yet to see this, (search yields no results, either) so I figure it's time to ask, as I would both like to know if there's a fix/reason for this, and to understand a bit more about what this feature does. My device = Nexus 6 running Screwd'd 7.1.2 and B14CKB1RD Kernel

Busybox being enabled appears to cause my device to remain "Permissive", in which case I cannot pass SafetyNet. Disabling Busybox in Magisk allows me to pass SafetyNet and boots me in enforcing. I've been unable to find what scripts might be loaded or not loaded to cause this discrepancy in behavior. This leaves me two questions:

1. Is Busybox forcing permissive a known issue, and if so, any workaround?

2. Are there any major pros/cons to using the Busybox contained within Magisk? All I have been able to find is that it is used to "ensure consistent behavior" - I am quite curious as to what functionality I may have issues with, etc. if unable to use Busybox in Magisk.

Any answers to those questions, or information (even just pointing me to what to read that I may have missed) on how to find the script/what have you that is causing permissive with Busybox enabled, I would be greatly appreciative.
[Magisk] patmann03:
My apps detect root just fine. It's just occasionally the magisk app doesn't think it has root until I reboot or get an app to ask for root privileges that doesn't have them granted forever.
[Magisk] adrman:
[MENTION=4470081]topjohnwu[/MENTION] I'll add to the chorus. In the long run, I don't care about Android Pay. Sure it's nice when it works, but I'm still taking something out of my pocket, wallet or phone, it really doesn't matter in the long run. Magisk with phhusson's superuser is an excellent approach for other systemless mods. Presently, I'm only using it for Adaway, GSAM and Action Launcher, but there is great potential there, not to mention, it's open source. As far as root goes, I don't want to "hide" it, but just easily disable when necessary. It's the safer approach. Please continue your work. It is appreciated and needed.
[Magisk] Nodens:
Modifying a person's work without explicit permission/license is something that can even be taken to court. Apologizing was actually the correct thing to do. Also Chainfire had all the reason

to be pissed because parts of his work were ported to phh Superuser without his permission so that phh Superuser could retain all functionality while rendering SuperSU unable to do something

(making AndroidPay work). This is indirectly damaging his project as it causes a massive influx of changing su provider since phh had no drawback yet the reason it had no drawback was because

Chainfire's work was ported without permission. This is the issue here. So people just relax and stay out of it.

Magisk as a framework for systemless modding is a great idea and in my opinion the project should continue. BUT without being officially supported by all the major system modifications (root providers, etc etc)

it is not a global framework but a dependency for some projects...
[Magisk] teddy0209:
Please continue, don't stop just like that, been using your work ever since your release of systemless xposed, i don't care about ap either because it doesn't work in my country, but your work has a lot of potential, you made things easier for the community and it was never a bad thing. Don't let it go to waste, don't quit now, you've already done a lot for this community and probably do more, just don't quit...
[Magisk] CHAMAVELI:
Absolutely nothing was changed. I don't use cache cleaning tools, and the files are still in place.

I have set permission to multiple different values, such as 644, 666, 750, 755.

As I said, I can see it being executed in the log. It's as if setprop is no longer working.

Any ideas?
[Magisk] :
I wish you guys would've settled this through pm to be honest. It's sad to see stuff like this on XDA, Android is open source, there's no reason why mods for it can't be.

Always competition and no damn collaboration. [MENTION=631273]Chainfire[/MENTION] I respect your work but not you after this... Just sad.
[Magisk] knpk13:
My bad
[Magisk] ipdev:
Stll excited for an update. ;)

Obviously you're pretty damn good. :svetius:

Do not "throw away you work" please. :o

You should enjoy your break ! (If any left..) Guys like you deserve it ! :)

The rest of us can and will wait for your return.
[Magisk] Philux:
What?!!! I think [MENTION=631273]Chainfire[/MENTION] has been more then fair in his position. He could have been a real d**k if he really wanted to be. I think [MENTION=4470081]topjohnwu[/MENTION] may have over reacted a little in his apology statement. I can sympathize with [MENTION=4470081]topjohnwu[/MENTION] for his reaction, because I know he has worked hard on Magisk. [MENTION=631273]Chainfire[/MENTION] has made some very valid points, and it sounds like the biggest issue was not being able/notified to fix issues with SuperSU to coincide with this project. The biggest overreaction of all seems to be coming from those who are not even developers and have zero investment into the project, other than reaping the benefits from both of these developers. [MENTION=631273]Chainfire[/MENTION] has made many contributions throughout the years, and to hear someone say that he is not collaborating is appalling. So I say to you [MENTION=6320543]RatchetPanda[/MENTION], that your comment is "just sad".

You guys should really let this go, and let [MENTION=631273]Chainfire[/MENTION] and [MENTION=4470081]topjohnwu[/MENTION] sort it out. There doesn't need to be any negative comments that is going to just make for more bad blood.
[Magisk] Citizen_Snips:
Did you guys not read the post literally right above yours?:rolleyes:
[Magisk] zelendel:
Ok guys enough. This is between the 2 devs. They have both said their parts and now its time to move on. No one else really has a place to say anything about it.

I want this to be the last time I hear about this.
[Magisk] Chainfire:
From a security perspective, having privileged control only once makes the device completely insecure. Your well-behaved and well-intentioned root apps are not a threat, but your malware will remain running even when you've disabled root, unless you actually take care to kill those processes, which no solution currently does (or can 100% reliably do). If they've had control once, they are possibly still in control. There is no one working in Android security who doesn't understand this. Sorry, but I honestly don't think you'll get to keep root with Android Pay one way or the other.

Then again, Google has not been very quick to roll out patches to SafetyNet so far (systemless SuperSU worked for months), so who knows how long it will last.

Either way, I hope someone in this thread understands that if there's a feature that people want that doesn't work with SuperSU but does work with some other app, then that pushes me to developing a similar feature. Even if I think the whole Android Pay while rooted and root hiding in general is a bad idea and a losing battle to begin with. I go where my users drag me (sometimes kicking and screaming), mostly.

Aside from the little jabs, I just want to point out a couple of things.

SuperSU has never really been a monopoly, at virtually all times has there been one or more competing superuser available. Sure, one may work better on one specific device than the other, but still. Right now there are half a dozen-ish superusers.

As for my Apple marketing - that is nonsense. If my apps are limited to SuperSU, then they are for technical reasons. They always need something special beyond the basic 'su' support that most superusers support (this is in fact what usually drives the development of new features for SuperSU). Often this is SELinux related - and no other superuser solution has the full SELinux flexibility that SuperSU has, at least last I checked - and then you can work around it by setting SELinux to permissive regardless of which superuser you have. The only other reason I can think of has been su.d support and the guarantees coming with that. LiveBoot for example relies on both. Of course, that doesn't mean in all instances that they cannot be made to work with a specific superuser, but I find it absurd that you think that should be a priority for me. I already have far too few hours to get the things coded I actually want to code, it obviously already works for me existing users, and I cannot be an expert on the moving targets that are all competing softwares.

EDIT: oh, and mount-master, that has also been one of those special features...
[Magisk] JERW28:
[MENTION=4470081]topjohnwu[/MENTION]

I hope you decide to continue working on Magisk. I think your goal of making a framework to modify the system partition without touching it is amazing! It is a great solution that creates the freedom to modify our devices while still working to keep our information secure and accept OTA updates! The best of both worlds! I didn't think that would ever be possible until Magisk.

I hope you, [MENTION=631273]Chainfire[/MENTION] and other developers can find a way to work together to benefit everyone, devs and users, in the community.

Don't give up. Keep going! I would love to be able to use [MENTION=631273]Chainfire[/MENTION] 's apps and solutions along with Magisk. I have great respect for both of you and each of your work for the community.

With that in mind, i want to echo what others have said.

The rest of us need to take a breath, stop panicking, withhold negative statements, put away the pitch forks, call off the firing squad and let them work it out.

I will try to be paitiant waiting for a decision.
[Magisk] stangri:
[MENTION=631273]Chainfire[/MENTION] -- welcome back from vacation, thanks for posting in this thread and in general your wonderful work and support of other devs.

[MENTION=4470081]topjohnwu[/MENTION] -- I hope you enjoy your vacation and figure out what the next step for magisk is after sorting out code/binaries stuff. Thank you for your ingenuity and developing magisk in the first place, your framework gave me an option of running two things systemlessly which I would have otherwise been unable to do.
[Magisk] AndroidGee209:
Well I've tried countless times to get magisk to work on my note 3.... everything is perfect except that my camera no longer works after flashing.. I have a logcat which I hope points out the issue, if someone could be kind enough to check it out
[Magisk] JudgeDread11:
If you open build prop in system can you find the added lines? If so then the mod works and something else is wrong.

You could try to make a copy of the whole build.prop, add your lines and the replies the whole file.
[Magisk] hua_wuxin:
Try move setprop to post-fs-data.sh or service.sh, or simply copy paste setprop in all the 3 shell script.

I've noticed some prop will restore to default value during the different boot stage.
[Magisk] Captain_Throwback:
That's not how setprop works....lines don't get added to build.prop when using it.

But yes, replacing build.prop and adding those lines may also be something to try.
[Magisk] JudgeDread11:
Learned something today :)

Thank you!
[Magisk] soder:
I'm about to try the systemless version of Xposed, and I then need to install this Magisk.

I do not use encryption on my phone, and I don't want to. What does this mean, and how do I change that during the installation of Magisk?

Installer will patch system verity and forceencrpyt. If you want them not to be patched, configure by:

Code:

# Remove previous configs

rm /cache/.magisk /data/.magisk

# Keep verity

echo "KEEPVERITY=true" >> /cache(or data)/.magisk

# Keep forceencrypt

echo "KEEPFORCEENCRYPT=true" >> /cache(or data)/.magisk

/Söder
[Magisk] eberhardweber:
I was able to pass the Magisk safetynet test on the stock 6.0 Samsung Tab S 10.5 ROM on a custom kernel on Magisk 12.0. Super cool! The stock kernel might work too :)
[Magisk] karthik km:
On Magisk V12

Magisk hide working fine

Even if saftynet failed

Pokémon go and other banking apps working fine
[Magisk] Didgeridoohan:
Busybox doesn't force permissive. But, if I remember correctly, B14CKB1RD kernel is permissive (although not forcing). Might be that your setup of Magisk doesn't work with Busybox enabled. There are a known bug where keeping it enabled might disable root.

To me it sounds like Magisk Hide doesn't work correctly on your device with Busybox enabled. When you disable it, Hide starts working and masks your permissive SELinux with the pseudo-enforce mode (you can see this in the log).

Just a theory...

If you don't have any apps that need Busybox there's no need to keep it enabled.
[Magisk] DroneDoom:
Seems I'm the only one having a problem installing magisk modules. Magisk manager is able to download and "install" the zip but when I reboot it, it was never installed. I've tried flashing it through TWRP and then flash magisk again but they turn out not to be actually"active" and I can't remove them after that.

This only happens when I install lineage OS on my Moto z play
[Magisk] wrongway213:
Sadly, several of my apps have dependence on Busybox - That is part of what I've been trying to piece together here - what I need (if anything) from Magisk's Busybox, or if Busybox is being detected elsewhere in the ROM.

As for working properly on my device - it doesn't seem to matter if the kernel itself is set to enforcing or permissive, in KA Mod, anyway. It does display, even immediately on boot, as "Enforcing" with Busybox disabled, and conversely as "Permissive" with it enabled. I'm a bit curious given the pseudo-enforce if it would be beneficial to me to get the kernel to actually boot in enforcing, or if that's not the issue. I ask because of your mention of B14CKB1RD as permissive by default - it in fact is.

I've noticed most of the Busybox discussion on a device specific/ROM specific basis seems to concen losing root, which has not been an issue for me with Busybox enabled or disbled. I haven't seen anything regarding BusyBox causing Magisk Hide to function differently.

Thanks for the response - I would love to hear any other feedback you or anyone else might have, both in terms of solutions, and knowledge to better understand Magisk Hide/Busybox. :good:
[Magisk] kopitalk:
It's SafetyNet. There's an 'e' in between 'f' and 't'. Can you see it?
[Magisk] karthik km:
OMG I'm sorry

It's a spelling mistake

But I'm not talking about SafetyNet their

I'm just talking about Magisk Hide
[Magisk] Didgeridoohan:
I've said it before, and I'll probably say it again:

Pokemon Go does not rely on the full functionality of SafetyNet. It doesn't matter if you get a CTS profile mismatch as long as basic integrity passes.

And far from every banking app utilises SafetyNet. They usually have their own detection methods.

---------- Post added at 19:06 ---------- Previous post was at 18:59 ----------

It's interesting... Like you say, most of the cases with issues with Magisk Busybox is about losing root. Have you checked though, if Hide works properly when you have Busybox enabled? Hide a root checker, both with Busybox enabled and disabled to see if there's any difference.

Also, do you see the pseudo-enforcing mode kicking in at any point (in the logs)?

I've followed Magisk closely for some time and haven't seen anyone else with your issue (in the Magisk forums). I'm sure it's something specific for your setup... It's just a matter of figuring out what.

Could you try with a different kernel? Franco, EX or even stock maybe.
[Magisk] lalitjoshi06:
Spush tan latest version not working. But Safety net passing.

I think bank apps recognized something other than root.

Lets hope for best in near future.
[Magisk] culiacanazo:
Reboot not needed

Surprising that so many ppl want this and fret over it just to play games. ..

Like MAGIC, right?

Neither did I...

I couldn't LOL over this more!

Huh?! :confused:

Me three!

Cool, will you share it?

App booting?!

It's "there" lol
[Magisk] djdarkknight96:
Just wanted to stop by and say thank you for all the fixes and updates. I'm now VERY happy with how it's working for me on DU Nougat 7.1.2. Keep up the awesome work.

DJ

TeamBlackOut
[Magisk] Didgeridoohan:
That app has had a bit of a story in this thread. At one point I was able to hide root from it on my Nexus 6. No luck on my OnePlus 3T... Some users have had luck with earlier versions of the app.

Some apps look for other things than just root, yes, and this app is one of them. Different prop values are usual suspects...

In the end, the root hiding game is a losing one for root users, but it's fun while it lasts.
[Magisk] manalicream:
I fixed the issue with Titanium Backup. I had to delete the backup folder that was already there from before I'd used Magisk.
[Magisk] brahma666:
Can magisk be installed on every kernel?
[Magisk] gravufo:
Hey, did you manage to get it working on version 8.0? It also used to work perfectly, but since the latest updates, it's broken. I'm not sure whether it's due to Magisk v12.0 or if it's just that the TD app added new sorts of checks...

I tried to decompile the apk and saw a few things where it checked for su access, but nothing out of the ordinary.

Thanks
[Magisk] zee24:
I mean yeah.... It does work on the older one that's kind of why I suggested you do the same
[Magisk] Truant_Luce:
Hi. Been trying to search and try changing my boot animation, and it worked when I was on 11.6, and then went to 12.0

But since then, I chose to start from scratch and wiped everything. Now when I place the boot animation under /cache/magisk_mount/ and then up to the target directory, it no longer works. Did I do something wrong?
[Magisk] Abort Retry Fail?:
I've got the LG G5 H850 with an unlocked bootloader. I've flashed Fulmics V2.0 which offers an Aroma option to install magisk, and it's working perfectly. SafetyNet check passes without any problem. Just make sure you're running a stock ROM with a Nougat bootloader when you flash Fulmics 2.0 and that you've flashed the latest TWRP: twrp-3.1.0-0-h850.img.
[Magisk] sunny1119:
I just rooted my note 5 with latest magisk su and as the latest v12 suggest samsung pay is fixed in this version, but I am not able to make it work. Anyone got it working? I already enabled magisk hide.

P.S: I am able to pass safetynet but not Samsung Pay.
[Magisk] Didgeridoohan:
Not quite right... Magisk v12 masks a triggered KNOX counter, yes. But the changelog also states that Samsung Pay hasn't been tested. It might be (and it's been reported earlier in this thread) that the Samsung Pay does a deeper check and can't be fooled that easily...
[Magisk] sunny1119:
Yup I just noticed that, damn i was hoping samsung pay would work. Lets hope it gets fixed in upcoming versions :)
[Magisk] gil80:
My 2 cents on why pay app is not working for some. I know that my bank application is also looking for build.prop. if my phone is not using the official build which is tested by them, then it won't work.

I'm using OnePlus one, but running CM13, where I think it expects OxygenOS official build.
[Magisk] xd4d3v:
you just need to enter resetprop and the prop you want to reset (they same you have added in system.prop)
[Magisk] smohanv:
Thanks for your response. I had mine last week and already unlocked bootloader and played around. Fulmics works fine. I am overall satisfied with this device.
[Magisk] Kapiljhajhria:
i am using redmi note 4 SD version (mido) . safety net passes completely on MIUI8 based on android 6.

But on miui8 based on android N safety net is not passing. even the basic integrity check fails.

what i have noticed from android 6 is that

1. zygote process doesn't come up in magisk logs

2. PID of com.android.google.gms.unstable also doesn't get shown in logs.

Only when above 2 things showed up in magisk logs my device (on miui8 android6) use to pass safety net completely

so i think these 2 things are missing on MIUI8 android N.

i tried various commands to find PID of com.google.android.gms.unstable but couldn't find it.

any suggestions???
[Magisk] Didgeridoohan:
Yes, I've noticed this as well. Certain ro.build values doesn't get set properly by using system.prop in the module. Using resetprop in post-fs-data.sh is necessary instead.

Hmm... Did I open a GitHub issue for that? Gotta check...

Edit: This issue is not universal. Previously I have been able to reproduce it on my Nexus 6, but there are no issues setting ro.build values through system.prop on my OnePlus 3T. More testing needed...
[Magisk] Futurehope:
How do I fully uninstall magisk? I've tried using the uninstaller but although magisk manager says root is no longer detected, the safety net did not pass(cts profile mismatch) and certain apps still can detect root(fate go). What should i do?