yashsingh1/xdaforums huggingface dataset:
[Magisk] ireun:
Hello. I'm facing a problem. I've installed Magisk v3 and the this phh's root. I ahve got a Magisk app in my drawer, but.:

1. I don't have root (Titanium backup is not working)

2. I can't change the status of root inside the app, always shows up as "mounted", also SElinux switch is not working.

I'm using stock S5 rom.. The only mods are TWRP Magisk and phh's superuser. Do I need any other apps for enabling the root? Like superSU or so?

EDIT: All right, phh's form google Play was what i needed. Why isn't that mentioned in the first post?
[Magisk] allen099:
As requested to keep Android Pay questions here, I'm copying my message to this thread.

http://xdaforums.com/showpost.php?p=68147128&postcount=518

Thanks for updating, [MENTION=4470081]topjohnwu[/MENTION]. After updating to v3 and reflashing phh superuser v2, I'm at the same place on my N6P with not being able to pay. I removed the magisk.img as you suggested, but got a message that my device is not rooted. I tried to reflash just the superuser from TWRP and it didn't let me, so I reinstalled magisk v3. Let me know if I can help with testing. Thanks for the hard work!
[Magisk] anagramgenius:
That's the least thing you must know after rooting.
[Magisk] topjohnwu:
Sorry, I'm maintaining too many stuff at a time lol

(Systemless Xposed, this thread, Magisk thread, I'm also developer of 2 roms.........)
[Magisk] CSX321:
Same here with the N5. Looking at things, I think what's tripping up Pay on my phone is that either Magisk or phh Superuser is sticking busybox in /system/xbin. I thought it wasn't supposed to be writing to /system. I mean it's actually there, not a link or overlay.
[Magisk] ireun:
Someon that has never used phh's su won't know that.

No problem, but please add this note somewhere. ;)
[Magisk] topjohnwu:
No busybox is sticking into your system bro!

They are installed into /data/busybox
[Magisk] adrman:
I think it must be Magisk. On my N6P, I flashed stock images and then used phh's eng image to gain root, getting a fresh start until Magisk gets things sorted. I happened to notice that I have system/data/busybox/ and it contains just symlinks. A full search of my device revealed no other busybox directories, so I'm assuming it's leftover from the previous Magisk v2 installation.
[Magisk] CSX321:
Ah, it was the ElementalX kernel install that was putting it there. And it being there doesn't prevent Pay from working, so long as I'm not rooted.
[Magisk] adrman:
Thank you for clarifying. I'll try to give v3 a test tomorrow.
[Magisk] sansnil:
I also don't think it's the boot image because it works on my N6 with Elite kernel. It's Xposed still somehow. If I disable Xposed and reboot it's money every time. Some Xposed process must be detectable.
[Magisk] Jayman007:
I get exactly the same thing on my nexus 5x running august update and only phh's SU. I as well am using an older card that was added long ago.

I'm gonna try with magisk v3 and see if I can get a transaction to go through.
[Magisk] CSX321:
I'm not even using Xposed. Just installing Magisk alone causes Pay to fail on the N5.
[Magisk] dannycellestio:
this su destroyed my root completely. I tried so many things, it's so buggy, auto-denies root permisions, even though I set it to prompt/allow.. I don't know what to do anymore, so I came here.. I tried anything possible, dirty flash, clean flash, everything. I even dirty flashed with normal su and it was working..
[Magisk] carlosggb:
Hi Jay,

Remove the card from AP and add it after all the modifications . For the bank its like a new device because the id gets changed by the modifications like root and magisk.
[Magisk] N00dle:
Ok so I've tried pulling the Magisk APK and it won't install. The weird thing is it won't even show in my downloads folder on my Nexus 5x so I have to go in through ES File Explorer and then I can see the apk however it fails to install.

I can't get the Magisk Manager to show.
[Magisk] tem02:
Mind me for my ignorance, I'm a noob here and I've got few questions I can't figure out.

1. Are the compatibility issues with some apps caused by phh's SuperUser, or by the root apps themselves? I'm not comfortable with the idea of turning permissive SELinux on to make an app work

2. Can the compatibility issue be fixed? If so, when?

3. phh's SuperUser hasn't been updated since January 2016. Is the dev still active? Because of this I am reluctant to flash this, as it may have some security or compatibility issues.

4. Do you recommend everyday root users to wait until this root is fully mature, or is it good to use already?

For reference, I am considering switching stock 6P+ system SuperSU+ system xposed -> stock+Magisk+phh's SU+ systemless Xposed (which would allow me to use Android Pay without rebooting)
[Magisk] Cares:
You need to install it as a system app. Just move the apk into /system/app and change permissions to -rw-r--r--
[Magisk] N00dle:
Ok stupid question. what are the default permissions for the /system/app folder itself. I wasn't paying attention and changed the permissions for the folder first. I just want to make sure I don't have bad permissions set for the folder
[Magisk] agentdr8:
If you're trying to keep your /system partition clean and untouched for OTAs (and possibly Android Pay) you should install Magisk Manager as a user app. The reason it fails when you had v1 previously installed is because of a package signature mismatch, and if you didn't manually uninstall it prior to trying to install v2, the signature is cached and won't let you install the new version.

The easiest way to solve this without affecting /system is to re-install the Magisk.apk from v1, then manually uninstall it, then install v2 from phh superuser.
[Magisk] N00dle:
and can I just uninstall the v1 from say Rom Toolbox or Titanium or even the App Manager and then install v2?

I'm a little confused by the uninstall instructions in the OP of the Magisk thread.
[Magisk] topjohnwu:
OK guys, big news here.

A tester just confirmed that even with the simplest method of v1, Android Pay is working with successful transition.

So it's the best scenario now: Possible for Root Toggles and Xposed works with enabled

This is nice because we can now toggle root at ease instead of relying on a timeout.

So all the problems now specifically points to Nexus devices :)

Never though Nexus will one day become the issue for Android development lol, super sarcastic

People can still report Android Pay failures in this thread

I'll recruit many testers soon, please stay tuned to my threads (systemless Xposed, Magisk main thread, Magisk phh root).

I'll post the info to all threads so you won't miss it.
[Magisk] agentdr8:
Not likely. When you flashed v2, it attempted to install the newer Magisk.apk (likely using the pm utility) but because of the conflicting signatures, it failed, and left v1 in a sort of half-uninstalled state. Most app managers won't pick it up as being installed any more.

If you don't have access to the original Magisk-v1.zip for flashing, you can also (re)install Magisk Manager v1 from apk (see attached), and then go to your Settings->Apps and uninstall it, and then either flash phh superuser v2 (includes newest Magisk Manager) or install Magisk Manager V2 that I've also attached.
[Magisk] agentdr8:
Not sure which streaming app you're working with, but I can happily report that Magisk v3 with phh superuser v2 works great for bypassing root checks on the Tivo app. And it works just fine with systemless Xposed installed as well.
[Magisk] elreydenj:
Thank you. Since you reference Nexus devices being one of the problems possibly (myself including using a 6P) do you think it could have anything to do with AP being installed as a system app? That is the one big difference between maybe a Samsung or an LG phone and the nexus i would think.
[Magisk] waylo:
Well this is great. It did seem like all the failure reports were from Nexus users.

If V1 does works then for us non-Nexus users, where can I get the phh-magisk superuser original version to recreate a v1 install? Does anyone have it somewhere handy?

Or should I wait for v4?
[Magisk] datafoo:
Android Pay updated today from Google Play Store.

Do we know if there are any issues with the new version?
[Magisk] sansnil:
Why don't you try it and let us know. No update available yet here.
[Magisk] shuckeru:
Welp. Android pay app just updated on playstore
[Magisk] datafoo:
LOL thanks for your "oh so helpful" response. You succeeded in upping your post count.

I would but it's pointless as my HTC 10 fails at the transaction level regardless of Magisk/Superuser version used.

I was bringing it up for those who are having success as more a forewarning that AP is being updated and it may or may not impact the process for them.
[Magisk] sansnil:
I was serious. You could test with the new AP version and perhaps it works (most likely not) and share the results.

Btw, I have no interest in "upping my post count." I just find it very "oh so helpful" when people post things like that instead of testing and providing results.
[Magisk] N00dle:
Thanks got it all working again. I just went back to square one and flashed the system and boot image again from the android full image. Then just installed v3 and phh v2
[Magisk] joeyddr:
Just tried a transaction after the new ap update and it fails

---------- Post added at 10:24 PM ---------- Previous post was at 10:22 PM ----------

Safety net passes but actual transaction fails.
[Magisk] waylo:
Did it work previously? What phone and Magisk version?

EDIT: From your post history I see you're on PureNexus. But doesn't look like you reported a working transaction previously?
[Magisk] joeyddr:
V3 N6p purenexus rom had not tried it before the update because I just got it working last night

---------- Post added at 10:37 PM ---------- Previous post was at 10:36 PM ----------

I will say o had another kernel that forced permissive so not sure if that has anything to do with it but safety net still passes
[Magisk] LuanTeles:
I cant get it to work

Flashed magiski , xposed systemless

Downloaded the app, flashed the ph supersu

And says that su binary needs to be updated

Galaxy s6 edge. N7 port rom
[Magisk] topjohnwu:
Some people is using Magisk and phh root fine on the same device you're using. Either restore to stock, or try to report logs so I can debug the issue
[Magisk] sorewinner:
PHH's superuser app or your Magisk-compatible version of his root is FC root request notifications due to a write permissions bug on CYM13.0. I've posted the results of ADB logs in his thread @ http://xdaforums.com/showpost.php?p=68147825&postcount=515 . PHH had requested them to debug, but hasn't yet responded. [MENTION=4470081]topjohnwu[/MENTION]: Could you please take a look at those logs, as well as the few posts between me & him, just in case it's a problem with Magisk, and not PHH's root/app?
[Magisk] cbarai:
[MENTION=4470081]topjohnwu[/MENTION] can you confirm if AP is working with the magisk method on OP3's latest update 3.2.4? Reports are that AP and Safteynet helper fail on unrooted devices. Have you had any reports of AP working on this env?

I've just flashed the latest update + magisk + phh and helper fails. Will the dirty flash of the new full rom clean up the boot.img or should I manually flash that again?

EDIT: just reflashed the boot.img, then magisk then phh and xposed. Still safteynet fails.

Thanks,
[Magisk] st0nec01d:
I'm having the same issue on OP3, safetynet fails while stock and completely unrooted with minute no xposed either. My banking app insists phone is rooted in that state also. Hopefully OP push out an update to fix this, can't see magisk sorting it till then.
[Magisk] joeyddr:
No one else besides me tried the new ap update?
[Magisk] ThomasC1970:
Oneplus 3 rom 3.2.1 work with Magisk v1 with Xposed enable. Have already tested purchase.

But if you upgrade to the latest OTA 3.2.4, root or non-root, Android Pay won't work. The ball now is for Oneplus to fix.
[Magisk] datafoo:
I'm glad you found it helpful, that was my intention.

But, you have to be honest with yourself, before you lie to me.

If you had no interest, then why did you even respond? Perhaps just to "get the last word in"...because you're witty like that eh?

Or you could put your money where your mouth is and test the new AP and let us know rather than telling someone else to do it ;)

That's 2 posts now with nothing of value, you're on a roll!
[Magisk] joeyddr:
I tested it btw and it failed for me but safety net passes, even lets me add a card. Did a clean install of pure Nexus without any root and I am going to go try it in a few.
[Magisk] joeyddr:
OK stock purenexus transaction just went fine but when I load up magisk v3 and unroot safety net still passes but transaction fails. Latest Android pay app
[Magisk] reekotubbs:
Having issue with AP and SafteyNet failing

Attached is the logs.

Samsung Galaxy Note 4 SM-N910 Android 6.0.1
[Magisk] Jayman007:
Tried exactly that with v3 and still no luck. I'm in a nexus device though and it sounds like they are all having an issue with AP.

If be happy to do testing and troubleshooting as needed. I have a nexus 5x.
[Magisk] cbarai:
Just downgraded my op3 to 3.2.2 with magisk. Can confirm now ap works.
[Magisk] vampire_8_7:
Hello everyone

I have been keeping an eye on this thread and been doing some testing myself and so far I can confirm.

1- Android Pay will allow you to add cards if Xposed is enabled and you're using Magisk v1 or v2 with temporarily disabling the root.

2- SafetyNet will pass the test (CTS profile match: true).

3- AP transactions will fail and you'll get the message in the picture below.

- I disabled Xposed rebooted the device, disabled the root using Magisk v2 and I was able to process the transaction without any issues.

- I haven't tried Magisk v3 yet and am not sure if we still have to disable Xposed or not.

I use Nexus 6 running Paranoid Android 6.0.2

[MENTION=4470081]topjohnwu[/MENTION] if you looking for some serious testing on the transactions side am more than happy to help I use tap and pay feature on daily basis :good:.
[Magisk] l1ttl3z:
I just tried v3 and i still get the same results
[Magisk] joeyddr:
Yeah I get that issue without having g Xposed at all.
[Magisk] poulopoulosa:
My experience; system-less Xposed does not affect Android Pay or SafetyNet checks. I have been testing around Android Pay with my Local Tesco on various case scenarios, with or without Xposed.

a) My phone was without reboot for two days, Root was all that period Mounted.

Unmounted Root 5 minutes before purchase, tried to use Android Pay, Fail.

Rebooted my phone on the spot while waiting at the self check out. Quickly Unmounted Root, did a safetyNet check, success.

Tried to tap my phone, Viola worked.

b) My Phone was without reboot for three (and a half?) days with Root Unmounted. Tried to use Android Pay, Worked.

I think: Since safetyNet Checks require internet, Android Pay itself caches(?) these checks until reboot. Android Pay App has to be independent and work even without internet or low signal. I remember I could make transactions with AP even when I had no internet, either because there was no signal in London Underground or because I was out of MBs or Credit.

Both cases mentioned above were while having system-less Xposed and some Xposed modules on, I had exactly the same behaviour without Xposed modules/framework
[Magisk] waylo:
Interesting idea about the caching. Will try to confirm that today. EDIT: Doesn't work still =(

As an update to my G5, I installed V3 successfully and today was the first day I could test out AP. It didn't work. But I will try to reboot, not run AP until I have root unmounted, and give it another go.

I do not have Adaway installed in any form, but I do have:

Foldersync

TB

Nova Launcher

Greenify

MyBackup Pro

Root Explorer

SD Maid

Droidwall

QuickBoot

Better Battery Stats

System Tuner

Terminal Emulator

ES File explorer

Flashify

I do not think (but cannot be completely sure) those would affect AP in any capacity. Droidwall does change iptables, but that does not trip SafetyNet.
[Magisk] wirelesskebab:
Hi there,

I'm having some difficulties with an application I mistakenly denied root to with the phh app... it isn't giving me an option to change it or re-prompt. I tried searching this thread but it seems it was too complex for search. :confused:

Sorry if this has been asked but I haven't had my coffee yet, thanks. :silly::eek::fingers-crossed::good:
[Magisk] sansnil:
From the Superuser app, tap n hold on the denied app entry and you'll be given options.
[Magisk] waylo:
As an update, I tried rebooting my G5 and un-rooted with the Magisk manager. It passed SafetyNet as I would expect. But a transaction DO NOT pass. I did not expose Android Pay to any rooted status after the reboot.

So if Android Pay caching is in effect, a reboot is not enough in itself to reset.

I do not have xposed installed btw.
[Magisk] vampire_8_7:
It's always best to do a full wipe if you don't want to mess around, ALWAYS TAKE BACKUPS :)

- From recovery flash Unsu.zip.

- Follow [MENTION=4470081]topjohnwu[/MENTION] instructions to remove Magisk (To remove Magisk, restore your boot image (Magisk will backup your boot image automatically in /data/stock_boot[md5].img.gz), then delete /data/magisk.img. Super simple and clean, no traces will leftover.).

- From recovery again flash Magisk v3 then phh's superuser.zip and download phh's superuser from PlayStore.

- Make sure you can unmount root and add cards to AP, try to proceed with a payment and see how it will go.

- Later try to flash systemless xposed and proceed with a purchase it will fail, if you disable Xposed and rebooted the device the transaction will go through.

This steps will get it working for you.
[Magisk] joeyddr:
Yeah I get this from a clean install of pure Nexus no root ever installed.
[Magisk] vampire_8_7:
Try to flash stock and do the previous steps and once you confirm it's working, flash the pure nexus rom and go straight to flash

1- Magisk v3.

2- Phh's superuser.zip.

3- Phh's superuser from PlayStore.

and see how it will go, remember custom rom aren't supported and the dev said some may work and some might not. I will try to flash the pure Nexus Rom on my N9 and test it myself to see what is going on :good:.
[Magisk] joeyddr:
I already did that and stock pn it works fine and when I flash v3 and phh it passes safety net but fails transaction
[Magisk] vampire_8_7:
I have a feeling the problem is the rom, am gonna flash it and will see how it will go. I just realized to replicate the scenario I have to process a transaction which is gonna be difficult to do with the massive N9 :D, backing up my N6 now and will flash PN and will let ya know later today or maybe tomorrow :good:.
[Magisk] joeyddr:
I also have a n9 and would need to tether to test it on that
[Magisk] vampire_8_7:
I don't think it would matter if it didn't work on the N9 it shouldn't work on the N6 and vise versa.
[Magisk] chazall1:
Using Magisk v3 on my N5 with PN Rom and AP is working great.
[Magisk] vampire_8_7:
Without Xposed installed Id say, correct?
[Magisk] vampire_8_7:
Magisk on Pure Nexus

Hi mate, was just reading the replies again and noticed what you wrote. I am pretty sure it won't work without Magisk installed on the custom rom as well as the phh's superuser. Pure Nexus isn't a stock Android so the root isn't the issue. AP looks for some specific stuff in the rom (which I don't know exactly what) and expecting specific results so when it sees a custom rom it gives a different results from the stock so it fails, but when you install Magisk and phh's superuser The Magisk Manager allow you to disable the root and bypassing AP checks.

Again am not sure what you mean by

stock pure nexus

cause it's a custom rom and you can't call it stock, unless am missing something here, please guys correct me if am wrong.

I can confirm now I flashed Pure Nexus on my Nexus 6 device, and I had previously Paranoid Android installed.

1- Did a clean wipe to [Dalvik Cache - System - Data - Cache].

2- Flashed the stock boot.image.

3- Flashed PN and Banks GAPPS.

4- Phone rebooted got it set up, rom isn't rooted.

5- Flashed Magisk v3.zip, phh's superuser.zip and downlaoded phh's superuser from PlayStore as well as safetyNet.

6- Checked the root status and the device was rooted.

7- Opened Magisk manager disabled the root for 5 mins [

noticed it stayed way longer than the 5 mins, I think there is timing issues which isn't a big deal

].

8- Added my card on AP got verified and all good, checked Magisk manager, root was still unmounted and

it was past the 5 mins

.

- I checked the root status via root checker said phone is not rooted, checked safetynet it passed fine.

- Tried to add another card on AP worked beautifully.

- I went to process a payment, it failed and I got the message I posted in my first comment. I had a feeling that the problem was because it was past the 5 mins and the apps were still running in the background tried to force close them and

BAM phone was back rooted

, AP gave me the message can't verify my Android and surely Magisk was showing root was mounted.

9- I have disabled root from Magisk one more time and gave it about 20 seconds then went ahead to process another payment, it WORKED PERFECTLY FINE.

Note all these steps

without Xposed insalled

, I was just doing some testing for Pure Nexus rom. I will try to install Xposed and make some payments, am sure it won't work but no harm from trying. I will update the post later:good:
[Magisk] poulopoulosa:
I forgot to mention that I am using magisk v3 but magisk manager from Version 1 in order to permanently unmount/mount root.

I appreciate the amazing work done to this project but I didn't like disabling root for a certain amount of time, because of the AP behaviour. Maybe root gets mounted again in your case? If you need the version 1 manager I use, you will find the APK into magisk V1 flashable zip. I hope it will work from you
[Magisk] waylo:
Okay, so in your situation:

1. You turned off root.

2. You rebooted and root stayed off.

3. AP worked.

Does that sound right? That might make sense that AP searches for root at the beginning of each boot.
[Magisk] poulopoulosa:
At each boot, root is automatically mounted, I just turn it off immediately after every boot since I need root only once a day. Today for example I tried to use AP but failed as I rebooted and I forgot to turn it off, rebooted and then unmounted straight after boot, tried again, worked. We cannot be sure as this is what works for my case with my phone (OnePlus One). I will logcat everything throughout the day and try a few times and see if there is anything interesting but I might do that over the weekend.
[Magisk] joeyddr:
Maybe it would be better to boot with it unmounted and turned on when needed.
[Magisk] Jayman007:
So has anyone got AP transactions working on a rooted nexus? I have a 5x running latest patched rom with magisk v3 and phh's SU. When I use the app to disable SU my safetynet passes but transactions fail.

I tried re adding the card with the new setup and still fails.

Anyone got this setup working? I see many nexus users having issues so it seems to be a nexus related issue (strange enough)
[Magisk] sansnil:
A couple questions, are you running Xposed? Anything else which has modified the system partition?