yashsingh1/xdaforums huggingface dataset:
[Magisk] pndwal:
Thanks for this @canyie.

However I'm not sure why you said/think denylist isn't working on my device*... It seems to work properly to me...

I've just tested it this way:

Putting gms attestation/droidguard process (com.google.android.gms.unstable) in denylist (with it enforced) is expected to break Universal SafetyNet Fix as this will revert injection of code for fake keystore registration relied on for triggering fallback to basic attestation. It will also revert USNFs targeted model and other prop changes (though these are not needed for RN8T with A10 running) while still providing basic root hiding...

When attestation/droidguard process is not in denylist, with denylist disabled + Shamiko working or with denylist enforced I have Play Integrity deviceIntegrity...

With attestation/droidguard process added to the list and with denylist disabled + Shamiko working I still have deviceIntegrity, but as soon as denylist is enforced I have basicIntegrity but no longer have deviceIntegrity...

This indicates that DenyList is preventing code injection as expected while the fact that basicIntegrity still passes indicates that denylist is still providing basic root hiding for the attestation/droidguard process, also expected...

Clearly Shamiko is somewhat broken on my device with recent Magisk builds, but AFAICS there is no indication that DenyList isn't behaving at expected...

* I guess your conclusion was based on Momo detections I posted, and that these (Magisk or SU or both?) might indicate that denylist is not reverting Magisk changes in isolated services... Please let me know...

In any case, as long as proper hiding using Shamiko can be restored, it seems most modders really have no use for fully working denylist... Also guessing that developers/researchers may be the only ones who miss the ability to restrict/revert Magisk modifications in affected isolated services. 😜

Please say what I'm missing... 🙃 PW
[Magisk] J.Michael:
I always find thread search results to be in reverse chronological order. I only use browser. Are you using app?

Probably easier to just read last five pages -- not all relevant posts will use keyword you chose.
[Magisk] zgfg:
Searching tips (again)

XDA app or browser:

1) "Search this thread"

On top,

do not enter any keyword, it will be ignored at the moment, "Search"

2) When it shows results for:

"Search results for: *"

Click on that star/asterisk/wildcard sign

and replace the wildcard with your search keyword, like "systemless"

3) Scroll little bit down and checkmark "Recent"

(who cares about the posts from 2017).

"Search"

Then, you will have results from this thread, most recent on top, for the keyword you asked
[Magisk] martyfender:
This should be in the op.
[Magisk] martyfender:
I have posted before here and linked in my signature, that I have 2 Onn 8, 1st gen tablets with Android 9. The only 2 differences that I see is that the model numbers are different and the Android security patch dates are many months apart.

The older one is model Onn ONA19TB002. The newer one is Model 100005207.

On the Onn ONA19TB002 I have Huskydg Delta debug builds. On the 100005207 I test John's official debug builds and action builds. Soon after the first one came out, @diplomatic ported TWRP 3.3.1-1 to the device. It also works on the newer tablet. Because Walmart never released stock rom for these tablets, I have depend on a new, initial backup for each device, in addition to a few newer backups. For these 3 or 4 years I have used them they have been mostly reliable, with the occasional need to factory reset or delete data to rebuild a new data partition at boot.

In the past week I had issues testing new builds so I booted to TWRP only to discover that the data partition can't be decrypted and I must each time do the new setup for time zone, etc, then switch to external storage where I also had TWRP backups stored. I restored and tried factory reset and later format data and internal storage which would usually solve the need for a password to enter to decrypt. this did not work to decrypt the data. Non of the searches on the internet solved the issue.

Reading back several pages I noticed the many posts concerning recent issues with TWRP and new builds. Twrp works just fine on other tablet with the Delta debug builds, In fact, I am considering abandoning testing of Johns build to move the other tablet to Delta. On the Onn 8 forums a user posted an MTK sp flash tool flashable backup for the first version of the tablet and I have used it the take the first tablet back to stock. I however, have not tried to see if this older rom backup will work on the Model 100005207,or not. I see none posted for this newer one, so I hate to risk flashing the older rom on the newer, hardware appearing to be the same, Android version the same and the kernel version the same. (I believe).

I do have the newer on restored, but still can't decrypt the data in TWRP. I have been testing some of the new action builds and none of them seem to solve the problem, although it has been a few days since I deleted data or factory reset to see the last couple of action builds will decrypt.

Finally, I am fully aware of why custom recoveries can be problematic with Magisk. Most of the time I use direct install to update Magisk, or in the case of action build I uninstall the Magisk app before I install the new build, then after install I update Magisk in the Manager then reboot.

By the way, hide the Magisk app seems to be fixed in the last few Action builds. I can never remember what you all call these action builds because I don't see it called that anywhere on the action github tj page.

If anyone has any insight it would be greatly appreciated.

Thanks
[Magisk] Donut_Man:
I hope the Devs issue an emergency patch to alleviate the issues breaking the loading of modules brought with 25210
[Magisk] Nergal di Cuthah:
Afaik they're looking at it now, but remember developers are volunteers and deserve not being prodded so fiercely <3

Edit: it's canary and quite simple to go back to 25209 i did it yesterday
[Magisk] Tirofog:
Yep, I'm on the (viewer?) app which installs via the chrome menu. My experience with the full version and the browser is the same, the results aren't in chronological order.

Reading above, it seems a bit convoluted rather than maybe a simple sort button. I just try to avoid using it tbh 😊

Just to get back on topic, all is sorted after flashing back to 25209 👍🏻
[Magisk] zgfg:
Go back to Magisk Canary 25209 and problems will be solved
[Magisk] martyfender:
It is solved also in the recent action builds.
[Magisk] J.Michael:
still hung up on search result order:

@zgfg's pictures show a place to select how results are ordered; I don't understand difference between "date" and "recent", unless "date" is oldest first. In a browser, I find order options under "Advanced", but I am only offered two: "date" and "relevance".

Can you find these options and confirm your choices?
[Magisk] deusfaux:
how/where do you get prior canary builds if you're on the latest?
[Magisk] ipdev:
Magisk canary builds are available on GitHub.

You just have to look at the history. 🙃

Canary builds are hosted in the magisk-files repo.

magisk-files (Canary commit history) - [GitHub] - Link

Spoiler content hidden.

Cheers. :cowboy:
[Magisk] ipdev:
Magisk PR (Fix mkdir #6690) - Link

Cheers. :cowboy:
[Magisk] deusfaux:
Ah, I dug around GitHub b4 but didn't know where to find it. release.apk, right?

And can I downgrade over .210 or should i be removing and reinstalling (re-rooting)
[Magisk] pndwal:
Glad you got issues sorted...

These are generally referred to as CI (continuous integration) builds as that's what they are in Dev speak... You'll get proper definitions if you Google it... 😜 PW
[Magisk] pndwal:
Yup ..

You'll either need to fully uninstall Magisk (as background daemon will otherwise forcibly prevent downgrading App... - To keep module and settings just flash unpatched boot image and uninstall App) or flash current Debug build (this disables version and signature checks and thus allows downgrading, and can also be done w/o PC) before installing and flashing older Canary build... See note here on Magisk signature checks. (Behaviour for version checks to prevent downgrading is similar):

https://github.com/topjohnwu/Magisk#signing-and-distribution

Nb. Recent Canary is now built as release but debug builds are produced simultaneously...

👀 PW
[Magisk] zgfg:
Since Canary versions are signed with the same key, it is not needed to fully uninstall Magisk

Reboot to Fastboot/TWRP and flash boot.img that was previously patched by 2520x

The catch - user must have stored that boot.img that was previously patched by the older 2520x

Uninstall the 25210 app (it will not affect modules, DenyList, etc) and install the older Canary 2520x app

I've done similarly many times

---

Actually, I do it without the need for uninstalling Magisk 25210 app

Instead, I use CustoMIUIzer (LSposed module for MIUI up to 13, with various tweaks - eg, making Smart Lock to work - otherwise broken on MIUI), where I have "Allow downgrade" tweak enabled, allowing me to downgrade ANY user app (assuming the signing keys are the same).

Of course, must be cautious when downgrading apps, the older version of that app may have had a different format of settings/data, etc

The other steps as above
[Magisk] Clandaries:
Hiho,

after a boot the Magisk app starts automatically. How can it be fixed?

Thank you
[Magisk] zgfg:
You see the Magisk app popping out automatically or how?

Does it ask something (if it does, follow what it asks, like to Finish setup)

For me Magisk app never autostarts but that depends on the system settings for the apps - on my MIUI, I go to Settings, search for Autostart and there I can configure which apps I want to automatically Autostart after reboots, and which not

Hence, it's controllable by the System. Magisk app by itself should not be forcing Autostart (unless maybe it asks for something)

(But Magisk app is not the Magisk itself. Magisk does automatically initiate while booting, loading the modules, etc)
[Magisk] martyfender:
I can get Android reset each time but I have to go through the whole setup again after a factory reset or deleting data, since I have not still been able to get the data partitions to decrypt in TWRP to restore it. I do know that these mtk devices have about 23 partitions on them and I wonder if some of them were messed up by the recent Magisk builds. So the bottom line is that I still want to fix the TWRP issue. I was hoping someone would have some Ideas as to how to fix it.

when booted into TWRP going to restore it shows: Boot, Recovery, DTBO, Crypto Footer, Cache, System Image, Vendor Image and VbMeta. It does not show the many other partitions.
[Magisk] pndwal:
Nothing to do with key; I said version checks work much like signature checks... These are not the same checks...

You shouldn't be able to do that in 25.1+... Doesn't work for me with any newer release Magisk version loaded (core/mask incl. daemon) since:

Force app version not lower than daemon...

App installs but is properly removed for me...

Do you mean Downgrading (or upgrading??)...

Doubt this works for downgrading, but whatever... Members can try... PW
[Magisk] zgfg:
DOWNGRADING exactly as described, from 25210 Canary to 25209

Not once but I did it twice since I wanted once again to test which mods don't work with 25210 and had to once again downgrade Magisk and the app back to working to 25209

Android by itself prevents downgrading the apps (!) - but that CustoMIUIzer overwrites the protection
[Magisk] pndwal:
That's not the same as the Magisk commit discussed above...

Are you sure you're using Canary (ie release build), not Debug generated in Canary channel?... PW
[Magisk] zgfg:
Watch the video showing Downgrading Canary app 25210 to 25209

Pay attention to the full version names/numbers

File on MEGA

mega.nz
[Magisk] pndwal:
... Ok, I've just done that...

Of course that works ... It's not a true downgrade as it makes App match mask/core... Magisk / daemon installed is already 25209...

If Magisk itself was not updated, you can update app to 25210 and come back to 25209 as 25209 daemon won't consider that a downgrade, rather 25209 App is simply at parity now with Magisk mask/core...

Now with 25209 mask/core installed, installing 25206 would be a downgrade and in release versions the daemon will prevent this as I said...

Try that, or update Magisk itself to 25210 Canary (release) and try to lower App to 25209 w/o changing mask/core... All the best, PW
[Magisk] zgfg:
Yeah, details matter. I will correct my original post

Downgrade from Magisk & Magisk app 25210 to 25209 must go in this order:

1) Flash the boot.img that was previously patched by 25209

Most users probably don't keep them since they usually do Direct install/upgrade -

but since I remember similar cases (rarely but sometimes), I always patch, store for future and then flash

2) Reboot, then downgrade Magisk app to 25209 - either by uninstalling 25210 app and then installing 25209 or by downgrading in-vivo, with the anesthesia provided by the tweak "Allow downgrade" of user apps

That works and then you have again Magisk and the app 25209, by keeping the modules, DenyList, etc

---

It can be done also in this order:

- Start by step 2, by installing Magisk app 25209 but DO NOT OPEN the app when the installation finishes

- Reboot to Fastboot/TWRP and flash the old boot.img, previously patched by Magisk 25209

- Reboot to System, open Magisk app and if it asks to Finish the installation, let it go

---

Or:

- Downgrade Magisk app to 25209 but do not open the app

- Flash NOT-PATCHED boot img, reboot, open Magisk app 25209 and patch the boot.img

- Flash the newly patched boot.img from 25209 and reboot

---

But the following way the downgrade won't work:

- Downgrade Magisk app to 25209

- Then, IF YOU OPEN the app, it will ask that that it needs to Finish. IF YOU CLICK OK, it will do and reboot, but then when you open Magisk app you will see that you again have Magisk and the app 25210 (hence, downgrade would not work, due to the demon and the Magisk code you mentioned)
[Magisk] canyie:
Ah yeah, you are right, my bad. Denylist still works for normal processes, but doesn't work for isolated services.
[Magisk] pndwal:
Ah, thanks... I hadn't realised it wasn't working for those till you mentioned that however...

So does Momo check for Magisk or SU by testing an isolated process? 🤔... PW
[Magisk] pndwal:
Yup.. So basically any release-Magisk patched boot image higher than downgrade App version being attempted must be replaced before downgrading... IIRC, you can't even downgrade first by avoiding opening the App since daemon still forcibly remove it, but I may be wrong about that...

The original point was that unlike using an unpatched boot image or earlier patched one, using Debug may be preferred as it avoids the need for a PC connection and allows downgrading or installing CI builds (even TJW CI builds use a different sig) etc because this disables both signature and version checks... PW
[Magisk] zgfg:
Sorry, lost track what were bugging you with Momo

For me, AppDataIsolation.v1.1 (from Adrian, your down-under fellow, his new GitHub page/identity), helps to pass Ruru, Applist detector and TB-Checker/XPosed check

Otherwise Syscall and libc are detected

I have no difference for Momo, with that module or without and with Shamiko or MagiskHide module, my Momo detects as on the screenshot

MIUI 12.5/A11, Canary 25209

---

On my other phone (MIUI 13/A12, Magisk Delta), I need that AppDataIsolation only for Ruru (Applist detector and TB-Check pass also without) and with or without, Momo does not detect Partitions mounted abnormally (but I think that's about the different ROMs on my two diff devices)

PS:

Fox MMM will find you also a legacy App Data Isolation module from Husky (it mentions A7 and A9)
[Magisk] Homeboy76:
< Removed >
[Magisk] martyfender:
I am happy to report that, finally, after about a week, that the latest CI builds have fixed the problem on my device of decrypting the data partition in TWRP.

I'm happy as a puppy with two p-----. (The comedy, City Slickers, Billy Crystal).

UPDATE: I'm wrong, it is not fixed, That was my tablet with the Delta builds on it. I accidentally put the official CI build on it. That chemo I had yesterday is effecting me already, lol!
[Magisk] pndwal:
Think you're jumping to conclusions again; Nothing was bugging me ... And I'm not sure why we need to keep regressing, however:

I posted Momo results in response to another user who stated Shamiko stopped hiding root to show:

@canyie has acknowledged this and said Shamiko fixes exist already:

But said:

which was also discussed since. (I disputed that denylist is entirely broken for me.) The conclusion was (with 25210 using A10):

I am aware of these solutions but they really have nothing to do with the issues discussed (won't fix 'em)... Isolated processes/services hiding and data isolation are two different issues...

Really, I have no need for App Data Isolation ATM... but thanks anyway... PW
[Magisk] pogo-airsupport:
Beware A14 DP2 cannot be rooted (or detected by app)

It appears the root itself works (can open ADB shell with su), BUT module loading isn't working because the app itself isn't detecting root
[Magisk] pndwal:
Seems it's because of Google change:

Blocks untrusted apps to access /dev/socket/mdnsd from U

New fix PR is Support untrusted_app_32

👀 PW
[Magisk] dd805bb:
A14DP2 not detecting root and modules loading are 2 different issues.. Modules are not loading due an error on a commit right before the last release. Reading through man oh man your back at it again. Lol.. Still fighting devs and people that actually have mods and or contributions to magisk itself. LMFAO..
[Magisk] pndwal:
If you're interpreting my hidden comment as "fighting Devs", I wrote and posted that before I was aware of vv's discovery/Google connection... She posted that just minutes before, and vv or Shana was right to mark my suggestion as Outdated... If it was considered 'fighting', it would probably marked as Off Topic at the least, and repo locked as 'heated' etc... Also, I posted Shana's fix didn't I?!

Dumb and inconsiderate comments like yours make me regret posting such fix links... Grow up... PW
[Magisk] pndwal:
More UNSUBSTANTIATED Tripe and Baloney... But you seem to want to fight... Where have I not backed down when wrong??!... PW

Edit: And it you who are breaking XDA/mod rules for 'flaming' etc...
[Magisk] dd805bb:
Modules not loading was figured out right after the update was pushed. Look at the actions. And I don't need to go back and clog the thread with more crap.

Android version and device??
[Magisk] pndwal:
And I was one of the first t post about it...

You're right though, I never said I was sure P7 issue was also related to refactoring in 25207 or 'Make Private...' neglected mkdir in 25210, but no-one mentioned even trying builds earlier than 25210 in that issue!... Seemed pretty obvious to suggest trying, which is all I did!

And no, I don't have P7... I've posted my current devices and setups often enough... I read and pass on whats helpful... What are you trying to do?!... PW
[Magisk] Badger50:
Thread lightly cleaned!

@S8rooted&tooted and @pndwal

Greetings to you both. As you have both noticed, I have cleaned this thread of some of your recent comments. I will politely ask you both to please refrain from

further OT and argumentative comments, and to please conduct yourselves in accordance with XDA Rule #2.3 for member conduct:

If you wish to argue further, then please do so via PM's, or another platform since XDA is not the place for these types of discussions on the public forums. Please be advised, posts which continue to violate the forum rules will be removed with immediate effect, and posiible sanctions applied to your account should things get too far out of hand, which we certainly do not want.

So please let this be the end of this here and now.

Thank you for your cooperation, and hope you have a pleasant day.

Best regards: Badger50
[Magisk] nicholasmaden:
I'm having a problem with the latest version of magisk, 20.1. Magisk stops sending root requests for new apps. It only request authorization if I install magisk zip via recovery again, and the problem appears after a few minutes. Apps with root authorization work normally.
[Magisk] pndwal:
Where did you get that?... Latest is 25.2!... PW
[Magisk] LVA_:
Got an odd issue here. Magisk, which was hidden, stopped working (app didn't open). Without thinking I uninstalled it, intending to reinstall it. Stupid, but it is what it is. Downloaded the 25.2 apk from github, installed it.

The resulting app showed in the app drawer, but without the icon. Odd.

It doesn't launch when pressed. Very odd.

It reports as being 180kB big. Uh-oh.

Tried uninstalling and reinstalling multiple times in various ways - local, adb, streaming, etc. No difference. I pulled a logcat now, and behold:

03-10 13:50:27.671 5264 18669 E Magisk : cert: APK version too low
03-10 13:50:27.672 5264 18669 E Magisk : pkg: APK signature mismatch: /data/app/~~ncOuYdYq2KGH6I7bHADykw==/com.topjohnwu.magisk-ZMFtiZff--iVmTN-czBVgw==/base.apk
03-10 13:50:27.732 22414 22414 I Magisk : pm_uninstall: com.topjohnwu.magisk
03-10 13:50:28.937 22457 22457 I Magisk : pm_uninstall: Success
03-10 13:50:29.004 22470 22470 I Magisk : pm_install: /data/stub.apk
03-10 13:50:30.055 22495 22495 I Magisk : pm_install: Success

So it appears that right after I install the full package, *something* is triggering an automatic uninstall, and the stub gets pushed. Which still works:

$ adb shell magisk -c
831a398b:MAGISK:R (25206)

To make things even more interesting: I rebooted as a test into non-rooted. Magisk app installs like a charm and opens. Reboot into recovery for root (as is the Samsung way) - nope.

I'm certain I never had more than one instance of Magisk installed, only the one hidden one. But to make sure anyway I ran over the full list of installed packages and there are none in there that I can't link to an app or system service.

UPDATE: I think I might have been running Canary. Had a need for some rather bleeding edge things at some point.

UPDATE 2: I'm an idiot. I *was* running Canary. And Canary doesn't like to mix with Release. Downloaded the latest Canary apk, installed it, works like a charm.

I considered deleting this post but perhaps it'll prevent some other airhead like me from going on a wild goose chase for a few hours.
[Magisk] TGX03:
I am not sure where to exactly write this, as Shamiko does not seem to have it's own thread.

However my bank (Commerzbank in Germany) pushed an update to its app, that now detects root even with Shamiko, USNF and so on. I dug into it a bit and found out for this it uses the ZygotePreload-Feature.

The only real existing information I found was this, and the proposed fix seems to be Riru-Unshare. As that module is out-of-date and not maintained anymore, I looked further and found claims about this module already being integrated into Shamiko.

But still, the app detects root. Is there anyone who has an idea what to do about this?
[Magisk] AquilaDroid:
I discovered this issue on my Pixel 5 a few days ago, Magisk is still working but can't open the app. I'm on Canary, need guidance as to how to install the new version (app.debug.app?) . Do I just install from file manager? Then what? Thanks!
[Magisk] Nergal di Cuthah:
Install canary 25209 it should open (it sounds like you have 25208 (i think it was) 25207 as that version refused to open for me)
[Magisk] AquilaDroid:
Thanks! 25209 did the trick!
[Magisk] mochamoo:
Having the darndest time trying to find 25209 on the github. Can someone point me in the right direction? Thanks.
[Magisk] zzz2002:
You and me both!
[Magisk] Nergal di Cuthah:
I finally went to apk mirror for it but on the off chance check your downloads folder it might be there
[Magisk] mochamoo:
no not in download folder...well possibly if it's app-debug 2/12/2022?? I could go to apk mirror but prefer github if I can find it. You know ... get it from the source!

which one is it?