yashsingh1/xdaforums huggingface dataset:
[Magisk] Didgeridoohan:
Don't shotgun post! Post once and wait (and don't PM with such a general question). Your post will likely be noted even if you only post the one. Anything else is just annoying...

You need to start with providing some information. What is it exactly that is keeping your device awake. Use a monitoring app, like Better Battery Stats or similar, to figure out what that might be. Check (and provide) the logs. There might be something that is constantly requesting superuser access, as an example, keeping your device awake. Etc...

---------- Post added at 14:36 ---------- Previous post was at 14:34 ----------

Magisk disables dm-verity already... You can experiment with the settings when installing.

Check here: https://www.didgeridoohan.com/magisk/Magisk#hn_Keeping_dm-verity_and_forced_encryption

Edit: I would recommend just using the custom kernel though. So much easier...
[Magisk] firozpatel:
[MENTION=4667597]Didgeridoohan[/MENTION]

it usually happens at night when the phone is idle, when i check the battery stats its something called android os thats at a high percentage, so if my phone is charged 100% in a few hours it will drop to 60-80% of not using the phone, most kernels have this deep sleep fix embedded in there kernels also chainfires supersu solved this matter

what i am using:

samsung galaxy s6 edge 6.0.1

magisk 16 and magisk manager 5.7.0 (passing safetynet)

arter97 kernel and XtreStoLite rom
[Magisk] Didgeridoohan:
Just using the Android battery stats won't tell much. Use a more detailed battery monitor. Without detailed info about what's going on, it'll be hard to have any kind of "fix".

Also, what about those logs?
[Magisk] firozpatel:
Right now it doesn't seem to be eating the battery away, but you know better, happens when the phone is idle at night, I've uploaded the log and the picture for the stats
[Magisk] Didgeridoohan:
Does it constantly force close when opening? I just tested (just opening it, nothing else since I don't have an account), and I could get it to start with the app on the Hide list and Magisk Manager hidden. If it's something else, take a look here if there's something that might work:

https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot
[Magisk] MrAndroid-HD:
It forcecloses on launch, yes :( I'll have a look at the link later when I'm off work, thanks.
[Magisk] xt1622-blue27:
so far i have been trying to install the magisk zip using twrp.

i now patched the stock boot.img using magisk manager. however when i try to flash it using fastboot i get

"FAILED (status read failed (Too many links))".

you're probably right... i'll use the elementalx kernel...
[Magisk] WTF_666:
today updated Samsung pay and the application began to see the root. tested on 16 and 16.4. Thank you in advance)
[Magisk] mobileman88:
How did you update Samsung pay?
[Magisk] angelus errare:
I'm running into this too, but it's a 5T (dumpling). It also does this from a clean install.
[Magisk] simo6:
Same here op5. Any ideas?
[Magisk] WTF_666:
across Samsung Gear an update has arrived
[Magisk] firozpatel:
[MENTION=4667597]Didgeridoohan[/MENTION]

The deep sleep has started to creep up and is starting to drain battery
[Magisk] Didgeridoohan:
That's to short a time to say much at all... You need several hours to get good data.

You need to try to figure out what is actually keeping your device awake. Not just that it is awake... Check the wakelocks and alarms to try to figure it out, but wait until you have more data to work with.
[Magisk] BurnedDrake:
I would suggest using a different kernel, every Android device I've had and used custom kernels on, damn near every one of the "no apparent reason for battery drain" was fixed by using a different kernel. It was probably something in my setup that didn't agree with what the kernel wanted to do, so I found it so much easier just to swap to a different kernel
[Magisk] firozpatel:
Have you got any recommendations for a kernel for s6 edge 6.0.1? I've tried few kernels but they don't work along side magisk, for example if I install magisk and then a kernel with supersu built (which most kernels do) it just uninstalls, and if I install magisk after installing the kernel, the kernel uninstalls. There is no both, only managed to have artar97 kernel working but his kernel does not fix the deepsleep bug

Unless there is a way to install a kernel without the use of SuperSU? And have magisk working

Thanks for your help
[Magisk] BurnedDrake:
Fully uninstall SuperSU from within SuperSU, you may need to flash the Uninstaller to get everything. Then just flash Magisk. What makes you think Magisk removes the kernel?
[Magisk] firozpatel:
I installed a kernel and I lost magisk, then I installed magisk and lost the kernel, I have no idea why it did that, so I installed my rom which is pre rooted with su and done a full unroot within su, and repeated the process of magisk and ended up with the same result
[Magisk] smfilip:
Hello, magisk manager started crashing 1-2 seconds after opening it... app simply closes,not warnings,nothing.

I have logged it, filtered to 'error' level:

05-29 23:53:36.260 D/HwRTBlurUtils(8415): check blur style for HwToast-Toast, themeResId : 0x0103013f, context : com.topjohnwu.magisk.MagiskManager@1be3867, Nhwext : 6, get Blur : disable with , android.graphics.drawable.NinePatchDrawable@9d79614
05-29 23:53:45.278 D/HwRTBlurUtils(8415): check blur style for HwToast-Toast, themeResId : 0x0103013f, context : com.topjohnwu.magisk.MagiskManager@1be3867, Nhwext : 6, get Blur : disable with , android.graphics.drawable.NinePatchDrawable@da4f1d1
05-29 23:53:46.693 E/MagiskManager(8415): ERROR: Repo [AppSystemizer] is outdated
05-29 23:53:46.749 E/MagiskManager(8415): ERROR: Repo [Google_Assistant_Enabler] is outdated
05-29 23:53:46.804 E/MagiskManager(8415): ERROR: Repo [HEVC-Enabler-for-OP3T] is outdated
05-29 23:53:46.854 E/MagiskManager(8415): ERROR: Repo [AptoidePriv] is outdated
05-29 23:53:46.866 E/MagiskManager(8415): ERROR: Repo [ExSDCard_Write_Access_Enabler] id=[ExSDCard] has illegal repo id
05-29 23:53:46.867 E/MagiskManager(8415): ERROR: Repo [magisk-gapps-h2os] is outdated
05-29 23:53:46.925 E/MagiskManager(8415): ERROR: Repo [magisk-soundmod-s7-n] is outdated
05-29 23:53:46.934 E/MagiskManager(8415): ERROR: Repo [magisk_selinux_manager] id=[magisk_selinux_manager] has illegal repo id
05-29 23:53:46.939 E/MagiskManager(8415): ERROR: Repo [MI-A1-Gcam-addicted] id=[mi_a1_gcam] has illegal repo id
05-29 23:53:47.005 E/MagiskManager(8415): ERROR: Repo [Nexus6_LED_Enabler] is outdated
05-29 23:53:47.010 E/MagiskManager(8415): ERROR: Repo [OnePlus-Slate-Font] is outdated
05-29 23:53:47.340 E/MagiskManager(8415): ERROR: Repo [SonyAppsEnabler] is outdated
05-29 23:53:47.344 E/MagiskManager(8415): ERROR: Repo [SonyAppsEnablerAlt] is outdated
05-29 23:53:47.344 E/MagiskManager(8415): ERROR: Repo [sudo4droid-magisk] is outdated
05-29 23:53:47.397 E/MagiskManager(8415): ERROR: Repo [Systemlessly-Font-with-Tsukushimarugo-A-CJK-Sleek] is outdated
05-29 23:53:47.397 E/MagiskManager(8415): ERROR: Repo [Tethering_Enabler] is outdated
05-29 23:53:47.410 E/MagiskManager(8415): ERROR: Repo [unlock-cn-gms] is outdated
05-29 23:53:47.450 E/MagiskManager(8415): ERROR: Repo [ViPER4Android-v2.3.4.0] is outdated
05-29 23:53:47.455 E/MagiskManager(8415): ERROR: Repo [Volume_Steps_Increase] is outdated
05-29 23:53:49.597 D/HwRTBlurUtils(8600): check blur style for HwToast-Toast, themeResId : 0x0103013f, context : com.topjohnwu.magisk.MagiskManager@1be3867, Nhwext : 6, get Blur : disable with , android.graphics.drawable.NinePatchDrawable@9d79614
05-29 23:54:02.441 D/HwRTBlurUtils(8600): check blur style for HwToast-Toast, themeResId : 0x0103013f, context : com.topjohnwu.magisk.MagiskManager@1be3867, Nhwext : 6, get Blur : disable with , android.graphics.drawable.NinePatchDrawable@e2de07b
[Magisk] Jrhotrod:
Hello! I'm a long-time user of Magisk and really enjoy this software.

I've always used a module that enables the camera2 API for my device (potter). I never had any issues with it, and it worked to perfection. I recently did a clean install of my ROM, and about 2 weeks after that, I tried to reinstall the Magisk module only to be greeted with failures, both in TWRP and in Magisk Manager. I reported the issue to my device's Telegram group, where I was told that it was an sepolicy issue. I wasn't so sure, since it was complaining about Magisk not being installed (which is wrong), but I also don't know much about how SELinux affects Android system and Magisk.

Logs from TWRP and Magisk are attached; I tried to filter them to get to the relevant information. Thank you for any help I can get :)
[Magisk] jenslody:
Hard to say without the module-zip, but it probably uses an outdated module-template.
[Magisk] Didgeridoohan:
[MENTION=7896819]Jrhotrod[/MENTION]

Two options, I would guess.

The module is incompatible with current Magisk releases and need an update. Upload or link to the module.

Faulty Magisk installation. A complete uninstall and reinstall might fix.

Edit: Ninja'd!
[Magisk] exist2resist:
The current stable version is not working on Pixel 2 XL, May Security patch.

I get the G logo and the load bar, I reflash the OTA and the phone boots fine.

I patch the boot.img and flash via fastboot.

Do I need to use the beta?
[Magisk] Jrhotrod:
The module is attached to this post. I've already tried reinstalling Magisk, but still no go.

Thank you for the help!
[Magisk] digitalhigh:
Gee...if only somebody were working on an update...

https://drive.google.com/open?id=0B0OpOqUNqeKkaVNWQWE3Si1TSXc
[Magisk] JudgeDread11:
You posted this 2 times in half an hour. This thread is already overflowing. Behavior like this will only annoy people and then they won't help you for sure.
[Magisk] StrykZ:
Hi, i followed the instructions and everything seems to be working but after installing i found that my bluetooth doesnt turn on anymore

i'm using n910u running cm13

Anyone have any ideas?
[Magisk] Alxoom33:
That would be wonderful, if the apk can be installed, unlike v. 1.2 which takes a lot to uninstall all remnants first.
[Magisk] digitalhigh:
Sigh...

That moment when you expect people to pee their pants, and instead, you get the feeling they didn't even click the link...
[Magisk] alroger:
See, for all those having root toggle problems, the reason is that there's some superuser app, or leftovers of one, that Magisk doesn't have control of. If it's not a Magisk root, it can't help it. (including busybox installs and stuff)

Can't you flash TWRP without rooting at all? Usually you can, just find the instructions for you device in it's forums or even the twrp site.

That way you flash a clean stock ROM, to get rid of everything, and start CLEAN - with TWRP, then Magisk and a Magisk root.

PS: if you get prompted for some superuser binary update, that's a sign that there is another superuser bin, app or leftover, because I've never had an update prompt since installing Magisk.

PS2: if you have Magisk installed, then removing su from an App probably won't work.. only through recovery flashing. Then again, you must find details in your root's thread, or ROM's, or device's.. each one has it's tips and instructions. You can even ask your ROM's dev what you need to do to completly remove root (search the thread first).

Cheers.

UPDATE: Wiping data/system/etc doesn't garantee that there isn't something in your boot (boot.img). SU apps might inject boot to keep itself alive after updating ROMs, etc. Thus the recommend stock flash. After TWRP you can flash you ROM or any updates. Just flash Magisk again after any ROM updates.
[Magisk] hoeni:
For every new flash I wipe system, data etc, so nothing "old" can remain.

Is it really necessary to install a stock rom?

I don't know if that's a prejudice but custom roms really give more options for... customisation. And performance. Oh God, the performance.
[Magisk] Android-UK:
Well goodie gumdrops thanks for showing me that. I didn't realise giving feedback involved such a sarcastic reply.

My suggestion of the widget still applies.
[Magisk] digitalhigh:
Ha. Talk to my wife. That's like a 1 on my sarcasm-meter. Nothing personal, I just found it a good opportunity to show off a bit. :P
[Magisk] Alxoom33:
Sorry, I didn't mean to be a "debbie downer" and rain on your parade. Your animation of the new version of Magisk Manager was wonderful and I hope the new manager is implemented soon. I am just very frustrated in not being able to install v. 1.2 manager after going through so many machinations to uninstall prior versions of Magisk file remnants per the instructions in the OP without success.
[Magisk] alroger:
Wiping data/system/etc doesn't garantee that there isn't something in your boot (boot.img). SU apps might inject boot to keep itself alive after updating ROMs, etc.
[Magisk] olivercervera:
Wow, this is wonderful. I'm not going to ask for an ETA, but I want that APK!!!! :good:
[Magisk] locolyric:
Yeah! just make the systemless magisck work!

now on the way to install xposed and viper4android.

=======================

Everything is working sa description!

Yeah
[Magisk] b00tstrap:
Thanks, that's good information. Unfortunately, I don't know enough about Magisk's architecture to guess what might be happening here. I do know that the notification that tells you your SU binaries are outdated happens when Magisk has been unable to mount root (which makes sense, since you flashed unSU).

I'm not sure where the point of incompatibility with older Samsung devices is, but I would assume that it's their architecture and not just the ROM. Fortunately, topjohnwu is working hard on v7 which should fix the problem.

Edit: And per alroger's comment above, I think that the ROM you're flashing has root built in, so the remove-root scripts probably aren't doing a good enough job. Flashing back to a stock ROM may be necessary to get it working.
[Magisk] Xebazzztian:
Reserved, I hope someday this fully work on Moto Devices with Custom ROMs and Kernels
[Magisk] villo88:
Anyone has a solution to install on Xiaomi? I made all the steps but when I click on hide root the toggle isn't working.

In my case also If I full unroot then from twrp I have the option to reinstall root permission since needed for the rom itself but I can use any app I want...

Inviato dal mio Redmi Note 2 utilizzando Tapatalk
[Magisk] james_rokr:
Working with Boeffla Kernel + CyanogenMod 13 (Phh Root) as a secondary rom on a Galaxy S5 (KLTE) using chenxiaolong DualBoot Patcher.

Minor Issue: Gotta reboot twice after each modification for getting root to be detected by apps (and kernel)

PS: Installation was a pain in the ass, please add CM13 instructions to the OP
[Magisk] Äptiva:
That is your problem. I had that issue with the dorimanx kernel installing busybox there.
[Magisk] digitalhigh:
Read my signature, post a logcat. I happen to know MIUI quite well, it's possible I can figure out what your issue is.

-Ben
[Magisk] hoeni:
Holy moly I got it to work on the Note 3.

The issue was: there was a separate folder called Supersu in the very root folder of the device (among bin, xbin etc). I never read abput that one before. I deleted everything in there and suddenly it startet to work.

I tried the same with my s3, but nothing changed.

I think the bug is that the Magisk app there doesn't ask for root.

I'll try another rom later on, although I don't know if there are any non-cm mm roms available. Hardly anyone uses that one anymore :)

---------- Post added at 07:01 PM ---------- Previous post was at 06:59 PM ----------

Could you provide me with a link to CM13 instructions? I'm stuck on my s3 atm and there aren't many alternatives to cm based mm roms.
[Magisk] Didgeridoohan:
That's an ancient module that won't install on any Magisk release past v14 (or thereabouts, can't quite remember the exact version)... It needs to be updated to the current template.
[Magisk] Jrhotrod:
Huh. I've always been able to install it on v16. How odd!

Thank you for the help nevertheless. I will contact the module dev, but they will likely not want to update it because Nougat for my device is not used by many anymore - just me and a few others that value stability over the latest Android version. Is there an easy template ZIP I can download and just maybe transplant some of the files? I don't know how to build from source :crying:
[Magisk] Didgeridoohan:
Yes, it's in the link from my last post. [MENTION=4470081]topjohnwu[/MENTION] have included some pretty thorough instructions in there, and you'll find some more here:

https://github.com/topjohnwu/Magisk/blob/master/docs/modules.md
[Magisk] LeRiton:
Hi everybody,

I'm trying to update my Xiaomi Redmi Note 4 (mido) from Lineage 14.1 to 15.1 (treble).

I'm using TWRP 3.2.1-5 and Open GAPPS 8.1 arm64.

Update was successfulk using ROM image and GAPPS.

Then Iaunched a Magisk 16.0 flash through recovery -> bootloop on Xiaomi logo.

I then tried version 16.4, system now boots but Google Play services crashes at startup and then keep crashing again and again.

I the tried to uninstall Magisk through uninstaller 16.4 in recovery, but uninstalling doesn't work:

Does anyone have an idea about what's going on with my update? Same question for the Magisk uninstaller?

Thanks in advance
[Magisk] smfilip:
still no solution
[Magisk] Didgeridoohan:
Try [MENTION=3306843]kantjer[/MENTION]'s unofficial snapshot. There's a commit that's not yet in any official release that might fix this.

Edit: just remember that it's a snapshot of the current code and may or may not work properly...
[Magisk] Jrhotrod:
Wanted to let you know that your tip worked - I successfully updated the module and it is working to perfection now. Thank you!
[Magisk] Elador:
Hi,

I've installed the latest Magisk via TWPR. The log output showed that it discovered a stock boot.img and it created a backup of it, but it didn't give the full path to where it is being stored.

I've searched the whole internal storage now but can't find any such file. Where does Magisk store the boot.img backup that it creates during its installation?

Thank you!
[Magisk] Wolfcity:
You should find it in /data as described in this great tutorial:

https://didgeridoohan.com/magisk/MagiskInstallation
[Magisk] Elador:
Awesome, that is exactly what I was looking for! Found it!

Thank you so much for the quick help! :) Much appreciated!
[Magisk] mateus9898:
I did exactly as you said but when i reboot to system the phone comes back to TWRP recovery. I tried extracting the "boot.img" from the rom but the same thing happens. I want to remove magisk make an OTA update and reinstall magisk. I'm using a Galaxy S6 on 6.0.1 and want to update to Nougat What should i do?
[Magisk] BillGoss:
I wanted to do some testing without Magisk installed, so I ran the 180429 uninstaller (from the OP).

It failed in TWRP with error 1.

The logs are attached but here are the relevant lines:

- Device platform: arm64
cp: can't stat '/dev/tmp/install/arm64/.': No such file or directory
! Cannot find /data/adb/magisk
Updater process ended with ERROR: 1

Any idea what's going on?

Phone: OnePlus 3T

OS: OOS 5.0.1 and 5.0.3 (tried it on both)

TWRP: latest official 3.2.1-0

Encrypted data
[Magisk] Didgeridoohan:
That's caused by the removal of the 64-bit binaries, and [MENTION=4470081]topjohnwu[/MENTION] haven't really had time to put out a fix. Use the next to last uninstaller instead:

https://github.com/topjohnwu/Magisk/releases/download/v16.3/Magisk-uninstaller-20180328.zip
[Magisk] smfilip:
It seems this solved my problem. Thanks!
[Magisk] specialex:
with Magisk 16.4, after some time root is lost so you need to restart your phone

with 3 different roms with clean install, DU, RR, Omni for OP3T
[Magisk] deepakdavidster@gmail.com:
Me too had same issues
[Magisk] ianmacd:
Module installation has suddenly started failing.

I'm running Magisk, compiled from the latest sources, on a Galaxy S3 Tab and it has been running absolutely fine.

Today, however, module installation has inexplicably started to fail. Here is an example:

- Copying zip to temp directory
- Installing initd-stub.zip
- Mounting /system, /vendor
Archive: /data/user/0/com.topjohnwu.magisk/cache/install.zip
creating: common/
inflating: common/post-fs-data.sh
inflating: common/service.sh
inflating: common/system.prop
inflating: config.sh
inflating: module.prop
********************************
init.d stub
********************************
******************************
Powered by Magisk (@topjohnwu)
******************************
- Creating /data/adb/magisk_merge.img with size 64M
Creating filesystem with parameters:
Size: 67108864
Block size: 4096
Blocks per group: 32768
Inodes per group: 4096
Inode size: 256
Journal blocks: 1024
Label:
FLEX_BG size: 0
Blocks: 16384
Block groups: 1
Reserved block group size: 0
Created filesystem with 11/4096 inodes and 1286/16384 blocks
- Mounting /data/adb/magisk_merge.img to /dev/tmp/magisk_img
Cannot mount image!
! /data/adb/magisk_merge.img mount failed...
Failed!
! Installation failed

The module is one I made myself, but that's irrelevant. Installation worked yesterday, but fails today. In fact, all modules I try to install today are failing in the same way, because Magisk cannot mount /data/adb/magisk_merge.img. I've verified that the ramdisk it creates is a legal file, because I can cleanly mount it on my laptop.

It seems that the mount point /dev/tmp/magisk_img isn't getting created, but I have no idea why and I haven't yet figured it out from the source code.

I've tried the sledgehammer approach of uninstalling and reinstalling Magisk, but that doesn't help. I should add that Magisk continues to function perfectly in all other ways, and previously installed modules continue to work. The issue is confined to the installation of new modules.

The Magisk Manager log shows nothing untoward. The log quoted above is the only one that shows anything relevant.

Has anyone seen this before and has a suggestion of what might have happened? To the best of my knowledge, I haven't changed anything on the device that could affect Magisk, but clearly something I don't understand has changed.

UPDATE:

Never mind. There's something not quite right about that build of Magisk. I must have installed it only after my previous successful installation of a module, and thus hadn't yet noticed that this build can't install modules.
[Magisk] BruceElliott:
Wipe /data required if already infected with SafetyNet?

Galaxy S5 on stock 6.0.1 is infected by SafetyNet. I re-flashed stock ROM (.HOME version from Sammbile) and am about to flash Magisk 16.4. I am trying to decide whether a dreaded factory reset to wipe /data is necessary to get rid of the SafetyNet failed state. What I am afraid of is that there may be a cross-infection between /data/data (gapps) and installed apps that cooperate closely with SafetyNet.

In particular in my case, for example, an app "NOAA Weather" reports frequently back to Google and warned me to to update Play Services to the bad actor v12.6.85 after I restored Play Services and Play Store to stock versions. Poking around in Play Services SqLite databases in /data/data (...gms) I found an unencrypted database listing the NOAA Weather app executable name. I am afraid that the NOAA Weather app's data may also have logged my device as SafetyNet blacklisted. And who knows where else in /data the SafetyNet failed state may be flagged.

I am hopeful that Magisk hide functions will provide a permanent solution. I'm just not sure whether I need to wipe /data (factory reset) to clear my device of the infection to begin with. But then if I do that I must have the phone out of airplane mode to go through initial device setup, during which time Google will update Play Services and Play Store in a blink of an eye and may re-infect the phone as "Uncertified" before I even have a chance to install and configure Magisk Manager. Also FYI I whitelisted the phone's GSF ID on the Google "Uncertified Device" website to regain access for awhile a couple of days ago. But that only lasted for a few hours until SafetyNet complained again after I began locking things down with Netguard and Titanium freezes.

Any suggestion are much appreciated!