yashsingh1/xdaforums huggingface dataset:
[Magisk] guastucci:
But I can't use superSu to have root and use Magisk to have it modules? In the past we could do this... Not anymore?
[Magisk] aaargh777:
No you can't, but if you install magisk your device is already rooted so there's no need to use supersu too
[Magisk] Pkt_Lnt:
Not since 2017.6.8 [BETA] Magisk v13.0

You might want to keep up with the Official Release thread.

https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445
[Magisk] Droiderat:
Failed again. I downloaded the patched version, and placed it in the MagiskManager folder. I renamed it to "Magisk-v16.0(1600)", so that it wouldn't be over-written by a new download (of the old code).

Here is the log file:

- Device platform: arm64

- Extracting files

- Unpacking boot image

MagiskBoot v16.0(1600) (by topjohnwu) - Boot Image Modification Tool

Parsing boot image: [/data/user_de/0/com.topjohnwu.magisk/install/boot.img]

PXA_BOOT_HDR

KERNEL [0]

RAMDISK [1296651355]

SECOND [1702130549]

EXTRA [979203183]

PAGESIZE [1159742537]

NAME [NFORCING

]

CMDLINE [usted boot]: SEAndroid MAGIC failure (recovery.img)

]

CHECKSUM [3d307831303030310000000000000000207365635f64656275672e6c6576656c]

Segmentation fault

- Checking ramdisk status

MagiskBoot v16.0(1600) (by topjohnwu) - Boot Image Modification Tool

- Stock boot image detected

- Backing up stock boot image

MagiskBoot v16.0(1600) (by topjohnwu) - Boot Image Modification Tool

Compressing to [stock_boot_98a6386c8d1ca4309fe673ec1b53536856d7ca11.img.gz]

cp: can't stat 'ramdisk.cpio': No such file or directory

MagiskBoot v16.0(1600) (by topjohnwu) - Boot Image Modification Tool

Add entry [init] (0750)

Patch with flag KEEPVERITY=[false] KEEPFORCEENCRYPT=[false]

Save SHA1: [98a6386c8d1ca4309fe673ec1b53536856d7ca11] -> [.backup/.sha1]

Record new entry: [init] -> [.backup/.rmlist]

Dump cpio: [ramdisk.cpio]

- Patching ramdisk

MagiskBoot v16.0(1600) (by topjohnwu) - Boot Image Modification Tool

Parsing boot image: [/data/user_de/0/com.topjohnwu.magisk/install/boot.img]

- Repacking boot image

PXA_BOOT_HDR

KERNEL [0]

RAMDISK [1296651355]

SECOND [1702130549]

EXTRA [979203183]

PAGESIZE [1159742537]

NAME [NFORCING

]

CMDLINE [usted boot]: SEAndroid MAGIC failure (recovery.img)

]

CHECKSUM [3d307831303030310000000000000000207365635f64656275672e6c6576656c]

Segmentation fault

! Unable to repack boot image!

Failed!

! Installation failed
[Magisk] guastucci:
Unfortunately Leandroid don't work with Magisk Su...
[Magisk] jcmm11:
Post questions about this version inn the other thread, referencing the author of the patch (see the post you got it from). I think that's your best chance of a good answer.
[Magisk] Didgeridoohan:
Just to make sure: You install the the zip by going to the module section of the Manager and pressing the "+" button. Then select the zip and it'll install.

In that case you should ask the developers to fix their app...

---------- Post added at 07:57 ---------- Previous post was at 07:28 ----------

I'm answering you here instead of the Beta thread where you posted, since it's not quite the correct place for your query...

It's very possible that the app needs to be updated to work with MagiskSU. After a quick look in the Play store I'd say it's an abandoned app and unlikely to get any updates though... You might have to find other alternatives.
[Magisk] binarnh:
Can anyone tell me if magisk works on Nokia 6?
[Magisk] Bogdan010:
Try
[Magisk] Didgeridoohan:
And in case you don't want to try, the device forum might be the best place for your query.
[Magisk] jenslody:
As [MENTION=4487388]jcmm11[/MENTION] tells you, if you use installation instructions from Beta-thread, please switch to this thread, you can refernce the post from here of course.

And if you follow instructions, you should follow them literally (note the "in TWRP"). Or follow the whole conversation, even if it means (here on xda) to step through all the former posts belonging to it.

In this case you would have seen, that [MENTION=1813976]shakalaca[/MENTION] has created a custom channel for this special version.

Renaming the zip does not work, because MagiskManager always reloads the update-files from internet (that's why the custom channel was created).

Or do it as [MENTION=4667597]Didgeridoohan[/MENTION] writes, install it through the modules section by using the "+"-button and chose the zip you want to install.

Just trying something without the knowledge of the mechanism behind it, and what's more without knowing the whole conversation about the problem, can be a waste of time.
[Magisk] shakalaca:
Can you check the existence of this file: "/data/property/persist.magisk.hide" ?
[Magisk] flipmode_11:
Thanks Shakalaca. :angel: :good: Yes it exists 0600 CHMOD.

Any other ideas why certain options would not stick after closure?

Probably unrelated, but I do remember seeing someone in another conversation recommended not to exit Magisk Manager and to reboot from within the app (instead of exiting, then reboot). I forget now which page, topic and category...

Cheers Shak! (wait, can I say 'Shak'?)
[Magisk] shakalaca:
Ok try those steps:

1. Close (stop) Magisk Manager

2. Remove that file (/data/property/persist.magisk.hide)

3. Open Magisk Manager

4. Turn on Magisk hide

5. Quit Magisk Manager (press back or home key)

Back to Magisk Manager again and check the status of Magisk hide.

btw you can just call me Shaka .. ;)
[Magisk] shakalaca:
Please uninstall Magisk Manager and install Magisk v16 via TWRP.
[Magisk] soder:
Without having read all the posts, I wonder if Magisk 16 Will work on Android 8.1?

I got a OP3T running LineageOS 14.1 and thinking about testing LineageOS 15.1 and therefore I wonder is Magisk 16 will work?

/Söder
[Magisk] Ja_som:
Try to use search function, it is helpful.

Also (re)read forum rules

https://xdaforums.com/announcement.php?a=81
[Magisk] martyfender:
I have not seen anyone make mention of the fact that Magisk development is on hold as [MENTION=4470081]topjohnwu[/MENTION] is on military duty for 4 months with limited Internet access:

"Huge Announcement

Starting from Feb. 22nd (yes, I'm about to leave in a few hours....), I will start serving the mandatory military service for 4 months. In these 4 months I will be disconnected from the Internet... umm... actually, disconnected from the entire world should be more precise LOL. I worked full time the last few weeks in order to push out some quality stuffs before I leave for quite a long period of time. The submission server is not robust enough for me to deploy it on a remote machine, so the server will be down for most of the time in the following months. Occasionally when I have a few days off in the weekends, I will ramp up the server and gobble through the requests, and maybe check some easy issues if I found the time, but don't expect anything from me.

I hope this release is good enough for my temporary departure. Good bye Internet

Logout. "
[Magisk] soder:
OMG...

/Söder
[Magisk] BertlBrown:
I can confirm that merging works with this changes but the script fails at a later step while accessing via the old and broken paths.

[MENTION=1959263]Sebastl[/MENTION], could make your changes public?
[Magisk] BertlBrown:
DM-Verity can't be the reason as it is not about access control at all. You can view it like signing a block device with pgp. It's still possible that data gets modified, but if you compare the signature, you can tell. The trick is, that the private key never gets delivered, so I don't believe that this is enabled at for /data. This is only for /system.

see https://source.android.com/security/verifiedboot/

I can't imagine how DM could produce this kind of errors. It simple doesn't know if data got written to the original fs or if it traveled through bind mounts, loop or anything else before. It can't even tell which fs is operating on it. It's just a block device writing blocks to other block devices.
[Magisk] Sebastl:
Thanks for the Feedback. Sure. I just posted it before im gone for a week so that potential solutions have time to rise ;)

Note: Logging for the bootstage mounts/merges is extended. Please send me failures - if they are relevant ;)

What does your magisk-manager log show when you try to install the busybox module in combination with my patch ?

DM Stuff:

It's not literally access rights. It is just managing the devices. And if the device-mapper or dm-verity decides or triggers "no" it just blocks the access to the underlying device. That results in a Buffer I/O Error as we experienced it for example.

And that leads to the kernel switching to RO as protection.

Thats how i understand that layer.

And of course it cant be active for /data. But every loop mount goes through /dev/block/loop. Thats what i meant with

"lowest common denominator". But still open for all other ideas ;)
[Magisk] flipmode_11:
Looks like the file system is mounted as Read Only R/O. You could try mount as R/W and try again.

/dev/tmp/magisk_merge/adb-ndk/

Have you tried flashing Uninstall ZIP package through TWRP? or Odin? Then try flashing Magisk after that?

Please attach error logs, or use "

" icon in the toolbar when inserting lots of text. :good:

---------- Post added at 08:53 ---------- Previous post was at 08:04 ----------

Okay so Bug regarding Magisk Hide not remembering Status is Fixed. Well done! :)

Force stopped Magisk Mananger.

Deletion of file /data/property/persist.magisk.hide (0600).

Start Magisk Manager and enable Hide, Swipe Left and Hide menu visible.

Close. Force stop

Mananger. Reopen and Swipe Left menu and Magisk Hide is still visible! Woohoo!!!

Cheers Shak!

Note: After re-enabling Hide, the file ''/data/property/persist.magisk.hide'' does not reappear. :eek:

I wonder why it was not removing the file itself? Bug or OS?
[Magisk] yochananmarqos:
If you're not clear on Magisk development for the next four months, then you didn't read what you just quoted. :rolleyes:
[Magisk] shakalaca:
Would you please send me your boot image for analyzing ? :)
[Magisk] Sf!:
Hello,

I'm stuck when i try this (adb) :

If anyone can help me...

thank in advance!

Plz use simple and easy english, i'm french

Windows 10, last adb (files are 13 december 2017)
[Magisk] siavash79:
Hi everyone

Since magisk 15.5 onwards (including 16.0) my pixel C tablet doesn't boot anymore. (it doesn't look like a boot loop as it never reaches the boot animation: The boot screen gets stuck at Google logo)

I've disabled all modules before updates, and it doesn't help either.

The only solution so far is to roll back to 15.4 which works fine for me.

Any suggestions?

Thanks
[Magisk] martyfender:
Do you mean this:

"Occasionally when I have a few days off in the weekends, I will ramp up the server and gobble through the requests, and maybe check some easy issues if I found the time, but don't expect anything from me."

?

Maybe, then, my statement of "on hold" is not entirely accurate. Why are you taking such offense?
[Magisk] vMAC:
I have a Pixel 2XL, tried flashing in TWRP, apparently my phone doesn't have a cache. So I don't believe that is my issue.

Anyone else have any suggestions?
[Magisk] chicato83:
I don't know how to mount as R/W tell me how can I do it?

I have the same issue with the magisk V15 and I installed the stock room again and then I installed the V16 of magisk. I Uninstaller with the zip one time and reinstall and I have the same issue.

Thanks.
[Magisk] yochananmarqos:
You answered your own question. No offense taken.
[Magisk] Droiderat:
Here is the link to the ROM: https://www.sammobile.com/firmwares/galaxy-s7/SM-G930F/BTU/download/G930FXXS2DRAA/206979/

I have attached what I believe to be the boot.img (renamed from boot.bin). I haven't extracted a boot image before, so please correct me if I am in error.
[Magisk] space_eyes:
Bin and IMG files are way different.
[Magisk] RASTAVIPER:
That's kind of strange.

I have an OP3T with stock Oos 5.0.1 rooted with Boeffla kernel.

I am using Microsoft Launcher and Magisk for so long without any problems before.

And now, after latest upgrade to 16, all my icons from homescreen were removed, except the widgets. So no there is no call icon or messages icon etc.

Any ideas?
[Magisk] Didgeridoohan:
Install log? Magisk log? Magisk debug log? Logcat?

https://www.didgeridoohan.com/magisk/MagiskHelp

---------- Post added at 10:49 ---------- Previous post was at 10:32 ----------

You don't have to mess with mounting /system rw or ro.

The issue is rather with your Magisk image being mounted as read-only. This is known to happen on systems with a f2fs bug (/data formatted as f2fs), and then the solution is to format data as ext4, or find a custom kernel that fixes the bug, or use a Magisk module that works around the issue.

In your case though, I think it's a Mediatek issue and as far as I know there's no workaround for that at the moment. If this is the case, you won't be able to use Magisk modules currently.

You can check by running the following command in a terminal emulator and check if the image is mounted properly or not (feel free to post the output if you're unsure):

mount | grep /sbin/.core/img
[Magisk] Droiderat:
I never used the sboot.img file that I attached. I created it to respond to the request in the thread. When Magisk asked me to point to the boot.img file, I pointed it to "BL_G930FXXS2DRAA_CL12365438_QB16535120_REV00_user_low_ship.tar.md5", to which it responded with the log that I already posted ("extracting files", "unpacking boot image" and "stock boot image detected", among other things, before the modification of the boot image ultimately failed due to a "segmentation fault"). So, even if *I* can't extract the proper boot image, apparently Magisk can.

If you want to tell me how to extract the boot image (manually) from the BL file, I will do so and attach it. Thank you for your input.
[Magisk] doumer:
same issue here :(

reflash system and downgrade seems to bee the only option available.

also see here: we are not alone: https://xdaforums.com/pixel-c/help/android-8-1-magisk-t3719607/
[Magisk] :
Hi, thank you for your response,

I checked the link and it seems the right solution but I can't find a footprint code for my device, I'm on the S7 edge, do you have some footprints for it ?

Thank you.
[Magisk] chicato83:
That is the result.
[Magisk] callumbr1:
Anybody know where the ps remote play module has gone? Or how to get it? The don't framework is still there but I need the remote play module? Thanks
[Magisk] shakalaca:
Would you please try my test build ? :)
[Magisk] alfred04:
Hello good day,

The weekend I installed Lineage OS 15 with Android Oreo 8.1, I installed the version of Magisk v16.0 and when flashing it shows me an error.

I would like to know if this version (BETA) is compatible with Android Oreo 8.1.

Thanks for the help,

Nice day.
[Magisk] gothicVI:
Error log? In general it's compatible.

Gesendet von meinem Moto G 2014 LTE mit Tapatalk
[Magisk] alfred04:
The error when flashing is something like "updater process error 1 magisk"
[Magisk] Didgeridoohan:
I'm actually working on a little something like that. Should have it done in the next few days. Meanwhile I'd head over to the S7 Edge forum and ask if someone on a stock ROM could post the output of:

getprop ro.build.fingerprint

Then you can use that.

What Magisk version are you using?

You need to post an installation log...

https://www.didgeridoohan.com/magisk/MagiskHelp
[Magisk] Sam Nakamura:
That's the fingerprint of my wife's s7e...
[Magisk] chicato83:
There is a screenshot of the version of magisk that I'm using.
[Magisk] gewe:
Prepare rooted phone with TWRP and Magisk for OTA update install

Hello,

My phone (Motorola Moto G5S Plus, XT1805) has TWRP recovery (v3.2.1-r16) and Magisk (v16.0) installed. Phone is rooted, data partition is not encrypted. Android version is 7.1.1. Patch level is June 2017. There is a system update waiting, containing the October 2017 patches (and probably more updates after that).

What are the minimal steps to put the phone in a state where it can install the OTA update successfully, and get back to where it has TWRP, Magisk, rooted and unencrypted data partition, without losing any data? I know, these steps will of course include creating backups. :)

Would the following work:

Boot into TWRP and create backup of all partitions;

Use adb pull /sdcard to create a backup of data partition (as TWRP backup skips some parts of /data);

Uninstall Magisk and flash stock recovery;

Reboot phone (this will maybe encrypt data partition);

Install OTA update;

Reinstall TWRP and Magisk (decrypting and probably formatting data partition);

Boot into TWRP and use adb push to restore contents of data partition.

Would this work, or am I missing something?
[Magisk] siavash79:
It worked! Just out of curiosity what's wrong with the original build?
[Magisk] Didgeridoohan:
In that case your Magisk image can't mount at all. Like I said, for now there's likely not much to do about Magisk modules on that device.

Be careful restoring a data backup from a previous android update. Can cause issues. Other than that it looks like it might work, although it does look like a lot of work... Do you really need /data to be unencrypted? Would be a lot easier if you didn't have to wipe to decrypt. That's the only step that should cause any loss of data... That's not saying you shouldn't make a backup. Always have a backup. :p

The only prerequisites to update through OTA is a stock recovery and boot image, and an untouched /system partition.

---------- Post added at 20:29 ---------- Previous post was at 20:27 ----------

Typo... :D
[Magisk] chicato83:
I'm so sad to know that.

Thanks so much for your help. I hope that they work on it soon.
[Magisk] Wolfcity:
And remember that even a r/w mounted system partition can be a "touched" one. There are several ways to change tiny things on system. For me only reflashing complete stock worked in the past to apply OTA.
[Magisk] shakalaca:
Here the PR: https://github.com/topjohnwu/Magisk/pull/377

When unpacking the boot.img of Chrome OS there will be no 'kernel' file but a single dtb image in output, the re-writed 'magiskboot' only adds the dtb image when kernel image is available, so the repacked boot image won't have kernel image and just a ramdisk inside it, leading to the 'soft bricked' device.
[Magisk] yochananmarqos:
The module is where it always has been. Do you even search, bro? :eek:
[Magisk] vMAC:
Still can not install any modules with this. I have just updated to 15.6, I am using a Pixel 2XL.

Here is the log:

https://pastebin.com/aH3ziV3c

Someone in the other thread mentioned that I should try the F2fs workaround, however that failed as it states that my phone doesn't have a cache?

Any help would be appreciated.
[Magisk] Computoncio:
Your typo fix worked like a charm in my daughter's ZenPad Z380M tablet.

V16 didn't patch the boot img right, your version does.

Thanks for you hard work :good::fingers-crossed:
[Magisk] siavash79:
Perfect! I hope topjohnwu knows about this for his next releases. (is there any way to mention someone in the post, say like @ or sth?)

Now that you know about the stuff, can you suggest the below points?

- my pixel 2 xl (taimen) gives me dtbo warning message after every boot. Is it normal or I'm doing something wrong? because I guess the whole magisk concept is to hide the root from the system

- pixel 2 xl OTA update fails every single time even after I restore the boot image as instructed. I have to download the full factory image every month (doesn't even download the OTA, gives me "could not download" error, tried with different IPs and VPNs)
[Magisk] gewe:
Not if I can easily access it with adb (push/pull/shell) when it is encrypted.
[Magisk] DeKiesel:
Does anybody know how to downgrade to 15.4 from 16.0? Can I just flash the zip?
[Magisk] Ja_som:
For sure, restore boot image and then flash 15.4.
[Magisk] DeKiesel:
That means dirt flashing my rom, right? Or does magisk have an option to flash my old boot rom back?
[Magisk] Ja_som:
You have 3 options here, dirty flash your ROM, extract boot image from ROM package and flash it separately. Or when you open Magisk Manager, press uninstall and then Restore images, or Complete uninstall (everything related to Magisk will be erased (settings, modules, ...))
[Magisk] DeKiesel:
The in-magisk method worked perfectly, thank you!
[Magisk] Didgeridoohan:
He knows... Or at least he will when he's got internet access.

I'm not that familiar with the Pixel devices, but I believe you can get rid of the dtbo message by enabling "Preserve AVB 2.0/dm-verity" when installing Magisk.

Shouldn't be any issues... Also, that's very easy to test before going through the whole hassle of decrypting and restoring data.
[Magisk] braschlosan:
Continuing my previous post, I uninstalled the xposed installer app and clicked the trash icon for Xposed inside the Magisk module list and rebooted. Then once I verified both were removed I booted into recovery and installed xposed. Now the Installer app cannot see the framework!
[Magisk] Didgeridoohan:
Are you 100% sure you're using a Xposed installer that's been modified to detect a systemless install. In other words, not the official one...
[Magisk] Bogdan010:
Here you go: https://xdaforums.com/xposed/unofficial-systemless-xposed-t3388268/amp/
[Magisk] Ham3dt:
I've magisk 16 installed, sometimes when i unlock my phone it shows a massage;

"magisk stoped working"

here's what was in magisk log:

02-27 12:49:46.618 359 557 I Magisk : proc_monitor: com.google.android.gms.unstable (PID=30170 ns=mnt:[4026547342])
[Magisk] DragonSpitz:
I have an issue on latest Magisk v16 (also happened on older versions too)

Issue is that even after Magisk installed, for some reason at particular time, the notification appears as "New Magisk update available". And when I opened Magisk manager, it shows Magisk not installed and prompting to install Magisk.

Temporary fix is that, I need to reboot each time to get it fixed, but after some hours, the above issue happens again.

And I don't know when the issue happens, so I can't take a logcat of it.

Device: Lenovo Vibe K5 Plus[A6020a46]

Android version: 5.1.1 Lollipop with VIBE UI [Stock ROM]

Magisk Manager: 5.6.1 (105)

Magisk version: v16
[Magisk] Didgeridoohan:
That is just MagiskHide doing it's thing to hide from SafetyNet... It should have nothing to do with Magisk crashing.

You would need to grab a logcat of the crash to know for sure why it's happening.

This one pops up from time to time, but I've yet to see anyone giving a definitive answer as to why it happens. It could be a too aggressive battery saver, background process killer, etc, or something completely different... Without some kind of log, no-one knows.
[Magisk] DragonSpitz:
I excluded on Greenify and system built-in saver.

About the logcat, no idea when it happens, for me it's every morning, today afternoon it's shown.
[Magisk] Selmak:
I'm having the same problem. I followed the prompts, but it failed to reinstall. I went through this process 5 times, and it failed every time. So I came here looking to see if anyone else was having this problem, and I saw your post. So following your advice I rebooted, and now magically it shows that it actually is still installed. So this bug in version 16 is reproducible across different devices. I have a Moto G3 2015 model.
[Magisk] DragonSpitz:
Ok then, I do remember happening on the previous Magisk, older ones have no problem.
[Magisk] Lownita:
Is there a working method for uninstalling or disabling a magisk module from twrp? I tried this module, but it didn't work for me.
[Magisk] Artim_96:
Mount the image and remove the folder.
[Magisk] braschlosan:
To make sure I uninstalled the current one and then used the apk attached to this thread. https://xdaforums.com/showthread.php?t=3034811

Xposed is still not functional
[Magisk] Didgeridoohan:
https://www.didgeridoohan.com/magis...agisk_functionality_bootloop_loss_of_root_etc

Well... If you reread my post again, I wrote

not

the official one. That's the official thread, so that won't work...