yashsingh1/xdaforums huggingface dataset:
[Magisk] DB126:
Wait - does clean flashing mean I will loose my progress on zoom-zoom mega monster 101 that defines the essence of my life?? Priorities, man, priorities!!!

Wait² - backup? Whaaaa?? :rolleyes:
[Magisk] RandomPooka:
Probably not, considering how Play Store and Play Games keep many game saves in ye olde cloud. But, good luck explaining that to people.
[Magisk] ilarson007:
I also cannot install Magisk on the latest Android build for the Pixel 3 XL (PQ1A.181205.006; December update). Maybe I'll try rolling my phone back?
[Magisk] mperezm77:
I have the same behaviour just after I upgrade my Lineage ROM

I tried uninstalling Magisk and installing again but no luck.

Also, when I boot the phone and enter the Magisk manager it gives me the possibility to just patch the boot image, but when it tries to patch it an error occurs. "Not possible to unpack the boot image"
[Magisk] jcmm11:
Logs? What happens when you try to install? I'm running the current Canary build on the 3 XL with no issues. I believe that topjohn is using a 3 XL as his development device.

You should definitely be able to install to a 3 XL, but just stating 'is boken, halp me' doesn't help anybody, including you.
[Magisk] ilarson007:
How do I take logs? There was no error when I installed it. I temporarily booted to TWRP and flashes the v18.0(18000) build.

It says "done" when finishing flashing. No errors.
[Magisk] Didgeridoohan:
Without looking at the recovery log no-one can say anything about what happened...

https://www.didgeridoohan.com/magisk/MagiskHelp
[Magisk] ilarson007:
Hence I asked how to get the logs.

However, when I went back to get the log, now it just worked. So IDK what happened.
[Magisk] martyfender:
If it uses Sony ELF format boot.imgs, you must use Boot Bridge in TWRP to flash Magisk. There could be other ways, but I suggest that you consult in your device forum.

The just recently updated Boot Bridge now supports Magisk v17+.
[Magisk] FMXP:
Is anyone else having trouble installing Magisk (any version) on Oneplus 5T with Oxygen OS 9.0.1? I upgraded from 5.1.7 Oreo using the recommended method through TWRP. Pie is fine and boots normally. But I cannot install any version of Magisk. I have tried both 17.3 and 18.0. It always goes through the steps in TWRP like normal and everything looks fine, then I reboot into Android and there is no Magisk Manager and no Magisk and no root. I've searched and searched and I haven't found anyone else with this problem. Does anyone know why it looks like Magisk is installing but isn't there when rebooting into Android?
[Magisk] FMXP:
Thanks for the useless and non-helpful response.

For anyone who cares, since I was under the impression this is the support thread and not the smug non-help thread, I was only finally able to fix this by doing 2 things. Hopefully this helps out my fellow Oxygen OS users here.

(1) Install the latest Canary, not Beta/Stable build. The Canary builds aren't easy to find either, the thread in this forum doesn't link directly to them so I will here.

https://github.com/topjohnwu/magisk_files/tree/master/canary_builds

What fellow Oxygen OS users will want is magisk-release.zip. Apparently latest Oxygen OS OTA's do weird things with Magisk and I only happened upon this solution by looking at the dev's Twitter. I don't have a Twitter account and I don't follow people around on Twitter so I was not aware that I should now check his Twitter for the latest information.

(2) Reboot to Android after flashing Magisk in TWRP. Then, from Android immediately reboot again into Android. I don't know why a second reboot makes Magisk Manager appear when it doesn't on the first reboot. The only reason I thought about this was because in previous Oxygen OS builds rooted with Magisk for the first time, WiFi would not work until you rebooted twice. Oxygen OS is weird.

Now I have Magisk again. Upgrading from Oreo to Pie on my 5T took almost no time at all. Chasing this solution down for Magisk took up my whole day.
[Magisk] martyfender:
I am glad you got it solved but with your entitlement mentality, no one here will want to help you.

When you joined xda you agreed to search before asking. A basic requirement in all of these magisk threads is to post logs. That includes install logs, magisk logs and in many cases, logcats.

Logs are a basic requirement on all of these Magisk threads, even this general thread, even if it is not explicitly stated.

The above is from the stable Magisk release thread.

What do you mean, not easy to find? The root Magisk thread lists most Magisk and module related forums. It comes up as the first page in search results in my Linux desktop web browser.

https://xdaforums.com/apps/magisk

It is not that hard to find, contrary to what you stated.

If you want specifics for your device I would suggest looking in your device specific forums.

Many, as I do, try to help users in our own free time. Ungrateful users, such as yourself, are better off finding help elsewhere, outside of xda.
[Magisk] anotherxdauser:
Sorry, I don't understand what you're getting at.

The app worked before as MagiskHide was hiding root. But very recently, it seems they changed the app and now it knows my phone is rooted.
[Magisk] ktmom:
Did you read through the linked document? There is comprehensive information about what things influence the hide functionality and what things might trigger hide not working. For example, some modules might cause an app to find root, or having usb debugging turned on. Or the use of the Canary build might be more effective for you.

All you have to do is read the document.

"find somebody that you think is undeserving of your compassion and give it to them" - Christian Picciolini
[Magisk] abdoh01:
Hey guys i have a problem with magisk v18 every time i flash through twrp or magistick manager get bootloop so i have to flash v16.7 The latest stable version in my phone and then flash v17.3

My phone is lg k10 (k430dsy) android 6.0

I hope the problem will be resolved soon
[Magisk] guest4711:
How anyone should fix it without proper logs? Do you really expect the developer has every phone for testing?

BTW: Did you try to disable all modules before restarting? There are a lot of modules for older versions for Magisk which do not work properly with newer ones (but for most of them updates are available).
[Magisk] soder:
I got a problem I think you guys in here might know what I shall do with.

I got a pretty new OP6T. A couple of days ago I installed TWRP (flashed in fastboot and then a installer .zip) and then rooted with Magisk 18. Worked well.

Today I got message about an update for the system. Since I used root it said something about that and just like I used to do on my OP3T I went to the .OTA folder and copied that file to my /download folder and went to my TWRP recovery. The file was about 1.6GB then the full ROM.

I flashed it and also Magisk 18 .zip and rebooted the phone.

After boot Magisk isn't installed and when I with the power button to reboot to recovery, I come to the default recovery, not the TWRP.

What have I've done wrong? Thanks for help.

/Söder
[Magisk] ktmom:
The OTA replaced the boot.img with a stock one which contains the stock recovery and never contains root. You will have to reinstall both TWRP and root.

You should read through your device forum to better understand how much had changed between a OP3T and the OP6T. They are completely different.

"find somebody that you think is undeserving of your compassion and give it to them" - Christian Picciolini
[Magisk] guest4711:
Probably the zip contained the recovery too. So reinstall TWRP again, then Magisk (same procedure as described by you - same procedure as every year ;) )
[Magisk] jcmm11:
The 6T is an a/b device. They're "different" from what you're used to.

Start here https://xdaforums.com/oneplus-6/how-to/guide-noobs-guide-to-b-partitions-op6-t3816123

For OTA how-to look here https://topjohnwu.github.io/Magisk/tutorials.html

(Also, FWIW, topjohn recommends not flashing TWRP to the phone and just booting the image via flashboot when necessary)
[Magisk] abdoh01:
Ok you have point but there is no logs for bootloop

cause to open the phone i must flash stock rom

And i will try to disable all modules and see what will happen

Thanks for your response
[Magisk] soder:
OK, because sometimes when the update wasn't uploaded to the oneplus.net I've done like this before on the OP3T. Used the file in .OTA and then flashed Magisk after and still got the TWRP.

EDIT: OK, now I've read the links. Great links BTW. So basically I lost my TWRP this time because it's got overwritten, like it didn't was before.

And now with a A/B-devices, I can actually use the system update system, like I didn't really could before with my OP3T and I had to do it manually in TWRP and then flash Magisk again.

Let see if I understand it right now then:

I've turned of that the phone shall do anything automatic except doing the download. When I get the info about a new update, I start Magisk Manager and with the uninstall button restore images.

I then use the system update function in the OP6T and install the update on the phone. After that I go back to Magisk Manager and with the Install button pick an option "Install to Inactive Slot".

After that I do a reboot from the Magisk Manager and after that it shall work.

Questions: Have I done anything wrong now when I flashed the OTA .zip in TWRP? Have I done something with the A/B-partition that will cause a problem for the next update?

Also, shall I flash the .zip again, and then the Magisk .zip and don't do anything with TWRP this time? Is that better? Or shall I just let that be to the next time? The flash of TWRP isn't that I've done anything to the /system ?

Thanks for great support and help.

/Söder
[Magisk] tom1807:
I think you have to clarify this a little bit more. I am pretty sure (so far) that if my OnePlus3T is updated to Pie, it stays on the same kernel version 3.18.66, which was included in v5.0.8. Following your statement it would mean that my OPT3 could never use v18.

If you refer to the requirement of Kernel v3.8 for A/B slots, then it was not 100% clear.

I also have the problem that SafetyNet fails for me, however I can't get a log file from my mobile (yes debugging is enabled) but ADB cannot get authorized on my mobile because error message: "Because an app is obscuring a permission request, Settings can't verify your response"

But that's not for this topic to resolve this issue. I just mentioned it, because my Magisk Manager Log is empty, so the topics in https://www.didgeridoohan.com/magisk/HomePage are not helpful for me.

Cheers

Tom
[Magisk] ktmom:
If you want to use Magisk hide, the kernel must be 3.8+ and logging must be enabled. If the Magisk log is empty, that's a problem. And all of this is discussed under Magisk Hide: Basics on the page you linked.

"find somebody that you think is undeserving of your compassion and give it to them" - Christian Picciolini
[Magisk] :
I got a problem. My Google Pay app doesn't work. I got magisk v18 with 2 modules: "universal safetynet fix v3-beta1 (magisk v17 fix)" and google face unlock. When I check the status it shows the two "ctsprofile" and "basicintegrity" as true both. In magisk hide, I selected "Google Pay" and "NFC service" apps, but also without their selection it isn't still recognized by a pos. Now, I'm really sure my payment card works, my bro one with a phone unrooted works fine.

How should I do for make pos recognize my LG H815 rooted Gpay?

Sorry my bad english

p.s. I haven't any xposed or similar installed.
[Magisk] moktadir:
Patched boot.img doesn't work on OnePlus 6 update 9.0.3. Updated using usual methods (I've done this half a dozen times now), but on reboot starts up to normal lock screen, but then immediately reboots to stock recovery. I've tried both flashing the patched boot.img and simply booting from it, both lead to recovery loop. I don't have a custom recovery installed, if that's relevant.

---------- Post added at 12:39 PM ---------- Previous post was at 12:35 PM ----------

I then reflashed stock boot.img and everything works fine after, just no Magisk, and CTSProfile registers false for some reason.
[Magisk] tom1807:
I would really appreciate if you could link me to a changelog or a statement where is written that Magisk Hide/Magisk Manager needs Kernel 3.8+.

So far all "official" pages (Github, this forum, the above linked page) don't write this.

I see as only "reference" in the start post that

.

Due that I have an older kernel on my OPT3 and the problem showed up recently a few days ago, I still doubt that Kernel 3.8+ is mandatory like you state.

And yes, I read all what is written on the page and logging is enabled, so the only thing what shows up is a log after running the SafetyNet check, but the dates writing in it are from October 12, 2018 and only the ones from SafetyNet are todays date.

Logcat, as written above, cannot be pulled by ADB from my device due the device stays unauthorized (makes me wonder whether you read the post or only give a standard answer which I know already).

Cheers

Tom
[Magisk] jenslody:
Your searching (and reading ?) skills seem to be not so good ;).

The first sticky thread in the Magisk forum states it.

Sometimes you have to open "hidden" stuff, just click on the second "Click to show content" button.
[Magisk] Luniz2k1:
Announcement thread for Magisk

https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445
[Magisk] megabass2:
Hi, can I go from v18 to v16?

Just flash the v16 or do I have to uninstall v18?
[Magisk] Didgeridoohan:
[MENTION=6617276]ktmom[/MENTION] and [MENTION=628957]tom1807[/MENTION], I don't know why you're discussing the kernel v3.8+ requirement. The OP3T has a kernel version of 3.18+ so it's all good. 18 is a higher number than 8...

And, [MENTION=628957]tom1807[/MENTION], your issue with authorising ADB is likely because you have an app drawing an overlay, causing some security features like that kicking in. And an empty Magisk log is actually covered in my guide, right here at the bottom: https://www.didgeridoohan.com/magisk/MagiskHide#hn_The_Magisk_log_is_empty
[Magisk] shami_n:
Lookout app detecting root and repackaged mm is identified as a threat

Hi,

I had installed latest Magisk stable v18 and Magisk Manager v6.1

I'm on Android 6.0.1 custom rom.

Lookout app is detecting root though I had enabled Magiskhide. I also tried the core only mode.

Is there anything else I could check to hide it?

Also when repackaging with random name (Manager), lookout idetifies it as a threat. With the original name it is fine.
[Magisk] cogelindo:
hello I'm on Dev base December in my note 8 950F. I have installed magisk v 18, one I can't pass safetynet. someone else with this problem?

EDIT: yo desinstalé Xposed, y todo volvió a la normalidad
[Magisk] tom1807:
I read it, I let FF search, the only reference I find is

But as I said, my OnePlus3T is on Kernel 3.18.66 and since 2 years, MagiskHide always worked, so I still stay with my statement that 3.8 is not mandatory if it is already backported (which is obviously the case for my device).

For now, I pass SafetyNet (ctsProfile: true, basicIntegrety: true), however, in between 30 minutes to 1 hour it fails.

First I thought maybe installing Magisk v18 through the Magisk Manager was the problem, so I installed it again through TWRP, it passed, 15 minutes later it failed. I rebooted, passed, 20 minutes later it failed.

Then I repacked Magisk Manager to a new name through settings, with a random name, SafetyNet failed, so I was running SDMaid, which deleted 2 files from the previous MagiskManager folder, then SafetyNet passed.

However 20 minutes later it failed again.

I noticed that Google Play gave me a notification on the lockscreen, first time it was checking for updates for Android Wear, then a second notification stating "Downloading security information". It's only a hunch, but I believe that Google stepped up the game in detecting MagiskManager and downloads information in the background which causes SafetyNet fail.

Still have GooglePlayServices 14.7.99 (released Nov.30, 2018) installed and GooglePay (released December 18, 2018)

Don't get me wrong, I have no problem in believing that Kernel 3.8 is preferred, but I have a problem with a statement which implies that 3.8 is necessary when in my case an older kernel is also fine if backported. Titanium Backup would be the first app which complains if mountspace is not correctly implemented like I experienced with SuperSU before I switched to Magisk.

I use now Magisk since v12, it failed for me one time in the past with v17, which was fixed in an unofficial build and since then all was fine., until December 31, this was the first time I could not use GooglePay.

And of course, Murphy's law is now kicking in, where I hoped that SafetyNet fails to have something in the Magisk log, but no, it passes :rolleyes:

Cheers

Tom
[Magisk] tom1807:
I apologize for my rant, for some reason I was blonde and thought after 3.8 < 3.9 <4.0, I didn't think in 2 digits :silly:.

So please forgive my stubbornness for "insisting" that 3.18 is lower than 3.8, in my mind was 3.8 = 3.80.

As for the overlay, thanks for helping, already found this hint and disabled on all apps, still no joy.

Cheers

Tom
[Magisk] akxak:
On my OP 6 with OOS 9.0.3 and Magisk 18, Magisk Hide seems to be completely broken... SafetyNet returns false and apps (like Google Pay) refuse to work. That changed exactly when I went to 18.0 from 17.2, with 17.2 everything worked.

Anybody has a short how-to to downgrade back to 17.2

The separate thread on banking and other apps not working anymore scrolled back and did not receive any helping answer.

Thanks.
[Magisk] martyfender:
Also, when I type in the terminal from my Linux Mint PC:

adb shell
su

I get a Magisk root prompt on the device to allow the shell root access, first time. Since he doesn't apparently have root access, maybe that is why he is getting those messages, also?
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] recently posted on his twitter feed about how manufacturers are using aggressive battery optimization techniques. From the provided link click on Oneplus for info on what you could try to turn it off.

https://dontkillmyapp.com/

Furthermore, I'm not sure if this was asked, but is the Magisk Manger on internal storage and not adoptable storage?
[Magisk] jenslody:
It does not work on external/adoptable storage.

That's the cause why MagiskManager sometimes believes Magisk is not installed (on new install or after repackaging).
[Magisk] martyfender:
Yes, if it was not clear, that is what I meant.
[Magisk] tom1807:
Thanks for the link, will try.

MM is installed on internal storage, never saw the option for adoptable storage.

Cheers

Tom
[Magisk] martyfender:
From what I read there, battery optimization may get turned back on after a reboot for Oneplus devices.

What is am suggesting is removing the Magisk Manager from battery optimization, however it is possible other apps may effect this, also, but I am not sure of this?
[Magisk] MashaSantiago:
How to use Magisk mods

I'm new to Magisk and have noticed that some mods have icons that allow you to access the mods whereas others only appear in Magisk. Do the ones that appear in just Magisk auto run? For example, Mic Fix, App Systemizer, and EmojiOne are installed and turned on but there are no icons to access them. Is the Mic Auto Fixed? Do the apps auto-systemize? Are the Emoji's replaced? Any help/advice would be appreciated! Thank you!
[Magisk] tom1807:
I read it also on the link you provided, will keep that in mind and pay attention to that.

Hope its just a glitch in OPT3, but I selected in Battery Optimization for MM don't optimize, however when I go into the apps listed in Settings and check from there Battery for MM it states Battery Optimization in use. :eek:

Cheers

Tom
[Magisk] jenslody:
Most modules show a (more or less) short explanation when you click on them in the download section.

Terminal app systemizer e.g. needs to be called from a terminal (as root).
[Magisk] pol-der:
Hi XDA members and [MENTION=4470081]topjohnwu[/MENTION] . I am using Magisk since months and happy to use this because open-source. Also i am using some Magisk modules like CloudflareDNS4Magisk, DNSCrypt-Proxy 2, Xposed Framework and Youtube Vanced. I am not expert or Android Developer. For this reason i was searching more information about Magisk and Xposed because some developers are saying they are breaking stuffs and adding security holes. I encountered with this link and as i understand we shouldn't use Magisk Modules and Xposed because of adding security holes.

I have some problems. If possible could you please answer these for us?

1) If security holes issue is true could you please explain how it is adding which security holes? If not, could you please explain or prove this?

2) Do you examine every Magisk module for security? I mean do you review whether each module harms the system or creates a security vulnerability? Or does anyone upload their module and nobody is looking?

Thanks in advance.

Kind Regards.
[Magisk] martyfender:
I just recently added App Systemizer. First of all, only systemize apps that will benefit from it such as Greenify. There is no extra benefit to systemizing most apps. Greenify has extra function when it is a system privileged app. Second you need a terminal app installed. Here is a good one from the many listed in the playstore:

https://play.google.com/store/apps/details?id=jackpal.androidterm&hl=en_US

You launch the terminal, type su, enter, to gain root access, then type systemize to see all of the options, 1 is to show a list of installed apps.

You then select an app from the list by typing the number then finally choose whether it should be a system app or a system-priv app.with 1 or 2. Once systemized you must reboot for the changes to take place.

I only have Greenify systemized, because it has extra functionality doing this. Plus the Greenify4Magisk will no longer be developed due to a few ungrateful users that frustrated the author to the point of stopping development.

Any other discussion of this should be addressed in the dedicated thread for the module:

https://xdaforums.com/apps/magisk/module-terminal-app-systemizer-ui-t3585851
[Magisk] jcmm11:
There's a big difference between Xposed and Magisk. It seems you read the first post and then stopped. You missed this:

Most Magisk modules are completely open, if they include an apk it's usually one available from somewhere else. So you (or anyone) are free to look at what the module is doing. There's very few modules which modify core system components. (One I can think of is the Edge Sense module which replaces the SystemUI apk. The changes it makes are specific to the Edge Sense app)

Xposed is an ugly hack (IMNSHO) which has the potential to break all sorts of things, which is why developers routinely dismiss bug reports which involve Xposed.
[Magisk] martyfender:
Yes, it does break all sorts of things. I used it in the past on my previous device. It led to system instability, frequent reboots, system ui crashing frequently, high cpu usage and poor battery life. Using the xposed uninstaller also did not fully return the system to it's previous, good state. Only reinstalling the rom solved the issues that it caused. The features that it provided were not worth the can of worms that it opened up.

That said, apparently it works well on many devices, if you don't need safety net to pass.