yashsingh1/xdaforums huggingface dataset:
[Magisk] simplepinoi177:
Lol! You are definitely right about that! Coming from Odin and one-click rooting and "dirty flashing" and only installing Full Factory images as last resorts that wipe everything out to "Bootloader" and "fastboot" and this (Magisk rooting) and flashing Full Factory images is actually the best method and you merely have to delete 2 characters from the code to not wipe anything!!!

What a learning curve that was....:silly:
[Magisk] davidzam:
What is this? Sorry I don't understand.

Enviado desde mi SM-G550T1 mediante Tapatalk
[Magisk] Strephon Alkhalikoi:
"Taimen" is the code name for the Pixel 2 XL.
[Magisk] avaholic:
Hello Didgeridoohan,

I believe when I installed Magisk-v16.0.zip I unfortunately clicked 'install Magisk as a system app' as I did not realize that was the incorrect way to install it.

Is there a way to remove root without having to totally wipe my phone? I've already tried using the Magisk Manager 5.70 app to uninstall and I also tried using the Magisk-uninstaller-20180429.zip in TWRP which failed with an error 1. Advanced Root Checker still shows I have 'SuperUser Binary, SuperUser Exists, and Root Native.'

I need to update my OnePlus 5 to the latest OpenBeta but don't want to cause a bootloop so I haven't even attempted it yet. Step 3 is where it failed obviously...

__________________________

Based on the following:

************************ For Unlocked Users with TWRP Recovery Method 1************************

Download the required files from Post 2

Once you have downloaded all the required files on you device, please follow as below

1. Need Codeworkx or Blu_Spark TWRP

2. Reboot Recovery and Take a Nandroid of your existing ROM just in case you need it

3. Flash Magisk Uninstaller

4. Wipe > Advance Wipe > Select Dalvik & Cache > Swipe to Wipe

5. Install Menu > Select OOS Open Beta Full Rom Zip > Swipe to Flash

6. Flash Magisk 15.3 to maintain root & Wipe Dalvik & Cache once done

7. Reboot System and Enjoy OOS 8.1 without any data loss

8. Upon Reboot Open Magisk Manager & update the Manager App and Magisk 16.0

PS: Some users reported bootloop flashing Magisk 16.0 thus i recommend flashing 15.3 and later updating it in OS.

The Device will reboot and OnePlus 5 is now running on the latest OxygenOS Open Beta firmware & OS based on Android Oreo 8.1.

__________________________

Any assistance you can provide would be most appreciated!

Thanks,

Avaholic
[Magisk] Didgeridoohan:
[MENTION=348580]avaholic[/MENTION] If you look back in the thread, starting from the post you quoted and maybe 10-20 posts, you'll find a solution. You'll just have to remove the Manager from system. Can be done manually or with apps like Titanium Backup.

I update my OP3T by just flashing the full update zip and then reflashing Magisk. There's usually no need to uninstall Magisk first...

I'm curious though: where did you choose "install as a system app"? That's not a standard Magisk installation...
[Magisk] avaholic:
LOL. To be perfectly honest, I don't remember. Maybe I'm thinking of my OnePlus One which I just replaced with this 5 last week. DOH!

Is this the post to which you are referring?

https://xdaforums.com/showpost.php?p=76799326&postcount=25229

Looking in '/System/priv-app/' I no longer have any Magisk folders.

But if all I have to do is flash the OnePlus Open beta zip on top of the current one (going from beta 11 to beta 12) and then flash Magisk again. I guess I wont have any problems. I wonder why those instructions say to uninstall Magisk first before installing the openbeta? I do have a full backup.

Thanks!
[Magisk] Didgeridoohan:
It's easy to verify if you have the app installed to system or not. Go to app info, and if it says that you can uninstall it, it's installed as a user app.

The instructions probably come from the fact that there sometimes have been issues, especially with the beta OOS releases. If you experience issues you have your backup... And if you do need to uninstall Magisk with the zip, use this one, until [MENTION=4470081]topjohnwu[/MENTION] release a new one with a fix for 64-bit devices: https://github.com/topjohnwu/Magisk/releases/download/v16.3/Magisk-uninstaller-20180328.zip
[Magisk] avaholic:
Well, I had no Magisk app in the all apps list either so I'm not sure where Magisk itself was but that older uninstall zip you listed worked perfectly. Thanks! I'm now on beta 12 with no data loss.

Were those the correct removal instructions from /System/priv-app? If not, would you please point me to the correct post in case it's needed in the future?

Thanks for the help!
[Magisk] fmotta:
Thanks for your work...

Did someone already pointed out that all Magisk version give a bootloop on Xiaomi Mi Mix 2s Miui Global Version?

This is happening on XE models which are the China ones.

Strangely, if flashing old SuperSU (latest version available) everything works flawlessly and root is acquired.

Any suggestions?

Thanks in advance for your help.

Inviato dal mio Mi MIX 2S utilizzando Tapatalk
[Magisk] Cogor:
Sorry but when will the stable 16.4 be released?
[Magisk] Tecalote:
When it's stable :)

Just be patient!
[Magisk] jcmm11:
Maybe never. ?16.4 is a beta. My guess is the next release will be 16.5 beta. Topjohn is done with his military service so I suspect we'll see something relatively soon, but there's still a number of issues that need to be resolved (based on comments in the threads, personally it's running fine) so it wouldn't surprise me to see another beta, or two, before the next stable release.

In any case the next stable release will come when it's ready. Patience will ultimately be rewarded ?
[Magisk] fifo_thekid:
I have a Brazilian Moto Z Play with Oreo and latest security updates.

I unlocked the bootloader and proceeded to installing Magisk 16.4 and and the F2FS loopback bug workaround, but I'd always get a bootloop even after applying the commands:

echo KEEPVERITY=true>>/data/.magisk

echo KEEPFORCEENCRYPT=true>>/data/.magisk

After uninstalling Magisk everything would start working again as expected

I have attached the logs copied right after installing Magisk.

Btw, I'm a systems developer and I can easily edit and debug the code of Magisk if you want
[Magisk] keedesu:
Hi everyone,

I recently had my brother's Samsung Galaxy J5 (SM-J500H) rooted with Magisk installed.

Now he's been trying to play the game "Naruto X Boruto: Ninja Voltage" and it keeps on giving the error:

"This app will be terminated because a security policy violation has been detected! [Code: 00000034]" at startup, despite being ticked to be hidden on MagiskHide.

Did a SafetyNet check, ctsProfile and basicIntegrity are both true. Also tested MagiskHide if it works via RootChecker, and it does work - just not on this particular game.

I've tried setting up the MagiskHide Props Config module by Didgeridoohan enabled and did the "Improve hiding" option, still to no avail.

The phone is running on Android 7.1.2, with Kernel version 3.10.107.

I am running out of options. Also trying to be really careful here as I'm not very experienced in this field. Help would be greatly appreciated. Thank you very much.
[Magisk] Didgeridoohan:
The Magisk Manager likely got uninstalled during your previous attempts. Which in turn means it never was installed as a system app.

That would be a correct way to uninstall it, yes, but as long as you only install Magisk through zips you get from [MENTION=4470081]topjohnwu[/MENTION]'s GitHub or the release thread, you won't end up in that kind of situation.

Hm... Don't know... There's been a couple of improvements to Magisk since v16.4, that hasn't been released just yet. You could try an unofficial snapshot, but beware that it's just that, a snapshot of the current code. There might be other bugs...

By the way, does the device boot without the f2fs loopback module? Or if you enable Core Only Mode? Do that by placing a file named ".disable_magisk" (without quotation marks and with the leading dot) in /cache.

And if you have a magisk_debug.log in /data/adb, attach that to your next post.

You should also try to hide the Magisk Manager. More hiding tips here: https://www.didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps
[Magisk] eliezerjk90:
Btw just curious, is there any plan to officially support custom rom that is treble compliant? I use redmi note 4 (mido) with LOS 15.1 (treble rom) and up to this point I have to use unofficial modified magisk. It would be great if it is supported officially.
[Magisk] keedesu:
Thanks for the reply! Tried hiding it, and two Magisk Managers appeared on my App drawer. Is that normal?

I also did everything in that link but the game still detects root. There are no other root apps installed in the phone as it's been newly reformatted.
[Magisk] Didgeridoohan:
And one of the Managers doesn't disappear when you've opened the Manager?

That usually means you're using a ROM that installs Magisk by default and makes the Manager a system app (which is a huge mistake by those ROM creators). If that's the case, it completely breaks the hide Manager feature and you can't use it until you've uninstalled the Manager that's installed to /system.

It's actually been discussed several times over the past few days, you'll find more info if you look back in the thread.
[Magisk] callihn:
OK, got it recorded using Catlog, hopefully this helps...

LG K7 ms330 stock rom debloated and stock kernel.

Android 5.1.1

Kernel 3.10.49
[Magisk] pimser:
hey

after installing 16.0 via twrp red wolf im not able to turn on WiFi anymore. can you help me? redmi 5 plus user

thanks
[Magisk] jenslody:
If you use stable Magisk, you should try the 16.4 beta (runs fine on J5), because it has improved hiding methods for subprocesses.
[Magisk] anos21:
Same here with op5T. All LineageOS 15.1 nightlies from MAY-28 and onwards shows the same behavior. Any news/solutions?

There is a ticket "REGRESSION-1950" pointing at Magisk. Checked the LineageOS changelog for MAY-28 nightly and there are some kernel and device changes common to op5 an op5T. Could be a clue. Really like Magisk so would be really appreciated with some guidance if there is a workaround. Sorry, not allowed to post links to the ticket and the changelog.
[Magisk] Didgeridoohan:
Looks like an issue that's already been fixed, but not yet released. Wait, build yourself or use one of the unofficial snapshots available in the forum.

If you keep looking thorough the thread you'll find that it's been discussed a few times and has likely already been fixed. Just not released yet. Use a LOS build that works,wait, build Magisk yourself from the current code or use one of the unofficial snapshots available in the forum.
[Magisk] keedesu:
Exactly that.

Although I've tried hiding Magisk before this, I had the problem of not being able to unhide it, despite having the Unhide Magisk Manager app to do so. I fixed it by reflashing the ROM and starting all over again. To conclude, hiding the Magisk app itself also did not get Magisk Hide to work on the game either. I will take note of changing the ROM itself, since I have a friend with a ROM from the same creator, and the game also won't work on his rooted phone.

Thank you, I'm currently on the process of testing this out. If this doesn't work, I'll change to a different ROM and see if that does it. :)
[Magisk] kmem:
I've seen it mentioned several times but magisk > 14.3 doesn't work on secondary ROMs under multiROM. Are there any plans or workarounds to remedy this?
[Magisk] Wolfcity:
[MENTION=4470081]topjohnwu[/MENTION]: Congarulations, you did it. https://twitter.com/topjohnwu/status/1005089007359819776?s=17

I'm sure that was a hard time for you but you know:

What doesn't kill you makes you even harder.

Good to have you back.
[Magisk] :
It seems like he did not update his status.

Check screenshot below.

Anyways, good job and welcome back [MENTION=4470081]topjohnwu[/MENTION]!
[Magisk] FriendlyNeighborhoodShane:
Hi dev! Awesome work.

I'm not sure if there's a right thread to ask this, but I have been experimenting.

I use my own custom scripts for Magisk flashable zips (many of them based upon osm0sis's work), and i wanted to know if there is a way to automatically get installation logs for troubleshooting.

I know about the 'user's action to press save log', I want to know if the script can do that, like at the end of a recovery flashable zip we can 'cat /tmp/recovery.log >>'. So where is the log stored during installation?

Thanks
[Magisk] keedesu:
Update on this issue: Great news! The phone can run the game smoothly now. First, I tried using the beta version but that did not work. Ultimately used a different ROM that did NOT have Magisk preinstalled as a system app and that fixed it. I did not need Magisk/Magisk Hide after all. Maybe the app detected something in it, and Hide Magisk didn't work because it was installed as a system app.

Thanks to all who helped!
[Magisk] jcmm11:
After boot you can find the logs in /cache/recovery/
[Magisk] masterbyte:
Hi

i bought a tablet allcube iplay8 and i am trying to patch the boot.img, but i always get a bigger image than the original.

and it's possible to patch because is avaiable patched image on 4pda.ru, but i can't register.

so... what i am doing wrong?
[Magisk] Artim_96:
It's bound to get bigger since Magisk has to add stuff in order to work. And we know nothing about that site, so maybe not advertise it, sounds fishy.
[Magisk] Wolfcity:
4pda ist kind of the russian XDA. It's well known here, a lot of mods and tweaks for things like viper and Gcam come from there. Imo this site is ok.
[Magisk] ImNoTAlex:
Can't toogle off encryption

Hi, I toogle off persistent encryption but it stays there, it shows it's off, but if a restart the manager or look into the setting the phone is encrypted, no events about this
[Magisk] Didgeridoohan:
The toggle in the Manager is used to disable forced encryption when you install Magisk. So, if you wan't to disable it, you uncheck the option and then press Install and choose either patch or direct install. Now you'll have the option to use your device without encryption. You still have to decrypt by formatting your /data partition after disabling the forced encryption flag though. Just disabling the flag won't decrypt your device...

IMHO, it's best to just keep your device encrypted. It's easy to forget about it, and accidentally enable the flag again. If you then turn off your device because you think it's bootlooping, while it's actually encrypting your data, you'll loose everything and have to reformat again.
[Magisk] ksio89:
There's a new stock firmware available for my device. Is it just a matter of flashing it and then Magisk on twrp, or do I have to restore stock boot image before flashing stock firmware?
[Magisk] ImNoTAlex:
ok ty! but i actually made like that first time, and it randomly got encrypted again
[Magisk] sk8223:
So I flashed a different ROM and after flashing Magisk, I forgot to ensure that my device was certified in the Play Store before hiding Magisk in Magisk Settings. Now it shows up as uncertified. Not a big deal, but I wonder if this status will ever change? I added the Play Store to Magisk Hide after hiding Magisk, cleared the Play Store's cache and it's still uncertified.

Now, I'd unhide Magisk to try the SafetyNet check again (can't do it when Magisk is hidden) but I can't. When I unhide it Magisk tries to download version 15 for some reason. The one I'm using is a custom build for Treble (yeah, I know topjohnwu recently updated the stable builds to be Treble-compatible but I only saw the news after I flashed the custom Magisk build).
[Magisk] jenslody:
And the update-channel setting points to the correct custom-channel ?
[Magisk] sk8223:
There's no channel or constant stream of updates. It comes from the ROM's dev who updates it using different Google Drive links.
[Magisk] guest4711:
Does the update channel in settings of MagiskManager point to the right one (stable/beta/custom) ?
[Magisk] martyfender:
Sounds like you are downloading it from gdrive and flashing the zip in TWRP and not downloading through the Magisk Manager? If so, then just turn off check for updates in the MM settings.
[Magisk] fifo_thekid:
IT'S NOT KEEPVERIFY, IT'S KEEPVERITY, WITH T NOT F

hahaaaaaa now it's working
[Magisk] sk8223:
Hey all, thanks for helping me out.

Turns out the issue has an easy fix. All I needed to do was add the Play Store to Magisk Hide, then clear the Play Store app's cache and storage (basically disable and re-enable). When I went back into the Play Store, my device certification section was missing altogether, but came back in a couple of minutes. Whew!

Damn this device certification BS stresses me out. I hate what Android is turning into.
[Magisk] jenslody:
Inside the MagiskManager's settings you can change the location used to fetch files for update or reinstallation, the setting is called update channel.

Either it points to a wrong update channel or the dev has build in an own update mechanism.

If it points to stable you should get Magisk 16.0, on beta it's currently 16.4 and with the custom-channel option he can do whatever he wants (depending on the json-file at the url the channel-setting points to).

Magisk 15.0 should never be an option, or something went totally wrong, but if you use a special build, you should probably ask the dev of your version what went wrong (at least with the update).
[Magisk] XavierBrian:
I am using redmi 5 plus as well root with rwrp too but no problem with wifi or any other system,just browsing this thread to make sure my installation of magisk 16 is in proper way,perhaps u use some kernel modify app?i once had same issu before when i off wifi scanning in L speed
[Magisk] FriendlyNeighborhoodShane:
Oh no, I meant the module installation logs from Magisk Manager.

Thanks
[Magisk] masterbyte:
my original boot.img - 7.65 MB

my patched img - 12.9 MB

russian patched img 7.83 MB

Or i am doing something wrong or the russians are using other method of patching boot.img to get magisk to work.

and no! i am not advertising other foruns in here because is a well known site here. You can confirm by serching on this site for "4pda.ru" and you will find a bunch of threads regarding the matter.
[Magisk] Artim_96:
Ok, it shouldn't get that big. But to tell what you are doing wrong you should tell us what you did. But I'd bet on wrong compression. My normal boot.img is 12.5 MB, the patched one just under 12.9 MB. So I'd guess your device requires a compression of the boot.img which Magisk doesn't support
[Magisk] Didgeridoohan:
The question in ny mind is: is it an actual problem? You haven't stated if it's causing issues or not, so kind of hard to know... Or are you just worried about the file size and haven't flashed it yet?
[Magisk] masterbyte:
i have unlocked the bootloader and flashed the img using fastboot and the tablet enters in bootloop and the only way to fix is reflashing the original img.

---------- Post added at 11:35 AM ---------- Previous post was at 11:31 AM ----------

i am not doing nothing special. and i try to patch on original tablet and on another tablet already running the magisk and the outputed img is basicaly the same.
[Magisk] Artim_96:
Like I said, your boot.img is very small before modifying and normal sized when modified. So you should find out how to compress the modified image in order to do that on your own
[Magisk] roles75:
Hello

I have the current magisk Version installed. Root works.

Safetynet in the APP is OK. If I test it with rootchecker, the status comes failed.

[MENTION=4470081]topjohnwu[/MENTION]: Is the error known? Apps that check Safetynet do not run.

[IMG="magisk status"]https://drive.google.com/file/d/1LGchys0WL1LDUQOeHXbOIE--MP1QbuHt/view?usp=drivesdk[/IMG]

[IMG="rootcheck status"]https://drive.google.com/file/d/1jEfb-iAOJPSjcFXU9NNP4dLiFNd3h5v7/view?usp=drivesdk[/IMG]
[Magisk] jesuita:
Hello, I'm sorry if this isn't the right place to ask this, and if it isn't please show me where I should go.

I use this application called TV Vodafone from my Internet provider to watch live tv and suddenly after they upgraded it it stopped working. I can open the application but anytime I try to watch TV it returns an error saying the service is not available.

After troubleshooting with Vodafone I was told the new version of the application does not run on rooted devices.

So I thought "good, I have Magisk I can hide it from root and it will work" but after hiding it on the options it still does not work.

Do you think this is something that can be looked into?
[Magisk] Pkt_Lnt:
You certainly can look into it, you have been given many tools to use here on XDA.

Start here.

https://xdaforums.com/apps/magisk/guide-magisk-troubleshooting-t3641417

Then here.

https://www.didgeridoohan.com/magisk/HomePage

Then here.

https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot
[Magisk] martyfender:
Have you tried to force stop the app and clearing the apps data and cache in settings?
[Magisk] jesuita:
Thanks, will check every option before posting again.

---------- Post added at 17:58 ---------- Previous post was at 17:51 ----------

Already did the following:

Reinstalled TV Vodafone

Reinstalled and upgrade Magisk and Magisk Manager

Wiped both app's data/cache

Wiped system cache

Checked if Magisk is working by testing a root checker app

Hided Magisk Manager

Turned off usb debbuging

Turned off developer options

So far none work :)

Magisk seems to be working (Netflix works) the app is definitly the problem as it works on 2 other non-rooted devices.

Next step try to check all the options on the guide and try to catch a log (opening the application and getting the error will be enough for the log?)
[Magisk] Didgeridoohan:
This is the second report like this I hear in a fairly short time... What root checker app is it that you're using? Could you link it? And what result do you get from this SafetyNet app: https://play.google.com/store/apps/details?id=com.cigital.safetynetplayground
[Magisk] Alucard:
Yeah it shows no root but it does have it,also cant disable force encryption wich annoying as hell,please any fix?
[Magisk] Artim_96:
Firce encryption can mainly be disabled by letting the manager patch the boot.img with that option set and flashing it. There should be some way to manipulate the installer zip to do that but that's much more work. If that won't work you should ask in your devices forum how to do that.

And what exactly is the problem with root? It's just the manger telling your not rooted but everything else works?
[Magisk] jesuita:
My case with Magisk Hide seems to be solved.

The only thing that changed was that I was on 4g when I made the changes and now, on Wireless tried to activate magisk hide again for this app and this time it worked both on the smartphone and the tablet :)

Oops, false alarm, Magisk hide works flawlessly when I'm connected to the WiFi (tested by disabling it and enabling it).

On 4g won't work at all.
[Magisk] Didgeridoohan:
That's interesting. Would you mind posting a magisk_debug.log from when you do a SafetyNet check on 4G and one on Wi-Fi?
[Magisk] jesuita:
Here goes. Hope they're correct: https://www.dropbox.com/s/kynhvuwa9my7c93/logs.zip?dl=0
[Magisk] yochananmarqos:
Wiping the Play Store's data was the solution. Hiding the Play Store does nothing. Keep the number of apps hidden to a minimum. In most cases, there is no reason to hide anything as Magisk already hides root status from SafetyNet.
[Magisk] Didgeridoohan:
[MENTION=2796838]madhub[/MENTION] Monitoring GitHub is a good way to find what's on the way... (And the beta thread is the wrong place for ETA queries.)

https://github.com/topjohnwu/Magisk/commit/835ece54696f7a908af34fb1c04d26db6739eae2

[MENTION=424985]sacredsoul[/MENTION] The Manager crashing on entering Downloads has been discussed a few times, so you could probably find something if you searched around. Meanwhile: https://xdaforums.com/apps/magisk/b...es-modules-t3805576/post76857073#post76857073