yashsingh1/xdaforums huggingface dataset:
[Magisk] TRM4X:
Probably a silly question, If I format my SD as internal storage, could something bad happen ?, Right now Magisk works well with the sd as external,
[Magisk] PereCaNostra:
Anybody can help me about this ussue?

Thanks in advance.
[Magisk] Didgeridoohan:
Your device is incompatible with Magisk. What is your device and ROM, by the way?

---------- Post added at 23:46 ---------- Previous post was at 23:35 ----------

Cleared data for the Manager? Flashed the uninstaller zip (from the release thread) and reflashed Magisk? Or is it a ROM with Magisk built-in? Maybe try dirty flashing the ROM or asking for advice in the ROM thread.

Magisk Manager has version numbers v5.5.3, 5.5.4, 5.5.5. Magisk has never had anything above v15.3 yet. The Manager and Magisk have different version numbers...
[Magisk] PereCaNostra:
Ooh!

:/

My device is Wiko Sunny2 Plus running Android 7.0

It has an MTK 6580 platform.

I can't found nothing in the Internet for root it or custom recovery for this device.

I'm not very happy now... Otherway many thanks for your help

Perhaps in the future in new releases...
[Magisk] Didgeridoohan:
Too bad...

If you upload a copy of the boot image together with an installation log there is a slight possibility that there might be support some time in the future. No promises, of course...
[Magisk] eried1:
Solved my problem. The nandroid I restored through TWRP worked. I had to run the uninstaller, flash the original boot image and reinstall Magisk.
[Magisk] deafmetal1:
The MM v5.5.5 link in the locked OP is incomplete. Going to the MM github provides the fol link:

Edit: Keeps astricking out the URL, so went to tinyurl and created a short link. And it keeps astricking out... grrr

Just go here: https://github.com/topjohnwu/

Navigate to Repositories - MMgr (won't let me spell it out) - Releases

Cheers & Thanks for all you do TJ!!
[Magisk] oldwolf613:
Didgerridoohan, tnx for reply. It was the Magisk Manager that is apparently corrupted. I'm on the HTC U11 fm Sprint, & using Bad Boyz 2.0 rom, which has Magisk root baked in… I can't seem to find the zip file for Magisk Manager 5.5.5, the link listed at the beginning to topjohn's thread isn't working & someone here posted a link in github for the apk, which is also not working. Any help on that appreciated.

At the end of my 1st msg, I mentioned I'd need more specfic directions to flash Magisk Manager - I have root & can use rooted-requiring apps & have TWRP; in so…which mode of twrp should I be flashing the zips? I've only done this once & need a more specific answer than flash the zip... TIA oldwolf
[Magisk] martyfender:
Flash your original boot.img and Magisk-v15.3.zip in TWRP, making sure it patches your boot.img, wipe cache and dalvik cache, then reboot and install Magisk Manager:

You can extract the Magisk manager from the Magisk-v15.3(1531).zip, linked on the Magisk beta thread. It is inside the archive's common folder. I believe v5.5.5 is also inside the lastest stable release zip, also. Magisk-v15.3.zip was re-released for a minor bug fix, in case you downloaded the original, v15.3.zip.

Once extracted from the archive, you can just install that Magisk.apk just like any other Android apk installer. You don't flash it in TWRP.

And you are correct the link for the Magisk Manager in the stable thread is not working, currently.

I'm not sure where to report it, in that thread?
[Magisk] aboalwi:
Is Oreo supported? I'm afraid to update and find out that Magisk doesn't work :confused:
[Magisk] peterlee928:
i am on oreo and magisk works.

verizon pixel xl

stock rom

magisk rooted

elementalx kernel
[Magisk] baku2313:
Magisk 15.3 Downloaded from official link.

Quickheal Shows me this threat

Any one please explain this "is it false alaram" ....:crying:
[Magisk] Ja_som:
Uninstall Quick Heal
[Magisk] randibaaz:
Latest magisk 15.3 does not pass safety net test. How to solve this problem.

AEX rom based on 7.1.1
[Magisk] Didgeridoohan:
It's been brought to attention and will be fixed as soon as [MENTION=4470081]topjohnwu[/MENTION] sees it and has time.

Meanwhile, for anyone looking for it, all Manager versions can be downloaded here:

https://github.com/topjohnwu/*************/releases

Ha! Seems like the issue is that the xda filter has been set up to delete references to the fake Magisk Manager website.

Here's a shortened link, for now:

https://goo.gl/Qdif56

If you downloaded Magisk from the release thread, that's definitely a false positive.

https://xdaforums.com/apps/magisk/guide-magisk-troubleshooting-t3641417
[Magisk] DenyDarko:
Don't use any of those inefficient battery hogs piece of trash software.

They do literally NOTHING but creating problems.
[Magisk] biribiribiri:
I just updated my system from 8.0 to 8.1 and I am stuck in boot. When I look in the adb log, it seems to be related xposed. I reflashed boot.img and got into the system. Then I uninstalled magisk manager completely. After that I flashed magisk again but I still got stuck at boot because of xposed. It seems that uninstalling magisk manager isn't enough to remove the modules. Where is magisk storing all the modules and how can I remove them?

I also have an unrelated question. How can I turn off my phone when it is in a bootloop? If I long press power it just restarts, but I need the phone to shutdown to get into fastboot. I am just waiting for my phone's battery to die now, but that seems rather silly. Is there a correct way to do this? I use a pixel xl by the way.
[Magisk] Badger50:
Don't know about all the exposed stuff since I never use it. Turning the phone off....hold power and volume down button until you get to bootloader mode. You can then shut it down using the volume buttons to get to the shutdown screen.
[Magisk] Didgeridoohan:
Yeah, if you didn't remove the Xposed Magisk module for sdk 26 prior to updating to sdk 27, you'll have issues... The modules are kept in the Magisk image and will be reactivated as soon as you reflash Magisk without first removing Magisk or the module. Check the troubleshooting guide under "Module causing issues".

Hold and press power + volume down to boot to the bootloader.
[Magisk] biribiribiri:
Thank you so much! That saved me hours. I now only have to find out how to remove the files for xposed.

---------- Post added at 12:53 PM ---------- Previous post was at 12:39 PM ----------

Thanks! I finally uninstalled xposed and got into the system
[Magisk] serajr:
Deleted.
[Magisk] kurruptor:
New Pixel 2 XL owner here and new to using Magisk as well. I installed the 5.5.5 manager. I select the "Patch Boot Image File" and choose my taimen-opm1.171019.013-factory-6d9954c3.zip. I get "Magisk Manager has stopped" within 30 seconds. Troubleshooting notes say to try an older manager version, but when I install like 5.5.4, I only get the "Update Magisk Manager".

Am I doing something wrong or do I need to try even older versions?
[Magisk] Ja_som:
If I'm not wrong, you need to extract boot.img from that zip file.
[Magisk] Sam Nakamura:
That's absolutely correct, open the zip and copy the boot.img to another place, repeat the process and point magisk manager to the extracted boot image, then flash the patched image from magisk manager folder on SD ...
[Magisk] Didgeridoohan:
[MENTION=3934153]kurruptor[/MENTION] He's not wrong... :p
[Magisk] kurruptor:
Thank you, missed that part. I'm all good now.

Now onto next issue:

I'm getting the popup below from the FAQ. The only reason I really want root is to install AdAway for ad-blocking. I also plan on using FlashFire to install the monthly security updates and regular Android updates. Do I need to be able to modify the vendor partition for those updates?

Q: After flashing Magisk, my device will show a scary popup saying "There's an internal problem with your device. Contact your manufacturer for details"

A: This is caused by dtbo image patched to remove AVB 2.0 of the vendor partition. This is required for allowing you to mount vendor to rw and make modifications

If you never plan to modify the vendor partition, in Magisk Manager, "Uninstall > Restore Images" to restore the images, check "Preserve AVB 2.0/dm-verity" box in Advanced Settings, then reinstall Magisk via the app.
[Magisk] mctiew:
Found out why magisk could not unpack the ramdisk. It is because the ramdisk has been compressed in two stages ( cpio output to file, then gzip the file ). Under such condition, magisk tool will wrongly detect the ramdisk as raw format, but in actual case, it is still a gzip compressed cpio.
[Magisk] MarcoReckless:
Hello, I can't type with my keyboard with Magisk's terminal while it installs a zip? (even though it's asking for a prompt)

EDIT: I'm a bit retarded lately, it said Vol+ to apply.
[Magisk] masri.razak:
Where I can find magisk v15.0 stable?
[Magisk] martyfender:
On my devices, v15.0 was an utter disaster. It did not patch the boot.img properly, therefore the device froze on the splash screen during boot. v15.1 thru 15.3 has been good, though.

If you really want v15.0, maybe someone will provide an upload of it. I deleted it, but still have v15.1, v15.2 and, of course, v15.3.
[Magisk] masri.razak:
When I was use v15.0 CTS profile was passed, but when I use v15.1 untill v15.3 in the same ROM, I have problem with CTS profile. I think it's better if I use the stable version rather than beta
[Magisk] fOmey:
I found & upgraded my old Galaxy S2 to lineage OS 14.1 (nougat) today.. unfortunately magisk is having some trouble installing on such a old device..

- Device platform: arm
- Extracting files
- Use boot image: /data/user_de/0/com.topjohnwu.magisk/install/boot.img
grep: /etc/*fstab*: No such file or directory
- Mounting /system, /vendor
- Unpacking boot image
MagiskBoot v15.3(1531) (by topjohnwu) - Boot Image Modification Tool
Parsing boot image: [/data/user_de/0/com.topjohnwu.magisk/install/boot.img]
No boot image magic found!
! Unable to unpack boot image
Failed!
! Installation failed

Installing in either recovery or magisk manager produce the same result..

I thought I would take a poke around using osm0sis's android image kitchen.. wasnt able to unpack the boot.img there either..

Android Image Kitchen - UnpackImg Script
by osm0sis @ xda-developers

Supplied image: boot.img

Setting up work folders . . .

Unrecognized format.
Error!

Press any key to continue . . .

Guess something has changed since 2011... hahahaha !

I attached the boot.img just incase anyone was interested taking a poke around, it's a boot.img from the official lineage os nightly (20180117)... I'm amazed there's still active development for such a old device !! Nougat actually runs surprisingly well also..
[Magisk] Didgeridoohan:
Curiosity compels me...

Do your device pass basic integrity on all Magisk versions? Do you use anything to make it pass the CTS profile matching with Magisk v15.0 (like the SafetyNet Fix module)?

And v15.3 is the stable release...

---------- Post added at 09:05 ---------- Previous post was at 08:58 ----------

Ok... No one answered, so I'll give it a shot. I don't have any experience with either your device or Flashfire though.

If you find the message annoying you can repatch with "Preserve AVB 2.0/dm-verity" checked. If it turns out you do need to modify the vendor partition you can patch it again with AVB removed.

The message is harmless though.
[Magisk] Resolute:
In miui magisk works properly.

But if I encrypt device magisk doesn't work. In magisk app I see "magisk is not installed"

Magisk works on encrypted devices?
[Magisk] Artim_96:
In general it does. It might not on some devices. It does work on my Motorola, but then because of the F2FS bug I have to use a module which basically let it run from /cache so I don't know if that's why it's working for me
[Magisk] teddy0209:
My device is encrypted and it works flawless...
[Magisk] Resolute:
I am on miui eu stable rom. I installed magisk before encryption and it was OK until I encrypt device. My device is mi5 too.

What is your rom and did you install magisk after or before encryption?

---------- Post added at 11:05 AM ---------- Previous post was at 11:02 AM ----------

Which module?

I also installed only universal safetynet fix module.
[Magisk] Artim_96:
F2FS loopback bug workaround
[Magisk] t2950486:
I am using LG G2 and running ROMs with kernel 3.4.

Is it not possible to using MagiskHide?
[Magisk] Didgeridoohan:
No. Not unless mount namespace support has been backported to the kernel.
[Magisk] KevMetal:
cant answer you in regard to encryption but on moto e4 i just went ahead and formatted my /data partition to ext4 and afterwards all my magisk modules were working 100%...
[Magisk] teddy0209:
I'm encrypted before I installed magisk... I'm on global dev rom...
[Magisk] Resolute:
Now, I installed magisk after encryption but no hope. Can it be related with magisk version? I use v15.3
[Magisk] mrblackthorne:
Sorry for the bump...

Could any of you guys on the 5T test the app shown above and hide it with Magisk and try the enable fingerprint feature.
[Magisk] martyfender:
I tried to unpack that image with [MENTION=4544860]osm0sis[/MENTION] latest AIK 3.1 in Linux and I can't unpack it either. I get the same error message as you did in AIK.

Maybe upload that boot.img on the AIK thread along with detailed device info and ROM info and [MENTION=1143630]osmosis[/MENTION] may be able to provide more insight as to what is going on with it.

Does it boot the device fine with that image?

Here is that thread link:

https://xdaforums.com/showthread.php?t=2073775
[Magisk] kryzeK:
Has anyone found a fix for OnePlus 3T with f2fs data partition? Except formatting for ex4
[Magisk] lalitjoshi06:
Also waiting for that i can't format it to ext4 kernel not supporting ext4. My device is zero 5.
[Magisk] Anas Rahman:
Does magisk allow writing and modifying /system files?
[Magisk] Didgeridoohan:
There are zero issues with OnePlus' implementation of f2fs and Magisk. If you use a custom ROM it might be another matter, but then you could ask the ROM developers to fix it.

---------- Post added at 17:46 ---------- Previous post was at 17:43 ----------

The point of having magisk is to systemlessly modify system files. So, yes...

If you're expecting to manually go in and edit system files, while Magisk has mounted a mask over /system, you might have issues though.

You might have to elaborate on your query.
[Magisk] Anas Rahman:
So... I'm trying to use google camera mod which requires camera2api to be enabled so I edited build.prop to and added the required code but when I reboot everything is back to default and the code I added is removed
[Magisk] plop12345:
Is using Magisk with with an encrypted device possible at all?

I'd like to understand if using Magisk with an encrypted device is possible. I Have an Note 8 N950N and as soon as Magisk is flashed in becomes impossible to encrypt the device. The attempt results in a failed encryption screen / factory reset. Is this by design or unavoidable? Is this related to disabling db-verify and mandatory encryption? Is there an alternative way to still be able to encrypt the device?

Thanks a lot, really appreciate any pointer.
[Magisk] jenslody:
You can add a script in

/sbin/.core/img/.core/service.d

and set the props there.

Content should be

resetprop [propname] [value]

and it has to be executable.

Instead of "resetprop" you can use "setprop", if you are sure the prop does not already exist. But using "resetprop" should work in any case.
[Magisk] Wolfcity:
I don't want to format to ext4 , I'm using the loopback bug module on my Moto G5+ and it's working flawlessly. It fixed the TWRP recovery which wasn't able to hold any settings and I updated from magisk 14 to 15.3 with all modules.

You need a ext4 formatted cache partition.

https://xdaforums.com/apps/magisk/guide-magisk-official-version-including-t3577875/page10
[Magisk] Kerrnel:
1. Mount system in Mount section of TWRP

2. adb shell

3. mkdir /vendor

4. mount /dev/block/vendor /vendor

5. Install as normal
[Magisk] Anas Rahman:
So the syntax would be like

resetprop persist.camera.HAL3.enabled 1

?
[Magisk] jenslody:
Yes.

And (as written) the file has to be executable, the name doesn't matter.
[Magisk] kryzeK:
I'm using OmniROM 8.1, I've asked but some blame Magisk and others in the own firmware of OnePlus.

What exactly should I ask the developer?
[Magisk] Didgeridoohan:
Your request for a fix to Oneplus f2fs doesn't make sense, since there are no issues with OxygenOS' implementation of f2fs... But...

Since you haven't actually mentioned it, I'm going to assume that you're talking about the issue where superuser requests aren't remembered. Or is it another issue you are talking about?

If it is about su requests, I have yet to see anyone coming up with some proper troubleshooting as to why it happens. Until then, there's probably not gonna be a fix... The best I've seen is a hint about the magisk.db not being created (it's supposed to be in /data/adb), but the question is why.
[Magisk] kryzeK:
Exact, my problem is su requests are not remembered. For some apps this does not bother you that much. But others like Greenify and BBS become completely unusable

But thanks, the way is to wait.
[Magisk] Pkt_Lnt:
No, the way is for those having this issue is to supply logs, if everyone waits for everyone else the "fix" ain't gonna happen. :rolleyes:
[Magisk] kryzeK:
I've done this before in the beta thread :) I just wondered if there was any progress or any discovery.
[Magisk] osm0sis:
[MENTION=1620550]fOmey[/MENTION]

S2 and Tab images are a special kind of hard-to-support. First they appear almost headerless, then there are a couple formats within that on those devices, with some of them using that isorec format and others just the stock Samsung. I could brute force unpack the ramdisk by just chopping out the ramdisk.cpio (and there is a split_img.pl somewhere on XDAs wiki that can do that) but it's pointless since repacking is another matter entirely.

They're listed in my AIK thread as unsupported with a link to my research so far on the matter, but I do plan at looking at it again at some point.

I mean I know LOS can certainly build a working image so you'd think the tools would be readily available, but I can't find anything.. only tools I've found have crazy device-specific bits and ASM code and such that would break hard under the cross-compiling I'd need to do for proper AIK support.

Any help anyone can provide would be appreciated. I guess I'll have to get someone to put me in touch with the LOS maintainer to see if we can get to the bottom of it..
[Magisk] teddy0209:
I'm using 15.3... Might be rom related, not sure about it... You can provide some logs for the experts to see...
[Magisk] TKruzze:
Is my understanding of the recently added fingerprint feature in Magisk correct that it only a convenience feature and NOT a security feature? The reason I ask is that you are always able to go into the MagiskManager app and just disable it and you're right back to the old method, right?
[Magisk] osm0sis:
Great point. In SuperSU when a PIN is set it also sets a PIN on SuperSU itself. Magisk needs to do that with the fingerprint support, and should also add PIN for devices without fingerprint readers.
[Magisk] Shen Ron:
I'm wondering if a feature could be implemented into magisk manager to determine beforehand whether a module is compatible, semicompatible or not at all for your specific device by determining the possibility that it may cause conflicts with your devices system. So if I'm installing a sound mod like viper for example it will show the compatibility with the device along with other modules that might cause an error.
[Magisk] DenyDarko:
And then you can just clear the app data and the protection is gone.

It's called obscurity feature, not security.

Passwords and stuff only makes sense when private data and encryption is involved and just for the protection of the actual private data.
[Magisk] Artim_96:
It could be possible but very difficult to realize. There are too many differences between every single device and ROM. Just look into the modules description and try it out. That's much easier. Even the devs of the modules often don't know on which devices it will actually work... Unless it's a very device specific one
[Magisk] DiamondJohn:
The below was the last few breaths my phone took, before it died. So, I am pretty sure it was not Magisk but the phone :o sorry :o again :o

I just did a wipe/reformat and clean flash of my phone, and this strange behavior is back again. ie where scripts sitting in /magisk/.core/service.d/ become filled with NULL characters to the same length of the original file:confused:

I have done multiple reboots, and it hasn't magically started working. I have also checked my partitions and there are no errors, and also performed repairs on all my partitions, and still the same behavior.:crying: They get mentioned in the log as being executed, but do nothing. I guess they are damaged before they are run.

So, I have tried creating a /magisk/.core/service.sh script, and that did not run (nor mentioned in the log). Where is the script suppose to be placed?

----edit-----

I have no idea if its right, but it worked on another test device I have; different phone model. I created a file in /magisk/init/service.sh and this file also became blank on boot. :crying:
[Magisk] tricke:
unable to unpack boot image, error 1 question

I restored my Nexus 9 to the latest factory image, installed TWRP, then tried to flash Magisk 15.2 (I've used this file successfully on other devices) but it failed with "unable to unpack boot image". I reflashed the factory boot image and tried again, but had the same error. I then randomly tried Magisk 14.0 and miraculously, it worked. I was then able to flash 15.2, weird!?. Does anyone know why a recent version doesn't work, but and old one does?
[Magisk] Massi-X:
OTA dtbo not restored

Hi topjohnwu

I hope you'll read this message because I found two bugs in Magisk:

- First, following your OTA update tips for devices with A/B partition, the dtbo image is not restored by clicking "restore boot image" and the OTA fails (I have to restore it manually with fastboot). So I was wondering if your tips are not updated, if I have to click complete uninstall or if you have to fix it.

- Second, I think you are aware of this, on Pixel devices (maybe others) the dtbo is patched and this lead to an "unknow problem" with the device every time you reboot

Thank you!
[Magisk] Didgeridoohan:
Is this the case even if you tick the option to preserve AVB 2.0 when installing Magisk?

From the release thread troubleshooting info:
[Magisk] Massi-X:
Yeah, you are right, I write before thinking... The checkbox was checked but maybe because I was coming from a previous version the dtbo was patched anyway. Well so it's all OK! Surely also the OTA will work. Thank you!
[Magisk] Resolute:
I uninstalled magisk and installed it again after encryption. Now there is no problem.
[Magisk] zurik:
On Nexus 5X and latest Magisk 15.3 (1531) sometimes when I reboot the device, it stuck at Google Logo and I need to force reboot the device to boot up. Without Magisk I don't have any problem like this.
[Magisk] otyg:
Hi, I was trying to make a Magisk module that enables the Document process app on MIUI (for some reason it disables it, making it a pain for apps to use sdcard), anyways I tried making a script , and set LATESTARTSERVICE=true in the magisk config.....however the documents process is still disabled after bootup, (i ran the script manually in terminal and it works fine then, so I think I need to delay it more or what could be the problem?
[Magisk] Didgeridoohan:
Sounds like you've already come to a solution. Try adding sleep x before the command, where x could be anything from 10 to 60 seconds or more. Trial and error...

sleep 10
pm enable com.android.documentsui

Since it's such a simple script, I'd also consider using a Tasker (or similar) profile to run the command at boot, with a possible delay.
[Magisk] otyg:
thanks, works perfect.