yashsingh1/xdaforums huggingface dataset:
[Magisk] Ghxst01:
Thank you for your suggestion, your help is really appreciated :o

Unfortunately tasker seems to be a paid app, I was hoping there would be an option to use maybe a custom magisk module?

I wouldn't mind making one, but I am just getting into this and am a bit confused.

My inspiration comes from setpropex.c, maybe you heard of it?

https://github.com/poliva/rootadb/blob/master/jni/setpropex.c

Could you tell me if my perception is correct on the following;

- Setting the property ro.debuggable=1 after boot has no effect due to adbd already being loaded.

- Setting ro.debuggable=1 in the build.prop has no use since default.prop in the ramdisk overwrites these.

However, since Magisk modifies the boot.img (I think?), maybe I could make a module that reboots me into debuggable, and out of it when needed?
[Magisk] Didgeridoohan:
In that case, the simplest solution might simply be to make a couple of boot scripts that you put in either /sbin/.core/img/.core/service.d or post-fs-data.d (depending on how early you want it to run, more on that here). Just switch between the scripts (manually or automated with Tasker, similar apps, scripts, etc) when needed and reboot.

One script would contain:

resetprop ro.debuggable 1

And the other:

resetprop ro.debuggable 0
[Magisk] Ghxst01:
Wait.. what? I feel so stupid now but is resetprop part of magisk?

How did I not find this earlier .. :confused:
[Magisk] Didgeridoohan:
Why, yes it is:

https://github.com/topjohnwu/Magisk/blob/master/docs/tools.md#resetprop

:laugh:
[Magisk] Ghxst01:
That's awesome all I was looking for!, thank you for the suggestions and your work :good:
[Magisk] jollfye:
I have maybe a stupid questions, but mm what if I try to install an update for an app that I got with magisk module? like just try to manually install an apk update? will the app be reverted to it's module original state before update after device restart? what will happen if I uninstall the module after app update, will it be gone (as it should) or smth else (like it stays cos it was updated)? I personally think the app will be reverted if not immediately after update (like it didn't even happen) then after device reboot for sure, idk here :confused: soo how am I supposed to update the app correctly (more like reboot safely), should I wait for it's update inside the module n then update it with magisk manager or I can update the app manually by installing it's "new" apk? if more details, the app I'm talking is Ruthless Pixel Launcher and module is Pixel 2 Experience
[Magisk] Artim_96:
If you installed an app as system app via Magisk, all updates will land in the data partition. So they are safe.

Android won't change anything in the system partition since that would lead to warnings and boot errors on newer devices
[Magisk] jollfye:
so u r saying if I installed the module with the app within it and this app ended up being system (it did, I just installed the module n didn't use appsystemizer or smth on the app itself) then I can safely install updates cos they all will go to the data part? aand what if I uninstall the module, the data will be erased? the previous version of the app will be back? cos I had stock pixel launcher installed as default before the module, after it just got replaced with the new Ruthless one.. hm will app data be lost then (like icon positions, widgets)? cos after module, all of it was untouched, positions, widgets, all came to the new pixel launcher from the old one as if by magic yay :victory: uh sorry for all the questions, just trying to figure things out.. from my "not so pro" perspective :silly:
[Magisk] AJ:
any news for Magisk for Android P ?
[Magisk] Artim_96:
Yes.

Some apps like Greenify lose their data, others like the Google dialer don't. I have no idea why, only that it's that way
[Magisk] Badger50:
Not working on the P2XL, and not likely to until topjohnwu gets back from his military service in June.
[Magisk] RASTAVIPER:
No,.I will have a look.
[Magisk] Didgeridoohan:
When a Magisk module adds an app to /system, it'll work exactly the same way as any other system app that is already installed on your device. The base apk can be found in /system/app or /system/priv-app and data from any updates you do will end up in /data. That's why you can only uninstall updates for system apps in the Play Store, you're uninstalling app data from /data. Depending on how the app is built, uninstalling the system part (or the Magisk Module) will sometimes simply leave the app as a user installed app instead.

When having an app systemised with Magisk, it's actually preferred to just update it through the Play Store, F-Droid or whatever tickles your fancy. If updating an app by installing an updated Magisk module, you might end up with issues like the app force closing or not updating properly. At least if you update the module through the Magisk Manager. Updating the module through recovery works fine, because then Magisk doesn't have to deal with a merge image and stuff.
[Magisk] Wolfcity:
Does the last part you wrote only concern system (ized) apps?

The question for me is should I update modules like Viper or Dolby better through recovery than through magisk manager?
[Magisk] Didgeridoohan:
Depends... If the app included in the module hasn't been updated it doesn't matter. And not all devices experience problems anyway...

I always update through the Manager and only go the recovery route if there are issues.

Edit: to answer your actual question. Yes, it only concerns apps.
[Magisk] Didgeridoohan:
You say you're rooted... With what? If it's not Magisk you'll first have to unroot and install Magisk clean (patch the boot image or install through custom recovery).

If you're already rooted with an older version of Magisk and are trying to update, same thing. Unroot and install clean.

And by the way, I answered you here since the Beta thread isn't the place for those kind of queries.
[Magisk] vwtc6yc8e:
verification failed

in order to get magisk on my device, i've downloaded the magisk zip file (v16) and flashed it via twrp on samsung a3 2017 device.

once twrp rebooted, i got a message "verification failed" error message with a button "restart" beneath.

worth noting that i have no sdard on the devices, i am using the device as is.

i would really like to root my device using magisk.

what am i doing wrong?

is there any fix for that?
[Magisk] ArmynC:
I have TWRP + SuperSU.. I need magisk for the xposed framework (that's compatibile with Samsung rom)

YesI saw it thar I need to remove root but nothing about the manager + on some sites said that is ok with roott anroid.****************/how-to/magisk-101-install-magisk-your-rooted-android-device-0176809/)
[Magisk] Didgeridoohan:
What device are you using? You might have to keep dm-verity and/or forced encryption enabled. Take a look here:

https://www.didgeridoohan.com/magisk/Magisk#hn_Keeping_dm-verity_and_forced_encryption

If you really need Magisk then you need to first remove SuperSU.

https://www.didgeridoohan.com/magis..._another_systemless_root_solution_to_MagiskSU

Just bear in mind that Xposed doesn't always work well with Samsung.
[Magisk] vwtc6yc8e:
[MENTION=4667597]Didgeridoohan[/MENTION]: thank for the reference. but still not very clear.

could you please clarify, or just let me know what are the specific commands that i should put into the recovery terminal?
[Magisk] Didgeridoohan:
The commands you find in the part of the Magisk guide I linked you...

echo KEEPVERITY=true>>/data/.magisk
echo KEEPFORCEENCRYPT=true>>/data/.magisk
[Magisk] vwtc6yc8e:
[MENTION=4667597]Didgeridoohan[/MENTION]: i tried each of which and when both of them (all the combinations) are enabled. nothing helped, same error.

any other idea?
[Magisk] Didgeridoohan:
You still haven't answered me on what device you have...

Edit: scratch that. Just saw you now have added that in your original post. Try flashing this after Magisk:

https://build.nethunter.com/android-tools/no-verity-opt-encrypt/

I've seen Samsung users reporting success with that. I wouldn't know though... I don't do Samsung.
[Magisk] vwtc6yc8e:
[MENTION=4667597]Didgeridoohan[/MENTION]: i will try to flash it using twrp.

but before doing so, worth noting that when i flash magisk, i get an error "unable to mount /data".

is it related? should it happen?
[Magisk] Didgeridoohan:
That's not normal. You should grab a recovery log and post it. You could also use the Manager to patch the boot image and then flash it with TWRP. That should work even if your TWRP isn't quite up to the task of installing Magisk.
[Magisk] vwtc6yc8e:
update:

i noticed that when i was flashing magisk i got an error saying "unable to mount /data".

in twrp, i headed to wipe, advanced wipe, picked the data and clicked "repair or change file system".

i noticed that all everything had zero values, meaning twrp cannot read it.

this what i did in order to solve my issue:

1. flashed the stock firmware

2. flashed twrp

3. boot to recover (twrp)

4. decrypt the data parition: wipe, format data

5. reboot back to recovery

6. flashed no-verify-opt-encrypt

7. reboot to system

8. reboot to recovery (twrp)

10. flash magisk

11. reboot to system
[Magisk] Eversmile23:
'magisk not installed' message. I am baffled.

I have been using magic for last 3 months. One problem is getting repeated from time to time. I had flashed closed for sdk 23 and xposed was working. Also, I am using apps2sd (by Vickybonik) for linking my apps to 2nd partition in my SD card. As my stock room do not support mounting of 2nd partition at boot, I need to make a soft reboot for making the linked apps visible. Sometimes, I had observed that my device gets restarted in the mid way ( I mean some time after opening the apps2sd app).My point of saying is that, 'magisk' gets vanished sometimes after such reboots. But, I saw one/two Xposed modules working though root apps fail to act. This forces me to again flash magisk zip from my tarp recovery. The same thing is observed irrespective of stable or beta version of magical. I am unable to make myself sure of the originating problem point --- whether it is magisk or closed or 'apps2sd app'.
[Magisk] cypher187:
Since I didn't get any answer and my problem still persists... But I'm really sorry for double posting.

Now version 16 is up but no change in behavior. Installation succeeds but system works not properly. I already posted in device / ROM thread but no help.

I am stuck with Magisk v1400

SystemUI keeps crashing if secure lockscreen is enabled after entering PIN and there is no fingerprint sensor. Also it doesn't matter if there are any substratum overlays or not. It doesn't matter if I install via MM and patch the stock boot.img, let it direct install or via TWRP. Also a full uninstallation of magisk has no effect. A clean installation of ROM doesn't help. The F2FS bug - workaround doesn't help.

And I'm out of ideas. I appreciate any help and suggestion. If you need more information, please ask. If I done something stupid wrong, please tell me.

Regards,

Chris
[Magisk] DB126:
"Soft" reboots are known to be problematic on many devices and configs as it only restarts the ROM. Kernel parameters, sensor state, etc remain in tact. Try a normal (full) boot.
[Magisk] zelendel:
Apps2sd always causes an issue as apps were not made to boot from the sdcard and all apps that allow it to be done are hacky at best and cause instability. This is why Google added the ability to use the sd card for internal storage.

It sounds like apps2sd is corrupting the main app storage. I wold lose apps2sd. In this day and age it is almost completely useless unless you keep dozens of useless apps on a device.
[Magisk] fiverings:
Hi, I installed March update to my Pixel XL, using flash-all. I forgot to uninstall Magisk like I usually do. During the installation things got weird. It install most files to A partishion and then install some into B. Most were the same as A and a few were not. Lost boot, when I tried, got the dead android and selected return to bootloader. Fastbooted twrp.img. then no boot so I uninstalled Magisk, booted twrp again and flashed twrp installer.zip and flashed Magisk 16.0. And now everything is working. What did I do wrong? Does Magisk in two partishions , good , bad, doesn't matter?
[Magisk] DB126:
While I agree with the above comments there are unique situations where symbolic linking is preferred and, in some cases, the only viable option. Good app hygiene is the best path (dump the crud...) followed by Adoptable storage if supported by ROM and/or internal controls offered within apps. Those who desire finer control of app placement or rocking Android 5.1 can benefit from an took that properly supports symbolic link management. Pick your poison; I've used Link2SD (no longer being developed) and Apps2SD and generally found they perform as advertised.

As for behavior with Magisk I'd strongly suggest only targeting apps that are natively installed to the data partition. Going after system apps is a fool's errand and only asking for trouble.

Again, best choice is to avoid symbolic linking if at all possible. Take the easy road and focus on using your device and app portfolio vs managing it.
[Magisk] firozpatel:
Hi everyone

I am running Samsung s6 edge, on firmware 6.0.1 using artar97 kernel and xtrestolite ROM also with magisk 16 passing safety net

This might of been answered before I'm sorry for repeating

So I'm sure everyone is aware of this deep sleep fix, I have been searching for a fix, used to work with super super as they implemented in the app itself

Any module for magisk to help fix this issue or a anything I can do

Thank you for helping me
[Magisk] Jaymin.0.1910:
I moved conversation here cause it's the right place for that

In Android P, /sbin doesn't seem to be in PATH, can you run

echo $PATH

from the root shell ??

---------- Post added at 06:14 PM ---------- Previous post was at 06:10 PM ----------

I don't have a Sammy, so can't test, but seems like the deep sleep fix script is in SuperSU zips common directory, just grab that script and put that to /sbin/.core/img/service.d and set permissions, mode to 0755 and owner to 0 and group to 2000

EDIT: You will need to change the hashbang to whatever applies to you
[Magisk] firozpatel:
i dont have supersu and i have no idea how to implement the scriped ou
[Magisk] Zythyr:
I am unable to toggle Root to OFF. Everytime I toggle it OFF, it automatically turns back ON.

I am using OnePlus One (OPO). Below are the steps I followed.

1) Boot into TWRP

2) Wipe all data/cache/etc...

3) Flash a NON-rooted custom ROM (ex: http://xdaforums.com/oneplus-one/development/rom-cm11-temasek-build-t2870743)

4) Flash Gapps as required by the ROM

5) Flash Magisk-v6.zip

6) Flash SupserSU-v2.76-magisk.zip

7) Reboot phone and go through the initial Android setup

8) Install Magisk_Manager_v1.2.apk

9) In Magisk Manager toggle Root to OFF. It will automatically turn back ON.

I tried the steps with phh's SuperUser also, but I am still getting the same issue...

Update:

I tested with a different ROM, http://xdaforums.com/oneplus-one/orig-development/rom-kernel-unofficial-cyanogenmod-13-0-t3242700. I am no longer having the issue mentioned above. I am unsure if its this issue is related to the ROM or Magisk...
[Magisk] Äptiva:
Ok so I managed to get PoGo and AP working flawlessly on my LG G2 running stock-ish rom using a modified Dorimanx kernel. I only modified the kernel for the d800 (AT&T G2) since my vs980 is a hot mess right now. What I'm using:

ROM: blastagator's stripped d80230f for d800

Kernel: modified Dorimanx v11.4 (I recompiled with SELinux enforcing bits enabled in ramdisk. Removed busybox from ramdisk as I needed to use the one from Magisk)

Addons: unSU script, Magisk v6, cBump by blastagator, phh's Superuser for Magisk

I don't have the kernel uploaded anywhere. The reason I needed to modify the kernel is because I could not pass the SafetyNet checks for some reason. When I changed the kernel to SELinux Enforcing on FIRST BOOT it just worked. I could not get a bone stock kernel to work with magisk because of compression of the boot image. I did full wipes and started with a clean device (even wiped internal storage just for testing. likely not needed)

My flash order was very specific.

1. Flash rom

2. Flash unSU

3. Flash Kernel

4. Flash Magisk

5. Flash cBump

6. Flash phh's superuser for Magisk

On reboot I didn't touch anything. Installed phh's Superuser from Play Store, opened this, then installed Magisk Manager. Magisk Manager showed root mounted and SELinux Enforcing. Toggles worked. Installed PoGo and loaded perfectly. Installed AP and started. Added a card and good to go.

I will ask Dorimanx if I can upload the version I have modified for sharing. It's his work with my tinkering and that's it. I was waiting to post a full method until I could consistently achieve results. If more people want it for the other G2 variants I can recompile those kernels with the same modifications, but they will be untested by me and you use them at your own peril. Again I will have to wait for permission.
[Magisk] Nik1703:
Does this work with any emulators currently? (I've heard Nox is not compatible) (and yes, i'm pokemon-ing)

I have genymotion with virtualbox operational, but it's buggy AF and really clunky - so i'd prefer something more compact (Nox, for example)
[Magisk] winters692pr7:
Toggle widget for Home screen would be great!

Just want to say this is outstanding work. Works well with Note 5 N920P. Of course the Selinux toggle says its disabled due to samsung not supporting this switching. Would it be possible to have a widget toggle that can be added to the home screen that toggles the root on/off from Magisk manager? How about the ability for the system to startup as a non root status as well (mine only starts up as root)? Maybe even a timed switch (customized 1 min. or so) from root to non root, as a majority of my rooting needs are only needed on boot (ad blocking host file, etc).

Just suggestions. Thanks again for all your hard work
[Magisk] westeight:
The latest LeeDroid nightly build has an install without root option. Dirty flashing also has an option in the Aroma installer to remove any existing SuperSU. A stable will follow shortly...

It's confirmed to work perfectly with both Android Pay and Pokemon Go.

V7 of Magisk is imminent...

The combination of the above is likely to fix 95% of the current issues, so for those unable to get things working now, just be patient.
[Magisk] kh43rul:
i was try to flash magiskv6 to my device mtk6582 but failed and error "unable to detect boot image".

i was open Rootex and find "/dev/block/platform/mtk-msdc0/by-num/xxx" but there is no dir "dev/block/platform/mtk-msdc0/by-name/xxx".

how to fix this? thanks.
[Magisk] Artim_96:
You shouldn't write, what processor you have, better tell which device and which ROM. Otherwise no one can help you

---------- Post added at 07:24 PM ---------- Previous post was at 07:21 PM ----------

What does the OP says about that topic? Read!
[Magisk] kh43rul:
my device lenovo a536 and Micromax A106 Unite 2, i'm using stockrom lollipop 5.0.2
[Magisk] lancespahr:
Does systemless Xposed work on your device? I have same device and when I install Xposed it breaks lock screen so it's pretty useless.. I've posted on the Xposed magisk forum but no progress yet.. I'll post my logs later with a logcat of boot, hopefully we (or more likely they) can get it fixed! :)

---------- Post added at 07:31 PM ---------- Previous post was at 07:30 PM ----------

SuperSU toggles fine for me, not sure what the issue is?
[Magisk] LakesideWiseman:
Yes it does work. Only safteynet fails.
[Magisk] renand3z:
I lost some hours here so I'm adding some info to others:

cbump is the first link (Boot Image Bumper):

http://www.gregtwallace.com/lgg2-projects/miscellaneous/

If you are not coming from some new rom you problaby never installed bootstacks. It is need to boot with news roms:

http://xdaforums.com/lg-g2/development/lg-g2-bootstacks-t3173715
[Magisk] o2demonangel:
Hi, i was trying to install Magisk on my HTC BUTTERFLY S with custom ROM 5.16.709.4 Sense 7 v1.2.4 with stock kernel but i received the error message "unable to detect boot.img", the same problem goes to phh-superuser-17-magisk.zip that downloadable from 2nd post but i manage to install the phh-superuser that downloaded from Official thread phh-Superuser.

Anyone please help me?
[Magisk] Artim_96:
You said it does not.
[Magisk] lancespahr:
Different user, just providing outside feedback :) just because someone flashes SuperSU does not mean root toggles can't work on Magisk.
[Magisk] kh43rul:
same with me, anybody can help?
[Magisk] shark300:
Ok, tried some kernels for my Xperia Z1:

XerXes Artemisia-> first I got logo and I can to flash magisk using recovery. After reboot, it seems to be freezed. A

OK Kernel V6.2 -> Boot up, after flash -> freez

Kryptonian-Z1 -> Boot up, after flash -> freez

Advanced-Kernel -> Boot up, after flash -> freez
[Magisk] Nik1703:
Anyone?
[Magisk] Opticuhl:
It seems SafetyNet has been updated, response validation fails as of today..
[Magisk] Nkaskaj:
Getting Error: 1

Hi guys, When I try to install Magisk I am getting ERROR: 1 ( Boot partition space insuffucient, Remove ramdisk backups and repack, Boot partition size still too small...) What should I do? I have stock rom, using TWRP 3.0.2-0, SM-G361F.
[Magisk] Artim_96:
Try it. Virtual machines are far off everything that will ever be supported. So when it works it works, if not it will probably never change
[Magisk] firozpatel:
i have no idea to go about what your saying

but i found this post (below in brackets), would you know how to implement this script in a kernel?

(Hi everyone, I won't make this a long-winded post, but if you have seen the deep sleep bug, and compile your own kernel, please try the patch attached below. The patch simply disables cache synchronization when the device is write protected.)
[Magisk] Jaymin.0.1910:
The file you attached is not a script, it is a patch file ( which contains difference of two files ), I modified Chainfire's script slightly and have attached it, remove the .txt extension from it and copy it to /sbin/.core/img/.core/service.d and set permissions as I said previously ( run 'chown 0:2000 /sbin/.core/img/.core/service.d/000000deepsleep.sh' and then 'chmod 0755 /sbin/.core/img/.core/service.d/000000deepsleep.sh' ) and reboot, if it doesn't work copy the script into post-fs-data.d and try again ( script was named 000000deepsleep by Chainfire, so I believe it needs to be executed at early boot stage )
[Magisk] firozpatel:
could you explain this bit abit further please "set permissions as I said previously ( run 'chown 0:2000 /sbin/.core/img/.core/service.d/000000deepsleep.sh' and then 'chmod 0755 /sbin/.core/img/.core/service.d/000000deepsleep.sh' ) and reboot, if it doesn't work copy the script into post-fs-data.d and try again ( script was named 000000deepsleep by Chainfire, so I believe it needs to be executed at early boot stage )"
[Magisk] rabin69x:
Why can't it showing any of my module?

Device: Xiaomi redmi 4 prime
[Magisk] Artim_96:
Let me guess, your /data partition is mounted f2fs? Well, whether the problem is, Magisk obviously isn't able to use modules. Or did you core only mode?
[Magisk] rabin69x:
Tnx man it was core only mode :silly: my bad
[Magisk] 314mp:
Magisk manager hangs after update to 16, I've attached a screenshot of the matlog with error filter, I can't save logs for some reason.

MagiskManager 5.6.1

Magisk 16

Pixel (sailfish,) 7.1.2

Tried older version doesn't help, flash uninstaller and I can open magisk manager.

Anyone have any help?
[Magisk] AndyShaytan:
Possible threat found after analyzing the latest Magisk .zip file on VirusTotal - WhiteArmor AV reported a PUP, type HighConfidence. OK, a single report can be a false positive, plus a Potentially Unwanted Program isn't necessarily malware, however it's even stranger when the file that triggered the report is called "Virus.zip". Can the situation be clarified?
[Magisk] BurnedDrake:
Where did you download the zip from?