yashsingh1/xdaforums huggingface dataset:
[Magisk] paarnoutse:
See here for an explanation and a solution how to prevent that background apps are killed by the crazy battery optimization implementation behavior at OnePlus devices running OxygenOS. The original thread subject of that post was triggered by Titanium Backup schedules not working (as experienced by many users), but the described method is a general solution, and can be used to prevent the stupid OnePlus background process killing behavior for any app that should permanently be kept active and never be killed, eg. Tasker, Titanium Backup, your Sync-to-cloud apps, etc. etc.

Nb.

I've implemented and tested that bypass at my OnePlus 5 running OxygenOS (Oreo), and it resolved the crazy app killing behavior for me. Not sure whether it also works when running other OS flavors at OnePlus (eg. LineageOS) and/or other brands (eg. Xiaomi). When it also works for you at another device/OS than OnePlus 5 / OxygenOS, plse add a reply to the original post to inform other users about your experiences with that solution for your brand/model and Android flavor+version. Thanks in advance!
[Magisk] paarnoutse:
No, although the actions as described here could also be applied to Magisk Manager (to make sure it will never be killed), unfortunately it doesn't help to prevent the root detection and the SafetyNet check failures in Magisk v18.

For that problem we've to wait for a solution by [MENTION=4470081]topjohnwu[/MENTION] of the Unreliable MagiskHide Process Monitor issue as described in Magisk GitHub issue #907.
[Magisk] aff1c:
Why my magisk v1.8 suddenly dissappeared and unrooted? Im using latest mi globe build btw.. tq. Need to flash again on twrp and install back the magisk manager latest to get it back rooted.. hmmm
[Magisk] jedi134:
Magistrate ver 17.3 to 18

---------- Post added at 01:00 PM ---------- Previous post was at 12:57 PM ----------

Magisk ver 17.3 to 18 don't work with android 5.01 anymore. Clean rom installs no root. 17.1 seems to be latest that work with lollipop 5.01.
[Magisk] Didgeridoohan:
It's already been noted that the thread you're linking doesn't really bring up any issues about Magisk and security. Only that users often have a hard time reporting their problems in the right place...

Regarding your questions:

The only security issues (apart from bugs that might arise in Magisk, but that's not what I gathe that the question is about) is if the module you install does harmful stuff. But, that's gonna be true for anything you install on your device. The good thing about Magisk modules is that you can alwasy open them up an look at exactly what it is they're doing before installing. There is a possiblity that a module that a user have installed does something to the device that causes issues for other apps, ROMs, etc. That might be a consern for developers and could cause some to refuse to help if the user has Magisk modules installed, just as with Xposed.

The official Magisk repo is moderated to a degree. Submissions to the repo are (nowadays) always looked at before they're actually accepted into the repo. That way there's a slightly smaller chance of anything harmful finding it's way in there. After a module has been accepted to the repo it is of course possible for the module creator to change it with harmful code, an edited apk or similar, but that would likely be found out quite quickly (again, it's very easy to look at what a module does before it's installed).

In the end it's all up to you as a user to be responsible when modifying your device, and if you do find issues to report them in the right place...
[Magisk] anotherxdauser:
Yes, I read a little.

But I don't have a "Canary" build that I'm aware of.

Nothing has changed, apart from the banking app updating itself, which I assume renders Magisk Hide pointless.

USB Debugging has always been on and it's worked fine in the past.
[Magisk] ktmom:
Canary is the name of the beta builds of Magisk and contain expanded debugging and, at any point in time, features that don't yet exist in stable releases.

You said the app updated and the problem began. App designers are in a tug-of-war with users who want root on their device. It's likely that the app you are complaining about implemented new "root" detection methods. USB debugging is not strictly root, but there are some apps that flash that condition as a reason to not run, considering the device to be "unsafe".

If you want your cake and eat it, so to speak, you'll need to do a lot of reading.

"find somebody that you think is undeserving of your compassion and give it to them" - Christian Picciolini
[Magisk] pol-der:
Thank you for your interests buddies. I read all Reddit page. I know Magisk is not harmful for our phones. Just modules. [MENTION=4667597]Didgeridoohan[/MENTION] as i mentioned before i am not expert and i don't have knowledge about Android programming. For this reason i can't understand that module has harmful stuff or not. If you know a simple way to check modules if they are harmful or not, please share with us. I can learn quickly and i love learning. Now i want to ask some questions all of XDA members and [MENTION=4667597]Didgeridoohan[/MENTION] [MENTION=4487388]jcmm11[/MENTION] [MENTION=8126387]martyfender[/MENTION]

As i understand Xposed is really adding security holes into the ROM. Why i am using it? Which modules i am using?

FakeGapps: I am using LOS 14.1 unofficial on my N910C device. And i don't use any Google services on my phone and PC. For this reason i need to install FakeGapps module of Xposed because of many applications and games require that. For this reason i installed module and thus i can use any app with this.

CameraNotify: I love this small module and it doesn't require any permission. When camera is enabled, green led is turning on and i know camera is enabled. Think like MacOS.

EnableCMCallRecording: This enables call recording feature in my ROM. When i enabled this, i can see a REC button on the call screen while i am calling someone. I searched a way to enable call recording via ADB but i couldn't find. I found some codes but they are for One Plus and didn't work for me. If someone know to enable call recording without an app please share with us.

GravityBox [N]: This module has many tweaks as you know. For example i can reach Status Bar (WIFI, Cellular Data or something else) while screen locked. I can disable access to the Status Bar with this module. This is just one example. It has many features.

XPrivacyLua: If you love Privacy like me you will love this module. As you know this module is changing values with empty or fake values. Which values? You can check from this link.

Dear buddies,

How can i do these without Xposed? If i can, i will backup my data and will make clean install without Xposed.

Thanks in advance.

Kind Regards.
[Magisk] BurnedDrake:
You basically can't, especially with something like Gravitybox, Xposed and Magisk modules are fundamentally different from each other.
[Magisk] martyfender:
You can't as far as I know. I would say stay with xposed if you want all of these features, since apparently xposed works well on your device. I assume also that you do not need to pass safetynet.
[Magisk] Didgeridoohan:
[MENTION=9593734]pol-der[/MENTION] The easy way to know if a module does bad stuff or not is, as I've already said, to open up the zip (or if available check the source code, but the only sure way is to see what's in the zip) and look at the scripts... It's simple (relatively) shell scripts so it's not that hard to learn. If the module mounts apk's or other files you'd have to figure out how to decompile those (there are plenty of ways to learn that online).

It's either that or just trust that other users keep an eye on what's going on and report if they find something out of order.

As for replacing Xposed functionality with Magisk modules, that's (as has been pointed out already) not so easy. Some things can be achieved, but the two frameworks are so fundamentally different that you shouldn't expect much.

Having said that, have you looked at NanoDroid by [MENTION=4187311]Setialpha[/MENTION]. Might be a way for you to continue going Google-less. For the other mods I believe you're out of luck.

---------- Post added at 16:49 ---------- Previous post was at 16:45 ----------

If you haven't added Lloyd stuff (it was Lloyd, right?) to your hosts file, I'd try with that. Check "External connections" under Hiding root from apps in the previously linked guide.
[Magisk] pol-der:
[MENTION=8126387]martyfender[/MENTION] Yes i don't need to pass Safetynet. Xposed is working good without any problem. Maybe it is harming (according to what you say) in background but i don't know and can't see. If i can find a way to do these features without Xposed, i will uninstall it completely by clean install but i couldn't find.

[MENTION=4667597]Didgeridoohan[/MENTION] I think i couldn't explain myself clearly. Let's try with a different way. For example i decompiled an APK with apktool and i am looking the source files without understanding. You are saying it is simple. It is simple for you not me. Even if I learn the basics of android programming (i don't know how much months it will take), this is not enough to review of module or APK. Anyway, thank you for your advises for this. I am using FakeGapps for signature spoofing in microG. Nanodroid is too much for me and it is installing unnecessary things for me.

---------- Post added at 06:04 PM ---------- Previous post was at 06:04 PM ----------

[/COLOR [MENTION=8126387]martyfender[/MENTION] Yes i don't need to pass Safetynet. Xposed is working good without any problem. Maybe it is harming (according to what you say) in background but i don't know and can't see. If i can find a way to do these features without Xposed, i will uninstall it completely by clean install but i couldn't find.

[MENTION=4667597]Didgeridoohan[/MENTION] I think i couldn't explain myself clearly. Let's try with a different way. For example i decompiled an APK with apktool and i am looking the source files without understanding. You are saying it is simple. It is simple for you not me. Even if I learn the basics of android programming (i don't know how much months it will take), this is not enough to review a module or APK. Anyway, thank you for your advises for this. I am using FakeGapps for signature spoofing in microG. Nanodroid is too much for me and it is installing unnecessary things for me.
[Magisk] martyfender:
If you have been using xposed for some time and have had no issues with it, I wouldn't worry to much about it. Especially if you have good backups such as nandroid backups. Like I stated earlier, xposed works well on many devices.
[Magisk] Didgeridoohan:
[MENTION=9593734]pol-der[/MENTION] I didn't say it was easy to decompile and analyse an APK... I said that Magisk modules are easy to figure out since they use relatively easy to understand shell scripts. APK's are a whole different beast, but if you're worried enough about that you'd have to decompile and analyse every single app you ever install...
[Magisk] pol-der:
I think there is no problem, but I don't know what's going on in the background.

[MENTION=4667597]Didgeridoohan[/MENTION] [MENTION=4487388]jcmm11[/MENTION] i told you which modules i am using. If you have free time or if possible could you please analyze those for us? I am really confused are they really adding security holes or something else to my ROM. I can wait for days, it is not problem. I would be grateful if you could.
[Magisk] BurnedDrake:
Which security holes specifically are being added that you are worried about? Look in the threads for whatever modules you are worried about. No one is going to do a security audit of xposed modules for you. If you are really worried about securing your device, why are you modding it?
[Magisk] pol-der:
I didn't request something from you? And are you lawyer of them?
[Magisk] jenslody:
I don't think anybody here will do a security audit of any modules (<t least not of contained apk's for sure).

A real security audit is nothing that can be done in five minutes.

If you are really concerned about security, you should not use any computer (including smartphones etc.), because all contain closed source parts that can not even be audited, in bios, bootloader, modem or other microcontrollers, that can have full access to your device.
[Magisk] pol-der:
Thank you for this polite and nice message buddy. I just thought that audit work can take maximum 2-3 hours for an expert or developer. And i didn't want this work as private just for me. If someone can do this, this will be useful to all people. I learned now it is hard work.

I wish everyone was as kind as you.
[Magisk] Lianthe:
Quick question: is 18 not playing nice with Titanium Backup? Force close every time; deleting the folder in data didn't work.
[Magisk] drothenberger:
It works fine for me.
[Magisk] martyfender:
Are you on a Oneplus or Huawei?

Look back a page or 2 where there is a link for what to do.

https://xdaforums.com/showpost.php?p=78610842&postcount=30304

Also see here:

https://dontkillmyapp.com/
[Magisk] Lianthe:
LGv20 using SuperRom v4.0 H918
[Magisk] Lianthe:
Ok, guess I stumped everybody; is there a way to at least roll back the Magisk version from 18?
[Magisk] Chinaboy5216:
Use the Magisk Uninstaller and install the wanted version afterwards

https://xdaforums.com/apps/magisk/dev-magisk-canary-channel-bleeding-edge-t3839337
[Magisk] Lianthe:
Is there a way to do it without losing root?
[Magisk] RandomPooka:
Do it all from TWRP, and you should have root still when you reboot, assuming you don't do something silly like boot back into your OS halfway through.
[Magisk] Chinaboy5216:
hi, if you stay in TWRP to uninstall and install a lower version of Magisk then that should do the trick
[Magisk] martyfender:
Yes but there are cases where you must reinstall a fresh stock boot.img before flashing Magisk.zip. all of this can be done in TWRP before you reboot in this order: Magisk uninstaller, stock boot.img, then Magisk.zip. Normally the uninstaller should restore the backed up stock boot.img but in some cases in may not be there, so what I outlined is usually a safer, plan.
[Magisk] Didgeridoohan:
If you had provided any more information than just "it doesn't work" it might have been easier to help... A logcat when the app force closes would be a good start. Many users, me included, use TiBu without issues on Magisk v18+.
[Magisk] tag68:
How does one generate the boot.img? Is restoring a Nandroid backup of the original not modified boot partition also sufficient?

I'm hesitant to search for the same firmware that I should have installed via OTA. I found they are not always the right ones and sometimes difficult to find.
[Magisk] martyfender:
Yes, that should be sufficient. The manufacturer of my devices never released stock roms, so I created nandroid backups with TWRP, when the devices were new, that I use to restore. I also keep a copy of my stock boot.img on the internal storage of my devices also that I can restore through TWRP. By the way, those stock boot.img's were backed up before they were patched with Supersu or Magisk, hence the term, stock. I previously used SuperSu.

I also have these TWRP backups for my 5 Nextbook Ares 8A's on my PC. From the PC I can also use fastboot to flash my stock boot.img or TWRP. Furthermore, I could create a system.img that could be flashed with fastboot from the PC, but have not had a need to do that yet and have not tested that option in TWRP.

Your Magisk backed up stock boot.img is stored in /data as a gzipped file that must be unarchived to use. It has a long file name which is also an SHA1 checksum for verification. The checksum should match the one for the image contained in the file and not the checksum for the archive, itself. I can view this checksum in Mixplorer under Info, hashes. Other file explorers have similar options.

What I proposed was a safe option, in case there is a problem with this backed up one.
[Magisk] jeffhart4890:
[MENTION=4470081]topjohnwu[/MENTION] sir, is there any way to select all apps in Magisk Hide ? Asking this so that Once all apps are selected, then one can only give root access to the desired apps by deselecting them in Magisk Hide. As of now we have to select all apps one by one in Magisk Hide, so selecting all apps at once & then deselecting the desired apps will be easier & faster. Thanks
[Magisk] jcmm11:
You DO NOT want to select all apps in Magisk hide. You should only be selecting those apps that have a problem and specifically need to be hidden from Magisk.

Adding apps to Magisk hide needlessly creates significant overhead and will probably lead to other issues.
[Magisk] martyfender:
Here is what [MENTION=4470081]topjohnwu[/MENTION] said about that in his twitter feed:
[Magisk] InTheWorks:
Can anyone spot what I'm doing wrong?

fastboot -i 0x2207 flash boot patched_boot.img
sending 'boot' (21817 KB)...
OKAY [ 0.564s]
writing 'boot'...
FAILED (remote: Write partition:boot)
finished. total time: 0.873s

This only happens with Magisk patched boot images. The stock boot.img writes fine as does the boot.img from hal9k_'s ROM. At first I though it might be size related, but:

-rw-rw-r-- 1 xxxx xxxx 22097192 Jan 7 11:30 boot.img
-rw-rw-r-- 1 xxxx xxxx 22421504 Jan 7 22:26 boot.img.hal9k
-rw-r--r-- 1 xxxx xxxx 22341075 Jan 8 01:21 patched_boot.img
-rw-r--r-- 1 xxxx xxxx 22341075 Jan 6 12:53 patched_boot.img.stable

patched_boot.img is larger than the stock boot.img, but hal9k_'s boot.img is larger than patched_boot.img.

I thought perhaps that it had something to do with keys, so I tried patching boot.img using magisk manager from here:

https://raw.githubusercontent.com/topjohnwu/magisk_files/master/canary_builds/app-full-release.apk

Because I read somewhere that canary builds use test keys and had the same problem.

I also tried booting with hal9k_'s boot.img, then running MagiskManager (stable and canary) and installing that way. MagiskManager seems happy with the operation, but on reboot it goes straight to recovery.

My hardware is an Android 8 (8.0.1) PX5 mtce head unit. It uses debug keys. I'm using USB OTG via hardware mod. Stock recovery.
[Magisk] Lianthe:
How about suggesting logcats first instead of spouting condescending crap to the inexperienced? The 'funny, it works for me' comments adds nothing as well. Thanks.
[Magisk] Didgeridoohan:
Wow... There was no intention of being condescending in my post. It was simply a reply to your comment that you had "stumped" everyone (which to me sounded like you were a bit annoyed at not getting any help after a mere two hours of posting your query).

And saying that TiBu works for me and others on Magisk v18+ was a reply to your original query if Magisk v18 wasn't playing nice with TiBu...
[Magisk] Spider210:
Anyone else having issue with the Jan 2019, creating a patched boot.img, mine comes out to about 4.25mb and boots phone directly into bootloader
[Magisk] tag68:
I tried to install Magisk on Moto Z Play Oreo, but it did not boot.

According to Alberto97 Magisk is not able to add the needed mount point in fstab.

He wrote it is necessary to flash a modified boot.img before installing Magisk to be able to install it:

https://xdaforums.com/moto-z-play/d...ficial-twrp-moto-z-play-t3495629/post78492195

This means that the backup Magisk does is not helpful for OTA in this case, it needs to be the original one. Nandroid will help, thank you very much.
[Magisk] warrencoakley:
Noticed in v18.0 that the safety net check is very temperamental at times.

Seems to randomly go offline/online very often compared to 17.3

Usually a reboot fixes this issue.

Surley there must be a bug somewhere.

Any ideas?
[Magisk] XzndrDroid:
Hi, I'm unable to install Magisk on a Nexus 5X. Here's what I'm doing:

-Installed TWRP 3.2.3-0

-In TWRP: Wiped Dalvik, System, Data, Internal Storage and Cache.

-Installed Android bullhead-opm7.181205.001

-Completed setup until I reached the desktop

-Reinstalled TWRP 3.2.3-0

-In TWRP: sideloaded Magisk v18.0.

=> Shortly after "repacking boot image", the device shuts down

Any idea what could cause this?

I also tried with TWRP 3.2.2, and with bullhead-opm7.181105.004, but I'm getting similar results.

Thanks
[Magisk] RandomPooka:
I don't have that device, but I have to wonder why you're sideloading and if having the zip on your device in order to just flash normally with TWRP might fix the issue.
[Magisk] iluvatrix:
Hi guys just wondering if I decided to roll back to magisk 17.3 which version of magisk manager should I use?

Also is it possible to turn off the nag to update to 18.0?
[Magisk] XzndrDroid:
If I remember correctly, using the TWRP sideload feature works pretty much the same as the manual push/install process. But anyway, I just tried as you suggested, and also didn't enable encryption from the start. It helped a bit, but now the phone is now very unstable and crashes randomly. I had observed that previously too.
[Magisk] RandomPooka:
Glad you got it installed. I'm no help on the instability issues. But, if they were there before Magisk, I would assume that they're unrelated and the ROM thread that you got it from is the best place to find knowledgeable help.
[Magisk] jcmm11:
He's running stock. I have a Nexus 5x buried somewhere, I may try to dig it out. Won't be very quick though, hopefully he'll get it resolved before then.

I do know that through the November patch I didn't have any problems installing Magisk (think it was 17.4 at the time)
[Magisk] bruno$0:
I can't install magisk 18.0 over omni 8.1 rom for sony xz. Everything seems okay in twrp. Already used boot bridge for sony kernel. It's dosen't work... 17.3 works fine.
[Magisk] jenslody:
Check if the Manager is installed to external/adoptable storage, if yes move it to internal.
[Magisk] umiuni223:
//play.google.com/store/apps/details?id=com.shinhan.smartcaremgr

this app was detecting root. could u patch it on next update?

this is banking application. (magsik hide was checked)
[Magisk] warrencoakley:
Are you having issues with 18.0? And if so what are they? The safety net feature seems to be more offline then on for me.
[Magisk] iluvatrix:
What you said.
[Magisk] warrencoakley:
Ok so it's not just me then. You can just flash 17.3 if you want but I hope they fix the bug.

---------- Post added at 11:04 AM ---------- Previous post was at 11:00 AM ----------

Can you fix the bug with the temperamental issue with safety check in v18? Seems to constantly go offline. Never use to happen with v17.3
[Magisk] nikal:
Titanium backup not detecting root

Hi!

I'm posting here after [MENTION=4667597]Didgeridoohan[/MENTION] suggested to do so.

I own an old spec tablet based on LP 5.1 stock, rooted with Magisk (kantjer update channel). I faced various issues which I managed to overcome but this one with TB and root. Did anyone have any similar experience ?

Root checker applications detect root and busybox (by [MENTION=4544860]osm0sis[/MENTION]) and I don't have root detection issues with other root compatible apps (so far). I am making clear that at the moment I don't care if my device passes Safetynet. I am not planning to use banking apps in this device for the time being. In the mean time I will try to get a logcat and post it here for further investigation.

Thanks in advance for your help.
[Magisk] JaskaranIsGreat:
It is not working on vivo y21L....

Please help me to root vivo y21L....

Please....
[Magisk] bruno$0:
It was installed on internal memory. I think its a 18.0 bug.

I run matlog app and thwn run magisk app. Seems that somethings isn't ok.
[Magisk] Wolfcity:
Logs? Android version? TWRP? What is not working?

Nobody is able to help you without any information.
[Magisk] JaskaranIsGreat:
Android version-5.1.1

TWRP-3.2.1

Not working -Magisk v18.0

Logs-don't know how to show
[Magisk] bruno$0:
I found something on log:

Start proc 14999:com.topjohnwu.magisk/u0a193 for activity com.topjohnwu.magisk/a.c

01-09 10:02:20.270 W/main (14999): type=1400 audit(0.0:5436): avc: denied { read } for name="u:object_r:wc_prop:s0" dev="tmpfs" ino=16805 scontext=u:r:untrusted_app:s0:c512,c768 tcontext=u:object_r:wc_prop:s0 tclass=file permissive=0

Maybe the process could not start properly on 14999 port.