yashsingh1/xdaforums huggingface dataset:
[Magisk] Vivekvkr7:
I can't flash magisk . It shows error 1 . I've tried almost every possible solution . Wiped everything and the did a clean install even after that it shows error . I can't even flash SuperSU zip . I've tried flashing the original boot.img of the ROM but it didn't help . Any solution ?? . Please help . Thank you .
[Magisk] jcmm11:
You're missing a few items.

What phone?

What ROM?

And most important - where are the
[Magisk] Hadookie:
I ended up flashing back to stock in order to fix my issues. Thank you for your reply as I will keep everything you said in mind next time I mess with trying to get an OTA to install (next month).
[Magisk] sekk:
Guys, is magisk compatible with Moto Z2 Play Android oreo 8.0? I'm wondering to root, but I've already updated to oreo.

Anyone can help?
[Magisk] peterlee928:
fyi - i found that replacing osm0sis busybox (magisk module) with stericson's busybox has solved my issue. dunno if this is coincidence or not.

EDIT

still experiencing the same issues smh... came back with a vengeance
[Magisk] Vivekvkr7:
My phone is Redmi Note 4 (Snapdragon) and the ROM i'm using is dotOS . I extracted the boot.img of the ROM i'm using and flashed it but didn't help . And one more thing my device is not rooted but i've flashed magisk earlier with RR ROM which was my previous ROM and it was showing "vendor image mismatch and something "NRD90M" " after my first update of RR version and after flashing another ROM this was the first prompt "your device has an internal problem please contact your manufacturer" . And I can't flash SuperSu too .
[Magisk] zeduck:
No, I don't.

I was waiting to flash LOS rather than CypherOS but, as you said, it doesn't seam to change anything.
[Magisk] Vivekvkr7:
My phone is Redmi Note 4 (Snapdragon) and the ROM i'm using is dotOS . I extracted the boot.img of the ROM i'm using and flashed it but didn't help . And one more thing my device is not rooted but i've flashed magisk earlier with RR ROM which was my previous ROM and it was showing "vendor image mismatch and something "NRD90M" " after my first update of RR version and after flashing another ROM this was the first prompt "your device has an internal problem please contact your manufacturer" . And I can't flash SuperSu too .

---------- Post added at 05:21 AM ---------- Previous post was at 05:10 AM ----------

My phone is Redmi Note 4 (Snapdragon) and the ROM i'm using is dotOS . I extracted the boot.img of the ROM i'm using and flashed it but didn't help . And one more thing my device is not rooted but i've flashed magisk earlier with RR ROM which was my previous ROM and it was showing "vendor image mismatch and something "NRD90M" " after my first update of RR version and after flashing another ROM this was the first prompt "your device has an internal problem please contact your manufacturer" . And I can't flash SuperSu too .
[Magisk] hteles:
Ok,

Thanks.

I've asked the question at ThePiGuy unofficial thread. I think this is related to LG G4 titan/oreo rather than Magisk.

Regards.
[Magisk] cetoo:
Hey man. Thx for your answer. I looked for every txt file in my phone. Cant find anything. In magisk app log was empty too. Than i started disable my modules step by step. When i disabled xposed, wow there is no lag. My all modules were active but there is no lag. Then i cut my eyes to into sherlock mode. Started xposed module checking by step step. And result was so amazing. Lucky patcher module was the criminal. By killing my phone from lag. Googlet it and i saw i wasnt first. Don't know why, but it caused lag on some people. Now i feel like i betrayed the Magisk all hail magisk! God bless topjhon.
[Magisk] bigrat:
I don't have much to add but "THANK YOU"! My bank didn't "like" LineageOS, and that was causing me problems. Working well here on a Nexus 5x.

EDIT: I haven't posted here since 2013. See what you made me do? :)
[Magisk] arshia.sunboy:
my problem with magisk.whats this?
[Magisk] kallell:
Anyone having issues with the latest android P beta? Trying to patch the boot image through the app, but it keeps failing.
[Magisk] joefuf:
Sorry to ask this question as I imagine that it has been asked in this thread more times than people can count... I have Magisk installed on my Moto Z2 Play (XT-1710-01 Retus) and I want to install OTA updates. I did not flash a custom recovery or TWRP, that's all still stock. I haven't tooled around with rooting Android and updates in a while, this being the first phone I've used Magisk on, so I'm not used to having to deal with locked bootloaders and such, but I am competent enough to follow directions if anyone can help me...

I have come to understand that the inability to install OTA updates is a result of Magisk, (so I need to uninstall Magisk) and I will need to flash a stock ROM for my device. I believe the users in my device's XDA threads have compiled the stock ROMs here.

If I understand correctly, the steps I will need to take are as follows. Please correct me if I have anything wrong!

1. Following the instructions from [MENTION=4470081]topjohnwu[/MENTION] here on GitHub, I have gone into Developer Options and disabled Automatic System Updates.

2. Then, I will go into Magisk and click Uninstall → Restore Images, and I will not reboot immediately or I will have Magisk uninstalled

This is where I need some help...

A. Am I going to have to boot into fastboot mode and fastboot into TWRP from here so that I can flash the stock ROM for my device?

B. Which ROM do I flash to my phone? Is it the same version that I currently have installed or should I flash the most recent update?

C. Do I not need to flash a stock ROM and I just need to get to the uninstall Magisk part so that I can install the OTA update?

Am I on the right track? Am I nowhere close? Is there somewhere better I should post to find these answers?

I sincerely appreciate any help someone can give me.
[Magisk] pic2022:
I'm trying to install Magisk on my Pixel XL Gen 1 on the P beta but I'm getting this error.

I updated my phone through system update, first time this has ever worked for me, I'm assuming this could be my issue. Still not sure though. Any ideas with what's going on? I downloaded this build, extracted it, took that boot.img and put it on my phone, even though it's still the same boot.img from 2009.

Device platform: arm64-v8a

- Extracting files

- Boot image is signed with AVB 1.0

Failed!

Bad system call

! Installation failed

EDIT: Fresh install didn't work. Still getting this error.
[Magisk] Didgeridoohan:
Moto devices might have f2fs loopback issues, but there are workarounds for that:

https://xdaforums.com/apps/magisk/guide-magisk-official-version-including-t3577875

Or you could reformat your device to ext4, but that'd wipe your data and some devices won't work properly if you change the file system.

Other than that the shouldn't be any issues...

"Error 1" might mean just about anything, and no-one will now exactly what until you provide the installation/recovery log from when you're trying to install Magisk.

Your vendor image mismatch message doesn't sound like something caused by Magisk. That usually happens if you update your system but not vendor, causing them to mismatch. I'd ask for advice in your ROM thread.

If I understand you correctly you loose Magisk functionality after a while, or?

Best would be if you could provide some logs, but since you loose root that might get a bit trickier. The logs that are interesting in this case would first of all be the Magisk debug log, so you would have to be on the beta release of Magisk.

When you loose root, reboot to recovery (I'm assuming you're using a custom recovery here) and copy the magisk_debug.log from /data/adb.

The inability to update with an OTA is because Magisk patches the boot image. There are a few prerequisites for updating with an OTA:

Stock recovery

Stock boot image

Several partitions need to be completely untouched, such as /system and /vendor

You have the stock recovery, and you can easily restore the stock boot image in the Magisk Manager.

After that it should be just a matter of applying the update as normal, if there is one. [MENTION=4470081]topjohnwu[/MENTION] talks about this way in the instructions you linked.

If the OTA fails, there's a possibility that /system or /vendor has been modified. This could be caused by several things. Any app with root access would be able to alter your device.

I'd give it a try, and if it fails please return with details about what failed and any error messages and such.
[Magisk] hl46000:
uiautomator command not working

uiautomator dump return ERROR with MagiskSU

[IMG="uiautomator dump error"]https://sv1.uphinhnhanh.com/images/2018/05/10/Captured4ba1.png[/IMG]
[Magisk] Tachyonic007:
Safetynet Error

Due to some changes in Google play services, it's not possible to check safetynet on repackaged magsik manager.

---------- Post added at 05:59 PM ---------- Previous post was at 05:58 PM ----------

Due to some changes in Google play services, it's not possible to check safetynet on repackaged magsik manager.
[Magisk] Didgeridoohan:
That's not an error, it's information.

If you've hidden the Manager (repackaged it), you can't use it to check SafetyNet. Use some other app if you need to check SafetyNet.
[Magisk] joefuf:
First of all, thank you very, very much for responding.

I definitely never touched the stock recovery. But I did however go in with System app remover when I was rooted and I uninstalled some bloatware and random apps that came with the phone. Is that going to count as having messed around with /system and /vendor? Also went in with Root Browser and added a line to /system/build.prop. Might that also cause any issues?

Any guidance on how to patch a boot.img with Magisk?
[Magisk] biggdevon:
Do you have to completely uninstall then reinstall in order to downgrade/revert back to a previous version? Or can it be reflashed?
[Magisk] ksio89:
I have an ASUS ZC553KL (stock ROM) with SuperSU and Xposed Framework installed. It it just a matter of removing root within SuperSU, and then flashing Magisk in custom recovery and then Magisk Manager apk? I'd like to use MagiskHide actually to attempt to hide root from a specific app, but as Magisk has it's own superuser manager, I would keep it and ditch SuperSU for good. Thanks in advance.

edit: I read that Xposed can trigger SafetyNet thus allowing apps to detect root, is that right? Can I just disable Xposed, or do I need to uninstall it?
[Magisk] jcmm11:
Yes

Yes

(Even just mounting system as rw, but not actually applying any changes, can cause an ota to be rejected)

See the op in the announcement thread https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445
[Magisk] joefuf:
Okay, just noticed the option to patch a boot.img file when you click Install. I've just been clicking the direct install option to update Magisk so I didn't realize that's where that was hidden. I thought it was a separate function.

So since this likely means that my /system and maybe my /vendor have been altered in some capacity, is there any method of recourse?
[Magisk] teddy0209:
You have to return to stock. If you can find a full rom for your device, that should do it.
[Magisk] Didgeridoohan:
You can use the full unroot option in the SuperSU app, as long as you restore the stock boot image. The SuperSU modifications will conflict with Magisk otherwise... More details on that here:

https://www.didgeridoohan.com/magis..._another_systemless_root_solution_to_MagiskSU

Xposed

will

trigger SafetyNet. Always...

If you need Xposed, change up [MENTION=4470081]topjohnwu[/MENTION]'s systemless version, that you'll find in the Magisk Manager Downloads. If you then need to use an app or service that doesn't like Xposed, you can simply disable the Xposed module in the Magisk Manager and reboot.

Really? Where have you seen that? [MENTION=4470081]topjohnwu[/MENTION] even provides one of the systemless Xposed modules available for Magisk...

Just to clarify: Xposed being systemless doesn't prevent detection, it just makes Xposed easier to disable if you want to use an app or service that triggers if it detects Xposed.

Does that option restore the stock boot image? If not, it's not going to work... Unless it's a system install of SuperSU I guess, but most installations are systemless these days.

Just wanted to give a head up that there's no such option, currently, in the Magisk Manager. You can use your fingerprint to authenticate superuser requests, but no PIN. It's also not a foolproof safety setting, since the Manager settings itself aren't protected... There's been discussion and ideas on how to move forward with that, but nothing substantial as of yet.

Best. Advice. Ever.
[Magisk] Rom:
@topjohnwu

Hello, i think there's an oversight in the Magisk Manager original strings file:

<string name="checking_for_updates">Checking for updates…</string> <string name="magisk_update_available">Magisk v%1$s is available!</string> <string name="invalid_update_channel">Invalid Update Channel</string> <string name="safetyNet_check_text">Tap to start SafetyNet check</string> <string name="checking_safetyNet_status">Checking SafetyNet status…</string> <string name="safetyNet_check_success">SafetyNet Check Success</string> <string name="safetyNet_api_error">SafetyNet API Error</string> <string name="safetyNet_network_loss">Network connection unavailable</string> <string name="safetyNet_service_disconnected">Service has been killed</string> <string name="safetyNet_res_invalid">The response is invalid</string><string name="magisk_version_error">Magisk is not installed</string>

There is no string for the case of an SafetyNet error, that cause in any SF result, the string for an good result will be permanently display, even if the SF response is false.

Idk if this oversighthas been already reported but i think it's sufficiently important to be noted :)

I have make the test, without Xposed module (the system-less one), i get a good SF result. After having enabling Xposed module in Magisk Manager and reboot my device, i get the same success short message on SF test and two bads reports for "ctsProfile" and "basicIntegrity".
[Magisk] jenslody:
I would says, it's a little bit misleading, but in the case you mentioned safetynet-check succeeds in general (therefore the message), but it returns false for cts and/or basic integrity.
[Magisk] Rom:
Yes but in the wrong case, the string don't exist, forgetfulness is minimal, but it could be misleading for "new" users with Magisk.
[Magisk] Didgeridoohan:
What do you mean "the string doesn't exists"? The SafetyNet check is either successful, as in: there's a response from the server, or it's not successful in which case you get one of the other messages (API error, invalid response, etc).

That the response is successful does

not

mean that you pass SafetyNet. That's determined by the kind of response you get, ctsProfile and basicIntegrity either true or false. A successful response just means you got an answer from the Google servers.

Yes, it can be confusing... :silly:
[Magisk] Rom:
As i quoted on my first post, there isn't the "string" (in the Magisk Manager repo source) for the bad SN result.

Yes, quite, for us who are aware of what is happening in "submarine", we can deduce and understand what is happening on the phone, but i think that this could lead to confusion for less comfortable users, who would therefore have a simple sentence stating in both cases that the SN control is bad, and the probative result for both tests that could be brought to varrier, but as far as the simple sentence, it never changes for the moment.
[Magisk] Snowbrand:
Hi, I might need some help with magisk and a problem I run into. I rooted and unlocked bootloader on my phone (Htc Desire 10 lifestyle) and installed SuperSU. But later I realised I couldn't use some apps like payment apps like google Pay and so on and therefore wanted to change to Magisk instead.

Well, so I uninstalled SuperSU by uninstalling it normally like any other app, but then I realised I might need to uninstall it manually by downloading the uninstall SuperSU zip. So I did that and then tried to flash Magisk zip through twrp. I got error 1 and I tried a few times without it helping.

So I thought I might have to flash the stock image instead because magisk couldn't finish the download. Found the RUU files for desire 10 and extracted the boot_signed.img from it and then flashed it by going into custome recovery >install>install image. After that I flashed the magisk zip and it seemed like it worked because I didn't get an error this time so I thought it had worked.

Before this I could boot normally, even though I lost root acess when I uninstalled SuperSU (still have/had twrp and custome recovery though), but after I did this I got stuck in the bootloader and I can't boot normally anymore so I guess it is soft bricked now. My guess is that somehow something went wrong with boot.img or that I didn't uninstall SuperSU properly.

What can I do, any ideas of what went wrong and if there is any way to fix this, or am I stuck with a bricked phone now? I have a feeling a factory reset won't work, because the problem is I think that I don't have a working boot.img or something along these lines that a factory reset won't help with anyway. I have tried some proposed solutions to fix bricked phones, but can't find anything that works. Thanks for the help anyway.
[Magisk] jacobyo7:
Not really the best thread for this, but I'll try to help you anyway. Download your full stock Rom (that you can find on XDA if you go to your specific phone forum), do a wipe data / cache / dalvik in twrp and then flash your full stock Rom. You should be able to boot again, but of course if you had any important data on your phone, they will be lost. Hope you can resolve your problem with this. Good luck!
[Magisk] Snowbrand:
Okay thank you! Well, I'll give it a try and see how it goes and come back with the results. The full stock ROM is the same as the RUU files right? I didn't have anything that important, most of it was saved on my google account anyway though.
[Magisk] ketwi15:
Guys, any idea why I've gotten locked out my Snapchat twice for third party apps when Magisk is all I use?
[Magisk] :
Whenever I flash, MIUI, TWRP, Lazy flasher, and then magisk zip. Magisk works. But when I flash lineage OS, gapps, and then magisk, there's an error

Cannot mount \vendor

magisk updater process ended with error 1

After flashing lineage OS and gapps, I tried flashing stock boot.img from MIUI fastboot ROM and then magisk. It doesn't help.
[Magisk] teddy0209:
Attached the recovery log, maybe someone can help. And don't use MIUI boot.img on none MIUI rom.
[Magisk] :
I tried the boot.img of lineage OS as well. It gave me the same error

I reverted back to MIUI by flashing fastboot ROM after getting the error in lineage OS. Is the log sufficient?

Uninstalling magisk also giving me the same error.
[Magisk] Didgeridoohan:
Your log doesn't show anything but a successful installation of Magisk, so I'm assuming it's from when you had MIUI installed.

It does show that you're trying a Redmi Note 4 Mido. And your problem is a known issue with that device... It's not a Magisk issue at all, but an incompatibility between the ROM and TWRP version you have installed. Take a look here:

https://xdaforums.com/apps/magisk/mount-vendor-t3774704
[Magisk] :
The same error when trying to uninstall magisk. Does flashing stock_boot_........img.gz from /data resolves the issue?
[Magisk] Didgeridoohan:
No, that's not the same error....

You previously stated that you get the "unable to mount /vendor" error when trying to install. You can fix that by changing your TWRP, like it's stated in the link I gave you.

The error you get when you are flashing the uninstall zip is caused by the removal of 64-bit binaries in Magisk. That's been fixed internally, but meanwhile you can use this uninstaller zip instead: https://github.com/topjohnwu/Magisk/releases/download/v16.3/Magisk-uninstaller-20180328.zip
[Magisk] :
I'm unable to update Magisk Manager to 5.7.0(115) after flashing Magisk 16.3 mido treble support in Lineage OS 15.1 and I'm unable to install any modules. And phh superuser showing SU binary out of date. Please help
[Magisk] :
I attached the log
[Magisk] Didgeridoohan:
What do you mean: "unable to update Magisk Manager"? Please provide more details, and possibly a logcat of the issue.

That module is outdated and you can't install it on Magisk v16.3+.
[Magisk] :
For now, I'm providing the screenshot. Package manager says app is installing, but in the end it says app not installed. I'll provide logcat asap.
[Magisk] Didgeridoohan:
Do you happen to have an unofficial Magisk Manager installed, by any chance? Even if you haven't, I would simply uninstall the current Manager and install v5.7.0 fresh.
[Magisk] :
Log cat for magisk manager not installed
[Magisk] :
Thanks issue's been resolved
[Magisk] jenslody:
Or (to keep all settings) hide the manager (repackage it) from the settings and update it, that works even if the old Manager has a different signing key.
[Magisk] -MB-:
Does flashing an official MIUI rom via miflash (On a redmi note 4x) completely remove any root and/or magisk installs?
[Magisk] Artim_96:
Most likely. I don't know how miflash works, but I also don't know how Magisk's recovery scripts work. I think they are able to keep Magisk on OTA updates... Maybe. But especially update tools normally flash the whole system, so no chance of survival. But as long as no factory reset happens you'll just have to flash Magisk since the image containing the modules should be untouched in the data partition
[Magisk] Snowbrand:
Well, I did as you said and now it works again! Thx :) Now I'll see if I can get magisk to work this time...
[Magisk] Augustoandro:
Magisk Hide is not working in Magisk 16.4.

Whenever I mark an app in Magisk Hide, it is automatically unmarked when I close the app.

Hence, I am not able to hide my root.

How can I fix this?
[Magisk] Didgeridoohan:
Have you tried turning it off and on again? Do you have the hidelist file in /sbin/.core/img/.core? And more importantly: where's your Magisk log? Please post it...
[Magisk] :
Does this Magisk works on Zenfone 2? I heard that the x86 or something is removed in the zip, so it causes bootloops...

My phone is being fixed now...
[Magisk] martyfender:
It works great on my Nextbook Ares 8A's with Intel x86 processors.
[Magisk] :
But different bootloaders...
[Magisk] martyfender:
re-reading your post, I think you are confusing x86 with the removal of 64 bit binaries that is causing some users to have problems. There is an unofficial build with those 64 bit binaries added back.

https://xdaforums.com/showpost.php?p=76390955

And yes, it appears your Zenfone 2 uses a 64 bit processor, unlike mine, so you may want to try the unofficial, 64 bit, build.
[Magisk] gajju.m:
Same with me ..

Here's my log.
[Magisk] :
Can I use Magisk 16.3 official beta build which does not have the changes of removing 64bit binaries in 16.4?

And with official 16.0 one?
[Magisk] Didgeridoohan:
You sure it's the same issue?

Your log shows that MagiskHide is running, and that you've added several apps to the Hide list. There's no indication of MagiskHide hiding from anything, but that might just mean that there was no such instance before you saved the log...

Describe your issue in a lot more detail please.

Go for it. Magisk v16.0 or v16.3 beta, either of them should work.

If you can't get it working, it should be only a simple matter of restoring your stock boot image to remove Magisk again. Just make sure to have this uninstaller handy, rather than the one that comes with the v16.4 beta release:

https://github.com/topjohnwu/Magisk/releases/download/v16.3/Magisk-uninstaller-20180328.zip
[Magisk] :
Magisk downloads shows no modules found
[Magisk] Didgeridoohan:
Have your tried pulling down to refresh?
[Magisk] :
Yes, I did
[Magisk] Didgeridoohan:
You can also try clearing the repo cache in the Manager settings and refresh the list again. If it still doesn't work you've likely got some kind of connection issue or something blocking the connection for the Manager.