yashsingh1/xdaforums huggingface dataset:
[Magisk] LlamaLord:
Just installed a fresh new room and installed Magisk. Trying to run my uConnect app for my Dodge car but keep getting an error due to unsupported device. I tried to use Magisk hide but still did not work. Anyone else see this problem?
[Magisk] Flyview:
Hey fellow devs! I'm not sure if this is the appropriate thread to ask some questions about Magisk's libsu, the su library you can build into your root apps.

I've read through the Github page and the documentation site but I still have a few questions. Let's start with the easiest:

What's the proper way to check for root?

I tried using Shell.rootAccess() which returns true or false synchronously. This seems to work great in an Activity with the following flow:

1) You call Shell.rootAccess()

2) The user gets the allow/deny root access dialog from Magisk

3) UI thread seems to pause during the decision

4) If you choose allow, it returns true, if you choose deny, it returns false.

However, if you're checking for root in a StartReceiver, say after BOOT_COMPLETED or ACTION_MY_PACKAGE_REPLACED, and you deny access (or has already been denied), the call never returns resulting in an ANR. If you choose allow access, then it returns true and works as usual. Any thoughts on this?

Another smaller gripe I have is that if you change an app's root access through Magisk Manager, it doesn't actually get allowed/denied access until you restart the process of that app (including killing all services and activities).
[Magisk] yochananmarqos:
Did you try clearing uConnect's app data after adding it to Magisk Hide?
[Magisk] dieGeist:
It was both. I ended up reinstalling Magisk (16.4) and not reflashing the 'BLOD Workaround AK2' and all seems to work now.

Not sure what caused it to stop working in the first place (as I hadn't updated anything. Just the stock 6p image + TWRP/BLOD/Magisk)
[Magisk] LlamaLord:
Tried did not work...
[Magisk] DiamondJohn:
I normally use ADB over WiFi, and thus am not reliant on a cable into the back of the computer.
[Magisk] John D J:
Hi can anyone please help me? I have a galaxy s4 on stock rom (lollipop ) I root my divice put magisk on but it won't hide any apps I've tried cloak root xpose installer but nothing seems to work. What am I missing please? Safety net won't establish either.
[Magisk] Didgeridoohan:
When you say "won't hide any apps", do you mean actually hiding the apps on the Hide list from other apps? If so, that's not what MagiskHide does... It hides Magisk and it's modules from the listed apps, nothing else.

SafetyNet won't pass with Xposed installed and active.

Edit: does the S4 have a new enough Linux kernel? Version 3.8 or newer is required for MagiskHide to work. Read more here: https://www.didgeridoohan.com/magisk
[Magisk] teddy0209:
What exactly are you trying to hide?... Safetynet won't pass with xposed active on your device.
[Magisk] John D J:
I'm trying to hide rooted device from a banking app. And thanks for the info on xposed, appreciate it.

Kernel is 3.4 damit
[Magisk] davidzam:
Yes. If you have xposed installed, "normal" instalation or magisk installed xposed, Safety Net will break. You should try to disable xposed to see if it work's, the banking app I mean.

Enviado desde mi SM-G550T1 mediante Tapatalk
[Magisk] AnDrOiDnEoV:
Hi,

I'm getting the following error while flashing magisk uninstaller - latest magisk stable version and latest magisk uninstaller. Oxygen OS 5.1.0

I can use TWRP filemanager to view the files /data/adb/magisk and there are no encrypted files in it.

Thank you for your help.
[Magisk] John D J:
What can I do to change stock kernel from 3.4 to 3.8 please? Is there anything out there? Actually xposed installer doesn't install framework as it says it doesn't support my device (s4). So I'm puzzled. :eek::confused:

Safety net ctsprofile false integrity false.
[Magisk] Strephon Alkhalikoi:
Nothing. Kernel upgrades like that are nearly impossible on Android.
[Magisk] Didgeridoohan:
Like already stated, that's almost impossible... But, there is a possibility that someone has backported mount namespace support for your device in a ROM or custom kernel. That would make it compatible with MagiskHide. It's far from easy though, so don't hold your breath...

Best place to find out if it has been done is in your device's forum.

Good luck. :good:

---------- Post added at 11:00 ---------- Previous post was at 10:58 ----------

That's because SafetyNet is detecting Magisk, since MagiskHide doesn't work on your device.
[Magisk] davidzam:
Try this. Read the post. I think you can try this. And you'll get an android update in the process. Your call though...

https://xdaforums.com/galaxy-s4/i9505-develop/rom-untouched-stock-rom-t3419034

Remember read and do everything you can to follow all the steps.

Enviado desde mi SM-G550T1 mediante Tapatalk
[Magisk] 123lisa:
It fails to unpack the boot image and aborts with Error 1 when flashing that zip (no-verity-opt-script-6.0.zip).

---------- Post added at 11:52 AM ---------- Previous post was at 11:46 AM ----------

I don´t have that option in the development options where I can turn the Debugging mode on and off. But was a good idea to use that in first place, so thanks for trying to help me with that problem.

---------- Post added at 12:16 PM ---------- Previous post was at 11:52 AM ----------
[Magisk] AnDrOiDnEoV:
I used the version Magisk-uninstaller-20180328.zip and uninstalled Magisk.
[Magisk] rn4Nlos:
Is magisk with treble support for mido (Redmi Note 4 Snapdragon) available yet?
[Magisk] Artim_96:
Try it out. In theory there shouldn't be problems with Trebble, just try if latest stable/beta is working. If not make a bug report so it can be added as soon as possible
[Magisk] DiamondJohn:
Maybe last_kmsg would provide what your looking for. Its basically a log_cat from the previous boot
[Magisk] ncrmnt:
I have the same issue on my dumpling (oneplus 5t) since LOS may 28 nightly builds. With 5th june nightly the issue persists. Lineage without magisk works like a charm, but installing magisk causes the device to boot directly to fastboot mode.

My wild guess is that the resulting boot.img just doesn't fit into the partition and gets truncated (thus becomes unbootable). This pull request claims to at least report the issue: github.com/topjohnwu/Magisk/pull/388 But I've no idea how to fix that. Any ideas?
[Magisk] qtvvtx:
Did you try Magisk with a different kernel, like the EX-kernel?
[Magisk] ncrmnt:
Nope, only lineage 15.1 stock one.
[Magisk] Didgeridoohan:
It's likely the same as this:

https://xdaforums.com/showpost.php?p=76726794&postcount=5719

And if so, can be fixed by this:

https://xdaforums.com/showpost.php?p=76734324&postcount=5723

https://github.com/topjohnwu/Magisk/pull/389

And there's not much you can do about it until it's been implemented in Magisk, except to stay on a LOS build that works, until then.
[Magisk] ncrmnt:
Thanks a ton! I guess I'll just try and recompile magisk with that magic pull request included and see if it works for me!
[Magisk] qtvvtx:
Suggestion: extract boot.img from a previous L-version that worked with Magisk. Flash that previous boot.img with twrp. When it doesn't bootloop you may try Magisk again.
[Magisk] benno1237:
Hello guys,

I have got a Samsung Galaxy Note 4 (SM-910) running LineageOS 14.1 Unofficial. I am trying to install magisk on this rom using twrp but after flashing magisk my phone isnt booting. I can shut it down and flash the uninstaller and then its working again. I have tried with Magisk 16.0, 16.4 Beta, 14.5 Beta. I am using Magisk Manager v. 5.7.0 and twrp v. 3.2.

Is there any way to install magisk properly on my phone?

Thank you for your help
[Magisk] Novakingwai:
I'm trying to install Magisk on Pure Nexus Rom on Google Pixel XL. I tried doing this in TWRP recovery and with the Magisk Manager. It says failed and I need to restore stock boot image. I was using the recommended settings in the Magisk Manager. Should I try the option to patch the boot image? Is this compatible with Pure Nexus?
[Magisk] Richy1989:
Magisk and "WiFi Tether Router"

Hey.

I'm using the app "Magisk and "WiFi Tether Router" from Fabio Grasso <snclabs@gmail.com> which is working like a charm with SuperSU.

Since everybody nowadays is using Magisk, I switched to it and had to note that it is not working with Magisk.

I talk with the developer from the App and he told me it is not his fault. He thinks and I quote:

"MAGISK has problems with some root commands

it fails to execute some root commands

maybe its developers should release an update"

I know that I can't aks any special Bug to be fixed. But I was just hoping to raise awareness that this app, which obviously need a lot of permissions to its job, is not working with Magisk.

And since you are the new big player is the SU marked I hoped there may be a solution sometimes in the near future.

Thanks Anyway.

Regards.
[Magisk] Didgeridoohan:
[MENTION=2966765]Richy1989[/MENTION] That sounds unlikely... Possible, of course, but most of the times these kind of issues need to be fixed in the app.

If you or the developer of the app could show which these root commands are, that fail, that would be very useful if it turns out that it's something that can be improved in Magisk.

Just stating that "it doesn't work" is unfortunately, in most cases, quite useless...
[Magisk] Richy1989:
Yeah I know.

Just thought I give it a try.

Becuase I don't know the Developer neither do I have any connections to the Magisk Team.

Maybe I will write the Developer a Mail for more informations.

Thanks for the answer anyway.

Have a great day.
[Magisk] Didgeridoohan:
[MENTION=3666694]Kamil.Blaha[/MENTION]

Well, it's obviously not a module issue, so any further posting in that thread would have been OT. Let's move things here instead.

Magisk isn't installing as it should on your device. Why? Don't know.

Try installing the beta release (currently v16.4) or an unofficial snapshot from the current code.

If that doesn't work, please post the magisk_debug.log. And don't post it in plain text, please. It's always best to attach log files to the post, or upload them somewhere and provide the link.

Edit: Oh yeah... Don't forget to post the installation log from when you install Magisk as well.
[Magisk] Kamil.Blaha:
I am sorry for pasting plain texts, but I do not see any possibility (icon) to add an attachment around "reply window".

OK, I will try beta 16.4. But: what shoult I do before installing it? Uninstall "MagiskManager-v5.7.0.apk"? Run uninstaller for "Magisk-v16.0.zip"? Backup of partitions (which one)? Flash boot.img (I have backup from another TA-1032 phone with identical Android version - is it possible to use it?). What else?
[Magisk] Didgeridoohan:
Ah yes... I did not note that you have too few posts to be able to attach any files, or post links. You could use Pastebin and then just post the paste id, or in worst case at least use the forum HIDE tags around the log text, if you post it directly.

You could try to do a dirty install first. Just flash the new zip over your current installation. If that doesn't work it should be enough to flash the Magisk uninstaller before flashing the new version.
[Magisk] Kamil.Blaha:
Thank you. During saturday I will check Magisk errors at my second phone. If it would show the same problem, I will try to "play" with the second phone rather than with mine work phone. I will post a message with results.
[Magisk] Novakingwai:
This is my error log when trying to install
[Magisk] Didgeridoohan:
https://www.didgeridoohan.com/magisk/Magisk#hn_Boot_image_patched_by_other_programs
[Magisk] Novakingwai:
Would you happen to know where to get the boot image?
[Magisk] Didgeridoohan:
It actually says in the wall of text I linked you...
[Magisk] ncrmnt:
Thanks a lot for the tip! I took the long way to install Android SDK at my box, recompile magisk from source with the pull request that fixes the issue applied - and worked like a charm! :good: I'm attaching the binaries to this post so that we have a working solution until the merge is accepted and the next Magisk release is finally out. Once again thanks for the super-fast support!

P.S. I've set versioncode in config.prop low enough so that Magisk Manager will prompt to update to any available official version. Unless a fix is out & merged - do not update or things will break once again.
[Magisk] callihn:
Always stopping, also appears to depend on play services since an upgrade to that makes it stop working everytime until a reboot. WTH?

Allows system apps root by default with no control over it, very bad and not secure as any app could in theory be moved to the system and later gain root. I know that for a fact because I have an app in the system that always, always asks for root in every other su manager but not this one and it's used by the vendor to detect root.

Also the link in the app for the support thread goes to the original thread which is locked.
[Magisk] DaveX2012:
No.. Xposed installed but.. Can't pass... S7 oreo.. View attachment 4522302
[Magisk] FlavioV:
Xposed messes with SafetyNet. Even if you use the systemless version you can't pass on SafetyNet until you either uninstall or disable Xposed.
[Magisk] Didgeridoohan:
Not sure what you mean... Do you mean that Magisk suddenly "uninstalls itself"? Or do you mean that the Manager keeps crashing? Or something else?

If it's the first, it's probably a bug with MagiskHide that's under investigation. You can try disabling MagiskHide to see if it works better.

If it's the second, a logcat from when the Manager crashes might show what's wrong.

If it's the third we'll need more details, and lots of relevant logs.

Again... More details (and of course, logs) would be useful. Can you see the app in question under "Superuser" in the Manager, and do you see it being granted access in the logs? I've installed apps as a system app and they asks for superuser access just as any other app.

I'm going to assume you mean that you don't have Xposed installed, correct? Otherwise just read the post above... If correct, try toggling Hide off and on, and if that doesn't work continue reading here: https://www.didgeridoohan.com/magisk
[Magisk] DaveX2012:
Yes that's correct xposed is Not installed. Try to enable this but some how it disabled by itself after exiting Magisk Manager.

View attachment 4522389
[Magisk] Didgeridoohan:
Try to manually delete the file /data/property/persist.magisk.hide.
[Magisk] graydiggy:
V16 seems to disable biometrics. Can't read the fingerprint scanner at all. 16.4 beta temporarily brings it back until the next reboot. Then nothing. Not even any fingerprint options in settings.

ASUS ZenFone 3 Zoom 8.0
[Magisk] pehoko:
How to uninstall magisk as seems my phone is bricked? I have tried uninstaller but it ends with error " ... unable to mount partition..."
[Magisk] guest4711:
Flash the stock boot image. Magisk saved a copy at /data/stock_boot_*.img.gz
[Magisk] callihn:
Says Magisk stopped working and closes right after opening it, I'm not using magisk hide. If a play store update is still on SDcard and not moved to the system yet it just closes with no message when trying to get into the superuser menu. The later is generally fixed with a reboot but I've seen the former survive a reboot, the former didn't happen on the previous version. Perhaps it was introduced in the bug fix when checking updates for andriod 7 mentioned in the change log?

The app has never asked Magisk for su access but always asks for it in all other su managers like supersu for example and nothing in the logs either. Now that I'm not suffering from sleep deprivation perhaps I was wrong on that and it's because it doesn't detect Magisk or systemless root at all so thus it doesn't ask, that makes more sense now.

Thanks for the reply. I'll try to get more info but it generally does it when I don't have time to look into it and it's not consistant.
[Magisk] peterlee928:
i continue to have this issue both on stable and beta versions. ive posted many (too many?) logs regarding this issue in this thread. one series of steps that seems to quell the issue is:

1) use stable instead of beta

2) before exiting out of magisk, always clear repo cache in magisk settings
[Magisk] mayur.3.92:
+1
[Magisk] Didgeridoohan:
Patience...

https://github.com/topjohnwu/Magisk/pull/389
[Magisk] ncrmnt:
Wait till a new build is released or use my temporary fix if you are in a hurry: https://xdaforums.com/showpost.php?p=76761894&postcount=25150
[Magisk] Cheewawit_T:
Facebook won't connect

I'm using MI6 with 9.5.6.0 global stable ROM and magisk v.16 installed. I've found out that latest FB update made the app unable to connect to server as well as some browser such as Firefox, but only Chrome works just fine after I hid it with Magisk hide. Other apps can't access Facebook as well even though I hid it just like Chrome. Also I have cleared all cookies and cache from all of the browsers even re-installing the ROM, didn't work at all. Always shows

'Error connection refused."

Ps. I can't upload log from mobile so maybe I'll try later

Thanks.
[Magisk] Jimdevl:
I got a problem, after trying t ofalsh a module it says either mount failed OR magisk mount point not found :\
[Magisk] Didgeridoohan:
I think the old "logs or it didn't happen" is applicable in this instance... :p
[Magisk] Technical:
After having Magisk installed, for any reason, I stop being root.

I go to TWRP and reflashed Magisk. I was bootlooping into recovery, most probably I do not have the backup of the original boot partition (.img).

If I flash the uninstaller and do not have the boot.img file to be restored, will the uninstallation work? I mean, the uninstaller works restoring the boot image or make its "magic" to restore it to the original state. Thanks.
[Magisk] jcmm11:
What ad-blocker do you have installed?
[Magisk] liamolua:
Magisk Manager keeps crashing nothing I will do will stop it.

Hey, I'm on a Nexus 6P Stock Android Oreo running latest Magisk stable everything and after I reboot my phone Magisk keeps crashing and I cannot do anything. How can I fix this? Seriously cannot do anything root related because it just keeps crashing.
[Magisk] Badger50:
Try flashing magisk again in twrp.
[Magisk] liamolua:
I have, Magisk Manager still crashes. I have even flashed Beta and still crashes
[Magisk] Badger50:
How bout clearing magisk manager app cache and data. It has storage permissions granted as well I assume?
[Magisk] countercharge:
The uninstaller does not seem to work on my Axon 7 mini. Its Arm64. I get a status 1 error when I try to run the uninstaller with TWRP.
[Magisk] liamolua:
Just tried it, even uninstalled completely and still crashes. Just won't open at all.
[Magisk] jcmm11:
Try turning off the dark theme
[Magisk] liamolua:
1) Can't even get into the app to exit settings

2) Never enabled it
[Magisk] Pkt_Lnt:
Did you miss the suggestion above mentioned twice to make sure Magisk has storage permissions in Settings > Apps??
[Magisk] liamolua:
I've tried storage permission enabled and disabled and still carqshes.

---------- Post added at 04:15 AM ---------- Previous post was at 04:05 AM ----------

I'm deleting everything off the phone, including the firmware. Going to try to reflash stock Android 8 and Magisk BETA and see if that works. If not will try a hammer :laugh::laugh:
[Magisk] peterlee928:
https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post76769410

ive tried all the previously mentioned solutions to no avail. this is the only process that has worked for me thus far.
[Magisk] martyfender:
I believe that fix is in [MENTION=4470081]topjohnwu[/MENTION] 's latest commits and now in the latest unofficial builds by [MENTION=3306843]kantjer[/MENTION].

https://github.com/kantjer/MagiskFiles
[Magisk] Kamil.Blaha:
Hi, Didgeridoohan.

I saw the same problem with Magisk v16.0 on my second Nokia 3. I did what you had suggested - I flashed zip with Magisk v16.4 just over Magisk v16.0 (I used "fastboot boot twrp.img" again, because I have no bad experience with this method and I need that my recovery stays untouched.).

With the backup phone everything went OK, Magisk v16.4 log was without errors and I have installed three modules with success (I restarted phone between installations).

With the work phone I saw differencies. After I had flashed Magisk v16.4 I saw error messages in Magisk Manager (5.7.0) immediatelly after reboot (same "No such file or directory" messages as in Magisk v16.0). After restart error messages went away and Magisk Manager log was the same as on my backup phone. In installed "ExSDCard" module and restarted the phone. After restart I had no root and Magisk Manager said that Magisk is not installed! After next restart root was back. I have installed two more (same as for my backup phone) modules and the problem with missing root never repeated.

But: when I swich the phone off, I feel vibration, what is correct, but next 40 seconds it is unable to switch the phone on.

Is it possible that the reason of my problems is caused by that I did not clean Cache/Dalvik?

Thank you very much for advices.
[Magisk] liamolua:
Installed Beta (but haven't rebooted yet), will clear repo cache whenever I exit and see if it works. Will post to keep people whom else is experiencing these issues updated.
[Magisk] Didgeridoohan:
I doubt it... Sounds more like something went wrong with the v16.0 installation and a cleanup (uninstall - reinstall) would be in order.

If the crashes are caused by repo updates (hard to say, since you haven't posted any logs whatsoever), that has likely been fixed and you should be able to verify that by installing an unofficial snapshot that [MENTION=8126387]martyfender[/MENTION] linked above.
[Magisk] naim.hassan:
Does magisk 16.4 beta (or any the particular version) work on project tremble custom ROM for instance, DotOs 2.3 (treble). I desperately need root for my device. Otherwise I am okay with my current pixel experience. Your response would be very grateful :)
[Magisk] Cyteezy:
Hiding magisk manager doesn't seem to work for me. When i try hiding my magisk, it creates two apps, one has a random name and the other one has the original name. Then after a while, the one with the random name dissappears and the one with the original name stops working so i need to update my manager again to 5.7.0 . I tried reinstalling magisk and the same thing happened again. magisk manager seems to be a system app. Any one here having the same experience?
[Magisk] ashyx:
Magisk manager never installs as a system app. No point of being systemless otherwise. :rolleyes:
[Magisk] jenslody:
Some custpm roms include MagiskManager as system-app, complete bull****, it breaks hiding the manager, which is a real important feature in the cat-and-mouse-game about hiding root.
[Magisk] Didgeridoohan:
Sounds like you're using a ROM that has Magisk included, and that ROM creator had a thought-booboo and included the Manager as a system app. This means that the feature to hide the Manager won't work...

Contact the ROM creator and let them know, and meanwhile you can delete the Manager manually from /system and reinstall it as a user app.
[Magisk] Cyteezy:
Could you please tell me where the manager files are located, i found a folder called MagiskManager in /system/app but its only content is an apk file.

Is there a way to make it so the manager will be a user app?
[Magisk] Didgeridoohan:
That's the one. To be sure that you won't experience issues, start by uninstalling updates for the Manager. After that, delete that folder in /system/app and reboot. Then you can download the Manager from the release thread (or go to GitHub) and install it manually.
[Magisk] jugoslavpetrovic:
I just tried to install some modules and I ended up in bootloop.

This Magisk thing is so frustrating and it is giving me so much hassle. I will definitely move back to SuperSU apparently.

This is not fun at all.

How do I freaking get out of this now?
[Magisk] Stevica Smederevac:
Flash this in TWRP and go back to SuperSU. Check pm.
[Magisk] Cyteezy:
Thanks it worked i really appreciated the help :)