yashsingh1/xdaforums huggingface dataset:
[Magisk] paolone919191:
Hi all

Device: Samsung S2 i9100 fresh flashed

OS: tested with lineage os 14.1 nightly and latest resurrection remix 5.8.5

recovery: twrp

problem: When flashing magisk-v16.x.zip, I got Error 1 (unable to unpack boot image)

Thank you
[Magisk] martyfender:
Try to mount system in TWRP, first, before flashing the zip. That solved it for me in a couple of instances with Magisk and modules. If that doesn't work, maybe others will have ideas.
[Magisk] guest4711:
Our beloved S2 is not compatible with magisk and will not be supported. Use LOS-su-addon.

See the device threats or https://xdaforums.com/apps/magisk/magisk-discussion-thread-t3467229
[Magisk] 123lisa:
Device: Oukitel K10 (MT 6763, arm 64)

Firmware: Stock 7.1.1

Security patch level: 5th december 2017

Bootloader: Unlocked (orange state)

Problem: Bootloops after flashing Magisk 16.4 or 16.0 (doesn´t matter if I use TWRP or fastboot to flash). Anyone have similiar problems?
[Magisk] :
Is phh's superuser still needed for Magisk 16.0+ to function? Because it shows SU binary out of date on reboot.
[Magisk] Didgeridoohan:
No... It's been replaced by MagiskSU since Magisk v11.0, well over a year ago.
[Magisk] :
We're you ever able to resolve this? Facing same exact issue
[Magisk] ksio89:
Hey man, just replying to thank you for the help, I managed to remove SuperSU and install Magisk, without any issues. My credit card app does not detect root with MagiskSU, however, it detects root after I installed Xposed systemless, even after adding the app to MagiskHide list. The app still detects root even after disabling Xposed and rebooting. With Xposed disabled, SafetyNet check test passes, both ctsProfile and basicIntegrity, but this sob app still detects root. I wiped cache and data and even reinstalled it, but nothing works. Is it a lost cause, or do you have any suggestion to make this app not detect root even when Xposed is disabled? Again, thank you for the help.
[Magisk] Didgeridoohan:
I'm gonna make a wild guess that it's looking for the Xposed installer. That can't be hidden, so you'll have to uninstall it when you need to use that app.
[Magisk] ksio89:
Yep, you're right, it was just a matter of uninstalling the Xposed Installer :) I thought I had to remove the files installed by Magisk, but I found out I didn't, so I just need to uninstall it before using this app, just a minor inconvenience.

Dude, I can't thank you enough, I really appreciate your help. I was afraid to install Magisk after years of using SuperSU, but it's way simpler than I expected. The guide you created in that website was very helpful and easy to understand, and I bookmarked it for future references. Thanks a lot to you and topjohnwu for creating Magisk.
[Magisk] hhwong:
nexus 6p 8.1 may patch stock, i flashed stock images from google before installing twrp, tried to flash uninstaller via twrp and got error 1 so i just went ahead and uninstalled the app myself.

everything booted up fine until i flashed magisk via twrp, then i am just stuck at boot logo loading forever......

i tried to patch the boot image directly and flash that, same issue, is it me or is it a bug?
[Magisk] yochananmarqos:
It's you. Every month I do the same thing with no issue on my 6P & 5X:

- Flash stock boot & recovery

- Sideload the OTA

- Flash TWRP

- Flash Magisk & ElementalX
[Magisk] hhwong:
i actually got it to work now, had to do a full wipe for a clean install.
[Magisk] yochananmarqos:
You didn't have to do a clean flash. All you had to do was flash the stock boot.img.
[Magisk] hhwong:
i did, i am not sure what was wrong but i reflashed boot, system, even wiped dalvik/cache everything, still couldnt get it to work until i did a full wipe.

at least it works now so its all cool lol
[Magisk] mm2104:
SafetyNet fails when using Tez payment app even after using MagiskHide on it. Tez app still detects rom is rooted. Any help?
[Magisk] :
This post is only for tez users who are not able to reopen it because of root and custom ROM...

The solution is given here -

1. Install tez app on ur android

2. Hide magisk root and Run the usual setup(just for testing)

3. If it fails then wipe out the data and force stop the app

4. Go-to settings>apps>Google play services>permission...and disable phone there

5. Now open the tez app and do usual setup.... it'll work now

6. Enable phone permission if u want

# it'll say tez won't work properly without phn access...don't bother about it

# won't work if safetynet isn't passed

# don't forget to hide root

Credits: Sad Satan https://t.me/USNFGroup
[Magisk] Evengard:
[MENTION=4667597]Didgeridoohan[/MENTION]

About the post-fs-data.d scripts: yes, I tried permission 755, but the result is just the same. Also, as an interesting fact, the scripts in <module>/post-fs-data.sh are with permissions 644 and they do work without problems. Still 755 didn't helped.
[Magisk] Didgeridoohan:
That's how it's supposed to work... The module scripts will always run, no matter what permission they have. The other boot scripts will have to be assigned execution permissions manually. It's made that way so that module creators and developers can have full control over what permissions the boot scripts in post-fs-data.d and service.d have.

Over to your issue:

Please provide a magisk_debug.log and your scripts for troubleshooting.
[Magisk] inchvbeam:
hi apologies, I have tried to remove magisk v16.4 on my ressurection remix because of failure of my banking app to load properly despite trying numerous way to hide root etc. I have run the uninstallation via the magisk manager. I have run the root checker to check that my root has indeed been removed. However my banking apps, including that of citibank app still notified that I have root privileges.

Thinking that I may have not properly uninstalled the magisk, i went ahead to run the latest magisk uninstaller.. but was met with error (error code '1') in TWRP. Please refer to the attached recovery log, thank you.
[Magisk] Didgeridoohan:
[MENTION=7933926]inchvbeam[/MENTION]

That's the removal of the 64-bit binaries causing issues. Use this uninstaller (the next to newest):

https://github.com/topjohnwu/Magisk/releases/download/v16.3/Magisk-uninstaller-20180328.zip
[Magisk] inchvbeam:
View attachment 4505896

It says "Magisk is not installed" but ended off with ERROR: 1. Is that legit? File is attached, thank you.
[Magisk] Didgeridoohan:
That means that Magisk isn't installed anymore and error 1 means that the zip failed, because Magisk isn't installed...

There are plenty of things that banking apps (and other apps looking for root) take as a sign of you being rooted. Not just actually being rooted...

Run RootBeer to see if it triggers for something. It'll not be a completely reliable test, but it'll give an idea.
[Magisk] inchvbeam:
I have "red cross" for "TEST KEYS", :DANGEROUS PROPS and SELINUS FLAG ENABLED (EXPERIMENTAL)" May i know if i could be detected as non-rooted please? Thank you..
[Magisk] dymbo:
Hi!

Tried to install Magisk 16.4 beta but couldn't install any modules & even magisk uninstaller failed in twrp. So, reflashed stock boot & tried the 16.0 with no luck. Here's the latest twrp log from the 16.0 & magisk uninstaller. Please advise what's may be wrong with this?

Thank's in advance!
[Magisk] Didgeridoohan:
You can hide all of those with MagiskHide... :laugh:

If you want to try, you can manually change the sensitive props that MagiskHide changes. You'll find then in build.prop and default.prop, but the ones in default.prop won't keep across a reboot.

There might be a number of things that the app is triggering on. It might be that you gave Developer Options and/or USB Debugging enabled, some of the apps you have installed, etc. It can be quite tricky to figure out sometimes...

You've got the same 64-bit issues like the guy above. Look back a few posts for a working uninstaller zip.
[Magisk] dymbo:
Thanks! However, that's not for uninstaller only, it's about magisk modules too. Every module I've tried so far failed to install with pretty same log errors.
[Magisk] Didgeridoohan:
I thought you just wanted to uninstall to go back to v16.0?

It's hard to say what's up with the modules without an installation log...
[Magisk] dymbo:
No. I've uninstalled it by flashing stock boot. The question is for magisk unusable for modules.

Here's the log after two modules installation attempts. Appears same issue as with the uninstalker
[Magisk] Didgeridoohan:
Better do to a fresh install (flash uninstaller and reinstall).
[Magisk] groundman:
fujitsu

hi, this is the best root trick so far, i used it for almost all my devices, but now i have question, i have a japan phone Fujitsu arrows F-04G it has no recovery and adb mode. can i use magisk to root this device? thanks for your attention bro.
[Magisk] Artim_96:
Only if there is a way to unlock the bootloader or some other (hacky) way to run TWRP.

Unless there is some way find for your device to e.g use it's recovery to let it flash image files like there was/maybe still is for LG devices, there is no other way to flash
[Magisk] inchvbeam:
Thanks! My other banking apps will still detect root after removing magisk and all but one become okay after using magiskhide. I removed magisk to look out for the source of error to try resolve before flashing magisk back..
[Magisk] davidzam:
Hi. Reporting that magisk manager 16 is force closing on my device, I'm using android 6.0.1 stock Samsung. Anyone is facing this issue as well? Thanks.

Enviado desde mi SM-G550T1 mediante Tapatalk
[Magisk] Buxbaum666:
You were right, of course, Magisk was back after a proper reboot. 16.0 doesn't seem to produce the magisk_debug.log so I switched to kantjer's unofficial update path and installed the latest version. Then I waited for the problem to crop up again and it did. I managed to grab the debug log:

https://drive.google.com/open?id=1EflocnFLFdTwC6LxXC7zGtcSl9iswenm

It's a whopping 35 MB tho, can you do anything with this?
[Magisk] ConradP:
I have observed something weird - I am on LG G4 H815 phone. As soon as I install Magisk on my phone I am encountering problems with LTE. What I mean no more LTE connecting.

GSM and WCDMA works fine but 4G - no more. After installing kernel Titan again all back to normal with 4G internet.

Can someone please help me? I am using a lot of Magisk modules but if it looks away my LTE there is no point in using it:(
[Magisk] inchvbeam:
I saw in the help guide to flashing a clean boot image after uninstalling magisk before performing a reinstallation. I have ressurection remix running.. do i extract my boot image from this rom pls? thank you.
[Magisk] BurnedDrake:
Yes
[Magisk] FlavioV:
If you use a custom kernel you should always flash it after Magisk. You should be all set now. :svetius:
[Magisk] tomahawk5000:
Hi I'm not sure that you are help me but I'll ask

I have safety net pass magisk hide work perfect but my bank app still see root. App called iko anybody know why?

I update magisk to v16.4 but still...
[Magisk] jenslody:
Dd you also try to hide the Manager (from it's settings) and clear the cache (probably also the data) of the banking app before re-running it (after hiding the Manager) ?
[Magisk] casouzaj:
Correct me if I'm wrong, but I think that the custom kernel to be flashed should be previously patched by Magisk. If you flashed an un-patched kernel afterwards, you'd loose root access.
[Magisk] tomahawk5000:
I did not try this option with hide magisk app. But how to make magisk visible again?
[Magisk] jenslody:
The Manager app will be repackaged with a random name, you should have in mind, that you need to hide it again after a Manager update.

Besides this, some apps fail because of othet phone settings (adb, props, etc), see also [MENTION=4667597]Didgeridoohan[/MENTION]'s great guide: https://didgeridoohan.com/magisk/
[Magisk] Didgeridoohan:
Just to make sure, you've tried everything mentioned here: https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot

That is indeed a sizeable logfile, but it does span over almost 12 hours... I'm not the best at reading logs, but it looks like the shutdown is initiated by the user. Did you force a reboot when the problem occurred?

First thing I'd try is to seriously reduce the number of apps and services you've added to the Hide list. It might not be the root of the issue, but having a list that large (149 entries) may cause problems if MagiskHide have to do a large number of unmounts and remounts in a short number of time (during the last second of your log there are 4-5 triggering events).

And, besides the tips above, from a quick test (I can't do more since I don't have an account with the bank) it looks like the app is requesting phone permissions. Try by also adding the phone to the Hide list.
[Magisk] jcmm11:
You're wrong. I'll just quote osm0sis from another thread.

AK2 Zip's, which nowadays means almost all (if not in fact all) custom kernels use, preserve RAM disk changes from the kernel that they're replacing. That's where the root enabling changes are found.
[Magisk] FlavioV:
Wrong. Magisk only patches the boot image. You'd only lose root if you flash a non-rooted rom afterwards.

It's even mentioned in the main thread (I can't do a proper quote because the thread is locked):
[Magisk] tomahawk5000:
Guys why one I try install for example zip to uninstall magisk or universal magisk zip I can't because of something like this info

Error executing update binary

How to solve this?
[Magisk] NLBeev:
And when the forced encryption flag is set (Lineage) the encryption process will start.
[Magisk] casouzaj:
Always learning... Thanks!
[Magisk] yochananmarqos:
The only reason why you'd lose root flashing any ROM would be if it wasn't using an AnyKernel2 kernel. Flashing a stock boot.img would also remove Magisk.
[Magisk] serajr:
[MENTION=4470081]topjohnwu[/MENTION] [MENTION=4667597]Didgeridoohan[/MENTION]

I need to patch sepolicy with customs rules, and this is what I'm trying directly in the boot_patch.sh file (in blue) at the install time, but with no success:

Magisk v16.4 (1642)

ui_print "- Patching ramdisk"

[COLOR="Blue"]./magiskboot --cpio ramdisk.cpio extract sepolicy sepolicy
if [ -f sepolicy ]; then
ln ./magiskinit ./magiskpolicy
chmod 755 ./magiskpolicy
./magiskpolicy --load sepolicy --save ./sepolicy "allow init securityfs file { write }"
./magiskboot --cpio ramdisk.cpio add 644 sepolicy sepolicy
rm -f magiskpolicy sepolicy
fi[/COLOR]

eval $LIB32PFX ./magiskboot --cpio ramdisk.cpio \
\"add 750 init magiskinit\" \
\"magisk ramdisk.cpio.orig $HIGHCOMP $KEEPVERITY $KEEPFORCEENCRYPT $SHA1\"

Any help would be great. Thanks in advance!!

Edit: New code!
[Magisk] nathanchance:
I will mention that certain A/B devices like the Pixel and Pixel 2 do require Magisk to be flashed after the kernel since the kernel itself is hexpatched not to skip initramfs so it's not a universal rule, it's device specific. I know that doesn't apply to this specific scenario but I don't want my users stumbling upon this and thinking they don't need to flash Magisk after my kernel lol.
[Magisk] pankozin:
Hi, I have the same app and it started to detect root after the last iko update. Tried reinstall and such, but it didn't help. Did u manage to get it working? As for now, I'm using previous iko version which works.
[Magisk] tomahawk5000:
I think it's global issue with this app many users complaints on this in GP. I also tired install this app without root permission and still was wrong.

We have to wait.

Ps could you please share me previous version of this app?
[Magisk] pankozin:
I have the same app with same problems, I tried your suggestion already and it doesn't help

---------- Post added at 12:38 PM ---------- Previous post was at 12:32 PM ----------

I can send you it
[Magisk] tomahawk5000:
Please

Appreciate

You can send me it on pw
[Magisk] pankozin:
I wrote u msg, it would be better to send it through telegram or another private messenger as it's titanium backup file. I extracted the apk, but am not sure it's working

---------- Post added at 01:11 PM ---------- Previous post was at 12:43 PM ----------

Do you have custom Rom installed? Or all stock?
[Magisk] tomahawk5000:
Of course custom room[emoji4]

---------- Post added at 02:01 PM ---------- Previous post was at 01:28 PM ----------

Unfortunately on Samsung J5 with stock rom without root app works
[Magisk] ianmacd:
[MENTION=346743]casouzaj[/MENTION] actually wasn't wrong. His confusion stems from the ambiguous wording of the advice that "If you use a custom kernel you should always flash it after Magisk." The advice meant after installing Magisk in the boot image, but the wording actually suggests after flashing Magisk onto the device. Obviously, rooting the existing device boot image and then overwriting it with an image containing an unrooted custom kernel will lose root access, as [MENTION=346743]casouzaj[/MENTION] accurately surmised.
[Magisk] casouzaj:
Let me try to explain why I stated it. I have two old Sony Xperia phones here: a Z3 Compact and a ZL.

The Z3C phone runs CarbonROM 6.1, with the boot image which comes with it.. As it is encrypted by the company I work for, and I could not find a TWRP version which effectively decrypts its data partition, whenever a new ROM update is released, I have to flash the ROM, then the gapps package (if I don't flash gapps, my Google account is deleted), and, finally, Magisk.

The ZL phone runs LineageOS 14.1, again with its boot image. It is not encrypted. After I flash the ROM (here gapps survives the flashing process), Magisk's addon.d script comes up, but the phone doesn't even loads the kernel when booted up . So, before actually flashing the ROM I extract the boot image from the ROM zip file, submit it to Magisk to be patched, then flash the patched boot image through a fastboot command. Only then, the ZL phone boots up.
[Magisk] ash roxx:
pls check pm [MENTION=2827817]gundal[/MENTION]
[Magisk] _RM_:
I installed last week lineage 15 with magisk 16 on my op2 and I can not get the magisk to find the tasker.

I have tried with old versions but it does not work.

I already edited the file /system/build.prop and added "# modversion" but nothing :S

Can someone help me plz?
[Magisk] johanruda:
Hey peeps!

I'm trying to get Pokemon Go to work.

I've got 16.4 installed, but the list under Magisk Hide is empty. No apps at all.

Am I missing something?

Stock rom on a V30+
[Magisk] Didgeridoohan:
[MENTION=5978748]AserLaser[/MENTION] Since this is a Magisk issue, I'm moving the conversation here to the support thread, rather than cluttering up the module thread.

This is exactly the issue. There's something wrong with your Magisk installation, but I don't know what...

Best I have to offer currently is to uninstall Magisk and do a fresh reinstall. I don't think it'll work, but it can't hurt to try.
[Magisk] BurnedDrake:
Yeah, add all the Pokémon Go stuff you need to hide from, manually
[Magisk] johanruda:
I get that, but the problem is that there are no apps to pick from. See attached screenshot
[Magisk] johanruda:
Stumbled across the solution by accident. Lucky me!

There is a bug in 8.0 that stops apps from showing all installed apps if there are any Instant Apps installed. I had one. Removed it and now it works!
[Magisk] head66:
Can I use MM to install SP OTA on rooted device Nokia 8?
[Magisk] BurnedDrake:
Glad you solved it, how in the world did you figure out that it was instant app that was the culprit?
[Magisk] morfinrider:
Maybe you can freeze it with TiBu temporarily?
[Magisk] davidzam:
I was having the same issue with games from netmarble under xposed. I found that the solution was disabling xposed to play. Then activate again after finishing. Automated I think was the name of the app.

Enviado desde mi SM-G550T1 mediante Tapatalk
[Magisk] firozpatel:
Hi all

All of a sudden my magisk hide option has disappeared, any ideas what I need to do? Thanks for helping

Also I have started to fail safety net, I have not downloaded anything new on my device that requires root, it just happened randomly

Any ideas people
[Magisk] johanruda:
Haha I was just extremely lucky.

This is the first time I root my main device (only tested it out on phones I don't really use) so I'm not super familiar with those kinds of apps, but I had heard of SD Maid and I saw it pop up on the store as a recommended app while I was browsing. I knew what kind of app it was so I thought "nah, I don't need that", but I went back a while later and installed it. I quickly swiped across its features when I saw a popup saying something like "If you have any Instant Apps installed, this list won't work. Do you want to uninstall the apps you have?", so that's when I put two and two together.

It's been mentioned in an issue over at github as well: https://github.com/d4rken/sdmaid-public/issues/1513
[Magisk] Didgeridoohan:
My guess:

Either MagiskHide has been disabled (enable again in the Manager settings), or Android logging has been disabled (check if you have any logs in the log part of the Manager).
[Magisk] firozpatel:
I have managed to fix the issue by uninstalling magisk, then installing it again, which then told me on the manager, magisk is not installed, then I installed it directly through the manager again, then I got the options download zip, patch boot image, so I found chainfires website with all boot images, patched that, then installed magisk again

That seems to have solved the issue of magisk hide not being there

Strange
[Magisk] Didgeridoohan:
Have to ask: why?

The Manager need to do some stuff at boot.
[Magisk] Buxbaum666:
No, despite what the log file said, the shutdown was not user-initiated.

I guess I went a little overboard when I first tried to fix this. :D

I now cleared the hide list completely and even deactivated MagiskHide but the reboot still happened last night. So I guess this isn't a hide-related issue. Shall I post another log, maybe trim it down a little? I'd be happy about any other suggestions I could try.

My wife says this started happening after she updated a whole lot of apps via play store one time. I guess I'll try removing any root apps and see if that does it.
[Magisk] marniel647:
I will check it still on the notification after several minutes.
[Magisk] Didgeridoohan:
I'm not sure that a new log would show anything. Going through the apps to see if there's one that's causing issues is a good idea. And, just in case: make sure that the reboots aren't being caused by a case sometimes pressing on the power button (this happens surprisingly often). From your description I don't think this would be the issue, but it's worth it to make sure.

That's different. Are you saying that the notification never disappears? Please try being a little more detailed in your description, and a logcat during boot might also be useful if you're experiencing some kind of issue.
[Magisk] marniel647:
Already gone after reboot sorry i dont want to wait. hehe
[Magisk] prathamb:
Bootloop

I have Lenovo k3 note with stock ROM.

Twrp : 3.0.2-3

Linux : 3.10+

OS : 6

Previous Root app : SuperSU 2.46 (system version)

1) I carried out full unroot of SuperSU by flashing zip , checked twrp for system/bin su folder , there was none.

2) before carrying out any modifications in k3 we need to flash patched boot.img so I have it flashed(before installing SuperSU about 2 months ago)

3) I checked root check app one app shows root is not properly installed , while others say it's not rooted. Safety net passes

4) I installed magisk v16 (flash was successful without any error), cleared cache and got bootloop, which I fixed by uninstalling magisk and reflashing boot.img (now magisk is not installed nor is supersu) ( I am able to boot properly)

Any fix for this error and any idea which version will support it ?

I have attached log of uninstaller which gave some error

I hope you will fix it
[Magisk] teddy0209:
It might be related to #2... What do you actually mean by patched boot.img? If it's like, it must be signed or something, then you might need that after magisk has modified/patched the boot.img.

Edit: Or you may try to manually patch the boot.img or patched boot.img using the magisk manager, then flash it. (Just try both)