yashsingh1/xdaforums huggingface dataset:
[Magisk] easytotype:
UPDATE: ISSUE HAS BEEN FIXED, THANK YOU

Hi all,

I am trying to compile Magisk from source and I'm running into some errors.

I opened a thread with the issue here: https://xdaforums.com/apps/magisk/help-compiling-magisk-source-errors-t3697396

Could an experienced dev maybe give some input there please? I'd really appreciate it. Thank you
[Magisk] pellajl:
[MENTION=4470081]topjohnwu[/MENTION]

I have a Galaxy Note 4 - SM-N910G loaded with Resurrection Remix N for trltexx [5.8.5] - Nougat V7.1.2 and I have an issue with Magisk Hide.

Links: https://xdaforums.com/note-4/snapdragon-dev/rom-resurrection-remix-5-8-0-t3523130

https://xdaforums.com/showpost.php?p=74344885&postcount=2996 (Response from ROM maintainer)

The first like takes you to the thread's first page where the kernel source code can be found.

Issue Specifics:

When I enable Magisk Hide and reboot the phone, the IR Blaster and the LED Indicator stop working. If I disable Magisk Hide and reboot the phone, the IR Blaster and the LED Indicator start working again. Once the phone has finished booting, I can re enable Magisk Hide and it will not impact the IR Blaster and the LED Indicator.

If I ever need to reboot the phone, I always need to remember to disable Magisk Hide.

Are you able to assist with this issue?
[Magisk] nabeelio:
Is the cleanup script supposed to be removing the /data/custom_ramdisk_patch.sh file? I removed Magisk, and was installing SuperSU, but it was failing because it was trying to run that script and Magisk is no longer installed.
[Magisk] Helbelinc:
Bump.

Edit: [MENTION=4470081]topjohnwu[/MENTION] maybe mentioning you helps :)
[Magisk] DodoGTA:
Yes
[Magisk] exodius48:
Hello,

If i've already installed SuperSU, can i install magisk directly from twrp?
[Magisk] DodoGTA:
No
[Magisk] mundodisco8:
Hi,

I don't know if it's the best place to post this question, so sorry if it isn't. I'm also on the "stupid-barclays-app-why-don't-you-work-on-rooted-phones!" wagon. I was wondering if it would be possible to install two copies of a particular rom, but root only one, and use the other, unrooted one, for Barclays. Yes, I've read it out loud before posting, and I realise how stupid it sounds, and how overkill it is, but in my particular case, I need both solutions, so it would work for me. I just wanted to ask if somebody has tried before or knows of a particular reason why it wouldn't work, so I don't have to go that route.

Cheers!
[Magisk] ytheekshana:
[MENTION=4470081]topjohnwu[/MENTION]

Its better if you add an option to sort the modules.. such as sort to date uploaded....So we can find the new modules quickly.
[Magisk] DenyDarko:
I was downloading the YouTube mod black themed from magisk manager.

When it passed 50% it started to count in reverse with negative operator till zero (0%) and then it started counting up again and finished at around 3%.

I guess it wasn't noticeable before as it's the size of modules are some KB at the most.

[MENTION=4470081]topjohnwu[/MENTION] it's minor but you might wanna take a look.

I'm using 14.3
[Magisk] thebrainkafka:
Which Version of magisk supports xiaomi mi a1?

Thanks
[Magisk] Didgeridoohan:
The one that hasn't been released yet. Mi A1 support is a work in progress...
[Magisk] DodoGTA:
Currently no version of Magisk will work on your device

Note: Welcome to 2018, the year of Android P!
[Magisk] thebrainkafka:
https://www.xda-developers.com/magisk-14-1-official-google-pixel-support/

But it's stated otherwise?
[Magisk] Didgeridoohan:
That text wasn't written by [MENTION=4470081]topjohnwu[/MENTION]. The release thread is a better source for info than the xda front page.

The Mi A1 is an A/B device, yes, but there's something different from the Pixel so it doesn't work out of the box.
[Magisk] kerpert:
Hello, can someone confirm if the latest Amazon Appstore shows the "my apps" list under Magisk rooted system?

Mine is in a continuous reloading state.

I was thinking to a (voluntary) incompatibility with Magisk.
[Magisk] Ketawa:
Amazon Appstore lists all my apps in its "My Apps" section on my Magisk rooted Pixel XL.
[Magisk] Gauravlonkar:
Why it doesn't support for latest Oreo build of oxygen and Hydrogen OS from OnePlus ?
[Magisk] onliner:
You ask those questions as if it were easy ...

Be patient, there will be news soon.

PS: next time use search button ?.
[Magisk] Helbelinc:
Bump again.

Is there nobody who's had a similar problem?

I switched from Lineage (respectively the latest RR rom) because I had frequent disconnections all the time (be it BT, during calls, or WiFi) and couldn't use the Cyberian camera.

Now being back on stock everything works smoothly, i just can't install Magisk for some reason :(
[Magisk] Unjustable:
Hello,

Im trying to install Magisk on my device but i get an error everytime.

I already spend a few hours trying to get a solution but im stuck.

Im running stock rom. No supersu installed. Also no old versions of magisk.

Bootloader is unlocked.

The error i get is "magisk updater process ended with error 1"

"unable to detect boot image"

If someone can help me i would be grateful

Link below is pointing to twrp log.

http://tinyw.in/JO7c
[Magisk] Didgeridoohan:
I have no idea about your problem, but have you checked your device's forums for advice?

Two things to try: Update your recovery and/or try the 14.3 beta.

Lenovo devices seem to be troublesome...
[Magisk] Unjustable:
Ok thanks. I will try to do that.
[Magisk] Helbelinc:
I'm running the latest TWRP and also tried the 14.3 beta ...

Thanks though
[Magisk] thebrainkafka:
Thanks.

So there is a pixel modified Version of magisk 13.4 which is working in A1. Pitts that official Pixel release 14.1 onwards are not working. Any idea why?
[Magisk] DiamondJohn:
I am getting a strange behaviour with the post-fs-data feature. I place a script in the directory, and after a reboot, the script is still there BUT its simply a file full of 0's (ie ASCII 0 not the character 0) The log shows that it tried to run the script https://www.hastebin.com/okaloxepex.hs but it was obviously changed to nulls before it ran, as none of the actions (including some logging) are actually run.:confused:

Am i Doing something wrong? I am, running v14.0 of Magisk ( as shown in the log) on a Nougat, Resurrection Remix ROM. This script all worked fine in my previous 6.0.1ROM running Magisk 13:confused:

I do not understand the line "proc_monitor: Your kernel doesn't support mount namespace :(" Is this the culprit?
[Magisk] Chamelleon:
Hi. I just installed Magisk 14 on fully wiped Doogee S60 with Android 7.0. Downloaded Manager, patched boot, flashed patched boot with SP Flash Tool and it's working but only partial. Magisk seems to be working, I have root access but every time I try to download any module I see error:

- Found /data/magisk_merge.img

- Mounting /data/magisk_merge.img to /dev/magiskmerge

! /data/magisk_merge.img mount failed...

Failed!

I've tried few modules and every time same error appears. Yesterday I checked 14.3 version and there was same error but I thought because I switched from SuperSU but today I did clean install with new firmware and nothing changed. Any way to fix it?
[Magisk] teddy0209:
Try using a custom kernel... A none elf one if available...
[Magisk] Maverick_TN:
I have a feature request for Magisk Manager. I admit that I have become spoiled by the xposed installers date information for created and updated sorting of modules in the download tab. Would something similar be possible in the future?
[Magisk] Didgeridoohan:
Post your recovery log again, together with a copy of your boot image (just to keep them in the same place).

The unofficial version is using a different method than the official to work on the Pixel. It's being looked into.

Interesting how about uploading a copy of the script from before and after it gets altered and a magisk_debug.log from when the script runs (it's in /data).

The mount namespace thing just means that your kernel is to old to work with MagiskHide.

Loop mounting doesn't seem to work on your device. Could be several reasons. Some devices see this because they have a faulty implementation of f2fs. The solution could be using a different kernel or changing the file system. Hard to say...
[Magisk] Chamelleon:
So now because there is no custom kernel only way is to convert data to ext4?
[Magisk] DiamondJohn:
Is that "interesting" as in its not a known problem and thereby there is no known fix?
[Magisk] Aballamis:
So, I'm sure this has been discussed in the over 2000 pages on this thread, but....

I'm currently running the latest Resurrection Remix on a Op5 (A5000) and it installs with Magisk. BUT, the instructions dictate that you flash whichever superuser and binary you wish, so I flashed the latest SuperSU on top during install. Works fine, with SuperSU as superuser. My question is: Magisk manager is still there and I upgraded to 5.4.0 and the option to download is there with available modules....CAN YOU USE MAGISK MODULES ON TOP OF SUPERSU BINARY? Such as in this situation???
[Magisk] DiamondJohn:
I didn't know about service.d until I read a few of the last posts :o I placed my script in there, and it appears to have run :highfive: so that's the simple work-around

Safety net pass not needed, so thats OK by me.:good:
[Magisk] Vision:
Hex Editor app and magisk

Hi I have Xperia z5 nougat 7.1.1 32.4.A.1.54 with magisk v14 root.. And go to hex in setting to change for root permission and say this.. can not change shell. is your phone rooted? stream closed... Why?
[Magisk] Helbelinc:
Already tried with stock, advanced stock and abricot kernel.

The custom kernels install magisk 'succesfully', but as I mentioned: after the boot magisk tells me that it's not installed.

Pokemon GO strangely doesn't work anymore though
[Magisk] jhavron:
Tried using the AppSystemizer1.1.2.zip installed through TWRP and my Nexus 6 never got past the boot screen. Had to restore from a backup I made just before I tried to install the module.

I'm using Magisk 14.3

I'll try making a MagiskManager folder and report.
[Magisk] dimm0k:
is it possible for Magisk to replace services.jar in /system/framework/ with a module?
[Magisk] eg1122:
Yes
[Magisk] JairPaalman:
How does one get their stock boot image for flashing with Magisk 14? Google apparently doesn't know the answer.
[Magisk] DodoGTA:
One can extract it from flashable stock firmware files (.tar.md5 files for Samsung devices, factory images for Nexus/Pixel devices etc.)
[Magisk] Josey Wales:
I just successfully flashed latest Magisk and installed Magisk Manager. . .

Samsung Note 5 SM-N920T

Processor: Exynos7420

Baseband: N920TUVU4EQG3

Arm: arm64-v8a

SDK: 24

What's the correct Xposed framework and does it get flash in recovery to work in Magisk?
[Magisk] Sirius_Balzier:
Good to ear that :D

Tell me when you're ready, so i'll test it. :highfive:

ps: recently installed a lollipop custom rom based on KitKat kernel, i guess there's no problem, if yes, tell me and i'll go back stock. ;)
[Magisk] Didgeridoohan:
Maybe... I have not seen this confirmed by anyone.

"Interesting" as in I've never seen that reported before. Nice to see you've found a fix though.

Still really curious about the script. Could you upload the original script for a few tests?

Example:

https://xdaforums.com/apps/magisk/module-smali-patcher-0-7-t3680053
[Magisk] JairPaalman:
How exactly? Can I just use 7zip? I've got a new S8 today, and I don't want to mess it up. :D

---------- Post added at 09:11 PM ---------- Previous post was at 08:20 PM ----------

Also, would it be possible to debloat (remove system apps) from my S8 without triggering SafetyNet?
[Magisk] DodoGTA:
1. Yes

2. Probably yes
[Magisk] KProject:
I think it would b great if Magisk has full logging (like SuperSU Pro).

And, how to clear this a lot of log?

Sorry my bad English :D
[Magisk] Josey Wales:
Couple of questions. . .

Why do modules I download or install disappear from Magisk Manager?

After installing Magisk and Magisk Manager I ran Safety Net check:

ctsProfile: false

basicIntegrity: false

I don't know much as I'm learning on the fly.

Galaxy Note 5 SM-N920T stock 7.0

Baseband: N920TUVU4EQG3

Arm64

Magisk v14.0

Xposed v88.2
[Magisk] yochananmarqos:
Your answer is in your device specs you listed. ;)
[Magisk] Josey Wales:
Right. . . I figured it out soon after I posted. I have a new device so I'm being too cautious but thanks [emoji109][emoji41]
[Magisk] DiamondJohn:
I am guessing its not script specific, but more to do with the fact that the ROM is an unofficial build of RR (I built it) for an aging device (xt907), with an old kernel (LOS 14.1 sourced) that I think has been partially broken, as the data partition now has to be F2FS (originally it worked as EXT4). The zip also includes a last_kmsg for good measure.;)

Because of the above (ie the ROM source), and the fact I have a work-around for my issue (ie use a feature already built into Magisk :o), I would not spend too much time on it.
[Magisk] SDMU:
It would be really awesome if a sorting option is introduced in the magisk manager app . This will help the average user to quickly discover newly added modules :)
[Magisk] Xennet:
[MENTION=6429309]DodoGTA[/MENTION] [MENTION=4667597]Didgeridoohan[/MENTION]

Seems I ran into some problem...

Just did a clean install of my ROM OOS on OnePlus 3T today...rooted as usual wth flashing magiskk 14.0 stable zip via twrp...

But the magisk folder has no .core folder or postfsdata.d folder or hidelist folder ...only folders are that of modules I installed...

So I think I get the followng magisk log while hiding apps in magisk manager...

fopen: /magisk/.core/hidelist failed with 2: No such file or directory

Moreover to run scripts at startup to place scripts I don't have the postfsdata.d folder...

I have tried multiple times uninstalling magisk via magisk uninstaller and reinstalling...new fresh clean install.nothing seems to work..

Will it work if I create the directory structure of magisk manually and place files and give permission 777? Or is there a solution?
[Magisk] Didgeridoohan:
The module installation issue might be because of a corrupt Magisk image. It seems to happen sometimes when installing large modules (like iYTBP). The easiest solution is uninstalling and reinstalling Magisk.

I'd start by uninstalling and reinstall Magisk. I've had no issues on my OP3T on OOS 4.5.1, neither on v14.0 or v14.3 beta.

[MENTION=2134415]sebx_g1[/MENTION]

You're in the wrong thread. The beta thread have very strikt rules, one of them being "no SafetyNet discussions". Besides, your log zip is missing the important magisk.log and magisk_debug.log... If you want help, post in this thread or create a new one, whatever floats your boat.
[Magisk] Xennet:
Yah that's why I tried multiple times uninstalling via the magisk uninstaller and reinstalled...yet the folder just don't seem to appear...

Can you just provide the folder structure...or folder zip so that I can just copy them over and the permissions so it may work..
[Magisk] KProject:
Xposed break Safety Net. Try to uninstall Xposed, then check Safety Net.
[Magisk] Didgeridoohan:
Sorry... I somehow read right past that part of your original post.

Just to make sure, you have made sure that your file explorer is configured to view hidden files and folders, right?
[Magisk] Xennet:
Yah..the file explorer is having root access and is configured to view hidden files...still no luck..
[Magisk] olivercervera:
To you and users of Barclays crap-app: [MENTION=3250933]rasseru16[/MENTION] [MENTION=1095206]daleski75[/MENTION] [MENTION=4915185]dtective[/MENTION] [MENTION=4834882]mihirr[/MENTION]

Original response here: https://xdaforums.com/showpost.php?p=74381007&postcount=12

Quoting myself for this purpose:

The great Topjohnwu is working on a new update that includes a key feature for us: reinstalling Magisk Manager with a random package ID.

These changes are in his Github Repo. On this thread you can find unofficial versions of Magisk compiled from Github.

I have tested Magisk-v14.4-20171102-091345.zip: HELL IT WORKS!

In Magisk Manager: go to settings and you will have the option to reinstall Magisk Manager with a random package ID

Install Barclays from Play Store

Add Barclays to Magisk Hide

Open Barclays, it will behave correctly and will work!

This solves our problem, Barclaycrap is beaten again.
[Magisk] olivercervera:
Thank you! What kind of root method did you use for Magisk?
[Magisk] daleski75:
I used phh root with no xposed and magisk to hide it, now my builds don't even have root in them so no need for any additional software to hide root etc.
[Magisk] Captain_Throwback:
This isn't an Xposed thread, and if your issue happens with the official Xposed, then you should be submitting an issue to the official Xposed github.
[Magisk] Nando_aot:
Iam using AICP which use cm13 mm, if you test it and report back taht will be great... Thank you
[Magisk] patkor:
Hello :) i've tried your method but still not working for me .. in TWRP installed CM then gapps, connected to computer and in adb and fastboot typed adb devices and saw my phone, then typed that adb shell ... and didn't get any anserw just new command line, and finaly magisk, phh superuser and still toggle gets automaticly on ..

Sorry for my english.

:)
[Magisk] olivercervera:
OK, I have used supersu, maybe by using PHH will do the trick. Will try, thanks

Well, if you don't have root at all it's anoter story :p
[Magisk] Aakash Kaushal:
Okay so now i clean install everything with phh supersu app and now switch on/off working fine but pokemon go stuck at loading screen(rbc wallet is working fine though).....now this is a new problem...either pokemon will work or root will work :rolleyes:
[Magisk] Äptiva:
Fastboot isn't necessary. Were you still in recovery when you did the adb command?
[Magisk] maurili00:
Problem on CM13 peregrine

Everytime when I boot my Moto G LTE (first generation), the su and all these archives keep coming back. How I can fix this?
[Magisk] qwertyxyz001:
check attachment
[Magisk] daleski75:
I think that will work :)
[Magisk] Captain_Throwback:
Is there an updated TWRP for your device (3.x)? The outdated version of TWRP you're using may be why you're having an issue.
[Magisk] azsde:
Thank you :)
[Magisk] patkor:
I have "Minimal ADB and Fastboot" program.. Yes i was.

Edit: Forgot to add that i have LeTV X800.
[Magisk] Syoenth:
What would happen if I delete /dev/socket/su-daemon?
[Magisk] ShapeShifter499:
I haven't read this thread in a while, does this still kill all ROOT processes when SU is unmounted?
[Magisk] renezada88:
Could anyone please help me with this problem?

http://xdaforums.com/z5-premium/help/xperia-z5-premium-magisk-error-t3461225
[Magisk] CKWTHN:
Got it to work

I can now toggle Root on and off without problems.

I actually had a SuperSu magisk modified version, but still no avail, Problem was that I had a previous Supersu Flashed when I rooted, and it was conflicting the new one, Somehow I got it to work and Problem now is I still got a CTS Profile match problem on safety net check, My bootloader is still unlocked and that is what I'll be working on tomorrow.

Thank you much...
[Magisk] mundodisco8:
That's brilliant, although I'm quite sure that the Barclays app developers are also subscribed to that thread and are working around it :D

I'll check it out nevertheless.
[Magisk] clps995202:
It actually happened on my Zenfone 2 Z00L and Redmi Note 4 Snapdragon version. Already tried uninstall and reinstall Magisk, still don't work. Modules won't install and won't pass safetynet. Also tried to reflash the system partition with rom but still no luck. The only way to make it success is to format all and reflash it .Hopefully can provide some solutions to this situation cuz it's a bit tired to reinstall all the apps....

Oh and this thing happened after flashing Pixel 2 Fonts with product sans fonts of Android Oreo 8.1 DP1 on Note 4 and systemize an app on Z00L using Terminal App Systemizer + UI v8.1

And I forgot to mention that Note 4 is running on Miui 9 7.10.19 by Xiaomi eu and Z00L is running on Resurrecttion Remix 5.7.4 Marshmallow
[Magisk] olivercervera:
Mate you made me laugh so hard! :p:p:p:p:p

Even if they find a way around it, it will take some time. If they implemented such a lame way to detect Magisk means they ran out of ideas!
[Magisk] Didgeridoohan:
Hopefully someone can provide relevant and useful logs of the issue, so that [MENTION=4470081]topjohnwu[/MENTION] have a chance of properly troubleshooting...

---------- Post added at 16:56 ---------- Previous post was at 16:49 ----------

No idea then... Things I'd try:

Use the uninstaller zip in TWRP

Flash an untouched boot image

Make sure that the magisk.img file is gone from /data

Flash v14.3 beta

If it still doesn't work, post the magisk_debug.log from the first boot after installing (it's in /data)
[Magisk] tcpcd:
modules not showing, here is error log

pls help, how to solve this
[Magisk] clps995202:
Got the same error as your's. Can't reproduce it again cuz I clean flash the whole thing..., but I'm pretty sure it has the same error. Btw, you can't pass the safetynet right ?
[Magisk] Xennet:
I just solved it...

Just created .core folder in /magisk and inside it the post-data-fs.d and service.d folders...

Now tried hiding an app in magisk

It automatically created hidelist file in .core folder

Then switched on systemless host and it again created hosts file inside .core folder...

Now hide apps and systemless hosts works flawlessly which earlier created logs that the .core directory not found...

And even placed .sh script in post-data-fs.d folder and it too works..

I don't know whether it's bug or not but someone earlier too reported something like this...

https://xdaforums.com/showpost.php?p=74094932&postcount=19611

Hope it helps if it needs to be addressed...
[Magisk] tcpcd:
yes bro right. i cant pass safetynet
[Magisk] Didgeridoohan:
That's not a solution. It's a workaround...

Was this on v14.0 or v14.3 beta? Because if it doesn't happen on the beta, it has already been addressed...
[Magisk] Xennet:
It's on 14 stable..

On stable 14 this is the only way to get it done..multiple flashes...uninstalling via twrp..flashing untouched boot IMG nothing seems to work...
[Magisk] tcpcd:
i try in BETA but not work.

Will reflash rom solve problem?
[Magisk] Didgeridoohan:
Is it possible for you to try a clean install of v14.3 beta? If that works we know that everything's dandy...

Did you completely uninstall Magisk first? If not, that

might

help...
[Magisk] kerpert:
Thanks for reply, I did a cache cleaning and now it works (wasn't been enough to reinstall the app only).
[Magisk] Choose an username...:
I have the same error, too
[Magisk] D-m-x:
Not a problem but I'd like to know if someone could enlighten me just for learning purposes. On very rare conditions sometimes after installing an update (IYTBP for example) after the reboot I'm in Force close Hell with no end. Another reboot fixes that again immediately. Maybe 1 out of 50 times (installing or updating a module).

Anyone know why this happens at all? The logs don't show anything different or suspicious. I've seen this maybe 3 or 4 times over various Magisk Versions until now.

Gesendet von meinem SHIELD Tablet K1 mit Tapatalk
[Magisk] tcpcd:
yes i tried to complete uninstall but it wont uninstall. whenever i reboot my phone magisk came back.
[Magisk] Didgeridoohan:
Have not seen that reported before. Next time it happens, hook your device up to a computer and grab a logcat.

Sounds like your setup is seriously messed up... Use the uninstaller zip in recovery. In case that also fails, make sure to save the recovery log.
[Magisk] tcpcd:
anyway i reflashed rom because no custom recovery installed.

so now magisk viper module installed successfully
[Magisk] D-m-x:
Yeah sure, will do. This time I rebooted straight away and forgot the Log, just thought maybe someone has heard it before :) :good:
[Magisk] papzi57:
Hello!

I have an OP 3 with OpenBeta 23 software. [MENTION=4470081]topjohnwu[/MENTION], as described here ( https://github.com/topjohnwu/Magisk/blob/master/docs/tips.md#ota-installation-tips ),

has anyone tried to upgrade to OpenBeta 26 so that the Magisk will also work and the phone will be flawless?