yashsingh1/xdaforums huggingface dataset:
[Magisk] martyfender:
[MENTION=4470081]topjohnwu[/MENTION] updated the Op in his stable thread and I see solutions to many posts I have read in recent weeks:

Notes & Troubleshoots

If you experience any bugs, check whether there is a newer version in beta, as the bug might have already been fixed. Please follow the instructions in Beta Thread OP to report a bug properly.

Please read this if you plan to use the "Hide Magisk Manager" feature: When using the hide Magisk Manager feature, the app will generate a random package name, repackage, and replace itself. Once you've repackaged Magisk Manager, please ALWAYS upgrade the app within Magisk Manager itself. If you plan to restore to official Magisk Manager, either use the Restore Magisk Manager option in settings, or uninstall the repackaged manager and manually reinstall the official APK.

MagiskHide relies on ns proc mnt file descriptor introduced in Linux 3.8. Even if you are running a kernel lower than 3.8, it is very likely this feature is already backported. If your kernel lacks this feature, you can build (or ask your custom kernel dev) with some additional patches. The relevant patches are: set CONFIG_NAMESPACES=y in defconfig, and apply this patch. More info: Namespace file descriptors (2010 original article)

Additional info are presented below:

Q: After flashing Magisk, my device will show a scary popup saying "There's an internal problem with your device. Contact your manufacturer for details"

A: This is caused by dtbo image patched to remove AVB 2.0 of the vendor partition. This is required for allowing you to mount vendor to rw and make modifications

If you never plan to modify the vendor partition, in Magisk Manager, "Uninstall > Restore Images" to restore the images, check "Preserve AVB 2.0/dm-verity" box in Advanced Settings, then reinstall Magisk via the app.

Some Motorolla devices' stock kernel ships with a flawed F2FS implementation. Change to a custom kernel with the fix or format data to ext4.

Magisk Manager CANNOT be placed in adoptable storage

Q: WebView is crashing on my device when I enable MagiskHide

A: It's a bug in your ROM, please ask your ROM developer to include this commit to fix the issue

Some of the ASUS devices requires boot image signing, search the forums and sign them yourselves.

Sony Stock ELF Boot: Please refer to the info when flashing Magisk in custom recovery

Q: Safety Net isn't working!

A: If your ROM itself is not able to pass SafetyNet, then there is nothing Magisk can help.

Your best bet is to run 100% stock ROMs, since your phone manufacturer is forced to release a device passing CTS.

Maybe this info should be stickied in both the beta thread and the general troublshooting threads op?

@ Didgeridoohan would the above be relevant to add to your great troubleshooting guide?

I wanted to add the hide tag to this but for some reason it is not showing up, even when I choose : go advanced. Does anyone know why? It even happened when I removed the quotes.
[Magisk] andrew2432:
Doesn't show up in the app
[Magisk] WalkerLee:
John,

It's EZ to flash Magisk v16.0 into my OS. But after I added a module what calls 'Xposed Framework (SDK 27)' my phone fell into a bootloop until I remove Magisk via the TWRP.

So this phone won't be a useless stone but I still cannot use Magisk. :(

The phone is a Xiaomi Redmi Note 3 'Kenzo', with Resurrection Remix OS and Android 8.1. I think Android 8.1 is using API 27, right?

Magisk is a useful bridge between users and systemless modules. I like it. So please help me! Thanks a lot! :o
[Magisk] martyfender:
I removed the quote tag to see if that is the reason it does not show up. Do you mean the xda app?
[Magisk] DroidJP:
Hey guys, i was wondering if it is possible to have a magisk flash zip that keeps the encryption enabled when flashing the zip in recovery? I extracted the zip to have a look at the scripts and i noticed that the flags are set to false on verity and keepforceencrypt i changed it to true and zipped it, and when i flash in recovery after factory reset. Data partition is not encrypted.

The only way to encrypt data is to patch the stock boot file within the manager and then flash it after. Be nice if somehow this could be enabled on the flash zip version.

Thanks.
[Magisk] Didgeridoohan:
You'll have to specify what you mean by "keep failing". Logs are always useful.

https://www.didgeridoohan.com/magisk/MagiskHelp

And here's some installation guidance:

https://www.didgeridoohan.com/magisk/Magisk

The only new info I see in there is about MagiskHide's reliance on the ns proc mnt file descriptor (topjohnwu recently found a way to relatively easy add this to kernels that lack it). The rest has actually been in there for some time, and pretty much all of it is covered in my guide in one way or another. Although not as compressed...

You're not having an issue with Magisk. Your issue is with Xposed... Don't use the Xposed module, that's all.

---------- Post added at 08:55 ---------- Previous post was at 08:49 ----------

If encryption is detected during installation, Magisk should keep the forced encryption flag intact. If this doesn't work, you can also use the .magisk file to set the flag:

https://www.didgeridoohan.com/magisk/Magisk#hn_Keeping_dm-verity_and_forced_encryption
[Magisk] DroidJP:
Yeah, i tried that and that did not work, i did find a workaround though. Basically i took the stock boot img and let the manager patch it with verity and encrypt boxes checked, boot into twrp, flashed the patched boot img, backed up boot as twrp img, facrory reset, flashed magisk, restored patched twrp boot and then reboot. Data is now encrypted. Just wished that the zip did all this in one flash lol.

So this tells me that the encryption is within the boot and not the .magisk, which explains why the commands did not work.
[Magisk] Xplorer4x4:
We would need to know what your device is for starters. I am guessing the version of Liquid Remix is specifically for your device as there is no gsi in the treble related forum here on xda.

As for fastboot, fastboot is not an IMG file. You can grab the universal adb and fast boot installer here on xda. The adb and fastboot.exe included are rather dated but I have a Moto G6 Plus which is pretty much a brand new device and I have not ran in to any issues with them doing what I need for them to do.

What you need to do is boot and/or install twrp on your device. You may need fastboot to boot a twrp IMG. Once booted to twrp you can flash the twrp zip for your device if one exists. From there you need to install the magisk zip by flashing it in twrp(you can do this from a booted twrp.img if there is no way to install twrp on your device).
[Magisk] KitsuneFoxy:
Hi, I'm using magisk on Chroma Marshmellow 6.0.1 (hellscore b88 kernel, last available for MM) with my nexus 4 and it works for the SU portion, but when i try to install any module, It'll download and "install" it (going through the termninal intall script etc), but when i reboot, it's not even there on the active modules and seemingly was never installed in the first place.

I don't know what is wrong, The phone is fine, runs well, It's just i can't install any magisk module. I've tried v16 and 16.6.

There is no magisk log in adb/data

Logging is not disabled.

Catlog included.

Anyone have any advice?
[Magisk] AngryLady:
Please Security Auditing Magisk v16.6

Why Magisk now access internet during boot so-called Startup Operations and what's the purpose New Demon Monitoring and replacing Invincible Mode in v16.6. Are you being paid by Googvernment to do this? Please audit and explain everything to the people! Thanks.
[Magisk] UFG93:
Well when I try to flash the zip ( i tried both versions 16.0 and 16.6) it gets stuck at flashing new boot img then the phone hangs no matter how long I leave it for then I have to turn it off and on again.
[Magisk] Xplorer4x4:
Logs
[Magisk] UFG93:
Hi thank you.

I'd already done those things (used fastboot and TWRP to flash the rom)

My device is a Lenovo P2.

When I try to flash the magisk zip (tried versions 16.0 and 16.6) the installation gets stuck on flashing new boot img and then the phone hangs until I turn it off and on again.

I tried using magisk manager but I don't know how go get/find the patchboot.

---------- Post added at 09:52 AM ---------- Previous post was at 09:48 AM ----------

I'll try to get them for you.
[Magisk] Xplorer4x4:
Good but understand that they are not for me. I do not have the knowledge of some of the members/devs here to truly be able to assist you most likely. However, for those that have the knowledge, logs are almost a detrimental part of helping you and it helps them be able to make changes to magisk(for example) so that these issues do not persist for you and others with the same issue.
[Magisk] Karls0:
I can't because it is not shown on the list. Seems like MagiskHide has no ability to see cloned apps. AFwall+ can see clone for example so it is technically possible. Is there any way to do it manually or do we have to wait for adding this feature in later releases?
[Magisk] mimmmmiiii:
Pixel 2 on Android P DP4 Magisk can't patch boot.img

Hi,

I was on Oreo 8.1 security patch July and rooted by Magisk 16.4 with stock rom,

uninstalled to stock boot and OTA Android P DP4,

then I want to patch my stock boot and got attached install_log_20180714_170730,

also CTSprofile always false even after cleared play store cache and data,

it could be flashed via boot to TWRP 3.2.2-0 but ended up to " can't load android system " as attached screen (this picture is from other post, same messages but I was using walleye),

any idea appreciated and thanks for your time! TAT

Best regards,

Mi
[Magisk] UFG93:
Alright. I get it. Thank you.

I'm very sorry but I'm having trouble posting the logs I copied.
[Magisk] grotesque02:
I'm on oreo rom (8.1) with magisk 16.6.

Tasker is very slow to work or not work at all (work only if I manually run the task) seems like is sleeping.

This never happend with old supersu.
[Magisk] evh5150ni:
I'm still confused about OTA updates with Magisk on the Mi A1.

My understanding is that to take OTA updates on the Mi A1, you need to flash the stock boot and recovery, then do your OTA updates, and then re-flash Magisk. Is this correct?

The Magisk github states that to take OTA updates, you restore images in Magisk, install OTA as normal, and when it gets to step 2/2, install Magisk to the second slot. But the second slot option does not appear for me.

What is the simplest way to take OTA updates when wanting to go back to Magisk immediately?
[Magisk] SL0nick:
Can anyone explain how to replace bootanimation.zip on latest beta?

Thanx!
[Magisk] martyfender:
As I just found out, logs are no longer in /data/adb, as of v16.6. The magisk.log is in /cache
[Magisk] andrew2432:
Idk
[Magisk] KitsuneFoxy:
Thanks! I updated my original post.

https://xdaforums.com/showpost.php?p=77068536&postcount=25871
[Magisk] Jaymin.0.1910:
The same old way, just use '/data/adb/magisk_simple' instead of '/cache/magisk_mount'.

Regards
[Magisk] jcmm11:
[MENTION=3004763]SL0nick[/MENTION]

This is correct - but some phones (ROMs?) don't mount it soon enough. If you look in the log you see that it does get mounted, at the very beginning, but it's still too late and the original animation is what gets processed.

This is really dependent on your device. Where it doesn't work your only option is to either live with the existing boot animation or give up the systemless option and go in and modify the system partition.

If you're running a custom ROM you don't really lose anything by actually modifying system.
[Magisk] Jaymin.0.1910:
Hello, could you provide module installation logs??
[Magisk] andrew2432:
Yeah in the app you have to type it out yourself and it doesn't hide like it does in a browser in the app, it just shows always
[Magisk] Didgeridoohan:
It's open source... You can audit everything right here:

https://github.com/topjohnwu/Magisk

And the new invincible mode with the main Magisk daemon and the magisklogd daemon working together is explained here:

https://xdaforums.com/showpost.php?p=77014053&postcount=43

Do you mean the stock boot image, so you can patch it? Or where the patched image is saved on your device?

https://www.didgeridoohan.com/magisk/Magisk#hn_Wheres_my_boot_image_for_the_Manager_to_patch

Attach them to a post here, or save them to a cloud or sharing service and post the link.

Haven't seen any kind of issue with Tasker for some time. And even then nothing like what you describe.

Could you provide more information on why you believe it's a Magisk issue?

The OTA instructions on GitHub are a little outdated and will be updated eventually. Restoring stock boot and recovery, or simply flashing the entire updated OS are the current options for updating. Best place to ask for assistance might be in your device's forum though...
[Magisk] grotesque02:
FOr example I make a task when phone isn't connect to wifi , turn data on and enable lte, and when wifi is connected turn data off and gms only.

With old supersu this task woprk, now with tasker work only if I start the task manually.

Anothe example is maxlock (xposed module, of course I have systemless xposed now) wifi connected ->maxlock disabled and wifi disconnected ->maxlock enabled.

With supersu this don't happend.
[Magisk] KitsuneFoxy:
Hi there!

I have uploaded logs now in a zip on my original post. but there seems to be no errors

https://xdaforums.com/showpost.php?p=77068536&postcount=25871
[Magisk] Xplorer4x4:
Click the reply button above the quick reply box towards the bottom right after last post. Then click the paper click icon on the text editor tools. Upload logs. You could also use www.pastebin.net and copy the contents of the log and post it there and share the URL here.
[Magisk] Didgeridoohan:
Tasker has had some issues with MagiskSU. Some of it is supposed to be fixed but I haven't checked recently. You can check the log if your profiles even run (three-dot menu - More - Run Log).

You can also upload your profile, so it's easier to see what's being done.

It might be better of you head over to Tasker's support forum though, and ask dior help there.

There are plenty of errors in those install logs. The module directory can't be created in the Magisk image, for some reason. Looking at those logs, you should be able to install modules through TWRP though... But, let's try to figure things out.

Question is, why can't you create the module directories? Is your Magisk image mounted rw? What do you get from this command in a terminal emulator:

mount | grep /sbin/.core/img
[Magisk] Jaymin.0.1910:
As Didgeridoohan said, plenty of errors are there. But the main reason behind the failure is that your magisk.img could not be mounted rw. I suggest you to try installing from twrp recovery.

Regards
[Magisk] KitsuneFoxy:
Thank you for the information!

Is there a way to fix the mounting error so it will work as normal, instead of flashing modules via TWRP?
[Magisk] Jaymin.0.1910:
Hey there, I will recommend flashing a different kernel which doesn't have the mounting bug or else if it's the F2FS, reformat it to ext4. But anyways, you will still need to reboot to activate the module, so what's the problem with TWRP (trust me, sometimes TWRP is a better option for flashing) ??

Regards.
[Magisk] KitsuneFoxy:
Thanks both of you!

I will do that terminal command. (initially i missed your post)

Image attached it what the command brought up.
[Magisk] KitsuneFoxy:
I dont use F2FS. All the partitions are EXT4.

I can't use a different kernel, Chroma freaks the **** out when i try to.

Chroma was built entirely around hells cores kernel.

and nothings wrong with twrp, but i wouldnt be able to turn the modules off and on because magisk wont know
[Magisk] Didgeridoohan:
The go-to solution when the image gets mounted ro have usually been to try a different kernel...

I'd ask the ROM creators for advice.
[Magisk] KitsuneFoxy:
Ah, [MENTION=1978554]zephiK[/MENTION] is retired, and dont think he's around now. to help with that.

I atted just in case he is, and mighht offer advice on how i can change it.

or if anyone around can offer adivce to change it. Maybes it's a script in the rom installer? Or something i can change in android?

If it's the img folder in the sbin core. Can';'t i change it to group and world R/W through terminal or adb?
[Magisk] guest4711:
You could disable/enable them using "Magisk Manager For Recovery Mode (mm)" by [MENTION=5228676]VR25[/MENTION].
[Magisk] kegang:
I can't uninstall MAGISK :(

I've wanted to unroot my device(SM-G950N Galaxy s8) so, I tried to unroot it from Magisk Manager, but it failed.

I flashed the Latest Magisk uninstaller zip file, and it shows this. What is the problem? :confused:
[Magisk] jcmm11:
You could try a different ROM ? maybe one more up to date ? You don't mention your device, but if there's no Oreo ROMs, I'm guessing it's an old Nexus device so you can probably find a Pure Nexus build for it - also discontinued, but would get you up to nougat.

As an alternate possibility you can try placing a startup script in service.d that contains the following command

su -mm -c mount -o rw,remount /sbin/.core/img

I'd try that command in a terminal emulator first to make sure it works.
[Magisk] guest4711:
As shown in your screenshot: You probably need to reboot to recovery after formatting /data to be able to access this partition... And the uninstaller wishes to access it.
[Magisk] WakedPaul:
I have a Note 4 ( N910W8 ) and I was playing around with some custom ROMs, this week I went back to stock (most ROMs I tried didn't have the features I needed or were too unstable).

Turns out the 16.6 version doesn't work with a stock N910W8 on 6.0.1 (it might with other Note 4 versions). I had a previous 15.3 zip on my SDcard and that seems to work. I could try previous 16.* versions but 15.3 seems fine for now.

What doesn't work with the 16.6 version on my N910W8 ;

Magisk hide doesn't work (can take up to 90 seconds to populate the screen and any app selected becomes unselected when going back in)

Couldn't install BusyBox (it would see itself as installed but apps that would use it would say it wasn't, it would also be uninstalled after a reboot)

SafetyNet kept failling, no amount of workaround worked.

All of the above aren't an issue with 15.3.
[Magisk] KitsuneFoxy:
Hi there. My phone is a nexus 4. I've tried nougat and oreo roms. They make my phone unusable, hand burningy hot, and work very poorly.

Marshmellow has always worked flawlessly, I gets four days battery idle or more. And three hours SoT. Nougat, oreo i dont get half an hour.

Either way. Thank you for the script. I will attempt that. However i will say that this is not the only marshmellow build i have had magisk issues on, all the other bigger marshmellow roms like slim 6, pure nexus and such seem to have this issue.

edit

Tried your command and met with "read only file system"

I'm not sure if theres a way to stop whatever is setting the filesystem to read only, it must be something in the rom. the kernel is prebuilt in.

So i took a look inside the rom, it has supersu in there. So i've replaced that with magisk, but used the same supersu names. So it should flash magisk along with the rom now.
[Magisk] Tr4sHCr4fT:
ASUS Zenfone Zoom ZX551ML

Magisk v16.4 + Manager 5.7: OK

Magisk v16.4 + Manager 5.8.1: opening Manager stuck on Logo

Magisk v16.6 + Manager 5.8.1: opening Manager stuck on Logo
[Magisk] j1gga84:
Which module can I use to change SELinux? Or is this only possible with Xposed?

Regards

Sent from my SM-G900F with Tapatalk
[Magisk] guest4711:
Magisk Selinux Manager, see https://xdaforums.com/apps/magisk/module-magisk-selinux-manager-t3760042
[Magisk] martyfender:
This is an app and not a module, but I find it works very well on my devices:

[MENTION=8240249]Ibuprofen[/MENTION] 's The SELinux Switch:

https://xdaforums.com/android/apps-games/app-selinux-switch-t3656502

Some kernels, though are not capable of permissive selinux.
[Magisk] pitsgraft:
dear dev,

I would like to ask your permission to upload and share Magisk manager and Magisk 16.6 file via mega drive to

https://xdaforums.com/xperia-z/orig-development/lineageos-14-1-xperia-z-t3637730/page67

due to I previously installed the rom without TWRP & ROOT. but using your magisk manager I managed to get my xperia z c663 rooted with custom recovery ...it work flawlessly.

if granted I will post and share link too
[Magisk] Didgeridoohan:
Any report about issues will only be useful if accompanied with relevant logs.

Whatever it is that's preventing the image from mounting as rw is in the kernel. Unfortunately I know next to nothing about it...

The magic happens right here (in case you want to start digging):

https://github.com/topjohnwu/Magisk...74a2940ed52/native/jni/core/bootstages.c#L405

Any report about issues will only be useful if accompanied with relevant logs.

Why use an annoying file sharing service when you simply can link to the Magisk release thread, where everything is readily available?
[Magisk] pitsgraft:
well not just a file but files in a folder that i create in mega, or maybe Gdrive. ahh well i was just wanted to share the how to...

please skip the requests to share
[Magisk] Didgeridoohan:
How-to's are awesome! :highfive: But, in my opinion, it's always best to link to the source instead of uploading stuff somewhere for yourself.

The people reading your how-to know that the files are legit and not tampered with.

You don't have to bother with the files, since they're already available.
[Magisk] pitsgraft:
well the file versions is specific 'as far as I know and use' if a link to a thread if may have been an updated version that 'without disrespect to dev' may cause issues...

okay than I'll share thread links...

done. this, thanks

https://xdaforums.com/xperia-z/orig-development/lineageos-14-1-xperia-z-t3637730/post77085241
[Magisk] zurik:
Someone have issues with Safetynet on latest Magisk 16.6 beta?
[Magisk] Didgeridoohan:
Nope...

https://www.didgeridoohan.com/magisk
[Magisk] zurik:
Ok, it fixed by itself ...
[Magisk] pantezuma:
I'm also confused as Second Slot option doesn't appear on latest Magisk Manager (it did in previous versions and I always updated that way).

Don't know if it's a bug in Manager or a device specific problem.
[Magisk] DanGLES3:
Its been temporarely removed due to issues and that magisk manager didn't fully supported the process (atleast that's what's stated on the dev's github page)
[Magisk] martyfender:
Sorry, yes I did. You can understand my confusion, with similar spelling.
[Magisk] jcmm11:
(Replying in general thread since this may veer a bit OT)

I'm using dnscrypt-proxy + WireGuard myself, with no issues at all. I'm also starting them myself, using scripts in service.d - as well as applying the needed iptables rules to get DNS to work.
[Magisk] KitsuneFoxy:
Thanks for the response! I've asked in the kernel creators thread to see if anything will come of it. Many thanks.
[Magisk] tcat007:
I've been curious about this check box. I am decrypted, and magisk always shows this box checked by default. So does it also preserve forced decryption if checked?
[Magisk] beardymarrow:
It preserves force encryption if ticked (it doesn't enable it), so in other words if force encryption is enabled it will remain enabled if you tick that box. If you're already decrypted then force encryption must already be disabled, in which case that option has no effect.
[Magisk] Ibuprophen:
This is always understandable and she just wanted to make sure that you were aware of this in case you needed my attention to something.

Have a great day! :)

~~~~~~~~~~~~~~~

I DO NOT provide support via PM unless asked/requested by myself. PLEASE keep it in the threads where everyone can share.
[Magisk] m0han:
I'd flashed a decrypt.zip file for my device and magisk showing the box checked was disconcerting. But, after checking further, it appears I'm 'not encrypted', right?

View attachment 4551979