yashsingh1/xdaforums huggingface dataset:
[Magisk] trias10:
Hello, I have a question regarding Magisk's patched boot.img method.

I recently created a patched boot.img following the instructions for creating one, using Magisk Manager 6.0.1. I then flashed this patched boot.img but it did not work -- it caused my phone to boot loop, and I had to hardware reboot into bootloader, and then flash the original stock boot.img to get it working again, which did fix the bootloop.

My question is, when my phone attempted to boot from this bad patched boot.img, could that have in any way corrupted the OS install/partition itself? My phone is working fine again after I flashed back the stock boot image, but I'm wondering if my failed foray into Magisk patched boot.img could have introduced any bugs or corruption into the OS such that I should factory reset the phone before continuing to use the phone as normal? I don't know enough about Android executing byte code in the boot.img to know if it's even possible to touch/corrupt any other partitions from a failed boot.img?

The bad patched boot.img did get as far as the boot-encryption process, asking me to input my decryption key, but after I entered it, it would immediately just reboot, ad infinitum.
[Magisk] regularmen:
I'm not sure this is the right place to ask, but since there are no threads related to dnscrypt module, I need help about getting my dnscrypt module to work. Installation is fine and have set it to automatic but when I put it to leak test, it sill showing my origin dns server. Have reinstalled it again and use manual mode and changed the dns from third party apps, still not working. Using magisk 16.1 and stock oreo rom, anyone know what is happening
[Magisk] martyfender:
Have you tried this module? I know it is not encrypted dns, but it uses cloudflares dns, which for me, it shows cloudflares dns on the dnsleaktest site.
[Magisk] xunholyx:
Cloudflare has an app now for using their DNS https://play.google.com/store/apps/details?id=com.cloudflare.onedotonedotonedotone
[Magisk] mordantly:
I tried to strip magisk 13.3 out of my zip and I get invalid when I flash. What compression and such does it need?
[Magisk] demonoidmaster:
Since all roms, modules etc all are zips, keep it that way, there isn't anything in rar format, because zips can be flashed, rar archives can't

So here's what you do, open your rom zip in winrar, find where the magisk zip is (usually /magisk/magiskziphere.zip) just delete that folder or the magisk zip, doesn't matter, winrar will rezip the rom as it were without changing anything about the file format or compression
[Magisk] mordantly:
Interesting... tried to with 7zip and no worksies. Then ried store compression.. I have winrar getting dusty thanks! Gonna get medieval on his donkey., BTW, in-place flash over previous version said found magisk boot image and reported no issues. Not wanting to risk another dmverity or upgrade bootloop again.
[Magisk] regularmen:
I tried, the internet doesn't working anymore.

However when checking in grep, it shows 1.1.1.1 as my dns so I guess it works but it wont connect to anything

Well there it is, it's just works. But would like to try again in systemless way
[Magisk] kiwigi:
Install Via Magisk Manager:

This method does not need root, and also does not require a custom recovery.

However, you MUST have a stock boot image dump beforehand, and you also have to be able to flash the patched boot image, either through fastboot/download mode or ODIN

Install the latest Magisk Manager

If you're planning to flash the patched boot image through ODIN, go to Settings > Update Settings > Patched Boot Output Format, and select .img.tar. For normal users leave it as the default .img

Press Install > Install > Patch Boot Image File, and select your stock boot image file

Magisk Manager will now patch your boot image, and store it in [Internal Storage]/Download/patched_boot.img[.tar]

Copy the patched boot image to your PC. If you can't find it via MTP, you can pull the file with ADB:

adb pull /sdcard/Download/patched_boot.img[.tar]

Flash the patched boot image to your device and reboot. Here is the command if using fastboot:

fastboot flash boot /path/to/patched_boot.img

I have managed to extract the oreo boot.img.lz4 by using the modded 7zip found here

Following that I have patched the image succesfully.

I had no luck yet with adb fastboot flash boot...:" waiting for device". Interestigly ; "device XXX found".

Nice Oreo home screen:)
[Magisk] martyfender:
With Samsung devices you have to use Odin to flash it, with the phone booted to download mode. I don't believe they have fastboot, if I am not mistaken.
[Magisk] kiwigi:
Thanks [MENTION=8126387]martyfender[/MENTION]

Ok, I will have a go with the tar version.

Is there an option for a nandroid backup as the setup I got now is nice enough except no Magisk/root yet.

Thereafter, Is it best to flash boot.img.tar first and then flash TWRP?
[Magisk] martyfender:
I would probably flash TWRP first, do a nandroid backup, then flash the boot.img.tar. On fastboot devices it is also possible to temp boot TWRP, without installing it to do the backup. That way you can also backup the stock recovery. I'm not sure how to temp boot TWRP on your device though, maybe through Odin? Be warned though, if you do restore it and you have TWRP installed, unless you uncheck recovery, it will overwrite TWRP with the stock recovery. Personally, I don't need a stock recovery backup, so I delete that file, so overwriting does not happen.
[Magisk] guest4711:
If there is a TWRP for your device it would be best to flash TWRP via ODIN, then reboot to TWRP and (backup your data and) flash Magisk, then reboot to system and enjoy...
[Magisk] kiwigi:
[MENTION=8126387]martyfender[/MENTION] [MENTION=8010004]guest4711[/MENTION]

Thanks to you both!

I'll take that advise and will try this step within the next couple of hours.

I guess I have to be careful to untick ODIN "reboot" while flashing TWRP. It happen to me more than once that I had to repeat the lot.

---------- Post added at 05:38 PM ---------- Previous post was at 05:38 PM ----------

[MENTION=8126387]martyfender[/MENTION]

[MENTION=8010004]guest4711[/MENTION]

Thanks to you both!

I'll take that advise and will try this step within the next couple of hours.

I guess I have to be careful to untick ODIN "reboot" while flashing TWRP. It happen to me more than once that I had to repeat the lot.

Do I swipe to allow Modifications?

I did swipe to allow. Still something is not right

I'm doing something wrong somewhere...:mad:
[Magisk] martyfender:
You should not have to flash Magisk in TWRP, if you are flashing the patched boot.img. You would do one way, or the other, not both, assuming the boot.img is properly patched.
[Magisk] kiwigi:
I have only flashed TWRP and entered recovery without booting. See the comments on the previous page what happen when I wanted to do a nandroid backup :mad:

As I said, I must be doing something wrong:(

Is there a way to get out of what looks like a "lot of red stuff"?
[Magisk] Prince Charlie:
Long Boot Times

It takes 30sec+ to startup on LOS 15.1 Oreo based rom without module installed. Using rom's native root only takes 8sec. That's why i uninstall Magisk. Is this normal or something wrong?
[Magisk] jenslody:
Does it happen always, also if you boot, wait some time and reboot ?

In this case a logcat from boot would be useful.

And you forgot to mention your Magisk version.
[Magisk] demonoidmaster:
don't unzip and rezip it, just open the zip in winrar and delete the magisk.zip, winrar will take care of the rest
[Magisk] GryphonBR:
I've been trying to figure out how an app I use (Pay With Rewards, from the Play Store) is able to detect root, despite my using MagiskHide and no other apps detecting Magisk is installed on my stock Pixel 3. Any help? I tried getting an strace, but there wasn't much to go on since the output was only showing part of the log, and logcat doesn't show much information other than the process being started and eventually terminated.
[Magisk] guest4711:
It looks like TWRP does not find your /data partition or does not support the file system type used. Please ask in your device's forum for a proper TWRP version.

AFAIK booting to stock system will restore your recovery (on Samsung devices)...
[Magisk] AlienTeck:
Found an interesting problem with a banking app.. It checks the directory made by magiksk manager to see if the phones rooted or not and wont load. The phone was not rooted but it kept saying it was was and exited right away. Its a banking app and have access to your accounts and all that but this is rather pointless. The directory was there from before but had trouble with OTA updates so got rid of root and TWRP etc and it was just the latest stock OS 8.1.. Deleting the directory got past the check.
[Magisk] spawnlives:
Don't know f this help's but these are the steps I took to install twrp and magisk on my s8 ( same steps for s7)

1. Back apps and data

2. Unlock bootloader

3. Flash twrp with Odin - use latest version of twrp

4. Boot straight into twrp and FORMAT data.

5. When finished the format using twrp menu reboot back into twrp

At this stage if you reboot back into system it will re-encrypt your phone.

6. Flash no verity opt encrypt zip - this will prevent phone from re encrypting when booting into system.

https://build.nethunter.com/android-tools/no-verity-opt-encrypt/

7. Flash magisk

8. Reboot into system

This should fix any issues with twrp in regards to encryption.

If you are still having data mount issues after this then as [MENTION=8010004]guest4711[/MENTION] has said it will be more than likely your partition format and/or now since your on Oreo quota management. I don't know the latest development for twrp for the s7 but hopefully the latest version has these issues fixed if not check your device forum and see if they have a modified version.

Note: When I flashed the no verity zip I did in twrp swipe to allow modifications not sure if it's required though. I'm pretty sure all it does is mount the system partition which you can disable/enable in the mount menu of twrp.
[Magisk] GryphonBR:
Pokemon Go was doing something similar not long ago, which is one of the reasons topjohnwu removed the directory some time around Magisk 17 was released
[Magisk] Strephon Alkhalikoi:
Samsung devices don't support Fastboot, thus temp booting TWRP is not possible. Odin only installs files, so he would need to flash TWRP using Odin, and then go from there. What he should do, if he hasn't already done it, is download a copy of his stock ROM from Sammobile, so in case of trouble he has sonething to go back to.
[Magisk] kiiiiiid:
I think I've done all of them. I have double checked them to make sure. But the app closes immediately and says "MobileBank keeps stopping"
[Magisk] Chouiyekh:
hello guys,

i have a problem with fingerprint sign in like paypal app and another app "CIH Mobile" is for a local bank in my country and i can't sign in using my fingerprint although if i enabled from the app and the mobile, i think this is because of magisk if i unrooted my mobile it works fine, but i hope if there a way to keep the fingerprint sign in working and keeping the magisk.

thank you
[Magisk] Horgyboy:
I have the Samsung s6 Frankenstein Rom and it works well... My magisk is all good too, but my bank id mobile don't work. Not even when i try to hide it in magisk... Used to work fine on my Samsung stock rom...

Tested different versions of magisk too..

What steps should i use to make it work?
[Magisk] swieder711:
Amazing work. Rooted on my Pixel 3 XL

Donation sent.
[Magisk] guest4711:
Have a look at [MENTION=4667597]Didgeridoohan[/MENTION]'s fine FAQ:

https://www.didgeridoohan.com/magisk/MagiskHide#hn_Hiding_root_from_apps
[Magisk] angelillom:
Please I need help, I have a Huawei P20 lite with Magisk and TWWR and I want to update the OTA, my question is someone who would do it if you could help me in the sense of being able to watch a video of how to do it or a not very complicated way since every time I wonder they send me to an address and I do not understand English because I use a Google translator

The case is whether it can be done without damaging the system

First of all THANK YOU and I hope the help to not spoil the Mobile
[Magisk] AlienTeck:
You should probably mention just what all steps you have already tried rather than just a vague statement if you want others to help. Someone might spot a step you had not tried and offer suggestions.
[Magisk] kiwigi:
Thanks@spawnlives

I'm away from my home and have to wait till I get back. In the meantime I am wondering if there is an option to initiate a nandroid backup before or when TWRP is flashed. It would make easier to continue if something fails.

Till now I have not used "no verity" and I suspect this has been part of my problems.

I had to get unrooted stock installed before going away and that is what I am using right now to write this.
[Magisk] Nimueh:
I'm getting a Galaxy Tab A 10.1 SM-T585 LTE (2016) today and was wondering if anybody here knows if I can root it with Magisk and how?

The threads in the device forum mostly say to use CF Root ... some users have said they used Magisk but they didn't say how.

Can I simply install the Magisk app and do a direct in-app install? Or do I have to extract, patch + flash the boot image like I had to do for my View 10?

Any help would be appreciated, thank you :) :good:
[Magisk] martyfender:
My guess is that unless the device has a custom recovery you will have to patch a boot.img, extracted from a rom download. You can't do a direct install unless it is already rooted.
[Magisk] Nimueh:
The device has TWRP available, but since it's older most guides simply pre-date Magisk lol.

It comes with Android 6.0 but has 7 available and even some Oreo roms.

So if I root it with CF Root then I can install Magisk? Excuse my ignorance, but I haven't had a Samsung device in years. I vaguely remember Odin, but that's about it :angel: :laugh:
[Magisk] Didgeridoohan:
You need Magisk root to use the direct install... Patch the boot image or flash the Magisk zip in TWRP.

---------- Post added at 09:10 ---------- Previous post was at 09:08 ----------

Then you're either doing something wrong or you've got something else going on...

(Canary thread is, for now, the wrong place for this conversation, so I moved it here instead.)
[Magisk] Nimueh:
Flashing it in TWRP sounds easier, I'll give that a try ... beats trying to locate the boot image I think :angel:

Thanks :)
[Magisk] martyfender:
Flash the available twrp for the device then Magisk.zip. I don't have a Samsung device either, but that may work. There are no guarantees. That is how I first did it on my Android 6.0.1 device. I think, at least with Samsung devices, you have stock rom downloads. For my devices the manufacturer never released them, so I have to depend on a stock TWRP backup, to restore my device in the event of problems.
[Magisk] Nimueh:
Yea I've been doing some reading in the device forum already but without having the exact model number I didn't get very far ... plus I only just decided + ordered it on Tuesday lol. But yea, flashing TWRP + then Magisk seems the easiest approach :cool:

I appreciate all the replies, thanks folks :) :good:
[Magisk] spawnlives:
My first backup was done after flashing the no verity zip then rebooting back into twrp( or system then twrp) and doing a full backup then before flashing anything else just use the backup menu in twrp. This can be your base line if something goes wrong.
[Magisk] oroboros74:
A little feature request [MENTION=4470081]topjohnwu[/MENTION] for Magisk:

- Add setting to for default open view: Downloads/Modules/Main

(I personally like to go directly to see new downloads, so it would save me a couple presses!)
[Magisk] Blooddrunked:
Hello.

My root dissapear every day... Ive tried to deinstall busybox, ive Updated magisk to the newest beta, nothing changed... I must install magisk evry day new..

Device is pixel 2xl with nitrogen os.

Thank you!
[Magisk] bbc89:
My safety net check has been failing continuously from yesterday. I have tried re-installing 17.1 and also upgrading to 17.3, but nothing could fix this. Is anyone facing this. Please help. Banking apps are not working.
[Magisk] bbc89:
THIS
[Magisk] bohemist:
Mine is OK
[Magisk] martyfender:
This might help, go into Android settings, apps and delete cache and data for Magisk Manager. Now relaunch the app, go into setting and redo any settings you had before. Finally check Safety Net and it will once again ask you to re-download the proprietary code. If this solves your problem, let know. If this does not solve it, is it possible you did something that would have modified the system? also, do you still have Magisk Hide enabled? I think something has been changed on your device to cause this.

If this does not help try looking in this excellent help guide under Safety Net:

https://www.didgeridoohan.com/magisk/HomePage

Magisk Hide Props Config Module may also be of use to you.
[Magisk] kiwigi:
Thanks [MENTION=8893719]spawnlives[/MENTION]

Have you used a specific install instruction?

I have used the one on Magisk and I did not see anything about the no verity zip(and for that matter which/if any version).

I suspect the reason for my failure to have it working by now is that I haven't used the "no verity". If you could share a link to a working instruction would be great:)
[Magisk] martyfender:
Yes, I tried his link for the no verity zip and it will not open because of an invalid security certificate. The no verity zip would not be on a Magisk forum, it would be on one of your device forums. Didn't you state that you have some kind of Samsung device, it is hard to remember since there have been so many posts.

I have in the past, removed the dm_verity flag by unpacking my boot.img in Android Image Kitchen, then repacking it. I believe there are some extra hoops to jump through to do that on Samsung devices, though.

In fstab device name originally:

/dev/block/by-name/android_system /system ext4 ro wait,verify=/dev/block/by-name/android_metadata

Change to:

/dev/block/by-name/android_system /system ext4 ro wait,
[Magisk] spawnlives:
Sorry about the link I didn't check it before posting

This one is for the latest version 6 no verity zip which is the version I used.

https://androidfilehost.com/?fid=817906626617949632

As for install as previously mentioned

If you installed any apps that you want to keep back them up first or reinstall later.

1. Flash twrp (latest version) reboot straight into twrp

If it ask's to swipe to allow modifications - swipe to allow I did when I did mine.

2. Format data ( not wipe )

3. Reboot back into twrp ( using twrp reboot menu )

4. Flash no verity zip.

5. Reboot back into twrp ( or system then twrp which is what I did. )

At this stage I did a complete backup using twrp in the backup menu check all boxes. Also check data storage if it reads 0mb then the no verity zip did not work and may have to re-flash no verity zip again.

6. Flash magisk following the guide you were looking at.

Hopefully you should have a rooted phone now.

Also I would recommend to use a separate app (not twrp) to backup your efs partition separately as well and keep it on your PC and/or SD card. While I don't have a recommend app for this there are some on playstore.

As an example:

https://play.google.com/store/apps/details?id=com.ketan.efsn8pro

Edit : Have check the links this time all good
[Magisk] :
I have a strange problem. According to magisk (17.3) I pass safetynet but even with magisk hide, one banking app still can't be used. I'm on aex pie.

The problem is that other users claim that they can use that app on Android nougat (haven't tested myself). So whats the problem here and it's there a way to solve it?
[Magisk] spawnlives:
Have a read of this very useful guide it will help you out.

https://www.didgeridoohan.com/magisk/HomePage
[Magisk] areris:
:good:
[Magisk] :
This actually helped me and I can use the app now. Thanks :)

I just had to disable and re-enable magisk hide for that app. I was sure I tested this already but well, no need to research this further now that it works.
[Magisk] Ekagra69:
Does anyone know how this module works... I installed it this morning with my phones battery at 17 % and then by mistake i overcharged it for like 5 hrs, the supply didn't seem to cut off. Do i need any app to make this module work ??

Using lineage OS 15.1 (mido)
[Magisk] Nimueh:
You can't overcharge a modern phone battery. It will charge until it's full and then simply trickle charge to prevent the phone from discharging. Pretty sure you don't need any modules like that either but ok lol :rolleyes:
[Magisk] Didgeridoohan:
If you check the module readme (click the module description in the Manager Downloads) you'll likely find a link to a support thread. Try asking for help there...
[Magisk] chooks06:
Have not used this before but from the notes user has to set up the parameters on first run.

From my understanding, the app controls when the battery is allowed to charge and when it should be stopped, based on user's settings.

The two auto settings provide options to auto cut-off OR power down, when preset charge level is reached, if I did not read wrongly.

The setup should have been done before charging. 17% would be more than enough to set up, I guess.

I had planned to install this module but have not as I was beta testing other apps.
[Magisk] Nonny_SA:
Hello,

i hope i am right here and i can ask my question in the correckt place :) ,

I have a Samsung galaxy Tab S3 (SM-T825 / DBT) on the Latest Firmware (T825XXUBRJ1 - Sec.Patch level - Oktober/ 1 / 2018)

I have installed from 0 - 3 times 2 times with Magisk 17.1 and now also Magisk 17.3 and i have trouble to get the OTG Funktion to work,

Symtomes are : USB Adapert conected and Disconected in an endless loop with flash drive attached and without , before rooting it was working fine , after root it dosent is it possible to take a look at this or is there maybe a patch for this ? Please fix this , because on my Galaxy note 8 SM-950F all is working perfectly inclusive the OTG function, i belive that must be something little to fix this but i didnt found a solution till now.

Please take a look at this and keep up the great work ! :)

Greetings !

Nonny
[Magisk] xsensei:
Hi..

Magisk can't hide root for some app. Can you check? Com.publicbank.pbbvocc.
[Magisk] mordantly:
I am on a deodexed CPK1 on my G900P.. 17.1 and manager 6.. no issues. If I can dl that rom, I will flash it and see what I get. Will advise.
[Magisk] Hippie459MN:
That would be great! Im at a loss here and really really new to this Magisk stuff and its making my head spin. lol
[Magisk] mordantly:
Chewing on the 1.2GB file now.
[Magisk] martyfender:
First off, this has been mentioned before, but rom authors should not include Magisk in their rom. It is just asking for trouble in the future. v14 is a very, very, old version of Magisk, so most newer module will not work with it.

I would suggest using one that does not include Magisk. Also, Safety Net will never pass with xposed installed, period.

Here is a superb guide about using Magisk. The minimum version I would suggest would be either the v17.3 beta, or the latest Canary build, as they both have the Samsung Defex patches in them.

I am not 100% certain, but you may be able to use the latest Magisk Uninstaller to remove v14 from your rom, then flash the newer version of Magisk in TWRP.

Usually the best way to install Magisk is through a custom recovery such as the latest TWRP for your device. UPDATE: I see in your signature you apparently have TWRP on your device.

https://www.didgeridoohan.com/magisk/HomePage