yashsingh1/xdaforums huggingface dataset:
[Magisk] Deadlights:
Yeah at that point I'd probably start just using root again. When I stopped doing it was around 16.0 and twrp was still shaky and every month when the security update came down it was a nervous run to see if it would brick after the update and rerunning magisk.
[Magisk] tonisidneimc:
I'm having some issues with magisk 17.0 and 18.0, because it resets some system settings after each reboot process, such as debugging usb and system language, which is redefined as Spanish from Mexico, when the correct language is Portuguese, because I am from Brazil. When I correctly reconfigure the language into Portuguese, the wrong language reappears after a new reboot process.
[Magisk] guest4711:
Probably some modules change these properties. Enable "core only mode" and see if this helps. If yes, disable this settings again. Disable all modules. Enable the firsy one and reboot. If everything is right enable the next one and reboot (and so on).

This way you should find the culprit.

If not, you should give us a list of your modules installed and proper logs so someone can try to analyze your issue.
[Magisk] monster1612:
I was just wondering what ACK (from the 17.3 changelog) meant and what it does. Feel free to point me towards a different thread if this question doesn't fit. :)
[Magisk] tonisidneimc:
This started after I installed the magisk via TWRP, and as soon as the phone started it came with the changed language, with no module installed yet.
[Magisk] tomatopotato1229:
Hello All,

I'm having a problem with my device writing tons of log data with error messages and filling up internal storage. I tried looking at the log files themselves, but I'm not quite sure what to make of them.

A bit of background information:

I recently decided to switch to stock rom + Magisk root instead of custom + SuperSU. I also wanted to try MicroG and cut out Big G as much as possible. Everything went smoothly for the most part. MicroG settings checklist is all green. Apps working properly, including push message ones. Calendar, contacts, and stuff are syncing correctly without Google. OSM is working fine as a replacement to GMaps.

But...

My device is mysteriously writing about 2-3gb of log data each day (yes, gigabytes). This fills up internal storage to the point where I need to restore a backup from recovery (TWRP) every few days. Here's where I downloaded a log checker to try and find out which app was being naughty:

[IMG="log data"]https://i.postimg.cc/j2jXwFHd/Screenshot-2019-01-02-14-55-55.png[/IMG]

[IMG="log data (expanded)"]https://i.postimg.cc/h4CMWKnJ/Screenshot-2019-01-02-15-28-58.png[/IMG]

Magisk pops up quite often, and I assumed the problem was a rooted app acting up via Magisk rather than Magisk itself. I also saw "pid=3732", but when I looked for a corresponding process ID in OS Monitor, there wasn't one. I searched the net for the error types that kept popping up (1300, 1306, 1320, 1327, 1400), but nothing relevant came up. So, I'm a bit baffled on what to look for next or how to interpret the rest of the log data.

For reference, here is my device/status/info:

Model: N915D Samsung Galaxy Note Edge (Japan/SCL24)

OS: Marshmallow 6.0.1 (TWRP 3.2.3-0 via Odin flash)

Root: Yes (Magisk 18.0 via TWRP install)

GApps: MicroG (via Nanodroid Magisk Module/TWRP install)

Xposed: Installed via TWRP for MicroG/FakeGapps module

SafetyCheck: Fails of course, because I'm using Xposed, but I don't mind since I'm not using apps that care about SafetyCheck

I've tried the following:

Disabled/debloated almost all non-essential services/apps (via OpenAPK)

Tried both v 2.0 and v 1.1 of the FakeGApps Xposed module

Tried disabling various Xposed and Magisk modules that I was planning to use (Greenify, XTouchWiz, etc.)

Deleted most non-system apps (AFWall, Nextcloud, browsers, VLC, etc.) to try and isolate the problem (i kept Magisk, Xposed, and some diagnostic tools)

Did a fresh re-install of the stock rom (via Odin), TWRP (via Odin), Magisk 18.0 (via TWRP), no Xposed, and only 2 apps (F-Droid via adb and a log reader, Matlog, downloaded from F-Droid)

None of the above were able to stop the error messages and ballooning log files. Finally, I tried downgrading from 18.0 to 17.3 and somehow the error messages stopped. But now the log files are filled with mostly this instead:

[IMG="log data after downgrading to 17.3"]https://i.postimg.cc/JzsjF191/Screenshot-2019-01-03-11-13-57.png[/IMG]

Is this normal? If not, any ideas on what I should try next?

Thank you very much for reading and for any help you can provide!
[Magisk] jcmm11:
First question. Where in internal storage are the log files being written to? The logs you displayed are a rotating FIFO buffer in memory, when the buffer fills up the new messages start to overwrite the old ones.

Also - you shouldn't need to restore a backup. If the culprit is log files simply delete the log files to free up the space.

As far as tracking things down goes the first thing I'd try is stock + Magisk, without MicroG, Exposed etc (use regular gapps). If that doesn't have a problem next install Xposed (since it sounds like you need it for MicroG) then start installing modules one by one.

Painstaking and time consuming but you should eventually figure out what's causing the issue

You can also try a Canary debug build of Magisk, that will give more information in the Magisk logs (which you should also look at).
[Magisk] winamp26:
Hi all

Anybody root s7 edge Oreo(xxu3erl3) via magisk v18.0?

I have issue with v18.0, no root in magisk manager but v17.3 works fine
[Magisk] martyfender:
Have you tried flashing the Magisk uninstaller, flashing a fresh, stock boot.img then v18?

For some, flashing v18 a second time and deleting the cache and dalvik cache, has helped, for some unknown reason.
[Magisk] winamp26:
Yes but v17.3 is work.
[Magisk] martyfender:
Yes, I have been seeing the same post quite frequently, that v17.3 works, but updating to v18 does not work.

I think more people with this problem need to post logs for any chance of this problem being fixed. I am seeing, post, after post, after post, with no logs provided, as if no one reads even the last few pages of this thread.

Also, the Canary debug build will provide much better logs:

https://xdaforums.com/apps/magisk/dev-magisk-canary-channel-bleeding-edge-t3839337

Set this url in the Magisk Manager setting, update channel, custom:

https://bit.ly/2MPKGY5,then go back to the main MM page and swipe down to refresh. Then download and install the Canary build.

How to provide logs and relevant device info:

https://www.didgeridoohan.com/magisk/MagiskHelp
[Magisk] jedi134:
Sorry no logs but just to confirm ver 18 stopped root on my s4 running 5.01. Every app hangs that uses root...seems like app wants root. And just hangs waiting for in to be granted. . No popup no nothing...I've gone back to normal chain fire root for now.... will try previous ver when I find link to it.

Edit: just read a previous post regarding dalvic cache..I have an app called system app mover. And now when I want to do anything through it.it keeps saying "searching for dalvic cache" this is on chain fire su.....Has my dalvic been hidden/or moved somehow with ver 18?

Edit2: 17.3 now don't work same problem apps hang at aquiring root stage....ver 18 has fooked Somert up. .
[Magisk] soder:
Hi. I'm on v18 on my new OP6T and I'm about to do all the config. I'm a long time user of Magisk, but not so much lately.

I wonder where on the phone I know find the "magisk" folder, with all the files from the different modules? I used to add files to modules I already got installed, if I just want a file added to the /system.

Right now I want to add the Pixel Launcher (the stock version) and I don't know if the Pix3lify module will work for me, or if the Pixel Launcher even is included.

Thanks.

/Söder
[Magisk] guest4711:
/sbin/.magisk/img
[Magisk] soder:
Thanks. You might also know what the correct folder name and apk name should be for the Pixel Launcher placed in /system/app ?

EDIT: Is it NexusLauncherPrebuilt for both folder and apk?

/Söder
[Magisk] anotherxdauser:
Here's a query.

I bank with Lloyd's Bank but their app has had a recent update that seems to detect Magisk Hide is hiding root.

It always worked before but not now.

Any ideas on what I can do?
[Magisk] martyfender:
https://www.didgeridoohan.com/magisk/MagiskHide
[Magisk] guest4711:
This sounds good. AFAIK (as far as I know) the name of the apk does not metter. "base.apk" would be sufficient.
[Magisk] jcmm11:
[MENTION=2438781]soder[/MENTION]

Folder name also doesn't matter, although the name given is the one Google uses in the Pixel and Nexus devices. However it was always found in priv-app, not app

/system/priv-app/NexusLauncherPrebuilt
[Magisk] Depressed Man:
Hmm, I seem to have lost root access again. Magisk is installed but getting the 'su binary is out of date' message Trying the revert to stock, reinstall Magisk, reinstall su doesn't seem to work this time. But at least I pulled the Magisk.log. any ideas? I've tried flashing the v17 su again and TWRP reports it installed correctly.

Logs are attached. Running stock ROM, latest build (MMBR30R) Nexus 6.

Edit: ....And I got it working again. I wish I knew what I was doing right or wrong.. I think it has to do with having the superuser (the manager not the su binary itself) installed somewhere in between reboots.
[Magisk] westeight:
Just updated Pokemon Go... still works fine.
[Magisk] SidneyD:
Sorry for the dumb question, but how do I tell if when I unroot via SuperSU and tell it to attempt to restore my boot image that it actually did so?
[Magisk] cthulhu1987:
I have no idea why, unmounting root apparently stopped fooling SafetyNet (at least in my case), Pokemon GO won't log in anymore and according to the SafetyNet helper app, the "response payload validation failed". What can I do (my device: SM-G900F, Stock Android 6.0.1, CSC

EDIT: I found this Reddit thread and deactivating Xposed did help... For now.
[Magisk] SidneyD:
Sounds like you did not flash phh-superuser-17-magisk.zip while you were in recovery. Phh's SuperUser (the app you get from Play) doesn't work without it.
[Magisk] Ranomez:
[MENTION=4470081]topjohnwu[/MENTION] 2 days ago I came here to ask if magisk could be made not to force SELinux on Enforcing and people just told me to use an other program to switch it to Permissive on boot however I come to report that is actually a big problem for some devices not only because some devices have things broken with SELinux set on Enforcing but there are also devices that CAN'T EVEN BOOT with SELinux set on Enforcing, Xiaomi Redmi Note 2 on 6.0 being the current example and also the HTC One X+ and HTC Desire HD have had that problem more than once on custom ROMs (IIRC the solution for the Desire HD was actually to disable SELinux at kernel compile) and so would like to request that a check was added before switching the SELinux mode to Enforcing and keeping it the way it was set by default.
[Magisk] 14eduardo144:
Deleted
[Magisk] Captain_Throwback:
Magisk does not change the SELinux mode. I'm not sure why people think it does. All it does is allow you to toggle it.
[Magisk] Ranomez:
There is something strange then since on my Redmi Note 2 I flashed Magisk on both CM12.1 which has it set on Permissive by default (cause otherwise the camera does not work right) and now it boots with it set on Enforcing, furthermore I also flashed it on android 6.0 for the same device (which again has it Permissive by default) and got in a bootloop but could connect to adb so I run "getenforce" and the response I got was "Enforcing".
[Magisk] Benconquerer:
Hey Guys,

Really struggling here, never really used magisk and I am going up and down the thread but i can't seem to figure it out.

I have installed everything, everything is working fine, i have android pay and i can switch to root mode easily. No problem on that end.

I have an issue with adding Tethering.

I have a nexus 6P running Nougat. I know that adding the line to the end of the build.prop in System\buildprop net.tethering.noprovision=true works because i have done it while having system root.

I am however having issues creating a mod to add this line so that i can still be able to use it and android pay.

So far i have the following:

Magisk\Tethering

>auto_mount

>module.prop

>>Name=tethering

>>version=V1

>>setprop Net.tethering.noprosvisioning true

>post-fs-data.sh

>>#!/system/bin/sh

>>this script will be executed in post-fs-data to add tether

>>setprop Net.tethering.noprosvisioning true

>service.sh

>>#!/system/bin/sh

>>this script will be executed in late_start service mode

>>setprop Net.tethering.noprosvisioning true

I do not know what i am missing. that is all i have and i am completely lost.

Thanks in advance!
[Magisk] putridfoetus:
Not sure if typo only here, but you misspelled noprovisioning. Also, make sure ”net” is lowercase. Android is case-sensitive. Thirdly, you should only need the post-fs-data script. No need for service.sh as well.
[Magisk] Benconquerer:
Sorry it was only here.
[Magisk] Devilix:
Guys... There is something strange... i have used magisk for some days, everythings forks fine till now...

The app "SafetyNet Helper" give me a grey screen! And not only on one device, i have try with another one, and its the same! (weird!)

Tryed also with different connection, LTE and WiFi... always get same error... :(

I only hope this is a temporary issue... :(

If someone has other infos...please, talk!!! :D
[Magisk] putridfoetus:
post-fs-data.sh should look like this. All lowercase. No need for service.sh.
[Magisk] JudgeDread11:
That's is not a dumb question. I don't know either. I assume it would give an error message somewhere in a log of it didn't.

If in doubt you can always flash back the original manually in twrp before flashing magisk.
[Magisk] 4min3:
Do you have Xposed?

If you have ,u need to disable it
[Magisk] Zythyr:
For those of you that are having issues with toggling OFF (unmounting) root... I was having the same issue before and found a fix.

One possible reason why you're unable to toggle OFF the root was because prior to installing Magisk, you didn't properly uninstalling all root. Based on what I learned from @FSadino, all CM custom ROMs are "pre-rooted" by default; but it is disabled. Thus even if you do NOT flash SuperSU when you're flashing the ROM, CM has the ROM "pre-rooted". For Magisk to work properly, you need to remove the "pre-root".

There are two methods that worked for me:

Method 1:

1) Go to TWRP and mount System partition

2) Navigate to File Manager

3) Change the names of /system/xbin/su and /system/bin/su into something (su_).

4) Now your "pre-root" from CM will be gone

Credit for this method goes to: https://forum.cyanogenmod.org/topic...rk-with-cm-130/?do=findComment&comment=609999

Method 2:

1) Flash your custom ROM as always from TWRP

2) Flash SuperSU in TWRP

3) Once bottled into Android go to SuperSU's settings page and do a "Full unroot"

4) Now both "pre-root" and SuperSU root will be removed.

Once you remove the "pre-root" from CM, you can follow the regular instructions to install Magisk + systemless root. This will allow you to properly toggle OFF the root...
[Magisk] exodius48:
Does magisk stopped working? I already disable root from magisk manager, then play pokemon go, but it stuck on loading screen, then give me a message "can't authenticate..blablabla"

---------- Post added at 12:18 PM ---------- Previous post was at 12:17 PM ----------

How about delete it instead of rename?
[Magisk] Hurrdurrdurrdurr:
if you have Xposed then disable it because the recent SafetyNet update detects Xposed and prevents you from logging in Pokemon Go
[Magisk] exodius48:
If i disable xposed, i can't play pokemon go because of gps spoofer module need xposed. Is there any other way?
[Magisk] soder:
Thanks. It worked in app to. And, it wasn't that I didn't had it as a system app as it was for a couple years ago, but the latest version that didn't work on other phones then the Pixel.

/Söder
[Magisk] Asumos:
I'm using pixel 3 xl unlocked bootloader no root and Google pay is working just fine. No hide needed
[Magisk] kryshnakishore:
Safety net fails randomly & I have to toggle magisk hide button when it fails.

Flashed safety net zip but still the same issue.

Cleared playstore & playservices cache too

Any fix for this?

OnePlus 6 stock os 9.03 with custom kernal
[Magisk] ktmom:
Reported often, but few logs provided. It would be appreciated if someone who has this problem contributes logs to assist n finding the fix.

"find somebody that you think is undeserving of your compassion and give it to them" - Christian Picciolini
[Magisk] kryshnakishore:
I dnt know whether you are referring to this. Pls let me know if you need anything further
[Magisk] kryshnakishore:
Another log where safety net works
[Magisk] martyfender:
I understand hiding your banking apps, but why are you hiding Google apps and related services?
[Magisk] kryshnakishore:
Without hiding those Google pay is not working. I installed tez hider module where Google services & telephone gets hided
[Magisk] volkbaad:
Many thanks for your great work, guys; I rooted my z1c amami running aicp 13.1/twrp w/o any prob. But unfortunately, the bravia engine offered in the d/l section kills every camera app on my device; only black screens therein after installing it. No chance then for me; or does s/o have a clue for a solution?
[Magisk] jedi134:
Logs from magisk it's self..lots of mentions of broken pipes and su denied....

https://mega.nz/#!tQZACYSJ!bFgdZhNf...39->0)
[Magisk] kryshnakishore:
Intially safety net passed, after 3hrs Safety net failed & I toggled magisk hide & safety net passed. Here's the complete log pls do check
[Magisk] tomatopotato1229:
Thank you. I managed to find them in:

(root) data/adb/logcat/

You're right. I don't know why I didn't think to do this instead earlier, hahah. Thanks again.

This was the last thing I did prior to just trying to downgrade Magisk, which fixed it I think? After cross-checking the process ID, I found that the rows of TextView log entries were actually being generated by Matlog Libre itself. The remaining entries were far fewer and being generated at a much more reasonable pace, as opposed to the hundreds/sec that were being spewed out before.

CPU activity has also settled to something far more ideal level. Before, at "idle", I had 2 out of 4 cores with medium to heavy load. Now I usually have 1 core at light-medium load and the rest truly idle. So I believe downgrading to 17.3 did the trick.

Anyway, thank you again for your attention and advice!
[Magisk] jedi134:
I've never changed kernal s I'm on stock Samsung kernal. ..same kernal I've always been using since the beginning of magisk versions..ver 18 has done something strange to my rom.
[Magisk] ktmom:
This is the point I was trying to make a few days ago if you're having problems on the GT-I9505 device in your signature.

The S4 was released in 2013. Magisk 18 is addressing challenges for modern A/B slot devices running Pie. One requirement is a 3.8 or higher kernel. Has somebody backported one for your device? You can identify your kernel version usually in Settings -> About phone or in a terminal with the command: uname -a. To compare, my device is an 4.4+ kernel right now.

Why not just stick with the last release that works for you?

"find somebody that you think is undeserving of your compassion and give it to them" - Christian Picciolini
[Magisk] jedi134:
Thats the problem i cant go back, something fooked up my rom with 18...Since the ver 18 update no previous version works..all have lost root. I was on the ver before the 18 releases. Is it 17.3 and all eas good, but now this has the same problem..no root..I've used the u_install zip. Clean davlik etc. Still previous version no working. Chain fire su works...
[Magisk] martyfender:
You may need to start fresh with a clean rom install, if you still really want to use older versions of Magisk that worked, or stick with SuperSU.

Also a clean flash of just your stock boot.img may allow you to use Magisk again?
[Magisk] onliner:
Hi, I think I need some help with some stupid problem.

I'm trying to use post-fs-data to edit an xml file in data, but my log says this:

xml exists
patching...
error
/sbin/.magisk/img/PatcherTest/post-fs-data.sh[71]: grep: not found

And:

error
/sbin/.magisk/img/PatcherTest/post-fs-data.sh[90] sed: not found

What is the problem with these commands? If I run the script from a terminal, it works perfectly.

Should I include something else in the module? :confused:
[Magisk] paarnoutse:
Logs for this Magisk v18 problem are available in GitHub, created - as always requested by TopJohnWu - while using the Magisk v18.1 Canary Debug version.

See https://github.com/topjohnwu/Magisk/issues/900
[Magisk] guest4711:
Either the path of these commands (probably implemented in busybox) is not in your search path when you call them. Then you should call them using the full path, e. g. /sbin/grep instead of grep. Or the module which implements them is not loaded when you call them. So you should implement a wait loop then (something like

counter:= 0;
while counter < 30 and file_not_executable(”/sbin/grep") do
begin
counter := 1 + counter ;
sleep (1000);
end;
[Magisk] bruno$0:
I upgrade magisk from 17.3 to 18.0. after first boot magisk shows installed and ctsprofile false. After a reboot , magisk says that isnt installed. I already tried with canary channel version. I flashed b

Stock boot.img and flash zip and get same error.

Sony xz , omni rom 8.1.
[Magisk] cassinni:
Hi,

my phone is dead since I updated successfully to Magisk v18.0.

I got a Xiaomi Mi Max 2 (Unlocked) and run xiaomi.eu_multi_MIMAX2_V10.1.1.0.NDDCNFI_v10-7.1.zip on it.

I was on my phone and started Magisk Manager and it asked to update twice, which I did the way it recommends it.

The second update was the v18.0 version, after that it asked me to reboot, which I did and I only see the Xiaomi boot logo for a few seconds

and then the screen goes black and the phone is off. I got 90% battery. I also am able to get into twrp.

I tried to install Magisk-uninstaller-20181208.zip from internal storage thru twrp but I get error

"Updater process ended with ERROR: 1

Error installing zip file '/sdcard/magisk-uninstaller-20181208.zip'

I get the same error when i try to flash Magisk-v18.0.zip thru twrp.

Please help me, i am in panic
[Magisk] XavierBrian:
In this case ur backup kick in real good (if u doesn't had a backup mean u didn't pay attention to op)or u can always wipe everything n reflash rom,if magisk uninstall give u error 1 mostly is ur data encrypted,only way is wipe data,
[Magisk] ktmom:
I would dirty flash the ROM. Or just the boot.img from the ROM, but a dirty flash is often easier.

"find somebody that you think is undeserving of your compassion and give it to them" - Christian Picciolini
[Magisk] cassinni:
i tried magisk uninstall as i wrote but it gives an error

---------- Post added at 12:53 AM ---------- Previous post was at 12:52 AM ----------

how to dirty flash? will I lose all my data on phone?
[Magisk] guest4711:
Flashing dirty means not wiping your data. So you will not lose them.

You need your rom.zip to install it from twrp. Then reboot.
[Magisk] cassinni:
hvala
[Magisk] martyfender:
Yes, is never seems to amaze me that people who never back up their data. When we suggest a clean install of their rom, they are afraid of loosing data. But often, that is the only way to get at clean start for Magisk to work as it should. And yes as was mentioned, you can often save your data by dirty flashing rom or just by flashing your stock boot.img.
[Magisk] ToXiTe:
Deleted
[Magisk] XavierBrian:
Most annoying they refuse to clean flash chose dirty flash end up something funny with system and start asking funny question that nobody had the mojo to answer anymore and he start blaming developer :silly:
[Magisk] RandomPooka:
It's a given that you're allowed to tell people who dirty flashed that they can stick it where the sun don't shine, though. If you don't follow directions, no help for you.