yashsingh1/xdaforums huggingface dataset:
[Magisk] prittjr:
Pixel won't take OTA - what do I do now

I have a Pixel XL running Magisk, but it just failed to take the Feb OTA. I assume I must have accidentally allowed a root app to mount the system folder. What are my options now? Here are some potential ones I could imagine:

Somehow restore the system to stock state without wiping data or losing Magisk/Root (flashing the system only??) How would I do this?

Can I manually flash the OTA without wiping data or losing Magisk/Root (I'd be okay manually flashing each month)? How would I do this?

Flash full factory images without wiping data or losing Magisk/Root...how would I do this?

Mainly I don't want to have to go through the process of installing Magisk again, and I DEFINITELY don't want to deal with wiping my data. Am I screwed?

Thanks in advance
[Magisk] siealex:
Flash the factory image without wiping (it would be better to find a twrp zip), then flash twrp and immediately flash Magisk again.
[Magisk] DeWil000903:
Bug? Oreo 8.1 not saving root decisions

Everytime I get asked by MagiskSU if I want to grant SU Permissions, (having 'permanent' selected), my decision for that does not get saved. Every time it needs root privileges, it keeps asking again. This happens for every App I'm using and it makes Background-Tasks like Tasker and Greenify impossible to work. In Magisk Manager, under SuperUser section, there's nothing listed. Also the Superuser log is empty. This seems to be a Bug for 8.1 Oreo AOSP roms, at least for what I tried.

It occurs for me using an Oneplus 3 device on both AOSiP and AOSP Extended Roms (both 8.1) and I did a complete clean flash every time.

Any suggestions for me? Or may this be a bug you can fix in the near future?
[Magisk] Didgeridoohan:
Boot to TWRP and use the file manager to navigate to /data/adb. Delete the magisk.img you'll find there and then flash your patched boot image again. All your modules will be gone, but you should be able to boot again.

Either flash all the parts of the full factory image separately with fastboot, or edit the installation script (the .bat file) and remove the -w option. This will update everything and keep your data intact. You'll find more details on how to do this in your device's forum.

You will need to install Magisk again, because the update will flash a new boot image that needs to be patched for Magisk to work.

Known issue with some 8.1 ROMs and /data formatted as f2fs. For the moment, the only solution would be to change /data to ext4.
[Magisk] DeWil000903:
Okay thank you, I'll change it back. I thought it would be ext4 because I changed it some time but I obviously was wrong. (Just looked after it)
[Magisk] Didgeridoohan:
Edit: never mind...

In that case you've got some other issue and you'll need to provide proper logs to show what it could be.

There's been some stuff added on GitHub recently that might fix issues like this. While waiting for any official release (beta, most likely), you could build yourself or use one of the unofficial snapshots provided by [MENTION=3306843]kantjer[/MENTION].

Remember though that they're snapshots of the current code and might not be useful. Also a good idea to do a clean install.
[Magisk] TENN3R:
Take a look at this post, it's pretty simple. Since magisk modules after update are still there, just reflashing magisk zip will automatically re-enable them all without have to reinstall them manually.
[Magisk] fiverings:
Use the flash-all file, remove the -w from the factory file you should have downloaded. Open cmd, type fastboot devices, if it returns you serial number your good to go. Then type fastboot reboot bootloader. Then double click the flash-all file, a new cmd will pop up and the flash-all will start. It will stop for a few minutes and the start again, let it run until it's finished.

Then it will boot up and after that's done, turn phone off and hold down keys to open bootloader. Open cmd, and run fastboot boot (whatever you named twrp) twrp.img after twrp boots, flash twrp installer, then flash magisk.zip boot to system and your done.

Make sure you double check the flash-all file to make sure the -w was removed. Then go ahead installing the Feb update. Good Luck
[Magisk] Abomb:
Since there is no support yet for twrp unencryption for my device the /data/adb folder is encrypted so I only see two files in there with random filenames. Is there some way to determine which of those is the magisk.img, or is it safe to delete both?
[Magisk] Didgeridoohan:
Man... I'm so glad that I have a device that's relatively easy to mod... :p

On a normal Magisk install there should be only two files and one folder in /data/adb. The Magisk image, the Magisk database (su stuff) and the Magisk folder with scripts and binaries. You should be fine deleting both files, if it's possible.
[Magisk] johnyg07:
I am using the Nitrogen Oreo ROM from this thread. I am on 1/12 build. I did a clean install and restored the apps from google. I am also using universal safety net fix.

https://xdaforums.com/nexus-6/development/rom-nitrogen-os-n-substratum-11-10-2016-t3478365

I installed the beta of magisk. I tried to capture the logs after the reboot but the reboot is somewhat random and I am not able to stop the restart to go to recovery to capture the logs.

I have attached the logcat and magisk debug logs which I copied using solid explorer.

Please let me know if you need some more information or I need to do something more/else to help investigate this issue.
[Magisk] IBNobody:
I've updated Magisk Manager to 5.5.5, and everything seems to work except for adding modules. When I go to add a module (+ button), the app crashes. I have no other modules added and have a fairly fresh ROM. Am I missing something stupid?
[Magisk] Didgeridoohan:
Even more errors in there... Segfaults, etc...

I'd start by removing the SafetyNet fix. I've no idea if it's the cause of your issue, but you don't need it to pass SafetyNet and it might be doing more harm than good. To remove it completely you actually have to reflash Magisk after uninstalling it, since it alerts the internal workings of Magisk.

To pass SafetyNet, just grab the attached file, unzip, place it in /sbin/.core/img/.core/service.d and give it permission 755.

You're missing an important part of asking for help: providing logs.

Grab a logcat when the crash occurs.

You could also check and make sure that the Manager has storage permission.
[Magisk] tomkug:
Error installing MAGISK V15.3 on P10 Lite

Here is the log ( dropbox ) trying to install MAGISK V15.3

"www .dropbox .com /s/0ps43ni7x0dqz4j/recovery.15.3.log?dl=0"

please add h t t p s : / / and delete the spaces after .com

afterwards the log of the installation of MAGISK V14.0

"www .dropbox .com /s/aw1mr8p1bd9pg9l/recovery.14.0.log?dl=0"

please add h t t p s : / / and delete the spaces after .com

sorry, up to now I am not able to post outside - links :(
[Magisk] jacklul:
I've been trying running a script on boot from within "/magisk/.core/post-fs-data.d" but It don't seem to run, I gave it 0777 and even put debug echo message inside to check in the log but it doesn't seem to be run, magisk log doesn't indicate it was run. Same applies to .prop files placed in "/magisk/.core/props”, they are completely ignored!

Then script:

#!/system/bin/sh
echo 1 > /sys/module/msm_thermal/core_control/enabled

Help? I do not want to use a module for this.

Fixed by moving the script to "service.d" and using script with resetprop to set the props!
[Magisk] qwer222:
Hi, this is my first time to install magisk and before install, i try to patch boot image using magisk manager but it return error. My phone model is samsung note 3 SM-N9005 LTE, below is the log file.

- Device platform: arm

- Extracting files

- Use boot image: /data/data/com.topjohnwu.magisk/install/boot.img

- Mounting /system, /vendor

- Unpacking boot image

MagiskBoot v15.3(1531) (by topjohnwu) - Boot Image Modification Tool

Parsing boot image: [/data/data/com.topjohnwu.magisk/install/boot.img]

No boot image magic found!

! Unable to unpack boot image

Failed!

! Installation failed
[Magisk] Badger50:
Have you extracted the boot.img from your factory rom/image and placed it on your internal phone storage? I'm not up to speed on Sammy's, but that's typically how magisk patches the boot.img.
[Magisk] qwer222:
Do you mean the boot.img from firmware tar file or bootloader? Before this i did ask in note 3 forum and they point me to download bootloader. So I did download the bootloader from below post and try to patch it using magisk manager, inside the bootloader tar file contain 5 files. Or the correct file is boot.img which i can direct extract from the firmware file that i downloaded from sammobile website?

https://xdaforums.com/galaxy-note-3/general/bootloader-baseband-bl-cp-samsung-t3582504

this is my thread: https://xdaforums.com/galaxy-note-3/help/question-regarding-stock-boot-image-t3746140
[Magisk] Badger50:
Again, my Sammy skills left with the S5, but I would think that you'd still need the boot.img from the firmware since that is the kernel that needs patching to achieve root.
[Magisk] IBNobody:
I found that the issue was that on my new ROM, there wasn't a file system browser installed/registered for MM. MM was wanting to let me browse for a file, but I didn't have an app that could do it. After I installed ES File Explorer, MM worked fine.
[Magisk] ktl20:
I have Asus Zenfone ZE520KL. I updated OTA to android oreo and unlocked the bootloader with the asus application. I would like to install Magisk without TWRP instances. I downloaded fw oreo and downloaded the file boot.img but when I try to patch it in magisk manager I get this:

-Device platform: arm64

-Extracting files

-Use boot image: /data/user_de/0/com.topjohnwu.magisk/install/boot.img

-Signed boot image detected

sh: <stdin> [120]: / vendor / bin / sh: Permission denied

Failed!

Instalation failed

What to do with it?

I care about stock recovery to make it easier to install updates.
[Magisk] buggerman:
My issue was solved. I figured it out. I had installed Magisk Manager on sdcard. As soon as I moved it to Internal memory, it worked perfectly.
[Magisk] qwer222:
I just tried it, i think the boot.img is the correct file, not bootloader. Thx :)

---------- Post added at 06:37 PM ---------- Previous post was at 06:33 PM ----------

Hi, i just install 15.3 magisk via flash patched boot.img using odin to my note 3 SM-N9005 LTE, my phone running with latest stock rom and able to boot without any problem. But the magisk hide and hide magisk manager feature is not working.

For magisk hide, when i tick an app in hide settings, the entry wasn't saved. When i close magisk and open the hide setting again, the app wasn't enabled for hide, i can tick it again but it wasn' save. I did enable Core Only Mode in the Manager settings and then reboot too, but it still the same.

For hide magisk manager feature, after i tick this option, it will show running for little time and then manager will close by itself. When i try to open back the magisk manager, it just stuck at the screen which only show magisk icon with green color background. I had to force close it and then reinstall the magisk manager.

Below is the log file which i found in cache folder.

05-22 14:28:37.540 254 254 I Magisk : * Creating /sbin overlay

05-22 14:28:37.540 254 254 I Magisk : * Mounting mirrors

05-22 14:28:37.540 254 254 I Magisk : mount: /sbin/.core/mirror/system

05-22 14:28:37.540 254 254 I Magisk : link: /sbin/.core/mirror/vendor

05-22 14:28:37.540 254 254 E Magisk : mount /data/adb/magisk->/sbin/.core/mirror/bin failed with 2: No such file or directory

05-22 14:28:37.540 254 254 I Magisk : bind_mount: /sbin/.core/mirror/bin

05-22 14:28:37.540 254 254 I Magisk : * Setting up internal busybox

05-22 14:28:37.540 255 255 E Magisk : execvpe failed with 2: No such file or directory

05-22 14:28:37.540 255 255 I Magisk : Magisk v15.3(1531) daemon started

05-22 14:28:37.540 255 260 I Magisk : ** post-fs mode running

05-22 22:28:37.670 255 262 I Magisk : ** post-fs-data mode running

05-22 22:28:37.670 255 262 I Magisk : * Mounting /data/adb/magisk.img

05-22 22:28:37.770 255 262 I Magisk : * Running post-fs-data.d scripts

05-22 22:28:37.770 255 274 I Magisk : * Starting MagiskHide

05-22 22:28:37.770 255 274 I Magisk : hide_utils: Hiding sensitive props

05-22 22:28:37.770 255 274 I Magisk : hide_list: [com.google.android.gms.unstable]

05-22 22:28:37.790 255 274 E Magisk : proc_monitor: Your kernel doesn't support mount namespace :(

05-22 22:28:38.990 255 409 I Magisk : ** late_start service mode running

05-22 22:28:38.990 255 409 I Magisk : * Running service.d scripts

02-10 01:00:20.721 13222 13222 E Magisk : select failed with 2: No such file or directory

02-10 01:12:57.491 16437 16437 E Magisk : select failed with 2: No such file or directory
[Magisk] Didgeridoohan:
Your devices kernel is too old and doesn't support mount namespace. This means MagiskHide won't work on your device...

A custom kernel or a custom ROM might be able to fix this.

If you have further issues, check out the Magisk guide:

https://www.didgeridoohan.com/magisk
[Magisk] fiverings:
I am using a Pixel XL, Since installing the February 5 factory update using flash-all and removing the -w then installing TWRP 3.2.1-0 image and in twrp, flashing twrp installer.zip the installing Magisk 15.3 zip then boot to system, everything is working right, magisk manager 5.5.5 installed, rooted, pass saftey net and I am certified. I now have a few apps crashing.

One is Google+ another is Android Malwarebytes. And a few others mis-behaving.

Is anyone else have some problems since Feb update?
[Magisk] Didgeridoohan:
[MENTION=4140321]tyler19820201[/MENTION]

https://didgeridoohan.com/magisk/MagiskHideHidingRoot
[Magisk] Draizix:
Magisk hide problem

So I have been using magisk 15.3 on a Google Pixel XL here for awhile. I am finding an issue with magisk hide.

I play Fire Emblem Heroes which throws up errors when it sees root. I hid it in magisk hide as well as all Google apps like we normally would yet for some reason it still throws the error. I have tried literally hiding every single app besides TB and Adaway as well as doing the magisk manager repackage to a different name. Still the same thing.

Now here's the thing. I reflashed back to Decembers Factory image and reinstalled superSU(last image it worked on) and put suhide on it as well. I hid the Google store and play as well as fire emblem heroes. It works perfectly fine.

From what I noticed in suhide is that there is a Google app that it finds and hides that I do not see in magisk hide. It seems to separate the play store into two different apps where magisk version of hide is only doing the one. Is anyone else having this issue?

In suhide it is labeled as..

Google play services

Com.Google.android.gms

Google play store

Com.android.vending

And in magisk hide all we see is..

Google play store

Com.android.vending

The play services seem to be missing from being able to be hidden.

This annoys me enough to go back to December until a new release of magisk and hoping it works....
[Magisk] Didgeridoohan:
You won't see Play services as a selectable service in the Manager Hide list since Magisk hides that by default. To pass SafetyNet... You've got something else going on.
[Magisk] Draizix:
That's the thing though. I don't even pass SafetyNet due to Decembers update being old yet it works fine on SU anyway and I get no errors at all. Tried for a week here and no errors. Just switched to February last night and instant error in morning. Did osmosis unSu script and flashed the factory image twice once before and once after the unSu script etc.

That's what I'm not understanding. This used to be fine on magisk back in the v14 time.
[Magisk] Didgeridoohan:
Like I said, there's something else going on. Logs would be nice... Magisk log and magisk_debug.log, at least.
[Magisk] Draizix:
Well hopefully did this right. This is the regular magisk log. I will have to download the beta version so I can go get the more in depth one.

htt

ps:

//paste

bin.co

m/QxAYDJ5i

Had to separate it since I have the post limit no outside links on my account since I never post. Sorry about that.
[Magisk] Didgeridoohan:
Woah... First of all you should clear out that Hide list a bit. Adding to many apps/services might have a detrimental effect instead... Only add those apps that you actually need to hide root from.
[Magisk] Draizix:
It isn't usually everything. Did it as a test to see if it solved the issue. Definitely not. Usually it's only Google play stuff and fire emblem.

Here's the magisk beta log. I also unchecked everything that didn't need it in hide besides Google stuff and fire emblem.

https://pastebin.com/muVapraX

If you need anything else please let me know. I'm honestly at my wits end with this lol.
[Magisk] bilgehnbilge:
Sorry wrong bug report. (Edited)
[Magisk] Didgeridoohan:
Is that really the whole thing? There's supposed to be a whole lot more to it than that, and there's practically nothing about Magisk in there...

Let the device boot properly and run a SafetyNet check before saving the log.
[Magisk] Draizix:
I found out what did that. ES file explorers text editor didn't load it all before copy. I just transferred to PC to do it instead. This one has the many lines you thought were missing.

https://pastebin.com/Z8ZJfvA9
[Magisk] Didgeridoohan:
At a quick glance, the log looks fine...

You're gonna have to do some investigating yourself to figure this out. Test stuff and so on... Start by making sure that MagiskHide works at all, that you don't have other mods or apps that Magisk can't hide, etc...
[Magisk] Draizix:
OH magisk hide definitely works. If I hide it from TB or Adaway or even ES file explorer none of the three can see I am rooted. That's why this is really weird.

I have tried turning off USB debugging and even developer mode to no avail. I have also tried elementalX kernel alongside magisk just to see if it had any affect and nothing.

Fire emblem obviously doesn't care about SafetyNet due to it passing on December security(SafetyNet fails) with superSU/suhide combo. So it's seeing something else magisk isn't doing when it tries to hide it. What that is I dunno but I am not sure what else to try besides just saying screw the updates and going back to December reluctantly.
[Magisk] jenslody:
Sorry for the delay.

Can you test the attached zip from TWRP ?

I just removed some of the "standarderror-to-/dev/null-pipes" ( "2>/dev/null" ) and a pipe to null in the "is_mounted()"-function to get more verbose output.

And of course post the recovery.log (or send it to me via pm if its possible).
[Magisk] iMZee:
Hey I have a htc 10 pme

When i flash magisk my audio (both headphone and speaker) stutter when ever using the power button

At first i thought it was a rom problem but uninstalling magisk root fixed the issue

Is there anyway i can stop the stutter as i really like magisk?
[Magisk] Stanney:
Debloater & Greenify for Magisk fail to isntall on S1

Hello,

I have Bluboo S1 phablet (MT6757) running with Nougat 7.0. (This is my first time rooting an android device, so don't have much knowledge, only what I have read in the past two weeks :P)

After few days of struggling I managed to install TWRP 3.2.1 and Magisk 15.3 (+ Magisk Manager 5.5.5)

Everything seems to run fine so far but when I tried to install the modules Greenify4Magisk v3.9.5 and Debloater (Terminal Emulator v8.7) from the list in Magisk Manager/Modules/Downloads.

Tried installing only these two modules so far, but I actually only care about the Debloater, as I want to remove and disable some apps which are part of the original firmware and cannot be modified without root access.

Tried installing them from the Manager and from Terminal (while in recovery) both ways, both apps/modules ended up with "Updater process ended with ERROR: 1

Error installing zip file..."

Please help me run Debloater so I can remove/disable app I do not desire.

So if you need more info ask away, will provide whatever I can.

Logs are below:

dropbox.com/s/kpb6nxjp1ni84q8/recovery.log?dl=0

dropbox.com/s/fiipov8uvknx4j0/dmesg.log?dl=0

dropbox.com/s/lktyyukv70v2uqn/KpshLog.txt?dl=0
[Magisk] Didgeridoohan:
You need to provide the install log from the Manager or a recovery log from TWRP. Take a look here for details: https://www.didgeridoohan.com/magisk/MagiskHelp
[Magisk] fiverings:
Try go into apps to play store delete cache, delete data. Then go to play services and just delete cache. Then check saftey net, then check if your certified.
[Magisk] Draizix:
I have done this before yeah. No help. I have never been certified on the playstore but see android pay, Netflix, Mario run etc to install so I know that's fine.

But safetynet doesn't matter for fire emblem from what I can tell because when I go back to the December security update and superSU and SUhide I'm not having this issue ever and I fail safetynet on that.

That's why this is really weird and I have no idea what's causing this all of a sudden. I used magisk before 8.1 and it was fine but as soon as 8.1 stuff hit this started.
[Magisk] fiverings:
Super su won't work ever since January update. That's when I tried Magisk 15.3 and it's been working since. You have to remove super su from twrp. That why you need to use flash-all. It removes all traces of super su. If you installed it systemless then it should work. If you installed it system wide (read/write) then you need a fix to set it back. And I don't know what that is. Maybe you need to wipe system. And install twrp systemless.
[Magisk] Draizix:
All I do is fastboot twrp. I don't install it for the recovery ever anymore. On December superSU works fine, that's the final update it works on that I tested. I do clean installs every time. That's why this is odd.
[Magisk] fiverings:
By clean install, your flashing the new boot in twrp or are you just using uninstall super su?
[Magisk] Draizix:
Fastboot boot twrp img

Then I do osmosis' unSU / magisk script then then I go back to fastboot and flash-all, with wipe, the factory image for whichever month Decembers for superSU or February for magisk then go through installing them. Since I'm clean installing and making doubly sure any remnants are there... This is why I'm confused on magisk not hiding this correctly. Like I said, back in November I was using magisk and it was doing its job right. Now all of a sudden it isn't.
[Magisk] fiverings:
When you wipe using flash-all, that should clear everything. Then go and boot twrp.img, then if you don't want twrp to stay, just flash Magisk 15.3.zip and boot to system. Check for root and if Magisk manager installed.
[Magisk] madbat99:
Are you hiding the manager too?
[Magisk] Draizix:
Yes I have tried both hiding with and without hiding the Manager using the option in settings.
[Magisk] jcmm11:
So since Pure Nexus for the Nexus 5x appears dead I'm about to upgrade to stock Oreo (haven't yet found an Oreo ROM for that device that appeals to me). Since SuperSU is dead as well I'm about to install Magisk for the first time. Does it have an equivalent to su.d? I have some scripts I'd like to run at boot. Some I'll probably need to turn into Magisk modules (once I figure out how) but some should just run.

TIA

Edit: never mind. Found what I'm looking for. Going through all the documentation on GitHub at the moment.
[Magisk] Stanney:
Alright, check the links above (in case they don't open like that, just add "www" in front)

One is the recovery log, second is kernel log I believe and the third one I don't remember what log it was, maybe from the error when I tried to install them from the Magisk Manager directly.
[Magisk] Didgeridoohan:
Looks like that could be a f2fs loopback issue. Take a look in your Magisk log and see if you have mounting errors (something like "failed with 13: Permission denied").

If that's the case, you might get things working with the F2FS Loopback Bug Workaround module.
[Magisk] Stanney:
Oh hehe, Nevermind I actually found it :D. And yes there are two with "failed with 13: Permission denied" and one stating "failed with 22: Invalid argument" positioned between them.