yashsingh1/xdaforums huggingface dataset:
[Magisk] DR64XDA:
Avoid redownloading zip already in place

Hi, not sure whether this is the right place for asking, but:

1 would be possible to have Magisk Manager to avoid redownloading magisk.zip when patching, if the proper zp is already in download folder? Maybe by md5/Sha/ any suitable hash validation?

2 As I am working myself a customized recovery image with TWRP and self developed other stuffs, am playing a lot with selinux policies because have no kernel sources (I know they should be available :( ) I found very useful magiskpolicy what is working with 7.1 while supolicy-inject is giving me some problem. And am using a lot seinfo and sesearch from xmikos setools for refining the policies. His searching tools work well still I wondered if they could appear as new added features in the magisk area to keep all modding tools in one place. As magiskpolicy already includes some of these libraries, the binaries won't increase dramatically in size I think (magiskpolicy becoming a multi applet - single binary?). The more, having magiskpolicy being able to apply policies from a definition file would be wonderful.

If the matter is having someone more putting efforts in coding, I could put some on the C development side for helping. Am new in XDA, but I can play with C code.
[Magisk] HypoTurtle:
Probably a strange ask but can magisk delete a folder in /data & if so what all would i need?

Issue - need to delete a folder in encrypted data partition, [systemui stopping on boot] - have access to system, cache etc. in recovery [no access to /data]. Is this doable - I've tried adding to scripts already in /system but they dont seem to be doing anything, if i can't get it sorted with magisk I'll try making adb unsecure in boot.img
[Magisk] alexandrerain:
Erro no SafetyNet

Oi eu sou novo aqui no forum e peço desculpas se eu estiver postando no lugar errado, eu tenho um moto g3 com a rom viperOS v3.1.1 android 7.1.2 e eu instalei o Magisk v14.0 e o apk 5.4.0(57), fiz a instalação pelo TWRP e quando eu abri o Magisk e fiz a verificação do SafetyNet as seguintes opções ctsProfile: false e basicIntegrity: true. Como eu resolvo o problema do ctsProfile?
[Magisk] yochananmarqos:
You don't need to wipe anything. Flashing your stock boot.img is all you need to do. Flash Magisk again after the OTA. If that doesn't work, then your system is modified otherwise.
[Magisk] Didgeridoohan:
If you can't unencrypt the data partition to get access to it there's not much you can do with Magisk. All the good stuff is kept in /data...

Hi and welcome to xda. Unfortunately the forum rules require that you use English...

About SafetyNet, check out the installation and troubleshooting guide. There might be something in there for you.
[Magisk] 3Dota:
[MENTION=4470081]topjohnwu[/MENTION]

sorry to bother you ...

http://play.google.com/store/apps/details?id=com.telkom.mwallet

that application still can detect root even I already enable magisk hide for that application

any workaround for this?

thanks m8
[Magisk] Didgeridoohan:
On current internal test version I can hide root from that app just fine. Wait for the next release or try an unofficial beta snapshot.
[Magisk] Veid71:
I just updated to magisk 14.5 and its giving me the same problem, it won't install any of the modules for some reason
[Magisk] Ecna:
I was following this guide to unlock, root, and install Magisk on my Pixel 2:

Nathanchance's XDA forum thread (this post path: /pixel-2/how-to/guide-unlock-flash-root-pixel-2-walleye-t3702417, cause it blocks full urls)

Everything seemed to be ok, I get all the way to the end where you flash the patched boot image, but when my phone reboots, Magisk Manager says Magisk is not installed and I don't have root. I switched to the beta channel and used the 14.3 zip.

I can't find a /data folder on my device using Total Commander, so I don't know how to get any useful logs.

What can I do to get my phone to flash? Where can I find logs to help?
[Magisk] 3Dota:
ok m8 ... I'll try it and report back

thanks

---------- Post added at 09:20 AM ---------- Previous post was at 08:57 AM ----------

just update to 14.3 ... and still not working on my side ...

Mi5 ... LOS 20171115 nightly ... with xposed 88.2 installed

any idea? or how to take a log?
[Magisk] twowheeler:
What is the difference between complete removal and restoring original boot.img?

I wanted to completely remove magisk, so I chose the last option. But has this also restored my original boot.img? The phone did the first boot twice
[Magisk] HypoTurtle:
I could/have installed magisk, it's installed itself as the device boots and data is decrypted & mounted, just SystemUI won't start.

I got back in to the system via a different way, and it seems what I thought would fix it won't. I've 000 out the SystemUI - so it doesn't run, now need to see if I can find it's issue and red able it
[Magisk] rxk:
Just updated to magisk manager v5.4.1, it also automatically updated magisk v14.4. After restart it seems ok but when i check the safetynet, magisk manager crashed. Is anyone experiencing this?
[Magisk] Wire1122:
Same here
[Magisk] IC_Blood:
Same issue here! Did you manage to fix this?
[Magisk] mctiew:
I have a particular bank application which refuses to run, complaining of jailbreak/root.

I have come to conclusion that it is not detecting correctly, as it is not able to run even I don't install Magisk.

I wonder if I can get some input as to what other things could the app be detecting ? Are android apps able to detect things like :-

1. Unlocked bootloader ?

2. Installed TWRP ?

3. Any other things which might be considered as lowered security ?
[Magisk] teddy0209:
Magisk will take care of UB, I'm not sure about recovery if they're detecting that... Try disabling developer options if enable... Don't forger to add the bank app to the hidelist...
[Magisk] chubby65:
Follow the safety net workaround from here it worked for me

May or may not work for you but it's worth trying

https://xdaforums.com/p9/development/bluewei-test-crossflash-to-l09-c432-t3608270
[Magisk] Didgeridoohan:
I meant the unofficial snapshots, not the official beta...

But, it's perfectly possible that it's Xposed that is triggering the app. Xposed can not be hidden and it doesn't matter if you're using the systemless version. Disable or uninstall Xposed and try again.

It's also a good idea to make sure that MagiskHide is actually working on your device by adding a root app to the Hide list and see if it can detect root or not.

Also, for future reference, logs are always good to provide when asking for help.

The difference is that "complete uninstall" restores the stock boot image and removes all Magisk related files from your device.

"Restore stock boot" is for when you want OTA update but want to keep Magisk on your device.
[Magisk] realista87:
mine is a stupid problem but:

in installed latest magisl 14 on a blackview bv6000 and the app is INSTALLED but, when i enter i only see a green flag for installed magisn and another green flag "14.0:magisksu(topjohnwu)

and the uninstall button.

NOTHING ELSE......... and on lateral menu i do not see the download section. why? maybe magisk is not fully compatible with my phone/rom ?

i can always try superSU but i would use magisk preferably
[Magisk] Wire1122:
OK. Magisk manager 5.4.2 released. Working great on p8lite 2017
[Magisk] DodoGTA:
Are you connected to the internet? :p
[Magisk] trax7:
Weird bugz

Hello,

I've been trying to figure this bug out for quite some time - Magisk Manager crashes after trying to access Magisk SU in it. Apparently, when running it in Core-only mode I can access it, no problem. However, this happens even if I have no modules. I have tried to flash the AINUR Audio mod and every time I get a bootloop after installing. I have done everything possible to isolate it but to no avail, clean installs, reinstalls, wipes, tried everything, doesnt help.

I have a Sony Z5 Compact on latest 7.1.1 Nougat (it also happened last firmware too so that's not it), rooted and custom kernel'd :d

The AINUR people say it's a weird Magisk error I'm getting too.

Here is the log, tell me if you need more I wanna get to the bottom of this :)

EDIT: Installed successfully and booted after disabling Magisk Hide. Magisk SU is also accesible from Magisk Manager. Seems Magisk Hide has been the culprit all along.
[Magisk] kojak1989:
if i put stock firmware again to phone and install magisk i still can get OTA updates from LG?
[Magisk] Pkt_Lnt:
nevermind, I misunderstood
[Magisk] trax7:
I have read it and this is why the bug is weird. Core-only mode fixed the manager crashing (even though Magisk Hide is still on) and disabling Magisk Hide ONLY solved everything for some reason.

I'm not overly familiar with the ins and outs of Magisk itself but I am technically literate and have tried countless solutions before posting :D Thanks for your time! :highfive:
[Magisk] Pkt_Lnt:
Sorry, did not mean to imply that you were not literate in any way. I misunderstood about the modules part, it took me reading if four times just now to get it clear. I thought your error was no modules showing in Core Only Mode. Sorry for the mistake and waste of time.
[Magisk] trax7:
Don't worry mate, everybody makes mistakes. Have a wonderful day/night wherever you are! :highfive:

EDIT: Just had to update AINUR, found out that if I flash it from TWRP it bootloops, if I flash it from Magisk Manager and reboot it's fine :eek::eek: So there's still a bug :(
[Magisk] vaskas:
Hi guys. Magisk 14.3 worked fine for me (modules downloaded and applied correctly) until I encrypted my phone. Once I did, I found that Magisk was no longer present and had to reflash it in TWRP.

This way, I've got SU back working. However the modules can't apply anymore and I'm seeing the following in the logs:

05-29 05:00:47.262 422 422 I Magisk : Magisk v14.3(1437) daemon started
05-29 05:00:47.313 422 429 I Magisk : ** post-fs mode running
05-29 15:01:47.650 422 2352 I Magisk : ** post-fs-data mode running
05-29 15:01:47.653 422 2352 I Magisk : * Creating /sbin overlay
05-29 15:01:47.654 422 2352 I Magisk : * Mounting mirrors
05-29 15:01:47.655 422 2352 I Magisk : mount: /dev/block/bootdevice/by-name/system -> /dev/magisk/mirror/system
05-29 15:01:47.655 422 2352 I Magisk : link: /dev/magisk/mirror/system/vendor -> /dev/magisk/mirror/vendor
05-29 15:01:47.656 422 2352 I Magisk : bind_mount: /data/magisk -> /dev/magisk/mirror/bin
05-29 15:01:47.656 422 2352 I Magisk : * Setting up internal busybox
05-29 15:01:47.672 422 2352 I Magisk : * Merging /data/magisk_merge.img -> /data/magisk.img
05-29 15:01:47.708 422 2352 I Magisk : Resize /data/magisk.img to -1091983040M
05-29 15:01:47.757 422 2352 I Magisk : Create /data/tmp.img with size -1091983040M
05-29 15:01:47.795 422 2352 E Magisk : mount /dev/block/loop0->/dev/source failed with 22: Invalid argument
05-29 15:01:47.841 422 2352 E Magisk : mount /dev/block/loop2->/dev/target failed with 22: Invalid argument
05-29 15:01:47.841 422 2352 I Magisk : New module: EmojiOne-systemless
05-29 15:01:47.985 422 2352 E Magisk : umount /dev/target failed with 22: Invalid argument
05-29 15:01:47.991 422 2352 I Magisk : * Mounting /data/magisk.img
[Magisk] habylab:
I've flashed 14.3 on top of OnePlus 3 Stable Oreo build, and safety net is failing. As I understood, this shouldn't happen. I've hidden root from the Safety Net tester and Android Pay but it still isn't working. I'm presuming I've done something wrong, but all I can see are people saying it works!
[Magisk] Krywk:
Hello!

So I seem to be having a problem regarding SafetyNet. The first time I installed Magisk, everything was fine, and the SafetyNet check passed. However, the second time I tried checking SafetyNet, it started failing.

This is what I see in the log:

--------- beginning of main
I( 425: 425) Magisk v14.0(1400) daemon started
I( 425: 441) ** post-fs mode running
--------- beginning of system
I( 425: 507) ** post-fs-data mode running
I( 425: 507) * Mounting mirrors
I( 425: 507) mount: /dev/block/bootdevice/by-name/system -> /dev/magisk/mirror/system
I( 425: 507) link: /dev/magisk/mirror/system/vendor -> /dev/magisk/mirror/vendor
E( 425: 507) mount /data/magisk->/dev/magisk/mirror/bin failed with 2: No such file or directory
I( 425: 818) ** late_start service mode running
I( 425: 818) * Running service.d scripts
I( 425: 818) * Running module service scripts
W( 7677: 7677) su: request rejected (10133->0)

Notice the only error there. It seems to be having a problem mounting the binaries for... something? I have no idea, honestly.

Anyone know how I can fix this? I've tried everything in the troubleshooting guide except for re-flashing the stock firmware. I̶ n̶e̶v̶e̶r̶ t̶o̶u̶c̶h̶e̶d̶ a̶n̶y̶t̶h̶i̶n̶g̶ i̶n̶ t̶h̶e̶ s̶y̶s̶t̶e̶m̶ p̶a̶r̶t̶i̶t̶i̶o̶n̶. Actually, scratch that, I installed the ElementalX kernel to be able to root the device.

EDIT: OKAY, seems like changing my phone's resolution automatically makes safetynet not pass? That's odd. But whatever, it works now.

EDIT 2: Apparently the "systemless Xposed Framework Module" from the Magisk module repo trips SafetyNet. That's nice. I really need Xposed. :( (Well, it's either that or GravityBox, which I also need. Maybe GravityBox isn't systemless?)
[Magisk] geekgunther:
Can somebody please help. I run Nougat 7.1.2 with Magisk 14.3. I pass the safety net partially with a CTS mismatch.

Recently released game called Naruto X Boruto: Ninja Voltage is able to detect my systemless root and shows an error closing the app. How to fix this problem?

SOLVED: Uninstalled Xposed to pass safety net. Selected the game in Magisk hide.
[Magisk] JTruj1ll0923:
Yes gravitybox, and everything Xposed, will break safetynet.
[Magisk] y2klol:
In MagiskManager I try to open superuser but this causes the app to crash.
[Magisk] Didgeridoohan:
Superuser database corruption, most likely... Clear data for the Manager. This issue should be fixed in the next release.
[Magisk] trax7:
Try running Magisk in Core-only mode and reboot. Then try disabling Magisk Hide. I had the same problem and that fixed it for me. :)
[Magisk] xhan145:
Moto E4 plus just got source from Moto so perhaps we can fix the f2fs implementation finally
[Magisk] DR64XDA:
Magisk Manager 5.4.2

Hi all,

Just updated to 5.4.2, and noticed a couple of things:

1 - Macisk.zip proposed version in 14.3 while the one already installed is 14.4 ( I selected beta update channel).

2 - Translations (Italian one in my case) seems outdated against the ones on GitHub.

Is it just temporary?

Thanks.
[Magisk] Alxoom33:
Where is Magisk Manager 5.4.2 hosted? Link?

Thanks,
[Magisk] DR64XDA:
I got it as auto update from Aptoide app.
[Magisk] zelendel:
Do not mention them in the forums. They are a banned warez market on the site. So no mention of them is allowed.
[Magisk] Didgeridoohan:
I'm pulling this discussion from the beta thread, since it's OT.

The Manager is included in the Magisk zip and will be installed alongside Magisk. But, the Manager might get updates when the Magisk framework doesn't and vice versa. It's all done in-app.

The Manager isn't on the Play store, since Google banned it... :p It'll probably eventuellt be found on F-Droid, but since it'll auto update you won't be missing out on anything.
[Magisk] DR64XDA:
Sorry, didn't know as am quite new here, won't do it again.

However, as few threads before the 5.4.2 was mentioned to have been just released, I assumed it was ok, maybe my mistake.

Will have a look a bit later on the official Magisk Manager and see what is available there... Just in case..
[Magisk] Didgeridoohan:
The proper sources for anything Magisk would be the release thread, the beta thread, GitHub and I think XDA Labs as well (I don't use it)...

If you wan't bleeding edge but don't have the skills to build it yourself, try the unofficial snapshots.
[Magisk] DR64XDA:
Thanks.

I forked the official report yesterday for this purpose - it is for contributing to development and not Ann alternative one, official one is always topjonhwho GitHub - and am doing some pull requests to topjonhwho repo to get eventually merged. But this is on development side :) while the app autoupdated matter was just on my poor user level side :)

I'll keep the references you kindly provided to avoid further mistakes.
[Magisk] babaganoosh76:
I'm relatively new here, so forgive me if I'm asking in the wrong place.

I've been messing around with Magisk modules, and decided to try to make some simple ones (i.e. change the font, lock/unlock sounds, etc.). However, whenever I edit a zip file (even if I download one from Magisk manager, unzip it, and immediately re-zip it), I get an error that says "This ZIP is not a magisk module!" I get the feeling I'm just missing a very simple step, but I don't know how to troubleshoot. Any help or reference to the correct support thread is appreciated.
[Magisk] AndroidDeveloperLB:
I got an update today, but it doesn't do anything.

Pressing the notification doesn't do anything, and choosing to update via the app itself also doesn't do anything.

How come?

Looking at the logs, I don't see anything special of the app that could give a clue of why this occurs.

Attached video to show this issue.

Why Google banned this app? It doesn't root the device. It's like SuperSu...

Is it because of the modules and the ability to download them? If so, this also doesn't make sense, as this app is intended for rooted devices anyway...
[Magisk] DodoGTA:
How do you ZIP your Magisk modules?
[Magisk] Addicted2Bass:
hey guys, i have that issue to, got the notification to update but it doenst update, i need to download the apk myself to update it!
[Magisk] Didgeridoohan:
Make sure that the Manager has storage permissions. There's a bug about that on v5.4.0...

Because the Magisk Manager is used to circumvent Googles tampering detection. Details: https://xdaforums.com/showpost.php?p=72508849&postcount=21

See above.
[Magisk] babaganoosh76:
I've tried both on my mac (by right clicking and hitting "compress"), and on my phone using a file explorer (Amaze).
[Magisk] DodoGTA:
Which files do you ZIP?
[Magisk] Thyrador:
My banking app (Fidor / com.fidor.fsw) is still able to detect magisk, despite the latest beta update.

Anyone who maybe can look into this issue?

You don't need an account for it, just install and open it and wait for a while. It should force close after a short time, rendering me unable to send someone money, for example.
[Magisk] Xostl:
when installing the beta version of magisk, an error occurs in the recovery associated with the data partition

android 8 samsung galaxy s8 exynos

rom like a https://xdaforums.com/galaxy-s8/sam...g95xf-fd-n-renovate-ice-or30-nightly-t3706221 please help us to fix this problem
[Magisk] babaganoosh76:
I've tried both using the magisk module template (github.com/topjohnwu/magisk-module-template), and I've also downloaded modules directly from Magisk manager, unzipped them, edited them, and re-zipped them.
[Magisk] AndroidDeveloperLB:
Storage permission?

But:

1. Starting from Android API 19 (Android 4.4 - Kitkat) , if you put the files only on the app's own private paths (including external storage), you don't need this permission:

https://developer.android.com/reference/android/Manifest.permission.html#WRITE_EXTERNAL_STORAGE

2. Why didn't it ask for this permission?

3. It's an app that already has root. Why can't it use root to grant this permission to itself? It can even install the APK by itself ...

About Play Store, but it still doesn't make sense, because that's only a side app. It's not the one that can affect the "tampering detection", as it's done only using Magisk itself...
[Magisk] Didgeridoohan:
Yes... Did you try?

Again: bug.

Read the link I gave you. If you still have questions: ask Google.
[Magisk] AndroidDeveloperLB:
Yes it works fine now.

Still, please see what I wrote. It can be fixed.

About Google, you could have split it to 2 apps. One for managing, and one for the modules. The modules app could be here on XDA, with a link to its XDA forum thread, via the Play Store app.

The modules app could even be without any UI, as the Play Store one would communicate with it to get the available repos modules.
[Magisk] meddylad:
ihavin issues with app 5.4.2.... crashes before it opens. tried cleanin cache, uninstall old version but no joy. unable to update via magisk manager also... i tap update but nothin happens

currently on S8+ Ambassadi 1.7 and notorious kernel 210.... my current magisk is 14.3 with 5.4.0

::fixed:: used the uninstaller in OP then installed 5.4.2.. from the app i could then download 14.5 and flash it in TWRP so now all good
[Magisk] zelendel:
You might want to just get off the playstore bit. You will soon find more and more devs are going to other app markets like F-droid. It is only a matter of time before everyone will have 3-4 different app market apps.
[Magisk] yochananmarqos:
You don't need to unzip anything, FYI. You can add or remove files within the ZIP with any respectable PC archive manager on any platform.

If you download the Magisk Manager template ZIP from GitHub, it will duplicate every folder contained within with an empty folder. Delete those and keep that ZIP as your template ZIP. Make a copy of it when you create a new module.
[Magisk] Pupet_Master:
So i have Magisk 14.0. The new app manager force close and don't work anymore with it.

Is 14.0 the latest stable release? If not, where can i find 14.1, .2 or .3?
[Magisk] machete187:
I'm having the same issue after updating 15 mins ago???
[Magisk] PraneethMv:
Updated to Magisk 14.5. Device in bootloop. Unable to even access the recovery for reverting or for providing the logs.

Device: Lenovo K4 Note

ROM: RR N 5.8.5

Android ver: 7.1.2
[Magisk] shahnawaz_sheikh:
I have patched my stock boot.img with magisk manager, but when i flashed this patched boot.img my device stucks at bootlogo. I am using vivo y51l android version 5.1.1.
[Magisk] kojak1989:
How to join to translators group?
[Magisk] mctiew:
I have a device which is a marshmallow tv box. It has been pre-rooted with SuperSu.

Now I haven't figured out what is the right model number of TWRP for this device.

When I install Magisk Manager it is complaining unable to auto detect boot device file name.

But I have used terminal emulator and moved around in the file system. I am now pretty sure the device file is /dev/boot. I extracted a few hundred k of its initial content and confirmed it has some bootstring there.

Is there away to install Magisk given the boot device name ?
[Magisk] abhaykelkar:
I have successfully installed magisk 14.3 on oos beta 18 and its working fine. I had previously installed supersu and after wiping sysrem, dalvik and cache i have flashed magisk.

Question is, can i simply uninstall supersu app which is leftover after above procedure?

Magisk superuser is working fine. SN too. Thank you.
[Magisk] ticktock666:
Just reporting, updating magisk manger to version 5.4.2 causes infinite crash loop when launching the app, tried 5.4.1 from apkmirror with same result, so I'm back to 5.4.0 and it works normally.

Also, what is the latest magisk version atm, I'm a bit confused as I've seen some people report using v14.3 to fix this issue, while the manager reports the latest magisk version to be 14.0 and the beta version is now 14.5.

System details:

Resurrection remix 5.8.4

Sony Xperia Z2 d6502

Magisk version 14.0

Manager version 5.4.0
[Magisk] Pkt_Lnt:
Reading post #1 (OP) of each thread shows:

Stable:

https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445

Beta:

https://xdaforums.com/apps/magisk/beta-magisk-v13-0-0980cb6-t3618589
[Magisk] ticktock666:
Thank you, but I've seen the thread and it was exactly why i was wondering why people were using 14.3 to "fix" the manager issue, i guess since the 14.5 beta was only out about 10 hours ago at time of these posts 14.3 was the beta.

Anyway I'll pass on the manager update for now, i don't see any issues and everything is working fine on my end, and the other fix involving disabling of magisk hide is also not an option.