yashsingh1/xdaforums huggingface dataset:
[Magisk] WoltreX:
Hi. There is a problem with x86 systems. When the system is rooted with Magisk, unable to access terminal. (version 17.1) Is there a way to solve this?
[Magisk] Squallo91:
From my observations, SafetyNet flags (ctsProfile, basicIntegrity) are easy to be changed from correct green to crossed-out red by random things - and even though my SafetyNet still says it's passed, I can see it's not just by looking for Netflix app in Google Play (missing). The things that trigger that permament transition for me - eg. I connected phone to PC and tried restoring Shazam app library through HiSuite (Huawei) or simply disabling and enabling developer mode on my phone.

I don't want to unroot/uninstall Magisk -> reflash stock software -> introduce and change settings in dev mode -> unlock bootloader again -> flash custom recovery -> install Magisk and all the apps ->> (...) everytime I see that transition.

So my question is, when is the best time (and using which method) to backup my phone so in case I spot a SafetyNet fail I just simply restore from my backup instead the whole ordeal? So far I've been using TWRP to make backup of all partitions but after spotting SafetyNet fail and trying to restore from that backup, after restoration I still see the test failed.

My device is Huawei P9 Lite (VNS-L21), running Nougat on B504 firmware, rooted with Magisk 17.1/17.3 and with recovery TWRP 3.2.1,
[Magisk] martyfender:
I have no issues with terminal apps on my 5 Nextbook Ares 8A's, Intel x86, Android 6.0.1 tablets. What device do you have and Android version?

I currently use Canary and unofficial builds.
[Magisk] Mrpookie:
You may have to revert to flashing firmware, then twrp, then magisk if you can't get the patched image to work from manager I think but you will lose data that way
[Magisk] jcmm11:
What's your play store status? Certified or uncertified? If it's showing as uncertified try stopping play store, delete data and cache (via settings|apps), then try again.
[Magisk] martyfender:
---------- Post added at 12:35 AM ---------- Previous post was at 12:16 AM ----------

You need to unlock your bootloader before installing Magisk or you are asking for major problems such as failing to boot or a bootloop. I don't understand why you would attempt installing Magisk with a locked bootloader?

You may want to install your rom fresh before proceeding, but, of course, you will loose data and apps:

With an unlocked bootloader, try Magisk 17.3 beta or the newer Canary builds because they have the Samsung Defex Patches:

17.3:
[Magisk] Ashish_117:
I have a strange problem with magisk

If i install magisk i wont be able to use the network. That is it will show No Service and i wont be able to turn on the Mobile radio power!
[Magisk] demonoidmaster:
Usually now all magisk modules expand the img to a specific size based on what it detects, installs the module and then shrinks it

But imo using twrp to flash modules or updates is better, it modifies the magisk.img directly rather than doing magisk_merge which takes two reboots just to get **** working again and because of it apps like vanced or xposed manager (if using the magisk module version) will lose their app settings and that **** drives me nuts... So i just use twrp now, less complicated

---------- Post added at 06:13 AM ---------- Previous post was at 06:10 AM ----------

or just delete the magisk.img file if the device won't boot, it's where it houses your modules pretty much ... Or .. Back up the file first, test it out, if **** goes south just go back to twrp and copy the file back onto it and call it a day

---------- Post added at 06:16 AM ---------- Previous post was at 06:13 AM ----------

Tell your rom maker to stop bundling magisk inside the rom zip, nobody does that anynore, it interferes with magisk survival script. Tell him to just put this thread on his post

At this point this should be a rom postings requirement rule on XDA

---------- Post added at 06:25 AM ---------- Previous post was at 06:16 AM ----------

just unzip the archive and in twrp reflash your boot img, if i were you i would've did that before upgrading from an old . agisk build to a new one..

Anyways yeah just do that then once your boot img is flashed reboot your device to be sure it boots, if it does go back to twrp and flash 17.1 once more, but if i were you I'd use the magisk uninstall zip instead before that, if it won't work just nuke /system (if you run a custom rom) and reinstall your rom then magisk 17.1, that's what I've always done when i needed to be sure i had a clean install of my rom, magisk, modules, etc

---------- Post added at 06:28 AM ---------- Previous post was at 06:25 AM ----------

........ SuperSU is long dead, stop using it, there's no reason to use it, use magisk.

---------- Post added at 06:35 AM ---------- Previous post was at 06:28 AM ----------

That's because magisk won't show modules if you're not using the latest magisk, just like how certain modules themselves won't show up because they haven't been updated to a newer template

Don't use v5.8 use v6.0.1 and i hope you're using magisk 17.1 ?

---------- Post added at 06:38 AM ---------- Previous post was at 06:35 AM ----------

Just adb flash twrp? You'll need a computer
[Magisk] martyfender:
Can that be done through adb? At least on my devices I have to boot into bootloader mode and use fastboot commands to do that, not adb.
[Magisk] ashyx:
100% agree. It drives me nuts.

Root should not be included, but optional.

It seems only novice ROM makers do this now though.
[Magisk] kiwigi:
I had the FRP lock and managed to get out of it with following this. I am back and all the Apps are working with Magisk manager 6.0 still there, except Magisk 17.1 and ROOT. .

I have tried multiple times to flash TWRP, which went nicely every time. Did not reboot and straight into TWRP and flashed Magisk 17.1. The error is something along the lines of "not able to mount". It fails and after reboot another error asking for something like" format, new install"(in german language). I can get back by my method linked up the top. The only problem seems to be able to get root. Any ideas?
[Magisk] mordantly:
You guys are correct.. but the roms for my version tab 10.1 are two choices. The one deodexed zipaligned had old magisk in it. Anyhoo thanks for the tips.. my bootloop is unrelated to the magisk over magisk issue as I thought it was. Fresh flash now won't pass the splash screen, worked fine before. I'll get out of the way.
[Magisk] Didgeridoohan:
If the TWRP you're using can't flash the Magisk zip, you might instead be able to patch a boot image with the Manger and then flash that patched image with TWRP.
[Magisk] kiwigi:
Thanks, that sounds promising. I wonder if someone else has done it that way.

I managed to get a patched boot image yesterday as I tried to do it through adb though the connection to the phone did not work. As a note; I have also tried unsuccessfully to get into fast-boot mode via ADB.

---------- Post added at 09:24 AM ---------- Previous post was at 09:16 AM ----------

thanks@ martyfender

Can I flash a patched boot image(which I had done for installing Magisk, though I "failed the adb route")?
[Magisk] Didgeridoohan:
I've flashed Magisk that way many times...
[Magisk] kiwigi:
[MENTION=4667597]Didgeridoohan[/MENTION]

Many thanks.

I will try it with the patched image. The system I have works perfect with all the apps and data there. As I said, except a working Root.

So I will flash TWRP without re-boot. From TWRP flash the patched image?

I'll report back.

Edit:

unlock oem was enabled

edit2:

I have created the patched boot img.tar and flashed it.

flashed the img.tar through odin

flashed twrp-3.2.3-0-herolte.img through odin

entered recovery without booting

flashed Magisk-v17.3

here below was the result

[url=https://postimg.cc/jCzmsGNZ][/URL]

after another flash as stated here I can boot into my phone and here below is an image from magisk manager how it looks now

I just don't seem to be able to get root. Could it have something to do with encryption? I have never willingly encrypted. Maybe it could've been done by accident.

Additional question. Do I need to patch the boot.img from the installed stock rom?
[Magisk] WoltreX:
I tried with PhoenixOS and PrimeOS (Nougat Systems Android_x86_64). Both rooted succesfully. ALT + F1 working (Terminal). But i cant enter any code. I was thinking about sharing new versions with Magisk upon the intense demand from the users. But it doesn't seem possible because of this problem.

For more detail about systems: http://bbs.phoenixstudio.org/en/showthread.php?tid=13388
[Magisk] redking974:
Hi, I have issues with Magisk Manager and Magisk on my OnePlus 3T encrypted.

I installed a custom ROM (Arrow-v9.0-oneplus3-OFFICIAL-20181119), GAPPS (open_gapps-arm64-9.0-pico-20181124) then Magisk (Magisk-v17.3) without issues.

Then I tried to "Hide Magisk Manager", which seems successfull but after a reboot (or sometimes before the reboot) when I go into the Manager it displays me that "Magisk is not installed". Sometimes a second icon of Magisk Manager appears and ask me if I want to install a complet version of Magisk Manager (which install a second MM which displayed correctly that Magisk 17.1 or 17.3 is installed).

Could it be a conflict with encryption of my device ? Does Magisk Manager can't be hidden on a device encrypted ? I remove the encryption and it seems to work, but I need to check it longer to see if it's OK.

Regards
[Magisk] Dhalsim43:
Magisk 17.1 installation is lost after each LineageOS OTA update. Is there a way to avoid that ?
[Magisk] Didgeridoohan:
If you use the patched boot image method you do not need to flash the Magisk zip in recovery. If you can successfully flash the image through Odin you can skip TWRP.

Sounds more like a known issue with the Magisk database (where the hidden Manager's package name is stored). That's been fixed and should be working in the current Canary builds.

Note: Reporting about bugs should only be done on the Canary debug build.

If I remember correctly, no. I think that's an issue with how LOS have changed their addon.d stuff (or something like that).
[Magisk] kiwigi:
I have done that with the result here below(unfortunately in german)
[Magisk] totbl:
So, every time I update LOS 15.1, I have to reflash Magisk. Kinda annoying. It didn't always do this. Any ideas?

Also, separate question, for some reason TWRP doesn't see my zip files anywhere except MagiskModules folder. Very weird.
[Magisk] Didgeridoohan:
I'm guessing it's telling you your device has been tampered with (or something to that extent). Was the patched file created with "Preserve AVB 2.0/dm-verity" un-checked? And it might be worth it giving the Canary builds a go...
[Magisk] kiwigi:
Preserve AVB 2.0/dm-verity" un-checked: it was not checked. Does it need to be checked?
[Magisk] Didgeridoohan:
If you had it one way and it didn't work, try the other... And like I said, try the Canary builds as well.
[Magisk] kiwigi:
Thanks. I'll have to go to b** and continue tomorrow.

Do you encryp? I tend not to.
[Magisk] guest4711:
Isn't it the expected behaviour when you try to load an unofficial/patched image as long as your bootloader is locked (as you've been told @https://xdaforums.com/apps/magisk/mod-magisk-v1-universal-systemless-t3432382/post78248176 ).
[Magisk] martyfender:
The TWRP screenshot shows that your data is encrypted. Therefore, it is using the keepforceencrypt flag.

In advanced wipe in TWRP you should format data or just use the factory reset option in TWRP so a clean, unencrypted data partition can be created next boot. And you should have the encryption and dm_verity options unchecked in MM before patching your boot.img. You did say you had that unchecked, but since your data is still encrypted, I think that may be why you are still getting the message at boot.

And definitely do as others have instructed and try the latest Canary build.

If the patched boot.img somehow still has encryption and dm_verity still enable, it will re-encrypt on next boot.

When I rooted my first Nextbook tablet, I got that message also in TWRP because I had not formatted the encrypted userdata partition first. Many older versions of TWRP, such as mine, can't mount encrypted data partitions, hence the error message you got in TWRP:

'failed to mount /data'. invalid argument.

First boot, after formatting userdata or a factory reset will take some time. The device will be on the boot animation for some time and will appear to be in a boot loop. At least on my Nextbook Ares 8A's, it can take from 5-7 minutes to boot to the Android Startup Wizard. It could be much faster with other devices, I'm not sure.

Be sure you have backups of any important data before you try this, as it deletes all userdata, including apps, etc. Using these options in TWRP, files in the internal SD are preserved, unless the internal storage is checked in TWRP, also, under the advanced wipe option. I never check that option.

There are no guarantees, but Magisk may flash just fine in TWRP with an unencrypted data partition, I don't know.
[Magisk] dope77:
Hey everyone, i got j6+ rooted with magisk. I can't install any module, keep getting this error sbin/.core/mirror/bin/magisk not found. I opened root browser and went to bin folder, i found magiskboot and magiskinit. This is the first time I use magisk, been using supersu for years so I'm kinda noob on magisk. Can somebody tell me what's wrong?
[Magisk] jcmm11:
For starters what version of Magisk, what modules?

There have been structural changes to Magisk but I just don't remember the details or when what happened.

I have a magisk file in bin (other than that it matches yours)(as an example of structural changes /sbin/.core/ will be deprecated in the next beta, although it will still work for the moment. It will be replaced by /sbin/.magisk/ At least that's what the latest Canary build is currently doing (which is what I'm running))

I think at one point there were also files in/root which magisk symlinked to, but my memory may be playing tricks.

It's also possible that your Magisk install is just corrupt/incomplete in some way. You could try reflashing Magisk. I'd probably recommend the current beta.
[Magisk] martyfender:
Yes I have that magisk file also, so I agree your install is incomplete. It may be missing other files as well. Canary builds have worked well for me on the 2 devices I have it on. Magisk 17.3 and Canary builds have Samsung Defex Patches, also.
[Magisk] kiwigi:
[MENTION=8126387]martyfender[/MENTION]

Thanks

I will follow your suggestions with firstly backing it up and then format/reinstall the lot. It will take time as am going away from home.

So it will take some time till I report back

---------- Post added at 04:42 AM ---------- Previous post was at 04:40 AM ----------

[MENTION=8010004]guest4711[/MENTION]

Thanks

I will format/reinstall
[Magisk] demonoidmaster:
yes, see the reason why is because a while back when i used to use Resurrection Remix the unofficial maintainer would include magisk in his builds .. which rom updates were like not often, whereas magisk would get updated so often.... Anyways thing is, rom update would flash but also run it's magisk install script from the zip, then once done the rom install would finish but then the magisk addon.d survival script would kick in, try to install but would fail because of trying to flash the boot img again (don't ask me why, all i know is that I'd remove the damn magisk zip from inside any RR rom updates whenever they'd release so that proper magisk would work)

---------- Post added at 07:15 AM ---------- Previous post was at 07:10 AM ----------

Do you flash the ota via twrp? If you do and it doesn't work then i guess your device doesn't run addon.d scripts post update
[Magisk] dope77:
I'm using stable 17.1,also tried 17.3 beta but still the same problem. I can't install any module. Believe me, i reinstalled magisk for the 9th time and still same problem. I still have the installation log if it helps
[Magisk] Dhalsim43:
I'm using integrated LOS update functionality, will it work if I flash manually ? What is addon.d script ?
[Magisk] dope77:
Just one more thing, when I'm not rooted , i can use the patch boot.img without problems, after rooting, i can't use that option at all, for example if i want to update magisk and select patch boot.img, i get this

setup

- Detecting target image

- Target image: /dev/block/mmcblk0p23

- Device platform: armeabi-v7a

- Existing zip found

- Extracting files

Killed

Killed

Killed

- Unpacking boot image

Killed

Killed

Killed

- Checking ramdisk status

- Patching ramdisk

- Repacking boot image

Killed

! Unable to repack boot image!

! Installation failed
[Magisk] demonoidmaster:
Basically anything that's a script placed there will run upon flashing a rom, opengapps uses it, same for magisk, what you described before isn't a magisk issue, you're just doing it wrong, flash your updates via twrp, don't update your rom with whatever update manager LineageOS has, should resolve your issues

In twrp after flashing your LOS update it should show magisk reapplying itself afterwards, if not then be sure to flash the latest magisk zip.

PS: i hope your OTA's are full zips and just patches right? Don't think magisk works with rom patches even in twrp

---------- Post added at 08:03 AM ---------- Previous post was at 07:59 AM ----------

Sounds like either magisk doesn't work on your phone, your rom or both

Idk if it's magisk giving those kill commands, but if it isn't, looks like something on your phone is trying to desperately block magisk install / boot patching
[Magisk] Syntist:
So for me, Magisk Modules aren't Working...

Magisk Log:
[Magisk] Saswata Chakraborty:
Greetings!

I have installed NOS on my Poco F1 and I had to format data in the process of flashing the ROM. Now when I open Magisk, I see "Preserve force encryption" is unchecked. However on my device settings, the device is showing "Encrypted".

Do I need to worry about the "Preserve force encryption" not checked on Magisk?

Thank you!!
[Magisk] Didgeridoohan:
Always post logs...

And if you already have Magisk installed you do not need to use the patch boot image method to update, you use direct install... Or is that not working either?

Anyway, the installation logs from both Magisk and modules are the only thing that have any kind of chance of showing what is actually going on.

(And make sure to attach them to your post, do not post them in plain text.)

The system mirror isn't properly mounted. Try uninstalling Magisk and start over.

Edit: and the same goes for you. Please don't post full logs and huge images directly in your post. It's quite annoying... Use the attachment feature of the forum, please.

No.

An option to enable or disable the forced encryption of your device is not the same as it being encrypted or not.
[Magisk] kiwigi:
[MENTION=8126387]martyfender[/MENTION]

[MENTION=4667597]Didgeridoohan[/MENTION]

Thanks guys!

I have now decided to backup my data and then wipe it all. Just too much trouble with the existing due to one or two mistakes I made lately.

Got a couple of questions;

Have been on stock 7.0 and intend to go with stock 8.0, are there any hickups/problems with Magisk? Are android ota updates working with Magisk?

Any advantages/disatvantages between the following:

a) Via custom recovery

b) Via Magisk Manager:This method does not need root, and also does not require a custom recovery
[Magisk] Didgeridoohan:
Shouldn't be, but you're using Samsung, right? There's been some issues with newer Samsung devices that need an extra patch to work with Magisk (no idea if this is applicable for you). That patch isn't in the stable or beta releases yet, but you'll find it in the Canary build. If 17.1 or 17.3 don't work, try Canary.

Yes. [MENTION=4470081]topjohnwu[/MENTION] have made a good guide on how to keep your device OTA-friendly while using Magisk:

https://topjohnwu.github.io/Magisk/tutorials.html#ota-installation

I find it slightly easier to install through a custom recovery, but the end result is the same for both methods. If you go with option b and don't install a custom recovery it might make it easier to update through OTA (see the link above).
[Magisk] kiwigi:
[MENTION=4667597]Didgeridoohan[/MENTION]

Super!!!!:good:

Thank you for your support.

My gadget is a sm-g930fd (2017). I'll check the link regarding the OTA.

Can't wait for an up to date install now.
[Magisk] Syntist:
Sorry for full post logs..

I did uninstall Magisk completely than reinstall it..

But same issue, Magisk can't mount the required folder, So modules doesn't work or even exist for Magisk
[Magisk] martyfender:
According to the release notes in the stable thread, the Samsung defex patch is also in the 17.3 beta.
[Magisk] Didgeridoohan:
Yes but if I remember correctly, it's been updated since then. I may of course be completely wrong... I don't really keep track of Samsung.
[Magisk] martyfender:
This is the last one I see, which was before the 17.3 beta was released:

https://github.com/topjohnwu/Magisk/commit/e1a65276b9074ada694467d0f327f6b13d86c5ac

I have never seen a list of Samsung devices that this patch is for. It is supposed to be a general patch. I do recommend 17.3 or higher Canary builds. Have you noticed that most here that post problems are on 17.1?

I found this for anyone with Samsung devices interested:

https://github.com/topjohnwu/Magisk/issues/689
[Magisk] Syntist:
Still no luck...

So, I did uninstall and reinstall again, but this time I saved installation log

Recovery log contain, Installation log of Magisk v17.1

Magisk_Install log contain, Installation of a test module
[Magisk] kiwigi:
I have continued my journey and have installed stock 7.0 and it updated quickly which I thought was good. So I ended up having, by the looks of it a bootloader 8.0(I did not know it).

Anyway flashed twrp and forgot to untick reboot. Bummer:(

Started again and had to flash stock 8.0. Opened developer options and allowed oem . Flashed twrp and went straight into recovery without reboot and flashed magisk 17.1. It was encrypted?

Locked out again and haven't been able to retrieve the log from the sd card. :(:(

Got there now on Oreo.

Wanting to patch the boot.img to save as .tar and it fails.

Unable to patch boot.img.lz4
[Magisk] redking974:
Hi, but with the same Magisk I can success to hide MM on my other Pie devices (Xiaomi Redmi Note 4, LG Nexus 5, LeEco X526). So if it's a issue with the Magisk database, it's already known on OP devices ?

Regards.
[Magisk] dope77:
Direct install isn't working. Before rooting, i could use patch boot.img with no problems, after rooting, it's not possible,always fail to repack boot.img.

You can say that magisk currently can't do anything except granting root permissions. Here are 3 different logs

1st for updating by direct install

2nd for updating by patching boot.img

3rd for installing module

And the screenshot of sbin folder, there's magiskinit and magiskboot, but can't find a file named magisk (error in 3rd log, modules cant install bcz magisk isnt found in sbin/.core /mirror /bin)

My device is samsung j6+ running 8.1 oreo