yashsingh1/xdaforums huggingface dataset:
[Magisk] :
Hi, I'm running a Moto G5 Plus with Android 7.0, and Magisk 16.0 and Magisk Manager v5.7.0. I'm using the F2FS workaround.

While installing a module (Youtube Vanced i believe), it indicated resizing the magisk.img to an impossible *negative* size. So I went to recovery mode and reinstalled Magisk F2FS workaround. When I rebooted to Android, most Magisk modules work but Manager crashes with backtrace (0 search results!)

java.lang.StringIndexOutOfBoundsException: length=421; index=-1

at java.lang.String.charAt(Native Method)

at com.topjohnwu.superuser.internal.StreamGobbler.run(Unknown Source)

Magisk Uninstaller seems to temporarily fix the problem. If I install Magisk v16.0, neither the bundled Manager 5.6.1 nor 5.7.0 crash.

If I install F2FS from recovery mode (which restores my previous magisk.img), both 5.6.1 and 5.7.0 crash.

I ended up entering recovery, deleting F2FS backup from /data/media, then installing the Uninstaller, Magisk 16.0, and F2FS module. Now I have to manually install modules one by one...

-----------

Does the F2FS workaround tend to cause corruption when installing from Magisk Manager, outside of recovery mode??
[Magisk] Didgeridoohan:
Hm... Could you post the recovery/installation log for both v14 and v16/v16.4?

Sounds like your query is best suited for the F2FS workaround thread...
[Magisk] lvbaal:
Thanks for this work around, grabbing the version from "your" custom channel. Installed it on an arm64 device and so far no issues.
[Magisk] cypher187:
No v14 log, I need to install it - but not today anymore. Here in this folder you can find anything. And tomorrow you can also find the recovery log for v14 there.

https://drive.google.com/folderview?id=1lXAj5-61qVz9T50i5bsnDQvXUnunYaCd

EDIT: [MENTION=4667597]Didgeridoohan[/MENTION] I uninstalled Magisk v16.4 (BTW uninstall script didn't work with updater error 1) from Manager app, flashed stock boot, rebooted to ensure everything works and then successfully installed v14.0. Recovery log is already uploaded.

After that I updated to beta 1642 via direct method and here I am again - same problem. Many errors in syslog, no FPS and so on.

It really doesn't matter which way I install or upgrade - even after full wipe with every custom ROM based on Nougat for this device. As I remember the behaviour isn't the same with every ROM but it never fully worked.
[Magisk] Ex1eXoR:
Hi everyone, dumb questioner here.

Recently, I played with a couple of magisk modes and after installing some and rebooting, I got a bootloop issue. Try uninstalling magisk, system wipe and reflashing firmware, nothing helped. Looking for any solution without data wipe. Guess, there is smth in boot.img file, coz I had a lot of problems while deleting magisk. I constantly got "updater process ended with ERROR: 1 (or 255)". Get rid of it with replacing backuped boot file and flashing uninstaller. No luck. Then I tried one more time install/uninstall magisk (idk why), but now changing boot image doesnt help to remove magisk. Any solutions? Stucked here for 3rd day:(

Im using Oneplus 3T 6/128, OOS 4.1.6 (tried many), android 7.1.1, twrp 3.1.1-2 (tried previous ones), magisk 16.4
[Magisk] Ibuprophen:
I'm not sure if this works for Magisk XPosed but, the following threads OP (by Rovo89) has a "Module Disabler" that you can flash via recovery that should work if it's an issue that's specific to one or more Modules.

https://xdaforums.com/showthread.php?t=2714053

If someone can confirm weather or not the Disabler will work with the Magisk XPosed too.

Good Luck!

~~~~~~~~~~~~~~~

I DO NOT provide support via PM unless asked/requested by myself. PLEASE keep it in the threads where everyone can share.
[Magisk] Ex1eXoR:
tested with magisk manager for recovery, no modules insatlled, according to it
[Magisk] Ex1eXoR:
just found some interesting lines in android_911 log

05-02 01:56:50.328 18575 18575 W : Unable to open '/vendor/overlay/RoundMaskOverlay.apk': No such file or directory

05-02 01:56:50.328 18575 18575 W zipro : Error opening archive /vendor/overlay/RoundMaskOverlay.apk: I/O Error

05-02 01:56:50.328 18575 18575 D asset : failed to open Zip archive '/vendor/overlay/RoundMaskOverlay.apk'

this is magisk module i've installed and then deleted

Maybe theres some more stuff I missed. So please help me delete all the traces of these modules. Is there some kind of startup script, which I can edit or some sort?
[Magisk] Ganuke2kx:
Within the op of the Magisk Announcement thread is listed as a notice the following :

" Magisk Manager*CANNOT*be placed in adoptable storage, or superuser will not work "

^----- Does that still hold true ? If so....... Does that mean if I utilize Magisk w/ Magisk Manager I cannot format my external sd card as adoptable storage or else root will not function ?

Thanks in advance for any input / explanation......

Ganuke
[Magisk] peterlee928:
fyi - when running on stable v16.0, mm also has occasional crashes. not nearly as frequently as when running on beta v16.4, which sometimes will crash mm multiple times immediatey after opening.
[Magisk] Strephon Alkhalikoi:
I use Magisk with adoptable storage on my Lenovo tablet without problems. However, I also don't force Magisk to move itself to adoptable storage, which is quite likely what the warning is all about. With that tablet however, I cannot directly update Magisk but have to enter TWRP and flash it. The catch: TWRP on the tablet doesn't like adoptable storage so I have to store the download on my OTG USB stick, which TWRP can see.
[Magisk] Didgeridoohan:
Sounds like it's possible the module in question doesn't do things completely systemless... I'd ask the module creator.

But first I'd try the Magisk uninstaller [MENTION=8340552]jenslody[/MENTION] provided the other day:

https://xdaforums.com/apps/magisk/beta-magisk-v13-0-0980cb6-t3618589/post76390955#post76390955
[Magisk] Ganuke2kx:
Thanks for the reply. Based on what you stated from your experience I can format my external sd card for adoptable storage...... Root won't " break...... " but I may need to update new Magisk versions via twrp flash and any new Magisk version file may need to reside on a usb otg for twrp to ' see ' it.

It seems that would not be a problem other than being a bit more time consuming compared to an in-Magisk-Manager update. My main concern was not having full root functionality should my device ( HTC 10 ) decide to install the Magisk Manager app to the external sd card portion of adoptable storage......

Ganuke
[Magisk] guest4711:
Did you reboot after deleting the module?
[Magisk] Ex1eXoR:
I got a bootloop after this

---------- Post added at 09:28 AM ---------- Previous post was at 09:09 AM ----------

Can I install this module again via recovery to boot successfully?
[Magisk] Ex1eXoR:
It completes, but bootloop issue continues
[Magisk] Didgeridoohan:
In that case you need to go with my other suggestion and ask the module creator how to revert any changes made by the module.
[Magisk] jcmm11:
What module and where did you get it?
[Magisk] Ex1eXoR:
FINALLY SOLVED

Im put RoundMaskOverlay.apk in /vendor/overlay/ and it boots

Now I have another issue, I cant reboot my device properly, when I press power button for about 0.5-1 sec it reboots immediately without any reboot options, and it seems to be like facing fatal error. Now Im rootless and trying to install magisk again. Log says that installation process was successfull, but after reboot I dont see any kind of magisk installed, root check also fails, but in update menu I get a pop up about having root, which I didnt get before, even with proper root
[Magisk] peterlee928:
[MENTION=4667597]Didgeridoohan[/MENTION] one more log... this shows the problem noted in the message above. thanks again to you and the team :)
[Magisk] ettore88:
Hi.

Usually when I flash Magisk's zip via TWRP...at the restart of my device...there is the presence of a Magisk manager.I installed before the vs 16.3 and then i updated via TWRP flashing vs 16.4.Why?THX in advance

*my device is Samsung S7 Edge stock fw 7.0
[Magisk] Didgeridoohan:
With the amount of logs you've posted now I'd be surprised if [MENTION=4470081]topjohnwu[/MENTION] won't be able to solve world peace next time he's around... :laugh:
[Magisk] peterlee928:
from no logs to mo logs. solve the north korea and syria crises in like 10 mins... easyyyyy :laugh:
[Magisk] flipmode_11:
Try what I documented here. I had a similar issue with "Magisk Hide" turning itself off all the time. I hope it helps! :)

https://xdaforums.com/apps/magisk/2-solutions-problem-magiskhide-disabled-t3758889

Edit:

Solution for Magisk Hide disabled when opening Magisk Manager.
[Magisk] DNikola:
I have Galaxy J100h and i flash rom rr-n 7.1.2 then flash magisk latest.but when i give root access to apps they not work..example app: system app uninstaller..i give root and he can't uninstall app..then i switch to supersu and working but i want use magisk..what i do wrong with magisk?
[Magisk] robchase91:
When i tried to install the latest magisk 16.0 it failed.

Redmi note 4x (mido) Lineage os15.1 /redwolf recovery v 2.7.1.

Please help me. Thank you
[Magisk] Didgeridoohan:
That can happen, although I haven't an it for some time myself.

It'll only happen on a clean install though, so if you updated from a working v16.3, it shouldn't. Or did you first uninstall before flashing v16.4?

You're experiencing the nature of Magisk...

Magisk mounts a mask over /system, so what you're doing is trying to edit that mask. The actual system files are all still untouched. If you need to remove system files, you can try activating Core Only Mode in the Manager settings and rebooting. That way, the mask mentioned above won't be mounted.

You can also use modules like App Systemizer to debloat the Magisk way (systemless). If you're trying to save some space on /system, this won't help you though and the old-fashioned way would be better.

https://xdaforums.com/search/forum/5903?query=cannot mount /vendor
[Magisk] robchase91:
It means i need to clean flash. Data, system, cache . Install magisk first before installing my rom?
[Magisk] Didgeridoohan:
Did you check out the first few posts in the search link I posted? It means you need to update your TWRP.
[Magisk] robchase91:
Yes i saw it. Thank you so.much. I'm using redwolf as of now. I'm not sure if twrp will work on my device. My lcd pannel is ebbg.. when i was using pixel experience rom. I successfully installed magisk. Which is confusing that i can't install magisk on LINEAGEOS 15. I ALSO TRIED RR.6.0 and magisk still didn't work. Thanks for the help.
[Magisk] tommasa:
Excuse me, usually I read and search solutions by my self. But in this case I can't. I'm on marshmallow and I flashed Magisk 16, and the flashing in twrp went fine, without error. Safety net fail, Magisk log is blank even after several boots. I've selected several apps to hide Magisk, but when I return in Magisk hide none of them result selected.

I'm on marshmallow g900fxxS1CQD9 rom version with security patch April 2017, twrp 3.2.1,Magisk 16 and Magisk manager 5.7.

Thanks in advance.
[Magisk] Didgeridoohan:
That your Magisk log is empty is a good hint.

Sounds like you have Android logging disabled. MagiskHide uses logcat to detect the apps and processes you want to hide root from. Try enabling logging again.
[Magisk] StuttgartKiwi:
Feature requests for Magisk Manager

Hi [MENTION=4470081]topjohnwu[/MENTION], I have a couple of feature requests/suggestions to make for the Magisk Manager app, although I'm not sure if this is the correct thread to do so...

1) I'd like to ask for the colour of the text in the app's Action Bar to be changed to a lighter colour - eg. white - instead of the current black colour, in order to improve the contrast and make the text easier to see and read. I have less-than-perfect eyesight, and find it harder to read text with low contrast. You can see what I mean in the screenshots attached here - although on my phone the contrast is even lower than in these screenshots, because on the phone the text is a lot smaller than it looks in the screenshot of course.

The same should go for the hamburger menu icon, search icon, overflow menu icon, tab text on the Log page, etc - basically everything that has the dark-green background colour. :)

2) I noticed that the Modules page has an overflow menu with four "Reboot" options on the menu, which is super-helpful (see screenshot4). What about putting that overflow menu on the main page (the "Magisk" page) of the app too? It would be useful to be able to quickly reboot the device from the main page.
[Magisk] tommasa:
Tnx sir, but I have no idea how to do that. For sure I had not disabled android logging. Reading your troubleshooting guide I've seen that installing kernel adjutor might help, but it changed anything. Can you help me. In this right moment I haven't a pc.
[Magisk] StuttgartKiwi:
Hi [MENTION=4667597]Didgeridoohan[/MENTION], I'm trying to test the "Restore Images" feature (when tapping Uninstall in the Manager app), to make sure it works.

When I do so, I get a toast saying "Stock backup does not exist".

Where exactly should my stock backup file be located on the device, in order for the Manager to find it? And what file name should it have? Eg. boot.img or something else?

I installed Magisk using the Magisk Manager method, ie. without having a custom recovery. Specifically, I copied a stock boot.img file to the Downloads folder on my local storage, patched it using the Manager app, copied it back to my PC, and then flashed it to my phone using fastboot over USB.

So I guess I need to manually put the original, unpatched boot.img file somewhere specific, in order for the Manager to be able to use it when uninstalling, right?
[Magisk] cypher187:
Uploaded as you requested and some additional logs.

https://drive.google.com/folderview?id=1lXAj5-61qVz9T50i5bsnDQvXUnunYaCd

Tell me if you need more infos. And big thanks for helping me.
[Magisk] flipmode_11:
Read my post at top of this page, under suggestions to improve Magisk documentation.

---------- Post added at 02:03 ---------- Previous post was at 01:44 ----------

G'day [MENTION=8938827]Lokanath_405[/MENTION],

Please be aware there are two types of "Magisk" - there is "Magisk Manager" and "Magisk SU" (Open Source Root). The Magisk SuperUser (v16.4 beta) is what gives you the SU command line that root-based commands will use, and the Magisk Manager (v5.7.0) is what allows you to interact and manipulate Magisk Root. You are best to keep Magisk Manager 5.7.0 as it is stable. However you can downgrade to a different Magisk SU Root e.g. 16.4 to 16.3 or 16.0, then upgrade Mananger to 5.7.0.

Backup your device and important data.

Download the Magisk Flashable

In

staller ZIP.

Download the Magisk Flashable

Un

installer ZIP. See

3 last versions

of Magisk Uninstaller in my topic here.

Download Magisk Manager 5.7.0 APK.

Reboot into TWRP recovery.

Flash the uninstaller and save the log.

Flash the installer and save the log.

Upgrade to the latest Magisk Manager and ignore all update notifications, or change Update settings to "Stable".

If there is a corruption in your Magisk configuration, then I'm not sure what to do, from what I see people write your settings are usually retained after uninstall/install. :good:

Alternatively, you can try the faster method, if your device is behaving and there are no issues.

Download Magisk Flashable

In

staller ZIP.

Open Magisk Manager (existing root / pre-root only)

Swipe the left menu open.

Click Modules.

Click (+) button to flash a Module OR Magisk SU Root (v14.0 - v16.4).

Follow the steps and reboot.
[Magisk] kryptikal:
Pure Nexus has BusyBox preinstalled, last time I checked anyway. I'll try the SELinux Permissive toggle trick after I get back from work (no time to reinstall the module & test). Thanks and I'll report back what happens!
[Magisk] mattgyver:
I tried flashing magisk to my at&t galaxy s4 (sgh-i337), which is on the MDL bootloader. Usually that is enough for custom ROMs and whatnot, since most things are auto-loki'd. When I flashed magisk, though, it came up with the yellow triangle and a message about unauthorized software. If I run the loki-doki.sh script after flashing magisk, does anyone know if that would work to coutner the not having a true unlocked bootloader (that script is supposed to work around it).
[Magisk] benlm72:
magisk and boon.

Hi,

I've installed magisk and phh supersuser on my phone (Galaxy S4 with opt cm13 from jdcteam and stock cm kernel). All works fine, thanks for the job!

I'm in France, so AndroidPay is not yet available and I wanted to try boon app. But when I laucnh it, I get an error message telling me that my phone is rooted, either root toggle is off or on. I've seen that it's possible to bypass that using xposed module, but would it be possible that magisk does the job too ?
[Magisk] goodtimes50:
After installing Magisk on my HTC 10 running Viper 3.1.0 my Motion Launch gestures no longer work (double tap screen to wake, swipe down to open camera, etc.). Does anyone know why that might be? I know those are kernel related, but I'm running the same stock kernel I was before.
[Magisk] p50kombi:
Working fine here on my 10 running leedroid
[Magisk] Jeggu:
Good, good. Now if only magisk didn't kill my mobile data on CM14 on OnePlus Two.
[Magisk] deathbytalkshow:
I'm on Fulmics 6.1 and I haven't been able to get this working on my LG G3 AT&T variant (D850). Got the boot cert error, then the "fastboot mode started" issue that you mentioned. I'm trying to read through every post that's LG related but haven't found a solution. Is there one? Another ROM maybe? Thanks.
[Magisk] lukey-55:
Up and running, android pay working perfectly! Nice one :good:
[Magisk] IamIrene:
finally got it working

few days ago not working, maybe due to supersu not fully uninstall, that why Pokemon Go detected I'm rooted

hence I straight away flash back stock rom to get unroot

today I am free then I here the steps I do :

1. flash custom recovery (I am using twrp)

2. boot in twrp and make a backup (in case anything goes wrong)

3. flash Magisk-v6..zip, phh-superuser-17-magisk and xposed-v86.5-sdk23-topjohnwu

4. reboot

5. download & install phh superuser from play store, install Magisk_Manager_v1.2 apk & XposedInstaller_by_dvdandroid apk

6. open phh superuser, click 3 dot over top right > settings > superuser access > apps only > reboot

7. open magisk manager, off root toggle, open pokemon Go
[Magisk] Jaylapeno:
I kept getting fastboot error as well when I bump. Fixed it by flashing dorimanx kernel first, then magisk, then bump
[Magisk] Artim_96:
Just flash it, it should remove the changes in boot.img. only if you want to update Magisk and it was recommended to start from stock you should at least delete /data/magisk.img and the Magisk stuff in /cache
[Magisk] kemz_a:
Tried it, magisk manger can't disable root after flashing the new superSu
[Magisk] desztan:
The new supersu v2.78 SR1 with magisk?
[Magisk] kemz_a:
Yea that one. The root toggle keep going back to on.
[Magisk] -LT-:
Tablet

Does this works on galaxy note 10.1tablet with 5.0.1 android :) ?
[Magisk] joshuaelliot:
I tried to install in a stock 6.0.1 MM ROM for Xperia M4 and it dies on boot. Flashes white screen sony logo then dies after a second. Ironically, I tried to install magic on a rooted device and it works, just doesnt toggles it cuz there is super su in it. But the boot succeeded, I have no idea what led to this.

I read some Z3 users got it to work with a custom kernel, just not sure which one to try for M4..... If anyone can suggest a custom kernel for Xperia M4 Single sim (E2306) it would be appreciated.

Hopefully this issue gets resolved in v7.
[Magisk] conn2005:
I can't get it to install on my OnePlus One with Android 6.0.1 and Multirom 1.188. See install screenshots below. It just gets hung up installing the Magisk zip during flash [IMG="hang up during flash"]https://goo.gl/photos/NAjV7oXSzSTdoeX5A[/IMG]
[Magisk] dimm0k:
[MENTION=5125527]Artim_96[/MENTION] I've seen you mention BusyBox... I've always had BusyBox installed when I installed Magisk and things seem to be working well on the surface... any suggestions on how to clean up BusyBox so that it's done properly or should I leave things the way they are since it's all working?
[Magisk] b00tstrap:
First of all, I want to make it clear that I'm not a ViPER expert; my main contribution here is modifying scripts in flashable zip files.

I didn't find the the ViPER4Android mod in the second post to have a big impact on my phone's (Nexus 6P, stock ROM) sound--I couldn't hear any effect on the speakers, and I could only hear potentially a very slight effect on the headphones. I didn't ever try switching to Permissive mode like a couple people have suggested, though.

At any rate, I really wanted to get one of the more updated ViPER installs working. At first I tried porting A.R.I.S.E. but it hung my phone at boot. So I went one generation back and ported some of guitardedhero's ViPER|Audio series mods (http://xdaforums.com/android/software/viperaudio-viperatmos-3-8-sq-driver-t3289075) to Magisk--namely, the basic ViPER|Audio mod and the ViPER|Atmos mod (v4.7.1 in both cases; not the latest versions because of what seems to be a file number limitation in Magisk for mods). I have both working on my phone now in Enforcing mode, and the effect on my phone's sound is as good as before I switched to Magisk (as far as I've tested).

Here are the places where I posted my Magisk ports:

http://xdaforums.com/android/software/viperaudio-viperatmos-3-8-sq-driver-t3289075/post68704408 (ViPER|Audio)

http://xdaforums.com/android/software/viperaudio-viperatmos-3-8-sq-driver-t3289075/post68709515 (ViPER|Atmos; note that I was able to update it so that it keeps the "surround" profiles--if you want that version let me know, I haven't posted it anywhere yet)
[Magisk] Jay794:
Ok, where am I going wrong? It installed ok but when I tap "Root Toggle" it keeps switching back
[Magisk] Wolfcity:
+1 for putting the reboot menu to the main page and maybe to the 7.1 app shortcuts too.

It would save up a reboot app for me.
[Magisk] psyfi:
hello, iam on Lineage OS 15.1 I use alot of banking apps, so tried to flash magisk via TWRP which gives me an error 1. :(

how do get pass this?
[Magisk] jcmm11:
To start (you may think of a better and more productive way) with go get a chainsaw, go into the woods, and collect some
[Magisk] Ibuprophen:
I had looked into this a bit more and additional information is really needed.

1) What device do you have

2) Is this for Magisk Root? I can only assume that it was Magisk Root seeing that the Magisk Hide is what others look to for hiding Root from banking apps.

3) The TWRP log is needed... (While in TWRP and after the error, go back to the TWRP main/home screen and select Advanced and Save Log then try to remember where it was saved to and provide it).

Other clarifications may be needed but, they may vary depending on the answers to the above questions.

Thank you for your understanding! :)

~~~~~~~~~~~~~~~

I DO NOT provide support via PM unless asked/requested by myself. PLEASE keep it in the threads where everyone can share.
[Magisk] PerfectSlayer:
Hi [MENTION=4470081]topjohnwu[/MENTION] and everyone!

I'm a developer of AdAway, an adblocker for Android, and I would like to let my users enable or disable a Magisk settings: the systemless hosts.

So I tried to start the settings activity from my app but it was not exposed.

As my application requires root, I use "am start" command but first there is some trouble with the UI loading, then with Magisk hide features, application changes its package name so I can't find which application to launch.

Do you see any better way to offer this feature (enable systemless hosts settings) from my app than display a popup to show some text to explain the user he/she has to start Magisk manager, go to settings and check the related feature then come back?

Thanks all! :fingers-crossed:
[Magisk] guest4711:
How about using the dark theme? I think the contrast is very much better...