yashsingh1/xdaforums huggingface dataset:
[Magisk] kryptikal:
How'd you get viper working at all? I've got a Nexus 6 running Pure Nexus rom with Magisk v6, phh 17, & xposed 86.5 and it all works perfectly.

After adding the viper module from the second post and installing the accompanying viper app I'm never prompted to install drivers and no audio ever gets processed (tried 6 different audio apps).

Any assistance would be appreciated.
[Magisk] nsl07:
Hi,

I am on a rogers samsung s4 SGH-l337M unlocked bootloader. I flashed the most recent firmware from sammobile which is 5.0.1 l337MVLUGOH1 and have not put root yet since I want to put magisk on first.

I flashed latest TWRP version via ODIN. Now my issue is after flashing magisk v6 from TWRP, once I boot it keeps showing "Phone stopped working" right after booting up and I'm forced to reflash my phone to 5.0.1 again. At the risk of sounding dumb...I don't need to unzip magisk v6 before I flash it right? Is my phone even compatible with this? If so what the heck am I doing wrong? lol I can't figure it out.

Thanks
[Magisk] ftarules:
You need to use Magisk manager to set SELinux to permissive for Viper To work

---------- Post added at 12:51 PM ---------- Previous post was at 12:50 PM ----------
[Magisk] JudgeDread11:
In the collection of magisk modules thread is a module that installs BusyBox systemless.
[Magisk] ftarules:
Where to download the latest phh Superuser zip that works with Magisk. The phh thread shows version 242. OP shows v17?
[Magisk] desztan:
Set SELinux to permissive if you want to use Dolby Atmos features only.
[Magisk] Nkaskaj:
Anyone?
[Magisk] desztan:
Have you install busybox? Viper drivers require busybox to be installed first
[Magisk] Didgeridoohan:
How did you install Magisk in the first place?
[Magisk] andynx1:
I got the update notification.

Downloaded the now version.

Tried to apply the patch, from within magisk manager.
[Magisk] Didgeridoohan:
Not sure if we're understanding each other...

What I mean is: you have a working Magisk installation. How did you install that?
[Magisk] andynx1:
Sorry, it was ages ago. I flashed it from twrp (clean install), and just auto updated since then.
[Magisk] Didgeridoohan:
But now it fails, when updating to v16.0 worked before? What changed? Does rebooting your device bring back Magisk functionality?
[Magisk] andynx1:
<highly embarrassed> yes, it does... <\highly embarrassed>

Thanks!
[Magisk] Cyborg321:
Someone please find a way to add support for Rockchip boot images.

They use a different signing and repacking than standard Android boot images.

But the problem seems the magiskinit file that replaces init in the boot image is causing a black screen on reboot when repacking manually. (Magiskinit - 700+KB, stock init file 1.2MB)

Just flashing a patched boot.img causes a boot to recovery since it's repacked incorrectly.

And for a boot.img without a kernel inside, is there a way to patch it and build a separate kernel from source code with a want_intramfs flag?

Rockchip devices also use a parameter.txt file to layout the booting process and list the different partitions, not sure if something here also needs to change.

CMDLINE:console=ttyFIQ0 androidboot.baseband=N/A androidboot.selinux=permissive androidboot.hardware=rk30board androidboot.console=ttyFIQ0 init=/init

More info about Rockchip boot image unpacking, repacking.

http://www.gizfun.com/content/unpack-and-pack-rockchip-bootimg-image-（rk3066rk3188

https://xdaforums.com/showthread.php?t=2257331

Rockchip RK3328 source code - https://github.com/rock64-android
[Magisk] saturday_night:
Hey Guys, i´m making my first magisk module now and i am stuck at one point. Did read about two days about what i am looking for but didnt find a solution for it. I want to change global settings using a magisk module (additional to other stuff with the same module but everything else is already done and working). For example if i want to add this in my magisk module, how can i do it?

adb shell
settings put global window_animation_scale 0.75

Would be great if someone could write me an example and tell me if i need to put it in post-fs-data.sh or in system.prop
[Magisk] StuttgartKiwi:
Unable to patch boot image on Pixel XL Marlin

Hi there, I'm wanting to install Magisk for the first time on my phone, but I'm having trouble patching the boot image file with Magisk Manager.

I have a Pixel XL (Marlin) running completely stock firmware, not rooted, no custom recovery. I'm trying to follow the installation instructions from here. Here's what I've done so far:

Installed Magisk Manager 5.6.4.

Downloaded the latest (April 2018) factory image for Marlin from https://developers.google.com/android/images

Extracted the "boot.img" file from the factory image, copied it to my phone.

Opened Magisk Manager, tap Install > Install > Patch Boot Image File > select the boot.img I copied to the phone.

A toast appears, which says "Downloading Magisk-v16.0(1600).zip" - see screenshot attached below.

After the toast disappears, nothing further happens. No message or anything else in the app.

There is a folder called "MagiskManager" in my internal storage, but it is empty. No "patched_boot.img" file is placed there.

Not sure what I'm doing wrong here - any ideas?
[Magisk] Didgeridoohan:
Put the command in service.sh.

settings put global window_animation_scale 0.75

If you can avoid it, don't use post-fs-data, it can sometimes cause issues. And system.prop is for setting props like ro.sf.lcd_density and other props you'll find in build.prop and default.prop.

Does the Manager have storage permission?
[Magisk] StuttgartKiwi:
Thanks for the quick reply!

Yes, it does - see screenshot below.
[Magisk] saturday_night:
I did it this way so now my service.sh looks like this

#!/system/bin/sh
# Please don't hardcode /magisk/modname/... ; instead, please use $MODDIR/...
# This will make your scripts compatible even if Magisk change its mount point in the future
MODDIR=${0%/*}

# This script will be executed in late_start service mode
# More info in the main Magisk thread
settings put global window_animation_scale 0.50
settings put global transition_animation_scale 0.50
settings put global animator_duration_scale 0.50

also i set latestartservice to true in config.sh but it doesnt change those settings. Am i missing something here?
[Magisk] Jaymin.0.1910:
Is settings available outside of adb?? Please verify that from a terminal!
[Magisk] saturday_night:
It doesnt look like, tried to set it with a terminal on the device itself and only got some failures no matter if i tried it with or without root access. Any sugestions how to make it possible with magisk or is it impossible?
[Magisk] jenslody:
I can use it from a termux-window (as root).
[Magisk] saturday_night:
That is strange, maybe those entries have a different name on android one devices?!?
[Magisk] jcmm11:
In Oreo (at least in 8.1) you need to be in permissive mode to run settings. So change the script as follows

setenforce 0
<settings commands>
setenforce 1
[Magisk] saturday_night:
Ok, i tested those settings now using adb connection and everything is working so the entries have the correct name. But also the change that you suggest here dont work. Looks like this now

#!/system/bin/sh
# Please don't hardcode /magisk/modname/... ; instead, please use $MODDIR/...
# This will make your scripts compatible even if Magisk change its mount point in the future
MODDIR=${0%/*}

# This script will be executed in late_start service mode
# More info in the main Magisk thread
setenforce 0
settings put global window_animation_scale 0.00
settings put global transition_animation_scale 0.00
settings put global animator_duration_scale 0.00
setenforce 1
[Magisk] Didgeridoohan:
Does that work in a terminal emulator? Focus on getting things to work from a terminal emulator... When you get that far you can move on to the module.
[Magisk] saturday_night:
Yes its working on a terminal using the setenforce 0 command at first
[Magisk] jcmm11:
What happens from a terminal emulator?

Edit: ninjad
[Magisk] Didgeridoohan:
It's possible you need to set a delay for the script to run. The setting might be overwritten at boot, after the service.sh script runs.

Add

sleep 60

to the beginning of the script and check after a minute or two if the settings are changed. If that works you can experiment with shorter delays until you find one that's suitable. If it doesn't work, try with a longer delay... :D
[Magisk] saturday_night:
Sorry for the late reply i had a meeting.

That did it, thank you all very much. Great that you guys are here. Thanks for teaching me something new, i allways love to learn new stuff haha
[Magisk] Jaymin.0.1910:
Just a little suggestion,

If you added a delay of 60 seconds or even 30s, executing the sleep and the rest part in a parallel subshell will avoid delaying other modules' scripts.

JayminSuthar
[Magisk] arsaam khan:
Why am i getting invalid response from SafetyNet Status
[Magisk] arsaam khan:
Previous one was mistakenly posted this is new one
[Magisk] Badger50:
What happens if you remove the substratum theme overlay??
[Magisk] We7dy:
Hi,

I'm on the OnePlus 5T, Android 8.0, and on the lastest version of TWRP, but I have a problem trying to flash the latest version of Magisk. I have to flash Magisk twice, because the first time I get an error message in TWRP, why doesn't it work the first time? And on reboot I'm redirected to TWRP, I have to wipe the data so I can boot into the system.
[Magisk] callihn:
First I want to say thank you for such a wonderful tool. I just got around to testing it this morning.

I'm having two odd problems.

Everything appears to be normal but Flash Fire still says I'm not running SuperSU in systemless mode, I do not get that message when running SuperSU 2.82 in systemless mode, so I'm not sure if it's accurate or not since technically I'm not running SuperSU at all when I get that message.

Second although BusyBox claims to install to /sbin on every boot using the commands directly do not work (i.e. cat filename) though (busybox cat filename does work and if I run the BB install after boot it works normally.

LG K7 MS330 Lollipop 5.1.1.

Any help on these issues greatly appreciated. Thank you!
[Magisk] Didgeridoohan:
Logs or it didn't happen...

IIRC FlashFire have issues with current Magisk releases. But it seems to vary between users... Best place for that kind of query would be in the FlashFire support thread.

Use [MENTION=4544860]osm0sis[/MENTION] Busybox module from the Magisk Downloads section. Only Busybox you'll need, you don't need any installer apps (that might trigger apps looking for root), and it's nice and systemless. :good:
[Magisk] arsaam khan:
nothing happens after removing substratum overlay
[Magisk] Badger50:
Then maybe try flashing your kernel and magisk again ?
[Magisk] martyfender:
You are not connecting to the internet.
[Magisk] Didgeridoohan:
Do you have the Manager hidden? See what happens if you unhide it.

Looks like something is going on when the Manager is hidden... Not really an issue though, if MagiskHide still works. You can use other apps to test SafetyNet meanwhile.
[Magisk] Didgeridoohan:
Wrong thread for general support questions.

Always check the stickies in a forum, you can usually find good info there. https://xdaforums.com/apps/magisk/guide-magisk-troubleshooting-t3641417
[Magisk] arsaam khan:
I have been connected to Internet

---------- Post added at 01:42 PM ---------- Previous post was at 01:41 PM ----------

no its not hideen!!!

and using other apps to check SafetyNet it pass all the test
[Magisk] Didgeridoohan:
Like I said, not really an issue since everything except the SafetyNet check in the Manager seems to be working.

But, you could try hiding the Manager and see if there's any difference. I can currently reproduce the issue 100% every time I repackage the Manager...
[Magisk] dev_freak:
Google lists my device as uncertified, Safety Net doesn't pass, and now I got issues with an app due to this :/
[Magisk] Didgeridoohan:
http://www.didgeridoohan.com/magisk
[Magisk] dev_freak:
It doesn't seem to work
[Magisk] StuttgartKiwi:
Hi [MENTION=4667597]Didgeridoohan[/MENTION] any further thoughts or ideas regarding my problem? (From here)
[Magisk] Didgeridoohan:
Sorry...

A logcat might show something.
[Magisk] StuttgartKiwi:
Okay thanks, I'll get onto creating a log cat and come back to you.

In the meantime, can you tell me what

should

happen when the patching works correctly? Should there be some kind of confirmation toast or message inside the Magisk Manager app, to confirm that it's worked? Or what should I expect?
[Magisk] callihn:
Thanks, my concern was that I read somewhere Magisk will install systemmode if you already have su installed and though I uninstalled SuperSU I wasn't sure how clean that actually gets and then the notice from FF after successfuly getting rid of it running SSU it had me a bit worried. I also can find no sure fire way to determine which mode su is actually running in.

I assume this is all satisfactory?...

u0_a137@m1:/ $ su
u0_a137@m1:/ # which su
/sbin/su
u0_a137@m1:/ # su -v
16.0:MAGISKSU (topjohnwu)
u0_a137@m1:/ # busybox
BusyBox v1.28.3-osm0sis (2018-04-09 23:00:58 ADT) multi-call binary......
[Magisk] borisov87:
Magisc crash when try refresh list with modules

I attach logcat
[Magisk] Pkt_Lnt:
This has been post many times as has the answer.

https://xdaforums.com/showpost.php?p=76315716&postcount=24405
[Magisk] Didgeridoohan:
You should get a terminal type flashing screen and a small toast saying that your patched boot image is in the MagiskManager folder.

That looks good.

Magisk will only touch /system if it finds another system based root solution already installed. If it detects systemless SuperSU (the default installation since Android 6 or so), it'll just not install. The message you got from FlashFire was because it's a SuperSU biased app (created by the same dude, after all :p), and it probably needs some more work if it will work fully with Magisk. If you're worried about having leftovers from SuperSU you can always run the unSU script by [MENTION=4544860]osm0sis[/MENTION]. That should take care of things, but you'll have to reinstall Magisk afterwards.
[Magisk] sarite:
[MENTION=4470081]topjohnwu[/MENTION] magisk uninstalls automatically when i reboot my device. that too not everytime but randomly. then i have to flash it again and the same repeats. where is the problem?

I'm on v16 stable.

device : zuk z2 plus

rom : viper os final
[Magisk] Pkt_Lnt:
The answer is probably in the logs you did not post. :p
[Magisk] madbat99:
This.
[Magisk] Wolfcity:
Not sure if this is a magisk related issue but maybe someone here can clarify this.

I´m runnig a Moto G5+ (potter) 7.0 stock rom, rooted with magisk 16.

Since a few days I recognize an error when opening a terminal emulator or using adb from a windows PC and just typing the command

getprop

from terminal emulator or

adb shell getprop

from PC the output is

stack corruption detected

.

I´m not new to android and know how to flash roms or kernels and stuff like this but I´m not so good in terminal commands. I googled for it but the answers I found were a bit above my level of knowledge, it's seems to be some kind of crash. Can someone help me out a bit and explain what this message means exactly and how to debug and/or solve it?

I was able to run this command a few weeks ago without problems, could it be any third party app or a magisk setting? I'm using the F2FS loopback bug module, so magisk is located in cache and not in data, just as additional information.

Any help much appreciated.

Attached a log when typing getprop into the terminal emulator and a screenshot of the same procedure.
[Magisk] Jaymin.0.1910:
Yeah, it might be related to Magisk since Magisk supplied resetprop messes with the memory locations where properties are saved.

Do you have any resetprop kind of mods ?? Could you check if disabling any such fixes this ??
[Magisk] Wolfcity:
My installed modules are only sound related like Dolby Atmos, Viper and Ainur Sauron. Also there is App Systemizer and the F2FS loopback bug module.

I'm sure that the "getprop' command was working with magisk sometime ago but that was probably an older version.

It's a bit irritating to not know what causes this "stack corruption detected" output and if it's a really bad sign that could cause problems or just an annoying bug.

Still any information greatly appreciated.
[Magisk] Didgeridoohan:
The crash on downloads refresh is a known bug that's fixed but not yet officially released. The solution for now is to clear the repo cache (in Manager settings) before refreshing.

---------- Post added at 14:29 ---------- Previous post was at 14:26 ----------

I believe all those modules do a bunch of prop value editing.
[Magisk] Wolfcity:
You're right, I disabled all of them except the F2FS loopback bug module and the command is working.

So I only have to figure out which one(s) causes the crash. Thank you [MENTION=4667597]Didgeridoohan[/MENTION], you are godsend! ;)And to [MENTION=8570610]JayminSuthar[/MENTION] who put me on the right track.
[Magisk] Didgeridoohan:
Actually... Looking back at what you posted, App systemizer is probably innocent... :o
[Magisk] Wolfcity:
It is. The bad boy is the audio modification library module. It allows the seamless integration of different audio modules (I'm sure you know that).

Will post it over there in the related thread.

edit: The same combination of modules doesn't cause the mentioned issue on my Moto G 2014.
[Magisk] 4rr4nc4r:
Wi-Fi won't turn on

Hi! After installing Magisk my Wi-Fi won't turn on anymore. Also, when I boot my phone it always says splendid app shut down.

Phone: Asus Zenfone 4 ZE554KL

Android version: 8.0.0 Oreo

Mac address is wrong, it says 02:00:00:00:00:00

Magisk installer and Magisk Manager flashed via TWRP recovery 3.2 and booted via adb

I tried most of the Wi-Fi fixing apps and I'm 100% sure it's not an hardware issue.

What can I do?
[Magisk] TewSlo:
Greetings,

On both magisk 16 & 16.3 anytime I go to refresh the downloads magisk manager crashes. I have tried it across multiple devices and it seems to be a consistent issue. I have forced stopped and cleared data and cache, along with switching to the beta and stable channels as well as clearing repo cache. I am wondering if there is a fix?
[Magisk] Artim_96:
Probably wait till topjohnwu had time to fix this. Manager also crashes for me quite often if I just open it. Then I open it again and it works
[Magisk] martyfender:
This fixed in the latest unofficial build by [MENTION=3306843]kantjer[/MENTION]:

https://github.com/kantjer/MagiskFiles/blob/master/MagiskManager-v5.6.4-180422.apk

It is built from the latest commits by [MENTION=4470081]topjohnwu[/MENTION] .

Because this Magisk Manager version is signed with a different key, you must uninstall your current Magisk Manager, ONLY, to install this version.

I am currently using this version with the 16.3 beta version of Magisk, with no problems.

I was using the full unofficial version until the latest 3 commits, where I eventually loose root and get a message that Magisk is not installed.

Reverting to the 16.3 beta solved this for me.
[Magisk] firozpatel:
Hi everyone, so recently I started getting this message on magisk manager, anyone can help to solve this? I have cleared the cache rebooted and still no idea how to get it work
[Magisk] Pkt_Lnt:
Try this -

https://www.didgeridoohan.com/magisk/MagiskHide

from here -

https://www.didgeridoohan.com/magisk/HomePage
[Magisk] Didgeridoohan:
There currently seems to be that some users are experiencing an issue with the SafetyNet check in the Manager if they've also hidden it (repackaged the Manager). Purely cosmetically tough, so shouldn't be an issue.
[Magisk] iPusak Gaoq™:
Invalid response just happen recently when hiding Magisk Manager...happen to me too so i used this apps to check safetynet status for now until there a fix for the invalid respone....

https://play.google.com/store/apps/details?id=com.rucksack.checkrootstatus
[Magisk] firozpatel:
Yeah everything seems to be working perfectly, as I have tried an app that I'll not work with rooted devices, is there a fix on the way and also there any need for me to update to v16.3 manually?

---------- Post added at 08:03 AM ---------- Previous post was at 08:02 AM ----------

Really good app, I tried and and I am passing safety net, I'll just have to wait for a fix, it's strange how it just happened out of nowhere

---------- Post added at 08:08 AM ---------- Previous post was at 08:03 AM ----------

Also I tried to uncheck magisk hide then reboot to see is the safety net would work, and then re enable it but it would enable for some reason, no matter how many times I turn it on and reboot, would just uncheck itself, so I just restored from back up and magisk hide is enabled
[Magisk] sgrunt:
Hello,

I'm trying to enable SafetyNet but it didn't work.

When I click to run the check, it says that it will download Google API stuff and after I've "SafetyNet API Error" message.

I've followed the solution on this site: https://www.didgeridoohan.com/magisk/MagiskHide#

But it didn't help.

My internet connection is great, I've tried both in 4G or WiFi.

I've the stable version 16.0, but I also tried beta 16.3 version, same result.

I've checked SafetyNet with "SafetyNet Helper" app, and it fail so I don't think that is an UI issue in Magisk.

I'm using Omnirom 8.1.0 (Weekly) on a Sony Xperia X phone

Here is the logs when I click on "Run Safetynet check" button in Magisk with app data erased: https://pastebin.com/zcLQwZYq

I can provide more information if you want.

Can you help me ?

Magisk and SafetyNet are new for me and I don't understand everything, so I'm sorry if this is a noob question...

Best Regards
[Magisk] dknight178:
I'm using stock Note 3 (N9005DXSGBQA1) and followed instructions for magisk manager. I got it rooted but magiskhide does not work - not saving any selection.

I tried using "core only" and tried inserting a new hidelist but both failed. I badly need the hidelist feature. How can I make magiskhide work? Thanks
[Magisk] Didgeridoohan:
Try a different Gapps package?

Don't shotgun your message like that. It's just annoying...

https://www.didgeridoohan.com/magisk/MagiskHide
[Magisk] dknight178:
Apologies for that. My kernel is just 3.4 so I guess I can't use it. Thanks
[Magisk] firozpatel:
So regarding the invalid response, I have figured out that if I hide magisk manager from settings I get invalid response, but if I don't hide it I pass safety net
[Magisk] Antire:
Magisk App (manager) 5.6.4 with v16 or 16.3 wont open on latest miui eu / miuipro 8.4.26 Oreo.

Modules/Root are working well tho, any suggestions? Cheers.
[Magisk] andrew2432:
Magisk v16.0 beta on RR N 7.1.2 r36 galaxy s5 sprint (kltespr) works beautifully on kernel 3.4.113 by ScrawnyB, pico gapps. Even replaced the SuperSU to magisk in options! Root is hidden from go. For some reason all I get is latest version and uninstall?

Edit: guess internet connection would be nice...also on 16.0 not 16.3!

Now how do we take advantage of some mods...

It's not just about the Linux version, I have avoided magisk since mount namespace. Its also up to the devs to add it to the kernel, or us since it open source! You could try other ROMs and things, I had no idea the s5 3.4 had it supported since, well, the build I'm using is from last year...
[Magisk] Artim_96:
Force stop and delete data? And maybe reinstall?
[Magisk] Didgeridoohan:
If you look around you might be able to find a kernel that has mount namespace support backported.

Known issue since a few days. Seems like Google have added a check for maliciously repackaged APK's, or something like that. Don't worry though, you're still passing SafetyNet with the Manager hidden, you just can't check SafetyNet. Use another app if you want to check it...

Provide a logcat.

Never mind...
[Magisk] Antire:
God, how could i skip that, big thanks!

Uninstall and then install the magisk manager apk (not the zip ones) did the job.