yashsingh1/xdaforums huggingface dataset:
[Magisk] jenslody:
False positive.

Or flagged as negative or unwanted to frighten users.

It's surely a possible unwanted program, because it can hide root on your device and that's unwanted by several companies, like google, banks, etc.

But it's wanted by the users just because of this functionality.

It's nit the first time Magisk is flagged as possible malware.

And that somebody named it Virus.zip before uploading it, does not say anything.
[Magisk] AndyShaytan:
From the link in the OP, in the official thread.
[Magisk] oreo27:
I just got an update to Magisk Manager, 5.6.2. Did another developer commit the update?
[Magisk] Homeboy76:
Nope, part of Magisk's 16.1 (1610) BETA update.
[Magisk] oreo27:
Oh. Alright. Thanks!
[Magisk] Jaymin.0.1910:
1) Download the attached script

2) Rename it to 000000deepsleep.sh

3) Copy it to /sbin/.core/img/.core/post-fs-data.d folder

4) Open a terminal and run the folowing commands after 'su'

4.1 --> chown 0:2000 /sbin/.core/img/.core/post-fs-data.d/000000deepsleep.sh

4.2 --> chmod 0755 /sbin/.core/img/.core/post-fs-data.d/000000deepsleep.sh

5) Reboot

and be sure to report back
[Magisk] firozpatel:
Thank you that was much more simple for me to understand

So I followed your steps and this is what happens
[Magisk] Jaymin.0.1910:
You did not ran those steps as I said, correct any spelling mistakes and then try again, BTW from the 2nd screenshot, I really could not understand if it was fixed, I never have used a Sammy, so do not understand if that is normal or what
[Magisk] firozpatel:
Sorry I don't it again, usually android os should exceed more then 20% and that's just me being fair, it should be less then that, but I done the terminal again and rebooted my phone
[Magisk] Jaymin.0.1910:
There should be space after '0:2000' and '0755' in those commands, you forgot it, add a space there and do it again
[Magisk] lvbaal:
Error Installing zip file Magisk mounter

I had installed Magisk module Xposed Framework (SDK 26) on my stock rom Mate 10 Pro Oreo 8.0.0. Then I un-installed the framework through TWRP sideload uninstall.zip because of bootloop. Upon which I was advised not to use the Xposed uninstaller with systemless Xposed. I needed to boot to TWRP, mount the Magisk image and remove the Xposed module manually. Here's when I run into trouble:

I booted to TWRP and tried to mount the Magisk image to remove the Xposed module manually. I've adb sideloaded Mount-Magisk,zip which reports an error: ¨Installing zip file Magisk mounter¨ ¨Magisk is not installed!¨ ¨Updater process ended with ERROR: 1¨. What could be the problem here you think? Neither Magisk Core Only Mode nor Magisk Hide are set to On. Nor does Rootchecker app report Superuser Binary files being installed. The Magisk manager v16.1 itself runs smoothly. I've attached Magisk log from the manager and magisk_debug.log from /data/adb. Also
[Magisk] firozpatel:
I did as you said with spaces between the command

I don't know but seems like it didn't work or is it supposed to be like that?
[Magisk] jenslody:
Mount Magisk has to be "installed" in TWRP, it does nothing but mounting the magisk.img and still works with Magisk 16.1 (at least on my device).

Copy it to your device and "install" it in TWRP, then go to TWRP's filemanager and remove the xposed-folder or create an empty file called "disable" with TWRP's terminal inside the "xposed_xx" folder.
[Magisk] Jaymin.0.1910:
It is supposed to be like that, a reboot now and the issue will be gone

---------- Post added at 03:49 PM ---------- Previous post was at 03:47 PM ----------

I can't understand exactly what help are you asking
[Magisk] firozpatel:
i shall test it out for a few days and see the battery drain, usually happens over night when im sleeping, battery will drain over 10% of not using the device

but thank you and will share my expericance over the next few days of testing

[MENTION=8570610]MCMotherEffin'[/MENTION]
[Magisk] lvbaal:
Basically, i need help to un-install (possible leftovers from) systemless Xposed which I installed earlier in Magisk manager.
[Magisk] Jaymin.0.1910:
So, simply follow this steps

1) Reboot to recovery

2) Flash the zip attached here ( I wrote it for you )

3) Reboot and it will all be good

Note that as many systemless Xposed are available, I wrote it to remove Xposed Unity and those by topjohnwu

Also, it would not unmount the magisk.img from /magisk, so that you can perform any other modifications
[Magisk] problemathic:
could this uninstall even the official xposed not just magisk xposed?
[Magisk] Jaymin.0.1910:
Nope
[Magisk] brybo86:
Hi I have magisk running on an HTC One m9, Android/google pay works fine with magisk hide, but for some reason "chase pay" will not open even after being hidden using magisk hide? Is there some setting I need to clear? TIA
[Magisk] problemathic:
is the latest version of magisk.apk and flashable zip could patched boot.img properly? last version gives only 6kb. feedback guys.
[Magisk] lvbaal:
[Mention=8570610]MCMotherEffin' [/Mention] Hi and thanks for your support. However, I'm getting an error flashing the zip you wrote for me:

1.Reboot recovery

2.Advanced>ADB Sideload

3.Swipe to start Sideload

4.(on PC) adb sideload ¨C:\Users\lvbaa\Downloads\systemless_xposed-uninstaller-signed.zip¨

No error on PC, but error on mobile ¨Updater process ended with ERROR: 1¨
[Magisk] Didgeridoohan:
You misunderstand. You're not supposed to sideload any zips. You flash them directly from recovery. You do have a custom recovery, right?
[Magisk] JugadorLPG:
Hello sir.

Please help me, this a problems on my device lenovo a7000 plus, stay running coustum rom miui9pro.

Magisk v.16 on seftynetNet checked all fail (filed) !!

how
[Magisk] elracingETR:
Hello everyone,

I have a problem in my Samsung Galaxy Note 5 apparently Magik hide does not work, when I ran the application my bank keeps dialing error my cell is root can not be executed. nevertheless, I tried to uninstall it both by the original magisk application and the zip uninstall by means of the recovery, when I try to uninstall it my cell phone does not start, it turns on and off in the Samsung Galaxy note 5 logo.

the only way to turn it on again is to install magisk

I will leave some images.
[Magisk] brybo86:
I have done the steps as described in the link.

One possible reason is that when I try to hide the magisk manager it creates a separate app with the same logo and everything , I thought it was supposed to completely change the name of the magisk app?

After hiding the manager it asks if I want to update the app also?
[Magisk] Habar_nam:
Hy there everybody.

I gave a question.

I have the ZTE Axon 7 ( a2017g).

Im using magisk v15.3 and the 5.5.5 manager version because v16.0 bricks safetynet on my phone.

But every time i start magisk manager it asks me to update.

If i update it asks me to upgrade magisk to 16.

How can I stop that ?

Is there any way?

Thanks in advance.

Gesendet von meinem ZTE A2017G mit Tapatalk
[Magisk] OldMid:
[MENTION=4667597]Didgeridoohan[/MENTION] For my module im trying to find a way to add a check for addon.d in the system, i attempted editing the update-binary file in META-INF but im still quite new to shell scripting, and i couldnt locate some variables etc. any tips?
[Magisk] lvbaal:
Yes, I have twrp installed as recovery. Please tell me the steps within twrp to flash this zip. Thanks!
[Magisk] jcmm11:
Really? Did you even try looking in settings?

Try looking in Magisk Manager's settings. See Update Settings|Check Updates.
[Magisk] jcmm11:
Enter TWRP. Go to Install. Select zip file. Slide to accept.
[Magisk] Badger50:
Go into twrp, select install, navigate to where your zip is, tap it, then swipe to install it.
[Magisk] Didgeridoohan:
Ha! Thanks for the vote of confidence mate, but I'm a proper scripting pleb. Good at figuring things out though...

Here's how the Magisk installer does it:

https://github.com/topjohnwu/Magisk/blob/master/scripts/flash_script.sh#L104
[Magisk] Habar_nam:
Of course i did before asking in the forum!

Sorry.

I forgot to mention it.

But I must admit that I did not look into all the settings.

I managed to solve it by changing to custom update channel and not entering any url .
[Magisk] ViRb3:
Hey guys! I'm trying to make a simple module that replaces a file under /system/priv-app. I am using the latest template; I added my file to the ZIP folder structure, and modified the module name etc. The module installs and everything looks good except the system file isn't replaced! All other modules work fine... Any ideas?
[Magisk] Didgeridoohan:
Uploading an installation log, a Magisk log and/or your module would be a good start.
[Magisk] lvbaal:
Okay, so now I do it like described above and get following output:

Failed to unmount ' /data' (Device or resource busy)

Updating partition details...

...done

Full SELinux support is present.

Installing zip file '/cache/systemless_xposed-uninstaller-signed.zip'

Checking for Digest file...

Skipping Digest check: no Digest file found

Verifying zip signature...

Zip signature verificatin failed!

Error installing zip file '/cache/systemless_xposed-uninstaller-signed.zip'

Updating partition details...

...done

Now I suppose nothing has been altered on my device, or what [Mention=8570610]MCMotherEffin' [/Mention]?
[Magisk] ViRb3:
The installation log shows nothing extraordinary. The replace files and "auto_mount" are properly created in magisk.img. The Magisk log also shows that the file has indeed been magically mounted:

bind_mount: /system/priv-app/Phonesky/Phonesky.apk

Maybe the problem is I am trying to replace (downgrade) the PlayStore? It looks like the files is actually replaced, judging by filesize and hash, but when I start the app (airplane mode on), its' still the new version.
[Magisk] jcmm11:
There's an option somewhere (I forget where, if it's on that install page or in TWRP settings someplace) to skip zip signature verification. Find that and make sure you don't verify zip signature then try again.
[Magisk] ViRb3:
It's a checkbox on the screen just as you're flashing a ZIP.
[Magisk] lvbaal:
Okay, did that: unchecked ip verificaton. Different error now:

Updating partition details...

...done

Full SELinux support is present.

Installing zip file '/cache/systemless_xposed-uninstaller-signed.zip'

Checking for Digest file...

Skipping Digest check: no Digest file found

Updater process ended with ERROR: 1

Error installing zip file '/cache/systemless_xposed-uninstaller-signed.zip'

Updating partition details...

...done

What could be wrong [Mention=8570610]MCMotherEffin' [/Mention]?
[Magisk] jcmm11:
Look in the /cache/recovery/ directory. Zip up the log file that's there and post it.
[Magisk] lvbaal:
here's last_log. Thanks for looking into this
[Magisk] vMAC:
I have attached a logcat from my attempt to install using MagiskManager. It failed again, and you will see that I tried to install two different packages. One was Unified Hosts Adblock and the other Active Edge Mod for Pixel 2 and Pixel 2 XL. https://www.dropbox.com/s/wztt47owfb0gizc/Magisk_module_Issue.txt?dl=0

Since I didn't want/nor have a custom recovery installed I had never tried that. Since you asked I tried to install it via TWRP and they installed without issue.

Interestingly enough, I started Magisk in January with version 15.2 or 15.3 (can't remember) at that time I was able to install modules with MagiskManager without issue. It is only recently that this has begun happening.

Please let me know if you need me to try anything else to troubleshoot.

Pixel 2XL besides Magisk it is completely stock.

No custom recovery, No modded kernel, besides installling Magisk and Apps from Google Play Store it is stock February image.

So should I just consider that something is wrong with my install and start all over? Anyone know of a way I can fix this?
[Magisk] jcmm11:
Well here's the relevant part of the log:

I:operation_start: 'Flashing'
Installing zip file '/cache/systemless_xposed-uninstaller-signed.zip'
Checking for Digest file...
Skipping Digest check: no Digest file found
I:Update binary zip
Verifying package compatibility...
Package doesn't contain compatibility.zip entry
I:Zip does not contain SELinux file_contexts file in its root.
I:Legacy property environment not used in updater.
e2fsck: No such file or directory while trying to open /data/adb/magisk.img
Possibly non-existent device?
losetup: /data/adb/magisk.img: No such file or directory . . . ->(This line repeats 8 times)<- . . .
Updater process ended with ERROR: 1
I:Install took 0 second(s).
Error installing zip file '/cache/systemless_xposed-uninstaller-signed.zip'

So do you have a working Magisk installed? This is saying that magisk.img doesn't exist where it's expected to exist. No magisk.img=no modules. So if you ever had an Xposed module installed via Magisk it's gone, along with any other modules (if this log is accurate).

I've done all I can at this point. You may want to consider running a Magisk uninstaller and starting over.
[Magisk] Didgeridoohan:
You're just replacing the system part... For it to actually show your version, you'll also have to uninstall updates for the Play Store. How do you plan on keeping it from auto updating? Are you using a modified apk?

---------- Post added at 06:39 ---------- Previous post was at 06:35 ----------

That's how hiding the Manager works. The package name will be changed though. Check in the Manager - About. If there's a random package name displaying, it works.

The updating part is kind of interesting. Are you on the latest version?

---------- Post added at 06:46 ---------- Previous post was at 06:39 ----------

Apart from what's already been posted, did you retry my advice of using the Mount Magisk zip and manually deleting the module folder? Now that you know how to use recovery zips...

Never mind... Like already stated as well, it doesn't seem like you have Magisk installed properly anymore.
[Magisk] Jaymin.0.1910:
You're doing it with Magisk, so you don't need any ****ty stuff but the standard ones, a simple 'test -d /system/addon.d' will do the job, you will not need anything special for A / B partitions or skip_initramfs', the mount_partitions() function in the Magisk's util_functions.sh will do it all for you

What [MENTION=4667597]Didgeridoohan[/MENTION] said is completely right, you should uninstall any updates first

There is no magisk.img in /data/magisk.img, so there's no Xposed installed

I'm sorry that you already posted it but, what is your issue, a link to the previous post will be nice
[Magisk] MrBrady:
Has anyone made a Magisk plugin yet that will show the battery percentage on the Ambient Display? Similar to many AOSP-based ROMs and the Android P preview?
[Magisk] Jaymin.0.1910:
It will need Xposed, Magisk cannot do this, and it even is not the purpose of it
[Magisk] lordlord6:
magisk on xiaomi mi max2 is it possible

i want to sp oof for po go,

can i install magisk on my xiaomi mi max 2,?

i dont see mi max 2 ,on twrp list for devices?

help me
[Magisk] Ja_som:
Try forum for your device:

https://xdaforums.com/mi-max-2

Or patch boot image in Magisk Manager and flash it via fastboot (or something similar for Xiaomi)
[Magisk] lordlord6:
i have put it on the mi max 2, forum no answet yet :confused:

i need someone who has done it?and play po go on mi max 2 :good:
[Magisk] lvbaal:
Okay, when you state that Magisk is not installed properly anymore on my device, is it to be expected that at least one of the Magisk modules (MC's Charging Controller) is installed and seems to work? Or is such a module installation seperate from Magisk installation in some way then? Please advise; re-install Magisk maybe?
[Magisk] Didgeridoohan:
From the logs you posted it seems like there is no Magisk image. If you have other modules installed and functioning you should be having one... No idea why the zip then fails. Have you tried the Mount Magisk zip?

I was under the impression that you couldn't even boot your device because of the Xposed module. Is this not the case anymore? What is your issue?

If you can boot you don't need to bother with flashing zips in recovery, you can just uninstall modules from the Manager, or even use a root capable file explorer and delete the module folder under /sbin/.core/img.
[Magisk] lvbaal:
Hmm, odd. I have at least one Magisk module installed that I can interact with (MC's Charging Controler). How is this at all possible when I maybe do not have a working Magisk installed...? Maybe indeed un- and re-install Magisk is to be advised here?
[Magisk] Jaymin.0.1910:
Hi,

If you can boot into system, then you can use Magisk Manager to uninstall any module

And for the zip to succeed, I wrote that in hurry, so forgot to put /data mounting code, so you will need to mount the data partition manually via TWRP, there is a menu for that in TWRP

EDIT :- I hope you forgive the little mistake
[Magisk] lvbaal:
So now I've installed Mount Magisk zip (TWRP Install) as per your suggestion. It reports ¨Magisk is not installed! Updater process ended with ERROR: 1¨

No, it's not that i cannot boot, only that after I had installed Xposed the Magisk way and entered bootloop I had un-installed the Xposed framework through TWRP sideload uninstall.zip. After that you suggested not to use the Xposed uninstaller (becasue of systemless Xposed), but in stead boot to TWRP, mount the Magisk image and remove the Xposed module manually (post). I interpreted your advise in such a way that I still might have leftovers from Xposed on my device, which I should get rid of. But now I am re-assured that there are no leftovers of Xposed framwork on my device because /sbin/.core/img only show modules that are actually installed. So, really there is no issue :D

Edit: apart from maybe being advised to un- and re-install Magisk because the Magisk image seems to be … (i don't know what) on my device ...
[Magisk] ViRb3:
Yes, I have an APK with automatic updates disabled. I uninstalled the updates (by disabling and re-enabling the app), disabled internet, but as soon as I rebooted with my Magisk module installed, the app was back to the latest version.

I noticed that there are an APK and ODEXed classes under:

/data/app/com.android.vending.XXX

I tried replacing the file base.APK, but upon restart the app no longer appears installed. What exactly are those files under /data/app? How can I get Android to use my APK instead? I checked a YouTube replacer Magisk module and it only changes the apk file under /system... Thanks!
[Magisk] Didgeridoohan:
Does disabling the app remove all updates? I'm honestly asking since I've not done that in a long time... There's usually an option to uninstall updates under the three dot menu in app info (same place as where you disable).

The Play Store app is complicated... Where did you get the modified apk? Where there any instructions attached on how to do it normally?
[Magisk] lvbaal:
No problem, your little mistake:) and thanks again for helping out

Btw [Mention=8570610]MCMotherEffin' [/Mention], if you state that manually mounting /data in TWRP before running your script (which you wrote in a hurry and forgot /data mounting code), I suppose this will not work either because of /data being encrypted on my device and TWRP not (yet) able to handle encryption. Am I right?
[Magisk] Jaymin.0.1910:
That APK is the installed APK, and that odexed files or anything similar are re-compiled .dex exexutables by Android, and for the Android to use your APK, the simplest way is to use a patched APK, or disabling the updater activity with pm will also be fine
[Magisk] jenslody:
Check the package name in the about-tab, if it is a randomized one, you probably found something new.

If it is thw normal name, you most likely have MagiskManager installed as system app.

Some rpm-deva do it for some reason. And it breaks the "hide-the-manager"-function.

---------- Post added at 02:06 PM ---------- Previous post was at 02:05 PM ----------

Do you use the f2fs workaround-module ?

You can search the image from TWRP's terminal:

find / -name magisk.img 2>/dev/null
[Magisk] brybo86:
In magisk it says version 16.0

I don't see a different name in magisk settings, about tab.

The prompt to update says v5.6.2

---------- Post added at 08:09 AM ---------- Previous post was at 08:06 AM ----------

This sounds like my problem,

I know magisk was installed as part of my rom.

how do I go about removing the system app? Is there a zip to flash?

Thx
[Magisk] jenslody:
You ca use terminal debloater module or boot into TWRP, mount system-partition and remove the folder below /system/{priv-,}app, probably called MagiskManager or similar.

But it will reappear after the next rom-update, unless the dev does not remove it from there.

You can see, that it's really a system-app, if you can not uninstall it, but just remove possible updates.
[Magisk] brybo86:
Hey you were right it was a system app.

I used twrp to remove it and then flashed the new zip.

Hide app and manager and now the chase pay works fine.

Thanks for your help
[Magisk] lvbaal:
f2fs workaroun module is not installed, no.

And output of find / -name magisk.img 2>/dev/null reads: /data/magisk.img
[Magisk] Jaymin.0.1910:
[MENTION=8340552]jenslody[/MENTION], you are one of those most helpful people, so just wanted to tell you that with F2FS workaround mod, there still will be a symlink to /data[/adb]/magisk.img

[MENTION=3150067]ivba[/MENTION]al, Are you using Magisk < 1455 ??
[Magisk] lvbaal:
Magisk Installed Version: v16.1 Magisk Manager Version 5.6.2 (108)
[Magisk] Jaymin.0.1910:
Weird, In such case, my recommendation will be clean Magisk installation
[Magisk] ViRb3:
I did some further testing and determined that the APK has the original Android/Google signature. Since the content has been modified, obviously the integrity is no longer valid. Maybe this prevented the app from showing up in the Android app list? So I proceeded to self-sign the app, but even now it refuses to show up. Is something stopping me from putting a non-Google app under /system/priv-app? Thanks!

---------- Post added at 08:46 PM ---------- Previous post was at 08:45 PM ----------

I have a patched (self-update disabled) PlayStore APK, but how would I go about installing it? Please check my reply above...
[Magisk] Didgeridoohan:
You can put any old apk under priv-app. That's likely not the issue...

Sorry, but this is now a bit outside my area of knowledge. Best guess I could come up with is that you're going to have to figure out how the Play Store is built up before you can start changing things.