yashsingh1/xdaforums huggingface dataset:
[Magisk] jenslody:
I would try the delete in "TWRP"-suggestion.

Also look for MagiskManager-related stuff in /system/app or /system/priv-app, at least if you have a custom-rom.

Some devs install it as system-app, if the include it at all.

It's strictly recommended to install MagiskManager as user-app or it breaks (at least) the "Hide the Manager"-function and probably has other side-effects.
[Magisk] oreo27:
Maybe someone can help me figure this out. The installation instructions here - https://xdaforums.com/apps/magisk/official-magisk-v7-universal-systemless-t3473445 say that:

...
Press Install > Install > Patch Boot Image File, and select your stock boot image file
fastboot flash boot /path/to/patched_boot.img

which will effectively root my device without a custom recovery.

The reason I'm asking is that TWRP takes a bit of time to update and I'd like to have the ability to root whenever a new version of my stock ROM is out.

However, here - https://xdaforums.com/showpost.php?p=73700423&postcount=4 it says that:

Btw, systemless root by supersu and magisk do a lot things like starting sudaemon, injecting supolicy changes, mounting su.img, etc. Its better to port a custom recovery and let supersu or magisk zip do all the required things to root your device.

Does this still hold true to this day or is flashing Magisk through recovery not q requirement any longer?
[Magisk] Didgeridoohan:
That thread you quoted from is about patching the boot image manually. That's not what you're doing when you use the Manager, it's the Manager doing it...

You do not need a custom recovery to install Magisk. Patching the boot image with the Manager and then manually flashing that to your device is perfectly alright.
[Magisk] der_Kief:
Today i tried Omnirom Oreo 8.1 and exact the same problems.

This has something with the device i bet. Is there something special to pay attetion with Redmi Note 4 (mido) ?
[Magisk] oreo27:
Oh. Makes sense. The fastboot ROM actually includes my boot.img. I can just use that as the boot.img to patch in Magisk Manager, correct?
[Magisk] Didgeridoohan:
Correct.
[Magisk] oreo27:
Awesome. Thanks for the very informative answers as always.
[Magisk] Rex_z9:
Hello, after flashing magisk zip i cannot install any other app in my phone. Package installer breaks after flashing magisk zip.

Any solution please

ROM : Lineage os go verison 15.1 unofficial oreo
[Magisk] Adrian312:
did you solved this? I have the same problem.
[Magisk] Baqir2:
I have install magisk and root my device successfully every apps i used are detected root but one of the apps named "3G/4G speed optimizer" didnot detected root and asking showing that it is not root plss help me.

Thanks in advance

[IMG="screenshot of the error"]https://preview.ibb.co/b9Jvf7/Screenshot_20180305_215755.png[/IMG]
[Magisk] Didgeridoohan:
Logs or it didn't happen....

I'd try uninstalling Magisk and doing a clean reinstall.

It's likely that it is the app that needs to be updated to work with Magisk. Contact the developer.
[Magisk] walid77dz:
Hi, i finally was able to get the patched boot image to my device ( LENOVO VIBE C2), but can't flash it with sp flash tool. Any help please and thanks for this great job (log is in attachment).
[Magisk] Didgeridoohan:
What is it that doesn't work when you try to flash it? The install log looks fine...
[Magisk] eddi0:
The March Security update is live and I have Magisk 16.0 and TWRP 3.2.1 on my Pixel (Sailfish). I cannot seem to find a trued and tried method to update my phone to the latest security update WITHOUT losing all data. I've tried TopJohn's method but I get a bootloop and I tried uninstalling Magisk and then flashing the latest ROM (removing W) and I get a bootloop. Is there a detailed breakdown of how I can do this so I don't end up losing all data?

Thanks in advance.
[Magisk] tsjanda:
I am getting invaled update channel with trying to check for updates. Only seems to happen on cell service not on wifi.
[Magisk] Badger50:
This is how I do it for my P2XL and 6p. Can't see it be much different for the Sailfish :cool:
[Magisk] walid77dz:
I think that my laptop can't detect my device when usb debbuging is enabled ( when i enable usb debbuging, my laptop start to intall something like "CDC abstract control ", the installation fail. ( sorry for my bad english).
[Magisk] Uzumaki:
yes. I first uninstalled magisk from recovery using the provided uninstaller.zip at official magisk thread. Then I flashed magisk manually from recovery.
[Magisk] Didgeridoohan:
In that case it's a question for your device's forum. Not a Magisk issue...
[Magisk] NLBeev:
Clean you laptop, remove adb drivers and reinstall the drivers.
[Magisk] Chamelleon:
Hi.

I have a problem to install modules on LG G6 stock 7.0. Magisk 16.0 itself working properly, SuperSU also. I could install RCM Patch, I can install Busybox from repository but every other module gives me unpacking error. Of course I also tried to install through TWRP but it gives me exactly the same error.

Any fix for that?

I hurried up with this post. Just have read log and see where is the problem. For some unknown reason my BusyBox uninstalled binary itself. After updateing binary everything works well.
[Magisk] fdgd1998:
Hi everyone! I have problems with magisk and audio on my HTC 10. Magisk is interefeering somehow and I get audio stutter. I don't get it with supersu. Any ideas?

I can put logs of neccesary.
[Magisk] Ham3dt:
why I don't have safety net check or install option after doing OTA?

i restore the image and tried to install ota through flashfire but it showed a black screen for 5 minutes or so and then i tried to restart because it seems failed, after restart OTA installed like unrooted device and then i reflashed TWRP and magisk 16.

i think i lost systemless root right?

what happened!
[Magisk] Ja_som:
Try to disable data saver, or enable Magisk Manager in Unrestricted data in data saver.
[Magisk] Ham3dt:
thanks man appreciate it, amazingly it worked!

but why data saver cause that problem?
[Magisk] Ja_som:
I edited my previous post, try it.

And another edit, if you don't want to enable MM in data saver, when you open MM, pull down to refresh.
[Magisk] Didgeridoohan:
I would start with a complete uninstall of Magisk (use the in-app option or the uninstall zip) and then do a clean install.

If it still doesn't work, please provide a Magisk installation log, a Magisk debug log and installation logs for the successful module installations.

Please do.

(Always assume it's necessary...)
[Magisk] fdgd1998:
I attach the log taken while music was playing and provide some other details.

This is a Magisk issue for sure, on stock ROM or rooted with supersu this would not happen. I am using wired headphones and tried with the screen off and on. Audio stutter persists.

I have uploaded it as a 7z archive due to size restrictions.
[Magisk] Didgeridoohan:
Another couple or relevant pieces of information may be what music app (and it's package name) you're using, if you have any Magisk modules installed and a Magisk debug log would be nice as well.

You could also try with Magisk's Core Only mode enabled. That way modules won't be active and you'll only have Magisk's base features available.

The comparison with SuperSU is a bit lacking, since Magisk does a whole lot more than just root your device.
[Magisk] kallell:
Anyone else now failing the saftney check after the march update?

ctsProfile: false

basicintegrity: false
[Magisk] fdgd1998:
Ok, thanks!

I don't have any magisk modules installed, but I have two audio mods: Ainur Sauron MK II.I and JamesDSP.

I am using Google Play Music (com.google.android music) and also have Magisk's Core Only mode enabled.

I mention SuperSU justo for info, because this things didn't happen with it installed. I know Magisk do a lot more things than root, but is interfeering with the audio.

I'll upload new logcat and magisk log later.
[Magisk] Didgeridoohan:
In that case I very much suspect you're issue is with those audio mods rather than with Magisk itself. Have you tried without them?
[Magisk] deathknight12:
Invalid Channel Update & SafetyNet API Error

Hello there. So I'm using Samsung S7 edge and all this time I was using the BatMan Rom and nothing happened. Then for a change, downloaded Project Dream and that was utter disaster so I flashed BatMan and now I'm seeing an error as the title. Here is my log.

03-06 15:29:28.097 3157 3157 E Magisk : symlink /root/YAqk3QrBt->/sbin/resetprop failed with 17: File exists

03-06 15:29:28.097 3157 3157 I Magisk : * Mounting mirrors

03-06 15:29:28.098 3157 3157 I Magisk : mount: /sbin/.core/mirror/system

03-06 15:29:28.098 3157 3157 I Magisk : link: /sbin/.core/mirror/vendor

03-06 15:29:28.098 3157 3157 I Magisk : bind_mount: /sbin/.core/mirror/bin

03-06 15:29:28.098 3157 3157 I Magisk : * Setting up internal busybox

03-06 15:29:28.107 3157 3157 I Magisk : Magisk v16.0(1600) daemon started

03-06 15:29:28.109 3157 3165 I Magisk : ** post-fs mode running

03-06 15:29:28.715 3157 3242 I Magisk : ** post-fs-data mode running

03-06 19:29:28.717 3157 3242 I Magisk : * Mounting /data/adb/magisk.img

03-06 19:29:28.758 3157 3242 I Magisk : * Running post-fs-data.d scripts

03-06 19:29:28.758 3157 3242 I Magisk : * Running module post-fs-data scripts

03-06 19:29:28.758 3157 3242 I Magisk : * Loading modules

03-06 19:29:28.758 3157 3255 I Magisk : * Starting MagiskHide

03-06 19:29:28.758 3157 3255 I Magisk : hide_utils: Hiding sensitive props

03-06 19:29:28.758 3157 3255 I Magisk : hide_list: [com.google.android.gms.unstable]

03-06 19:29:28.768 3157 3255 I Magisk : proc_monitor: init ns=mnt:[4026531840]

03-06 19:29:29.231 3157 3367 I Magisk : ** late_start service mode running

03-06 19:29:29.232 3157 3367 I Magisk : * Running service.d scripts

03-06 19:29:29.232 3157 3367 I Magisk : * Running module service scripts

03-06 19:29:31.328 3157 3255 I Magisk : proc_monitor: zygote ns=mnt:[4026535690] zygote64 ns=mnt:[4026535689]

03-06 19:29:58.982 3157 3255 I Magisk : proc_monitor: com.google.android.gms.unstable (PID=7728 ns=mnt:[4026535812])

03-06 19:29:58.985 7735 7735 I Magisk : hide_daemon: Permissive detected, hide the state

03-06 19:30:46.677 3157 3255 I Magisk : proc_monitor: com.google.android.gms.unstable (PID=11929 ns=mnt:[4026535855])

03-06 19:30:46.682 11935 11935 I Magisk : hide_daemon: Permissive detected, hide the state

The root works but I can't download any modules or check safetynet status.
[Magisk] Didgeridoohan:
Sounds like your Magisk Manager doesn't have internet access. Make sure it's not blocked by anything.
[Magisk] fdgd1998:
Yes, on stock ROM. No problems at all. I will try later.
[Magisk] fdgd1998:
Stutter also happens on a clear install without mods and magisk installed. I get that from magisk log.
[Magisk] Didgeridoohan:
Hmm... Ruling out stuff at least...

I'm horrible at reading logs, but I do see a whole bunch of "Background execution not allowed" and crashes for com.google.android.music from your logcat you posted earlier. No idea if they're relevant... Sorry.

The Magisk log looks fine.

I can't see what it could be in Magisk that would cause something like this. Do you have some root app running in the background hogging resources, that doesn't work well with Magisk?
[Magisk] zfk110:
Hi, Genius, I couldn't pass the SN anymore I was and then I wasn't on 15, then I was its was hit and miss, but since I updated to 16 I couldn't could you please look into it? I got 910T with stock kernel and TekHD's Lollipop ROM can't thank you enough!!
[Magisk] fdgd1998:
No, nothing running at the background. I know it is magisk, but can't find how can be causing this. However, with other root methods this doesn't happen. Even in the ROM thread this has been discussed many times, and all fixes point the same direction: use SuperSu intead of Magisk.

I will flip through the log file again and try to find out something...
[Magisk] Didgeridoohan:
So it might be ROM related then?

Have you tried disabling everything but MagiskSU? Enabling Core Only mode, and disabling MagiskHide and systemless hosts.

---------- Post added at 20:43 ---------- Previous post was at 20:35 ----------

Log looks fine. You might get more info out of a Magisk debug log.

Edit: and you've tried toggling MagiskHide off and on again, right?
[Magisk] exaveal:
Hello,

i try to make a clean install on my Samsung Galaxy S5 Mini. I have the LineAgeOS Custom Rom running from this Thread: https://xdaforums.com/galaxy-s5-mini/development/g800f-m-y-lineageos-14-1-g800f-m-y-t3549055

I'm new to all this and I really have problems to understand how to install Magisk. I read, that I should install it before the custom rom.

So here is what I did:

Initial Situation: Custom Rom was already installed.

1. Wiping everything on my phone with TWRP version 3.1.0-0

2. Copying the Magisk-v16.0.zip to the SD card

3. Starting TWRP and trying to install "Magisk-v16.0.zip".

The Installation process ends with the message:

This is the recovery.log which I can copy on the sd card in TWRP: https://pastebin.com/nResJ9xL

So what to do now?

Help - sorry for my inexperience :(
[Magisk] Crepusculi:
Trying to get Magisk working on the March update gave my 5X a bootloop. Had to go back to the February update. Going to try again this weekend to see if I can figure it out.
[Magisk] Didgeridoohan:
I think you're confusing custom ROM with custom kernel. From the installation instructions:

Installation order:

ROM

Gapps

Magisk

Custom kernel (if applicable)
[Magisk] exaveal:
Thanks for your answer! Hm okay, so I did the right order (except I haven't flashed a custom kernel).

The problem is: I want to install the app "Circuit" from the Google App Store and it directly says, that the device is rooted. I wiped everything on the phone, installed the Custom ROm, than Magisk, than Gapps. I booted the phone, installed "Circuit" from Google Play Store. Started it, try to login and the app says, the phone is rooted. :confused:

And I know, that this is not normal. Others have this app installed via Magisk. Something I must do wrong, but I don't know what i do wrong :(
[Magisk] Didgeridoohan:
So you've got Magisk installed now, without any error?

For tips on hiding root, take a look at the Magisk guide, here:

https://www.didgeridoohan.com/magisk
[Magisk] exaveal:
Okay, i needed to explicitly hide root for the app. Now it works. :good: Thanks a lot!
[Magisk] fdgd1998:
Tried everything. So, thanks for the help, I doubt it's ROM issue, it only fails with Magisk.
[Magisk] 666pigo:
Having same issues, although everything works of kinda fine when magisk hide is disabled and google play data is cleared.

Magisk version: 16

ROM: los 15.1

There are two logcat logs: one for installing from google play, another for installing from SD. And also a magisk log.
[Magisk] pennywaltz:
For the pixel, i can't get Magisk to work on stock rom.

So I loaded 8.1.0 Feb and 8.1.0 March. I first flash TWRP 3.2.1 (lastest) and then I use TWRP to load Magisk. After that, I hit reboot system and it just reboot to TWRP and not into android. I am unsure what is going on here.

I have done the exact step for Resurrection Remix 8.1.0 Feb 2018 build.. and it works fine... But I found RR to be a bit sluggish... so I figure I would use stock.
[Magisk] churchmice:
I have experienced the same issue, and my steps are followed below:

1) install march update and wipe all data

2) setup the phone without pin

3) fastboot twrp-3.2.1 image and install twrp-3.2.1-zip

4) reboot into recovery

5) install magisk and reboot

My understanding is that the installation of magisk will use /data partition, the current twrp version does not support decryption well, so you should install magisk without setting up and pin.

I have tried to install magisk without first setting up the phone ( skip step 2 ), which won't work and my phone will reboot into recovery ( twrp ).

My understanding of this is that after a fully wipe, if you install twrp directly, the /data partition is wrongly formed and android won't accept it. Therefore, step 2 is essential.

---------- Post added at 05:23 AM ---------- Previous post was at 05:17 AM ----------

I would like to report some of my findings regarding the FC of magisk manager.

The steps is shown below:

1) a clean reboot

2) magisk manager can be opened without problem

3) let the phone sit there by about half an hour

4) magisk manager will FC

I find it has something to do with the magisk self updating by downloading things from the internet ?

Here are my findings:

1) clean boot the phone

2) open magisk manager, which works fine

3) turn my phone into airplane mode

4) let the phone sit for one night

5)open magisk manager, which still works fine

The 3) could also be accomplished by disable the 'UpdateCheckService' with Myandroid Tools app.

I am running with pixel gen1 with march security update and so far it works just fine.
[Magisk] deathknight12:
Today morning when I checked it, it works so yay. But SafetyNetAPI still shows error.
[Magisk] Adnanakhtar:
Need help for root santoni (running pixel experience ROM)

I've Redmi 4 santoni 3gb version.and I flashed pixel experience ROM in it....but if I try to root it with magisk then it failed again and again....I want to run banking apps also .... that's why I need magisk for root ..... please help guy's.... which file should I flashed in my Redmi 4 for root my mobile? I've twrp installed!
[Magisk] Didgeridoohan:
Look here for tips and tricks on how to get things running:

https://www.didgeridoohan.com/magisk

If you can't get things working, take a look here on what kind of info to provide:

https://www.didgeridoohan.com/magisk/MagiskHelp
[Magisk] RASTAVIPER:
I am using Magisk v.16 with my stock OP3T Oos 5.0.1

I have selected the HSBC app at Magisk hide, but still the app recognizes my root.

Why Magisk hide is not working?
[Magisk] Didgeridoohan:
And you've tried all of this?

https://www.didgeridoohan.com/magisk/MagiskHideHidingRoot
[Magisk] Wolfcity:
I think I've read something similar in here but I can't find it using the search function.

The magisk hide toggle automatically turns to off when I delete MM from the recents tab.

If turned on magisk hide is working and I pass both SN checks. I'm using the loopback bug module on my Moto G5+ (data f2fs partitioned), 7.0 stock ROM, Magisk 16.

Log attached.
[Magisk] Sebastl:
HERE you find a Magisk v16.01 Permissive with the folllowing changes: https://github.com/Permission13/Magisk

It allows to mount and write to images via loopback and also to install modules based on [MENTION=5065917]BertlBrown[/MENTION] sdcardfs mount idea.

There is one drawback:

After having rebooted to complete the installation of a module,

you have to reboot one more time before being able to install the next one.

If a module installation fails because of different mount pathes or anything else please leave me a note.

If it is working for those people affected by Permisssion 13 NOT due to F2FS,

maybe [MENTION=5228676]VR25[/MENTION] could take a look of implementing the changes in his F2FS Workaround module ?
[Magisk] Jaymin.0.1910:
Nice

Analyzed both the commits and I don't know if it works or what, but if it does, then firstly author of the changes will need to clean the code first and then rewrite a bit of comments, and for the F2FS Loopback bug workaround module, it could have setup bind-mounts, but the further will not be theoretically possible for a shell script to handle, unless someone compiles a binary for that
[Magisk] problemathic:
why cant i install magisk on mt6580 3.4.67 Micromax unite 2 a106 running custom roms temasek os 5.1.1 lollipop, aosp extended 7.1.2 nougat, aokp 6.0.1 marshmaow, crdroid 7.1.2 nougat, mokee os 7.1.2 nougat. Tried the patched boot.img also via the app but it will give me a 6 kb patched_boot.img. even my boot.imgbis on 6mb +
[Magisk] Didgeridoohan:
That's a known bug with the latest release. Should be fixed soon... Meanwhile you could try the latest unofficial snapshot, if you can't wait...
[Magisk] problemathic:
now it just a bug silly me. been confused for 4 days why only 6 kb until i decided to get a support here. thank you so much man. now i can have a good sleep.

---------- Post added at 01:41 AM ---------- Previous post was at 01:27 AM ----------

bro its still the same. the patched_boot.img is still 6 kb downloaded the latest unofficial magisk.apk on github.
[Magisk] Didgeridoohan:
If you want to patch the boot image with the Manager, using the unofficial snapshot, you're going to have to change to the snapshot update channel. Enter this address as a custom update channel in the Manager settings:

https://raw.githubusercontent.com/kantjer/MagiskFiles/master/updates/kantjer.json
[Magisk] problemathic:
bro it worked. im not on bootloop. my stock android version is Kitkat 4.4.2 running now a lollipop custom rom. awesome. to tell you the truth the reason i installed custom rom for a higher version of android where magisk is supported now im on magisk. thank you for the guide. and modules are working great :) which is cool. can i flashed the magisk beta version now? or should i stay on this version?
[Magisk] nexusmaniac:
So then, seems like a nice place for general discussion ;)

Anyone tried Magisk on Android P? :D

https://www.androidpolice.com/2018/...-preview-images-now-live-no-beta-program-yet/
[Magisk] TonikJDK:
I have. It patches the boot img. I flashed it and it boots fine but no root.

Pixel XL 2
[Magisk] nexusmaniac:
Does magisk hide work for you? I.e. android pay working even though the build isn't CTS approved? :)
[Magisk] TonikJDK:
Didn't try, and I ahve cleaned it all out. Just running stock P for now. It fails CTS stock.
[Magisk] xatornet:
Yep, same here. Although TWRP works fine, Magisk will flash succesfully, but Magisk Manager won't detect root. So no Magisk support at this moment :eek:
[Magisk] Didgeridoohan:
You'll need to stay on that version until a fixed official release is out. Hopefully next time [MENTION=4470081]topjohnwu[/MENTION] has some free time.
[Magisk] Ghxst01:
Magisk not hiding when stock boot.img is changed.

Hey, I managed to modify my stock ramdisk / boot.img to set ro.debuggable to 1. However when I `dd if=boot.img of=/dev/block/mmcblk0p37` this boot.img, magisk fails to hide and safetynet fails as a result of that.

Isn't magisk supposed to hide the ro.debuggable property?
[Magisk] Didgeridoohan:
Well, no it doesn't. It changes the loaded value to 0, there's no hiding going on...

What is it you're trying to achieve?
[Magisk] LLStarks:
Did Magisk and TWRP work during the Oreo DP?
[Magisk] Didgeridoohan:
Not straight away:

https://xdaforums.com/showpost.php?p=72293984&postcount=20
[Magisk] LLStarks:
Doesn't help that John is away for a few more months. Maybe some brave developer will make an attempt for P.
[Magisk] Ghxst01:
I want a "dynamic" way to toggle between ro.debuggable=1 and ro.debuggable=0.

My idea was to flash the modified stock boot.img that has ro.debuggable set to 1, and have it hidden from safetynet by magisk, then when needed I can for example turn off magisk and make use of the default modified setting.

Maybe you have an alternative though, it's quite an important modification for me as I use it a couple of times as week, but also need to pass safetynet for other applications.

If I had the money to spare, I would have maybe bought a second device with this permanent modification, but I hope magisk can help me solve this issue eitherway.
[Magisk] Didgeridoohan:
The P preview has been out for a few hours. Have some patience... :laugh:

I'd simply make a Tasker task and put a widget shortcut to that on my home screen. Something like the attached one...

And with that I'd also copy the "Set Widget Label" from that task to a "Device Boot" profile together with a command to set the current value to %DEBUGGABLE (so that the proper value would show in the widget at boot). Edit: kind of like the attached profile...