yashsingh1/xdaforums huggingface dataset:
[Galaxy S 5 Q&A, Help & Troubleshooting] korn16ftl3:
hello i have recently purchased a strait talk samsung galaxy S5 model # SM-S902L and have been trying to root the device.

i have used the TWRP and Odin method as towel root says it is not supported the method i have been trying to use is located here on the XDA forums her:

http://xdaforums.com/galaxy-s5/help/galaxy-s5-straight-talk-variant-sm-s902l-t3162340

the problem i seem to be having is Odin is flashing and the phone is accepting the flash even the flashing screen says i am running a custom OS how ever both titanium backup and root checker are saying i do not have root privileges....what am i doing wrong here? any one have any idea or that can help?

i found a stock rom in that thread as well i was thinking about flashing it then trying the TWRP method again.

suggestions or ideas would be greatly appreciated
[X Style (Pure) Themes and Apps] DJTeeJay:
http://www.droidviews.com/enjoy-moto-g4-apps-motorola-device/

apk files are in link

-Time & Weather Widget (360 style-shown in pic)

-File Manager

-Camera

-Gallery (didn't work on AICP)

-Boot Logo
[X Style (Pure) Themes and Apps] MrMeeseeks:
Is that the stock g4 wallpaper? ????
[X Style (Pure) Themes and Apps] DJTeeJay:
Noooooo, I got it somewhere on G+. But the widget fit and I already had the wall up....
[X Style (Pure) Themes and Apps] BooBzi:
Will test on my stock 6.0.1, but I have a question, does this works also on CM and AOSP based ROMS?

Curious about "slow-mo" and "save to SD card" modes.?
[X Style (Pure) Themes and Apps] sabinblitz:
Thank you, really excited to try the camera app when my phone arrives tomorrow.
[X Style (Pure) Themes and Apps] JackieBrown:
I just tried the apks and they worked
[X Style (Pure) Themes and Apps] DJTeeJay:
And what ROM might u be on?
[X Style (Pure) Themes and Apps] JackieBrown:
Resurrection
[X Style (Pure) Themes and Apps] gchase23:
NVM
[X Style (Pure) Themes and Apps] namartlu:
For camera app, it installs and works except quick capture won't work.... I'm on TruPure X.
[X Style (Pure) Themes and Apps] lk2race:
Stock moto x pure and could not get the camera app to install
[X Style (Pure) Themes and Apps] Deleted member 6284772:
Moto G4 Camera App Mod

Hi Guys,

I have been using Apktool for the first time today and have managed to get the professional mode working on the stock moto x style rom (marshmallow 6.0.1, 1 may 2016 patch level) without root and have also managed to enable the debug menu option i.e. what was the ladybug button in the old version app.

I have uploaded the new version of the apk to google drive for anybody that wants to give it a try.

If anybody wants to look at what has been updated I only modified three files (AndroidManifest.xml, \res\raw\app_features.json and \smali\com\motorola\camera\Util.smali) so if you decompile the original apk (standalone) and the new version I have created you will quickly see what has been changed.

p.s. When I updated the app_features.json file I added in device codes for the moto x style (clark), moto x play(lux) and moto g 2015 (osprey) so a wide group of people could try the mod but I have only tested it on the moto x style as that is the device i own.

UPDATE:

See post #29 for a more up-to-date apk http://xdaforums.com/showpost.php?p=67863180&postcount=29
[X Style (Pure) Themes and Apps] churapa:
[MENTION=6284772]data365[/MENTION] Your mod worked perfectly! I just installed it as normal apk. Thanks.
[X Style (Pure) Themes and Apps] amanjeet@msn.com:
worked well

Thanks friend this app worked like a charm Thanks once again
[X Style (Pure) Themes and Apps] HPAR:
I can't save to external SD card.
[X Style (Pure) Themes and Apps] churapa:
Nobody can, at least for now!
[X Style (Pure) Themes and Apps] AsquareX:
This worked perfectly. Thanks! :good:
[X Style (Pure) Themes and Apps] 12paq:
Dude! As a photographer this is huge for me. Great work. Nice to have the manual settings.

Working on rooted DU's latest test ver.

You should open your own thread.
[X Style (Pure) Themes and Apps] namartlu:
for those with the camera working, do you use quick-capture (double-twist your wrist to launch camera)? I couldn't get it to work, the settings turns off by itself.
[X Style (Pure) Themes and Apps] donrojo:
This is how i installed gallery apk since normal install was not working on CM13 MXPE 2015:

- deleted gallery that came with cm13

- created a new folder at /system/priv-app (i called it Moto Gallery)

- placed apk inside the new folder

- reboot the phone

- (icon will show on app drawer but when opening the app it will show only pictures but with no options, settings etc)

- return to the system folder created in the beginning

- install apk by clicking on it

That's it! Fully functional gallery. Take a picture and slide the right side of the screen inward. A bottom drawer will ask you to open pictures with gallery. Choose always!

I also set Moto G4 camera as default camera and not out works with twist gesture!

Once again, I'm on official CM13 nightlies 07/20 on MXPE 2015.
[X Style (Pure) Themes and Apps] namartlu:
Sorry, you mean works or not work with twist gesture?
[X Style (Pure) Themes and Apps] dj_ooms:
Hi data365,

First, I just want to say a big thank you for the app. The professional mode works perfectly on my custom stock 6.0.1 ROM with the May patch. I also have quick launch work using Xposed and the Twisty Switch beta module. The camera launches as normal with a double twist gesture though the stock camera needs to still be there for it to work. I just have one question though. You have stated that the debug menu has been enabled but I don't seem to have the option in my app. Did you have to edit your build.prop for to enable the option? I have the Moto CheckBox Xposed module and this seems to work with the stock camera only as I have the ladybug button in there. I had tried the normal G4 camera zip file installed through TWRP on the Pure Nexus ROM and this has the debug menu and I had to edit the device name in the build.prop file to enable the professional mode. The twist gesture worked perfectly on that ROM as it was built in. I really liked the Pure Nexus ROM it's just the battery life was killing it literally; my phone wasn't even lasting a day due to the poor mobile reception in my house draining the battery. If you could provide any information or help on the debug option, this would be really appreciated.

Thanks,

Ooms
[X Style (Pure) Themes and Apps] :
Hi Ooms,

No I did not edit my build.prop file because I don’t have root access, i edited how the code works when reading the ro.bulid.tags value. i.e. the "\smali\com\motorola\camera\Util.smali" update

The original code enabled the debug menu when the ro.bulid.tags value was set to "test-keys" but the stock build.prop file has the ro.bulid.tags value set to "release-keys" so I updated the code to enable the debug menu when the ro.bulid.tags value has been set to "release-keys" simple!

I don’t know how the Moto CheckBox Xposed module works so can not comment on why it is not working with that module in place.

I have been trying to get the latest version of the app (6.0.24.9) working but have not had any success yet, I always get a message back saying "Device not supported" :(, between version 6.0.20.6 and 6.0.24.9 there have been lots of changes so its not easy to track why I’m getting this message although I have found where the message is being triggered.

---------- Post added at 12:53 AM ---------- Previous post was at 12:02 AM ----------

Hi Guys,

I've just created a new version of the app with two more code names added to the "\res\raw\app_features.json" file (kinzie and otus) so professional mode should now be accessible on more devices.

i don't now how i managed to get links into my first post as i now getting a message saying i have to post ten times before this is allowed :confused: anyway you guys will just need to remove the white space from this link...

See post #29 for a most up-to-date apk http://xdaforums.com/showpost.php?p=67863180&postcount=29
[X Style (Pure) Themes and Apps] churapa:
[MENTION=6284772]data365[/MENTION] Here is the link,

I edited your post with the link for you and anybody who may wanna use it.

Again, thanks for all your hard work. :good:
[X Style (Pure) Themes and Apps] dj_ooms:
Thank you very much data365. I had a look at my ro.build.tags value and it was set as test-keys. I tried to change it to change it to release-keys but the result is the same; I do not have any option for debug menu. Is there possibly anything else that is being looked up? I may have to resort to installing a full stock ROM and trying to get it working from there. I have a feeling the build.prop file may have been modified more than just the ro.build.tags line which may be causing the issue. Out of curiosity, would it be possible to post a copy of your build.prop file so I can make a comparison to see what else might be different?

Thank you for all your hard work.

Ooms

P.S. I have tried your second release too and still have the same issue.
[X Style (Pure) Themes and Apps] :
No problem https: // drive.google.com/open?id=0BzN_CG03Ba9WOWVnU0ZTRzBMcGc
[X Style (Pure) Themes and Apps] donrojo:
It works, at least with cm13 twist gesture.
[X Style (Pure) Themes and Apps] dj_ooms:
Thanks data365. There is a definite difference between the build.prop lines on your stock ROM and my custom ROM. It tried to replace the build.prop to see if it made a difference. I still didn't have a debug menu option. As a last resort, I decided to try a full stock unrooted ROM to see if your app worked. Unfortunately, I still didn't have the debug menu. I have now gone back to my custom ROM. I am happy the professional mode is working and I am grateful for your hard work on this. I would have preferred to have the debug menu but I can't figure out why it doesn't work. The camera takes decent pictures as it is. It would have been nice to be able to tweak some settings further but I can live with the app as it is. Hopefully you will be able to continue your work and give us updated versions of the app. in the future

Thanks again,

Ooms
[X Style (Pure) Themes and Apps] :
I got version 6.0.24.9 working today and have been looking more into how the debug menu is displayed and think I might have found your problem.

The code checks the device root status using the qe e-fuse status and disables the debug menu if your e-fuse has a setting of qe 1/1

I have made modifications to the code to get around this as well as removing the read of the ro.bulid.tags setting so you might have more luck this time around.

https://drive.google.com/file/d/0BzN_CG03Ba9WRm1ZaU1sZTV0SWs/view?usp=drivesdk

I say "might" because the code also has a check to make sure the device is secure (I need to check how this is working) before this menu option can be displayed so that might also be the root of your problem and would be a much bigger change to the code that i don't even want to think about as updating smali code is a nightmare.
[X Style (Pure) Themes and Apps] dj_ooms:
Brilliant work data365. :good: Just tested your new app and it is working perfectly. I now have access to the debug menu. :victory:

I think the e-fuse is probably triggered when you unlock the bootloader which may explain why your previous builds did not work even on a stock unrooted ROM. When I flashed the stock ROM, I did not lock the bootloader, which may also be why the debug menu did not work. I suspect though that locking it would not have made any difference. It may explain why on previous stock ROMs (5.1.1 and 6.0), I could not get the ladybug debug menu on the original stock camera app. The only way I could get it was by using the MotoCheck Xposed module, which probably works around the coding for the checks. The MotoCheck module is quite old though which may mean it does not work on the new Moto phone models of 2016 and any ported apps.

I really appreciate all the time, effort and hard work you have put into this. Once again, many thanks for everything. I hope you continue to release new versions when the app gets updated, as I can only expect the camera to improve with every update, no matter how minimal it may be.

Thanks,

Ooms
[X Style (Pure) Themes and Apps] r3sidual:
Use Twisty Switch via Xposed to get the new camera app to work. It works perfectly on my X 2014
[X Style (Pure) Themes and Apps] churapa:
[MENTION=6284772]data365[/MENTION] Have you been able to find a way to save pictures to external memory in your modded camera?
[X Style (Pure) Themes and Apps] dj_ooms:
Saving to external memory works on the stock based ROMs. It's only on AOSP ROMs that you can only save to internal. I had the same issue when running the Pure Nexus ROM.
[X Style (Pure) Themes and Apps] :
I'm happy to enable options that are already in the app once I find out how it has been disabled but I'm not about to debug and fix code that I have not written myself, I do that every day at work so like to switch off when I get home.

I also have no plans to unlock the boot loader so I can install another ROM on my phone at least until the start of November when my warranty runs out so until then I would be guessing what the problem is.

Lenovo/ Motorola don't seem to update this app to often so I don't expect I will have to make these updates again for a few months.
[X Style (Pure) Themes and Apps] DrunkUncas:
Camera APK wouldn't install

TruPureXMM 2.9

And the camera links are labeled backwards. Haven't tried to install via zip yet
[X Style (Pure) Themes and Apps] dboombuki:
Hey thanks for the apps. I got the to work and install. But the clock widget is small not sure if anyone else is having this problem but I can't get it bigger.
[X Style (Pure) Themes and Apps] Aodrulez:
The download link you provided has expired it seems. Can you kindly re-upload the apk? Thanks in advance.
[X Style (Pure) Themes and Apps] :
I'm not sure what links you are referring to as I've just checked all of the links from the OP and the latest link i gave and all appear to be working.

OP link: http://www.droidviews.com/enjoy-moto-g4-apps-motorola-device/

Link from post #29 https://drive.google.com/file/d/0BzN_CG03Ba9WRm1ZaU1sZTV0SWs/view?usp=drivesdk
[X Style (Pure) Themes and Apps] churapa:
I found the way to save pictures to external memory (External SD card) using the MotoG4 camera apk modded by [MENTION=6284772]data365[/MENTION] (thanks again for the mod).

1.- In /data/system

look for packages.xml

In there, look for com.motorola.camera1

2.- Add

<item name="android.permission.WRITE_MEDIA_STORAGE" granted="true" flags="0" />

Right after <perms>

3.- Save and Reboot
[X Style (Pure) Themes and Apps] Rotondo:
works professional mode?:eek:
[X Style (Pure) Themes and Apps] churapa:
Yes, Professional Mode, Debug and Save to External Memory (performing the steps I pointed out in my last post).
[X Style (Pure) Themes and Apps] Moppusan:
I'm coming from an LG G2 (my MXP should be arriving around Wednesday). How do the pictures compare to stock camera app? With the G2, the stock camera app on a stock-based ROM would give the best quality, everything else was...useful but kinda meh. Not that the G2 had a good camera in the first place *cough*grain-grain-grain-lowlightespecially-grain*cough*
[X Style (Pure) Themes and Apps] ilovemeow:
thanks for sharing,

but after you tune the iso/shutter speed,

is there any change from the EXIF of the photo?

coz for mine mxpe, wband focus working fine

but iso and shutter speed not changing
[X Style (Pure) Themes and Apps] :
on my moto x style (running stock 6.0.1 with may security patch) the iso setting works and you can see the difference in the preview and EXIF details but the shutter speed setting does not do anything.
[X Style (Pure) Themes and Apps] ilovemeow:
Thanks for reply

Wondering did you patch the lib or using original lib?

Or might be is version issue

I'm currently running 6.0
[X Style (Pure) Themes and Apps] :
I'm using the original lib so i guess it might work once you get onto 6.0.1 or later...

---------- Post added at 06:01 PM ---------- Previous post was at 05:40 PM ----------

Do the iso settings work for you in other apps like a better camera? I just remembered that at some point trying to change iso caused apps to crash but now works fine on my phone
[X Style (Pure) Themes and Apps] ilovemeow:
even using freed cam is not working, might be work 6.0.1+ only
[X Style (Pure) Themes and Apps] ilovemeow:
just update to 601

iso work onlyand changed to

125/250/640

and mine dont have iso3200 lol but not big deal
[X Style (Pure) Themes and Apps] :
Good to know you have got something working :good:

I was checking through the code last night and think I found the reason why the shutter speed setting does not work on the moto x style, The app attempts to set a camera parameter called "exposure_time" but this parameter appears to be missing on the style.

I'm going to have a look through these files to see if I can understand why it is missing.
[X Style (Pure) Themes and Apps] ilovemeow:
omg where did you found those parameter?

btw: and remind all user which has os6.0.1

i've got crash after do libchange, not sure only my problem or not, just becarful when doing libchange on 601, was work fine in 6.0
[X Style (Pure) Themes and Apps] :
I have been running the code in a debug mode using android studio so i can see whats happening and can see lots of parameters you would not normally see.

I have been doing this a bit more this afternoon and it looks like the "exposure_time" parameter is being created and set as the app is stated and not read in and set at a more global (maybe hardware) level as i can see with the "iso" parameter.

If you want see all of the parameters I'm talking about you can download "Camera Parameters" from the play store as this appears to show the same info i can see in android studio
[X Style (Pure) Themes and Apps] :
looking at both the Googles ASOP source code and the CyanogenMod source code i can see that the setExposureTime method (line 6341 in the files linked below) is only ever called when the "exposure-time" parameter is updated and it never initially set around lines 5028 to 5046 as i would expect and can be seen happening for the “iso” parameter at line 5026

https://android.googlesource.com/pl...a/+/master/QCamera2/HAL/QCameraParameters.cpp

https://github.com/CyanogenMod/andr...ob/cm-13.0/QCamera2/HAL/QCameraParameters.cpp

I can not say 100% that this is the cause of the problem but it looks suspicious to me and if I was developing a custom rom it would be the first thing I would try to get this fixed.
[X Style (Pure) Themes and Apps] ilovemeow:
thanks mate

im not a dev, and im only the beginner android studio learner

thanks for you kindly explanation[emoji2]

will have a look for that app your mention

---------- Post added at 09:06 AM ---------- Previous post was at 09:04 AM ----------

but any chance can this be fix in stock Rom? or custom kernel?
[X Style (Pure) Themes and Apps] mex2309:
Thanks for this. My wife has the G4 and I like her camera better. It had a shutter button :)

So for on my Pure X the G4 camera works pretty great. Has anyone found anything it doesn't do compared to the stock?

Also, how do you set the G4 one as DEFAULT so the wrist action works?

The gallery .apk i found was to be the same as stock. I think the one thing on the Pure X were a highlight reels feature. So I'm sticking with the old one.
[X Style (Pure) Themes and Apps] kbsarfaraz:
Time and widget are not in the circle dot
[X Style (Pure) Themes and Apps] :
I think this would need to be a rom level update as it has nothing to do with the kernel.

It would be nice to know if they bug is also present in the phones that can download this app from the play store unmodified ,mex2309 as you said your wife has a G4 can you confirm if the shutter speed setting actually works on the stock app?

If it is working can you also install "Camera Parameters" from the play store and see if you can see a parameter called "exposure_time", this should confirm my suspicion that this parameter needs to be setup at a more global level before the camera app is loaded.

If its working and you can not see the "exposure_time" parameter my suspicion is unfounded and i have no clue to why this setting is not working on the moto style.
[X Style (Pure) Themes and Apps] ilovemeow:
thanks

and I found the max exposure time for both camera

Motorola XT1572

max-exposure-time = 657.770600

max-iso = 6339

min-exposure-time = 0.016733

min-iso = 50

picture-format-values = jpeg

picture-size = 5344x3006

picture-size-values = 5344x4008,5344x3006,4160x3120,4320x2432,4160x2340,3840x2160,3264x2448,3264x1836,2592x1944,2592x1458,1920x1080,1440x1080,1280x960,1280x720,640x480,352x288,320x240

qc-max-num-requested-faces = 32

raw-size = 5344x4016

video-size-values = 3840x2160,1920x1080,1280x720,864x480,720x480,640x480,352x288,320x240,176x144

whitebalance = auto

whitebalance-values = auto,incandescent,fluorescent,daylight,cloudy-daylight

zoom-supported = true

zsl = on

zsl-hdr-supported = true

zsl-values = off,on
[X Style (Pure) Themes and Apps] gavsi:
thanks thanks thanks

dude plaese make 60fps 1080p video ..in modedapk :cowboy::p

maybe this file work
[X Style (Pure) Themes and Apps] quakeaz:
Moto File Manager is now on Google Play, downloadable for the Moto X.

https://play.google.com/store/apps/details?id=com.lenovo.FileBrowser2
[X Style (Pure) Themes and Apps] AlphaKilo09:
Says 'App not installed!'

Hello DjTeeJay!

I tried installing the apk file of moto camera app from your link on my Moto X Style(XT1572). It says app not installed after installing through package installer.
[X Style (Pure) Themes and Apps] AlphaKilo09:
Thanks!
[X Style (Pure) Themes and Apps] AlphaKilo09:
It worked ! Thanks!!

Installation successfull on Moto X Style (XT1572) Stock! 6.0 [No root]
[X Style (Pure) Themes and Apps] DJTeeJay:
I believe there is an updated version in play store. I have a MXP XT-1575 which the apk worked fine.
[X Style (Pure) Themes and Apps] AlphaKilo09:
I will check with that in Play Store!
[X Style (Pure) Themes and Apps] Lupask:
those apk's are not available anymore on the original link :(
[X Style (Pure) Themes and Apps] ghitus:
+1
[X Style (Pure) Themes and Apps] Highlanderix:
Thank you for your work data365 !!

I tried installing the app from #29 on my new Moto X Style XT1572 and it installed fine. I have access to the debug menu and professional mode but in professional mode, changing ISO or shutter speed doesn't do anything. I did 3 patches one after the other and I now have the september patch and Android 6.0 (not 6.0.1). Could this be the reason ? Thank you for your help !

P.S. : also, do you get better photos when using this app ? did someone did a comparison ? Thanks
[X Style (Pure) Themes and Apps] GeneClwtr:
write perms not working

This line was already present in my packages.xml but does not allow for camera writing to SD card. Any thoughts?
[X Style (Pure) Themes and Apps] noisufnoc:
i'm having a similar problem, running LinageOS on Moto X clark, the packages.xml gets overwritten on reboot.