yashsingh1/xdaforums huggingface dataset:
[OnePlus 3 Themes, Apps, and Mods] matssa:
Well if it is correctly defined, explained and transparent, this can be used by other cameras so I don't think it will be given... Just like the dash stuff, this is OnePlus knowledge and work, not common stuff.
[OnePlus 3 Themes, Apps, and Mods] Racpu_:
Better camera on last CM13..:D

AUTO MODE

CM 13 day 31/07/2016

http://imgur.com/lqrJnhY

CM13 day 02/08/2016

http://imgur.com/RoUTgBK
[OnePlus 3 Themes, Apps, and Mods] EnormoDerClown:
I dont really see a difference there. Mainly i think it looks different because the sun shines in a different way
[OnePlus 3 Themes, Apps, and Mods] AcmE85:
If you download the images in full resolution, you can clearly see the difference in noise!

[IMG="Full resolution 100% crops"]https://abload.de/img/crop2turv.png[/IMG]
[OnePlus 3 Themes, Apps, and Mods] EnormoDerClown:
Indeed in your new pictures you can see a difference with the leafs. Thanks
[OnePlus 3 Themes, Apps, and Mods] quini2k:
Hi! Thanks for your port!

I get a fc when trying to change aspect ratio from default 4:3 (I'd like 16:9), 1.2 version.

Quini OP3
[OnePlus 3 Themes, Apps, and Mods] angelcoquito:
Which camera is this ? v1.2?
[OnePlus 3 Themes, Apps, and Mods] EggZenBeanz:
Great project and interesting thread. Looking forward to ditching OOS as soon as the CM quality is comparable
[OnePlus 3 Themes, Apps, and Mods] AcmE85:
The fact that you quoted my post shows me that you did not read!

The answer was right on the same page

Please read the thread before posting!

These pictures were not taken with this port,

but with snap on the last two cm13 nightlies to show the progress cm is making in improving the camera performance for custom Roms.

Please keep that in mind when browsing other threads in the future.
[OnePlus 3 Themes, Apps, and Mods] angelcoquito:
I know :)

I was hoping that out of a beta , and reads from # 19
[OnePlus 3 Themes, Apps, and Mods] boober78:
I get fc when trying to switch to video or manual focusing.
[OnePlus 3 Themes, Apps, and Mods] hurray:
Yes, we try to fix this over the last 5 pages. ;)

If you use the latest test version you are able to switch between the modes but manual focusing still give a FC.

We have to wait and see how the progression with CM13 on the camera implementation goes on.
[OnePlus 3 Themes, Apps, and Mods] iNickMe:
fc when i try touch focus :s
[OnePlus 3 Themes, Apps, and Mods] Signor Rossi:
LoL, read above

Gesendet von meinem OnePlus 3
[OnePlus 3 Themes, Apps, and Mods] AcmE85:
[MENTION=5279101]ghbuur[/MENTION]

Today's cm13 nightly will include the mentioned commit which enables OP3 camera modes on the Snap camera app.

https://review.cyanogenmod.org/#/c/154668/

So it seems that all camera related files which make the postprocessing work are already included into cm13.

There are also these two focus related commits:

http://review.cyanogenmod.org/#/c/155141/

http://review.cyanogenmod.org/#/c/155150/

I'm not sure how this might help the port though :(
[OnePlus 3 Themes, Apps, and Mods] matssa:
I thought there were touch focus issues even with other apps, maybe this will help? Can't really tell though, we will be able to test it out in the next nightly :)
[OnePlus 3 Themes, Apps, and Mods] AcmE85:
Although the commit description specifically mentions "snap",

the changed code is applied to the system:

src/com/android/camera/PhotoModule.java

src/com/android/camera/FocusOverlayManager.java

Might indeed work for more than only snap. Fingers crossed
[OnePlus 3 Themes, Apps, and Mods] matssa:
True, that is what I saw last time, specially the comment from Steve. This doesn't prove that it will make the other apps work but can still be a promising lead. Thanks to Steve for his work :)
[OnePlus 3 Themes, Apps, and Mods] matze19999:
Any updates? [MENTION=5279101]ghbuur[/MENTION]
[OnePlus 3 Themes, Apps, and Mods] srt10coupe:
crashes when switching from mode

java.lang.UnsatisfiedLinkError: dalvik.system.PathClassLoader[DexPathList[[zip file "/system/priv-app/OnePlusCamera/OnePlusCamera.apk"],nativeLibraryDirectories=[/system/priv-app/OnePlusCamera/lib/arm64, /system/priv-app/OnePlusCamera/OnePlusCamera.apk!/lib/arm64-v8a, /vendor/lib64, /system/lib64]]] couldn't find "libopcameralib.so"

at java.lang.Runtime.loadLibrary(Runtime.java:367)

at java.lang.System.loadLibrary(System.java:1076)

at com.oneplus.camera.media.YuvUtils.<clinit>(YuvUtils.java:14)

at com.oneplus.camera.CameraImpl.onPreviewFrameReceived(CameraImpl.java:2225)

at com.oneplus.camera.CameraImpl.access$1100(CameraImpl.java:52)

at com.oneplus.camera.CameraImpl$5.onImageAvailable(CameraImpl.java:232)

at android.media.ImageReader$ListenerHandler.handleMessage(ImageReader.java:648)

at android.os.Handler.dispatchMessage(Handler.java:102)

at android.os.Looper.loop(Looper.java:148)

at com.oneplus.base.BaseThread.run(BaseThread.java:377)
[OnePlus 3 Themes, Apps, and Mods] matze19999:
already fixed:

https://www.dropbox.com/sh/rrfwcxpwjxt87ru/AAB5RaFEmZpsLR9T5aZBG43-a?dl=0
[OnePlus 3 Themes, Apps, and Mods] srt10coupe:
oneplus 3 cm 13 (latest)

use this file: "new cm test 4.zip" or "test with hal 7.zip"?

which is the latest (stable) version?
[OnePlus 3 Themes, Apps, and Mods] matze19999:
new cm test 4.zip

please look at the upload date
[OnePlus 3 Themes, Apps, and Mods] beelzebu:
Hope to get touch FC sorted, I really like this camera. much better than cm stock. I'm willing to test new releases of this port.
[OnePlus 3 Themes, Apps, and Mods] Konskl:
Is the development of the camera still WIP or project's dead?
[OnePlus 3 Themes, Apps, and Mods] cohaolain:
Really hope it's still ongoing anyway :eek:
[OnePlus 3 Themes, Apps, and Mods] EnormoDerClown:
I think the developer waits for CM at the moment, they made a lot of improvements on the way "how the camera works" within the OnePlus 3 and they are ongoing with that. I think the developer hopes a lot will be fixed by that, like it also happend a few times until now. Steve Kondik made some interesting posts on his work and he said a lot will change.
[OnePlus 3 Themes, Apps, and Mods] cohaolain:
Could you link those posts?
[OnePlus 3 Themes, Apps, and Mods] ghbuur:
exactly ;) like it was on OP2 too...
[OnePlus 3 Themes, Apps, and Mods] srpayo:
Tried the v1.2 with Resurrection Remix and it crashes on slowmo, panorama, video, timelapse, manual...basically anything apart from just taking a picture which is fine. Hope that you'll manage to port it fully at some point. This and the fact that Android Pay doesn't work is making me reconsider going back to stock as I really liked the slowmo and timelapse features of the stock camera and I was using NFC to pay on my tube journeys every day which was pretty convenient.

Thanks for porting it though. Keep up the good work! I'll check back in the next few weeks! I flashed it via TWRP and tried all the zip files you provided so far.
[OnePlus 3 Themes, Apps, and Mods] EnormoDerClown:
1.2 is old, use the versions from the dropbox
[OnePlus 3 Themes, Apps, and Mods] srpayo:
cool thanks for the hint mate, got the "new cm test 4.zip" and re-checked it. Everything works now apart from manual focus and panorama which is what I've read in previous posts. Awesome!
[OnePlus 3 Themes, Apps, and Mods] Eagle-no1:
Version 1.4 does not change the aspect ratio of 16: 9, only completely stop the camera program :crying: . I use Resurrection Rom latest version 5.7.3
[OnePlus 3 Themes, Apps, and Mods] cohaolain:
Works fine on 20160812 cyanogen nightly, must be a resurrection remix camera bug. They mightn't have included all the camera blobs and such that were added in commits the last while.

Just guessing, don't hate if I'm wrong ;) was on RR before anyway
[OnePlus 3 Themes, Apps, and Mods] Eagle-no1:
No stock rom and back to stock ROM :cyclops::D:laugh:
[OnePlus 3 Themes, Apps, and Mods] VVMM:
New test 4 and cm build 20160814 crashes when I tap on the camera screen.
[OnePlus 3 Themes, Apps, and Mods] seniorstew:
Auto HDR would be great if you can find a way to enable it ?
[OnePlus 3 Themes, Apps, and Mods] ravishmahur:
Only thing holding me back from switching to a custom rom is the stock oos camera, I hope this mod soon becomes perfect so that people like me can easily switch and try other custom roms out there :)
[OnePlus 3 Themes, Apps, and Mods] jeturbo820:
Manual focus still crashing with RR.
[OnePlus 3 Themes, Apps, and Mods] tibby87:
Agreed. I would miss the manual functions like changing the shutter speed. Non of the 3rd party apps provide that (at least not for the OP3). I really want to use a custom ROM, but it's a deal breaker for me. :crying:
[OnePlus 3 Themes, Apps, and Mods] GeneralDisaray2:
My thoughts exactly.
[OnePlus 3 Themes, Apps, and Mods] badtzo:
Are you sure? I'm using manual camera and it works with ISO, shuter's speed , WB and focus.
[OnePlus 3 Themes, Apps, and Mods] tibby87:
You are right! I've tried a lot of camera apps, but I missed this one. Now I tried it, and it really works! :D Thank you! :good:

Although it still has a few minor downsides compared to the stock app, like the max. shutter speed is only 10 secs instead of 30 (sometimes I like to photo the starry sky, so 30 is needed in that case), and it's only a photo app, there's no video recording in it.

But this one is definitely the best 3rd party photo app so far!
[OnePlus 3 Themes, Apps, and Mods] kanth1991:
Hello , i would like please to ask if there were any improvements eventually with CM 13 regarding the camera especially now that they published a Snapshot build...

Cheers!
[OnePlus 3 Themes, Apps, and Mods] GeneralDisaray2:
Still on nightlys for OP3. Snapshot was never released for OP3.
[OnePlus 3 Themes, Apps, and Mods] S4turno:
cm-13.0-20160817-SNAPSHOT-ZNH5YAO0GF-oneplus3.zip (492.81 MB)

http://get.cm/?device=oneplus3&type=snapshot
[OnePlus 3 Themes, Apps, and Mods] EnormoDerClown:
Normally a Snapshot does not give you more features, nightlys are newer. A Snapshot is a more stable build => older commits (which could be tested more) are in use. So the Snapshot won´t give you a better camera. All in all you can say the camera is getting better, in daylight the photos are really good, i haven´t used it in the dark for now but there it shall be quite poor. Maybe this summary also helps you
[OnePlus 3 Themes, Apps, and Mods] GeneralDisaray2:
Nightly's are ahead of Snapshot...Snapshot is stable release. Nightly is experimental...makes no difference for the camera quality.
[OnePlus 3 Themes, Apps, and Mods] S4turno:
I know. You said that a "Snapshot was never released for OP3", which is not true, so I linked to the snapshot released by CM. That's all.
[OnePlus 3 Themes, Apps, and Mods] nhugh406:
Maybe a noob question, but I've not been able to find an answer via searching. After installing this port on CM snapshot, I click the shutter button, and nothing happens..no photo, nothing. All permissions have been granted. What am I missing??
[OnePlus 3 Themes, Apps, and Mods] tdamocles:
Try manual camera a little more.. Shutter speed is a little buggy.
[OnePlus 3 Themes, Apps, and Mods] Supranoob:
I'm on arter97's cm13 build and tried out the cm test 4 and the camera works well except for it crashing when tapping on photo box.
[OnePlus 3 Themes, Apps, and Mods] ritchiedrama:
If I want to take a camera from a new nightly, and put it on an old nightly version, how can I do that?

I use an old version of CM (0802) and want to take the latest camera as it's better.

Thanks
[OnePlus 3 Themes, Apps, and Mods] anhtin:
I installed it on PureCM but it crashes a lot. Only the Gallery app is working fine.
[OnePlus 3 Themes, Apps, and Mods] matze19999:
Can you please take a look at Sultan's cyanogenmod thread?

He modified the camera hal, I thought it could help you :)
[OnePlus 3 Themes, Apps, and Mods] Kipp162:
Also tried on PureCM and it just crashes every time you tap on the screen to focus.
[OnePlus 3 Themes, Apps, and Mods] philidor:
[MENTION=5279101]ghbuur[/MENTION] on OP2 forum you make a CM version and a AOSP version. Here I have found only CM version. If I want to try on an AOSP ROM (exodus) with version I have to flash for start?
[OnePlus 3 Themes, Apps, and Mods] tatuboy:
can i port this in RR ROM?
[OnePlus 3 Themes, Apps, and Mods] laupuy:
Yes (read op) ;)
[OnePlus 3 Themes, Apps, and Mods] fuarkgl3:
Is it fully working? Post-processing working? Im still sick of OOS rom just because of camera. But snap camera is horrible...
[OnePlus 3 Themes, Apps, and Mods] beelzebu:
I'm using it on asp rom DU, and there is no fc on focus!!, everything working as it should. Thx!!
[OnePlus 3 Themes, Apps, and Mods] locotion:
No FC on sultanxda cm Version also, but Flash is activated at the wrong time in dark Environment

Gesendet von meinem ONEPLUS A3003 mit Tapatalk
[OnePlus 3 Themes, Apps, and Mods] seniorstew:
Does it include auto Hdr? And its a aosp rom right?
[OnePlus 3 Themes, Apps, and Mods] beelzebu:
It doesn't have HDR mode at all. It is AOSP rom with CM kernel
[OnePlus 3 Themes, Apps, and Mods] seniorstew:
I'm talking about the Camera port
[OnePlus 3 Themes, Apps, and Mods] beelzebu:
The port is taken from original app from oos
[OnePlus 3 Themes, Apps, and Mods] seniorstew:
So just to confirm, you where able to install the port in a aosp rom with everything working including Auto Hdr?
[OnePlus 3 Themes, Apps, and Mods] beelzebu:
Thats's right everything working except HDR.
[OnePlus 3 Themes, Apps, and Mods] seniorstew:
Boo guess I shall keep waiting.. Would you happen to have a link to the rom your talking about? Thanks!
[OnePlus 3 Themes, Apps, and Mods] beelzebu:
Here you go.

http://xdaforums.com/oneplus-3/development/rom-tweet-1-dirty-unicorns-10-4-t3426739
[OnePlus 3 Themes, Apps, and Mods] cameron1292:
I can confirm it's working perfect on sultans latest cm release. No fc in anything. Picture quality is still up in the air. I'll post some in a bit
[OnePlus 3 Themes, Apps, and Mods] matssa:
Ok thanks, don't understand why there is such a difference between sultancm and official cm. [MENTION=5091734]dianlujitao[/MENTION], any thoughts?
[OnePlus 3 Themes, Apps, and Mods] cameron1292:
The same zip file didn't run smoothly on resurrection either. I've used that for the last month. Decided to switch over with the promise of a better stock camera so I went with it
[OnePlus 3 Themes, Apps, and Mods] matssa:
Yeah but since sultan is based on CM, I would like to know where is the difference in order to know if we can use it on the official CM
[OnePlus 3 Themes, Apps, and Mods] cameron1292:
In his newest build he talks about the updated Hal and processes so I'd say that's the key
[OnePlus 3 Themes, Apps, and Mods] matssa:
Aaaah need to take a look tomorrow. If indeed the HAL has been updated using the one from OOS then CM won't do it since they use their own camera HAL i think.
[OnePlus 3 Themes, Apps, and Mods] cameron1292:
First one is cm camera. It's noticeably sharper. Almost too sharp? And the file seize is 8.5 where the op camera is only 2 something.
[OnePlus 3 Themes, Apps, and Mods] laupuy:
Thank you for the info, which version do you have installed, the v1.2 in op?
[OnePlus 3 Themes, Apps, and Mods] cameron1292:
No the newest build he posted a few pages back. Cm build 4 I think
[OnePlus 3 Themes, Apps, and Mods] matssa:
Ok I just switched to sultan CM ROM, gonna test out the camera. I hope it will be better, I tested Snap and the photos are captured a lot faster than on official CM so first good point :)
[OnePlus 3 Themes, Apps, and Mods] cameron1292:
A little advise on his build. He underclocked it a good amount. I think it's at like 1400 something max. Where the kernal is capable of like 2100 or 2400 not sure. I did get some stuttering when waking the phone up once in awhile and it wasn't due to greenify so I boosted the speed up and that fixed it. Still go great battery. Currently on 14 hours battery and at 40 percent.
[OnePlus 3 Themes, Apps, and Mods] dianlujitao:
He has his own device/kernel branches
[OnePlus 3 Themes, Apps, and Mods] cohaolain:
Can confirm the port doesn't force close on Sultanxda's CM13 with the custom HAL.

Bugs that are still a problem:

Slow motion just doesn't work. Records video normally and plays it back slowly at about 7.5fps.

No HDR.

Flash problems.

Video stabilisation.

Fixed in Sultan:

Force close on manual touch to focus

Fingers crossed this moves along with the sultan development possibly providing a workaround maybe for the force close and some further work on everything else :)
[OnePlus 3 Themes, Apps, and Mods] matssa:
Yeah figured that out, but wanted to know if it was possible to merge the camera stuff in the official CM tree in order to help out all the community in one big batch. Don't see why it can't be done, I don't think sultan will be angry bout it if we put his name :)

---------- Post added at 06:45 AM ---------- Previous post was at 06:42 AM ----------

Yeah I saw that there was some severe underclocking, I might flash the zip to remove it though, I find the phone quite slow when rebooting and at some times.
[OnePlus 3 Themes, Apps, and Mods] dianlujitao:
I don't see any camera related stuff in his branch
[OnePlus 3 Themes, Apps, and Mods] matssa:
Oh, that's strange... Gonna have to take a better look in his branch when I have the time.

EDIT/// When looking into his manifest, I can see that the camera can be in one of these three branches

<project path="packages/apps/Snap" name="sultanxda/android_packages_apps_Snap" revision="oneplus3/cm-13.0-sultan" />

<project path="vendor/oneplus" name="sultanxda/proprietary_vendor_oneplus" revision="cm-13.0-sultan" />

<project path="device/oneplus/oneplus3" name="sultanxda/android_device_oneplus_oneplus3" revision="cm-13.0-sultan" />

Not sure if it can also be in the oppo common...

EDIT 2 /// Ok found this : https://github.com/sultanxda/propri...ce00bae#diff-fcdb8a02764271be19a35bfd3ee4ae0c , might help, gonna take a look in other other ones.

EDIT 3 /// There is also the custom Snap camera app stuff that should help, but needs to be dig out since it is only specific to that app, I think that the custom HAL is the one that we need for this port to work. The snap changes should change the quality of the photos in the app though, so good to be taken as well :)

I can't help out more than this since I don't have enough knowledge in the field, might just break everything ^^ So yeah, I hope you will be able to make your magic work [MENTION=5091734]dianlujitao[/MENTION] :D
[OnePlus 3 Themes, Apps, and Mods] dianlujitao:
He might built the camera hal based on source from oneplusoss, but according to Steve (http://review.cyanogenmod.org/#/c/154668/) there're oneplus proprietary enhancements in stock camera hal. And photo quality can be changed to 100% even in official CM Snap
[OnePlus 3 Themes, Apps, and Mods] matssa:
True for the 100% in the snap app, but isn't there a chance that there was some internal modifications other than the percentage? For the camera HAL, I saw that commit and the justifications, but I can't understand why we get some touch FCs with the stock camera HAL and no FCs with the custom one, isn't there a way to get this fix in the stock camera HAL in order to have one big custom HAL? :D The biggest fear is when the camera HAL get's updated, even though the source code is opensource.
[OnePlus 3 Themes, Apps, and Mods] dianlujitao:
Interesting, how could camera HAL cause FCs, can you tell how to reproduce?

p.s. the oss camera hal is incomplete, or it's different from the commercial one.
[OnePlus 3 Themes, Apps, and Mods] matssa:
Ah OK so this explains it... For the FCs, flash the latest file from this port on your CM ROM and try using the stock OOS app. When touching the screen for focus, we get a FC of the app. With the custom HAL from sultan, we don't have this issue anymore with the same zip. You can also find logs in this threaed with the different issues etc ;)

This issue seems to be with the stock OOS app (not Snap) but also with 3rd party cameras on Google Play.
[OnePlus 3 Themes, Apps, and Mods] dianlujitao:
He might force disabled hal3 (just guess), we plan to do similar thing on CM as well (http://review.cyanogenmod.org/#/c/157498/) but haven't found a perfect solution.
[OnePlus 3 Themes, Apps, and Mods] matssa:
Mmm might be that, but can't be sure though unless [MENTION=4800121]Sultanxda[/MENTION] tells us :) I saw that commit the other day, did you do any testing on this?
[OnePlus 3 Themes, Apps, and Mods] dianlujitao:
The issue is the app list is too long, while the system allows no more than 128 chars.
[OnePlus 3 Themes, Apps, and Mods] matssa:
Yeah just saw that. Is there a way to test this port with the HAL1, like replacing a file or somehting, in order to see if it solves the issues? If I try to include your stuff in the build.prop, it should work right?

camera.hal1.packagelist=com.oneplus.camera

If this can work, we need someone on the official CM ROM to test this out, i just switched to sultan with custom camera HAL.

Furthermore, I see pokemongo is there, it works fine on my phone, what is the issue?
[OnePlus 3 Themes, Apps, and Mods] dianlujitao:
IDK, it's included in the original patch from PA
[OnePlus 3 Themes, Apps, and Mods] matssa:
Ah, then if it was already merged in the official CM builds, this means that HAL1 shouldn't be the reason why it works now, must be more.

EDIT/// NVM, just saw that is isn't in the CM builds... So if PA has this, maaaybe someone can try this on PA ROM and see if it works, unless they merged some camera stuff like sultan ;)
[OnePlus 3 Themes, Apps, and Mods] dianlujitao:
Hmm......still not merged
[OnePlus 3 Themes, Apps, and Mods] matssa:
Yeah I got lost in my thoughts lol. What we can try is, since you are on your CM builds, you could try changing the system.prop in order to include only the oneplus camera app and see if the HAL1 changes. I would do it myself but need to redo all my Linux partition again and it got crappy with my windows10 stuff (and virtual machine is a lot longer than dual boot). If you have the time of course :) In either case, if you trest this out or if [MENTION=4800121]Sultanxda[/MENTION] helps us on what he did, it could improve this port greatly.
[OnePlus 3 Themes, Apps, and Mods] l3ones:
I'm not sure what everyone is talking about with the cm test 4 zip working on Sultan's CM. Sure it doesn't force close, but it also doesn't actually capture a photo. And slowly after that it deteriorates to completely unusable. So far I'm down to being able to toggle the flash once, and get an animation for trying to switch cameras. Other than that nothing in the OOS camera app is working.
[OnePlus 3 Themes, Apps, and Mods] matssa:
Strange cause I just tried and I managed to get photos in normal and HQ... Did you clean flash?

Furthermore, we are trying to understand what has been changed on the camera HAL from sultan in order to see if we can't apply it directly on the official CM.
[OnePlus 3 Themes, Apps, and Mods] matssa:
I just tested the photo app out, and apprently, there is a lot of differences between the images in size. The Snap app takes 8Mb photos and the OOS app is 850Ko... Really strange... The quality, when zooming, is better, sharper with the Snap app than with the OOS app. Truth be told, the OOS app is crappy even on SultanXDA ROM... So yeah, don't know if the app is outdated or if there is something else somewhere
[OnePlus 3 Themes, Apps, and Mods] Roykooiman:
My camera crashes when I'm trying to get in manual mode. Anyone experiencing the same?

Verstuurd vanaf mijn ONEPLUS A3003 met Tapatalk
[OnePlus 3 Themes, Apps, and Mods] Monk3y:
For me it's when I switch to 16:9, still following the thread for new update I'm pretty sure they will find a way to fix everything, we have to be patient developers have life :)
[OnePlus 3 Themes, Apps, and Mods] cameron1292:
Yea I experienced this. Not sure if the photos I uploaded a whole back are compressed or not but you can see the snap is sharper zoomed in and a larger file.
[OnePlus 3 Themes, Apps, and Mods] Nicotin3:
Did somebody made it work on ResurrectionRemix Rom? It FC on almost all the settings or focus.
[OnePlus 3 Themes, Apps, and Mods] sanangel:
What is the more stable zip to flash in a based CM rom? link, please?