yashsingh1/xdaforums huggingface dataset:
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] lagittaja:
Sorry for the OT flar2..

If you wish to use the included charger, Quick Charge can be "disabled" by using a "charge only" cable (or a data block adapter for that matter) but the phone might not "like it" e.g. charge excruciatingly slow at the default USB rate of 5V/0.5A. I haven't tested it so YMMV.

http://www.portablepowersupplies.co.uk/portapow-fast-charge-data-block-usb-adaptor/

or

http://www.portablepowersupplies.co.uk/portapow-data-block-charge-usb-c-cable/

No, your phone or charger won't blow up or damage anything.

These work because before Quick Charge can work there needs to be a digital handshake between the phone and the charger.

Simplified digital handshake:

*plugs phone into charger*

Phone: Yohoo, I support Quick Charge

Charger: Yohoo, I support Quick Charge as well

Phone: Shall we charge rapidly?

Charger: Sure, let's do it

*phone starts charging rapidly*

These "charge only" cables (or those adapters) prevent the digital handshake from happening because the D+ and D- pins aren't connected, the data pins I mean, and since they're not connected the digital handshake cannot take place ergo the phone will not charge rapidly..

But don't worry about the heat. The phone will adjust the charging power dynamically depending on the temperature of the phone.

The phone won't overheat unless there is something seriously wrong.

Charging faster is better for the battery contrary to the popular belief of charging slower being better.

Spending less time shoving electrons down the battery's throat is better than to take forever to charge the battery keeping the battery hotter for longer.

If you're worried about the longevity of your battery and wish to extend it as much as possible the solution is simple: don't charge your phone higher than ~90% or lower than ~20-30%. Charge your phone using the QC charger and don't worry about any memory effects etc., lithium batteries don't have that so feel free to top off the battery during the day (or night) as often as your heart desires..
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] envoy_467:
Probably one of the most beautiful explanation ever! XD not sure about charging faster is better(some laboratory experience with completely different devices though).

So... Let's use the standard charger! XD thanks a lot for the super answer!;)
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
[MENTION=4684315]flar2[/MENTION] any progress on the GPU gov side?

To be sure, I just tried suicide squad on the G5 on high graphics and it ran as it should out of box full speed while on the ten it need GPU gov set to performance

I think the solution is just to import the adreno GPU gov from any other s820 device

HTC never changes....
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] flar2:
I haven't had time to work on it yet.

What are the best "easy" games to test with? I'm not much of a gamer and can't spend a lot of time going through story or levels. Something like Minion Rush, Asphalt 8 or Riptide G2 are good for me because I can quickly play the first level over and over and get used to the spots where lag or frame drops occur.

I like something where it's easy to reproduce the problem.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] flar2:
...................
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
Just download skyforce reloaded (small game) play any level near any device and you will see the massive difference switch to performance GPU gov, then it's fixed
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Why not leave it up to the gamer to decide for the frying pan on any kernel setting app which is able to max out frequencies with that governor switch. :) btw cool game, reminds me of good old PC gaming back in the days cca 2000. Runs ok on default governor, tho maxing out freqs definitely adds a touch of smoothness even if not massive at least for me.

Btw are you on kernel stock 1.90?
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] MartinS13X:
[MENTION=4684315]flar2[/MENTION] , when I download ElementalX-HTC10-0.11-Sense.zip, Windows Defender freaks out and starts shouting Trojan!!! Kill kill kill!!!

detected item:

Trojan: Win32/Spursint.A!cl

Alert level: Donald Trump is president

Reccomended action: Remove immediately

containerfile: D:\_HTC10\Downloads\ElementalX-HTC10-0.11-Sense.zip

file: D:\_HTC10\Downloads\ElementalX-HTC10-0.11-Sense.zip->boot/elex.Image->(GZip)

Suspecting a false positive, just wanting to make sure it not an evil plot to break my phone and steal my pokemon

Thanks :)
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
Dude please try to understand this is not how its supposed to run even the m9 and m8 runs it better on stock, in case of the 10 the GPU is completely failing to scale up the clock speed

I don't want to lock it to max clocks as this would be thermal stupidity, I want the GPU gov to function as it should like it does on all other s820 devices, ie. Smartly scale up the GPU speed AS NEEDED, performance gov is a bad workaround as it locks the clocks to max which a disaster in battery and temps

You say its not a big difference? It's 30fps(stock ten) vs 60fps (stock m9) according to game bench

Please enough with these stereotypical answers, this is not how these games are supposed to run out of box, this is a flagship with s820 with adreno 530, I expect it to run it flawlessly as this awesome hardware should not run it worse than last year's thermal disasters, the very main advantage of snapdragons are their awesome GPU

This kind of mentality is exact why iOS remains king, it's really looking like this is going to be my last Android, I've had it with hunting such issues and I've also had it with such replies, sorry just being honest
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Ok, that's good reasoning, I just always wonder if htc had or not manufacturing reason to cut it. Also we have emmc against ufs on some cases it might cause lags periodically. [MENTION=1144067]hamdir[/MENTION] I trust your judgement, I'm just wondering HTCs reasoning for deviation.

I'm curious is it the same in the new stock 1.90 kernel? They supposed to have fixed something in GPU. Haven't yet tried will do so in a few hours tho. Are you on that?
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Again duplicate, chrome is playing games with me sorry
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
I didn't try stock 1.90 yet as I'm on TW unit and I don't s-off

I hope they did but I doubt it

There is no reasoning htc doesn't have the testers simple as that and they like to **** around with these things just like they did with cpu migration just to brutally counter their stupid pyramid concept of the SoC on top of battery

I repeat both skyforce reloaded and suicide squad (high GFX) don't suffer from this GOU gov problem on G5 and Mi5

Speaking of testers, here is a sad info for you, half the issues that were fixed lately like camera exposure time (first fixed what was broken then extended time) auto hdr, etc were fixed thanks to constant nagging PMs to HTC testers in private here on XDA

They simply don't have good testers
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
i'll have a go with 1.90. GameBench should show me difference, you're still using that, right?
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Ok had a go with new GPU and as others pointed out it's performance consistency is much better on the 1.90 kernel.

But it's still balancing on 30fps but consistent, not jumpy and jerky as it was on 1.80.

Here are two shots, one on performance and one on default GPU governor profile

Same game and same conditions.

[MENTION=1144067]hamdir[/MENTION] what would you like to see on it? Consistency or higher rates? What's on lg5
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
Lol mate it's 60fps on both the g5 and mi5, even m9

Give up ;)

you are chasing a wrong end and just confirmed that it's still broken on 1.90

Believe me in the 60 range this is considered very consistent
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
[MENTION=1144067]hamdir[/MENTION] I know your style, you can't make me feel annoyed :) so let me be clear, I want to measure and help the situation here.

Do you have info if with that 60fps consistency how's battery life compared to htc 10

I wonder how it would suffer in our phones.

At the moment the solution at hand is to pump the freqs, which usually means degradation of battery life.

Any objective input appreciated, because you always have them between the lines in the end ;)
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
Right now all I want is it running like any GPU ramp up its bloody GPU when needed like it should, on stock gov, otherwise I would get myself an MTK device

Bringing battery into the equation is counter intuitive because if a high end game needs the available and marketed power, it's the gamer and dev choice not HTC's to cripple it

Besides this an old engine which is running perfectly 60fps even on adreno 430
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
ok, ramp up sounds like something to improve.

I still wonder that HTC was going to try to fix to an FPS that is supposedly humanly visible ~29fps kinda crippling it (and maybe because of battery even if you think it's counterintuitive, because 30fps supposed to be enough for the eye), but I can agree that consistent 60fps always looks better. So don't take this paragraph as an argument, i'm just musing.

I'll dig around the gpu governor a bit myself, it seems like an interesting area, and i've just run out of features to develop in kernel. I bet flar2 will be faster with this, he's very good at this, but I'm curious.

Cheers
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Funfact for [MENTION=1144067]hamdir[/MENTION]

OP3 governor on flar2's OP3 kernel is by byte the same as official HTC 10. So something else might be at play here... i'll dig further sometime, just the governor line mentioned here looks like little to blame on htc...it will be something else, even if htc's doing :)

https://raw.githubusercontent.com/f...talX/drivers/devfreq/governor_msm_adreno_tz.c

https://raw.githubusercontent.com/t...ster/drivers/devfreq/governor_msm_adreno_tz.c
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
Can we check stock g5 kernel?
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
i'll check both but in more detail, this was just one file of the driver... downloading lg5 kernel and the op3 too and will do some comparisons
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
[MENTION=1144067]hamdir[/MENTION] pm sent with something, im curious how it works for you. I've did some smaller merge that seems to boost adreno governor around 35-40FPS
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] flar2:
[MENTION=1144067]hamdir[/MENTION] [MENTION=3088420]tbalden[/MENTION]

This is overkill, but here's a test kernel that scales GPU up a lot more easily. Before I continue, I want to see if it's stable (last time I tried to tweak the GPU there was an occasional crash) and if it actually helps the FPS problem.

A tuneable (between 0 and 50000)

echo 2000 > /sys/class/kgsl/kgsl-3d0/devfreq/adrenoboost

(Hint: enter this path into EXKM User Settings for easy tweaking)

And to view gpu stats:

cat /sys/class/kgsl/kgsl-3d0/devfreq/trans_stat

(Another hint: pro version of DevCheck can overlay current GPU freqency on the screen)

Download:

https://www.androidfilehost.com/?fid=24588232905722078
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Cool, I mean hot for the GPU, but definitely cool. I only had sustained performance governor for a couple of minutes, that was stable, but if I remember others reported crashes on that (?)

Thanks Flar !! My guess it's lg5 takes a different approach on 3d games and kills battery for gameplay. I think this if it's an optional thing can be quite useful, especially if we find a sweet spot between max ramp up and a steady 40-50 fps with battery and temperature left usable

will check the code too if I can find the point of boost. Shouldn't be hard based on different governors.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
unfortunately it's indeed getting unstable very easily, as [MENTION=4684315]flar2[/MENTION] has already mentioned earlier. Approaching higher FPS values it soft reboots after a while :(

we will need to carefully check what performance governor is doing to remain stable

EDIT:

Or the measuring app is unstable maybe... need to be checked thoroughly
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
[MENTION=4684315]flar2[/MENTION] you never fail mate :)

Solution is really working, but the default 10000 value wasn't great, is this htc's value? If this is htc value then it's hilariously low

Anyway 20000 still not perfect 60, once we jump to 30000 to 40000, it really works, you know as the phone GPU should in the first place

Confirmed by both skyforce and suicide squad

I noticed [MENTION=3088420]tbalden[/MENTION] is really seeing the difference now !

Thanks mate ill continued testing to see if any instantly occurs
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Definitely. I'm still concerned for battery life, but as [MENTION=4684315]flar2[/MENTION] 's patch lowered the minimum GPU freq, and it can easily remain there with the finetuning, I think it goes through my filter where battery life and stock working matters most. But I have to admit, this seems to be overclippled by the original driver somehow (not HTC's driver!)...and it somehow slashes back multiplicated on the 10....

so this patch was indeed needed, and needs care and probably HTC/QCom adoption!

But [MENTION=1144067]hamdir[/MENTION], as you can see, it's not absolutely sure where it went wrong, but definitely not in the kernel driver by HTC, as it's the same as on OP3 (I tried OP3 drivers too on the HTC 10 kernel, before flar's ramp up solution came into the picture)
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] flar2:
[MENTION=1144067]hamdir[/MENTION] [MENTION=3088420]tbalden[/MENTION]

Unfortunately, I still get soft reboots with this.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
[MENTION=3088420]tbalden[/MENTION] [MENTION=4684315]flar2[/MENTION] here is one more evidence for you, I have asked my friend to gamebench OP3 for me, stock

As you can see this is how this game is supposed to work and the battery is unrelated

I am seriously fed up with HTC and their non sense (whatever the reason), I really wonder why tweaking the GPU gov causes instability even though performance gov works perfectly
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Did you get the soft reboots with simply using the performance governor too?

Also are you using any program to monitor fps? With one of them I got soft reboots too, without using the measurement tool it worked. But it happened the same way without the patch too.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
I only monitor clocks using adb, this how we tested the cpu migration PNP mods or gamebench
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Double post.. :( chrome at work sorry
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
That is something we cannot get close to even with the patch. 60fps constant.... Something else is fishy here with the htc roms. Maybe the adreno driver bins?

I'll need to download an op3 ROM and try lib exchange.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
Out of box HTC cripples both the cpu by killing one big core via migration and now this GPU gov thing

So we can conclude that the s820 is seriously crippled on the HTC 10, they advertise it as powerbotics, I call it butchery

The real issue is the SoC being placed too close to the battery and all these measures are desperate attempts to counter it

The curious part is that this issue is not with every game some games like Dead Effect 2 ramps the GPU properly
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Gosh, I have to install so many games. But I'llv try that too on default ramp up , i got curious yesterday...
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Indeed Dead Effects ramps up much aggressively and properly than Suicicde Squad (which doesnt ramp up at all with stock kernel !?!?!).

But with my kernel gpu test version I cannot get any soft reboots in any of these games, and with the adrenoboost thingy I can run them fine, and they ramp up just nicely and I can play Suicicde Squad without too much framedrops. (Tho now Dead Effect 2 ramps up even more, which might be unwanted...)

So I've tried to reproduce Soft reboots with my patch, and I couldn't yet.

Only time I got reboots was using a lousy FPS monitor root app, but then I read it caused reboots on other devices as well.

Maybe there's a difference between the two types of patches that may cause the difference [MENTION=4684315]flar2[/MENTION] ? I'm not sure anymore... Can you try with my patch too if it soft reboots? (https://github.com/tbalden/htc-kernel-pmewlvzw/commit/d8bb9c59f3a57f486ed7b33f2ef93f9e97f7aa83 )

[MENTION=1144067]hamdir[/MENTION] did you have any soft reboots with the test adrenoboost version by flar?

Maybe it's indeed related to some software trickery that HTC binaries lets some games ramp up, and others not.... Will investigate further as soon as i'll have some more time
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] vincenzo697:
I know it might be stupid but can it be from the boost+ app too?
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] fokus:
I just updated the elementaX app. I can't find the settings for the LED?
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] ElementRn:
[MENTION=3088420]tbalden[/MENTION] implemented the LED mods in his kernel. ElementalX kernel isn't updated yet. So you have to wait for an update or flash Cleanslate to get the MOD working.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Well, i was thinking about that too, but I never enable it to any of the games I test, so it shouldn't count
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] flar2:
That's probably it. They seem to wrap the games in a root shell or something. Soft Reboots are usually never kernel related anyway.

I think the the problem could be in firmware or userspace driver.

The funny thing is the GPU doesn't ramp up on op3 and it's still 60fps. The op3 is 1080p, however. And had extremely fast ufs storage.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
Ok, let me know if your find it stable enough too.

So far it seems like stable and quite useful for some games. I still wonder about software trickery, dead effect ramps so well, yet the heavy intro scene on the suicide squad goes down to the lowest possible which is quite strange...
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
Still using ex test kernel and didn't face any reboots

We need flar2 to confirm if his reboots where happening with monitor apps
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] flar2:
Since it's a soft reboot, i think it's the software. L
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
which software? please be more specific

are the monitor apps causing reboots or the test kernel?

still didnt encounter any but i am not playing much games either, ill get to stress testing it tonight hopefully
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] mick_soul:
Does anyone know if V0.11 is working with latest 1.90.401.3 firmware? Thanks
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] flar2:
FPS Meter. That's definitely the cause.

I've been using the phone heavily and it has been stable without that app.

How are you getting FPS with adb?
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] flar2:
By all reports so far, yes. I don't have it myself.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
why didnt you say so? FPS meter caused reboots for me even on the old 1.20 base

its a totally unreliable meter as well, even Trepn causes issues with GPU gov on its own, when use Trepn it completely fails to ramp the gpu in all games including DE2

the 10 or s820 has serious issues with monitor apps

the only two ways to monitor without any negative effects is Gamebench with screenshot function disabled from settings (screenshot did cause dips) and using cat via adb

i dont watch FPS in adb just the clocks and migration, but for now Gamebench is the most reliable tool of them all especially the way i use, i start the game to a specific level and pause, then launch GB, then play the specific section the exact same way and stop it in the same place

this way i have a very clear yellow graph to do comparisons this is how we fine tuned Ivicask's Pnp mode performance profile

looks like your patch is good to go? ;)
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
one problem with gamebench is that their went rather expensive / month and usable for a little while per month for free...:(

So I went with my eye looking at the games, programming and finetuning my governor modifications...
[MENTION=4684315]flar2[/MENTION] maybe a dev check addition? :)
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] flar2:
I'm still experimenting. I threw that patch together in five minutes without any tuning. tbalden did more work on it on Saturday, then last night I started looking at the behaviour of the governor more closely. Looks like it goes up one freq step if the GPU is busy for 80% of the of the time for 5 consecutive windows and drops one step if it's busy for less than 50% of five windows.

I'm trying out another idea today, basically adding an adjustable up threshold. I think that will be more intuitive.

How are your temperatures and battery life using the test kernel?
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] flar2:
I wanted to add that to DevCheck. I can do it for 2d graphics without root, but haven't been able to figure out how to do it for opengl games. And then didn't pursue it because it appears that root is necessary. At the time, I wanted DevCheck to be a non-root app, but Android Nougat changes that.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
That would be awesome.

I've tweaked a conservative type of governor (still testing) for now to retain 2D battery life at normal operation, and scaling up when gaming bothers the GPU enough, and seemingly i could level it to have different levels of FPS targeted , but i solely base on frequency and eye for now.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] tbalden:
i'm really curious about your implementation. i've been going with a counting type of conservativism, before ramp ups, and hardening it before it leaves the low freq area, and also making it harder to go to the upper freqs, because the midground seems to be the good for most games, and really heavy games ramp it up anyway.
[HTC 10 ROMs, Kernels, Recoveries, & Other Developm] hamdir:
[MENTION=4684315]flar2[/MENTION] [MENTION=3088420]tbalden[/MENTION] I tested further tonight and I'm wondering why you guys think there will be an increase of heat, what this patch actually does is simply fix these games to operate properly so its nothing outside the envelope especially since many other games ramp the GPU properly on their own, it's simply bringing affected games up to speed with other games

anyway I have verified that the stock value of 10000 is pretty good for a default value, it runs both games in question pretty well, I would personally raise to 20k but 10 is enough for average users.

I would say this patch is ready for prime time

- GPU gov fix

- CPU cripple fix

- color balance / red tint reduction

This makes your kernels essential tools for the HTC 10

Still a shame that the device is shipping with such issues, it spoiled the early adoption of this glorious device