yashsingh1/xdaforums huggingface dataset:
[Galaxy S 4 i9506 Android Development] :
Please, try with the app : AndroSensor, available on PlayStore, or download the .apk on my Drive :

https://drive.google.com/file/d/0B7NYMa4FPbKpSHI3N0tNYXJTa0E/

Then, report... :good:

I enjoy you to take videos !

---------- Post added at 11:28 AM ---------- Previous post was at 11:22 AM ----------

I can confirm that +

GPU test (Open GL 3.0 - Manhattan 1080p) :

S4 (Adreno 320 - 1080p screen): 450

S4 LTE-A (Adreno 330 - 1080p screen): 764

S5 (Adreno 420 - 1080p screen) : 700

S6 (Mali T760MP8 - 1440p screen) : 760

So our S4 LTE-A is the best gamer phone with that

6.0

ROM !!!
[Galaxy S 4 i9506 Android Development] DahakePL:
There's a big delay when unlocking the phone, I have to wait 2-3 seconds for the screen to light up, any fix?
[Galaxy S 4 i9506 Android Development] TonyTeoTeo:
Sound alive noise, I had to flash patch by karkasss to fix.

E330S.
[Galaxy S 4 i9506 Android Development] Wylany:
Too buggy

Hi! Great work! Unfortunatelly, none of cameras worked for me. Also screen doesn't go off during call and "ok google" doesn't work on homescreen. And I'm not sure it was me or another person but phone call was stuttered. At the moment... no chance to use, but good luck!:)
[Galaxy S 4 i9506 Android Development] 3lambda:
I don't know if all these bugs will be fixed but I'm gonna take a look anyway I keep you informed :)

Take in case that this rom shouldn't come to i9506 this is really awesome to have a touchwizz 6.0.1 :)
[Galaxy S 4 i9506 Android Development] xarisioannina:
thats true but please if its possible if you can fix only the cam? i personally dont care about other bugs because they are not important
[Galaxy S 4 i9506 Android Development] toinkmons:
what boot it would take 20mins? is it the SamsungS4 logo with kernel is not seandroid enforcing on top or just samsung logo? Been stuck at samsungs4 logo for many minutes now :(
[Galaxy S 4 i9506 Android Development] 3lambda:
E330s user ?
[Galaxy S 4 i9506 Android Development] toinkmons:
No sir i9506
[Galaxy S 4 i9506 Android Development] hs911:
i try my suggestion again: there are so many roms based on note4 for our ks01lte that it might be a good idea to port the note 4 marshmallow rom? afaik the hardware is almost identical and i guess the camera would have a good chance to work..
[Galaxy S 4 i9506 Android Development] 3lambda:
Update will come soon I think :)
[Galaxy S 4 i9506 Android Development] DahakePL:
Hardware is a LOT different in note 4
[Galaxy S 4 i9506 Android Development] breakingstorm:
thats good news :) you think camera will work in the next update?
[Galaxy S 4 i9506 Android Development] 3lambda:
No idea... I keep toi informed but these time Im really busy
[Galaxy S 4 i9506 Android Development] doctorex1:
[MENTION=4993440]3lambda[/MENTION] can you port this rom for I9505 snapdragon ?
[Galaxy S 4 i9506 Android Development] 3lambda:
Ï dont have this device... And these I don't really have time
[Galaxy S 4 i9506 Android Development] Usama707:
or u can tell us how to port it in I9505? :confused:
[Galaxy S 4 i9506 Android Development] 3lambda:
Look tutorials I can't help... I'm too much busy
[Galaxy S 4 i9506 Android Development] :
Touchwizz S5 ROM for S4 LTE-A : status

I want to say that I tried this ROM on my Galaxy

S4 LTE-A

(ks01lte, GT-I9506).

LINK : http://artas182x.tk/android-projects/touchwiz-marshmallow-for-note-3/

The artas182x ROM is a International Galaxy S5 (SM-G900M) port for Galaxy NOTE3 (N9005) (

not S4 LTE-A !!!

)

So to use it on our S4 LTE-A, we have to install the gugu0das' kernel.

BUGS : WIFI can't turn on, camera displays something but still doesn't work

There is an other ROM :

LINK : http://gugu0das.blogspot.fr/2016/02/601-jactivelteskt-galaxy-s5-marshmallow.html

The gugu0das ROM is a KOREAN Galaxy S5 (SM-G900S) SK Telecom port for Galaxy S4 Active (jactivelteskt / SHV-E470S) (

not Galaxy S4 LTE-A !!!

)

So to use it on our S4 LTE-A, we have to install the guguodas's kernel.

BUGS : camera doesn't display something and still doesn't work, T-mobile apps :(, Bootanimation : :crying:

Thanks to gugu0das, artas182x, 3lambda... and others

Good luck for the next:good:
[Galaxy S 4 i9506 Android Development] baciany:
Thanks for info but... where to download guguodas's kernel :?
[Galaxy S 4 i9506 Android Development] 3lambda:
His website is on op
[Galaxy S 4 i9506 Android Development] baciany:
This s5 port is really smooth and nice. Now i dont know what to choose Phronesis (5.1.1 and full note 5 design, almost perfect rom) or this 6.0.1 but old layout romm which works like a charm (excluding camera of course, didnt tested it for long time)
[Galaxy S 4 i9506 Android Development] 3lambda:
Stay on phronesis for the moment wait until bugs are fixed etc on this one
[Galaxy S 4 i9506 Android Development] bairog:
Note that only Galaxy S5 Plus (G901F - Snapdragon 805 processor) has Adreno 420 and 1080p screen.

Galaxy S5 (G900F - Snapdragon 801 processor) has Adreno 330 and 1080p screen. :)
[Galaxy S 4 i9506 Android Development] xarisioannina:
that happened to me after some time!
[Galaxy S 4 i9506 Android Development] xarisioannina:
after restart they are working again for some hours
[Galaxy S 4 i9506 Android Development] Spike97:
Have you converted from ext4 to f2fs? Just curious
[Galaxy S 4 i9506 Android Development] :
Wich fix, please

How can I heard that noise ?

Is Sound Alive a feature or a bug ?

Thank you

---------- Post added at 07:47 PM ---------- Previous post was at 07:40 PM ----------

Ok, so you are in V4.4.1 (DarkLord kernel V1.7) and happens it on V4.3 (DarkLord kernel V1.6) ?

Thank you
[Galaxy S 4 i9506 Android Development] xarisioannina:
yes now I m on V.4.4.1 with v1.7 kernel In past I used the v.4.3 with v1.6 and after v1.7 but I cant remember if I faced the same problem because It needs 1-2 or more hours to front this error! something is making sensores to deep sleep after a long period of time
[Galaxy S 4 i9506 Android Development] DahakePL:
No :laugh:
[Galaxy S 4 i9506 Android Development] Spike97:
i have no ideea if this will work for you but maybe you should try because before that i used some tw and cm based ROMs and haved the same issue,

make data and cache F2FS format and tell me if that worked :)
[Galaxy S 4 i9506 Android Development] DahakePL:
But.. all my data will be lost?
[Galaxy S 4 i9506 Android Development] TonyTeoTeo:
This patch fix sound alive. Work for me. E330S.

Sound alive is a feature of samsung music app.

Go to your music/ setting/ soundalive, turn on auto mode, tube amp or 7.1 and open some high song like opera...
[Galaxy S 4 i9506 Android Development] :
Thank you TonyTeo !

I work on camera, keyboard & sensors...
[Galaxy S 4 i9506 Android Development] DahakePL:
Working good, it's not slowing down after a few weeks of usage so that's great news.
[Galaxy S 4 i9506 Android Development] :
Glad to see that.

RR and CM13 are too ugly for me.

S7E is good, but not adapted for the S4 in my opinion...

5.1.1 TW ROMS are not good in performance and features compared to 6.0...

So, I will always use that ROM... like you I think
[Galaxy S 4 i9506 Android Development] DahakePL:
Features are much better on 5.0 or 5.1 ROMs, performance wise 6.0 is the best
[Galaxy S 4 i9506 Android Development] karkasss:
Edit your system/etc/floating_features.xml to change equilizer shortcut menu.

From

<SEC_FLOATING_FEATURE_AUDIO_CONFIG_SOUNDALIVE></SEC_FLOATING_FEATURE_AUDIO_CONFIG_SOUNDALIVE>

To

<SEC_FLOATING_FEATURE_AUDIO_CONFIG_SOUNDALIVE>40</SEC_FLOATING_FEATURE_AUDIO_CONFIG_SOUNDALIVE>
[Galaxy S 4 i9506 Android Development] TonyTeoTeo:
I have tried and rebooted but its still a favorite star.
[Galaxy S 4 i9506 Android Development] karkasss:
Oops. That is for S7 music. Sorry.

나의 SM-G935F 의 Tapatalk에서 보냄
[Galaxy S 4 i9506 Android Development] bairog:
Do you mean there are many features present on 5.0 or 5.1 ROMs that are missing on this 6.0 port?

What are they (exept NFC and SBeam)?
[Galaxy S 4 i9506 Android Development] killerxda:
Would be nice if you could add support for E330SLK on this rom
[Galaxy S 4 i9506 Android Development] rhartinger:
When I connect to my PC I cannot see the SD Card in Explorer
[Galaxy S 4 i9506 Android Development] :
It is, you just have to flash an additionnal .zip to make call working with E330S...

Link : ask to karkasss

---------- Post added at 02:18 PM ---------- Previous post was at 02:17 PM ----------

I9506 or E330S ?

sdcard formatted in FAT32 or exFAT ?

Thank you

---------- Post added at 02:19 PM ---------- Previous post was at 02:18 PM ----------

So, we must install the S7 Music player to have the equalizer shortcut ?

Is SoundAlive good in daily use ?
[Galaxy S 4 i9506 Android Development] blexen:
- the "bubbles" on lockscreen moves very very slowly.. seems like after few hours.. restart solve problem for another few hours..

- the auto-light sensor doesnt work.

Can someone confirm that?
[Galaxy S 4 i9506 Android Development] Mix30:
Thank you for this rom! How to switch on flex storage ver 4.4.1 ? or how to remove application cash to sd card?

Sorry for my english)
[Galaxy S 4 i9506 Android Development] :
So, you want to install apps on sdcard like on CM13 ?
[Galaxy S 4 i9506 Android Development] Mix30:
I do not know how to CM13 , not used ,to this was an android 4.4.2 and 5.0.1 used a folder mount, but it does not work on the Samsung android version 6
[Galaxy S 4 i9506 Android Development] :
Ok, but explain more cleanly what you want...

I haven't understand...
[Galaxy S 4 i9506 Android Development] Nite.Achilles:
yeah I can confirm that. The rotate orientation also doesn't work after some time.
[Galaxy S 4 i9506 Android Development] :
Ok, please can you try V4.3 and say if it was working...

If it was working, I will begin working on that.

And don't worry, V4.3 is also STABLE...

Thank you very much
[Galaxy S 4 i9506 Android Development] blexen:
No problem with v4.3. Testing it.
[Galaxy S 4 i9506 Android Development] xarisioannina:
test it for more time please I an confirm that on v4.3 sensors are not working after some time please test your divice run programms or maybe a game and after 2-3 hourse sensors will be off
[Galaxy S 4 i9506 Android Development] Mix30:
I wish that the cache of applications placed on sd card , is it possible?
[Galaxy S 4 i9506 Android Development] zardak:
Is there a way to reset the old scrolling speed?

Samsung did a bad job here, I really hate this inconsistent scrolling speed. Only chrome has the right scrolling speed, every other app follows the stupid Samsung settings.

I've already tried to tweak friction and max fling velocity without good results.
[Galaxy S 4 i9506 Android Development] bairog:
Mix30 is talking about MM feature called Flex Storage or Adoptable Storage (on his attached screenshot selected string is "Format as internal" in English)

[MENTION=4993440]3lambda[/MENTION], [MENTION=7371323]cedric3[/MENTION] could you please clear one moment (about updating base as far as new S5 MM firmwares will roll out):

Is it possible for you to update S5 base

separately

from artas182x's rom?

Or you can do it only after he updates base in his Note 3 port?

Thx.
[Galaxy S 4 i9506 Android Development] Nanosudha:
Can some one post screenshots ?? all stable ??
[Galaxy S 4 i9506 Android Development] :
No, because :

1) I have the S5 latest update

2) I have not the artas182x files (a lot)

1) I have the 3lambda's files

4) I have my files and the karkasss' files

So I need the artas182x files to update the ROM...

---------- Post added at 11:14 AM ---------- Previous post was at 11:09 AM ----------

No, you can't because it's 6.0, yes, but Touchwiz...

And Touchwiz remove this ability...

But yes, you can, by following a tutorial...

My advice : don't install apps on your external sdcard :

S4 internal storage speed : 250Mo/s read, 180Mo/s write

S4 external storage max speed : 21Mo/s read, 21Mo/s write (hardware restriction :()

And if your card is only a class 10, write=10Mo/s !!!

I tried it, yes, but it speed down the phone :crying:

Good luck !

---------- Post added at 11:15 AM ---------- Previous post was at 11:14 AM ----------

Ask to [MENTION=5150446]karkasss[/MENTION]
[Galaxy S 4 i9506 Android Development] bairog:
Which tutorial do you mean?
[Galaxy S 4 i9506 Android Development] :
http://bgr.com/2016/03/11/galaxy-s7-edge-tips-microsd-adoptable-storage/

Good luck !
[Galaxy S 4 i9506 Android Development] knojap:
What about the sensor problem?

---------- Post added at 02:26 PM ---------- Previous post was at 01:49 PM ----------

Tried this rom to install. Formatted cache and data into f2fs.

After installing the zip there is a message in russian "Wrong Storage" ore something like that. After that it was rebooting in twrp and started again....

And now this is a loop.

After reformating in ext4 it's working.

What about energy saving? Does it work? When enabling the screen doesn't go darker like in lollipop stockrom?
[Galaxy S 4 i9506 Android Development] :
No, sorry, try with EXT4.

Thank you for your report about F2FS, it was never tested :good:

If something goes wrong with EXT4, there is a problem ;)
[Galaxy S 4 i9506 Android Development] bairog:
So maybe it's better to remove "I recommend converting to F2FS using TWRP (only DATA and CACHE)" from the instruction in the first post? :)
[Galaxy S 4 i9506 Android Development] :
Of course, now that it's tested, I can, but I will test many kernels to see which is F2FS compatible...
[Galaxy S 4 i9506 Android Development] knojap:
What about energy saving? Does it work? When enabling the screen doesn't go darker like in lollipop stockrom?
[Galaxy S 4 i9506 Android Development] logansrun24:
So for right now this looks like the most stable marshmallow rom, any one had any problems on e330s?

Before I install again I was wondering if anyone got rro layers to work with this rom?
[Galaxy S 4 i9506 Android Development] :
Try if you want, but there is no need :

in normal use, the ROM is already not battery saver. To maximise autonomy, you can low brightness manually.

in standby, the ROM is very battery saver : 0.2%/hour a record !
[Galaxy S 4 i9506 Android Development] knojap:
Went back to debloated and xposed 5.01.

There are two facts dissapointing me.

1. Gravitybox ain't working correctly. I can't remap the hardware and softbuttons buttons.

2. After debloating some apps the rom doesn't start anymore. Don't know which app causes this error. But in Lollipop i can deinstall theses apps and the phone is starting again.
[Galaxy S 4 i9506 Android Development] zardak:
For the first point you can try Xposed Additions. It's working perfectly
[Galaxy S 4 i9506 Android Development] :
And for the 2), you shouldn't debloat anything in that ROM, in my opinion...

And I never debloated a ROM, you should ask to S5 users, they have the same ROM ! :laugh:
[Galaxy S 4 i9506 Android Development] knojap:
Debloating is very useful for me. Booting will be faster, Backups are faster and smaller and more free memory.

I'm trying to find out which debloated software interrupts the booting.

Till now i can't find a benefit using this rom against lollipop 5.01 debloated. But I'm trying to find out :)

Xposed Additions didn't work like gravitybox. In Gravitybox i can rempap the menu softbutton with a doubleclick to start something...
[Galaxy S 4 i9506 Android Development] rockman.kowal:
Anybody can post link for xposed working with this rom?

Wysłane z mojego SM-G900M przy użyciu Tapatalka
[Galaxy S 4 i9506 Android Development] :
Flash that .zip : http://dl-xda.xposed.info/framework/sdk23/arm/xposed-v84-sdk23-arm.zip

Then install that .apk : http://xdaforums.com/attachment.php?attachmentid=3383776&d=1435601440

Source XDA thread : http://xdaforums.com/showthread.php?t=3034811

Please report if it work, or not.

Thank you ;)

---------- Post added at 09:50 PM ---------- Previous post was at 09:43 PM ----------

http://xdaforums.com/galaxy-s4/general/i9505-ultimate-bloatware-remove-list-t3080800

That thread ? It's for LL, but we are MM :laugh:

You can try that : http://xdaforums.com/galaxy-s6/development/script-marshmallow-6-0-x-super-debloater-t3319854

Or that : http://androidfreeroms.com/samsung-galaxy-note-5-stock-odexed-rom-with-de-bloat-script/

Good luck :fingers-crossed:
[Galaxy S 4 i9506 Android Development] rockman.kowal:
That verision causing bootlop for me

Wysłane z mojego SM-G900M przy użyciu Tapatalka
[Galaxy S 4 i9506 Android Development] :
It's weird...

Bootloop at SAMSUNG or S4 I9506 ?

Have you waited 20 mins at least ?

If you want, try v82
[Galaxy S 4 i9506 Android Development] rockman.kowal:
I wait only normal time for booting rom. Installation framework xposed take more time??

Wysłane z mojego SM-G900M przy użyciu Tapatalka
[Galaxy S 4 i9506 Android Development] baciany:
After installing xposed it should boot the same as after clean install. If rom install took 20 min then after xposed sometimes it took 20 min plus then all apps get optimised :)

Wysłane z mojego GT-I9506 przy użyciu Tapatalka
[Galaxy S 4 i9506 Android Development] knojap:
No, this xposed won't work because the rom isn't deodexed.

You have to use this one:

http://xdaforums.com/xposed/unofficial-xposed-samsung-lollipop-t3180960

xposed-v84.0-sdk23-arm-custom-build-by-wanam-20160504.zip - [Click for QR Code] (4.65 MB, 10654 views)

---------- Post added at 08:44 AM ---------- Previous post was at 08:24 AM ----------

After last night sreen rotation doesn't work anymore. Reboot, pull out battery doesn't help.
[Galaxy S 4 i9506 Android Development] :
Ok, I'm going to share gugu0das' kernel to fix sensors...

And for Xposed, Is it working ?

(If yes I will link it to the thread)

Thank you
[Galaxy S 4 i9506 Android Development] knojap:
Sorry, my fault. I have debloated something that makes the rotation sensor noct working anymore. Don't know which app causing this error. Will find out.
[Galaxy S 4 i9506 Android Development] knojap:
Debloating SNote causing this error.
[Galaxy S 4 i9506 Android Development] karkasss:
[MENTION=7371323]cedric3[/MENTION]

Do not include this file to the rom.

It seems that this file cause the trouble of mtp connection when PC connected.

After rom installation, recommended to replace this file.
[Galaxy S 4 i9506 Android Development] :
Ok, but have

you

got a MTP/sdcard issue ?

And do you know why NFC is not working ? And why there is no NFC option in the Settings ?

And for sensors, some users are saying that they are disabled after some time (2-4hours).

The sensors fix is not working ? Where did that fix come ?

Than you [MENTION=4958692]karkass[/MENTION]

s

.

PS: I have added the missing "

s

" in your name to all my posts :)
[Galaxy S 4 i9506 Android Development] :
up
[Galaxy S 4 i9506 Android Development] TonyTeoTeo:
But you forgot to add "k" in "than you [MENTION=5150446]karkasss[/MENTION]". Haha :silly:
[Galaxy S 4 i9506 Android Development] karkasss:
Have you got a MTP/sdcard issue ? No

And do you know why NFC is not working ? And why there is no NFC option in the Settings ? All MM porting rom has no NFC at this moment. Only Super dev can fix.

And for sensors, some users are saying that they are disabled after some time (2-4hours).

The sensors fix is not working ? Where did that fix come ? I have no idea.

I'm on the gugu0das S5 rom with S7 patch which is based on Korean firmware. So it's not easy to help you as I did before. Sorry.
[Galaxy S 4 i9506 Android Development] rockman.kowal:
Anybody can find how many dpi have oryginal screen in this rom?

Wysłane z mojego SM-G935F przy użyciu Tapatalka
[Galaxy S 4 i9506 Android Development] karkasss:
480 is original dpi of S4

나의 SM-G935F 의 Tapatalk에서 보냄
[Galaxy S 4 i9506 Android Development] msx680x0:
hi! the auto brightness is limited to the last three steps only
[Galaxy S 4 i9506 Android Development] TonyTeoTeo:
Sometime i can't hear anything from music app, both stock and 3rd app.
[Galaxy S 4 i9506 Android Development] :
I don't understand, please screenshot, video or better explanation... ;)
[Galaxy S 4 i9506 Android Development] theflanker:
Thanks for your great work. I have a question: there are tweaks of customization, there will be none ever? or you do an update?
[Galaxy S 4 i9506 Android Development] :
It's stock ROM, untouched...

If you want (I remind it's a Touchwiz ROM), you can Deodex, debloat it, add features, etc...

But it's not my work, so ask to others devs that have already did that with 5.0 ROMS in the GT-I9506 thread.
[Galaxy S 4 i9506 Android Development] 3lambda:
Maybe I'll work on it when I'll hit time
[Galaxy S 4 i9506 Android Development] zardak:
What customizations exactly? I think we would love to keep this as stock as possibile, there is already xposed framework for tweaks and customizations. Maybe you guys should focus more on making this rom more stable and reliable (I'm not saying it's not, but could be better); THESE kind of work are really more appreciated IMO.
[Galaxy S 4 i9506 Android Development] 3lambda:
I'll make a different thread for customization or an additional download link

Well the problem for the moment is kernel... If we have a better kernel we will have a better rom
[Galaxy S 4 i9506 Android Development] :
What are the current problems with kernel please ?
[Galaxy S 4 i9506 Android Development] 3lambda:
Too much experimental

And no tweak on it
[Galaxy S 4 i9506 Android Development] :
Ok, but sensors disabled after some time...

How to fix it ?
[Galaxy S 4 i9506 Android Development] 3lambda:
Either lib or kernel related
[Galaxy S 4 i9506 Android Development] msx680x0:
a) enable auto brightness from system ui

b) check the levels inside a room

c) levels 1 to 7 are the same like a min level of brightness
[Galaxy S 4 i9506 Android Development] :
ok [MENTION=5150446]karkasss[/MENTION], I know that you have already fixed that on NOTE 3...

Please
[Galaxy S 4 i9506 Android Development] msx680x0:
:good::good::good:
[Galaxy S 4 i9506 Android Development] zardak:
I don't want to be rude but I don't think this is a problem at all. To know if is a bug or not someone with s5 should confirm. In my opinion is OK to have the lowest brightenss even of level 5 of auto brightness in dark rooms, this way it will not hurt eyes and when some light comes it will raise the brightness higher making the display comfortable to read.

In other words: if you keep the device under moderate light and move the auto brightness bar you'll see that it actually works fine for every single step. Only for very dark rooms it stays at the lowest point until level 7
[Galaxy S 4 i9506 Android Development] msx680x0:
it is not a problem of lightness...

it is a bug.

it is a nonsense to have ten levels if you do not can use it and with the stock rom works fine. :cool:
[Galaxy S 4 i9506 Android Development] zardak:
The 10 levels are working perfectly under normal light. The real nonsense is increasing the brightness when there is no light. You just increase the auto brightness level to have a more aggressive jump when you move in a brighter environment. Also I use a screen filter to dim it more since to me is too bright.
[Galaxy S 4 i9506 Android Development] msx680x0:
I'm sorry but the stock rom works fine inside and outside a room and it is the correct way to go with the auto-brightness.

However you could fix the first steps with an additional reduction of brightness or changing from 11 to 4 steps when the lux value is too low.

The empty steps are very bad solution for me.
[Galaxy S 4 i9506 Android Development] dajhacker:
Do i need to flash the e330 user call fix on version 4.4.1???
[Galaxy S 4 i9506 Android Development] TonyTeoTeo:
Yes, you need.
[Galaxy S 4 i9506 Android Development] blexen:
Hello

i have problems with gps function at 4.4.1. Sometimes it needs few minutes to get connect to gps and sometimes the gps get disconnect. Tryed with Google mapps and tomtom go.

any ideas?

Thanks
[Galaxy S 4 i9506 Android Development] :
Try to install that .apk : com.qualcomm.location.apk

Then reboot...

And please report if it works or not...

Good luck :fingers-crossed:
[Galaxy S 4 i9506 Android Development] blexen:
Thank you. The apk didnt solve the Problem. I had to reset my phone. Now it works. Dont know what was going wrong.