yashsingh1/xdaforums huggingface dataset:
[Sprint Samsung Galaxy S6] nostrings:
[MENTION=4988866]tdhite[/MENTION]

I am not sure how up to date the source in GitHub is, but I am confident I found at least one memory leak with what's up there.

Here is the commit that causes this leak; https://github.com/TeamSPR/kernel-n...1cf62e8#diff-1c5364196d98130348bddabaad0a701f

And here is the fix; https://github.com/XileForce/Vindicator-S6-Unified/commit/f7d70299380adb03e8db88a4f555b4f3d199fa49

I do not see the above fix cherry-picked in your repo ... again, based on what's there in the remote repo.

Give it a whirl - and let us know if this works for your kernel.

PS: if the fix doesn't works, maybe revert the original commit entirely for now, and is if that is the culprit. Just a thought.
[Sprint Samsung Galaxy S6] tdhite:
I think you may have found something. The other fixes I have are similar in nature (cleaning up various routine exits that deal with kernel allocation failures).

This addresses similarly the kernel stack issue for sure; I’ll build it in and if it goes, I think we have a perfectly stable and clean kernel (I have scoured hard and can’t find much else).

Thanks!
[Sprint Samsung Galaxy S6] nostrings:
I was testing this on my kernel, and the "fix" didn't seem to fix the problem. So I just took out both commits. So far, that seems to have done it.
[Sprint Samsung Galaxy S6] tdhite:
No worries -- correct the fix you sent didn't fix the entire problem (deals with a small part only, if it ever gets hit).

The area of problem is what I needed. There is s miserable error in the fair.c file that I fixed. I've been testing all day (fixed stuff very early AM) and it's flawless (finally, whew!).

I'll post up things assuming all tests go well for the rest of today, but I don't see any degradation of KernelStack (the leak) at all any more.
[Sprint Samsung Galaxy S6] hammmersmashface:
Best news so far this yeah ..can't wait!!!! Whoo
[Sprint Samsung Galaxy S6] tdhite:
RC Release

If folks don't mind testing this -- assuming it works as well as it did for me, it's a release and I'll post it in the OP.

https://www.androidfilehost.com/?fid=11410963190603904144

The sources are now here (kernels are based on the more recent Samsung base code): https://github.com/TeamSPR/kernel-nougat2

Also -- since it's a new kernel build, be sure to check your Synapse settings a couple minutes after boot, in case Synapse decides things have changed enough to not actually run. Just hit the 'X' to let it setup as normal if it warns that it didn't run.

Also -- feel free to turn the Cortex service back on in Synapse if you turned it off. It's good to go with the memory fixes.

:cowboy:
[Sprint Samsung Galaxy S6] millernet:
thank you for continuing to support this, it is much appreciated. When I tried to install v7.3 I got an .md5 signature failure--tried downloading and installing twice.
[Sprint Samsung Galaxy S6] digitalchaos1980:
Man, I don't say it enough, you are amazing with this device and your kernel!! I'm back on my S6 as a daily driver again for a while so I'm definitely glad to be able to keep this sucker going as long as possible.

Now with that said, I do have a question. A few pages or so back, you (I think) instructed us to comment out the "cortexbrain_background_process=0" (or 1) in a file and save it. When flashing this newer kernel does it automatically revert that change or would we need to go back and undo what we did? Thank you good sir for your time and ALL of your hard work!!

Chuck
[Sprint Samsung Galaxy S6] tdhite:
MD5 is what it is, a failed download will fail the check (appropriately).

Yea, good point. The flash doesn’t try to back out your changes In that regard. Just back them out by hand, or if preferable, have Synapse reset all things to default and set things up again.
[Sprint Samsung Galaxy S6] souzabrz:
Has anyone tried flashing this on G920I? Is it possible to work or no way?
[Sprint Samsung Galaxy S6] tdhite:
It will not work due to chip differences. If there is enough interest from the international folks, I can easily port the kernel to the other models.

I don’t follow the general S6 forum, I’ll check in there once in a while.
[Sprint Samsung Galaxy S6] digitalchaos1980:
OK cool, thanks for that tip then! So far things are going well on my end! Sometimes the system RAM seems to be initially higher after a reboot than before, however that could just be anything, however with that said so far it's not slowly using itself out of RAM. So far so good! :)

Chuck

p.s. Anyways the point was maybe reverting that change could change something, so I will revert and see if it does anything.
[Sprint Samsung Galaxy S6] shawn67:
Working Fantastic! Thank you for making my S6 usable again.
[Sprint Samsung Galaxy S6] LazerOrca:
Wondering if this was possible to port to SM-G920R4?

Hi there. Just from cruising the S6 forums for a good while, I see that the Sprint guys get left out in the cold here. Well the US Cellular guys like me really really get left out in the cold :)

In the past I have used 920P files like for flashing custom recovery and so on, particularly early on when it was the only thing that we had. I was wondering what all would be involved to port this to SM-920R4.

I'm really looking pretty dilligently for a custom kernel to put on this thing, because the battery is beginning to wear down a little. Right now, I'm just stuff with the generic governors and CPU voltages and frequencies. I think the last time I saw anything sort of custom kernel for my variant with the UniKernel. And it had compatibility with the 920P too.

[KERNEL][920P/R4] UniKernel v9 120615
[Sprint Samsung Galaxy S6] Wormsnake:
Sadly Synapse doesn't show up for me even after a clean install. :/
[Sprint Samsung Galaxy S6] acdjkz:
Any chance for a SM-928F port, or instructions on how to compile for the SM-G928F?

Thanks.
[Sprint Samsung Galaxy S6] souzabrz:
I'd really appreciate if you do this, this kernel seems awesome
[Sprint Samsung Galaxy S6] Wormsnake:
So I'm guessing this project is dead?
[Sprint Samsung Galaxy S6] nostrings:
What do you need updated?
[Sprint Samsung Galaxy S6] Wormsnake:
After several clean installs synapse doesn't seem to install and now my phone becomes really hot when playing a game or reading news with a white background.
[Sprint Samsung Galaxy S6] tdhite:
Folks, my phone finally bit the dust, so updates are unlikely from here. Not sure there is really any need anyway; the kernel is extremely stable and covers every base of needs for the phone we know (so far, anyway).

I’ll watch the thread for a time, but will close it over the summer in all likelihood.

For the record, I’ve switched to a Pixel 3a, a great phone that also assures the future of my development efforts.
[Sprint Samsung Galaxy S6] nostrings:
Thank you for your work all these years - definitely gave a different life to our devices.

Enjoy your new phone - I'd be interested to know your take on comparing it to this phone; what is performance like, audio (jack), screen, ...

I also am considering the 3a XL myself, though that storage capacity is what's keeping me away for now. 64GB isn't a whole lot, especially when you have some (FLAC) music, and a movie or two for the commute.

I am currently eyeing the ZenFone 6 and the Red Magic 3 (and switching carriers of course), but only after this current phone bites the dust.
[Sprint Samsung Galaxy S6] tdhite:
The thing seriously rocks. So much so I may never root it. It's that good, IMHO.
[Sprint Samsung Galaxy S6] zfk110:
HI, I was trying to flash your magisk-module-skyhigh-v1.9.20180430.zip on newer Magisk 20.4, but it wont flash it will give me error 1 under TWRP. with the older Magisk 18.0 it will install but when I open Magisk manager it said no root installed so for root I have to install newer 20.4, but then your magisk-module-skyhigh-v1.9.20180430.zip wont install under newer Magisk. is there anyway I can disable that error and install this?
[Sprint Samsung Galaxy S6] tdhite:
I have never seen this, and to be sure I do not run xposed or any other such hacks.

With that said, there are no known errors or missing features.

Realize the governor has many settings, one that is important is the no_extra_cores_screen_off. Try setting that to 0 (zero) for the A53.
[Sprint Samsung Galaxy S6] omar_31091:
i flashed 2.84 and its getting bootloop now... and when i am installing rom its saying symlinks failed.

i factory reset 2-4 times then rom successfully installed but the it keeps on rebooting after logo
[Sprint Samsung Galaxy S6] Jimmy1life:
Well good luck i had that last week if click my name look at all my post i was screwd i thought but its working fine now and better then ever. kernels installed working good my wifi password had to be reset.
[Sprint Samsung Galaxy S6] omar_31091:
plz if u can give me a link :(
[Sprint Samsung Galaxy S6] Jimmy1life:
Well I dont got a link but il tell you I flashed stock multible times it still rebooted took to store to sprint guy wipe data and cache which i had done 15 times man no matter what rom it reboot well i pulled sim card out put back in tryed in a old phone threw it in my draw till next day it was complety dead gonna get a log cat but it worked excellent then.

---------- Post added at 02:34 AM ---------- Previous post was at 02:03 AM ----------

To be honest i was flashing a few kinds of roms g925 n920 but didnt encounter any problems until i restored a few day old efs. Thats something i never touch next boot it started rebooting. I didnt use md5 either so cant be fa sure man. I know during the time 1st ten lines of logcat had emmc in them idk if thats normal couldnt read it and didnt copy it.
[Sprint Samsung Galaxy S6] omar_31091:
ok, i flashed stock 3 to 4 times now. hoping to get it right soon :(
[Sprint Samsung Galaxy S6] UpInTheAir:
[MENTION=4988866]tdhite[/MENTION]

As I have nothing to do with this kernel or how it interacts with a device that I don't use, if you could please do a number of things for me?

Add the term "PORT" before any reference to SkyHigh in thread title etc.

If using parts of my Synapse UCI implementation, upload to gitHub with appropriate credits etc. Due to excessive and repetitive kang (and continues to this day), I've included it with my source so all is under GPL. Meaning authorship, changes and comments, credits etc must be visible and shared for all.

Thank you good luck with the project :)

UITA
[Sprint Samsung Galaxy S6] tdhite:
[MENTION=3511708]UpInTheAir[/MENTION], everything is already in github with due credit and GPL basis should all be in place. However, for the sake of sanity I will recheck and if anything is missing will update and send you a note of the updates so you can set that in your base for future ports. I too have been kanged many times, and it is far too rampant in Android works. Frustrates for sure.

As for the PORT nomenclature in the thread title, great idea. Will do. You might note the first line of the OP specifically notifies it is a port, but why not the title too ;).

Thanks for checking.

--- update --- [MENTION=3511708]UpInTheAir[/MENTION] -- there are a lot of problems in your GPL implementation -- turns out the repos you have don't follow proper GPL implementation, which is very likely how it looks to you that you get 'kanged'. Per the GPL instructions:

"Just putting a copy of the GNU GPL in a file in your repository does not explicitly state that the code in the same repository may be used under the GNU GPL. Without such a statement, it's not entirely clear that the permissions in the license really apply to any particular source file. An explicit statement saying that eliminates all doubt." See http://www.gnu.org/licenses/gpl-faq.en.html#LicenseCopyOnly .

"You should put a notice at the start of each source file, stating what license it carries, in order to avoid risk of the code's getting disconnected from its license. If your repository's README says that source file is under the GNU GPL, what happens if someone copies that file to another program? That other context may not show what the file's license is. It may appear to have some other license, or no license at all (which would make the code nonfree)." See http://www.gnu.org/licenses/gpl-faq.en.html#NoticeInSourceFile.

None of your files have a copyright notice and GPL preamble. I'll add them to my repo, but effectively folks taking your files end up disconnecting them from the license. Sucks, but true. A lot of folks screw up GPL implementation -- you need to fix all your repositories as soon as possible.
[Sprint Samsung Galaxy S6] Defi4nc3:
So I'm on G920PVPS3CPD2 firmware and the kernel will install but I have no access to synapse as it says device not supported. Whats the workaround?
[Sprint Samsung Galaxy S6] tdhite:
I have not yet updated the kernel to the latest drop from Sprint -- suggest you restore your boot.img (hopefully you nandroid backed up in TWRP prior to flashing).

I'll update over the week.
[Sprint Samsung Galaxy S6] UpInTheAir:
No, I get kanged by people extracting directly from my ramdisks. I've only decided to upload and commit (once again) the ramdisk (which weren't covered by GPL, but only XDA sharing rules - share with one, share with all).

There should be any need for copyright notices etc, but is covered under https://github.com/UpInTheAir/Exynos-7420-6.0.1/blob/SkyHigh-N920C/COPYING, which is found in my repo covering

all

code

We are here to share, but most just take and take and without proper acknowledgement etc. I make it open-source, which does not imply open-free !!

Anyway, I'm rather busy, getting back to what I was doing :) . . . .
[Sprint Samsung Galaxy S6] tdhite:
:) -- we'll get you fixed up [MENTION=3511708]UpInTheAir[/MENTION]. Just beware of that above as the GPL is pretty clear on that (as I quoted earlier): "Just putting a copy of the GNU GPL ([i.e., the COPYING file)] in a file in your repository does not explicitly state that the code in the same repository may be used under the GNU GPL. . . . . You should put a notice at the start of each source file, stating what license it carries, in order to avoid risk of the code's getting disconnected from its license."

I'll add headers to your files for you -- you could then cherry-pick 'em back in for ease (as appropriate, anyway). I don't have actual copyright notices for you, but I'll make something reasonable. I harbor the same concerns as you -- folks will keep lifting the stuff and without that preamble (copyright statement), it'll keep happening. Let's fix 'er up but good.

:highfive:
[Sprint Samsung Galaxy S6] UpInTheAir:
It's only just a hobby. I'm not too bothered as most of the time is ignored anyway. . I'm busy with other "stuff" to worry about that. Others can see the intent and should reciprocate the opensource commits for open sharing, transparency and collaboration. You do what you wish though.

Good luck.

Sent from my SkyHigh Kernel powered SM-N920C
[Sprint Samsung Galaxy S6] junioric9:
When i flash the kernel qith twrp 3.0.1 stuck into galaxy s6 boot logo forever, how cani fox this?
[Sprint Samsung Galaxy S6] omar_31091:
how to reset wifi
[Sprint Samsung Galaxy S6] Jimmy1life:
Long press the network then hit forget network.
[Sprint Samsung Galaxy S6] xXxSMOKExXX:
COULD someone make the core SkyHigh-v2.84 worked in very good G925P work great and ADMIRE as not there for our device, we would be very grateful

---------- Post added at 03:07 PM ---------- Previous post was at 03:07 PM ----------

Please help i need this kerner for g925p
[Sprint Samsung Galaxy S6] Jimmy1life:
03:07 PM ----------

Please help i need this kerner for g925p[/QUOTE]

The renegade rom unikernel not working for you. Tdhite said he will make the port hang in there man. Maybe ask for the issues u need solved with the kernel in the 925p threads. Ram9200 might have a kernel if asked he might give it to you im not sure but he saved me when there wasnt any kernels available he had one premissive enforcing. Well good luck ive had excellent results with this skyhigh kernel. Plus it dosnt have the red enforcing at boot.
[Sprint Samsung Galaxy S6] nostrings:
Here is the thread; http://xdaforums.com/sprint-galaxy-s6/orig-development/kernel-kt-sgs6-ocv-ktweaker-t3093009

It's been almost a year since I skimmed the github repo, but I vaguely recall one or two commits dealing with something of the sort. I can peek at the repo again and see if I can point you to files/lines specifically.
[Sprint Samsung Galaxy S6] tdhite:
I'm telling you, the governor is up to date. Just post up some logs (logcat and /dev/kmsg if you can). I have no other reports of this issue with a heck of a lot of users, so probably a device (bluetooth possibly?) or xposed or something is badly interacting. Logs will tell me what's up, if anything kernel related.
[Sprint Samsung Galaxy S6] nostrings:
Yeah, it was a shot in the dark, but I asked anyway.

I have since removed Xposed, and so far things are running OK. Will nag you back in case the problem recurs.

Thank you!
[Sprint Samsung Galaxy S6] tdhite:
LOL -- you're better off without it. Is there anything specific Xposed was doing for you that maybe I could add to the kernel?
[Sprint Samsung Galaxy S6] nostrings:
Most of the stuff I was using Xposed for was not really kernel related, except for the Smart Network module, potentially.

In Synapse->Cortex, there are some functions (WiFi Auto, for example) that get turned off when screen is off. If Network type can be changed to EvDo/3G and/or location can be turned off when the screen is off, then awesome!
[Sprint Samsung Galaxy S6] chewbapoclypse:
Hi, I installed this on my device. Does this kernel block messaging for adb? I cannot seem to get logcat messages in Android Studio 2.1, neither by usb connection or tcp. I have tested to make sure it wasn't the new version of AS. The reason why I installed it in the first place is because I was told that it supports Xbox controllers as being detected as a Input Device, can someone please confirm this is a feature, and if not point me in the direction of one that does? Thanks!
[Sprint Samsung Galaxy S6] UpInTheAir:
Have you read the OP ? Synapse Features ?

Obviously you require Synapse app for these advanced features. All your answers are there and in Synapse sections + descriptions.

Please read Post #3 for Synapse install instruction.

Good luck.

Sent from my SkyHigh Kernel powered SM-N920C
[Sprint Samsung Galaxy S6] Joshuaboyzn:
Third post is empty. At least on this end.
[Sprint Samsung Galaxy S6] UpInTheAir:
Damit. My apologies. The thread title is so close to my own, I thought it was !

If the OP had just asked before starting this project, instead of kang in the first instance.

Many have been shut down because of this at XDA. No different from grabbing someone's ROM and changing a few things.... Open source != open season.

Permission first is ALWAYS required to redistribute publicly.

Let's say I decide to release official SkyHigh here, what next? Get my point?

Anyway, OP has made it clear that I have nothing to do with how this kernel is built and associated mods etc are implemented. I'm not the one at the keyboard.

If in future you see me post here, then kindly ignore my mistake.

Good luck and have a nice day. [emoji3]

Sent from my SkyHigh Kernel powered SM-N920C
[Sprint Samsung Galaxy S6] tdhite:
Whoah whoah whoah. Certainly no kanging going on here, no hate throwing deserved. When you were contacted to discuss, the request was ignored because apparently you were quite busy. So certain attempt was made to get you involved. I totally understand that, though, as I too get pretty busy.

Further, if permission wasn't granted in this post, then I'm a little confused, as quoted from you: "Thank you good luck with the project": http://xdaforums.com/showpost.php?p=66654172&postcount=70

I'm working, as noted thereby, to get your files all setup with GPL copyright so when ports are made, all the copyright goes with you. For example: https://github.com/TeamSPR/tools/blob/master/G920P-SkyHigh/sbin/SkyHigh.sh which is the correct implementation of GPL code so you don't end up thinking you got kanged. As I noted before, you need to fix that for sure, I'm here to help.

Further, I did definitely make clear this is a port from the very beginning, making credits to you, [MENTION=3511708]UpInTheAir[/MENTION] -- bolded in the OP, first line: "Port of the SkyHigh Kernel, originally created by [MENTION=3511708]UpInTheAir[/MENTION], to SM-G920P (Sprint Galaxy S6)."

If you decided to release an official SkyHigh, I would immediately close this thread.

I'm working in awfully good faith, so a little surprised with the kang claim all of a sudden.
[Sprint Samsung Galaxy S6] UpInTheAir:
The bottom line is that I had not given you permission == Kang.

As I said, no difference from any other work here at XDA. You must seek and OBTAIN permission first. Lets just call it what it is and not hide that fact.

You did not receive a response? So you made a conscious decision to Kang. Yes it is. If you have a problem with this definition, then a Moderator can assist you to define, otherwise accept it and please amend your ways for future.

This is not how members behave in XDA development. For example, I recently asked and was given permission to use the busybox Uninstaller script (unmodified and credits given) before including with my installer zip. This is how we do things. We ask and obtain permission first not just take. This is just common courtesy and respect.

Now. I'm going to give you a little latitude, but please take what I've said on board. We all start somewhere and make mistakes. I've made plenty (and still do). . .

Cheers.

Sent from my SkyHigh Kernel powered SM-N920C
[Sprint Samsung Galaxy S6] tdhite:
All good. Not on the same page with your definitions, given the nature of GPL license, but no matter, will will honor your wishes. It's good work to start from for sure.

Thanks, I will get you a snap of the copyrights I put in place for you so confusion doesn't reign next time.

All on board.
[Sprint Samsung Galaxy S6] UpInTheAir:
FYI == Kang : XDA definition. We should be on the same page now.

There is no confusion ;) As I said, don't need to clutter code with copyright nonsense, just be respectful in future : ask > obtain permission > use . That's how we do things. This isn't for profit, just a hobby, but doesn't mean "free". I could just as easily uploaded a tar-ball. This is GPL compliant and within XDA rules. BUT, this does not encourage open-source sharing, transparency, possible collaboration and respect. Without, we have pretty much nothing.

Sign out :good:
[Sprint Samsung Galaxy S6] tdhite:
Now that *is* interesting -- according to XDA:

"Kang The process of creating a code based of someone else's code or reapplying code that someone else created into your own code (e.g. git cherry-pick)[.]"

So, all kernels, Cyanogenmod, and pretty much everything going on in XDA is a bunch of kanging, since pretty much everything (including your kernel sources) all include a bunch of cherry-picks. If that's the deal, agreed -- I definitely learned something here: we we're all kanging (you, me, Cyanogenmod, OmniROM (TWRP), etc.), gobs of kanging going on. I definitely stand corrected. ;)

LOL -- on the real side -- it really is all good. Agreed on the shared communications and permissions (though GPL grants that by definition). Thanks dude.
[Sprint Samsung Galaxy S6] nostrings:
Umm, wow.

I thought [MENTION=4988866]tdhite[/MENTION] explicitly giving credit to the original author ought to be enough... apparently, not so.

I wonder how this would translate into publishing in journals - the equivalent here, I think, would be to ask for permission to read someone else's paper(s), ask permission to cite them, and then cite them in your work... or something to that effect... good grief!