yashsingh1/xdaforums huggingface dataset:
[OnePlus X Themes and Apps] blackkn1ght2010:
When you choose a low ISO value the image gets much darker. The camera automatically tries to compensate by using a slower shutter speed, that determines the slowness you see, and is the reason why it's much more difficult to get a steady photo at low ISO when there's not enough light.

OOS in the manual control section has also a setting for shutter speed, unfortunatelly Sultan's HAL hasn't...
[OnePlus X Themes and Apps] Tanogeek:
It works perfectly with the last CM version from Ashwin (1103), thanks Sultan.

Before that, i had trouble with video being not readable.

Does anyone know an camera app compatible with CM13 and 60/120 FPS video mode ?

I don't find it on Google Camera, thanks.
[OnePlus X Themes and Apps] ashwinpilgaonkar:
The default camera that comes with CM13 (Snapdragon Camera) supports 60/120 FPS video mode.
[OnePlus X Themes and Apps] awildsloth:
Sultan, you're a legend. At last you fixed the banding! Keep up the good work :victory:
[OnePlus X Themes and Apps] xda.buff:
[MENTION=4800121]Sultanxda[/MENTION] I took some pics from a friend who's using a fully stock OPX with OOS 2.2.0-X and I noticed some differences between his and mine so, I decided to do a little comparison of my own.

Front Camera

From top to bottom,

- CM13 Stock, Auto ISO (558)

- CM13 with HAL, Auto ISO (1510)

- OOS 2.2.0-X Stock, Auto ISO (628)

(FRONT_AUTO.jpg)

- CM13 Stock, ISO 100

- CM13 with HAL, ISO 100

(FRONT_ISO100.jpg)

1. Why does the stock CM13 image looks much more detailed when compared to the one using your HAL and stock OOS?

Rear Camera

- CM13 Stock, Auto ISO (758)

- CM13 with HAL, Auto ISO (1344)

- OOS 2.2.0-X Stock, Auto ISO (746)

(REAR_AUTO.jpg)

2. Even though the ISO of the image using your HAL is much higher than the others, how is it that all three images and the amount of noise in them look more or less the same? Isn't the noise level supposed to increase with an increase in ISO?

- CM13 Stock, ISO 100

- CM13 with HAL, ISO 100

- OOS 2.2.0-X, ISO 100

(REAR_ISO100.jpg)

- CM13 with HAL, ISO 100

- OOS 2.2.0-X, ISO 100

(REAR_ISO100_2.jpg)

3. The pics with and without your HAL look kind of the same but the OOS one has much lesser amount of noise in it. Does it have a denoising algorithm or something that's missing in CM13?

A similar difference between the 3 images is noticed when ISO 3200 is used.

All images were shot in completely artificial lighting using Snapdragon Camera on the latest builds of OOS, CM13 and your HAL with blu sparks kernel r108.

Can you please answer these questions of mine?

(Zoom into the images to see the detail more clearly)

P.S. - The latest update of your HAL is awesome! Fixed the annoying anti banding issue :)
[OnePlus X Themes and Apps] Sultanxda:
There are 2-3 issues with your tests: the device was not kept stationary for all photos (i.e. you held the phone with your hand instead of putting it on a desk or something), focus mode was not set to auto for the rear camera (disable ZSL in order to change the focus mode in Snapdragon Camera), and you didn't report the exposure time for each photo.

Focus mode should be set to auto when performing direct comparisons with the rear camera because continuous autofocus can be wild sometimes and you may end up taking a photo at the moment that continuous autofocus decides to move the lens out of focus.

Also, you shouldn't compare photos of yourself because exposure times can be quite high when you force ISO to 100, and you may introduce blur into the photo if you move even slightly. Photograph stationary objects instead.

The reason why I'm saying all of this is because some of your results don't make sense, so you should redo your tests with all of these variables accounted for.
[OnePlus X Themes and Apps] xda.buff:
I don't have a tripod or anything to hold the phone so I tried my best to keep my hand still and repeated shots when it was necessary.

I had manually focused at a certain point before capturing every picture and I repeated all the front camera tests 3 times. They produced the same result everytime. I don't think that can be a coincidence.

Exposure times-

FRONT CAM

CM13 Stock and OOS, Auto - 1/14

CM13 with HAL, Auto - 1/40

CM13 Stock and with HAL, ISO 100 - 1/5

REAR CAM

CM13 Stock, Auto - 1/30

CM13 with HAL, Auto - 1/60

OOS Stock, Auto - 1/25

CM13 Stock, with HAL and OOS, ISO 100 - 1/5
[OnePlus X Themes and Apps] ba5e:
Which camera app do you recommend sultan to get the most out of the custom HAL?
[OnePlus X Themes and Apps] Pejpi:
Hello again everyone,

After a few weeks of using Sultans HAL im reporting back with sopme issues which i cant get my head around.

If anyhow possible i'm asking for some help of you guys, maybe you know whats going on.

2 problems:

1. When i'm recording video in 1080p and high framrate 60 fps enabled, after a short period my camera adds some weird green color into the recording as seen attached

- it dissaperas only when i restart the camera app, and the all over again.

2. Same video recording set up as above but this time..the picture is totaly broken, the frame rate is constant but the picture is....well, take a look for your self see attached

I uploaded the clips to my youtube channel since i cant yet paste links just search for my channel Mpapac11 and look for the videos.

Using Temaseks CM13 with stock camera app. No custom kernel what so ever.

Any ideas?

Cheers
[OnePlus X Themes and Apps] ashwinpilgaonkar:
Yep. I don't think these issues are due to the custom HAL though.

The same thing happens on OOS with stock HAL.
[OnePlus X Themes and Apps] ito.tm:
Sultanxda, thanks for your excellent work. I tried the HAL and only one thing is preventing me to use it, photos are too big with 100% setting in jpeg. Is there a way to adjust the level of compression? I'd use 85-90% that is reasonable for my needs.
[OnePlus X Themes and Apps] ashwinpilgaonkar:
Snapdragon camera gives you an option to change the JPEG quality.
[OnePlus X Themes and Apps] Pejpi:
Yeah....so...what? do I try and see if the problem perssist after changing to any other ROM..say CM12.1 as Sultan is using?

And is there any way to completely delete Sultans HAL from my device and then try and instaling in again fresh ?

Cheers.
[OnePlus X Themes and Apps] Kéno40:
Just reflash Temaseks CM13 , then flash HAL.
[OnePlus X Themes and Apps] awildsloth:
Where exactly? I can't find the option on mine.

Enviado do meu ONE E1003 através de Tapatalk
[OnePlus X Themes and Apps] sneakerspark:
That won't matter any way as he forced the picture quality to be 100%
[OnePlus X Themes and Apps] Josephvb10:
I'm having problems with HDR: when this is installed, every app I tried crashes when using HDR. Google Camera, Snapdrsgon Camera, FV-5 camera, they all crash.

Using a marshmallow ROM (Exodus).
[OnePlus X Themes and Apps] demolatorul:
Same thing happens to me, I'm on purity ROM with bluespark r108

Trimis de pe al meu ONE E1003 folosind Tapatalk
[OnePlus X Themes and Apps] Tiongkia:
Understand from op that this mod forces jpeg to 100%. But in cpu x, it indicates as 85. See screenshot.

Is cpu x wrong?

Also i didn't see jpeg quality in build prop.
[OnePlus X Themes and Apps] TheDj408:
Moving black bars in photo & video both! Tried flashing 60Hz antibanding! Still same! & yes this is in artificial lighting so cant be fixed by the developer but it works fine with that lighting for multiple other phones! Any solution?
[OnePlus X Themes and Apps] matwaking:
Maybe cpu x is getting info from camera app or somewhere else,but its already told in op that jpeg quality is forced to 100%,so why bother
[OnePlus X Themes and Apps] faldo:
Same here, using CM13.
[OnePlus X Themes and Apps] Sultanxda:
Last time I checked, HDR was broken in some Marshmallow ROMs. This has nothing to do with my camera HAL, so please stop reporting it here.
[OnePlus X Themes and Apps] Tiongkia:
I installed camera mx from play store. Hdr didn't crash. It only crashes in oss camera and google camera
[OnePlus X Themes and Apps] ERRORR2:
HDR works perfectly on latest CM13 in Snapdragon and ColorOs cameras
[OnePlus X Themes and Apps] awildsloth:
Exodus ROM?

Enviado do meu ONE E1003 através de Tapatalk
[OnePlus X Themes and Apps] ERRORR2:
I don't know how it works on Exodus. I never installed this ROM. I'm on CM 13.
[OnePlus X Themes and Apps] davidcantillo:
HDR is over saturated! Like REALLY REALLY saturated! Why?
[OnePlus X Themes and Apps] Sultanxda:
If I knew why, then I would've fixed it already.
[OnePlus X Themes and Apps] Mr_Comple:
You have achieve to unlock all the abilities this camera offers...!

An over saturated HDR is not going to stop me for flashing this mod.

I you find a way to fix this its ok. but nevertheless you make me to wanna take photos again with my X.!
[OnePlus X Themes and Apps] faldo:
Just a hint, considering most ppl here most likely use CM13 or other AOSP, if you don't want ppl reporting bugs about it you might wanna consider writing about it in OP :)

Cheers!
[OnePlus X Themes and Apps] jonrodz:
Even if he writes it in the op that is not an issue with the hal, most people wont read it (like always) and will still posting that here. :)
[OnePlus X Themes and Apps] Sultanxda:
The anti-banding settings I wrote use the same values as Qualcomm's proprietary anti-banding algorithm. There is nothing more I can do to improve the anti-banding.

JPEG quality is silently forced to 100% all of the time.
[OnePlus X Themes and Apps] ashwinpilgaonkar:
[MENTION=4800121]Sultanxda[/MENTION] is there anyway you can decrease the ISO in auto mode?

Many times it uses an ISO much higher than what it used in stock. This results in lower image details and more noise.
[OnePlus X Themes and Apps] Francis Tony:
The install keeps failing , any fix?
[OnePlus X Themes and Apps] Sultanxda:
So you can hold your phone perfectly still for 1/10th of a second while taking pictures?

This device does not have OIS, so faster shutter speeds are the only way to compensate for motion blur. Faster shutter speeds are required in auto mode for other important reasons as well.

You can manually reduce the ISO if you want.

Try downloading it directly to your device again.
[OnePlus X Themes and Apps] ashwinpilgaonkar:
When I tried clicking pics without using your HAL, I never got any motion blur. The viewfinder was smooth as well.

But the ISO in Auto was still much lower (mostly in artifical lightning and in low light) than what it is with your HAL.

There's quite a noticeable difference when the two images are compared.
[OnePlus X Themes and Apps] Sultanxda:
What was the exposure time and ISO for each image?
[OnePlus X Themes and Apps] Francis Tony:
Tried Downloading it directly , still shows install failed.

please help, do i need to root?
[OnePlus X Themes and Apps] Kéno40:
No just a custom recovery. Did you read the first page ?
[OnePlus X Themes and Apps] sarthakspiker:
Can someone link a working OPPO cam or colorOS cam to use with this HAL..

Thanks
[OnePlus X Themes and Apps] jandurek:
I'm experiencing something similar to [MENTION=5417408]ashwinpilgaonkar[/MENTION]. On stock, I was able to get photos without motionblur AND with a sane amount of noise. With this HAL, I have to choose between low ISO (=less noise) or sharpness. On Auto setting, I'm getting a lot of noise on every single photo, even in daylight (though cloudy) conditions.
[OnePlus X Themes and Apps] Sultanxda:
This is not useful information. I need the exposure time and ISO for the photo, and maybe the photo itself.

I consider exposure times of 1/30th of a second and shorter to be sufficient for counteracting motion blur. If you think otherwise, then I need to know exactly what exposure times you're using to get better photo quality without motion blur.
[OnePlus X Themes and Apps] ashwinpilgaonkar:
Im free tomorrow. I'll do a comparison and send you the images.

Is it possible to keep the auto mode for still camera the same as stock and only mod it for video? Or does a change in one reflect on the other?
[OnePlus X Themes and Apps] Sultanxda:
It's possible, but I'll never consider it. 1/10th of a second is far too long; so long that it significantly impacts the speed of our phase-detection autofocus system. The highest I'm willing to go is 1/20th of a second.
[OnePlus X Themes and Apps] Francis Tony:
Okay , i tested it , i really loved it.

how do i remove it?
[OnePlus X Themes and Apps] :
You must reflash the ROM back (you can dirty-flash it, I guess).
[OnePlus X Themes and Apps] davidcantillo:
Fair enough. Im sorry, I didn't want to sound rude.

I'll avoid HDR for now. I love recording in 4K :D
[OnePlus X Themes and Apps] fretka963:
I wanted to do the same so I dirty flashed the ROM (from the official website) with all other goodies (super-su, xposed etc.) and the result was success with no data loss and camera got back to normal ;) nothing to loose :)
[OnePlus X Themes and Apps] Francis Tony:
Did the same ;)
[OnePlus X Themes and Apps] Pejpi:
So i recently dirty flashed temaseks CM13 grom v4.6 to v5.4, flashed this camera Hal again...and only when Recording High framerate @60fps the camera starta normal Recording And after a few seconds it just ads green/blue colors imensly into the Recording...any tips?

Besides reflashing the whole ROM from scratch.

Cheers in advance.
[OnePlus X Themes and Apps] :
Hello there,

I flashed the mod and it seems fine. But, I am curious about something. Does this mod upscale the 1080p recorded video into 4K or does it record 4K video?

Thanks!
[OnePlus X Themes and Apps] adity:
I flashed back to oos today after a long time. There is no google camera available on play store. Any reason why this is happening?

Can someone provide me the apk?
[OnePlus X Themes and Apps] 73IGH:
http://www.apkmirror.com/apk/google-inc/camera/

Download v2. 7

Newer versions are for Android 6+ only.

I personally find stock camera better, with this hal and latest blu-spark kernel everything is working.
[OnePlus X Themes and Apps] ukanth:
Direct link works, it's been removed from search

https://play.google.com/store/apps/details?id=com.google.android.GoogleCamera
[OnePlus X Themes and Apps] Sultanxda:
New build uploaded. Since many of you have requested it, I have made the anti-shake algorithm less aggressive. As a result, your photos will look better and have much less noise. Image clarity in general should also be improved in this new version.
[OnePlus X Themes and Apps] Jude Aranha:
So, what is the loss in making it less aggressive ?

I'm not complaining or anything, just for knowledge purpose.

~Tapatalk'd v¡a my OnePlus X
[OnePlus X Themes and Apps] Sultanxda:
Your photos will now be more susceptible to motion blur.
[OnePlus X Themes and Apps] Jude Aranha:
Thanks for the confirmation.

~Tapatalk'd v¡a my OnePlus X
[OnePlus X Themes and Apps] submundo:
Anyone knows?
[OnePlus X Themes and Apps] Sultanxda:
This mod does not upscale 1080p into 4K; it records actual 4K video.

Upscaling 1080p into 4K doesn't really make sense...
[OnePlus X Themes and Apps] :
I know that it doesn't make sense, but why OnePlus didn't enable this feature, since it doesn't need better equipment?
[OnePlus X Themes and Apps] Lazy Rich:
I think because this is a midrange phone and midrange phones normally don't record in 4k. That's one reason less to buy the more expensive OPT.
[OnePlus X Themes and Apps] :
Yeah, you are right. Didn't think of that. OPX is already among the best mid range phones, doesn't really need 4K to prove that ?
[OnePlus X Themes and Apps] Firefly1337:
http://xdaforums.com/showpost.php?p=65334810&postcount=11

Next time please look first before posting :)
[OnePlus X Themes and Apps] ashwinpilgaonkar:
[MENTION=4800121]Sultanxda[/MENTION] what will happen if you disable the anti shake feature altogether?

Yes, the viewfinder lags in low light but it's still pretty easy to get a good picture without any motion blur even if the phone shakes a little bit.

Blur in photos is noticeable only if the phone really shakes a lot, which doesn't happen under normal conditions.

Also, are you using some kind of denoise algorithm? The pics without the HAL look so much more noisy.
[OnePlus X Themes and Apps] :
Sorry, didn't notice that...
[OnePlus X Themes and Apps] Sultanxda:
The autofocus system will turn into trash in low light if my anti-shake algorithm is disabled. With the new build, anti-shake goes to the edge of what is needed to reduce motion blur and ensure timely autofocus in low light, so going any further than that is not something I'm willing to do.

If you can capture photos with no motion blur at 1/10th of a second exposure, then you should become a surgeon. I wasn't able to capture any blur-free photos at 1/10th of a second exposure, no matter how still I thought I kept my hands when holding the device. My anti-shake only tries to address minor motion blur that destroys fine details in photos; zoom in on your pictures and look at the finer details to see what I'm talking about.

The stock camera apps in the CM12.1 and CM13 ROMs I've seen here disable denoise by default, so I've forced denoise to always stay enabled from inside the camera HAL.
[OnePlus X Themes and Apps] danbrown162:
Much improves the camera quality with cm13. Many thanks for your time and effort you put into this mod :)
[OnePlus X Themes and Apps] Ciastek92:
Great work, Sultan. Both video recording and taking pictures is much better with this software. However, I've noticed that HDR gives too much orange color to photos(?). Look at these:
[OnePlus X Themes and Apps] feligoni:
Hi!! Been using it for a few days now and I have to say it really improves quality in both video and camera...

Just a question... Any app for good slow motion videos? On spadragon camera I can't get it to work and stock is really bad.

Thanks a lot! Grate work sultan
[OnePlus X Themes and Apps] 73IGH:
Slo mo works fine with this hal on oos with stock camera.
[OnePlus X Themes and Apps] Ciastek92:
Hey, today I've got very big delay when moving camera in recording mode (but not turned on). Does have that issue?
[OnePlus X Themes and Apps] sohaibshtf:
hey guys, do i have to root my phone or unlock bootloader, or i just flash it from recovery i know nothing about it butbi really wanna try it, please help me out
[OnePlus X Themes and Apps] Jude Aranha:
Root is not required i think, but you will have to unlock bootloader as you'll have to use TWRP to flash this.
[OnePlus X Themes and Apps] awildsloth:
If that's the case then he can boot TWRP through cmd and then flash the HAL without changing recovery or even rooting

Enviado do meu ONE E1003 através de Tapatalk
[OnePlus X Themes and Apps] valimot:
hi [MENTION=4800121]Sultanxda[/MENTION], thanks n good job,

i try to install on my OPX, but fail to install :crying::crying:

i used standard OPX Rom OOS v 2.2.0-x, locked bootloader with original kerner for OP,

thanks for help
[OnePlus X Themes and Apps] Kéno40:
:silly::silly::silly: Read posts just above :

You need Unlocked Bootloader & a custom recovery to flash it.

Usually, a stock recovery can just flash stock updates.
[OnePlus X Themes and Apps] valimot:
ooh OK,, thanks
[OnePlus X Themes and Apps] ashwinpilgaonkar:
Is there anyway to disable the denoise filter in your HAL or enable it on the stock CM13 HAL?

There are times like when there's plenty of sunlight where the noise is hardly noticeable but the denoise filter removes quite a lot of detail from the images (especially in selfies). So I'd prefer to have the option to enable/disable it when I want.

Is that possible?

BTW here's a pic (attached) I had clicked in very low light by keeping the phone in my hand using stock CM13 HAL, Snapdragon Canera. I can't seem to notice any motion blur in it. I'm not disagreeing with you or anything, it's just to clarify.

1/12 s

ISO-4653 (Auto)
[OnePlus X Themes and Apps] reebomber:
Yes, but what about on CM13?

I have Hydrogen OS 1.0 caneta, and video has a weird 90° rotation to it, mostly unusable for any video operation.

Google Camera doesn't have slo-mo, and last I tried, Snapdragon couldn't be installed on CM13.

---------- Post added at 09:13 PM ---------- Previous post was at 09:12 PM ----------

Same here, started noticing after last update.
[OnePlus X Themes and Apps] Pejpi:
Quick update:

A few days ago i flashed new rom (12.1) and flashed the recent camera hal as well.

But the problem still persists, when recording and when 60fps mode enabled the whole video just recordins with huge amounts of green color in the video.

If any one knows any solution i'm listening becouse I am all out of ideas for now.

cheers.
[OnePlus X Themes and Apps] ishmeet1995:
I flasheda zip of approx 498kb

But i cant see any app named hal

I am on stock(2.2.0)

Obvously rooted and used twrp to flash this file
[OnePlus X Themes and Apps] dadaz007:
It's not an app, it's library for camera. It's used by any camera app.
[OnePlus X Themes and Apps] ishmeet1995:
Ok

But i cant see any 4k option :/
[OnePlus X Themes and Apps] Kéno40:
Wipe cache app.

Did you flash it with twrp ? If with stock recovery, it's not installed
[OnePlus X Themes and Apps] ishmeet1995:
Wiping cache worked

Thanks

I think its pretty nooby?[emoji28]
[OnePlus X Themes and Apps] etoy:
many thanks [MENTION=4800121]Sultanxda[/MENTION], really miss your roms since i switched from OPO to OPX
[OnePlus X Themes and Apps] NeroD:
Wow awesome.. Nice to see you in opx forum.. Hoping for sultan cm rom for onyx.. Thank You.
[OnePlus X Themes and Apps] Mithrandir_:
Beautiful work Sultan, thanks!
[OnePlus X Themes and Apps] ashwin007:
Hey Sultan .Welcome aboard !! Great to have you here.
[OnePlus X Themes and Apps] Kéno40:
Slowmo are around 7.5 fps

"TimeLapse" are OK at 30.000 fps

4K & FHD varies between 29.500 and 30.500 fps. That always seems weired to me.

I have to test precisely, but Iso damages seemes to raise quickly in 4K too with this mod.
[OnePlus X Themes and Apps] saurabh40629:
works awesome on cm12.1 . Couln't be happier. The difference before and after the zip is phenomenal.
[OnePlus X Themes and Apps] Loureiro:
Slowmotion mode records at 30fps and does a post processing to reduce the playback time by around 1/3 , hence the final 7.5fps on playback.
[OnePlus X Themes and Apps] Kéno40:
Normal behaviour on OPX is capture at 120fps, then slowmo divided by 4 => 30 fps.

Edit : note that 120fps is limited to 720p on OPX in the stock app.
[OnePlus X Themes and Apps] artrokas:
Would it be possible to get 1080p 60fps recording without slomo ?
[OnePlus X Themes and Apps] Mithrandir_:
I can confirm that is not working on cm13
[OnePlus X Themes and Apps] Kiras_PL:
I installed this mod but i don't know how to use it :/ I've got OOS 2.2.0 and standard camera app. I cleared app data but i still can't find an option to switch to 4k. Where is it ? Can somebody help me ?

---------- Post added at 06:03 PM ---------- Previous post was at 06:01 PM ----------

nevermind - i've found it
[OnePlus X Themes and Apps] Loureiro:
Yes that how it works from stock.

With this MOD, it'll perform like i said on my last post. Didn't check if it's recording 1080p or 720p.
[OnePlus X Themes and Apps] Kéno40:
OK, it was just to be sure, it's clear for everyone.

Not possible to change settings on slowmo mode
[OnePlus X Themes and Apps] sanjay.ghanchi:
Clear image and slow motion seems to be working with hydrogen OS camera from oneplus x app and themes section

Great work sultan ... Thanks for it... Looking forward for more development .. :)
[OnePlus X Themes and Apps] ashwinpilgaonkar:
HFR video is now recording audio as well!

Using snapdragon camera, 60fps mode works but the video has a blue tint to it.

120 fps mode is sort of jittery and choppy even though Windows seems to detect that the video has been recorded at 85fps.
[OnePlus X Themes and Apps] bijgu:
First of all, a big thanks to you Sultan for giving us a little attention :D

Has anyone tested on ashwin's CM13?
[OnePlus X Themes and Apps] blackkn1ght2010:
Nicely done! although i rather have manual mode... Any idea on how to revert the changes?