yashsingh1/xdaforums huggingface dataset:
[Zenfone 5 Android Development] herecomesmaggi:
U have to flash gapps b4 first boot or it will not work properly. I suggest, flash AICP then fix webview v1 then gapps, then su then Xposed...

Go to open gapps and download for 5.1.1 x86 package.
[Zenfone 5 Android Development] rafabsd:
This update v2 fix random reboots?

Enviado de meu ASUS_T00F usando Tapatalk
[Zenfone 5 Android Development] TheAreS:
I have the same random reboot issue and if your talking about fixwebview_v2, no it wont fix it :(
[Zenfone 5 Android Development] Edorewiel:
Stock rom based aosp 5.0.2.

Works the tank0412 's build ?
[Zenfone 5 Android Development] dgadelha:
No

GPS and FM are deeply integrated on framework and Bluetooth.apk also

I'm sorry
[Zenfone 5 Android Development] roxas76927:
It turned out to be xposed modules which were causing the issue. Now finally I can run this rom perfectly. Many thanks for the quick help bro :D
[Zenfone 5 Android Development] jephimax:
Disable 'ambient display' to get rid of the random reboots.
[Zenfone 5 Android Development] tiagoclc:
GPS

Hi! I saw anywhere that CM gps problem could be related to SELinux and will probably works with it disabled.

I saw too that the gps problem with MOTO G CM Builds could be fixed with fastboot erase modemst1 and fastboot erase modemst2.

Did you ever take a look at this:?

https://github.com/thuutin/android_device_asus_a500cg/tree/master/blobs

https://github.com/thuutin/android_device_asus_a500cg/blob/master/BoardConfig.mk

https://github.com/thuutin/android_device_asus_a500cg/blob/master/device.mk

https://github.com/thuutin/android_device_asus_a500cg/blob/master/configs/gpsd
[Zenfone 5 Android Development] Ades69:
Bug!!

Good work! Amazing! But please fix it, sometimes my phone is reboot own!! Thanks
[Zenfone 5 Android Development] tank0412:
Just stop posting same message in different topics.

It is not fault of Selinux. It is a fault of gps,fm and bluetooth libs/apps because it is integrated very deep in framework.
[Zenfone 5 Android Development] dgadelha:
It's funny how he does that.

Did you see his answer to me on MY thread? [MENTION=1350000]tiagoclc[/MENTION] if you are so right about your answer, why don't you try to fix it yourself then? You come to us saying that, and when we answer you, you come with that ignorance. Don't expect anything from us, we don't work for you neither for Asus or CyanogenMod, but show some respect.
[Zenfone 5 Android Development] amit kattal:
5+ hours screen on time with this rom

great rom, i am getting 5+ screen on time, with this rom with default kernel and some tweaks,

View attachment 3698338

View attachment 3698339

View attachment 3698340
[Zenfone 5 Android Development] Gexg:
can u please put the link for SU to be flash:)
[Zenfone 5 Android Development] abw_bw:
http://download.chainfire.eu/supersu-stable
[Zenfone 5 Android Development] Gexg:
no mD5 file found??? any help:crying::crying::crying::crying:
[Zenfone 5 Android Development] jephimax:
Anyone found a fix of the touchscreen bug after receiving calls?
[Zenfone 5 Android Development] rafabsd:
Lol!! you can explain for me the config that you do? You use a ZenFone 5? Thanks

Enviado de meu ASUS_T00F usando Tapatalk
[Zenfone 5 Android Development] Gexg:
After a constant struggle i have finally done it. Thank God.

And i'd like to make sure everything is in order.So i can make the most outta this rom.

1. Flashing Gapps but there's only Playstore and its working fine. Others we'd have to install manually

2. I cannot find the TWRP folder in sdcard, needed for aroma file manager (it seems)

3. Same with Gapps, Asus in-built must be installed manually

i'm don't kid around
[Zenfone 5 Android Development] amit kattal:
yeah i use zenfone 5, the thing that helped me achieve that was i disabled system animations and i disabled every google play service ,
[Zenfone 5 Android Development] amit kattal:
does anyone know how to solve screen lock on 2g bug?
[Zenfone 5 Android Development] Stonecaper:
Issues faced so far -

1. Random reboots, I got both patches flashed and ambient display disabled

2. Sudden freezes, the phone would freeze suddenly ( if Media is playing, the frame would freeze and sound would play in loop). Solved by a forced restart.

3.Erratic touchscreen behaviour while on call.this is by far most annoying. The screen would open clock, start a event or some other crap everytime I take the phone to my ear.

4.Whats app call volume is lower than regular call volume.

5. Cant disable a simcard

6.Speaker volume is pretty low, even v4a wont help :(
[Zenfone 5 Android Development] Gexg:
Okay here's my prob...while watching movies or listening songs or doing some **** my phone just lock itself ...this is really annoying...and when I lock it just open itself up again....frustrating... Please help me
[Zenfone 5 Android Development] dgadelha:
1. Try disabling Day Dreams, also erase cache.

2. That's because of bootloader unlock?

5. That's an issue of x86 devices, probably won't be fixed. It's a bug even on Zenfone 2.
[Zenfone 5 Android Development] Stonecaper:
The how the Recreated Remix Leopard Rom would do it?

Also, any workaround for the silent speaker?
[Zenfone 5 Android Development] dgadelha:
Because it is a Stock-Based ROM and ASUS has a custom code to make it work.

Also, for low audio, try this tool (I've not tested it, but people say it works)
[Zenfone 5 Android Development] StefanoZen5:
How to make asus pixelmaster camera save photos on sdcard?
[Zenfone 5 Android Development] abw_bw:
http://xdaforums.com/showpost.php?p=65417134&postcount=3

or you can use XinternalSD xposed module
[Zenfone 5 Android Development] TongYabgu:
when ı was set up my phone(language vs at first) ı take google play services stopped . How can ı fix it
[Zenfone 5 Android Development] :
I have the same Problem flash fix 1 and make factory reset
[Zenfone 5 Android Development] httam3006:
i can't open 2g/3g on my phone althougt it has signal

Gửi từ ASUS_T00F của tôi bằng cách sử dụng Tapatalk
[Zenfone 5 Android Development] sharvana:
hi StefanoZen5

Am too having the same problem, ear phones button is not at all working... [MENTION=5392204]quanganh2627[/MENTION] can yo help us to solve this bug??? :(:(
[Zenfone 5 Android Development] StefanoZen5:
If i return to stock rom i lose data?
[Zenfone 5 Android Development] mzj4213:
yea
[Zenfone 5 Android Development] kloroform:
use Titanium Backup to backup your data, then restore it in your new ROM
[Zenfone 5 Android Development] hrocks:
Next launcher 3d

Pls anyone tell me why NEXT LAUNCHER 3D is not working in this ROM ,it's crash every time whenever i open the app. Any solution....
[Zenfone 5 Android Development] quanganh2627:
i just realized this idea recently when look at our [MENTION=5875920]tank0412[/MENTION] & [MENTION=6292495]dgadelha[/MENTION] M's src, but not test, coz my phone has been in test state, and still stuck(s..hi..t [emoji21] ). if you don't mind, plz test it and share here. Just override 3 folder in system/usr( as pic attached below) by ones from stock romAnd it's safer and quicker if u do in TWRP (assuming on pc, u open terminal/command-prompt at extracted stock rom folder)

adb push system/usr/idc/ /system/usr/idc/
adb push system/usr/keychars/ /system/usr/keychars/
adb push system/usr/keylayout/ /system/usr/keylayout/

then reboot to test. im pretty sure i was using headset key till RR beta 5 build, then dunno it's been disabled when & why. Maybe started since stock .78 released, or when I tried to port zenmotion from our upgrade gen device-Z00D.

that's correct. in the past, It's successful upgraded from stock 5.0 to RR5.1, if phone hasn't encrypt, and i always recommend do a dirty-flash to get the best results. but now we can't do that, unless upgrade from the the same Rom, i.e. cm -> cm, aicp->aicp, but not even rr -> aicp. maybe it's changed by Google for security reasons, i guess.
[Zenfone 5 Android Development] akiralee:
[MENTION=5392204]quanganh2627[/MENTION] : this rom wont update anymore?...
[Zenfone 5 Android Development] TheAreS:
Headphone buttons (hardware) not working.

And when the next update will release?
[Zenfone 5 Android Development] Amincha:
help me

my zenfone 5 cant connect to camera after i flashed this rom , how to fix it ?
[Zenfone 5 Android Development] Gexg:
Does anyone else got an OTA error?
[Zenfone 5 Android Development] mzj4213:
of course as our roms are unofficial
[Zenfone 5 Android Development] adamilmanns:
Update AICP 11 ( Marshmallow )
[Zenfone 5 Android Development] adhit_barker:
Can u update AICP to android MM ??
[Zenfone 5 Android Development] LuanHalaiko:
I am making it

---------- Post added at 00:30 ---------- Previous post was at 00:29 ----------

I will do it :)
[Zenfone 5 Android Development] monnett:
Cool..ive been waiting for aicpMM. Hope can release ASAP
[Zenfone 5 Android Development] LuanHalaiko:
Well I did sucefully compiled it, but it needs a new kernel, so I'm working on it :)
[Zenfone 5 Android Development] adamilmanns:
Boot up ?
[Zenfone 5 Android Development] LuanHalaiko:
Yes and no, it needs a other kernel to boot like this AICP, it just stays on the bootanimation, I'm working on it ;)
[Zenfone 5 Android Development] Stonecaper:
Is this rom dead or what?

Whats the point of including an OTA app if no OTAs are coming, ever?
[Zenfone 5 Android Development] LuanHalaiko:
no one is updating this rom, the project is abandoned, you should use my AICP with android marshmallow that is updated
[Zenfone 5 Android Development] gacky1601:
So can it uses on ZenFone4?
[Zenfone 5 Android Development] tank0412:
What???

No...
[Zenfone 5 Android Development] Stonecaper:
well, anybody?
[Zenfone 5 Android Development] Stonecaper:
any fix found for the 2g lockscreen bug?
[Zenfone 5 Android Development] aditya510:
Will Opengapps-x86(December Build) work with this ROM?
[Zenfone 5 Android Development] tank0412:
I think that it will work.
[Zenfone 5 Android Development] kuranzi:
Anyone test random sceen lock on 2G signal on this rom ? This bug appear on RR ...
[Zenfone 5 Android Development] tank0412:
I does not face this issue but maybe i am very lucky today.
[Zenfone 5 Android Development] kuranzi:
Ookaay, timw to download this new rom :D
[Zenfone 5 Android Development] adamilmanns:
I faced it too. But its not big problem for me. Im using wifi.
[Zenfone 5 Android Development] FaizK:
Waiting for vibration fix or update.

The rom is best for daily use.

Bug for - random reboot (fixed by tutning of ambient display) ,faced freeze issue after restarting from bootloader(touch was dead) th e third restart fixed the issue.
[Zenfone 5 Android Development] kuranzi:
U mean this bug is appear on this room ?, bad luck for me, 3G signal not stable here, 2G is my main signal, hope dev will fix it on next update...
[Zenfone 5 Android Development] Ale uto:
Vibration not working on touch or only vibration on call only
[Zenfone 5 Android Development] pedromd:
Bugs?
[Zenfone 5 Android Development] tank0412:
Like RR + vibrator (not sure) + Bluetooth freeze sometimes
[Zenfone 5 Android Development] Ghi98:
Audio lag in game is fixed in this rom ?
[Zenfone 5 Android Development] ChristopherXI:
Can't enable Viettel Telecom Billing service. I can do this in stock rom
[Zenfone 5 Android Development] quanganh2627:
U make me find hard to know your new service. It's complete a private service between viettel & Google, and on testing status right now. I guess you must extract any Gapp family from stock then install it. On stock, Gservices have been integrated into framework very deep, while we can't do the same thing with any custom Rom.

Gửi từ ASUS_Z00AD của tôi bằng cách sử dụng Tapatalk
[Zenfone 5 Android Development] quanganh2627:
I still use the very old Gapps Pico package , which was used with RR, but i updated OP to lastest yet. Why u want a older then waste your time to update Gapps later via Gplay?

Gửi từ ASUS_Z00AD của tôi bằng cách sử dụng Tapatalk
[Zenfone 5 Android Development] adamilmanns:
[MENTION=5392204]quanganh2627[/MENTION] so u are stopped building M ?
[Zenfone 5 Android Development] FaizK:
Please provide the vibration fix [MENTION=5392204]quanganh2627[/MENTION]
[Zenfone 5 Android Development] shobint7:
Almost all 2nd gen zenfone series have got cm13, now recently zenfone 2 laser!!,still senior members are trying hard!! Good work.
[Zenfone 5 Android Development] arieph7x:
[MENTION=5392204]quanganh2627[/MENTION] do u continue RR or AICP??? #justAsk.... :) :)
[Zenfone 5 Android Development] dhirajahuja432:
[MENTION=260193]quanganh[/MENTION] Can I dirty install from rr?
[Zenfone 5 Android Development] minhduongtrung:
Vibration when used Multifunctiional kernel by X Anwar:

http://xdaforums.com/zenf...2#post64313512
[Zenfone 5 Android Development] Ale uto:
X anweri kernel work on this ROM ?
[Zenfone 5 Android Development] quanganh2627:
My Z5 has WiFi dead, so u can use wifi, can't u? BTW, vibra issue fixed, uploading
[Zenfone 5 Android Development] LuanHalaiko:
If I compile a rom with tran huu tin device tree, it will not be audio lag in games right?
[Zenfone 5 Android Development] quanganh2627:
Not sure. Actually my tree forked from his too. I am testing A8 only, and no problem with it
[Zenfone 5 Android Development] monnett:
Will SMAI kernel work on thir rom sir?
[Zenfone 5 Android Development] tank0412:
This rom is a CM-based rom so all kernels for CM and CM-based roms will work on AICP.

Yes.
[Zenfone 5 Android Development] @Cracker747:
How about BT, can I transfer to other devices sir??
[Zenfone 5 Android Development] quanganh2627:
Nope, for all ROM except AICP, unfortunately. If u wanna keep your user apps & data, use titanium.
[Zenfone 5 Android Development] quanganh2627:
Yes, although sometimes it takes a long time to turn on bt
[Zenfone 5 Android Development] @Cracker747:
Thanks sir, Downloading it now ...
[Zenfone 5 Android Development] Ale uto:
Aaaaaa, why mobile data not working on my phone ?T_T
[Zenfone 5 Android Development] tank0412:
You should set APN manually.
[Zenfone 5 Android Development] Steratul:
Are you done uploading the one with fixed vibration?
[Zenfone 5 Android Development] Ale uto:
OK thanks Tank. God bless
[Zenfone 5 Android Development] tank0412:
Yeah. He uploaded new build in his AICP folder.
[Zenfone 5 Android Development] Steratul:
Oh. Thank you! Btw, What's thr difference between the 2 rom zips there? Also, do I need the boot.aicp.zip also? What's it's purpose? Sorry for noob question..
[Zenfone 5 Android Development] tank0412:
I flashed only one zip with rom and its booted.
[Zenfone 5 Android Development] Ale uto:
After flash xanwer kernel vibration still not working

---------- Post added at 06:32 AM ---------- Previous post was at 05:57 AM ----------

Oh its working now
[Zenfone 5 Android Development] tank0412:
[MENTION=5392204]quanganh2627[/MENTION] Webview is dead on your new build of AICP.

Pls re-build it.
[Zenfone 5 Android Development] milano88:
yeah and busybox not work
[Zenfone 5 Android Development] sayan7848:
Google Play FC

help :crying::crying:

logcat attached

https://drive.google.com/file/d/0B1IvtR9WrLXjM0hkUGpZR3VwdVE/view?usp=sharing
[Zenfone 5 Android Development] adamilmanns:
What happen if webview dead ? Good for daily driver or not ?
[Zenfone 5 Android Development] Steratul:
What do you mean by Webview? I just finished downloading. Should I flash it or not? My current ROM freezes occasionally and it's really an inconvenience..
[Zenfone 5 Android Development] tank0412:
OMG. If Webview is dead, all browsers will be dead.
[Zenfone 5 Android Development] Steratul:
Noooooooooooo
[Zenfone 5 Android Development] milano88:
to fix webview use my mod Webview

download zip and replace files from rom.zip

note: webview updated to latest version
[Zenfone 5 Android Development] adamilmanns:
Work ?
[Zenfone 5 Android Development] milano88:
yes work
[Zenfone 5 Android Development] adamilmanns:
Okay thanks
[Zenfone 5 Android Development] shobint7:
Yaa browser is dead!! And google play service is also not working!
[Zenfone 5 Android Development] Ale uto:
[emoji26] [emoji27]
[Zenfone 5 Android Development] adamilmanns:
This for fix http://xdaforums.com/showthread.php?p=65437240

---------- Post added at 11:49 AM ---------- Previous post was at 11:26 AM ----------

[/COLOR [MENTION=5289472]milano88[/MENTION] its not work bro -_-. Give some prof if work on u. Screenshot

[MENTION=5289472]milano88[/MENTION]
[Zenfone 5 Android Development] akc1329:
Is there audio lag during video playback in this rom?
[Zenfone 5 Android Development] ChristopherXI:
Thanks . This method works like a charm !

---------- Post added at 01:41 PM ---------- Previous post was at 01:40 PM ----------

To workaround the playback lag. Go to the Developer settings and Enable 'Use AwesomePlayer'

---------- Post added at 01:45 PM ---------- Previous post was at 01:41 PM ----------

To all the people out there PLEASE STOP WHINING FOR CM13 OR MARSHMALLOW. For God's sake. The Developers will let us know when will they release it or if there are progress on the project
[Zenfone 5 Android Development] Boomshiva:
Can someone guide me which files to replace after downloading the webview zip . Plz elaborate

Thank you
[Zenfone 5 Android Development] pedromd:
I install AICP rom more I get random freezes in less than two hours due to unlocked bootloader I had hope that this does not happen in this rom 'm stuck in stock asus
[Zenfone 5 Android Development] shobint7:
Thanxx man!! Your great.I downloaded this zip extracted, with aicp ROM and flashed it again.by this browser and play service worked.by the way i have made a zip!! Thanks sir.
[Zenfone 5 Android Development] tank0412:
You know, few minutes ago i successfully built Marshmallow kernel using Lollipop kernel sources 3.24. for Zenfone 5.

I did not patch kernel sources for Marshmallow. (Is it needed?)

If you have idea, PM me.

Anyway, i consider to share my Marshmallow kernel. I do not know what to do with it next. (I plan to build AOSP 6.0) But anyway:

https://drive.google.com/open?id=0B-Fin8UxrD6POUFrN2xTdjFPUDg

P.S. I checked: kernel is flashable but i got a very strange bug on the Asus OEM l;ogo. It is really strange. Check it by yourself.
[Zenfone 5 Android Development] FaizK:
Is it bootable or still stuck on oem logo?
[Zenfone 5 Android Development] tank0412:
I must build AOSP 6.0 to check. xD

But i flashed it on AICP 5.1.1.

Oem logo became very unstable. It rebooted every second.
[Zenfone 5 Android Development] pedromd:
Fix frezes by unlock bootloader please ):
[Zenfone 5 Android Development] FaizK:
Best of luck!!!

Hopefully we will get cm 13/Marshmallow soon.
[Zenfone 5 Android Development] milano88:
Flashable fix for Webview made by me.

1. Flash AICP rom

2. Flash Gapps

3. Flash SuperSu

4. Flash Xposed

5. Flash FixWebview

6. Wipe Cache/Dalvik

7. Done

DOWNLOAD
[Zenfone 5 Android Development] ChristopherXI:
Replace it with the files from the zip to the AICProm.zip

---------- Post added at 03:27 PM ---------- Previous post was at 03:15 PM ----------

I can't flash your zip. I replace the files to the rom.zip
[Zenfone 5 Android Development] minhtri109:
File fix flash TWRP https://drive.google.com/open?id=0B7Py5ad2aHwKb3JKc3Z6ZHJPdk0
[Zenfone 5 Android Development] abw_bw:
If test in RR 5.6.0 quanganh build it will boot? :D
[Zenfone 5 Android Development] Boomshiva:
Ok so first I have to extract both (rom and webview) then replace file in rom and then zip the rom again . Right?
[Zenfone 5 Android Development] tank0412:
I do not know. He did not shared his rr6 builds.

I have already sent my kernel to quanganh2627. I hope that it will help him a bit.
[Zenfone 5 Android Development] milano88:
try again FIX
[Zenfone 5 Android Development] abw_bw:
Yeah, i hope RR 5.6.x will booted and him continued developing RR [MENTION=5392204]quanganh2627[/MENTION] :)
[Zenfone 5 Android Development] adamilmanns:
[MENTION=5875920]tank0412[/MENTION] check your pm

Btw, in your kernel, what did changed ?
[Zenfone 5 Android Development] tank0412:
It is just my first Marshmallow kernel. Nothing else.
[Zenfone 5 Android Development] LuanHalaiko:
yeah it dosen't have, but geometry dash, bomber friends, real racing 3 haves, and asphalt 8 have lags for me, why?
[Zenfone 5 Android Development] tank0412:
Maybe it happened due to blob files.

You should test RR build based on 3.23.40.60 blobs.
[Zenfone 5 Android Development] shobint7:
Srry for asking noob question!! But how did zenfone 2 got enough source code? Did asus provided it?? If yes! Then why not zenfone 5??
[Zenfone 5 Android Development] LuanHalaiko:
same issue, I tested all versions, since beta 4
[Zenfone 5 Android Development] adamilmanns:
[MENTION=5875920]tank0412[/MENTION] how did u make openssl and minigzip ? I still stuck at there
[Zenfone 5 Android Development] tank0412:
Yeah. It compiled on my PC without that problems. I deleted/added many folders in my Android sources so i do not remember what i did to fix it.
[Zenfone 5 Android Development] adnaanbheda:
Bug : WPS Office app isn't working

Error "Unfortunately, WPS Office has stopped" when I try to open the app. [MENTION=5392204]quanganh2627[/MENTION] BTW, The best Custom ROM that I've used on Zenfone 5. Although, I have to ask, Why can't you fix the 1080p recording lag ?

Keep up the good work. :)
[Zenfone 5 Android Development] quanganh2627:
This link is my unbootable RR5.6, y you can test your kernel with it.https://drive.google.com/folder/d/0BwEWY6gMvYOeSEQ3RUREMlFfUmc/edit

Gửi từ ASUS_Z00AD của tôi bằng cách sử dụng Tapatalk
[Zenfone 5 Android Development] tank0412:
Thanks. I will test it tomorrow. (I am sleeping now)

And can you help me to fix error during AOSP 6.0 building? More info i sent to your e-mail.
[Zenfone 5 Android Development] quanganh2627:
It's reboot like that due to selinux, thus even we can not get log to know what wrong.

Gửi từ ASUS_Z00AD của tôi bằng cách sử dụng Tapatalk
[Zenfone 5 Android Development] tank0412:
I think that Marshmallow selinux should be added to Lollipop kernel sources or something like this.
[Zenfone 5 Android Development] abaka123:
Thankyou for your great work. I really love it! This is my new favorite rom.
[Zenfone 5 Android Development] Oculam18:
Thank you, good rom, beautiful rom, good job.
[Zenfone 5 Android Development] pedromd:
Freze cause by unlock bootloader :confused:
[Zenfone 5 Android Development] pakpenyo:
Yes and no.

Yes because i have random freeze with all custom rom (rr, cm by dgaldheha and xhook, and this aicp).

No, because i have no random freeze with stock kk.

I'm using same unlock bootloader, official unlock apps, and already trying all unlock bootloader method and version i have found in the internet.

Sent from my ASUS_T00F

---------- Post added at 02:15 AM ---------- Previous post was at 02:14 AM ----------

Yes and no.

Yes because i have random freeze with all custom rom (rr, cm by dgaldheha and xhook, and this aicp).

No, because i have no random freeze with stock kk.

I'm using same unlock bootloader, official unlock apps, and already trying all unlock bootloader method and version i have found in the internet.

Sent from my ASUS_T00F
[Zenfone 5 Android Development] johnny132:
after turning airplane mode off, does it need to reboot to find sim cards ?

because previous RR ROM have this bug
[Zenfone 5 Android Development] shobint7:
I checked the kernal is quite unstable!! It restart OEM logo every second with RR 5.6.0

My suggestion is that why can't you try making system folder to system.DAT and then check it will compress the ROM and even I checked all marshmallow ROM it is converted into .DAT format so plzz try
[Zenfone 5 Android Development] ShuviterDjogja:
In FB Group of Z5 indonesia,someone told that devices with JB at 1st buy (shipping),no freeze problem when use RR.

Don't know exactly, but maybe u can try to downgrade your device to JB ,and flash some CM12.1 based customROM again sir [MENTION=6844478]pakpenyo[/MENTION]
[Zenfone 5 Android Development] quanganh2627:
I forgot check webview, sorry all you guy. Flash my fix platform+webview+apn(no need add manually anymore) here or attach below