yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] mr.phantom:
Click on "Need Help" and it will automatically allow you to send email.

It looks like no application is working with that version. I'll check it out. Thanks!
[Xposed Framework Modules] mr.phantom:
Now, it's working fine for me. Did you reboot your device after updating it ? Because I found that Android was caching one thing due to which notification was not being shown up until I rebooted my device. Clear data/cache of the application and reboot your device.
[Xposed Framework Modules] Francescorm76:
I try thank

Inviato dal mio SM-G935F utilizzando Tapatalk

---------- Post added at 03:46 PM ---------- Previous post was at 03:08 PM ----------

I tried master but nothing [emoji21].. Clear data and cache of applications (Facebook /OTVD /OTVF)....Working only in Internet (you tube and video streaming general)... However it is not a big problem for video Facebook ... I download via links from the Internet or connecting me in Facebook from web .. Thanks again

Edit.. With version 4.0 all ok

Inviato dal mio SM-G935F utilizzando Tapatalk
[Xposed Framework Modules] mr.phantom:
I released version 4.1/4.2 because it contains fixes for latest Facebook version available on the playstore. If version 4.2 is working for other applications like Youtube and Browser, then it really should work on Facebook.
[Xposed Framework Modules] Francescorm76:
I'm still in version 97 ... the previous one .. Maybe that's the problem..

Inviato dal mio SM-G935F utilizzando Tapatalk
[Xposed Framework Modules] mr.phantom:
No, it should work on previous versions. Moreover, I downgraded my Facebook to version 97 and it's still working for me.

Moreover, can you please send me new logs to onetapvideodownload@gmail.com ? Just click on Need Help button.
[Xposed Framework Modules] Francescorm76:
I'll try to uninstall and reinstall OTVD and OTVF..... Thanks again

Inviato dal mio SM-G935F utilizzando Tapatalk

---------- Post added at 04:41 PM ---------- Previous post was at 04:29 PM ----------

Email with log sent

Thank again

Inviato dal mio SM-G935F utilizzando Tapatalk
[Xposed Framework Modules] koko115:
From today update facebook from play store facebook module dont work ;-(
[Xposed Framework Modules] aryantyagiji:
Need update

Stopped working after latest youtube update
[Xposed Framework Modules] westeight:
Working fine here (HTC 10, LeeDroid, Xposed 86.6)
[Xposed Framework Modules] Artieza:
Why so much wakelocks while Internet was off?
[Xposed Framework Modules] Strike3k:
I don't get the xposed module descriptions for the youtube and the facebook versions 4.0 not 100%:

Does that mean that I can delete the xposed modules for facebook and youtube and only install the Play Store app to download Facebook and Youtube videos?

Atm it does not work for me with the modules installed.
[Xposed Framework Modules] srijith.407:
I do not see any notification while viewing videos from YouTube app or Facebook app.. I can see the notification while watching videos on browser.. I am using MIUI 8. Any suggestions?
[Xposed Framework Modules] stefanwlb:
Youtube new version don't work.
[Xposed Framework Modules] mr.phantom:
Try clicking on "Update Hooks" for updating Youtube Hooks and then reboot your device. If it still doesn't help, click on Need Help and send me email. It will automatically attach logs along with that.

For Facebook, I'm using staged rollout. So, 20% of the users have got the update. And others have yet to get that.

Which version are you using right now ? Latest version is 4.3

Please read above post for facebook :)

Wow, I didn't know that. I'm using a library by Evernote Organisation which allows me to schedule job. So, I have scheduled Update Hooks job. All of those wakelocks are from that library. I'll try replace it with some other library.

Well, yeah those descriptions are indeed confusing. You require both facebook and youtube modules in order to download videos from facebook and youtube. Please read above replies to know why you are not able to download facebook and youtube videos.
[Xposed Framework Modules] Artieza:
Maybe, you just should setup this library a bit. :confused:
[Xposed Framework Modules] mr.phantom:
Yeah, don't worry. I'll look into this matter for sure.
[Xposed Framework Modules] sagar_here:
facebook module not working now

fb version 90.0.0.18.70

using miui8, mi5
[Xposed Framework Modules] Artieza:
Try to clean OTVD's data and reboot system.
[Xposed Framework Modules] sagar_here:
I have uninstalled and reinstalled the module

didn't work

Whats OTVD
[Xposed Framework Modules] Artieza:
One Tap Video Download. Not Facebook Module. But try to clean both.
[Xposed Framework Modules] sagar_here:
uninstalled and reinstalled both

actually it is just one now i think!? ????
[Xposed Framework Modules] umarmasroor:
Facebook module not working :(
[Xposed Framework Modules] mr.phantom:
Install OTVD version 4.3 and then clear app's data. Reboot your device and then try to use it on facebook.

No, you need One Tap Facebook Module too.
[Xposed Framework Modules] umarmasroor:
Worked ?
[Xposed Framework Modules] Artieza:
About job scheduler from Evernote...
[Xposed Framework Modules] mr.phantom:
Oh, does it crashes at that time ?

Sorry, I didn't get time to inspect that issue.
[Xposed Framework Modules] Artieza:
No, but maybe, it is a reason of 800 wakelocks...
[Xposed Framework Modules] koko115:
Latest fb from play store video download no working
[Xposed Framework Modules] mallahata:
does it work with firefox or chrome and other type of browsers ?
[Xposed Framework Modules] koko115:
[MENTION=4900001]mr.phantom[/MENTION] please fix for latest FB
[Xposed Framework Modules] umarmasroor:
Not working on latest fb update
[Xposed Framework Modules] mr.phantom:
Please try the following APK :

https://drive.google.com/open?id=0B2STLDUPnCd7MG9pLUh2cGwwNTA

I have fixed that issue. Can you please try it out ?

https://drive.google.com/open?id=0B2STLDUPnCd7MG9pLUh2cGwwNTA

It does work for Chrome and Chrome Dev but not for firefox.

Moreover, if there's any chromium based browser which anyone uses, I might add support for that too as I just have to add one line for the same.
[Xposed Framework Modules] Francescorm76:
With OTVD 4.4 working flawless.. Thanks again Master! [emoji16] [emoji16] [emoji16]

Inviato dal mio SM-G935F utilizzando Tapatalk
[Xposed Framework Modules] koko115:
No working. I test on FB 101.0.0.7.70
[Xposed Framework Modules] Francescorm76:
On 100.0.0.20.70 working

Inviato dal mio SM-G935F utilizzando Tapatalk
[Xposed Framework Modules] KaMyKaSii:
You can add Chrome Beta and Chrome Canary?
[Xposed Framework Modules] koko115:
Working good on FB 100.... and FB 101.... after clearing cache OTVD
[Xposed Framework Modules] Artieza:
It isn't a regular issue. So I can't check it.

---------- Post added at 09:03 PM ---------- Previous post was at 09:03 PM ----------

Seems like the problem with broken prefs is still here...
[Xposed Framework Modules] mr.phantom:
That's really weird because there are no such shared preferences related to hooks.

Sure
[Xposed Framework Modules] mr.phantom:
Please try this APK on Chrome Beta and Chrome Canary : https://drive.google.com/open?id=0B2STLDUPnCd7ZTBUS0M0WnktWk0
[Xposed Framework Modules] Artieza:
I'll check it when you will push the update to Google Store. But notice that user said that cache clearing is enough (previously I wiped all data).
[Xposed Framework Modules] KaMyKaSii:
Works on Google Canary. Thanks
[Xposed Framework Modules] Artieza:
List of URLs without dynamic height (wrap_content).
[Xposed Framework Modules] vip57:
i can't download facebook videos anymore when i updated to fb 100.0.0.20.70

i deleted fb and wiped data for this mod and disabled it and rebooted and installed fb and module then enabled it then rebooted and didn't work and i updated hooks also please fix :(
[Xposed Framework Modules] Artieza:
Ok. I updated it.

The last updates through Google Play lead to soft reboot at the end of updating. Previously it wasn't. Works well for me after update. No need to clean data.

---------- Post added at 10:09 AM ---------- Previous post was at 10:07 AM ----------

Delete data of the main Xposed module (not Facebook extension) then reboot.
[Xposed Framework Modules] vip57:
didn't work :(
[Xposed Framework Modules] Ragnar Eldur:
Just use Download Accelerator Plus from the Play Store. It can download almost any media including Facebook. Just open Facebook with l

Browser or the app and share the link or copy the URL and open the Downloader and it will detect the link and offer you to download the video. Just start playing the video first so the app can detect the video.
[Xposed Framework Modules] umarmasroor:
Thanks new one worked
[Xposed Framework Modules] nazeer66:
Facebook module not working fr me.. I'm on sultan MM
[Xposed Framework Modules] ArgamanZa:
+1 with A8 port on S6 Edge.
[Xposed Framework Modules] Fearless_Knight:
Thanks alot for this :)
[Xposed Framework Modules] ajit1441:
youtube module is not working... previously it was working fine.....version 4.0
[Xposed Framework Modules] rony raj:
youtube module stop working since youtube updated

i use tubemate now
[Xposed Framework Modules] mr.phantom:
Which youtube version are you using right now ?

--------------------------

Make sure you are using version 4.4 of One Tap Video Download. It works fine on Facebook.

---------------------------

Actually issue was something else. Anyway thanks for reporting!

I have fixed it in attached apk. Moreover this version has a lot more improvements related to UI and performance. But I want to make sure it doesn't crash. So, won't be releasing it soon on playstore.

Can you please try it out and report bugs if any ? :)

Edit :

(APK updated)

https://drive.google.com/open?id=0B2STLDUPnCd7WjNMd0wwOHJPeUU
[Xposed Framework Modules] nazeer66:
Yeah fa me too
[Xposed Framework Modules] Artieza:
Fixed. But, lol, what are you doing in background? Hidden advert loading? I disabled AD in settings.
[Xposed Framework Modules] mr.phantom:
Please tell me Youtube version on which it's not working.

Nope, no advertisement is being loaded in background. Moreover, I won't get any revenue even if I load them in background.

Background services :

1. If any file is being downloaded.

2. Show notification for video plays(By the way, no processing is being done when no notification is being shown. Although that service might run in background but that's because of Android's memory management(caching in memory for performance) and Android will kill it when any new operation needs memory.

3. Scheduling of Hook Updater (Way of scheduling is different in different Android versions.)
[Xposed Framework Modules] Artieza:
But why is measurement broker service written?
[Xposed Framework Modules] mr.phantom:
Is that service running from OTVD ? It was in some language other than English, so I didn't understand it.

Anyway, check this out :

https://developers.google.com/andro...android/gms/measurement/AppMeasurementService

Yes, I am using Firebase Analytics. So, it might be because of that. Anyway, I assure you that Ads are not loaded in background if you have disabled them. If you still have any doubts, you can check it out in code as OTVD is totally open source. Here's link to that code :

https://github.com/Ashish-Bansal/On.../onetapvideodownload/ui/MainActivity.java#L95
[Xposed Framework Modules] nazeer66:
YouTube app version 11.41.56
[Xposed Framework Modules] mr.phantom:
Did you try updating hooks from application menu and then reboot your device ?
[Xposed Framework Modules] Artieza:
Huh. Android 5.0.2.
[Xposed Framework Modules] mr.phantom:
Fixed! Link : https://drive.google.com/open?id=0B2STLDUPnCd7WjNMd0wwOHJPeUU
[Xposed Framework Modules] Still_living714:
Module isn't working on Chrome browser anymore
[Xposed Framework Modules] AMJ_Vario:
Hope it will work fine on my Redmi 3pro.. :D
[Xposed Framework Modules] Artieza:
I don't like that all URLs are noted into Xposed log. Because time to time I need to share this log. Privacy destroyed. Could you disable or make it as option for debugging?

Also I noticed that your inspector doesn't process all correctly.
[Xposed Framework Modules] ilabstudios:
I have been using your module for a long time but may I make some suggestions.

- Provide a clear list button or menu option to remove downloaded files.

- Provide a toggle button to temporarily disable OTVD (so it doesn't listen and record the URL of media. This way I don't need to disable the module, as xposed requires a restart.)

- When the 'enable URL logging' is disabled no URLs should be logged in the background. All its actually doing is disabling access to the list.

- In the log list long press on URL gives option to view details (as the URL cuts off so I can't see the video ids) and option to download file (sometimes the file will download but video is corrupted from interruptions).
[Xposed Framework Modules] Artieza:
One more suggestion: user modified timer for dismiss notification. Now it have 3 minutes maximum, but I want to set 0 (never dismiss automatically).
[Xposed Framework Modules] JosueMirandapr:
Help! It not works!

I have installed facebook module and it downloads youtube videos 0.o but with facebook it makes anything... please help
[Xposed Framework Modules] DAS82:
mr.phantom,

Thanks for the v4.4 update! I'm glad the bug that was using extra unnecessary cpu cycles appears to be fixed so far. I was tired of having to every couple days clear the OTVD app data, reboot, and reconfigure for my settings and blacklist domains in order to stop the extra cpu cycles to keep good battery life with previous versions. So far the new v4.4 has maintained minimal cpu use without me having to reset it. I hope it continues working like this.

This version been working great so far, YT hooks work fine, no instability or crashing, and notifications come fast.

Keep up the great work!

---

Samsung Galaxy S5 running stock Marshmallow ROM, Boeffla Kernel v2.2-beta2, wanam's Xposed v86.1
[Xposed Framework Modules] mr.phantom:
Oh cool! Thank Artieza for bringing that issue to my notice :)

Which version of OTVD are you using ?

Added to my ToDo list. I'll fix them next time, when I'll sit to fix bugs. Moreover, it would be great if someone can add them as issues on the github repo : https://github.com/Ashish-Bansal/OneTapVideoDownload
[Xposed Framework Modules] Artieza:
Lucky guy, but for me hooks for YT work bad. Time to time notification doesn't appear. I don't know, but it is. In such situation I tried to play other video or close YT and reopen... Notification comes back within some minutes... No logic. I captured logcat. Seems like OTVD is just died, and need to wait for stabilization...
[Xposed Framework Modules] DAS82:
That's unfortunate.. Still today, on my device v4.4 is running better than any previous version, primarily because it is not falling into excessive cpu cycles every day or two like previous builds. Thanks to you for bringing that issue to the developer's attention. The only issue I still experience is that the hooks never catch YT opening the first video I open after starting YT. I always need to back out of the video and reopen it, then OTVD catches them fine for as long as YouTube stays resident. It is not a new problem with this build though, it's been like that for a while, but it's such a minor inconvenience it doesn't bother me at all.

Let's hope he can identify & correct what's causing the instability with your system without having to undo the cpu cycle fix. It is nice when OTVD isn't eating cpu cycles and draining battery.
[Xposed Framework Modules] Artieza:
Exactly! But time to time it isn't working at second reopening... I don't know. Hope, [MENTION=4900001]mr.phantom[/MENTION] will find the cause.
[Xposed Framework Modules] mr.phantom:
Can you please send me logcat instead ?

Actually xposed logs won't help in case main application crashes. Logcat would be required in that case. Do steps which crashes the application and then take logcat and send me.
[Xposed Framework Modules] mr.phantom:
Try updating YouTube mod to v2.0 :)
[Xposed Framework Modules] mr.phantom:
Version Bump to version 2.1

Version Bump to version 2.1

Change log :

Urgent fix for Android 5.1.1
[Xposed Framework Modules] mr.phantom:
Thanks for reporting!

This has been fixed in latest release (v2.1)
[Xposed Framework Modules] DowneyHere:
Thanks mate, v2.1 working flawlessly!!! Keep up this awesome project!! [emoji4]
[Xposed Framework Modules] exodius48:
No error message on logcat but notification while playing youtube does not show. :/

I'm confused.
[Xposed Framework Modules] Prokillz:
Looks nice, but sadly it's not working in my LG G Flex. The app keeps saying its not enabled (even when it is) or to reboot.
[Xposed Framework Modules] exodius48:
[MENTION=4900001]mr.phantom[/MENTION] today i check error log on xposed i get these:

Loading modules from /data/app/com.phantom.onetapvideodownload-1.apk
Loading class com.phantom.onetapvideodownload.MediaPlayerHook
java.lang.IllegalAccessError: Class ref in pre-verified class resolved to unexpected implementation
at dalvik.system.DexFile.defineClassNative(Native Method)
at dalvik.system.DexFile.defineClass(DexFile.java:222)
at dalvik.system.DexFile.loadClassBinaryName(DexFile.java:215)
at dalvik.system.DexPathList.findClass(DexPathList.java:322)
at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:54)
at java.lang.ClassLoader.loadClass(ClassLoader.java:497)
at java.lang.ClassLoader.loadClass(ClassLoader.java:457)
at de.robv.android.xposed.XposedBridge.loadModule(XposedBridge.java:421)
at de.robv.android.xposed.XposedBridge.loadModules(XposedBridge.java:386)
at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:120)
at dalvik.system.NativeStart.main(Native Method)

and

Loading modules from /data/app/com.phantom.onetapyoutubemodule-2.apk
Loading class com.phantom.onetapyoutubemodule.YoutubeMediaHook
java.lang.IllegalAccessError: Class ref in pre-verified class resolved to unexpected implementation
at dalvik.system.DexFile.defineClassNative(Native Method)
at dalvik.system.DexFile.defineClass(DexFile.java:222)
at dalvik.system.DexFile.loadClassBinaryName(DexFile.java:215)
at dalvik.system.DexPathList.findClass(DexPathList.java:322)
at dalvik.system.BaseDexClassLoader.findClass(BaseDexClassLoader.java:54)
at java.lang.ClassLoader.loadClass(ClassLoader.java:497)
at java.lang.ClassLoader.loadClass(ClassLoader.java:457)
at de.robv.android.xposed.XposedBridge.loadModule(XposedBridge.java:421)
at de.robv.android.xposed.XposedBridge.loadModules(XposedBridge.java:386)
at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:120)
at dalvik.system.NativeStart.main(Native Method)

Please make a fix if its possible.
[Xposed Framework Modules] mr.phantom:
I have fixed this issue. I'll release it in next version.
[Xposed Framework Modules] exodius48:
I can't wait it. :D
[Xposed Framework Modules] brusyev:
Tried it on my Rooted SM-N910T and it didnt work. I am running the latest version of Youtube and Android 5.0.1. Xposed is at version 75....
[Xposed Framework Modules] mr.phantom:
Please specify what's not working for you and give me your Xposed logs. Saying that "it didnt work" isn't helpful at all.
[Xposed Framework Modules] brusyev:
When I was playing videos in youtube player no popup appeared giving option to download. The only time I got the prompt is when I clicked on one of the videos in Chrome. I didnt have time to gather any logs but will try to if I find some time today or later this week.
[Xposed Framework Modules] mr.phantom:
Now this is somewhat helpful :)

Please try to get Xposed logs if possible. You might be using different version of youtube which isn't supported right now. I can try to add support for it, given that you send me your xposed logs.
[Xposed Framework Modules] leodfs:
What about an option to rename the video before download it? We could choose in settings if we want to download as it is today or we want to rename.

Enviado de meu SM-N910C usando Tapatalk
[Xposed Framework Modules] mr.phantom:
Did you mean renaming youtube videos ?

I have changed the application to automatically get names from youtube title. It will be available in next release. I'm busy from some days and am not able to release it.
[Xposed Framework Modules] leodfs:
Not only youtube, any video. I didn't mean automatically, but manually by typing it.

Enviado de meu SM-N910C usando Tapatalk
[Xposed Framework Modules] bimmermad:
Hi will this work on the Facebook app or will it have to be the Web version?

Phronesis V5.2
[Xposed Framework Modules] hereandthere:
It works now in 2.2 (YouTube module 2.0). It automatically fetch video title. :D

I don't have Facebook app installed but you can download videos from their mobile site without problem with this module.
[Xposed Framework Modules] hereandthere:
Is there a way to cancel an ongoing download? I can't find a way to do this. Switching connection on/off or even rebooting don't clear download queue. It's resuming immediately after a connection is available. I don't want to download when I'm on mobile data.

Edit: Actually we can cancel download and clear download queue by opening App (all) > Download Manager. And then force stop and clear data.
[Xposed Framework Modules] DAS82:
I know I had that happen a number of times with previous builds..My solution was the same I used for the excess cpu cycles... to force stop OTVD app, clear OTVD app data, uninstall app, reinstall app & enable Xposed module, then reboot. That always would fix it for me... at least for a few days until it happened again.
[Xposed Framework Modules] westeight:
Was working fine on my HTC 10 until the latest update. Tried uninstalling, reinstalling, etc. Clearing cache. Updating hooks, etc.

Simply doesn't want to work / recognise that any video is playing when the YouTube app is open...

Any ideas folks?
[Xposed Framework Modules] Artieza:
Read above.
[Xposed Framework Modules] old9:
youtube 11.43.52, not working again on OTVD 4.4, after updating hook and rebooting...

not working either on m.youtube.com website.
[Xposed Framework Modules] DAS82:
v11.41.56 is the latest version supported by the current server-side hooks
[Xposed Framework Modules] mr.phantom:
Just added hooks for Youtube version 11.43.52!

Can you please send me your xposed logs ?

I'm unable to reproduce this due to which it won't be possible for me to fix it. I at least need some error logs so that I know where I should look for this bug (which needs cleaning OTVD app data after sometime).

Yes, I am aware of that issue that it never catches link for the first video (That's because the method that I have hooked in Youtube passes wrong "zzzzzzzz" video id for the first video. I can look for better class to hook but that would require me to fix automation script which I don't really want to do right now.)

Well, that cpu cycle fix isn't causing the mentioned issue of "stops working after sometime".

Can you please capture whole logcat instead ? I think OTVD is dying because of crash in native library and that's not the coding error in the OTVD, instead bug in the system itself. If you could provide me full logcat when the process dies, I might be able to look into it. By full logcat, I meant output from each and every component of the Android at that very instant.

Try updating hooks now if you are using latest version of Youtube. Make sure to reboot your device. If it still doesn't work, please attach application logs along with that. I can't help you out without them.
[Xposed Framework Modules] westeight:
Working perfectly again. Thank you for the update! :cowboy:
[Xposed Framework Modules] JosueMirandapr:
I download it again and now it works!!! Thanks!!!
[Xposed Framework Modules] koko115:
Its is posible to this app (otvd and facebook modules) do force restart phone (3×vibrates and force reboot) after go to landscape mode ? After untouch this two apps in xposed installer, i dont have this problem. Galaxy s7e, magisk v8, xposed 86.6
[Xposed Framework Modules] mr.phantom:
Sorry but I didn't get what you are trying to say.