yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] Artieza:
He said that this app leads to force reboot the phone if screen orientation was changed (while downloading). He disabled OTVD & OTFM, and problem is disappeared.

I think, it is possible. I many times faced with memory leaks (system UI crash & sometimes soft reboot), especially within long (30 minutes on slow 3G) downloads. But I'm not sure if it is OTVD or something else.
[Xposed Framework Modules] mr.phantom:
Oh, thanks for explaining!

I have never experienced this problem and reboot due to application crash, that's overkill for an android application. Every application runs in a container. Xposed Hooks allows one to go out of that. So, the place where it can happen is in Xposed Hooks in OTVD. But as you have mentioned it happens when there is change in screen orientation, so that shouldn't be because of OTVD.
[Xposed Framework Modules] mr.phantom:
Changes :

Improved hostname extraction from URL

Memory leak fix; Used SparseArray instead of HashMap

Used better function to get hostname from URL

Run mediascanner when download completes

Added option to disable module completely

Fixed crash if video id has been removed from the database

Show video details on long press in URL Log activity

Fixed SwipeToAction library to call OnLongPressed immediately

Added SwipeToAction library code manually to make customize it

Disabled web view url logging as it's not imp

Fixed URL logging enabled/disabled option

Increased notification dismiss time options

Fixed YouTube icon for downloads in card view

Link : https://drive.google.com/open?id=0B2STLDUPnCd7MVJLQ0kyLXNTLTA
[Xposed Framework Modules] Artieza:
For me it happens in any orientation. I don't know. Since I noticed this weirdness I started to look at logcat time to time. This is why I brought many issues to attention of developers (for you too).

This fault is absolutely annoying because I cannot figure out what is happen. Also my system crashed while I downloaded stuff through ADM. Do your app intercept download manager? The only one thing which I found is on the screenshot. I'm absolutely disappeared...
[Xposed Framework Modules] mr.phantom:
I'm intercepting android APIs. So, if that download manager is using that API, then yeah you can say that I'm intercepting download manager. Well from the APIs which I have hooked, the only Android API which I think ADM uses is WebView (for displaying ads). Moreover, if the frequency of reboots is really high, I would recommend you to use hit and trial by disabling/enabling half modules and check if reboot happens and keep whitelisting modules.
[Xposed Framework Modules] Artieza:
It is a random issue, really cannot catch it. But if I leave phone on downloading at night, I can expert that system UI was rebooted and ADM was dropped down at morning. 100%. Great tests there should be...

---------- Post added at 12:32 PM ---------- Previous post was at 12:27 PM ----------

XInternal SD is a second alleged... :confused: But I use it per some apps, not for ADM.
[Xposed Framework Modules] Artieza:
Oh, haha, I think, all users which said that this doesn't work with YT faced with this trouble.
[Xposed Framework Modules] mr.phantom:
In that case, I think the best workaround would be to show a notification that "Notification for downloading video will appear for next video". ;)
[Xposed Framework Modules] Artieza:
Bad. In many causes I need exactly the first video. Reopening of YT doesn't help, because caching is continued under unidentified label.
[Xposed Framework Modules] mr.phantom:
I didn't get it. Caching is continued under unidentified label ?
[Xposed Framework Modules] Artieza:
You told that cannot catch the id (label). If I open YT and start to play video (first after reboot), OTVD doesn't catch it. If I close YT, open it again and start this video, it still unidentified for OTVD.
[Xposed Framework Modules] mr.phantom:
Yeah but don't close the YT, just open the same video again.
[Xposed Framework Modules] Artieza:
Seems like it's wrong. I checked it some time ago. Now I'm sure.

1. If you open YT in short time after system boot, you won't see any notification from OTVD. If you will restart playing of this video or close and reopen YT app, you won't see notification anyway.

2. If since boot went over 1 hour (I don't know exactly, but much time), I will receive notification even I open YT app in first time after boot.
[Xposed Framework Modules] westeight:
Strangely, that does actually work! Open, play, close, play again = OTVD works :cowboy:
[Xposed Framework Modules] oldman20:
Great work, please make it work with other download manager like ADM, sir

Gửi từ Redmi Note 3 của tôi bằng cách sử dụng Tapatalk
[Xposed Framework Modules] Artieza:
You can press "open" & choice ADM. It works for WebView based apps. For YouTube it doesn't show ADM in chooser for some reason. I'd like to ask dev to change attributes (flags) of notification for YouTube.
[Xposed Framework Modules] Artieza:
Here it is. I'm sure that it isn't a fail of the system. You made it very unstable. I mean:

1. It may starts download, but when it finishes, may crashes instead of change notification to "download finished" (like now, check the log).

2. I can tap on the notification while downloading, then leave main app, and download may be stopped (but notification will be there).

Also you should dismiss notification after press "download".
[Xposed Framework Modules] Artieza:
In the latest versions "Remove download from the list" doesn't work. After reopening the app deleted downloads come back.
[Xposed Framework Modules] mr.phantom:
I'll check it out.

I'll check the bugs you are having. Moreover about fail of the system, I'm quite sure that isn't result of OTVD.

It won't work for youtube because of the way Youtube video handling works.
[Xposed Framework Modules] Artieza:
In fact notification "download finished" never comes in the test version.

No direct link to the file or what? That's strange, because it can be opened in external player, what means that you push to it some link. Why this link cannot be pushed in download manager instead?
[Xposed Framework Modules] mr.phantom:
Ah sorry! I misunderstood you earlier. Now I get it. I'll check it out.
[Xposed Framework Modules] mr.phantom:
I'm passing same flags for both Youtube and Browser video. The problem is with file extension. Youtube Videos(Most of the videos from the Google Server) have urls http://foo.bar/videoplayback?paramters. They don't contain file extension where as other Browser video, on which it shows ADM, contain file extension. If I manually set mime type (video/*) there won't be any difference in "Play" and "Open". If you want to download Youtube videos using ADM, click on "play" and then select ADM editor (Although I think it will move ADM editor to the most preferred application for opening videos).

Changelog :

Added hooks for Facebook; Update hooks in JAVA code

Fixed showing download finished notification

Fixed 'Delete from Storage' from download options

Fixed 'Remove from list' from download options

Edit : (Updated link)

OTVD Testing version : https://drive.google.com/open?id=0B2STLDUPnCd7T21Bbkw1WTk4V1U
[Xposed Framework Modules] westeight:
Testing version works perfectly. Thank you :cowboy:
[Xposed Framework Modules] kylecore:
Using updated apk in youtube app, notification appears however it downloads the ad, not the video. Still not working using youtube in browser either.

keep up the good work :)
[Xposed Framework Modules] yomiguy:
Interesting to give a try...

Enviado desde mi Galaxy Tab 2 mediante Tapatalk
[Xposed Framework Modules] mr.phantom:
That's really weird. What happens after Ad ends ? Isn't there any new notification for video after Ad ends ?

I haven't added the functionality to download youtube videos from the browser.
[Xposed Framework Modules] SinisterGenocide:
For me it doesn't work at all anymore. When I open YouTube it freezes YouTube for me and give an error in my notification bar saying how many errors the module has had in the past week and that it is cause my device to perform poorly. Also when I turn my phone on and open vlc to watch some TV shows I have I get a constant reoccurring error for one tap download but it goes away and comes back too fast for me to click OK on the error. I have to go into running apps and force close it. This has been happening for a few weeks now. I have the GS6 edge running mm 6.0.1 on renegade ROM. This module used to work perfect for me and now doesnt work at all. Any ideas on how to fix this other than going back to a old version of the module and old version of YouTube?
[Xposed Framework Modules] mr.phantom:
By "Constant reoccurring error", did you mean constant Force Close errors ? Or some other kind of error ? Can you please attach Screenshot ? If you get Force closes, please send me logcat. Moreover attach this file : sdcard/.OneTapVideoDownload/Logs.txt (It's in hidden folder).
[Xposed Framework Modules] SinisterGenocide:
I can't really say what kind of error. It flashes so fast I can't see what the message is. I don't think I'll be able to get a screen of it due to it being so fast. And also how do I get a logcat?
[Xposed Framework Modules] mr.phantom:
Check Matlog application on playstore and use it to send logcat.
[Xposed Framework Modules] SinisterGenocide:
Well I had the modules uninstalled for a few days and I use reinstalled to get a log but now they are working fine. Lol
[Xposed Framework Modules] Artieza:
[MENTION=4900001]mr.phantom[/MENTION], are you meaning it? :confused:

W/SELinux (11918): SELinux: Could not look up information for package com.android.providers.downloads, cannot restorecon cache.

E/SELinux (14030): SELinux: Could not set context for /data/data/com.android.providers.downloads/cache: Permission denied
[Xposed Framework Modules] Artieza:
Hey, why did you require calendar & location permissions? :confused:
[Xposed Framework Modules] Artieza:
Could you also change the name to "One Tap..." without "Xposed"? In the Xposed's list your modules not close to each other. So if I want to disable it, I should find 2 places in the list. Yea, I have big list.

---------- Post added at 01:30 AM ---------- Previous post was at 12:36 AM ----------

Delete downloads from the list -> exit from One Tap -> crash -> nothing was deleted. Crash report on mail.
[Xposed Framework Modules] mr.phantom:
Nope, I have implemented custom download manager because default download manager doesn't support various things. So, in change log, I have mentioned fixes related to my custom download manager.

Actually, I'm using Mediation network by Mopub and it requires those permissions. Although for Android 5+, as you know application has to ask for permissions, I'm not asking that. So, those things won't be used in Android 5+.

Changing name at this point, would create inconsistency. Although I can think about adding "Xposed" in front of other modules.

Although trivial excuse but it's easier to find OTVD in the launcher due to "Xposed" as prefix because everyone knows that it would be on last page as very less no. of applications start with 'X', 'Y' and 'Z'.

I'm unable to reproduce the crash and I didn't receive crash report on mail. Please send me report again.
[Xposed Framework Modules] koko115:
When i want share downloaded video from extsdcard i have this info. I clear cache and nothing.

On build memory all ok.

---------- Post added at 03:33 PM ---------- Previous post was at 03:30 PM ----------

And after update, when i exit from thiss app, app is crash.
[Xposed Framework Modules] Artieza:
What the ****? It's the first ads mediator, which grab contacts. I didn't understand about Android 5+. Lollipop doesn't allow to adjust permissions. It is only for 6+. Are this permissions not used in your app or what are you saying?

Ok. Let's add "Xposed" to every module. And we will get extra long names. ? Anyway it would be better, if you will uniform somehow all this stuff to easy disabling/enabling in Xposed's list.

Report was sent via Google's form. You should get it.
[Xposed Framework Modules] mr.phantom:
Can you please check if that file is present in Downloads folder using file explorer?

And yeah, I got the report. I'll fix it in next release. It crashes when Ads are disabledThanks!

Grab contacts ? Right now, OTVD only requires three permissions "Calendar", "Location" and "Storage". OTVD requires "Storage" permission for downloading files. Other two are required by Ad Mediator. Although I plan to remove "Calendar" permission in next release(making sure it doesn't crash without that). And yeah Android 6+. Sorry for creating confusion!

Yeah I got the report, thanks!
[Xposed Framework Modules] Artieza:
Ups, I meant calendar! I understand location for ads, but this...
[Xposed Framework Modules] mr.phantom:
Yeah, I understand. I was also bit surprised when I got to know this.
[Xposed Framework Modules] mr.phantom:
Testing APK : https://drive.google.com/open?id=0B2STLDUPnCd7TmxJVVA5OWFCeHc

This version includes a lot of code refactoring and performance fixes. Please test it and report bugs.

Edit : Updated URL.
[Xposed Framework Modules] Artieza:
Please, share it via Google's testing.
[Xposed Framework Modules] mr.phantom:
Before publishing it to Beta Testing, I wanted to ensure that there ain't lot of bugs which effect Beta Testers.
[Xposed Framework Modules] Artieza:
Facepalm. Beta testers in Google Play exactly for that. If you afraid that there are problems, so anyone who connected to beta canal should understand for what they was assigned.
[Xposed Framework Modules] koko115:
Yes. File is present in Extsd download folder.
[Xposed Framework Modules] mr.phantom:
Of course I know that the Beta testers is for testing purpose. But I treat as an entry point for newly introduced features in the application, not for checking crashes on the devices. I don't want to distribute bleeding edge version and make beta testers experience lot of bugs or continuous crashes making it totally unusable. That's why I post it on XDA because some testers test the posted APK and send me crash reports to my email(onetapvideodownload@gmail.com).

That's really weird. Can you please check if you are able to browse the file following full path or not ? By full path, I meant going to / ,then storage etc etc. (/storage/xyz/Download/filename) instead of checking extSD/Download/filename.
[Xposed Framework Modules] Artieza:
So you use stable & beta (Google Play) & alpha (XDA) distributions, lol. I just meant that it might be more comfy to download alphas from Google Play...
[Xposed Framework Modules] Artieza:
What is curl.io?
[Xposed Framework Modules] mr.phantom:
I tried to setup alphas on Google Play earlier but they said that both Beta and Alpha can't be active at the same time. Anyway, I'll again try to setup it.

It's file sharing site by which I can share file directly from terminal instead of opening web interface and uploading files. Anyway, I'll replace that link with GDrive.
[Xposed Framework Modules] Artieza:
Are you sure that you correctly setup it? I see only "ups".
[Xposed Framework Modules] mr.phantom:
Did you mean "oops" ? Probably that link has expired.

Anyway I was checking out setting up Alpha and Beta Testing and I got to know that if I want to enable both of them, then I'll have to setup Closed Alpha and Open Beta.

Meaning of Closed :

I will need to add the emails manually for users.

Meaning of Open :

Who so ever want to join that testing group, can opt in using specific URL.
[Xposed Framework Modules] Artieza:
Fine. ? So it is possible now.
[Xposed Framework Modules] Artieza:
Got it via Google. ? Still cannot clean downloads list. All items are restored after reopening app. Again. ?
[Xposed Framework Modules] KaMyKaSii:
Sorry for the late feedback, I installed and forgot to report my experience. Anyway, it is working perfectly on CM 12.1. I installed it when you posted it so far without any crash, and the files removed from the list are not mysteriously returning
[Xposed Framework Modules] koko115:
After today update, still unable share video downloaded from EXTSD card.
[Xposed Framework Modules] Artieza:
Did you try to select multiple items (all), press delete, exit from the app?
[Xposed Framework Modules] mr.phantom:
Working for me at least ^

Does it crash or what ? And on how many no. of downloads you are experiencing this issue (1, 5, 10, even more) ?

Clear application data and then please explain how to reproduce this as detailed as possible.

Did you try this ? -> ""Can you please check if you are able to browse the file following full path or not ? By full path, I meant going to / ,then storage etc etc. (/storage/xyz/Download/filename) instead of checking extSD/Download/filename.""

No problem :)

Oh cool!

Moreover, all the users who want to be alpha testers, please send me your Name as well as Email to onetapvideodownload@gmail.com

Others who want to be become beta testers can opt in using this link :

https://play.google.com/apps/testing/com.phantom.onetapvideodownload
[Xposed Framework Modules] koko115:
Look to this video... This is from S7Edge.. but on my Galaxy Note Pro 12.2 is this some problem.

https://vimeo.com/194370701
[Xposed Framework Modules] Artieza:
No. Just auto restore. 13 items. Select them all, delete, swipe app from resents. Here it is...
[Xposed Framework Modules] mr.phantom:
Oh okay. Was it working earlier on Galaxy Note Pro? Or you didn't try it earlier or purchased new device?

Okay, now I'm able to reproduce this problem. I would like to know if it started happening recently or was it happenning in previous stable releases too.

Because if this happens only in Beta/Alpha releases, not the stable releases, then I'll only check the recent commits which could be responsible for this.
[Xposed Framework Modules] koko115:
On note pro, and galaxy s7 no working share from extsd.
[Xposed Framework Modules] mr.phantom:
Oh okay. I'll try to find out the reason for that.
[Xposed Framework Modules] westeight:
YouTube updated to v11.47.55 and OTVD isn't working now :(
[Xposed Framework Modules] Jonas27M:
This mod will be very useful, thanks :)
[Xposed Framework Modules] Artieza:
I remember that you had same problem in the past. I reported about it. Then you fixed it. And now it came again. Short time ago.
[Xposed Framework Modules] lanesman:
facebook HD videos

Hey, I'm looking to get facebook HD videos URLs.

it seems the module works fine for SD but for HD i don't get any notification.

I'm guessing it's because of a difference in facebook app URLs as can be seen in logs (tokens altered and https changed to hp because of forum restrictions):

2016-12-18_16-21-53 - ---------------------------
2016-12-18_16-21-53 - One Tap Initialized
2016-12-18_16-21-53 - OneTapVideoDownload : Self hooking.
2016-12-18_16-22-00 - ---------------------------
2016-12-18_16-22-00 - One Tap Initialized
2016-12-18_16-22-00 - OneTapVideoDownload : Self hooking.
2016-12-18_16-22-26 - Facebook Main URL : hp://127.0.0.1:39784/cache-thru?remote-uri=https%3A%2F%2Ffb-l-d-a.akamaihd.net%2Fh-ak-xfp1%2Fv%2Ft42.1790-2%2F17470_2192790381_642396819872_n.mp4%3Fefg%3DjAzLCJ2ZW5jb2RlX3RhZyI6InN2ZV9zZCJ9%26oh%3Dfdb0424605fae93731aca2%26oe%3D58580%26__gda__%3D6653_6863e4a6c444e29df2781de851&vid=10154890920649312&sid=11
2016-12-18_16-22-26 - Facebook Query Parameter URL : hps://fb-l-d-a.akamaihd.net/h-ak-xfp1/v/t42.1790-2/17470_2192790381_642396819872_n.mp4?efg=jAzLCJ2ZW5jb2RlX3RhZyI6InN2ZV9zZCJ9&oh=fdb0424605fae93731aca2&oe=58580&__gda__=6653_6863e4a6c444e29df2781de851
2016-12-18_16-22-33 - Facebook Main URL : hps://video-frt3-1.xx.fbcdn.net/v/t43.1792-2/15559_115215599511_50056624834928_n.mp4?efg=eyJyjM2NjcsInJsYSI6NwidmVuY29kZV90YWciVfaGQifQ%3D%3D&oh=0fd12793ae5da63bad5f650&oe=58842
2016-12-18_16-22-33 - Facebook Query Parameter URL :

the first one being SD and the second being HD.

I'm not sure whats this

hp://127.0.0.1:39784/cache-thru

but it seems OTVD counts on the url having this format, any option of supporting both formats?
[Xposed Framework Modules] caniko2:
Now that you have implemented an "update hook technology". I feel it is safe to ask for support on SoundCloud. Thank you for your time! Happy Holidays
[Xposed Framework Modules] Ephesis:
It doesnt work on Youtube on marshmallow
[Xposed Framework Modules] mr.phantom:
Sorry for late replies everyone! I was having my final exams in college.

Fixed in latest version!

Facebook opens a socket on device for IPC and uses it for caching purpose somehow. That's why URLs have that string at start.

I didn't know that on HD videos on Facebook are being played without caching.

I just received pull request from you. Thanks a lot!

Which version of Facebook are you talking about ? And Facebook or Facebook Lite ?

"Update Hooks" just downloads updated hooks from the server. I still will have to update hooks on the server. I'll try to create a automation daemon for doing that. If I succeed, I'll add support for SoundCloud.

Which version of Youtube are you using right now ?
[Xposed Framework Modules] Ephesis:
[MENTION=4900001]mr.phantom[/MENTION]

I'm using the latest one.
[Xposed Framework Modules] Artieza:
Amazing! :victory: Time to change app name to "One Tap Media Download". ;)
[Xposed Framework Modules] mr.phantom:
Please tell me the exact Youtube version. Because release timeline of Youtube is different in different countries.

Cool!

Haha!
[Xposed Framework Modules] CODENEX:
indeed, time to pick soundcloud support too ..
[Xposed Framework Modules] kos25k:
please give us Christmas present also Popcorn time app!!!Merry Christmas to all!!!
[Xposed Framework Modules] Open.Orange:
[MENTION=4900001]mr.phantom[/MENTION]

Hi ,

I have a phone which is KitKat(4.4.2) with XposedBridge.jar version 54 ,and it'll be "forced close" when clicking the icon to the main UI of program since version 4.4 of OTVD.

I've uploaded a video to explain this occurrence https://youtu.be/uaaGGxvMAJU ,and here's the log file in attachment.

Please fix this issue, thank you!! :D
[Xposed Framework Modules] ag6ag:
slimsocial is not supported why? ðŸ˜ðŸ˜

Facebook use many permissions please help to fix that for slimsocial and thanks for this modules
[Xposed Framework Modules] mr.phantom:
Adding support for new modules is difficult for me. Sorry, I can't add support for slimsocial. If anyone is interested in contributing, I'll be really glad to help them out in implementing it.

Hi [MENTION=4446668]Open.Orange[/MENTION],

Is that latest version of XposedBridge available for Kitkat ?
[Xposed Framework Modules] Fadefade91:
Youtube add on doesnt work for me :( I use youtube 11.47.57
[Xposed Framework Modules] Open.Orange:
Yes, this is the latest version on Kitkat ,and this problem is also occurred on my LG Gx, which is in Lollipop (5.0.2) with XposedBridge version 87.
[Xposed Framework Modules] mr.phantom:
Are you using anything related to multi-user ?
[Xposed Framework Modules] mr.phantom:
Oh okay. I'll fix it up. Just click on "Update Hooks" after one hour.
[Xposed Framework Modules] Open.Orange:
No. Both of these OS don't support multi-user function or using related apps.
[Xposed Framework Modules] mr.phantom:
When did you start experiencing this problem ? After any specific OTVD version ? Or did you change your device ?

Edit : Because according to logs, this is not OTVD specific issue.

Edit 1 : Some other application(could be Android ROM too) is blocking OTVD to send the video URL. That's why it doesn't show any notification. And about the crash whenever you open the application, I'll require logcat. The logcat which you posted didn't have information about OTVD's crash.
[Xposed Framework Modules] Open.Orange:
Okay, I've just downgraded to 4.3 and confirmed it's working without crash on my device.

I didn't forbid OTVD to show notifications ,and there's no features to forbidden any apps at KitKat or Lollipop in LG's ROM.

After verision 4.4, there're still shown notifications when detecting videos/musics, and I'll get crashed every-time I open OTVD.

So what should I do next for debugging? :confused: Thank you.
[Xposed Framework Modules] mr.phantom:
Open OTVD, it will crash. After that, send me full logcat.