yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] Riccorbypro:
I couldn't get into my phone because the knock code didn't respond. As in, there was no response to my tapping the squares. No ripple effect, no dots popping up, the only things I could do were press back end emergency call. The code was correct, as I entered it normally after rebooting.

I haven't been able to reproduce it under controlled circumstances, but I wouldn't be able to give you a logcat anyways, as I would have to reboot to get into my phone and allow adb. So you'll have to do a bit of guesswork on this one... I'm working on CM12.1 for my phone, so once that's up and running, I'll test it on there and see if the same problem arises... I'm pretty sure it has something to do with Sony's implementation of the keyguard though - while it looks AOSP, it really isn't. So maybe you can have a look at the systemui I uploaded.

But that's the only complaint I have for this mod. It works smoothly, is faster than drawing my pattern, and even keeps the stock look'n'feel of the phone. And it's convenient as hell. I don't buy LG because of the heavily customised stock ROM, similarly, I don't buy Samsung. But this is one feature from LG I wish every phone had. And now, close-to-AOSP phones can have it.

Sent via Carrier Pigeon
[Xposed Framework Modules] :
Thanks, I will have a look. Meanwhile could you try version 1.1.5 for a while? In 1.1.6, I had reimplemented the knock code view to confine the dots in boxes. If the old version works without qualms, we can at least determine without a doubt that the new implementation is at fault instead of Sony.
[Xposed Framework Modules] Riccorbypro:
I think this occurred once in 1.1.5 as well, will have to try and confirm, but I know it's happened to me 3 times so far. I just dismissed it the first time, and then thought you'd fixed it when you said you'd fixed a bug that caused users to get locked out of the phone... Obviously not...

Sent via Carrier Pigeon
[Xposed Framework Modules] :
The bug that fixed in 1.1.7 was brought out as a result of the knock code reimplementation in 1.1.6.

Please try to check for 1.1.5, thanks. It will help.
[Xposed Framework Modules] Riccorbypro:
OK I will do

Sent via Carrier Pigeon
[Xposed Framework Modules] brossovitch:
Yea, my question doesn't make sense because i obviously had no idea what I wass tslking about, haha! I pasted half of it very wrong....

Well the kernel on my LG typically supports things like double tap to wake. Yes, I'd like to unlock with screen off. It would work if it was a feature, but I don't know how much of a hassle it would be to add an option for devices that have double tap to wake enabled. And whatever else is necessary.

I will take a look at Hellscore, thank you.
[Xposed Framework Modules] cattolicboy:
I just want to thank [MENTION=6065596]Rijul.A[/MENTION] for this module and to confirm that is working without issue, both in Sony's concept that in CM13 (on the phone in my signature).

I vote for this!

And would be also nice to have an option for resizing the grid (personally I would like a bigger grid, like the original from lg stock).
[Xposed Framework Modules] :
I think I should be able to implement the failsafe option in next release. Other than that, I am going to study Data Structures & Algorithms in college and I think quite a lot of it will help me in speeding the module up and slimming it down.

About the resize thing, I tried, couldn't figure out what to edit. I tried some things, but none of them worked. If you see something similar anywhere (resizes the lockscreen), please bring it here so I can understand and implement in my module.

Thanks for feedback! Next release will take some (?) time as my classes have started.
[Xposed Framework Modules] Hassan096:
doesnt work on sense 7 roms, what do u need from me in order to look into this ?

thanks
[Xposed Framework Modules] Riccorbypro:
Sense 7 isn't AOSP. This module is made for AOSP or close to AOSP ROMs. Having seen sense 7, I wouldn't even start to call it close to AOSP. It won't work. Like Samsung, HTC has their own implementation of the Android keyguard, and has overwritten the default AOSP one. So a whole new hook would have to be written to enable the knock code to even display. I don't know if the dev will go to this amount of effort to enable the code on sense...

I have yet to see a phone that isn't Sony or Nexus run this module on its stock ROM. So I don't think it will work on a highly customised ROM like sense.

Sent via Carrier Pigeon
[Xposed Framework Modules] Hassan096:
but it worked on sense 6 :( maybe theres a chance just maybe
[Xposed Framework Modules] Riccorbypro:
Sense 6 is Android KitKat. Since Lollipop, the hooks have had to be changed to enable the code to show again. Sense doesn't use the same hooks, so the code can't show, since it isn't hooked in.

Sent via Carrier Pigeon
[Xposed Framework Modules] Hassan096:
oh :( well it was a worth a try
[Xposed Framework Modules] :
SystemUI.apk and Xposed Logs with only this module active. I will try, but there are no guarantees.
[Xposed Framework Modules] Hassan096:
Hope this helps. Thanks for your time
[Xposed Framework Modules] zimmen:
How do I change the size on tap?
[Xposed Framework Modules] :
Sorry, I didn't get that. If you want to change the grid size, and you're using a version higher than 1.1.0, it will ask you to set the pattern size when you change the knock code.
[Xposed Framework Modules] zimmen:
Ohh! I did not have the right version, the xposed "market" hade the wrong one, but now its right :)

Thank you
[Xposed Framework Modules] roelmatahq:
Locked out

Hi

What is the default/original pass code on 2*2 grid, I forgot to setup my own code, and locked myself out... Please and thank you!
[Xposed Framework Modules] terroboy k9:
AB

CD
[Xposed Framework Modules] Rakuu:
Hey I know you said you can't fix the whole squishing of the lock pattern, but what really bothers me about the squishing is the inconsistency as with it, sometimes it's squished sometimes it's fullscreen, and if I'm honest I've grown accustomed to the 'squished' mode, so is it maybe possible to force it in to this squished mode always?
[Xposed Framework Modules] Bo0o9y:
Very good model and it works will

but can you add "hide status bar" enable/disable option?!
[Xposed Framework Modules] :
If I were aware of what caused the behaviour, I would eliminate it entirely. However without a testing device, I cannot do anything.

No, this module is not meant for that purpose.
[Xposed Framework Modules] Rakuu:
It works, that's good enough for me ?
[Xposed Framework Modules] :
Untested version attached, please check.
[Xposed Framework Modules] Ez3k1el:
Android 6 sense 7 wolla roms

Hi, this module works on Android 6 sense 7? my m8 v2.1 ROM is Wolla sense 7mm
[Xposed Framework Modules] :
No, not yet. I am trying to add compatibility for Sense ROM, but I need a tester. If you're willing to be one, please try the version at http://xdaforums.com/showpost.php?p=64768935&postcount=220 and report back.
[Xposed Framework Modules] Ez3k1el:
I download the apk but still not working. That I can help to make it work?
[Xposed Framework Modules] :
Send me the com.htc.lockscreen apk and Xposed logs with only my module active.
[Xposed Framework Modules] Ez3k1el:
Apk and logs

I send a private message with the attachment. I am new to XDA and I can not attach or place external links.
[Xposed Framework Modules] :
Try attached release and report back with logs.

EDIT : Updated release.
[Xposed Framework Modules] Ez3k1el:
logs

after installing app-release.apk, log Xposed is this:

01-15 02:33:07.756 I/Xposed ( 526): -----------------
01-15 02:33:07.756 I/Xposed ( 526): Starting Xposed version 79, compiled for SDK 23
01-15 02:33:07.756 I/Xposed ( 526): Device: HTC One_M8 (HTC), Android version 6.0 (SDK 23)
01-15 02:33:07.756 I/Xposed ( 526): ROM: Wolla v2.1 - MRA58K release-keys
01-15 02:33:07.756 I/Xposed ( 526): Build fingerprint: htc/brightstarus_wwe/htc_m8:6.0/MRA58K/662736.4:user/release-keys
01-15 02:33:07.756 I/Xposed ( 526): Platform: armeabi-v7a, 32-bit binary, system server: yes
01-15 02:33:07.756 I/Xposed ( 526): SELinux enabled: yes, enforcing: yes
01-15 02:33:07.764 I/Xposed ( 526): -----------------
01-15 02:33:07.764 I/Xposed ( 526): Added Xposed (/system/framework/XposedBridge.jar) to CLASSPATH
01-15 02:33:08.240 I/Xposed ( 526): Detected ART runtime
01-15 02:33:08.264 I/Xposed ( 526): Found Xposed class de/robv/android/xposed/XposedBridge, now initializing
01-15 02:33:08.728 I/Xposed ( 526): Loading modules from /data/app/me.rijul.knockcode-1/base.apk
01-15 02:33:08.862 I/Xposed ( 526): Loading class me.rijul.knockcode.XposedMod
01-15 02:33:41.756 I/Xposed ( 2132): [KnockCode] 5.1.x or 6.0.x device
01-15 02:33:41.890 I/Xposed ( 2132): [KnockCode] Hooking, classLoader of com.htc.lockscreen, sending com.htc.lockscreen.keyguard
01-15 02:33:41.912 I/Xposed ( 2132): [KnockCode] Unknown type of device, not hooking onSimStateChanged
[Xposed Framework Modules] :
Try this one?
[Xposed Framework Modules] :
This?
[Xposed Framework Modules] :
[MENTION=7206511]Ez3k1el[/MENTION]
[Xposed Framework Modules] amer_zx:
Working here with touchwiz ... But only the knock code appears ... No clock no notification no camera shortcut .....

Using port s6 ROM for i9500
[Xposed Framework Modules] :
http://xdaforums.com/showpost.php?p=64562013&postcount=185
[Xposed Framework Modules] :
New version with untested HTC compatibility has been uploaded. If any HTC users are reading this, please tell me if it works and provide logs if it does not. Thanks.
[Xposed Framework Modules] :
New version with the failsafe option is up.
[Xposed Framework Modules] RusherDude:
Hey [MENTION=6065596]Rijul.A[/MENTION], long time no see! :)

Thanks for adding failsafe on last version :). (Edit: doesn't work, see bottom of this post :( )

However, it still lacks the last dot showing and the green unlock effect :( :( :( :'(

For that reason, I find myself continuously uninstalling last version and reverting to v1.1.3, because the effect is just awesome enough for it.

You told me you would look into this however I haven't seen anything for it in the last updates :(. It would be hard to just add the entire non-material method with the last dot and green effect showing (v1.1.3 effect) as an option for the dots? like permitting both the actual material system and the other one. It would be way easier that spending a lot of time trying to integrate the effect into the current animation.

Thanks a lot! keep up the good work!

EDIT: Tested v2.0 and failsafe does not work, after the 5 attempts the timer appears and then you can keep putting knock codes.

Nothing strange on the xposed log, only the "reporting unlock attempt, dismissing, dismissed, setting correct, verifying, inside verifying, etc.. loop).
[Xposed Framework Modules] M1P:
Failsafe option works as expected on Xperia LP 5.1.1.

Thanks a lot, nice job!

Sent from my D5803
[Xposed Framework Modules] :
https://goo.gl/photos/USrj8iyo1oTjL2DP6

You have to long press 5 times, without any short press in between. The timer will only appear if you short press.

And about your green dot, I don't want to do so much work for a feature I would not use (implementing both options and stuff), but I will add an option to have the last dot show and green up when I get around to understanding the AOSP dots view.
[Xposed Framework Modules] sudanking:
It is not working on HTC One M9... Using marshmallow Viperone ROM.
[Xposed Framework Modules] slimshouki:
It delays when I enter the code usually freeze 1 second or 2 which causes code to be entered twice

Emergency rext and icon is not displayed as well

Samsung s4 e330s stock tw 5.0.1
[Xposed Framework Modules] :
Sorry, no support for TouchWiz. I don't have a device to test it on. Even if I did, or I could find a tester, TouchWiz is not even consistent across devices at the same version. I cannot really support it. If you could give me logs with the delay, I might be able to guess why it occurs, but no guarantees.
[Xposed Framework Modules] Hermankzr:
Finally it's working like it was.

I've been waiting for this app to support Note 4 since i was always used this on my Note 2 (DN4 Rom). I've been left this app because it doesn't works anymore on my Note 4 5.1.1 stock.

And now it works again. Thanks for the dev. You've been break the challenge to support Note 4.

There's only a few thing needs to be fixed. As many people said it doesn't show camera shortcut and no Clock at all.

I knew it is already answer before but i just wanna know is there any chance of the future update to fix that?

Or anyone knows how to get rid of that limitation?

I mean any method to show Clock by for example using third party lockscreen.
[Xposed Framework Modules] RusherDude:
Ah okay, long pressing 5 times works, thanks!

Thank you! :D... But why dont just do the same for when an incorrect code is put, I mean you could reuse the same code for painting last dot and dots going up animation, but using green instead of red..? You already have that coded, just need to put it on succesfull attempt code too with just another color, right?
[Xposed Framework Modules] :
Lend / gift me your device and I will fix it. I can't say anything unless I have the device in hand, not knowing how your manufacturer has modified stuff.

No, animations automatically run in a new thread. The original thread dismisses the keyguard before the animation is able to start, that is why you don't even see the last dot even though it should be there. So I need to modify the code to freeze the current thread, wait until the animation thread is finished and then continue this one. However, because of the way the password dots view is made, that cannot be done without heavily modifying it, which will only be done once I get the time.

Please note that if you pester me more about this feature, it will never be added back. I have tried to explain to you many times already that I will add it when I get around to it. I do this work for fun, not to cater to other people, or for money.
[Xposed Framework Modules] Hassan096:
it didnt work for me , im on marshmallow sky dragon rom
[Xposed Framework Modules] RusherDude:
Ah okay, didn't think of that, thank you! :good:
[Xposed Framework Modules] :
Try latest version and report back with logs. No logs = no support.
[Xposed Framework Modules] Gggggas:
Works perfectly well on my Note 3 running a touchwiz Note 5 port.

I got a question, I guess the app is supposed to be as clean as possible but imo it would be handy if it would be possible to integrate some notifications without bothering the knock code area.

Just a suggestion that we could have as a choice in the app's settings.

Amazing work once again.
[Xposed Framework Modules] :
http://xdaforums.com/showpost.php?p=64946091&postcount=233

I see no reason to duplicate the work of Google when we see the notifications just a second earlier before swiping up
[Xposed Framework Modules] Gggggas:
Touchwiz issue as always lol [emoji12] thanks for the reply
[Xposed Framework Modules] lakyboss:
Hey, guys

I'm using Temasek's CM13 for OnePlus X, and I have knock code on lower half of the lockscreen.

When I had stock rom, everything was good.

I have attached a screenshot so you can see.

Is there anyway to change it, so it can be on the whole screen?

Thanks!
[Xposed Framework Modules] :
No, I tried but it does not work. Any help in this matter will be appreciated.
[Xposed Framework Modules] HGKing:
Does it work with screen off too (like the LG stock rom)?
[Xposed Framework Modules] nicesoni_ash:
No. It doesn't.
[Xposed Framework Modules] :
I have an idea, can you give me your Stock ROM's SystemUI.apk ?
[Xposed Framework Modules] lakyboss:
Here it is, SystemUI.apk from OxygenOS 2.2.0 for OnePlus X.
[Xposed Framework Modules] :
Thanks, I will take a look after exams end.
[Xposed Framework Modules] cattolicboy:
Best wishes for your exams!
[Xposed Framework Modules] comercials:
Knock code is not working on my HTC One m7 that is running on lollipop Android 5.0.2. With HTC sense 6.0. Anyone know how to fix this?
[Xposed Framework Modules] :
HTC support is not present, it cannot be fixed because I don't have a HTC device.

Unless you or somebody else signs up to be a tester, I will never be able to provide support for HTC devices, because I don't even know why it won't work. There have been 3 or 4 people who were keen to get it working, but nobody replied when I asked for logs to fix it. So I will not waste my time on such devices unless I can get a committed tester, or I can get somebody to loan me the device.
[Xposed Framework Modules] :
Could you also give me framework-res.apk ? The SystemUI does not seem to decompile properly - maybe framework-res will help
[Xposed Framework Modules] comercials:
I will send the logs if you still want them
[Xposed Framework Modules] :
Sure, fire away. Xposed logs should do fine. A copy of your com.htc.lockscreen.apk too, please. Thanks!
[Xposed Framework Modules] comercials:
Is there a way I can email it to you?
[Xposed Framework Modules] :
As per discussion on PM, could you try the attached APK? If it does not work, report back with logs. I have fixed only that particular error which was in the log you sent earlier, there may be more.
[Xposed Framework Modules] comercials:
Thank you it worked!!!
[Xposed Framework Modules] :
Thank you, you should now download the latest version from the repo, it has a few minor changes to suit HTC devices.
[Xposed Framework Modules] lakyboss:
Here.
[Xposed Framework Modules] diazepambr:
What do you think about implement a square like this?
[Xposed Framework Modules] :
No, that would remove the notifications. I like them.
[Xposed Framework Modules] :
Sorry, can't get that to work either. Apologies - I would have liked that feature too, but I don't know how to implement it. Thanks for your time though.
[Xposed Framework Modules] diazepambr:
But the pattern only show when you swipe up the lockscreen, notifications will still appear. Btw, thanks for your reply, awesome module ?
[Xposed Framework Modules] :
Sorry, I must have misunderstood. You want to border the knock code with a box?
[Xposed Framework Modules] diazepambr:
Yes, like this! No problem, it's my fault, my english isn't good, not expressed very well
[Xposed Framework Modules] KeithPhantom:
Can this be used by a Xperia?
[Xposed Framework Modules] M1P:
Using it on Xperia Z3C, working great so far...

Sent from my D5803
[Xposed Framework Modules] :
Umm, I will try. But since everything is dynamic (cannot use XML layout files), I do not know whether it will work.

Depends on the Xperia really, AFAIK. It will work on some OEM ROMs, but I don't know if everything will work as expected.
[Xposed Framework Modules] amirarsyad97:
Got it working on HTC desire 820s, 5.0.2, sense 7.

Thanks a lot! I really like it! :)
[Xposed Framework Modules] Tyaginator:
Its an awesome module, i love it. I have one feature suggestion can u add a feature by which we can open specific apps using assigned knock codes.

And thanks for this module [emoji106]

Sent from a Device using an App!
[Xposed Framework Modules] :
If I can figure it out, I will add it. I know the module you talk about, perhaps I will look at its source. However, it will take some time, life is hectic these days. Thanks for your feedback!
[Xposed Framework Modules] lxda:
Love the app idea but I was wondering if there's anything I can do to up performance? My lockscreen feels a bit laggy after installing this. Specifically, swiping up to access knock locked screen and unlocking the screen after a successful unlock
[Xposed Framework Modules] :
I will have a look, I think there are two functions which I should fix but I am not sure. Can you give me your Xposed log after unlocking - the statements that start with [KnockCode] are of particular interest to me. Make sure to send the time stamps with them, that will help me determine which statement takes time.
[Xposed Framework Modules] :
New version up!

[MENTION=7299907]lxda[/MENTION] : You might wanna try this out.

[MENTION=6815027]pantinPL[/MENTION], [MENTION=7294089]al_yabd[/MENTION] : Thanks for translations, they have been incorporated.
[Xposed Framework Modules] DNALogic:
Awesome Work

After using knockcode for years all I can say is, Fantastico, this is really great port for LP,MM devices,

It has become one of xposed module I can't live without. Great built bro :)
[Xposed Framework Modules] thoughtblocked:
I have a minor graphical suggestion if possible. I would increase the padding or margin between the knock area and the displayed code dots.

Also the module should work along with No Lock Home?
[Xposed Framework Modules] :
1. Okay, I will try that. I saw what you are talking about earlier, but I don't have the lines enabled so I didn't get to see much of it again and I had forgotten.

2. Yes, it will.
[Xposed Framework Modules] lxda:
Hey, the earlier lag issue was probably down to Xposed/my phone itself and not specifically your module!

I'll try and fix things on my end and check out your new version again. Thanks.
[Xposed Framework Modules] terroboy k9:
Cool update. Smoother now

Yuphoria blazed with velocity!!!
[Xposed Framework Modules] nixie2121:
I installed last night, is that the latest?
[Xposed Framework Modules] :
No. You can check for yourself in the installer.
[Xposed Framework Modules] nixie2121:
never mind, a refresh fixed my issue and I got the update, thanks!
[Xposed Framework Modules] terroboy k9:
The latest is 1.2.2 my friend check again

Yuphoria blazed with velocity!!!
[Xposed Framework Modules] RusherDude:
Awesome!

Now at least the last dot is shown and they animate up when password correct. However they animate up and to the left, why? looks kinda strange considering all stock stuff animates vertically only. If you can get that to paint green then my request will be over :laugh:

Btw, the dots kinda lag a little now on both a N5 and N5X, at least more than before, or i tested in a bad moment haha.
[Xposed Framework Modules] :
If you see here, there is no horizontal (X) animation, so you must be imagining things

https://github.com/Rijul-A/Xposed-K...cac#diff-50eea4dfe309a3900e931ef3cacd49e1R531

EDIT : They seem to go left because the disappear animation occurs at the same time as the move left and insert another dot animation.

> tested in a bad moment

Yes, haha.
[Xposed Framework Modules] RusherDude:
I'm not imagining anything!, they move to the left because the animation of the last dot appearing and the rest moving to the left is there, all the dots do a up AND left animation when dissapearing. The animation is close to 30º turned to the left...

Can this be fixed somehow? the stock dots seem to move vertically only even if all the dots are there o.O

And I re-tested and for some reason after every reboot the dots lag 3-4 times and then they work ok, didn't happen before :P.

Thanks for your hard work!
[Xposed Framework Modules] :
I cannot fix something I cannot reproduce. Do it yourself and file a pull request.
[Xposed Framework Modules] RusherDude:
You cannot reproduce the dots moving to the left? You even said the reason for that: the last dot appearing and pushing all the rest to the left :laugh:

EDIT: Tested on the N5X and it still happens but its very less noticeable, maybe a 5º movement only. Are you testing on a LG G4? maybe the movement is near vertical there.
[Xposed Framework Modules] :
30º I cannot reproduce. I barely see it for a second. Stop nitpicking. I won't fix it. I don't mind it.
[Xposed Framework Modules] RusherDude:
As I said, on the N5X I see 5º max, don't know why are you still talking about the 30º on the N5, its obvious that newer devices lag less and thats why you can't see 30º but you can see less º.

About the "Stop nitpicking. I won't fix it. I don't mind it", why are you so aggresive? I understand if you don't wanna change anything, just trying to report the bug for you.

You don't mind, you won't fix, okay for sure. I was just trying to report.

And I won't post here again if you want, seeing how aggresive you are to any of my posts, just say it if you want this :).

Thanks and keep up the good work.