yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] :
Can you give me your Xposed log - I added a statement in there. It is strange that full screen occurs after unlocking, because from what I understand, it should not happen because it would require a restart of the keyguard.

No, I did not try it yet. But I did look at Max's source code, and it seems that to implement it with a custom grid size and so many customization options will take a lot of time.

Hmmm, it's quite subtle right now. Let me make it a bit bolder.

EDIT : Turn on the correct lines and check if the disappear animation works well?
[Xposed Framework Modules] :
New release (1.3.8) is up
[Xposed Framework Modules] Ms_Julia:
UTF-8 & Unicode
[Xposed Framework Modules] :
I have uploaded a version, can you check if it contains the translations?

Now when I am trying to compile it does not let me. Same error as before. But the uploaded version seems to have compiled with success. v1.3.9
[Xposed Framework Modules] :
Those of you who were having issues with OEM ROMs (Touchwiz) having disabled the swipe up notification screen, can you please check this release? Make sure to enable the option Show notifications first, and set Directly show knock code entry to Never, please report back with logs. Thanks!

[MENTION=5923792]crille612[/MENTION]
[MENTION=7174976]nabil08[/MENTION]
[MENTION=6223117]amer_zx[/MENTION]
[MENTION=5597804]Gggggas[/MENTION]
[MENTION=7283585]AciDxLK[/MENTION]
[Xposed Framework Modules] yakie996:
Awesome! sadly enough I can't test it since I bought a new phone moto x style and I'm having trouble with unlocking the bootloader for some reason :/
[Xposed Framework Modules] crille612:
Yes it's working now on tw. Thank you

Clock is showing up on knock code and notifications are covering the knock code screen. Unlocking effect sticks to knock code. And when phone has been locked on knock code screen it stays on the knock code screen when woken up, (it skips the swipe screen)
[Xposed Framework Modules] reallyimjesus:
Here you have the logs. If you need anything else, please let me know.
[Xposed Framework Modules] Gggggas:
As [MENTION=5923792]crille612[/MENTION] said it works, great to have this feature back good work dev!

I found that the custom shortcut for apps when executes it doesn't go to the app but stays at the lockscreen. I have to turn off and on the screen and unlock using the master tap password in order to show the app but this unlocks the phone. The feature to go back to the lockscreen when exiting the app doesn't work this way.

And I have the App Settings Xposed module mentioned and have checked to show in lockscreen.
[Xposed Framework Modules] prestodigiti:
I think you can implement this in a way that it can only work if the 2x2 grid size and the hidden dividers are used. Because i think it will be rather confusing than useful for people who have a grid size bigger than 2x2 and useless for people who have dividers on. I believe that this way it won't be harder to implement and it will be useful for those who have the dividers hidden.
[Xposed Framework Modules] :
Let me try to fix that if I can figure it out

Does that happen with versions on the repo too?

I am sort of an all or nothing guy, so I am gonna do it for all sizes when I get the time.
[Xposed Framework Modules] :
Can you redo the log with other modules disabled?

Also, could you please disable Gesture Unlock permanently? It might conflict with Knock Code
[Xposed Framework Modules] :
So, to clarify,

1. Knock code works, but notifications are in the background?

2. Once turn off and turn on screen, knock code still visible?

To mitigate 2, check attached APK and report back. It might loop you in the lockscreen, so be ready to boot into recovery and delete /data/data/me.rijul.knockcode/shared_prefs/me.rijul.knockcode_preferences.xml
[Xposed Framework Modules] crille612:
1.Yes, notifications are on top of knock code. I can swipe them away when on the knock code screen.

2. When turning off screen on knock code and turn on again it skips the swipe screen. And stays on knock code screen. But if I unlock the phone completely and lock it. The swipe screen shows up.

I tried the apk it did no difference at all. (But it didn't loop me in lockscreen)
[Xposed Framework Modules] Gggggas:
Does that happen with versions on the repo too?

I'll try with 1.39 and report back.

EDIT: I tried 1.39 repo version and the same thing happens. When I type the knock code for an app to launch it launches in the background but the lockscreen doesn't unlock unless I turn off and on again the screen in order to type the master knock combination.
[Xposed Framework Modules] Tyaginator:
I feel that the newer animation after 1.3.6 is slower than the older one and also it takes more time to unlock screen after entering correct code. And unlocking also doesn't feel as smooth as in older one i.e upto 1.3.5. I switched back to 1.3.5

Does anyone also feel that?

Sent from a Device using an App!
[Xposed Framework Modules] Gggggas:
I haven't tried older versions but the animation is very smooth and snappy. By the way I'm on the Phronesis 6.3 rom on my Note 3 hlte.
[Xposed Framework Modules] Gggggas:
Dev, it would be nice if we could open the notification we click on the lockscreen directly after unlocking. Just like it normally works cause now I select the notification to open after unlocking the lockscreen but it doesn't launch.
[Xposed Framework Modules] Ms_Julia:
Slightly revised translation of the text, but will require a subsequent correction.

Please apply it in the next update.
[Xposed Framework Modules] M1P:
You can try the latest version (1.3.9), and disable "Wait for last dot animation" under Duration setting.
[Xposed Framework Modules] Tyaginator:
Oops! didn't checked that. Now it's fine, thanks.

But that AOSP swipe up animation speed is slower, due to which most of the time my code goes incorrect.

Sent from a Device using an App!
[Xposed Framework Modules] :
I think your App Settings etc are not working properly. Please check if you click the save button in App Settings and turned on the setting in knock code.

Which version? 1.4.0 or 1.3.9? Please be clear.

I can add an option to close the lockscreen when screen off, perhaps.

I will add an option to customize this.
[Xposed Framework Modules] Gggggas:
I don't know if it's an App Settings problem or if it has to do with Touchwiz roms, if some other guys told us if it's working for them it would be great.

About the problem on opening notifications directly after unlock, it can only be used on 1.40 cause on 1.39 you can't see your stock lockscreen before swiping to enter the knock code.

We need more feedback from other touchwiz rom users about these 2 issues.
[Xposed Framework Modules] crille612:
You are correct, I also have both these issues on 1.40
[Xposed Framework Modules] :
I think it's because your ROM has modified the lockscreen beyond what I have expected.
[Xposed Framework Modules] Gggggas:
Possibly yes. There are a lot of mods on Phronesis roms.
[Xposed Framework Modules] :
Thanks, merged.

I have also uploaded a new strings.xml in my project, can you please translate again when you get the time? Some of the things you would already have translated, just need to translate the new things, and remove the old ones. You can see the changes by clicking on the history button.

Lastly, is there a link for your page so that when people click on your name in About, they see it?
[Xposed Framework Modules] :
New version is up [MENTION=5327227]Tyaginator[/MENTION]
[Xposed Framework Modules] :
Translators, you can use this page for updating translations now, no need to worry about encoding, uploading, etc. I will merge translations with releases, so even incomplete translations when you get the time will work too!

https://crowdin.com/project/knock-code-xposed
[MENTION=6815027]pantinPL[/MENTION]
[MENTION=5976147]Ms_Julia[/MENTION]
[MENTION=7294089]al_yabd[/MENTION]
[MENTION=6976675]TheromsMan[/MENTION]
[Xposed Framework Modules] Tyaginator:
Thanks you so much!!, it works perfect now.

Sent from a Device using an App!
[Xposed Framework Modules] reallyimjesus:
Sure. I'll upload it now. The logs should show the first device unlock, when the layout is the regular, small one. Then it should show the second unlock, after the layout is changed automatically.
[Xposed Framework Modules] _cab13_:
Hey [MENTION=6065596]Rijul.A[/MENTION] ! Module working perfectly on Sony Stock Xperia Z5 (LP and MM). The only feature broken is fullscreen. Exepted that, all working fine.
[Xposed Framework Modules] :
Nope, nothing in there about the module converting it to full screen. I honestly have no idea why that would happen then. Apologies.

Logs + SystemUI.apk
[Xposed Framework Modules] Ms_Julia:
I will finish the translation of tomorrow, today I have a rest on my birthday:D
[Xposed Framework Modules] bzlmdfk:
Polish translation have wrong coding.

Ciul dup jeb wysłano z Xperii Zet 2
[Xposed Framework Modules] Ms_Julia:
Translation completely updated and finished

Please note that many of the lines has been changed.
[Xposed Framework Modules] SyCoREAPER:
Any chance you can make the knock box relative similar to how MaxLock is doing it for app locks? He does not have an actual grid, the 4 areas are relative to one another depending where you initially tap.
[Xposed Framework Modules] Tyaginator:
Someone already asked for this feature, rijul said he'll try it.

See post no. 476

Sent from a Device using an App!
[Xposed Framework Modules] SyCoREAPER:
Thanks,

In reference to him (rijul) questioning if it is worth it, I would pay a premium/pro fee to have this, I think that is a very good feature.
[Xposed Framework Modules] AciDxLK:
]

Sorry just got this now. Did as mentioned how do I share the logs?
[Xposed Framework Modules] :
Turn off all modules except Knock Code. Reboot. Play around with the lockscreen a bit.

Go to Xposed Installer -> Logs -> Menu -> Save to SD Card. Attach the file here (path will be shown in a toast).
[Xposed Framework Modules] AciDxLK:
I think thats it
[Xposed Framework Modules] :
I would appreciate a description of the symptoms too
[Xposed Framework Modules] AciDxLK:
A description?
[Xposed Framework Modules] cazuniq:
Using Z3 Xperia, please add option to remove or add "Sound" cause when I enter the knock code, it makes the tapping sound, as I was navigating through my phone
[Xposed Framework Modules] Tyaginator:
Turn it of in Settings>sound>other sounds

Sent from a Device using an App!
[Xposed Framework Modules] :
Does the app work? What does, and what does not? Are you able to see the notifications? Anything at all, really. How will I fix something if I don't know what it is?
[Xposed Framework Modules] AciDxLK:
Same as before, knock code takes up most of the screen, clock disappears and notifications dont show
[Xposed Framework Modules] :
Log doesn't mention anything related, apologies.
[Xposed Framework Modules] AciDxLK:
I can screenshot it if you like, that's how it's been since I installed this on release
[Xposed Framework Modules] Teblakuda4o4:
Was using v1. 4.1 and I had the full-screen bug. I changed launchers from Google Now to Nova, and now lock screen isn't stuck in full-screen anymore.

If anyone else is using Google Now, try Nova, see if it works.
[Xposed Framework Modules] :
I will work on this feature in some time, once I understand how Max's implementation works, I will see. Right now I have exams and then I'm going away for my internship, so you'll have to wait a bit longer.
[Xposed Framework Modules] raphTec:
I experience a lag with this module enabled:

When you swipe up the notifications from the lockscreen, as soon as you release the finger from the screen, the unlock challenge will be displayed or, to be more precise, the appear animation of the unlock challenge starts.

With this module enabled, as soon as I release my finger, the notifications moving up stop for a split second and then the unlock code starts appearing. This lag is not existent with the module deactivated. The lag is clearly visible when swiping up after locking the device. On subsequent swipes the lag is minimal, to see it again, one must fully unlock and lock the device again.

I have a kernel setting which can flash the notification light when there is I/O access to the flash memory. While the lag appears, no I/O access seems to take place, so it may not be an resource loading problem.

I would appreciate it if this already extremely cool module could be further improved by removing that lag. Thanks.
[Xposed Framework Modules] Tyaginator:
Try this

Go to Knock code>duration and reduce appear animation to 250

Sent from a Device using an App!
[Xposed Framework Modules] raphTec:
Does not work. The lag is not in the appear animation of the knock code, but in the movement of the notifications.
[Xposed Framework Modules] Tyaginator:
Don't know, mine works butter smooth.

Sent from a Device using an App!
[Xposed Framework Modules] raphTec:
Just checked: lag issue persists with all modules off except knock code. So I am pretty sure that this module is the cause.

I use cyanogenmod 13 nightly on my nexus 6,but cyanogenmod has some serious bugs on the lockscreen since a month or so, maybe it is related. I can't remember if it worked fluently before the lockscreen bugs appeared.
[Xposed Framework Modules] :
Can you send me a video of this?
[Xposed Framework Modules] raphTec:
https://www.dropbox.com/s/gowm0snxb4tjyrc/SCR_20160508_145429.mp4?dl=0

Here it is. Note how the notifications stop moving up for a split second when releasing my finger. This happens only the first time after locking the device.
[Xposed Framework Modules] :
I don't see it
[Xposed Framework Modules] raphTec:
I know, it is very hard to see. It can be best seen at 0:15 of the video. To make it better visible, i used the command line tool ffmpeg to extract the individual video frames from my screen record:

ffmpeg -i SCR_20160508_145429.mp4 -r 60 -ss 00:00:15 out%03d.png

Then I selected the relevant frames, I will upload them later today, when i have good internet access again. Hope you also have a good and unlimited internet connection, there are about 100MB of png images total which can be viewed individually. If not, i can scale them down...

I can see that the movement freezes for 10 images, that is 166ms at 60fps.

edit: I have frames from two different video parts:

The first one is from 0:07 and shows almost no lag because this was not directly after I locked the device. Here are the frames: https://www.dropbox.com/sh/q1n9n5ycibuj424/AADUltehwB2jik6dH9E_CDlga?dl=0

There are only two frames of lag: out102.png is duplicate to out103.png. also out104.png is duplicate to out105.png. This is not notable , and therefore not really a lag to me.

Compare that to position 0:15 of the video, where I also extracted the frames:

https://www.dropbox.com/sh/qif5xh4gz1jk68e/AAClfAcrZPNtRjPxmKY0vkKna?dl=0

At frame "out26.png" I released my finger, you can tell because the touch point marker stops moving (it is displayed a little longer than the actual touch event happens and fades away then). Then, until frame "out036.png" the notifications don't move, after that, they suddenly jump up. It seems to me that the display is not properly updated, but the movement continues in the background ...

Since 10 frames are visible to me, I would consider this as a lag.

Hope I can help.
[Xposed Framework Modules] :
I will get back to you with a release with a few log statements inserted here and there, and maybe then we can see what it is. I don't feel it while using my phone, so it's probably gonna be on you to check what works and what does not. Is that okay with you?
[Xposed Framework Modules] raphTec:
Would be OK for me. I am a bit amazed that noone before found that lag or submitted it... Hope it is not only my device at all...

Thanks for the support on this.

Nexus 6 with CyanogenMod 13
[Xposed Framework Modules] Juara ads:
Whats the effect of this module on battery? I think this is like doubletap2wake function which is a real battery drainer.
[Xposed Framework Modules] phanipk:
no effect
[Xposed Framework Modules] Tyaginator:
It doesn't work while screen is off like dt2w. It's simply a replacement for stock android lockscreen so it has no impact on battery.

Sent from a device using an app!
[Xposed Framework Modules] terroboy k9:
Thnx for border less taps with circle animation, a long awaited feature , in love with knock code :)
[Xposed Framework Modules] yakie996:
Motorola has some kind of ambient display is it possible to already enter the code there (invisible) since the screen is already on?
[Xposed Framework Modules] A4shay:
Hey guys i have an idea if we remove widgets from lockscreen and apply black wallpaper then use tap code then it will unlock in black screen and will looklike phone is turn off and be similar to lg g4 .........

Srrry for my english
[Xposed Framework Modules] Tyaginator:
Nice thoughts but it won't look like that, you can go ahead and try it, there are many xposed modules available that can do that.

Sent from a device using an app!
[Xposed Framework Modules] :
A new version is up which replaces PIN instead of pattern, so that people with Google Apps Device Policy situations which force PIN/password can use this module 0(eg. me now, at my new work place).
[Xposed Framework Modules] nicesoni_ash:
Will this new version obsolete the pattern unlock cause it's not showing me knock ui anymore but pattern lock?

Sent from my "i9300/1+2" powered by Carbon/RR

Fueled by 7000mAh ZeroLemon Battery
[Xposed Framework Modules] :
Switch to PIN in stock settings, it will work.
[Xposed Framework Modules] :
It is possible, but it will need some changes to the ambient display. You can check some of it out by

1. Set directly show knock code to always

2. Increase your doze pulse duration time (may need another module, my ROM has an option in the setting)

So now on ambient display you can enter the code, but once you do and the timeout for doze expires it will turn off the screen without locking it. If I can figure it out so that upon unlock some signal is sent to the system to not turn the screen off, it will wok well.
[Xposed Framework Modules] nicesoni_ash:
That's what I am asking, pattern lock won't work anymore?

Sent from my "i9300/1+2" powered by Carbon/RR

Fueled by 7000mAh ZeroLemon Battery
[Xposed Framework Modules] Naveenjotron:
New update not working.(1.4.2)

Version 1.4.2 is not working on my zenfone 4.5.....

But, previous version(1.4.1) works fine on my device....
[Xposed Framework Modules] :
No, it will only work with PIN. Do you have any issues with using a PIN or are you just curious? My workplace won't allow me to use a pattern so I had to change it to PIN.

Did you switch to PIN?
[Xposed Framework Modules] nicesoni_ash:
Both actually, but I can switch to PIN now, no problems. [emoji4]

It would be great if there is an option within the module to switch between these two if possible.

Sent from my "i9300/1+2" powered by Carbon/RR

Fueled by 7000mAh ZeroLemon Battery
[Xposed Framework Modules] B8shT1m3:
Yeah that would be cool :D

Anyway great work:good:
[Xposed Framework Modules] Tyaginator:
I don't know why does it matter using pin or pattern, coz you're actually still using knock code to unlock the phone.

Sent from a device using an app!
[Xposed Framework Modules] nicesoni_ash:
It's not only for unlocking the phone, same protection is used in other areas too after you unlock the phone.

Sent from my "i9300/1+2" powered by Carbon/RR

Fueled by 7000mAh ZeroLemon Battery
[Xposed Framework Modules] Tyaginator:
Other areas? Like what?

Sent from a device using an app!
[Xposed Framework Modules] nicesoni_ash:
Protected apps in privacy setting for example.

Sent from my "i9300/1+2" powered by Carbon/RR

Fueled by 7000mAh ZeroLemon Battery
[Xposed Framework Modules] Tyaginator:
I don't think it matters to protected apps. It uses its different key, Even if i use PIN, pattern or swipe on main lockscreen, protected apps still asks for its pattern to authenticate app.

Btw i'm on CM13, maybe its different for you

Sent from a device using an app!
[Xposed Framework Modules] nicesoni_ash:
I know it can be changed or use a different one yet I would prefer to use the default one set as my lock code. I know it can be avoided but that's how I would like it. Everyone has their own choice. Enough ot, further discussion via PM please.

Sent from my "i9300/1+2" powered by Carbon/RR

Fueled by 7000mAh ZeroLemon Battery
[Xposed Framework Modules] Dhaval2904:
Thanks for the great module buddy.

It was working perfectly until yesterday . But after updating to latest cyanogen mod 13 it stoped working. I'm using Nexus 5 (Hammerhead). Hope you'll give any solution .

Thank you
[Xposed Framework Modules] :
The module now uses PIN instead of pattern, please switch - it will work.
[Xposed Framework Modules] ajkahn:
Was this listed in the changelog? I didn't see it anywhere till I ran into this thread.

Please make this a sticky.
[Xposed Framework Modules] :
Unable to reproduce on CM12.1 or 13.0 - sorry. You will need to provide logs.
[Xposed Framework Modules] RusherDude:
I am unable to reproduce it either :S, and I don't like this honestly..

I tested before and nothing worked, I knew what the old code was (because the app did let me change it for another) but at that moment the app was waiting for a 1-position shorter code.

I tested going from the 5 dots code (by default) to a 3 dots code and it worked.

I also went from 3 to another combination of 5 docks and works ok now..

No idea.. but there is some error case there that blocks you from accessing the phone. You'd see in your code where you could skip reading 1 position when saving the password because that seems what did happen before and not now.

Also more feedback!

The "incorrect pattern" message should be occultable too!! this was on the 4.4 version (people went crazy figuring what was happening, which is what I like) , but on this version you can't do that. Imho this is a critical point because lets people detect there is pattern, if we want an invisible riddle to solve this breaks it up for me :(. Please add this option to completely hide system messages or to be able to change it in something (like a dot appearing somewhere if password was bad, 2 dots if you were blocked for 30s, etc.)

For now tho it seems to work with the mentioned problem above, thank you a lot!!!
[Xposed Framework Modules] ajeesh vijayan:
marshmallow 6.0.1 works perfect

thanks for this amazing piece of work...
[Xposed Framework Modules] crille612:
Is it possible to make the knock code grid size smaller, and make notifications show on the lockscreen. Thank you
[Xposed Framework Modules] :
Smaller as in 2x2 in size, but reduce the height and width?

Notifications on lockscreen are already shown to me, before the swipe up on the knock code. Do you want notifications again in the knock region?
[Xposed Framework Modules] crille612:
I don't have any other swipe up screen. When the screen comes on it is on the knock code screen. That's why I want notifications.

Like on Lgs knock code.
[Xposed Framework Modules] :
Which phone and ROM are you using? Here's what I get first, where I swipe up to reach the knock code. http://forums.androidcentral.com/at...-driving-screenshot_2014-11-18-14-09-08-2.jpg
[Xposed Framework Modules] RusherDude:
It would be cool if apart from changing the grid size, we have options to both make the grid total size on screen either bigger (full screen, not only lower part) or smaller (more at the bottom).
[Xposed Framework Modules] crille612:
I am using a samsung galaxy note 3 with Phronesis Rom, android 5.1.1

I don't have the screen that you have before the knock code
[Xposed Framework Modules] :
This post has instructions on how to enable/disable lock screen notifications on your ROM http://xdaforums.com/galaxy-note-3/...le-feature-t3241910/post63992071#post63992071

I will not be implementing the notifications feature on the knock code screen, as I see no need for it. Apologies.
[Xposed Framework Modules] crille612:
Thanks anyways mate (I don't have the first screen so notifications and the clock etc doesn't show. Notifications are enabled) :good:
[Xposed Framework Modules] ahero123a:
Here's my result..