yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] RusherDude:
Thanks a lot!

Well, as a suggestion, maybe the dots would look better if they moved all the screen up like the original pattern. That'd make them match the screen animation and lool cleaner. Right now they move very few pixels up (less than in previous version?) and its like a secuence: first dots move up, then emergency text moves up, then activity moves up.

With dots off, its difficult to show the outcome... The rest of the activity turns also green and moves up, so maybe making them move up a lot more would be more noticeable and do the job?

This new version is awesome! The new apps over lockscreen work wonders!! Only see 2 issues:

- hiding emergency text doesnt seem to do anything.

- the lag at recognizing the code on the lockscreen (both the ko and the ok cases) is bigger now for some reason?. There is like 1s between the last input and the color change and animation, this didnt happen for the wrong code before (it did with the ok code tho, but I remember it being less?).

Real nice job!!
[Xposed Framework Modules] :
Don't understand this. The moving up amount has been reduced because (see below)

Can't make them move much more up because they will fly off the screen if the code is in fullscreen.

Found the bug, squashed it.

Added an option to customize the lag for yourself.
[Xposed Framework Modules] :
New version with a few fixes and animation duration options is up.
[Xposed Framework Modules] prestodigiti:
I'm using a nexus 5x actually.
[Xposed Framework Modules] cattolicboy:
[MENTION=6065596]Rijul.A[/MENTION] , very nice improvements in the latest version, but I can't get to work the full screen feature (Sony Z3 Compact with marshmallow concept software).

Any suggestion? Do you need my systemUI?

ps: not a problem on another phone with CM13
[Xposed Framework Modules] :
Yes, with Xposed logs
[Xposed Framework Modules] RusherDude:
I can't enable fullscreen for some reason (nothing happens), so I can't test fullscreen.. but would it be possible to add 2 different animation lenghts, one that moves up all the activity up when not fullscreen and one that doesn't when on fullscreen?

I don't know how the stock android pattern dot system works, but it actually looks awesome since 6.0.1, because the dots start moving up instantly after putting the correct code and move up all the screen accelerating and deccelerating at the end. I guess this can't be replicated on this module :crying:, it would be one of the best updates ever :laugh:

Very graphic :laugh::laugh:, thanks!

Uhm, I didn't explain me too well :P, sorry. I wasn't talking about the animation time (which you call lag on that option), but the time between the last dot appareance and the color turning/animation start. It is bigger than on old versions, it's like there's a half a second after the last dot is there where nothing happens and then the ok/wrong code animation starts. You once told me that the "lag" when the ok code was input was needed for some reason, but there wasn't any before in the wrong code cases :crying:.

However this option is very cool to control the animations, a nice add!! :good:

PS: Any special step needed for fullscreen? doesn't seem to work even after restarting.

Thanks a lot for your awesome work mate!!! :laugh: :laugh:
[Xposed Framework Modules] :
I think right now it looks cool, so not changing anything.

I don't know how to do animations that well, so not changing anything there either.

> The gap is equal to the time it takes for the new dot to appear and settle in, and it was the same in previous releases. Not changing that. Refer https://github.com/Rijul-A/Xposed-K...me/rijul/knockcode/PasswordTextView.java#L293 and https://github.com/Rijul-A/Xposed-K...in/java/me/rijul/knockcode/DotsView.java#L156

> Fullscreen : No idea. Give me SystemUI.apk and Xposed logs to check.
[Xposed Framework Modules] RusherDude:
Fine :good:. However for the future, it could be a great update to keep up with the stock dots moving up animation, because that was one of the best addings google did on 6.0.1, hyper sleek!

No, it wasn't. The gap was inexistent for ok/ko cases in the old and best version 1.1.3, and it was inexistent for the ko case in the last "big" version 1.2.5!!.. I am not lieing, just test those 2 versions. The lag has been increasing since then :crying::crying: , and right now the lags on the last version are the majors ever. I understand this after the complete remade module! but it lags more :(

Nothing on xposed logs related to this mod (some errors from FSCB but nothing from yours). Only thing is "[KnockCode] AOSPish Device"

I'm using this both in a N5X and on a N5, both in stock, do you need the systemUI.apk for stock too?
[Xposed Framework Modules] prestodigiti:
Finally another 5X user who can't enable the fullscreen option. I thought i was the only one in this thread.
[Xposed Framework Modules] :
I have no idea why fullscreen will not work in your devices, because the module is replacing the correct resource. Have you disabled resource hooks in Xposed settings?
[Xposed Framework Modules] :
Does not decompile, probably cause I have slow internet. Can you run it via decompileandroid.com and give me the zip that is generated?
[Xposed Framework Modules] crille612:
That site does not decompile it. I decompiled it myself with apktool. Here it is decompiled, just unzip it
[Xposed Framework Modules] andrehsu:
Sometimes the "incorrect" text does not disappear after the designated time
[Xposed Framework Modules] :
Cannot reproduce.

It will only disappear after the red dots animation is completed, if it is enabled. Otherwise it disappears after the lines error time, if enabled. Otherwise it disappears after the text error time. Please check.
[Xposed Framework Modules] :
I could have done that, but my apktool installation only gives smali for some reason. Your ZIP didn't even have that.
[Xposed Framework Modules] kman1706:
Hi, great work! I do have an issue with the last update where by the full screen knock code is automatically set even though it is disabled in settings. I'm running CM 12.1 on a Galaxy S4. Do you know what could be causing this? Thanks.
[Xposed Framework Modules] rana ali nawaz:
(Directly show knock code entry) that's the feature i want..cuz its time saving...but the lock screen becomes too dim...i can't see clock time...if its a bug...plz fix it..if not...than plz make it brighter... Thanks
[Xposed Framework Modules] :
Try to enable and disable the feature manually, and then restart the keyguard?

Bright Lockscreen is an Xposed module which will serve you well.
[Xposed Framework Modules] rana ali nawaz:
But lock screen is OK when this feature is disabled... I can easily see clock...or notification....it makes lock scree too dim...
[Xposed Framework Modules] kman1706:
Tried that multiple times but it's still in full screen mode either way. Would reinstalling KC or installing an older version do anything possibly?
[Xposed Framework Modules] rana ali nawaz:
But lockscreen is fine if this feature is disabled..i can see clock and notifications easily
[Xposed Framework Modules] :
I have no idea why it is making it full screen if it is not configured to. Which version are you on, again? Which version did it work as expected? EDIT : Are you restarting the keyguard after changing the option?

1. Disable background for the knock code, if you haven't done so already. Or at least reduce its opacity.

2. Please try Bright Lockscreen - it has an option to customize the opacity of the overlay which shows up behind the knock code, as well as that of the overlay which shows up on the lockscreen. Currently you are seeing two overlays matched together, both of the security screen as well as the lock screen and that is why it appears dark. Change one of those overlays using Bright Lockscreen and you will be good to go.
[Xposed Framework Modules] kman1706:
on latest 1.3.3 was previously on 1.2.3 I believe. I removed it completely before installing 1.3.3
[Xposed Framework Modules] :
I have no idea. My college will start tomorrow so releases will be scarce, but I will make a debug release soon to help out those who are having trouble. You can go back to 1.2.5 if you wish to, but it is not as well built as the new versions.
[Xposed Framework Modules] rana ali nawaz:
Ya thank you so much... It fixed with bright lockscreen...but i requested you that can you plz add this feature in knock code...thanks again
[Xposed Framework Modules] :
No.
[Xposed Framework Modules] Rakuu:
For what? A module for this already exists, he's about to start classes he has more pressing things to do than make his module redundant.
[Xposed Framework Modules] :
Can you give me content of /data/data/me.rijul.knockcode/shared_prefs/me.rijul.knockcode_preferences.xml ?
[Xposed Framework Modules] rana ali nawaz:
Ok...dont be aggressive..
[Xposed Framework Modules] andrehsu:
When the dots move up due to an error, the text doesn't disappear, resulting the text to be cut in half.

Also, I can't seem to enable/disable keyguard using tasker after version 1.3.0
[Xposed Framework Modules] :
> Which options are enabled, I am still unable to reproduce that error.

> Can you give me a Logcat with that? No idea how tasker works
[Xposed Framework Modules] andrehsu:
Weird, the tasker error resolved itself after a reboot.

http://imgur.com/a/bmZSJ
[Xposed Framework Modules] kman1706:
Here you go.
[Xposed Framework Modules] kman1706:
I sent the file as is. There is nothing else to it.
[Xposed Framework Modules] andrehsu:
The email is there because I added it as owner's info. Any way I can get more info for you?
[Xposed Framework Modules] :
Can you use a laptop and run the adb command as given in my last post?

EDIT : Or you could run this on a terminal emulator and screenshot it and send it to me?

su
cat /data/data/me.rijul.knockcode/shared_prefs/me.rijul.knockcode_preferences.xml

I think maybe it's a problem with uploading on XDA, could you try hastebin or someplace else?

Wait for a debug release, I guess. I think it should change the text, the code is pretty well configured.

https://github.com/Rijul-A/Xposed-K...e/rijul/knockcode/KeyguardKnockView.java#L418
[Xposed Framework Modules] :
Oops, nevermind, it was the browser. Opened it in gedit and it worked.

It does say fullscreen is off, so why won't it work, I have no idea. Wait for a debug release.
[Xposed Framework Modules] kman1706:
Ok cool, thanks anyway. Might just be a CM issue.
[Xposed Framework Modules] Pelufaz:
Full screen always on (HTC Desire 626s Lollipop 5.1 twrp)

Help please, 1.3.0 was perfect but when I updated the module to 1.3.1 the knock code became full screen and overlays the clock and is annoying. The full screen button is disabled. I tried to install 1.3.0 again but it doesn't work, still full screen.
[Xposed Framework Modules] Tyaginator:
Try clean install.

Sent from a Device using an App!
[Xposed Framework Modules] Pelufaz:
Doesn't work
[Xposed Framework Modules] RusherDude:
[MENTION=6065596]Rijul.A[/MENTION] I've found a small bug when the "shortcuts over lockscreen" option is enabled: It can do direct calls without a problem for example, but it can't open apps (tested with calculator and Clash Royale), it instead opens them in the background and when you unlock the phone the actual app is opened. If we disable the "shortcuts over lockscreen" option, both direct calls and app opening works without a problem.

No error or message about Knock Code on the xposed log other than [KnockCode] AOSPish Device.

Apart from this, the old minor bug that lets you add infite more dots on the code once it turns green (correct) is back: it doesn't work when the code is wrong, but when it is OK, after it turns green, you can press any key and make infinite more dots appear apparently :P.

Full screen still doesn't work, told you Im trying in both stocks Nexus 5 and Nexus 5X and if you needed the SystemUI apks or not, since the code for it should be in aosp being stock. Maybe you worked with it already.

Keep up the good work!
[Xposed Framework Modules] :
Uninstall latest version. Install 1.3.0. Activate in Xposed. Reboot. Don't update if 1.3.0 is perfect for you.

> The instructions ask you to use App Settings Xposed, are you using that?

> Will fix the dots bug when I get time.

> No idea about fullscreen, as I said before.
[Xposed Framework Modules] :
A new version is up with shake on error animation, vibrate on error option, the green dots bugfix, and other UI changes.
[Xposed Framework Modules] Rainy_day:
• Help Please •

Oh guys, I disabled line option and now I can't imagine where are the squares exactly. Please someone upload a screenshot while entering knocks in 4 row and 3 column (I think full-screen option had been enabled). I remember my code, only give me a correct view about placement of blocks.

I can't access my phone! please harry up!
[Xposed Framework Modules] :
5 long presses one after the other will kill the knock code.
[Xposed Framework Modules] Rainy_day:
Thanks, but I had disabled failsafe that time with my own risk ;)

So finally (as an alternative way) I disabled xposed tool entirely via terminal command in TWRB recovery.
[Xposed Framework Modules] :
Protip : You could delete the preferences file from recovery of my module

/data/data/me.rijul.knockcode/shared_prefs/me.rijul.knockcode_preferences.xml

Or you could even delete the APK if you believe that the module is not working at all

/data/app/me.rijul.knockcode-*/base.apk

This way you prevent the requirement of another reboot after re-enabling xposed.
[Xposed Framework Modules] :
A new version is up with (possibly) fullscreen bug fixed for some devices. [MENTION=7371968]Pelufaz[/MENTION]
[Xposed Framework Modules] Rakuu:
Just wanted to say it's fixedish on Samsung for me at least, still is pretty full screen the same way it was before, never squishes though so I'm fine with it .
[Xposed Framework Modules] prestodigiti:
The fullscreen bug is still there :( also the restart keyguard button stopped working after this update
[Xposed Framework Modules] Pelufaz:
I tried to install 1.3.0 again but didn't work. The newest version didn't fix it too.
[Xposed Framework Modules] RusherDude:
Didn't notice that :S, my fault. It works with app settings, thanks!

The new shake animation is cool!, but you deleted the old red dots animation in the process :( could you put an option to choose, please? :fingers-crossed: the old animation was cooler, way more material :(. Also the new animation would gain a lot if the dots turned red too!

Returning the option to select color for the KO case and adding a switch for dots anomation (push up or shaking) would make this awesome :victory:. And could be extended to the OK unlock scenario too, this option has potential :good:.

Fullscreen still doesn't work on N5/N5X :(.

--

Btw, a little suggestion: like you imported the "direct unlock" feature from gravitybox, could you import too the app settings feature so the module doesn't depend on it? app settings usually never works after an update until someone fixes it, and it's an app only for this, because all the other features don't work at all anymore..
[Xposed Framework Modules] :
No.

Nope. App Settings has been fixed by Marshmallow for pyler who is a trusted member of the community. Everything works in app settings as of now. I don't want to make my module redundant.
[Xposed Framework Modules] Rainy_day:
Is there any option to increase the max number of knocks? Older version let us enter up to 12! please remove this restriction.

Thanks in advance.
[Xposed Framework Modules] :
Currently it is 10 https://github.com/Rijul-A/Xposed-K...va/me/rijul/knockcode/LockButtonView.java#L19
[Xposed Framework Modules] Rainy_day:
In latest version (1.3.5) it's 9, not more. 10th tap makes everything clear!

Please if it's possible change max to 12.

github link refers to 1.3.3 ver

Thanks
[Xposed Framework Modules] reallyimjesus:
The knock code field still shows full screened even though it's not configured so. It displays correctly right after boot up, but then it changes. Nexus five on stock 5.1.1
[Xposed Framework Modules] :
Sure, next release.

Are you on the latest version?
[Xposed Framework Modules] reallyimjesus:
Yes. Updated yesterday in hopes it'd get fixed, since it was stated in the update info. It seems to still be an issue.
[Xposed Framework Modules] RusherDude:
Well Rijul, you're doing a great work with the module, but completelly changing stuff in one version to another, cosmetical things than the users may have liked and you take it out suddently) and then those sudden negation answers goes not ok with your hard work here :good:

In fact this is over for me, thanks for all the time (I guess this is what you wanted, because you put a "more customization!" in the tittle yet reject adding a damn if/else case for fullscreen for a total up animation and a combobox for the 2 already working animations).

App Settings doesn't work, only few features do. Try setting DPI, or full screen to not immersive, or change language, or.. it is 90% broken.
[Xposed Framework Modules] :
Can you give me content of /data/data/me.rijul.knockcode/shared_prefs/me.rijul.knockcode_preferences.xml?

My phone broke recently, so I won't be able to test things out, but maybe I still can fix it up.

Cool!
[Xposed Framework Modules] reallyimjesus:
There you have it. Thanks a lot for the effort. This module is pretty awesome and I love using it! :)
[Xposed Framework Modules] yakie996:
I've just updated to the latest version and man it's an awesome update!

The new feature to skip the lockscreen is it possible to only do that when there are no notifications or no non-removable notifications?
[Xposed Framework Modules] Rakuu:
Noticed one bug with this on touchwiz, tapping a notification and trying to unlock crashes the lockscreen, my systemui is the same one I posted before.
[Xposed Framework Modules] :
Nothing strange in there. Wait for debug release, I guess.

I will have a look.

Logcat pls.
[Xposed Framework Modules] :
Good news, my OnePlus X will be in my hands tomorrow. Development will resume shortly.
[Xposed Framework Modules] Rakuu:
I feel like a fool, me of all people[emoji14]

Here you go https://gist.github.com/raku-cat/901ea911176682f863db665a3dba8dbb
[Xposed Framework Modules] :
Disable other modules and try again
[Xposed Framework Modules] Rakuu:
Sorry about that https://gist.github.com/raku-cat/bd9646f6b92f7e979bd149cf9f8f2eb6
[Xposed Framework Modules] :
Don't see anything related, apologies. The module or any part of it isn't even mentioned anywhere. Are you sure it's an issue with the module and not something else?
[Xposed Framework Modules] reallyimjesus:
No problemo sir!
[Xposed Framework Modules] Rakuu:
For the record in catlog o had it set to only show warn and above, would that have anything to do with it? I tried again and looked in the xposed logs, but I didn't see anything having too much to do with your module there either. Do you have any ideas of what could be conflicting? Where too look?
[Xposed Framework Modules] :
> Disable Xposed entirely and check maybe.

> Disable only knock code and check.

> Find which version of my app worked last?
[Xposed Framework Modules] Rakuu:
The one that worked last(back when I was debugging the squished issue) was 1.1.6 or 1.1.7 I believe, I only recently just reinstalled this so I can't say at which point it started doing this :/
[Xposed Framework Modules] everlasting207:
Hello~ this is one of the best xposed module!

Recently I have noticed that I need to input knock code when receiving call, which i dont think i should be required to. Could we make a workaround on this?

Using the latest version of knock code, v80 api23(MM), bacon(OPO), rr.
[Xposed Framework Modules] Tyaginator:
But it doesn't needed to enter code while receiving call, i think its due to dialer you're using.

Sent from a Device using an App!
[Xposed Framework Modules] everlasting207:
im using standard dialer that comes with the rr mm rom.. pretty sure its stock aosp dialer. says "com. android. dialer" :P
[Xposed Framework Modules] :
Try to find out?

CM bug, downgrade your nightly.

http://xdaforums.com/showpost.php?p=66202077&postcount=166
[Xposed Framework Modules] Rakuu:
Will do, ill get it to you later today
[Xposed Framework Modules] prestodigiti:
Hey Rijul i just figured out what was causing the fullscreen option not to work, and i feel kind of ashamed. All i needed to do was to wipe dalvik. Now it is working perfectly.

Btw, i'm using the maxlock module to lock apps with knock code and i noticed that the way maxlock handles the code is pretty interesting; when i chose the option to hide dividers i was able to tap the code in any corner of the screen and it unlocks even if it is fullscreen. It's like if the screen has multiple small dividers everywhere instead of just a big one in the middle, so no matter where you tap the screen will unlock as long as the code is correct. I don't know whether the idea is clear or not but maybe you should check out the app in order to better understand what i meant. It is very practical imo.
[Xposed Framework Modules] :
Others can confirm?

I know what you are taking about, I will have a look to see if it is worth implementing.
[Xposed Framework Modules] al_yabd:
Not work for me :rolleyes:
[Xposed Framework Modules] Ms_Julia:
The translation into Russian is necessary?
[Xposed Framework Modules] :
Yes, please. Grab strings.xml from here

https://github.com/Rijul-A/Xposed-Knock-Code/blob/master/app/src/main/res/values/strings.xml
[Xposed Framework Modules] andrehsu:
On my device, when you swipe up to dismiss the notification screen in order to get to the unlock screen, there is a noticeable lack of transition between them. Doesn't happen with the stock pattern unlock
[Xposed Framework Modules] :
It's because I am not aware of how animations work, and I don't have time to learn them.
[Xposed Framework Modules] Ms_Julia:
Perhaps there will be errors in the translation to Russian.

Send me this application already with my ready to transfer to my E-mail juliayanovskaya@yahoo.com

And if errors occur, then I will try to fix them.
[Xposed Framework Modules] sam0056:
Hi I am using one plus x trying to use knock lock module.i have done everything correctly set a pattern enabled in xposed but I get error module it's inactive thanks.
[Xposed Framework Modules] B. Bushnaq:
Hello and thank you for such a splendid job :)

The customization capabilities, the shortcut codes especially are a real piece of work :D

But I'm having a minor issue, that is, I get the lock-screen up whenever I get a call or the alarm runs, which is actually pretty "obtrusive"

I don't know if this may help but I'm using a Note 2 lte with resurrection remix cm13 :)
[Xposed Framework Modules] :
That's a bug with RR and other similar ROMs. Try disabling the module to check if a call will prompt you for a pattern.

As a workaround, you could press the power button twice to allow you to take the call.
[Xposed Framework Modules] B. Bushnaq:
I've tried that and turns out it really is a Rom related issue , anyway thank You for your fast reply and for the workaround ^^
[Xposed Framework Modules] :
I haven't had any success in being able to merge this, or read it. It shows up as question marks (????) and adding it to the project prevents compilation. Can you save it in Unicode and send it?
[Xposed Framework Modules] :
I spent some time to figure it out, and I think it works now. Please check.

EDIT : Obviously, a new version is up!
[Xposed Framework Modules] :
Added in v1.3.7.
[Xposed Framework Modules] reallyimjesus:
Full screen mode still changes to "on" automatically after the first unlock, even when the full screen mode isn't enabled. I suppose that wasn't fixed in the latest update (?)
[Xposed Framework Modules] prestodigiti:
Any news about this ?
[Xposed Framework Modules] andrehsu:
The lack of transition is still there for me :(