yashsingh1/xdaforums huggingface dataset:
[One (M9) General] evilmastr:
This doesn't work with Viper 4.0.1 MM beta if anyone is wondering. Just tried it. :)

Skickat från min HTC One M9 via Tapatalk
[One (M9) General] hamdir:
are you sure, can you please post an MM photo on stock vs mod?
[One (M9) General] evilmastr:
Nope, camera doesn't even start. Crashes immediately. Maybe someone else has better luck...
[One (M9) General] hamdir:
looks like we will have to mode the MM files again :rolleyes: [MENTION=377973]defcomg[/MENTION]
[One (M9) General] tessut:
Maybe its only my placebo but the cam got worse After the mm update...Hope its only placebo :)
[One (M9) General] evilmastr:
I think so too. Looks horrible! But I had the mod before updating, so that could be the reason. :)

HTC M9'd from Tapatalk
[One (M9) General] throcker:
some beta tester said that that camera has been improved in MM, before it was released....

I personally find it just bad, can't wait for this mod to be updated for new version! is it on schedule?
[One (M9) General] starbase64:
[MENTION=4471772]throcker[/MENTION]

i can't confirm, sorry
[One (M9) General] defcomg:
send them mm libs my way will take a crack at it
[One (M9) General] nbicho:
Tell me what do you need and where to get
[One (M9) General] defcomg:
libchromatix tk** in system/vendor
[One (M9) General] nbicho:
See if it's this what you need
[One (M9) General] defcomg:
yup its that i see htc moved things around in the lib must try bookmark new offsets tomorrow if i have free time
[One (M9) General] nbicho:
Ok, if you need something else, let me know
[One (M9) General] ivicask:
For Viper rom users, i ported A9(6.0.1) new camera with PRO mode and gallery with auto RAW enhance, if you want to try it its available on Venom HUB.
[One (M9) General] Luhccas-X10:
And for stock ROM users?

Can you share the files of that port?

Sent from my HTC One M9!
[One (M9) General] ivicask:
http://xdaforums.com/showpost.php?p=64536236&postcount=610

You got an version of it here, but dont know if it will work for you, do some backup before..
[One (M9) General] Luhccas-X10:
Don't work with odexed stock ROM :(

Sent from my HTC One M9!
[One (M9) General] ivicask:
Well, sorry, i dont have time to play with other roms, barely find time for our own.
[One (M9) General] ectn:
Does this mod work on M9 Sprint ?
[One (M9) General] LLegion:
I had Mod before update and the camera i dont remember to be so bad (before even mod) i feel we need a new mod to work onn MM if i can assist somehow ill be more than happy
[One (M9) General] defcomg:
Happy New Year here are some libs to test
[One (M9) General] LLegion:
It is nit working for me i tried to flash it with twrp it gives me error message
[One (M9) General] DeeZZ_NuuZZ:
the lib zip is not a flashable zip! lol
[One (M9) General] tessut:
Please do it by yourself... you have to place the files in system/vendor/libs and change permissions to 0644 with root explorer or something else
[One (M9) General] bumpaneer:
Are just the two new files needed? Or should I still replace all 4 library files as the previous installer did?
[One (M9) General] Luhccas-X10:
I tested.

Flash isn't working. (just light for AF)

Sent from my HTC One M9!
[One (M9) General] tessut:
As the previous installer doesn't work on MM you only can install those 2 files in system/vendor/libs

---------- Post added at 10:10 AM ---------- Previous post was at 10:07 AM ----------

This MOD doesn't do anything to flashlight on what Custom ROM are you ?
[One (M9) General] zeonism:
Can anyone tell me how to remove this? i accidentally installed it on the 6.0.1 based rom and camera FC and is not working any more.
[One (M9) General] Teo032:
Reflash the Rom
[One (M9) General] Luhccas-X10:
I'm not on a custom ROM. (stock dev'ed MM)

And after change back the files, it worked again.

Sent from my HTC One M9!
[One (M9) General] LLegion:
What improvements do we find with this to search specifically? I mean to give feedback
[One (M9) General] hamdir:
When you zoom into 100% you should see more, less smudging and higher noise
[One (M9) General] Dirgeelu:
After testing for several days, I find more grain with this cam in low light shots. I had some comparism with iphone and S6 also. I found out, M9 cam is a little less warm comparing to the standard scene. So making the default WB a little warmer would definitely give better photos. I tried preset WB options but some are too much warm and some are too muich cool. SO tweaking it a little may be 300/400+ woould do it! IS it possible? :)
[One (M9) General] ectn:
Anyone tried this mod on BadBoyz Sprint v2.3 yet ?

(base build 2.11.651.19)
[One (M9) General] starbase64:
Hi,

i have tested A9 Camera Port on my M9.

A9 Camera untouched by Maik Reifschneider, auf Flickr

A9 camera with RAW enhancement by Maik Reifschneider, auf Flickr

A9 camera PSX enhancement by Maik Reifschneider, auf Flickr

A9 camera untouched by Maik Reifschneider, auf Flickr

A9 camera with RAW enhancement by Maik Reifschneider, auf Flickr

A9 camera PSX enhancement by Maik Reifschneider, auf Flickr

regards

starbase64
[One (M9) General] ivicask:
Im not expert in photography, i just ported that A9 mod, not even using it curently. but isnt A9 RAW enhance much better than PSX? PSX kind kills colors and gives it like weird overlay, HTC RAW enhance gives more natural colors and more realistic look?

Am i right?
[One (M9) General] starbase64:
PSX is closer to reality
[One (M9) General] ivicask:
Rly?Coz PSX looks worse to me, like u applied some color filter over entire picture, kind washed out...well..its me i guess...
[One (M9) General] hamdir:
can you please provide me these tests in 1:1 in order to see how HTC is doing denoise in RAW enhance

also if i may ask, how fast does it take to apply the processing using the M9, on the A9 its kinda of slow

dropbox would do
[One (M9) General] Luhccas-X10:
Anybody tried the A9 camera port on stock dev ROM?

Sent from my HTC One M9!
[One (M9) General] bumpaneer:
I must have missed the A9 post, where can the files be found?
[One (M9) General] starbase64:
[MENTION=1144067]hamdir[/MENTION]

https://onedrive.live.com/redir?res...34&authkey=!AK9v-pk2n6re5aM&ithint=folder,jpg
[One (M9) General] hamdir:
ok i have seen the samples, all that HTC RAW enhance is doing is enhancing the contrast and sharpening the image in a more Photoshop way, but both Auto and Enhance are exact in aggressive denoise, the PSX image is able to do much cleaner denoise and hence preserve a lot more detail

in short: nothing to fuzz about :)

[MENTION=2059926]StarBase[/MENTION] your mountains and sky sample with the blue sky, has a different image for the PSX? in onedrive?
[One (M9) General] hamdir:
yes once the line is added regardless of the value: the thumbs does change to crazy colors confirming that it worked, so if we dont want N21 we should not add the line at all, i will post samples soon

on the M9 this line slightly improves the results with default HTC denoise but completely destroys the results with HTC denoise disabled
[One (M9) General] hamdir:
here are the low light samples, i will keep my recommendation at the top so we can see the best results first

pure HTC One M9 base 2.10.401.1, HTC camera app

Group A Tweaks

persist.camera.qcwnr.enabled=0

camera.eis.enable=0

persist.denoise.process.plates=0

Sharpness -1

Group B Tweaks

persist.camera.qcwnr.enabled=0

camera.eis.enable=0

persist.denoise.process.plates=0

persist.camera.snap.format=1 (damaged thumbnail)

Sharpness -1

Group C Tweaks

persist.camera.qcwnr.enabled=0

camera.eis.enable=0

persist.denoise.process.plates=0

persist.camera.snap.format=0 (thumbnail not damaged)

Sharpness -1

Group D Tweaks

Stock HTC

Sharpness -1

Group E Tweaks

Stock HTC

persist.camera.snap.format=1 (damaged thumbnail)

Sharpness -1

Group A MaxISO400

Group B MaxISO400

Group C MaxISO400

Group D MaxISO400

Group E MaxISO400

Group A MaxISO400

Group B MaxISO400

Group C MaxISO400

Group D MaxISO400

Group E MaxISO400

Group A MaxISO400

Group B MaxISO400

Group C MaxISO400

Group D MaxISO400

Group E MaxISO400

Group A MaxISO400

Group B MaxISO400

Group C MaxISO400

Group D MaxISO400

Group E MaxISO400

Group A MaxISO1600

Group B MaxISO1600

Group C MaxISO1600

Group D MaxISO1600

Group E MaxISO1600

the above comparison concludes few things:

- HTC is using extreme and low precision smudging to deal with the tiny pixel lack of precision, its the main reason behind the fuzzy results form the M9

- Switching to Android's built-in quality denoise and killing HTC's EIS will give us more detail and hence sharper images at 1:1 but the cost is color/luma noise at high ISO especially in weak light

- The M9 captures good amount of light in low light even with ISO400, Sticking to MaxISO400 is essential if we are to disable HTC smudging, ISO200 will slow down the shutter signifcantly

- The Subsmaple command (persist.camera.snap.format) is acting oddly even if we use the value 0, it exaggerates the color noise despite improving detail slightly, if we are to disable HTC smudging we shouldn't not use the YUV422N21 subsampling

essentially my recommendation is this:

DO NOT add the line persist.camera.snap.format=1 or persist.camera.snap.format=0

in the following screenshot you can see how the thumbnails color gets damaged when we use YUV422N21 subsampling (persist.camera.snap.format=1)

it happens if we use it with or without HTC denoise disabled!

what's odd is that adding the persist.camera.snap.format=0 doesn't damage the thumbnail but still causes extra color noise with my recommended settings, so i still recommend that we don't use this line completely
[One (M9) General] OGhoul:
Hamdir, the dedication you have to helping everyone with the M9 camera needs to be commended.
[One (M9) General] gelo01:
[MENTION=1144067]hamdir[/MENTION]

From your set of camera combos, i think the best one is the Group A tweaks. It has the best output and detail but the color noise on low light is really aggressive, even on the front facing camera..
[One (M9) General] troopii:
Preview can affect pic quality only with zsl turned on. Then it use the preview stream frames to capture. So it looks like htc app turns it on. Saw same behavior on stock g3app. Would be interessting how pics look with zsl off.
[One (M9) General] hamdir:
yeah well you are disabling denoise what do you expect, this tiny sensor 1.1um pixel suck bad in low light hence the smudging plaguing most phones, in case of HTC their smudging is really terrible, i think it's Qualcomm algorithm by the way not HTC's

its trade off you will have to chose if it suits you

---------- Post added at 07:31 AM ---------- Previous post was at 07:29 AM ----------

dude you want to turn ZSL off on the M9? it's already slow in low light as it is!

by the way, HDR mode (which used to merge two smudged photos) is now killer with HTC/Qualcomm denoise disabled :)

I wish we had a way to control the qcwnr amout of denoise rather than disable it

https://android.googlesource.com/platform/hardware/qcom/camera/+/jb-mr1-dev/QCameraHWI_Parm.cpp

i found this "key_denoise" and "denoise_values"

i wish we had a way to edit that from build.prop

there was this "postprocess.denoise_level" previously

.
[One (M9) General] troopii:
Yep i want to turn off zsl. Without it its a highquality capture. The question is what you want to achiev. Fast capture with noise or a slow clean image with less noise. And with zsl off its not realy slower. Around 200-300ms. You notice it as slower because already present frames get not used.
[One (M9) General] hamdir:
so i use this to turn it off?

persist.camera.zsl.prop.enable=0

edit: i tried it, nothing changed

i also found these

persist.camera.zsl_raw

persist.camera.zsl_yuv

persist.camera.zsl.interval

persist.camera.zsl.backlookcnt

persist.camera.zsl.queuedepth

also [MENTION=377973]defcomg[/MENTION] these are the internal comments i was tipped when HTC was fixing the camera for base 1.40

we really need a way to control the WNR parameter

we are still getting the best result with the RAW file without any processing to the pixels what so ever, wavelet is not as destructive as HTC's qcwnr but it's still aggravating the noise
[One (M9) General] hamdir:
here is a comparison between auto mode and our group A tweaks, i tried to stabilize my shot the best i can this time, in order to fairly compare 1:1 with RAW mode

Group A, Auto mode, MaxISO400, Sharpness -1

Group A, RAW mode, JPG preview file, MaxISO400, Sharpness 0 (you can't change the sharpness for the preview in RAW mode)

Group A, RAW mode, PNG converted to JPG untouched, MaxISO400

for some reason the JPG photo from the RAW mode is coming a lot brighter even though they are both focused on the same mode and were taken at ISO400

HTC has added an excellent sharpness algorithm after base 1.40 it extracts a lot of detail, sadly with our tweaks using sharpness 0 will also exaggerates the noise aggressively especially in lower light, this is why we have to keep shadpness around -1

looking at the pure DNG output from the M9 it's clear that M9 has a good sharpness algorithm and terrible denoise, if we have a way to fine tune the denoise values we would have the chance to match our DNG edits using PSX, but for now the difference between the JPGs coming from the M9 camera with or without the tweaks and the RAW/PSX edits is day vs night....
[One (M9) General] troopii:
in postprocessing happens alot more then only sharpening and denoising the image.

there also gets colors boosted and shadows and light adjusted. thats why the raw is brighter.

that denoise stuff is all stored in chromatix lib and can tweaked there.

i dont see a chance to make it with the build.props. it must also not mean that the build.prop flags have to work if its in a source.

i think more that zsl get activated by the htc app by default.

sharpness, saturation and zoom are postprocessing parameters. they dont get applied to raw files
[One (M9) General] hamdir:
thanks for the reply, but the JPG preview in the HTC RAW mode actually has post processing like sharpness and smudging (when not disabled) applied to it, the only way to see the M9 proper RAW is by acccessing the DNG file, RAW mode on the M9 saves two images per capture one processed JPG and another untouched RAW
[One (M9) General] hamdir:
[MENTION=5128617]troopii[/MENTION] [MENTION=377973]defcomg[/MENTION]

interesting

but one more question, now that we have a way to turn off QCWNR aka. HTC/Qualcom smudging via build.prop, do we have a way to turn off wavelet denoise in build.prop? so that we can get pure JPG output from HTC camera, right now we are forced to chose between qcwnr or wavelet
[One (M9) General] defcomg:
QCWNR is wavelet denoise its short for Qualcomm Wavelet Noise Reduction.

The Denoise Code or any other qualcomm param can be injected into HTC Camera.

also can you run getprop command look for persist.camera.tuning_spec see what value is set
[One (M9) General] hamdir:
i couldnt find it with getprop but its there in build.prop of base 2.10

persist.camera.tuning_spec=htc

persist.camera.antibanding=50

ro.qc.sdk.gestures.camera=false

ro.qc.sdk.camera.facialproc=false

these are the only camera props, are the other profiles for China and Japan using lower or higher denoise?

sadly i was wishfully looking for a way to tweak those things easily without hexedit or playing with lib files, you know easy stuff for general users to tweak

regarding my QC vs wavelet question, right now this is how it goes:

persist.camera.qcwnr.enabled=0 truns off QC HW denoise, ie: the aggressive waterpaint like smudging, but when we do that although the change is very evident we still have a lower level of denoise going on, we still don't get the pure pixel noise from the sensor

which is why i've assumed that persist.denoise.process.plates only works when we disable qcwnr ie: when we disable qualcomm's denoise (Hardware) we switch to Android's built-in denoise (software)

http://www.google.com.lb/patents/US7483685

https://www.qualcomm.com/news/onq/2013/10/25/power-vs-performance-management-cpu

https://www.qualcomm.com/media/docu...r-breakthrough-mobile-imaging-experiences.pdf

Qualcomm is pretty proud of their HW based smudge fest :)

the above image is by Qualcomm and it demonstrates exactly what's happening when we use persist.camera.qcwnr.enabled=0 on the M9

we are not turning off denoise completely, we are simply killing the s810 HW denoise as configured by HTC and hence switching to software denoise

.
[One (M9) General] defcomg:
From the Code it seems all QCWNR does is force denoise on for all camera apps its added to the init default params

http://imgur.com/oTC24Cx

in the chromatix file there are 4 different denoise configs SW420 H420 SW422 HW422 when i modified my chomatix lib i made sure i disabled SW420 when using snap format param it switches to HW422 profile its a pity snap format param kills HDR

AFAIK only samsung devices produce 422 JPEGS by default
[One (M9) General] hamdir:
i understand but 422 is clearly causing issues on the M9 and buggy, so its not working for us, it even caused stretched pixels in low light
[One (M9) General] troopii:
its caused by the jpeg converting. a solution to get plain rgb data would be to capture a yuv frame and convert it to rgb without any postprocessing.(android camera internal handel everything in yuv)

but with htc app it looks bad without heavy modding it
[One (M9) General] hamdir:
[MENTION=377973]defcomg[/MENTION]

i found your previous posts about the chromatix file

http://xdaforums.com/showpost.php?p=61652019&postcount=1649

http://xdaforums.com/showpost.php?p=61648730&postcount=1640

http://xdaforums.com/showpost.php?p=63213555&postcount=32

here is the M9 current WWE base, pure HTC 2.10.401.1, if you like to give it a go :)

i will source older chromatix files and add them here, we know HTC changed the values between 1.32 to 1.40
[One (M9) General] defcomg:
from an older base not sure what version

the changes are made from offset 00009958 to 00009AD2

old

146E00004E080000146E00008E080000146E0000D0080000146E000014090000146E00005A090000146E0000A2090000146E0000EC090000146E0000380A0000146E0000860A0000146E0000D70A0000146E00002A0B0000146E0000800B0000146E0000D80B0000146E0000330C0000146E0000910C0000146E0000F20C0000146E0000550D0000146E0000BB0D0000146E0000240E0000146E0000910E0000146E0000010F0000146E0000740F0000146E0000EB0F0000146E000065100000146E0000E3100000146E000065110000146E0000EB110000146E000075120000146E000003130000146E000095130000146E00002B140000146E0000C6140000146E000066150000146E00000A160000146E0000B3160000146E000061170000146E000015180000146E0000CE180000146E00008D190000146E0000511A0000146E00001B1B0000146E0000EB1B0000146E0000C11C0000146E00009E1D0000146E0000811E0000146E00006B1F0000146E000000000000146E

2.10

F41F00004E080000F41F00008E080000F41F0000D0080000F41F000014090000F41F00005A090000F41F0000A2090000F41F0000EC090000F41F0000380A0000F41F0000860A0000F41F0000D70A0000F41F00002A0B0000F41F0000800B0000F41F0000D80B0000F41F0000330C0000F41F0000910C0000F41F0000F20C0000F41F0000550D0000F41F0000BB0D0000F41F0000240E0000F41F0000910E0000F41F0000010F0000F41F0000740F0000F41F0000EB0F0000F41F000065100000F41F0000E3100000F41F000065110000F41F0000EB110000F41F000075120000F41F000003130000F41F000095130000F41F00002B140000F41F0000C6140000F41F000066150000F41F00000A160000F41F0000B3160000F41F000061170000F41F000015180000F41F0000CE180000F41F00008D190000F41F0000511A0000F41F00001B1B0000F41F0000EB1B0000F41F0000C11C0000F41F00009E1D0000F41F0000811E0000F41F00006B1F0000F41F000000200000F41F

may i also have this file libchromatix_t4ka7_cpp_snapshot

Edit this is just the exposure table so changes must be in cpp file
[One (M9) General] defcomg:
could you share the original raw files wanna compare enhaced to retinex on rt
[One (M9) General] starbase64:
[MENTION=377973]defcomg[/MENTION]

https://onedrive.live.com/redir?res...34&authkey=!AK9v-pk2n6re5aM&ithint=folder,jpg
[One (M9) General] defcomg:
Auto RT + Retinex strength 14 + Highlight Reconstruction

IMAG0016-1 by defcomk, on Flickr
[One (M9) General] hamdir:
if only....

:)
[One (M9) General] bobytsekov:
Hi.:)

I tried these libs, but there is no difference IMO

Before

picbg.net/u/21117/50955/826915.jpg

After

picbg.net/u/21117/50955/826916.jpg
[One (M9) General] hamdir:
i think you should try again and disable EIS first (From build.prop)
[One (M9) General] JR 2007:
Will be support base 3.35?
[One (M9) General] bobytsekov:
On MaximusHD 7.0.0

stock

picbg.net/u/21117/50955/826917.jpg

disabled EIS & new libs

picbg.net/u/21117/50955/826918.jpg
[One (M9) General] HTID1983:
will it hurt to wipe cache/delvik after flashing this?

---------- Post added at 12:26 PM ---------- Previous post was at 12:11 PM ----------

By the way, where are the settings? After flashing I have no new icon or extra settings/options anywhere...
[One (M9) General] hamdir:
guess its not working then

actually are you sure that you didnt flip your results?
[One (M9) General] bobytsekov:
haha, no, I didn't flip them :o
[One (M9) General] bobytsekov:
ОК... another test

MaximusHD 7.0.0

stock

http://picbg.net/u/21117/50955/827037.jpg

disabled EIS & new libs

http://picbg.net/u/21117/50955/827038.jpg
[One (M9) General] hamdir:
ok one more time, in daylight this time with ISO capped at 200 :)
[One (M9) General] bobytsekov:
capped ISO 200

stock

http://i.imgur.com/03ZmRYs.jpg

disabled EIS & new libs

http://i.imgur.com/fgOoTSN.jpg
[One (M9) General] throcker:
ok, read 5 pages back, almost since MM came out

my question is: is anyone running a9 camera on stock rom? or is just for viper?

where are new MM compatible libraries, and how can I flash them?

thank anyone for any reply :)
[One (M9) General] hamdir:
well its clear now that the new lib is not doing anything :) [MENTION=377973]defcomg[/MENTION]
[One (M9) General] defcomg:
Hmm okay will change something else HTC moved alotta stuff around .
[One (M9) General] LLegion:
[MENTION=1779752]m4jkee[/MENTION] will be there any update for android 6 mm? i can test whatever you want or tell me what do i need to extract from rom to submit tou you and help with your great mod, im so sad i dont have this amazing mod in mm :S have a nice weekend bro!
[One (M9) General] DeeZZ_NuuZZ:
man why you ask everywhere for an update and wether you can do something or not. why not just waiting for an update... and i think as soon as he is on MM when he isn't already he will definitely update it...so please let him take his time and don't ask everywhere for an update... just an idea, no need to take it offensive :P but it is a bit annoying to see you everywhere asking for updates and wether you can help or not...when he needs someone he will either post it as open beta or has some closed beta testers :p
[One (M9) General] LLegion:
Dodnr know that process thanks anyways
[One (M9) General] defcomg:
HERE ARE TEST LIBS

as i said HTC moved stuff around in the lib i found the NR Tables but not sure what order there are in

There is 4 Types of tables normally

Software 420

Software 422

Hardware 420

Hardware 422

then HTC Further adds Multiples of those For KDDI Device and CMCC

in the ZIP you will see ALT and ALT 2 those are the KDDI CMCC there one without alt is the main COnfig used i hope

to test

Start With

HW420 -> ALT HW420 -> ALT2 HW420 -> SW420 -> ALT SW420 ..... HW422 -> ... ALT HW420

if NR is adjusted with just the first test no need to try the others .

also not sure if M9 requires Preview LIb for NR

You can also try freedcam with Noise Reduction and ZSL disabled in case preview lib is required :fingers-crossed:
[One (M9) General] bobytsekov:
Some tests :)

ISO capped at 400

EIS enabled

Stock

http://i.imgur.com/iStVdUw.jpg

http://i.imgur.com/f3H3jCR.jpg

HW 420

http://i.imgur.com/v21BErG.jpg

http://i.imgur.com/en9KVK8.jpg

ALT HW 420

http://i.imgur.com/CxIoXCG.jpg

http://i.imgur.com/ZmqDoeX.jpg

ALT2 HW 420

http://i.imgur.com/aDvl0MI.jpg

http://i.imgur.com/h9skzj7.jpg

SW 420

http://i.imgur.com/zz9PPis.jpg

http://i.imgur.com/95d10FW.jpg

ALT SW 420

http://i.imgur.com/sJFlc13.jpg

http://i.imgur.com/917b2Dz.jpg

HW 422

http://i.imgur.com/jQAciqZ.jpg

http://i.imgur.com/EWIQiej.jpg
[One (M9) General] defcomg:
Seems ALT HW420 is the Right One

Skip to post #405