yashsingh1/xdaforums huggingface dataset:
[Sony Xperia ZL] imcrazyz:
Google claimed that they have the fix on Android M, isn't it?

Source: https://code.google.com/p/android-developer-preview/issues/detail?id=2556#c104

and yea cyanogenmod should just merge it and let the people try it out...

Anyways, thanks a lot for the findings. You are better than Google's devs.
[Sony Xperia ZL] ichbinich:
Big up and thank you very much for your work dude! @ Stock 5.0.2 on bq Aquaris M5
[Sony Xperia ZL] pcarenza:
I expect as much from Cyanogenmod... they're not real quick on stuff unless they can profit from it. AOSP not paying attention might be because you haven't assigned any reviewers, perhaps?

Anyways, it's about to be merged into XenonHD ROM, and should be in our next Saturday weekly build here: https://mirrors.c0urier.net/?dir=android/teamhorizon/weeklies ... be on the lookout.
[Sony Xperia ZL] tiny4579:
Not everyone from CyanogenMod works for cyanogen inc. They are not all for profit. Please don't loop all contributors to that project as being for profit.
[Sony Xperia ZL] pcarenza:
Jose does have a point though when he mentions Steve Kondik, because I don't know how many times one of his "+2 and through" posts have broken something or other. Additionally, all this trying to be different from Google is having a trickle down effect on CM, between the API nonsense, Live Display, and several dozen other things that were just fine to begin with.
[Sony Xperia ZL] EvanA:
There is no official comment from CM on that patch regarding its fate. I can guess they will not be merging it though.

M preview code on android.googlesource.com does not include any platform commits from Google's development. It is only pushed to comply with the GPL requirements since some android components are licensed under the GPL.
[Sony Xperia ZL] opssemnik:
fixed only in final version, as addresed by google on the bug tracker

EDIT: installed via xposed, monitoring to see wether the counter will remain, also monitoring battery life to see if its just visual as the devs are stating on cm´s gerrit, or if it really makes battery life better

Also: keep looking on chroma rom, the dev merged your patch and its on undergoing test, maybe his results can also help

http://xdaforums.com/nexus-6/development/rom-chroma-01-11-2015-t3000003/post62582622#post62582622
[Sony Xperia ZL] r3pwn:
The "issue is still there" in the M preview "source" because that isn't the full source code release for Android Marshmallow (which has not yet been released). They only released the kernel sources, which were required by law. Yes, I know, there is an "m-preview" branch for pretty much every repo, but if you look, they are literally the exact same as lollipop. If you check, it even has the same build number (starts with L instead of M). To reiterate, the only thing that the m-preview branch is useful for is the kernel sources (which, again, were required by law for Google to distribute), as the rest of the source has not been pushed.
[Sony Xperia ZL] orange808:
Given the amount of foolish, silly, and (even) **gasp** stupid commits I've seen hit the nightlies; the code review is making me smile.

I'm not even sure we are debugging anymore. It looks like a flame war in a newsgroup.
[Sony Xperia ZL] Bazoocaze:
Thank you, I don't know that.

Wish google solves this in Marshmallow (they will, because the PhoneStateListenner is definitively not working).
[Sony Xperia ZL] infatality:
Seems like cynogenmod isn't interested to commit into their repo. [emoji22]
[Sony Xperia ZL] Bazoocaze:
5940 downloads of the Xposed Module. ;)
[Sony Xperia ZL] imcrazyz:
You did great work there. I'm still waiting for CM team to merge the patch though they seem to be scared of idk what. Just some codes and it won't brick the phone... lol

Anyways, the mra bug seemed to be fixed, BUT the drain is still there from nowhere. :( Just that the drain is minimised a little bit.
[Sony Xperia ZL] Bazoocaze:
Thank you.

It's easier to hunt a drain when the stats are correct.
[Sony Xperia ZL] zephiK:
I haven't been doing much tests as I've been home pretty much all day. I only merged it as my own personal use, whether or not I'll include it in the next release is still yet to be determined.
[Sony Xperia ZL] xddawg:
i cannot flash this zip. i use twrp. can anyone lead me in the right direction. i am using sultan's stable rom
[Sony Xperia ZL] Eeelgen:
It better not flash because it's a build for Xperia ZL. Use Tinys test build, you can find it in the nightlies thread in OPO>General

Skickat från min A0001 via Tapatalk
[Sony Xperia ZL] ajitkatte:
Yes Google has fixed this in marshmallow , confirmed by a Google engineer.

https://code.google.com/p/android-developer-preview/issues/detail?id=2556
[Sony Xperia ZL] orange808:
The Cyanogen Code Review page has become a complete mockery and flame war. In the course of the argument over <snark> "the bestest and smarty-est ever ever" </snark>, everyone involved embarrassed themselves.

The page looks like a chatroom of warez scriptz kiddiez..

Get yourselves together. Everyone is watching.
[Sony Xperia ZL] StewieTech:
Yeah i noticed that. Here the poll says it works, there not so much. I´m testing it on AOSP rom now.
[Sony Xperia ZL] optimumpro:
Here is Sony Xperia Z1 input: I did not use the xposed module, but rather made changes directly in sources and recompiled the rom. This positively does not affect battery drain in any way. This just masks the drain, which is now reported under miscellaneous, which is the difference between actual drain and estimated. It is a classical placebo: when your phone is sleeping, you will have 100% battery for 2-3 hours, but once you start using it, the procentage would drop like a rock in minutes to compensate for phoney reporting in the first hours.. Then look at your battery stats and you will see 30-40% drain under miscellanesous. . It is no fix at all, it "fixes" battery stats reporting...
[Sony Xperia ZL] Bazoocaze:
There is no "miscellaneous" item on my device on BatteryStats.

I am sorry for you, but "miscellaneous" indicates a bug in your RIL module which this patch not solve.
[Sony Xperia ZL] bdasmith:
Been using this patch 2 days.....no miscellaneous or fast drops

Nexus 4
[Sony Xperia ZL] optimumpro:
You don't have miscellaneous because this feature is optional and has to be enabled in settings, so that the phone starts calculating the difference between actual and estimated drain. If you enable it, you'll have it. :)

Your feature does not do anything to actual draining, it just fools the estimate and the user too.

I don't like cyanogen people: they are rude, arrogant and treated you badly, but in this case they are absolutely right on point: the fix fixes nothing...

Edit: You say in your OP that "This fix the "high cell standby mobile radio active time" bug."

It does not fix the bug, it alters the reporting of it, sort of like when someone has 40 degree temperature, you fix the thermometer to show 36.9...
[Sony Xperia ZL] Bazoocaze:
Don't know where did you get this, because the "mischellaneous" feature is already in the code:

File: BatteryStatsHelper.java

processMiscUsage();

if (DEBUG) {
Log.d(TAG, "Accuracy: total computed=" + makemAh(mComputedPower) + ", min discharge="
+ makemAh(mMinDrainedPower) + ", max discharge=" + makemAh(mMaxDrainedPower));
}
mTotalPower = mComputedPower;
if (mStats.getLowDischargeAmountSinceCharge() > 1) {
if (mMinDrainedPower > mComputedPower) {
double amount = mMinDrainedPower - mComputedPower;
mTotalPower = mMinDrainedPower;
[COLOR="Red"]addEntryNoTotal(BatterySipper.DrainType.UNACCOUNTED, 0, amount);[/COLOR]
} else if (mMaxDrainedPower < mComputedPower) {
double amount = mComputedPower - mMaxDrainedPower;
[COLOR="Red"]addEntryNoTotal(BatterySipper.DrainType.OVERCOUNTED, 0, amount);[/COLOR]
}
}

Collections.sort(mUsageList);

This is not a patch for the drain. Please read the topic.

[/QUOTE]

No, it's working as expected, because the battery stats is notified when the radio is connected and disconnected. There is no timer or something simulating the notifications. If you wish, please I invite you to put some logs on the notifications (file NetworkManagementService.java), and then you will see the notifications showing correctly when the mobile data link switchs from connected to unconnected and vice-versa.
[Sony Xperia ZL] optimumpro:
It is in the code, but you have to enable it in developer settings: Showunaccounted/overcounted stats/show in battery statistics unaccounted and overcounted usage. If you didn't enable it, you won't see it.

You are misleading people. You say this:

"I'm working on a fix to the infamous Cell standby / Mobile radio active time issue.

Android issue 165558

- Mobile radio active battery drain in all internet apps

- https://code.google.com/p/android/is...tail?id=165558

Android issue 2556

- When mobile radio is active, battery drain in all internet apps

- https://code.google.com/p/android-de...detail?id=2556"

The issue you referenced above are about actual battery drain, but your patch does not affect any battery drain, it just changes the way radio is reported to battery stats.

Then you go on to say that you compiled a rom with the patch and on your device the issue is fixed. You seem like a person who knows a bit about coding. You can't really believe that this patch could affect the battery drain mentioned in Android Issues above..

You have to tell people more prominently that this patch in not about actual battery drain, but rather about changing the way it is shown in battery stats. . I bet 90% of your downloads are from confused users who think this fixes cell radio battery drain.
[Sony Xperia ZL] Bazoocaze:
Please read #8 and #10
[Sony Xperia ZL] sh4d1t0:
So nobody knows what is this patch..

I'm confusing about this patch
[Sony Xperia ZL] venky716:
This is a real 'Fix' !

Like OP says it does nothing related to drain, it fixes the incorrect reporting of battery stats.

Mobile radio will drain way more battery than when on WiFi , its common knowledge.

Everyone started panicking after seeing the battery stats, if it was fixed from the beginning I doubt there would've been such panic .

Don't know why everyone is giving him such a hard time, for once someone tried to fix the issue and came out with something substantial.

Thanks for the fix.
[Sony Xperia ZL] optimumpro:
He is given hard time, because he misleads people into beleiving he fixed android infamous issue 16558 with high battery drain when apps continue to use data even if radio is off. His fix does not address actual draining and he knows it. Yet he posts here that he fixed that bug, he goes to CM gerrit and does the same, and he even posts the same on google code in that 16558 issue thread, again knowing well his patch does nothing to fix battery draining. That's deceptive at the least and he is surprised he is given a hard time?
[Sony Xperia ZL] pcarenza:
Nothing deserves that kind of immature snark.
[Sony Xperia ZL] imcrazyz:
Just to clear something out, this fix does make us see the mobile radio active time decreased. Yes, it does work. Yet it still doesn't fix the DRAIN. I don't know what Google has done with those codes, it just simply drains the battery life for no apparent reason. I started to doubt how well will be the battery life in android M.. Google said they had the fix already.. well....
[Sony Xperia ZL] StewieTech:
After testing with AOSP rom my conclusion is that it improves the battery stats but it doesn´t fix the drain. It does improve the battery a little though.

I wonder, why do so "few" suffer with this bug? I mean a person can have the same phone, rom and settings as me and not suffer from it. Surely there has to be something to do other than coding right? I can´t get rid of the bug though, tried just about everthing.
[Sony Xperia ZL] Bazoocaze:
There is absolutely no hard time. ;)

I just laught on the face of people that think they are smart but don't know how the inner core of Android works nor how to debug the inner core. :cool:

I do not have the drain on my device (read post #8 and #10), I have only the active time issue, that is now gone on my device thanks to my researching. Unfortunatelly the active time issue is present on ALL androids LP, because it's on the inner core of Android. Regarding the drain, can't debug and fix an issue not present on my device.

For you that think you are smart, why did you not fixed the LP drain for us (but not for me, because my LP device is now working fine)? After several months there is nothing about that. Oh, I know, you want badly to contribute to xml translations.

Anyway, this is the nice part on Android: people can contribute where they want, other people test and if it works people will use it. If it not works or people do not want then they will not use it. And if people fells unconfortable people will blame the voluntary contributions.

Take a lesson on how to help people knowing more about what I am used to contribute fo fix droids: http://xdaforums.com/showthread.php?t=1312398

PS: 10,340 downloads of the Xposed module. :p
[Sony Xperia ZL] StewieTech:
Bazoocaze, is that last message of yours directed at me?
[Sony Xperia ZL] Bazoocaze:
Ok, so please, guide me: how do you think I must annouce this fix on the thread post?
[Sony Xperia ZL] Bazoocaze:
Of course it is not!!!!!! Please! It's for harsh people sending me messages.
[Sony Xperia ZL] vivekchamoli:
Right ..i gone through the CM post and seen the worst ever response from the so called developers n evaluators ...towards their contributor. Instead of accepting it they seems to hv taken up with their egoes n said no ..i m using patch via expose over OPO ..n its under observation.. Will update...keep doing your best ..XDA and its users are backing you ..what if they don't include .. Ppl here will surely cherry pick your commits in their respective ROMs ..have a great week ahead.
[Sony Xperia ZL] optimumpro:
For starters, stop saying that you fixed Android issue 16558. That's a clear falsity. Second, before demanding that others take example from your "excellent" work, examine profiles of people to whom you address this nonsense. Third, grow up. And finally, this discussion is going nowhere, so, I am stopping first.

Best regards...
[Sony Xperia ZL] bdasmith:
With the xposed patch enabled I am definitely getting a cleaner battery usage. Thank you OP.

Edited : tested two full days and half a day....
[Sony Xperia ZL] Hemant:
Good work. Thanks
[Sony Xperia ZL] Bazoocaze:
To protect this thread from more trolls, I removed the reference for that two issues. ;)

I still think they can be related at some degree - some people may have the mobile radio active time bug and then are thinking it can be a drain.

In my case, I thought I have a drain, but after some research and debugging it was only the mobile radio active time bug (see post #8 and #10). Please test to see if that is your case.
[Sony Xperia ZL] j3bus2k3:
I've also had great luck with this as an exposed module. Are there any suggestions for a workaround for music apps? I understand on a charger I can just set the phone to never sleep but off a charger, in my pocket, at the gym with no wifi...any idea? Thanks in advance gents.
[Sony Xperia ZL] rajib4:
[MENTION=4215483]Bazoocaze[/MENTION] Excellent work bro :good:

I use AICP ROM for my device (Xiaomi Mi3) and used to get around 5hrs of SOT (100% - 5%). The AICP team on their latest nightly included your fix and now with 50% battery left I already hit 4hrs of SOT. My usage style remains same... So it has to be your fix which has done the trick :)

I have seen a lot fire fighting after you published the fix. Technically I don't know how good your code is but as a user I can say that it is working very very well.

A big thanks to you :good:
[Sony Xperia ZL] :
If I understand this right, this will not increase my battery life, but just give me cleaner stats, right?

Using a Samsung Galaxy S6.
[Sony Xperia ZL] acwest:
I think this patch is more important than it is getting credit for. The Mobile Radio Active that is being displayed in the battery stats is wildly wrong, due to the issue that this patch addresses, and until that is fixed, we have NO idea what is actually causing the battery drain. It likely has nothing at all to do with the mobile radio.

It has also occurred to me that depending on what else in the system is paying attention to the radio power notifications, this could actually have some effect...
[Sony Xperia ZL] bdasmith:
[MENTION=4215483]Bazoocaze[/MENTION] thanks so much for your efforts in going through all that code. I'm enjoying using this patch through the xposed module put together by [MENTION=5064841]pyler[/MENTION].

Edit: also agree with post before mine...
[Sony Xperia ZL] acwest:
good news, bad news

I have been running this for a while as an Xposed module, and it seems to be helping battery life, so the theory that there are listeners that were behaving badly due to missed notifications is looking better.

On the other hand I do have one app which still has an inordinately high mobile active time (CPU total 9m 20s, CPU foreground 4m36s, Keep Awake 0s, GPS 7m22s, Mobile Radio Active 56m 20s)

It is possible it is an app error (not sure an app should be able to behave badly in that way) or possibly there is a callback somewhere that hasn't been fixed yet.

-Craig
[Sony Xperia ZL] sipe1:
Xperia Z C6602 running 10.7.A.0.222 5.1.1. Can confirm this patch is working, running it all day got only 8 minutes of mobile radio active.

Thank you, will keep an eye on battery drain!
[Sony Xperia ZL] mariano55:
How did you install it?, xposed?, you have stock room?

Thanks
[Sony Xperia ZL] sipe1:
Yes, over xposed on stock rom.

Unlocked bootloader, installed recovery from here

http://xdaforums.com/showpost.php?p=62722996&postcount=14

Rooted, installed xposed and patch.
[Sony Xperia ZL] Inati:
It worked fine, thanks!
[Sony Xperia ZL] brunodu91:
Hi

How to know if my bootloader is unlocked ?

Im on i9505

Jfltexx bootloader XXHOH2 on ojdc cm12.1 optimized rom

Thx in advance
[Sony Xperia ZL] sturmtruppler:
Has this code been merged into official CM nightly yet? I'm not that familiar with github, sorry... :D
[Sony Xperia ZL] lurenja:
I installed the xposed module on my motox xt1053 with nxrom and it seems that the issue still exists. Should I turn back to the official rom ?
[Sony Xperia ZL] wea3el:
[MENTION=4215483]Bazoocaze[/MENTION]

Is your solution implemented in CyanogenOs 12.1? I've updated my Oneplus to latest COS version and it seems that on wifi I'm not getting crazy MRA values.

Still on mobile data MRA and apps active time are way off. :(

Should I notice improvement in MRA time while on mobile network if I flash this zip?

Thanks for fighting with this huge bugg!

?
[Sony Xperia ZL] Laczyi:
Worked for me, thank you.
[Sony Xperia ZL] AndreIrawan97:
Can i flash this to my OnePlus One?
[Sony Xperia ZL] sturmtruppler:
If you want to turn your phone into a paperweight flash the rom provided in this thread.... :D

Otherwise I woul propose to use the xposed module or take a look into OnePlus One forum. Maybe there's a rom for you!
[Sony Xperia ZL] cingolat:
Seems to work on my Z1 C6903 running 5.1.1 stock rom.......thanks
[Sony Xperia ZL] AndreIrawan97:
Well, i don't know if that flashable zip was a rom , lol...

But i don't see any difference when i'm using xposed
[Sony Xperia ZL] e371:
Seems like it's not work for cm12.1

I tried the Xposed module and it's not work.

I request our developers to include this patch in cm12.1rom for my phone, they do it, but after upgrade the bug is allready here... and i'v see many same reports here. :(
[Sony Xperia ZL] Purerawenergy:
Yes you can "If" you have a cm12.1 ROM AND you have the correct Xposed installed on your device.

It doesn't help with the battery drain itself, however, it is supposed to help correct the way your device actually "reports" battery usage, specifically for mobile data.

Tom 2.0
[Sony Xperia ZL] mh7:
I have m9+

i use Xposed Fix but not worked

is there other wayto solve this issue

Thanks
[Sony Xperia ZL] lallolu:
This patch improved my battery life from what I can see. I use the exposed module.
[Sony Xperia ZL] ppaasseeii:
Works as an Xposed module on Moto G 2015 5.1, thanks!
[Sony Xperia ZL] zack.1988:
Who is not affected from the battery drain (caused from mobile radio active bug), is who live in a place with a great cellular network signal. Just try to use your phone with mobile data ON for some hours in a place with bad (and often absent) signal and let me know if it does suck your battery as hell or not...

my two cents
[Sony Xperia ZL] bipinbedi:
I am experiencing drain and lots of flat network even after using this module, m having hlte aka note 3 international model and using temasek cm12.1 latest version.
[Sony Xperia ZL] IaKnightHawke:
Use caution when applying any 'fix'. Decide if the problem exists in your own case. Be sure to have a backup of your phone in case. I tried the Xposed mod and borked my data. Thankfully, I had a working backup to restore. Just be aware and be careful.
[Sony Xperia ZL] addictarmy:
Thanks!

I recently upgraded my moto x 2013 to lollipop and was so happy with the performance only to be shocked with the cell standby battery usage.

This xposed module addressed that specific issue for me. I love this community!
[Sony Xperia ZL] Derpling:
Note 5 5.1.1, mobile bug is still active even after applying the xposed module.
[Sony Xperia ZL] blatesk:
If you have a tablet that you don't use as a phone, but still get the ridiculous battery drain from cell standby. I tried the following

Switching on Airplane mode is not an option for me to kill my cell standby/cellular radio standby 40% battery drain. My kid uses madden mobile (and other apps) and they will not run with airplane mode on. (Eventhough wifi is on and connected (and internet is working fine with the browser and other apps).

I need to switch off the cell standby (radio) that is using up 40% of a 10,000mah battery on this android tablet.

I found that going into your file explorer and changing all "tele***.apk" files to .bak instead will kill these dialers for searching for signals all day. Battery doctor can help some too. We use 4.4.2 KitKat. possibly download from play store 'toggle cell' and 'data on off'.

If you can find any other .apk files on your device like phone.apk or telephony.apk, these need to be disabled or changed to .bak
[Sony Xperia ZL] SirMika:
So does this works or should I just skipped this? Phone is OPT w/cm12 /AK
[Sony Xperia ZL] khangozzy:
Anyone know how to apply this patch if running other ROM based on CM (crDroid)? I dont want to flash the Xposed framework.
[Sony Xperia ZL] trond_1970:
Hi.

I tried to install this fix on com.pyler.mobileradioactivefix_v11_19c319 .apk on a Galaxy S 5 due to battery drain using the K9 email client.

K9 run flawlessy on Kittykatm, but reduced battery significantly on Lollipop.

Unfortunately this fix did not work for me, still more or less the same. Additional tips for this configuration ? (K9 client: Total connection time 5h. 13 min after running 21 hours after install/reboot, recharged once after this):
[Sony Xperia ZL] zadeora420:
hi

I have applied this fix on Moto x xt1058 on 5.1 with locked bootloader and rooted by this method

http://xdaforums.com/moto-x/general/root-moto-x-att-xt1058-5-1-lpa23-12-21-1-t3164125.

it didnot brick my device. i will report after a couple of days if the fix works or otherwise.
[Sony Xperia ZL] Rohandd:
I tried enabling this on moto G 2014 running marshmallow through xposed but the phone does not boot up ( bootloop)after that, I have tried using it on a custom rom too but with same effect..
[Sony Xperia ZL] glauberlima:
Take a look here. Hope it helps:

http://xdaforums.com/showpost.php?p=65068405&postcount=183

:)
[Sony Xperia ZL] Rohandd:
Thanks a lot! :)
[Sony Xperia ZL] oliverweidel:
Wow, found this by accident - this works like a charm!

Installed via xposed on HTC One (M7) on official CM 12.1 Nightly.

Now the battery stats are not complete (some apps are not shown etc.) but it doesn't matter - I have now over 24 hours power with WLAN and LTE, instead of max 16 h.

Thanks a lot for your work!