yashsingh1/xdaforums huggingface dataset:
[Galaxy Tab 4 Android Development] hennymcc:
Hi sub77,

thanks for the pull-requests.

Seems as if most of the patch is to change the behavior of the menu-button back to the app-switch behavior. I deliberately changed the action for the menu-button back to the "menu" action instead of the "app-switch" action because this is more standard and I was always annoyed by the special Samsung settings.

What is the general preference for this button in this forum? Do you want it to be "app-switch" (= Samsung style) or "menu" (= default Android style)?

Nevertheless the button behavior (no matter if it defaults to app-switch or menu) can be changed via the settings app, so the default setting is not really that important.

More important than the behavior of the left button is the correct filename. The input device is called sec_touchkey for the S5 mini, hence sec_touchkey.kl is used there for the input configuration. The T235 does not have such a device, so the file sec_touchkey.kl is ignored. Instead it should be handled by gpio-keys.kl.

You added the settings to sec_touchscreen.kl which might also work, because the device sec_touchscreen exists on the T235 and hence this file is loaded. But I rather would add it to gpio-keys.

Have you already tried if your patch with sec_touchscreen.kl works?

Could you please delete sec_touchscreen.kl and rename the old sec_touchkey.kl (with menu-key setting, as it might not work with the app-change setting with the current ROM) to gpio-keys.kl and check if that works?
[Galaxy Tab 4 Android Development] sub77:
i want them disabled using the navbar. but general preference was app-switch, i remember that the custom configuration did not work if the hardwarekeyvalue in the overlay setting says the key is menu not appswitch. but iam not sure.

but it seems you know what your are doing, i dont, so there may come some questions.

sec_touchscreen.kl deleted touchkey.kl, gpio-keys.kl

key 158 BACK

key 254 APP_SWITCH

= still works fine and can be customized.

touchkey.kl renamed to gpio-keys.kl

key 158 BACK

key 254 MENU

= left button is dead
[Galaxy Tab 4 Android Development] hennymcc:
OK, fine. Thanks for testing.

Strange that it works with "key 254 MENU" on the S5 mini, although it was configured as APP_SWITCH in the stock ROM, too. Maybe it would work if it is used in the sec_touchscreen.kl file.

Whatever, I do not really care that much about the default config of the left button as long as there is a solution that makes it work. So I think I will merge your pull-requests.

Just one question: what do you mean with "still" in "= still works fine and can be customized"? I thought you did not test the sec_touchscreen.kl keylayout with CM12 when you first posted the pull-requests and at least the left key did not work with an unmodified CM12 before.
[Galaxy Tab 4 Android Development] sub77:
it works on the s5 because the overlay config was right:

<!-- Hardware keys present on the device, stored as a bit field.

1 - Home

2 - Back

4 - Menu

16 - App switch

64 - Volume rocker

<integer name="config_deviceHardwareKeys">71</integer>

the tab 4 need config_deviceHardwareKeys=83, if it is set you can configure any function to key 254 with the sec_touchscreen.kl

another question, i dont get the matisse3g working (it does not find the sim card) while the matisselte works fine with data and phone. some idea?

last bothering: it lasts some years to get the cam working with front and back videorecording, while the cam just works frontside. i cant figure out if it is a missing blob, misconfigured wrapper or just a missing camera parameter.
[Galaxy Tab 4 Android Development] hennymcc:
How did you change this setting? Did you build your own ROM?
[Galaxy Tab 4 Android Development] hennymcc:
I also had this problem with the S5 mini at the beginning. The modem daemon (cbd) needs a working mobicore framework to access the SIM-card, but mcDriverDaemon did not work correctly because of mmap incompatibilies. The following change fixed it:

https://github.com/tobigun/android_...mmit/db9500d369191be7eb7ef4165d94bc9cab41f69e

I haven't found the "BOARD_USES_LEGACY_MMAP" flag in your matisse3g BoardConfig, so you may give it a try.

It could also be something different, but without a full ADB log ("adb logcat -b all" or at least "-b radio") I can only speculate.

Same as above. Without an ADB log, I cannot tell you anything.
[Galaxy Tab 4 Android Development] sub77:
thanks, but cbd seems to be some exynos thing.
[Galaxy Tab 4 Android Development] HackFeed:
Hi, hennymc! Thank you so much for source-codes for Exynos3470! Can I use it to build CM11 fo this tablet?
[Galaxy Tab 4 Android Development] rheckr:
[MENTION=6225744]hennymcc[/MENTION]

Will be there any update for this rom with latest bugfixes?
[Galaxy Tab 4 Android Development] hennymcc:
Most of it might work with CM11 but you might have to slightly modify some files I guess.
[Galaxy Tab 4 Android Development] hennymcc:
I will wait until I get some feedback on the camera problem.
[Galaxy Tab 4 Android Development] rheckr:
[MENTION=6225744]hennymcc[/MENTION]

How can we help you?
[Galaxy Tab 4 Android Development] hennymcc:
This is the current status (Camera):

At least for corneo, the camera app is missing. He uses a 3rd party app but that is not able to connect to the camera.

The ADB-log contains the following lines:

V/CAM_PhotoModule( 6809): Open camera device.
V/CameraHolder( 6809): open camera 0
E/CameraService( 1865): Camera HAL module not loaded
W/CameraBase( 6809): An error occurred while connecting to camera: 0
E/CameraHolder( 6809): fail to connect Camera:-1, aborting.
E/CAM_PhotoModule( 6809): Failed to open camera:0

It seems that the camera-service and hence the camera HAL is not started. The S5 Mini log contains the following line which is missing in corneo's log:

I/CameraService( 1938): CameraService started (pid=1938)
I/CameraService( 1938): Loaded "Exynos Camera HAL1" camera module

It is unclear so far, why the service is not started. At bootup (or at least the start of the camera app) the system should load the library:

/system/lib/hw/camera.universal3470.so

If the system was not able to load the library there should be some error message ("missing reference to ...", or similar) but there is none. So either the file is missing or no further error message is logged.

Maybe someone can check if this file is present on the device.

It is difficult to remotely debug this issue as I don't own a T235. Especially when the ADB-log does not contain usable debug information. Would be better if someone with a T235 would debug this issue.

Edit:

On stock ROM the file is located in

/vendor/lib/hw/camera.universal3470.so

but it should not matter if is located in the system or vendor directory. So you can try to move the lib to the vendor dir. Just to be sure.
[Galaxy Tab 4 Android Development] sub77:
dont you need at least a camera wrapper, better the camera hal?

maybe these can be modified?

https://github.com/CyanogenMod/andr...ommi/b31c446ecd85a506af75d9ca609d99f03796e081

https://github.com/LegacyExynos/and...mmit/aa6ae38ebd1a861949182c6d62bca4bdf63fcc81
[Galaxy Tab 4 Android Development] hennymcc:
Yes, it requires a camera HAL, but camera.universal3470.so is the camera HAL - at least the prebuilt one from the stock T235 KitKat ROM.

On the S5 Mini the stock KitKat camera HAL works good (although using the camera app multiple times might cause crashes from time to time) - so it is a good starting point.

It would be indeed nice to build the camera HAL from scratch instead of using a prebuilt one, as in the worst case the stock one might not be compatible with Lollipop.

The first link you posted contains the camera HAL for Exynos4412. I remember that I tried some Exynos4 and Exynos5 based camera HALs some months ago. None of them worked out of the box and after some modification started up but were still a bit unstable.

The Exynos4412 HAL might work but probably needs some trial & error. So someone should build the library who can directly try the resulting libraries on his device. Do you have a build-environment set-up?

The second link is a camera wrapper. For the beginning this might be the way to go. It still uses the stock HAL but increases the amount and granularity of the debug output. The linked one is for CM11 and will probably not work with CM12.1 without modifications. But I think there will be enough wrappers for CM12(.1) out there.
[Galaxy Tab 4 Android Development] sub77:
i had overseen it in the propietary list.

yes i do, but i dont have the device to test.
[Galaxy Tab 4 Android Development] hennymcc:
If you do not have the device, how did you test the left touchkey issue?
[Galaxy Tab 4 Android Development] sub77:
Tested on matissewifi, it use sec_touchscreen.kl too and got the same keys.
[Galaxy Tab 4 Android Development] SM-T231:
Can u make cyanogenmod for SM-T231 please?

This device doesn't have any custom ROM...please update for sm-t231 users
[Galaxy Tab 4 Android Development] sub77:
nomen est omen
[Galaxy Tab 4 Android Development] hennymcc:
An updated ROM is available (see opening post for download links). Like before it is totally untested.

Changelog:

Update to newest CyanogenMod sources (LMY48G)

Left touchkey working now (configured as App-Switch button)

Camera Preview working (saving a picture might still crash)
[Galaxy Tab 4 Android Development] hennymcc:
Although T235 and T230(NU)/T231 (T230:WiFi / T231:3G) share the "Galaxy Tab 4 7.0" name they are not related in terms of hardware due to the different SoCs used (Samsung Exynos3470 vs. Marvell PXA1088).

So the ROM for the T235 cannot be updated to support the T231 (or T230) and almost nothing of the work done to port CM-12.1 to the T235 can be reused for the T231/T230.
[Galaxy Tab 4 Android Development] rheckr:
[MENTION=6225744]hennymcc[/MENTION]

So, i have tested this rom and that's what i've found for now:

- Hardware sensors (Light, Proximity) - this tablet doesn't have light sensor so you should delete it from the not working things (not sure about proximity)

- Camera works, saving images and videos too.

- USB-OTG (mouse works, keyboard works)

- Last apps button works

- While rotating the screen looks laggy

- Making screenshot with Power + Home instatly enables power off menu, making screenshot from power off menu works

Is there any way to enable multi window?
[Galaxy Tab 4 Android Development] corneo:
Taking pictures are working? What you're doing to fix it? Is it possible to take a picture and post it here? I can't believe it... And the rotation is working fine for me.

Gesendet von meinem One M8
[Galaxy Tab 4 Android Development] rheckr:
[MENTION=387656]corneo[/MENTION]

Sure

Grab it. I've just installed the new .zip from OP and everything is working now ;)

I can't upload there .jpg photo so there is a link - http://i.imgur.com/aGjsAJD.jpg
[Galaxy Tab 4 Android Development] corneo:
now it works! my gapps from slim doesn't work properly. without gapps taking pictures is no problem. it's better to use the recommended gapps from first post! really great work hennymcc!
[Galaxy Tab 4 Android Development] hennymcc:
Can somebody please test which sensors are integrated into the device? There is a nice app called "Sensor Box for Android".

Would be nice if one user could test the sensors with the stock ROM and one with CM-12.1. Then copy the table from below and enter the results for every sensor (one of: available/working/not-available/non-working)

Accelerometer:

Light:

Orientation:

Proximity:

Temperature:

Gyroscope:

Magnetic:

Pressure:
[Galaxy Tab 4 Android Development] hennymcc:
It seems that SELinux is the last feature feature missing so far.

Anybody who is interested to work on this?

[MENTION=3132221]sub77[/MENTION]: maybe you with some user who owns the device?
[Galaxy Tab 4 Android Development] rheckr:
[MENTION=6225744]hennymcc[/MENTION]

CM 12.1

Accelerometer: Working

Light: Not-available

Orientation: Not-available

Proximity: Not-available

Temperature: Not-available

Gyroscope: Not-available

Magnetic: Not-available

Pressure: Not-available

IMPORTANT

Connecting turned off device into usb charger (not into PC) shows just the grey battery with circle loading (not moving), when i've unplugged the usb cable the device has started into recovery.
[Galaxy Tab 4 Android Development] hennymcc:
That is possible. Newer kernel sources for the S5 mini had a patch for bad chargers. The T235 sources are rather old and might miss this patch.
[Galaxy Tab 4 Android Development] rheckr:
I've used the original charger for SM-T235. I will check the charging right now.

So the only way is to charge it when it is turned on, right?
[Galaxy Tab 4 Android Development] hennymcc:
When what is turned on - the smartphone? It should also work, if you shutdown the phone.

As I do not have this device I don't know if this really works.
[Galaxy Tab 4 Android Development] rheckr:
The tablet. What i've seen for now:

Device disabled - not sure about charging, it is freezing with grey battery and then booting into recovery

Device enabled - charging

Device enabled, USB PC - doesn't charging

btw. how are you able to make a rom without this device?
[Galaxy Tab 4 Android Development] hennymcc:
Now I understand what you meant with your first post. The grey battery is shown when the smartphone is charged while it is "turned off". I thought you meant that the battery symbol in the Android UI status bar turned grey.

It is possible that it is charging but some animation file is missing.

I have an S5 mini. Both devices are 80% similar as both are based on the Exynos3470 SoC. So providing a ROM with basic support is not a problem but debugging the last 20% is.
[Galaxy Tab 4 Android Development] rheckr:
Exactly that i meant. But what about botting into recovery when device is charging when turned off. I've checked this twice and every time it boots into recovery.

Novice users could be scared when it boot because recovery has "screen timeout" as default. When screen goes black in recovery you can't wake up it (only way is to trying with random buttons to restart the device).
[Galaxy Tab 4 Android Development] hennymcc:
It seems that a library is missing:

https://github.com/cm-3470/android_...ob/cm-12.1/proprietary/lib/libQmageDecoder.so

Could you copy the libQmageDecoder.so file into the /system/lib folder and try again?
[Galaxy Tab 4 Android Development] hennymcc:
According to interstellar22 it is the same on stock ROM. So all sensors (which means: Accelerometer) work.
[Galaxy Tab 4 Android Development] hennymcc:
The app does not test the compass (which is not the "Magnetic sensor"). Does the T235 have a compass at all?

Another App called "Phone Tester" does also test the compass feature.
[Galaxy Tab 4 Android Development] hennymcc:
Ok, according to interstellar22 (and the "Compass test" app) the T235 does not have a compass.

According to the Samsung web-pages the T235 also does not have a camera flash.
[Galaxy Tab 4 Android Development] rheckr:
Charging through USB Charger works now, the battery loading logo is visible now and it doesn't boot into recovery.

Works now exactly as it should :)
[Galaxy Tab 4 Android Development] hennymcc:
I uploaded a new ROM which contains this file.
[Galaxy Tab 4 Android Development] rheckr:
Is there any chance to enable multi window feature?
[Galaxy Tab 4 Android Development] hennymcc:
Does CM-12 support this feature?

The only way I know of is to use Xposed + xmultiwindow. Note that the official Xposed framework still does not support Android 5.1.1 - only 5.0. There are some unofficial Xposed binaries that claim to support 5.1.1 - you can check if they work with this CM-12.1 ROM (and xmultiwindow).
[Galaxy Tab 4 Android Development] rheckr:
I will check that.

Ive found next bug - when setting minimum brightness with slider the device screen goes totally black.
[Galaxy Tab 4 Android Development] rheckr:
[MENTION=6225744]hennymcc[/MENTION] Flashable xposed module doesn't work - after flashing there is a bootloop.

I've tried .zip from this topic - http://xdaforums.com/xposed/super-alpha-posted-permission-xposed-t3072979
[Galaxy Tab 4 Android Development] rheckr:
Delete this post
[Galaxy Tab 4 Android Development] HackFeed:
I find bug. Slide options in Trebuchet-launcher are not working.
[Galaxy Tab 4 Android Development] mac231us:
About the restoring TW stock from TWRP recovery...I found that the 2.8.7 has issues but the 2.8.1 does not...it is notthat cannot go back to stock imo..you can after CM but the recovery version at least per my checks is preferably the 2.8.1...so am sticking with 2.8.1-no problem shuttling back and forth from stock and CM

one thing and this was in CM 12.1 post April 16 on other devices too (then had SM-T325 Tab pro) that the exchange services would fc when syncing...there I foudn that using the 4/15 or earlier worked...but forget which one it was the email apk or the exchnage apk (both did not need replacement on the tab pro to make them work-replace one of the files with its 4/16 or earlier version...4/15 oe earlier would be a better bet imo)

another thing is the media scanner..is it actually scanning? as even I inserted audio files (ogg and mp3) directly into the system/media/audio sub folders and gave permissions, rebooted etc several times they would not show up when I tried to assign new ringtones (also maybe missing that in contacts for custom ringtones-don't recall now though the media scanner is definitely something i noticed for audio files not being scanned or showing up in selection)

cannot specify the file filter for reading in music (was thinking maybe that would enable the files to be read-like based on size in miui etc)

Thanks for your work!
[Galaxy Tab 4 Android Development] Quazu:
I found bug. You can set brightness to 0 and stuck on black screen.
[Galaxy Tab 4 Android Development] lexib68:
Patching

Dear hennymcc,

first oft all I want to thank you very much for your work.

Besides very little issues the ROM is working nearly perfect on my tab.

But I am wondering if there is a possibility to include the stagefright cm patches in this Rom?

Sorry if this is off topic and thank you for any reply.

All the best, Lexi!
[Galaxy Tab 4 Android Development] hennymcc:
A new (untested) build is available:

CM 12.1 ROM: https://www.androidfilehost.com/?fid=24052804347790522

Recovery: https://www.androidfilehost.com/?fid=24052804347790541

Changelog:

Update kernel to T235XXU1AOD1

Synchronize with newest CM 12.1 sources (contains stagefright patches)

Fixed black screen on minimal brightness

Same disclaimer as before:

As this is untested, bricking your device is possible. It is also possible that the ROM does not boot at all.

Report problems in this forum.
[Galaxy Tab 4 Android Development] lexib68:
Hi,

thanks a lot for your quick reply including download, you almost made my day ;)!

sorry for my most likely dumb questions but I use my tab daily with your great ROM! do I need the recovery? its because I used the version from OP of course to load your cm12.1 and did a nand backup with! But more important to me is do I have to flash via Odin or if twrp install will do?

Thanks again for your work!

KR Lexi
[Galaxy Tab 4 Android Development] hennymcc:
The previous recovery should work too.

Odin is only necessary to flash the recovery. The CM ROM is installed with the recovery. So if you already installed the previous recovery, just boot into it and flash the CM ROM.
[Galaxy Tab 4 Android Development] sub77:
[MENTION=6225744]hennymcc[/MENTION] how did you disabled selinux, i cant boot with selinux=disabled on the t530.
[Galaxy Tab 4 Android Development] :
sub,

hi, selinux forced permissive in kernel, not the ideal but it works

https://github.com/moonbutt74/kerne...mmit/2e4de065b266a7a15e1d392ff3f80f5c089a423d

m
[Galaxy Tab 4 Android Development] sub77:
Thanks, but permissive is no problem. he got it disabled.
[Galaxy Tab 4 Android Development] lexib68:
Boot not completed, black screen, unresponsive

Hi again,

unfortunately flashing via twrp only seemed to work. Flashing completed successfully, after that I did dalvik and cache wipe and rebooted.

Booting seemed normal, starting apps message counted complete and then: black screen, completely unresponsive, no reboot, neither button combos worked. This evenening I connected the charger and luckily reboot to download worked, selected reboot and then reboot to recovery combo worked.

Now I am back to the last version which is working very smooth but unfortunately without the stagefright fixes ;-(

Did I any obvious wrong? Or do you have a hint?

Thank you again very much for supporting!!

All the best, Lexi
[Galaxy Tab 4 Android Development] hennymcc:
As you are the only one who seems to have tried the ROM I cannot tell you if it is a general problem with the ROM or if something went ROM during the installation on your phone.

As I updated the kernel and CyanogenMod, the problem could be either in the one component or the other.

Maybe you can check if it works with the old kernel:

https://www.androidfilehost.com/?fid=24052804347793939

Just flash it with Odin.
[Galaxy Tab 4 Android Development] hennymcc:
See this commit on github:

https://github.com/tobigun/samsung-kernel-smg800f/commit/386b2a006524f1ccd34fe59de93a116c7243d9e8

SELinux is only disabled because the SELinux rules are missing at the moment (nobody worked on this so far). Better fix the SELinux permissions than to disable it.
[Galaxy Tab 4 Android Development] LauRoman:
I can't seem to get to TWRP recovery, either it's the wrong image for the device/stock firmware i have on my t235, or i'm flashing it wrong, or the device is overwriting the custom recovery somehow. Is there anything i can do?

I understand you might hesitate to respond to a newish member or one that has such a small post count, but i have flashed a few devices so far and this is the first one i'm stuck on.

LE: Nevermind, i just needed to do a 3 stage button combo :D

It is not my first device flash, but it is my first non removable battery device flash.
[Galaxy Tab 4 Android Development] rheckr:
[MENTION=6225744]hennymcc[/MENTION]

Everything is working fine. Total wipe -> flashed new rom -> flashed gapps -> rebooted.

Stagefright is patched and bug with minimum brigthness is fixed. Good job Henny ;)
[Galaxy Tab 4 Android Development] mac231us:
Does media scanner work finding ring tones etc from ext SD card or even internal storage (other than system ones)

Thx
[Galaxy Tab 4 Android Development] rheckr:
You can choose them through 3rd party apps for example - Solid Explorer. Sorry but i've never used much those settings in my tablet :)
[Galaxy Tab 4 Android Development] mac231us:
Media scanner is not some special app...basically whenever you add new media files the files get scanned and added to media file list...so if you want to change ring tones etc you can look the files up..this is my understanding. .in this rom for whatever reason the files were not seen even when I put them into system/media/audio/ringtones, ui, notifications folders with correct permissions..even after multiple reboots..standard mp3 and ogg stuff .never had an issue on cm or even stock roms before so think something to do with media scanner

Edit....stock rom can see the media files i am referring to so this one should too in my opinion (if it is a bug which it so appears to me so am reporting)
[Galaxy Tab 4 Android Development] lexib68:
so glad

sorry for late reply!

thank you very much hennymcc, I was forced to factory reset my device due to a no more working sms app (one fc and no more action afterwards strangely) and of course flashed the new version.

after that I did a flash of the gapps and now everything is looking great!!

I really thank you very much hennymcc.

you're great!

all the best, Lexi
[Galaxy Tab 4 Android Development] yaro666:
any updates?

great work dev, you the man
[Galaxy Tab 4 Android Development] hennymcc:
According to SamMobile Android 5.1.1 has arrived for the T235:

http://www.sammobile.com/firmwares/download/55932/T235XXU1BOH7_T235OXA1BOH7_NEE/
[Galaxy Tab 4 Android Development] p94:
If you turn on "Adaptive brightness" (which doesn't work) in system settings the bug with black screen on minimal brightness returns.