yashsingh1/xdaforums huggingface dataset:
[ONE Original Android Development] joefso:
alright camera quality does eem to have improved on first sight, the picture quality seems to be better than with the 50 mp plugin ( using cameranext mod and coloros camera ). The odd thing is that the automatic flash is always on in daylight ( I have tested it this morning taking pictures of my keyboard ). Sizes of the picture are bigger too. On a 1:1 zoom it seems that the picture of the sides of my keyboard buttons are somewhat distorted(?)' - I am not sure if this because of the camera though, it needs further testing.

This is what I got so far

edit : btw - excited to see how this will develop!

edit: yes I am on exodus and now the camera does not flash when taking a picture (same room setting) but it seems that the picture quality is nowhere as good. ( same with camera flash turned on ). On the other side, the distortion(?) is not present
[ONE Original Android Development] Sultanxda:
You can never have too much overkill with the camera :p Everything looks so nice with the quality cranked up to the max.

Currently, the camera HAL will ignore all JPEG quality changes and it will always force the JPEG quality to 100. If you want to compare quality with different JPEG compression levels then you should test that with the CM nightly, as I'm fairly certain that the OxygenOS camera HAL doesn't let you use the maximum JPEG quality possible.

BTW, I cheated when I took the 13MB picture. I took a picture of my laptop's screen, so all of the individual pixels of my screen were captured. Here is that picture: https://www.dropbox.com/s/51v42hqniv0cens/IMG_20150714_004931.jpg?dl=0

You need to zoom in to see the full image (as DropBox shows a smaller compressed image until you click on it).

Most of my regular day-to-day pictures average around 5-6MB, which isn't very overkill.

Automatic flash is likely based on the current ISO mode used, and the different ISO modes are working properly (and I couldn't reproduce your issue). It was probably a fluke, or something happened to temporarily increase the ISO to the point where the camera HAL (or app, not sure which) decided to use flash.

EDIT: Also, XDA compressed your picture so much that I don't know what I'm seeing in your picture :/
[ONE Original Android Development] joefso:
it is the side of a keyboard button zoomed in i did not upload the whole picture just cut out the part to make it clearr. It is just weird because the side is no where a representation of how that button really looks on the side. If you zoom in beyond 1:1 it becomes obvious
[ONE Original Android Development] gwindlord:
Will do more tests later on, but on the 1st try images look really better now, noticeably clearer and sharper. Thank you very much [MENTION=4800121]Sultanxda[/MENTION] !

None of these happens for me.

Need to mention that I use custom built UberCM ROM with your kernel and device tree (I build this ROM just for myself, nobody else has it); also building kernel via UBER 6.0 and shoot with latest CameraNextMod; this time even did no rebuild, just replaced .so on the device directly :D

Just out of curiosity, without intention to change anything: your new HAL is committed as a blob. Are its sources opened?.. And any plans to add RAW? :o
[ONE Original Android Development] Sultanxda:
Sources are partially open. The only source I've posted is from 2 months ago, and it's just enough to get the camera to open and run with the base CAF source: https://github.com/sultanxda/android_device_oneplus_bacon/commits/caf-cam

This was the hardest and most important piece of the puzzle (and it's what took me several hours over many days to accomplish). The rest of my changes that are not posted on my GitHub only took me a day, and they are maybe 50 or 60 lines of code in total.

I plan on trying to add RAW, but it may require support in the camera daemon (which is completely closed-source, no reference implementation available on CAF).
[ONE Original Android Development] gwindlord:
I've already tried to find commits for RAW support in CM gerrit, but no success yet.

One small addition: the old HAL wrote line "Flash did not fire [off]" into EXIF, the new HAL leaves an empty string. It's not bad or good for me, just different :)
[ONE Original Android Development] Sultanxda:
RAW can be implemented from the Nexus 5's camera HAL: https://github.com/CyanogenMod/andr...mmit/52658833b8a8ee9a4bc9e7b24c70730dcab074ee

There are more commits after that, but you get the idea.
[ONE Original Android Development] kaz93:
Seriously an awesome job you had done here [MENTION=4800121]Sultanxda[/MENTION]. This is the first time my phone camera quality is actually better on a custom rom vs stock rom.
[ONE Original Android Development] joefso:
video recording is broken with cameranextmod(screen turns black when pressing recording and crashes afer a while. ColorOs camera video recording works fine
[ONE Original Android Development] gborgert:
I try flashing in TWRP version 20150713 and I get an error

Comparing TZ version TZ.BF.2.0-2.0.0123 to TZ.BF.2.0-2.0.0109

assert failed: oppo.verify_trustzone("TZ.BF.2.0-2.0.0123") == "1"

Error exceuting updater binary in zip

Some help?
[ONE Original Android Development] gwindlord:
Can confirm that, attaching the logcat.

Curious thing: 60 fps video is recorded OK. The regular one became OK too after I turned off the image stabilization in video options... not sure how useful this option is, I'm not really a video shooter.
[ONE Original Android Development] FOSI17:
Is this the updated ROM cm-12.1-20150713-UNOFFICIAL-Sultan-bacon.zip ? Are we on CM or OMNI now?
[ONE Original Android Development] ciarpame:
Maybe camera fv5 app is using a different saving method and seems to follow its own quality setting (and that's fine for me): file size changes a lot if I save with a quality 75 or with a quality 100.
[ONE Original Android Development] joefso:
Yes - you can find the official releases on the first page. CM is currently only being build.
[ONE Original Android Development] MobileThrowAwayAcc:
I'm glad the hotspot is fixed! Thanks!

Is anyone else having an issue where their 'okay google' activation form any screen isn't available? I have the setting from the google now app, but there's no switch to allow it from any screen.

I'm not sure if this is rom related, or from which GApps package I flashed (I assume gapps, but I tried PA Gaaps, and Slim with no success). If you're not having this issue, could you link which gapps you used?

Thanks!
[ONE Original Android Development] damage98:
[MENTION=4800121]Sultanxda[/MENTION] - Since the thread has veered into jpeg quality / size, I hope it's ok that I tip you guys to CRAM. If we're going to be taking pics at 100% jpeg as of the 13th build (I've dirty flashed, working perfect) Some of you might want to shrink your photos to save space, especially if you have the 16gb model. Try this app - http://xdaforums.com/android/apps-games/app-best-sdcard-space-saver-cram-3-2-t3035933.

I hope you'll be impressed. It's NOT compression. Instead some algorithm tweaks are optimizing the jpeg DCTs (Discrete Cosine Transforms). Science! :)

Here's a link to a pic I took with the july 13 build, stock camera, saved to Flickr - https://flic.kr/p/v4nj9M (~6mb)

Here's the same pic, Cram'd, using default 'balanced' settings - https://flic.kr/p/w1eMXR (~1mb)

Feel free to download and pixel peep. Yes, I know it's not a great pic :) Feel free to test with your OWN works of art. It's Thunderstorming cats n dogs here in Tampa.

Thanks for the awesome ROM [MENTION=4800121]Sultanxda[/MENTION]
[ONE Original Android Development] aosp:
[MENTION=4800121]Sultanxda[/MENTION] Take a look at the camera related repos

https://github.com/almalence/OpenCamera

https://github.com/troop/android_raw_collection

https://github.com/troop/camera

https://github.com/troop/chromatix_hex_wrapper

https://github.com/troop/FreeDcam
[ONE Original Android Development] SergioPC92:
Awesome ROM!

Never seen other rom with the same level of optimizations like this.

One Thing, beauty face don't work, bug?

Thnks master!
[ONE Original Android Development] andreas__:
Try this :

Navigate to your Google settings- languages and LONG press your native language to set is as "default". Just selecting it didn't do the trick at least for me.

My gapps are these:

http://xdaforums.com/android/software/tk-gapps-t3116347 by tkruzze (thanks for a great package)
[ONE Original Android Development] CNDow:
To take advantage of the new build's camera tweaks does it matter what camera app you use?

TIA
[ONE Original Android Development] Sultanxda:
Yeah, I tried enabling DIS (digital image stabilization) on my own and the same thing happened, so I will forcefully disable it in the camera HAL.

I couldn't see a difference in video quality before with it enabled (I think it messes with the preview).

It does not. You can use any app.
[ONE Original Android Development] Likort:
Hey Sultan, first of all thanks for the work you put into this ROM, I really like it. The only problem with it (or maybe it is with CM 12.1 in general), I am having several soft reboots per day. Is the attached logcat snippet (just happened a few minutes ago) helpful in finding out what is causing it?
[ONE Original Android Development] Sultanxda:
New build uploaded with the camcorder troubles fixed.

Stop using xposed.
[ONE Original Android Development] ciacho333:
MMS sending still not working :|
[ONE Original Android Development] 69gm:
For those of you who have not tried Sultan's latest ROM with his camera magics, and were wondering if it makes a difference, here are some shots I took at my work place (yes I live in Hawaii).

I think it really showcases how well it works. I don't know if XDA compresses them but I can link to the originals if you like.

I think they look pretty nice. Hope it gives you an idea of how they can look.

My camera app is the latest ColorOS port (ver. J).

Hope you like it!
[ONE Original Android Development] gwindlord:
All shots are nice, but macro, should be also tested on landscapes probably.

Interesting fact: yesterday's HAL made photos 4208x3120, and today's one provides 4160x3120 :)
[ONE Original Android Development] Sultanxda:
Myth!

Both resolutions are still available at the HAL level, but some camera apps decide to use one as the max and not the other. Example: Google Camera goes up to 4208x3120, but the ColorOS camera doesn't.
[ONE Original Android Development] gwindlord:
I swear you, the same CameraNextMod, same options, I've just replaced camera.msm8974.so again with the new one, making shots before and after the replacement. No idea why yesterday's and today's HAL decisions differ, but this could mean something for this camera app users.
[ONE Original Android Development] 69gm:
Actually NOT macro. Macro is usually measured in inches. All these shots are a few feet away believe it or not. I was no closer than about a meter to any of my subjects.
[ONE Original Android Development] Manav Bhagia:
Cyanogen os camera builds

Sir , I am a great fan of the ROM , but can you provide a ROM with cyanogen os camera libs?

I take a lot of 4k recording
[ONE Original Android Development] Renosh:
I'd be interested in knowing if you compared these photos with previous ones you had taken of the same subjects before the new camera HAL?
[ONE Original Android Development] 69gm:
That would be an interesting comparison. After all, I DO have a good eye! All these pictures could've been just MY skill! :D

Seriously though, I do remember taking pictures with the old CM libs as well as Sultan's original camera. Although I do think the older pictures came out nice, I don't ever remember being impressed with this level of detail and color saturation.

I will see if I can dig up any old pictures as a comparison...

---------- Post added at 11:03 PM ---------- Previous post was at 10:41 PM ----------

I think I got rid of a lot of my older test pictures since I didn't need them anymore. These are the only ones I could find. Details are pretty good but the picture itself doesn't "pop" to me:

---------- Post added at 11:05 PM ---------- Previous post was at 11:03 PM ----------

To me, the pictures really come alive with Sultan's new camera HAL.

Opinions?
[ONE Original Android Development] Renosh:
Kinda hard to tell with these pictures, I'll have to test this out since I'm on regular CM12.1 nightlies and compare the same photos with Sultans, hopefully in similar conditions
[ONE Original Android Development] gwindlord:
Maybe it's just sunny weather, but I do agree, new HAL makes photos... slightly better than alive I would say :)
[ONE Original Android Development] 69gm:
It is true that I didn't take all these pictures, especially the older ones, on the same day with EXACTLY the same conditions...but here in Hawaii, we don't get much fluctuation in our weather. All the days these pictures were taken, it was a nice sunny day. :D

---------- Post added at 11:51 PM ---------- Previous post was at 11:49 PM ----------

My thoughts when I looked back at these pictures were, if it were similar, the array of colors in the balloons would've been a lot more brilliant. To my eyes, anyway, the balloon colors seem muted compared to the newer pictures of the flowers.
[ONE Original Android Development] Renosh:
That is a function of the Oxygen camera libs

Here are two photos of the same subject

Took these a couple weeks ago when I was on Oxygen OS and its clear the colors are punchier in the second photo . First photo is taken using CameraNext and second Google Camera on O2 Os. I was more interested in knowing if the photos were sharper/more details or any other additional benefits gained from Sultan's efforts on camera HAL
[ONE Original Android Development] Sultanxda:
There are benefits. In the OxygenOS camera HAL, JPEG quality was capped below 100, so pictures came out looking far too compressed even when supposedly setting the JPEG quality to 100. This was the major problem with the OxygenOS HAL; my HAL has JPEG quality forced at 100 all the time.

Furthermore, my HAL is based off of plain CAF sources from Qualcomm. With my first build, the compiled HAL library was 276kB, whereas the OxygenOS HAL library is 296kB, so it can be assumed that my HAL and the OxygenOS HAL are different (albeit very similar overall, otherwise my HAL wouldn't work with Oxygen's proprietary camera libraries).
[ONE Original Android Development] mumaster20:
:good::good: No RAW support is literally make me not using this rom as a daily driver. Almost going on vacation and i need that RAW support to take pictures over there.

Once it's implemented in this rom it would basically be perfect, hope you can make it work! :good::good::fingers-crossed:
[ONE Original Android Development] 69gm:
It is true that there are tons of variables in the world of photography. And even after all this, i am a firm believer that if you are serious about taking good pictures, you should NOT be doing so on a phone camera.

That being said, this was the first time I took pictures and was impressed enough to think they rivaled a good stand alone digital camera. In the past, I've taken hundreds of pictures and each time I thought, "Meh, not bad".

I'm just happy to know that the OnePlus One seems to have decent hardware and that once you tweak the software, you've got yourself something decent. If the hardware was crap, no amount of tweaking will help. :D

---------- Post added at 01:09 AM ---------- Previous post was at 01:08 AM ----------

One can only hope! Let's hope that O2 fixed it in it's newest build that's installed on the OP2. Hoping for RAW and 4k too!

---------- Post added at 01:32 AM ---------- Previous post was at 01:09 AM ----------

Speaking of the OnePlus 2 camera, here's a review of it! Interesting!
[ONE Original Android Development] xxDominatorxx2:
So how is the battery life compared to dirty unicorns ROM ?
[ONE Original Android Development] Renosh:
Tested out photo quality between CM12.1 nightlies and your latest build and sure enough there's greater detail and sharpness in the photos on your 0714 build . Using CameraNext on both versions
[ONE Original Android Development] ce_rob:
anyone have SOD issues on the 13th build? or random google music/flashlight turning on?

i was on the 12th build for a day without any issues. flashed 13th on top and twice i've had to hard reboot (power + volume up/down) as my phone wouldn't wake up. the one time it DID wake up - which was after maybe 1-2min of trying to turn the phone/screen on, google music started playing out of no where and the flashlight turned on. this morning, exactly one minute before my alarm went off at 5am, google music started playing by itself again.

very strange and probably a one-off issue, but i'm curious about the SOD/not waking up problem. anyone experience that?
[ONE Original Android Development] RenderBroken:
If you were to provide logs by using an app called Syslog, we could help you better.

Getting logs together when reporting an issue should be automatic. Users, need to get into the habit of doing so. This is not a gripe, just a reminder to all users. Devs need to know about these issues so they can be fixed before moving on. Sometimes it's hard to go back and fix an issue after you have already committed other changes on top of it. Still thanks for the report.
[ONE Original Android Development] ce_rob:
oh definitely, just figured i'd ask beforehand if it were a known issue - particularly because i'm still in the process of setting my phone up (got it two days ago, flashed right away haha) - but i'll be adding logs if/when it happens again. thanks either way :)
[ONE Original Android Development] grotesque02:
I want try this rom.

I read this "Download and flash the latest official CM12.1 nightly. Then, without rebooting from recovery, flash my ROM on top", so I have to flash last nightly and after flash this rom over without clear cake/dalvik/factory reset?

Thanks!
[ONE Original Android Development] Deepak Vishnu:
Just flash the lastest cm nightly then sultans rom and then gapps then your good to go and clear wipe after cm nighly is always good though... [emoji5] [emoji5]
[ONE Original Android Development] grotesque02:
Sorry, my limited english don't help me :(

I have to do this:

1-factory reset

2-flash cm nightly

3-flash sultan's rom

4-flash gapps

5-(some wipe here?)

Or this:

1-factory reset

2-flash cm nightly

3-wipe dalvik/cache (or factory reset?)

4-flash sultan's rom

5-flash gapps

Sorry again :(
[ONE Original Android Development] Deepak Vishnu:
Any will do.. But the second one would be better
[ONE Original Android Development] kepaware:
Delete this please
[ONE Original Android Development] c_brown93:
I don't know what this build of CM did to my camera. But I have ran CM12.1 nightlies, CM12s, Slim, etc. And my camera was messed up bad (laggy camera, purple lines, did not focus, cannot connect to camera errors). I actually ordered a new camera for $25 because I thought mine was bad. After flashing this ROM ALL my issues are gone. Camera is perfect now. Zero lag, great photos and focus, video recording works good. I don't understand. Can someone shed some light? Should I still replace my camera? It was going crazy on everything else.
[ONE Original Android Development] joefso:
Basically Sultanxda modifed camera HAL from CAF branch(so very different code from the roms here on xda - see first page for more detailed info). Feel free to support this developer by donating :)
[ONE Original Android Development] c_brown93:
So do you think I should replace the camera still? After having those issues on all those other ROMs.
[ONE Original Android Development] joefso:
No, if you have no problems with your current camera then I do not see any reason why you should. Any explanation for why your camera is behaving so with other roms should be investigated further by capturing a logcat, if you desire a more indepth and accurate explanation.
[ONE Original Android Development] move_some:
I just noticed that the download via OTA is quiet slow (8 to 10 KB/s). The speed via androidfilehost is normal 3 to 4 MB/s.

Is there a Chance to fix this? Would be great.

Bzw. using 20150713....

Thanks.
[ONE Original Android Development] TCattd:
ColorOS camera J is an instant crash for me here. Even without any plugin installed, just force close at startup.

H version works without problems.

How do you get it up and running with J version? Please.
[ONE Original Android Development] 69gm:
I don't know. I installed and it works! Generally, if you have problems with any camera, I would try to delete app data and see if that helps. Many times, that's all it takes.

---------- Post added at 11:52 AM ---------- Previous post was at 11:51 AM ----------

OTA is not something Sultan controls. He just uploads to the server. If the server is slow, there's nothing that can be done about that.
[ONE Original Android Development] TCattd:
Did that already, no luck.

Even tried the recovery installer zip, same results.

(Thanks for the time)
[ONE Original Android Development] Sultanxda:
New build uploaded. [MENTION=1540130]ce_rob[/MENTION]'s SoDs should be fixed, I/O latency should be a bit better, and the screen should wake from sleep a bit faster.

I should really think of something better to do with my summer break :|
[ONE Original Android Development] ce_rob:
you sir, are amazing - flashing now. thanks!
[ONE Original Android Development] qwerty123321:
I flashed your ROM on top of Jgcapps cm12.1 and so far so good ! Dirty flashed it and absolutely no issue thus far !
[ONE Original Android Development] animefans:
As a decent human being, I totally agree with you

As a selfish SOB, I wish you do more of this, especially adding RAW support to your camera HAL

:laugh:
[ONE Original Android Development] bokisagod:
Just wanted to say thanks for the amazing work. As you said in the OP, current 12.1 CM has been a bit borked with all the merges, this is a big improvement!

Cheers
[ONE Original Android Development] crazydude10:
Off Topic :

I was having the WiFi drop issue that couple of people mentioned in this thread. In my case it turned out to be Titanium backup running scheduled backup which broke the Wi-Fi. There is a new titanium build which claims to have this issue fixed.
[ONE Original Android Development] nickjwall:
Hi

So in frustration at this issue absolutely destroying battery life, last night I clean flashed and it seems to have resolved it.

Cheers!
[ONE Original Android Development] Super_Commando:
Hi, I'm on slimsaber 13/06 build, can i directly flash this over it. I'm on a limited data plan, so don't want to download latest nightly.

Or , is there any other method?
[ONE Original Android Development] abhibnl:
The latest nightly flashing is to make sure that you are on the latest firmware. However, it's not mandatory. You can flash the standalone firmware zip file dated 6/15 and it would work. Search it on xda or move to any rom's OP. Almost all the roms has this firmware mentioned in their OPs. Go to temasek rom thread for example.

Sent from OnePlus One
[ONE Original Android Development] fmc000:
Never imagined that you young Californian guys had this kind of problems :confused:
[ONE Original Android Development] lordsinasina:
Ever since cm12 IMDB app video playback is struggling as it hangs most of the times somewhere in between. The issue is not consistent but I would say 70 percent of the times it happens. Does any one know a possible solution for this?
[ONE Original Android Development] TCattd:
This happens to me with the Relay for Reddit's internal YouTube player. The video hang somewhere in between, but the audio keeps playing. Have to rewind it a little to keep watching.

Not always, but happens.

Also happens with the new Google Photos video player.
[ONE Original Android Development] spyrale:
Happens also with Play NewsStand internal YouTube player.