yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] Massi-X:
New alternative version 2.0

[MENTION=5222551]Maxr1998[/MENTION] I hope you'll read this.

Hi to all, I've worked in the last few days to this new version to fix many things that doesn't work in the previous ones.

In particular:

- Fix the loading of album art in the notification: indeed it never worked for me, now it's fixed

- Hide voice commands toggle

- Fixed error in nowplaying screen show in xposed log

- Added italian translation

Attached to this post there is the apk. It is signed differently, so you have to uninstall the previous version.

Maxr1998, I made a pull request on github with all the changes, give it a try!
[Xposed Framework Modules] RSDamasceno:
How to change only dpi for GPM? (App settings doesn't work).
[Xposed Framework Modules] Maxr1998:
I've seen your changes on your repo, but I didn't find the pull request by now.. could you create one for me?

Then I can look through them in detail, but for now, they look very promising!
[Xposed Framework Modules] Massi-X:
Yeah, the problem is that I never used github :P

I have to search how to do it!

EDIT: OK, done!

PS. I think I have to edit some file, I will send you later.
[Xposed Framework Modules] h4waii:
This has fixed my crashing and works beautifully.
[Xposed Framework Modules] Massi-X:
Max, I've pulled all the changes!

You can see in your github!
[Xposed Framework Modules] Maxr1998:
Saw it, will look through it in detail tomorrow.
[Xposed Framework Modules] yakie996:
Im using the new design but now the title is empty if collapsed is it possible to change it when in the menus?
[Xposed Framework Modules] Massi-X:
Yeah is a know issue, maxr is working on it!
[Xposed Framework Modules] OrangeFever:
Is the xMediaNotificationTractor module still being worked on? Just installed it alongside xGPM and when I click the queue button in the notification it brings up a white box.
[Xposed Framework Modules] Massi-X:
Share xposed log, but it must be a XGPM problem.
[Xposed Framework Modules] Maxr1998:
Make sure you're running the latest GPM and XGPM version.

I'm using Google Play Music 6.10 from apkmirror released yesterday and everything works fine.
[Xposed Framework Modules] OrangeFever:
Yep that worked. I was using the xGPM 2.0 posted by another user but I uninstalled that and installed the official one and it worked.
[Xposed Framework Modules] Maxr1998:
Didn't find the time by now, but I will look at it soon, I promise!

Glad it works again now. [MENTION=5576742]Massi-X[/MENTION] could you look at your changes again to fix this bug?
[Xposed Framework Modules] Massi-X:
Yes Max! Done even before reading this post! Now you can choose from max(r1998) implementation or ma(ssi-)x implementation! :P

I attach the APK for who want to try it out!
[Xposed Framework Modules] greg285:
Hi,

I still have issues with ne design...each time i select it it force close google music

Tried with latest version from apk mirror, and the first debug app posted in this thread - rebooted the phone ...still no success

I read in previous pages than it can be due to DPI ...mine is at 360

Logcat attached
[Xposed Framework Modules] OrangeFever:
Works perfectly with the notification tack selector xposed module, thanks!
[Xposed Framework Modules] hochoch:
Confirming that there definitely is an issue with DPI. I was at 480 on my 6p, and getting fc's so I went back to stock 560 and it's working perfectly.
[Xposed Framework Modules] cantsingh:
So I factory reset my 6P and XGPM changes aren't taking effect. Any ideas on how to debug? Thanks in advance.

Edit: Here's a pastebin of the relevant portion of my Xposed logs. Looks like a null pointer in the XGPM module, no idea what could be causing it though...

http://pastebin.com/3JfA6Mq3
[Xposed Framework Modules] Maxr1998:
Update your Google Play Music from APKMirror and reboot. That should fix it.
[Xposed Framework Modules] cantsingh:
No luck. Updated to the most recent Google Play Music apk on apkmirror, cleared data / cache for Google Music & XGPM and still not taking effect... any other ideas?
[Xposed Framework Modules] Maxr1998:
Wait, could it be that this apk is the one from N-Preview? If so, try the previous one.
[Xposed Framework Modules] cantsingh:
I tried the previous version, too..still no luck. Are there particular version numbers for Google Music / XGPM you suggest?
[Xposed Framework Modules] Maxr1998:
Nope, I'm using the previous one. Guess it's something else.

I will look at it soon.
[Xposed Framework Modules] cantsingh:
Thanks. I'll continue to troubleshoot on my end and let you know if I come across anything concrete. Thanks again for an awesome module, XGPM has totally changed how I use Google Music.
[Xposed Framework Modules] Massi-X:
Try to install my debug version some post before, i fixed the setvisibility problem, maybe it can help! And if not works, send log!

EDIT: in my app i came across this problem and was caused from the PREFS.reload() that returns a blank file, maybe you can try with this [MENTION=5222551]Maxr1998[/MENTION] ?
[Xposed Framework Modules] cantsingh:
Hey that fixed it! Thanks a lot buddy!
[Xposed Framework Modules] Massi-X:
:victory:
[Xposed Framework Modules] jerryshaw12:
Custom design caused no song title, album title and artist name
[Xposed Framework Modules] jerryshaw12:
Could you add option to tint statusbar based on album art too? (Only in player mode)
[Xposed Framework Modules] Massi-X:
Know issue!

Yet requested!
[Xposed Framework Modules] jerryshaw12:
Is it just me or current bug? There are no action menu on top
[Xposed Framework Modules] jerryshaw12:
Also there is google now voice button, is it GPM feature or XGPM feature? When i enabled this module, this button is appearing
[Xposed Framework Modules] Massi-X:
I see this time ago, you ca submit a bug on github.

Xgpm feature you can disable it using the beta version some post above.
[Xposed Framework Modules] m4mmt:
Thanks for the mod, it's awesome :). There's a way to have it for those who have android n and can't install xposed? Maybe something like a custom apk? It would be perfect since the stock play music app is quite bad
[Xposed Framework Modules] Maxr1998:
Known "bug". It happens because I shifted the details to the bottom on the info screen. Have to find a solution for this..

Actually, this is an upcoming feature of Google Play Music that I found because the button was shown after adding the equalizer button, and then I found a solution to fully enable the feature.

Probably not. I'm using Xposed because it's rather easy to edit apps, with a custom apk I had to modify it for every new release..

Also, resigning, etc..

That's a ton of unnecessary work. I'm pretty sure that Xposed will be updated soon after N is released.
[Xposed Framework Modules] m4mmt:
Thanks for the quick reply. Can you consider to mod the latest version of the app and ignore new updates? Probably Android n will be released in two months, we will also have to wait that xposed will became compatible. Or at least can you give me some information about how to apply your mod to a custom apk? It would be awesome :). Again thanks for your work
[Xposed Framework Modules] Massi-X:
I think xposed for Android Nougat will arrive before a modded apk... Modding an apk means play with smali files that are soooooo different from Java files, and doing this require months of unuseful work! The only way is wait for xposed for Android N!
[Xposed Framework Modules] Sirence:
I switched phones today, rooted and installed xposed on the new one, and then restored everything via titanium backup - now xgpm won't work at all. I use the same play music version on both devices (6.10) and it's fine on the old one, but not on the new one I restored to. Other xposed apps work fine. Do you know by any chance what the problem could be? No matter how often I reboot, reinstall xgpm or google play music, it won't work :(
[Xposed Framework Modules] Maxr1998:
Maybe a broken SELinux context or file pernissions for the settings file. Clear data of XGPM, choose your preferences, reboot.
[Xposed Framework Modules] Sirence:
Thank you for the reply. Clearing data does not work, however, when I deinstalled version 1.9.1 and reinstalled the previous, that one works.
[Xposed Framework Modules] Maxr1998:
Then it's most likely a crash. Update to 1.9.1, the latest GPM 6.11.3119D.XX from apkmirror, then try if it works and if not send me your logs :)
[Xposed Framework Modules] Sirence:
How do I send a log?
[Xposed Framework Modules] Massi-X:
Go to xposed and send it, download catlog from the play store and send it. Total 2 logs
[Xposed Framework Modules] weijunmark:
Hi, I encountered the same problem as above. I switched to a new phone and installed 1.9.1 but it doesn't work. When I uninstall it and installed 1.8.8 first before updating to 1.9.1 everything works smoothly now. I am no coder so I am unsure where the problem stems from. I hope this information helps.
[Xposed Framework Modules] Massi-X:
As usual for this to be helpful you have to send the logs! :P
[Xposed Framework Modules] Maxr1998:
Pushed an update as 1.9.2, tested against Google Play Music 6.11.3120D.3072211:

Fix cover loading for local files, improve caching and speed, show grey square instead of blank space if no cover is available (Thanks to [MENTION=5576742]Massi-X[/MENTION])

Fix any UI bugs in preference screen by switching back to CheckBoxPreferences

Update build tools, target API and support libraries

Add Italian translation by [MENTION=5576742]Massi-X[/MENTION]
[Xposed Framework Modules] DiegoMarcondes:
Thanks for the awesome work!

The new version is forcing close GPM here and I didn't changed anything. Just update and opened the app so it stop working when I play something.
[Xposed Framework Modules] LuanTeles:
Lastest build. New Design and Tint Icons.. crashes Play music
[Xposed Framework Modules] Snowby123:
When I first installed the update I did no longer notice said problem, but now that you mention it I try it out myself and the problem is still there. So this is not a new problem
[Xposed Framework Modules] Massi-X:
Send log please!

Send log please!

Send log please!
[Xposed Framework Modules] Snowby123:
I replicated the issue with all my modules active and then with just this one active.
[Xposed Framework Modules] Snowby123:
The previous post lacked the attachments
[Xposed Framework Modules] Maxr1998:
I believe I fixed the bug that crashed GPM with new design enabled. Download attached version.
[Xposed Framework Modules] Massi-X:
Max I can't try it, I've never had this problem...
[Xposed Framework Modules] Maxr1998:
But I used your tip ;) thanks!
[Xposed Framework Modules] RSDamasceno:
Doesn't work for me.
[Xposed Framework Modules] DiegoMarcondes:
It doesn't work for me too. I don't know how to get the logs, sorry.
[Xposed Framework Modules] Maxr1998:
No problem. I already have an insight through the other ones. Could you tell me your config though?

Aka, GPM version, All access or not, country, Android version.
[Xposed Framework Modules] DiegoMarcondes:
Sure!

GPM version: 6.11.3120D.3072211

All access or not: (no)

country: Brazil

Android version: 5.0.1
[Xposed Framework Modules] Maxr1998:
Thanks for the information!

All access is the premium subscription of GPM.

Only edit the post to prevent clutter. :)
[Xposed Framework Modules] Presto99:
The custom design is SO SLEEK, I love it, especially seeing the whole album art. If only it didn't make the minimized Now Playing bar be blank with just a pause button. I can be more patient... But I was wondering if this was planning to be fixed. Hasn't it been broken for around a month? (thanks for xgpm!)
[Xposed Framework Modules] Snowby123:
After uninstalling version 2.0 and installing the version that was recently placed in the thread, I still get the force closes with the new design. Should I send another log?
[Xposed Framework Modules] Massi-X:
So 2.0 doesn't have that problem?
[Xposed Framework Modules] Snowby123:
The problem was in 2.0 and has not disappeared.
[Xposed Framework Modules] gunner6643:
Great module, thanks! Would fetching gif album art from google play music be possible?
[Xposed Framework Modules] VincentJoshuaET:
Just reporting: there's a new APK available (included in Open GApps), breaking the module again.
[Xposed Framework Modules] Maxr1998:
You mean for local songs? If yes, I fear not. Might look into t though.

Got the new apk via Play Store and can reproduce the crashes on my site. For now, just disable the new design. I am currently writing my term paper, which means that I don't really have time to work on XGPM. When I have time again though, I will try to fix all crashes and the blank bottom bar. No need for logs ATM, but I'll post here when I need some. Also, which version 2.0 do you guys mean? Newest version is still 1.9.2.

I do have a list of things I want to add, but I'll probably focus on fixes and compatibility with new versions first.
[Xposed Framework Modules] Massi-X:
The beta posted by me some time ago!
[Xposed Framework Modules] Maxr1998:
Oh. I see. That's a little confusing.. Well, my apks also increase the version code, so there's that. Next version will probably be 1.10 though.
[Xposed Framework Modules] Dead-neM:
Hi maxr the new GPM version broke the hide part of your module. Anything related to hide podcast section etc is not working now. Anyway this module still rocks!

Do you need log for this or you where already working on it?
[Xposed Framework Modules] earthsound:
New GPM crashes, version 6.12.3216E.3118869. Options enabled: 3 column grid, new design, tint icons.
[Xposed Framework Modules] Maxr1998:
No, I can reproduce. Will fix it soon. :)

Read the last few pages, this was already reported. Disable new design.
[Xposed Framework Modules] Maxr1998:
Ok, rats. Could you send me a logcat?

Sent using my nexus⁴ running Euphoria 1.0 with Xposed and hells-Core B69-t4 L

Bitcoin donation address
[Xposed Framework Modules] Robot Ross:
Yup, can confirm that this module is still causing crashes on 5.1.1 on my OnePlus One. Official CM12.1 nightlies. Logcat attached.
[Xposed Framework Modules] AndroidPantechFlex:
I downgraded to 5.0.2 to install this module and its great overall...it would also be good if you could theme the shuffle buttons as well to go with the album art
[Xposed Framework Modules] Maxr1998:
Thanks for the logs. This really seems like and Xposed issue. Probably nothing I could do about it. But rovo released a new 5.0.2 version today, maybe we also see a new 5.1 version the next days..

Yeah, I will also include these buttons when I have time :)
[Xposed Framework Modules] MtG92:
[MENTION=5222551]Maxr1998[/MENTION] Do you think, at some point, code wise, it's possible to add the option to download album art and artist picture, like on Shuttle and other 3rd party players?...lack of decent album art and artist picture is what keeps me away from GPM ATM.

I'm more like asking if it's feasible, not so much requesting.
[Xposed Framework Modules] Robot Ross:
Hopefully, but I doubt it since Rovo is busy at the moment, and 5.1 had a couple of major changes to ART, but at least we may see it within the next month or so hopefully
[Xposed Framework Modules] Maxr1998:
You mean downloading the album art for local music? Possible, yeah, easy, nope. I don't really see the sense, because album arts can easily be tagged to the files and Google will read it, artist picture is considered in future, though, as you can't tag it..

Sent using my nexus⁴ running Euphoria 1.0 with Xposed and hells-Core B69-t4 L

Bitcoin donation address
[Xposed Framework Modules] Robot Ross:
+1 for setting the artist art. It annoys me since for *some* artists on Google Play, Google automatically generates the art for them based upon their album art, and often isn't the official motif of the artist. I'm guessing the problem comes from artists or studios not setting up and branding their accounts fully.
[Xposed Framework Modules] Maxr1998:
Guys, I just found out this module works on Android 5.1 with dalvik-cache workaround! You know, delete the dalvik file of Google Play Music after each reboot. Anyway, I will first publish my MaxLock update, and then turn again to XGPM with some new features, I already have _TONS_ of ideas!

Sent using my nexus⁴ running Euphoria 1.1 with Xposed and hells-Core B75
[Xposed Framework Modules] Maxr1998:
Yeah, I already talked to GermainZ, and he allowed me to include it. Also, I found out XGPM now works with 5.1 with the new Xposed 5.1 alpha 4, thanks to [MENTION=5008415]C3C076[/MENTION] and [MENTION=2476451]romracer[/MENTION]!

As I said, I first want to finish my current work on MaxLock, then I will look onto XGPM again.

Sent using my nexus⁴ running Euphoria 1.1 with Xposed and hells-Core B75
[Xposed Framework Modules] lion7718:
Seems to be working fine for me on 5.1.

I would like to see "Instant Mixes" disappear, if it's possible. ;)
[Xposed Framework Modules] Maxr1998:
Yes, it is, but not before next weekend, have some tests next week..

Sent using my nexus⁴ running Euphoria 1.1 with Xposed and hells-Core B75
[Xposed Framework Modules] AndroidPantechFlex:
hey max thanks for your module. I was wondeting

If you could implement tinted status and navigation bar based on the album art? I think that would be even better and cleaner ☺ thanks once again man for this nice module, now I only use google play music because of this module lol
[Xposed Framework Modules] ScarletDusk:
Fixing the drawer lag

I don't know about anyone else, but the drawer in the Google play music stutters quite a but on my nexus 6 when switching between tabs. (eg. Try switching from playlists to my library) and I think I know why. The app tries to load the new page at the same time as moving the drawer away, causing stuttering. If you were to make it load the page BEFORE moving the drawer away (like how it works in the Google app when using its drawer) then the lag would dissapear
[Xposed Framework Modules] Maxr1998:
Interesing idea! This could really be the problem. Well, I will definitely look into it, but first, you know, I have to finish MaxLock.

Sent using my nexus⁴ running Euphoria 1.1 with Xposed and hells-Core B75
[Xposed Framework Modules] MelomanCool:
There is a small bug. Look at the upper-right corner.

ASUS MeMO Pad HD 7 running Android 4.2
[Xposed Framework Modules] Maxr1998:
Oh, I will look into it. Send me you GPM version.

Since I am on vacation the next 1½ weeks, it could take some time..

Sent using my nexus⁴ running Euphoria 1.1 with Xposed and hells-Core B78
[Xposed Framework Modules] MelomanCool:
It's 5.9.1854R.1904527 (latest).
[Xposed Framework Modules] AndroidPantechFlex:
I notice this annoying problem

When there's an album art cover with white and black the colors turn yellow? Shouldn't they be black instead?
[Xposed Framework Modules] Maxr1998:
Well, yellow is the default color when no color can be found. Palette seems to have problems with black & white images..

Sent using my nexus⁴ running Euphoria 1.1 with Xposed and hells-Core B78
[Xposed Framework Modules] frusso21:
SUGGESTION:

Default to play next/add to queue. One of the things I hate most about gpm is when I meticulously make a queue and tap on a song it will delete all my work. I'd much rather have my default set to play next with an option to hold down to play right now.

Love your work btw!!
[Xposed Framework Modules] CCJ22:
Is there a mod we can do to stop the data from upstream/downstream?

Check out my video linked below of my screen recorder. I have:

-ticked the "only show me my downloaded songs I own on the device storage"

-stream ONLY on wifi turned on

-cache music while streaming is off

-download only on wifi turned on

YET STILL on LTE and not on wifi google play is constantly crushing on the data. Why would this be? How can I turn this off? Maybe through an xposed module?

www.youtube.com/watch?v=CVnVruVJbjU
[Xposed Framework Modules] Maxr1998:
I think that the cover art and artist art loading still happens on mobile data. To prevent GPM from using any of your data, I can wholeheartedly recommend you trying out AFWall+, it's a root linux iptables firewall app on Google Play. Config is easy, it hardly uses any processor cycles (if not none at all), and the design is superb. Just choose blocking mode and select GPM (and possibly others).
[Xposed Framework Modules] Xhatry:
Hello, I am getting this error with the lastest update of Google Play Music in the playstore on my Moto G (2015) 3rd Generation:

08-13 17:57:43.925 E/Xposed ( 6070): java.lang.NoSuchMethodError: com.google.android.music.Feature#isSnappleEnabled(android.content.Context)#exact

08-13 17:57:43.925 E/Xposed ( 6070): at de.robv.android.xposed.XposedHelpers.findMethodExact(XposedHelpers.java:337)

08-13 17:57:43.925 E/Xposed ( 6070): at de.robv.android.xposed.XposedHelpers.findAndHookMethod(XposedHelpers.java:178)

08-13 17:57:43.925 E/Xposed ( 6070): at de.robv.android.xposed.XposedHelpers.findAndHookMethod(XposedHelpers.java:253)

08-13 17:57:43.925 E/Xposed ( 6070): at de.Maxr1998.xposed.gpm.hooks.Main.a(Unknown Source)

08-13 17:57:43.925 E/Xposed ( 6070): at de.Maxr1998.xposed.gpm.hooks.Main.handleLoadPackage(Unknown Source)

08-13 17:57:43.925 E/Xposed ( 6070): at de.robv.android.xposed.IXposedHookLoadPackage$Wrapper.handleLoadPackage(IXposedHookLoadPackage.java:34)

08-13 17:57:43.925 E/Xposed ( 6070): at de.robv.android.xposed.callbacks.XC_LoadPackage.call(XC_LoadPackage.java:61)

08-13 17:57:43.925 E/Xposed ( 6070): at de.robv.android.xposed.callbacks.XCallback.callAll(XCallback.java:106)

08-13 17:57:43.925 E/Xposed ( 6070): at de.robv.android.xposed.XposedInit$1.beforeHookedMethod(XposedInit.java:93)

08-13 17:57:43.925 E/Xposed ( 6070): at de.robv.android.xposed.XposedBridge.handleHookedMethod(XposedBridge.java:314)

08-13 17:57:43.925 E/Xposed ( 6070): at android.app.ActivityThread.handleBindApplication(<Xposed>)

08-13 17:57:43.925 E/Xposed ( 6070): at android.app.ActivityThread.-wrap1(ActivityThread.java)

08-13 17:57:43.925 E/Xposed ( 6070): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1415)

08-13 17:57:43.925 E/Xposed ( 6070): at android.os.Handler.dispatchMessage(Handler.java:102)

08-13 17:57:43.925 E/Xposed ( 6070): at android.os.Looper.loop(Looper.java:148)

08-13 17:57:43.925 E/Xposed ( 6070): at android.app.ActivityThread.main(ActivityThread.java:5443)

08-13 17:57:43.925 E/Xposed ( 6070): at java.lang.reflect.Method.invoke(Native Method)

08-13 17:57:43.925 E/Xposed ( 6070): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:728)

08-13 17:57:43.925 E/Xposed ( 6070): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:618)

08-13 17:57:43.925 E/Xposed ( 6070): at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:102)

Is it normal or there is something wrong?
[Xposed Framework Modules] Maxr1998:
[MENTION=7271684]Xhatry[/MENTION]
[Xposed Framework Modules] Xhatry:
It's good to hear that you will be trying to fix the crashes and the blank bottom bar in the future. I just wanted to say that I had already the new design option disabled (because it interferes with another Xposed module, which I have told you about in the past, called XNotifications).
[Xposed Framework Modules] OrangeFever:
Getting constant reboots using latest XGPM, new design not selected.

Nexus 6P, 6.0.1, Pure Nexus
[Xposed Framework Modules] Snowby123:
Recording the Xposed log and posting it here would be useful for the developer to identify the issue. Do you have any other modules activated?
[Xposed Framework Modules] OrangeFever:
Installed Modules

Phone rebooted twice within an hour after enabling XGPM + XMediaNotificationSelector. 2 xposed error logs attached
[Xposed Framework Modules] Massi-X:
There is an error in the log, but I think this isn't the problem. I'm almost sure it happens when you skip much songs in a long playlist. The module do too much work and cause a soft reboot. You can try if this is the case?

PS. Try to enable no covers option and see if this fix the reboots.