yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] jrcyscon:
You should also add some more things like these:

1. Get rid of the "Google Play Music" tab

2. Disable the double tap on top screen to turn off downloaded only tracks

3. Customize features where you can change the color of the app and stuff. That would be dope
[Xposed Framework Modules] GoJo ^^:
I read about safemod but it doesn't seem to work at all for me..!

Always quote my messages so I get notified quickly!
[Xposed Framework Modules] Maxr1998:
Whoops, really? I never used it myself, thought it works. Please file a bug report in Xposed thread, then :)
[Xposed Framework Modules] Sirence:
Google Music keeps force closing on 1.8. I went down to 1.6 and it works. Is this a known problem or is there anything I can do?

The Playlist Shortcut in the Navigation Drawer also doesn't work if enabled, on any version.
[Xposed Framework Modules] Dead-neM:
It's a know problem due to art cover that are not loading well -- Log are welcome

It's working if you untick the start on my library option
[Xposed Framework Modules] Sirence:
I see! Sorry, I can't send a log atm as I already reverted to a previous version.

But thank you very much for your help!
[Xposed Framework Modules] Billyvnilly:
I've just seen that if your phone has the power button set to lock the phone, (galaxy s6, 5.1.1, settings > lock screen > secure lock settings > "lock instantly with power key" toggled on) that it causes crash if GPM is playing and XGPM is installed. Search is down for me, is this new?
[Xposed Framework Modules] Jkay7:
I cannot confirm this bug on Xperia Z3, although “power button instantly locks“ is active, just as XGPM and music playing.
[Xposed Framework Modules] Maxr1998:
I guess it's another cause, not directly related to locking of screen. Could you send me a logcat, please?
[Xposed Framework Modules] ban.codrut:
[MENTION=5222551]Maxr1998[/MENTION] I have a strange problem with your module since you added the old style notification option ( previous versions worked flawless )

If I enable your models, even with no option enabled in it, GPM crashes no matter what.

In Logcat I see lots of errors about an com.google.android.music.art.ArtRequest.finalize, lots of them then it crashes. Here is the logcat https://drive.google.com/file/d/0B4CKB4HIk8-bb0Rac0lZWE1feXc/view?usp=docslist_api

I have logged only the errors if you want a more verbose log tell me and I'll upload one.

Can you fix this?

I really like that old style notification which fixes my Moto Display issue with the new one, that's the main reason I'm not sticking with your old version of the module. Thank you for the great work !

Inviato dal mio XT1575 utilizzando Tapatalk
[Xposed Framework Modules] brossovitch:
I've been using this module for quite some time now.. It's really amazing, BTW.

I've always just had one issue, just one.

The option to hide from launcher does not work. It never has since I first began using this.

Has this been addressed? Just curious, it's not bothersome or anything.

Running CM13.

Thank you.
[Xposed Framework Modules] vjtigas:
Not yet. We just have to wait for him to fix it and update.
[Xposed Framework Modules] Maxr1998:
Experiencing the crash as well.. Since there wasn't an update in the last days, I might have done something wrong. And btw, ArtRequest is caused by track selector, not old design.

Didn't fix it by now, I just don't have the time to look at such an rather unimportant issue (at least to me). But I will look at it soon, and fix it on MaxLock and XGPM (since it's basically the same code).
[Xposed Framework Modules] ban.codrut:
Are you sure is the track selector ? 'Cus it crashes even without XMediaNotificationTrackSelector installed, this in the last update where the feature got removed in the favour of the plugin option. So basically I get the same error/crash without that feature in the house.

Could you suggest an workaround? Is there a way to use v1.8 with old style notification without the track selector in a stable manner ?

Inviato dal mio XT1575 utilizzando Tapatalk
[Xposed Framework Modules] Maxr1998:
I guess not, wait for an update, probably even later today..
[Xposed Framework Modules] Maxr1998:
[MENTION=6320600]ban.codrut[/MENTION] I fixed the issue, and pushed 1.8.1 to Xposed repo. Another change is the update of the build tools and a library.

Fix was quite easy, I just stupidly use the wrong list instance when receiving completed ArtRequests. That resulted in a crash when switching to a playlist with less track than before (IndexOutOfBoundsException when getting list item outside of the lists length), or in leaked ArtRequest objects.
[Xposed Framework Modules] ban.codrut:
I'm gonna try and report back

Inviato dal mio XT1575 utilizzando Tapatalk
[Xposed Framework Modules] Jkay7:
Hey :)

Thanks a lot for your module(s), I've been using it for quite a while now! Do you think it'd be possible to set a custom transparency to the notification of GPM? I'm using a different module to blur the status bar, so it'd be nice to have the same effect for the notification :)
[Xposed Framework Modules] NIGHTFIRE777:
Thanks for the update! It works really well but for some reason the XMediaNotificationTrack thing doesn't work at all for me. I'm on the latest versions of both XGPM (1.8.1) and XMediaNotification (1.1). I have also enabled the "use old style notification" in XGPM but it doesn't seem to be working for me.
[Xposed Framework Modules] Maxr1998:
It might be enough to just allow the notification to be transparent, I will take a look at it.

That's strange. You don't need the old style for it to work btw. Did you reboot after installing and enabling both modules?

Send me your Xposed logs if it doesn't help.
[Xposed Framework Modules] NIGHTFIRE777:
[MENTION=5222551]Maxr1998[/MENTION]. I reinstalled the XMedia module and it still didn't work. I attached my log file and hope it helps.
[Xposed Framework Modules] fireworksordie:
I am getting a consistent crash after installing the latest XGPM and trying to play an album in Play Music- the music starts to play but Play Music immediately tells me it's crashed, attempts to restart, crashes again, then restarts fine. But then when I attempt to play an album it does the same thing over. I've PM'd you a link to a CatLog.

Let me know if there's anything more I can do to troubleshoot this.
[Xposed Framework Modules] Moiremoi:
I've updated Google Play Music to version 6.3.2313V and since all the notification modification doesn't work, including xMediaNotificationTrackSelector even with the new notification style (the one with the thumbs)

Also the drawer modification doesn't work to

Hope you can do something about it

If you want logs or something, tell me

Now I can't do anything, but later I'll be able to do something

Sorry about my poor English ^^'
[Xposed Framework Modules] Maxr1998:
I already noticed, probably there are some other bugs... I will hopefully fix them later today or the following days.
[Xposed Framework Modules] Moiremoi:
Thanks for responding so quickly! ^^

And happy to know that you're already looking for this! ^^
[Xposed Framework Modules] Maxr1998:
I fixed support for the new update of the Google Play Music app (version 6.3.~; note that it isn't fully rolled out by now, wait before updating XGPM or install GPM from apkmirror.com!)

There is also a little crash fix for the XMediaNotificationTrackSelector, thanks to [MENTION=3308020]fireworksordie[/MENTION] for pointing out.

The broken track selector and old design funnily wasn't caused by an Exception in the Notification part, but by a crash and a missing try {} catch() in the now playing screen class.. Explains why I didn't find any error messages.
[Xposed Framework Modules] Curiousn00b:
I installed the latest GPM(6.3) and latest module and none of the options seem to affect GPM in any manner.

I don't know if it could be caused by my device(6P) or not, but I plan on reflashing my rom. It seems as if there's lots of different things happening between this and my N5. :/
[Xposed Framework Modules] Maxr1998:
Did you make sure your Xposed installation works? Did you enable the mod and reboot?

If everything is set up correctly, and it still doesn't work, could you send me your Xposed logs?
[Xposed Framework Modules] D-m-x:
I'm also having Problems with XGPM since Google implemented the new Notification Design. In XGPM the Old Notification Layout would never work for me, on any Device (N6, N6P, N9). Play music is crashing as soon as I try to play a song.

Other things I noticed: The play/pause Button is buggy with XGPM enabled, it works in general but the Button isn't updating, making it impossible to swipe away the notification if I stop listening to music.

Also the Xmedia module never worked, its active and I have the Button but if I click it the page is just plain white. Later / Tomorrow when I'm home I can create Xposed logs and upload a screenshot.

Keep up the great work, I'm loving your modules, especially Maxlock :)

Gesendet von meinem Nexus 6P mit Tapatalk
[Xposed Framework Modules] vjtigas:
Noticed this too, but doesn't happen all the time
[Xposed Framework Modules] Moiremoi:
I may have found a bug

You know that you can upload up to 50 000 music file to your Google account?

If you do it, you can download your own mp3 file and you them the same way that the music you bought on GPM

That the way I use GPM personally, but using it this way add data to the GPM apps (instead of taking 45-50 mo, the app take 2.5Gb, that not a problem, because a that it not required to have all your mp3 on your SD)

But when I install or upgrade XGPM after downloading all my music data in GPM, I can't use GPM, it crash and it reboot my phone

Can you do something for it? Do you need logs?

I don't want to download 2.5 GB of music each time I update GPM, XGPM or Xmedia ^^''

Sorry for my poor English!
[Xposed Framework Modules] Maxr1998:
Guys, when you report a crash, please always include logcat and Xposed logs, or I can't fix.

Other general things: make sure you use GPM 6.3.2313V.2554147, and always reboot after updating XGPM/GPM/Track Selector. I also have my own songs uploaded to Google cloud, I use all-access, and I use the old notification design, everything without any problems.

Please report back with logs if above doesn't help you.
[Xposed Framework Modules] Curiousn00b:
Yeah, I had everything setup right. I had other modules running fine(XInstaller, Desk Clock Alarm, etc).

Long story short, I reflashed the ROM, flashed a custom kernel, and now everything's working fine again. :)

The only thing not working is ' Hide From Launcher ', or is it another me problem again?[emoji14]
[Xposed Framework Modules] Maxr1998:
Well, that's my always-not-working-never-properly-fixed feature ;)
[Xposed Framework Modules] teads:
If I have this installed, even if its not activated, google play music doesn't work. Any ideas? Music wont play, get error that says gpm has stopped unexpectedly.
[Xposed Framework Modules] mentallo:
Could you add an option to Remove Images from the artists screen and just have a long list names? That would be really awesome. Thanks for the great module.
[Xposed Framework Modules] ban.codrut:
That seems pretty hard-coded into the app to me. What you are suggesting is a radical change in the layout of that page and I don't think a simple module can do that. Probably removing the thumbnails and the image slot, this way ending up to a two column list of only artists names. But again, that seems hard-coded into the app itself .

Inviato dal mio XT1575 utilizzando Tapatalk
[Xposed Framework Modules] teads:
https://drive.google.com/file/d/0B11RB-stYOFkbjlxVjRPY3pGVWM/view?usp=docslist_api

I cannot figure out how to share these loga, but heres an attempt

Anyway you could make a mini module that only changes the notification to the old style? This is the only bit that I cant live without. I'd be happy to donate if thats an option.

I am also on the xt1575, running 6.0 with xposed version 80
[Xposed Framework Modules] ComfortablyDumb:
Hi Maxr1998, thanks for the great quality of life changes from this mod, it makes using GPM a much nicer experience.

Since the last change that Google made to the notification and the corresponding update to XGPM I've been running into problems like those talked about in previous few pages.

The latest update to XPGM very nearly fixed all of the problems I was having and for the first time in awhile I've been able to use XGPM with all of the options I normally use.

However I've run into a problem with large playlists that causes a force close of GPM. When the playlist is started the song takes an abnormally long time to start playing and once it has begun it will only play for 4-5 seconds before GPM force closes and begins to reboot and close itself a few times before finally closing for good. Once this has happened it becomes impossible to use GPM without a reboot of the phone or clearing of the appdata.

Playlists of 50-60 songs seem to be absolutely fine but something like my Thumbs up playlist with 500+ songs causes a crash. I've no idea where the cut-off point is or if this is even the cause.

I've sent you logs for booting into a short playlist and booting into a long playlist. Let me know if you need more info.

Phone & App Info:

Nexus 5 6.0.1 (MMB29S)

GPM 6.3.2313

Xposed v80
[Xposed Framework Modules] vjtigas:
So I just saw this…

Can I use it with your module without breaking main functionality? Or can you implement this? Thank you so much!
[Xposed Framework Modules] Moiremoi:
I'm having the same probleme as describe here

Phone & App Info:

Xperia Z3 Compact 6.0.1 (MMB29M)

XPGM 1.8.2

GPM 6.3.2317

Xposed v80

Log (here)
[Xposed Framework Modules] jbarajasp:
This Module is AMAZING! Thank you for your fantastic work!

I would love to see the ability to reorder the my library tabs. I hate that Google makes you swipe right 3 times just to go from playlist to albums.

again, thanks for your great work!

-Jose
[Xposed Framework Modules] Caketray:
Old style notification doesn't work since latest GPM update

Since the latest update, setting 'use old notification design' does nothing
[Xposed Framework Modules] Maxr1998:
It could be possible to do this, but we might end up with two-column-no-pic as [MENTION=6320600]ban.codrut[/MENTION] says, if I don't add a custom layout. Let's see how complicated it is too build.

The only error I see in Xposed logs is a native crash of art because of "Too many files open", which seems rather strange, considering you have an Moto X Pure.. Could you try to grab me a logcat when it crashes? Take a look at catlog app on Play Store for that :)

Thanks for your reports and logs! I am currently trying to reduce the amount of loaded covers to prevent the crash, let's see where that takes me. Btw, congrats on your proper bug reports ;)

I installed and activated it, but it doesn't work, XMNTS takes precedence. I would look at the sources if they were open, now I have to reverse-engineer them to fix XMNTS for the seekbar.. *grumble*

Could you send me your Xposed logs?
[Xposed Framework Modules] Moiremoi:
Thank for your response!

Hope my logs are too in mess for you ^^
[Xposed Framework Modules] Maxr1998:
No, they're perfect :)

MediaFire also seems like a good logs provider, as it loads the logs rather smooth :D
[Xposed Framework Modules] teads:
got logcat installed, once my local files download, I'll try reinstalling the module and upload some logs
[Xposed Framework Modules] Maxr1998:
I uploaded version 1.8.3, changelog on first page :D

There is also a small update to the TrackSelector module.
[Xposed Framework Modules] teads:
This update has seemed to fix my issue. No errors, no issues at all. I'll keep logcat and if I have future issues I'll be sure to post here. Thanks for the amazing module!
[Xposed Framework Modules] Maxr1998:
Glad it works now. Thanks for your generous donation! Means a lot to me :) :3
[Xposed Framework Modules] aslefnad:
hi, i hope you can help me. i recently switched roms and since then xgpm won't work anymore. i did a clean install of the rom, did restore from google backup, installed xposed with framework 80 and xgpm. what i found strange is that all my settings that i had on my old rom were the same from the beginning. but it doesn't work. i wiped cache a couple of times reinstalled xgmp, xposed, google music, tried old versions of google music. is this maybe a common error and i did miss something? thanks very much for your help
[Xposed Framework Modules] davidfresh:
This is a great module.

Is it possible for us to choose the default tab for My Library? I browse by genre and it can be a real pain to swipe every time. Thank you!
[Xposed Framework Modules] SergioSanchezR:
[Bug report] -> XMediaNotificationtrackSelector

- If you know this error ignore this post.

- Problem: with android 5.1 systemui crash when i touch the playlist of the expanded notification.

- Logcat:

Process: com.android.systemui, PID: 18335
java.lang.NoSuchMethodError: android.widget.LinearLayout#removeLongPressCallback()#bestmatch
at de.robv.android.xposed.XposedHelpers.findMethodBestMatch(XposedHelpers.java:273)
at de.robv.android.xposed.XposedHelpers.findMethodBestMatch(XposedHelpers.java:286)
at de.robv.android.xposed.XposedHelpers.callMethod(XposedHelpers.java:949)
at de.Maxr1998.xposed.mnts.TrackSelector$1$3.onInterceptTouchEvent(TrackSelector.java:167)
at android.support.v7.widget.RecyclerView.dispatchOnItemTouchIntercept(RecyclerView.java:2161)
at android.support.v7.widget.RecyclerView.onInterceptTouchEvent(RecyclerView.java:2207)

- Tested with cm12.1 (crash) and cm13 (everything works).

- XMediaNotificationtrackSelector -> versionCode 4, versionName "1.1.2"

========================================================================================================

Improvement to make your module compatible with cm12 and maybe other versions:

- Pooject: XMediaNotificationtrackSelector

- Class: de.Maxr1998.xposed.mnts.TrackSelector

- Line: 163

- Original code:

queueLayout.addOnItemTouchListener(new RecyclerView.OnItemTouchListener() {
@Override
public boolean onInterceptTouchEvent(RecyclerView rv, MotionEvent e) {
ViewParent mScrollLayout = ....
...
}
});

- Improvement:

@Override
public boolean onInterceptTouchEvent(RecyclerView rv, MotionEvent e) {
ViewParent mScrollLayout = getStackScrollLayout(rv);

if (mScrollLayout == null) {
log("Precondition failed. Log error...");
return false;
}

mScrollLayout.requestDisallowInterceptTouchEvent(true);
callMethod(mScrollLayout, "removeLongPressCallback");
return false;
}

And

private static final String STACK_SCROLL_LAYOUT = "NotificationStackScrollLayout";
private static final int MAX_DEPTH_SCROLL_LAYOUT = 10;

private static ViewParent getStackScrollLayout(View initial) {
ViewParent current = initial.getParent();
int maxDepth = 0;

while (maxDepth++ < MAX_DEPTH_SCROLL_LAYOUT) {
if (current.getClass().toString().endsWith(STACK_SCROLL_LAYOUT))
return current;
current = current.getParent();
}

return null;
}

========================================================================================================

Congrats for your excelent work and have a nice day!
[Xposed Framework Modules] Maxr1998:
[MENTION=6374995]SergioSanchezR[/MENTION]

Thanks for your code improvements and suggestions, they're really appreciated! I will look at them in detail and report back tomorrow or Sunday, but for now, they seem very promising!
[Xposed Framework Modules] zippedexploit:
Working great on my S5 phone. Thanks! ^_^
[Xposed Framework Modules] RandomPooka:
This is why I love open source development. You guys rock.
[Xposed Framework Modules] 2skies:
I've been looking for something like this to modify GPM. I'd really like to configure the way my songs are displayed, and it would be great if this module could do that: is that in a scrollable list of artists, that when I tapped on one, all their songs would be listed under their respective albums in a scrollable list. With Google Play Music default, I have to tap artist, tap album, tap song OR tap artist, tap "all," then scroll to tap song. If I could eliminate that extra tap from "album" or "all," it'd be perfect! Is this possible?
[Xposed Framework Modules] Sirence:
Is it possible to set 3 column view for other pages such as playlists and stations?
[Xposed Framework Modules] skibijabadibi:
When I select "Show my library as default screen" I'm getting force close when trying to start Google play music app.

More info below:

https://drive.google.com/folderview?id=0B31AgImi0-nDRjhlMktndVlvUWs&usp=sharing

Thanks.

Wysłane z mojego SM-G900F przy użyciu Tapatalka
[Xposed Framework Modules] Maxr1998:
XGPM 1.8.4 released

I released XGPM 1.8.4 at the Xposed repo. Fixes support for GPM 1.8.4 and fixes another bug which [MENTION=2852658]skibijabadibi[/MENTION] pointed out.

====================================

Fixed, thanks. Expect a new release soon.

Sorry for being late, I was busy with school and my other app, and had not much time to look at your code. Now I did :p

I can't use your code as it stands, as your modification would only allow it work with GPM, but the TrackSelector supports other apps, for example Timber.

Means I can't use the application info solution. The layout id solution sounds quite promising though, and I will likely use it. I will still wait for your source code, as I can then choose the best solution ;)

I will try to improve the animations, thanks for your suggestion :)

And last, but not least, can you tell me which nav bar icons and weather notification you use? They look super awesome!

So you basically say you want to get straight to "all tracks from artist" when tapping the artist?

Sure, it's on my list :)
[Xposed Framework Modules] 2skies:
That's right! (Said much clearer than I did :p)
[Xposed Framework Modules] skibijabadibi:
Thank you for looking into my problem.

Unfortunately it's still crashing.

New catlog added ( 2016-02-22-12-45-44.txt ):

https://drive.google.com/folderview?id=0B31AgImi0-nDRjhlMktndVlvUWs&usp=sharing

Wysłane z mojego SM-G900F przy użyciu Tapatalka
[Xposed Framework Modules] 71hvh:
XGPM hide icon from launcher option are currently not working. Switching the option doesn't affect launcher icon.

Is there any option to disable playlist hamburger menu?
[Xposed Framework Modules] ibmiz:
I believe the module is not working with the current play music version. Any plans for an update?
[Xposed Framework Modules] Maxr1998:
That's so weird. I will take a look at it soon!

I know, I just don't get into fixing it. When working on XGPM, I'm most times busy fixing support with a new version..

You can hide playlist menu from settings.

Really? It's still working here. What version do you use? What doesn't work specifically? Could you share your Xposed logs?
[Xposed Framework Modules] ibmiz:
I'm using 1.8.4 running xposed framework version 80. The module itself as a whole is not changing anything such as the equaliser button or custom colours, old notification style. I don't know why it shouldn't work! I've attached my logs.
[Xposed Framework Modules] Maxr1998:
Well, your logs don't contain any errors, that's weird. Also, the module seems to be loaded fine. Idk why. Could you also tell me your GPM version?

At least, notification not working is caused by GPM notification progress module. But that shouldn't break colors or equalizer button.
[Xposed Framework Modules] ibmiz:
I'm running version 6.4.2417W.2625988 on the app.
[Xposed Framework Modules] Maxr1998:
So do I, it's still working fine. Could you reinstall the mod, enable it, reboot, pick your settings, reboot again, open GPM and then grab me Xposed logs and logcat?
[Xposed Framework Modules] ibmiz:
There's no need to as it works now!! I reinstalled the app as well to make sure and it started to work again. Thanks for your help!
[Xposed Framework Modules] Maxr1998:
Awesome, glad it works now! :)
[Xposed Framework Modules] aslefnad:
i want to reinstall xgpm because i have a few problems with it but for some reason after i delete it and reinstall all my settings are like before. are there some other files/folders I can delete to get a fresh start? thanks for your help