yashsingh1/xdaforums huggingface dataset:
[Samsung Galaxy Alpha] modpunk:
I've opened this thread that people know what I'm working on and developers can help to fix bugs. This works just fine with my sources. As you're using a ROM which I did not provide nor is based on the source code I developed during the last 8 month, please stop reporting bugs here ...
[Samsung Galaxy Alpha] sk0815:
Bugs:

1: If you use inductive charging it stopps after nearly 75%.

2: If the screen is locked, and the display is on, the sensor buttons are activ.

Only the home button should be activ.

---------- Post added at 03:52 PM ---------- Previous post was at 03:50 PM ----------

sorry it was for the one from KYASU

I thought it was your sources
[Samsung Galaxy Alpha] kyasu:
For keeping this thread clean, I will create a new thread for my build in this weekend. Please stop reporting bugs in this thread.
[Samsung Galaxy Alpha] modpunk:
The question still remains, why do you work on a fork and don't help to work on my codebase. I'm happy to assist, review patches and explain code ...
[Samsung Galaxy Alpha] bonuzzz:
Probably you had broken repo at that time

Anyway I published my work for one goal only: what I did to get lollipop kernel booting. As I see, It doesn't help you..
[Samsung Galaxy Alpha] line____:
why no one publish the cm 12.1 for public? :|
[Samsung Galaxy Alpha] modpunk:
You helped me in the way that the kernel was working for you but not for me. The lollipop kernel is booting for me too now. The reason was that I had an old bootloader which did not set androidboot.hardware=universal5430 in the kernel command line. So the init system didn't find the init script and stopped to finish booting.

However thanks for all your help and the patches you provided. They are all in my tree with your nick name ...
[Samsung Galaxy Alpha] modpunk:
I do not understand. All the sources are published for the public at:

https://git.cryptomilk.org/
[Samsung Galaxy Alpha] kyasu:
Because my tree is forked from bonuzzz's tree (thnak you [MENTION=242033]bonuzzz[/MENTION]) and very different from your tree. That is bonuzzz's tree is different from your tree.

I can only push a single jumbo patch that will reorganize your tree. This is not desirable.
[Samsung Galaxy Alpha] bonuzzz:
ownership doesn't make any sense for me, because I'm not programmer and I have my career in completely different area.

this is only a hobby. And I honestly say I dont have enough skills to solve hw decoding for example. And I try to solve most of issues here with experience of other people.

Yes, I agree with Kyasu. It's very difficult to make patche because of other structure.

I started to make cm for alpha and only after that I saw your topic and your work. I didn't have plans to say about it in public. At that time I thought main problems would be solved very soon
[Samsung Galaxy Alpha] modpunk:
I do not see why my tree needs to be reorganized. Comparing the sources of the HALs with your tree, mine seem to be much more complete.

Also maybe you can explain why you need a audioworkaround, my audio works just fine without it. And the same for the camerawrapper. The only thing I see you would need it for is to disable HDR.
[Samsung Galaxy Alpha] kyasu:
Your tree does not need to be reorganized. As I and bonuzzz explained, bonuzzz's tree differs from your tree. So my patch causes the unnecessary reorganization of your tree.

But I like bonuzzz's tree structure that is very similar to the official CM tree structure and it is easy to maintain.

See #162 and #196.

I'm not an expert of android and my tree is work in progress.

I honestly say I feel a strong stress to be forced to push a patch and explain a patch.

I just want to keep my dev as my style. My source is open. Please cherry-pick my patch if you want.

By the way, I found the audio recording bug in your audio HAL and I am fixing. So the next my build will be "ok google" and ok the audio/video recording. I think this patch will be also useful for you.
[Samsung Galaxy Alpha] kyasu:
I create a new thread for my build. Please report bugs in new thread.

http://xdaforums.com/galaxy-alpha/orig-development/5-1-x-cyanogenmod-12-1-unofficial-t3145217

As described in credits in new thread, I appreciate [MENTION=242033]bonuzzz[/MENTION] and [MENTION=4297219]modpunk[/MENTION].

Fix of the audio recording bug is here.

https://github.com/kyasu/android_device_samsung_slte/commit/df5743d37099ad87703e5221dd6b021bbf7acd2b
[Samsung Galaxy Alpha] Alberto96:
[MENTION=4297219]modpunk[/MENTION] : aren't kk 4.4.4 exynos5422 repositories more useful than older jb 4.2.2 exynos5420 ones?

https://github.com/codewalkerster/android_hardware_samsung_slsi_openmax/tree/5422_4.4.4_master

https://github.com/codewalkerster/android_hardware_samsung_slsi_exynos5422/tree/5422_4.4.4_master

https://github.com/codewalkerster/android_hardware_samsung_slsi_exynos5/tree/5422_4.4.4_master

https://github.com/codewalkerster/android_hardware_samsung_slsi_exynos/tree/5422_4.4.4_master

https://github.com/codewalkerster/android_vendor_samsung_slsi/tree/5422_4.4.4_master

Other repos including core patches can be found here: https://github.com/codewalkerster

ODROID-XU3 by HardKernel uses Exynos5422 CPU which is newer and probably more similar to Exynos5430. And most important, Exynos5422 uses Linux Kernel 3.10 as on Exynos5430 and not Linux Kernel 3.4.
[Samsung Galaxy Alpha] modpunk:
Awesome thanks. I will take a look ...
[Samsung Galaxy Alpha] modpunk:
The code really matches much more our device. I've already fixed most of the sources.
[Samsung Galaxy Alpha] Alberto96:
That's nice to hear. :)
[Samsung Galaxy Alpha] modpunk:
Thanks, it still doesn't fully compile cause the include patch need to be changed and the sources fixed that they compile correctly but I will get there.
[Samsung Galaxy Alpha] modpunk:
I've got it compiled and the new sources are running on my device. The seiren code works which is nice for hardware audio decoding. I also got the VP8 hardware decoder working but h264 fails with "Bad address". I need to find out what the kernel doesn't like.
[Samsung Galaxy Alpha] Alberto96:
Have you configured slte device repo as specified here? https://github.com/codewalkerster/android_device_hardkernel_odroidxu3-1/tree/cm-12.1_5422

media_codecs.xml & BoardConfig.mk
[Samsung Galaxy Alpha] modpunk:
Yes, changes can be found here: https://git.cryptomilk.org/projects/android/android_device_samsung_slte.git/log/?h=TESTING
[Samsung Galaxy Alpha] modpunk:
I've fixed libhwjpeg to match the latest Kernel changes, so there is no need for the binary blob. I've also pushed all the new repos. The next thing is to get h264 decoding working. After that I will look at video capturing. If I get it working, I will release a ROM.
[Samsung Galaxy Alpha] sphazer:
Fingers crossed
[Samsung Galaxy Alpha] gabrielking9:
Does this means that the camera quality is the same as stock?
[Samsung Galaxy Alpha] modpunk:
I've updated the TODO list. Video decoding and SELinux should at least work for a release ...
[Samsung Galaxy Alpha] Blubberor:
Cm12 has a General issue with Bluetooth music and lags coming from buffer overflow.

This is a General fix i found and it works. Maybe worth including it aa default?

http://xdaforums.com/showthread.php?t=2456073

https://www.androidfilehost.com/?fid=95916177934534153

Best and thanks,

blubberor
[Samsung Galaxy Alpha] modpunk:
If there are bugs why don't you report them to CM so that they get fixed for everyone?
[Samsung Galaxy Alpha] Blubberor:
This bug has been reported to CM team many times and did not get fixed.

so I started looking for a proper solution - thats the only working that I found up to now.

Best,

blubberor
[Samsung Galaxy Alpha] modpunk:
Can you post the link to the entry in the bugtracker?
[Samsung Galaxy Alpha] Blubberor:
I know this is no Github source....

e.g. here is the entry for one plus one.

https://jira.cyanogenmod.org/browse/BACON-3275

is valid for S4 as well (my brother in law uses this) and its in CM12 g850f sources from what I read this is really a general problem.

Maybe this is informative as well

http://forum.cyanogenmod.org/topic/103632-cm12-bluetooth-audio-issues/page__st__20

Best,

Blubberor
[Samsung Galaxy Alpha] lololololol:
I cant stand it any longer. Waiting so eagerly for news here...

So I havo to ask:

Is there any progress? Still somebody workin on our Galaxy Alpha?

Or is it the time for a new touchwiz-free device?

:confused:
[Samsung Galaxy Alpha] modpunk:
I did some fixes to the audio hal and currently try to get the open source h264 decoder working. I'm also working on sepolicy so that I can finally turn it into enforcing mode ...
[Samsung Galaxy Alpha] tileeq:
Just a reminder that if you can make this rom more stable that the other CM 12 posted on the forum there would be a donation on the way, a donation that i would gladly make.

Sent from my SM-G850F
[Samsung Galaxy Alpha] modpunk:
I would say it is more stable, because I work differently than others and I work together with other ROM developers. I do not release before the SELinux rules are complete ...
[Samsung Galaxy Alpha] tileeq:
My intention wanst to rush you, i do feel that you are working more steadilly and safer than the others and thats why im waiting for your release. I do have a feeling that you gonna make a boom with first one even from start.

Sent from my SM-G850F
[Samsung Galaxy Alpha] nuno.f.ferreira:
I've been using kyasu's published ROM for a few weeks and, except for the permissive SELinux and the BT's audio bug (that I believe it's more widespead), I'm very happy with it. I also acknowledge camera errors but, personaly, those do not really bother me much.

Having said that I would like to try your work and if I find time maybe even try my first contributions but there's been some months since I tried to build your tree. Was trying it again now and I have two questions:

1. I had this manual update. Is it still needed?

$ cd hardware/samsung_slsi/exynos5-insignal

$ git fetch http://review.cyanogenmod.org/CyanogenMod/android_hardware_samsung_slsi_exynos5-insignal refs/changes/65/78565/2 && git checkout FETCH_HEAD

2. A new repo sync throws this error. This has to do with the new CM recovery (I'm assuming I can still use TWRP)? Is there a new local manifest that I should use?

Fetching project omnirom/android_bootable_recovery

Retrying clone after deleting None

error: Cannot fetch omnirom/android_bootable_recovery (GitError: --force-sync not enabled; cannot overwrite a local work tree)

Fetching project CyanogenMod/android_external_arduino

Exception in thread Thread-197:

Traceback (most recent call last):

File "/usr/lib64/python2.6/threading.py", line 532, in __bootstrap_inner

self.run()

File "/usr/lib64/python2.6/threading.py", line 484, in run

self.__target(*self.__args, **self.__kwargs)

File "/opt/android/system/.repo/repo/subcmds/sync.py", line 254, in _FetchProjectList

success = self._FetchHelper(opt, project, *args, **kwargs)

File "/opt/android/system/.repo/repo/subcmds/sync.py", line 297, in _FetchHelper

optimized_fetch=opt.optimized_fetch)

File "/opt/android/system/.repo/repo/project.py", line 1144, in Sync_NetworkHalf

self._InitGitDir(force_sync=force_sync)

File "/opt/android/system/.repo/repo/project.py", line 2198, in _InitGitDir

raise e

GitError: --force-sync not enabled; cannot overwrite a local work tree

Thanks
[Samsung Galaxy Alpha] modpunk:
My ROM uses newer sources for the exynos, see the README in the TESTING branch ...

There are much more, I need a force sync for most of the repositories. This is either due to the git upgrade or something else ...
[Samsung Galaxy Alpha] modpunk:
RaymanFX and I got h264 video decoding working! The camera video recording works too but the colors are inverted. However this is the next big step!

I've also got the SELinux policy nearly done ...
[Samsung Galaxy Alpha] nuno.f.ferreira:
When you have SELinux policies ready and there's a fix for audio calls over bluetooth (car use-case) it's going to be party time :)
[Samsung Galaxy Alpha] nuno.f.ferreira:
I believe this problem is solved - http://xdaforums.com/showthread.php?p=62338314

[5.1.x][SM-G850F] CyanogenMod 12.1 UNOFFICIAL for the Galaxy Alpha (slte)

New version is up.<br />

After loooong debug efforts, finally I fixed the camera video recording bug (the inverted colors).<br />

The last major bug was fixed and I changed status from beta to stable.
[Samsung Galaxy Alpha] modpunk:
I have to check, RaymanFX and I are building the OMX codecs from sources and kyasu is using the binary blobs ....
[Samsung Galaxy Alpha] gabrielking9:
What is the difference between both?
[Samsung Galaxy Alpha] modpunk:
RaymanFX and I are using different sources. We are currently working with Ethan to get them upstream in CM. We also dissassembled the OMX blob to find out the correct values to get NV12 and NV21 video formats working correctly. The sources are newer and fix several bugs. We are getting there ...
[Samsung Galaxy Alpha] modpunk:
Video recording and video decoding are working now.

I've reduced [MENTION=4861355]kyasu[/MENTION] his patcheset to this change: http://review.cyanogenmod.org/#/c/106227/

It works with the OMX codecs compiled from the sources ...
[Samsung Galaxy Alpha] RobertAslan:
Not asking for an eta, but just wondering how long do you estimate it'll take to get cm working completly.

Just a rough estimate. Cuz I want cm as my daily

Not trying to rush you, I'm just tired of this touch****wizui.
[Samsung Galaxy Alpha] modpunk:
I will release a ROM soon. The camera is working now. Video decoding too. Just SELinux needs to be set to enforcing.
[Samsung Galaxy Alpha] modpunk:
I've added NFC support and cleaning up SELinux now. There is still one annoying bug that if you receive a phone call, the IncallUI needs ~20 seconds to come up ...
[Samsung Galaxy Alpha] gabrielking9:
Does cyanogenmod supports 1080@60fps and 720@120fps?
[Samsung Galaxy Alpha] Killbom:
Does the 20 second call screen happen every time?

Thinking about trying this rom out, if i can help in any way!
[Samsung Galaxy Alpha] modpunk:
Currently the issue is that we can switch from video recording to photo camera:

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 15057]
0xb6dbee30 in android::sp<android::CameraDeviceBase>::clear (this=this@entry=0xb3836574) at system/core/include/utils/StrongPointer.h:197
197 m_ptr->decStrong(this);
(gdb) bt
#0 0xb6dbee30 in android::sp<android::CameraDeviceBase>::clear (this=this@entry=0xb3836574) at system/core/include/utils/StrongPointer.h:197
#1 0xb6dc1a38 in android::CameraClient::disconnect (this=0xb3836520) at frameworks/av/services/camera/libcameraservice/api1/CameraClient.cpp:271
#2 0xb6b8bad8 in android::BnCamera::onTransact (this=0xb3836520, code=1, data=..., reply=0xb160aca4, flags=16) at frameworks/av/camera/ICamera.cpp:284
#3 0xb6e92c4a in android::BBinder::transact (this=0xb3836524, code=1, data=..., reply=0xb160aca4, flags=16) at frameworks/native/libs/binder/Binder.cpp:108
#4 0xb6e97c5c in android::IPCThreadState::executeCommand (this=this@entry=0xb5ab4a80, cmd=<optimized out>) at frameworks/native/libs/binder/IPCThreadState.cpp:1084
#5 0xb6e97d82 in android::IPCThreadState::getAndExecuteCommand (this=this@entry=0xb5ab4a80) at frameworks/native/libs/binder/IPCThreadState.cpp:435
#6 0xb6e97dc4 in android::IPCThreadState::joinThreadPool (this=0xb5ab4a80, isMain=<optimized out>) at frameworks/native/libs/binder/IPCThreadState.cpp:489
#7 0xb6e9bf3e in android::PoolThread::threadLoop (this=0xb5aa30d0) at frameworks/native/libs/binder/ProcessState.cpp:62
#8 0xb6c01fae in android::Thread::_threadLoop (user=0xb5aa30d0) at system/core/libutils/Threads.cpp:776
#9 0xb6c01b1e in thread_data_t::trampoline (t=<optimized out>) at system/core/libutils/Threads.cpp:101
#10 0xb6e1bef8 in __pthread_start (arg=0xb58a4280, arg@entry=<error reading variable: value has been optimized out>) at bionic/libc/bionic/pthread_create.cpp:141
#11 0xb6e19e40 in __start_thread (fn=<optimized out>, arg=<optimized out>) at bionic/libc/bionic/clone.cpp:41
#12 0x00000000 in ?? ()
(gdb) p m_ptr
$1 = (android::CameraDeviceBase *) 0xb3831340
(gdb) p *m_ptr
$2 = {<android::RefBase> = <invalid address>, _vptr.CameraDeviceBase = 0x17}

It looks like mHardware is invalid ...
[Samsung Galaxy Alpha] modpunk:
I think I got all SELinux policies set correctly now. I plan to turn SELinux into enforcing next week and release a first version of the ROM.

Knows bugs:

CAMERA: Switching from recording mode to camera crashes the App (invalid pointer)

CAMERA: The LL blob doesn't work cause of an invalid gralloc handle. We are stuck with KK blobs now

MEDIA: HEVC videos don't work

INCALL: The device needs 12-20 seconds to wake the screen on an incoming call

AUDIO RECORDING: Too quiet

VOIP: Not tested

BLUEOOTH: Headsets not tested

BLUETOOTH: CarKit not tested
[Samsung Galaxy Alpha] RobertAslan:
After you release the first version, will the next versions be update.zip files or will we have to reflash the entire rom?
[Samsung Galaxy Alpha] modpunk:
I do not plan to provide update zips. It is simple to just install a complete ROM. I've set SELinux to enforcing but there are still rules missing to get everything working.
[Samsung Galaxy Alpha] modpunk:
After some hours of more debuggging ...

[IMG="SELinux enforcing"]https://i.imgur.com/qUqC9LM.png[/IMG]
[Samsung Galaxy Alpha] tileeq:
I see on the pic that you are on 3g connection. Is 4g working ok?

Sent from my SM-G850F
[Samsung Galaxy Alpha] modpunk:
I guess so ...
[Samsung Galaxy Alpha] slg60:
Hey Modpunk, thanks for your hard work!

Will your rom, when you release it, be available officially @ CM or will this also be an unofficial one?
[Samsung Galaxy Alpha] leripe:
It doesn't yet meet the requirements for being official. Maybe some day.
[Samsung Galaxy Alpha] Ashareth:
What are (roughly) the requirements for being an "official" CM one ? Not using proprietary blobs/dll i guess ?
[Samsung Galaxy Alpha] leripe:
Well I don't know what they are but I know that at this stage we are not close to that point of being official. (It's freaking first release people.. :) )

Few examples: No major bugs, no major hacks, global interest on the phone, what cyanogenmod thinks about it and if the dev here even wants it to be official etc.

But these questions should go to the Q/A thread, not here!
[Samsung Galaxy Alpha] modpunk:
See the known bugs list, if this stuff is fixed I'm pretty sure they would accept my sources for an official build.
[Samsung Galaxy Alpha] Alberto96:
[MENTION=4297219]modpunk[/MENTION] : is SIM Toolkit (STK) working correctly on XMM7260 with actual RIL?
[Samsung Galaxy Alpha] modpunk:
I thought it was. I had the STK application but it is gone. So I think it doesn't work ...
[Samsung Galaxy Alpha] Alberto96:
Weird, here on XMM6360 (GT-I9500) it appears, but commands are corrupted/wrong, resulting in error messages from my mobile operator.

UPDATE: as far i remember, STK was working fine with Exynos4 RIL Class...
[Samsung Galaxy Alpha] modpunk:
The Note 4 got the first 5.1.1 release and a new kernel. This means we will get it too soon.
[Samsung Galaxy Alpha] gabrielking9:
Why two threads?
[Samsung Galaxy Alpha] modpunk:
This is a discussion about the source code and not about ready to flash ROM ...
[Samsung Galaxy Alpha] modpunk:
Looks like the slow IncallUI bringup when someone calls will be fixed soon:

http://review.cyanogenmod.org/#/q/status:open+branch:cm-12.1+topic:fastcall-redux
[Samsung Galaxy Alpha] nuno.f.ferreira:
Just to reiterate that I didn't felt that bug when I tested your latest ROM.
[Samsung Galaxy Alpha] modpunk:
But I'm running into the issue and this patchset looks like it will fix it.
[Samsung Galaxy Alpha] modpunk:
I've improved voice call quality. However I've wanted to know why we do not get informed about WB_AMR changes. So that we can detect if we want WB (Wideband) support.

Looking in the radio logs I've discovered that there is a sound manager which is issuing much higher UNSOL number than the radio codes. The radio commands have a base of 11000 but this is using 20000.

09-16 14:16:05.557 E/RILD ( 4025): SND-MGR: EVENT_WB_AMR_REPORT
09-16 14:16:05.557 E/RILD ( 4025): OnUnsolicitedResponse: unsolId: 20017
09-16 14:16:05.557 D/RILC ( 4025): SAMSUNG: unsolResponse=20017, unsolResponseIndex=9017
09-16 14:16:05.557 E/RILC ( 4025): unsupported unsolicited response code 20017
09-16 14:16:05.557 E/RILD ( 4025): Oem OnUnsolicitedResponse: response code=20017

09-16 14:16:05.571 E/RILD ( 4025): SND-MGR: EVENT_CLOCK_CTRL
09-16 14:16:05.571 E/RILD ( 4025): OnUnsolicitedResponse: unsolId: 20022
09-16 14:16:05.571 D/RILC ( 4025): SAMSUNG: unsolResponse=20022, unsolResponseIndex=9022
09-16 14:16:05.571 E/RILC ( 4025): unsupported unsolicited response code 20022
09-16 14:16:05.571 E/RILD ( 4025): Oem OnUnsolicitedResponse: response code=20022

libril needs to detect this and be able to run a request handler for it ...
[Samsung Galaxy Alpha] modpunk:
4232 09-16 16:36:47.911 V/audio_hw_primary( 4080): adev_set_wb_amr_callback: Turn on Incall Wide Band support

Yeah, phone calls with great sound quality are back :)
[Samsung Galaxy Alpha] nuno.f.ferreira:
Great stuff!! I'll try to build your tree and I might just keep it as my daily ROM, last time I tried it was the only blocker for me. Of course I still want car BT very much :)

Just one question, sorry for my ignorance. I understand you'll not be generating update zips for now but if I stick with this ROM I would like to avoid the full wipe+flash cycle. Assuming I'm successful at building your tree how hard is it to generate update zips? do you know of any online howto?

Thanks a lot!
[Samsung Galaxy Alpha] Blubberor:
I guess simple installing of latest builds works. At least for me in any cm build using in the past.

Looking forward to beta3 :)
[Samsung Galaxy Alpha] modpunk:
You do not have to wipe, you can simply install it over the previous one and that's it ...

However the audio improvements are not pushed yet. I need to clean up the code. You also need an upstream change or it will not work ...
[Samsung Galaxy Alpha] modpunk:
I can't really release beta3, because CM broke support for camera api version 1. The camera doesn't work ...
[Samsung Galaxy Alpha] modpunk:
Ok, it was my fault, building beta3 now ...
[Samsung Galaxy Alpha] Alberto96:
[MENTION=4297219]modpunk[/MENTION] : i'm testing your WB_AMR changes on i9500. I'll alert you if something goes wrong.
[Samsung Galaxy Alpha] modpunk:
Check the radio log 'adb logcat -b radio' for the SND-MGR and the 20017 unsol response before you start ...
[Samsung Galaxy Alpha] Alberto96:
Should i do it while on Stock?
[Samsung Galaxy Alpha] modpunk:
No, on CM. You see all the responses in the log, you should either see the standard RIL_UNSOL_WB_AMR_STATE or you will see 20017 as a unknown response ...
[Samsung Galaxy Alpha] gabrielking9:
With LL camera blobs nothing works(take picture, video rec..)?
[Samsung Galaxy Alpha] modpunk:
No, you can help debugging it if you have time ...
[Samsung Galaxy Alpha] modpunk:
The audio hal has code for noise_suppression which should be called by the Telephony framework. However this code is never triggered and so

ril_set_two_mic_control(&adev->ril, AUDIENCE, TWO_MIC_SOLUTION_ON);

is never triggered. With fixing this, I don't have any audio when doing a phone call. So I think I've triggered the phone state several people have ...

I was wrong. Fixed now. I still don't understand why Bluetooth has this weird sound ...
[Samsung Galaxy Alpha] modpunk:
Ok, bluetooth needs 8k as sampling rate. The sound is working, but not the bluetooth mic. We are getting there ...