yashsingh1/xdaforums huggingface dataset:
[Xposed General] mionica:
wrong ferror()

EDIT #2 Nope, this wasn't it - I was just lucky to get my change in the same build as the change that fixed it.

EDIT This was it; the next Xposed framework build isn't going to have the leaking files problem.

[i] waiting for boot to finish...
[i] > boot completed after 27s
[v]
[b][i] system_server has only [color=blue]270[/color] open files
[i] (and Xposed is installed)
[i] this probably means the fix is no longer required :)[/b]
[v]

[MENTION=4419114]rovo89[/MENTION]

Ummm, what does this code do? xposed_service.cpp, lines 765..769

[b][color=green] status_t err = ferror(f);[/color][/b]
[b] fclose(f);[/b]
if (errormsg) *errormsg = formatToString16("%s during fseek() to offset %d for %s", strerror(err), offset, filename);
[b] return [color=red]ferror(f)[/color];[/b]
}

I have no idea what calling ferror() on a closed file does, but I'm pretty sure you're not returning the value you mean to, which could potentially result in the flow going bananas after that point. Particularly if bionic clears the error flag to indicate that fclose() was successful - in that case you'd return success. Bad idea. Or, if fclose de-allocates the FILE struct, it gets better, you're calling ferror() on freed memory :)

May I suggest you change that to

if (errormsg) *errormsg = formatToString16("%s during fseek() to offset %d for %s", strerror(err), offset, filename);
[b] return [color=green]err[/color];[/b]

Pull request here.

:)

PS. If you cared to do a build with that fix, could you PM the .zip? I looked at everything file-related at https://github.com/rovo89/Xposed and this was the only thing I found amiss. I'd be inclined to give it a go; I'm running a script that says things like

...
[i] waiting for boot to finish...
[i] > boot completed after 26s
[v]
[b][i] system_server has 972 open files[/b]
[b][i] this probably means the fix is still required :([/b]
[Xposed General] uicnren:
any reason to update to alpha4 if there havent been any issues with alpha3 (that were fixed by alpha4) ?
[Xposed General] TheTeslaCoil:
What ?

Of course.
[Xposed General] gorankx:
If you have sony device then yes, read updates by yourself !
[Xposed General] billybag:
"alpha4 (20150430) is now available. It fixes bootloops and crashes on some ROMs, especially on Sony devices. In the logs, there used to be "Too many open files" errors."

hope that helps

http://xdaforums.com/showpost.php?p=60454533&postcount=9
[Xposed General] cocous:
Try anyone to G3?

Have again smart cover error?
[Xposed General] francwalter:
And where can I find the download of alpha 4?

In the advertisement of rovo89 there is no link or I don't see it. The start post neither shows alpha 4 but still alpha2.

Or is it just to inform that the work is going on but not intended to test the alpha4?
[Xposed General] ilos:
look the name of the file ....april 30

xposed-sdk21-arm-20150430.zip
[Xposed General] FuMMoD:
Don't use this alpha. You can't discern between an apk and a zip. You could seriously mess up your device. Read twice and flash once
[Xposed General] Pkt_Lnt:
Where it always is, even had today's date in the file description. :eek:
[Xposed General] HorstiG:
You only need to flash the ZIP again, the Xposed Installer app remains the same (and therefore still shows version alpha2)
[Xposed General] TheTeslaCoil:
The apk is still the same, Alpha2, don' t worry, the sdk is updated, no need to reinstall any apk, just flash the zip.

That' s the update.

...430.zip
[Xposed General] xlxcrossing:
I'm hearing rumblings of people getting xposed running on 5.1 roms at first boot. Anyone lucky enough? (Don't anyone dare tell me to go try every ROM and report back, I'm fine with waiting)?
[Xposed General] AstroBoy89:
Okay, so I've tried reading through some of the posts, but I can't find an answer. If I already have xposed-sdk alpha 2 installed, do I need to wipe anything or turn off any of the modules before installing the new alpha4? I don't want to screw something up and have to reflash everything. I usually end up wiping everything using adb and reflashing everything and that takes about 30 minutes to an hour and is a pain. Also, I can't find it anywhere, but would I be able to run this on 5.0.2? I'm not sure if much changed, but I would really like to get this up and running on my kindle fire HD 2012 running beanstalk :D

Please and thank you!
[Xposed General] FuMMoD:
There's a 5.1 discussion thread for that very reason. It's in the xposed boards here.
[Xposed General] xlxcrossing:
Im in a discussion thread being rerouted to a different discussion thread? Found it though. Linking would've been more "helpful" but I understand you ran out of silver spoons.
[Xposed General] JLoSD:
I have a G3 that's working great (with Smart Cover turned off/frozen via Titanium Backup). I'm on alpha2. If you were asking about alpha4, I haven't tried it yet.
[Xposed General] cocous:
I ask if works without disable the smart cover or any other.
[Xposed General] xantanion:
Perhaps try?
[Xposed General] auto-star:
When can my nexus 5 with 5.1 eat it
[Xposed General] francwalter:
Sorry! I really didn't think. I even had read that the installer didn't change.
[Xposed General] gorankx:
And this happens when people don't read but think they read something .............
[Xposed General] nithinte:
I have a moto g 5.02 rooted. How should I install xposed? What are the available modules? I tried to flash the .zip from another thread and it failed. :( Total noob here. Please guide
[Xposed General] AstroBoy89:
Instead of posting what you just posted, you could have given me an answer and then made your comment. Like I said, I've read the initial posts, the first few pages and a few of the pages before posting this, but I'm not sifting through 600+ pages to find a simple answer. I know how to flash, but I'm new to xposed (yeah I know I probably shouldn't be flashing alphas if I don't know what I'm doing, but I'm tired of the ridiculous wakelocks, especially *alarm*, which can't be amplified or disabled without reboots). I'd like to avoid performing a factory reset or having to wipe the device, but if that's what must be done, I'll do it. I'd just like a simple answer please and then you can bash me for posting in here :)
[Xposed General] Fra8:
still does not work for slimSaberLP
[Xposed General] awakener777:
Flashing fails for me. Twrp says something about SDK is 22 but should be 21, when clearly sdk21 is in the file name? Only happens on newer versions of cm12. It flashes fine on my 4/22 build.
[Xposed General] mielletseed:
"newer versions of cm12" are cm12.1 are android 5.1.x are using SDK 22 instead of SDK 21 of Android 5.0.x

So yes, all is right, the ZIP is for SDK 21 and is not compatible with SDK 22 of your "newer versions of cm12" ...
[Xposed General] ldeveraux:
Just try it out! Since you searched and couldn't find the answer, upgrade without disabling modules. If it doesn't work, post that and then everyone else will know how to do it properly:good:
[Xposed General] awakener777:
OK I didn't realize they changed to build to 12.1
[Xposed General] AstroBoy89:
I'm not a guinea pig...I have a feeling that I should disable modules before updating, but still, xposed changes system files around and it couldn't be as easy as flashing another zip on top of it. I probably won't make a backup. I'll flash the zip and If anything goes wrong, well, I'll probably just do a factory reset and see if xposed is removed. If it is I'll install alpha 4, if not then I'll use adb to wipe everything and reinstall everything from scratch. It'll take awhile, but I'd like to test as alpha 4 as I've come across an annoying bug with a module that causes static boxes to appear at the top of the screen. It has something to do with the one of four modules I'm running I think and causes the static to appear randomly even in apps that have no ads. I don't know if it will show up in a log though, but I'll paste it anyways when I get the chance. It could be the modules, xposed, or a combination of the two, but I'll just report on what I see.

Seriously though, if I can make a suggestion. I suggest adding how to install updates for xposed just so people like me don't have to ask questions here. I know the developer wants to keep the thread clean, so adding information concerning updates would be beneficial to everyone, especially xposed noobs like me :)
[Xposed General] 089man:
Hi [MENTION=4419114]rovo89[/MENTION], with newest build from you alpha 4, I have bootloops, also with build bevor. Only the build from März 03 month is working.

Have resurrection remix rom and Android 5 02. Cm 12 unofficial.

My device is Samsung galaxy s2.

Anybody knows a solution for other devices as Sonny?

Regards from Munich

I9100 Tapatalk, RR 5.0.2 Lollipop
[Xposed General] ldeveraux:
We're all guinea pigs! It's an alpha after all! :D
[Xposed General] dreamjaeil:
Yes please try and let us know! We will appreciate it
[Xposed General] MoBluey:
I got continuous fc's with smart cover but no FC's with weather although the weather app will fc if you try open it. So in other words that issue hasn't been solved yet tho keep in mind this is still alpha I'm sure [MENTION=4419114]rovo89[/MENTION] will have it sorted by the final release :)
[Xposed General] bdizzle1686:
I have Xposed working on my lollipop Samsung Galaxy S-HTC one m7.. ?????????????
[Xposed General] EuEra:
Working on stock samsung yet? S6 Edge
[Xposed General] commencal661:
Read post 1 & 2. Also follow the link in post 1 for all the information you need.
[Xposed General] zolaisugly:
Just want to say it's working on Sony z3 running lp no bootloops just installed gravity box module. One happy person again after lp update
[Xposed General] Basche:
Try it out and see, or you can use the search function and see if anyone else asked this before.
[Xposed General] Space_pilot:
Btw, there still need in editing XZDR prop file - set SE to true? Cause im still getting bootloops sometimes.
[Xposed General] UszkiX:
Can I install Xposed on Android 5.0.2 on LG G3S without recovery? It will work?
[Xposed General] Space_pilot:
U need recovery to flash sdk.
[Xposed General] UszkiX:
How to install recovery (TWRP or other) on my device?
[Xposed General] TheTeslaCoil:
Via adb. Or there is TWRP Manager in PlayStore.
[Xposed General] Space_pilot:
Check subforum for your device.
[Xposed General] UszkiX:
There isn't section for LG G3s on xds forum :(
[Xposed General] xantanion:
Look in the g3 forums that DO exsist on xda. Isn't hard to find.
[Xposed General] Smac89:
Question

So I just installed the zip file and everything started working again (flawlessly I should add). Now do I need to install the new installer apk as well? As of now the old apk I had before 5.0 is still installed and since everything seems to be working fine, I feel like going with the saying "if it ain't broke, don't fix it". What is your suggestion?
[Xposed General] cantenna:
**Latest xposed-sdk21-arm-20150430.zip results in a boot loop on Danvdh and Kryten GPE 5.0.1 rom. Flashing back Alpha 2 fixes all!
[Xposed General] ImADev:
Disable your modules, update and then if it boots try activating each module one by one.
[Xposed General] Oxious119:
Latest framework works great on my Nexus 4 running stock 5.0.1

Good job!
[Xposed General] mdamaged:
NM
[Xposed General] cantenna:
Thanks. I did, thought it was greenify beta at first but it turns out just sometimes it cause bootloop, sometimes it does not. having same experience with other modules as well. Guess modules need to be updated for Alpha4 or at least that seems to be the case with this ROM. Would love to know if anyone else is having this experience with this rom. Anyways, back to alpha 2 for now. Ill give it another month before I try alpha 4 again.
[Xposed General] bpdamas:
If you have a stock system backup, couldn't you just flash it, install a stock recovery, and then download and install the OTA like normal? Does xposed just modify the system partition?
[Xposed General] anthonyly:
Stupid qiuestion and can't find delete button
[Xposed General] kartiksood1:
hi all. i am looking for alpha 4 as mentioned in the op. have been searching for the download link since long time.. pls help to locate it.. thnx
[Xposed General] android404:
It's the thing called "xposed-sdk21-arm-20150430.zip" here http://xdaforums.com/showthread.php?t=3034811
[Xposed General] kartiksood1:
thanks for ur help bro.. much appreciated
[Xposed General] john1850208:
Yes
[Xposed General] UszkiX:
You can not throw Xposed to /system by the SD Maid without recovery?
[Xposed General] android404:
Give it a guess.
[Xposed General] mielletseed:
Don't think so since you have to replace system libraries and I think that's not possible while running the system.
[Xposed General] hinuk:
So far so good, i just flashed alpha4 and there haven't been any random reboots and it boots without the need to wipe cashe/dalvik cashe.

That previous fix had random reboots, when you installed any apps or updates it rebooted almost every time. So far with this alpha4 it hasn't had any reboots or other random problems.
[Xposed General] awesome274:
anyone test xposed framework alpha 4 on z2 .726 and 690 yet ?
[Xposed General] fervidtester:
Error executing updater binary to zip

After doing all the steps of advanced wipe and data and cache and all clean the framework is still not working on nexus 5 . Please help!!!
[Xposed General] hinuk:
I have it in z2 tablet 690 and it works fine, now if it would be working on stock Samsung roms without the need to flash it through a custom recovery i would be so happy...

I know I know it's just a alpha stage, but would it even be possible to get xposed to work without the need to flash it through the recovery. Or are those easy days gone with kitkat, would it even be possible to make xposed to be just a .apk install on lollipop.
[Xposed General] Ja_som:
Android version?
[Xposed General] Gotcher:
Are stock Samsung stock ROMs now supported with the newest version posted today? Has someone tried it on the S6?
[Xposed General] v7:
Try yourself and enjoy a bootloop.Do you think that with TW compaitability released,the thread supposed to be this quiet?

Tapped from my furious ZR ;)
[Xposed General] haseoxth:
Nope, if samsung stock get supported rovo will write in the post for sure.
[Xposed General] trahzebuck:
The framework from 30th ist running perfectly on Sony Z1 Stock .242. Generic German. Rooted of course. TY very much!
[Xposed General] 089man:
I'm happy with you. Only Sony users are happy and become an update. My device cm 12 unofficial with resurrection remix 5.3.9 Android 5 02 had bootloops since the last 2 updates. Only the old alpha 2 build from March is working fine here....

I9100 Tapatalk, RR 5.0.2 Lollipop
[Xposed General] k2828:
nevermind. i didnt read the faq
[Xposed General] Space_pilot:
Err: Found a bug - Fonter was causing bootloops. Uninstalled/Solved.
[Xposed General] TheTeslaCoil:
Nice photo.

Can you do another one?
[Xposed General] m1trand1r:
ROFL:D

/LG-G3/d-855/16Gb/Titanium Black/
[Xposed General] RedSkyRoad:
Where can I find "alpha 4" download? The original post only contains alpha 2
[Xposed General] TheTeslaCoil:
The sdk flashable zip is ''alpha4''

This one :

xposed-sdk21-arm-20150430.zip
[Xposed General] RedSkyRoad:
The Xposed app still says alpha 2 after flashing that zip. I need the alpha 4 APK.
[Xposed General] #sharath:
There is no alpha 4 apk, only the sdk zip is updated.
[Xposed General] .97:
No, apk is the same. You need only to flash Alpha 4 zip

from here: http://xdaforums.com/showthread.php?t=3034811
[Xposed General] bradgh:
where is the alpha 4 apk for downloading!! can i install alpha 4 on alpha 2!!

how disable xposed framework or unistall without clean flash!!

Sent from my D6633
[Xposed General] #sharath:
Xposed framework isn't for people who doesn't like reading.
[Xposed General] .97:
First of all:

1. alpha4 is here xposed-sdk21-arm-20150430.zip - http://xdaforums.com/attachment.php?attachmentid=3290173&d=1430421353

You can read this - http://xdaforums.com/showpost.php?p=60454533&postcount=9

2. Yes you only need to flash alpha 4 ZIP. APK is the same!
[Xposed General] bradgh:
I've read already . if you dont know how disable or unistall framework, you dont have answer people!!!!

Sent from my D6633
[Xposed General] thefiqs:
I will be happy as well with my locked bl. :(
[Xposed General] SpotTech:
I'm report an bug, some apps of play store aren't compatible with xposed....

ff legacy

facebook messenger

rayman all version

firefox
[Xposed General] TheTeslaCoil:
That is alpha4.

No matter is saying alpha2

The sdk = alpha4
[Xposed General] nidhish91:
Is alpha 4 compatible with Samsung roms?
[Xposed General] FuMMoD:
Your answer is in the first page......................
[Xposed General] NeoLogY:
Still not yet. Keep on asking next week, might get better luck.:D

Sent from here to there
[Xposed General] nidhish91:
I did and it said to check the other thread for updates and I couldnt find anything regarding Samsung devices on the latest update post hence asked.
[Xposed General] smooth 123:
In this Thread were can see Samsung owners are the most arrogantly user in the Android world [emoji27]
[Xposed General] hinuk:
I have unlockable but locked bl with dual recovery and rooted stock rom, at least with xperia z2 tablet you don't need to unlock your bootloader to get xposed to work.

Lähetetty minun SM-G900F laitteesta Tapatalkilla
[Xposed General] FuMMoD:
If there is no updated post regarding Samsung then there is no update. It's that simple. No one but rovo or an independent developer with the appropriate thread will update TW support. You'll know when it is posted in the read only thread or a separate alpha thread for TW is posted if any is posted.

No new post means no update. Simple
[Xposed General] pro-handler:
Im running on jellybean

Please help me fix this.....thank u
[Xposed General] madbat99:
Jellybean? This is lollipop only.
[Xposed General] mon5trum:
Man you are going to be torn apart!
[Xposed General] cobravnm13:
Bruh. This thread is for Xposed LOLLIPOP. Not Jellybean. You need to find the correct thread. Granted, your account is new, but you need to search for the right thread.

If I helped you please press Thanks!
[Xposed General] v7:
Find a way out of here.

Visit this

Download apk.

Install.

Reboot.

Eat something.

Sleep.

Tapped from my furious ZR ;)
[Xposed General] Hgneto:
are we close to a stable release?
[Xposed General] bBigBrO:
No, rovo89 told me that it will be posted the 32/2/2019

Sent from my Sony SmartWatch 3
[Xposed General] android404:
Nonsense

Edit: sent from my one and only Sony phone.
[Xposed General] m1trand1r:
nvm...missread post...

/LG-G3/d-855/16Gb/Titanium Black/
[Xposed General] RusherDude:
[MENTION=4419114]rovo89[/MENTION]

Thanks a lot for your hard work :)

One suggestion: I understand that you don't let the installer flash the zip so people has to accept this is an alpha and to go through recovery to flash it (a nice idea), but I don't understand why don't you let uninstall it (executing the simple script to rename and delete the xposed files and restore the originals) througt the app or the 5-touch method when booting.

It wouldn't make unexperienced people use it since they still won't be able to flash it the normal way, but people which is testing and reporting bugs will be able to test without needing to execute scripts or such in trwp or to restore nandroids just because something went wrong.

It is so much work to implement a small feature like this? even something like a feature that deletes the list of modules file at boot with touching events would be useful.

Thanks a lot!
[Xposed General] m1trand1r:
ummm....method of pressing hw keys during boot still works...else i'd be screwed the last day when I was testing Super alpha for 5.1.x ...so we have that easy method afaik:)

/LG-G3/d-855/16Gb/Titanium Black/
[Xposed General] RusherDude:
hw keys in boot doesn't work on the official alpha 4 (and didn't from alpha 1 to this point either). Maybe romracer implemented it on super alpha but it is not working on official alpha for 5.0.
[Xposed General] kaopho:
Work fine for me on my Xperia Z2 with stock Lollipop 5.0.2 AndroPlusKernel v53.
[Xposed General] Davey212:
Any Oneplus One 5.1.1+ nightlies feedback yet?

Currently running CM 12 5.1.1 nightlies on my OPO, curious to know if anyone has feedback on the alpha builds and 'stable' enough to use daily? I'll prob give it a shot and see. :cowboy:
[Xposed General] m1trand1r:
I never had to use hw keys on alpha1 but I don't know if [MENTION=2476451]romracer[/MENTION] implemented that...it wasn't mentioned anywhere ...at least I didn't notice that...I was pushing volume down in my case when bootanimation appeared ...and then as always...one vibration ...then on another press again and 4 times then it went vibrating long one and rom booted with disabled framework ....I can restore my 5.0.2 nandroid where I have official alpha 2 or 3 installed if you wish so to confirm or drop your statement ..;)

/LG-G3/d-855/16Gb/Titanium Black/
[Xposed General] RusherDude:
If you could test on stock alpha if it works it would be awesome (don't do it if its much hassle), I just re-tested rebooting and there is 0 vibrations when pressing vol up or vol down, even spamming them didn't do anything and xposed booted as normally :(.
[Xposed General] m1trand1r:
Wait a bit please...I've just done huge amount of work with my new 5.1.1 setup....I.need to nandroid that first as it's awesomeness ....than i'll restore my 5.0.2 and test that...ok?...

C'ya soon....:)

EDIT: Ok mate i'm back and button press method works here....proof is under spoiler just to save some space...and i'm currently on crippled 5.0.2 due to disabled xposed lol[emoji14]

have a look:

now I'm gonna go back to awesomeness :D

/LG-G3/d-855/16Gb/Titanium Black/
[Xposed General] RusherDude:
Thanks a lot for testing! :fingers-crossed::fingers-crossed:

I flashed alpha1 and it doesn't work either, I think that something is interfering on it on my N5 (maybe its ElementalX kernel or its multirom injection, or maybe there's another incompatibility??)

Also, just creating the "disabled" file works? I remember that at some point it was said that this didn't work anymore (the reason why the old zip flashable doesn't work). It is reallt working for u? :eek:

Thanks!! :laugh::good:
[Xposed General] smknutson:
If you're having a bad day, I highly recommend you read at least the last five pages.

Turned my frown upside down...

LoL

This thread has become my go-to for laughs
[Xposed General] m1trand1r:
you shouldn't even post what you did....just keep on ROFL....bud...:)

/LG-G3/d-855/16Gb/Titanium Black/
[Xposed General] Pkt_Lnt:
This was addressed by rovo in post 3 of the official thread.
[Xposed General] Rix70:
Hi

I don't know guys but on my m7 the better version is alpha 2..

On 3 and 4 version xtended setting sometime stops work... for fix I have to open xtended and turn off and back on the mod...

That happened frequently :(

Obviously I go back alpha 2 but don't understand if this issue is only on my phone (M7 5.0.2 - sense 7)

Thanks
[Xposed General] m1trand1r:
logs would be nice move if you could provide 'em....

/LG-G3/d-855/16Gb/Titanium Black/
[Xposed General] flexxoo:
Is easy to say that when you don't have a Samsung phone cause if you will you would it be the same way so please don't start!!
[Xposed General] TheTeslaCoil:
Tell that to SAMSUNG and KNOX.
[Xposed General] RusherDude:
He said that he didn't have time at that point, and it was 19th February 2015, 10:48 AM. Right now he cleared a lot of bugs, and finished making his tools to compile and such faster. Maybe it's the moment for that :fingers-crossed:
[Xposed General] Pkt_Lnt:
The fact that he has not done it after mentioning it tells you it is not time, at least in his opinion. He asked someone else do it, why don't you if you want it so bad instead of trying to coerce him into it?
[Xposed General] RusherDude:
If you notice, he was asking if someone could do a zip executable and such, which got done a month ago. I am asking him to integrate those functions into the official app and such, which is different :good:
[Xposed General] aHecticLife:
Delete