yashsingh1/xdaforums huggingface dataset:
[Xiaomi Redmi 1S] eminem47:
Sir Can You Upload A Zip Already Enabled Music Mode Can't Get To Set The Mode Values
[Xiaomi Redmi 1S] Zeehan:
guys Im on mokee rom.

I just wanted to try out the new kernels

knowing that it won't be of any use even if I flash on mokee, so yes flashed cody kernel, nothing happened.

like the kernel version in the settings page still showed builder@xiangshan#1, so I flashed the new R15, after that cleared cache and dalvik, then flashed the cody kernel, but still the kernel in use was of jsevi's not cody.

and this happens to almost all the kernels put up here on XDA, the extreme, even the Angsa kernel. none of them showed that they are in use in my settings page.

but all went well when I installed them from recovery which is philz touch, the latest one.

what am I doing wrong?

am I using the wrong recovery?

and I tried the same with TWRP too. still the same thing.

basically the kernel which comes with the rom is always in use even if I successfully flash other kernels :/
[Xiaomi Redmi 1S] Zeehan:
nevermind guys, figured out where I went wrong.

didn't put the kernels in the root of my storage.

LOL'ing so hard at myself now.
[Xiaomi Redmi 1S] bilakos10:
I see that the developer has implemented a fix for dt2w allowing the phone not to sleep.

This should solve the issue with the phone not waking on double tap.

Any feedback concerning the above feature as well as dt2w?
[Xiaomi Redmi 1S] dixan43:
dt2s not working mostly.. works once or twice..or maybe randomly..but sweep to sleep over the nav bar works..problem is with double tap to wake
[Xiaomi Redmi 1S] wffarrel:
01-15-2015 ver

Still unable to d2d or s2w during deep sleep just reporting here.

Thank you
[Xiaomi Redmi 1S] kuldeepraj:
Anybody using this kernel in carbon rc5?

Wants to try it in carbon now using beast kernel.
[Xiaomi Redmi 1S] MaCrocy:
This kernel is compatible with CyanogenMod 11.0 R16?
[Xiaomi Redmi 1S] dixan43:
otg not working after flashing this kernel.. any idea on wat to do?
[Xiaomi Redmi 1S] dixan43:
dt2w works within 5 seconds of locking or turning screen off.. after that i think it goes in deep sleep that dt2w cant wake screen..
[Xiaomi Redmi 1S] thewisenerd:
hi,

will let the screenshot do the talking.

getting the display working on stock ROM was easy peasy, though hard to find.

anyways, could someone lend a hand with helping fix WiFi and stuff?
[Xiaomi Redmi 1S] Luffy.d:
great work....for wifi will pm you
[Xiaomi Redmi 1S] teddy0804:
a new hope episode has just arrived for MIUI lover... :victory:
[Xiaomi Redmi 1S] thewisenerd:
i hope the same.

as I said before, display fix was easy peasy, but difficult to find. so, what was the patch?

diff --git a/drivers/video/msm/mdss/mdss_mdp_overlay.c b/drivers/video/msm/mdss/mdss_mdp_overlay.c
index 82dc31c..f3e236c 100644
--- a/drivers/video/msm/mdss/mdss_mdp_overlay.c
+++ b/drivers/video/msm/mdss/mdss_mdp_overlay.c
@@ -2179,6 +2179,8 @@ static int mdss_mdp_overlay_ioctl_handler(struct msm_fb_data_type *mfd,
break;

case MSMFB_OVERLAY_SET:
+	case 0xc1b06d87:
+
ret = copy_from_user(&req, argp, sizeof(req));
if (!ret) {
ret = mdss_mdp_overlay_set(mfd, &req);

what exactly is 0xc1b06d87?

the problem with the kernel sources is zero. the problem is that the stock ROM either has updated binaries, or outdated binaries, either one of the them. So, when IOCTL function not implemented was the error, i checkpointed entire kernel (the parts that mattered), and found that MSMFB_OVERLAY_SET ioctl pointed out to this place, but instead of both kernel && hwcomposer sources being in sync, they both had different values for MSMFB_OVERLAY_SET.

so, just 0xc1b06d87? nothing else?

no. i still get some errors in dmesg. which means some more ioctls are different. all of that needs to be logged, and added appropriately in kernel, to completely support stock.

yay, so stock kernel, here i come!?

no. not that early. i've been working on trying to get wifi working for the past one day, without any success. xiaomi's libhardware legacy has a patch for appending mac=<macaddr> to the load_module syscall args (similar to this: https://github.com/MoKee/android_hardware_libhardware_legacy/blob/5861490931876db12a1a899c340dac08d4479521/wifi/wifi.c#L173 && what was being used in CM for quite some time). Even though I hackishly removed the "mac=" since it was giving unknown parameter error, i can't get the wlan.ko module loaded. it gives following error:

<4>[ 22.708365] wlan: module is from the staging directory, the quality is unknown, you have been warned.
<6>[ 23.900841] param 0x3
<6>[ 23.900851] cold

So, i have literally no idea how to get wifi working now. someone get wifi working && this patch would be of use.
[Xiaomi Redmi 1S] ranit:
Stops working after some time after locking

Hi, I think there is a problem... Double tap stops working if we keep the device for a long time and I need to use key to unlock the device...

Thanks for your awesome work
[Xiaomi Redmi 1S] Mohanshbhr:
[MENTION=4869275]thewisenerd[/MENTION] is there any progress of this kernel with miui rom.
[Xiaomi Redmi 1S] thewisenerd:
26Jan2015

- Asynchronous Fsync: initial extraction of Async Fsync from HTC (credits to Paul Reioux)

- fs/dyn_sync_cntrl: dynamic sync control (credits to Paul Reioux)

- block: add BFQ-v6-3.4 (credits to Paolo Valente)

- overall_stats: add overall stats for all available cores (credits to faux123)

- cpufreq: add intelliactive (credits to Paul Reioux)

- add Sound Control 3.2 (credits to Paul Reioux)

- Input: Send events one packet at a time (credits to Henrik Rydberg)

- powersuspend: new PM kernel driver for Android w/o early_suspend (credits to Paul Reioux)

- add intelli_thermal (credits to Paul Reioux)

- intelli_plug: add an intelligent hotplug cpu driver with eco mode (credits to Paul Reioux)

- drivers: input: touchscreen: imagis: add prevent_sleep functionality

- drivers: input: touchscreen: gt9xx: add prevent_sleep functionality

- drivers: input: touchscreen: s2w && dt2w: enable support for ist30xx_ts and Goodix-CTP touch panels

Download

: http://www.mediafire.com/download/kiq7cfvpmbxpqfg/output_26_Jan_2015-g6e12f86-00403-g0c4b2a6.zip
[Xiaomi Redmi 1S] teddy0804:
hi, thanks for the new update. i will try it

is the new update really give a new hope for MIUI lover? :cool:
[Xiaomi Redmi 1S] thewisenerd:
Do not try the kernel on MiUi. It WILL be stuck at bootloop. And, I will not fully support stock ROM till I can find a fix for WiFi.

Current kernel is for CM11 RC #16
[Xiaomi Redmi 1S] bhu1:
I have been meaning to try this kernel, was waiting for an update. Will try now. Thank you.
[Xiaomi Redmi 1S] bilakos10:
Looking at the changelog, i believe DT2W should have been fixed...

Please report back!
[Xiaomi Redmi 1S] sinnerz2000:
Just installed the kernel, dt2w worked even after a minute after phone was locked will check for a longer period. But the issue is touch suspend fix during calls isn't implemented, please add this fix.
[Xiaomi Redmi 1S] thewisenerd:
I rebased my changes with cm-11.0 branch of armani-dev kernel. The fix is already included.

P.s. congo. You might have *not* a focaltech touchscreen, so, i might need to rework that patch for imagis and goodix TS panels if necessary.
[Xiaomi Redmi 1S] sinnerz2000:
I did not get the second part of your reply [emoji53] So you mean there are different touch panels for different 1s's?
[Xiaomi Redmi 1S] thewisenerd:
OFC. So do I think. Reason why dt2w and s2w didn't work for half the people out there, and reason why xiaomi added/enabled two other touch panel sources (viz. Imagis and goodix) in their "xiaomi changes" patch.
[Xiaomi Redmi 1S] SH3H1:
How can we check which one is ours?
[Xiaomi Redmi 1S] sinnerz2000:
Oh makes sense. BTW I've been using my phone all day now and dt2w hasn't failed on me yet, its rock stable now [emoji16]
[Xiaomi Redmi 1S] thewisenerd:
IKR... Because it was wierd having people saying DT2W don't work, S2W don't work, when it works for me everytime, whether or not the phone's in deep sleep.

Usually with the logs. Or you could also use the sysfs files to figure out which one is yours. One of them reads the name of the input firmware.

Edit: I've searched the sysfs and found the file for you.

su
cat /proc/bus/input/devices

This shows all the input devices. The touch panel is usually the first one on the list. Eitherways, you can search for the input device with the name that matches any one of the following:

ft5x06
ist30xx_ts
Goodix-CTP

ft5x06: focaltech. Ours is FT5306, because it falls in 4.3" - 7" range. datasheet:

orig site downloads: http://www.focaltech-systems.com/En/down.aspx (but asks for login)

so, I found another: http://www.newhavendisplay.com/app_notes/FT5x06.pdf

ist30xx_ts: imagis/imagix. idk. didn't search much. didn't find much.

Goodix-CTP: ours is a 9xx series. didn't find a datasheet though.

-------------

BTW, those using gt9xx panels (i.e. Goodix-CTP) (ctp: capacitive touch panel), are in for a real treat. It seems that the panel has inbuilt support for Sweep2Wake && DoubleTap2Wake. So, upon deciding to investigate, I found out that they were just a subset of their 'Gesture Support', inbuilt in the touchscreen firmware. This means that they can have these features (S2W, DT2W, and some more, i.e. gesture support) at an ultra-low power consumption with almost no effect on battery life.

moar info here: http://www.goodix.com/Products/touchscreen-chip-for-mobilepho/smart-wake-up/

note: since I do not have a Goodix CTP, I cannot possibly test these features. So, I would require a tester.

--------------

ft5x06: well, whattdya know. the very panel I own. todo: use monitor mode instead of active mode while screen off, && s2w/dt2w. more details about active mode, && hibernate mode: pg 2 && 3 of datasheet.
[Xiaomi Redmi 1S] bilakos10:
Lucky bastards! 600uA current while not touching the screen.

My monitor on the other hand is the same with your's...!

So different panels is the reason why the dt2w implementation is broken on the other kernels!

Nice finds & nice job done!
[Xiaomi Redmi 1S] sinnerz2000:
Damn, I have the ft5x06 too.
[Xiaomi Redmi 1S] pradumnk.mahanta:
The best one till now I guess...!!

well it rocks, everything is perfectly working except the in call touch issue. it works sometimes and the touch is disabled but sometimes i end up opening random apps. Any way will stick to this for now, I know you will fix everything. Thanks dev.
[Xiaomi Redmi 1S] SH3H1:
Feel good bro that you have the same hw as the dev :D

Me too ft5x06

(But ultra low power consumption is :eek: )
[Xiaomi Redmi 1S] Picvajzmen:
Sorry for my noobishnes, but is there a way to check which screen do i have without the adb and the computer?:rolleyes:
[Xiaomi Redmi 1S] bilakos10:
Just download terminal emulator and run the commands given!
[Xiaomi Redmi 1S] sinnerz2000:
If your phone is rooted then follow that path given in the previous posts by OP through a root file explorer
[Xiaomi Redmi 1S] Picvajzmen:
Tnx friend. I have the ft5x06 also..
[Xiaomi Redmi 1S] Mohanshbhr:
Dt2w is working perfect for me. i have a noob question, does dt2w function affects touch panel life?
[Xiaomi Redmi 1S] sinnerz2000:
Probably since the touch panel is active all the time, its similar to saying that overclocking your CPU will decrease its life.
[Xiaomi Redmi 1S] userprince:
Hello [MENTION=4869275]thewisenerd[/MENTION] ,

I have a wired issue with all Xiaomi Kernel maybe there is some issue in the source itself i have a game controller which perfectly works on Samung phone and micromax but it don't work on Redmi 1S and Mi3. i thought maybe you can figure out if some drivers or etc thing is missing

By The Way implementing:

1. Faux App control in your kernel is great.

2. D2W is working flawlessly.

3. Sound output is super loud.

Thanks for such a good kernel :good: :victory:
[Xiaomi Redmi 1S] SandeepEmekar:
[MENTION=4869275]thewisenerd[/MENTION]

Thanks for the smoothest kernel ever for Redmi 1S.

Can you tell me why Voice Call Time in Battery stats is equal to stand by time?

Is it because touchscreen is not fixed for call?
[Xiaomi Redmi 1S] Picvajzmen:
it wont work on R17, only on R16 and down.
[Xiaomi Redmi 1S] travarilo:
The simplest way to do is installing TricksterMod on PS..

You can manage dt2w easily.. :)
[Xiaomi Redmi 1S] manuhackzzz:
happy to help

http://en.miui.com/thread-79280-1-1.html

here is what you need
[Xiaomi Redmi 1S] thewisenerd:
17Feb2015

- drivers: input: ts: doubletap2wake: bump version to 1.4

- drivers: input: ts: sweep2wake: bump version to 1.5.7

- [exp]drivers: input: ts: s2w: Add keypad S2W for Redmi 1S (armani)

- drivers: input: ts: ft5x06: use monitor mode with CONFIG_TOUCHSCREEN_PREVENT_SLEEP

- drivers: input: ts: s2w: don't use musiqmod on the navbar

- Fix Goodix panel drivers as well (credits to zeroblade1984)

- ft5x06:Fix notifier for suspend (credits to zeroblade1984)

Download

: http://www.mediafire.com/download/hy6m501mcf96544/output_17_Feb_2015-g6e12f86-00410-g51b3c8b.zip
[Xiaomi Redmi 1S] sinnerz2000:
Hey did you implement changes from the 14th Feb kernel of armani Dev or the latest test4 17th Feb kernel? The earlier one was draining battery.
[Xiaomi Redmi 1S] thewisenerd:
RC16 only for now...

Ain't got much time for rebasing my changes.
[Xiaomi Redmi 1S] sinnerz2000:
Moving back to R16 then [emoji106]
[Xiaomi Redmi 1S] bilakos10:
Make sure to give feedback about the battery life as well as the new keypad s2w feature...!
[Xiaomi Redmi 1S] travarilo:
I got random reboot twice so I back to the previous version..
[Xiaomi Redmi 1S] thewisenerd:
commit notes of keypad s2w

from here: https://github.com/thewisenerd/android_kernel_xiaomi_armani/commit/f75da4e0026c554c599d6933b3055af63c7a0516
[Xiaomi Redmi 1S] sinnerz2000:
Battery seems to be OK for now, but I'm getting crashes when I change the governor , I changed it twice once after 2 reboots the phone was stuck in bootloop and I had to reflash, I don't know about the keypad s2w feature but will try it.
[Xiaomi Redmi 1S] thewisenerd:
new MusiqMod layout

-------------------------------------

| volume zone |

| swipe right: vol up |

| swipe left: vol down |

| |

|-----------------------------------| // _Y_B1 (300)

| | | |

| | | |

| | | |

| prev | pause/ | next |

| song | play | song |

| | | |

| | | |

| | | |

| | | |

| | | |

|-----------------------------------| // _Y_B2 ( _Y_LIMIT - 300 )

| track zone |

| swipe right: next song |

| swipe left: prev song |

| |

-------------------------------------

| |

_X_B1 (200) _X_B2 (_X_MAX - 200)

thought so.. xda messed this up.

new layout for musiqmod; coming soon.

un-messed version here (in commit message): https://github.com/thewisenerd/android_kernel_xiaomi_armani/commit/7674cd32ed22d8a1f3e4924c25bc739ec39f772e
[Xiaomi Redmi 1S] sinnerz2000:
Battery life is great, please fix reboots while changing governors and add OC GPU.
[Xiaomi Redmi 1S] sharan.nyn:
Questions

I used this kernel on CM11 r16

I had turned on DT2W and S2W settings too. But phone drained about 7% overnight. I have the ft5x06 panel too does this mean I will have some discharge if I enable the DT2W and S2W?

Also I use TricksterMod to control the kernel but there is MP-Decision and Intelli-Plug, I can turn on both. Should I keep the both on or just use the Intelli-Plug?

The gesture posted here :https://github.com/thewisenerd/android_kernel_xiaomi_armani/commit/7674cd32ed22d8a1f3e4924c25bc739ec39f772e

does it work on feb17 build? I'm excited to use the music controls ;)
[Xiaomi Redmi 1S] thewisenerd:
1. Yes, the panel would be on 24x07 if S2W or DT2W is turned on. But now, I've modified the _suspend, _resume code so as to put the panel from _ACTIVE mode (~ 6 mA power consumption), to _MONITOR mode (~ 3-4 mA power consumption), (not much, but hey!?).

A much better way to work things out, would be to use the proximity sensor to 'detect' if any obstruction is present and turn off the touch panel accordingly. Thus, if the phone is flipped, or placed in a pocket, etc, the touch panel would be disabled automatically. The 'problem' with that is: how exactly would you turn the phone on? The 'only' way to do so then would be to use the power button (which I hate to), or to run a kernel_thread in the background that checks for proximity sensor every 5 seconds or so (which might lead to battery drain). And, so, I've decided to go with the former, and I'm planning to run a proximity check ~5s 'after' the screen is turned off, and if the sensor detects an 'obstacle', the panel would be turned off. And it needs to be manually turned on later. (though I think running a thread wouldn't take up much battery *constant consumption at ~4 mA > every 5s consumption of 2 mA or so, depending upon the prox sensor) (but all of it would need to wait for testing.

2. you cannot technically keep them both on. either mpdecision or intelliplug. go with both of them, see which one of them suits you, and use it.

3. those gestures posted are just an announcement. they are ready, but I haven't released the builds yet. as of now, I'm working on porting all of my advancements with the S2W and DT2W back for my old phone, the HTC Pico (Explorer), with a k3.0.101 (not that I use it much these days, but hey! simply chutzpah.)
[Xiaomi Redmi 1S] sharan.nyn:
Thanks for the detailed reply :)

You could see the gravity screen app it works by using the proximity sensor. I don't know it might help you in some way ;)

I turned both the DT2W and S2W off , because I always end up pressing the power button. It's like muscle memory lol

Sent from my Transformer TF101
[Xiaomi Redmi 1S] gopalmishra:
Not Working On CM-11-R18

I tried this on the recent CM-11-R18 built but my device stucked on the MI logo. Hope it will be supported soon! And thanks for the awesome kernel!
[Xiaomi Redmi 1S] saurabhrck:
Anyone using it with pac rom latest nightly?
[Xiaomi Redmi 1S] sinnerz2000:
What have u done to the battery life?? My SOT is 3.5hrs so far and my battery is still 50%. This is crazy
[Xiaomi Redmi 1S] dipanjanforever:
doubletap2wake music mode

what exactly is doubletap2wake music mode!!
[Xiaomi Redmi 1S] bilakos10:
Hey please post your battery stats...! Are you using the dt2w and s2w features?
[Xiaomi Redmi 1S] sinnerz2000:
I just shifted to R19, I was using only dt2w.
[Xiaomi Redmi 1S] saurabhrck:
Please release the kernel for r19! thank you!
[Xiaomi Redmi 1S] bilakos10:
[MENTION=4869275]thewisenerd[/MENTION] is the one of the few developers I know of that offers that much detailed answers on every of his replys.Being able to actively communicate with the developer is such a great thing :D
[Xiaomi Redmi 1S] thewisenerd:
test build for r19: http://www.mediafire.com/download/9gjpe72vzz6u2cw/output_20_Feb_2015-g8640b1a-06503-gf72762a.zip (tag names are messed up, will fix that up later)

changes included: s2w(showp1984), dt2w(showp1984), msm_thermal(franco), intelliactive(faux123), powersuspend(Yank555.lu), SoundControl(faux123), async(HTC), bfq(v7r7) (all s2w, dt2w changes, new musiqmod layout included) (yes, msm_thermal by franco, and changes for armani by zeroblade, they;re awesome; and from the feedback, i've taken a.. 'leap of faith') (ondemand governor by default, instead of intelliactive in kernel, intelliactive in 80_cPanel)

i'm working with zeroblade on getting msm_hotplug (by myfluxi) working, and then will run some comparison tests on battery life, etc, and will decide whether or not to make the switch.

note: this is *not* an official release; just a test build.
[Xiaomi Redmi 1S] saurabhrck:
thanx. I will flash it now! And will report back! Just a question, is this synced with armani-dev's latest kernel updates with the latest caf update?
[Xiaomi Redmi 1S] dipanjanforever:
[MENTION=4869275]thewisenerd[/MENTION] thnx man for the quick reply...... kudos
[Xiaomi Redmi 1S] thewisenerd:
Yes, lnx.la.3.5.1.10xxx tag and changes from armani-dev.

cm-11.0-cts3 on my github.

CTS: close to stock (in this case, armani-dev sources).

current kk branch will be replaced with it as soon as I figure out why hotplug isn't working.
[Xiaomi Redmi 1S] AmartyaLive:
Hey man, I'm running RC 17. I looked at the changelog but couldn't find if the stable release is compatible with RC 17.

Also is this kernel backward compatible for older releases of CM on the armani.

Thank you so much again for bringing tap2wake to us. I really love it on the G2 and eagerly waiting to use it on the 1S too
[Xiaomi Redmi 1S] bilakos10:
No its not compatible with R17.

Just jump over to R19 and flash the latest test build...
[Xiaomi Redmi 1S] dipanjanforever:
Conservative Governor

i always use Conservative Governor in my devices ... after flashing the new kernel version i've noticed opposite trait in this govornor .... as per defination "This biases the phone to prefer the lowest possible clockspeed as often as possible. In other words, a larger and more persistent load must be placed on the CPU before the conservative governor will be prompted to raise the CPU clockspeed. " ... bt now my phone every time stuck at max cpu speed which is 1401 in my case .

---------- Post added at 02:41 PM ---------- Previous post was at 02:38 PM ----------

@bilakos10 is 17Feb2015 built is compatible with r19??
[Xiaomi Redmi 1S] saurabhrck:
thnx for the info. But I faced an issue. The thing is, due to dt2w when ever a min touch was on the screen it was waking the device. may it be while holding the phone, or putting in the pocket or pulling out. due to this, the screen was waking too much and the battery was draining. and I tried to turn off the dt2w via touchscreen control in performance control app. but its not working. other than that the kernel was good.

Please look into this. Will wait for proper fix and update!

greetings!
[Xiaomi Redmi 1S] dipanjanforever:
TRUE... same issue
[Xiaomi Redmi 1S] thewisenerd:
please note that it is virtually impossible for me to support every kernel tuning app available out there, and the only possible solution for me is to write and maintain a synapse configuration.

i'm working on it, and its in its inception, and with due course of time, will see the light of day.

until then, you can use the terminal emulator to type in commands (given in post #2) after obtaining superuser permission using the command 'su'.

regards.
[Xiaomi Redmi 1S] dipanjanforever:
20th feb test built working properly with R19
[Xiaomi Redmi 1S] militantmind:
Use Kernel Audiutor in configurating kernel parameters
[Xiaomi Redmi 1S] saurabhrck:
thnx for the info. I forgot to chk the op! I made a Init.d script to turn off all touchscreen controls on boot for now!
[Xiaomi Redmi 1S] thewisenerd:
i've tried to get myfluxi's hotplug implementation working from today morning 6:00 am IST along with zeroblade (its 0:15 AM of the next day btw), and yet, we have no clue why it doesn't work from my PC (it works for zeroblade though; same code, same toolchain).

so, i'll be sticking with intelliplug for now.

thus, feature list for release:

s2w(showp1984), dt2w(showp1984), intelli_plug(faux123), msm_thermal(franco), intelliactive(faux123), powersuspend(Yank555.lu), SoundControl(faux123), async(HTC), bfq(v7r7)

from now on, my kernels would be as much CTS as possible (CTS: close to stock). that way, i won't be introducing any new bugs that might break userspace which I dread doing.

p.s. anyone interested in the release already, build it from the cm-11.0-cts7 branch in my github.
[Xiaomi Redmi 1S] AmartyaLive:
Noob with a noob question here.

I find dt2w wakes the phone even in my pocket.

Could a check from proximity be enabled before dt2w wakes the screen?

I know better than to request features from a great dev but I'd just want your opinion if this could be implemented somehow
[Xiaomi Redmi 1S] sinnerz2000:
Read previous posts from the dev
[Xiaomi Redmi 1S] AmartyaLive:
I did but didn't find anything regarding this..... I found one post about the proximity issue in call, and that was solved supposedly. I don't use the in call speaker at all since I have mine connected through a watch to my Bluetooth headset.

Getting back to point though... I didn't find any solution for this problem
[Xiaomi Redmi 1S] neonkat:
Overnight battery drain issue....20 feb kernel.....on r19....