yashsingh1/xdaforums huggingface dataset:
[ONE Android Development] tobitege:
Putting on my (non-linux) developer hat for a moment, here's how I'd approach the information at hand, just as

a thought experiment, not as an expectation to recode anything. :)

Most likely the extra fs_type comparison in "fs_mgr/fs_mgr.c" (line 364-368) is the "culprit".

By all means, the check itself sounds sane and reasonable on its own...

So, all of our 3 partitions (system/data/cache) are within the same block device "/dev/block/mmcblk0p28", which

obviously should be "f2fs" for a 3P setup (execute "blkid" in terminal).

The code then checks if the block device's fs_type is the same as the one of the currently processed fstab entry.

Unfortunately, if it early exits the loop, it is not logging it as an error or anything, but just skips the current fstab entry.

IMHO the error we run into with this code commit, it looks only like dealing with a symptom, not the cause.

What do I mean with that? From the code in the listed commits, the above check is the only change that

influences the program flow (leaving out any potential issues with included libraries).

If the check skips an fstab entry (in our case it's supposedly "cache", right?) and thus the partition stays unmounted

(and breaks boot), I'd deduce from that, that the partition in question is in fact not formatted with the right type,

i.e. it still is (or gets reported as) ext4 and not f2fs.

Sorry for the brain dump, only had one coffee this morning. :D
[ONE Android Development] brunes:
Followed this suggestion to wipe /system only and repartition as ext4, now running 6.5 nice and smooth so far! Thanks!
[ONE Android Development] phermey:
thanks [MENTION=4164878]smint86[/MENTION] for the upload..

it looks like the multi-task bugs have been fixed.
[ONE Android Development] smint86:
v6.6 linaro f2fs-mixed (2P): https://www.androidfilehost.com/?fid=95916177934520101

md5: 2ae57a5343a073ad9d4e3edbdc9f021b

(only primary, no multirom)
[ONE Android Development] gnan10:
Mann...... you two guys are making this thread even more awesome. love you guys. :laugh: :laugh: :D

flashaholics can enjoy your uploads well
[ONE Android Development] fabryx92:
I'm trying to update my current zhapod-sm-5.9-2p-f2fs rom with one of the subsequents smint86 or phermey rom update, but all cause me a bootloop. :(

I try to wipe/format /system, to wipe cache and dalvik/art cache, to install again firmware, to flash ak kernel before first boot. Nothing!
[ONE Android Development] phermey:
Once I had to just install the ROM. And boot. Then I was able to install AK on top.
[ONE Android Development] fabryx92:
I know, I've already tried all possible combinations of what I wrote above, with no results. :confused:
[ONE Android Development] azsl1326:
Last resort, you can try reformatting the partitions and then do a clean install. I had a similar issue and that's the only thing that worked.
[ONE Android Development] :
Is your recovery current? Did you make sure mtp is disabled if it is connected to a computer?
[ONE Android Development] katinatez:
Which recovery? Philz is not capable of flashing firmware yet. Testing an updated Philz recovery that will do this. Try twrp to flash firmware
[ONE Android Development] fabryx92:
I had already updated the firmware with your Philz Recovery, and it seemed that everything went correctly. I successfully update to 5.9 version, that require firmare update.

Whatever, I'm trying to repeat the process, updating the firmware using TWRP recovery.
[ONE Android Development] phermey:
you shouldn't have to update that firmware after the first time.
[ONE Android Development] fabryx92:
I know, but i wanted to try.

So, for now i always have a bootloop. I think that the only solution is clean install.
[ONE Android Development] smint86:
I'd really try TWRP 2.4.8.1 unofficial by [MENTION=3814731]katinatez[/MENTION]. Or try his updated PhilZ (thanks [MENTION=4877142]tobitege[/MENTION] ;)).
[ONE Android Development] tobitege:
ahh... newest Philz is already released today :)
[ONE Android Development] D0M1N13:
Where ??
[ONE Android Development] tobitege:
See signature link of [MENTION=3814731]katinatez[/MENTION] for recoveries
[ONE Android Development] D0M1N13:
The link if broken for the firmware file. :(
[ONE Android Development] tobitege:
[MENTION=5165679]D0M1N13[/MENTION]: please remove the full OP quote, against etiquette ;)

See Misc folder: https://www.androidfilehost.com/?w=files&flid=19647
[ONE Android Development] D0M1N13:
Sorry ! Understand. :)
[ONE Android Development] Genericxx:
This is actually a general issue on all CyanogenMod based ROMS, since CM updated some blobs and camera libraries yesterday which render CameraNext currently unusable. Should be fixed soon, meanwhile just take Google Camera, which is reported to just work fine.
[ONE Android Development] Ideas4ya:
Hey what is the best way to update this ROM? I'm on v1.9 on my primary multirom slot. I've downloaded 2.0 but do I have to wipe everything and reinstall all my apps?
[ONE Android Development] Genericxx:
Just read OP...
[ONE Android Development] Ideas4ya:
Yea...the OP says nothing about updating the ROM, plus I'm using Ark Kernel.
[ONE Android Development] Guido83:
temsek has fixed the camera in 2.1 :)
[ONE Android Development] USHAM2:
Can someone post more screenshots of this ROM? I'm currently running C5 with AK.035 and bpear GaPPS with hardly any issues other than the standard CM12 (GPS status icon and Navi button LED delay on screen-lock). I would like to try this ROM & f2fs, but not sold on it yet.

Someone needs to sell me on it :) :)
[ONE Android Development] temasek:
[MENTION=3874152]zaphodbeeb[/MENTION]

See PM
[ONE Android Development] ek69:
Just wondering if you asked temasek that he is OK with this? I was reading in another device temasek thread that he only had one Dev per device, and katinatez seems to be his Dev for bacon?

I'm not trying to offend anyone here [emoji40]

Also, any users try both and notice any major difference in speed or anything?

Sent From Bacon
[ONE Android Development] Ideas4ya:
I do not feel a difference with CM12. But, I've flashed this rom and Blitz on EXT4 and F2FS using Ark Kernel (same settings). I've noticed the boot time is longer with F2FS but no other notable differences on how the rom actually feels. This could be due to the continued development of CM12 as well. I don't think we will get accurate benchmark scores on CM12 until we start to get some release copies...But with Blitz and this rom as well, I get 2k-3k higher benchmark scores on F2FS.

This is just my experience...anyone feel free to chime in if their experience is a bit different.
[ONE Android Development] otisman:
Could be wrong but open source means open or close lol
[ONE Android Development] Striatum_bdr:
[MENTION=2332422]temasek[/MENTION] i use your roms since a long time but I must disagree totally with you. Your work is open source, you can't prevent someone to build it. There is no intellectual property theft, as the Rom's name isn't changed.

It's the same when you take sources from many other roms and build your own ! How can you deny this guy the right to do what you're actually doing...

Credits are properly written, in fact OP should have renamed the Rom, like all people here are doing.

I don't see the rational here of your demand, and I hope no mod will follow you.
[ONE Android Development] iscraigh:
Temasek i use you ROM compiled by katinatez and enjoy your work. CM's work is open source and you use it, AOSP you use also. I do not use this ROM but credit is given and the modifications made do not merit a new name. I guess you could copyright the name or close source your mods. This Rom adds a convenience that you were not offering. I for one appreciate it. I use multirom and would love a multirom version of all lollipop Rom's, I use AK's kernel nice to not have to flash it. You can not build upon others work without allowing others to build upon yours.
[ONE Android Development] nicholaschum:
Slapping on a different kernel, adjusting it's F2FS parameters and putting an updater-script that works for multirom, all in all is a great package, but it doesn't justify to ANY change/use of temasek's source code at all.

There was no "true" source tweaking, only change in updater-script, boot.img (using this guide) and adding ak's kernel into the installer. Everything else was kept stock.

Just imagine zephiK posting a Mahdi version EVERY SINGLE TIME Mahdi updated his ROM, with SmoothScrollingMod automatically installed, and on a new thread. He didn't do that, but instead, allowed for people to do so themselves. Yes, I understand this is easier when someone else does it for you, but if you want to post even a mirror of the dev's work, you have to get permission - this is an explicit rule on XDA (Rule 12. Using the work of others.) -->

Now don't get me wrong, I understand the true intentions of the OP here, and that the Open Source License gives you permission to expand your work.

If you want to build your F2FS, multirom, AK built Temasek ROM, that's fine, name it something else, credit, and ask for permission for pulling unique tweaks to post publicly. However, a person with 70k thanks, is seeing a person who kanged his ROM without his permission, even though is legal through Open Source Licensing, does not abide by XDA rules and regulations - and now is getting "disagreed" by people.

By joining XDA, you abide by these rules, even when things don't seem to be "illegal", you're on XDA grounds, and this is what it is.
[ONE Android Development] otisman:
And this why there should be an age requirement! The rules makes no sense open but you need permission or Free if you ask but cost a dollar same thing! Nice quote of rules look up and tell temasek it will be OK lol! Plan and simple close your source!
[ONE Android Development] zaphodbeeb:
Permissions, opensource and all that stuff

Hi all,

Im going to put the publication of any further f2fs work on hold for the current. I have requested some clarification of the XDA rules with regards the legality of reusing opensource software, and obtaining permissions to reuse this in the XDA forum. It may be that I will have to continue by hosting this elsewhere to continue, but I hope not.

All got a little heavy for my liking really. It takes a good bit time to mod and test this f2fs work before publication with each release. I intend to carry on doing this, but dont want to have to expend so much of my remaining time exploring legalities etc.

No offence was intended, and I apologise if I have offended. All credits go to the original devs, from Cyanogenmod and on. All I was trying to do was to share, and save other f2fs oneplus users a little time out of their day. I do this for myself each time new versions are issued. Just thought it would be good to share.

One last point. Thank you to all those who have expressed support and interest in this. Appreciated.
[ONE Android Development] störte:
I know how difficult it is as i try to do it myself. At the moment i am failing so i decided to return for the time being to ext4 as i like to test a few Rom.

Thank you very much for the help making my life easier.
[ONE Android Development] katinatez:
From the very begining I have supported f2fs starting with all my recoveries, and continuing with temasek rom. I know it's time consuming to convert to a f2fs ready to flash rom. [MENTION=3874152]zaphodbeeb[/MENTION] has my permission to continue his work and I will send all potential f2fs users to this thread.

Here is the latest release changelog

http://xdaforums.com/showpost.php?p=57405177&postcount=1617

zaphodbeeb will be releasing the f2fs version soon, all development question regarding temasek will continue on my thread, all f2fs questions will be replied by zaphodbeeb or thread users.

Enjoy :D
[ONE Android Development] otisman:
Much alohas katinatez for looking out and working with zaphodbeeb
[ONE Android Development] Rycon33:
Nice, like what they say, "all is well that ends well" .??
[ONE Android Development] otisman:
Ain't that the truth back to f2fs lol
[ONE Android Development] clutterking:
Love this ROM, thanks for all the hard work guys.

Is anyone else having an issue with wifi disconnecting after long periods with the screen off? Every morning my phone is switched to mobile data which I need to manually switch off than on to get it to reconnect to my home network. Thanks in advance.
[ONE Android Development] smint86:
Thanks for the ultra fast 6.8 2p ln version [MENTION=3874152]zaphodbeeb[/MENTION] :)
[ONE Android Development] Jole7:
Can we wait F2FS ALL updates? I see there are some problems till now. Great Thread!!!
[ONE Android Development] zaphodbeeb:
Not on the radar for the moment. f2fs-mixed s working fine.
[ONE Android Development] phermey:
this is not happening to me. although there do seem to be a lot of bugs that weren't around a week ago. the best place to find out is on the temasek unofficial thread by katinatez.
[ONE Android Development] fabryx92:
Finally I can update the rom. With zhapod new release, dirty flash work perfectly unlike smint and phermey releases!
[ONE Android Development] smint86:
Makes me wonder. It would be interesting, why it is like that. I'm flashing my own builds since v5.4, always dirty, no problems. Also, in the end the builds should not differ at all. But in the end it's good, that it works for you now :).
[ONE Android Development] AtAM1:
No issues installing zaphodbeeb or smint86's roms - clean or dirty flash! Hoping for a 6.9 sabermod 2p-F2FS release soon :) Keep it up and thanks for your effort and time.
[ONE Android Development] phermey:
here is the sabermod. i stuck on the new cm12 boot. it is kinda meh. wish it would restart instead of just pulsing. maybe i can figure out how to make that work. maybe not.
[ONE Android Development] AtAM1:
I wish I could help you out but I am only flashing [MENTION=3874152]zaphodbeeb[/MENTION] and [MENTION=4164878]smint86[/MENTION] 2P-SM builds - is this your first time flashing cm12? if so, did you update your firmware first?
[ONE Android Development] tobitege:
[MENTION=4164878]smint86[/MENTION] / [MENTION=4584934]phermey[/MENTION]

Hey guys,

would either of you mind sharing your local_manifests/roomservice.xml? Preferrably the linaro one?

I'd like to do a test build to figure an issue out.

Thanks a lot in advance! :D
[ONE Android Development] smint86:
Where exactly do I find it? On my desktop pc, lubuntu?
[ONE Android Development] tobitege:
On your build machine, lubuntu? It's within hidden ".repo" folder, forgot to mention that, so ".repo/local_manifests/roomservice.xml".
[ONE Android Development] smint86:
Yeah... a little bit embarrassing, but I haven't set up a build machine (yet). I'm using lubuntu, but never built on my own. Only a little bit scripting, editing, adb stuff and things like that. Always wanted to intensify that, but time is too short atm. Sorry...
[ONE Android Development] tobitege:
[MENTION=4164878]smint86[/MENTION]: ok, no problem, I had thought you were already building. :)
[ONE Android Development] phermey:
nothing wrong with the build. i added the new cyanogen boot animation to it. the new boot animation is kinda meh.

---------- Post added at 09:44 AM ---------- Previous post was at 09:38 AM ----------

katinatez gave me the info i need to start building. but i am having issues installing arch linux on my machine. it doesn't want to be loaded from usb, and my dvd drive no longer works. since arch has different commands, the info he gave me will not transfer straight over to ubuntu. quite the pickle.
[ONE Android Development] phermey:
here is the sabermod 7.0 2p-primary build.

changelog now found in >about phone >changelog

on a side note. anyone else notice how much faster the camera seems to be at taking shots? it seems like auto is a touch faster to send over to the gallery, but hdr and clear image seems to have shaved a second off. i haven't taken an hdr or clear image shot in quite a while because it was so slow. so maybe it has been like that for a couple of weeks and i just never noticed.

i just pulled an 49,824. maybe in another update or three, i will hit that 50k mark again. :)
[ONE Android Development] gnan10:
Other than AK kernel. Is there any good kernels for f2fs builds?

Please tell me
[ONE Android Development] phermey:
i just use the stock kernel. it is pretty quick. and decent on battery life. katinatez has used the tyr kernel on his sabermod builds before. it was also pretty good.
[ONE Android Development] Guido83:
I have just made the linaro version of 7.0-linaro-2p-f2fs-primary
[ONE Android Development] zaphodbeeb:
Because only f2fs-mixed (2p) is currently working with Katinatez rom the only change needed in the "stock" updater-script is to change the following line.

mount("ext4", "EMMC", "/dev/block/platform/msm_sdcc.1/by-name/userdata", "/data", "");

to

mount("f2fs", "EMMC", "/dev/block/platform/msm_sdcc.1/by-name/userdata", "/data", "");

Also, you can now use the new fstab which will enable the kernel(s) to work in either 2p or 3p configurations when/if the current problems with system f2fs is fixed.

# Android fstab file.
#<src> <mnt_point> <type> <mnt_flags and options> <fs_mgr_flags>
# The filesystem that contains the filesystem checker binary (typically /system) cannot
# specify MF_CHECK, and must come before any filesystems that do specify MF_CHECK

/dev/block/platform/msm_sdcc.1/by-name/system /system ext4 ro,barrier=1 wait
/dev/block/platform/msm_sdcc.1/by-name/system /system f2fs ro,noatime,nosuid,nodev,discard,nodiratime,inline_xattr,errors=recover wait
/dev/block/platform/msm_sdcc.1/by-name/userdata /data ext4 noatime,nosuid,nodev,barrier=1,data=ordered,noauto_da_alloc,errors=panic wait,check,encryptable=/dev/block/platform/msm_sdcc.1/by-name/reserve4
/dev/block/platform/msm_sdcc.1/by-name/userdata /data f2fs noatime,nosuid,nodev,discard,nodiratime,inline_xattr,errors=recover wait,nonremovable,encryptable=/dev/block/platform/msm_sdcc.1/by-name/reserve4
/dev/block/platform/msm_sdcc.1/by-name/cache /cache ext4 noatime,nosuid,nodev,barrier=1,data=ordered,noauto_da_alloc,errors=panic wait,check
/dev/block/platform/msm_sdcc.1/by-name/cache /cache f2fs noatime,nosuid,nodev,discard,nodiratime,inline_xattr,errors=recover wait
/dev/block/platform/msm_sdcc.1/by-name/persist /persist ext4 nosuid,nodev,barrier=1,data=ordered,nodelalloc,nomblk_io_submit,errors=panic wait,check
/dev/block/platform/msm_sdcc.1/by-name/boot /boot emmc defaults defaults
/dev/block/platform/msm_sdcc.1/by-name/recovery /recovery emmc defaults defaults
/dev/block/platform/msm_sdcc.1/by-name/misc /misc emmc defaults defaults
/dev/block/platform/msm_sdcc.1/by-name/modem /firmware vfat ro,shortname=lower,uid=1000,gid=1000,dmask=227,fmask=337,context=u:object_r:firmware_file:s0 wait

/devices/platform/xhci-hcd auto vfat defaults voldmanaged=usbdisk:auto
[ONE Android Development] byAidan:
Latest version is running great as always, thanks for sharing these so fast! :)
[ONE Android Development] f41lbl0g:
I downloaded the latest temasek update, but when I change the "ext4" to "f2fs" it is stuck on the boot animation. Do I have to change the fstab as well? I am using 2p configuration.
[ONE Android Development] phermey:
yes. the fstab has to be changed also. if using windows... scroll up and go step for step on my guide. you can use the different code you quoted from zaphod... but you do not have to. Zaphod's guide on it, using ubuntu, is post #453. that is pg16 on my browser. i am using the old way. but both work just the same for the 2p rom.
[ONE Android Development] f41lbl0g:
If I change it from ext4 to f2fs in the updater script is it sufficient enough to be able to mount it properly? Instead of using busybox commands?
[ONE Android Development] phermey:
the 7.5.1 ln and sm are uploading. 7.5.1 sm and ln 2p primary

---------- Post added at 07:09 PM ---------- Previous post was at 07:07 PM ----------

i have not tried it yet. i am sure it will.

video guide on the conversion process.

http://youtu.be/Hwz7aIayrt8?list=UUZyQxm7nDVpmf8RekAOjHzw
[ONE Android Development] zaphodbeeb:
yes
[ONE Android Development] phermey:
i don't want to hijack this thread at all.... but i just got done converting the new stock rom to our 2p format. since this is really the only 2p thread around... i figured i would put it here for yall to try out. it is pretty dad gum snappy.

enjoy

zaphod - if this is considered disrespectful, just let me know.
[ONE Android Development] tobitege:
I'd call it friendly assistance to help out. Just my 2 cents. ;)
[ONE Android Development] zaphodbeeb:
No prob mate. All good stuff.;)
[ONE Android Development] DominiCOne:
Bootloop with the 7.7 linaro... Sabermod is OK
[ONE Android Development] zaphodbeeb:
Apologies,

fixed version uploading now.
[ONE Android Development] DominiCOne:
No problem zapho :)
[ONE Android Development] smint86:
Added v7.7 (second version) Linaro (2P/f2fs-mixed): smint86-temasek-bacon-ln-7.7_v2-2P-f2fs.zip
[ONE Android Development] zaphodbeeb:
Thanks for the heads up. I didnt realise that Temaseks rom had changed. Damn this feeble body requiring sleep!! Anyhow I updated both versions in the op. Hope you dont mind, but I re made these myself instead of using your version. Its just that I know what Im supporting then. I dont want to put you off uploading your versions, thanks for doing that, as it provides service to those that want it quicker. Just didnt like the idea of replaced versions in the OP.;)
[ONE Android Development] smint86:
Temasek Linaro & Sabermod v7.8 (2P/f2fs-mixed) uploaded:

smint86-temasek-bacon-ln-7.8-2P-f2fs.zip

smint86-temasek-bacon-sm-7.8-2P-f2fs.zip
[ONE Android Development] DominiCOne:
MaxxAudio seems to cause a lot of problems either on Linaro or Sabermod :(

But find the solution on Katinatez thread :)
[ONE Android Development] clutterking:
Anyone else have trouble flashing 7.8?
[ONE Android Development] smint86:
Did work without problems for me. What exactly is your problem?
[ONE Android Development] DominiCOne:
Check this http://xdaforums.com/showpost.php?p=58920580&postcount=7933
[ONE Android Development] M5devil:
Don't know if anyone notices, but I see slight increase in scroll lag on 7.8 and Antutu dropped from 49K to 44K. Don't really care about the score, but lag is noticeable. I flashed for the first time AK kernel 119 as opposed to staying on stock before. Maybe this could be the reason. I know there are tweaked profiles for Synapse. Any care to share so I can see if that changes anything? Thanks!
[ONE Android Development] smint86:
You could check this thread, various profiles and configs for AK kernel are shared here: http://xdaforums.com/oneplus-one/general/ak-kernel-profile-synapse-t2858674

Besides that, there are multiple posts to fine tune settings in the official AK kernel thread. You could search for "interactive" for example, there are several posts about fine tune the governor.
[ONE Android Development] DominiCOne:
I use OmegaBlaze profile on the last ak Kernel => http://xdaforums.com/showpost.php?p=58976618&postcount=755
[ONE Android Development] smint86:
Temasek Linaro & Sabermod v7.9 (2P/f2fs-mixed) uploaded:

smint86-temasek-bacon-ln-7.9-2P-f2fs.zip

smint86-temasek-bacon-sm-7.9-2P-f2fs.zip (with AK kernel included by [MENTION=3814731]katinatez[/MENTION])
[ONE Android Development] DominiCOne:
Damn you're quick :D
[ONE Android Development] c8503:
I've been intermittently reading the thread (mostly just grabbing the latest SM build). What was the issue with 3P / is it fixed? I thought 3p has faster boot times so curious if there's any future for 3p.

ty to Smint for staying on top of katinatez's releases.
[ONE Android Development] M5devil:
Thank you! I'm also seeing fast battery drain on this build. It's 2 pm took it out of charge at 7 am and already at 46%. Less than 2hr SOT. Didn't have this on previous builds and I did fresh install. Hoping 7.9 will be better