yashsingh1/xdaforums huggingface dataset:
[Galaxy Note 4 Unified Development] twistedumbrella:
Note: Discussing the process of developing on xda is just as much kernel dev 101 as makefiles and kconfigs.
[Galaxy Note 4 Unified Development] friedrich420:
absolutely!!

i call it our "unsupervised group development therapy"- there's no therapist and the group decides on its own what issue to tackle ;)
[Galaxy Note 4 Unified Development] :
Following this thread from the day it opened and really have learnt a lot from you guys. I'm certainly not a dev maybe a chef at a push but totally agree with your comments about abuse, you give something for free and yet people still complain. I was talking with the eteam about it only 2 of them want to stay on xda the rest like friedrichs idea of creating thier own forum. Personally I think the dev section of xda should be a subscription service maybe that would get rid of the trolls with multiple accounts
[Galaxy Note 4 Unified Development] friedrich420:
[MENTION=593514]twistedumbrella[/MENTION] about LED Brightness Control (and fading i guess) am i way off in thinking that this could work?

https://github.com/friedrich420/S4-...mmit/3f4a6d5a784c744b3f1d9005bca70fd46fd008da

i just tried it.. i dont get all the sysfs options like with the s4.. so i cant control brightness...

I also have this (from note 3) but i dont even know where to begin trying to backport it..

https://github.com/friedrich420/Not...mmit/54a40e6ab58120193bfac87f9f6a9e8c65aadf7e
[Galaxy Note 4 Unified Development] twistedumbrella:
I don't usually laugh out loud when I lol. Who does? I have never had to fake it with you. And now I know why people question my orientation...

That looks possible. Increasing the power behind it makes sense since that's all the lights really are. I almost added the second one before but for some reason I thought it was panel not notification.
[Galaxy Note 4 Unified Development] friedrich420:
;)

Oh if you can manage the 2nd one, im sure you can create an interface on your sku app to control it as well..

it was one of the easiest implementations (even for me...) on stweaks and synapse...

the sysfs will be: /sys/class/sec/led/led_intensity (min=0, max=255)

The 1st one if doable also has some cool options..

It gives you 2 options to control brightness.. one in lowlight environments and one in brighter environments..

the sysfs for that will be:

/sys/class/sec/led/led_lowpower_current

/sys/class/sec/led/led_highpower_current

Plus some more options for blinking speed:

/sys/class/sec/led/led_fade_in_time

/sys/class/sec/led/led_fade_out_time

sys/class/sec/led/led_fade
[Galaxy Note 4 Unified Development] twistedumbrella:
leds-qpnp is nothing like it was in the Note 3 apparently. They turned it into more of a for each than an each for each haha

static int qpnp_led_set_max_brightness(struct qpnp_led_data *led)
{
switch (led->id) {
case QPNP_ID_WLED:
led->cdev.max_brightness = WLED_MAX_LEVEL;
break;
case QPNP_ID_FLASH1_LED0:
case QPNP_ID_FLASH1_LED1:
led->cdev.max_brightness = led->max_current;
break;
case QPNP_ID_RGB_RED:
case QPNP_ID_RGB_GREEN:
case QPNP_ID_RGB_BLUE:
led->cdev.max_brightness = RGB_MAX_LEVEL;
break;
case QPNP_ID_LED_MPP:
if (led->mpp_cfg->pwm_mode == MANUAL_MODE)
led->cdev.max_brightness = led->max_current;
else
led->cdev.max_brightness = MPP_MAX_LEVEL;
break;
case QPNP_ID_LED_GPIO:
led->cdev.max_brightness = led->max_current;
break;
case QPNP_ID_KPDBL:
led->cdev.max_brightness = KPDBL_MAX_LEVEL;
break;
default:
dev_err(&led->spmi_dev->dev, "Invalid LED(%d)\n", led->id);
return -EINVAL;
}

return 0;
}

is the "new" version of what gets edited in the first one

static void qpnp_led_set(struct led_classdev *led_cdev,
enum led_brightness value)
{
struct qpnp_led_data *led;

led = container_of(led_cdev, struct qpnp_led_data, cdev);
if (value < LED_OFF) {
dev_err(&led->spmi_dev->dev, "Invalid brightness value\n");
return;
}

if (value > led->cdev.max_brightness)
value = led->cdev.max_brightness;

led->cdev.brightness = value;
schedule_work(&led->work);
}

and then the edited part of the second
[Galaxy Note 4 Unified Development] friedrich420:
yep thats why i gave up immediately..

however the other one is the same (almost) and the changes are applicable.. i did it (with some changes) bc of some compilation errors, but couldnt get the extended sysfc to control led.. but i thought the actual led was much brighter in my notifs..
[Galaxy Note 4 Unified Development] twistedumbrella:
I started working on that with https://github.com/StarKissed/stark...mmit/5474f1fb5b7f997e57d3f21ef160cd40fe964978

The hardest part will be how blink and brightness are now separated. That cur variable will probably need to be passed around.
[Galaxy Note 4 Unified Development] friedrich420:
Thank you :)

It sucks because by the time i come back from the office you'll be in bed.. but there's also a really good chance ill find a nice surprise waiting for me on your git :)
[Galaxy Note 4 Unified Development] twistedumbrella:
That is optimistic on both haha.
[Galaxy Note 4 Unified Development] friedrich420:
Hey so its mutually exclusive therefore it still works for me hahahah
[Galaxy Note 4 Unified Development] twistedumbrella:
My best guess is https://github.com/StarKissed/stark...mmit/b4f35bf6bd5f05c0641c8a307f409fa55a125015 but I dumped all the timer stuff because it appears to already exist

static int max77843_rgb_ramp(struct device *dev, int ramp_up, int ramp_down)
{
struct max77843_rgb *max77843_rgb = dev_get_drvdata(dev);
int value;
int ret;

pr_info("leds-max77843-rgb: %s\n", __func__);

if (ramp_up <= 800) {
ramp_up /= 100;
} else {
ramp_up = (ramp_up - 800) * 2 + 800;
ramp_up /= 100;
}

if (ramp_down <= 800) {
ramp_down /= 100;
} else {
ramp_down = (ramp_down - 800) * 2 + 800;
ramp_down /= 100;
}

value = (ramp_down) | (ramp_up << 4);
ret = max77843_write_reg(max77843_rgb->i2c,
MAX77843_LED_REG_LEDRMP, value);
if (IS_ERR_VALUE(ret)) {
dev_err(dev, "can't write REG_LEDRMP : %d\n", ret);
return -ENODEV;
}

return 0;
}

static int max77843_rgb_blink(struct device *dev,
unsigned int delay_on, unsigned int delay_off)
{
struct max77843_rgb *max77843_rgb = dev_get_drvdata(dev);
int value;
int ret = 0;

pr_info("leds-max77843-rgb: %s\n", __func__);

if( delay_on > 3250 || delay_off > 12000 )
return -EINVAL;
else {
value = (LEDBLNK_ON(delay_on) << 4) | LEDBLNK_OFF(delay_off);
ret = max77843_write_reg(max77843_rgb->i2c,
MAX77843_LED_REG_LEDBLNK, value);
if (IS_ERR_VALUE(ret)) {
dev_err(dev, "can't write REG_LEDBLNK : %d\n", ret);
return -EINVAL;
}
}

return ret;
}

so all that is needed now is a sysfs to replace the hardcoded values

max77843_rgb_ramp(dev, 800, 800);
max77843_rgb_blink(dev, 200, 200);

would be something like

max77843_rgb_ramp(dev, sysfs-ramp_up, sysfs-ramp_down);
max77843_rgb_blink(dev, sysfs-delay_on, sysfs-delay_off);
[Galaxy Note 4 Unified Development] twistedumbrella:
The question is whether adding ramp and delay would just be overwhelming to the user. If all the values are made proportional to the smallest, that isn't much control. Setting an interface for each variation would be around 20 interfaces. Setting proportional values would require the user to either calculate or trial and error around 5 values.

The first is just an illusion of control, the second is the most accurate, and the last is the most manageable, but is there enough demand for any of them?
[Galaxy Note 4 Unified Development] ktoonsez:
Ya that is a tough one, what I usually do is just ignore the comments 99.999999% of the time unless they are relentless and then in that case report them. On occasion I have lost my temper (usually when I am on the road working 14-16 hour days) but have done pretty good on keeping it in check. Most of the time they will just get bored when no one answers and they will go away. It is definitely a challenge that is for sure :rolleyes: :eek:
[Galaxy Note 4 Unified Development] twistedumbrella:
The challenge I seem to face is trying to diffuse the issue so that no one does answer. You can see in the thread I posted a little while back that my last post stating the conversation was over was something like 6 hours and 10 posts prior to when it was stopped by closing the thread.

...and I cannot even begin to describe how hard it was not to lose my temper to a user of a year and 2 threads about app settings calling me uneducated and saying I had to work hard to prove myself to him.
[Galaxy Note 4 Unified Development] twistedumbrella:
[MENTION=4325945]ktoonsez[/MENTION] when you get a chance, what is your take on the LED stuff above?
[Galaxy Note 4 Unified Development] ktoonsez:
Yes, a few weeks ago I was looking at that stuff and does seem very simple with the 2 functions. Only thing it really needs from looking at the code is a "max77843_rgb_ramp" for MISSED_NOTI since it only sets the blink.

Oops, forgot one part, the max77843_rgb_ramp function has a hard coded value of 800 as the max ramp so that needs to be raised if u want a longer ramp/fade.
[Galaxy Note 4 Unified Development] twistedumbrella:
So only add the sysfs for notifications and not the battery or the other stuff? That makes sense, too. That actually may be the cleanest way to provide just enough.
[Galaxy Note 4 Unified Development] ktoonsez:
In the past I have never seen the need to do the battery ones since they are rarely seen like the charging error one and then u got the low battery one which if your battery is low, you probably dont want to be doing fancy things on low battery, lol.
[Galaxy Note 4 Unified Development] UpInTheAir:
This is exactly why i handed back my Recognised Contributor title. Having to put up with the BS and held to a "higher" standard than others became a 'handicap' when contributing to a discussion and unable to defend my work or reasoned input. The user in question didn't like the term "lame ass lemming". The Mods either.......
[Galaxy Note 4 Unified Development] twistedumbrella:
Good point. Notifications only it is.

I think I got the other edge of that sword. I only recently discovered I could choose the RD label when someone made a comment about preferring an answer from a dev over my opinion (if they only knew the RD application). I still got the RD speech with any and all warnings, but to the other members I had been nothing more than a senior member for 2+ years, lol.

By the way, howdy :D
[Galaxy Note 4 Unified Development] friedrich420:
oh yesss!!!! i knew it!!

im adding the changes now and testing it!!

Apparently when i thought you would be sleeping i messed our time zones ;)

i keep forgetting that im in the future ;) (at approx 6:41 pm the future looks the same btw...)

edit: i compared that RD application to applying for PhD candidacy .... :o
[Galaxy Note 4 Unified Development] twistedumbrella:
[YouTube]BBhk4cL6UmA[/YouTube]
[Galaxy Note 4 Unified Development] friedrich420:
hehe :)

my bad news: i cant compile it.. im getting lots of errors :( :(

a repetition of this pretty much:

drivers/leds/leds-max77843-rgb.c: In function 'store_max77843_rgb_lowpower':
drivers/leds/leds-max77843-rgb.c:393:49: error: 'leds_control' undeclared (first use in this function)
led_dynamic_current = (led_lowpower_mode) ? leds_control.current_low : leds_control.current_high;
[Galaxy Note 4 Unified Development] twistedumbrella:
I kind of expected that. I got distracted and ordered a gear vr, built a recovery for the shield, and watched psycho pass... :/
[Galaxy Note 4 Unified Development] friedrich420:
:P :P

A little ADD aren't we??
[Galaxy Note 4 Unified Development] twistedumbrella:
How generous. Even the doctor didn't call it "a little" haha
[Galaxy Note 4 Unified Development] friedrich420:
hahahaha :D

and i was about to become even nicer and change it to "multitasker" haha
[Galaxy Note 4 Unified Development] twistedumbrella:
https://github.com/StarKissed/stark...mmit/7ef07791ab023fc4fef1d9dffe76d643b03d241b
[Galaxy Note 4 Unified Development] friedrich420:
You did it my man you did it!! And you made it brighter by default if im not mistaken??

Any idea what the max value for brightness is?? :P
[Galaxy Note 4 Unified Development] ktoonsez:
Its a byte so 255 :good:
[Galaxy Note 4 Unified Development] friedrich420:
I thought so just wanted to make sure!!

THANK YOU SO MUCH!!

A step of 5 should be ok or is it too low/insignificant?
[Galaxy Note 4 Unified Development] ktoonsez:
Good stuff man :D. Is it producing a fade effect that everybody loves when tweaking the numbers?
[Galaxy Note 4 Unified Development] ktoonsez:
Couldnt hurt but probably is over-kill to be that small
[Galaxy Note 4 Unified Development] twistedumbrella:
One minor issue: https://github.com/StarKissed/stark...mmit/3d799b5e26ac36d31450651a06a277ee03f14941
[Galaxy Note 4 Unified Development] friedrich420:
im gonna start by saying that im too lazy to fix that now and ill just pretend you went a little hispanic on us ;)

hey what about that shield??

let me do a basic search first to see what it is but could sound like a cool xmas gift if not overly expensive..

ok after looking at it im reassessing..

its def not for her but could be an AWESOME gift for my godson :) :)

and i never know what to get that kid bc he is more high tech than me (almost 12 now...)

the price is good in usd but i imagine times 1.5 Euros here... so im thinking around 400-450 euros...
[Galaxy Note 4 Unified Development] twistedumbrella:
I think around 300 for wifi, 400 for lte. I forget. I got one as part of working with reicast so it was never a matter of doing my homework first. I will say it has some bad press for breaking if you beat it up, but I've never had any of those issues. I love it.

By the way, I know doing the open forum thing on most issues helps because you get a lot of input. If there is ever stuff you'd rather not have on here, though, my hangouts is the same name. I don't typically use it, but I can make an exception lol.
[Galaxy Note 4 Unified Development] friedrich420:
yeah 300 for the 16gb one and 400 for the 32gb lte one ..

---------- Post added at 06:25 PM ---------- Previous post was at 06:24 PM ----------

thank you so much!!

im the same exact way!! i dont typically use it (i have an issue with things that notify me.. so i turn off notifs and then i forget i even have it) ;)
[Galaxy Note 4 Unified Development] twistedumbrella:
Exactly. Or five devices go off at once...
[Galaxy Note 4 Unified Development] twistedumbrella:
So making an app is complicated, but not entirely difficult for kernel config.

Taking an app that was already made with activities and transitioning to fragements... :silly::eek::crying:
[Galaxy Note 4 Unified Development] friedrich420:
you are trying to make me throw up ?? i just ate man lol

**** is still going on on that thread,,, i put rlorange on my ignore list so i dont have to read anymore of what he says but i know he is replying non stop..

btw awesome job on the new app update!!

i finally got to play with it again a bit this afternoon!!

its almost complete!!!

is there anyway i can help?

would the "scripts" i have for stweaks and synapse help at all for some of the other options or we are talking a completely different league??
[Galaxy Note 4 Unified Development] twistedumbrella:
I built the entire app based on a script, but the app is such a mess right now, haha. I don't know that I can add anything without a nuclear reaction. It all started with imoseyon's speedtweak and some minor mods, then expansion, then an app launcher, then a whole app hahaha

http://loungekatt.com/StarKissed/fusion/application/speedtweak.sh

I think he is a bit like I was when I started (and still am to some extent). Being all about the numbers is fine for debugging an issue, but it only goes so far without sounding cold before it needs a little help sounding right.

Don't get me wrong, I have had plenty of battles where I have flown the "respect isn't given, it's earned" banner, but all it takes is saying "this might improve it" over "this will fix your **** up"
[Galaxy Note 4 Unified Development] friedrich420:
wow!!! just wow!!!

it's like a mini novel ;)
[Galaxy Note 4 Unified Development] twistedumbrella:
If you want a good scare. I wrote a little over 80% of that script myself... on my phone... in a text editor... on lunch breaks at Circuit City...

and that is why I can recite mount -o remount, rw -t yaffs2 /dev/block/mtdblock3 /system
[Galaxy Note 4 Unified Development] friedrich420:
gsus!!! that says a lot about you!! :good:

edit: there's a school of thought amongst some philosophers who believe that almost all "philosophical dilemmas/disagreements" are nothing more than linguistic differences/misundersatndings/ "mishearings" than differences in the essence of things...
[Galaxy Note 4 Unified Development] twistedumbrella:
It says a lot about how little focus I had in the workplace, haha.

I have heard that before. One of our classes was "Working Across Cultures" that focused on conveying your message with the same meaning regardless of the audience.

How did you get started in this? That script is more or less how I did, at least for kernels.
[Galaxy Note 4 Unified Development] twistedumbrella:
This is what I meant by all messed up BTW
[Galaxy Note 4 Unified Development] twistedumbrella:
I may be off in assuming this applies to any dev but I think on forums you get "caught between a rock and a hard place"

The rock being those not interested in anything more than the specific, subjective, simple answer that make it feel like a job, and the hard place being those that already know most of it and belittle your effort by pointing out mistakes or shortcomings because their pride in accomplishment usually comes off as your failure.

The second part can be just as much a rock and hard place for that person, though. Do they minimize their accomplishment or risk offending the original author?

I think we get stuck choosing our battles. The constant question of how far is too far...
[Galaxy Note 4 Unified Development] friedrich420:
My friend [MENTION=593514]twistedumbrella[/MENTION] what do you think about remembering your younger days of smali and baksmali, rom cooking, apk modding??

As you may or may not know at this moment ALL DEVS are stuck with the lollipop system structure, the fact that dalvik is removed, its all based on art and as of now theres no way of deodexing or even the one way of deodexing that was found, leads to either those apps fcing or the complete system crashing..

http://xdaforums.com/galaxy-s5/devs...-5-0-gonna-t2961967/post57421564#post57421564

i figured they need you ;)
[Galaxy Note 4 Unified Development] twistedumbrella:
They need a miracle. That is not my department lol. I looked at it, though. I am so far out of the loop on that I would need weeks to get caught up.

Leaving this for future reference:
[Galaxy Note 4 Unified Development] Pafcholini:
First of all I have to read every page of this thread to keep up :D I'm adapting my Synapse scripts from the Note 2 to the Note 4. Btw [MENTION=4401403]friedrich420[/MENTION] I saw that you are using Synapse on your kernel so maybe you can help me with this issue. The issue is When I try to set the "Governor tunables" .

If I write the codeon this way Synapse give me FC:

{ SPane:{
title:"CPU_GOVERNOR",
description:"The CPU governor determines how the CPU behaves in response to changes in workload."
}},
{ SOptionList:{
default:`cat /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor`,
action:"generic /sys/devices/system/cpu/cpu0/cpufreq/scaling_governor",
values:[`while read values; do busybox printf "%s, \n" $values; done < /sys/devices/system/cpu/cpu0/cpufreq/scaling_available_governors`]
}},
{ SPane:{
title:"Governor tunables",
description:"The various configuration items which are governor-dependent."
}},
{ STreeDescriptor:{
[B]path:"/sys/devices/system/cpu/cpufreq",[/B]

I found the problem is the path:"/sys/devices/system/cpu/cpufreq". If I change the path then Synapse boots fine. And here come the problem, the governor tunables are in /sys/devices/system/cpu/cpufreq and i don't know how the fix this issue to show the governor tunables...

Any idea?
[Galaxy Note 4 Unified Development] friedrich420:
i did it this way... it seems to only work for interactive though...

{ SPane:{
title:"Governor tunables",
description:"The various configuration items which are governor-dependent."
}},
{ SDescription:{
description:""
}},
{ STreeDescriptor:{
path:"/sys/devices/system/cpu/cpufreq",
generic: {
directory: {
STreeDescriptor:{
generic: {
directory: {},
element: {
SGeneric: { title:"@BASENAME" }
}
},
exclude: [ "boostpulse", "sampling_rate_min", "cpufreq_limit_requests", "target_loads", "timer_rate", "above_hispeed_delay", "go_hispeed_load" ]
},
}
},
exclude: [ "overall_stats", "vdd_table" ]
}},

minimum frequencies work for you my man?
[Galaxy Note 4 Unified Development] Pafcholini:
No, it's show me 1574MHz but the kernel use frequency under 1574... I'll try to fix it tonight.

Powered by ET
[Galaxy Note 4 Unified Development] friedrich420:
same exact here..
[Galaxy Note 4 Unified Development] twistedumbrella:
FedEx says Monday for Gear VR. It looks like Monday I'll be starting a regiment of "let users answer redundant questions" lol.

I figured I would give this SaberMod a try when the MacOS version finishes compiling ...in 2015...
[Galaxy Note 4 Unified Development] thehacker911:
Arm-eabi GCC 5.0 Sabermod

Build from Source.

https://www.dropbox.com/s/6mzo1yja810vjk1/arm-eabi-5.0.zip?dl=0

Note: It's a WIP!
[Galaxy Note 4 Unified Development] airmaxx23:
What is this exactly?
[Galaxy Note 4 Unified Development] twistedumbrella:
I can't use Linux versions, though. Hence having to rebuild it lol.

I realized I wasn't using the Mac job number so now it's really east building but seems to fail on gmp being too old even with the newest.
[Galaxy Note 4 Unified Development] thehacker911:
I building on Linux Server.
[Galaxy Note 4 Unified Development] twistedumbrella:
Yeah. I would, except my linux server runs on an MBP that's got a 2.3 quad with 4 GB RAM whereas I like to build on the MBP that's got a 2.7 quad with 16 GB RAM.
[Galaxy Note 4 Unified Development] thehacker911:
My server has: i7 3750 k Processor with 32 GB RAM, 250 GB SSD and 2x3 GB HDD. Using Jenkins for kernel, rom and toolchain builds.
[Galaxy Note 4 Unified Development] twistedumbrella:
Congrats, but it wasn't a pissing contest. It was Linux -= 12 GB RAM and .3 GHz per core. The point still stands that I'll need to use a SaberMod for MacOS
[Galaxy Note 4 Unified Development] Pafcholini:
I never tried SaberMod toolchains. I'm using 4.9.3 Linaro toolchain from christopher.

What about SaberMod?

Powered by ET
[Galaxy Note 4 Unified Development] twistedumbrella:
Dunno. That is why I was going to try it lol.
[Galaxy Note 4 Unified Development] friedrich420:
im using SaberMod 4.10

https://github.com/friedrich420/N4-...mmit/7b8782e7aacee60165206b548dea6884dcd53f25
[Galaxy Note 4 Unified Development] twistedumbrella:
I gave up, lol. At least for now. I keep getting pulled away for other stuff, such as dissertations on thermal or governor configuration. GCC isn't broken, so there is no real need to fix it.
[Galaxy Note 4 Unified Development] friedrich420:
i agree with you.. GCC 4.7 is just fine..

SKU being perfect is much much more important ;)
[Galaxy Note 4 Unified Development] twistedumbrella:
It's getting there. I need to figure out why Unity is not sending my variables to Leanplum, though. I have to have analytics for this thing by Sunday and right now nothing is registering.

Holy McS***! Nevermind, I just needed to set an override in the panel. It works. Woot...

But as for this app, it is a long, grueling process to undo years of building it up to go about it completely different. It is a necessary change, but not any less tedious just because it was inevitable.

Hmm.. That sounded really fancy. "The updates were needed but it's still a pain."

lol @ http://xdaforums.com/showpost.php?p=57476054&postcount=58

At least others are jumping on the "help these people do for themselves" bandwagon.
[Galaxy Note 4 Unified Development] Pafcholini:
Btw, i saw that with the stock kernel happens the same. The min frequency doesn't show the correct values...

Powered by ET