yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] tony78960:
Thank you for your contribution!

Do you feel like the current icon is too old and does not fit Lollipop's design? :p

I like the idea of the bevel on the screen :good:

But I fear that the puzzle piece might confuse people with Xposed Installer's icon...

Also, IMHO the button feels a bit iPhonish :silly: Most of the recent Android devices don't have hardware button anymore!

Don't you want to add a 3D feeling at the top of the device like in the current icon? :3

I added the vectorial version of the current icons on Github if you want to take a closer look or use them.
[Xposed Framework Modules] PunchUp:
Haha yea does feel a bit old :p

I don't think it could be so confusing. Rather I feel it distinguishes your module from other screen filter apps available on the market. That was the thought behind it

I also used the jigsaw in this icon. Not a problem IMO

Thought you would say that haha :D But don't take it so literally. I just thought it looked too plain without the button

And 3D look probably won't look so good I think :p (Will give it a try though)

Anyway I've attached a version without the button. Maybe you could add a poll for user opinion?

(Also made the screen a bit lighter. Looks better now)
[Xposed Framework Modules] St3ve32:
I love especially the first one :) nice work, thanks :)
[Xposed Framework Modules] PunchUp:
Glad you liked :p

The second one is for notification. I think it'd look good when you actually see it there
[Xposed Framework Modules] Biyoalp:
last update

Hi

Galaxy s5 4.4.2

I use it and an awesome app.

After last update continuously shown "app stopped" dialog. I returned previous version.

Secondly why minimum level 15, actually I want really 0.
[Xposed Framework Modules] tony78960:
Oh, I got it.

Ok then! Maybe slightly more opaque, a bit bigger and with a thiner border?

Regarding the small depth feel, I was following Google's guidelines. It looks better if you add a small border around the whole icon.

The notification icon, on the contrary, should be flat and white.

Also, don't forget to check the rendering on a dark background!
[Xposed Framework Modules] tony78960:
Could you provide the part of your logcat containing the error message? (if you don't know how to get it, just provide a full logcat)

The minimum level is 15 and not 0 because it makes the screen already really really dark.

You can compare the transparency level with the number of luminosity levels you screen can display. Transparency level of 15 = 15 x 3 different colors ≈ 15 luminosity levels

I can lower this limit, but then it's up to you to keep your screen readable.
[Xposed Framework Modules] PunchUp:
What about now? :D
[Xposed Framework Modules] fullydeveloped:
Suggestions: Multiple Profiles

Suggestions

Please allow for multiple profiles to be saved.

Please configure a profile toggle through a persistent notification.

Thank you!
[Xposed Framework Modules] PunchUp:
Changed the colour for better visibility in darker backgrounds. What do you think? :p
[Xposed Framework Modules] Biyoalp:
logcat

---- 8 Ara 2014 15:58:13 ----

12-08 15:55:42.403 4650 4650 E AndroidRuntime: Process: com.tonymanou.screenfilter, PID: 4650

12-08 15:55:42.403 4650 4650 E AndroidRuntime:	at com.tonymanou.screenfilter.ui.ScreenFilterActivity$UIHandler.changeTransparency(ScreenFilterActivity.java:445)

12-08 15:55:42.403 4650 4650 E AndroidRuntime:	at com.tonymanou.screenfilter.ui.ScreenFilterActivity$UIHandler.handleMessage(ScreenFilterActivity.java:408)

12-08 15:55:46.253 917 1943 I ActivityManager: Process com.tonymanou.screenfilter (pid 4650) (adj 15) has died.

12-08 15:57:01.323 6425 6425 E dalvikvm: >>>>> com.tonymanou.screenfilter [ userId:0 | appId:10341 ]

12-08 15:57:04.003 6425 6425 E AndroidRuntime: Process: com.tonymanou.screenfilter, PID: 6425

12-08 15:57:04.003 6425 6425 E AndroidRuntime:	at com.tonymanou.screenfilter.ui.ScreenFilterActivity$UIHandler.changeTransparency(ScreenFilterActivity.java:445)

12-08 15:57:04.003 6425 6425 E AndroidRuntime:	at com.tonymanou.screenfilter.ui.ScreenFilterActivity$UIHandler.handleMessage(ScreenFilterActivity.java:408)

12-08 15:57:07.543 917 928 I ActivityManager: Process com.tonymanou.screenfilter (pid 6425) (adj 11) has died.

---- 8 Ara 2014 15:58:13 ----
[Xposed Framework Modules] divineBliss:
Questions and more bugs

tony78960,

Thanks for answering my questions :) . I have a few more and more bugs to report below:

I'd like to learn and understand the topic of computer color representation as you are using it in Screen Filter a bit better.

I don't want to play the "it's so obvious" guessing game ;) , so I'll ask more questions:

In figure e of the color representation diagram of http://en.wikipedia.org/wiki/HSL_and_HSV which you provided previously, they use hue, saturation, and value.

Is think link applicable?: http://en.wikipedia.org/wiki/Alpha_compositing

Is my interpretation below correct of what the sliders in the color settings dialog do?:

The circular color slider selects hue.

The 1st linear slider in the color filter settings selects saturation (1 to 0 left to right or bottom to top depending on device)

The 2nd linear slider in the color filter settings selects value (0 to 1)

The 3rd linear slider in the color filter settings selects alpha (1 to 0)

So if alpha is close to 0 (fully transparent), then I won't see the color filter having any effect. Is that the reason for showing the hatched/checkerboard pattern in the color circle and on the right side of the square color boxes?

When you use this app on your devices, if you use the color filter, do you disable the transparency filter or do you enable both filters at the same time?

What are you thoughts on providing a way to enable/disable the transparency filter and color filter from the tool box?

Glad to help.

Now here are more scenarios that cause "Unfortunately, Screen Filter has stopped" pop ups on multiple devices, so you should be able to reproduced them:

Scenario A:

1. Enable Screen Filter.

2. Long press icon in notification panel to enter settings, then press back to exit settings.

3. From notification panel, use slider to change filter value.

4. You should see the "Unfortunately, Screen Filter has stopped" error box pop up. If not, repeat steps 2 and 3 a few times until you do.

Scenario B:

1. Enable Screen Filter and check "Hide when the filter is not active" check box, then exit settings.

2. From notification panel, use press the value box to turn off the filter.

3. You should see the "Unfortunately, Screen Filter has stopped" error box pop up. If not, repeat steps 1 and 2 a few times until you do.

Hopefully these bugs are all related and have the same root cause. Even though I see those error messages, the app seems to still be running.

1. If it will be easier to maintain the code with just one string "?", leave it at that.

2. Okay - thanks!

---------- Post added at 09:40 PM ---------- Previous post was at 09:30 PM ----------

PünchUp,

FWIW I think the contrast between the filtered and unfiltered screen areas on the icon is too low and barely noticeable.
[Xposed Framework Modules] PunchUp:
Wasn't playing a guessing game. I work with various colour models while designing, so am well aware of HSL, HSV, CMYK, etc.. Just tried to explain it in layman's terms since the question sounded noob-ish. But I see you were looking for an in-depth explanation, so forgive my assumption

Checkered background is the standard way to display any image file with varying alpha levels. You must have noticed it in various image viewing applications.

You don't really need to enable the darkening filter while using colour one, since it can adjust both

The filters weren't split before version 1.4. So if you read up some of the previous pages, I have already asked this before and Tony said that it will be implemented soon

It is not meant to portray filtered and unfiltered areas. Just a designing trick to create illusion of glare/reflection

Anyway, [MENTION=4272306]tony78960[/MENTION] I completely redesigned it. What do you think? :p
[Xposed Framework Modules] divineBliss:
I don't recall seeing checkered backgrounds in image viewing apps, but don't use them often and don't recall ever adjusting alpha - otherwise I would not have asked the question.

From http://developer.android.com/design/style/iconography.html#launcher

"An icon is a graphic that takes up a small portion of screen real estate and provides a quick, intuitive representation of an action, a status, or an app."

The puzzle piece in your icon dominates the icon in my opinion and there is no clear representation of being a screen filter app. I'm not sure why you're creating the illusion of glare/reflection.

I prefer the blue/gray screen filter representation portrayed by the original app icon below. I think the original icon below could use a puzzle piece to convey that it's an Xposed module, similar to what you did in your icon, but with lower contrast and smaller size.

Maybe take the original icon's phone outline and replace it with the one you created in your icon, keeping the original blue/gray screen filter representation and adding a lower contrast smaller sized puzzle piece to the left side in the blue area?
[Xposed Framework Modules] tony78960:
You suggestions are in the to-do list!

It will take some time to implement this cleanly, just be patient ;)

-----------------------

I guess so, but it's Android that is taking care of this job (using ATOP blending by default I think).

For me it seems to be the opposite (all the interval reversed) :silly:

That's right. And and as [MENTION=5444464]PünchUp[/MENTION] said the checkered background is the standard way to display transparent parts of an image.

The two filters are independent and can be enabled at the same time. The color filter is drawn first, then the darkening filter is drawn on top of it.

Thanks, this confirms the Force Close reported by [MENTION=6226392]Biyoalp[/MENTION].

What a buggy app :eek:
[Xposed Framework Modules] tony78960:
Icon

Thank you for continually trying to improve your icon!

I prefer this last version as there is no hardware button :silly:

But, well... you will find me really really picky.

I am insanely fastidious regarding line sizes, shapes and symmetry :eek: (don't worry, I am more open regarding colors ^^')

Why did you replace the depth effect at the top of your previous version with a shadow at the bottom?

You should keep it at the top, make it a bit bigger and use a lighter color!

Regarding the puzzle piece: you should use the RGBA color #5a5a5aaa as it is more visible on a dark background. A gray border would be better too.

IMHO we should keep the icon as simple as possible. It is the main goal of the Material design, right? So no hardware button, and no camera hole / speaker as well...

Except for the jigsaw piece's borders, your lines are a bit too thin, they won't look good after down-scaling your image to create icons. On a 48x48dp image, a line should be at least 0.5dp

Could you use this vectorial image as a template? Just use the color palette you want, add the bezel on the screen and replace the square with your puzzle piece.

Which computer graphics software do you use?

In order to create different icon sizes I recommend you to export your final product as a vectorial image (especially in the SVG format), Inkscape is quite good for this.

In a way, it aims to break the monotony of the screen part (which is flat and quite big compared to the size of the icon).

I have seen various developers using these triangles in their icons recently, it is so next-year and in the spirit of the new Material design.

You can give a try, but I wouldn't want the icon to be too close from Xposed Installer's one!
[Xposed Framework Modules] rocapillon:
Working in Xperia M2 on stock 4.4.2 with root
[Xposed Framework Modules] drexvil:
If I accidently make the screen too dark, how would I reboot a device with a non-removable battery? It's a Samsung Galaxy Tab S. I tried using the DOWNLOAD MODE key combinations, but I believe it requires a device that's already off.
[Xposed Framework Modules] divineBliss:
drexvil,

Did you try the power button on your Samsung Galaxy Tab S?
[Xposed Framework Modules] drexvil:
Yes but it does nothing since it just brings up the power menu, which I can't see. But I found the solution: power + down volume for 10 seconds. Hope this helps someone. Thanks divineBliss!
[Xposed Framework Modules] divineBliss:
:eek: Ok - thanks for catching that - I had the ranges backwards for phone being in portrait mode (three color sliders are horizontal). Corrected by switching range order and bottom/top order below - so you must having been checking your phone in portrait mode.

The 1st linear slider in the color filter settings selects saturation (0 to 1 left to right or top to bottom depending on orientation)

The 2nd linear slider in the color filter settings selects value (1 to 0)

The 3rd linear slider in the color filter settings selects alpha (0 to 1)

Thanks for answering the other questions I had.

Caution: Work in progress :) . Glad to help.

So about the new Screen Filter app icon, I don't see how screen filtering is being represented in the icon. Am I missing it or is that not a requirement of yours for the candidate new Screen Filter app icon?
[Xposed Framework Modules] m4tchb0x87:
Wish I had known about this sooner. I've been waiting for f.lux to be ported to android every since I dropped apple. This works just as well. Solid work and thanks.
[Xposed Framework Modules] PunchUp:
If you notice the first icon I posted here, that puzzle was smaller and more transparent. I increased the size and made it darker as per Tony's request. I appreciate the critisism and take it contructively but please read up before doing so

It is to prevent it from looking too flat and Tony has already provided a very good explanation

I don't want to move it to the left, since the Xposed Installer's icon already has it there

Picky is good, don't worry.

"lighter colour".. That is the reason why I removed the depth effect :p The previous version looked great with dark background but not so much with a lighter one. And I was being too picky about what shade to use there, so removed it for the time being.

Do you really need it though? A flat icon looks nice too.. Won't mind adding back if you want though

I do try it out a lot of times using Nova launcher before posting it here. The hardware button, etc looked pretty cool but ok I'll remove it

And yes I know about the lack of visibilty with a darker background. Thanks for the suggestiom. Will try it out

Yes I am aware of that. Just wanted to get the main stuff sorted before taking care of the finer adjustments

Inkscape is what i use :)
[Xposed Framework Modules] PunchUp:
To be honest, I still prefer the one I posted yesterday. I don't really think much about material guidelines and Google use a lot of details in their icons too

But anyway, I guess this is close to what you want :p
[Xposed Framework Modules] GunPowder55555:
Working perfectly fine here on note 2 ????
[Xposed Framework Modules] mo30:
Hi. I install new ver of screen filter then change filter color to blue when I done it my phone screen compality blue and i dont see nothing after this i go to recovery and flash disable-xposed

then I reboot after boot some thing cause problem ex:in camera say camera not availiable and i can not play video or music and i cannot turn on led flash(i thing problem of camera is from this)

and when i have a call no sound no vibrate working

Soory for my bad english

My phone is miro
[Xposed Framework Modules] PunchUp:
Is all that happening when Xposed is disabled or enabled?
[Xposed Framework Modules] Dark_Slayer:
The app was not accepting xposed permissions.. Even rebooted to double-verify if i rebooted after updating the module.. but no use..

I have no idea why and how it got fixed after i selected the "hide the toolbar when filter is not active"

Its ur call now. Issue solved or A bug :thumbup::rolleyes: im satisfied with the results atleast :) cheerz bro :beer:

Sent from my GT-N7100
[Xposed Framework Modules] Hig13:
Hey, the default value of the color filter is 0% see through (opaque? Maybe I'm confusing the word..). When you select blue, you hit okay before changing value of opacity. Your screen is blue.

Why did you go to recovery? Doesn't it reset when you restart your device? You might have screwed some stuff up, and may have to wipe and flash your rom again.
[Xposed Framework Modules] PunchUp:
It won't reset after a reboot. Have to disable Xposed framework
[Xposed Framework Modules] Quipp:
Don't know if it has been asked yet. But when this is active I can't see my notifications.
[Xposed Framework Modules] pakitos:
[MENTION=4272306]tony78960[/MENTION]

I have a suggestion that I always forget to ask.

When Screen Filter is not active it says "Off" or "Apagar" in spanish. Is not a thing of a bad translation but context. I think it should say "Enable/On" "Encender" Because you are actually turning Screen Filter On.
[Xposed Framework Modules] rohith86:
Thanks for this mod. I was searching for a while for this.

I have a suggestion. Can you please position the slider below the brightness slider?
[Xposed Framework Modules] srnoth:
Great tool... only screen color changer I know of that still allows you to click "Install" on apks and to click "Allow" for supersu while the filter is active.

One suggestion... with the recent upgrade that separated the color setting from the 'darkness' filter setting... the plugin for Tasker now only activates the darkness setting. I use this app to tweak my screen color, so using the Tasker plugin to change the color on boot no longer works. Had to revert to previous version.
[Xposed Framework Modules] FoferX:
Or at the very least make it an optional tile/button in QuickSettings (by way of GravityBox and/or other means.) Seems more appropriate there than Notifications...
[Xposed Framework Modules] Quipp:
Any body els having the problem on HTC one (m7) that when it's active you can't see notifications when you pull the screen down?

Better yet is there a fix for this?
[Xposed Framework Modules] Strider77:
on paranoid android 4.6 beta 6 when dsb is on, the status bar and navigation bar are darker than rest of the screen

[IMG="without screen filter"]http://s11.postimg.org/kp9r8g5pf/Screenshot_2014_12_17_06_44_07.png[/IMG]

[IMG="with screen filter"]http://s27.postimg.org/s3hjfj14j/Screenshot_2014_12_17_06_44_36.png[/IMG]
[Xposed Framework Modules] divineBliss:
What is "dsb"?
[Xposed Framework Modules] Strider77:
dynamic system bars
[Xposed Framework Modules] Adam3Sixty:
Ignore, sorry.
[Xposed Framework Modules] oldman20:
i have a question: what exactly this mod doing with screen to make it darker? decrease bright (mean increase life batterry) or just cover screen a layer dark transparent? sr my english not good! Do you understand target of my question?:rolleyes:
[Xposed Framework Modules] PunchUp:
If you have an AMOLED screen it will save your battery but otherwise it will save your eyes
[Xposed Framework Modules] nvo2411:
Unable to set the default level to custom value, whatever I do it remains on 115.
[Xposed Framework Modules] tony78960:
Oh, sorry for this misunderstanding...

Exact, it is not implemented yet.

@Rom, this is why I added this at the end of my reply:

Your screenshot made me realize that the black background was not always pretty.

I will add the ability to change the toolbox's background once the settings activity is made, maybe in a few days.

Yup, it's in the to-do list :D
[Xposed Framework Modules] Rom:
No problem :)

I will very happy when you will add this feature :D :good: because i don't find any other xposed app that make this change :)

I am very exited about next update ! :good:
[Xposed Framework Modules] MrGlitch:
It's doesn't work with me! ?

I'm using i9500 (4.4.2 Stock Rom).

Can you support my phone, please?!
[Xposed Framework Modules] siavash2death:
[MENTION=4272306]tony78960[/MENTION]. Hi.Thanks for your great mod. I have a suggestion/request: Could you please add option for your mod to make the bar in notification panel transparent? It would be great. Thanks again.
[Xposed Framework Modules] Slem34:
Yes ! It was good

And he work on my S4 GTI9505 on 4..4.2 in Samy Deluxe Pick Your King ;)
[Xposed Framework Modules] nereis:
Great module!

One suggestion I'd prefer is to make the toolbox only show on notification panel, but not the quick settings panel.
[Xposed Framework Modules] datdirtyscrew:
Works on my T-Mobile LG G3 Stock ROM rooted. [emoji106] [emoji106]
[Xposed Framework Modules] EMK2000:
It works on my Samsung Galaxy Note 3 (SM-N9005) with stock TouchWiz rom and Android 4.4.2.
[Xposed Framework Modules] nvo2411:
Love it.

Works flawlessly on galaxy r with omni Rom.

Well done.
[Xposed Framework Modules] zamzameir:
can you make option for background to be transparent instead of black?:)
[Xposed Framework Modules] :
Doesn't work on 4.4.2, Elephone P10c
[Xposed Framework Modules] tony78960:
Sure, this feature is in the to-do list as I said a bit earlier.

Please, read the entire thread while it is still only 3 pages long :D

Thanks! Updated to the to-do list.
[Xposed Framework Modules] tony78960:
[MENTION=5918335]Slem34[/MENTION], [MENTION=2942431]datdirtyscrew[/MENTION], [MENTION=5916558]EMK2000[/MENTION], [MENTION=4428519]nvo2411[/MENTION] Thanks for your report!

(Sorry I am limited to 8 thanks per day, they will come later)

Could you please attach the last log from the Xposed Installer "Log" tab and your SystemUI.apk (should be located in /system/app or /system/priv-app) so I can support your ROM?
[Xposed Framework Modules] dorndi:
Is tasker integration planned?

This would be very nice, I want to regulate the brightness of the filter automatically by day time (e.g. dark from 21:00pm to 06:00am).

Best regards
[Xposed Framework Modules] Spere:
Working fine on both of my devices:

Note 3 (SM-N9005) - KitKat 4.4.2 (Touchwiz)

Note Pro 12.2 (SM-P905) - KitKat 4.4.2 (Touchwiz)

Waiting for Tasker support... I can imagine it already: some superhyper multitouch gesture using GMD Gesture Control, that enables this filter through Tasker. It also should hide (if possible) that slider from notification panel when disabled :)
[Xposed Framework Modules] tony78960:
Added to the to-do list!
[Xposed Framework Modules] Okluzhion:
Is it possible to add support for Sony devices? I can provide all the necessary files.

Sent from my eXposed C6603
[Xposed Framework Modules] kirkirehani93:
It aint working on kitkat 4.4.2
[Xposed Framework Modules] souler456:
Awesome! Just what I really need! :D

Works exquisitely on LG Optimus L3 running CM9 (ICS 4.0.4)... :good:

Don't have my trusty SGS2 yet to test it out... Will report if it also works as well... ;)

Great work, man! :good:

:D :) ;) :good:
[Xposed Framework Modules] tony78960:
Support is more a question of ROM rather than device because it depends on the SystemUI implementation.

Try Screen Filter first to see if it works out the box (do not forget to reboot). If not, then post the last error log from the "Log" tab of the Xposed Intaller (if you have some) and your SystemUI.apk so I can try to support your ROM.

Did you reboot your phone after activation of the module in the Xposed Installer?

If so, could you post the last error log from the "Log" tab of the Xposed Intaller and your SystemUI.apk in order to help me support your ROM?
[Xposed Framework Modules] zmaku:
Hi, I've just tried this nice module and I've found only one bug. When the Screen filter slider is set to be shown in the notifications I can't expand the other notifications with two fingers. When I set it to Hide when inactive then notifications are fine. I'm on 4.3 stock ROM, Samsung i9500.
[Xposed Framework Modules] Quipp:
Same problem here. When it's active. And you can see the slider bar. I can't see other notifications. And when it's hidden there's a gap. But I can see the notifications.

Is there a way so I can see them both?
[Xposed Framework Modules] oldman20:
Why can be that? can you expand to me? I use TFT screen with IPS. But I want to know how this mod working? Decrease bright or just cover whole creen with dark background transparent? That's all!