yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] tony78960:
Really strange... Could you try to have Screen Filter installed but not enabled in Xposed and see if there is still a fast battery usage (it would mean that another app is conflicting with Screen Filter).

In case the previous try does not reveal any particular battery drain, enable Screen Filter in Xposed and enable debug logging in Screen Filter (do not forget to reboot). Then after an hour or two, could PM me a full logcat and your Xposed log? Thank you!

BTW, are you using a stock ROM on your SG Note 3?

Thank you, exactly what I needed! Unfortunately, it seems that your "one handed mode" does not create a new virtual display. Thus, I don't know how to bypass its limitation (yet)...
[Xposed Framework Modules] Spere:
Well, this doesn't matter to me anymore. I edited the "blank area" background in one handed mode to black (should have been that by default). So now it looks better, wont consume battery (Note 3 AMOLED screen) and therefore no use for Screen Filter for that. Thanks for looking it anyway :)
[Xposed Framework Modules] mrbobo1:
Love the module, would it be possible to allow us to choose the color of the overlay so we could do similar to twilight instead of just the grey tint?
[Xposed Framework Modules] erik443:
Thanks, tony. It's unfortunate that Samsung uses a nonstandard way of handling those backlights. I googled around for an easy solution or some other app which does this, but didn't find anything useful.

There's a setting in the Touchwiz settings UI that controls the backlight (always on, always off, on for 1.5 seconds after touch, on for 6 seconds after touch), so I suppose in theory it would be possible to decompile the settings apk and figure out how it gets/sets that value... but that could be hard. Let me know if you want to investigate, and I'll be happy to help by sending you whatever I can. Otherwise, I understand if it's not worth the effort.
[Xposed Framework Modules] krazman325:
Still have the rapid battery loss without Screen Filter installed. I noticed gPlay updated recently without my knowledge. I'm wobderi g if ghat is causing my problem.

Stock ROM but rooted with original technique for att rom when N3 first came out.

---------- Post added at 10:17 PM ---------- Previous post was at 10:15 PM ----------

Should read: I'm wondering if that is causing my problem. Sorry for the fat finger typing.
[Xposed Framework Modules] krazman325:
My apologies. Definitely not Screen Filter causing my rapid battery depletion. Updated several other apps last night and today I have gone 17 hours on battery with 49% remaining. I will reinstall SF to confirm normal battery usage with SF installed. I will send logcat etc. if problem returns. Thank you.
[Xposed Framework Modules] Anyoe:
SimpleChinese Translation Update 2014/11/08

Color: -- 颜色

Customize -- 自定义

Double tap -- 双击

Long press -- 长按

Debug -- 调试

Disable hardware buttons backlight when filter is active -- 当屏幕过滤启用时禁用按键背光。
[Xposed Framework Modules] Kadilak Nupe:
Working on bigginsROM v 8.3

The eyes of us night owls thank you.

Sent from my SM-N900V running bigginsROM
[Xposed Framework Modules] Sam7777777:
Sir could you please provIde coloured filter like bluelight filter app does

Also the slider background colour to white (to match the surround colour)

Thank you!
[Xposed Framework Modules] TechnoSparks:
Hello.

This is a very nice module and I must say I use it every night!

But please allow me to request a quite simple feature.

Though I like the slider to be in notification drawer, I would prefer for it being available only when the master switch is flipped to "on". So, my notification drawer wouldn't be cluttered when I use my phone in broad daylight.

Thank you for such of a nice module.
[Xposed Framework Modules] ericsmart:
can you add colours filter, not just only blue but red, Brown and etc. good job btw
[Xposed Framework Modules] mauam:
Guys, please stop asking for features that are already in the "to do" list. Simply read the OP:)
[Xposed Framework Modules] tony78960:
Hello, all my apologize for not answering earlier, I was quite busy with my studies lately... Next week is going to be time consuming too.

I tried to work on a way to change the location of the toolbox (notification area or quick settings, top or bottom), but even for a pure AOSP based ROM it seems quite tricky.

Just imagine the difficulty of the task if I want to support various Stock ROM flavors! So for now, I leave this in a corner until I have more free time.

By the end of the weekend I will probably release a version allowing you to change filter's color.

Oh and yeah, don't forget to read the three first posts of this thread before requesting a new feature, it's probably already in the to-do list and I just need some time to implement it!

Thank you for your patience :good:
[Xposed Framework Modules] huladaddy:
Awesome! Any chance you can use the multiplication of pixel values as opposed to the addition of same?
[Xposed Framework Modules] ZeuseZ:
toolbox trouble

Module works fine when I start it from shortcut.

But there is not toolbox in extndd statusbar at all. And I couldn't on/off this option in app - checkbox is unable to change.

Samsung Galaxy Note stock 4.1.2 fw

N7000XXLT3

Please, check this trouble))

Thank you very much for this such a good module)))

(Screens, sysui and log are in attach.)
[Xposed Framework Modules] tony78960:
Well, it's a bit later than I expected but here is Screen Filter 1.3.3 beta.

Changelog:

Added ability to choose the color of the filter

Improved the readability of transparency range values in the range dialog

Updated Dutch, French, Simplified Chinese, Slovak & Spanish translations

The implemetation is still draft.

Choose a dark color for your filter, otherwise the filter will make your screen brighter! This is due to the filter being blended with an additive algorithm for now ([MENTION=4731217]huladaddy[/MENTION], implementing the multiplicative algorithm will take some time)

I'm off for this week, see you next weekend!
[Xposed Framework Modules] tony78960:
Thank you for your report, I will take a look at it next weekend.

In your screenshots, the fact that all checkboxes relative to the toolbox are grayed out means that your ROM is not supported yet... Thanks to your sysui I may be able to fix this soon.
[Xposed Framework Modules] pkWhistle:
Can't install the new beta. Even uninstalled previous version

No dice
[Xposed Framework Modules] The Fer-Shiz-Nizzle:
Couldn't install the update either.
[Xposed Framework Modules] Anyoe:
1.3.3 version could not install in MIUI v5 (Android 4.2.1).

And i found that many guys cannot install too. hope fix.

---------------Simple Chinese Translation Upadte 2014/11/18

Preview the changes in real-time -- 实时预览
[Xposed Framework Modules] Rom:
Same issue for me, i can't install last update, when i touch to install, an error message appears on the screen that the apps is not install..
[Xposed Framework Modules] 089man:
Here the same, can't install....

I9100 Tapatalk 4, Spirit-Rom 4.4. 4
[Xposed Framework Modules] 089man:
I9100 Tapatalk 4, Spirit-Rom 4.4. 4
[Xposed Framework Modules] Droidphilev:
+1

I think that last apk is corrupt
[Xposed Framework Modules] tony78960:
Ouch, such a newbie mistake: I forgot to sign the apk *facepalm*

I was really tired last night...

Sorry for that, I reuploaded the signed version :good:
[Xposed Framework Modules] PunchUp:
[MENTION=4272306]tony78960[/MENTION] can you please add an option to show the toolbox in status only when the filter is active?
[Xposed Framework Modules] Sam7777777:
Great Module, Really

Suggestion : clicking on app icon in notifications panel should open app settings screen

Thank you so much Sir
[Xposed Framework Modules] godly967:
After installing the new update, after restarting it tells me this, I've checked to make sure it's activated already

Edit

After clicking the module off and on and restarting it works again.

Did you see that ludicrous display last night?
[Xposed Framework Modules] sunwee:
Any idea what colour/settings to use to emulate something like the Blue Filter app?

Somehow Blue Filter seems brighter.
[Xposed Framework Modules] FoferX:
I have beta enabled but Xposed is only showing me version 1.3.2. Has 1.3.3b been taken down?
[Xposed Framework Modules] abhi08638:
On the download page I in the xposed repo, if you swipe all the way to the right, under version to be shown, set it to beta

sent from my amazingly awesome OnePlus One

Don't forget to hit thanks!
[Xposed Framework Modules] FoferX:
Yes, I already did that, which is why my short post started with the words "I have beta enabled..."

I'm still not seeing 1.3.3b even after refreshing, rebooting, etc.
[Xposed Framework Modules] mauam:
Try to play with colors till find some like those images from Twilight:)

BTW: [MENTION=4272306]tony78960[/MENTION], you're the man:cool:
[Xposed Framework Modules] abhi08638:
Oh didn't see that. Try wiping the xposed app's data
[Xposed Framework Modules] FoferX:
Thanks. I didn't want to wipe app data (via App Info) because I was afraid that would erase my installed modules in Xposed and all their settings too. So I did a "clear cache" instead. And then when I went back into Xposed, I noticed it was doing a full refresh, and then it presented the Screen Filter 1.3.3beta to me. Woo hoo! Thanks for the assist.

For what it's worth, I am using Xposed Installer version 2.7experimental 1.
[Xposed Framework Modules] TMFGO45:
Also can't install the new beta version. I'm on stock 4.3 MJE Note 3.
[Xposed Framework Modules] abhi08638:
You could try reading one post above yours

sent from my amazingly awesome OnePlus One

Don't forget to hit thanks!
[Xposed Framework Modules] soalokinx:
this module is amazing. ty only thing that would make it better for me would be a scheduler :)
[Xposed Framework Modules] divineBliss:
Sam7777777,

Do you know that long pressing on the icon in the notifications panel opens the settings screen? :)

---------- Post added at 11:16 AM ---------- Previous post was at 10:21 AM ----------

tony78960,

Thanks for v1.3.3b . Working great!

I noticed you added the version # to the About screen - it currently has "Screen Filter 1.3.3" for the beta version, but no big deal ;) .

Feature request:

* Would it be possible to add an on/off switch to the color line in the Settings screen, so we could selectively enable/disable color while the filter is active and not lose our current color settings positions? It looks like there's enough room to add a checkbox or on/off switch.

Bugs:

* If I move the color ring selector away from its default (e.g. to blue) and I leave the left control at its default top position and just move the right control away from its default bottom position, then click ok, then when I go back into the color settings screen, the color ring selector moves back to red by itself. Same thing happens if the left color control is moved off default and the right control is left in its default position. Only if both left and right controls are moved off their default position, then the color ring select keeps its position on the circle.

* From the settings screen If the current color selection is off (value box is 0 and color box is showing black), if I rotate my phone (rotation enabled), then after the settings screen changes orientation the color value box becomes blank and the color box goes from black to showing four smaller boxes - two white and two gray - in a checkerboard pattern. If I exit the settings screen and go back into it, the condition will be cleared (0 value and black box). I saw this on two different devices, so I think it's easily reproducible and not device dependent.

Thanks again! Keep up the studies and the great work on this app :) .
[Xposed Framework Modules] TMFGO45:
Deleted
[Xposed Framework Modules] divineBliss:
TMFGO45,

Did you try uninstalling the current version of Screen Filter from Xposed first, then installing the v1.3.3b version?
[Xposed Framework Modules] serega180765:
button auto start on boot

Very need function and buttonbutton autostart on reboot
[Xposed Framework Modules] sunwee:
Using 1.33b. For me the settings for color and brightness doesn't stick after reboot. Tried clearing the cache but didn't help.
[Xposed Framework Modules] tony78960:
I apologize in advance for the following long Q&A post :angel:

Why not! But then you will need to open the activity to enable the filter and show the toolbox (until other ways to control the filter are implemented).

Use a brownish/redish color to reduce blue screen effect.

You can use Locale or Tasker (or anything compatible with them) to control the filter programmatically!

As above, you can use Locale or Tasker to create a profile activating the filter after device boot.

Alright, the next beta will have a "b" in its version number ;)

I agree with your feature request, I will implement it in the next release: separating the dimming filter from the color filter will make the code easier to maintain.

Regarding the bugs:

This is the default behavior: filter's color is stored as RGB while the color editor use HSV (hue, saturation, value). When the black RVB color is converted to HSV, hue is defaulted to 0 (red on the circle), you can see the formula here.

Will be fixed in the next release, thanks for your report!

Cheers :cowboy:
[Xposed Framework Modules] PunchUp:
Sure! Thanks :good:
[Xposed Framework Modules] satsmagic:
Widget

The module works perfectly and is much better than the app.

Not sure anyone else asked for this,

Please add a widget toggle in addition to the control from Notification Bar., a tap on widget shall dim the screen to default value.
[Xposed Framework Modules] gorman42:
I've been using it with great satisfaction on my Galaxy Note 3, running 4.4.2. Just wanted to chime in to say thank you to the developer.
[Xposed Framework Modules] sunwee:
Earlier I reported that the settings doesn't hold after a reboot. Seems I was wrong. The setting especially colour filter gets reset at random occasions.
[Xposed Framework Modules] agentdr8:
Awesome project here OP. I've got a specific use-case for your module as a compliment to my module, XposedMTC. During device dimming time periods I'd like to fire an intent to your module to enable the screen filter. This would be a nice seamless integration without the need to install Tasker or Llama.

If you would consider adding a broadcast receiver for this purpose, it would be much appreciated.
[Xposed Framework Modules] tony78960:
I am about to release a new stable version :laugh: It introduce many changes and a lot of new/changed strings.

Could all the willing translators update their strings on Github?

Thank you!

Why not, but where could I find some informations about how to implement a compatible broadcast receiver?

Don't you want to adapt your application so it can handle Locale receivers? (That's what Tasker did)
[Xposed Framework Modules] pakitos:
Spanish done! :good:
[Xposed Framework Modules] agentdr8:
I don't mind adding Locale support to my module, but not everyone has Tasker/Locale/Llama installed. Listening for a specific intent isn't hard to implement. Here's an excerpt from my module to start and stop the service via intent:

Create a broadcast receiver class:

public class ServiceIntentReceiver extends BroadcastReceiver {

private static String TAG = "XMTC-IntentRecv";

[MENTION=439709]override[/MENTION]
public void onReceive(Context arg0, Intent arg1) {
Intent intent = new Intent(arg0, SunriseService.class);
if (arg1.getAction().equals("com.dr8.xposedmtc.START_SERVICE")) {
arg0.startService(intent);
Log.w(TAG, "SunriseService started via intent");
} else if (arg1.getAction().equals("com.dr8.xposedmtc.STOP_SERVICE")) {
arg0.stopService(intent);
Log.w(TAG, "SunriseService stopped via intent");
}
}

}

And the AndroidManifest.xml changes:

<receiver
android:enabled="true"
android:name=".receivers.ServiceIntentReceiver"
android:exported="true">
<intent-filter>
<action android:name="com.dr8.xposedmtc.START_SERVICE"/>
<action android:name="com.dr8.xposedmtc.STOP_SERVICE"/>
</intent-filter>
</receiver>
[Xposed Framework Modules] tony78960:
Screen Filter 1.4 is now available!

Changelog:

Refreshed UI: filter settings are separated from global settings

Color filter is now independent from darkening filter

Added ability to hide toolbox when the filter is disabled

Added help dialog

Changed the behavior of "change default" buttons, read the help dialog!

Many other internal changes, bug-fixes and improvements

Added Russian translation

Updated French, Japanese, Spanish translations

I you have any suggestion about the UI (you can see some updated screenshots in the OP), do not hesitate to give your opinion!

Now, the Tasker receiver needs to be updated to support the color filter... Then, I will concentrate on the hard task of improving the toolbox and making it compatible with more devices.
[Xposed Framework Modules] PunchUp:
The new update is great! The refreshed UI seems well sorted now.

Just a heads up to others. CAREFUL with the transparency settings in colour filter settings. I accidentally turned the whole screen into solid red :D

---------- Post added at 12:20 AM ---------- Previous post was at 12:12 AM ----------

Some feedback regarding the independent colour filter. I personally prefer the previous way. Now I have to enter settings activity in case I want to disable it temporarily

Could you make the independence optional?
[Xposed Framework Modules] tony78960:
Thanks for your snippets.

So, basically you want me to handle two different intents:

the com.dr8.xposedmtc.START_SERVICE intent to enable the filter,

the com.dr8.xposedmtc.STOP_SERVICE intent to disable the filter.

Is that right?

Don't you want to support customizable transparency/color values?

It's up to you, making your module able to handle Locale addons may let you control more apps without needing to ask developers to support your module.
[Xposed Framework Modules] tony78960:
Sure.

I wanted to add an option to toggle the color filter from the toolbox (linked with the darkening filter or separated), but first I needed to make the toolbox modular (which require a fair amount of work).

I will see what I can do :cowboy:
[Xposed Framework Modules] agentdr8:
Those are the intents that I listen for in my module. Yours would be named in your module namespace (something like com.tonymanou.screenfilter.START and .STOP).

As for changing values, I think the user could just do that themselves with the toolbox. They won't need to do it dynamically, as this would just be used to dim the screen further than the hardware backlight allows during night time hours.
[Xposed Framework Modules] mauam:
Juicy changelog:cool::good:
[Xposed Framework Modules] sunwee:
It's a great update. I hope you will update the Tasker integration for colour filters soon. Since I am not a fan of the toolbox method, using Tasker is my primary way of controlling the app.

Also looking forward to your implementation of the option to link screen and colour filter. Hope it will also be implemented via Tasker plugins.

This module has replaced 2 of my most used apps - Screen Filter and BlueScreen Filter. Thanks very much for this!
[Xposed Framework Modules] ZeuseZ:
Please, update this such a usefull mod for my ROM =)))

1.4v doesn't work for me((

Earlier details
[Xposed Framework Modules] twe90kid:
Can we get Tasker plug in for color filter?
[Xposed Framework Modules] Dark_Slayer:
Doesnt work on Note 2 after the 2nd Dec 2014 update.. it worked once.. then after another reboot bang... it doesnt... its my favourite xposed mod.. please fix
[Xposed Framework Modules] divineBliss:
v1.4 feedback and bug

hi tony78960,

Thank you for the great work on v1.4! It's working quite nicely and I like the enhancements you made.

Questions:

I'm not sure I understand how some of the controls for setting the color filter works.

1. What the function of the three slider bars in the dialog window with the circular color selector?

2. Can you explain the two semicircles represent within the color selector ring that change as the any of the three slider bars is changed.

3. What does each half of the two color filter sample boxes in the main settings window represent?

Bug:

Color Filter becomes disabled when device orientation is changed

1. Set device to auto rotation enabled.

2. Open Screen Filter settings dialog from toolbox.

3. Configure and enable both filters so you can see their effects. Keep Screen Filter settings dialog opened to see the bug happen after the next step.

4. Rotate device 90 degrees. The color filter will become disabled and the color filter switch will now be in the off position.

If in step 3 you exit the settings dialog window, the color filter remains enabled until the next time your enter the Screen Filter settings dialog. This bug was a fun/tricky one to figure out :) .

Color Filter becomes disabled when entering Screen Filter settings dialog

1. Open Screen Filter settings dialog.

2. Configure and enable both filters so you can see their effects, then exit Screen Filter settings dialog window.

3. Open Screen Filter settings dialog. The color filter will become disabled and the color filter switch will now be in the off position.

This second problem seems to be similar to the previous one above, so maybe the root cause is the same.

I see these problems happening on three different devices made by two different manufacturers - LG phones and Nexus 7 2013.

Suggestion:

* Change "?" to "Help" in the settings window. Seems that "Help" is more commonly used from what I have seen, but "?" is fine if you like it better.

* Consider changing the toolbox icon long press to double click to open the settings activity. It seems to me that double click would open the window faster than a long press :) .

Thanks again and keep up the great work!
[Xposed Framework Modules] PunchUp:
It's quite obvious.. Lightness, darkness and transparency.

Again quite obvious if you observe. The left semicircle is the current colour and the right semicircle is the new colour

Not sure if I understand this question properly. The upper half is only for darkness. The lower half lets you control the colour as well. Is that what you're asking?

All good here on my device. You should provide your device information and logs
[Xposed Framework Modules] Anyoe:
SimpleChinese Translation Update 2014/12/04

SimpleChinese Translation in ScreenFilter1.4.txt [MENTION=4272306]tony78960[/MENTION]
[Xposed Framework Modules] fullydeveloped:
Multiple Profiles

The only thing keeping me from switching from Twilight now is the ability to save multiple profiles, and quickly switching between them.
[Xposed Framework Modules] PunchUp:
Made a couple of icons if you'd like to use

I've tested the launcher icon using Nova. Looks fine..... But not sure about the notification icon. If you need any changes let me know or provide a test apk :)
[Xposed Framework Modules] iM7umd:
Nice work .. thank you
[Xposed Framework Modules] tony78960:
Most of your questions were well answered by [MENTION=5444464]PünchUp[/MENTION].

I would add that:

1. The true names of the 3 sliders are: saturation, value and alpha.

2. Touching the circle resets the right half with the color of the left half.

3. The left half of the color boxes represents the color without alpha, the right half is the real color (but you may not see what color it is due to alpha).

Thanks for pointing that out! I was able to reproduce these bugs, hope they will be fixed in the next release.

1. I chose "?" because it was taking less room on my small screen :3 But I can change it to "Help" for Large screens.

2. It is still in the to-do list! I just want to implement a better toolbox customization system first, otherwise there will be too many settings here and there.

Yes, the last release was only about the color filter, not the toolbox. I will try to fix your issue in the next release.

Please describe the problem you are facing: activity crash? SystemUI crash? no toolbox? no darkening filter effect? no color filter effect? other?...

Does it sorts things if you untick/retick your ticked settings and tick/untick your unticked settings?

Also please provide your Xposed logs, and perhaps a full logcat too.