yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] Maxr1998:
Here's the new beta. As I said, I dramatically improved lockscreen load time (by 400ms!), and the app now protects itself from being disabled as a device admin.
[Xposed Framework Modules] yurividal:
Any chance of adding time-pin??
[Xposed Framework Modules] slonn:
It is a bit of a gamble to change the lock screen resolution. The app recognises that my phone can be set as tablet mode and when I did that only three digits per time shows up. That's a real bummer when using a 4 unique digit pin code...
[Xposed Framework Modules] Maxr1998:
Which device do you use? That's why I add an option to switch modes..

Oh, and you didn't change your dpi, did you?
[Xposed Framework Modules] slonn:
LG G4 H818P. I didn't change the dpi...not sure how to do that
[Xposed Framework Modules] Spookymyo:
Great app!

I had some issues initially. Any time I tried to add an app to be locked it force closed every time I pressed the grid icon, check mark, or X at the top. And none of the apps would lock until I did a restart, this might be normal though. I tried to send a log but it never generated a log file. I got it fixed though...I think.

I have a suggestion however. It really needs the ability to crop an image when you set a custom background. As it is you have to pick a picture that is exactly the right dimensions to get it to fit right.
[Xposed Framework Modules] Maxr1998:
I also got that crash at the toolbar some time ago, I'll look into it.

You were using the inbuilt report option? It might not have permission to write to storage if you're running Marshmallow.

I always wanted to add a scaling option, but I didn't have the time for it considering all the other things.

Currently, the app scales and centers the image to fit most of it onto the screen.

That option is already there, scroll way to the bottom on the screen where you set 5 mins relock time ;)
[Xposed Framework Modules] yurividal:
Same issue on Galaxy S5 Running CM13.

Would be awesome if we could resize the pin pad to become smaller. The default one takes up almost the while screen, and it is not so easy to type one-handed.

And the tablet mode screws it up just like the screenshot.

(Running latest beta version)
[Xposed Framework Modules] Maxr1998:
I will definitely refine it soon. The default one is surely not what it's meant to be (that's why it's still a beta). Anyway, I will update you when I fixed it.
[Xposed Framework Modules] Spookymyo:
Thanks.

Yeah I saw the relock option after I sent you an email.

I'm on 5.1 and yes I used the built in reporting function.
[Xposed Framework Modules] xringo:
So there seems to way to bypass this. Not sure if its been brought up..

It goes like this, if you set up a lockscreen pin on a app. Click the app, as its opening, quickly press the back key, removes the pin screen and goes right into the app. It works quite a lot. I took a screen recording

https://drive.google.com/file/d/0Bx1tFrvB2S-WRDlXSVVrcWhJWGs/view?usp=sharing

In the video it took me a few trys, for some reason my nexus 6p is very slow when using screen recorder but in the last few seconds you can see I bypassed the screenlock.
[Xposed Framework Modules] Spookymyo:
I can confirm this bug

Eric

VZW LG G4

Rooted

Android 5.1

Stock ROM

Stock Kernel
[Xposed Framework Modules] Maxr1998:
Weird. Do you think you could extract me your logcat manually?

I can confirm. The bugs exists since last? release, and I haven't found a good fix yet. It's probably caused by some sort of concurrency... I hope I'll find a fix soon.
[Xposed Framework Modules] slonn:
Any update on a fix? This is quite a serious bug...
[Xposed Framework Modules] Maxr1998:
I have a German exam tomorrow, so no. I will hopefully be able to test some of my ideas for fixing it tomorrow afternoon.
[Xposed Framework Modules] barani kumar:
G:):)d luck in exam.
[Xposed Framework Modules] ashok:
is the fingerprint option is available in lollipop?
[Xposed Framework Modules] 65vdub:
I believe it's marshmallow only since it utilizes the fingerprint api in marshmallow.
[Xposed Framework Modules] Maxr1998:
That's right.
[Xposed Framework Modules] :
[MENTION=5222551]Maxr1998[/MENTION], can I send you a pull request with Gesture Unlock? I have implemented it as a lock screen for unlocking the phone, maybe you could implement it in the MaxLock app?
[Xposed Framework Modules] Maxr1998:
Well, I don't know if you would code it the way I need it, but I would be thankful if I could cherry-pick it :)
[Xposed Framework Modules] :
I will try to understand your code and then do it, thanks for the opportunity. Will get back in a few days to you.
[Xposed Framework Modules] yurividal:
Any possibility you can merge it to cyanogenmod 13 too? Sorry for the off topic.
[Xposed Framework Modules] :
Sent you a pull request, let's continue the conversation on Github

No, my laptop fails to build ROMs for some unidentifiable reason, so I will not be able to do so. However, if you would like to do it yourself, these are the relevant commits

https://github.com/temasek/android_frameworks_base/commit/d89f57baa936d6c2114e1a3726ca4f4f8f2b2437

https://github.com/temasek/android_...mmit/8fea9e778259df367066c2e74708dedc6498ff87
[Xposed Framework Modules] Zenith:
Feature request:

Is there any chance you could add a 5x5 pattern option?
[Xposed Framework Modules] Maxr1998:
Thanks for your report, I will fix the bug later. Could you also tell me the output of "pm list packages | grep packageinstaller" in either a terminal or adb shell? Thanks again :)
[Xposed Framework Modules] fddm:
It says it's there:

com.google.android.packageinstaller

I was just being a dummy and did not enable "Show System Apps" when looking it up. It's still the case that it does not appear in the app list within Maxlock and clearing data and going through initial setup doesn't seem to help.
[Xposed Framework Modules] Maxr1998:
Oooh now I know, the fix isn't there in the current stable version. Try the beta posted a few pages back, that should work.
[Xposed Framework Modules] Maxr1998:
Ok, I think I fixed the bug. I'll post a new beta soon, please report back when that happened ;)
[Xposed Framework Modules] slonn:
Will the update fix the back button override issue on pin lock as well?
[Xposed Framework Modules] Maxr1998:
I hope so. But I don't have much time lately. Driving license, school, etc. The little time I work on MaxLock is spent on code cleanup and some fixes.
[Xposed Framework Modules] SyCoREAPER:
Maybe I am just blind but where is the fingerprint option?

nvm, appears at the unlock. But there is a severe startup delay before Maxlock actually starts locking apps. And back button is still an issue, shame. You have a great app but its still not daily driver ready.
[Xposed Framework Modules] Maxr1998:
The reason behind this is Android's awful, crappy, and never finished multi-process SharedPreferences implementation. I already switched to a hacked-together JSON storage for the unlock handling, but that has the problem of race conditions, which lead into back button unlocking. When I finally have time this weekend, I will debug this issue and make sure file contents get written before they get read. So it's definitely not as easy as you might think.
[Xposed Framework Modules] nextheart:
Thanks Maxr1998, this is really a very good app lock.

I would like to suggest some features to make it more awesome.

Feature request 1: Please enable phone screen lock.

Feature request 2: Please enable custom fake crash massage like "check you internet connection", or "admin rights required to open this app", or "root not found in this device", or "this app is not installed properly, reinstall the app" etc.

Feature request 3: Please enable time pin with variations like reverse time pin, XX number before time pin, +or- X in time pin etc.

Feature request 4: Please enable position of squares and number of squares in Knock lock.

Thanks again for your kind attention.
[Xposed Framework Modules] TechnoSparks:
I dont think this is necessary, as it is out of the scope of the module; to lock apps

Fake Crash already exists! You can choose per-app switch by navigating in "Select apps", hit the cog icon for the app your prefer, and tick "Fake crash". On "Report" button press, you will be presented with "Report problem" and a text bar, requiring you to put a passphrase to dismiss the dialogue and show the lockscreen. this is more like a 2-layer-locking. You can alter the fake-crash behaviour in MaxLock > Locking Options. An option to change the crash message however, isnt available

I dont really understand about this one

Might not happen, this old knock code still was replaced with the current "relative" knock code based on the favour of the developer.
[Xposed Framework Modules] nextheart:
Dear Sir,

Thanks for you kind help.

1. Locking phone screen with knock code will be good, unknown person cannot unlock the phone until he/she knows that how to unlock phone.

2. I know fake crash exist in the app, but I suggested about custom crash message.

3. To know more about Time PIN, search apps by "Time Pin" in play store. In short, pin changes with current time.

4. It is just a request. It would be very great, if possible.

Thanks again for your taking interest in my post.
[Xposed Framework Modules] SyCoREAPER:
1) Again, not purpose of this app. There is another xposed module you can you http://repo.xposed.info/module/me.rijul.knockcode

2) What's the point? The point of an error message is to make it appear authentic. If you change the verbiage it will be clear it's a fake crash and defeats the entire purpose.

3) Still no clue what you mean but that's pointless. Don't give your phone to strangers.

4) I've asked for this but I don't think dev want's to add it but at this point I've actually grown to like it without.
[Xposed Framework Modules] TechnoSparks:
I see, I will look into the Time Pin soon ;) Seems like a neat thing though!
[Xposed Framework Modules] Maxr1998:
1. I won't implement it, because it's just outside of the purpose of this app. Look at the suggestion of [MENTION=1506211]SyCoREAPER[/MENTION].

2. I will consider this for the future. But also take a look at the response of SyCoREAPER again.. He is right imo, the fake die should be as legit as possible - that's also why I used DeviceDefault theme and not the Material appcompat theme for the dialog.

3. That feature is highly insecure and total junk in my opinion - I am not sure if I want to encourage people to use it by adding it.

4. Knock code now uses relative touch targets, so there aren't dividers anymore. I plant to add some in-app help for users to understand the new-but-actually-not-so-new-anymore system.
[Xposed Framework Modules] Maxr1998:
Good news everyone!

I finally fixed back key unlocking :)

After some extensive logging I found out it had nothing to do with my speculations above, the bug turned out to be caused by Android's weird activity lifecycle management. Luckily, I could easily fix it with another hook.

I attached an apk for you to test below.

Other changes include some UI improvements (= more MD) for devices with KitKat and below and a few bug fixes.

Oh, and take a look at the app's size - Proguard, resource shrinking and VectorDrawableCompat ftw :D

(old version had roughly 4MB)

AlertService™: [MENTION=4680476]barani kumar[/MENTION], [MENTION=3711980]fddm[/MENTION], [MENTION=3148573]slonn[/MENTION], [MENTION=732771]Spookymyo[/MENTION], [MENTION=4121750]xringo[/MENTION], [MENTION=965229]yurividal[/MENTION]
[Xposed Framework Modules] SyCoREAPER:
Downloading now. Thanks
[Xposed Framework Modules] yurividal:
Thanks! Downloading and will test thought the day tomorrow. I'll report back. Thanks once again
[Xposed Framework Modules] SyCoREAPER:
Unable to bypass from quick testing I did. I missed the boot and am low on battery so I can't test the startup delay experienced previously but bypass appears fixed!
[Xposed Framework Modules] nextheart:
Dear Sir, Thanks you for your kind support. I have found an alternative app containing features I was looking for. Thanks again for your help.
[Xposed Framework Modules] yurividal:
O

I have tested, and the lag to open the lock is really gone! Good job.

I use pin, and there is still a small lag (1,or 2 seconds) after the number pad shows, before I can start typing the pin. But the rest, all works Fine!
[Xposed Framework Modules] yurividal:
[MENTION=5222551]Maxr1998[/MENTION] I am getting FC when try to add new apps to lock in latest beta. =(
[Xposed Framework Modules] fddm:
[MENTION=5222551]Maxr1998[/MENTION] I tested the new build, and the FC on lockscreen is now fixed for the Nook HD+ for both orientations. What's new is the pattern does not appear centered anymore(top-left in portrait and top right in landscape), but this is barely noteworthy since it does not effect function. I also get the FC yurividal mentioned, but it works awesome apart from that, thanks!
[Xposed Framework Modules] slonn:
Brilliant with the latest update for the pin lock fix! Hoping that lock delay and smaller pin area will be implemented as well.
[Xposed Framework Modules] Maxr1998:
When you report crashes, please also always include logs! Logcat for crashes and ANRs, Xposed logs when the locking doesn't work.
[Xposed Framework Modules] SyCoREAPER:
[MENTION=5222551]Maxr1998[/MENTION]

Looks like you squashed the two biggest bugs!

1) Startup app launch leak is fixed.

2) Bypassing lockscreen appears to be fixed too.

Great job. Will do some further testing and donation/purchase coming your way.
[Xposed Framework Modules] Maxr1998:
MaxLock 6.2 RC1

This is the final MaxLock 6.2, from now on I will only push bug fixes. Please test _EVERYTHING_ and report any crashes or bugs with complete logs. Use the inbuilt report option for that :)

I reworked lockscreen margins, and could finally ditch the so called "tablet mode". Also, I added a sweet animation when entering PIN or password wrong. Make sure to check it out ;)
[Xposed Framework Modules] sathishcoumar:
On selecting Choose apps, it crashes every time.
[Xposed Framework Modules] Maxr1998:
Logs?
[Xposed Framework Modules] Vernyak:
Just sent using internal bug report.
[Xposed Framework Modules] slonn:
Same here. Log sent.
[Xposed Framework Modules] Maxr1998:
Thanks, received them. Really strange bug, caused by the Android support search view. I'll look at what I can do.
[Xposed Framework Modules] Vernyak:
If it helps - Galaxy note 3, Pronesis 6.2 firmware (ported Note 5 Android 5.1.1)
[Xposed Framework Modules] Spookymyo:
I'm getting the same thing. I had to revert back to the previous version.

Also the new app post is 6.1.1 not 6.2

---------------------------

VZW LG G4

Rooted

Android 5.1

Stock ROM

Stock Kernel
[Xposed Framework Modules] Maxr1998:
Yeah, I was to lazy to update the version number :D

Also, it is only a RC, so I will change it the time I push it to GPlay. I want to fix 3 things tomorrow, then I'll post a last RC and hopefully push it on Saturday.

I wonder how I couldn't reproduce that crash myself. I tested it on frickin' 4 devices, 5 roms, 3 Android versions, and didn't get it. I will have to do some research tomorrow.
[Xposed Framework Modules] Maxr1998:
No need to tell me, your report.zip contains everything I need ;)

Device name, Android version, logcat and xposed logs, MaxLock settings, the temp files..

Aaahh, I am so glad I added this feature! :) :)
[Xposed Framework Modules] Maxr1998:
Well, that explains everything: ProGuard optimized away the SearchView constructor, that's why it didn't crash for me (I'm only using debug versions). I'll have to report that bug to the support library devs, that they can fix it on their own. For now I just fixed it in my ProGuard config.

I also improved Talkback support, and fixed that weird bug that opened the changelog in the browser instead of the dialog. Though you won't see it until next official release.
[Xposed Framework Modules] mondohow:
This fixes the FC on adding new apps. Everything else seems to work as good as usual. Thanks for your continued support of this.
[Xposed Framework Modules] pranjal18:
Hi! This is damn good stuff! It's definitely an awesome improvement over minminlock!!

Please resolve one issue please. I think it might have been reported already.

The issue is...suppose I lock the clock app. I open the clock app and enter the password which gives me access to the app.

When I press the back button, the app exits. When I reopen the app, then it doesn't ask for the password again.

The lock for that particular app is reactivated when I close all recent apps (long press the home button).

I know it sounds weird, but can you look into the issue please? :)
[Xposed Framework Modules] Maxr1998:
It's known and I can't do very much about it, but I will at least try to fix it.

I switched to SHA-256, will come in next release, note you'll have to wipe data then..

I'm still looking to fix master switch, I hope I get it working soon. It'll probably still take some time to the next release, I want to get everything perfect before..

Beamed to you faster than the speed of magic by my Nexus⁴ on Android Lollipop 5.0
[Xposed Framework Modules] CHEF-KOCH:
Thank you, awesome app which not drains the ?. Keep up you're good work man! Thanks again, sr for OT but someone needs to say it ?.
[Xposed Framework Modules] TechnoSparks:
I actually prefer it being still unlocked until recent apps is closed. If you manage to find a way to really ask for unlock code every time it opens, could you consider preserving the old mechanism too? Which I meant the current way of the applock whereas an app will never get locked unless swiped away from the recent apps list.

Thank you :D
[Xposed Framework Modules] KOHO:
Possible to add multiple passwords?

Great app!! Love it very much~

Is it possible to add feature on having multiple pins/passwords to apply to different apps? If you can implement this feature in this already awesome app, it will be greater than awesome!! :D

Thanks Dev~
[Xposed Framework Modules] Maxr1998:
New experimental release! This is just for testing a bit and that you don't have to wait any longer ;)

Changes:

- App now uses sha-256 to encrypt.

YOU'LL HAVE TO CLEAR APP'S DATA AFTER INSTALLATION or you can't unlock apps anymore!

Deleting keys.xml and packagename_preferences.xml in app data directory should be also enough

- New UI options, e.g. black text color, hide app name, hide input box

- Clear current input button next to input box

- Now using Async task for loading app list, less laggy and with a nice dialog :)

- bug fixes, translation updates, etc.

DOWNLOAD: https://www.dropbox.com/s/mfpos1cqgy0wdg5/MaxLock_2.1.1.apk?dl=0

Please don't report any bugs, I know about them, this is experimental :)

Sent using my nexus⁴ running Mahdi 2.8 with Xposed and hells-Core B59-f
[Xposed Framework Modules] Maxr1998:
I will do this, but I first want to completely fix all the bugs and cleanup the code, then I will add new features again

Sent using my nexus⁴ running Mahdi 2.8 with Xposed and hells-Core B59-f
[Xposed Framework Modules] mnhs1010:
Is it not possible to implement lock policy after screen off and on every time app opening? In future is it possible?

Clearing apps from recents looking not comfort for me:'(
[Xposed Framework Modules] nikctsh:
Its not an issue, its actually a feature :)
[Xposed Framework Modules] Maxr1998:
You don't actually need to close it from recents, closing the app with back button is enough most time. The activity just needs to be destroyed, that the onCreate() method is called again and the lock appears. Look at http://developer.android.com/guide/components/activities.html for more info

Sent using my nexus⁴ running Mahdi 2.8 with Xposed and hells-Core B59-f
[Xposed Framework Modules] Patryipe:
Agreed!
[Xposed Framework Modules] mnhs1010:
But in my case ,lock screen never appeared unless the locked apps are not cleared from the recent list.
[Xposed Framework Modules] Maxr1998:
That's true, the activity needs to be destroyed to be locked again. This happens after some time, but it is destroyed immediately when closing from recents..

Sent using my nexus⁴ running Mahdi 2.8 with Xposed and hells-Core B59-f
[Xposed Framework Modules] mnhs1010:
So,you are not going to implement another locking mechanism?
[Xposed Framework Modules] Maxr1998:
I am still trying too. E.g. I hooked the onResume method (current version also does) but it still only shows lockscreen on first app opening. Really don't know what to do :/

Sent using my nexus⁴ running Mahdi 2.8 with Xposed and hells-Core B59-f
[Xposed Framework Modules] mnhs1010:
Excited for the update,hope dev will find a good mechanism of locking e.g on every openning & after screen off.
[Xposed Framework Modules] Mothamoz:
Why is it that maxlock isn't locking my WhatsApp properly? It asks for the knock code once after booting my device, then never again :(
[Xposed Framework Modules] Maxr1998:
Works for me :/

Don't know what's the problem for you..did you clear the app from recents?

Sent using my nexus⁴ running Mahdi 2.8 with Xposed and hells-Core B59-f
[Xposed Framework Modules] Mothamoz:
Yeah I did, also cleared the ram just to check, rebooted and checked again, still won't lock it down ?
[Xposed Framework Modules] Maxr1998:
What rom/device do you use?

=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=

I'll publish a new build next week, stay tuned!

Sent using my nexus⁴ running Mahdi 2.8 with Xposed and hells-Core B59-f
[Xposed Framework Modules] sathishcoumar:
Thumbs up....

All working fine...

Good work, max dear.
[Xposed Framework Modules] Spookymyo:
Works great!

Still shows 6.1.1 in the about section. ?

---------------------------

VZW LG G4

Rooted

Android 5.1

Stock ROM

Stock Kernel
[Xposed Framework Modules] yurividal:
New beta is awesome. The size of the number pad fannaly got smaller (on my s5) and it looks much neater now! Also, the FC is gone.

One thing : I still have a small delay after the dial pad shows and before I can start typing the number pin. I have to wait like 1 second after the numbers show, to be able to enter the pin.

Nothing too big, though

Thanks for the amazing work!!
[Xposed Framework Modules] Maxr1998:
I can't reproduce this issue, I can start typing immediately. Could you maybe do a screenrecord and pm me the video?

[MENTION=4756497]liveasx[/MENTION], [MENTION=6313849]alex king[/MENTION], [MENTION=3783030]t61p[/MENTION] could you do a last update on translations today? I want to push a new version this evening.
[Xposed Framework Modules] alex king:
[MENTION=5222551]Maxr1998[/MENTION] Done
[Xposed Framework Modules] Maxr1998:
Already seen it, thanks! I will merge it later.
[Xposed Framework Modules] t61p:
I've just sent a pull request.

Btw, It's already tommorow here in Japan. :p
[Xposed Framework Modules] Maxr1998:
Thanks for the fast response! :) I will merge it in a minute.

If you're honest, it's also today in Japan, just another today, which would be today for me. And then, this is the today I mean. Errrr, yeah. ;)
[Xposed Framework Modules] Maxr1998:
Okay, since I didn't want to ship MaxLock without finished translations, I didn't release MaxLock yesterday, but I will do so later.

If there's anyone who wants to update translations which aren't complete currently (French, Italian & Spanish), feel free to download the strings on GitHub. Additionally, I always welcome new translated languages (would be pretty interested in Russian and Portuguese currently :)). Thanks in advance for your contribution! :D
[Xposed Framework Modules] Vernyak:
I could easily translate into Russian but never used GitHub and don't even know how to use it. Can you make a hint or direct link to ease the process?
[Xposed Framework Modules] Maxr1998:
Well, you don't have to use GitHub, I can also merge the strings manually, then you don't need to create an account as well.

Download this file, then translate everything in between ..> and </string>. Make sure to escape apostrophes and quotation marks with \, and keep the %s/etc at sensible positions. When you're done, pm me the file or a link to download the file, I'll then merge it and send you a test apk that you can check if every translation makes sense.

Thanks for your contribution!

Oh, and please don't translate MaxLock, Xposed, MasterSwitch, I.Mod, Knock code, Tasker and AMOLED.