yashsingh1/xdaforums huggingface dataset:
[Android Builders Collective] dankoman:
Tabs thing is frameworks support issue. Google doesn't update certain aspects of aosp.

See 3 latest commits here, fixes the tabs issue:

https://github.com/SlimRoms/frameworks_support/commits/staging/mm6.0
[Android Builders Collective] ezio84:
Uh, thanks a lot Daniel!
[Android Builders Collective] dankoman:
No prob! Griffin whacked that bug 2 weeks ago. It was a glitch with SDK 22 and 23.0, and was fixed finally with SDK 23.1. Only problem is Google never updated support repo for aosp to include necessary patches. Here's the original bug if you're interested:

https://code.google.com/p/android/issues/detail?id=183127
[Android Builders Collective] Yank555:
Where can I easily check this, I checked a few apps, seems fine on my end, so I'm a bit surprised ?

JP.
[Android Builders Collective] ezio84:
Thanks again :D

I've noticed it only in the caf AppOps at the moment.
[Android Builders Collective] dankoman:
any ViewPager layout that uses PagerTabStrip/PagerTitleStrip. many ViewPagers that have tabs are still using TabLayout instead of PagerTabStrip because of this bug. the issue won't appear with TabLayout because the bug is in the PagerTabStrip/PagerTitleStrip class.

also, the bug might not manifest unless the ViewPager pages that are densely-populated, as is the case for AppOps.
[Android Builders Collective] Mikulec:
[MENTION=2033478]Yank555[/MENTION] I dont know if anyone already reported it, but the new build fixed the weird led notification colors. I can now set almost all colors and even darken the colors so they dont shine so much.
[Android Builders Collective] Yank555:
Seriously ?!?!??! We're talking angler, right ?

Just tested, not for me at least... stock kernel ? If you use a different kernel, someone might have fixed that thing ... wanted to have a look, but been kept too busy by Google lately :D

JP.

EDIT : Good find ;)

--> https://github.com/flar2/angler/commit/0adfad2a6f3d78015dcf19e94594a2b112341dc9

Edit 2:

Guess what, the "new" kernel has that implemented already ;)

--> https://android.googlesource.com/kernel/msm/+/85d6f74f9082451765c027c19cea15f3c9eeebe5
[Android Builders Collective] ezio84:
Hey Dan i was checking now, both master and android-6.0.1_r22 aosp branches already have those 3 commits

Edit: yup, AppOps tabs issue fixed with the r22 tag.

Thanks again D!
[Android Builders Collective] Mikulec:
Looks like you were quicker than me, yes, I am on ElementalX. So they finaly fixed it. :D
[Android Builders Collective] Yank555:
So here we are ... ;)

JP.

Edit :

Sources are up : https://github.com/YAOSP/manifest

Angler can be downloaded directly from here : https://www.androidfilehost.com/?fid=24438995911975942
[Android Builders Collective] adm1jtg:
[MENTION=2033478]Yank555[/MENTION] Found a small bug in your shamu 1.0 release. The new charging led for quickcharge works fine BUT when we hit 100% or even 20 min after 100% the led never changes to completed color.

AKA I have the leds set as follows:

low = red

charging = green

fast charging = blue

done = black or no led light

When I plug it in the colors change properly from red to blue (I use a quick charger) but no matter how long I wait the blue never goes to black or off. on 97 i know it took an extra few minutes and got used to that but I left it 20 min past 100% and still blue. I am betting somehow the fastcharging still registers as pushing current indefinitely but thats just my guess.

Actually I just did another test and something with the code isn't right. I just took it off the quickcharger @ 100% having waited like 20 min and put it on a regular charger, i think its a 5v 1a or so and the charging light is still blue, not green like I was expecting and not going black either as its at 100% it should have turned black/off within a few minutes and its not.

Edit: just had a thought I am using elite kernel for testing atm I will check and see if reverting to your included kernel fixes this

Update: Reverting to your kernel seems to have no effect the above issues still exist, no change.

Update #2: Finally changed to off on the regular charger but may have been cause I rebooted. Will test more tomorrow as its late
[Android Builders Collective] Yank555:
That's not a bug but a feature ;)

Full = when charging stops, not when 100% is reached

Battery still gets charged even when 100% is reached, I want to know when charging really stops, so I changed it in that way.

Full is reached (on angler) about 30-40 minutes

after

100% is reached.

Note : If you get fast charge color with a non fast charge charger, you have an out of spec cable, there are many (mine is too). Google had been complaining about this in social media.

Test with the tiny cable that came with the phone, you'll see it works.

The system can't work if detection logic is fooled.

To validate what I'm saying, use any ROM and look at the text on lockscreen, with a bad cable it will always show 'charging quickly'.

JP.

Sent from my Nexus 6P running Yank555.lu YAOSP-M 6.0.1_r17 v1.00
[Android Builders Collective] VictorLapin:
Blue led for cable charging here as well. I use flo cable to power up my hammerhead :)
[Android Builders Collective] Yank555:
Blue means, maxcurrent reported is above 1500mA/h.

I wanted to add the actual figure to be displayed on lockscreen, may make sense to add this ;)

On angler, I had it wrongly reported (but that's consistent with what lockscreen shows, as it's done at the root that keeps keyguard informed) with my 3rd party cable, but correctly reported with stock cable that came with the device.

On a sidenote, USB-C cables are known to be mostly out of spec :( Which shouldn't be the case for microUSB cables, though.

JP.
[Android Builders Collective] t0mas_:
sorry about the delay, but here are the logs of the appopps crash...
[Android Builders Collective] dankoman:
Better late than never. oh, Google. Tsk tsk.
[Android Builders Collective] ezio84:
PureNexus mod 6.0.1-20160311 :D

Download for Hammerhead: https://www.androidfilehost.com/?w=files&flid=50100

Changelog:

AppOps:

- Fix race condition when collecting op callback

- Fix missing tabs title when opening the app the first time

- Merge tag 'android-6.0.1_r22' from Aosp (some fixes around)

- Update to MHC19J build version

Installation, tips, info: check the 6th post of this thread: http://xdaforums.com/showpost.php?p=55121776&postcount=6

PS: if you have problems, call A-team or clean flash.
[Android Builders Collective] coolek33:
Darn, [MENTION=2095315]ezio84[/MENTION]. I love your n5 PN mod. Maybe you consider building for other devices after all. I would like to make my wife in other way ;) She's using n4 with unofficial PN build. I've asked it's builder but he's building from source only without any additional picks. And she misses slimpie/navbar so badly :p I in other hand miss them on Flo. Maybe if had some time... I know you're busy, but... Ehh, thanks for making me happy anyway :D
[Android Builders Collective] ezio84:
Nope :p

But aside the multirom support and the different dpi value, there are no other changes in the stock PN device and kernel trees, so if there's an official PN version for Flo and mako you can build also the mod using my local manifest and the needed kernel/device trees ;)
[Android Builders Collective] Yank555:
YAOSP-MM v1.00 MHC19J Update

Available for all 4 devices : angler, shamu, hammerhead & flounder (all tested)

Sources are up to date on github as well.

Changelog & Download links as usual : https://github.com/YAOSP/manifest#changelog

Note : MHC19J is

not

the last file in the list, pay attention to MHC19J build tag.

JP.
[Android Builders Collective] Garrykd:
^^>> PureNexus mod 6.0.1-20160311 angler version

:p

PS. Probably a good idea to upgrade to twrp 3.0.0-1
[Android Builders Collective] VictorLapin:
I've had some troubles with my hammerhead, so JP shamelessly ninja'd me :D:D
[Android Builders Collective] damngood98:
Let me know if I'm going about this incorrectly by all means

Updating to this would also mean needing to update the vendor, no? System is showing mch19j but factory image from Google for the 6p is mch19i ... Flashing the vendor image results in an initial warning after first boot
[Android Builders Collective] efan3719:
mch19j build is for the 5X on the factory image site. there doesnt seem to be a vendor image (at least for the 6P) anywhere. i dont know enough about the vendor partition to know if it's ok to flash an img from a different device... probably not..
[Android Builders Collective] Garrykd:
Not sure. I would assume the new vendor image would be necessary. I didn't bother updating the vendor image when i flashed the rom because i just wanted to make sure it worked. Now that you mention it, I do recall i didn't get the warning.

Just to be sure, i clobbered my source and started another build (vendor stuff has sometimes required this in the past). Should be a couple hours.

If its not that, it might be a difference in versioning.

Sorry for the inconvenience and thanks for bringing it to my attention :o:)

Edit: MHC19I is the correct vendor image but the build fingerprint in pn source has not been updated yet for angler. I'll update that (if i can find it) and build again.

Pps: If anyone is running a MHC19I rom, could you please tell me what the ro.build.fingerprint line is in your build.prop? Thanks.
[Android Builders Collective] amphi66:
All seems well.except FC of the AOSP Browser. Clearing cache (& even data) doesn't help. Browser is OK in Chroma. Any ideas? Good to have you back, BTW!
[Android Builders Collective] efan3719:
I've done just that! Here's a PN-mod build for Flo if anyone wants it.

https://www.androidfilehost.com/?fid=24438995911977147

Thanks to [MENTION=2095315]ezio84[/MENTION] for the mods, [MENTION=4395895]BeansTown106[/MENTION] for the source, and [MENTION=2640853]Garrykd[/MENTION] for the help. :good:
[Android Builders Collective] coolek33:
Efan, my hero. Works like a charm. Now, who's out there want to build it for mako? :>
[Android Builders Collective] ezio84:
Yes, fingerprint needs to match the last vendor img for Angler to avoid the warning message :p

Aosp browser has been removed from my build. Where did you grab it from?

Maybe it needs the HTMLViewer. Try to install it:

https://www.androidfilehost.com/?fid=24438995911977245
[Android Builders Collective] Yank555:
Has PN been rebased on MHC branch yet ? If not, I'd stick to MMB29V, vendor and fingerprint.

MMB and MHC branches have totally dissociated commit histories !

JP.
[Android Builders Collective] ezio84:
Yes, on mhc now.

And the r22 tag gives some good fixes on hh too, i had problems with my mpow headest but now they work :D

Also the DoNotDisturb mode should be fixed now.
[Android Builders Collective] kantjer:
PN fingerprint is still at MMB29V
[Android Builders Collective] ezio84:
Here are the new fingerprint for MHC19I on 6p (thanks CM) so you can use the last vendor.img without the version warning at boot:

BUILD_FINGERPRINT=google/angler/angler:6.0.1/MHC19I/2590160:user/release-keys \
PRIVATE_BUILD_DESC="angler-user 6.0.1 MHC19I 2590160 release-keys"

---------- Post added at 12:05 PM ---------- Previous post was at 11:54 AM ----------

And thanks Nate for the bullhead fingerprint too :D

https://github.com/PureNexusProject...mmit/54dea144492528d8d7d22871be6556ef2fc63163
[Android Builders Collective] Yank555:
Fingerprint (i.e. for vendor check) or code rebase on r22 branch ? Not the same thing...

r21-r22 branches are not evolutions of r13-r17 branches.

JP.

EDIT: OK, r22 seems to have been merged in in the meantime.
[Android Builders Collective] ezio84:
Merged r22, e.g: https://github.com/PureNexusProject...mmit/91e0d078e0d5936d5c0708a399b9e41f67196827
[Android Builders Collective] NeBouse:
Ok guys, let's say i'd like to "try" to build YAOSP or PNmod for my particular device, what should i do ^^

I have a 250Go HDD with Ubuntu installed on (juste have to swap my windows one in my laptop).

I have a LG G4 (the international version H815, with bootloader unlocked).

I'm actually running Resurrection Remix on it, but i'm not satisfied with it and I'd really like to get back to some stable rom !!

To summarize, my bootloader is unlocked, TWRP is installed, AOSP and CM roms already exist for my devices (might be easier to find some blobs or vendor tree I suppose), and I have a fresh Ubuntu install ready to go.

I'm not new to android (my first one was a HTC Hero, back in 2009), I've flashed a LOT of roms and i'm used to it, BUT I'm totally noob regarding compiling a rom.

I also know how to use a terminal, and i'm used to compile things (not roms, but programs, since i'm actually in a fast track year at university to learn informatics, yes I am an old 40 years old fart going back to school to change his life lol).

So, after this story of my life, can anyone point me in the right direction on how to do this ?

I don't have a powerful computer, so it may take forever for the rom to compile but I don't care lol, as long as I can try and maybe succeed !!

That would be a good experience.

Thanks.
[Android Builders Collective] Garrykd:
This was my problem:

Ah hah! That's the number i need. Figures, cm, the one place i didn't look :rolleyes:

Thanks E :highfive:

Of course, now its fixed and i don't need to do anything :cowboy:

New build compiling.

Edit

: after the longest upload ever (thanks to a joint effort of my isp and basketbuild) the new, fixed build is up

https://s.basketbuild.com/devs/garrykd/Builds/
[Android Builders Collective] Yank555:
Well, given both ROMs you've mentioned are AOSP based, and you don't have a Nexus, it might be a challenging project, but one you'll certain learn a lot from, so if learning is the ultimate goal, it should be an excellent project ;)

You van sync the ROMs using their manifests, I give the necessary command / links to info in my manifest repo readme, and I think Nate does the same on PN.

Then you'd need to get the corresponding device/kernel/vendor repos from a fellow AOSP ROM available for your device.

After which you should be able to build. At this point you might need help from someone who built AOSP for your device for the last details on how to get going.

But that's theory on my end, have never tried to build AOSP on non Nexus devices.

JP.

Sent from my Nexus 6P running Yank555.lu YAOSP-M 6.0.1_r22 v1.00

PS: You're in good company here, turning 45 in a few months :D

And also, don't hesitate to ask here if you get stuck, all helping fellows here ;)
[Android Builders Collective] NeBouse:
Thx.

There is an AOSP rom available for my device, CandySix, so i'll try to get in touch with the dev.

I'm gonna have a look at your repo to see how to sync and download the source code.

EDIT: you can be sure I'll ask if needed, I know people are helping here ;) I'm not a huge poster, but I'm an enormous lurker lol, I follow this thread since its creation. And I've owned 2 Nexii before moving to G4, a N4 and a N5, both were sporting Slim of course !!
[Android Builders Collective] Yank555:
Have a look here : https://github.com/YAOSP/manifest#getting-started

Read the linked page, it should help.

JP.

Sent from my Nexus 6P running Yank555.lu YAOSP-M 6.0.1_r22 v1.00
[Android Builders Collective] ezio84:
:D

Welcome back dude :D

There are also nice step by step howto here on xda:

http://xdaforums.com/showthread.php?t=2455005

http://xdaforums.com/showthread.php?t=1798056

First build for a supported device (any rom you want), to check if the building environment is well set. Then, try with custom stuff or devices and enjoy the errors rivers :D :D
[Android Builders Collective] NeBouse:
Okay I have set up everything (or at least I believe lol), and I also did the repo init thing ;)

I'll do the repo sync tonight, IIRC there is something like 30 or 35Go to download, and i have a crappy connection (7Mb/s...) so it will download during the night, and i must get back to Win7 so my wife can use the computer lol

I think I'll try first to build for a supported device (angler for example) as suggested by Ezio, to see if everything is set up correctly.

Thx again.
[Android Builders Collective] efan3719:
[MENTION=4741244]coolek33[/MENTION] i done goofed! i built a -user not a -userdebug. so like abd wouldn't work. i learned the error of my ways and am uploading now to AFH. i'll post the link as soon as it is done. sorry about that.

and here is the updated link - https://www.androidfilehost.com/?fid=24457741883932712
[Android Builders Collective] amphi66:
Thanks for the response, unfortunately HTML Viewer didn't do tbe trick. Since you ask I actually don't recall where it came from. It was restored from a TBu. I've used it for a long tkme tho, believe it came from SlimLP and then then ran it on Chroma until this update. I had tried some "clean" versions of Pure Nexus and don't recall an issues there. As do so many others, I appreciate your work and in keeping the N5 alive. After dropping in a new (los cost) battery I haven't seen any need to drop big $$ for a new model (of anything out there) that really isn't any better!
[Android Builders Collective] Yank555:
Fllowup on this ... oddly ... angler and shamu behave as expexted, but hammerhead indeed seems to royally ignore and turn to fast charge color, for a reason I have yet to understand ;)

I've added the mA/h info on lockscreen, will be in next build.

JP.
[Android Builders Collective] coolek33:
Hehe. No worries. I'm not using it very often but I think it's working. I'm not 100% sure but I've connected it to pc in the morning (for other reason) and debugging notification was on. Don't know if adb would work though. Thanks for heads up and keep up the great work.

SBC RULES :P
[Android Builders Collective] ezio84:
Upload the apk or take a logcat ;)
[Android Builders Collective] adm1jtg:
Well I have a pile of cables to test but so far on my shamu they all show blue... Aka always fast charge. Will let you know results after testing more cables.
[Android Builders Collective] Yank555:
I can upload a build for you with mA/h indication, that does help find the issue.

My car charge on stock angler cable shows 1500mA/h, whereas as you can see I get 1800mA/h on stock charger.

JP.
[Android Builders Collective] ezio84:
This is a nice but also useful feature, great idea (again) ;)
[Android Builders Collective] Yank555:
Here's one example, connected to a computer.

JP.

PS: You can grad the testbuild with mA/h info on lockscreen for shamu here : https://www.androidfilehost.com/?fid=24457741883932796
[Android Builders Collective] teemo:
I borrowed your code for my local aicp build. Where does it get the numbers from?

Mine show 2000 or 5000 mA/h - I was hoping that it would show the actual current flow (mA). Would that be possible ?

Edit: Should mention that I'm not on any Nexus device. Oppo r7+
[Android Builders Collective] Yank555:
Non Nexus shouldn't make any difference here.

The value is broadcast from BatteryStatus, value comes from kernel and indicates the max. current the device is allowed to draw from whatever it is connected to. Actual draw at a given moment is not possible, due to hardware limitation, it could only be 'guessed' given how long it takes to add 1% to the battery knowing the full capacity of the battery.

So the value shown should be the max. allowed current on the given source (as negociated with the current provider, like USB port based on it's type). With the correct cable I got correct readings on my angler (500mA/h on standard USB data port, 1500mA/h on my car charger which corresponds to its specs or 1800mA/h on the stock charger).

To be more precise, the info is broadcast from here :

https://github.com/YAOSP/frameworks...a/com/android/server/BatteryService.java#L512

And received here :

https://github.com/YAOSP/frameworks...roid/keyguard/KeyguardUpdateMonitor.java#L604

You'de need to check the former to see where it is getting the info from, but ultimately it's coming from the kernel.

I played with my kernel fastcharge implementation on HH where you can set mA/h as you want for 'usb' and 'AC' individually, and that is correctly reported to the ROM.

JP.

Sent from my Nexus 6P running Yank555.lu YAOSP-M 6.0.1_r22 v1.00

---------- Post added at 23:48 ---------- Previous post was at 23:24 ----------

About "bad" cables (USB-C are champs in that division), just look at this G+ : https://plus.google.com/collection/s0Inv

JP.
[Android Builders Collective] teemo:
Okay thanks. So it's working as intended, good to know. The 5A and 2A I see might be correct. I know the Max is between 4 and 5 amps and it makes sense to throttle down to Max 2 amps somewhere around 90%.
[Android Builders Collective] adm1jtg:
[MENTION=2033478]Yank555[/MENTION] tested a known good cable hooked into my usb on laptop using your new build. Led is blue and lockscreen says 500ma and charging slowly. Colors are set to red for low green for slow charge blue for fast charge and black or off for completed charge

So in this test as in my few previous tests charging always shows as blue.
[Android Builders Collective] Yank555:
That's odd ... you've seen my shamu !? Damn confusing lol

On the other hand, your finding is exactly the same as on my hammerhead, shows slow and is blue nonetheless...

Dunno what's wrong on these when the same code is working absolutely fine on angler.

Gonna add some debugging log code and work through it on my HH since I can reproduce this on it.

Hopefully I can find a reasonable explanation and more importantly a fix ;)

More in the next episode I guess :D

JP.

Sent from my Nexus 6P running Yank555.lu YAOSP-M 6.0.1_r22 v1.00
[Android Builders Collective] Yank555:
So I fixed the battery LED stuff with my plan B... I wanted to grad the fast threshold from Keyguard ressources, but this proved unreliable, while working on angler, it didn't on hh and shamu was incomsistent. So I use a separate threshold value in core/res/res afterall, and all us good.

Sources are up, v1.01 builds are coming over the day.

JP.

Sent from my Nexus 6P running Yank555.lu YAOSP-M 6.0.1_r22 v1.00
[Android Builders Collective] Fastrite:
Thanks for the builds :) Its really nice to be able to use some of the slim stuff, nav bar, recents etc.

I can confirm that the vendor warning has gone now.

I have an issue in that I can't seem to get the dpi to change...

I've edited the build prop 3 different ways (via PN build prop tool, manually editing build prop with text editor & with [MENTION=2095315]ezio84[/MENTION] 's flashable zips) and although build prop is successfully changed the DPI does not change on reboot... However the nav bar icons do go crazy (quadruple in size!).

Amy ideas what I can do to sort this and change DPI on angler.

PS all works fine on HH with build prop edits for DPI...

#whiteuimustdie
[Android Builders Collective] kantjer:
Just did a clean install (on Angler) of my first PN build with [MENTION=2095315]ezio84[/MENTION] commits.

I have set dpi to 500 using the build in build.prop editor, worked fine.

Also no issues with nav bar icons (only in settings one or two look huge)
[Android Builders Collective] Fastrite:
Mmmm. Thanks for the feedback.

The first time I tried to change the DPI on I tried the adb cmd "adb shell wm density xxx DPI"

Could that have messed with something?

#whiteuimustdie
[Android Builders Collective] kantjer:
Check your build.prop, that should be set to the desired value.
[Android Builders Collective] VictorLapin:
YAOSP-MM v1.01 for hammerhead: https://www.androidfilehost.com/?fid=24457741883933576
[Android Builders Collective] ezio84:
Found a solution about the slow pulldown animation when opening the notification/QS panel from a launcher like Nova (without root) or Slim Actions :D

- add this fix to make the animation faster:

https://code.google.com/p/android/issues/detail?id=189826#c4

(i'd set it to 400, 350 is too fast)

- pick this CM commit to let the animation work on all notifications in the panel: http://review.cyanogenmod.org/#/c/129433/

[MENTION=2064327]Fastrite[/MENTION] : considering [MENTION=3306843]kantjer[/MENTION] 's test with a clean flash, try to wipe system and flash the rom again, maybe it does fix the issue on your side too :good: