[Samsung Galaxy S Relay 4G] phred14:
OK, I'm now responding to both scotte9999 and magamo, so I guess quote time is over.

First, I've been delaying this trying to get further on a specific train of thought. But here it is Sunday night and I haven't been able to yet, so I'm just going to keep in touch and ask more newbie questions. I guess I'll say first that right now I'm backing up android/system/vendor/samsung, and in a moment I'm going to try to revert those two commits. Now that I think of it, I'm going to back up that rom image I built earlier. I am intentionally not re-syncing, so that I'll have two copies of 20130904, one stock and one with the commits reverted. From there I can compare. I was hoping to get more of this done before tonight, but no time. Yesterday we had an "emergency pool closing". The 13 yo pump died, and rather than try to fix then close, we just closed. I'm distributing the chemicals with a utility pump and hose for a few days. I think I can rebuild the pump over the winter, but didn't want it in series with pool closing. We're a week late, as is. Pools close early in Vermont.

Second, I'm just a tad worried that at some point the codebase will be cleaned / rebased / whatever, and the content I'm attempting to revert to will be just plain gone. No doubt a git-master could get it back, but not me. That's also why I'm not doing another repo sync.

So much for that attempt:

~/android/system $ git revert -m 1 187689ea76effd42b680a147d080512ac62a0fed

fatal: Not a git repository (or any parent up to mount point /local)

Stopping at filesystem boundary (GIT_DISCOVERY_ACROSS_FILESYSTEM not set).

I'm sure it's something so basic it wasn't covered in the document scotte9999 pointed me to. I'd already done everything to get my environment ready - my own exec to get started and "source build/envsetup.sh", so I presume everything would have been in place to run the revert.

As for the revert itself, I found the 2 commits on github and have looked at them. It appears that someone was trying to move a bunch of common code together under msm8960-common, generally a good idea, except when it doesn't work. I presume had one of the old Team apexqtmo developers still been around the current situation would have been corrected, presumable in a minimal fashion rather than reverting the whole commits.

Looking at the commits...

Minor oddity with the "aec" commit - libinvensense_hal.so disappeared from the "after", but when I look in the phone build I'd just done, it was still there. Maybe it was a duplicate? A little more looking, and this appears to control the sensor to get the "position" of the phone, which I'd hope wouldn't keep it from booting, just from making things upright when you rotate 90.

Even though it isn't listed in the "after" side of that commit, I find that lib in the relevant msm8960-common directory, and when I diff it against the one in the apexqtmo directory they don't match. (specifically, diff apexqtmo/proprietary/lib/libinvensense_hal.so msm8960-common/proprietary/lib/libinvensense_hal.so) Maybe there's a build date buried in the lib, so that they will never match, but I would have hoped that if it was a simple move, code unchanged, they would have.

Most important question - what's the correct syntax for the git revert? Obviously my attempt to RTFWP didn't work.

Second question - M10 is coming up next week, and if I can get the revert done, I'd really like to build this and make it work, if only to get the camera video, which is known-broken in M8, working on my wife's phone. Reading build/envseup.sh I get the impression that the magic invocation will be "breakfast apexqtmo-M10" and "brunch apexqtmo-M10", and someone must have been really hungry the morning he wrote this code. Is that presumption correct?

Thanks...