yashsingh1/xdaforums huggingface dataset:
[Android Apps and Games] NisseDILLIGAF:
Yes, now I can save the file... :) thanx!

it asks for superuser when i open the file.. shouldn't it wait to ask for it until i save the file?

and when I'm in ES file explorer and select to open with Turbo editor it doesn't show the file... I have to select the file from the swipe panel in Turbo Editor...

on previous version it showed the file...
[Android Apps and Games] Vlad Mihalachi:
Try this new one
[Android Apps and Games] NisseDILLIGAF:
Thanx!

Now its working... :)
[Android Apps and Games] Vlad Mihalachi:
Nice :)
[Android Apps and Games] Vlad Mihalachi:
A new update is available on the Play Store and on the download section of this thread.

Changelog 22 Aug 2014

∙ New Floating action button in the "Open a file" screen

∙ New set as working folder action in the "Open a file" screen

∙ In the info/about screen added a link to the XDA thread

∙ New menu icon for overflow

∙ Updated the translations

∙ Other enchantments

If you have some questions let me know! :o
[Android Apps and Games] edamigo:
Root feature is extremely convenient.

Improvements in syntax highlight would be welcomed. I suspect some kind of plugin framework would help.

Thank you for your efforts. I really appreciate your editor. Especially after root support.
[Android Apps and Games] funCrash93:
any chance of getting JSONs properly readable? :)

a json object (json string to be able to refactor it properly with correct indentation?)

Thank you.

Sent from my bacon.
[Android Apps and Games] Vlad Mihalachi:
Can you describe it more? How it should work?
[Android Apps and Games] u1988:
Thank you!

Can you add backup option like for file build.prop etc...

Like in 920 editor text
[Android Apps and Games] Vlad Mihalachi:
I think this is out of the scope of the app, you can do this easily with a file manager :)
[Android Apps and Games] funCrash93:
you know like in programming languages you have indentation for better readability, so could you add something like automatic indentation correction (like eclipse has :

public void example (JSONObject *jsn)
{
if (jsn != null)
{
fixIntent(jsn);
}
else
{
Log.e("JSON : ", "NULL");
}
}

so to get from {"mykey":"value4key","anotherKey":{"key":"val","2key":"2val"}}

to

{
"mykey":"value4key",
"anotherKey":
{
"key":"val",
"2key":"2val"
}
}

(and this indentation feature you could add for all supported languages, and just add *.json as supported "language")

hope I got myself clearer as English is not my native one ;)

Thanks
[Android Apps and Games] ykkfive:
a good editor

any chance to have regular expressions search?
[Android Apps and Games] u1988:
It can be a litile Suggestion for improvement ,bacuase many of the files you editing need backup before changing settings.

Anyway thank you!
[Android Apps and Games] Vlad Mihalachi:
I will do my best to support regular expression search
[Android Apps and Games] Vlad Mihalachi:
Thank you for the suggestion but I do not know if I will add that feature :)
[Android Apps and Games] funCrash93:
[MENTION=4692685]Vlad Mihalachi[/MENTION] so what about formating code ability and json files/"language".? :angel: :fingers-crossed:
[Android Apps and Games] ykkfive:
thank you, it's a must have feature

btw, u know why I chose your turbo editor over others since I started to use it today? coz yours is the only one I found that keeps the permissions after saving the file! a super one for editing system files or otherwise have to set it again!

although it's still lacking of some features, I still enjoy using turbo editor

oh btw, undo sometimes not working?

thanks :laugh:
[Android Apps and Games] Vlad Mihalachi:
It's not easy to format code ... I don't know if I can do that :) for json I can give a try but I can't promise anything
[Android Apps and Games] Vlad Mihalachi:
Thank you! :) when does undo not work?
[Android Apps and Games] funCrash93:
Thanks just for trying :)

I thought that the feature of formatting the code (correcting indentation) will be need, and with time if you'll add languages you'll just update this feature according to the language ;)

still will be using your app Thank you :)

Sent from my bacon.
[Android Apps and Games] ykkfive:
seems not working at all :rolleyes:

one more suggestion, ask before closing file or quit after changes made, this should be relatively straight forward, I think

anyway, take your time :p
[Android Apps and Games] Vlad Mihalachi:
took ahahahha :D

Try this new version, it shoud have the fix to the undo/redo function, search with regular expression and now the app should ask to save the file if changes was made. :)
[Android Apps and Games] ykkfive:
great. will try it and report back. thanks

edit where's the search button now? the only search btn i can see is in the open file menu
[Android Apps and Games] JerryGNYC:
I believe the word we want here is "indentation". :good:

And many text editors make an automatic backup of the original file.
[Android Apps and Games] funCrash93:
uuups :D

thank you sir :angel:

sorry, english is not my native language :p
[Android Apps and Games] Vlad Mihalachi:
The search button hasn't been moved. It s in the menu as before
[Android Apps and Games] Vlad Mihalachi:
Ok, so the app should create a folder called lets say "turbo editor" and there save a copy of all the system files it tries to edit?
[Android Apps and Games] ykkfive:
cant find the search button

btw, a minor bug, both sliding menus can be opened but overlapping each other when in

port mode as shown in the attachment
[Android Apps and Games] Vlad Mihalachi:
thanks for the bug report. For the search button open a file and then click the menu :)
[Android Apps and Games] ykkfive:
not found
[Android Apps and Games] Vlad Mihalachi:
What device do you have? Does it have a menu button?
[Android Apps and Games] ykkfive:
yes, when i press the menu button on my note2, the slide menu on the left will appear as in the screenshot, same as tapping the menu key on top left
[Android Apps and Games] Vlad Mihalachi:
Ok, try this new one
[Android Apps and Games] ykkfive:
ok

btw, just found that there is a menu button (a real menu button) on top right in the old version on my tablet but not on the last one I installed.

will try this one now
[Android Apps and Games] ykkfive:
the latest one shows the menu button correctly, thanks

and I have some feedbacks and suggestions after testing for a few mins, not being demanding but just act as a general user, as well as a novice programmer

do u want me to go into details now?
[Android Apps and Games] JerryGNYC:
Well, that's a good choice to let the user make. I say this because if you store a copy of the original file in its original location, you don't have to worry about preserving the full path information, which can get to be a handfull, especially on a rooted device where the user may be peeking into all sorts of deep cracks and crevices... :eek: :silly:

If you store in a special location and DON'T store the path information, you run the risk of a file with the same name overwriting a totally different file with that name... :(

And I wouldn't bother to make the backup until the file is about to be saved (and has also been modified). And making the backup could be done with a simple shell command. Here's some pseudo-code for what I'm saying -

if [ $FILE_NAME_FLAG -eq modified ] AND [ $FILE_SAVED -eq false ]
then
cp -u $FILE_NAME ./FILE_NAME.bak
if [ $? -eq 0 ]
then
save $FILE_NAME
$FILE_NAME_FLAG = unmodified AND $FILE_SAVED = true
fi
fi

If I was (really) doing this I'd check for success of the save operation before toggling the flags... :D

HTH,

-Jerry
[Android Apps and Games] Vlad Mihalachi:
Sure :)
[Android Apps and Games] Vlad Mihalachi:
What if when a user edits the build.prop that is located in the "/system" folder the app saves the backup file in "/turbo-editor/system" so this way the path information is preserved?
[Android Apps and Games] JerryGNYC:
I don't see any problem with that. Just make sure that you're able to properly handle the length of the text string - full-path+filename you get, and are able to recreate that in the backup folder. I haven't programmed on Android and don't know what the limits are.
[Android Apps and Games] ykkfive:
sorry, i have not read all posts yet so may be i am not talking about what have been discussed actually

just wondering why bother to the original file location? once the user opens a file, u can get the file path already. so why to make a backup? (i think >50% i am OT, sorry)
[Android Apps and Games] JerryGNYC:
A user requested automatic backup. :) Discussing methodology. :cool:
[Android Apps and Games] ykkfive:
ok. but before that, i wanna ask you a question that i forgot to ask yesterday. is it by design turbo editor is a single file editor? i have this qustion because when i looked at the file history list on the left hand side, which i thought they were file tabs that allow me to switch between files and edit multiple files simultaenously. i am not criticizing the design, only due to my incorrect perception

anyway, after trying the lastest version, i have the following comments/suggestions

- looks like a bit slow to open a file. i picked a 2xx kb file to edit at first (by accident) and later i found it took 7 seconds to show the contents. if i remember correctly, one of the slowest editor took about 1x-2x seconds to open a 1MB file. pls correct me if i am wrong

- about the regular expression search. when i opened that 2xx kb file i tried the seach immediately but i think its not handled properly. everything i typed was treated as reg search and thus the app freezed very often due to the file size and multiple reg searches were executed for every letter i typed. so, u know what will happen. it seems that the delay is too short before the search actually starts, and this is even worse when regex is enabled. more, i suggest it is better to have a check box to indicate the user is going to perform a regex search or not, or simply by treating it as regex if the query starts and end with a / (slash), with i (ignore case) support to further reduce the time for seaching. of coz a 'do search now' button helps too

- would be better to highlight the results (i didnt notice it scrolled to the line containing the result at first since that was a log file with similar contents on each line)

- when i wanted to change "tje" to "the", for instance, by moving the cursor and hitted the back key and h key attempting to remove the letter j and replaced it with h, the search was cancelled immediately (called by the back button), and the letter h i typed was inserted somewhere in the file

- perhaps 'cancel', 'save', and 'discard' are needed instead of 'cancel' and 'save' when it is about the close the current file, since if i pressed the back key or tapped another file in the history list accidently during editing a file, a 'cancel' will discard all changes made and the file will be closed, therefore no way to cancel the 'back' and go back and continue to edit the file

sorry for a bit long and poor english

and the suggestions above are my 2 cents only
[Android Apps and Games] ykkfive:
i see.....

may be just save a copy to the data folder will do since the original file location is known already (in case of temporary backups)
[Android Apps and Games] JerryGNYC:
Yes, temporary backups like that are also a good option! :good:
[Android Apps and Games] ykkfive:
so the problem solved? or only a part of what have been discussing?
[Android Apps and Games] JerryGNYC:
Can't tell you... Going to have to wait for the OP to decide! :D
[Android Apps and Games] ykkfive:
ok, just want to make sure i m not OT
[Android Apps and Games] JerryGNYC:
NP, and I don't see how discussing app design is OT on a dev site. :cool:

Even if it is for a user requested feature... :silly:

---------- Post added at 12:00 PM ---------- Previous post was at 11:56 AM ----------

And FWIW, what I think most (if not all) modern operating systems are missing is a versioning file system. I work with OpenVMS and love the ability to store up to 32K versions of a file (though we usually don't go past 8).
[Android Apps and Games] Vlad Mihalachi:
Hello folks, I will be offline for an entire week because I will be abroad.

Feel free to download the Play Store version if the one uploaded on the thread has bugs.

In the meantime I will think about a new way to search (highlighted results, Regex, find and replace etc) and about the backup feature.

Bye! :)
[Android Apps and Games] bombadier:
Enjoy your break

Tapatyping from my Nexus 4
[Android Apps and Games] JerryGNYC:
Have a good trip!
[Android Apps and Games] tschmid:
Enjoy

Gesendet von meinem LG-D855 mit Tapatalk
[Android Apps and Games] Vlad Mihalachi:
thank you all!! eheeh :laugh:

A new beta version is available, the main new feature is the search functionality which was enhanced with the regex and the replace function support. Now the app also support Right to Left languages.

Let me know if it works correctly, thanks!!

P.S.

No backup function for now, sorry :)
[Android Apps and Games] DF1E:
Hi, I just tested your new version and most things are looking fine. But Syntax Highlights isnt working correctly on larger files.
[Android Apps and Games] Vlad Mihalachi:
Hi, I'm working hard on a new version that will better support larger files. In the meantime can you give me more details?
[Android Apps and Games] ykkfive:
hi

glad to see there are many enhancements in the recent version, especially the speed and great job for the extra dialog for regex activation as suggested.

will be happy to see highlighted search results in later version since I have to manually look for the matching words after search

thanks
[Android Apps and Games] Vlad Mihalachi:
Hi, the app highlights the words but only one at time, doesn't it? :)
[Android Apps and Games] ykkfive:
not for me, perhaps due to dark theme ?

edit: strange.... the highlights is working now...

edit 2: ok, i see what;s wrong. just a sec

try this:

- open a file and dont tap on anywhere

- choose search from the menu

- type something and start search

- nothing hightligted

conclusion: if the file contents is not focused/tapped yet, no highlights

edit 3:

sometimes i got these errors and the app fc

09-04 00:15:06.538: E/AndroidRuntime(3828): Process: com.maskyn.fileeditor, PID: 3828

09-04 00:15:06.538: E/AndroidRuntime(3828): java.lang.IllegalStateException: Fragment FindTextDialogFragment{426533c8} not attached to Activity

09-04 00:15:06.538: E/AndroidRuntime(3828):	at android.app.Fragment.getResources(Fragment.java:767)

09-04 00:15:06.538: E/AndroidRuntime(3828):	at android.app.Fragment.getString(Fragment.java:789)

09-04 00:15:06.538: E/AndroidRuntime(3828):	at com.maskyn.fileeditor.fragment.FindTextDialogFragment$SearchTask.onPostExecute(FindTextDialogFragment.java:219)

09-04 00:15:06.538: E/AndroidRuntime(3828):	at com.maskyn.fileeditor.fragment.FindTextDialogFragment$SearchTask.onPostExecute(FindTextDialogFragment.java:156)
[Android Apps and Games] Vlad Mihalachi:
Strange because for me it works even if I don't tap the text before....

I'll try to fix the issue that comes with the dialog, does it happen at random or there is a specific sequence?
[Android Apps and Games] ykkfive:
as follow the steps I mentioned

sorry for making u busy every time :p
[Android Apps and Games] Penacal:
I can't use the app for editing, because my keyboard(SwiftKey), isn't call by the app, it does appear when I tap on find, but not on the text file.

Nexus 4, SlimKat ROM.
[Android Apps and Games] Vlad Mihalachi:
What version of the app do you have?
[Android Apps and Games] Penacal:
The version was 1.7,after your post I remove that version and installed the latest from xda(appear as 1.6),and it's working. The playstore is the 1.7.1 and is working too. Bit strange, but it's working now. Thanks
[Android Apps and Games] Vlad Mihalachi:
Great! :)
[Android Apps and Games] Vlad Mihalachi:
Hello there, a new version is ready. It has a new great feature.... The support of Very Big Files!! :D:D Big files are now treated as a list of pages, a sort of book.

When you open a small file you shouldn't notice any difference but when you open a big file two buttons will appear at the bottom of the screen.

One is used to navigate to the previous page, one to navigate to the next one. If you long click one of those a popup will appear asking you what page you want to view.

IT'S STILL VERY EXPERIMENTAL, but I hope to publish this version relatively soon. Please test it and let me know if it works good :)

[MENTION=720170]bombardier[/MENTION] [MENTION=4004386]Ultramanoid[/MENTION] [MENTION=2038193]dron39[/MENTION]
[Android Apps and Games] Ultramanoid:
Thank you for this version.

It opens the big files I've thrown at it fine, and the paging works well, pretty fast.

What I've noticed is that finding text or code only works for the page you're in. For example, if I'm searching for something that is in page 11, but I am displaying page 4, it won't find it.
[Android Apps and Games] m0d:
Why in this version permission for full device features including SU is needed?
[Android Apps and Games] Vlad Mihalachi:
what do you mean by "full device features"?

SU is needed for the Root features :)
[Android Apps and Games] Vlad Mihalachi:
Thanks!! I'll look into it :)
[Android Apps and Games] m0d:
I see.

Root just applies to viewing and editing hidden/system files?
[Android Apps and Games] PunchUp:
That is what SU means
[Android Apps and Games] Vlad Mihalachi:
yes, It's needed for viewing and editing system files. :)
[Android Apps and Games] elban:
Why not open a beta channel on play store?
[Android Apps and Games] m0d:
Is it possible to have one version without root features?

As most Roms have settings where you can edit system files like build.prop, hosts, etc.

Personally, I do not see why a text editor should have access to root

Thank you for your quick responses
[Android Apps and Games] PunchUp:
Just deny SU permanently
[Android Apps and Games] 1tek:
Thanks for share!

Thanks for share!
[Android Apps and Games] Vlad Mihalachi:
Hi, if you don't allow the app to use the root features you shouldn't notice any difference. Writing that my app needs Su permission doesn't automatically grant this permission. :)
[Android Apps and Games] Vlad Mihalachi:
There is already a Google plus community for beta tester but it's not active as this thread on xda :D

Anyway that's the link http://j.mp/TurboEditorCommunity
[Android Apps and Games] elban:
I was thinking about beta apk releases: better on play store than forum attached files, IMHO ;)
[Android Apps and Games] heather1209:
I love this editor! I thought I loved DroidEdit, but this one is awesome with big files. I have 2 requests though.

First, I was wondering why changing the side panels with the theme isn't a good idea?

I always have dark themes because I use my phone a lot at night in a dark bedroom so those bright side panels are blinding, even at my lowest brightness! Is it possible to revisit this?

Second, can you add a read only option so the keyboard can be disabled temporarily? Sometimes when I'm reading through long text files, I don't need my keyboard and so I don't want it popping up every time I happen to tap the document.

Thank you for your hard work on such a great app!
[Android Apps and Games] Ultramanoid:
There are people who don't / can't use the Play Store.
[Android Apps and Games] elban:
I know. In fact most developers link the apk in the thread and keep a beta channel on play store so people with market get automatic updates. Was just for convenience and it doesn't take a lot of time, but it's up to the developer to decide ;)
[Android Apps and Games] JerryGNYC:
+1 to both requests!
[Android Apps and Games] Vlad Mihalachi:
New Update

Hello there, there is a new udpate available on the Play Store and here in the download section. :victory:

Here is the changelog:

∙ New: Create empty files with just one click

∙ New: Read only mode

∙ New: Autosave function, to save files when the app loses focus

∙ New: Share the text from other apps to Turbo Editor

∙ New: Style changes

∙ Other enchantments and fixs
[Android Apps and Games] JerryGNYC:
I like the update very much! And I always said there's magic in good development! :D

Question - in one text file (about 190+ lines), I get a jump to top/bottom floating button (never saw this before). In another text file (about 160 lines), I don't. Is there a size threshold for this?

TIA,

-Jerry
[Android Apps and Games] Vlad Mihalachi:
thanks! :) each page can contain approximately 12.5kb of text. do you think I should increase the text that each page can contain?
[Android Apps and Games] JerryGNYC:
You're welcome. Oh - I wasn't think you should change anything, just didn't know it had to do with the file being over a certain size, and I wanted to know.. Thanks.
[Android Apps and Games] Ruku1994:
I started using your app last week and so far it looks good except one thing. When I open files with syntax highlight only about 112 lines are highlighted. The rest remains white until I tap on the text. It gets troublesome if I want to read code because I have to tap on it whenever syntax highlight ends. Also at places without highlighting there seems to be no lines numbers. Hope you can fix that. Thank you for this I really like the app.
[Android Apps and Games] Vlad Mihalachi:
Hi! That's how it works for now. In the next version I will try to fix that. Thanks! :laugh:
[Android Apps and Games] luqman98:
Bug.....

Sent from my Xperia E1 dual

1. Love doesn't need any reason.

2. Wanna speed up 3G (not 4G LTE)?

Here it is:

http://xdaforums.com/showthread.php?t=2586876

3. Press the thanks button if I really helped/assisted you.
[Android Apps and Games] Vlad Mihalachi:
Strange... Is it the first time you use the app?
[Android Apps and Games] luqman98:
Nope..... and the screenshot isn't from my phone btw. Mine (below) just fine.

Sent from my Xperia E1 dual

1. Love doesn't need any reason.

2. Wanna speed up 3G (not 4G LTE)?

Here it is:

http://xdaforums.com/showthread.php?t=2586876

3. Press the thanks button if I really helped/assisted you.
[Android Apps and Games] Vlad Mihalachi:
what Android version does it have?
[Android Apps and Games] luqman98:
Xperia J 4.1.2 Jelly Bean (stock ROM).

Sent from my Xperia E1 dual

1. Love doesn't need any reason.

2. Wanna speed up 3G (not 4G LTE)?

Here it is:

http://xdaforums.com/showthread.php?t=2586876

3. Press the thanks button if I really helped/assisted you.
[Android Apps and Games] Vlad Mihalachi:
fixed this issue. thanks!!
[Android Apps and Games] ykkfive:
hi

unable to show the whole file (265kb)
[Android Apps and Games] heather1209:
Any update on this? It's doing the same thing on my device. The search only searches the active page instead of the entire document, which makes the search feature very ineffective.
[Android Apps and Games] Vlad Mihalachi:
please explain it more
[Android Apps and Games] Vlad Mihalachi:
in the next update I think there will be this feature :)
[Android Apps and Games] ykkfive:
sorry, I didnt notice the navigation button until now

:D
[Android Apps and Games] Vlad Mihalachi:
I hope it's not a common problem their visibility :)
[Android Apps and Games] KnifeFed:
What's the difference between the free version and the pro version? There's no indication in the description in the Play Store.
[Android Apps and Games] PunchUp:
I guess this hasn't been reported by anyone but the keyboard doesn't show up on my device :confused:

I haven't enabled read only mode
[Android Apps and Games] Vlad Mihalachi:
Hi, I will add it later. the only difference is that the pro version doesn't show an interstitial banner. :)
[Samsung Galaxy Mini] Djuka445:
Hello guys i have this pixel problem please help me if u can

This is my 1st thread pic at attach

So i bought this phone sg mini 2 and i droped it

I hope someone can help me

Thanks!
[Android Q&A, Help & Troubleshooting] I98:
Hello I was wondering whether there is a ported gingerbred dialer, if yes can you please provide the link to download.If there isn't can you please give me a method to port the dialer as I tried pulling the apk from the cm7 rom and tried it on a cm11 rom but got i think unfortunately android.process.acore has stopped.

thank you