yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] Thomas_BA:
I am using AlarmDroid.

Systemui crashes with this module when activating an alarm..
[Xposed Framework Modules] GermainZ:
How is it not working? What clock app are you using? Did you check the Xposed log?

Sorry, I don't understand what your problem is.

Thanks, will be fixed.
[Xposed Framework Modules] chrisch91:
I'm usimg stock app. After restart it works for about a few minutes and then it is stock (shows 8:00).
[Xposed Framework Modules] GermainZ:
[MENTION=3604086]chrisch1974[/MENTION] Any chance you could paste HtcPhoneStatusBarPolicy, please?

Anything in the Xposed log?
[Xposed Framework Modules] chw9999:
Hi, got a log entry which I believe belongs to you ;)

Looks like it's in the log after ever boot. Seems to work anyway, just with the the ICS sense glitch.

Thanks!
[Xposed Framework Modules] chrisch1974:
That's a link to the HtcPhoneStatusBarPolicy files. I hope those help you :)
[Xposed Framework Modules] GermainZ:
Thanks :) Could you please test if the latest commits work correctly on Sense?
[Xposed Framework Modules] miki.cis:
On Xperia SP (4.3 PureXSP) is not working. Makes the UI force close after setting alarm in third party app, when trying to launch stock clock app, the app gets FCd and can't be entered...
[Xposed Framework Modules] theknut:
Just want to confirm that the latest changes from Github fixed the DeskClock app "issues". It's now showing the correct time in the notifications. Thank you very much!
[Xposed Framework Modules] chrisch1974:
New version works flawlessly on Sense too. Great work and It should finally solve all those time updating issues :)
[Xposed Framework Modules] miki.cis:
I hope this is the one you need.
[Xposed Framework Modules] GermainZ:
I see no FCs in that log, please take one right after the FCs happen.
[Xposed Framework Modules] GermainZ:
1.3 out, changelog:

Better method to replace left side icons (for clock packages).

Added support for Google Clock and GentleAlarm (DynamicAlarmClock will also change their notification icons).

Compatibility fixes for Sense devices, by chrisch1974.

Better alarm change detection.

Added clock style preference: choose between the AOSP style and a TouchWiz-like style.

Added clock color preference.
[Xposed Framework Modules] Roudier:
Hi Germain,

Thanks so much for your work, especially regarding the TouchWiz-like icon : very few people requested it, but you added this awesome feature anyway. One thing though : compared to the stock TouchWiz icon, the one in your module is this time way too thick : the hands are not readable at all, on the contrary of the ones on the stock icon. I can post a screenshot if needed, or provide any Samsung file you may need (supposing that the TW alarm icon is not coded, of course).
[Xposed Framework Modules] GermainZ:
A screenshot of how DynamicAlarmIcon's TouchWiz clock looks on your device, as well as the stock TouchWiz drawable (res/drawable-xxhdpi/stat_sys_alarm.png in the SystemUI APK, usually in /system/priv-app/SystemUI.apk) would be of great help if you can provide those. Thanks. :)
[Xposed Framework Modules] Roudier:
Here you are (screenshot to be compared with the one in post #20). After a second reading, please replace "way too" in my previous post by "a bit too". ;)

PNG file of the TW alarm icon attached to this post (white on white obviously).
[Xposed Framework Modules] GermainZ:
The problem isn't with the app, it's with me assuming that method exists in 4.3. I'll update it as soon as I can.

(It should work just fine when the notification isn't expanded.)

Thanks! :laugh:
[Xposed Framework Modules] Skhulile:
V 1.3 Doesn't work well on Galaxy Note 10.1

Hello, for some reason this module does not work well anymore after the update. I can confirm it used to work perfectly. I attached a screen shot of my status bar, you can clearly see that it just shows an empty space
[Xposed Framework Modules] GermainZ:
ROM, Android version, clock app? Also, does your Xposed log show anything?
[Xposed Framework Modules] terrorist96:
Mine does the same thing if I reboot. To fix it, I have to go into the alarm app, turn off the alarm then turn it back on and the icon will show up again.
[Xposed Framework Modules] Skhulile:
Oh I'm using the Gnabo V5.5 Custom ROM, KITKAT 4.4.2, Default clock up (Touchwiz).

Here's my xposed Log but I see no error:

03 Aug 2014 10:22:48 PM UTC

Loading Xposed v54 (for Zygote)...

Running ROM 'Gnabo.Rom.v5.5' with fingerprint 'samsung/p4noterfxx/p4noterf:4.4.2/KOT49H/N8000XXUDNE4:user/release-keys'

Loading modules from /data/app/tw.fatminmin.xposed.minminguard-1.apk

Loading class tw.fatminmin.xposed.minminguard.Main

Loading modules from /data/app/com.ash.androidlnavigationbar-1.apk

Loading class com.ash.androidlnavigationbar.HookClass

Loading modules from /data/app/info.mzimmermann.xposed.cputempstatusbar-1.apk

Loading class info.mzimmermann.xposed.cputempstatusbar.XposedInit

Loading modules from /data/app/com.oasisfeng.greenify-2.apk

Loading class com.oasisfeng.greenify.pro.FrameworkPatch

Loading class com.oasisfeng.greenify.pro.SettingsPatch

Loading modules from /data/app/ma.wanam.youtubeadaway-1.apk

Loading class ma.wanam.youtubeadaway.Xposed

Loading modules from /data/app/com.mohammadag.disablelocationconsent-1.apk

Loading class com.mohammadag.disablelocationconsent.DisableLocationConsent

Loading modules from /data/app/com.germainz.dynamicalarmicon-3.apk

Loading class com.germainz.dynamicalarmicon.XposedMod

Loading modules from /data/app/ma.wanam.xposed-1.apk

Loading class ma.wanam.xposed.Xposed

Loading modules from /data/app/com.mohammadag.headsupenabler-1.apk

Loading class com.mohammadag.headsupenabler.XposedMod

Loading modules from /data/app/tw.fatminmin.xposed.networkspeedindicator-1.apk

Loading class tw.fatminmin.xposed.networkspeedindicator.Module

/sys/devices/platform/s5p-tmu/curr_temp

But it seems like to make it show I always have to go and turn off the alarm and then back on again.which I think is not convenient.
[Xposed Framework Modules] Lycidias:
The Icon disappeared with the newest update, only See an empty space in statusbar

LG G2 KK
[Xposed Framework Modules] sublimaze:
Working fine here. Reinstall the module & reboot(?)
[Xposed Framework Modules] GermainZ:
Alright, I can see the issue and it'll be fixed, obviously (already is locally, but can't upload it right now). Thanks everyone.
[Xposed Framework Modules] dctrbnsttr:
Lg g3... Two things: a reboot seems to be needed to change the icon's color..... And, the third slider on the color change screen (I assume it's the opacity slider) is not visible.... Hidden by the buttons
[Xposed Framework Modules] GermainZ:
That wasn't very important, so I didn't look into it. (It's the intended behavior, for now.)

I can make it scrollable. Can I see a screenshot, though?
[Xposed Framework Modules] dctrbnsttr:
Here's the screenshot
[Xposed Framework Modules] GermainZ:
1.3.1:

Fix missing icon on start up.

Compatibility fix for 4.0-4.3.

TouchWiz clock style improvements.
[Xposed Framework Modules] jairmoreno:
Hi men, your mod rocks!!!. Thank you very much, this kind of personalization makes me feel in love with android. I have one question, Is possible to mod the quicksettings icon as well?
[Xposed Framework Modules] matrixzone:
Working great on Samsung Galaxy S3
[Xposed Framework Modules] baaabovka:
GermainZ: Thank you. Now it's working well!
[Xposed Framework Modules] Chamelleon:
After last update it stopped working.

Stock 4.1.2 on Motorola XT890.

Wysłane z Motorola RAZR i
[Xposed Framework Modules] GermainZ:
Probably. :)

Which version are you using? How is it not working? Did you check the Xposed log?
[Xposed Framework Modules] Ja_som:
Hi [MENTION=4775688]GermainZ[/MENTION]

First I want to say thank you for this great module...

Most of time it works without problem...

But I have one issue. I use Tinted Status Bar, when all icons are white, then it is OK, but when icons change color to black, then stock alarm icon appears and remain until I turn off and again turn on the alarm.

No errors in log...

Can you do something with it, or I need to live with it :)

Thank you

(Moto G GPE Android 4.4.4)
[Xposed Framework Modules] GermainZ:
I use TSB and I can't reproduce this. Could you disable all modules except DynamicAlarmClock and TSB, in order to make sure it's not another module that's conflicting? Thanks.
[Xposed Framework Modules] Ja_som:
You're right...

Only TSB with DAC works great, but after I enabled GravityBox this issue appears :(
[Xposed Framework Modules] GermainZ:
Alright, I took a quick look at GravityBox's code. Its status bar icon manager is basically replacing the alarm clock with the stock alarm clock (meaning you wouldn't normally see a change). (This is to ensure you have live updates when switching between styles, FYI.)

It needs to have a master switch that completely disables status bar icon or a check box to disable changing the alarm clock icon.

[MENTION=5008415]C3C076[/MENTION] is that acceptable, and if so, which alternative would you prefer? I can submit a patch myself.
[Xposed Framework Modules] terrorist96:
The left icon displayed prior to an alarm going off has been fixed. The only issue I see remaining is the incorrect icon being used by dashclock's next alarm extension. I don't suppose there's anything you can do for this, is there?

Thanks for your awesome work!
[Xposed Framework Modules] Skhulile:
[MENTION=4775688]GermainZ[/MENTION] thanks a lot man after the 1.3.1 update everything works well. You ROCK!!:good::good:
[Xposed Framework Modules] GermainZ:
It can be done, but I'm not sure if that belongs in an Xposed module.

Test the attached build and let me know if it works. If not, please post another Xposed log.
[Xposed Framework Modules] jorgex94:
can you please add the Xperia clock icon in the next version?

And when I restart the phone the alarm stock icon is activated.
[Xposed Framework Modules] dimm0k:
[MENTION=4775688]GermainZ[/MENTION] is it possible to add the option for the alarm icon to go hidden at a preset number of hours prior to the actual alarm? so say my alarm is set to 7am on weekdays and I set this option to 24 hours, the icon would hide itself over the weekend until Sunday at 7am?
[Xposed Framework Modules] C3C076:
Looking at the source code, the stock icon is replaced only in case user chose to use KitKat style icons instead of stock JelltyBean icons.

If the user keeps stock icons, there should not be any conflict with this module.

Details.

Fragment that decides which icon to use depending on icon style:

https://github.com/GravityBox/Gravi...gm2/gravitybox/StatusBarIconManager.java#L595

If mBasicIconIds for a given iconStyle index is null (which is the case for alarm icon: https://github.com/GravityBox/Gravi...gm2/gravitybox/StatusBarIconManager.java#L165)

the original icon from SystemUI is used and only color filter is applied:

d = mSystemUiRes.getDrawable(resId).mutate();
d = applyColorFilter(d, PorterDuff.Mode.SRC_ATOP);

Edit: I see your point. You don't want to module to even set the stock icon, right?

The easiest would be to return stock icon only in case, user had coloring enabled before disabling it again.

If coloring is disabled and was also previously disabled, getBasicIcon would return null and icon won't be replaced.

Edit2:

Attached is the GB APK for JB with potential fix. Needs testing.

Note, that coloring in GB needs to be disabled.
[Xposed Framework Modules] Ja_som:
Hi, thank you...

I tried this now... Changed icon to JB (is gray, not white), I reenabled alarm, icon is changed with DAI icon, then I opened GB settings and icon is again stock JB...
[Xposed Framework Modules] C3C076:
Check previous post. But it's GB APK for JellyBean, I can release the KK version with the same fix, if you want to test.
[Xposed Framework Modules] Ja_som:
Yes please. I use KK version.

Thank you.
[Xposed Framework Modules] C3C076:
Here you go.

Make sure statusbar icon coloring in GB is disabled.

Please, let us know. I cannot currently test with this module myself.
[Xposed Framework Modules] Ja_som:
Thank you again...

Tested with KK and also with JB icon, icon is still changing to stock :(

With disabled icon coloring battery and signal icons with time are white also on white status bar (see picture)
[Xposed Framework Modules] C3C076:
As I said, the fix in GB will work only as long as Icon coloring is disabled. White status bar is not a GB issue. When coloring is disabled, it also applies to status bar. This means something else is keeping it white.
[Xposed Framework Modules] Ja_som:
But is also not working with disabled coloring. White status bar is not an issue, it is Tinted Status Bar :)

This issue is in combination with 3 xposed modules.

When I have enabled only Tinted Status Bar and DynamicAlarmIcon then everything is OK, as you can see on first image.

But when I enable GB, then I need to have enabled coloring, because some icons are not changing (second picture) and then also the alarm icon changes to the stock.

But, if this is hard to fix it, I can live without DynamicAlarmIcon (sorry GermainZ, but I am grateful to you for your hard work ;) ) but I can't live without GB, because I have a lot of things changed with GB.
[Xposed Framework Modules] GermainZ:
Can you post the Xperia clock icon (it's in the SystemUI APK, in res/drawable-xxhdpi/stat_sys_alarm)?

Are you using GB? If so, we're looking into it as you can see. :p

It's planned, though I'm not sure if it would be possible to support all clock apps for that. I need to look into it.

Yes, exactly.

I think there are two solutions here that would work in all cases:

1- in GB, allow the user to completely ignore certain icons.

2- In this module, restore the custom alarm icon in an afterMethodHooked hook for getIcon, basically undoing what GB did in the beforeHookedMethod hook.

The 1st method might be handy for some users who use other mods that may change the status bar icons. The 2nd method would require no modifications from your part.

I'm happy with both, so if you've never had complaints about other modules conflicting, I guess the 1st method isn't worth the time for one module.

Thanks a lot for dropping by, though! :)

It's not a competition, lol – you use what you want.
[Xposed Framework Modules] dimm0k:
The Touchwiz version looks a bit oversized compared to pre-mod... still looks good, just stands out a bit too much. Pretty cool mod nevertheless!
[Xposed Framework Modules] GermainZ:
Can I see a comparison?
[Xposed Framework Modules] Roudier:
+1 (for both points)

Germain, I attached the requested TouchWiz stat_sys_alarm.png file to my former post. As it's white on a white background, maybe you missed it, so here it is again just below.
[Xposed Framework Modules] GermainZ:
That's what I used to recreate the TouchWiz icon, and the dimensions match perfectly for me. That's why I'd like to see how it looks in the status bar. :)
[Xposed Framework Modules] Roudier:
Weird... Just give me a second.

Here you are, stock TW icon up (in white), Dynamic Alarm Icon mod bottom (in blue). Looks slightly bigger, goes down further than the bottom line of the status bar, much thicker (less readable) hands :
[Xposed Framework Modules] GermainZ:
It doesn't look like you're using the latest version (1.3.1).
[Xposed Framework Modules] Roudier:
Hmm, after a second thought, I guess you are right : the design of the clock is a give-away. Seems I used an "old" screenshot I had with your mod enabled (sooorry), can't remember now what version it was.

So, I just checked I had the latest version of your mod :

Then set up an alarm and took another screenshot (a fresh one this time) ; here's the comparison with the stock TouchWiz icon again. Well, my former "mistake" will be useful, as obviously, things are even a bit worse here (regarding the size, of course) than in the former version of your module.

As I (too often) say, the bigger is not always the better. ;)
[Xposed Framework Modules] GermainZ:
Thanks a lot for the screens. It's not really worse TBH, since the design is mostly the same (it was quite different (and a bit broken if you look at the right leg) in 1.3.0).

I just have to edit one value (the radius) to make it smaller, which is pretty easy. :) Anyway, I compared the radii from your screen and modified the radius used by this module accordingly. Please test and let me know if it's good and if it still needs to be smaller/bigger.
[Xposed Framework Modules] Roudier:
No, thanks a lot for your time and work. Yup, I noticed the tiny changes in the design of your clock, the latest one was spot-on. So, I just tried your test version : the size of the icon is absolutely fine by now, as you can see below. The readability of the hands is still average, but I guess it's specific to the TouchWiz design itself...

Thanks again, Germain. :good:
[Xposed Framework Modules] GermainZ:
Mhmm… it's still a tiny bit bigger than the original. I've made the radius and the hands a bit smaller, does that look any better?
[Xposed Framework Modules] Roudier:
Well, here's (a part of) the icon of your test 2 version (in blue) placed over the stock TouchWiz icon (in white) : the differences in design and size are of the order of a couple of pixels only, which won't be noticeable to the eye IMO.

But well, I'll try your test 3 version right away.
[Xposed Framework Modules] dimm0k:
thanks [MENTION=5960726]Roudier[/MENTION] for filling in for me, didn't have time to get a screenshot in until now. thanks [MENTION=4775688]GermainZ[/MENTION] for the FAST turnaround and hard work!! test3 works for me!
[Xposed Framework Modules] Roudier:
And here are the results of the mod test 3 :

Edit

: for info, here's a comparison, side by side, of the stock TW and Test 3 icons, placed at their respective levels (heights) on the screen. This time, I've set the alarm at 10:10 to have a better similarity between the two. Looking more closely, it seems that decreasing the radius of the test 3 icon makes it now look like sitting a couple of pixels too low on the status bar. But it's only a tiny detail, of course. LOL, I'm sorry Germain, but I used to make icons and improve Winterboard themes for my iPhones & iPad : believe me, being as fussy as I am about details nearly drove me nuts. I promise it will be my last intervention here about your TW icon. :D
[Xposed Framework Modules] jorgex94:
No, I'm not using Gravity Box...

This module works perfect, but after restart back to the original icon appear in the status bar

Maybe it's because I have modified the SystemUI.apk

Here's the icon from stock Xperia ;)

And thanks for the answer...
[Xposed Framework Modules] Ja_som:
[MENTION=4775688]GermainZ[/MENTION]

This module checks alarm status in some intervals?

When icon changes to stock (e.g. when status bar changes color), then after some time I have again icon from DAI.
[Xposed Framework Modules] GermainZ:
It's not a problem, it's easy to fix and I'm happy to do it. I'll post another text release with an icon that's a bit smaller. :p

Thanks. I don't know why the original icon is appearing after a restart, but if you can upload your SystemUI APK I can have a look.

No, it only changes the icon when NEXT_ALARM_FORMATTED is changed. That might be done by your clock app.
[Xposed Framework Modules] punkmonkey1984:
Any plans for Miui support, currently not working on my N4 - 4.4.2

I was thinking about this alarm icon today.

Its a great idea. Thanks
[Xposed Framework Modules] Roudier:
Great. You're almost done then, see below. :good:
[Xposed Framework Modules] zeljkoxt:
A problem .. on Note 2 , ditto note 3 rom (4.3)... everything worked fine until today. At one point i applied icon pack through unicon, restarted shell and now i don't see dynamic alarm icon any more after restart, only stock icon. If i want to make it work i must delete any alarms i set previously so that stock icon disappear and after setting alarm time again dynamic icon show up immediately. When icon is present if i switch between aosp and touchwiz style, old style remains just like there is no refresh of statusbar. (sorry for grammar and misspelling)

Any thoughts about this ?
[Xposed Framework Modules] chw9999:
Huh, I just noticed the alarm clock does not work anymore with app versions higher 1.2.1 on my ICS Sense Rom. 1.2.1 works with the "click two times to show the last time" glitch, but apart from that flawless.

Newer versions just show the regular unchanged icon... Could you have a look?

Thanks!
[Xposed Framework Modules] GermainZ:
I deeply dislike MIUI because of their policies and actions. Patches welcome from any dev using MIUI, but I won't personally look into it.

Are you guys using GravityBox or any module that might be changing the status bar icons (e.g. to apply colors)?

(Note that changing the style/color in DynamicAlarmIcon currently requires a reboot.)
[Xposed Framework Modules] zeljkoxt:
Im using xbatterythemer and xuimod for adding clock seconds but that should not be a problem as I know that dynamicalarm worked before.. the same version (1.3.1)
[Xposed Framework Modules] GermainZ:
Could you upload your SystemUI APK?
[Xposed Framework Modules] zeljkoxt:
i have sent you a private message, cant post links here because i have less than 10 posts. tnx.
[Xposed Framework Modules] GermainZ:
It's slightly smaller in the attached build, hopefully it's enough. :D

Could you please install the attached build, reboot and post your Xposed logs? I've added some extra logging so I can identify the problem. Thanks. :)
[Xposed Framework Modules] zeljkoxt:
Here it is ...
[Xposed Framework Modules] GermainZ:
No wonder it's not working, it's failing to hook something and crashing.

Thanks, I'll upload another test build as soon as possible.
[Xposed Framework Modules] GermainZ:
Another test build attached that should hopefully fix the issues on pre-KK devices. If not, please upload your Xposed log (open the Xposed Installer > Logs > Menu button > "Save to SD Card" or "Send").
[Xposed Framework Modules] chw9999:
Argh, thanks man, just installed DynamicAlarmIcon-1.3.2-test4, rebooted, works flawlessly on ICS sense, now new version again - do you ever sleep? [emoji6] I really appreciate your effort, thanks a ton!

Will install new version now, but reboot and report tomorrow (almost midnight here). Need sleep [emoji1]

Cheers!
[Xposed Framework Modules] zeljkoxt:
We have a winner!

Its working now. I installed test5, enabled it, reboot and aosp icon showed up. For touchwiz style to apply i must reboot after selection.. dont know is this expected behavior or it should apply immediately after selection. Launcher icon dissapeared without reboot, after disabling check box.

Tnx again.
[Xposed Framework Modules] chw9999:
GermainZ, thanks a ton, everything works as supposed [emoji1]
[Xposed Framework Modules] XlAfbk:
There's 2 places the alarm icon isn't replaced. On CM11, not sure whether they exist in other ROMs. Would be great if those could be replaced as well!

- Quick settings panel

- Upcoming alarm notification

Thanks for this very nice module!
[Xposed Framework Modules] GermainZ:
Quick settings panel: haven't looked into that yet.

Upcoming alarm notification: what clock app are you using (package name, please)?
[Xposed Framework Modules] theknut:
GermainZ, this is not really a usecase but I noticed your module throws NullPointerExceptions when the time is set past a set alarm. I noticed this when I tested something for my module and I thought I'd share it with you. Not a big deal if you don't have time to fix it as this is a rare use case and the drawables are still OK.

set alarm to current time plus 10 minutes

set your device system time to current time plus 15 minutes

a notification will appear that you missed your alarm

see Xposed error log for NullPointerException

I'm on 1.3.1. The error occurs here.

While you are at it, would you mind removing the Xposed loggings?
[Xposed Framework Modules] XlAfbk:
com.android.deskclock, CM11 version