yashsingh1/xdaforums huggingface dataset:
[Android] Albert Tross:
Thank you, tripLr and ripee for your great support!

Yes, my device is the T819, I must have mixed something up assuming that it was the gts210ltexx.

cd ~/android/lineage/.repo/local_manifests
rm *
whet -O roomservice.xml https://raw.githubusercontent.com/ripee/local_manifests/lineage-16.0/gts210velte.xml
repo sync -c --force-sync --no-clone-bundle --no-tags
. build/envsetup.sh

[MENTION=6005084]ripee[/MENTION] Thanks man, I am truly blown away by all the support and awesome people in here.

Makes me want to dedicate much more time to this and help out others.

I will try 16.0 with this roomservice now and the correct device tree.

<?xml version="1.0" encoding="UTF-8"?>
<manifest>
<project name="LineageOS/android_device_samsung_gts210velte" path="device/samsung/gts210velte" remote="github" revision="lineage-16.0" />
<project name="LineageOS/android_device_samsung_msm8976-common" path="device/samsung/msm8976-common" remote="github" revision="lineage-16.0" />
<project name="LineageOS/android_hardware_samsung" path="hardware/samsung" remote="github" revision="lineage-16.0" />
<project name="LineageOS/android_hardware_sony_timekeep" path="hardware/sony/timekeep" remote="github" revision="lineage-16.0" />
<project name="LineageOS/android_kernel_samsung_msm8976" path="kernel/samsung/msm8976" remote="github" revision="lineage-16.0" />
<project name="LineageOS/android_packages_resources_devicesettings" path="packages/resources/devicesettings" remote="github" revision="lineage-16.0" />
<project name="TheMuppets/proprietary_vendor_samsung" path="vendor/samsung" remote="github" revision="lineage-16.0" />
</manifest>

One more question about the various commits that are being repopicked.

repopick 226756 226757 226758 226759 226760 226761 226762 226763 226764 226765 226766 226767 226768 232034
brunch gts210velte

I must agree that I am a bit paranoid, but it appears that 7 of these commits have not been verified, I am checking how important those are, but do you think it's a problem?
[Android] ripee:
[MENTION=10012590]Albert Tross[/MENTION] who cares if a gerrit commit is verified? These are intended to improve RIL functionality.
[Android] Albert Tross:
Please excuse my noobishness, my lord.

Build completed successfully.:)

lineage-16.0-20190703-UNOFFICIAL-gts210velte.zip

I just flashed it with pico gapps and everything appears to be working properly.

Contrary to my suspicions, I have not yet experienced any instances of severe lag or greatly diminished battery life

I will still continue to build 14.1 next and Resurrection Remix as my final act.

Would you like me to upload the 16.0 zip for you or should I open a thread?

BIg thanks [MENTION=5624167]tripLr[/MENTION] [MENTION=8017005]srgrusso[/MENTION] [MENTION=6005084]ripee[/MENTION] !

Edit:

There seems to be a problem with the cm-14.1 branch though

From https://github.com/LineageOS/android_kernel_samsung_msm8976
* [new branch] cm-14.1 -> github/cm-14.1
fatal: Couldn't find remote ref refs/heads/cm-14.1
error: Cannot fetch LineageOS/android_device_samsung_gts210velte from https://github.com/LineageOS/android_device_samsung_gts210velte
error: Cannot fetch LineageOS/android_kernel_samsung_msm8976 from https://github.com/LineageOS/android_kernel_samsung_msm8976

<manifest>
<project name="LineageOS/android_device_samsung_gts210velte" path="device/samsung/gts210velte" remote="github" revision="cm-14.1" />
<project name="LineageOS/android_device_samsung_msm8976-common" path="device/samsung/msm8976-common" remote="github" revision="cm-14.1" />
<project name="LineageOS/android_hardware_samsung" path="hardware/samsung" remote="github" revision="cm-14.1" />
<project name="LineageOS/android_hardware_sony_timekeep" path="hardware/sony/timekeep" remote="github" revision="cm-14.1" />
<project name="LineageOS/android_kernel_samsung_msm8976" path="kernel/samsung/msm8976" remote="github" revision="cm-14.1" />
<project name="LineageOS/android_packages_resources_devicesettings" path="packages/resources/devicesettings" remote="github" revision="cm-14.1" />
<project name="TheMuppets/proprietary_vendor_samsung" path="vendor/samsung" remote="github" revision="cm-14.1" />
</manifest>

Edit2: I worked around it by using a different repo for the kernel
[Android] ripee:
[MENTION=10012590]Albert Tross[/MENTION], luk1337 already opened a pie gts210velte thread.
[Android] Albert Tross:
I just finished building Resurrection Remix Pie for the gts210velte, I'll start testing it later.

Unfortunately I was forced to use an unofficial repo for qcom_common and the device tree.

Would that still be acceptable for a development release thread?
[Android] srgrusso:
All my roms I build are unofficial and use unofficial code. Most of the threads you see posted are unofficial builds. So yah I would say it is alright. I would recommend testing your roms first. Also have you asked for a developer account on https://androidfilehost.com. It's a great place to host your roms for free. More than likely they will give you an account. One thing I would be mindful of is always give credit to the developers your using code from. If your using someones else's device tree or forked their work make sure you mention it in your thread. I always make sure that no one has already posted a thread for the rom i'm developing. I will say this again always cite other people's work.

Congratulations and enjoy your journey into rom building. :highfive:
[Android] Albert Tross:
Thank you for the great advice, I will make sure to credit any original contributors.

Is it true that most devs release their code on github under a creative commons license or how does that work exactly. Does one have to waive any legal claims regarding intellectual property etc. before sharing on github?

I have been thinking about a crowd funded development model, where xda devs only release particularly desired roms upon completion of a certain donation goal. I mean, all that research, compiling, maintaining, direct support and bug tagging consumes a lot of time and resources, for which developers should be compensated for. Obviously there would always be that one guy who does it for free attempting to disrupt the cause, but the well respected and renowned devs should make the first step to steer away from the current *get everything for free and still complain* model, imho.

What do you think?
[Android] srgrusso:
I think that would defeat the purpose of open source and the topic is probably off topic for this thread.

Edit: I agree developers put in a lot of their personal time and money that most people take for granted. I think that if you like the developers work it would be nice to donate. But I don't feel it should be a requirement. I have a donate button but never had any donations. I put it there in case someone wanted to donate to me to help buy more devices or more hardware resources for developing.

---------- Post added at 08:09 PM ---------- Previous post was at 08:02 PM ----------

I'm building for 2 devices and I would like to append the device name to the output file. Does anyone have any suggestions other than adding it by hand? Is there some build option I can add to my liquid.mk file?

Thanks
[Android] NepoRood:
We all do this in our spare time, it's not about the money, you can't require people to spend/pay/donate and post as much on XDA, it's against the rules...
[Android] NepoRood:
What ROM, ours has the device name in each build
[Android] srgrusso:
Liquid Remix. All the other roms I build have the device names in them. The differences I see is for example AEX use aosp_gtaxlwifi.mk but in Liquid Remix it uses liquid.mk. If I try liquid_gtaxlwifi.mk it won't find the make file.
[Android] DiamondJohn:
I am pretty sure they are building LiquidRemix, based on their make file name.

I have built that specific ROM, and also all ROMs I have previously built., already include the device name in the resulting ROM zip. For example, my LiquidRemix build came out as "liquid_remix-10.0.9-20190703-UNOFFICIAL-ks01ltexx.zip" Although, I had to make a small change to the device source to ensure it came out as Un-Official instead of Official. But that was only part of the changes I had to make to get it to compile for an unofficial device.
[Android] srgrusso:
Mine comes out as liquid_remix-10.0.9-20190705-UNOFFICIAL-true.zip. I don't know where it is getting the true from. Here is my device tree https://github.com/srgrusso/android_device_samsung_gtaxlwifi/tree/liquid-remix-9.0_64-bsp.

Edit: I have this in my liquid.mk file "LIQUID_BUILD := true". Should it be "LIQUID_BUILD := gtaxlwifi"? I added that so it would build the kernel. Man I feel like an idiot. :o
[Android] Soumy1234:
Background information:

ROM: Resurrection Remix Nougat

Device: Galaxy Tab 3 10.1 (santos10wifi)

Lineage OS ROM for the same devices with the device source code and extra commits (will be important later):

https://xdaforums.com/galaxy-tab-3/development-10/rom-lineageos-14-1-t3587761

I have a couple of questions:

1. How can I add a swap file to my ROM? The Lineage OS ROM for my device once had a 512mb swap file so I'm wondering if I could do the same.

2. My device has three variants, but I only have one of them, so I can only test one of them. Is it ok to post ROM zips for all three devices here on a separate thread if I compiled them or no?

3. My ROM has problems with Magisk (long boots, Magisk Manager is slow, "Magisk is not installed", empty su list). The developer, nels83, who has created the lineage os ROMs for the same devices also works on the device source files. His ROM have the same Magisk issues as mine, so I think the problem is with the device sources and/or the extra commits.

The developer, like many others, isn't always working on this project, and it is unknown when he'll return if he'll return at all. I have little coding experience, so I don't know what and how to fix these issues.

My question is, being the developer of my ROM, can I upload it regardless, should I wait for nels83 to return and work on the device sources, or should I still try to find some way to fix these issues despite my lack of knowledge (and where can I start?)?
[Android] DiamondJohn:
I dont have a "LIQUID_BUILD", but I do have the following in my liquid.mk I made these changes for a simple test build, its not an official build, so take with a grain of salt.

...snip...
#export
LIQUID_BUILD_TYPE := UNOFFICIAL

PRODUCT_PROPERTY_OVERRIDES += \
ro.liquid.maintainer=DiamondJohn

## Device identifier. This must come after all inclusions
PRODUCT_NAME := liquid_ks01ltexx
PRODUCT_DEVICE := ks01ltexx
PRODUCT_MODEL := GT-I9506
...snip...

and the following in my full_ks01ltexx.mk

...snip...
# Set those variables here to overwrite the inherited values.
PRODUCT_NAME := full_ks01ltexx
PRODUCT_DEVICE := ks01ltexx
PRODUCT_MODEL := ks01ltexx
PRODUCT_BRAND := samsung
PRODUCT_MANUFACTURER := samsung
...snip...
[Android] srgrusso:
I fixed it by adding "LIQUID_BUILD := gtaxlwifi" to my liquid.mk

Thanks for your help
[Android] AmirHRC:
who can help me and tell me how to cherry pick smarpixel feature to my build
[Android] Soul Spark:
Error while repo init

Get git://github.com/RevengeOS/android_manifest.git
Traceback (most recent call last):
File "/home/alpha/rom/.repo/repo/main.py", line 547, in <module>
_Main(sys.argv[1:])
File "/home/alpha/rom/.repo/repo/main.py", line 522, in _Main
result = repo._Run(argv) or 0
File "/home/alpha/rom/.repo/repo/main.py", line 184, in _Run
result = cmd.Execute(copts, cargs)
File "/home/alpha/rom/.repo/repo/subcmds/init.py", line 426, in Execute
self._SyncManifest(opt)
File "/home/alpha/rom/.repo/repo/subcmds/init.py", line 188, in _SyncManifest
m._InitGitDir(mirror_git=mirrored_manifest_git)
File "/home/alpha/rom/.repo/repo/project.py", line 2395, in _InitGitDir
self._UpdateHooks()
File "/home/alpha/rom/.repo/repo/project.py", line 2416, in _UpdateHooks
self._InitHooks()
File "/home/alpha/rom/.repo/repo/project.py", line 2446, in _InitHooks
os.path.relpath(stock_hook, os.path.dirname(dst)), dst)
File "/home/alpha/rom/.repo/repo/platform_utils.py", line 195, in symlink
return os.symlink(source, link_name)
OSError: [Errno 38] Function not implemented

Getting this error while

repo init -u git://github.com/RevengeOS/android_manifest.git
[Android] DiamondJohn:
I think you are using the wrong var/placeholder. That one should be either Release (for official builds) or UNOFFICIAL for, you guessed it, unofficial builds.

The device setting is

PRODUCT_DEVICE := gtaxlwifi

Although it appears to work for you, I have previously and currently use LIQUID_BUILD_TYPE

---------- Post added at 21:25 ---------- Previous post was at 21:16 ----------

I am sure I read about this here somewhere, I would like to build my ROM to boot permissive, but switch to enforcing, or at least be able to be switched to enforcing once its up and running,

I have used the following to switch it to permissive, however, as far as I am aware, once you do that, it can not be switched to enforcing

BOARD_KERNEL_CMDLINE += androidboot.selinux=permissive

Or am I wrong? I have to admit, I haven't actually tested it.:o

If it could, I guess I could see that modifying one of the init files, for after boot complete event, would be a possible in-road.
[Android] NepoRood:
LIQUID_BUILD should reflect the device being built for without being declared in device tree, IF you wanted to it say "official" or anything else for that matter, it would probably be something like:

export LIQUID_BUILD_TYPE := Official

As for the SELinux thing, that command in your kernel command line will work, remove it to go back to enforcing. Only ways I know to change after boot is with ADB or Terminal Emulator. In Shell or Su, respectively:

setenforce 1 (enforcing)

setenforce 0 (permissive)
[Android] DiamondJohn:
Going off one of the official devices: https://github.com/LiquidRemix-Devices/android_device_leeco_s2/blob/pie/liquid.mk They have:

...snip...
PRODUCT_DEVICE := s2
...snip...
# ONLY FOR OFFICIAL LIQUID TAG
LIQUID_BUILDTYPE := RELEASE
...snip...

However, it does show that It IS "LIQUID_BUILDTYPE" and not "LIQUID_BUILD_TYPE" :o my bad.

Used that before, but that would give me the exact opposite. ie it would boot enforcing and then switch to permissive after the boot has completed. :(

I haven't been building permissive for a while, but from memory, I thought (ie I could be wrong) that if you set the kernel permissive as above, you could not switch to enforcing once the ROM was up and running? ie it took a different method / technique / code.I tried searching the web, but didn't find anything, so it may of just been me misreading / remembering it wrong.
[Android] NepoRood:
I'm pretty sure I've seen it both ways, BUILD_TYPE and BUILDTYPE, (I could be wrong too, lol)

I've never tried to make it "enforce" with a permissive build, I will next chance I get, cause now I want to know :good:
[Android] DiamondJohn:
Yep, my assumption was wrong. I did a permissive build (so it booted permissive), and then tried setting it as enforcing, manually after it booted, and the ROM then reported that it was enforcing.

I previously in the few ROMs I have built, have only seen it as "_BUILD_TYPE", and in my first builds of liquid, thats what I had placed in the code, and it did work; ie my outputted zip was tagged/named as "unofficial". Its only after checking official liquid devices that I noticed it was coded as "_BUIDTYPE". So either appears to work for liquid.

Without doing an actual test to see if something fails (ie not just logged) because of an enforcing kernel, it appears it is possible,
[Android] Sword900:
Hello!

My device thread is here: https://xdaforums.com/general/general/teclast-master-t8-e8c1-thread-t3900666

It has rarest MTK chipset : MT8176 (aka MT8173). Kernel - 3.18.35, Android 7.0.

For now, I've ported all the available ROMS (stock firmwares mostly) and would like to build something new by myself. I've tried to find kernel source for my device, but only found kernel sources for other devices on this SoC. Also device tree was found and lineage os resources for alike device (Xiaomi MIPAD 3).

So, I would like to know, is there an opportunity to make custom kernel or firmware for my device as I don't have kernel source?

I will appreciate any help. Have so many questions (even dumb). Don't even know where to start. . .
[Android] srgrusso:
You might be able to but it will take a little work. Check out this link https://xdaforums.com/android/general/guide-how-to-build-custom-roms-kernel-t3814251

He has several videos on what you're trying to do. I hope this link you to the first post.

Edit Now that I am at home this is his video playlist I would recommend for what you want to do. Good Luck :)

https://www.youtube.com/watch?v=5c66tBsiVVM&list=PLRJ9-cX1yE1nnhWBrZtuVz5YC2OPfQVVp
[Android] hayahsc3:
How did you do that, my firend?
[Android] DiamondJohn:
I am building ROMs for a Samsung Galaxy S4 GT-i9506 (ks01ltexx). A lot of init, ownership and permissioning of folders is handled by the file

android_device_samsung_ks01ltexx/rootdir/etc/init.qcom.rc

A while back, we had an issue where I found by checking the folders of a running device, that the RIL folders ownership/permissioning in the file, did not match the actual folders on a running device; so they were corrected to folders that were on a running device. I would *guess* that occurred from the original source coming/matching a previous version modem.

Anyway, I had a browse of the current version of the device init.qcom.rc. Within the file, there are references to many paths that do not exist on a running device, but the code appears to be setting permissions/ownership up for the devices sensor to operate. eg, the following appears to ensure that the accelerometer sensor has the necessary ownership to operate correctly:

# Accelerometer_sensor
chown system radio /sys/class/sensors/accelerometer_sensor/raw_data
chown system radio /sys/class/sensors/accelerometer_sensor/calibration
chown system radio /sys/class/sensors/accelerometer_sensor/reactive_alert
chown system radio /sys/class/sensors/accelerometer_sensor/vendor
chown system radio /sys/class/sensors/accelerometer_sensor/name
chown system radio /sys/class/sensors/accelerometer_sensor/selftest

Similar code is there for numerous sensors. eg: Accelerometer_sensor, Proximity_sensor, Light_sensor, Gyro_sensor, Barometer_sensor, Magnetic_sensor, Temphumidity_sensor, Grip_sensor, HRM_sensor, UV_sensor, SensorHub, Gesture_sensor

However, on a running device of this ROM, the path /sys/class/sensors/ is completely empty:confused:. And further, our device does not even have Grip, HRM or UV sensors:confused:

can/should these lines be removed? and as a general rule, should lines for folders permissioned/ownership set, but not created by the init file, be there at all?
[Android] VincentJoshuaET:
Is it possible to compile only specific packages (android_system_bt, android_packages_apps_bluetooth, android_packages_apps_settings, and android_frameworks_base)? Thanks.
[Android] NepoRood:
In my limited experience, init files can be finicky creatures. I'm pretty sure all the stuff in qcom init covers more than one device, though, probably more related to the SoC itself than any particular device...
[Android] DiamondJohn:
Now that you say it out loud, its so obvious:o. The file IS in "android_device_samsung_msm8974-common". But it then makes me wonder, my device does have an accelerometer, so where is the setup for my device:(. Nonetheless, the accelerometer is working anyway, so meh
[Android] DiamondJohn:
A question I asked a while ago. The following commits may help point to what needs to be added. I havent tested it, so I am probably missing something.

https://github.com/kyasu/android_de...mmit/6c99fc35ac57f52d4158bb27055411fed99d059a

https://github.com/kyasu/android_de...mmit/e85e91cb89758aac10a15086b98188e5c9c9ee53

https://github.com/LineageOS/androi...mmit/d72529309a4b6ebe58ecbdb9ca01b310e209f6ff

Its a setting in LOS 16
[Android] JT1510365:
how do you that can you help me i am trying to figure this error for my rom that i am trying to build i am facing this error also. Are you on telegram?
[Android] Simon1511:
Hello, Im trying to build AOSP extended for my Galaxy A5 2017.

Im successfully building the ROM but when I install it on my device it just stays at the Samsung logo.

All sources Im using are Lineage sources except for vendor sources, they are from TheMuppets.

last_kmsg file is blank, there is not a single letter in the file.

I already took a logcat but I dont really understand much of logcats. I will attach the logcat file.

Can someone help me?
[Android] AndDiSa:
[MENTION=7334446]Simon1511[/MENTION] at a first glance I would say OpenGL ES libraries are missing or not accessable.
[Android] Simon1511:
How do I fix this?
[Android] camaroamarelo:
How to prevent rom from downloading tree from source?
[Android] alphamale:
I keep getting following error. Trying to build for crdroid for taimen https://del.dog/yobiqeqiza.pl. I've tried different device trees and still got same error.
[Android] nitin.chobhe:
Check if the commits needed for vendor.img are in kernel.mk file.

Nitin
[Android] tripLr:
Its called open source. Free to use, free to change, but must post changes as part of the free to use.
[Android] tripLr:
Its called open source. Free to use, free to change, but must post changes as part of the free to use.

If you try to dev with the above plan unless your ROM is really really really really good, it won't work.
[Android] Simon1511:
Hello,

Im trying to build OmniROM for my A5 2017, but it is not booting.

The phone hangs on the Samsung logo after installing it.

The build process gives no error and I can install the zip on my device.

I have already tried 2 different ROMs, but none of them boots.

Im completely using Lineage sources, only Vendor sources are from TheMuppets.

My last_kmsg shows no errors, so my device SHOULD boot. But it doesnt.

I also tried logcat, but ADB shows the phone as "unauthorized".

Any ideas?
[Android] DiamondJohn:
I do not know your specific device, however, I will go out on a limb with the following comments:

1. When I first started building ROMs, the thing that made it the easiest was that I started with an official build. In my case, that was LOS. It has very strong support with https://webchat.freenode.net/?channels=lineageos-dev Without their help, I would of not gotten anywhere. If you are building LOS from LOS sources, you may wish to give it a look there. And if its official, that may be a first good learning route

2. Just because there are no last_kmsg does not mean it should boot. For example, maybe one of the things broken IS last_kmsg... Also, if the reason it does not boot is because a big portion of the ROM is missing, then that section is not going to log an error, if the starting portion does not log the issue etc etc etc I know my device has last_kmsg, but many use a different logging avenue now.

3. It might help to attach/post your local_manifest and the repo_init command you used (preferably LOS as its more familiar to many)

4. On a wild note, are you certain you have the correct bootloader and modem flashed on the device?

5. How big is the resultant ZIP? does it look about what you would expect?

6. If you are using LOS device / vendor / kernel for a custom ROM, I have always had to modify at least the device tree to be aware/compatible with the custom ROM I am using it to build.

Just some suggestions, others with more specific knowledge, may chime in