yashsingh1/xdaforums huggingface dataset:
[Android] Arvind7352:
Uhmm, that's a proprietary (vendor) lib as referenced from HERE... Confused (check if you have synced proprietary_vendor_yu ) :eek:
[Android] aalupatti:
I am building roms regularly.. Currently doing Pure nexus rom. I can do basic builds. However I wanted to add a package to the build.

Eg : for purenexus - ( https://github.com/PureNexusProject ), I am building ROM from the oms branch. But I want to add the package ( https://github.com/PureNexusProject/masquerade ) . This is not normally included in the default build.

Can someone please help me.
[Android] MSF Jarvis:
Have you tried reading the README? It takes a blind guy to not understand those simple instructions
[Android] aalupatti:
[emoji27]

Sent from my Nexus 6P
[Android] MSF Jarvis:
What's not clear? Add masquerade as a product, add one line to the manifest. Someone who build ROMs regularly, familiar with basic building can be reasonably expected to understand them.
[Android] skull(nj):
Same arror originate after CLOned the vendor again
[Android] kn06497:
any idea is RR lollipop

http://pastebin.com/d2Y5xrZv
[Android] aalupatti:
Now I get it .. I was reading the wrong readme file..

Thanks
[Android] MSF Jarvis:
I don't do {insert system language here}, so can't help. Please try to post English logs here :)
[Android] XeniX_Force:
Help with building CM11 for my unsupported device.

Can someone please help me with these issues?
[Android] skull(nj):
error

stderr log

http://hastebin.com/isisenifex.pl

stdout log

http://hastebin.com/ogowayarug.vhdl

one solution of this error is change hardware/qcom/wlan file but it didnt help me
[Android] skull(nj):
Any help pls
[Android] DarkFrenzy:
error while building AOSP 6

its about Multiple same specifications for ...

http://pastebin.com/Uq9WcRwP
[Android] :
I changed the toolchain to 4.8 and then set the TARGET_GCC_VERSION_ARM := 4.8 in my BoardConfig but still I stumble upon the same error.
[Android] firefoxjds:
Help building packages/apps/Bluetooth/jni

Super stuck building for osprey. Could really use a hand.http://pastebin.com/PHWhmT6F

---------- Post added at 10:49 PM ---------- Previous post was at 10:15 PM ----------

Building DU 10.3 for Osprey/ motog 2015

Stuck somewhere near apps/packages/Bluetooth/jni.

I could really use a hand. http://pastebin.com/PHWhmT6F
[Android] _superman:
Help please

[/home/androbot/cm13/out/target/common/obj/APPS/Gello_intermediates/org.cyanogenmod.gello-20.apk] Error 127

make: *** Waiting for unfinished jobs....

make: Leaving directory '/home/androbot/cm13'

#### make failed to build some targets (03:32 (mm:ss)) ####

Happens this when brunching
[Android] limjh16:
Could someone help here? Sorry MSF forgot to get it on gist. I'll remember next time :)

Edit: Figured I should post my local_manifest and explain myself.

<?xml version="1.0" encoding="UTF-8"?>
<manifest>
<remove-project path="system/core" name="android_system_core" remote="SlimRoms" revision="mm6.0" />
<remove-project path="packages/apps/SamsungServiceMode" name="packages_apps_SamsungServiceMode" remote="SlimRoms" revision="mm6.0" />

<project name="limjh16/i9305_device" path="device/samsung/i9305" remote="github" revision="slim"/>
<project name="Haxynox/android_kernel_samsung_smdk4412" path="kernel/samsung/smdk4412" remote="github" revision="Mmm" />
<project name="rodman01/android_device_samsung_smdk4412-common" path="device/samsung/smdk4412-common" remote="github" revision="pans_common" />
<project name="limjh16/proprietary_vendor_samsung" path="vendor/samsung" remote="github" revision="n-3.0" />
<project name="CyanogenMod/android_hardware_samsung" path="hardware/samsung" remote="github" revision="cm-13.0" />
<project name="limjh16/android_system_core" path="system/core" remote="github" revision="slim"/>

<project name="CyanogenMod/android_device_samsung_smdk4412-qcom-common" path="device/samsung/smdk4412-qcom-common" remote="github" revision="cm-13.0"/>
<project name="CyanogenMod/android_external_sony_boringssl-compat" path="external/sony/boringssl-compat" remote="github" revision="cm-13.0" />
<project name="CyanogenMod/android_packages_apps_SamsungServiceMode" path="packages/apps/SamsungServiceMode" remote="github" revision="cm-13.0"/>
<project name="CyanogenMod/android_external_stlport" path="external/stlport" remote="github" revision="cm-13.0"/>
</manifest>

I already have a slim running with valid RIL, but I am trying with different blobs because my current config is facing some lag, which is also faced by other ROMs for my device using the same blobs. I was using nameless for hardware/samsung and smdk4412-common. Therefore, now I am trying with CM blob in hopes to fix the lags and wierd touch bugs faced.
[Android] Arvind7352:
I think you may need to update your android_system_bt repo from DU

repo sync android_system_bt -j1 -c --force-sync

and Continue the Build
[Android] adityaupreti:
remove gello and compile
[Android] Qiangong2:
I get a warning when I build xosp (cm13) that system/build.prop is not there to be added to the zip. I have system.prop in my device tree.

My device tree: http://github.com/Qiangong2/android_device_samsung_logan2g branch xosp

My Kernel tree: http://github.com/Qiangong2/android_kernel_samsung_logan2g branch cm-13

The full error:

http://pastebin.com/XKXnFKHF

Also, I'm getting the install-recovery.sh error again. My previous fix for it does not work and every time I place it in the ota_temp folder is automatically deletes itself on any brunching I do.
[Android] skull(nj):
Help me also pls
[Android] firefoxjds:
I am on my way home right now to give it a try. Thank you so much for responding. I'll let you know if it works :)
[Android] firefoxjds:
My friend, you have solved my issue with which I have been stuck for weeks. Thank you very much :)
[Android] firefoxjds:
Oops OK it worked for a little until I made an edit to a file to fix an error. Now I'm back to the same problem and the solution doesn't seem to work now. Do you know what might be causing this?

---------- Post added at 02:33 AM ---------- Previous post was at 02:16 AM ----------

Never mind :) sorry, I found the issue
[Android] Arvind7352:
Change this line of your init.rc

service flash_recovery /system/[COLOR="Red"]etc[/COLOR]/[COLOR="Red"]install-cm-recovery.sh[/COLOR]

to

service flash_recovery /system/[COLOR="Lime"]bin[/COLOR]/[COLOR="lime"]install-recovery.sh[/COLOR]

Hope that helps ...

Extra Information : (Learnt just now...)

Whatever things (<-related to services/commands) you add to an init file override the default ones (if the same exist) that are present HERE...

The Default init.rc has this commit which changes back the name of the script 'install-cm-recovery.sh' to 'install-recovery.sh' -

https://github.com/CyanogenMod/android_system_core/commit/f6264d40e9a33e2e81efa2660e4ebdd63b2e149f

and XOSP is CM-Based....

You need to bring this change to your init.rc too, which i told above
[Android] limjh16:
Bump...
[Android] MSF Jarvis:
Try adding libhwconvertor as a product in your device tree
[Android] limjh16:
Sorry, how? In boardconfig.mk or where?
[Android] MSF Jarvis:
You should have multiple PRODUCT_PACKAGES declarations in device.mk, just make sure that the except the last, all in a list should have a space and a backslash at the end
[Android] skull(nj):
Help me also:(
[Android] firefoxjds:
OK I had my hopes up. At first glance it seemed to fix things, but it actually created a new problem, which once fixed broought me back to the old errors. Now its saying I have too few arguments for code that I can compare onthe internet. I can't seem to solve it.
[Android] ParanoidNemo:
Post the error using hastebin please..not with a photo
[Android] Qiangong2:
Thanks man, I'll try it later today :)
[Android] limjh16:
Alright, will try over weekend
[Android] OdSazib:
Error! Help please

make: *** No rule to make target '/home/odsazib/dev/cm13/out/host/linux-x86/bin/dtbToolCM', needed by '/home/odsazib/dev/cm13/out/target/product/ido/dt.img'. Stop.

make: *** Waiting for unfinished jobs....

Notice file: external/zlib/NOTICE -- /home/odsazib/dev/cm13/out/host/linux-x86/obj/NOTICE_FILES/src//lib/libz.a.txt

make: Leaving directory '/home/odsazib/dev/cm13'

#### make failed to build some targets (02:57 (mm:ss)) ####

I'm building cm for first time, I m on Linux Mint18
[Android] Arvind7352:
First of all i want you to Edit your post and remove jackeagle's quote. You're making your post tooooo big.

Secondly, you're missing this Repository -> https://github.com/CyanogenMod/android_device_qcom_common/tree/cm-13.0

Sync / clone it to device/qcom/common
[Android] MSF Jarvis:
Do not use the quick reply button from the OP post please, it's a request. You need the dtbtoolCM from here, the location where it needs to be put is extremely clear and I will not spoonfeed you on it at all.

Credits to [MENTION=5991747]neonkat[/MENTION] for the fix shared earlier, you would have seen it easily had you searched the thread for the word 'dtbtoolcm' since that's all I did to find it.
[Android] neonkat:
not dtb tool,he needs device_qcom_common(included in that).
[Android] SlimShady's:
Or maybe he already has that repo but has set "dtbTool" only in mkbootimg.mk? He didn't even post device trees..
[Android] DarkFrenzy:
trying to build android N preview it builds fine but the build system (NINJA) doesn't build some very important libs like liboverlay.so and libstagefrighthw.so and i thinks thats y the screen is blank but can take a logcat.

Anybody has any idea or a fix for that ?
[Android] SlimShady's:
Don't build previews since we are 1 month behind the official release :D
[Android] :
[MENTION=6049586]Arvind7352[/MENTION] any help on this?
[Android] Qiangong2:
You have to use TARGET_KERNEL_CUSTOM_TOOLCHAIN := arm-eabi-4.8.
[Android] :
I did try that as well. Same error. Even when using 4.8 toolchain. I manually changed the directory from build pointing to 4.8 toolchain. Still error while compiling with 4.8 toolchain.
[Android] Qiangong2:
You remembered to make clean beforehand right?
[Android] Arvind7352:
Use this config instead of the one you tried...

TARGET_GCC_VERSION_EXP := 4.8

In BoardConfig.mk

You can change the value according to the tool chain you're using

Sent from The Machine
[Android] Qiangong2:
[MENTION=6049586]Arvind7352[/MENTION] helped me get past the install-recovery.sh error, now I get this on build: http://pastebin.com/dehk9xHZ

I don't understand why it is undefined as it is defined at the top of the cpufreq_stats.c file

My trees: http://github.com/Qiangong2/android_device_samsung_logan2g (branch xosp)

http://github.com/Qiangong2/android_kernel_samsung_logan2g (branch cm-13.0)
[Android] OdSazib:
Thnx all, i forgot to add missing packages in local_manifest and solved just after posting this and before any one's reply here :P

anyway fix was to add device_qcom_common and, Boring ssl compat and stlport.
[Android] Arvind7352:
I think you can safely remove those prototyping/definitions...

Precisely...

From Line 29 to Line 35

then, from Line 39 to Line 45

I see the same definitions/prototypings done in a header

of.h

, which is #included in cpufreq_stats.c
[Android] limjh16:
Quite late, but thanks, it works!
[Android] limjh16:
Sorry, spoke too early. Problem appeared again, checked late :(

Do I need to add some special repo or anything?
[Android] Qiangong2:
[MENTION=6049586]Arvind7352[/MENTION] The fix did not work. I get an implicit declaration error. The same two lines.
[Android] Albe96:
How to fix A/V recording in cm 13??
[Android] Arvind7352:
1. Paste Build Output to hastebin.com and link it to your post

2. Provide your Toolchain path. Looks like it's wrong.
[Android] MSF Jarvis:
Off-topic, extremely unlikely to be answered for the simple reason that there is nothing wrong with CM. You have cared neither to provide your device name, nor any of your sources, which is the absolute bare minimum for us to not label you as dumb.
[Android] saintxseiya:
Hi,

did you solve that?
[Android] osas514:
Mate don't you ever get tired? Btw did you specify your toolchain path in boardconfig? And why are you using 5.3 toolchain to compile grand kernel and rom? It won't compile(for the kernel part) and if you managed to do it then forget about booting..
[Android] sai milind:
managed to compile the kernel by setting proper tool chain path and now as the rom uses dragon tc and all other optimizations so facing many new errors and now i am really tired :p:p
[Android] bipindr123:
heY GUYS, is it possible to compile a 32bit rom from sources which build 64bit roms?

if yes can you give me a basic idea on how to do it
[Android] Arvind7352:
Sources aren't CPU-Architecture specific. Device tree should have proper information about CPU (32/64 bit and some other important properties)

Any ROM's source can build for both 32 and 64 bit devices.
[Android] kn06497:
Any idea?

target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/dir.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/ea.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/efs.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/index.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/inode.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/ioctl.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/lcnalloc.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/logfile.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/logging.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/mft.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/misc.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/mst.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/object_id.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/reparse.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/runlist.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/security.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/unistr.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/unix_io.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/volume.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/xattrs.c
target thumb C: libntfs-3g <= external/ntfs-3g/libntfs-3g/realpath.c
target thumb C: libntfs-3g <= external/ntfs-3g/ntfsprogs/utils.c
target thumb C: fsck_msdos <= external/fsck_msdos/boot.c
target thumb C: fsck_msdos <= external/fsck_msdos/check.c
target thumb C: fsck_msdos <= external/fsck_msdos/dir.c
target thumb C: fsck_msdos <= external/fsck_msdos/fat.c
target thumb C: fsck_msdos <= external/fsck_msdos/main.c
Import includes file: /home/xperiamm/XenonHD/out/target/product/jagnm/obj/EXECUTABLES/gatekeeperd_intermediates/import_includes
target thumb C++: libgatekeeper <= system/gatekeeper/gatekeeper_messages.cpp
clang++: error: unknown argument: '-fno-sanitize-coverage=edge,indirect-calls,8bit-counters,trace-cmp'
build/core/binary.mk:734: recipe for target '/home/xperiamm/XenonHD/out/target/product/jagnm/obj/SHARED_LIBRARIES/libgatekeeper_intermediates/gatekeeper_messages.o' failed
make: *** [/home/xperiamm/XenonHD/out/target/product/jagnm/obj/SHARED_LIBRARIES/libgatekeeper_intermediates/gatekeeper_messages.o] Error 1
make: *** Se espera a que terminen otras tareas....
target thumb C++: libgatekeeper <= system/gatekeeper/gatekeeper.cpp
clang++: error: unknown argument: '-fno-sanitize-coverage=edge,indirect-calls,8bit-counters,trace-cmp'
build/core/binary.mk:734: recipe for target '/home/xperiamm/XenonHD/out/target/product/jagnm/obj/SHARED_LIBRARIES/libgatekeeper_intermediates/gatekeeper.o' failed
make: *** [/home/xperiamm/XenonHD/out/target/product/jagnm/obj/SHARED_LIBRARIES/libgatekeeper_intermediates/gatekeeper.o] Error 1

#### make failed to build some targets (16:40 (mm:ss)) ####

xperiamm@MaxiCM-Team:~/XenonHD$
[Android] MSF Jarvis:
First things first, never paste logs in your post. Use sites like hastebin.com and paste everything necessary over there. Secondly, English language please! It's hard to debug an error if you can't understand the text
[Android] folgore95:
Is this a text from building? Because i think i'm building now.. My first ROM..

:crying:
[Android] quanganh2627:
Spoiler content hidden.

Your troubles is at clang flags when build gatekeeper, so did u add your own flags in your device tree, or somewhere in your local build repo? So recheck on your own.

By the way, I share u a method to locate your real troubles when building stop. It's very simple and for almost case. That's just open "Find" function of ur terminal( shortcut key is "CTRL + SHIFT + F"), then find scrollbars 2 regex as below(without quotes):

1. "error:" this will explain what happens, and sometimes it'll provide a method to resolve.

2. "make: ***" to help us locate which project easier.

Now I use yours as example:
[Android] folgore95:
I'm getting this error when i try to compile:

SOLVED!
[Android] folgore95:
Error when try to compile unofficial rom

ERROR:

No private recovery resources for TARGET_DEVICE jfvelte

make: *** No rules for making the object "jfvelte". Stopping.

//

i added device tree kernel and vendor to the local_manifest and i added the android info also in it. the repo sync works. when i start build this error appears. Some tips?
[Android] Arvind7352:
Wait. Looks like you've altered the output.

And guess you typed this command,

make jfvelte

Which is wrong...

For CM13 - Do mka bacon

For AOSP - Do mka otapackage

If you're building other ROM and don't know to start Compilation, Quote me.

EDIT : [MENTION=6992369]gosha98_[/MENTION] -- For Dirty Unicorns, do mka bacon
[Android] folgore95:
hi thanks for your fastly reply. i'm building dirty unicorns rom. Btw i used that command to start building: breakfast jfvelte && mka jfvelte but as you can see it gives me that error.

What need i to write to make the building right?

---------- Post added at 10:28 AM ---------- Previous post was at 10:23 AM ----------

So in terminal:

. build/envsetup.sh
mka bacon

right?
[Android] Arvind7352:
No

. build/envsetup.sh
breakfast jfvelte
mka bacon
[Android] folgore95:
it is starting.. i will let you know if it works )

---------- Post added at 10:42 AM ---------- Previous post was at 10:32 AM ----------

drivers/usb/otg/Kconfig:187:warning: leading whitespace ignored
drivers/media/video/msm-jf/Kconfig:114:warning: choice value used outside its choice group
drivers/media/video/msm/Kconfig:108:warning: choice value used outside its choice group
drivers/media/video/msm-jf/Kconfig:119:warning: choice value used outside its choice group
drivers/media/video/msm/Kconfig:113:warning: choice value used outside its choice group
#
# configuration written to .config
#
make[1]: exit from directory "/home/gio98/du/kernel/samsung/jf"

et voila.. another error :( do you have any ideas?
[Android] neonkat:
full log please :v

use the search option to know how to.
[Android] #Vangreen:
Guys i need help. How to create vendor for my device? Any link to totorial. I can't find anythink.
[Android] MSF Jarvis:
There are no hard and fast rules for creating a vendor tree
[Android] #Vangreen:
So how create it?
[Android] MSF Jarvis:
I've never had to sustain the pain of creating one from scratch so I don't have a very clear idea
[Android] #Vangreen:
If I make vendor for my d315 base on g2 mini it will works? . it has the same spec.
[Android] Startrek852:
[MENTION=6992369]gosha98_[/MENTION] If you're already using breakfast you should use

. build/envsetup.sh
brunch jfvelte

It does the same thing as

breakfast jfvelte
mka bacon

but it's simpler.
[Android] Qiangong2:
What does ro.kernel.qemu do in system.prop?
[Android] Arvind7352:
If you're running Android in an Emulator, then this property's value is set to '1'

If its a Real Device, then this property's value is set to '0'

Looking at your Device Tree's system.prop, the value is correct

Sent from The Machine
[Android] Adromir:
I have this question.. When there is a problem with a device (Sim card not detected) which is caused by compiling optimizations, is it most likely to happen for a different device on the same rom as well..
[Android] quanganh2627:
Nope, it's depended your device, your config or gcc version.... only. so, if u have troubles then it's not mean others have too.
[Android] garnet&gold:
I'm trying to build pure nexus for the nexus 10, manta. I'm getting a "no rule to make target" but I cannot figure out how to correct this. This is a link to hastebin: http://hastebin.com/najohajalu.pl

I'm hopeful someone can point me in the right direction.

Thanks
[Android] Adromir:
Well I mean if I compile the same source with the same toolchains and same additions. Background is, that I want to compile an optimized rom for my phone, using the Ubertoolchains. That works fine so far, but whenever I add compiling optimizations, it breaks simcard detection. As my main phone is in daily use, I can't use it for testing that often, but I have an older spare phone, for which the rom has device support. So I thought, if the problems might occur on both devices, I can use this for developing
[Android] #Vangreen:
Anyone know how slove this error?
[Android] ParanoidNemo:
Please paste errors on hastebin and link them here. Don't post images!
[Android] sagarshah1729:
Its easy..Go to Build/core and open main.mk..

Search for this than..

# For Java 1.7, we require OpenJDK on linux and Oracle JDK on Mac OS.
requires_openjdk := false
ifeq ($(HOST_OS), linux)
-requires_openjdk := false

Change false to true..

---------- Post added at 09:48 AM ---------- Previous post was at 09:47 AM ----------

Can I get Help for this ERROR?

make: *** No rule to make target 'NOTICE-TARGET-STATIC_LIBRARIES-lib_driver_cmd_qcwcn', needed by 'out/target/product/lettuce/system/bin/hostapd'. Stop.make: *** Waiting for unfinished jobs....
[Android] justgamer01:
Hello,

I'm trying to compile AOSPA for my i9505(jfltexx), but each time it shows the error message that the dependencies file wasn't found(I renamed it to pa.dependencies!).

It shows me:

Traceback (most recent call last):

File "build/tools/roomservice.py", line 62, in <module>

raise ValueError('No dependencies file could be found for the device (%s).' % device)

ValueError: No dependencies file could be found for the device (jfltexx).

** Roomservice failure for: 'pa_jfltexx'
[Android] TimSchumi:
Why does CM 12+ need OpenJDK?

About your error: Search in the build log for an error before the "No rule to make target"-Error, as this message only says, that something returned an exit code different than 0
[Android] sagarshah1729:
You need to make pa.dependencies file in vendor/pa/products/yourdevicename..

Check cm.dependencies file for guide in making the dependency file..
[Android] #Vangreen:
I change it to false and then compilation run

Thanks!
[Android] justgamer01:
After I had changed a lot of stuff, I got this error. At the moment I'm not having any idea how to solve this problem!

build/core/product_config.mk:227: *** _nic.PRODUCTS.[[vendor/pa/products/jfltexx/pa_jfltexx.mk]]: "frameworks/native/build/phone-xxhdpi-2048-dalvik-heap.mk" does not exist. Schluss.

** Don't have a product spec for: 'pa_jfltexx'
** Do you have the right repo manifest?
[Android] MSF Jarvis:
You need an optician. The error clearly says it cannot find the file, so you need to change the declaration from your device tree to point to the 1024 variant. Stop getting into the habit of being spoon-fed.
[Android] Zenderable:
out/host/linux-x86/bin/checkpolicy: loading policy configuration from out/target/product/cancro/obj/ETC/sepolicy_intermediates/policy.conf
vendor/pa/sepolicy/vold.te:2:ERROR 'unknown type persist_file' at token ';' on line 13857:
allow vold persist_file:dir { getattr read open ioctl };
#line 1 "vendor/pa/sepolicy/vold.te"
checkpolicy: error(s) encountered while parsing configuration
external/sepolicy/Android.mk:69: polecenia dla obiektu 'out/target/product/cancro/obj/ETC/sepolicy_intermediates/sepolicy' nie powiodły się
make: *** [out/target/product/cancro/obj/ETC/sepolicy_intermediates/sepolicy] Error 1

Total time elapsed: 2 minutes (132.822342971 seconds)

How to define persist_file?

Anyone can help?
[Android] AndDiSa:
Probably this commit for angler for a different rom will give you an idea. But if you introduce "persist_file" you most likely will need to adapt your policy rules, too.