yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] andykamezou:
Hmmm I see that in 2.0 you hardcoded internalSD as "/sdcard" in beforeHookedMethod.

While the 2.9 Asus test, getCustomInternalSd are called in afterHookedMethod.

Will it change anything if we hook it to before calling the getExternalStorageDirectory method?

ps : sorry if my sentence doesnt make sense... its 3.30am here...

------

Is it possible that when the codes are running, the storage might not ready yet?

While logging the normal boot I found these Mount Service log, but I don't see any of these on the bootloop logs :

I/SystemServer( 653): Mount Service
D/MountService( 653): got storage path: /storage/sdcard0 description: Internal storage primary: true removable: false emulated: true mtpReserve: 100 allowMassStorage: false maxFileSize: 0
D/MountService( 653): addVolumeLocked() StorageVolume:
D/MountService( 653): mStorageId=65537 mPath=/storage/emulated/0 mDescriptionId=17040666
D/MountService( 653): mPrimary=true mRemovable=false mEmulated=true mMtpReserveSpace=100
D/MountService( 653): mAllowMassStorage=false mMaxFileSize=0 mOwner=UserHandle{0} mUuid=null
D/MountService( 653): mUserLabel=null mState=null
D/MountService( 653): got storage path: /storage/MicroSD description: SD card primary: false removable: true emulated: false mtpReserve: 0 allowMassStorage: false maxFileSize: 0
D/MountService( 653): addVolumeLocked() StorageVolume:
D/MountService( 653): mStorageId=0 mPath=/storage/MicroSD mDescriptionId=17040667 mPrimary=false
D/MountService( 653): mRemovable=true mEmulated=false mMtpReserveSpace=0 mAllowMassStorage=false
D/MountService( 653): mMaxFileSize=0 mOwner=null mUuid=null mUserLabel=null mState=null
D/MountService( 653): got storage path: /storage/USBdisk1 description: USB storage primary: false removable: true emulated: false mtpReserve: 0 allowMassStorage: false maxFileSize: 0
D/MountService( 653): addVolumeLocked() StorageVolume:
D/MountService( 653): mStorageId=0 mPath=/storage/USBdisk1 mDescriptionId=17040668
D/MountService( 653): mPrimary=false mRemovable=true mEmulated=false mMtpReserveSpace=0
D/MountService( 653): mAllowMassStorage=false mMaxFileSize=0 mOwner=null mUuid=null
D/MountService( 653): mUserLabel=null mState=null
I/SystemServer( 653): LockSettingsService
I/SystemServer( 653): Device Policy
W/MountService( 653): Duplicate state transition (unmounted -> unmounted) for /storage/MicroSD
D/MountService( 653): volume state changed for /storage/USBdisk1 (unmounted -> removed)
[Xposed Framework Modules] pyler:
2.1 didnt create these folders also. It is same code.

I may do some more test builds for Asus later.
[Xposed Framework Modules] dimm0k:
noticed two things... using the app SC-OS it takes pics into /storage/emulated/0/SCOS. I've enabled the checkmark for this app in XInternalSD, however when it saves the pics it does not save it to /storage/extSdCard/SCOS the way it should. Also, the stock Samsung camera app when you do burst pics, it saves them to /storage/emulated/0/DCIM even though I have "Android System" and Camera both checked in the list. Chrome does save downloaded files to /storage/extSdCard/Download and XPrivacy does save backup files to /storage/extSdCard/.xprivacy whereas without this module it would save them to /storage/emulated/0/. any suggestions?
[Xposed Framework Modules] pyler:
did you enable "Pictures" in "Change path to system directories"?

Edit: I will remove "Change path to system directories" and paths will be automatically changed since so much confusion.

--------------------------------

Asus tests :D

test1 - hook1 is disabled

test2 - hooks 1 - 3 are disabled

Try
[Xposed Framework Modules] andykamezou:
Bootloop but I didn't see any error logged by xposed in logcat.

Log attached just in case you want to see it.

So, it's not the hook...? ~~~ :eek:

Today I also tested "OBB on SD" module by [MENTION=426237]moneytoo[/MENTION] , this module also produce NullPointerException related to getExternalStorageDirectory. But no bootloop occur though. Probably because that module only playing with obb location.
[Xposed Framework Modules] dimm0k:
[MENTION=5064841]pyler[/MENTION] FYI i did have the Pictures folder checked, as well as DCIM. the stock Samsung Camera app outputs burst shots to the DCIM folder while SC-OS outputs to its own folder called SCOS.
[Xposed Framework Modules] jvglez:
LG D320

Good day I have downloaded the module but for some reason in my LG D320f8 the latest version does not work :crying: the only one that is working currently seem to be the 2.1 :o can anyone give me some advice on this please:confused:
[Xposed Framework Modules] pyler:
Did you enable module for all (some) apps in module settings? Check Xposed log for errors. What do you mean by "it doesn't work"?

I have no issues on my devices.
[Xposed Framework Modules] jvglez:
LG D320

well I have selected the enable all and the right SD partition but it does not seem to access it and beside that I'm pretty new on android maybe I'am the one doing something wrong
[Xposed Framework Modules] pyler:
Did you enable enable module in Xposed Installer -> Modules (I think you did but I must ask you about it). Did you reboot device?
[Xposed Framework Modules] jvglez:
I did but the module does not work on the newest version only the 2.1 works
[Xposed Framework Modules] shenlong85:
Go to App Settings and clear the data. Then readd the app. Happens to my phone after upgrade.
[Xposed Framework Modules] nathanski:
hi dev, great job

thanks for this app it works so well "with my limited onboard storage" i payed for an app to help re locate apps to sd but with this it just works, now my large game data and obb files fit well some internal and some external, thank you for this its a great app that works well for me.... :good:
[Xposed Framework Modules] nvo2411:
This module users can easily make a statement: 'one can imagine a pune without lollipop but one cannot imagine phone without xposed'.

Keep it up pyler for both of your amazing modules
[Xposed Framework Modules] eliasildi:
No hay suficiente espacio en el dispositivo

Tengo problemas con el modulo,

Uso libk2sd plus con partición ext4 y otro módulo xposed obbtosd, pero cuando activo xinternalsd y aplico la ruta de la sd fat32 (/storage/sdcard1) llega un momento que no puedo instalar nada, me sale el mensaje de "no hay suficiente espacio de almacenamiento disponible".

Si desactivo el modulo xinternalsd ya me deja instalar de nuevo, pirque ocurre. Perdonen mi ingles, uso giigke traductor.

I have problems with the module,

Use libk2sd plus with ext4 partition and another module Xposed obbtosd, but when active xinternalsd and apply the route fat32 sd (/ storage / sdcard1) comes a time that I can not install anything, I get the message "not enough space available storage. "

If I disable the module xinternalsd and let me reinstall, pirque occurs. Pardon my English, giigke use translator.
[Xposed Framework Modules] pyler:
Firstly, I think there is conflict between this module and Obb to Sd, since there are some methods which are hooked by modules and only one can win.

Secondly, you said you couldn't install apps but I am not sure if this is caused by this module (I don't think so...). Simply untick

"Custom internal SD path" and check whether it works or not.

And thanks for your nice words :).
[Xposed Framework Modules] kotey:
[MENTION=1694745]andykamezou[/MENTION] & [MENTION=5064841]pyler[/MENTION]

I'm using Zenfone 5. I don't have any bootloop or other issues. On 4.3 last-update (TW firmware, hesitated to cross flash to WW) and don't want to up to KK because of restrictions. So I can't say if you're on KK.

I replied to devs request to try 2.9-test2 and all went well, now on 3.1 also works great.

Somehow I remembered that my /system/bin/vold was patched by an (root) app called FolderMount, because initially its automount will fail randomly if using stock vold. I'm not sure if this somehow helped in my case, but its likely.

[MENTION=1694745]andykamezou[/MENTION] you can try to install the free version of the app, let it patch vold, reboot and then if it works, install XInternalSD and see if it works for you.

OR

I'm attaching vold (and original with .backup extension) from my /system/bin. You can try it, make sure of the permissions before rebooting!
[Xposed Framework Modules] andykamezou:
[MENTION=1954283]kotey[/MENTION]

The 1st time I update XInternalSD from 2.1 to 3.0, I already have FolderMount installed. So I don't think that app can fixed the issue.

And yeah unfortunately I'm on Kitkat. That might add another cause of problems.

Restriction sucks~ And I sucks for not doing research thoroughly before buying this tablet >_<

Anyway, last week I remember another module that I also use before the 1st bootloop occur : download2sd

I believe this module is quite the same as what the latest XInternalSD do. Today I installed it again, and it still works.

Can't quite remember if I uninstalled download2sd before updating to 3.0, because these 2 module might cause some conflict. But even after fresh factory reset, the 3.0 still not working even without download2sd.

I guess there something incompatible with how the new lines of codes works on my tablet :eek:. It's a rare case anyway, unless some other Fonepad user willing to jump in and test it~

As for now, I'll just use the old XInternalSD together with downloads2sd.

If there's any ASUS Fonepad FE375CG user read this, please let me know if you're able to use the latest version of module.
[Xposed Framework Modules] Motwera:
Are you able to fix the issue for Xperia M users?

Especially that the newer versions mess up with the sdcard as seen in the attached screenshots
[Xposed Framework Modules] pyler:
No, because there is nothing to fix. Module works and value from API is changed but X-plore use other way how to get internal SD path. (parsing mount info or something like that). It could never work so "newer versions" have nothing with it.
[Xposed Framework Modules] cewong2:
HI thanks for the module. I have been having an issue with selecting apps. With our without the enable for all apps checked I can't select apps individually. The option is greyed out. I've tried clearing data, reinstalling both 3.1 and 3.2 and I have the same issue. In using a galaxy s4 with insane hybrid kit Kat 4.4.4 does anyone else have this issue or know if a solution?

Thanks

Sent from my GT-I9505
[Xposed Framework Modules] pyler:
They are greyed out because list of apps is not yet loaded. If you have maaaaany apps, wait for some seconds. Clearing app data/downgrading app will not help.
[Xposed Framework Modules] seekfind:
anyone had any luck using this on Desire 816 and stock 4.4.2?

I do have full SD access via this patch but still no luck. how can I find the correct SD path to enter manually?
[Xposed Framework Modules] pyler:
Use some file manager to find out path to external SD card (storage)
[Xposed Framework Modules] seekfind:
Es explorer shows it as Storage/ext_sd. that was the default path in XinternalSD and it didn't work
[Xposed Framework Modules] pyler:
It was autodetected correctly. So you enable module for all apps or for some apps only? You should tell me more about problem to solve issue.
[Xposed Framework Modules] dimm0k:
[MENTION=5064841]pyler[/MENTION] after taking a screenshot I noticed that the images got dumped to the internal memory instead of the external on my Galaxy S5. any idea what app I need to tick off to have it dump to the external SD card?
[Xposed Framework Modules] AkshayGunplay:
Hey [MENTION=5064841]pyler[/MENTION] . Ssup mate. I have been using this module since i got a KK device. Two days back, i updated my device to Lollipop. And now xposed is also compatible with Lollipop. So when can i expect Lollipop support? I know i shouldn't ask this, but i really need this module. Can't live without it. Hope you don't get offended. And thanks for making such a useful module. :laugh::good:
[Xposed Framework Modules] pyler:
Well, done. Module features ported.

There is one but... I just can't solve "full access to external sdcard" thing - how to implement it on Lollipop. It will may be reimplemented later.
[Xposed Framework Modules] MBariya:
Obb files for apps are working fine.

Like Microsoft excel....

But files not moving for whatsap....

I am on CM12
[Xposed Framework Modules] pyler:
I changed nothing in "module logic". What works on older Android versions, it has to work on newer Android versions. Maybe we need "sd fix", idk.
[Xposed Framework Modules] billbo40:
Tried to get some games to run with version 2.1 and 3.3, everytime the games are searching files on internal memory, nothing seems to help, so sad!
[Xposed Framework Modules] MBariya:
Ohh Yes it is working. It need whatsapp to be restarted manually after selecting from setting.

Working now. Testing more.

---------- Post added at 06:38 PM ---------- Previous post was at 06:32 PM ----------

First you have to move obb files of game/app to external sd card,

then select that app in setting of xinternalsd module,

also enter correct external sd card path in setting,

and finally reboot or force close that game/app manually, it should work now.
[Xposed Framework Modules] billbo40:
Tested it excactly that way, path to external sd: /storage/sdcard1

with options - custom parh to internal... checked/unchecked

- enable for all apps checked/unchecked

- full access to external.. checked/unchecked

and different xposed modules: HandleExternalStorage or KitKat SD Card Full Access

doesn't work, what can be wrong here?
[Xposed Framework Modules] MBariya:
[MENTION=2307527]billbo40[/MENTION]

Check my SS. You will get more details from there....

I have made that for Microsoft excel app obb.
[Xposed Framework Modules] billbo40:
Perfect!!!! It runs!, I added only one game and put the "/" at the beginning of path. Your screenshots are very helpful, many thanks!!!

bill
[Xposed Framework Modules] MBariya:
[MENTION=5064841]pyler[/MENTION], system apps not taking external sd path. They are giving FC. Like i have changed for download manager and chrome. But both of them are giving FC.

Edit:find the attached log file for more details.
[Xposed Framework Modules] nicesoni_ash:
Hi [MENTION=5064841]pyler[/MENTION]

I really like this module and I just started using it because my internal memory is getting filled up with my whatsapp data. I activated this module for Whatsapp, moved whatsapp folder to external sd card and restarted my phone. Problem is it's working fine for any new media sent or received but it can't read and show old media. Can I do something that will fix this?

Thanks.

Edit:

If I leave old data in internal sd card, it can read old files. Why is that when whatsapp should be reading data from external sd card not from internal?
[Xposed Framework Modules] MBariya:
No you can't. Because media was saved with internal sd location. And new media is saved with external sd.
[Xposed Framework Modules] nicesoni_ash:
But I moved all data to external sd card so logically since whatsapp is thinking that extenal sd is internal sd, it should read earlier data too. That's logically wrong completely if it can't.
[Xposed Framework Modules] MBariya:
No it's not like that. This module changes internal sd path with external sd. And makes it capable woth external sd. Not like folder mount or linktosd app. In which app creates a link to external sd.
[Xposed Framework Modules] nicesoni_ash:
But even in that case it makes app think that it's writing data on internal sd card, right? If so then app is reading data from external sd card but thinking that it's reading from internal sd card, right? So if that's correct too, it should be able to show old data too. I am really confused if that's not what's happening here.

_____________

Sent from my "GT-I9300/1+1" powered by Carbon Rom & Boeffla/ak Kernel

Fueled by 7000mAh ZeroLemon Battery
[Xposed Framework Modules] MBariya:
Read OP and other 2 post linked in op. You will be more clear.
[Xposed Framework Modules] nicesoni_ash:
Unfortunately I already did before asking in this thread but I am still unclear about my question.

I hope [MENTION=5064841]pyler[/MENTION] can shed some lights on it. Thanks though for your help. :)
[Xposed Framework Modules] dimm0k:
the way I understand it is, this module intercepts calls for the internal storage location. in the example of whatsapp, when it wants to save NEW data to the internal storage it asks the Android OS for the location and that's when this module steps in to intercept that call and returns the location you've set so all your new stuff gets saved to this new location.

whenever whatsup saves data it most likely keeps track of this through a database that contains locations for every file it saves. your old stuff would be saved with the old internal storage location whereas the new stuff would be saved with the new location. when whatsup tries to pull up your old stuff, it looks up this database for their location instead of making calls to the Android OS for every file it tries to load... because it goes skips any calls to the Android OS, it effectively bypasses this module.

this module DOES NOT replace the internal storage location directly.

app requests int storage location -> Android OS -> /storage/sdcard0

app requests int storage location -> Android OS -> XInternalSD -> /storage/extSdCard

app opens up /storage/sdcard0/screenshot.png -> /storage/sdcard0/screenshot.png

app opens up /storage/extSdCard/screenshot.png -> /storage/extSdCard/screenshot.png

hope this helps...
[Xposed Framework Modules] nicesoni_ash:
That indeed help. I had doubts about that and needed some confirmation, I guess this is closest I could get. Thanks. ☺

_____________

Sent from my "GT-I9300/1+1" powered by Carbon Rom & Boeffla/ak Kernel

Fueled by 7000mAh ZeroLemon Battery
[Xposed Framework Modules] pyler:
Nothing interesting in logs. But I think you need "external sdcard full access fix for LP" as you need it on kitkat. No dev yet do it (send me pull req if you did) and I have no time study it further.
[Xposed Framework Modules] thach273:
not work for youtube

It's not support all, and some damn software write data to storage/sdcard0 :( , but not much
[Xposed Framework Modules] MBariya:
Yes you are right. Some apps are not getting sd card access. Like chrome, android system which takes SS, download manager. I have used sd card fix which is used in kitkat but still having problem. It looks like some thing is changed in system wise which is not excessing sdcard.
[Xposed Framework Modules] dimm0k:
now that you mention it, I'm having similar issues, but only for taking screenshots. I have Android System checked off, but it's still going to the default location and not where I have set in XInternalSD.
[Xposed Framework Modules] pyler:
Enable module for "Android system" and reboot device. Should work nut On LP It may or may not fail since I don't know whether system can directly access external SD card.
[Xposed Framework Modules] dimm0k:
I'm actually on KitKat and have "Android System" checked off and rebooted... screenshots unfortunately still go to /storage/emulated/0/Pictures/Screenshots instead of /storage/extSdCard as specified in the module. I do have read/write access to that location...
[Xposed Framework Modules] shahrooz_ra:
hello

can anyone tell me that this module work on cm12 or not?:confused:

or any alternative method for cm12?
[Xposed Framework Modules] pyler:
It is working but you need "external sd card fix" for Lollipop too. I want to reimplement it to be "builtin" feature but.. I don't know. Can [MENTION=4501300]defim[/MENTION] help us? His module probably works on LP so maybe he can help me somehow.
[Xposed Framework Modules] JoxeeM:
I think the problem with this module in my case with lollipop is relate to my photos, always get duplicated. Is annoying, and most of the time makes other apps fc when they use gallery to choosing pictures. Am guessing that I need the external sdcard full access fix for LP.
[Xposed Framework Modules] shahrooz_ra:
hello

" pyler" very thanks for your module

if i upload my cm12 rom framework.jar can you please edit it and set default primary storage to

external sd only for installed app?

if you do it we can use this function without install xposed framework i think.:confused:

then you can share your work in cm12 galaxy grand forum.

I've installed your module in cm12 for galaxy grand and work perfect I've tested it only by set for

installed app.

at the same time i I have changed SELinux status to permissive mod and module work perfect.
[Xposed Framework Modules] pyler:
I found "by accident" how to fix it on LP. External sd card fix code was in PackageManagerService, in LP it is in SystemConfig.
[Xposed Framework Modules] flexxoo:
update coming soon!??

never mind is already available in xposed repo thanks!!!
[Xposed Framework Modules] pyler:
If new update doesn't work, try redownload it (it found there was some error during compiling :/)..
[Xposed Framework Modules] flexxoo:
thanks
[Xposed Framework Modules] Utacka:
Just found this module now, tried it and loving it. I must say that this is genius and working as expected :)

Thanks and cheers =D

Edit: Using LP 5.0.1 with SELinux enforcing.
[Xposed Framework Modules] Pacjonek:
Hi, Why in newest version there is no option to enable this module for all apps? I need this function, therfore I had to downgrade to 3.3
[Xposed Framework Modules] tobbbie:
Just upgraded, but got stuck at boot (KK 4.4.2 on my Tab3). Nailed it down to SD card (it booted without SD Card). SD Card itself is fine (I check on PC). After I disabled the (new?) option "full access to external SD card" it boots fine again. So far I use the "KitKat SD card full Access" module by Falseclock - the one from defim does (did) not work for all my apps.

The option was set by default - maybe you should leave it to the user to activate after de-activating conflicting modules.
[Xposed Framework Modules] pyler:
Yes, enable all removed since I don't think that it is smart to apply module for all apps. Just tick all apps if you really need it.

And ok, full access fix will be off by default..
[Xposed Framework Modules] sever20067:
The latest version provides access to the map. Rolled. 3.5>3.4.
[Xposed Framework Modules] pyler:
What? Explain better pleasse. If any issues, try clear app data.

No issues on Android 4.2.
[Xposed Framework Modules] sever20067:
User programs that load and write files to a memory card, an error occurs. Set to zero 3.5. Fell back to 3.4, reboot the device, the program earned.

Sony ZR, 4.4.4 stock.
[Xposed Framework Modules] kulguy:
With all apps function removed, then what should I tick for newly installed apps to download obb files to external sd card? I can't tick them before they are installed.
[Xposed Framework Modules] adyy94:
Installed it on moto e running lollipop but unable to download or move the apps to external SD card. Is there any way I can do so? Tried downloading injustice gods among us but gave an error that there was insufficient space on external SD card.
[Xposed Framework Modules] pyler:
This module has nothing with installing apps on external SD card.

Enable for all apps is back in 3.5, only Disable for apps was removed, since it was useless.
[Xposed Framework Modules] haoyangw:
[MENTION=5064841]pyler[/MENTION]

Actually you should not add support for full access to external sd on Lollipop, people are probably better off using Google's new implementation of requesting access and granting before there is full sdcard write access for each app.
[Xposed Framework Modules] pyler:
You should realise that this "new thing" must be implemented by every developer. Many of them will not do it. There are only a few apps with support for that, mostly file managers. Without this "fix", module is useless on LP.

Of course this option will stay.