yashsingh1/xdaforums huggingface dataset:
[Android] hondajohn88:
I've read through the thread and couldn't find a specific answer to a question I have in regards to searching for features/commits on github.

I'm looking for a few features for my Nexus6, specifically notification lights, resizable nav buttons and an audio volume fix. I've found a few commits that deal with the lights and volume fixes, but I'm not sure if I grabbed all of the involved commits or not. Also, I'm not certain where to look for all aspects of a ROM feature.

In your example, there are two commits for Halo, indicated by [1/2] & [2/2]...but do all commits follow this style of labeling, or is it up to the dev?

I've managed to cherry-pick a couple of commits and successfully added & commited them on my machine. The ROm built, but ended up in boot loop, so I know there's something missing somewhere. I haven't tried to go through the build errors to see where the specific error happened & what it was, but I'll do that in the future if I can figure out where to locate all the necessary commits & files for each feature to cherry-pick.

I really appreciate this guide, as it helped me understand the process of where to begin to add things to a ROM. For that I'm very grateful.

Any help you can provide in shedding some light on finding all related commits to a specific feature would be greatly appreciated. I'm guessing it's relatively tedious trying to locate those things.

Thanks in advance! :)
[Android] CoreGaming:
Hey,

i will try my first cherry pick for my Lollipop Rom. Is it possible to pick it in Lollipop or only for KitKat?

Greetings
[Android] KingDani1997:
Hey guys,

I am trying to add this commit: https://github.com/marshmako/platform_build/commit/16559c8a3052c05c7d3b9553d066730f87b71fef to aosp, but i am getting this error:

daniel@daniel-VirtualBox:~$ cd /home/daniel/mm6.0aosp
daniel@daniel-VirtualBox:~/mm6.0aosp$ cd build
daniel@daniel-VirtualBox:~/mm6.0aosp/build$ git fetch git://github.com/marshmako/platform_build.git
From git://github.com/marshmako/platform_build
* branch HEAD -> FETCH_HEAD
daniel@daniel-VirtualBox:~/mm6.0aosp/build$ git cherry-pick 16559c8a3052c05c7d3b9553d066730f87b71fef
fatal: bad object 16559c8a3052c05c7d3b9553d066730f87b71fef
daniel@daniel-VirtualBox:~/mm6.0aosp/build$

Thanks in advance.
[Android] fhem:
Looks like Sykopompos had same problem --- read bottom line of commit message. Try it from here or just edit file manually and commit the change -- it's only one line.
[Android] 3yan:
SlimRecents - cherrypick guide

Hi,

I was trying to cherry-pick SlimRecents by this guide. Even though it was helpful on the start I ran into many issues when I was trying to resolve conflicts in my cherry-pick.

After resolving those issues I've tried to make guide for cherrypicking of slightly advanced feautre. In my case cherrypick of SlimRecents to CM 12.1. The reason why i wrote it down is that I think it could save some time and help people who have almost no computer skills like me. As I'm no programmer/developer I'm not sure if this guide is "code-correct" so feel free to post me PM with hints how to improve it.

link:

brmlab.cz/project/android/grouper#cherry-picking_slimrecents_to_cm_121

Hope it helps someone.

Huge thanks to kufikugel for this awesome feature, SlimRoms team, Gabriele Mariotti for frameworks_opt_cards, guys from CM and Jabza for his cherry-pick guide.
[Android] Uchiha_Dev:
using this method can I cherry-pick any feature from any ROM to another ROM ? example from blisspop to aicp ?
[Android] MSF Jarvis:
Of course
[Android] Uchiha_Dev:
thanks, I thought it was only for same roms. For example(this is what I thought) there are some new features in the latest builds of PAC rom but users can't build the latest ROM so they can just cherry-pick those features to old builds.
[Android] MSF Jarvis:
That is done by repo sync, but yeah, the confusion can occur. Happy to Help!
[Android] ryanguy426:
Any idea what it would take to bring a bigger feature from CM like LiveDisplay to AOSP?
[Android] MSF Jarvis:
Open their Gerrit instance at review.cyanogenmod.org and then then search for LiveDisplay and cherry-pick the necessary commits.
[Android] atharwaqas:
So i am working on CM 13 and trying to add Halo to the build. Following your guide i used gerrit to download both framework and settings package and proceed as you have said but when i do a git status i get this

both modified: core/java/com/android/internal/logging/MetricsLogger.java

both modified: packages/SystemUI/proguard.flags

both modified: packages/SystemUI/src/com/android/systemui/statusbar/BaseStatusBar.java

both modified: packages/SystemUI/src/com/android/systemui/statusbar/phone/StatusBarHeaderView.java

both modified: services/core/java/com/android/server/notification/NotificationManagerService.java

both modified: services/core/java/com/android/server/notification/RankingConfig.java

both modified: services/core/java/com/android/server/notification/RankingHelper.java
[Android] HaoZeke:
You need to resolve each files errors and add them each with git add file name.

Then you can do git cherry-pick continue.

Halo is probably not the easiest thing to start with... Try a smaller feature maybe?

---------- Post added at 11:37 AM ---------- Previous post was at 11:36 AM ----------

Hey so I have a problem / question.

I forked a repo and made a new branch...

I cloned said branch on my computer and added some cherry picks.. How do I make these changes reflect online?
[Android] DSA:
git push (To whatever remote & branch you want)
[Android] alphamale:
Is it possible to cherry pick this to a different device using this tutorial. Or would I have to clone and or fork
[Android] DSA:
Cherry pick should be fine, you will probably have to resolve errors
[Android] rob_z11:
if I want to bring emotionROM ROM control to LineageOS ROM for Tmobile. Is it possible to do this? There are like 100's of commit for the EmotionROM control, so I am not sure which one I should pick?
[Android] DSA:
Start at the oldest/beginning. Its likely they will be the ones that are the actual rom control implementation, and the ones after will be modifications of various sorts (Of which its up to you to decide what you want).

Got a link?
[Android] prajnay:
Nice guide
[Android] alphamale:
Is the process the same if I wanted to cherry pick a commit that was in 6.0 ROM to use in a 7.0 rom
[Android] fhem:
Process is the same but it most likely will not come in clean and good chance it won't work unless it is forward ported properly.
[Android] Equals_Android:
Hi guys how would i find a commit/feature to add. For example, if i want to add the status bar ticker or something how do i search for the commit? Thanks!
[Android] DSA:
by literally looking through all of the commits in that repo/gerrit
[Android] fhem:
Try using keyword searches. As long as the repo you are searching is not forked search will not work on forked git repos
[Android] Equals_Android:
Hey, where about is the search function? I've tried looking for one on gerrit and github but still not sure how to find it lol since im still very new to this.

EDIT: i've kinda of figured a way to find commits and stuff on gerrit on search bar just type "message: eg/Lockscreen chargining info"
[Android] fhem:
Sounds like you got gerrit --- for git you need an account and the search bar is located top middle "This repository" search.
[Android] alphamale:
Wondering if someone can help. Trying to cherry pick commit i get this error.

frameworks/base/core/res/res/values/config.xml:2961: error: Resource entry config_uiBlurEnabled is already defined.

frameworks/base/core/res/res/values/config.xml:2939: Originally defined here.

Aidl: framework <= frameworks/base/core/java/android/net/IConnectivityManager.aidl

build/core/package_internal.mk:389: recipe for target '/home/android/rr/out/target/common/obj/APPS/framework-res_intermediates/package-export.apk' failed

make: *** [/home/android/rr/out/target/common/obj/APPS/framework-res_intermediates/package-export.apk] Error 1

make: *** Deleting file '/home/android/rr/out/target/common/obj/APPS/framework-res_intermediates/package-export.apk'

make: *** Waiting for unfinished jobs....

make: Leaving directory '/home/android/rr'
[Android] fhem:
Looks like you got "config_uiBlurEnabled" defined twice. Look at lines 2929 and 2961 of frameworks/base/core/res/res/values/config.xml then look at history of that file "config.xml"
[Android] vidwhal:
Thanks heaps for writing this up. It's exactly what I needed to clarify the process. :) :good:
[Android] alphamale:
Anyone know of a guide on how to port commits nougat to oreo
[Android] fhem:
The same as when you went from 6.0 to 7.0 ---- or just pick from someone who has already brought it up.
[Android] nicesoni_ash:
You can simply pick them and then fix the conflicts if there are any but since oreo has some methods changed/deprecated, you must have good enough knowledge to understand what's changed and to what else you will face build or runtime issues.

Sent from my "1+2" powered by Delight Oreo

Compiled by myself
[Android] Amit Kumar21:
Hey guys I wonder if one day we change icon packs and pulse light change automatically accordingly those icons color...? Possible!
[Android] sohail0098:
Quick question

I have a doubt regarding this. Suppose I build a pure AOSP rom. And I want to add some features from AOSPExtended or some other ROM into my ROM. Then what do I do with the commits that are ROM specific like for example, AOSPExtended has it's settings in "Extensions" app. How to I add them to my AOSP rom?
[Android] DSA:
You cherrypick the extensions app as well, or make your own and incorporate the commits into that.

Either way, you will probably be resolving multiple conflicts
[Android] Mr.Ak:
Great guide,but I'm facing a conflict with a tag not mentioned in this guide: both-added

If someone could explain how to fix those,it would be great.Please have a look at attached ss for more info,thanks!
[Android] DSA:
https://stackoverflow.com/questions/9823692/resolving-a-both-added-merge-conflict-in-git
[Android] DJKristy:
I'm trying to cherrypick this commit from aospextended http://gerrit.aospextended.com/#/c/27/

I'm trying to apply this commit to lineage 15.1.

but the project tittle aint in lineage, so where am i to apply these changes.

is it to be applied in packages/apps/Settings
[Android] DSA:
That looks their own custom settings app.

You need to create your own/clone theirs or figure out a way to implement into normal settings.
[Android] alphamale:
Trying to cherry pick this commit https://github.com/AICP/frameworks_...2c748b#diff-6ffa48d5ed5366446743ddc300d48292. I'm getting error in screen shot. What is meant by cannot be resolved or is not a field, and or cannot be resolved to a variable?
[Android] DSA:
Have you also taken the 2nd cherry pick? It will be for the settings app or their own custom settings app.
[Android] alphamale:
I didn't cherry pick them. I manually added them because xml files were named different between roms
[Android] DSA:
That wont really work

You need to cherry pick both items (And any other related commits), otherwise you will run into the issues you are currently having dude...
[Android] alphamale:
So here is my question then. One file that I'm cherry picking from is called custom_arrays.xml. The ROM I'm trying to pick to its called cr_arrays.XML. The cherry pick wants to delete custom_arrays.xml. No options to modify cr_arrays.xml. Should I add custom_arrays.xml there would be 2 arrays.xml?
[Android] DSA:
Keep cr_arrays.xml

copy and paste the relevant info from custom_arrays.xml into cr_arrays.xml

delete custom_arrays.xml.

Or

Keep both but make sure there are no duplicated items/lines in each file.
[Android] alphamale:
Looking for help with a pick. Keep getting unbound prefix in an XML in line com.crdroid
[Android] DSA:
</Preference - - ->

The above (One up from the bottom line in the first pic) disables things (If you want to remove something without deleting the code)

its just randomly sitting there...try removing that line only

Also, it looks like it should be a preference category but your closing line is a preference screen...that may also be the issue.

And theres no entry for "Units left"

If you pasted the code/error here in code tags rather than a screenshot it would make it a lot easier - Which line is line 25?
[Android] Sahil_Sonar:
Thanks, man it was really hopeful! Please keep on making the thread like this also I wish in future you make the guide on how to apply patches manually. By the way best of luck!
[Android] sebas4200:
Can anyone help me get dark notification from one rom to another , where can I find them in GitHub , I found framework base for both roms on GitHub I'm not sure if framework is where I would find notification settings , thanks in advance
[Android] alphamale:
So I've successful cherry picked a commit. How do I keep that cherry pick from being erased from repo sync
[Android] nicesoni_ash:
You need to push your changes to your repo online.

Sent from my "1+2" powered by Delight Oreo

Compiled by myself
[Android] alphamale:
Trying to cherry pick large commit for Xtended rom Active edge. It requires me to clone a director external/google. Keep getting this build error. Looking for help
[Android] dandyfarid:
Awesome guide :)
[Android] DiamondJohn:
undo a commit?

this looks like a VERY useful guide and is very well detailed. I have yet to try it out, however, I think my current issue is caused by the inclusion of a newer commit.

I am building Oreo Havoc-OS for an S4 GT-i9506, up to a few months ago, it was building perfectly. However, I just recently tried a build after a full sync, and it now fails to build. The project that is failing to compile on is a LineageOS project. This project has had a relatively recent (I haven't built it for a few months) commit which I *think* is causing the issue.

What are the steps to undo a specific commit?

Do I just cherry-pick the previous commit?
[Android] thezinq:
Try "git revert <commit id>"
[Android] DiamondJohn:
I am building two ROMs (Oreo & Pie Havoc-OS). I think the above worked for reverting the commit on a lineage repository used in the Pie ROM :good:, but now I am trying to revert a different commit on the Oreo build.

The commit I am trying to revert is from android.googlesource.com, the following are the details:

within the manifest is

...snip...
<remote name="aosp"
fetch="https://android.googlesource.com"
review="android-review.googlesource.com"
revision="refs/tags/android-8.1.0_r43" />
...snip...
<project path="prebuilts/misc" name="platform/prebuilts/misc" groups="pdk" clone-depth="1" remote="aosp" />
...snip...

The commit I am trying to revert is:

https://android.googlesource.com/platform/prebuilts/misc/+/cdf25317a1e22b3eb94ed84143d23778dc6b97d2

I enter into a terminal (directly after a full sync)

cd prebuilts/misc;
git revert cdf25317a1e22b3eb94ed84143d23778dc6b97d2;

The terminal returns the following for the command:

fatal: bad object cdf25317a1e22b3eb94ed84143d23778dc6b97d2

Anyone know what I am doing wrong?
[Android] thezinq:
Make sure you have committed all the changes before you perform <git revert>
[Android] DiamondJohn:
I have just performed a synch, so there should be no uncommitted changes.

so the full sequence is:

cd ~/android/havoc/;

repo forall -c git reset --hard;
repo forall -c git checkout -f;
repo forall -c git clean -fdx;
repo sync -fc -j16 --force-sync --force-broken --no-clone-bundle --no-tags;

cd prebuilts/misc;
git revert cdf25317a1e22b3eb94ed84143d23778dc6b97d2;

running a status just before the revert

git status;

returns

[B][COLOR="Red"]Not currently on any branch.[/COLOR][/B]
nothing to commit, working tree clean

ooo...I think that may be my issue:o

But it seems right as per the manifest I posted above, and it has a ".git" directory. So why would it say "Not currently on any branch"?:confused:

just kicked off a

git clone https://android.googlesource.com/platform/prebuilts/misc

in the misc path, but its taking some time.

Hopefully that might help, but I would much prefer an actual correction if someone knows it?
[Android] sdeft:
In order to apply Google's security patches into an AOSP ROM that is not updated anymore (eg. because of moving from pie to q/10) do I need to download all code from Google or only the specific security patches ?
[Motorola Atrix HD] Parham112:
I apparently flashed a bad .zip file that won't load, and now all I can do is sit at the Motorola logo. I've tried the hard reboot with power+vol up and down but, for whatever reason, that won't reboot to the bootloader like it used to. So, I can't get back into recovery at the moment. I can ocassionally get it to reboot to the fastboot menu, but I don't know what commands or anything to use to get me back to recovery. If I could just get back to the recovery I would be fine because I have a few older ROM zips I could flash.

Can anyone give me some advice on what to do here? My computer has ubuntu, so I'm not sure if Myth tools or anything would work?
[Motorola Atrix HD] mauchito:
You can do the following while on bootloader (Volume DOWN + Power button):

fastboot flash recovery recovery.img

Where recovery.img is your custom recovery image. Just make sure is in the same folder that your fastboot archive. After this, you should be able to access to recovery and flash another ROM.

OR... You can flash to stock with RSD Lite and then do everything again.
[Motorola Atrix HD] audit13:
Use Myth Tools to flash stock ROM or recovery.
[Galaxy S 5 Q&A, Help & Troubleshooting] digzee:
Hi Guys,

Is it just me or is selective focus not all its cracked up to be when shooting a toddler. I understand that they move around alot but even when my little one is standing still 9 times out of 10 I always get the message that focus could not be applied.

The way it blurs around the edges of the subject can also look a little underwhelming. I know that its not a full fledge SLR but i thought it may have been a little better.

Anybody else experiencing similar issues.

See attachment to see what I mean.
[Galaxy S 5 Q&A, Help & Troubleshooting] termdj:
I struggle to get it to work, but if it does work, I don't get the blurry edging as on your pics. I have seen some reviews where they comment on the same issue
[Galaxy S 5 Q&A, Help & Troubleshooting] mediumsteak:
I agree, it seems that the feature is designed to identify objects which drastically contrast from the background. For example a a yellow bottle on a white background mostly likely will yield a failure. However a red bottle on a white background would pick up more accurately. You have to mess around with the camera to learn how the selective focus works.
[Galaxy S 5 Q&A, Help & Troubleshooting] msavic6:
Well it is a software trick and in the end it will never match the BOKEH you can achieve with a DSLR.

With that said though, I find it helps to have an extremely obvious foreground and background in order for the effect to be applied. It can be sort of hit and miss with moving subjects though.
[Sprint Samsung Galaxy S III] MooreAJr:
I want to start off by saying that, over the past week, I have looked all over XDA forums for the following information but to no avail. I apologize if this is in the wrong thread or if I am breaking any forum rules.

I recently updated my Sprint version Galaxy S3 to Android 4.4.2 just as many people have. I actually skipped the 4.3 update and went straight to 4.4.2 from 4.1.2 due to all the bugs I heard about. My root access was broken while updating through Samsung Kies, naturally, and I want to get re-rooted. My questions are as follows:

1. Is the CF-auto-root method safe with this new bootloader that came with the 4.4.2 and(or) 4.3 updates?

2. After rooting, will flashing a custom recovery like clockworkmod brick my device due to the Knox software and bootloader?

3. Will Triangle Away work with resetting any tripped counters due to rooting on 4.4.2?

4. And, if Triangle Away doesn't work, will flashing the original stock 4.4.2 firmware via Odin reset Knox's bootloader counter just as doing so has in the past? (versions 4.1.2 and lower)

5. Will flashing an older build firmware like 4.1.2 or any roms based on an older build brick my device?

I apologize if I am asking questions already asked in these forums, as you can see they mostly center around my lack of knowledge in flashing/rooting with the Knox technology. I couldn't for the life of me find the answers to the specific questions I have to alleviate my paranoia in bricking my device. Thanks in advance for the assist. :)
[Sprint Samsung Galaxy S III] roirraW "edor" ehT:
Safe but won't necessarily work. Works for some, for others it doesn't. IMHO the most reliable and easy way of getting root on ND8 is to Odin the latest Philz Recovery, and when you tell recovery to reboot it'll offer to re-root your phone.

No. AFAIK, the only things that will brick you that's Knox related are trying to downgrade either your bootloader or modem.

The flash counter, yes, the warranty (Knox) counter, no. It's an e-fuse, nothing can reverse it.

I don't think anything has ever reset the Knox counter; only the flash counter.

Firmware, yes absolutely. ROM, no it won't. Firmware being bootloader and modem. Once you Odin ND8, never ever Odin anything other than ND8 or a custom recovery. ODINing an older ROM will permanently brick your phone.

You can nandroid backup and restore, and flash custom old and new ROMs using your custom recovery as always, though.

This thread answers some of your questions

http://xdaforums.com/showthread.php?t=2743554

Also, please post threads with questions in the Q&A section.

Sent from my Sprint Samsung Galaxy SIII with M.O.A.R. v9.0, dkp kernel dated 3/20/2014 and TWRP v2.7.0.0.
[Sprint Samsung Galaxy S III] MooreAJr:
Thanks a lot for the information. I need to get better at navigating and finding the answers to my questions on the forums. Im going to do a search on the latest Philz Recovery and see if I can my device rooted again.
[Sprint Samsung Galaxy S III] roirraW "edor" ehT:
One suggestion for searching. I find it simpler to Google search XDA than to use XDA's own search. Just put xda (space) then whatever you're searching for.

For example, Google:

xda SPH-L710 philz

Sent from my Sprint Samsung Galaxy SIII with M.O.A.R. v9.0, dkp kernel dated 3/20/2014 and TWRP v2.7.0.0.
[Sprint Samsung Galaxy S III] MooreAJr:
I did just that and found the appropriate zip & .md5 files for SPHL710 and im going to give it a try later today when I get a chance. Thanks again for the assistance with this :)
[Sprint Samsung Galaxy S III] roirraW "edor" ehT:
You're welcome. Just to be clear, you'll need the tar version of Philz to Odin it after the ND8 tar. The whole file extension is .tar.md5.

The .zip and the .md5 for the zip will only be of use once you're already in a custom recovery.

Sent from my Sprint Samsung Galaxy SIII with Wicked X v6.5, Ktoonsez' latest kernel and the latest Philz Touch Recovery.
[Sprint Samsung Galaxy S III] MooreAJr:
Hmm, I see. In the past I've only had to use two file types: tar.md5 for the recovery & .zip to root from recovery.

Guess I wasn't paying attention while downloading files, I just noticed there are 3 files types per version release.
[Sprint Samsung Galaxy S III] jacknmary:
After I updated to 4.4, I used this method to root

http://xdaforums.com/showthread.php?t=2596697

It worked like a charm!
[Sprint Samsung Galaxy S III] roirraW "edor" ehT:
Philz recovery will offer to root your phone for you automatically if you go to reboot from it and it detects you're not rooted.

Sent from my Sprint Samsung Galaxy SIII with Wicked X v6.5, Ktoonsez' latest kernel and the latest Philz Touch Recovery.
[Sprint Samsung Galaxy S III] MooreAJr:
I used the Philz recovery method to root. I did notice a weird lag and stutter after booting up. Tempted to do a factory reset but everything looks good so far. I do like the Philz Recovery interface as well :)
[Sprint Samsung Galaxy S III] roirraW "edor" ehT:
It takes any new ROM time to settle in. Hours or days depending on how you use it.

Sent from my Sprint Samsung Galaxy SIII with Wicked X v6.5, Ktoonsez' latest kernel and the latest Philz Touch Recovery.