yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] pbosio:
Yes, It only works for WhatsApp, It doesn't mute notifications from other apps

I'm currently working in changing the module's logic to make it compatible with all Quiet Hours systems, CM's built in QH, GravityBox's QH, etc

This will, probably, fix the issue with CM's profiles

Currently, enforcing quiet hours mode does not work, in fact, disabling CM's quiet hours does not disable quiet hours of this module. That's a bug that will be fixed on next

update.

You can expect full CM's quiet hours compatibility on next update.

I think there are a lot of developers put there who welcome feedback, I think the issue usually is the nature of the feedback.

For example, I'm a game developer, last year we published on several mobile stores a game for a movie about soccer, we had comments in the store like "I like it, but I would like it better if it the game were more similar to fifa" the game mechanic was pressing on a team mate to pass him the ball and dodging different obstacle, It had nothing to do with fifa! another was something like "I'll rate you only three stars because the PC game doesn't work" we didn't even developed the PC game, it was other studio that developed it.

And sometimes I think developers don't have the time to answer 20 millions of users sending feedback, I have it easy, there are only 3 or 4 guys asking or sending feedback about this module.

BTW, I think by now is pretty obvious that English is not my native language, if anybody find an error in the module text, please, let me know.
[Xposed Framework Modules] ronmq:
Thanks, gracias, very useful app

Enviado desde mi GT-I9300 mediante Tapatalk
[Xposed Framework Modules] Elemino:
If only there was a Facebook version!
[Xposed Framework Modules] defim:
[MENTION=5196737]pbosio[/MENTION]

(official) Xposed needs API 15 (4.0.3)
[Xposed Framework Modules] pbosio:
Yeah I know, but if I'm not mistaken, there is an unofficial xposed for gingerbread.

Also, I'm used to write almost every little change in the changelogs
[Xposed Framework Modules] Smultie:
Just installed the new update. Just to be sure, will the following config allow WhatsApp Quiet Hours to copy the settings from Gravity box Quiet Hours?
[Xposed Framework Modules] pbosio:
Yes it should.

If it doesn't work, please let me know
[Xposed Framework Modules] defim:
Xposed GB is API 10 :D
[Xposed Framework Modules] pbosio:
Yes, I know that, what I don't know is... If I am running Android 4.0 (API14) I can't use official xposed, can I use the unofficial gingerbread one instead?
[Xposed Framework Modules] mauslbr:
Nice app. Thanks
[Xposed Framework Modules] Smultie:
Was just going to post an error with clicking the notification not opening the app, but I see you airway fixed it! Good job!
[Xposed Framework Modules] silentvisitor:
Great job :good:

Can you extend it (or make another standalone) to cover SMS,Calls, Emails, etc ? Something like Samsung's Blocking Mode (but it doesn't work on WhatsApp. Dont know why)
[Xposed Framework Modules] pbosio:
I don't know how Samsung's Blocking Mode works, I don't own a Samsung.

Versions 1.2 and 1.3 should work with every app that mute notifications, this means that maybe now (after installing this mod and rebooting) Samsung's Blocking Mode works on whatsapp if you have unchecked "use custom quiet hours" in this mod settings.

If it doesn't work, there are others app and mods that extends quiet hours for all applications.

Please, read the known issues before installing whatsapp quiet hours mod.
[Xposed Framework Modules] Smultie:
Just an idea: it would be awesome if WQH would show that it found a quiet hours app and used its time schedule.
[Xposed Framework Modules] pbosio:
Yeah, but it can't be done.

The reason why whatsapp doesn't work with QHs apps is beacuse when they push notifications, they push it without any sound, then they use the MediaPlayer class to play the notification sound.

If you are not using the custom QH of this module, to add compatibility with others quiet hours app, I add the notification's sound to the notification being push and mute the MediaPlayer, that way QHs apps can mute the sound coming from the notification.
[Xposed Framework Modules] Smultie:
I'm not sure if I explained it correctly.

According to the descripton of your app it uses CM's/GB's Quiet Hours. I only would like to see a confirmation that it indeed found my Gravity Box's Quiet Hours settings and uses those to mute WhatsApp.

Do you understand what I mean now?
[Xposed Framework Modules] pbosio:
The thing is that this mod does not use the settings of GB's QH or any other, it modify the way that whatsapp push the notification so Gravity Box's (or any other QH app) is able to mute it.
[Xposed Framework Modules] Smultie:
Okay, didn't know that. In that case my question is not possible. Thanks for the info!
[Xposed Framework Modules] pbosio:
No problem.

It would be far more easy to me just to read CM's QH and GB's QH settings and use that, but I decided I should support any QH app that the user has, that's why I couldn't release any update without bugs yet.

In any case, If I can't fix current bugs, I imagine I would have no choice but to start reading CM's QH or/and GB's QH.. then I will do as you suggested and show some feedback about what QH setting is the module using.
[Xposed Framework Modules] Smultie:
Just heard a WhatsApp (group)notification through quiet hours. Will test the 'manual' settings now.
[Xposed Framework Modules] 089man:
Hi, with the last updated the notification sound is disabled any time. I have set from 01 to 08 in the morning. But now we have 21.35 hour and no sound notification is coming. Only if I disable quit hour in check box.

I9100 Tapatalk 4, C-Rom 4.4. 2
[Xposed Framework Modules] Smultie:
Does this mod unmute muted groups during not-quiet hours?
[Xposed Framework Modules] 089man:
Here all mutes also if quit hour time isn't running. I disable it on the day that i become sound notification and if i go to bed i enable it...it's not fine but so i can sleep... Hope Dev fixed it soon.

Edit

Sound I only hear if I online on WhatsApp, if i finish the app, always mute outside the saved quit hour time.

I9100 Tapatalk 4, C-Rom 4.4. 2
[Xposed Framework Modules] pbosio:
Please, try the update I've just release, it should be working fine now.

It was written under "Known Issues" of that version, it was a bug, it is fixed in the update I've just release.
[Xposed Framework Modules] ronmq:
Great changelog! Thanks, testing
[Xposed Framework Modules] 089man:
Thanks, have updated and reboot, now it's works fine... Where i found in setting your new + mute all?

I9100 Tapatalk 4, C-Rom 4.4. 2
[Xposed Framework Modules] pbosio:
In "Chats" screen in WhatsApp
[Xposed Framework Modules] 089man:
Smile, great thanks.. I have only look in the settings quit hours, smile.. Ok, have found, grins..

I9100 Tapatalk 4, C-Rom 4.4. 2
[Xposed Framework Modules] Venomous Viper 119:
Hey can you please evolve this module to make it the quiet hours as in the ROMs? I'm on stock & love quiet hours but I don't like going for a custom ROM to get that.
[Xposed Framework Modules] pbosio:
I think the module GravityBox do exactly that (among other things)
[Xposed Framework Modules] Venomous Viper 119:
But it works only till a few reboots & after that the ultimate notification control is turned off.
[Xposed Framework Modules] ashwinmudigonda:
The stock Facebook app also does this. It would be nice to extend this to that too.
[Xposed Framework Modules] StuttgartKiwi:
Actually I would strongly encourage the developer of this module NOT to extend it to cover other apps (like Facebook or whatever) or to provide quiet hour functionality for the ROM itself. Just keep it simple and let it only work for Whatsapp - the original purpose - so that it doesn't get bloated with more and more features for unrelated purposes. It should just work to fix the bug in Whatsapp's coding, and nothing more, in my opinion.

There are plenty of regular apps for Android that provide Quiet Hour functionality for stock ROMs. Just do a search for "quiet hours" in the Play Store. Eg. I found this one which looks promising. There are others too.
[Xposed Framework Modules] pbosio:
I agree. I never have the intention of extending it to another app nor to add any over-complicated feature, the plan was always to keep it as simple as possible. I've always hated those apps with some many and complicated features that I end up lost.

I currently have no time to develop and maintain another module, but I will keep in mind the idea of develop a similar module for facebook in the feature, for example. Or may be someone else develop it, the link for the source of this module is published on the first post, so if someone want to use that to develop a module for facebook or other app... is more than wellcome.
[Xposed Framework Modules] pbosio:
Have you try other apps like this one or this one?
[Xposed Framework Modules] Stuartglossop:
Do we still need this for the latest cyanogenmod release?
[Xposed Framework Modules] pbosio:
I think this module will still be needed until WhatsApp devs start playing the notification sounds through the proper notification API
[Xposed Framework Modules] JoyMoro:
Hi..

Great module. Works perfectly for whats app.

Does it work for OGwhatsApp??

If not, could you make one for OGwhatsapp.?

REGARDS

Sent from Note2. :D
[Xposed Framework Modules] pbosio:
Sorry, It only works for the WhatsApp package... I have no time to develop and maintain another module.
[Xposed Framework Modules] warci:
[MENTION=5196737]pbosio[/MENTION]

Thanks for your module, works fine. :good:

Hope you add more translations with the next releases.

In the attachment you can see my translations for values-de.

Including "mute_option_title", "mute_option_title_c" and "quitehourse_option_title" which are momently hard-coded. :D

Keep it up!
[Xposed Framework Modules] pbosio:
Thank you very much for the translation!

I will added as soon as possible.

I had to hardcode those strings cause I encountered some issues while trying to read WQH's translation file from within WhatsApp package
[Xposed Framework Modules] thelast_star:
Is it possible to give mute for group conversations ?
[Xposed Framework Modules] pbosio:
What do you mean by that? WhatsApp already added the feature to mute groups and their notification a long time ago
[Xposed Framework Modules] frank@:
maybe another feature request ;)

some users of Whatsapp pretty annoying, because they send away every single sentence, instead of writing everything and then send

at my side, then the notification is played a lot of times in 2-3 minutes :mad:

hello --> ring

how are you --> ring

will we meet us -> ring ......

are there any chance to mute whatsapp for (let's say) 2 minutes (or customized time) since last notification?

or since last notification of same user? :good:

Frank
[Xposed Framework Modules] pbosio:
since last notification yes, since last notification from the same user probably not... I could never figured out how detect who is sending the message, it's easy when you have a notification from a single person, but when there are several notifications... I have no idea :)

I think your request is a good idea so I will implement it a soon as I find the time to do it, I'm having a really busy couple of month.
[Xposed Framework Modules] TazZHD:
On My OnePlus one I am still getting vibrations and notifications in status bar while all should have been muted.

What is about to add a slider or a time picker to set mute length?
[Xposed Framework Modules] Sagar4995:
hi,

i dont think this module is working after whatsapp's recent update last week. pls could you confirm.

many thanks
[Xposed Framework Modules] pbosio:
I've just made a quick test and it seems to be working (I'm on whatsapp version 2.11.362)
[Xposed Framework Modules] Sagar4995:
Very interesting. I'm on the same version. Thanks. I'll do some further testing & investigate.
[Xposed Framework Modules] pbosio:
Ok, let me know your results.

Anyway I will do some more testing on the weekend
[Xposed Framework Modules] cd69:
Not working for me on the latest version either. I appreciate you looking into it when you get a chance.

Thanks.

Oneplus Nexus 5
[Xposed Framework Modules] pbosio:
I couldn't find any issue, It's working fine for me.

Are you running another xposed module that modifies notification?
[Xposed Framework Modules] cd69:
Thanks for your reply. No I don't use any other module. I am however on mahdi custom rom. Oneplus and ak kernel. Not sure what might be the issue. Thanks again for trying.

Oneplus Nexus 5
[Xposed Framework Modules] pbosio:
Are you using WQH custom settings for quiet hours or your rom have it own quiet hours system?
[Xposed Framework Modules] cd69:
Hi. My rom has its own (based on cm). Plus I tried custom settings. I will be install the rom and try again.

Thanks

Oneplus Nexus 5
[Xposed Framework Modules] pbosio:
custom settings didn't work either?

could you send me a logcat when you hear a whatsapp notification during quiet hours?

just to see if the module is working properly in your device

adb logcat -s "ar.pbosio.whatsappquiethours" > logcat.txt
[Xposed Framework Modules] cd69:
Will do in couple of weeks once I am back from holidays. Thanks for the support.

Oneplus Nexus 5
[Xposed Framework Modules] cd69:
Hey dev. All working great now. I guess something was broken on my end. Re installed xposed and seems to be working. Thanks and appreciate your patience.

Cheers.

Oneplus Nexus 5
[Xposed Framework Modules] pbosio:
Great news! :good:
[Xposed Framework Modules] chhapil:
quiet hours issue

I'm on stock samsung JB 4.1.2 rom, i dont have any quiet hours module.

When i set custom quiet hours, the notifications are always disabled irrespective of the quiet hours.

Will you please look into the issue?
[Xposed Framework Modules] pbosio:
Could you tell me what time range do you have set in custom quiet hours? It's just to discard any logic/math issue in the code
[Xposed Framework Modules] chhapil:
It's set from 11pm to 6am IST
[Xposed Framework Modules] pbosio:
Well I've just look the custom hours logic and it seems to be all OK.

I will be doing some testing on the weekend, cause I don't use the custom hours myself...

Could you send me a logcat, something like this, of the notification not playing when it should?

adb logcat -s "ar.pbosio.whatsappquiethours" > logcat.txt
[Xposed Framework Modules] pbosio:
If I have to guess... I would say that Android is freeing the instance of the class NotiManager...

I will compile a new build for you as soon as possible to check if we can solve this issue... the plan is to replace the class NotificationData for something like this

class NotificationData implements Runnable
{
Notification mNotification
String mTag;
int mId;

@Override
public void run() {
try {
if (mNotifications != null) {
try {
mNotifications.remove(this);
} catch(Exception e) {
Logger.log("NotiManager: Runnable mNotifications error",e);
}
}
else {
Logger.log("NotiManager: Runnable mNotifications == NULL");
}
getNotificationManager().notify(mTag, mId, mNotification);
} catch (Exception e) {
Logger.log("NotiManager: Runnable run error",e);
}
}

private NotificationManager getNotificationManager()
{
Context ret = (Context)AndroidAppHelper.currentApplication().getApplicationContext();
return ((NotificationManager)ret.getSystemService(Context.NOTIFICATION_SERVICE));
}
}
[Xposed Framework Modules] chhapil:
I did some check, the getcurrentapplication method of xposed helper is returning null in handlepackage itself. That's something strange.

On the other note, why do you have the notifier running in separate thread? Can't it be clubbed in main xposed class itself?
[Xposed Framework Modules] pbosio:
I did that way because some issue with whatsapp playing the sound for the notifications... sometimes the sound arrive first and in other occasions the notification arrive first and then it sound... I don't know why... so I run a runnable with 2 seconds delays waiting for the sound

So if the issue is with the getcurrentapplication... maybe getting the notification manager in some other way should fix the issue
[Xposed Framework Modules] pbosio:
[MENTION=4354573]chhapil[/MENTION] try this https://mega.co.nz/#!ws8l1L7a!eBPe82RJv_tFzc6D9seic740JLmKQ1gqfHldkfcWxdg and tell me if it works

EDIT: I forgot that I can attach the apk here :p

apk attached.
[Xposed Framework Modules] chhapil:
Thanks

I'll try and let you know the results

Please give me some time
[Xposed Framework Modules] chhapil:
Thanks for the update. Tested for couple of minutes for various scenarios. Working fine now.

I'll test for couple of more days and report if I face any issues
[Xposed Framework Modules] pbosio:
Ok, Great news then.

I'm using the same version as you do... no issues so far... I will keep testing in for a couple of days and if it is all good I will uploaded it to xposed repository.

It shouldn't have any issue, the changes I made were minimal.
[Xposed Framework Modules] chhapil:
Can I see the changes in git?
[Xposed Framework Modules] pbosio:
I will try to push the changes to Github tonight (current time here is: 13hrs)
[Xposed Framework Modules] pbosio:
I pushed the update to github last night. Please ignore the commented code for MySQL hooks... I was trying to find out how does Whatsapp insert data to their local database to make a feature for "whitelisting" contacts so their notification can be ignored by the quiet hours system. (No luck so far)
[Xposed Framework Modules] Androidttraction:
Hello, I have an Oneplus One with the latest firmware stock (CM 11S), but I seem to have a problem with the notification ringtone, it keeps repeating itself until I open the app or pull down notification. When I can uninstall the module it rings are once. Btw thanks for this awesome module.
[Xposed Framework Modules] pbosio:
Sorry. I was on vacations until today.

I need you to send me a logcat to see if I can find the bug causing that.
[Xposed Framework Modules] poczynek:
Does this work on lollipop?
[Xposed Framework Modules] pbosio:
I'm not sure.

I flashed CM12 last night, I tried to test Whatsapp Quiet Hours and it look like it was working... but... CM12 was too bugged so I got frustrated pretty quickly and went back to KK. So can't be really sure if it was working OK
[Xposed Framework Modules] fantomatico:
Hi. I installed whatsapp queit hours last night and today when checking which apps are using background data, I found it used more than 200 mb.

Whats the purpose of this?
[Xposed Framework Modules] pbosio:
Whatsapp quiet hours doesn't use data, you can check the source yourself.

Make sure you have install it from the proper repo (http://repo.xposed.info/module/ar.pbosio.whatsappquiethours) or directly from xposed installer, being open source nothing prevents that someones take the code, modified it and publish it somewhere else.
[Xposed Framework Modules] fantomatico:
I downloaded it directly from xposed installer.
[Xposed Framework Modules] pbosio:
Then, I don't know what to tell you, it's probably a measure error
[Xposed Framework Modules] nicesoni_ash:
Hi

The option to mute all in whatsapp disappeared once my calling ui gets activated. Can you do something about it. Thanks.

_____________

Sent from my "GT-I9300/1+1" powered by Carbon Rom & Boeffla/ak Kernel

Fueled by 7000mAh ZeroLemon Battery
[Xposed Framework Modules] tovivekmishra:
For me too, The option to mute itself in whatsapp+ has disappeared once i activated calling ui .first i thought it is the new version of whatsapp+ with default Calling UI but then i reverted back to older version and my mute option came back. I tried again to bring back the Call Ui by modifying preferences xml and here the mute option goes away again.

Hence requesting developer to Please fix this , mute option is more important to me than Calling UI, thats that's reverted back to older whatsapp without the call UI.

Thank You
[Xposed Framework Modules] pbosio:
Yes, I was aware of that issue last week when I activated the Calling UI myself.

I'm currently in the process of moving to other apartment so I couldn't find time to fix this issue (I don't even have internet connection yet).

But I imagine I could find time to develop a fix the first weekend of April, since here is a 4 days holiday
[Xposed Framework Modules] tovivekmishra:
Hey , Thanks a lot, will wait eagerly for the fix and btw Happy Holidays :) ..cheers.
[Xposed Framework Modules] tobbbie:
I noticed that the module actually spoils the calling alarm when using Whatsapp calls. It prevents the ringtone until after the call has dropped and it is played along with the reminder that you have missed a call. I checked on any other module and it only appears when WQH is active - not even any dedicated hours set. I checked on all my Samsung devices (4.2.2 and 4.4.2).
[Xposed Framework Modules] pbosio:
As soon as Whatsapp calls became available to me (a couple of week ago), my friends and I start calling each other (the same thing that everybody does when it become available), the issue that you are describing happen to all of us (I'm the only one using xposed) plus a lot of other issues, conclusion: Whatsapp calling sucks.

I'm not saying that this module can cause issues with the whatsapp calling, I'm not sure, I never could do the proper tests. I had calls coming ok and others that started ringing after caller hang down.

I will try to test it this weekend if I have time, I have other fix to do and callings are not my priority until they work as well as skype or hangouts.
[Xposed Framework Modules] tobbbie:
No hurry - I just disabled the module until you report that it is solved. Must be linked to notifications and them playing sound. I have also disabled all other modules interfering with notifications - and it was WQH tampering on the sounds. With it disabled, the calls run well both ends if connectivitiy is persistent. But mind to disable all battery optimizers that switch off connectivity when screen off. As long as even just radio data connection is available the terminating calls reach your device with a little delay (3-5 seconds) and it rings.

Whatsapp calls is much better than SIP (battery drain due to heartbeat on UDP) or skype (just too bloated to have it active all time). I think it will be a big success - especially when IOS and WP will join the train one time in future...
[Xposed Framework Modules] renosampaio:
You are wrong, first, calling ringer is a very important thing. Second, it's obvius that the problem is whith your module, I have just disabled it and I receive the whatsapp calls ringing a vibrating, if I reenable your module, the call just vibrate.

Maybe there are some android versions where this problem does not show everytime, but for many many people this is the problem. I'm using android 4.3.1.

Thanks
[Xposed Framework Modules] pbosio:
Well, as I already replied to [MENTION=393455]tobbbie[/MENTION] I will look into it as soon as I have the time to do it, there is other issue, that, in my opinion, is more important than whatsapp calling issue, that here sucks and you can't maintain a conversation even if caller and receiver are connected to a 30mb wifi.

You should never, when you are asking for something, start your statement saying "You are wrong" and start enumerating issues and opinions, that was not polite. I make not profit with this module, I started programming it for myself and I shared it to the community that were as annoyed as I was with whatsapp ignoring quiet hours. The source code of this module is published in github if the issue with the calling outrages you that much you are welcome to modified it and push the fix to github or just disable the module and wait for me to fix it.

Cheers.
[Xposed Framework Modules] renosampaio:
Thanks for the input, but sorry, it was not my intent to annoy or not be polite, maybe my poor english...