yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] egingell:
It FCs because it's supposed to.

Anyway, I put the wrong "fake" in the parameter of checkFileUriDestination().

Here's what I intended. lol

Downloads2SD_v7_b8eebb.apk
[Xposed Framework Modules] claytonjn:
Yea, that's what I figured. Back to downloads just failing. Like I said, don't bother trying to fix it just for me.
[Xposed Framework Modules] egingell:
It was worth a shot.

Any logs in case I think of something else?

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] claytonjn:
Sure, here you go.
[Xposed Framework Modules] egingell:
And back to "invalid combination of destination"... whatever that means.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] silentvisitor:
Sir,

Can it redirect my WhatsApp directory ?
[Xposed Framework Modules] egingell:
No. That's hard-coded. And I'm not about to hook the File class and look for folder names or hook the method which provides the path to the SD card and break everything. This mod already breaks enough stuff. lol

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] keithleyson:
Latest version fixed some problems for me, screenshots, photos, except download from Chrome. Still getting downloads unsuccessful.

ಠ_ಠ

On mobile....
[Xposed Framework Modules] egingell:
Please read. I have exhausted all possible solutions ... to my knowledge ... to fixing that.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] haoyangw:
Hmm is it possible for Dropbox downloads to work? Like downloads/opening of files from the Dropbox app? It still downloads to Internal. If it is not possible then never mind, that isn't very important. Thanks anyway!
[Xposed Framework Modules] egingell:
If it doesn't use the "right" method for getting the directory or it's using its own cache, then I can't/won't do anything about it. I'm not hooking into individual apps.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] An_I_K:
creates lots of empty folders

Changed the Screenshot folder to external SD card on my Z1 Compact (4.4.2 (14.3.A.0.681)). Working great!

But when this module is activated, phone creates empy folder Android/data/(and lots of empty folders with app names) on external SD card. While deleted - they reappear again.

Can it be fixed somehow? Thanks in advance!
[Xposed Framework Modules] egingell:
I can't replicate this, do there's nothing for me to fix. Please provide more info. Like how you determined that it was this module and not done other app/module.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] An_I_K:
Oh, I'm sorry, I was wrong! While was trying to figure out what the cause of this strange behavior, I switched this module off and it seemed to help.. But no, after some period of time folders reappear again.

Sorry for the inconvenience once again!

But maybe someone could give a quick hint about where should I look to stop this. :p
[Xposed Framework Modules] egingell:
Basic troubleshooting. Disable all. Enable one one at a time. A lot of rebooting.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] alirezaafkar:
This doesn't work with New Google camera! Am I right? Camera force closes for me when I choose sdcard1
[Xposed Framework Modules] egingell:
Logcat?

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] alirezaafkar:
https://www.dropbox.com/s/nyh8nng34t90biu/2014-04-18-10-36-39.txt

https://www.dropbox.com/s/ur9rh5hm9pxe8k7/xposed_debug_20140418_103535.log
[Xposed Framework Modules] egingell:
The only thing I see of mine is "DIRECTORY_DCIM : /storage/emulated/0/DCIM => /storage/sdcard1/DCIM (edrwx)" which is immediately followed by an FC caused by XHaloFloatingWindow. Please disable that module and try again. If the problem persists, post a new logcat without that module enabled.

I suspect the problem will persist; however, if it's what I think it is - Google "fixing" external SD card access, then there's nothing I can do.
[Xposed Framework Modules] alirezaafkar:
After checking the logcat i found the problem, It couldn't load an image in DCIM, After i deleted that image it worked.

Thanks
[Xposed Framework Modules] theknut:
Hey mate, can you please reduce the logging in the next release? The logging doesn't provide any useful information for the user and it seems to be logged because of a missing folder but it doesn't seem to be a error log either.
[Xposed Framework Modules] egingell:
It only logs when an app requests a folder's location, but you are right - is not entirely necessary.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] Gertlily:
I get issues on the Galaxy S5 with the /Pictures folder.. Telegram picture's wont save in there, and screenshots get an error "Couldn't save screenshot. Storage may be in use."

Is there any way you know a fix for this? The folder's do exist and have right permissions...
[Xposed Framework Modules] egingell:
This is a Kit Kat issue that I am not fixing any time soon. I tried and failed several times.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] Gertlily:
Oh bad to hear that. Is there maybe something I can do to debug it?
[Xposed Framework Modules] egingell:
Yeah. Give me your phone*. I'm not installing Kit Kat on this phone, yet.

*Don't give me your phone. I was just kidding.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] Gertlily:
Well I did al most post the phone to you. ?

When you need a tester or something just ask me.
[Xposed Framework Modules] mmamedov:
I'm using this module on CyanogenMod 11 on my Xperia Z and it works flawlessly. Screenshots, Pictures from other apps, everything saves to external sd
[Xposed Framework Modules] egingell:
ROM devs are free to disable the permission restriction that was added* in Kit Kat. However, I tried and tried to retroactively disable this via Xposed, but couldn't.

*The code has always been there.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] mmamedov:
I believe this module does what you're trying to do. You can mention it in main post so vanilla Android 4.4 users will have a chance to use your module ;) .
[Xposed Framework Modules] egingell:
I may look into incorporating that when I feel up to it, but inline file editing is not my strong suit.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] atthebeach:
Same here, both Chrome Beta and Chrome say "Download unsuccessful" in the notification bar where normally the ongoing or finished download would be visible.

But because I have the other apps installed that can download, I usually (always?) get a popup that asks which app to use for the download when I click on a file to download, and if I then choose the "ES File Explorer" or "Firefox", the file downloads successfully to the folder that Downloads2SD is configured for.

I can live with that as a workaround. I would say it's actually a feature, as it disables unnoticed 'drive by downloads'...

Note: This is on a SGH-I747 with SlimROM KitKat 4.4.2, with the path for 'Download' set to /storage/sdcard1/Download
[Xposed Framework Modules] egingell:
This is a problem with Chrome then. Not my module. All my mod does is intercept the request for a destination and return a different one. What the browser does with that info is independent.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] Rom:
Can you add the option to change the directory of bluethoot receive directory please ?
[Xposed Framework Modules] egingell:
I explored this. I can't determine how or when the folder is chosen.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] Rom:
How you can't determine this?

Me, i am on the Cyanogen 10.2 i know that received by his Bluethoot stored on the internal memory in the "bluethoot" folder files ..
[Xposed Framework Modules] egingell:
You're not a programmer - just a guess.

I'm, aware of where files are stored. I'm not about to hard-code folder paths nor am I even going to consider hooking the File class to "wait" for when it's accessed or written to. I can't find what method or property determines the output location of the Bluetooth directory before it's accessed. It's also handled in a completely different way than the those intercepted by this module.
[Xposed Framework Modules] Rom:
Okkk so its impossible ?
[Xposed Framework Modules] egingell:
No. Not impossible.
[Xposed Framework Modules] Rom:
Ok, and for information, i am not a dev but i learn to make projetcs.

So, can you more see it or not?
[Xposed Framework Modules] Oijkn:
Hi,

Can you make it working for the default browser please ?

Best regards.

Envoyé de mon GT-I9195 en utilisant Tapatalk
[Xposed Framework Modules] egingell:
This is not browser dependent and it does not work reliably on Kit Kat.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] Oijkn:
OK thank you for your reply.

Regards.

Envoyé de mon GT-I9195 en utilisant Tapatalk
[Xposed Framework Modules] sabret00the:
Anyone tested this with Tapatalk?
[Xposed Framework Modules] egingell:
Tapatalk has its own setting for download destination.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] JoshDi:
I'm having issues on my Verizon Galaxy Note 3 with Google Apps, like Chrome, and changing the download directory to /mnt/media_rw/downloads. Chrome will download files unsuccessfully on 4.4.2 (NC4) unless it is on the internal storage drive. Any suggestions?
[Xposed Framework Modules] sabret00the:
I've found that I still had to install https://play.google.com/store/apps/details?id=nextapp.sdfix to ensure I could write to SD
[Xposed Framework Modules] lelepelli:
one shot feature

It is possible to implement 'one shot' changes from sdcard0 to sdcard1 for all folders?

Thanks!
[Xposed Framework Modules] Chosen_on184:
Can you maybe implement this where I can have screenshots saved to SD CARD
[Xposed Framework Modules] egingell:
Screenshots are saved to /sdcard/DCIM/Screenshots (on my phone at least), changing the DCIM folder should do it. If it doesn't, then it's beyond the scope of this mod.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] Razwerkz:
I'm having this same issue, but on JB. Chrome can't seem to download to the external SD (using storage/sdcard1/downloads).
[Xposed Framework Modules] egingell:
It's hit and miss and the only thing I can do about it is prevent Chrome from FCing.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] seagate1:
[MENTION=4587767]egingell[/MENTION]. is this the apk i need for 2sd ? ive been going through this post. and reading it. ive looked on google playstore, and theres many on there. and i have been reading the reviews about them, link2sd but its either hit or miss with them thanks.
[Xposed Framework Modules] egingell:
No. This mod makes the API return a different directory path when asking for certain ones.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] dumbl3:
I cannot get it to work on my sony xperia z2 tablet. I am running CM11, I have installed this SDFIX from playstore to make sd writable, but when I setup Download2SD to '/storage/sdcard1/Downloads' and I try to download a file, downloads will fail. If I move it back to default, downloads work again..

Can someone help me, am I doing something wrong. Or it just doesnt work with cyanogenmod or something?
[Xposed Framework Modules] egingell:
Read the OP. KitKat functionality is hit and miss.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] dumbl3:
OK, so I just tried downloading with Firefox instead of the android browser app, and with Firefox it does seem to work,, I'll stick with Firefox then I guess
[Xposed Framework Modules] isaak:
I think this is a conflict between this module and ccleaner for android:

13/ott/2014 17:16:29 UTC
Loading Xposed v54 (for Zygote)...
Running ROM 'JZO54K.I9070UBLPK' with fingerprint 'samsung/GT-I9070/GT-I9070:4.1.2/JZO54K/I9070UBLPK:user/release-keys'
Loading modules from /data/app/com.oasisfeng.greenify-2.apk
Loading class com.oasisfeng.greenify.pro.FrameworkPatch
Loading class com.oasisfeng.greenify.pro.SettingsPatch
Loading modules from /data/app/git.hub.font-1.apk
Loading class git.hub.font.x.hooks.XposedInit
Loading modules from /data/app/com.egingell.downloads2sd-1.apk
Loading class com.egingell.downloads2sd.XHook
java.lang.NullPointerException
at java.util.regex.Matcher.reset(Matcher.java:181)
at java.util.regex.Matcher.<init>(Matcher.java:94)
at java.util.regex.Pattern.matcher(Pattern.java:290)
at com.egingell.downloads2sd.XHook$1.afterHookedMethod(XHook.java:80)
at de.robv.android.xposed.XposedBridge.handleHookedMethod(XposedBridge.java:645)
at android.os.Environment.getExternalStoragePublicDirectory(Native Method)
at com.piriform.ccleaner.core.d.l.<clinit>(SourceFile:12)
at com.piriform.ccleaner.c.a.f.a(SourceFile:57)
at com.piriform.ccleaner.c.a.f.a(SourceFile:28)
at com.piriform.ccleaner.ui.fragment.g.doInBackground(SourceFile:672)
at android.os.AsyncTask$2.call(AsyncTask.java:287)
at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:305)
at java.util.concurrent.FutureTask.run(FutureTask.java:137)
at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:230)
at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1076)
at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:569)
at java.lang.Thread.run(Thread.java:856)
[Xposed Framework Modules] egingell:
I don't know what to tell you. I can't debug other apps and I'm not doing anything special.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] isaak:
Can you implement a function to exclude any app by choice?
[Xposed Framework Modules] egingell:
There an idea I hadn't thought of. I'll look into it. I'm not very good at interfaces, though, so it'll be a while.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] stievy:
It

only

works on KitKat when you adjust the path to /storage/sdcard1/whathever_folder_you_want. Maybe you can add this to the description ;)

You also have to install this module on KitKat:

http://repo.xposed.info/module/kz.virtex.android.sdcardfix
[Xposed Framework Modules] mmamedov:
Thank you for this great module!

I have checked the latest version on CM12 running Lollipop 5.0.2, and D2SD (v. 1.0.8) does not work on it. No error messages, no strange behavior, it just doesn't do anything. I've checked it by taking a screenshot (after changing the path of picture to SD card) and it saved to internal memory. I also tried to download a file using Chrome, and it also save to the phone instead of SD card.

Rovo89 on his post on XDA Portal said that there is a simple fix for modules targeting system files. The adjustment is needed to be done to the new Android framework code. You may want to look at it and see if that is the issue here.

Thanks again for this great module and I can't wait for an update for Lollipop!
[Xposed Framework Modules] egingell:
It says "system services". I'm not hooking any system services. I'm hooking the method by which the app gets the folder's path. Regardless, I literally can't fix it without any error messages.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] egingell:
Looks like it can't create the settings file. SELinux set to enforcing?

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] mmamedov:
So should I change it to permissive move on every boot or is it fixable through an update?
[Xposed Framework Modules] egingell:
I can't fix that.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] 7786:
I just tried this on a CM12 ROM. I changed the download directory to my sdcard, I believe something changed because now whenever I try to download anything it says "download unsuccessful". I can read/write to my sdcard with other apps just fine. SELinux is set to permissive, xposed and a few other modules are running as they should. Heres a log:

http://pastebin.com/PHr5w8ik
[Xposed Framework Modules] egingell:
Is /external_sd a symlink? Try /storage/extSdCard or /storage/sdcard1 ... or whatever it might be called (not sdcard0, legacy, emulated, or any of the UsbDrive* folders).

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] MBariya:
I have tried on several apps with CM12.

Chrome give FC.

Screen shot also gives error while saving file, may be it is not getting sdcard excess. (Even i have used sdfix same as kitkat)

But Google camera and stock camera works perfect. It gives FC on first click but after that all snaps saves in External Sdcard.

One more thing tapatalk saves file on internal SD even after giving external SD card path in app.

Log files are not giving much details so not attached, but if u need it i can provide them.

Lets make it full capable with LP.....
[Xposed Framework Modules] 7786:
It was, so I changed it to what was under the storage directory. Now it seems like whatever I download is hit or miss. Maybe related to the size of the file being downloaded? I tried downloading some random images from google image and they worked fine. However trying to download any kernels/zips fail. I attached another log if you want to have another look. If you search "testing" you'll see the image I successfully downloaded. Search for "Cataclysm" to see all the failed attempts out downloading those.

http://pastebin.com/xpKetbYj
[Xposed Framework Modules] egingell:
There's not really anything I can do when it comes to "hit and miss" issues.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] MBariya:
Issue is not regarding your module, google made some changes to their code for not copy some content to exsdcard. If it is regarding your module then it should also not support camera app. But it works fine with camera.
[Xposed Framework Modules] egingell:
Leave it to Google to implement restrictions that don't make any sense and are completely unnecessary.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] quorn23:
Using Lollipop on a Samsungs Galaxy S4, download2sd works, except saving screenshots. This breaks with the module enabled. Is there a plan yet if the module will be upgraded for 5.xx? :)
[Xposed Framework Modules] egingell:
Please read the previous 10 posts.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] sireebob:
Or you could have just said "no."

This does not work with Lollipop and there appear to be no plans to fix it.
[Xposed Framework Modules] MBariya:
I have tried this app on samsung TW 5.0.2 roms. And this module working file. But at same time it is not working with CM12 based roms.

I think problem is related to CM12...Not with this module.
[Xposed Framework Modules] pyler:
XInternalSD does this too.

The key is "full access for external sd card" fix for LP
[Xposed Framework Modules] MBariya:
I know that xinternalSD also does that. But it also gets failed for ScreenShots. May be google has restricted that. Only CM12 base ram has that problem. TW roms doesn't have that problem.
[Xposed Framework Modules] marcdw:
Been awhile since someone posted tests on Lollipop.

Did some quick tests today.

Pac-Man ROM 5.1.1.

As mentioned before screenshots fail and Tapatalk downloads to internal storage.

Pale Moon, Chrome, and Android Browser worked.

Downloading images from Facebook went into a DCIM subdirectory on external SD.

Google+ saved to external SD.

Will test other items as I go along. Note that I do use defim's HandleExternalStorage module which may or may not play a role.
[Xposed Framework Modules] pyler:
That module does the magic, w/o it, this module can't work on LP/KitKat. Hopefully I will be able to send "kk/lp fix patch" to this project in coming days =)
[Xposed Framework Modules] KTownGT:
This module seems to work without it on 5.0. I did however run an APK that forces RW access for the sd card
[Xposed Framework Modules] pyler:
I sent fix for KK/LP sdcard restriction. Dev should merge it, try it and upload apk.
[Xposed Framework Modules] :No-Frost::
It seems that is not properly working for Chrome... I've downloaded a few files and all of them have been saved to internal storage ?
[Xposed Framework Modules] egingell:
Did you change the directory in D2SD settings? It doesn't work out-of-the-box.

Sent from: SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] :No-Frost::
Yep, I've chosen "/sdcard1/Download" and when I download stuff from Chrome, it goes to the internal memory rather the external one :(
[Xposed Framework Modules] :No-Frost::
Just realized that this module is not maintained anymore... ?
[Xposed Framework Modules] egingell:
Not since I have no devices above Jelly Bean.

Sent from: SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] :No-Frost::
Is there anyway I can help or collaborate to get it updated for Lollipop? As it's not working on it ?
[Xposed Framework Modules] gadget!:
My favorite module!

I have been using this module since Jelly Bean, it has worked great for me on KitKat, and Lollipop as well.

Unfortunately it does not work on Marshmallow. ?

Any chance this may get updated in the future?

sent from a Galaxy far far away.
[Xposed Framework Modules] Roxbox:
Not working on HTC E8 Viper Rom MM :( older KK works

One e8
[Xposed Framework Modules] gadget!:
​

It seems development has stopped on this module, That's to bad because even though the OP says it doesn't work on KitKat, it worked perfectly for me on both KitKat and Lollipop.

MM brings a whole new set of challenges for this type of module with all of the permissions changes that have been made.

This module is partially working for me on MM, the only thing I have found that does partially work is the "Pictures" folder. With the module enabled my screen shots are being saved to the external sd card, without it enabled they are saved to the internal sd card.
[Xposed Framework Modules] egingell:
I said I can't test it. I never said it won't work.

Having since updated to Lollipop, I lack the patience to get Xposed to work on my phones; therefore, this mod will remain as-is.

Sent from: SGS5 - LP 5.1.1 / SGS4 - LP 5.0.1
[Xposed Framework Modules] Roxbox:
if there is some sort of alternative to this program which operates on MM ?
[Xposed Framework Modules] DemonDroid_97:
Try this module. It works perfectly.

http://xdaforums.com/xposed/modules/xposed-disablesignaturecheck-t2789267
[Xposed Framework Modules] Yudh:
It used to worknon kitkat and also marshmallow till xpose v78 but now it stopped working on marshmallow with xposed module v85

✌
[Xposed Framework Modules] egingell:
How unfortunate.

Sent from: SGS5 - LP 5.1.1 / SGS4 - LP 5.0.1
[Xposed Framework Modules] Yudh:
Is there any way to make it work plz

✌
[Xposed Framework Modules] Rakuu:
Oh well since you said plz...
[Xposed Framework Modules] egingell:
I'm sure it's possible. The source is available, feel free to do it.

Sent from: SGS5 - LP 5.1.1 / SGS4 - LP 5.0.1
[Xposed Framework Modules] Yudh:
Hey man i am not capable of doing so. But we all people using marshmallow will be greatfull if you try . What i can do for you is testing part.

✌
[Xposed Framework Modules] egingell:
I've made it fairly clear that I won't be continuing development.

Sent from: SGS5 - LP 5.1.1 / SGS4 - LP 5.0.1
[Xposed Framework Modules] Yudh:
Sorry i didn't knew about that .?

✌
[Xposed Framework Modules] Roxbox:
Great app working 100% thx

One e8
[Xposed Framework Modules] mohsenfa01:
Please add Bluetooth folder
[Xposed Framework Modules] egingell:
A) This only works with certain folders, one can't simply add folders.

B) As I said not even three posts above, there will be no further development by me.

Sent from: LG G4 MM 6.0 / SGS5 MM 6.0.1
[Xposed Framework Modules] Rom:
Hello @	egingell

As you ca see XPosed for Nougat has been release, so can you update your module please ?

Thanks in advance.