yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] wanam:
It is not an App bug, this is an Android limitation, it doesn't react to volume keys neither broadcast their events so there is nothing i can do from my side.
[Xposed Framework Modules] Blizzard22:
"Enable torch helper" caused an softbrick after rebooting my phone. My Note 2 couldn't boot anymore and got stuck at the Samsung

(bootloop).

I had to reset my phone. -.-
[Xposed Framework Modules] MuratR:
bug

on my mt6575 gt-i9500 not work. android 4.0. when I open the xposed torch app this message writen "Your Device does NOT have a Flashlight support! "
[Xposed Framework Modules] _jis_:
It wasn't necessary at all, you didn't read OP for Xposed Framework?

---------- Post added at 12:59 PM ---------- Previous post was at 12:52 PM ----------

Why you don't add the option to use Home button (hardware one) or Power button for switching torch On/Off? The other button will be still able to switch the Phone On/Off.
[Xposed Framework Modules] jpierce1987:
Home button...

This is why cyanogenmod used the home button for the flashlight, because the home button can wake the device... You could either press to wake, or hold home to toggle flashlight.. Plus the home button feels smoother than reaching for the volume buttons..
[Xposed Framework Modules] wanam:
I hesitated to use the Home button because many devices don't have it, but anyway here is a new update to turn the Torch on with the Home button.

Try it and let me know if you get any issues.

Edit: 1.5.0 posted.
[Xposed Framework Modules] marbulas:
Turning on and off with home button fine.

But if I turn off the torch with home button, screen turns on.

I'm using your wanam xposed and set 'home button wake up' into off but it ignored if I turn off the torch with home button.
[Xposed Framework Modules] jpierce1987:
Interesting... It works just like the volume one. Doesn't work if the phone is in deep sleep... I wonder how cyanogenmod was able to make it work so smoothly? Weird... THANKS, though! Was not expecting that, and especially not so fast! It does work, and its easier to reach than the volume buttons... Just has the same limitation... Maybe something to do with xposed?
[Xposed Framework Modules] wanam:
New update posted.

1.5.0:

- Turn On Torch through Home button (if available) long press

- Turn Off Torch through Home button press without turning On the screen

- Remove Torch App for recent Apps history

- Few other fixes and improvements
[Xposed Framework Modules] dimiav:
tested on: Galaxy s3 i9300 , temasek unofficial CM v50 , .boeffla kernel v2.2 beta

the new Home button works great1!!!!!! thank you very much!!!!
[Xposed Framework Modules] thedicemaster:
could you add an option to choose which button to use?

I don't like the idea of putting too much functions on 1 button(volume+, skip music, torch all use the same button) so i'd like to disable torch through volume buttons without disabling torch through the home button.
[Xposed Framework Modules] sutobe:
thanks for fixing the close torch process in recent app history! :good:

Now there's one thing, I am pretty sure I could turn the torch on and off by pressing volume up and then volume down and then turning it back on again right afterwards by pressing Volume up again. Now I have to first press the power button twice before it reacts.

Nexus 5, Kitkat 4.4.2, Stock Rom, Torch 1.51

Cheers

PS:

So far I am staying with this because the torch function in Wanam Kit is giving me trouble as can be seen in the Wanam Kit thread.

EDIT:

Damn this was quick! xD just got 1.52 and now it's working just fine! :D
[Xposed Framework Modules] Blizzard22:
Could you please add an option to disable home button torch light?

I already have set up the home button for the module physical button control.

It would be also great if you could add an option to disable display wakeup when starting torchlight with the volume buttons.

I have to disable your module until I can change the settings because it causes problems and it wakes up the phone.

Thank you for reading!
[Xposed Framework Modules] towelboy:
You should make the option for turning it on by holding the power button while phone is off. Its an option in sense toolbox and works like a dream on the HTC one!

Sent from my Nexus 5
[Xposed Framework Modules] termit901:
Hi, my friend.

With the last update, during conversation it is impossible to turn on the display, it lights up for 1 second and at once is switched off.

Rec video screenshot:

https://www.youtube.com/watch?v=I-fBn7FLpOg&feature=youtube_gdata_player

Note 3 sm-n900 4.4.2

please fix. Thanks you work
[Xposed Framework Modules] wanam:
Are you sure it's related to my app? the behavior you described is normal during call, the light sensors are used to turn off the display when you put your hands or ears close to them.
[Xposed Framework Modules] termit901:
Certainly. If to switch-off the module that everything apprx.

As the sensor works I know, the problem not in that as works the sensor, and in that that after the display will be switched off during conversation on the sensor, I can't turn on the display, i.e. on video I photographed that pressing the house button the display загврается and at once is switched off and I can't awaken phone during conversation, also on video it is visible that there is "closing flash light" inscription

It only if to include small lamp activation on hold home
[Xposed Framework Modules] sutobe:
Hey

the module still isn't working properly. (1.60)

I can turn torch on with volume up, I can turn it off with volume down and that's it.

Without pressing power button to wake up the display it is not possible to turn torch back on.

And even if you wake up the screen it is a game of luck. Mostly I get a closing torch screen and then the app crashes, also with an error message (doesnt work anymore, closing)

Worked with 1.52 for a certain time then it started again, also did error reports in here and on Wanam kit thread but there was no reply!

Did several reinstalls and reboots. Simply doesn't work.
[Xposed Framework Modules] Preshak:
Worked on grand
[Xposed Framework Modules] d_bizzzz:
additional suggestion

Great app ... I use it very frequently ...

Could I please ask if you can add the option to turn torch on with 2 button presses together rather than one.

I find I accidentally turn the torch on. Pressing both home & vol up together would be a fix for this problem.

Thanks
[Xposed Framework Modules] wanam:
I removed the Home button feature because it causes some wake-lags at least on Samsung Touchwiz, re-broadcasting the home key event does NOT work well on Touchwiz (something related to DVFS i guess), i tried some workarounds but none of them was a perfect solution.

So i looked on the other way, how to force the Volume UP to be broadcasted even on deep sleep (without waking the screen of course), so the solution i found was to hook the "isWakeKeyWhenScreenOff" method and catch a wake-lock for the Volume UP key, the wakelock is required to launch the Torch, but it will be released once the Torch is off.

1.7.0 released:

- Removed Torch helper, not needed anymore.

- Ability to run the Torch even on deep sleep.

- Removed Home button option, this feature causes some wake-lag on Touchwiz Roms.

- Many other stability fixes
[Xposed Framework Modules] ABQNM:
This is great. Thank you! I was using the volume down flashlight in Gravity Box, but I like being able to make the press duration longer, so thank you for this.

The only thing I miss is the vibration when it is activated. Any chance this could be added as an option? I like the vibrate in case I accidentally turn it on in my pocket, I can feel it. This should happen less than the GB implementation due to the adjustable durations but it would be nice.

Either way, thanks for the work!

Sent from my brain using human to phone transport technology.
[Xposed Framework Modules] wanam:
New update posted.

1.7.2:

- Disable Torch triggers while making Calls

- Transparent Torch activities

- Improved Torch response

- Vibrate while launching the Torch
[Xposed Framework Modules] ABQNM:
Works great! Thanks for adding the vibrate!

Sent from my brain using human to phone transport technology.
[Xposed Framework Modules] pringlare:
Thanks for a wonderful app that works great! :D Can you make the vibration an option to turn on or off?
[Xposed Framework Modules] kotey:
Nice addon, but i have several complaints.

v1.4.x used to work on my S2 tw 4.1.2 stock. Newer versions didn't. Pressing button did nothing now. So firstly i downgraded..

Then i noticed the size. It matters to me when it comes to size. Especially for simple, single function apps. What bothers me is, it was a mere 250k addon, since 1.5.x its a bloated 900k apk. I dont see a future anymore and uninstalled.

Below are rants; don't read if you're easily disturbed.

The reason was, i already have TeslaLED which does 10x more functions and its only 512k. It doesnt have button shortcuts obviously, but a lot of launchers/utils can call it directly. I always wonder why there are always smallers apps that does more than bigger counterparts..

What i'm saying here is, i can live with a 'shortcut' worth 250k, but in reality it should be more like 15k or 20k, not 900k bloatware. So, unless xposed torch is back on diet, consideration is out of question.

I dont know what or who to blame but lately, lots of apps tends to became bloated for no reason. I guess i blame actionbarsherlock, supportv4, among others. And holo. And google play service. While it should be leaner, when it comes to code, actually its a bloat and a mess. Now i have the hate for lots of android apps that is comparable to Visual Basic programs -- point and shoot programming.

People always ask me why i hate 'big' apps. I gave them a simple answer:

It probably contains NSA code from Google, your phone could be the next suicide bomb.

And that includes open source apps, too. If it contains alien, bloated codes.

Nothing personal, i'm not against you or something like that. What i mentioned are general.

And please no hard feelings, nothing personal, really. (In fact i admire your hardworkship)
[Xposed Framework Modules] Blizzard22:
As much as I want to understand you I honestly can't take this much stupidity. Do you seriously believe that bigger apps means higher risk?

Today's smartphones are definitely all unsafe as much as you want it to be. And I just have to tell you that nobody really cares about your ****.

Worst thing that can happen to you is that somebody finds your phone and sell it or before that trying to buy stuff with the eBay/Amazon/Play store.

Please don't post such ridiculous and retarded stuff here...

Buy the 'Merkel phone' (which soon be available in Germany) if you're upset about the NSA.

As long as you use Android/WP/iOS you are NOT safe at all.

It doesn't matter if youre phone is rooted or not.
[Xposed Framework Modules] CNexus:
If you really did appreciate his work, you would take this up with Google, not developers that merely make use of Google's API.

There are only so many ways to code things. You're not even really complaining against this mod, but against Android and programs that use Java in general.

If it's bloatware to you, don't use it. Bloatware is junk that people don't need because they don't use it. If you don't need it, uninstall and move away from the thread. Simple as that.

Do you understand what it means when xposed is used to hook into the system? Completely new code is introduced. It's not just an app that calls on existing camera flash api like your great TeslaLED app does. It introduces listeners, wakelocks as a workaround for deep sleep not triggering key events, etc.

At least do your research before you rant. And at least rant at the correct audience if you've decided you're going to rant.

And as was said, YOU are choosing to use a Google OS based device. No one forced you to buy it. And as long as you are doing that, your information won't be safe from those who need to see it.

tl;dr

Start your own software company and make your own OS. See how"easy" it is to get out of feeding your data to the NSA through PRISM then.
[Xposed Framework Modules] Looki75:
Hello, thanks for the update.

1. I still experience issues in deep sleep: torch doesn't light up! When the home button option was here, it was ok with the home option.

Volume keys are/have been always erratic...

Other remarks:

2. I would like to have the vibration as an option as mentioned by someone else

3. Is it a bug or a feature: after the torch has worked once, only a single click on the vol+ button will trigger it again!

Scenario:

click and hold vol+ / torch gets ON / click short vol- / torch gets OFF / click short vol+ / torch gets ON again

Note:

if you switch the screen ON, everything is back to "normal"

If it is a feature, could it be optional? I like to use the torch and then off without switching on the screen and put the phone in pocket... currently there is a risk that the torch gets activated by mistake in the pocket.

Thanks!
[Xposed Framework Modules] wanam:
In a short answer i would say it appears bigger because Google migrated their Admob SDK to the Google Play Services.

I know it should be much smaller without the ads framework, but as many of you know, i can't make paid Apps on Google Play and i don't have any other alternative to support my work.
[Xposed Framework Modules] SadHeroXIII:
stupid useless update !

the update u make is really stupid and useless !

I just uninstall this mod now !!

u take off all customize setting and add stupid vibrate !!

I hata vibration !

also it does not response as fast as what it was in the old version

​
[Xposed Framework Modules] Fleetknight:
Module works 99% great right now, my only caveat being that the torch does not seem to work once the lockscreen takes effect. If i sey the lock delay to 30 minutes it's fine, but after that it just flashes once and turns the screen on.

Galaxy S4 4.2.2 with stock Touchwiz and Wanam Xposed.
[Xposed Framework Modules] kotey:
Thank you very much for the clarification. I'm not aware that you can't get paid directly, thus the ads.

As for the admob sdk, i'm well aware of that since i baksmali'd almost every apps i got my hands on to examine the codes. I figured that around the end of last year google put admob into play service, hence some devs used admob twice. The new admob+play service is four times the size of the old sdk.

One questionnaire remaining though; is it possible for 'modern' apps to be developed using the older sdk (and devs still get paid) or is that google intentionally make it harder and harder (while using words as 'easier for developers')

---------- Post added at 07:25 PM ---------- Previous post was at 06:28 PM ----------

@blizzard22

i did said 'simple answer'. it also mean 'stupid answer'. you pointed out the nsa part. do you understand sarcasm?

if you can't take 'this much stupidity' i've also said don't read if you can't take it. can't take that much of your own what then?

you replied in anger with zero points answering mine.

[MENTION=4645794]CNexus[/MENTION]

thanks for the comments. i might be a little harsh on word choice, my bad.

i really do like wanam's work (wanam lite, etc) he's a good dev. what disturbs me when a good dev somehow did something i felt uncomfortable, so i feel responsible to at least give some kind of feedback to him to keep his good rep. (and i dont care of my own rep since im in the bottom of the food chain) so i did what i did.

and, i mentioned that i blamed holo, gplay service. i never blamed the dev. (erm, maybe he chose a bad code, or maybe he HAD TO because he had no other choices, so i had to ask)

in my later post i raised a question if the 'older' sdk's are still any good. i think they still are, but not sure about ads payment from google's side.

and oh, i can't take it up to google because gapps are close sourced and they listen to no one, unlike nice devs on xda. only things i can do, i did like using gplay 3.x and denied gplay service installation.

@

i'm not starting flame wars. my intention was pure, and wanam has answered my question.

---------- Post added at 07:31 PM ---------- Previous post was at 07:25 PM ----------

i had to agree on this one (this guy's choice of word is worst than mine though)

not everyone is fond of vibration. but some people do need it.

vibration should always be made an option, not forced.
[Xposed Framework Modules] wanam:
Yes i understand, this App should be ~ 50KB without Google Play services, i think it's bigger because it bundle the Play service for the devices that don't have PlayStore but i also prefer to use the new API to avoid any future incompatibilities with Google services.

I posted a new update to avoid more messages on my mail box :rolleyes: , it seems a lot of users like the Home button feature, so it's back with a few improvements, i made also the vibration optional because our sad herro hata it :D , but i still recommend it to trigger any accidental buttons long press.

1.7.4:

- Add back Home button option with a few improvements (it may still cause a few delay on Touchwiz Lock screens)

- Make Volume UP button optional

- Fix Pair Volume UP/Down triggering the Torch

- Make the vibration optional (i recommend to use it for intentional Buttons long press)

- Removed some debug code

- Few other fixes

Edit: Removed some debug code on 1.7.4.
[Xposed Framework Modules] kotey:
Wow you really ARE FAST! One more thing to admire :)

I thought only devices that have Play Store & Google Account will have Play Services, am I correct? AdMob prefs used to be configurable inside Play Store app but now its not there but inside GMS instead. How will a device without PS use Play Service without Advertising ID (if so?) is beyond my knowledge anyway.

My wet dream everyday is Google killing it's Play Services so it's again standalone Play Store and AdMob. I guess Google is giving Apple some slack to show that iOS is faster by hogging Android with bloats and battery drains :p Until the EU objected this (Google then get sanctions/ballot like Microsoft) then I guess I have to wait... :fingers-crossed:

---------- Post added at 09:33 PM ---------- Previous post was at 09:17 PM ----------

hey wanam.

just a quick thought:

in order to use an xposed module, one must have xposed framework. to have it you must be rooted at least initially.

as we know, rooted devices mostly have (or can have) ad-blocking hosts file installed. and this renders ads unusable, thus a waste.

if an app refused to work if hosts is detected, it can be patched (rooted, remember?) but thats another story. some (hostile, mostly games) apps already do and generally took me less than 5 mins to fix them.

i'm really sorry that i dont have any other idea to help you to compensate from your hard work.

but i also felt that bundling ads in a 'rooted app' is such a waste, unless a user intentionally #admob lines from hosts file to compensate devs as i do sometimes.

my two cents.
[Xposed Framework Modules] ABQNM:
While I am obviously not wanam, I have one point to make on this. This really doesn't seem like an issue here since wanam includes an option in the app to permanently remove ads anyway as a simple menu option. I don't think with this practice that root ad blocking/hosts manipulation is that much of a concern, but again I am speaking as an outsider.

Sent from my brain using human to phone transport technology.
[Xposed Framework Modules] wanam:
Thanks for your interest, don't worry, compared to the amount of installs i'm still getting enough ad impressions, let's hope soon Google will add Morocco to the supported countries for merchant accounts.
[Xposed Framework Modules] kotey:
Actually, that's not the issue. The issue is not manipulation of ads. The issue is the waste of ads code, thus waste of resources. Thanks for your concern, I understand your logic (which is legit).

I just expressed another side of the logic. A (rooted) user wants to let an ad to go through but still no ads, because his hosts file blocked ads. He had to remove/remark some lines from the hosts file, which I doubt many will do (hassle/no knowledge/no idea/etc,etc). Hence ads in rooted devices with hosts (most are) are such a waste.

Amen to that, bro.
[Xposed Framework Modules] ABQNM:
Oh I agree about wasted resources. Using ad blockers can send some ad providers into a tailspin. Having wanam make it an option to disable would (I hope anyway) remove those API calls so that if you do have the ad blocker it won't constantly keep trying to reach localhost, thus wasting resources.

Plus it is a very nice gesture by wanam, who by the way, seems like a really great person to deal with. This is the first module I have used from wanam and I am very impressed with how things are handled here. Thanks for being awesome, wanam!

Sent from my brain using human to phone transport technology.
[Xposed Framework Modules] wanam:
If you choose the "remove ads" option, it won't create any adview instance neither make any API calls.
[Xposed Framework Modules] ABQNM:
See everyone? Awesome developer! You seem to get how things work.

Hopefully you can get play store paid apps in your country soon. There has been a lot of global expansion happening lately, so fingers crossed...

Sent from my brain using human to phone transport technology.
[Xposed Framework Modules] Schokonuss:
With v1.7.0 you introduced the feature to start the torch even when in deep-sleep. I upgraded to that version and it worked, but there were annoying bugs like if I just turned the disply on (with power button) the torch got launched. The updates came so fast that I upgraded from v1.7.0 immediately to 1.7.4. Now these bugs are gone but I can't launch the torch in deep-sleep anymore.

Otherwise I love the module :p
[Xposed Framework Modules] _jis_:
I have the same problem in deep slepp even with the latest release 1.7.4 and using Home button, volume up button switched off, 2s long press delay, 1 minute turn off delay and vibrate :(
[Xposed Framework Modules] BenGentle:
Note 3 not crunk

It doesn't work for me.

Samsung Galaxy Note 3, Android 4.3, TWRP 2.7.0.0, rooted, TweakedN3 2.X + ColonelX + Mini-Update, AOSP for TWEAKED, Nova Launcher & XPosed :)

Before adding ColonelX, TWEAKED's Mini-Update and Nova's launcher, it worked 30% of the time (not scientific).

I love this idea and I hope you get it crunk for my crunk device!
[Xposed Framework Modules] sutobe:
Running the latest build now and still getting the often explained issue that after turning the torch on and then off again, it refuses to turn back on again.

Unlocking and then locking the screen sometimes solves it, then it doesn't work anymore.

I set the On trigger time to 1second because I thought it would work better (and it did for several days) but now it's back to the old habbits again.

Nexus 5 Stock Kitkat 4.4.2

EDIT: I don't know if this is a coincidence or a feature, but if I double tap the volume down button I can turn the torch back on again. If I just press volume down once it won't start up again.
[Xposed Framework Modules] Looki75:
For me, home button works perfect, in every situation. However, despite the long-press setting being 200ms, sometimes, I have to hold it ~2 seconds. I guess this happens when the phone is in deep sleep.

Difference is: in deep sleep Vol+ can never work for me, this is why I prefer the home button solution.

I guess the reason Home button always work is: in normal use, it can wake up the phone - vol+ cannot.