yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] pugsang:
Greek translation attached.

Regards
[Xposed Framework Modules] kosique:
I just noticed that when I open a link from ie. Twitter and confirm it, it works ad expected. The second link, however, does not bring Firefox in front. Firefox loads the page but in the background. How can I fix that?

Thanks,

Marc
[Xposed Framework Modules] ruvort:
I would like to request support for the Auto Guide app (com.quoord.tapatalkautoguidefree.activity)

Thank you
[Xposed Framework Modules] GermainZ:
Thanks, I'll add it in the next version.

I don't understand your problem. I'd make sure it isn't happening with CrappaLinks disabled though. If you're certain it only happens when CrappaLinks is enabled, then try to explain your problem better, please.

Read the OP, please and thank you.
[Xposed Framework Modules] estapagu:
I would like to request support for youtube "attribution_link". I.E. http://www.youtube.com/attribution_link?a=2Xr6LtFgkqk&u=/watch?v=AslPYSm7jfg&feature=share

This kind of URLs is generated when sharing a video from youtube PC website through "share on facebook" option.

Thanks.
[Xposed Framework Modules] theknut:
Tinyurl doesn't seem to work for me.

[youtube]3k4EemM80kw[/youtube]

The link: http://tinyurl.com/qgmz3sh

The thread: http://xdaforums.com/xposed/modules/app-unbelovedhosts-t2720860

I'm on 2.3 and the debug log is clean.
[Xposed Framework Modules] dimm0k:
doesn't work for me either... on mine it just keeps asking if I want to open up this url. if I press yes, it asks again...
[Xposed Framework Modules] GermainZ:
I'm afraid there's nothing I can do here… I can't reproduce it myself, and tinyurl uses the location correctly in its header so I don't see where it could be going wrong…

dimm0k: that's correct, it might trigger a loop if it fails, since it'll be detected as a shortened URL again. I can add an option to disable recursive checks (that is, only check URL once instead of trying to look for nested redirects/masking.)
[Xposed Framework Modules] theknut:
Have you tried opening the link from the thread within the XDA app? I couldn't reproduce it on Chrome or if I copy and paste the link.
[Xposed Framework Modules] GermainZ:
Yes, it resolves the final URL correctly for me.
[Xposed Framework Modules] theknut:
It does if you click the link in my post but it doesn't if you open the links thread and click the repo link from there.
[Xposed Framework Modules] dimm0k:
ok, so here's the weird thing... when I first tried clicking that tinyurl link to verify on my end, CrappaLinks would show a toast that it was expanding the URL. as mentioned, on my stock rooted device, it would repeatedly show the toast every time I pressed OK. after canceling out it seems CrappaLinks doesn't catch anymore links... if I try to open up this tinyurl link now CrappaLinks never intercepts or display a toast until I reboot.
[Xposed Framework Modules] GermainZ:
I'll take another look at the tinyurl links soon enough, I was able to reproduce it after clicking a few times. It seems very random (happens once every five times or so for me) but I'll need to test some things to figure out if there's anything I can do.

Nothing happens? Might be crashing, not sure. Logcat?
[Xposed Framework Modules] dimm0k:
here's a logcat after the fact when I try to open up the tinyurl. let me know if you need a full log while reproducing it...

EDIT: oops, forgot to upload the file...
[Xposed Framework Modules] frankee207:
Hi guys

Works perfectly on my device. Thanks you for this useful (really, really useful) mod.
[Xposed Framework Modules] GermainZ:
I'm curious if this APK will fix the tinyurl issues… If not, I don't think I can do anything: the issue is that tinyurl is replying with a 200 response code (simply put: redirect = 3xx; OK = 200) sometimes, but I can't understand why. Spoofing Firefox's UA seems to fix it, but I can't say for sure since I couldn't reproduce it consistently in the first place.

Changes:

Added new preference: "Resolve All URLs." If enabled (default) and you tap a shortened link, CrappaLinks will keep trying to resolve URLs till it gets to a URL that's not a redirect (this is usually useful for nested, unknown redirects.) If disabled, it'll only keep trying as long as known URL shorteners are detected. If you care about bandwidth, or if you have a slow Internet connection, then you probably want to disable it.

Spoof Firefox's user agent, because some URL shorteners apparently don't like unknown ones.

[MENTION=5687667]dimm0k[/MENTION]

You forgot to attach the logcat.
[Xposed Framework Modules] dimm0k:
crap, file was too large to attach and it didn't say so... here it is zipped...

EDIT: too lazy to type this out on the phone so I posted and edited on the computer here... so I actually downloaded the version you just posted, rebooted, started logcat and then opened up that tinyurl link. did not see any toast from CrappaLinks at all...
[Xposed Framework Modules] theknut:
Sorry mate, I tried 3x but it didn't work.

Yes, I rebooted after installing the update. Nothing in logcat/debug.log.
[Xposed Framework Modules] an0n981:
It doesn't unshorten but at least they open now
[Xposed Framework Modules] GermainZ:
Nothing related to CrappaLinks in the logcat. Are you sure toasts are enabled in CrappaLinks' settings?

Alright, I'll take another look later on.
[Xposed Framework Modules] dimm0k:
yep, just doubled checked it myself and it's on for full toasts... is there a test link I can load for sure to verify it's working?
[Xposed Framework Modules] GermainZ:
There is one in the OP.
[Xposed Framework Modules] dimm0k:
thanks, sorry I didn't look hard enough. I see the problem now. it looks to be that CrappaLinks and the module 'Complete Action Plus' don't mix well, specifically the latest version of the latter mentioned module. will mention this to the author of that module...
[Xposed Framework Modules] an0n981:
This might have something to do with AdBlocking. I just disabled AdAway and tested again, it unshortened the URL a few pages back.
[Xposed Framework Modules] GermainZ:
Works for me. It's not impossible though.

That's weird, I don't see what AdAway would have anything to do with tinyurl... The hosts file doesn't have tinyurl in it.
[Xposed Framework Modules] an0n981:
You are right, I just tried it again. It did not work on the firsy try. It took about 5 tries then it unshortened it
[Xposed Framework Modules] none323232:
Version 2.X do not work for me. It simple do nothing. It is like it is not installed. 1.7.2 work fine.

Do you need a full logcat from device boot until link click?

An 5 second logcat are >1MB, so it will be a really big file.

cu

Gesendet von meinem ALCATEL ONE TOUCH 997D mit Tapatalk
[Xposed Framework Modules] GermainZ:
I need two things. First, reboot. Wait for your device to fully boot then open the Xposed Installer, go to "Logs," press the menu button and select "Share." Paste that here.

Second, clear the logcat (adb logcat -c) then click a shortened or masked link and dump the logcat (adb logcat -d > location) and paste/attach that as well.

Also specify which link you're trying to tap.
[Xposed Framework Modules] none323232:
The xposed log: <proto>pastebin.com/EDR4D0TG

(I guess that show the problem, i see this not before)

The Link click in Tapatalk: <proto>pastebin.com/8Nua0jeM

I try to open: <proto>pastebin.com/xx3f7wu3

I hope this help, if you need more infos or testing i try to do my best.

cu

PS: I need to make the Links unusable because the new user rules.

PPS: Need only 30 trys to solve the Capaca ;) Hard to post here ;)
[Xposed Framework Modules] GermainZ:
This is using the latest version? Can you clear the Xposed log (Xposed Installer > Log > Clear Now) and reboot, then post it again please?
[Xposed Framework Modules] Magissia:
Hello, is the module still using itself to un shorten links instead of injecting this task to the current app to use it's permissions?

Regards
[Xposed Framework Modules] GermainZ:
Thanks, it'll be fixed in the next version.

EDIT: [MENTION=3539306]none323232[/MENTION] please test the version attached.

Yes and no. It obviously still hooks methods, but it redirects the intent when a shortened URL is detected to open with CrappaLinks (an invisible activity.) The URL is then unshortened there.
[Xposed Framework Modules] GermainZ:
This should work.
[Xposed Framework Modules] ccav2000:
Hello, started using CrappaLinks recently with version 2.3. Today when I updated to version 2.4 it is no longer unshortening any urls. Tried twitter and Google plus, it just opens the short url in the browser. Toggling the settings has no effect at all. Have the issue in both my cell phone and my Nexus 7.
[Xposed Framework Modules] GermainZ:
Please read the OP and offer examples as explained there. Thanks.
[Xposed Framework Modules] ccav2000:
Unshorten urls is checked but the t.co and goo.gl urls at least that I tried are not resolved, the toast just gives me the original short url and opens it in the browser. Resolve all urls is also checked by the way.

Let me add that it does that unconditionally, not in specific urls. All t.co and goo.gl that I tried were not unshortened.
[Xposed Framework Modules] GermainZ:
Can you give specific examples?
[Xposed Framework Modules] Adreaver:
Will this work with tapatalk-based apps, such as XDA Premium?

I'd test, but don't currently have xposed installed.
[Xposed Framework Modules] GermainZ:
Not currently but it can be added.
[Xposed Framework Modules] xdagee:
Awesome

Wow! that is really true, thanks for such a great module. xposed is really xposing :good:

This has really worried me for sometime now. I use both TapaTalk and Xda-Developer Premium App. I already gave up.

Thaks to you am back on.

This actually happens with Play Store, TapaTalk and Xda-Developers App, I believe all will be fixed now :good: Thanks
[Xposed Framework Modules] ykumar00:
Can you try to implement a feature to go directly to the URL when the URL is in the format www.adf .ly/URL? This would be awesome as many forums use adf .ly for EVERY link there is. Thanks!
[Xposed Framework Modules] pandasa123:
Saw this on Portal! Congrats on that! But thank god you made this. I hate having to go back to Chrome and it opening up the redirected page from TapaTalk every time!
[Xposed Framework Modules] Lal Ayer:
Thanks bro Awesome​
[Xposed Framework Modules] Tx Redneck:
Thank you sooooo very much for this! Here's a quick screen recoding in action for others to see it's functionality.

https://www.youtube.com/watch?v=NIce-x2NRCs&feature=youtube_gdata_player
[Xposed Framework Modules] bberryhill0:
Yup. People got so annoyed with Tapatalk 4 that they had to make Tapatalk 2 available again but they called it Tapatalk Classic.

Swyped from my Verizon LG G2 using Tapatalk 4.4.2
[Xposed Framework Modules] SpasilliumNexus:
Haha wow just last night I raged a bit in my review with Tapatalk because of the redirects.
[Xposed Framework Modules] raolin7:
Nice work. Such a small tweak that relieves so much resentment towards an otherwise quite good app.
[Xposed Framework Modules] badmoj0:
Fantastic module. Thank you very much for sharing!
[Xposed Framework Modules] Gokh:
I would love to see CrappaLinks to work with the Facebook app :)
[Xposed Framework Modules] famewolf:
He's already stated this app is only for tapatalk, that he has no interest in doing a facebook version, and that requests such of that should be posted in the questions and requests thread. What more does he have to say?

[MENTION=4775688]GermainZ[/MENTION]

I'm very interested in your module...been using tapatalk url fixer up till now but will set some time aside to compare them this weekend. Thanks for the module!
[Xposed Framework Modules] MordyT:
That one exactly, but I have the original version install (not renamed to tapatalk classic at that point). I can get you the package name if you want?

Please post a review here. I also gave been using the URL fixer...
[Xposed Framework Modules] GermainZ:
No. This module has a very simple and particular function, use an appropriate app/service for that.

This module only affects TapaTalk. I'll look into supporting the XDA app as well (it's based on TapaTalk,) but not other apps.

Not going to happen, read my previous posts. :)

It works differently. From what I understand, the URL fixer decodes the URL then sends another intent. This module fixes the issue at the source.

Thanks, I'll let you know if I need that.
[Xposed Framework Modules] famewolf:
So if tapatalk tries to get tricky and encrypt the url in a less recognizable form will your module continue to work since it's accessing the url from the beginning? That's a definate concern with the url fixer method.

Last I remember the xda programs didn't do the link tracking..has that changed?
[Xposed Framework Modules] matrixzone:
Looks good
[Xposed Framework Modules] dEris:
Test https://play.google.com/store/apps/details?id=com.twitter.android

[DEVICE : N⁴]❌[ROM : CM11NIGHTLY]❌[KERNEL : AK]

[LAUNCHER : NOVA]❌[CARRIER : T-MOBILE]❌[CASE : NONE] ​

---------- Post added at 12:54 PM ---------- Previous post was at 12:53 PM ----------

Wow it works lol. Nice!

[DEVICE : N⁴]❌[ROM : CM11NIGHTLY]❌[KERNEL : AK]

[LAUNCHER : NOVA]❌[CARRIER : T-MOBILE]❌[CASE : NONE] ​
[Xposed Framework Modules] nixie2121:
awesome! thanks for this
[Xposed Framework Modules] GermainZ:
Depends on the changes they make.

Basically, unless they intend to break this module or rewrite the whole thing, it should keep working as it is.

[MENTION=1420949]MordyT[/MENTION] and [MENTION=4828873]xdagee[/MENTION] [MENTION=4686120]Adreaver[/MENTION]

TapaTalk Classic doesn't seem to mask URLs at all? What about the XDA apps (specify the version, please?) Does it happen for all links or not?
[Xposed Framework Modules] ccav2000:
As I edited above, it does it in ALL t.co and goo.gl urls not in specific ones.
[Xposed Framework Modules] GermainZ:
Works for me. Please provide specific examples just to make sure, and a logcat as well.
[Xposed Framework Modules] ccav2000:
Does this works for you http://t.co/Bi4wGKCCiQ ? Doesn't unshorten for me. I tried a bit.ly one you have in the OP, that worked.
[Xposed Framework Modules] GermainZ:
Thanks, I'll have a look at it soon.
[Xposed Framework Modules] none323232:
Do NOT work for me, i edit a logcat later if no one are faster in doing that.

cu
[Xposed Framework Modules] GermainZ:
No need for a logcat, I can reproduce it on my side. Other URLs I tried worked though, so I needed a particular example.
[Xposed Framework Modules] ccav2000:
I guess I was the lucky one...
[Xposed Framework Modules] GermainZ:
OK, let's see if this build fixes some of the issues. :) I captured the actual requests, took a quick look at them, and noticed some quirks. The first one was that setting the user agent was causing some… unexpected problems. I can't personally explain this because I lack the knowledge, but if someone can, I'd be pretty happy to hear an explanation. Other than that, tinyurl was *sometimes* redirecting us using meta-tags, so now I'm always checking for those.

Please test and let me know if it works.

Note that a reboot is not required.
[Xposed Framework Modules] theknut:
Quick question: how can you update a module without rebooting?

Edit: Sweet, this fixed the tinyurl problem I reported some days ago! Good job!

Edit 2: did you only update the app part and not the module path? That's why we don't need a reboot?
[Xposed Framework Modules] GermainZ:
Yes, the URL unshortening is done by the app itself. The Xposed module only "redirects" the intent in that case so that it opens with our own activity.
[Xposed Framework Modules] ccav2000:
New version seems to work better, just not sure how it's supposed to behave with unknown shorteners, many of the twitter t.co urls resolve to another short url that is usually site specific and so unknown to CrappaLinks. Does CrappaLinks try to resolve even that with the checkbox "resolve all URLs" enabled? Because it does not seem to do so if that is the case.
[Xposed Framework Modules] GermainZ:
Yes. If "Resolve all URLs" is checked, it will keep going as long as a redirect is detected (usually a 3xx response.) If it doesn't, please give a specific example.
[Xposed Framework Modules] ccav2000:
Here's one: http://t.co/BG5sjybyRT resolves to http://nyti.ms/1kQNXxw which in turn resolves to http://www.nytimes.com/2014/05/09/o...-love-their-children-too.html?smid=tw-nytimes but Crappalinks stops at http://nyti.ms/1kQNXxw and opens that in the browser.

---------- Post added at 11:33 AM ---------- Previous post was at 11:24 AM ----------

Ok, now it's even worse, won't open any link at all. I'm suspecting something's get stuck on a loop with such URLs. I cannot get logcat currently, I'm stuck at work, not a good place to debug things.
[Xposed Framework Modules] GermainZ:
That's because the nytimes kept redirecting us:

http://www.nytimes.com/2014/05/09/opinion/druckerman-the-russians-love-their-children-too.html?smid=tw-nytimes
-> http://mobile.nytimes.com/redirect?to-mobile=http%3A%2F%2Fwww.nytimes.com%2F2014%2F05%2F09%2Fopinion%2Fdruckerman-the-russians-love-their-children-too.html%3Fsmid%3Dtw-nytimes%26_r%3D0%26referrer%3D
-> http://www.nytimes.com/glogin?mobile=1&URI=http%3A%2F%2Fmobile.nytimes.com%2Fredirect%3Fto-mobile%3Dhttp%253A%252F%252Fwww.nytimes.com%252F2014%252F05%252F09%252Fopinion%252Fdruckerman-the-russians-love-their-children-too.html%253Fsmid%253Dtw-nytimes%2526_r%253D0%2526referrer%253D
-> http://mobile.nytimes.com/redirect?to-mobile=http%3A%2F%2Fwww.nytimes.com%2F2014%2F05%2F09%2Fopinion%2Fdruckerman-the-russians-love-their-children-too.html%3Fsmid%3Dtw-nytimes%26_r%3D0%26referrer%3D
etc

… this is because it relies on cookies as well, so this build should fix that by enabling the cookie manager.
[Xposed Framework Modules] ccav2000:
Ok, the fixed version works for me, thank you! I'll keep reporting any quirks I may discover.
[Xposed Framework Modules] dimm0k:
still having conflicting issues with "Complete Action Plus" module. noticed that I'm asked what app I want to open the link with twice before device actually opens the link. CrappaLinks never shows itself.
[Xposed Framework Modules] GermainZ:
Is that only with shortened URLs? Here's what happens in that case:

CrappaLinks redirects the original intent to open directly with a CrappaLinks activity;

CrappaLinks unshortens the URL in the background;

Once unshortened, CrappaLinks sends another intent to view the URL.

Now, the only part where Xposed comes in is the first point. Even there, I do not replace any method or do anything that should affect any other modules. While I can't reproduce your issue (I use Complete Action Plus as well,) I can't see how it could conflict either. If it is, however, I can't do anything on my end because I don't see how it's a problem with CrappaLinks.

EDIT: I'd double check that CrappaLinks works fine with Complete Action Plus disabled.
[Xposed Framework Modules] dimm0k:
sorry, I should have done that in the first place to narrow down the cause. unfortunately I've disabled Complete Action Plus and tried the tinyurl listed in the first page and I'm still given the dialog to open up the link in either Chrome, Youtube, or Internet twice before whatever choice I make opens up the link.
[Xposed Framework Modules] GermainZ:
So obviously, it's not Complete Action Plus. ;) Assuming this problem only occurs with shortened URLs and CrappaLinks, I'd try disabling all the other modules as well (only leave CrappaLinks enabled.)
[Xposed Framework Modules] dimm0k:
wow, just did as you asked and MAN is my device ugly/bloated looking with all the modules I had disabled! unfortunately it is still asking me twice before opening up. here's something else I noticed. clicking http://nyti.ms/1kQNXxw as posted by ccav2000 and no double asking with that link, but CrappaLinks doesn't do anything as I see that shortened link in the URL. clicking on the tinyurl in the first post I do get the double asking.
[Xposed Framework Modules] egingell:
I don't understand why web devs think they need to redirect 10 times.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] moterbbb:
2.4 version has something wrong. when unshorten twitter links . it still is t.co not the real link... It's not better than the last version.
[Xposed Framework Modules] GermainZ:
Read the OP, please. I need specific examples. Also try the build posted a few posts above and see if that fixes your issue.
[Xposed Framework Modules] dimm0k:
any luck narrowing down my issue? it's like CrappaLinks isn't even called, but it is enabled in Xposed Installer
[Xposed Framework Modules] GermainZ:
Which issue? If it's CrappaLinks apparently getting called twice/getting stuck, I'm probably going to send you a build with debug logging. I just haven't had the time to do that yet.

(Also, you've attached the BBS log, not the Xposed log :p)
[Xposed Framework Modules] an0n981:
Which BTW looks pretty good
[Xposed Framework Modules] jugg1es:
[MENTION=4775688]GermainZ[/MENTION], been using the tapacrap beta and the update seems to have broken your module

pastebin.com/MqisA9Xi

the difference between bravery and foolhardiness is in the outcome
[Xposed Framework Modules] GermainZ:
I'm going to need an example (obfuscated link and what it should open instead) since the module is not crashing - TapaTalk is probably obfuscating URLs differently. See the OP for more details.
[Xposed Framework Modules] nein7three:
I'm having a problem now that is like I don't even have Crappalinks installed. Ex: I click a link in XDA for a Play Store app and it opens up my browser instead of the Play app.
[Xposed Framework Modules] GermainZ:
Read the post just above yours or the OP.
[Xposed Framework Modules] ashvay:
similar module as browser extension...?

hi all,

this is such a great module, I wish I had it on my computer browser...!

does anyone have any idea whether such a browser extension exist? I'm using Safari on OSX, so preferably an extension for that browser :)

tried looking for it on Google, but not sure about proper keywords to use for this ...

cheers
[Xposed Framework Modules] vNa5h:
Does this support adlfy links

Sent from THE motog
[Xposed Framework Modules] egingell:
There's a handy list in the OP.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] vNa5h:
My bad I read the ones inside the spoilers.. But failed to read the underlined text

Sent from THE motog
[Xposed Framework Modules] GermainZ:
Uploaded the build posted a few days back to the Xposed repo (v2.5.)

Changes:

(dimm0k: I'll PM you a test build when I get some time to try and figure out what your problem is.)
[Xposed Framework Modules] Riekr:
Can you add pt.tapatalk.com as was link.tapatalk. com? They updated Tapatalk today..

Inviato dal mio Nexus 5 utilizzando Tapatalk
[Xposed Framework Modules] GermainZ:
This is the third time someone asks about TapaTalk, hopefully I'll get a reply back this time. I need the exact example - what's supposed to open, and what's opening instead? More info in the OP, so read that.
[Xposed Framework Modules] Riekr:
Sorry for double posting, I'll try to intercept the link with burp but meanwhile if someone has the opportunity to check can simply click the example in op from Tapatalk

Inviato dal mio Nexus 5 utilizzando Tapatalk
[Xposed Framework Modules] GermainZ:
I haven't received the update yet. You can send me the APK if you want and I'll do it myself. ;)
[Xposed Framework Modules] GermainZ:
Thanks, that's exactly what I need. Please try the attached build.
[Xposed Framework Modules] Riekr:
Yeah it works now :)

another problem that was there on previous version of tapatalk ant crappalinks is that when i open the link from http://xdaforums.com/showpost.php?p=50340224&postcount=186

http://m.facebook.com/l.php?q=www.xda-developers.com

tapatalk crashes without making any request at all (i have official fb app installed), is it a known problem? :o
[Xposed Framework Modules] GermainZ:
Ah, that's because it should be "l.php?u=…" - it was causing an infinite loop. :p It'll be fixed in the next version, thanks for reporting.