yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] toxic-hero:
hi, crappalinks 2.0 is causing apex launcher to freeze when i click on a www shortcut on my homescreen. when i disable it the problem cease. i also couldn't reinstall the previous version over 2.0, i had to uninstall it first.

HTC one SV, android 4.2.2, Firefox browser.

log: http://hastebin.com/qifihivena.avrasm
[Xposed Framework Modules] Cyclu:
How test that "work across the system"?
[Xposed Framework Modules] GermainZ:
The log shows nothing related to CrappaLinks, please upload an unfiltered logcat.

Also, I can't reproduce this. Does it happen to all URLs?

Android doesn't allow you to downgrade apps without uninstalling, that's normal.
[Xposed Framework Modules] toxic-hero:
i installed 2.0 again and did more testing. it ONLY happens with facebook url shortcut.

edit: just sent you logcat on pm.
[Xposed Framework Modules] GermainZ:
I'm only checking the host to determine of it's masked or not (infinite loop, yay,) when I should be checking a bit more. I'll get it sorted as soon as possible. Thanks a lot. :)

EDIT:

Update:
[Xposed Framework Modules] jacknicholson:
Incredibly inconsequential: Just a heads up, unless someone can confirm if it's just me-- I've noticed that both CrappaLinks and ActivityForceNewTask are showing incorrect update dates in the Installer repo. Other modules (installed or otherwise) seem to be listed correctly.
[Xposed Framework Modules] GermainZ:
I've reported this in the Xposed Framework thread here.
[Xposed Framework Modules] bberryhill0:
Are you saying that it should work on custom Tapatalk apps? The Old Row app still goes through viglink.

Swyped from my Verizon LG G2 using Tapatalk 4.4.9
[Xposed Framework Modules] GermainZ:
It works for supported URLs (I'll add those to the OP later,) for all apps. Read the OP if you want to request something. :)
[Xposed Framework Modules] bberryhill0:
There are hundreds of custom (BYO) Tapatalk apps so it doesn't make sense to support them individually. I was just curious what you meant by system wide.

Swyped from my Verizon LG G2 using Tapatalk 4.4.9
[Xposed Framework Modules] s3icc0:
Hi I read in latest changelog infinite loop fixed but not for me. ... still getting into infinite loops with aosp browser and chrome (slimroms.net weekly download links not working for me)
[Xposed Framework Modules] GermainZ:
I don't think this is related to CrappaLinks, as it won't affect browsers (it will modify links *before* they're opened in your browser, though.)

That being said, does it work if you disable this module? How can I reproduce it? For what links does it happen? Etc.
[Xposed Framework Modules] Cyclu:
I ask the same question.;)
[Xposed Framework Modules] earth08:
Whenever I want open any downloaded apk or ear files it shows ne 2 optionib popup

1 an money

2 Norton web browser.

Is there anyone with this.

Pls guide me to fix this
[Xposed Framework Modules] GermainZ:
This isn't related to this module. Ask elsewhere, in the Android Q&A forum, for example.

Was the post he quoted clear enough? Also read the few posts above please.
[Xposed Framework Modules] defim:
[MENTION=4775688]GermainZ[/MENTION]:

With version 2.x this app unusable: https://play.google.com/store/apps/details?id=de.heise.android.heiseonlineapp

It opens everything in Chrome, insted inside the app.

Additionally downloads (like with the Xposed installer) take a long time to start.

Back @ 1.7.2 and everything works fine
[Xposed Framework Modules] GermainZ:
I get the same behavior with the module enabled or disabled. Clicking on an article opens it inside the app, clicking on a link inside the article opens it with a browser.

CrappaLinks doesn't even touch that. I've double checked both the code and added logging as well to make sure, the hook isn't triggered at all in these cases.
[Xposed Framework Modules] defim:
I have even different baheviour with 1.7 and 2.0 of Crappalinks installed...

So on the main page, after you selected a category, you see a list of news. And a touch an any of these news shows it inside the app for you? Very odd

Oh, i thought Crappalink inspect alls URLs. Maybe another problem, webserver or so
[Xposed Framework Modules] GermainZ:
Ah, I can see what the problem is now. I'm using Intent.setData(Uri data) which clears the intent's type, and heise online is using a weird way to open articles internally. I'll push a fix as soon as I can.
[Xposed Framework Modules] defim:
Great that you found it!

The "heise" app is not updated often, but it's better than using the website itself ^^
[Xposed Framework Modules] GermainZ:
Update:
[Xposed Framework Modules] Bajanman:
Thanks for the update was having some issues with Dolphin browser watching some videos. Where it would bring up the browser's to watch on instead of my video app's.[emoji726] After the update its back working the way is was...

Thank you thank you[emoji106][emoji106][emoji106]
[Xposed Framework Modules] CatsAreGods:
Speaking of updates, this module's changes aren't showing up properly in Xposed app. I have to keep scrolling back to February to find it for some reason. FYI.
[Xposed Framework Modules] jacknicholson:
It appears to be a repo-wide issue; GermainZ has already informed rovo89.
[Xposed Framework Modules] CatsAreGods:
Thanks for the update. This is the only module I've seen this happen with, so I thought it was something here.
[Xposed Framework Modules] MikaelFolkesson:
It could be worthwhile mentioning that this app only affects tapatalk, already in the brief description of the app when you are about to download it, now it seems like it's a system wide thing. Had to go to this thread and search to find out.
[Xposed Framework Modules] egingell:
By that do you mean only links in Tapatalk are unmasked? Because I'm pretty sure that's not true. It also affects Facebook, the Play Store, and a few other apps. Check the change-log.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] s3icc0:
Strange - but after disabling Crappa links my download started immediatelly.

Steps to reproduce: Open Chrome beta browser - go to www.slimroms.net into any download section and try to download a ROM zip. New windows with the same link to the file keeps openning. Then disable Crappa and repeat.

Now I have Crappa disabled and I don't have the problem.
[Xposed Framework Modules] Bajanman:
I was having issues with the older version not letting me play my videos on dolphin browser. But after the update everything works on my end...

---------- Post added at 08:18 AM ---------- Previous post was at 07:58 AM ----------

@GermainZ

I get these apps sent to me thru email from Appgratis...

But when I check on the link it goes to something else. Instead of straight to the play store.

Here the original link»»»

http://affiliation.appgratuites-net...ratis_Emailing_en&su=7bUQXSsJRkY7qNY2qKZLgmaQ

Where it's suppose to go here»»»»

https://play.google.com/store/apps/....forestpondfree&referrer=utm_source=appgratis

This^^^^ is the free app that the link is suppose to go to. Can you check it whenever you have time...

Thanx
[Xposed Framework Modules] GermainZ:
I tried a few and I don't get any zips, only JDownloader files. I don't want to search them all so if you could just give me a direct link it'd be easier for all of us. Also make sure you tried the latest version (that's 2.0.2.) :)

It's not only for the Play Store so I can't unmask it directly by taking the package name, but I can add that as a shortened URL and CrappaLinks will unshorten it if that option is enabled.
[Xposed Framework Modules] defim:
This is the same like http://xdaforums.com/showpost.php?p=51230991&postcount=131, but now in the correct thread

[MENTION=4775688]GermainZ[/MENTION]: Another minor thing: The app shows in the recent list after it did his work, see attached screenshot. Maybe this in the Manifest helps (i've not read you source, if available)

android:theme="@android:style/Theme.NoDisplay"
android:excludeFromRecents="true" >
[Xposed Framework Modules] GermainZ:
It was in the right thread, actually. I already have that in the manifest and it works as expected, but ActivityForceNewTask is causing the problem. ;)
[Xposed Framework Modules] defim:
:D I thought the cause was the un-shorten feature of CrappaLinks (if you want, delete the above posts)
[Xposed Framework Modules] SolidSnake33:
So, wait...What does this module do?

Sent from my Slim Galaxy S3

SlimKat 4.4.2
[Xposed Framework Modules] egingell:
The OP is very detailed.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] pitastrudl:
Turns all the links into snakes, that slowly devour your phone.
[Xposed Framework Modules] SolidSnake33:
That's what I thought.

Sent from my Slim Galaxy S3

SlimKat 4.4.2
[Xposed Framework Modules] GermainZ:
I've added a link to a detailed example in the Introduction of the OP since an increasing amount of people can't seem to understand the current OP. :)

That was a bug, I think it got fixed in 1.5.
[Xposed Framework Modules] SolidSnake33:
Not detailed enough for non nerds.

Sent from my Slim Galaxy S3

SlimKat 4.4.2
[Xposed Framework Modules] pitastrudl:
[MENTION=4775688]GermainZ[/MENTION] , i think you should enlarge a little bit and put in red this part of the OP: . As you can see, some "non-nerds" cannot understand/read the OP :):
[Xposed Framework Modules] GermainZ:
While I don't think you need a nerd to understand it, that part was added after he asked so he couldn't have seen it.
[Xposed Framework Modules] pitastrudl:
I see, even though the linked post is from 15th february. Well better now than never.
[Xposed Framework Modules] Cyclu:
Here CrappaLinks in action: the shortened link from OP opened with Xda Priemum application! [MENTION=4775688]GermainZ[/MENTION] you can add this screenshot to OP if you want.

Hope this help the peoples to understand how CrappaLinks works.
[Xposed Framework Modules] Crime_Monkey:
[MENTION=4775688]GermainZ[/MENTION]

Since I updated to version 2.0/2.2, the module crashes every time I want to click a link. Is this a bug or because of my other installed modules?

List of installed Modules:

BootManager

Chrome new tab

CrappaLinks

GravityBox

Instagram Downloader

Notification Mod

PeerBlock

Play Store link in app info

TickerToast

Tinted Status Bar

Translucent Recent

Unicon

Wanam Kit

XBlast

X Force enter

Xhalo floating window

Xposed GEL settings

Xui mod

And I'm on Nexus4 with Franco kernel, and stock 4.4.2 rom
[Xposed Framework Modules] GermainZ:
Logcat?
[Xposed Framework Modules] Crime_Monkey:
I asked on google+ community, no problem anymore :D

Thanks anyways :D
[Xposed Framework Modules] GermainZ:
What was the problem/what Google+ community?
[Xposed Framework Modules] Crime_Monkey:
I meant the XDA G+ community, I posted the same text like here.
[Xposed Framework Modules] GermainZ:
So what was the problem?
[Xposed Framework Modules] Crime_Monkey:
I meant that CrappaLinks crashes every time I click a link.
[Xposed Framework Modules] GermainZ:
Yes, I got that part already. How did you solve it? What was causing the problem?
[Xposed Framework Modules] Crime_Monkey:
I simply wiped dalvik cache
[Xposed Framework Modules] wilflare:
[MENTION=4775688]GermainZ[/MENTION]

Crappalink seems to conflict with Link Bubble :/

https://play.google.com/store/apps/details?id=com.linkbubble.playstore
[Xposed Framework Modules] Pons:
I have both working fine. Crappalinks unshortens the url, then passes it to whatever you have to open as default. For instance, a Google+ bitly will unshorten, then pass to Google+ app (if you haven't touched the Link Bubble settings), while a Google bit.ly will go to Link Bubble.

Care to explain how to replicate your issue, and provide a logcat? Also, have you cleared your browser's defaults?
[Xposed Framework Modules] wilflare:
apologies. I seem to have misunderstood how Link Bubble work (I thought Link Bubble would preload Instagram/YouTube in the background.. and not in WebView)
[Xposed Framework Modules] Cyclu:
[MENTION=4775688]GermainZ[/MENTION] Since version 2.0.2 click a link open directly my browser with no unshortened address web also no toast and sometime the dialog to open YouTube or Browser has trouble to appears I must refresh the web page. I have reinstalled the version 1.7.2 which work perfect.
[Xposed Framework Modules] GermainZ:
In which app? What link?
[Xposed Framework Modules] Pons:
Got a shortened link and app that you have this problem with? A logcat couldn't hurt. 2.0.2 works so far for me against everything I've thrown at it.
[Xposed Framework Modules] Cyclu:
I always test first with the link from OP (YouTube) with Xda Premium I have tried also with the links on Play Store like in the Wakelock Detector OP the same behavior happened.

I'll try to capture a logcat.
[Xposed Framework Modules] GermainZ:
Make sure you have URL unshortening enabled in the settings, too.
[Xposed Framework Modules] Cyclu:
Okay I always have enabled this setting I tried disable then enable it and also tried different toast settings without success.
[Xposed Framework Modules] GermainZ:
Make sure the module is loading correctly and not crashing (check the Xposed Installer log as well as the logcat.)
[Xposed Framework Modules] Cyclu:
I took the logcat after opened the link (Youtube) in OP with Xda Premium and redirected to the browser (screenshots attached)

module is loading correctly not trace of error in the Xposed log. Hope this help;)
[Xposed Framework Modules] GermainZ:
Looks like the URL simply isn't supported. What's the URL that is opening, and what should be opening instead?
[Xposed Framework Modules] Cyclu:
It open my browser URL is apicdn.viglink.com/api/click etc. instead what you can see in the attached screenshot

the opened link is Youtube in OP that is how is worked with version 1.7.2..
[Xposed Framework Modules] GermainZ:
I need the full link. See OP for example.
[Xposed Framework Modules] Cyclu:
http://apicdn.viglink.com/api/click?key=null&out=http://bit.ly/1gf00Wo&loc=http://xdaforums.com
[Xposed Framework Modules] wilflare:
is there a way to make facebook links (from WhatsApp convos, etc) open up in facebook?
[Xposed Framework Modules] GermainZ:
Read the OP, I don't use Facebook so I'm going to need more info.
[Xposed Framework Modules] wilflare:
my apologies! the think is WhatsApp doesn't mask/track/shorten the link in anyway... but for some reason, the facebook link just opens in my browser. is this a limitation of the facebook app (no intent filter?) and thus this module would not be able to do anything for it?
[Xposed Framework Modules] GermainZ:
Yeah, looks like the Facebook app can't handle the URL, sorry.
[Xposed Framework Modules] Cyclu:
[MENTION=4775688]GermainZ[/MENTION] I have a suggestion don't know if is possible I will try explain with my bad English.

When I open a shortened link which is opened only in the browser is possible to have a dialog to allow/deny open a link.
[Xposed Framework Modules] GermainZ:
So something like the following? Tap shortened URL -> CrappaLinks unshortens -> CrappaLinks shows you a dialog asking if you want to open the link -> If you answer yes, the intent is sent.
[Xposed Framework Modules] wilflare:
bummed but thanks for this module :D it really solves the problems I have with Tapa, Google and etc :D
[Xposed Framework Modules] Cyclu:
Yes exactly so it's possible that you can add this future?
[Xposed Framework Modules] GermainZ:
Yes, that is possible. :)
[Xposed Framework Modules] GR0S:
Please add progress box while unshorting, sometimes I open 10 tabs in chrome
[Xposed Framework Modules] Cyclu:
I call it great news!:good: Thanks! I wish nice week for you and good continuation.
[Xposed Framework Modules] lenthele:
When clicking a link in the official Twitter app I often get an error message saying that there is no network Connection. Like shown in the screenshot. It happens every time when I click on a shortened URL by SPIEGEL ONLINE (Spiegel.de)....

Gesendet von meinem HTC One X mit Tapatalk
[Xposed Framework Modules] GermainZ:
I'm going to need the full URL and a logcat, please.

I'm not sure what that means. A blocking progress dialog would be a bad idea since you'd be forced to wait for CrappaLinks to finish unshortening.
[Xposed Framework Modules] GR0S:
Well, if network connection isn't good enough, it takes about 5 seconds to gunshot link. In this time, apps look crashed or like you mis tapped link.
[Xposed Framework Modules] GermainZ:
You should be able to continue using the app normally while the link is being unshortened.
[Xposed Framework Modules] lenthele:
Shortened URL: http://spon.de/aecrs

Full URL: http://www.spiegel.de/auto/aktuell...ne-zulassungsstelle-einfuehren-a-962072.html

Logcat: http://www.pastebin.com/YPuWuxnd

It seems to me that CrappaLinks unshortens the url correctly but then breaks the link by removing the "prefix" http://www.spiegel.de.

Android tries to open the link without the "prefix" (just the part after the "main url") and of course throws an exception.

Gesendet von meinem HTC One X mit Tapatalk
[Xposed Framework Modules] Blizzard22:
Also here is my log from Xposed framework.

http://pastebin.com/vbL5Y7ZU
[Xposed Framework Modules] earth08:
How to short adfly?
[Xposed Framework Modules] GermainZ:
Update:

This should fix the issues reported in the above posts. :)
[Xposed Framework Modules] Bajanman:
[MENTION=4775688]GermainZ[/MENTION]

Thanks very much for the recent update bro...[emoji106][emoji106]
[Xposed Framework Modules] Anderson2:
I have crappalinks installed on my Nexus 5 and have 2 questions :

1. Even though it is installed and rebooted I cannot find its shortcut to modify it's settings? Does it have a desktop shortcut like other Xposed modules (Xgravity, Xprivacy, etc.) ?

2. Is the installation of Crappalinks the reason why when using Tapatalk I get an alert that YouTube has stopped? If so, can I stop that alert without uninstalling YouTube?

Thanks.
[Xposed Framework Modules] GermainZ:
It does. You might have hidden it, though. You can always open the settings from the Xposed Installer > Modules > CrappaLinks.

I don't know what that is. Does it happen when opening a link from TapaTalk?
[Xposed Framework Modules] Anderson2:
Thank you.

Don't know how it happened but the icon was hidden. I unhid it and now can see it.

The YouTube alert happen when I send a reply in Tapatalk.
[Xposed Framework Modules] GermainZ:
Shouldn't be caused by CrappaLinks. Does it happen if CrappaLinks is disabled? If so, then it's caused by something else. ;)
[Xposed Framework Modules] _jis_:
What version of Tapatalk and Youtube do you have installed?
[Xposed Framework Modules] Anderson2:
Tapatalk ver 2.4.15 (to avoid the url redirections)

YouTube 5.5.27

I disabled crappalinks, rebooted, but the YouTube alert still appeared when I clicked on submit within Tapatalk. So it is not caused by Crappalinks. Only happens in Tapatalk. Wonder what the link is between Tapatalk and YouTube?
[Xposed Framework Modules] GR0S:
Anyway you should add user feedback while unshortener runs.
[Xposed Framework Modules] _jis_:
I asked you with the reason, because I noticed this bug between these two apps too. It is Tapatalk 2.4.15 and YouTube. It started after YouTube was updated to 5.5.27.

It has nothing common with Xposed nor any Xposed module at all.

How I can invoke this error:

Start Tapatalk and open any post which contain any link inside.

Click on this link.

Dialog "Complete action using" opens, you can even select no app here, just press Back.

After a few seconds another dialog is displayed: "Unfortunately, YouTube has stopped. Report/OK"

You can press Report or OK button.

After a few seconds another dialog is displayed: "Unfortunately, Tapatalk has stopped. OK"

You can press OK button or Back.

I think that the culprit is embedded YouTube player support in Tapatalk and because this version of Tapatalk in not updated anymore, this part of code has some problem with the latest YouTube update. Thank you for opening this, I see that I am not alone with it, so I could report this problem in Tapatalk forum now.
[Xposed Framework Modules] Cyclu:
With latest version 2.1 when I want open the youtube link in OP with XDA Premium:

Shortened link http://bit.ly/1gf00Wo

Redirection link http://apicdn.viglink.com/api/click?key=null&out=http://bit.ly/1gf00Wo&loc=http://xdaforums.com

http://www.youtube.com/watch?v=dQw4w9WgXcQ

I have the confirmation dialog but nothing happens when I press Yes button and the toast "An error has occurred...appears " first screenshot.

press the back button I get only these dialog "CrappaLinks" second screenshot.

I have enabled Shortened URLs Confirmation and to be sure I have rebooted after change.

Logcat attached.

I have tried to open in my browser two additional links in WakeLock Detector OP on Play Store:

First link is "Full list of change-log:

Shortened link http://bit.ly/19DzL4L

Redirection link https://www.google.com/url?q=http://bit.ly/19DzL4L&sa=D&usg=AFQjCNFWsXLXQJ6Za5EqN6Np2sySva67WQ

Opened link in browser https://docs.google.com/document/d/1eatTvA_mSaN2Nljq7i_Qy-5gfDtkOi5QiYY5QHUga84/edit

Second is "Manual for WD":

Shortened link http://goo.gl/l4bzH1

Redirection link https://www.google.com/url?q=http://goo.gl/l4bzH1&sa=D&usg=AFQjCNERjEV2mAGKAeAyw1riJZDL24RPUg

Opened link in browser http://www.slideshare.net/ahikmat1/manual-for-wakelock-detector

Here I don't have the dialog or toast the link is opened in browser the redirection links come from XPrivacy (of course android.intent.action.VIEW is unrestricted) because the address appears in browser very furtively I found nothing in the logcat for these links.
[Xposed Framework Modules] GermainZ:
Looks like CrappaLink can't connect to the internet (at least not to bit.ly,) check your firewall/XPrivacy/hosts/whatever might be affecting this. At least that's what I can see from the logcat (also, it works fine for me for the links you posted.)

Thanks, that will be fixed.
[Xposed Framework Modules] Cyclu:
Bingo! I have allowed CrappaLinks in AFWall+ it works perfectly now.

It's strange because it worked great with bit.ly and ver. 1.7.2. without Internet.

It's impossible that's works without allowing access to Internet?

For the two other links (fortunately I have checked with the posted url) yes it works but only when I open these links in Xda Premium application but I don't have the confirmation dialog and the toast message when opened these links on Play Store.
[Xposed Framework Modules] GermainZ:
That'll also be fixed in the next version.

1.7 was unshortening URLs inside the hooked app itself, so it used the hooked app's permissions. This would of course fail for apps that can display/open URLs without needing a connecting themselves.

Starting 2.0, URLs are unshortened by CrappaLinks itself, so it needs to connect to the Internet directly.

It's impossible to unshorten URLs without an Internet connection since there simply is no pattern.
[Xposed Framework Modules] Cyclu:
Thank you for all! I'm always glad to contribute to any security and privacy project it should be our priority. I appreciate your works and I read most often your post's here and Xposed thread with great interest.;)

I would can paid/donate but for this maybe you can make an Pro/Donate version to Play Store I don't have other possibility for now.
[Xposed Framework Modules] GermainZ:
Thanks a lot, but I don't take donations ?
[Xposed Framework Modules] k2thec:
I commend you for this unusual behavior!
[Xposed Framework Modules] theknut:
Hi Dev,

I saw your module on Xposed Tuesday! I treid it but its not works :(

I tried clearing cache and rebooted a couple of times but no success.

Attached is a logcat. Please halp!

Thanks you very much for your hard work!

-------------------------------------------------

:good::good::good::good: HIT THANKS IF I HELPED YOU :good::good::good::good:
[Xposed Framework Modules] egingell:
There is literally nothing in that log file.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] GermainZ:
I believe thatsthejoke.jpg :p
[Xposed Framework Modules] egingell:
Jokes are supposed to be funny.

Sent from: SGS2 - JB 4.1.2 GB27 / SGS4 - JB 4.2.2 MF9
[Xposed Framework Modules] theknut:
We've just been talking about this module being on Xposed Tuesday.

I'm breaking the ice...