yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] p.valenta:
Version 1.6.1 released

- Let's try now if left & right area got removed.

- Colors are holo dark now (background, textcolor)

- Title fixed to blue color

Take it from Xposed Repository first and let me know.
[Xposed Framework Modules] xPr0metheus:
Looks great now! :)

Can you make different title colors for the different themes? I would like to have black on white and white on black. If that's not possible it's fine as it is now :)

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] p.valenta:
Version 1.6.2 released

Changelog

- Title color changed to white on black (darker white and lighter black as holo dark) and black on white
[Xposed Framework Modules] _jis_:
Version 1.6.2 looks beautifully on SGNII. One nitpick: I am missing pitch black background from previous version.
[Xposed Framework Modules] p.valenta:
Any feedback for latest 1.6.2 ?
[Xposed Framework Modules] xPr0metheus:
Yes it looks awesome now :) thanks!

Another request: can you also apply all the settings to the share menu (gallery for example):

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] igresso:
On light layout theme check box still in black ..

تم الإرسال من جهازي GT-I9305 بواسطة تاباتوك 2
[Xposed Framework Modules] _jis_:
It is impossible, because some devs/apps aren't use system opening/sharing methods. See this post.
[Xposed Framework Modules] xPr0metheus:
Hmmmm... when did the time end android was fully customizable? :(

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] _jis_:
This mod is hacking system wide opening and sharing method. It is very difficult nearly impossible to hack every app which is using own proprietary methods. Examples: Samsung Gallery, QuickPic, ...
[Xposed Framework Modules] osama-selo:
After testing the new version here is my feedback:

1- The wrench icon now is displayed, so I can access the apps list :sly:

2- Layout is still not changing.

3- XHalo is now working when longpress.

4- Layout theme changes only the title color (anyway I like the default HTC)

5- Always & just once options as greyed out, so I can't select them.

6- When I tried now to attach screenshot there was 2 dialogues to select the app.

Here is my log:

https://www.dropbox.com/s/pbgu82ovegpaoie/debug.log
[Xposed Framework Modules] Scorp123:
So is there anyway to get the Samsung gallery share menu customized? I've read about it being app specific and that's the only part not working perfectly for me.
[Xposed Framework Modules] Ninolina:
[MENTION=489665]p.valenta[/MENTION],

great mod. :) Thanks for it. :) Can you please add option to choose text color? :)

Thanks in advance. :)
[Xposed Framework Modules] xPr0metheus:
Strange that it works for youtube share feature:

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] p.valenta:
Apps which use system "open" & "share" dialogs are fine. Apps which have own implementation not. :(

I got emails asking me to include Phone app. There is similar dialog when contact have more than one telephone number. This part should be common to all devices so I'm going to make this in later versions (not next, but later after system part is done enough).

Samsung TouchWiz users,

Can you check for me if this is happen on your devices as well that Gallery app share doesn't get modified? Or it happen only on Note3?

I could take a look later after Phone app. I don't want to promise anything as it's Samsung closed source and I might be not able to modify it as much I did for system dialog. I will know more after checking it's decompiled apk.

In any case there must be a border line which this mod will not pass. I'm thinking of keeping it to

stock only dialogs

. Android system and android default stock apps.
[Xposed Framework Modules] xPr0metheus:
I am surprised that they use different dialogues. I always thought there is one dialogue popup with just different texts in it.

Another screen: (facebook on chrome)

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] p.valenta:
This will be the best. :)

But looks like more developers don't like default stock dialogs behaviour, so they implemented it by own. They use same style, so it looks same, but it's code and resources are inside their apk. This is why this mod doesn't see it and modify it.
[Xposed Framework Modules] p.valenta:
I guess pink color, right? :)

Maybe I could make "Custom" theme choice and then there will be choices where users can select own color for background and own color for text.
[Xposed Framework Modules] p.valenta:
What is your device?

I would like to know if this is common for other than Note 3 device.
[Xposed Framework Modules] p.valenta:
2) This is weird. I will look more into decompiled HTC framework.

4) Yeah, related to (2). Resources not got replaced.

5) Yep, (2).

6) This is strange, two times? After first one is finished another one appear?
[Xposed Framework Modules] Scorp123:
I'm on a Verizon Galaxy S4 Android 4.3
[Xposed Framework Modules] Ninolina:
;) That was "hard" to guess. :)

The "custom theme choice" would be the best! :)

Thank you...:)
[Xposed Framework Modules] osama-selo:
Yes tapatalk displayed the first dialogue as in first screenshot & then after I have chosed the gallery app another dialogue has appeared as in second screenshot :what:
[Xposed Framework Modules] igresso:
Not modify here galaxy s3 lte !!
[Xposed Framework Modules] wilco375:
I wanna be able to always open my yt download app if I click the share button in my yt app.
[Xposed Framework Modules] _jis_:
Built in Gallery has own sharing dialog in Note 2 too. It'll be probably the same in Samsung Galaxy devices at least.
[Xposed Framework Modules] osama-selo:
I can confirm this also on my wife's device Samsung Galaxy S2
[Xposed Framework Modules] p.valenta:
Version 1.6.3 released

Changelog:

- Fixed missing applied theme to title when "Manage List of Apps" is uncheck. (Samsung users, please confirm. I hope no left & right gaps)

- Another HTC fixing. ( [MENTION=4694552]osama-selo[/MENTION] please check )

Only bug fix version, no new stuff.

Available by Xposed Repository, OP and Google Play.
[Xposed Framework Modules] igresso:
Always check box in light layout theme still in black ! ..

Also "manage list of app" in app dark theme & light layout theme
[Xposed Framework Modules] p.valenta:
Yes, That checkbox I need to replace image for it.

Manage Layout is fine except that warning text. I think I will adjust colors little bit better. :)
[Xposed Framework Modules] _jis_:
This warning text is not needed there anymore, because you add program check for at least 2 apps with toast message with this warning text. Less is more :)
[Xposed Framework Modules] p.valenta:
Yes, you are right. :)
[Xposed Framework Modules] osama-selo:
Test share button: complete action plus has stopped.

Test open button: unfortunately Android system has stopped.

I think u need logcat now not Xposed log, right?
[Xposed Framework Modules] p.valenta:
yes, but better both. thanks. :(

Edit: Looks like resources got finally replaced, but I will need to add your extra HTC stuff so original method will not crash.
[Xposed Framework Modules] osama-selo:
Anyway here are them:

https://www.dropbox.com/s/pt8v5fgh7u2o9nr/alogcat.2014-02-17-19-26-35+0200.txt

https://www.dropbox.com/s/49wwg1f742c77xq/xposed_debug_20140217_192306.log

Thanks ;)
[Xposed Framework Modules] p.valenta:
Version 1.6.4 released

Please try this new version and let me know. Xposed Repository only for the moment.

Edit: I guess "share" should work fine now, but "open" make system crash, right? If that's true, I have ready one more version.
[Xposed Framework Modules] p.valenta:
Version 1.6.5 released

Changelog:

- Fixed theme for always checkbox.

- HTC fixes as I assume 1.6.4 was not yet working fine for open dialog. ( [MENTION=4694552]osama-selo[/MENTION] please test )

Available on Xposed Repository, OP and Google Play.
[Xposed Framework Modules] igresso:
Ummm i got this qustion ..

Sorry if it can be made & late to ask ..

If i choose number of culomns 4 ..

And the pic or vid ..etc when the open dialog popup comes with like 2 or 3 apps to complete action with ..

There well be empty space on the right side ..

Can u do something with it ?

Cuz its too much empty space
[Xposed Framework Modules] Toledo_JAB:
Considering this is a general module and isn't device specific, I have moved it to the new Xposed modules forum: http://xdaforums.com/android/xposed-modules
[Xposed Framework Modules] osama-selo:
Great now it's almost working, just it needs some modifications.

Here are screenshots:

As you can see the grid view shows 3 rows instead of 3 columns & the list view icons needs to be aligned a little bit to the right.

Really great job :thumbup:
[Xposed Framework Modules] partylikeaninjastar:
Is it possible to make the icons on the grid centered when it's not a full row?
[Xposed Framework Modules] p.valenta:
I will handle it with next version. Will be fixed and centered. ;)
[Xposed Framework Modules] p.valenta:
I'm happy that it somehow works, but what I see from screenshot is trouble. It is still original List as you can

see each row line

, so it didn't get replaced to Grid. Items got replaced, so at least this is working fine. Anyway, let's see in next version tonite. :fingers-crossed:
[Xposed Framework Modules] toxic-hero:
BIG thanks, it's working now on htc one sv!!

one small visual glitch..
[Xposed Framework Modules] Walter.White:
Awesome module. Works really great on my N3 with 4.4.2

Just one feature request if possible. Import/Export Settings
[Xposed Framework Modules] p.valenta:
Hmmm, I will take a look to fix it. ;)
[Xposed Framework Modules] p.valenta:
I just wonder, you want apply same settings to different devices, right? This is the reason?
[Xposed Framework Modules] Walter.White:
Yup so that way the list for different calls (http, https etc) will be same/similar across all my devices.

And also it would be nice to see the changes I made to different calls show up in CAP app so that way I don't have to make that call again and then click the wrench to revise my changes. (I hope this makes sense).

Either way this app is freaking awesome!
[Xposed Framework Modules] p.valenta:
Version 1.6.6 released

Changelog:

- Handle case when less items than columns exist in Grid by using AOSP way to set less columns.

- Fixing HTC issues

- Fixing missing theming on List

- Better align in List

- Better align in App Settings for longer titles

- Improved code

Pending issue:

Always checkbox doesn't work on all devices when it is used together with "Manage List of Apps".
[Xposed Framework Modules] PunchUp:
When the text is hidden, the space between the rows needs to be more.. Kindly fix that :)
[Xposed Framework Modules] p.valenta:
It looks fine on my device. Anyway, I will set minimal height. ;)
[Xposed Framework Modules] osama-selo:
Now the grid layout is working perfect for the share, but for open it needs some modification as there is a lot of free space below the icons.

And also the always checkbox needs a little alignment to the right.

Thanks ;)
[Xposed Framework Modules] p.valenta:
Great! :victory:

I will take a look and fix that.
[Xposed Framework Modules] PunchUp:
Lot of free space below the icons??

Please don't remove that space. It would look very congested. I think it's spacious and good as it is now
[Xposed Framework Modules] p.valenta:
That case looks wrong. It should be set there from original list, not my grid. I guess there will be some big min. height set from HTC.

These are two different cases (yours and this one).
[Xposed Framework Modules] PunchUp:
Oh yes I'm sorry. I didn't notice his screenshot properly.. Different case :thumbup:
[Xposed Framework Modules] xPr0metheus:
First one looks beautiful *_*

The second one looks strange. Maybe you could add it as an option if we want icons centered or as it was before

(Options are always good :D)

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] p.valenta:
I don't know if anybody want to have two columns only, but maybe I could remove that choice from settings and same here don't set less than 3.

Anybody is using two columns Grid?
[Xposed Framework Modules] xPr0metheus:
hmm don't know if we mean the same. I meant an option to switch between this view

*Icon**Icon**Space**Space**Space*

*Icon**Icon**Icon**Space**Space*

*Icon**Icon**Icon**Icon**Space*

and this one

*Space**Icon**Space**Icon**Space*

*Space**Icon**Space**Icon**Space**Icon*

etc

(hope you get what I mean without screenshots :D)

Ps: I was shocked to see my first post had the one pic so small and the other so big. It looks always so clean on tapatalk
[Xposed Framework Modules] p.valenta:
ic, so between "keep same number of column with empty on right" or "auto-reduce number of columns to fit whole area". could be.
[Xposed Framework Modules] killoid:
[MENTION=489665]p.valenta[/MENTION] can we get gingerbread support for this module?
[Xposed Framework Modules] p.valenta:
I'm sorry, but I do not have in plan to support Gingerbread

at the moment

. Currently only Jelly Bean 4.1+ and KitKat are supported. I'm not saying that it cannot happen in future that I will support for 4.0+ or even 2.3+ Android version, but it will add a lot of trouble with big batch of different layouts to handle.
[Xposed Framework Modules] p.valenta:
Version 1.6.7 released

Changelog:

- Add min. height to Grid Item, so it will not get shrink when text size is 'Hidden'.

- Fixed layout height for wrap content in Grid or List layout so it should not have empty big gap below it.
[Xposed Framework Modules] osama-selo:
It's this version meant to fix my extra gap issue?
[Xposed Framework Modules] PunchUp:
Yes the second mention in the changelog is your issue. Has it been fixed now?
[Xposed Framework Modules] osama-selo:
No, as you can see the black area in the screenshot.
[Xposed Framework Modules] p.valenta:
Wow, this looks really weird. Can you try apply experimental layout change and keep List layout. Let me know if this helps as it will re-create that view from scratch.

Do you see any empty white area at the bottom where buttons should be? Or whole bottom area is cut off?
[Xposed Framework Modules] schloss:
Doesn't help. And without 'experimental' option I can't get list layout anyway.

Double checked: I have nothing messing with share menu. But I had a couple of modules in the past. Maybe that's the reason. It seems that I'm the only one facing this funny problem, so just forget about it.
[Xposed Framework Modules] igresso:
Like u read my mind ..!!

Thaaaanks for that really ..

Share works and not shown ..

openin like the pic .. action are just there not hidden like share .. but it doesn't ask me to select action .. when i select something its directly do it ..

Thanks again for ur work
[Xposed Framework Modules] p.valenta:
Hi [MENTION=432821]friguy3[/MENTION], [MENTION=4475064]schloss[/MENTION], [MENTION=5159619]igresso[/MENTION],

I made modifications and prepared test version for you guys. Please check your PM. Any feedback welcomed. :fingers-crossed:
[Xposed Framework Modules] p.valenta:
Version 1.2.2 released

Fixed alignments for experimental List layout on some devices.

Edit: Always checkbox appearance got fixed as well.
[Xposed Framework Modules] Eve_brea:
As of recently, when i hit anything that would ask me what app to use, instead this causes "Android system" to crash.

the only way to fix it is to disable this in xposed framework.
[Xposed Framework Modules] JoeFCaputo113:
Guessing this won't work on my Sprint Galaxy S4 (running a TouchWiz ROM)?!
[Xposed Framework Modules] badkill:
working perfectly on my galaxy s4 with Android 4.3 stock (TouchWiz) :D thanks
[Xposed Framework Modules] p.valenta:
Can you provide me crash log? If it crash without display anything, you can provide Xposed Log. Please go to Xposed Installer, switch to Log, click menu and there is "Send" or "Save to SD card". Thanks.

Btw. what device and what ROM are you using? (only curious)

Thanks for feedback, good to know that. :good:
[Xposed Framework Modules] Eve_brea:
blanked.
[Xposed Framework Modules] Eve_brea:
Nexus 7 2012 using stock unlocked rooted with Nova launcher

okay then. dropbox URLs it is.

https://www.dropbox.com/s/29bi37jzv8x0akh/2014-01-20-21-38-45.txt <--- Catlog log

https://www.dropbox.com/s/91sxflys6skvrlh/xposed_debug_20140120_214007.log <--- Xposed debug log
[Xposed Framework Modules] abo_mara7:
This is the first time I resisted rooting for about 3 months since purchase time. This will make me do it immidiately!

Thank you so much.
[Xposed Framework Modules] p.valenta:
Please check your PM. I send you my latest development version to test.
[Xposed Framework Modules] Eve_brea:
Well, it works when what's being opened is a picture, but in my case, where i'm scanning an NFC tag and it normally asks for Automagic OR firefox, it crashes still.

Here's my logs i took today, the final ones are what it looks like when your module is off, and the NFC tags trigger properly, for comparison.

https://www.dropbox.com/sh/dcveqc2m0ejj6ky/x3CCT9-wKR

(it's a folder of logs)

For reference, i'm also using that module that allows nfc in lockscreen (which is why i want this to pick the one i want)
[Xposed Framework Modules] p.valenta:
I see that you are using qwerty12's alternateapppicker mod at the same time. This is not good idea as his code is replacing same part of code like I do, which can results in conflicts. Please try only with my mod.
[Xposed Framework Modules] Eve_brea:
I added that recently when yours wasn't working. I'll remove it and try yours again.

Nope. "unfortunately, android system has stopped"

Gonna hit it again with catlog running so it'll add the logs to that folder (yay for dropsync!)
[Xposed Framework Modules] p.valenta:
It crash no matter if from lockscreen or after lockscreen, right?

I just installed few NFC readers and to my surprise it show different layout dialog, "however" it works on my device. Anyway, I will look into your case of android NFC picker dialog.
[Xposed Framework Modules] Eve_brea:
Yes, crashes any time.

Also, as i said, the only apps i'm using that access NFC are Automagic, and Firefox

It's weird that it does this at all. This is an NFC tag i bought online and set the info in it myself. There's nothing for a browser to open...

Yet i use the NFC tag from a spyro skylanders toy, which is locked, and it only tries to read with automagic. (Which is what i want. )

New logs in the folder, the "21" ones (9 pm )
[Xposed Framework Modules] p.valenta:
Version 1.3 released

Let's make a major step in this Mod. After changing layout, let's manage list of apps!

As [MENTION=4540350]cramu[/MENTION] suggested, I implemented way to hide selected apps from

selected action

dialog.

1) You can turn it on by this checkbox:

2) Then there will be new button in top left corner of the dialog:

3) Click it and you will see new activity where you can hide selected apps from list. Please note, this will affect

only selected action

.

4) And here we go, hidden:

Like you can see in my example tutorial, I don't like to have Total Commander in Open Picture dialog. This doesn't affect other type of content, only pictures.

NOTES:

PS: Now I can move back to fix reported bugs. ;)
[Xposed Framework Modules] cramu:
Thanks for implementation!
[Xposed Framework Modules] s3icc0:
Diky za paradni funkci na kterou jsme vsichni cekali ...

Thanks for perfect feature we all were waiting for ...
[Xposed Framework Modules] Dovidhalevi:
This is being flagged for upgrade and is upgradable through the Xposed installer. It is also being auto-updated from Play. I actually had both happen. Maybe we should choose :)
[Xposed Framework Modules] oTeMpLo:
black theme works now on stock rom 10f
[Xposed Framework Modules] p.valenta:
Ohhh, so looks like height is still set somewhere else for this dialog on HTC. Ok, then let's continue to fix that....
[Xposed Framework Modules] p.valenta:
Yes, it's up to you which one you will let update it. Both ways works. :D
[Xposed Framework Modules] _jis_:
Please, could you take a look on my comments for Czech translation of these 4 strings and upvote correct ones?

Display Always checkbox

Advanced

App Icon

Long Press will start app in XHalo
[Xposed Framework Modules] Albator V:
Hi

How I can manager app list?

And why when I clic Test Open button, xda forum is open?
[Xposed Framework Modules] _jis_:
Did you read this tutorial?

It is just built-in example, but very handy to test the functionality of this module for Opening.
[Xposed Framework Modules] Thomas_BA:
Great, the dark theme working now. Just a little cosmetic wish.

Can you place the configuration icon a little bit more to the right and leave some space to the headline? So it will be in line with the rest.

Thanks

Enviado desde mi XT1058 mediante Tapatalk
[Xposed Framework Modules] PunchUp:
Funny how compatibility differs :D
[Xposed Framework Modules] p.valenta:
Version 1.6.8 released

Changelog:

- Fixed "Always" checkbox to set default app even when "Manage List of Apps" is active. :victory:

- Fixing layout to remove bottom gap on HTC device ( [MENTION=4694552]osama-selo[/MENTION] please try )

- Align preference icon littlebit more to right ( [MENTION=2234284]Thomas_BA[/MENTION] please try )

- Updated Czech translation ( [MENTION=4478620]_jis_[/MENTION] replaced with your suggestions )
[Xposed Framework Modules] p.valenta:
Well, if yours "Test Open" button open directly XDA forum without asking which app to choose, then you have already set default browser.

Anyway, like [MENTION=4478620]_jis_[/MENTION] said, these bottom buttons are for fast testing as

you don't need to restart to apply changes set in my mod settings

. Choose your layout, theme, text size and then simply take a look with test buttons.
[Xposed Framework Modules] Thomas_BA:
Updated. Looking much better now. Thanks

Enviado desde mi XT1058 mediante Tapatalk
[Xposed Framework Modules] osama-selo:
Sorry to tell you that it's still the same

Here it's my Xposed log:

https://www.dropbox.com/s/porg6quz2u58bob/xposed_debug_20140220_194146.log
[Xposed Framework Modules] p.valenta:
Screenshot is better. Can you do these steps:

1) Go to Settings -> Developer options -> "Show layout bounds" and check it. ( I hope you have such choice on HTC )

2) Then you will begin to see "weird" borders around elements on every screen.

3) Open again this "open" dialog.

4) Make screenshot, so I can see all that border lines.

Thanks
[Xposed Framework Modules] osama-selo:
Here it is:
[Xposed Framework Modules] _jis_:
But imagine how hard is it for the developer to accomplish his mission satisfactory for all users of those devices. This thread is very good example that it is sometimes even frustrating, one iteration over another one and happy end for some devices is still far away. I have a great respect to p.valenta and his work! :angel:
[Xposed Framework Modules] osama-selo:
+1 :thumbup:

Thanks for your hard work [MENTION=489665]p.valenta[/MENTION] ;)
[Xposed Framework Modules] PunchUp:
Indeed I agree.. I've only recently become an XDA regular and I must say some of the devs really have a heart of gold.. It's been a great experience and inspiration for me to look at their hard work and the patience with such a large user base. And I love the fact that some of them do not crave for money.. Donations are good and necessary but overall I think it's an act of generosity in an otherwise cynical world. I hope people realise how they work hard but still are kind enough to keep it free and listen to all the requests and complaints.

It's a life lesson I think :p Many people may not know how to make an app but all these good devs must surely inspire them to help others in any way they can :)