yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] sunwee:
1) Yes

2) checkbox appears

3) With "changed layout" ticked, the options all does show up. But no matter what configuration chosen (whether grid or list), it still appears like default (ie, 2 items per Grid). Also text size remain default no matter what is chosen.

Just to add, "Manage items" icon also appears and working.
[Xposed Framework Modules] p.valenta:
Good, thanks. So it's only replacement of layout style. I will take a look at this part. ;)
[Xposed Framework Modules] osama-selo:
Ahhh, so after your last update my app picker didn't change like almost everyone else and I thought that it's not working for me, the only thing that had changed is that I have to tap only once to open the app, but the buttons of the dialogue are disabled (I can't tap Always nor Just once and there is no other options of your mod ) also I can't change the layout to grid.

Here is a screenshot of mine.

Thanks
[Xposed Framework Modules] p.valenta:
Samsung Note 3 change layout

I just downloaded CivZ_FlexKat_Rev1.1-SM_N9005-4.4.2 ROM from Note 3 Dev section. I took look inside and I found that Samsung

renamed resources on Note 3

, this is why no resources got replaced.

I will prepare another version tonite which will handle that. ;)

I'm downloading one of HTC One X ROMs now to see if same thing happen on this device as well.
[Xposed Framework Modules] osama-selo:
If you want I can provide u of any apk you want instead of downloading the whole ROM
[Xposed Framework Modules] p.valenta:
framework-res.apk please, thanks. :)

well, let's add framework.jar and framework2.jar just in case I will need to de-assemble source code.
[Xposed Framework Modules] osama-selo:
Here is the required files in addition with the file framework-HTC-res.apk (maybe it will be useful also)

https://www.dropbox.com/sh/f1eb85ra73nj4hl/MG-Sg6EVaX
[Xposed Framework Modules] _jis_:
I tested it in the morning when I read your answer, but I have found that it has a strong and valid reason to keep at least two items active in the list. Why? For the http scheme I have four apps: Internet, Chrome, Chrome Beta and Tapatalk. So I try to hide all but Tapatalk to test it. Guess what happened: When I closed Complete Action Plus UI and started it again, the button Test Open! show me immediately Support thread. So I lost ability to edit the list again, I get to the dead end. It is logical, so when you have just one app, the Complete action using dialog is then skipped completely...

But as an experienced user it wasn't any problem for me, I choose to just unfreeze an old version of Tapatalk, so I get another app with http scheme support and I was able then restore my previous configuration for this scheme and after this operation I freeze old Tapatalk again. But I can imagine that inexperienced user might have a problem. So I recommend to you forgot to display warning text in List Manager (it is just wasting a space here and it makes people to wonder and to test why there is a such limit) and hard code check for at least two items to be active all times. This check can show the toast message with existing warning text.

You probably didn't understand me there. I meant N/A items in apps list, see the last item in the last attachment. This is some remnant from previous used but now uninstalled apps?

Yes, it works beautifully now. If you are using web browser, you didn't notice any change, it brings you still at the first post in the thread, but if you are using Tapatalk and have it set its Loading behaviour to First Unread, Tapatalk show you the first unread topic if you invoke Support page from Xposed Installer/Modules/Complete Action Plus Context Menu/Support. :)

It is great to be able to catch the news on its XDA thread from the mod context without any hassle now.
[Xposed Framework Modules] yurividal:
[MENTION=489665]p.valenta[/MENTION] i have found a bug. Not sure if already reported. But here you go.

When i open the browser, google a song name, and google shows me a youtube link to the name. When the open with dialog appears, and I try to hit "configure" i get a System Force Close.

I have attached my xposed log.
[Xposed Framework Modules] deathshead:
Great app, Booyah!
[Xposed Framework Modules] p.valenta:
I really appreciate your valuable feedback and testing. Great response! :good:

1) Yes, you are right. Better add check and don't allow it.

2) Should be, I will add extra condition check for uninstalled items.
[Xposed Framework Modules] p.valenta:
Well, well, I guess you will need to post logcat. Xposed log shows crashes of other mods, but not mine. :(

So please follow again these steps and then capture logcat as crash should be reported there in your case.
[Xposed Framework Modules] yurividal:
Here you go. Logcat and screenshot:
[Xposed Framework Modules] p.valenta:
Version 1.5.6 released

Changelog:

- Fixed crash for youtube links from browser.

- Allow landscape.

- Simplified Chinese translation.

- Samsung Galaxy Note 3 layout fixing. Guys please let me know if change of layout works now?

- Removed uninstalled apps from manage list.

Edit: Just released 1.5.6.1 as there was bug in previous version which cause crash when first time load manage list.

Edit2: One more small thing, so 1.5.6.2. Removed debug toast message.

Well, it's not good idea to publish something before going sleep.
[Xposed Framework Modules] cramu:
When I read that I hoped you give us an option to choose a theme for the popup but I recognized that you meant the app theme?

Would you consider to add an option for the popup too?

Attached a log concerning system crashes when pressing the wrench icon on my N4.
[Xposed Framework Modules] _jis_:
What version is crashing to you? Do you have the latest one 1.5.6.2?
[Xposed Framework Modules] Spiricore:
I'm running 1.5.6.2 and am able to customize Open With via the wrench icon, but Share with just brings up a black screen. Thought it was my theme but I switched and still had the same problem. If you need a logcat I can provide one. Device details are in my sig.

On another note, thank you so much!
[Xposed Framework Modules] _jis_:
I polished the Czech translation to be more consistent and logical.

Remarks about GUI glitches:

Layout of two bottom buttons in the List Manager doesn't change at all when the app theme is switching from light to dark. I think they should change, at least black ink into white to be more contrasty.

"Test Share!" button invoke window with "Test Share!" title, but "Test Open!" button invoke window with "Complete action using" title. Shouldn't the second title be "Test Open!" analogically?
[Xposed Framework Modules] _jis_:
The same version works fine on SGNII 4.1.2.
[Xposed Framework Modules] sunwee:
Note 3 user. Thanks for the update.

As I can see now, List view works, text sizing works, but Grid setting column still remains 2 no matter what number selected.

Also as a suggestion, is it possible to make the List view with less space padding? Eg, those that use Tiny or Small text will look more pleasing with smaller height.
[Xposed Framework Modules] cramu:
Just updated and no more crashes.
[Xposed Framework Modules] kamikaze702k:
Thanks for this lovely little app !

Sent from my GT-I9195 CARBON ROM 4.3.1
[Xposed Framework Modules] p.valenta:
Thanks, díky.

Yes, it is not instant change as changing theme need to create activity again. To my own experience it is not common to do so in other apps, so I let it like this for now.

Well, this is quite standard way of these dialogues. Developers should set title for "Share" action. But for "Open" action you just send action with content type and system handle it with standard "Complete action using...".
[Xposed Framework Modules] p.valenta:
Great !! :victory:

So let's do one more step to fix number of columns. :fingers-crossed:

I got already feedback from other users in emails asking about less padding. You are right, it will be best to combine it together with text size. Smaller size of text, less padding around. I will add it for sure.

Tablet users asked me about different number of columns per portrait and landscape orientation. This will be there for sure too, so more translation will be needed soon. :)
[Xposed Framework Modules] p.valenta:
These popups theme is directly set in original method, so I cannot overwrite it. :(

Only way how to change theme will be manually change all elements attributes in popup (background color, text color). This could be possible, but it will be so slow operation, not fast as simply change theme.

I don't have it in plan, but if there will be big interest in to have it .........

I just think, would it be more better to simply use some kind of XThemer engine? These kind of theme managers can change whole system theme including these dialogs. :confused:
[Xposed Framework Modules] mugendon:
Dark Theme for Popup [...]

Interest+

Btw. thanks for the great app =)
[Xposed Framework Modules] _jis_:
Maybe we didn't understand each other. I didn't ask for the instant change when the app theme is switching from light to dark. I was talking about two bottom buttons in the List Manager that they didn't change graphically at all when you switch app theme. They look the same in both light and dark theme. At least on my TW SGNII 4.1.2. This is what I had in mind. I think they should change, at least black ink into white to be more contrasty in the dark theme. :)

Ok, I don't know this, I thought that you were going to set both titles explicitly to show the user that he/she is in testing mode of those dialogs.
[Xposed Framework Modules] p.valenta:
Version 1.5.7 released

Changelog:

- Make sure number of columns in Grid layout is set. ( [MENTION=1758291]sunwee[/MENTION] please check)

- Add checking for at least two remaining items in list and fixed button style. ( [MENTION=4478620]_jis_[/MENTION] feedback)

- Integrated support for [MENTION=5402474]zst123[/MENTION] XHaloFloatingWindow mod by long press item. (You need to have this mod installed to see this choice. [MENTION=4921161]xPr0metheus[/MENTION] enjoy!)

This means one more sentence to translate. Translation files in attachment.
[Xposed Framework Modules] xPr0metheus:
Still layout doesn't work right on my Note 3. And when I long press an app the app info in settings opens :(

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] p.valenta:
I guess that I don't need to ask you if you restart. :(

What is original layout on Note 3? Grid or List?
[Xposed Framework Modules] xPr0metheus:
I restarted and it's grid

This is without module:

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] p.valenta:
Ok, I think I found what can cause it. I will create test version tomorrow to handle it.

Edit: Can you try if XHalo works without checked "change layout" checkbox?
[Xposed Framework Modules] _jis_:
Czech translation :)

Please correct one string according this one:

<string name="activity_main_display_always">Zobrazovat volbu 'Vždy'</string>
[Xposed Framework Modules] xPr0metheus:
Tested and doesn't work either

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] faku1810:
Great module :) I've always wanted to hide some apps i never use to share with, and the favorites feature is even better so thanks a lot for your work on this.

I wanted to report that the Spanish translation is not well done (words order isn't right) so later I'll attach a corrected version of the xml files so you can update the app if that's okay.

Edit: Spanish translation attached, I corrected the wrong translations and shortened a few strings which were too long, and left the original app name as the translation makes no sense at all.
[Xposed Framework Modules] Spiricore:
Don't know what changed, but after attempting to edit the Share menu a good dozen times over half a dozen reboots it seems to be working now. :confused:
[Xposed Framework Modules] sunwee:
I downloaded from xposed repository and version shown is 1.5.7 but it doesnt have the "Long press..." halo option??

And as reported by xPromethous, grid settings still not working in Note 3.
[Xposed Framework Modules] GermainZ:
This module slows down the following by roughly 5-10 times. It's easy enough to test (and if you don't want to make your own activity just to test this, PerAppSettings uses the same code as well.) Just disable/restart/test/enable/restart test (naturally, I've tested it with nothing except CompleteActionPlus enabled.) This happens regardless of the "Manage List of Apps" state, which is the only thing I think should even affect this.

for (ApplicationInfo appInfo : apps) {
dialog.setProgress(i++);
if (appInfo == null)
continue;
[U][B] appInfo.name = appInfo.loadLabel(pm).toString();[/B][/U]
appList.add(appInfo);
}

I can live with it if it's a must, but since no one else reported this slow down I thought I would. Your module isn't open source, but taking a quick look at the decompiled package I don't think you're hooking anything directly related to ApplicationInfo or PackageItemInfo. I can't quickly try and debug it myself either for the same reason. :(

Anyway, you might want to look into this if you have the time. Thanks!
[Xposed Framework Modules] p.valenta:
Did you installed XHaloFloatingWindow mod? It must be installed and activated. ;)
[Xposed Framework Modules] p.valenta:
Thanks for speed analyst. :good:

This line of code is used to get localized name of application and then display it in the list. I don't want to display package name or non-localized english name as some applications translate their names.

I will take a look in code and try to call it only when necessary. Or do you know alternative optimized way to get application name?

Edit: It should be called only when "Manage List of Apps" is checked. Anyway, thanks for report. I will optimize it. ;)
[Xposed Framework Modules] AndroGuru:
Feature Request:

Gr8 Job with the module dev. I just have a feature request. In the app setting page can you implement a way to reorder the apps. So that one can have most used or important apps first. Thanks
[Xposed Framework Modules] p.valenta:
Select them as favorite = star button. These will be at the top of list. ;)
[Xposed Framework Modules] p.valenta:
Translation

I was thinking about to make it easier for translation. I look around to see what other projects are using and I decide to give a try to GetLocalization.

I setup project there, so if anybody want to contribute with new language or improve current one, please go there: http://www.getlocalization.com/CompleteActionPlus/

I will still be posting files in attachment as a second way for volunteers who don't have account there or do not want to register there.

Thank you!
[Xposed Framework Modules] OrangeFever:
I can't actually find the option to disable what apps show up in the share menu, would someone mind helping me out please?
[Xposed Framework Modules] GermainZ:
Check this post.
[Xposed Framework Modules] AndroGuru:
You won't get the options here. But when you bring the share or open with menu then look for a gear icon in the top left. Click on that and it will take you to the edit page.
[Xposed Framework Modules] OrangeFever:
Thanks for the quick response! Got it working now.
[Xposed Framework Modules] JirkaS:
Great app, thanks! Would it be possible to NOT aquire two apps checked since last version? My CM11 on GTN7100 was soooo long awaiting such possibility :)
[Xposed Framework Modules] _jis_:
Did you read this?

http://xdaforums.com/showpost.php?p=50259559&postcount=236

So it has valid reason to keep at least two items active in the list...

You can install older version from repository and test it for yourself.
[Xposed Framework Modules] p.valenta:
Version 1.5.7.1 BETA

This is testing beta version only. Trying to solve Samsung Note 3 Grid layout issues in this version, so please test it. ( [MENTION=4921161]xPr0metheus[/MENTION], [MENTION=1758291]sunwee[/MENTION] and other Note 3 users)

No other change except translations.

I got Dutch translation from R3MCOON3, thanks!

Updated Spanish (by [MENTION=4690266]faku1810[/MENTION]), Simplified Chinese (Wu Ming), Slovak (gettrolled) and Czech (Jirik, Janinka, fanouch), thanks!

Edit: Only available through Xposed Repository as BETA branch.
[Xposed Framework Modules] xPr0metheus:
The attached file from op? No difference :(

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] p.valenta:
Sorry, I forgot to post there that it is only in Xposed Repository.

I will add version number to OP file next time I update it. :o
[Xposed Framework Modules] xPr0metheus:
Nice! Now xhalo works and grid. New problem occurred now :D (I am so sorry :( ): Icons are cut. However, great work! Would be cool now if we could change the "theme" of the chooser (to pure android, black, white and similar)

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] p.valenta:
Great! I will try to solve icons in next beta.

Looks like one more vote for theme feature. :laugh:

Edit: Does it looks fine if you choose less columns than 5?
[Xposed Framework Modules] xPr0metheus:
I just thought about something: maybe you can make it so that the icons arrange automatically. That would mean that you can set how many apps will be max. per row (up to 6 would be nice) as it is now but when there are only 3 choices that they are also centered and icons automatically bigger. So that there is no gap at the right side. You know what I mean?

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] JirkaS:
Now I understand. I did install older version, I prefer not to always choose app for majority of filetypes/protocoles. And I don't know why the default app set in Android is often not rememberd after reset. Complete Action Plus IS the solution. Maybe the 2 apps checking would be adjustable option.
[Xposed Framework Modules] valk791:
Many thanks to the dev for this module, it's very useful!

I would like to manage the list of app that I can choose for instance Skype or the browser stock but I don't know where is this option. Can someone light me up? Thanks

Inviato dal mio Nexus 4 utilizzando Tapatalk
[Xposed Framework Modules] _jis_:
Did you read this tutorial?

---------- Post added at 10:46 AM ---------- Previous post was at 10:41 AM ----------

Now I don't understand you, because these two your sentences are in conflict with each other. :confused:
[Xposed Framework Modules] JirkaS:
I mean "condition of checking at least 2 apps per filetype" . And I assume that new versions of Complete Action Plus will mabye have great features which I could not use when I stay with older version. Is this celar now? I am sorry for imprecision ;)
[Xposed Framework Modules] _jis_:
I sent you PM.
[Xposed Framework Modules] kamikaze702k:
love this module, please can you make this so that when the action plus opens up we can choose our background color?? that would be awesome, as the app interface itself has a dark theme but can we please have a dark theme for the app action popup pleaseeeee

apart from that well done and thank you
[Xposed Framework Modules] wilco375:
Feature request: Always button in share

Can you add an always button to the share menu (or an option to add it) just like the always button with clicking a link?
[Xposed Framework Modules] _jis_:
Just read this post, it is on the same page as your post.
[Xposed Framework Modules] kamikaze702k:
So it will be implemented soon ? :)

Sent from my GT-I9195 CARBON ROM KK 4.4.2
[Xposed Framework Modules] _jis_:
I am sorry, but this request doesn't make any sense in the sharing menu. Can you give an example to explain why do you want it?

---------- Post added at 08:49 PM ---------- Previous post was at 08:43 PM ----------

I cannot speak for developer, but primary target is to iron out rest of bugs for some devices and then, maybe :)
[Xposed Framework Modules] p.valenta:
Version 1.5.7.2 BETA

Changelog:

- Improved layouts. Should be more tight, reduced gaps. Should help to fit when setting more columns in grid.

- Set number of grid columns per Portrait and Landscape. Portrait 2-5 and Landscape 4-9! Yeah 9. :D

As you might notice, there is "Layout Theme" in settings, well this

will be

what you asked for. I disabled it as it's not yet done, but choices will be:

- Default (no change)

- Light

- Dark

Translations will need to be updated with every new feature. ;)

Please go to http://www.getlocalization.com/CompleteActionPlus/ or find files in attachment.

Available only by Xposed Repository as it's BETA.

Great thanks to [MENTION=4478620]_jis_[/MENTION] for helping and providing answers.
[Xposed Framework Modules] _jis_:
Please, is it possible to little bit squeeze that empty space before Advanced section? That way will be screen real estate better used for some of us, see two half hidden buttons on the bottom in my snapshot. :)
[Xposed Framework Modules] p.valenta:
Yes, I have it in plan to do before release non-beta. It will be fixed.
[Xposed Framework Modules] p.valenta:
Version 1.5.7.3 HTC BETA

This version is for HTC fixing. [MENTION=4694552]osama-selo[/MENTION] please try it.

There is nothing new for other devices so you can stay with 1.5.7.2 ;)
[Xposed Framework Modules] osama-selo:
Sorry, but where is this version and what version it is?!!!
[Xposed Framework Modules] _jis_:
It is HTC BETA branch 1.5.7.3 in the Xposed framework repository, choose Download page :)
[Xposed Framework Modules] osama-selo:
Refreshed many times with no updates, will try again.
[Xposed Framework Modules] _jis_:
Restart the phone and try it again, it should be here.
[Xposed Framework Modules] osama-selo:
Unfortunately, it's still the same :(
[Xposed Framework Modules] p.valenta:
Can you post Xposed Log? Layout is still same?

I check HTC source from your frameworks and should match now.

Edit: I think I found why, soon new version.
[Xposed Framework Modules] osama-selo:
Hope it work in the next version :rolleyes:

Anyway here is my log:

https://www.dropbox.com/s/pbgu82ovegpaoie/debug.log
[Xposed Framework Modules] _jis_:
This bug is back in 1.5.7.2, but in strange way only for some apps, see two Tapatalk icons:
[Xposed Framework Modules] p.valenta:
Well, if you have two Tapatalk App then this is standard behavior. Android source code have one condition, if there are two same name apps, it will display their package names. ;)
[Xposed Framework Modules] _jis_:
Thank you, I don't know it. It explain behaviour which I unknowingly captured in this my post. Look at the difference between first two snapshots... After all it is a smart behaviour, apps with the same name are distinguished. :)
[Xposed Framework Modules] p.valenta:
Version 1.6.0 released

Changelog:

- Layout theme feature done. Please note that it's fake. I cannot use theme so I changed background and text colors to match with themes.

- Improved layout of settings to better align.

[MENTION=4694552]osama-selo[/MENTION] please try again.

Edit: This version is now available at Xposed Repository, OP and soon will be available by Google Play.
[Xposed Framework Modules] xPr0metheus:
Icon bug is GONE now thanks! For the theme: can you make the black more like the grey black of stock android? (Or is it transparent?) And with the white background the text should be in a different colour. And the window is not completely colored

Great work anyway :)

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] _jis_:
Great release! Only small nitpicking, see window title bar with blue strips on both snapshots. But I think that it is Samsung thing not your fault. After all it looks interesting in this way. ;)
[Xposed Framework Modules] _jis_:
You were faster. :)

I am happy with actual pitch black on AMOLED display, but you are right with the rest remarks.
[Xposed Framework Modules] p.valenta:
Thank you both for screenshots and feedback. I will adjust it and apply changes to these.

Btw. LG show it like this:
[Xposed Framework Modules] xPr0metheus:
Yeah, it's Samsung. They really change every little thing on their roms -.-*

Gesendet von meinem SM-N9005 mit Tapatalk
[Xposed Framework Modules] igresso:
Layout theme light title here..

Galaxy s3