yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] LucasR93:
hello Sirlatrom,

sorry, I didn't look into this thread for a while and I must admit I forgot to answer your message.

It is not that easy to implement your fix, as I changed some other stuff in the source code (and did not make a backup of the old code unfortunately)

I will try to repair the code and then publish it to github or anything, so the community can help here with pull requests.

Thank you for your support by the way, I hope we can add Sense 5 support soon

Regards

Lucas
[Xposed Framework Modules] LucasR93:
Source

Hi folks,

source can be found here now: https://github.com/LucasR93/android-lockscreen-disabler

I am happy if you commit pull requests!
[Xposed Framework Modules] gsamtan:
Now with a timeout to restore original lock...

Awesome Mod [MENTION=2593381]LucasR93[/MENTION]... I liked it so much I forked it and added the ability to set a timeout value so that the original secure lock screen will be restored. This allows you to lock your screen and get the slide lock for a while, but has the real lock kick back in after X minutes of inactivity (and always on bootup). This provides a nice balance between keeping your phone secure, and making things usable. Interestingly, this feature was available in Gingerbread's CM, but has long since disappeared...

Changes can be pulled on github once you're ready. Others can feel free to pull the source (look at the forks from the above link) and build it - but I won't be publishing an APK as the core belongs to [MENTION=2593381]LucasR93[/MENTION] who can choose to include it or not at his/her discretion.
[Xposed Framework Modules] trackloading:
Great. Works fine on my Nexus 7 lte.

But how is the battery impact?
[Xposed Framework Modules] LucasR93:
Awesome work, really! As said in github, I will test it next week and publish it via the xposed repo so everybody can use the new features. :)

Battery impact in general or with the addons from [MENTION=3544163]gsamtan[/MENTION]?

General: absolutely no impact, as stated and explained multiple times before. If you are interested, search this thread.

Addons: I can not tell you, but I think also no bigger impact, as it should not create any wake locks in my eyes.
[Xposed Framework Modules] trackloading:
Ok, thanks. Didn't see that...
[Xposed Framework Modules] trunzoc:
anyone feel like adding Support as a Tasker plugin, or just simple intents to turn the Lockscreen on and off?

Sent from my AT&T S4 running KangaKat.
[Xposed Framework Modules] LucasR93:
Thanks to the great work of xda [MENTION=3544163]gsamtan[/MENTION], the new v 1.4.5 now has the following new features:

-> Changing the lockscreen type now doesn't require a reboot anymore - finally!

-> You can choose a timeout, after that you are required to enter your device standard security information (e.g. password)

Find it in the Xposed Repo!
[Xposed Framework Modules] tangcla:
Thanks for this module. I've been using it on my Galaxy S5 just fine, with TouchWiz.

However - with this latest version, my lockscreen has become secure, in that I can't swipe down to access my notifications - I can only unlock. Can this be reverted back to how it was previously?
[Xposed Framework Modules] LucasR93:
Hmm that is not good :(

As a quick fix, you can download an older version within you xposed app, but I will have a look at your issue so you can also use the new features later
[Xposed Framework Modules] tangcla:
Thanks. I rolled back to 1.4.2 and all is well again.

Also, I noticed that I lost the lockscreen style (ripples/water drops etc from TouchWiz) with the new version, it was just the boring old lock ring.
[Xposed Framework Modules] peterf9:
So, should work on xperia z2?

Thanks
[Xposed Framework Modules] gsamtan:
Hmm, I suspect the change to not hook the isSecure method is why the notification bar didn't come down. I can look into that.

If you configure the swipe screen options before enabling the password, does that let you use something other than the plain lock ring?
[Xposed Framework Modules] tangcla:
I'm not sure - on 1.4.2 it reverts back to my original setting, on 1.4.5 it is lock ring only. I haven't configured it in a while, since I have my VPN settings (hence the need for this module!).
[Xposed Framework Modules] LucasR93:
[MENTION=3544163]gsamtan[/MENTION] I think we should then go back to hooking the isSecure method, as this seems to be the best solution, at least for the touchwiz based ROMs. What do you think?
[Xposed Framework Modules] LucasR93:
Yes should work I think. Report if it does, please :)
[Xposed Framework Modules] gsamtan:
So there are two things. First is the notifications. Adding isSecure hook to the keyguard package should take care of that.

The second is being able to configure the settings for swipe when password is enabled. If we also hook the isSecure method for the settings package, it ends up showing swipe as the lock screen type and let's you configure the swipe options. The problem though is that you can't configure the options for the password screen. That said, there really aren't any options. So perhaps it makes sense to do that even though it is a bit misleading. But we want to only do this for the settings package, otherwise there may be side effects.
[Xposed Framework Modules] tangcla:
New version works great, thanks!
[Xposed Framework Modules] gsamtan:
Great to hear, thanks!
[Xposed Framework Modules] dinglehoser:
[MENTION=3544163]gsamtan[/MENTION] Oddly, 1.4.5 and 1.4.6 don't work at all for my setup (CM11S, OnePlus One, encryption enabled, password forced via Citrix Worx Home) but 1.4.2 does. CM11S's custom lockscreen doesn't work on any version with the module enabled - selecting slide-to-unlock gives me the password prompt (which I can just swipe away without having to type in a password). Any idea what the issue is, and what can I do to help you drill down on the issue?
[Xposed Framework Modules] LucasR93:
You should do the following to help us track your issue:

Enable logging in the lockscreen disabler app

Go to your lockscreen and lock/unlock etc., play a bit ;)

Go into Xposed app -> Log and copy the logs

Post the logs here
[Xposed Framework Modules] NoobTW:
Bug Report:

During the lockscreen, it's normal that I can't click on my widget and items on statusbar without entering password.

But it should be a bug that I can easily start Google Now by holding and drag my home button on the lockscreen before I unlock, suddenly I can bypass the lockscreen and do anything.

Is it because I'm using Google Now Launcher?
[Xposed Framework Modules] gsamtan:
Seems like an issue to me. I can't replicate that though as I don't have device buttons.

I assume that if you disable the mod altogether from xposed that you don't see this issue? If you choose the lock screen type default option does it happen? If you use the previous version 1.4.5 does it happen?
[Xposed Framework Modules] NoobTW:
It won't happen if I disable the XPOSED mod.
[Xposed Framework Modules] gsamtan:
Can you try the other things I mentioned? Will help diagnose where the issue may lie.
[Xposed Framework Modules] NoobTW:
Disable all mod exclusive of this, it still happens.

Use default lockscreen type, no it doesn't happen.

Use previous .5 version, yes it still happenes.
[Xposed Framework Modules] gsamtan:
Ok, I've been able to replicate. I have an idea of how to fix...
[Xposed Framework Modules] NoobTW:
Being waiting ;)
[Xposed Framework Modules] defkev:
Any progress one the CM11S custom lockscreen issue initially reported by dinglehoser?

Running 1.4.6 and tried 1.4.5 as well without success, keyguard will prompt for whatever i have configured (PIN/Pattern/...) regardless of what is setup in the module.
[Xposed Framework Modules] gsamtan:
Nope, not from me. If somebody can point me to the source for this it should be easy to figure out. CM11 should work just fine...wonder if they did something different with 11S.

Any idea what the name of the keyguard app is? If you can hunt down the key guard apk (and likely odex) then we can probably figure this out.
[Xposed Framework Modules] defkev:
Running bacon XNPH33R

The package should be:

com.cyngn.keyguard
[Xposed Framework Modules] LucasR93:
Me too, I fixed it in v 1.4.6
[Xposed Framework Modules] webard:
Pattern lock

Great mod, but I would like to see additional functionality.

Now, to encrypt device and memory card data, we need to set lock on password. But this method of lock is very impractical.

What if, in system we set password lock, but mod change this method to Pattern lock or PIN which uses a lot more people and is much more useful.

What do You think about it? We have secure device and practical lock method, which together with lockscreen enforcement timeout gives pretty good protection.
[Xposed Framework Modules] tangcla:
The new version seems to have broken the lock ring style on the Samsung phone again! :( also lost the ability to edit lockscreen settings. Back to 1.4.6 for me!

---------- Post added at 11:59 PM ---------- Previous post was at 11:36 PM ----------

Also, in the next version, can you update the app name to Lockscreen Disabler? It's still Keyguard Disabler (at least Keyguard is spelt right! :p)
[Xposed Framework Modules] gsamtan:
Ugh, you're right. Getting the screen secure while maintaining the ability to edit the setting is hard :) I'll work on it...
[Xposed Framework Modules] tangcla:
1.4.6 seemed to work with everything though.. Is that secure?
[Xposed Framework Modules] gsamtan:
No, it's possible to circumvent the password screen once it shifts from swipe to password. Just pull down the notification bar and try accessing an app. .7 fixes that. I should be able to get it all working though.
[Xposed Framework Modules] ts_mpls:
Is it possible to enable other unlock methods? I'm using this mod to just do swipe to unlock where my policies typically only allow PIN and password, but what if I want to do pattern unlock?
[Xposed Framework Modules] dinglehoser:
1.4.7 now does something on CM11S, but the behavior isn't quite right. When using slide-to-unlock, on first boot, it requires a password. On subsequent locking, sliding the lock screen panel (which now appears correctly, with notifications and everything) doesn't actually do anything. You can work around this by sliding up from the bottom of the screen to activate Google Now, whereupon it unlocks. Same if you swipe left to activate the camera.

Logs don't show anything interesting - slide-to-unlock events don't even appear to register, but camera and Google Now activation show up normally as unlock events.

Getting there ... thanks for the hard work!
[Xposed Framework Modules] LucasR93:
Hi,

yes I have the same issue - I tried to add support for Oneplus, but I have the same issue.
[MENTION=3544163]gsamtan[/MENTION] can you help here? As stated by dinglehoser, code for Oneplus one is loaded, but the lockscreen style is not changed at all. Interesting though: in the settings app, the current lockscreen method is shown as slide, although PIN is activated in the background. On the lockscreen I also am always asked to enter PIN instead the desired slide to unlock. Did I miss anything in my commit?
[Xposed Framework Modules] gsamtan:
Hmm, it looked right to me, but it could be the cgn key guard app is just a little different. We'd need to look at the decompiled code to figure it out.
[Xposed Framework Modules] phailyoor:
App works great. It's saving me since I need to use a vpn for personal uses.

It breaks the ripple animation on the note 3. Is there any possibility of fixing that?
[Xposed Framework Modules] tangcla:
Roll back to v1.4.6 and that gives you best of both worlds :)
[Xposed Framework Modules] drsood:
Hi

If pattern unlock is enabled in system settings and lockscreen type is set to 'no lockscreen' in the app, after restarting my tab when i turn on the screen for the first time, the pattern lockscreen shows up. Why so?

Although any subsequent screen on event doesnt bring up the lockscreen as per the app settings.
[Xposed Framework Modules] tangcla:
Hi, the new version 1.4.8 still doesn't recognise my lockscreen options on the Samsung lock screen (popping colours, ripples etc). 1.4.6 is still the best version that had this feature.

Edit: on my gf's Nexus 4, it also asks for a PIN the first time the phone is on after a reboot, and I can't reboot from the lockscreen. So 1.4.6 is still the best version.
[Xposed Framework Modules] LucasR93:
I added an option to let you decide whether you are forced to enter a pin/password once after boot or not.

(also for your information [MENTION=3544163]gsamtan[/MENTION])

Github user ravikumars also brought us

tasker support in version 1.5.0!
[Xposed Framework Modules] drsood:
Sorry for bothering again. I just tried out the latest version and now on startup, it shows up the slide 2 unlock screen once on startup.

My setup:

System settings › pattern lock

Lockscreen disabler

Lockscreen type: none

Lock on first boot: unchecked
[Xposed Framework Modules] LucasR93:
No no, feedback is always much appreciated!

I can reproduce the error - I will have a look at it - maybe [MENTION=3544163]gsamtan[/MENTION] can help here, because he implemented all that bootup stuff
[Xposed Framework Modules] trunzoc:
TASKER!! OMGYAY!!!!

Thank you so much for that!

Sent from my AT&T S4 running KangaKat.
[Xposed Framework Modules] tangcla:
Version 1.5.0 still doesn't honour the swipe options on my Samsung S5 like 1.4.6.
[Xposed Framework Modules] drsood:
Any progress on this issue??

I would like to point out another issue. There's an xposed module ProtectedApps that probably looks for the lockscreen broadcast to relock apps after turning on the screen. But if LockscreenDisabler lockscreen type is set to none, ProtectedApps fails to relock the device. This issue has been discussed in a little more detail here:

http://xdaforums.com/showpost.php?p=55832948&postcount=163

http://xdaforums.com/showpost.php?p=55835475&postcount=164

http://xdaforums.com/showpost.php?p=55840583&postcount=169

http://xdaforums.com/showpost.php?p=55847261&postcount=170

Can you help resolve this issue?
[Xposed Framework Modules] waby38:
Using v1.5, but still no "slide-to-unlock" after reboot

seem that since 1.48, "slide-to-unlock" should be present in Lockscreen type,

but this not the case for me (v1.5, lockscreen type only show "No lockscreen" and "Default")

Using 4.1.2 Android, and system screen lock only premit "pin code" & "passwd"

How can I help you to debug ?

Anyway, Many thanks for your work!
[Xposed Framework Modules] defim:
Small addition: Intent. ACTION_USER_PRESENT

http://developer.android.com/reference/android/content/Intent.html#ACTION_USER_PRESENT
[Xposed Framework Modules] drsood:
[MENTION=4501300]defim[/MENTION] [MENTION=2593381]LucasR93[/MENTION] Thanks for working together for resolving the issue
[Xposed Framework Modules] tangcla:
Could someone please upload v1.4.6 of this? I accidentally overwrote my backup and it seems to be a skipped version in the XPosed repository.
[Xposed Framework Modules] LucasR93:
Sorry, I don't have it anymore :(
[Xposed Framework Modules] tangcla:
I found a copy on my gf's Titanium Backup - do you want it?
[Xposed Framework Modules] LucasR93:
Yes please, then I can upload it to xposed repo :) Thanks
[Xposed Framework Modules] tangcla:
As requested :)
[Xposed Framework Modules] LucasR93:
Nice, that was quick :) I've added it to xposed repo :)
[Xposed Framework Modules] tangcla:
Cool! Glad to have helped.

Any update on making new versions work nicely with Samsung lockscreen eye candy? :)
[Xposed Framework Modules] Bingley:
Can this be made to optionally choose pattern lock on an encrypted S4?
[Xposed Framework Modules] earthman5678:
And for note 3 too if possible. Vpn forces me to use password but I want is pattern lock. Thank you for your great work.
[Xposed Framework Modules] youngmack2k4:
VZW GS3

Good morning guys,

I cant get this to work on my gs3 running liquidsmooth rom, I can set no lockscreen on the module but when I select slide to unlock and lock the device it still requires me to put in my pin every time. here is the link to their source https://github.com/LiquidSmooth, I would really love for this to work since using IBM Notes forces me to have a strict lockscreen enabled at all times. Look forward to hearing from you guys.

Thanks.
[Xposed Framework Modules] Kasya:
LG G3 - 4.4.2

Working perfectly. I use this for Exchange bypass.
[Xposed Framework Modules] jsp91470:
Thanks for the great mod!

I'm running it on my stock rooted Galaxy Note 3 with KK 4.4.2.

I can also confirm that the ripple effect on the swipe-to-lock screen doesn't work.

I also noticed that if I don't set the option to require lock at first boot, my SD card doesn't work properly. If I disable this, the phone boots without the lockscreen but I get an icon in the notification bar "Preparing SD Card" and if I pull down the notification tray it says "scanning card for errors." This never goes away, and the card is not mounted. If I turn on"Lock on first boot" I of course have to enter my PIN when I reboot the phone, but then the SD card works correctly.

This doesn't bother me-- in fact it's exactly the way I like it but I thought I'd mention it. My guess is that the phone is clearing the stored PIN/password when you reboot the phone, so when you reboot with "Lock on first boot" disabled it has no password and can't mount the card. I didn't try it but I suspect in that case you would also get the "enter credential password" prompt when trying to use the VPN. This would make sense because it had cleared the stored password when you rebooted and not entered it again on startup. Checking "Lock on first boot" would allow it to store the password once, then you could have your slide lock or no lock.

As I said, it's the way I want it already.

Any chance on getting the ripple eye candy working?

Thanks!
[Xposed Framework Modules] tangcla:
Roll back to version 1.4.6 - everything works on my S5. Ripple effect, no first lock.
[Xposed Framework Modules] jsp91470:
I rolled back to 1.4.6 and yes, the ripple effect works, but I had the same problem with the SD card. Unless I have it set to ask for my PIN once on first boot, my SD card never gets mounted. I had to go back to the current 1.5.0. Waiting for a fix for the ripple effect that still allows to lock on first boot-- without that, my SD card doesn't work.
[Xposed Framework Modules] tangcla:
Hmm, interesting, doesn't do that on my S5. Thought it'd be similar. :p
[Xposed Framework Modules] DCThunder:
Appreciate everyone's efforts. Combined this with the "Samsung Multiple Widgets" module on my SGS3 running stock touchwiz, so that I could have custom widgets on my lockscreen but also enable and disable the lockscreen via Tasker. I lost the Tasker control when I activated the "Multiple Widgets" modules, so it's nice to get that back.
[Xposed Framework Modules] Droidphilev:
Same on AICP (based on AOKP)
[Xposed Framework Modules] numanair:
I have found a bug with using this module and a USB connection.

When plugging into a computer to transfer files over USB MTP it needs to prompt for the unlock pin/pattern or it won't be detected by the computer.

Device: moto x (original), 4.4.2

Good work though! I was using this to work around the VPN lockscreen pin requirement.
[Xposed Framework Modules] RadarNyan:
I was looking for a solution to use both insecure lock screen (slide) and VPN the same time, but this module just doesn't work.

It did indeed locked my Screen security setting to Slide, which is if this module is enabled, if I try to set the screen lock to anything other than slide, it will revert to slide after setting. Strangely, I'm still asked to input the pattern to change the setting even when it says slide.

And if I enable this module, set the screen lock to pattern, my VPN works, and I have slide unlock, but it won't survive a reboot - I had to manually set the screen lock setting again to make it work again.

: / Maybe I'm doing something wrong? I'm on CM11 nightly (4.4.4)
[Xposed Framework Modules] tangcla:
Try an older version. 1.4.6 is the one that works best for me.
[Xposed Framework Modules] RadarNyan:
Thank you! I installed version 1.4.7 (since it says there was some critical Bugfix from v 1.4.6) and it works, then I noticed that there was once the pattern lock on boot and I can't disable it. Then I guess that's just required so

I went back to latest version 1.5.0 and checked "Lock on first boot"

Now it works like a charm :D cheers~
[Xposed Framework Modules] GTvert90:
Glad I'm not the only person with this issue. Any idea if it works normal on CM?
[Xposed Framework Modules] kiran3111:
Does not work on MIUI v6

Hi guys, lockscreen disabler does not work on my Miui v6, MI3 device. Could someone help resolve this issue. Or suggest an alternative app that works on MIUI. I have WSM TOOLS installed.
[Xposed Framework Modules] ts_mpls:
I had the same exact problem with LiquidSmooth. What fixed it for me was to enable the "Lock before unlock" setting in Settings / LiquidSmooth / Lock Screen.
[Xposed Framework Modules] Ok_Kaleidoscope5109:
This works with CM but I don't think the slider shortcuts work??
[Xposed Framework Modules] ts_mpls:
They work for me on LS. But the settings are under the LS specific section so it might be different under the covers?
[Xposed Framework Modules] Ok_Kaleidoscope5109:
So I should be more clear. The Lockscreen Ring in CM works to unlock my phone, but I cannot get it to launch any of my pre-programmed shortcuts. I'm wondering if this is a limitation from Device Encryption. Is your device encrypted?

Previously the shortcuts definitely worked with Lockscreen Disabler when I just disabled the lockscreen because I wanted to use VPN. But since I added full device encryption, I don't think the shortcuts work.
[Xposed Framework Modules] gsosna:
I have similar problem. Using HTC-M8 CM-11. Using Lockscreen Disabler - working, and VPN working too - which is great. But the "Slider Shortcuts" (Settings > Lock Screen > Slider shortcuts) in Cyanogenmod 11 (other than unlock itself) are freezing the phone for about 10-15 seconds, and then the phone returns to the lock screen. The google slider still works fine.

Is there anyway to make the Slider Shortcuts compatible with Lockscreen Disabler?
[Xposed Framework Modules] Ok_Kaleidoscope5109:
My problem exactly. But somehow I swear the problem only started once I encrypted my device.

Is your device encrypted?
[Xposed Framework Modules] gsosna:
It is not encrypted right now. It will be soon.
[Xposed Framework Modules] ts_mpls:
My shortcuts work just fine but no, my phone is not encrypted.
[Xposed Framework Modules] hubs032:
Can't download

Trying to download this module, but it just spins, can't get it to download. Please help. Let me know if you need additional information.
[Xposed Framework Modules] Ok_Kaleidoscope5109:
Odd. Yeah I'm on the latest CM nightly and seeing the problem where my lockscreen shortcuts do not work.
[Xposed Framework Modules] tangcla:
Try rolling back to older versions. I'm using 1.4.6 as that one works best for me (Samsung with TouchWiz).
[Xposed Framework Modules] gsosna:
1.4.6 working OK

Thanks [MENTION=1204099]tangcla[/MENTION]. I rolled back to 1.4.9->1.4.8->1.4.7 - and neither version was working. Then I rolled back to 1.4.6 and it's working! I'll give it a whirl for the next few days and we'll see if it is good. Thank you!
[Xposed Framework Modules] Ok_Kaleidoscope5109:
Pinging [MENTION=2593381]LucasR93[/MENTION] if he can take a look :)
[Xposed Framework Modules] tzabee:
Hello, thx for the app :)

Could you add fingerprint scannig?

I can't find howto enable fingerprint scanner when I use VPN certs or encrypt device.

Thank you :)
[Xposed Framework Modules] Boosoth1st:
I agree, It would be very helpful to have the same options as the phone itself

I agree, It would be very helpful to have the same options as the phone itself.
[Xposed Framework Modules] gsosna:
It's been working perfectly for a week now. So confirming the bug has definitely been introduced in 1.4.7.