yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] Typhus_:
Thank you for your replies!!!

Hello everybody!

I'll try to answer everything.

That's on my to-do list. I'm thinking, as well, on making a big change some time soon in order o enable/disable customization and to have 2 distinct layouts to customize horizontal and circular bars separately.

I've already merged your improved translation. A new small update will be available as soon as I get time. Besides your translation, a new Russian translation is also available. I'll have to credit both of you and update the module as soon as possible. Thank you.

The logs you're seeing is because you're not using Lollipop, therefore, those files don't exist on your phone. You see, in order to get this done on Lollipop I had to come with a workaround using resource replacement. It looks for those drawable files and it replaces them for others.

A Reset option indeed makes sense...although if you don't save your changes when you enter the app again it will be as it was before. Anyway, I'll try to come up with that feature.

As for the app name, since the original name was not "mine" I've decided to keep it so that people would not strange. I've only decided to translate it... I thought it would be cool but I may disable that if it causes any troubles to anyone.

The thing is, everything on that code was castorflex work. He was the one who came up with this "smooth progress bars". MohammadAG and me only adapt his code into a Xposed module. I could try and look into it but I doubt I could fix that. Anyway, I've tested it on different devices and I've noticed that if we test changing speed and/or interpolators we are able to achieve a smoother effect without glitches. It's a case of try and test until our device "likes" it. I remember that these animations are all coded. There isn't a single image there and so, the device has to decode it in order to show us those animations. That uses CPU (i think...) and so, it's possible to notice more glitches if our device is busy, on background, doing other stuff. You could try and activate GPU for all 2D drawings on developer settings and see if that helps.

The original module was hidden...that was something that bothered me. I don't like to be forced to open other app so that I change something on another. Anyway, I guess I could come up with an option to enable/disable it on the drawer...don't know if that's possible, but I'll try.

Thank you. As for the glitches, I've already addressed that subject.

Well I suppose you did touch the "save" button, right? If you did and if you don't see nothing happen, maybe it's because you may have disabled resource replacement on Xposed Installer. This module only works on Lollipop if you allow resource replacement.

Thank you all for your replies. It really means a lot to me.

I remember you that I'm still on a learning phase so, please, bare with me ok? I'll try to improve this module as much as I'm able but I just can't promise everything nor that those possible improvements will happen anytime soon.

Cya!
[Xposed Framework Modules] sutobe:
Thanks for answering!

The Ressource APIs weren't deactivated, I also noticed the save button ;)

I received the E-Mail that I've been quoted in this thread while my phone was booting up from recovery (I flashed something from there). Now it works. I don't know why, I did at least one restart right after I updated the module.

:good::good:
[Xposed Framework Modules] :
Thanks for detailled reply and take your time for update, it's not hurry!
[Xposed Framework Modules] SkorpEaGLe:
Hello, i think that will be more better to have ability to change size of Circular.
[Xposed Framework Modules] 0xetrov1:
Wow, nice, that is something outstanding :good:
[Xposed Framework Modules] NEMESIS_9000:
Rounded edges

Hi, how about rounded edges on the horizontal bar elements? That would fit the circle “theme“ better.
[Xposed Framework Modules] Prasad98:
[MENTION=5057272]Typhus_[/MENTION]

Thanks for the suggestion man!

Changing the speed to 0.6 made the circular spinner smooth!

Loved ya work man just keep going!
[Xposed Framework Modules] w0rinal:
Cool you're continuing this module :thumbup:

Looking forward to seeing the improvements on your to-do list :)

Sent from my Boeffla powered Slim (4.4.4) GT-I9300
[Xposed Framework Modules] kelpium:
The circle doesn't seem to work properly it doesn't move in a smooth fluid motion in most apps except for YouTube

Using LG D415

---------- Post added at 07:36 PM ---------- Previous post was at 07:00 PM ----------

Fixed!

I took your advice of turning GPU on in developer settings
[Xposed Framework Modules] Typhus_:
I know what you mean and why you're suggesting it. I feel the same way. I don't know how to achieve that but I'll try.

Weird. Well, but it's working and

THAT'S

what matters.

Well, that would be quite hard to achieve since it would imply that I would have to change original's castorflex's smoothprogress library. I'm not really sure how to do that. The circle, on the other hand, I believe it has already that feature (rounded or normal edges). I just need to add an option for that type customization.

Thank you for all your replies and suggestions.
[Xposed Framework Modules] Typhus_:
Version 1.4.3 released

Check OP for more info.

Cheers!
[Xposed Framework Modules] blnk2007:
That didn't work for me.. :(
[Xposed Framework Modules] Prasad98:
Try reducing the speed to 0.8 or 0.6 in the module itself!
[Xposed Framework Modules] JoxeeM:
Love this app, really cool. But this module change the color in every app for example, in twitter the circular progress bar should be blue. Isn't a way to disable my choice of color in that app?
[Xposed Framework Modules] n0j0e:
The speed changing is working only in some situations. Please make an option to disable circle theming. So we can wait for a proper version! ?

[size=-4]Send with much love & Android.[/size]
[Xposed Framework Modules] rambojambo21:
Is there a way to get the lollipop progress bar on KitKat?
[Xposed Framework Modules] Typhus_:
This module replaces the default system indeterminate progress bars (horizontal and circular), meaning, it replaces them at framework level. And so, if an app doesn't have it's own indeterminate progress bar it will use the one provided by the framework. It isn't possible to choose different colors (or any other custom attribute) for different apps.

In theory we could achieve that if I used the same logic that Holo Themer does. That would force the module to change things app per app. I don't know if I could implement that feature...maybe I can, never thought about that. I guess I could launch an UI where the user chooses if it wants to implement things at framework level or by app.

Anyway, by now it isn't possible. Not sure how to achieve that (I remind you I'm still learning as I go...) but I guess I could look into that.

A feature to enable/disable circular (or horizontal) mod is on my to-do list. Regarding the "proper version", please read THIS post. Pay attention to my answer to "alqoshi4life".

Well, you could try to customize it and make it look like the one in Lollipop...by now that's the only way to go.

Yes, that. Also, please read the post I've mentioned before.
[Xposed Framework Modules] w0rinal:
[MENTION=5057272]Typhus_[/MENTION] is it just me and my phone is behaving strangely or did you forget to change version number?

Although xposed installer says it's version 1.4.3, when I look into app settings after installing it says it was version 1.4.2. And xposed installer stills shows there was an update to 1.4.3

[size=-4]Sent from my Boeffla powered Slim (4.4.4) GT-I9300[/size]
[Xposed Framework Modules] Typhus_:
When I upload the apk to Xposed Repo it automatically detects version name and version code, I think it reads the info from AndroidManifest.xml.

Having this said, if I had forgotten to update that info, I believe the repo would notice that.

Anyway, if you try to install the apk again, not using Xposed Installer but by using a file Explorer (e.g. ES File Explorer) a popup will show you what version name and version code the apk has. I've tried that just now and it's correct.

Cheers!
[Xposed Framework Modules] w0rinal:
It's probably a problem with the other modules I have installed

Uninstall 1.4.2 and installing the latest version did it

[size=-4]Sent from my Boeffla powered Slim (4.4.4) GT-I9300[/size]
[Xposed Framework Modules] Typhus_:
Version 1.4.4 released

Check the OP for more info.

Many thanks to [MENTION=3907705]HaPe111[/MENTION] for the tip on the circular fix that [MENTION=3327002]Castorflex[/MENTION] had already released on a different branch (that's why I didn't noticed it before...).

Hope it fixes it for good.

Cheers!
[Xposed Framework Modules] szunyi77:
Hi! Note 2 works great Resurrection Lollipop Remix v5.3.8 Rom! Thanks for the Hungarian language!

Galaxy note 2, Resurrection rom, Agni kernel
[Xposed Framework Modules] skyalvinlee:
Circular glitch still there for me, HTC one m7 kk
[Xposed Framework Modules] Prasad98:
So it happens on the 'M7' too? O.o

Thought it was due to a weak device.....

This means the module needs to be worked out!

---------- Post added at 03:46 PM ---------- Previous post was at 03:21 PM ----------

EDIT

:

Updated to the latest version released just now 2 min ago and it has fixed the spinner completely 100% smooth! ^_^ (y)

Keep going [MENTION=5057272]Typhus_[/MENTION]

---------- Post added at 03:49 PM ---------- Previous post was at 03:46 PM ----------

Hey also add to the OP tested on ics and jb on my XPERIA J!

Works on cm11 too!
[Xposed Framework Modules] w0rinal:
If 1.4.4 is supposed to have fixed the hopping circular bar completely, I am sorry, it's still occurring on my device.

It's happening at high and also low speed values and with every interpolator

[size=-4]Sent from my Boeffla powered Slim (4.4.4) GT-I9300[/size]
[Xposed Framework Modules] Typhus_:
Hello!

[MENTION=3327002]Castorflex[/MENTION] fixed the circular glitches, check it HERE.

The module has been updated to include that fix and I've noticed that, at least on my device, I don't see any glitches after this update.

I'm terrible sorry but I'm not that advanced developer to figure it out why it still happens on some devices.
[Xposed Framework Modules] Prasad98:
He must not have updated the module....

Working smoothly here on a s#itty 1GHz single core, 512mb RAM

:p
[Xposed Framework Modules] alqoshi4life:
I'm not exactly sure *how* this module modifies the circular indicator, but I noticed that it is trying to mimic the stock circular behavior of my LG g3. On my phone, the circle animation cascades into itself. With the module, I feel like the "glitches" occur because the stock animation just isn't compatible with the type of animation that the module is trying to implement. I updated to 1.4.4 and nothing has changed with respect to the behavior. I tried different settings as well. Either way, thank you for your work on this module and I hope one day it would work for all phones!
[Xposed Framework Modules] kelpium:
After the 1.4.4 update it went back to stock the circle animation

:confused:

UPDATE

The whole app isn't working the circle animation and progress bar is stock
[Xposed Framework Modules] skyalvinlee:
hey ur doing a great job picking this up where mag left off, the glitch still happens on 1.4.4, noticibly within the xposed app itself

i also notice that the loading circle is perfect only the 1st time it appears after every reboot

hope that helps?? :confused:
[Xposed Framework Modules] Typhus_:
Something is wrong at your end. Just yesterday I've updated the app on 4 different devices, everything went well. Is this the only module that's not working?

This modules hooks into android progressbar class, then it looks for the drawable used for it's indeterminate state.

From ICS to KK

, if the drawable type is AnimationDrawable, it means that the indeterminate progressbar is horizontal, therefore it get's the default drawable replaced by an user customized instance of Castorflex's smoothprogressdrawable. On the other hand, if the drawable type is AnimatedRotateDrawable (the Gingerbread ones...) or LayerDrawable (ICS+), it means the indeterminate progressbar is circular, therefore it get's the default drawable replaced by an user customized instance of Castorflex's circularprogressdrawable.

On Lollipop, both progressbars (horizontal and circular) use AnimatedVectorDrawable type. And so, since I could not distinguish which progressbar I could replace the drawable, I've made a workaround using Xposed resource replacement feature. And so, on Lollipop, all drawables used for progressbar bars are replaced by the ones used on ICS+. By doing this, the module is now able to distinguish which progressbar is called by the system and it then overrides the drawable using the same criteria I've mentioned above.

Having this said, and since all is being hooked into the default android AOSP code, if a device has a lot of modifications introduced by it's manufacturer, it may cause this module to not work flawlessly.

All devices I've came across are very close to AOSP ROMs, and so, in order to get this 100% on all manufacturers it would imply a lot of testing and debugging for each manufacturer.

Never saw that on any of my tests. The only thing I've noticed it was the "glitch" that has been reported HERE. And that glitch, is fixed.
[Xposed Framework Modules] _jis_:
I can confirm that the latest version works perfectly without any graphic glitches or hiccups on my Motorola Moto G LTE 4.4.4. Thank you so much Typhus for your great work, you breathed new life to this mod :good:
[Xposed Framework Modules] n0j0e:
How can i help with Lollipop 5.0.2 Sense Rom (ViperOne 8.0.0). The hickup/glitches is also on my wife's Kitkat 4.4.3 Sense Rom (ViperOne 7.0.2).

[size=-4]Send with much love & Android.[/size]
[Xposed Framework Modules] Typhus_:
Well you could look into your framework and see what are the drawables used for the indeterminate progressbars by default.

Then you should look for differences between them and the original android ones.

I think that you should have a DeviceDefault Theme that overrides the default "Theme" or "Theme.Holo" or "Theme.Material" themes. Either that or you may have a resource framework (e.g. com.htc.resources.apk or lge-res.pak) that could be modifying the progressbars as well.

This would be my first attempt to look for something.

Good luck!
[Xposed Framework Modules] tonyp:
It's a nice addition, thanks for this! Although when my device is in the new lollipop battery save mode the spinner goes crazy :D
[Xposed Framework Modules] Drahric:
Still glitchy but a lot less so, I plan on looking at your source later to see if you are doing the hooks correctly. Great job on this thus far!

EDIT: I don't know if this helps but every third rotation glitches out and never finishes and goes to the fourth set

Sent from my TF300T
[Xposed Framework Modules] Prasad98:
I've noticed that it glitches when "settings> dev options> animation scale is set less than 1

---------- Post added at 06:32 PM ---------- Previous post was at 06:32 PM ----------

On 1.0 scale it is smooth
[Xposed Framework Modules] amoreno1093:
so uh...

So uh... if I have this module installed, Instagram crashes every time I post a pic. I uninstall this module, and Instagram is fine. I love this module but I work on Instagram, so using this module is a sacrifice I'm not willing to take. Any ideas why this is happening?
[Xposed Framework Modules] z-vet:
Hi. Trying to install today's update gives me this:
[Xposed Framework Modules] n0j0e:
Yeah, that's the trick but everything is so slow on 1! [emoji19]

Edit: Only the last parameter of the three animation options in the dev section need to be 1.0!

[size=-4]Send with much love & Android.[/size]
[Xposed Framework Modules] prajwal mohan:
Z-vet.. Deactivate and uninstall the current version and install the latest version. Activate and reboot. Enjoy
[Xposed Framework Modules] z-vet:
Yeah, that's what I did.
[Xposed Framework Modules] _jis_:
[MENTION=758827]Typhus[/MENTION]: Your release doesn't have those old problems with unable to scroll between color bars and with saving entered colors inaccurately, but one thing still bother me. When you try to add 4 colors as are in above example, why it is impossible to add them in exactly the same order? If I enter blue, red, yellow, green I'll get red, blue, green, yellow. There must be still something strange and undocumented in the code in regards of color bars management.
[Xposed Framework Modules] Typhus_:
Beats the hell out of me...sorry. :confused:

And it still isn't possible to install? I assume you we're using one of MohammadAG's versions (1.3.* or less), right? Are you on Lollipop? It's just that, once, on Lollipop, I've installed a version with a different signature and, afterwards, I simply could not install a newer version with a different signature, that's why I'm asking.

The colors are added by a "LIFO" structure (or order...you name it...), aka, "Last In First Out". Meaning....the last color added will be the first and so on, and so on...

The first color, by default, is "Holo blue". That one has to be changed or, deleted, if you add another color first.

Cheers!
[Xposed Framework Modules] _jis_:
I am afraid that it is not true:

Could you try it?

Holo blue cannot be deleted. Again, could you try it?

I think that color bars editor need code refactoring.
[Xposed Framework Modules] z-vet:
I'm on KK. Once I uninstalled previous version and installed a new one everything works just fine.
[Xposed Framework Modules] Typhus_:
Hello!

If the first thing you do is to add a color, the prgressbars will have 2 colors. The default holo blue and the color you've add.

The order will be:

1 - Holo Blue

2 - Color you've added

When this happens, you then are able to delete the default Holo blue.

As for the order of the next colors...yeah, just noticed that something along the code is messed up and it isn't adding them by order.

I will try to look up into that. Sorry.
[Xposed Framework Modules] _jis_:
Yes, that way it is possible to do it, but it even more messed color bars order according my testing.

Thank you so much, but no need to apologize because this old error is from the original developer. I noticed it one year ago.
[Xposed Framework Modules] Typhus_:
Yeah, I've noticed that as well.

Well... :eek: As for now, I really don't know, yet, how to fix that. But I'll try to investigate it further. In the mean time I've been adding a new feature...

A new version will be up soon.
[Xposed Framework Modules] amoreno1093:
Okay, it only happens when any version 1.4.0 or up is installed. If I have version 1.3.1 or earlier installed, Instagram is fine.

I'm guessing it has something to do with the circular loading bar? Maybe? :confused:
[Xposed Framework Modules] Typhus_:
Version 1.4.5 released

Check OP for more info. ;)

[MENTION=6488650]amoreno1093[/MENTION]

Well, I suppose so. The main difference between 1.3.* and 1.4.* is, indeed, the circular indeterminate progress bars.

It's weird that it only happens on Instagram...

----EDIT----

I've tested it right now and Instagram FC when I've posted the pic. The good thing is that the pic was posted anyway. One more thing to look at...sighs...
[Xposed Framework Modules] Rom:
Hello [MENTION=5057272]Typhus_[/MENTION]

I have your last release, how can i change the round-shaped progress bar ?
[Xposed Framework Modules] Typhus_:
What do you mean?
[Xposed Framework Modules] Rom:
The circular progressbar, for exemple, when you open Play Store app, its the first circular progressbar, how modify it to stock ?
[Xposed Framework Modules] skyalvinlee:
---------- Post added at 10:28 PM ---------- Previous post was at 10:27 PM ----------

this sloved my issue, was the animation speed setting, had it at 0.5, now at 1.0 thanks buddy!!
[Xposed Framework Modules] Drahric:
Can confirm this, if you are getting weird circle animations. Set animation speed to 1 and reboot.

Maybe add this info to OP?

Sent from my TF300T
[Xposed Framework Modules] aperture22:
I get the cut circular loading animation on YouTube too. Speed is set to 1.0. Screenshots attached.
[Xposed Framework Modules] n0j0e:
Speed animation settings in Android Developer Settings, man, not in the module!

[size=-4]Send with much love & Android.[/size]
[Xposed Framework Modules] Cyboy:
separate settings for eirher horizantal and circular progressbars

its really needed

thanks its nice work!

---------- Post added at 07:26 AM ---------- Previous post was at 07:20 AM ----------

what exactly did you mean?it must be or allready being?
[Xposed Framework Modules] n0j0e:
Be. ?

Settings, Developer Settings, More, Animations.

The last option must BE 1.0 for smooth, liquid and perfect Pixar circle animation.

[size=-4]Send with much love & Android.[/size]
[Xposed Framework Modules] Typhus_:
With this module? You can't...at least not yet. I'm trying to learn how to code preferences in order to enable/disable the mod for horizontal/circular.

Never saw that on any of my tests. Have you tried the animation speed set to 1.0 (on developer settings)?

Yes, indeed it is. I'm trying to implement that.
[Xposed Framework Modules] aperture22:
Tried both the modes (with/without developer settings) and clearing cache. The result is the same. I even tried changing the screen dpi to see if that had anything to do with it. But its all the same. The circle animation is fine everywhere except the youtube app.

Running Stock CM11s on OnePlus One. Youtube app ver. 10.08.53

Have attached the screenshot of my settings and the cut animation.
[Xposed Framework Modules] Typhus_:
That's a really weird behavior.

I don't see any of that on my youtube and the app version is the same.

Are you using any youtube related module?
[Xposed Framework Modules] Rom:
Ahh okkk :D

But if I'm not mistaken, in one of the latest updates, you included this circular loading .. Right ?
[Xposed Framework Modules] aperture22:
Disabled all the modules and restarted. The default grey anti-clockwise animations works just fine. Then I just switched on just this module and the problem is back. So its not any other module affecting it. Also choosing the reverse mode doesn't affect the circle animation. Check the video for understanding better.

https://youtu.be/x5winJumr3g
[Xposed Framework Modules] Typhus_:
I've included default Holo animations only to use them as a workaround for Lollipop Roms.

Some of the options only work on horizontal progress bar, the checkbox options for example.

I will try to create 2 distinct layouts, one for horizontal mod and other for circular mod, each one will have only the options that affect each animation.

As for youtube circular animation issues, I really don't know what could be causing them, I'm sorry.
[Xposed Framework Modules] Rom:
And can you add this feature for JB ROM please ? :)
[Xposed Framework Modules] Typhus_:
What feature? I'm sorry but I don't understand. This module objective is to replace stock progress bars by custom ones...

I' must be misunderstanding your request....

Sent from another dimension...
[Xposed Framework Modules] w0rinal:
I have no idea why but the hopping has stopped for some reason

It's even more awesome than I thought :thumbup::thumbup:

[size=-4]Sent from my Boeffla powered Slim (4.4.4) GT-I9300[/size]
[Xposed Framework Modules] Typhus_:
Well, that's great news.

:)
[Xposed Framework Modules] Typhus_:
Version 1.4.6 released

Check OP for more info.

I still haven't fixed the "add colors by the correct order" issue nor have I found out the reason why Instagram FC's.

Anyway, I've added other stuff people have requested.

Hope you enjoy it.

Sorry for double post.

Cheers!
[Xposed Framework Modules] Rom:
Thank you very much, your new option to disable the rounded animation works, thanks :good:
[Xposed Framework Modules] kassaaam:
Bug report: Circular animation keeps rotating at the speed of light even when I set the slowest speed
[Xposed Framework Modules] ATGkompressor:
+1 Circular works fine in certain apps, Flipboard is one and there are a couple others. But for the most part, circular goes crazy.

Galaxy S4, NC5, Hyperdrive 20, Safestrap