yashsingh1/xdaforums huggingface dataset:
[Xposed Framework Modules] federigo:
Progress bar tracking not working

On my Nexus 5, GB 3.5.0, Xposed v54, stock Android 4.4.4 KTU84P,

the progress bar tweak is not working if I enable the new "Progress bar tracking" in the default UNC setting.

Also to let it work again, of course just for the download manager (as it was before this release) I have to disable the setting and reboot.

I took a look at your source code (I buought the unlocker from the Play Store yesterday just for this new option) but I couldn't find anything wrong with it.

Is there any way to enable the DEBUG flag on the released (final) APK? I see it's a static bool variable set to false in code.
[Xposed Framework Modules] mdamaged:
FYI, CM is as far from stock as you can get without it being IOS. :p
[Xposed Framework Modules] C3C076:
Strange. Progress bar for download manager and Bluetooth is set implicitly, you don't need to use UNC for those. Only in case you want to enable it for other apps. I'm not sure I got the part about "reboot". This feature does not require reboot. Regarding debug version, I can provide you with alternative apk with DEBUG flag enabled. Just let me know if you're still interested.
[Xposed Framework Modules] federigo:
That's why is strange to me too: *IF* I enable the option in UNC, it stops working even for the packages in the SUPPORTED_PACKAGES variable, but I don't see why in your code.

You're also right it's strange about the reboot. I'm missing something and I'd like very much to have an APK with the same code of 3.5.0 except with the DEBUG flag enabled for that modules.

Thank you very much. I'll let you know what I discover.
[Xposed Framework Modules] C3C076:
Works with all of them except for CM browser as its download notification is somewhat strange. It doesn't have ongoing flag set for some strange reason, which is a requirement for GBs progress bar feature.

Solid explorer works when you minimize transfer dialog as notification is there only when transfer dialog is hidden. Progress bar can't show when there's no notification.

Edit: I didn't test with mi explorer as I couldn't find anything like that in the play store.
[Xposed Framework Modules] C3C076:
Just a guess. Do you have any persistent notification that's always there? It could have progress bar and steal it from other apps (there can only be one progress bar at a time). If yes, use UNC to override that app and disable bar tracking for it.
[Xposed Framework Modules] sixday:
Please add the choice of transparency status bar
[Xposed Framework Modules] federigo:
While waiting for the APK, I was just headed in the exact same direction. I'm currently experimenting with enabling/disabling per-app settings, trying to take a look to the logcat. I'll update in a few minutes I think, I'm almost done.
[Xposed Framework Modules] C3C076:
Yeah, that's the only reason I can think of. Progress bar is constantly occupied by some persistent notification not allowing other notifications to use it. I will probably have to remove "Progress bat tracking" from UNC "Default settings" to force users to set it explicitly for apps they want.

Here's the APK with debugging enabled. Already contains changes I added today.
[Xposed Framework Modules] federigo:
Ok I had to reboot everytime (still don't see why by looking at your code, but just reading I might be missing something): but I managed to narrow it down to this very same reason (a persistent notification with no visible progress bar).

If I may, I think it's better to display a toast alert when there are two progress bar present or just log this type of error

It's just my use case, but I enabled the option globally because I don't know with which app it might work and I think it's a way to discover when I'd might be able to have this very usefull option.

I'd just prefer to leave it on all the time and then disable it for app that interfere with their persistent notifications.

Please make it an option if you intend to proceed in this way.

I'm now going to install the DEBUG version to see if I understand something more about the reboot part. Thank you!
[Xposed Framework Modules] BeInGarvey:
I'm Ioving this mod and its BY FAR the best AIO XPosed mod available! I would like to see the ability to apply custom images to Lock Ring/Unlock icon and Lock icon as well as adding system info such as CPU, RAM, SD as quick settings tiles or in the notification/status bar. Thanks c3c076!
[Xposed Framework Modules] C3C076:
Actually, it's not about notification having a progress bar. There's currently no check whether notification has progress bar when it is added to the notification shade. This means, when "Default settings" is enabled, any ongoing/persistent notification that comes first will steal progress bar view from other apps.

Possible solutions:

- remove "progress bar tracking" from "Default settings" to force the users to use feature for apps where it makes sense

- extend verifyNotification method to check whether notification actually has a progress bar (which puts more demand on processing) - this would be the best anyway as it would still allow progress bar tracking in default settings.
[Xposed Framework Modules] federigo:
Ok. Now looking at the code, at the logs (I installed your debug APK) and reading this I think understand why I had to reboot: being the notification persistent, it doesn't "free" the slot for the progress bar 'till the next boot (or untill you manually restart just that app, but I have 4: tasker, lux, ...).

So, case closed. Thank you very much for your help!

Do you think this mod should work also for uploads (e.g. Facebook, Dropbox, ...) ?
[Xposed Framework Modules] C3C076:
Should work for any persistent notification having progress bar. It doesn't differentiate whether it's download or upload. You can already test with bluetooth transfer - works when you are receiving as well as sending.

Notification is strictly required - as it allows to abstract from a specific implementation of a specific app.

It's impossible to make it work with progress bars that are part of internal UI of any app.

(Well in theory, it could be possible in case we hooked it directly on system's progress bar widget but that would probably cause chaos)
[Xposed Framework Modules] federigo:
Perfect!

Yep, I understand.

Thanks again for your work, and your time today.
[Xposed Framework Modules] C3C076:
OK. Made some further adjustments.

Persistent notifications without progress bar will no longer steal progress bar view from other apps.

Moreover, I changed the check so also non-clearable notifications are treated as candidates, not only ongoing ones.

This makes e.g. CM Browser work or other apps that use non-clerable flag but don't use ongoing flag.

You can test with attached APK.
[Xposed Framework Modules] federigo:
Really really nice! I actually like the "isClearable" idea. Seems ok here!
[Xposed Framework Modules] RusherDude:
Thanks for the idea.

It is horrible compared to the original. Only the animation is similar, it is not fluent, it is not fast, it is not intuitive (doesn't use the action bars like the original which is reaally useful to recognize the app, but uses a fake extra bar with another color...), uses hundreds of MB of ram for not much work.. and slow, takes several seconds to open :(

Very appreciated, but not even close :P. However I am surprised that it is able to change the stock recents window without root (or at least what the recent task button points to).. wtf??
[Xposed Framework Modules] xbizkuit:
I have a problem with custom lockscreen wallpaper

I set custom wallpaper with GB and says 'save' but when I wake up the device wallpaper appearing is samsung s5 default. Turn off screen and wake up again and appears my custom wallpaper. Crazy!

Im using xtrestolite rom with no original gallery

Help! Thank youu
[Xposed Framework Modules] :
Doesn't work on lock screen... :(
[Xposed Framework Modules] cakdavid:
Hi Devs, I just wanna report this issue when I set a pic for backgroud notification panel. please fix. thanks.
[Xposed Framework Modules] C3C076:
Please, read about module compatibility in the first post.
[Xposed Framework Modules] ffejy462:
Please review the op regarding compatibility and unsupported devices/roms.

lg g2 xdabbeb's vs980 v2.3.0
[Xposed Framework Modules] petrsiri:
This works great (tested with play store, Dolphin and Tapatalk)! Thanks a lot!
[Xposed Framework Modules] fappapp:
lockscreen ring targets problem

SO on my device when i set up the ring targets for lockscreen.

It gets rid of the "unlock" option, forcing mw to launch one of the apps, instead of having the gerernal unlock to homepage option included with the app targets which is annoying. Do i have the settings wrong?
[Xposed Framework Modules] bad1080:
[MENTION=5008415]C3C076[/MENTION]

i'm not sure weather this is gravity box's fault or not, but i cant get 'quiet hours' to show up on my quick settings anymore. i know i had it showing up no problem before and now i dont know if its version related or not. i recently updated to 3.4.9 and just today to 3.5, before that i had like 3.3.2 or it might have been even earlier than that. i thought its because i had motorola assist disabled (which is responsible for quiet hours on my device) but i reenabled it and its still not showing up (although the quiet hours are working as is). also i can add the rest of the buttons to the quick settings (like the compass, audio recording, music and so on) without a problem...

device: moto g (2013)
[Xposed Framework Modules] C3C076:
Well, looks like your lock screen comes with non-standard unlock ring. Not sure if something can be done about it. Never seen such issue before.

Basically, QH tile hasn't been touched since it was introduced. It's visibility is based on the following conditions:

- Ultimate Notification Control feature unlocked

- Quiet hours feature enabled in ultimate notification control

- Quiet hours tile enabled in Status bar tweaks / Quick settings management

If you are sure everything is setup correctly, provide the xposed error log.
[Xposed Framework Modules] A1ps:
Oh oh! I accidentally updated to Lollipop. Everything still seems to be working on GB. But is there a way to revert back to KitKat?
[Xposed Framework Modules] Ja_som:
How can GB work on Lollipop when Xposed is not available for Lollipop???

Which device you have?
[Xposed Framework Modules] kingvortex:
If you updated your device to Android 5, then it's impossible that GravityBox is working. The Xposed framework does not work with ART. I suggest you look in About Phone and see what you "accidentally" updated to.

Sent from my C6603
[Xposed Framework Modules] C3C076:
Well, looks like your lock screen comes with non-standard unlock ring. Not sure if something can be done about it. Never seen such issue before.

But maybe this new option will come in handy: https://github.com/GravityBox/GravityBox/commit/a14e3bf2e890bedc79f1196d2212bc2603206f5a
[Xposed Framework Modules] bad1080:
thats it, it must have reverted back its settings when i updated it or something (because i definitely havent touched that setting. i totally forgot about it and i only found it after you told me it was there). thanks a thousand times!
[Xposed Framework Modules] A1ps:
Very strange, it seems I updated to 4.4.4.

I've had the notification in my notifications bar for weeks asking me if I wanted to update. I thought this was for Lollipop seeing as I have a nexus do didn't update.

Oddly it seems it was actually for 4.4.4.
[Xposed Framework Modules] C3C076:
Yeah, related to:
[Xposed Framework Modules] JerryGoyal:
am i the only one who's GB progress bar is not working after recent update?
[Xposed Framework Modules] C3C076:
Read through couple of pages back. There are some issues which are already fixed for the next version.
[Xposed Framework Modules] fireforhire:
Also the clear recents button is broken. Doesnt move from the top right, even if you set it to off.
[Xposed Framework Modules] kingvortex:
It works just fine for me in every position and is removed when set to off.

What device and rom are you using? If it's the OnePlus One in your signature and you're using CM, then your device and rom isn't supported. Read the first post for more details.

Sent from my C6603
[Xposed Framework Modules] fappapp:
the unlock image is there when i disabled the custom ring targets back to Rom default,

Thanks for that adding that update, that should work. However ill leave it off as im a noob!

I presume how that page reads, the green lines are codes i must edit or add input myself to set a custom image for a new unlock symbol as a target?! No need to explain this to me really, im not going to try it on this phone, but just handy to know how that page of code actually reads, this is something I might try later down the line.

AND with that update.... were fixed. Thank you C3C076 my good man
[Xposed Framework Modules] kingvortex:
It's a commit that C3C076 added to the source code, which means it will be included in a newer version of GravityBox. Unless you're going to build it from source yourself, then you don't need to do anything with it. :)

Sent from my C6603
[Xposed Framework Modules] fireforhire:
What's happening is, no matter the setting the button is still in the top right. It will make 2 buttons if chosen to change the position. Setting it to off the button is still in the top right.

One plus one

Cm 11 12/12 nightly

Same issue on 11s for OPO.
[Xposed Framework Modules] kingvortex:
This module isn't supported for use with Cyanogenmod (or any custom rom). Read the first post, especially any sections in red text and those regarding compatibility for more information.

The feature isn't broken, it just doesn't work with your rom and C3C076 has said he won't make changes for compatibility with custom roms. ;)

Sent from my C6603
[Xposed Framework Modules] C3C076:
[MENTION=4285601]fireforhire[/MENTION]

Moreover, AFAIK cm has its own clear all button. That's probably the one you see when option is disabled in GB. GB can't control 3rd party elements.
[Xposed Framework Modules] C3C076:
As [MENTION=2452820]kingvortex[/MENTION] mentioned, it's a new feature that will allow you to manually set unlock ring target to whatever ring slot you like and even choose your own icon (example attached). All you need to do is wait for the next version.

But I still cannot guarantee everything under lock screen tweaks will work for you as your ROM seems to have some own modifications in this regard.
[Xposed Framework Modules] JerryGoyal:
Whenever i restart my Moto E phone "mobile data" turns on automatically and i believe this is caused by GB,can anybody take a look into this.
[Xposed Framework Modules] kingvortex:
Firstly, you're on an unsupported device but having said that, have you disabled GravityBox to make sure it's the cause?

I would imagine that logs will be required to troubleshoot this if that's the case. See this post for guidance on reporting a bug.

Sent from my C6603
[Xposed Framework Modules] JerryGoyal:
my bad,I should have checked by disabling GB. it's something else which causing this problem. though I know some logcat apps but wondering how can I check logs after booting the phone.

P.S my phone is supported.
[Xposed Framework Modules] kingvortex:
It's a good idea to double check what is causing your issue by basic troubleshooting such as disabling modules etc before reporting a bug, as time may be spent tracing an error that doesn't exist. ;)

You can capture a log during boot using adb. You can search XDA or Google on how to do this. This thread has some information. There are more if you search. :)

As for the Moto E being supported, it isn't listed in the first post as supported, unless I'm missing something.

Sent from my C6603
[Xposed Framework Modules] Haik0:
Shrink Back button on Navbar

Hello.

Why is my Back button shrinking as soon as I am disabling the "Navigation ring" o.O ?

Thanks
[Xposed Framework Modules] C3C076:
What device? Also, are you using some other mod for lollipop icons or the one from GB? I am not able to reproduce. Lollipop back icon in GB is designed to scale properly (it doesn't scale properly on stock android by default - due to how IME dismiss icon is designed).
[Xposed Framework Modules] Haik0:
Oh I'm sorry, it's HTC One M8 (Sense 6).

Yes I am using a mode called "Xstana", cuz GB's Lollipop navbars are not working on Sense. The option for disabling navigation ring works!!! , it does disable the ring, but when it does while using the moded navbar it is shrinking the back button and when I am disabling while on a stock navbar it makes it even bigger then normal o.O, so there is always a size change and only with the Back button. Is there no way to disable the ring and leave the button scaling alone ?
[Xposed Framework Modules] Ja_som:
Please read first post, and information which is displayed when you run GB about device compatibility.
[Xposed Framework Modules] ffejy462:
Maybe three warning pop ups are needed.... Jk. How about a report error button? Press button, supported device, link to gb thread. Press button, unsupported device, link to: http://www.princeton.edu/mcgraw/library/for-students/remember-reading/ or similar.

Nexus 7 5.0.0_r6 LRX21T
[Xposed Framework Modules] TNSMANI:
Notifications posted twice

In my Nexus 4 and 7 both running stock 4.4.4, the notifications for mail and Hangouts get posted twice simultaneously on the Status bar. If I get one mail, it is shown twice and two mails are shown as four mails etc. I know it is not some bug in GB, it must be some settings. But for the life of me, I am unable to locate the correct settings. Can someone point me in the right direction? I have enabled UNC for these two notifications.

Hi [MENTION=5008415]C3C076[/MENTION],

The apk given by you for the progress bar works great for Dolphin. Thank you once again! :good::good:
[Xposed Framework Modules] C3C076:
New version announcement

Version 3.5.1 available

Changelog 3.5.1 - 14/12/2014

- Lockscreen tweaks / Unlock ring targets: added option for custom unlock target

--- when option is enabled, one more slot becomes available (total of 8 customizable slots)

--- allows customizing target that serves for unlocking purpose by default

--- GravityBox Actions: introduced Unlock action which can be assigned to any unlock ring target

- Status bar tweaks / Progress bar:

--- improved identification of notifications that contain progress bar

--- other improvements and bug fixes

- Status bar tweaks / Data traffic monitor:

--- added option for Display mode which replaces previous "Download manager only" option:

------ Always (when connection available) (default behavior)

------ For Android Download Manager only (previously as standalone option)

------ When progress bar in status bar is showing (new)

- UNC Progress bar tracking:

--- extended to support more 3rd party apps (browsers/download managers/file managers)

--- fixed progress bar issues when tracking is enabled in Default settings

- Key actions: don't perform torch on volume down during call

- Updated Chinese (Simplified) translations (thanks to liveasx)

- Updated Italian translations (thanks to valerioscifoni)

- Updated Hungarian translations (thanks to benjoe1)

- Updated Polish translations (thanks to xtrem007)

- Updated Slovak and Czech translations
[Xposed Framework Modules] hzr34:
Navigation bar diretion control key not work anymore with new update.

D6503 cihazımdan gönderildi
[Xposed Framework Modules] kingvortex:
The cursor control keys? They work just fine for me.

Sent from my C6603
[Xposed Framework Modules] lulli1:
for me not. everything is perfect so long. thanks again for this last update, master!
[Xposed Framework Modules] souderisto:
The new version doesn't work on BQ Aquaris 5.7 (mt6589)
[Xposed Framework Modules] kingvortex:
You'll need to be more specific than "doesn't work" if you want any help. What doesn't work?

Also, be aware that GravityBox is only supported on some devices with untouched MediaTek roms. If your manufacturer modified the rom, then some or all features may not work.

See the first post for more information on supported devices.

Sent from my C6603
[Xposed Framework Modules] hzr34:
Yep cursor key.

D6503 cihazımdan gönderildi
[Xposed Framework Modules] kingvortex:
It definitely works for me. I tested multiple times in multiple apps. Nothing was in the changelog that suggests that feature was altered.

Your device isn't supported by this module, so that may be a factor, but neither is mine (I have a Sony device as well). Maybe C3C076 will have some input when he sees this.

Sent from my C6603
[Xposed Framework Modules] hzr34:
Actually my rom was compatible cursor key on gravity box but I updated my rom today maybe new version not compatible I don't know. Do you khow same options another xposed mod ?

D6503 cihazımdan gönderildi
[Xposed Framework Modules] kingvortex:
You updated your rom? Did you install the Xposed framework again? Updating a rom normally disables Xposed.

Also, unless you're running pure AOSP then your rom is not supported, even if most features may work. Read the first post for more information on supported devices and roms.

Sent from my C6603
[Xposed Framework Modules] khadafynor:
Sir thanks for this lot of feautures to use

Btw can i ask or suggest some new on the upcoming updates, can you add more signal icon/battery icon other icon hehe if ok :) thanks to this!
[Xposed Framework Modules] m0han:
my device is a clone of yours. or vice versa. i'm running stock kk rom of your device.

gb v3.5.1 runs ok. or so it appears from the log. :D
[Xposed Framework Modules] souderisto:
This is what I get when I open the new version

Thanks!
[Xposed Framework Modules] C3C076:
Thanks for the log but it won't help in case of GB settings crash. Logcat taken during crash is needed to identify the issue.

You can use any logcat app of your choice from the Play Store or use ADB.

Deactivate/reactivate module in xposed installer and reboot.

Also make sure GB APK is installed within internal storage. It won't work when moved to the external storage or SD.
[Xposed Framework Modules] :
Double tap to sleep on pattern lockscreen?

Hi there [MENTION=5008415]C3C076[/MENTION], Title says it all...

Is it possible to implement double tap to sleep on pattern lockscreen like CM11?

And is there any plan for GB on Lollipop?

Thanks for the awesome work Sir... :good:
[Xposed Framework Modules] SignetSphere:
GravityBox won't be able to work on Lollipop as long as Xposed Framework is not supporting it. Been asked pretty much every time so please use the search function next time.
[Xposed Framework Modules] :
Any hope of Xposed on Lollipop? Or is custom rom the way forward? :confused:
[Xposed Framework Modules] m0han:
read [MENTION=5008415]C3C076[/MENTION]'s post on these here and here.
[Xposed Framework Modules] C3C076:
Unfortunately, it's a hardware limitation which means nothing can be done about it.

Most of the devices "listen" to power button only when they are in deep sleep (CPUs offline) - it's designed like that at hardware level.

For all other hardware keys, CPUs must be online for the system to be able to process them.
[Xposed Framework Modules] nvo2411:
The new version progress bar features works flawlessly with all the apps till now.

The best xposed module according to many has another feather attached with this great feature.

Keep up the good work dev.
[Xposed Framework Modules] cadarn07:
As usual, thanks for the update!

Also, the User Guide has been updated as well, for those who use it: https://www.evernote.com/pub/cadarn07/gravitybox
[Xposed Framework Modules] MasterManson_Gunstorm:
have a possibility to change the settings from tabletui module from gravitybox? like bar size, font size, itens i.e. from another module like the tabletui from gravitybox?
[Xposed Framework Modules] NXghost:
A lollipop battery icon in the battery settings will be awesome too :D
[Xposed Framework Modules] mikejeep:
Love this mod, thanks for all of your hard work! If I could submit a feature request to be considered sometime.. perhaps a QuickSettings tile that toggles auto brightness on and off? Similar to how the Stay Awake tile works, I love that.

-Mike