yashsingh1/xdaforums huggingface dataset:
[G2 Android Development] -Jesco-:
kind of derp actually

and the instructions given to get 4.4.2 goodies was actually instructions for 4.2.2 as there aint custom recovery for 4.4.2
[G2 Android Development] xdabbeb:
ha...Someone had actually just PM'ed me about that. Still no idea who tipped Droid Life though.

[MENTION=4710962]-Jesco-[/MENTION] I thought that was pretty funny myself :)
[G2 Android Development] suhiiii:
Tested KK version and working fine , 4k & 120 fps :D good job
[G2 Android Development] xdabbeb:
Great. Glad it's working for you. Honestly, though, the 4kUHD/120 thing was about the easiest change to make. Just a few plaintext resource xml edits.
[G2 Android Development] WACOMalt:
Really? Are the changes documented anywhere?

I'd like to try my hand at adding this to Verizon stock on 4.2
[G2 Android Development] xdabbeb:
No, but I could easily tell you how. To be clear, though...it still won't work on 4.2.2, otherwise I would've done it long ago. The key has always been whether or not LG added the capacity in their (or more accurately, QualComm, Sony, etc's) binaries. In the past I had gotten the apk to pass along everything properly to the api/drivers and then it would fail. With 4.4.2, they thankfully left the potential for it in the binaries, but just didn't include the options in the apk. That's just in res/values/arrays.xml with the newest 4.4.2 apk.

If you (or any other dev) wants more info on it feel free to ask.

I still may try to get those two features on 4.2.2 (I'm on vzw as well), but if KK is coming soon I don't know if it would be a waste of time.

EDIT: The previous version (1.5.0) works just fine on 4.2.2 and contains many more changes. I should have a new version today for 4.2.2 as well
[G2 Android Development] WACOMalt:
Gotcha. So in order to get this working on pre 4.4.2 we'd need to first get the camera libraries and such from 4.4.2 ported back?
[G2 Android Development] xdabbeb:
Kind of. Unfortunately, pulling libs from one and putting them on another doesn't always work...especially across api levels. Also, there are a lot more changes needed in the 4.2.2 apk to make it work as the 4.4.2 apk won't work on earlier android versions.
[G2 Android Development] suhiiii:
I think its waste of time working still on 4.2.2 ,in a few days all would use KK :D
[G2 Android Development] WACOMalt:
Try a month. But yeah it is probably a waste.
[G2 Android Development] lemach:
Maybe...but i am not sure to update...Really it is so necessary? Overall performance it will not be very different from a JB custom rom...Xdabbeb's kk mod it is very interesting but only UHD video and 120 fps are not very important to me. If the last 4.2.2 camera mod improve the photo quality i will have got a complete smartphone.

So, i am very happy with the work of xdabebb in 4.2.2 camera.

Cheers.
[G2 Android Development] Kiwi_Dude:
Sorry to be a pain in the arse!

So just to confirm the steps....

1) Full Nandroid backup

2) Root

3) DON'T install custom recovery

3) Install MOD (for 4.2.2 or 4.4.2???)

4) Update OTA when 4.4.2 is available for the D802 Unlocked International model, and should retain root and MOD?

Would just like to confirm the steps before doing this as I don't wanna screw it up!!!

Thanks again.
[G2 Android Development] xdabbeb:
No problem...though as I mentioned to someone else, this isn't really the appropriate thread to be asking in. Your steps will only work if your nandroid was performed before any system files had been modified AND if the stock recovery is also restored properly. If all else fails, you could always back up all your important data off your phone, use one of the tot/kdz methods to do a full/clean install of a 4.2.2 stock rom, root only, then get the OTA.
[G2 Android Development] xdabbeb:
OP Updated with new version for 4.2.2 (I also updated the KK ver as I had mistakenly left something out before)

In my search for ways to disable NR completely (still looking), I stumbled upon a couple of interesting things while looking through some native code that applies to many QualComm chipsets. The most interesting was the following:

+cam_denoise_process_type_t QCamera3HardwareInterface::getWaveletDenoiseProcessPlate()
+{
+ char prop[PROPERTY_VALUE_MAX];
+ memset(prop, 0, sizeof(prop));
+ property_get("persist.denoise.process.plates", prop, "0");
+ int processPlate = atoi(prop);
+ switch(processPlate) {
+ case 0:
+ return CAM_WAVELET_DENOISE_YCBCR_PLANE;
+ case 1:
+ return CAM_WAVELET_DENOISE_CBCR_ONLY;
+ case 2:
+ return CAM_WAVELET_DENOISE_STREAMLINE_YCBCR;
+ case 3:
+ return CAM_WAVELET_DENOISE_STREAMLINED_CBCR;
+ default:
+ return CAM_WAVELET_DENOISE_STREAMLINE_YCBCR;
+ }

This gives at least some control over one (there are 3 that I've found) of the nr algos in play here. Stock LG cam/sw was defaulting to nr on all channels, and since luma nr is the most objectionable/noticeable I've changed it to only work on chroma.

There was also a reference to another build.prop variable that sets the photo pixel format. I've changed it to yuv422 as in theory it will provide better quality, but I haven't really noticed much difference.

Full changelog in the OP.
[G2 Android Development] aminmzh:
Can you help me for root my device in 4.2.2 vodafone official?
[G2 Android Development] lemach:
Good!

I will post when i have tested this new and amazing 1.6.0 mod!

Thanks xdabbeb for all, and for your technical explication.
[G2 Android Development] jamminjon82:
I looked at the spreadsheet however didn't seeif 1.6 works on vs980 12b malladus 1.2.7
[G2 Android Development] ozzyager:
Backup and flash it. I have a feeling it works just fine.
[G2 Android Development] WACOMalt:
I'm confused now. I see there are two mods for this. One by Jishnu and yours. Which is the best one? Looks like both support 4.2.2 as well now, and Jishnu's appears to have an AOSP version? Are these two approaches to the same idea or different?

http://xdaforums.com/showthread.php?t=2471900 is a link to the other one. Please advice which is best. I want stock camera, 4k, and 120fps. Photo improvements are appreciated.
[G2 Android Development] sdrawkcab3:
Reading about your journey through this project is like reading a great book! I'm sure I'm not the only one that appreciates the care you take to report your progress and stumbling blocks.

I can't wait to see some sample shots from 1.6 - if anyone can post some before/after shots, it'd be great! If not, I may cave and go stock at some point this weekend...
[G2 Android Development] Zoide_:
Would you like some fries with that? :rolleyes:
[G2 Android Development] WACOMalt:
Yes please :)

I only stated what I want because I know these features are already implemented. but am trying to list what I want to help me choose between the two mods from different devs. In case one doesnt have one of those features.

---------- Post added at 07:06 PM ---------- Previous post was at 06:58 PM ----------

Sorry I am a bit confused. The new version for 4.2.2, does that include the UHD 4K mode and 120fps mode? I have also recently found Jishnu's camera. Is this the same as your mod? His has 4k and 120fps, and supports even AOSP roms. I dont see HDR video listed on his camera though. Please advice what features are included in which versions of your mod. Please stop by #lg-g2 again if you have the time :)
[G2 Android Development] xdabbeb:
I'm not going there :)

I'd recommend trying them both out and deciding for yourself.
[G2 Android Development] WACOMalt:
Fair enough. Does your version for 4.2.2 support UHD and 120fps, and HDR video?
[G2 Android Development] xdabbeb:
Unfortunately there's no way to do uhd and 120 on 4.2.2 at this time
[G2 Android Development] WACOMalt:
OK, thanks. I got excited when you said you updated a 4.2.2 version :/ I guess this is probably true for that other mod as well then. Guess I still have to wait another month to try this out, fecking Verizon.
[G2 Android Development] muffinflesh:
I have a bug with this camera where when I switch to video the screen fades to black until I switch to front facing cam and then switch back and it will work.
[G2 Android Development] jayochs:
hint: this mod's better. it actually changes things rather than random build prop edits that don't do anything ;) lol
[G2 Android Development] Hid3rs:
1.6.0 works perfectly fine on my D802, thanks a lot! Your mod is literally the only reason I'm still on Jelly Bean, and also the only reason I'd like the have a rooted KitKat.

edit: It actually isn't that perfect.

First, it's not as fluid anymore, there's no way it's 60fps (it's not laggy, but you can tell the difference between 30ish fps and 60. Maybe it needs more light now? I know if I pointed the camera to my monitor and moved my hand in front of it, it looked pretty fluid in the viewfinder, now it doesn't);

second, if I switch to video mode, the picture is stretched out until I actually start recording. I'd show you a screenshot, but I couldn't take one while I had the camera app open.

It was a clean install, I've just flashed a v10e FW which I've always used, I even did a hard reset, so I don't think I messed up anything. I wiped dalvik/cache, of course.

I haven't istalled any other mods or xposed.

It takes pretty good pictures though!
[G2 Android Development] RPAusCan:
I just installed 1.6.0 (quiet) on my Rogers D803R10c. All working great! Thanks again for this latest update. Looking forward to (eventually) getting KK on this phone - hurry up Rogers!!
[G2 Android Development] bonny_k-9:
There will be no application port for custom firmware for example, CM11?
[G2 Android Development] robfactory:
I have the Sprint version LS and when I switched to video it force closes on me. I tried downloading the zip twice and get the same error. The camera seems a bit better in low light.
[G2 Android Development] lemach:
1.6.0 mod in d802:

FC if 720p 60 fps video is selected. It seems a problem of the apk...if i change the apk in the zip by the mod 1.5.0 apk it fixes the FC.

Have you made any improve mod to the apk? Can i let the 1.5.0 apk if no then?
[G2 Android Development] xdabbeb:
Thanks for letting me know. It's working fine on vs980, but I have an idea why it's FCing on other variants. I'll look at this in the morning...just getting back from the bars now :0
[G2 Android Development] Kiwi_Dude:
Ok me again!!!

I've just rooted with IORoot22, installed SuperSU and selected "Survival Mode" in it's settings, still on stock recovery. I'm currently on 4.2.2 and awaiting the 4.4.2 update OTA. Going by some of the comments, Root access should survive the OTA, so the question is should I wait to install this MOD until I have installed the KK update?

Thanks again.
[G2 Android Development] xdabbeb:
No worries, sir (mate?). You'll just owe me a personal tour of every LoTR location. Anyway...you don't want to install this mod before taking the OTA. Your system partition (more explicitly, every file that is patched) must remain untouched. Had you gone back to 100% stock before? Also, I'll likely forget I asked about the personal tour in the morning, so you're off the hook.
[G2 Android Development] Kiwi_Dude:
Thanks for the speedy reply!

As for the tour someday, I'd be more than happy to, if I can get the time off work that is!!! I had a feeling I may have to wait until after the OTA came through. This is the first root I have done (on this device, but not my first ever!!!) and made sure to just root and let it install SuperSU and checked root with "root checker", nothing else has been touched, so hopefully I'm safe! :fingers-crossed:

Anyway, thanks again for helping out a relative n00b!
[G2 Android Development] davidep85:
Hi, I have D802 and 1.6.0 mod. When I try to access video, it crash.

Another problem is that I can't see Exif in photos!! The Exif is always the same!
[G2 Android Development] GaYoung28:
Really want to have a 4Krecording and 120fps on HD but i can't root this KITKAT -_-"
[G2 Android Development] mannequin:
flashed 1.6.0 on t-mo D801 without any issues. however, the video stays out of focus once you start recording it no matter what the settings are. never experienced that with other versions.
[G2 Android Development] uoY_redruM:
I. 2.0.4 is an apk only. Is that suppose to be that way?

EDIT- Never mind, I see there is an XML file as well.

---------- Post added at 10:20 AM ---------- Previous post was at 09:49 AM ----------

How do you know if it installed correctly? I don't see a 4k recording option or anything like that.
[G2 Android Development] Keithgordon:
Absolutely Awesome!

I just did a side by side comparison and it is so much better now. I thought it was the compression utility used by LG before that was the problem and I was kind of disappointed in the camera, with this mod, the photos are comparable to a dslr, albeit somewhat smaller, but that could be my settings; i havent played with it that much yet. Thank you for fixing this for LG, they need to put you on their payroll
[G2 Android Development] ziociccio:
Hi,

i have stock rom kitkat,how i can root this room to flash 2.x camera mod?
[G2 Android Development] gonk24:
I can also confirm on LS980 that video causes crash. First try did shoot video but had lines throughout. Second attempt crashed. Third attempt froze the app.

I did restore back to stock camera before flashing 1.60.
[G2 Android Development] faithraze:
Video crashes 1.6

D80210E, cloudyflex 1.3, flashed back to 1.5.0 worked again.
[G2 Android Development] Bornin:
Well I don't have any problems with 1.6 on D802 with Black Pearl Rom
[G2 Android Development] mistermidas:
I had the exact same results, on the same phone model. Pictures took fine, didnt really notice any dramatic improvements but I didnt play with it long though. But video had moving vertical screen tearing, and HDR video was just a mess in general lol. Flashed back to 1.5.0 and everything was all good to go again.
[G2 Android Development] gonk24:
Unfortunately for me, my camera has now gone ape****e My stock backup says it restores in recovery but once booted into the system I get an app isn't installed error. Backup files are all in place where they are supposed to be, just like always. I've never had a single issue with the camera before. Oddly, flashing back to 1.5 or even 1.4 gives me either a can't connect to camera error or a force close. Not sure what the hell is going on. Trying a few things first before I restore a nandroid. Luckily I don't have much on my device so if I need to I can get it back up and running fairly quick.

You wouldn't be able to zip up the backup folder that the backup.zip creates and upload it somewhere would you? I really don't get why mine isn't working. It's always worked before.
[G2 Android Development] xdabbeb:
As I mentined, I believe I know why some variants are having issues. I have pulled the downloads temporarily.

If you want a quick fix, try replacing /system/lib/libmmcamera_interface.so with a stock/original one from your backup. If that doesn't resolve it then a new version will be uploaded shortly (with the storage menu...sorry, [MENTION=5632451]Hid3rs[/MENTION]). Basically, some extra test code was left in that could be exceeding the registers.
[G2 Android Development] mistermidas:
Damn man that sucks. All i did was use restore zip to recover my original stock camera before I flashed 1.6. After I found out 1.6 had issues, flashed back the restore zip again and did a full reboot after I wiped cache. Then went back to recovery and flashed 1.5 again, after wiping cache one more time. Did that process and all was well, no issues at all on 1.5.

Honestly Im usually a "if it aint broke dont fix it" kinda guy...and flashed 1.6 out of pure curiosity to see the improvements mentioned, when I was already perfect happy with 1.5. Im just glad I didnt run into any issues after I flashed back to 1.5 again
[G2 Android Development] gonk24:
I'm going to have to nuke the damned thing. I manually took every file that gets backed up from a stock Sprint rom and placed them into the backup folder that gets created. Restore.zip did it's thing, I cleared dalvik, rebooted and app not installed. Don't know what else to do except restore nand. Probably better off anyway. So strange that my backup was borked though.
[G2 Android Development] xdabbeb:
If you want to send me a logcat before doing that I'll take a look. That really doesn't make any sense though.

Also, OP updated with the fixed version (along with storage menu)
[G2 Android Development] Hid3rs:
Just flashed the new 1.6.0.

Even if I choose SD card instead of internal storage, it still saves them pictures on the internal. I'm sure it detects my pendrive, because when I disconnect it, the storage menu becomes inactive. Is it supposed to work only with SD cards?

Oh, and do you have any idea why the anti-shaking menu is inactive for me? (this is no news, it was the same when I used 1.5.0)

Earlier today I flashed a kdz and did a hard reset, so my phone was pretty much stock. Then I flashed 1.6.0, and I could turn anti-shaking on just fine, so I have no idea why it doesn't work on my current system (I restored a nandroid backup).
[G2 Android Development] xdabbeb:
Yeah, it's possible that this app will only work with SD Cards, but I can look into it further. Can you get me a logcat of you taking a photo and saving it externally (as far as the app is concerned). As for the anti-shake...are you attempting it in 1080p@60fps? It is inactive for everyone in that mode.
[G2 Android Development] Hid3rs:
Oops, you're right about the anti-shake, thanks! It was indeed a quick fix.

Here's the logcat.

Not sure if I've done it correctly. I started logcat > opened cam > took a pic > closed cam > stopped logcat
[G2 Android Development] Mangtas_666:
4kUHD for JB

Hi Xdabbeb just asking if it is possible to add the 4KUHD in JB version of D800? thanks in advance.
[G2 Android Development] gonk24:
I went ahead and restored my stock nand and made a new backup of the camera. Then I restored a 2nd nand I had made after that stock one, only with all my apps installed and everything set up how I like it. Camera is working fine now as it should be.
[G2 Android Development] sdrawkcab3:
No, JB is missing the libraries to do 4k. He's written about it throughout the thread in a couple places. You'll find some info if you search a bit.
[G2 Android Development] chaotic87:
deleted
[G2 Android Development] mannequin:
fixed the video focus!
[G2 Android Development] gonk24:
[MENTION=2941286]xdabbeb[/MENTION]

I'm still having restore issues and it looks to be due to my backup being from the Sprint ZV8 software. I'm running the current ZVA software and if I restore my backup which was from ZV8, I get app not installed errors.

I just made a new backup from 1.5, then flashed 1.4. I checked to make sure it flashed properly, then restored 1.5 and it worked fine.

Running 1.6 updated now and it has no issues so far. I'll have to flash a stock ZVA rom when I get time and make a stock camera backup and a new nand.
[G2 Android Development] bigsnack:
Is it possible to add this feature(if you haven't already) from the G Pro 2? http://www.youtube.com/watch?v=r7aLMTooPmQ#t=12
[G2 Android Development] Hid3rs:
Your KitKat version works like a charm on my D802 4.4.2!

Do you think the libs from 1.6.0. would work on KitKat? The quality kinda sucks without your mod, but I'm happy to have 4k and 120fps, so thanks a lot! :)
[G2 Android Development] robfactory:
[MENTION=2941286]xdabbeb[/MENTION] thanks for fixing the problem with the video. The only issue is that the camera app freezes when I take a photo with the Normal setting.
[G2 Android Development] xdabbeb:
If I'm understanding what you're saying correctly, were you trying to restore an older system (zv8) backup to a newer firmware (zva)? If so, I could imagine there might be problems. There have definitely been changes to the libraries between firmwares on the same variant (let alone between variants) that could cause issues. If ZVA is the latest, I'd recommend doing a backup of those files and use that for your restores from now on. If I'm misunderstanding what you're saying, let me know.

Possibly? A friend just showed me this as well. The changes to the apk should be easy enough, but I would imagine there are also libraries that would be needed as well. It looks like it's just combining multiple shots (like night mode, hdr), so the potential downside is the extra processing that we've all grown to dislike. Might be better with only two shots though if that's what they do.

I wouldn't guess so, but it can't hurt to try if you backup the originals. I've replaced many of the libraries while the system OS is running without SoD, etc. Just make sure you set the proper permissions and reboot after. What quality are you referring to specifically? Video or photo? Once VZW gets KK I should be able to do more.

OK. Try wiping app data/cache if you haven't already, replace the system/lib/libmmcamera_interface.so with the stock one from your rom (set 644 perms), and reboot.

I noticed you're also on Sprint. Is it ZVA like gonk24? It seems like this particular variant/firmware combo isn't playing nice. Anyone got a link handy to a system dump of it?
[G2 Android Development] gonk24:
The ZVA update was a small one to enable Sprint Spark. Looking through the files that came with it, there are a few lib files for the camera included.

I have the update in a zip I can put in Dropbox and get a link here in a bit.
[G2 Android Development] GaYoung28:
[MENTION=2941286]xdabbeb[/MENTION] can you please help me to root this KK rom? I can't use your mod :'(

I have PM you :)
[G2 Android Development] Hid3rs:
I've replaced all the .so files one by one (libmorpho_movie_stabilization and libmorpho_video_denoiser didn't exist), then set permissions, rebooted, but it hasn't really changed anything. The camera works fine, but there's no difference. I thought I'd either work or the camera FCs or something, but it's literally the same.

Well, low light shots looks disgusting, I didn't remember stock cam was so bad. Even in the viewfinder it looks bad and it's really laggy.
[G2 Android Development] anonymousss:
I still dont understand the idea of making two files for the camera apk

And that if you want to flash the quiet version u need to fladh the normal version first :d what the hell :D
[G2 Android Development] xdabbeb:
Unfortunately there is no root method for 4.4.2 yet. You would have to downgrade to 4.2.2, root, and then take the OTA. There are a number of threads on this in the General section that I'd recommend reading through.

Yeah, those two wouldn't be there. The morpho libraries aren't the ones I'd look into for photos (other than panorama). If you're up for it, try some of the libchromatix135's in /system/vendor/lib/. I'd try the snapshot one to begin with. Just make sure you have backups. Like I said, I'll be able to look into quality improvements more when I have KK myself. If you're up for it, I could get you a test version as well. Just PM me.
[G2 Android Development] robfactory:
[MENTION=2941286]xdabbeb[/MENTION]s ok. I redownloaded the zip file and did a completely new install of the ROM wiping cache, System, and Dalvik. This seemed to work.

Thanks for all of your work and patience.
[G2 Android Development] xdabbeb:
It's just to save time on my end, due to the scripts I run to build/zip everything. I've never used it myself and only post it as a courtesy. You're more than welcome to take over making the quiet version if you'd like.
[G2 Android Development] antawnm26:
Im confused..In your install notes you state to download the test version if your on KitKat 4.4.2 but you have a

xdabbeb's camera v2.0.4 - ONLY for stock LG 4.4.2 roms
[G2 Android Development] uoY_redruM:
The kitkat version was updated? Still shows 2-28. Just want to double check.

I don't have recovery access because of the kitkat update for T-Mobile but I have root. I just manually moved and changed permissions. I'm assuming that should suffice, right?
[G2 Android Development] xdabbeb:
Thanks for pointing that out...leftover text for earlier KK versions of the mod from Dec/Jan. It's no longer a test version. Just download the 2.0.4 if you're on stock 4.4.2

Yep that should work for installing it. What version had you downloaded before?