yashsingh1/xdaforums huggingface dataset:
[Nexus 5 Themes and Apps] tkoreaper:
By all means I know mine isn't perfect and that it won't work for everyone (At least not my specific settings) However, I do think the procedure that I laid out WILL work for everyone. As far as breaking the gradient/producing slight banding I understand that's an issue, but at the moment I'm willing to live with it after staring numbers for more than a week lol.

I'll try to convey all my findings as accurately as I can and hopefully I don't miss anything. You are correct about each "half" of the numbers acting differently... opposite to be more precise. Here is what I've learned:

Values 12-23 effect the amount of "color". The higher the number the less that particular color is added at that area of the spectrum and vice versa. I say "area" because they don't effect one specific line when you look at the gamma display on the display tester app. The numbers seem to overlap some so if you decrease a value in blue, for example, you won't just see more blue on the spot for gamma 1.6 or whatever, Instead you see more blue in multiple spots. I'm sure it's to be expected, but it makes it extremely difficult to calibrate things properly.

Values 1-11, on the other hand, are strange and effect the bottom portion (brighter) of the gamma display. These values, when increased, will add to the intensity of that color. They go up when the values go up unlike the other half of the numbers.

You are also right that the numbers don't exactly coincide with the area that they effect. Values 11 and 12 effect the center of the gamma (which is why the gamma changes) 13-23 effects the top portion with 13 being the very top and 23 being the top-center.

To put the values in order of which they effect the scale it would be this: 12-23 then 11-1 (from top to bottom) so if we were to redo the gamma app to reflect this it would be:

12-13-14-15-16

17-18-19-20-21

22-23-11-10-09

08-07-06-05-04

03-02-01

---------- Post added at 07:39 PM ---------- Previous post was at 07:36 PM ----------

Were you at stock settings before you put these values in? You may have to go in to apps in settings and delete the app's data and reboot. It got stuck on me before. If this still happens then look at your gamma values and follow the procedure in my post. Also, make sure you are putting the numbers in the right spot.
[Nexus 5 Themes and Apps] mag01:
[MENTION=3490263]tkoreaper[/MENTION]

well I think there's currently some bug either in the kernel code or in this app itself that causes this strange behavior (that change around the numbers 12-13). I'm going to update my post 485 with the proposal of the corrected graph and numbers.
[Nexus 5 Themes and Apps] tkoreaper:
I agree, but it may just be how they decided to display it in the app. For all we know it could just be 2 different portions of code put together in the app. I'm also wondering if the display options that were removed, that were in the initial versions of the app, were actually important.
[Nexus 5 Themes and Apps] hunter99507:
Any leads on amoled like colors?
[Nexus 5 Themes and Apps] notbrodie:
I used these settings with white point at 10 and it's kinda similar to the effect of f.lux. great for night use

Sent from my Nexus 5
[Nexus 5 Themes and Apps] F4M0U569:
I don't get it. So all red, blue and green will be?

60	67	73	80	87

93	100	107	113	120

127	133	127	120	113

107	100	93	87	80

73	67	60
[Nexus 5 Themes and Apps] yorici:
No you can have different sets of values for different colors. In my case green and red were the same, but that doesn't need to be true for your display. You have to do a bit fo trial and error here. You fill in a number for Tweak value T. Is gamma too high or too low, adjust it.

Though this formula will get you gamma 2.2, it does cause banding..
[Nexus 5 Themes and Apps] gpvecchi:
I'm still trying to understand what values stands for...

Are the 23 values the color switch from 0-255?

So first value is 0 and 23th is 255?

And what is the negative? Just the opposite scale?

Thanks!
[Nexus 5 Themes and Apps] F4M0U569:
I want more saturated colors but no banding
[Nexus 5 Themes and Apps] yorici:
The linear formula has the most saturation for now as the other methods are based on the stock values. Either wait for response from faux/myfluxi on the latest findings (post 485), take banding for granted or have less saturation with adjusted stock values.
[Nexus 5 Themes and Apps] Kusie:
Someone PLEASE code a simple config app for us noob users with just a few sliders to adjust RGB values and Whitepoint ...

Thank you! :)

Kusie
[Nexus 5 Themes and Apps] jm700wx:
The whole point of this thread is to help us figure out what these values mean and how they work so kernel developers and can work them into their kernel and the apps that control aspects of the kernel. Once these values are completely understood, I am sure you will see easy settings and sliders incorporated into kernel control apps (ie. Faux Clock, franco.kernel updater etc.) Until then, be patient and try to contribute what you can.
[Nexus 5 Themes and Apps] tkoreaper:
Although I haven't personally tried it, I do know that at 2.2 there is very slight banding that really can't be avoided. I imagine at a higher gamma it will be more noticeable and still unavoidable.

EDIT: I set my gamma to 2.4 and to be honest I see NO difference at all when it comes to saturation. Blacks just become blacker and so do whites. To my knowledge there are currently no settings that effect saturation.
[Nexus 5 Themes and Apps] Zephyr101:
These settings are amazing and they really make the colors a lot better(at least in my screen) if you'd wanna try that.
[Nexus 5 Themes and Apps] mag01:
Saturation can't be properly handled by this sort of adjustment alone. However you may achieve partially similar result when modifying the shape of the whole curve - with approach similar to increasing the contrast - by making the curve steeper somewhere around the mid-tones and flatter around shadows and highlights. If you dare to try that, be very careful and prepare a new curve mathematically and then test its effects on various gradients in order to avoid banding and posterization. The upper part of the tonal range reacts to any adjustments very strangely...
[Nexus 5 Themes and Apps] tkoreaper:
My values are already perfect and all I have to do is change the white point to a lower value to increase the gamma. With that said it is just like I said in my previous post... There is no increase in saturation. Things just become darker. I suggest you set your gamma to 2.2 and then lower your white point to quickly see the difference. You'll see that what I'm saying is true.
[Nexus 5 Themes and Apps] Zephyr101:
I'll try that and then let you know how it goes.
[Nexus 5 Themes and Apps] myfluxi:
The reported values represent readings directly from the command structure at the relevant offsets. These are 25 bit maps that end with 0x00. And yes, they form an upward/downward curve. These values are correct nonetheless.

You may find that JDI's (panel maker) logic is somehow hard to figure out and I can attest to that. Without any kind of documentation we have come a long way already. I also think we may forego positive/negative polarities but as faux thinks it's easy too leave this to the control app and that's perfectly fine with me.

I pointed you to commit history and listed all relevant patches in this thread (use xda search, pls). Check their values and see if it corresponds to your findings. Plot the values to curves and analyze the (suspected) logic and chances are you come back with the holy grail of N5 gamma correction. I lack the time to do it, faux is busy either, hence faux and me involved the community, you and everyone, and you are doing great.
[Nexus 5 Themes and Apps] mag01:
Yeah I checked that sequence (qcom,panel-on-cmds) and it's really like that. Very strange. I'll try to check it with one friend who might know something more about how these displays could be driven.
[Nexus 5 Themes and Apps] fireproofrev:
Can you explain how to set your values? I tried both orders (hell of work) and both are totally incorrect. Is one for pos and one for neg or how can I understand this?
[Nexus 5 Themes and Apps] gpvecchi:
For the ones who are trying to decode all the values, as I read that positive and negative act differently in darker and whiter zone of the grayscale: could the values control brightness and contrast of every color?

This values are complementar and act in the same way: now, working just on this parameters affect gamma, too...

I even noticed that the value called "white point" seems not to shift to "bluer" or "reddish" display, but to a higher or lower gamma.

So, (but I still have to make tests, this is just theory) you'll have all controls in this way:

Positive (full contrast curve)+ negative (full brightness curve)= single color gamma.

Once curves are aligned, white point is the RGB gamma.

Could this be?
[Nexus 5 Themes and Apps] yorici:
[MENTION=5543250]mag01[/MENTION] [MENTION=3490263]tkoreaper[/MENTION] [MENTION=4909585]gpvecchi[/MENTION]

You know the drill. Have fun!

These values are according to mag01's theory (http://xdaforums.com/showthread.php?p=48279955#post48279955).

I have added logarithmic and linear formula's.

__

If you are new on this thread. I recommend reading the (entire) thread first.
[Nexus 5 Themes and Apps] mag01:
[MENTION=4259467]fireproofrev[/MENTION]

These values are not meant to be set in this app, it's an attempt to reconstruct the real curve (since the curve representation in these numbers doesn't seem to be the real one)

[MENTION=4909585]gpvecchi[/MENTION]

Positive vs negative just refer to positive vs negative voltage regulators. They should be probably set to identical values. Yes there's a minor shift between them but that doesn't seem to be important for us.

This display is likely controlled by the Orise OTM1902A chip and though I haven't found any datasheet for this particular (or even some very similar) chip, there are some for few older ones and they all work that way. I haven't studied this part much as it doesn't seem to be much important in this case, but it's probably just a voltage that ends at the input of some operational amplifier.

That number that's called white point at the moment probably scales the output on the vertical axis (output levels), or at least the gamma correction curve. Higher values clip highlights and highlight shadows. So it has an effect on the contrast and of course the gamma value. I would call it gain probably, see here: http://www.qvolabs.com/images/Nuke_basic_CC_Gamma_GainMultiply_Offset .jpg.jpeg It could be theoretically also offset, but it doesn't seem to have that sort of effect - shadows aren't affected as much as highlights.
[Nexus 5 Themes and Apps] jsylvia007:
I know that Cyanogen has been built incompatible with 3rd party kernels, but do you know if they expose the correct API for use of this application so that I can change the Gamma values? The default Gamma values in Stock are too washed out, and I'm nervous to go over to CM and lose this capability.
[Nexus 5 Themes and Apps] bikeryder007:
Alright man, I have some feedback for you. When I ran your stock settings this is what I got:

Grey 2.2

Red 2.4

Green 2.3

Blue 2.3

Yellow 2.4

Cyan 2.2

Magenta 2.4

Using your formula, here are the settings that brought me to 2.2 by only changing row 2, column 5, and Row 3, Column 1 from your stock settings:

Red: 110 and 122

Green 121 and 129

Blue 123 and 130

Everything looks like it is dead on 2.2 except red is between 2.2 and 2.3 and Cyan is between 2.1 and 2.2

That said, I think I actually like the way my screen looks with your stock settings better than my own 2.2 settings.

Your stock settings was the best my screen has looked and the blacks popped off the white better making the text easier to read.

If you have any other suggestions, I will try them first, but I think I am going back to your stock settings for now. Thanks for those!
[Nexus 5 Themes and Apps] tkoreaper:
Interesting that you think it looks better, but I also don't have your screen. To get your red to 2.2 just keep lowering those values one at a time and only one value at a time. What you're seeing with such a high game is just darker colors. I explained earlier to someone else that increasing the gamma beyond 2.2 doesn't increase the saturation of colors but actually just makes everything darker.

I'm curious, since your screen is so different from mine, how your grays look at stock settings. Maybe those need tweaked a bit. When you look at your grays do they have any tint to them such as red, green, or blue?
[Nexus 5 Themes and Apps] bikeryder007:
Yes, I lowered red to 109 and 122 and it put me dead on 2.2

When I look at grey in the display tester app it has a slight red tint to it.
[Nexus 5 Themes and Apps] tkoreaper:
Do you see red all the way through the gamma display on gray or only certain portions?
[Nexus 5 Themes and Apps] bikeryder007:
The tint is pretty much all the way through on gray.
[Nexus 5 Themes and Apps] tkoreaper:
OK so there's too much red. Go ahead and try increasing the values of everything from spot 12 to 23 by 1 until the red is gone from the upper portion of the gamma display. If there is still some tint on the bottom portion after this let me know.

Take your time with this. If you start producing blue or green then you added too much. You'll be doing this to both positive and negative sections of red only. Do one position at a time and take note of the changes. Sometimes you don't need to change a value
[Nexus 5 Themes and Apps] gpvecchi:
Check my signature...
[Nexus 5 Themes and Apps] tylerdurden83:
What do you mean with it exactly? I'm running CM11 and a custom kernel (mpokang) on my GNEX without any issues
[Nexus 5 Themes and Apps] jsylvia007:
Sorry, I should have said, *SOME*, 3rd party kernels. Franco Kernel and Faux, two very popular kernels no longer work with CyanogenMod.
[Nexus 5 Themes and Apps] tylerdurden83:
Why would CM make such a stupid change agaist everything that open source stands for, freedom of choise?... Their loss
[Nexus 5 Themes and Apps] fireproofrev:
against everything that open source stands for???????

Do you know what you are talking?

CM did some changes so that original based kernels are not working instant. Developers like franco or faux are easy able to make a CM kernel but they don't want to (call them lazy or so but this has nothing to do with open source)

I am using elemantalX 0.14 with CM11 right now without problems.

So far even on AOSP based roms like carbon I got the best performance/batterytime with elementalX (4,5 - 5h SOT with 40h standby). With faux and with some franco versions I had a very pooor batterytime.
[Nexus 5 Themes and Apps] jsylvia007:
Thanks for the heads-up on elementalX... Does it also have the ability for TouchScreen Wake and Gamma correction? That might be the Kernel I start with when I make the jump back to CM...
[Nexus 5 Themes and Apps] fireproofrev:
Everything inside you want and need, touch2wake etc.. and also the latest gamma drivers like in the faux and franco kernels.
[Nexus 5 Themes and Apps] jsylvia007:
Thanks for the update... Looks like my girlfriend gets to watch her shows tonight while I recluse myself into my office and configure CM back to the way I like it... And then re-install all my apps... And configure those...

HAHA.
[Nexus 5 Themes and Apps] fireproofrev:
I installed CM today and it still lacks some features. I also had FCs while playing 2 games, so maybe it is better to wait a bit. I also tried carbon before (because Carbon is my absolute favorite I already used it about 1 year on my GNEX) but also carbon still misses alot of features.

Cataclysm has so far the most features I need, but because I don't want to change the rom again I will keep CM some days and check the next nightlys.

I know titanium backup pro is quite expensive but it is totally worth it!! It is so comfortable to restore all apps and app-settings with just a few clicks
[Nexus 5 Themes and Apps] jsylvia007:
Good to know! I don't mind a FC here or there. I ran nightlies on my GNex and N4, so I'm accustomed to that. The big features I use from the Rom are the quick settings tiles and Quiet Hours (all the rest I can actually get from Xposed Framework on Stock)... Then, I like TouchControl and Gamma from custom kernels. Any of the other features, I so far haven't missed.

I do own TiBackup Pro... I honestly never used it to backup and restore apps because when I tried it out a few years ago, it broke the Market links, so NONE of my apps were linked to my google account and I never received updates to them... I will give it a try this time.
[Nexus 5 Themes and Apps] fradbari:
This app is also used to collect information on improving slide2wake function?
[Nexus 5 Themes and Apps] shadowblade330:
So far the stock settings for 1.0.10 are nice. Only thing I needed to change was the white point and which I set to 28 and I come close to 2.2
[Nexus 5 Themes and Apps] fireproofrev:
the app doesn't come with modified settings, so you are using totally stock values with another Whitepoint
[Nexus 5 Themes and Apps] magnamentis:
finally :)

hi,

thanks for those

finally there is only one thing which counts, ones taste and the result related to that :)

for me, who is follwing this thread and using the app from day 1 and having tried all suggestions

and performed endless numbers of own trials, I can say that for my tasteyour settings are the very best so far.

there is perhaps one thing which i think worth to mention to make it for many a bit easier to choose between the

various settings posted here:

i've seen many suggestions with low whitepoint. lowering the white point itself helps a lot to get rid of the

greyish look by increasing gamma, but this comes at the cost of reducing brightness and brillance, toghether

with an increase of any "dirty colors" on really white screens like hangouts etc.

so should anyone be looking for a most probably good set of settings it will help to check the proposed whitepoint first.

if that suggested whitepoint is at or close to stock (32) and the result is better or good, you have the biggest

chance to get what you want, and additionally you can still lower the whitepoint a bit, but no too much, to get

even blacker blacks and even less washed out colors, specially the light colors like light blue will be improved.

hope it helps a bit and thanks again for the great job to achieve your settings, i'm sure that it took quite some time :)

regards

PS: even thought the formulas provided in this thread will most lead to a perfect slider solution finally, for now what

makes these settings so welcome ist that fact that they are simple to setup and to tweak, just in case :)

Current Devices:

N7000, 4.1.2 Stock/TW

N7100, PacRom, 4.3.1, Pac Kernel

Nexus 4, PacRom, 4.3.1, Franco Kernel r193

I9100, OmniRom, 4.4.0, Omni Kernel, Xposed Framework

Nexus 5, Cataclysm ROM 4.4.1, Franco Kernel r19, Xposed Framework, Gamma 2.4<>2.6
[Nexus 5 Themes and Apps] tkoreaper:
IMO no one should even touch the white point. The reason for people changing it is because their displays are a little borked. They lower brightness to hide things at the expense of detail. If your colors are washed our or you have issues with tint it is NOT a problem with your white point but with the calibration. I can help fix it!
[Nexus 5 Themes and Apps] gpvecchi:
Guys, I measured display with colorimeter and stock values: impressive!

There should be very few to calibrate...

The gamma curves are alligned each other and follow enough the reference curve; level of red and green is perfect. Gamut is almost perfect.

There are just a couple of values to correct: level of blue is low (and this leads to a yellow display, exactly 6000k insthead of 6500k) and global gamma, that is around 2.00.

I'd say that this is the most stockly calibrated display I found around.

I just tried correct white point value, but this leads to a wrong correction (gamma is raised just in the lighter parts of the graph).

There's something more to decode in the values, and with a few work, display will be perfect; otherwise, I'll keep it stock...

Screenshots of measures in attachment (values VS ideal line, this should be clear to read).
[Nexus 5 Themes and Apps] mag01:
Yes the default setup has some decent basis coming from in-factory calibration, however it can still be improved as your dE is terrible (mostly due to blue being off a lot). I'm going to play with it once my colorimeter arrives and of course will post results and adjustments.

By the way, what did you use to generate test patterns? This https://play.google.com/store/apps/details?id=org.projectvoodoo.screentestpatterns or something else?
[Nexus 5 Themes and Apps] yorici:
Great job! How long does it take to do these tests?

(Which colorimeter are you using and where did you get it from?)
[Nexus 5 Themes and Apps] gpvecchi:
Yep, sure, but actual values don't give control of level of blue; I used 1080p 10% step grayscale+RGB+CMY videos from a calibration disk.

I'm using Spyder 3, a cheap model you can find (but noit so easily) around internet and HCFR software (freeware)

BTW, I tried choosing "cooler colors" in my kernel settings. Blue level is correct, but obviously red becomes a little too low, and gamma curve is not as regular as before and still too low: this leads to a 7000k color temperature
[Nexus 5 Themes and Apps] tkoreaper:
Keep in mind that all the displays will be different. So while all of our screens will be calibrated the same, we will have small variations which in your case is yellow tint which can be fixed by subracting values to blue in the 11-23 positions in the app.
[Nexus 5 Themes and Apps] bikeryder007:
Thanks for your help yesterday. I did not have any luck with the 12 to 23 changes, but I did not have my red set quite low enough then. Here are my final settings that brought every value to 2.2 and even Cyan is between 2.1 and 2.2. The screen looks great and I am totally happy with it now. In the display tester app in grey, you can see a slight hint of pink, but I do not notice it anywhere else on my phone, so I should probably leave it alone.

Row 2: Col. 5 Row 3: Col 1 Row 3: Col 2

Red 108 120 131

Green 121 129 137

Blue 123 130 136

White Point: 32

Thanks again.
[Nexus 5 Themes and Apps] chw2006:
I also have an issue with yellow tint, how much should we be subtracting from the 11-23 positions for blue? And should we do this for both the negative and positive blue values?
[Nexus 5 Themes and Apps] mag01:
That's something that should be measured. Now [MENTION=4909585]gpvecchi[/MENTION] should measure the real effects of changing these values and even though every display is slightly different, that will give us better idea of how far we should go with any adjustments.
[Nexus 5 Themes and Apps] tkoreaper:
It depends on where your tint is located. If its all across the gray display then you want to adjust all those positions. Just subtract 1 at a time and check for results. It doesn't take much. Each position 11-23 represents a position on the scale from top down with 11 being the top and 23 being top-center.
[Nexus 5 Themes and Apps] franciscofranco:
Hi [MENTION=3332811]faux123[/MENTION]

A user reported me having a hard reboot triggered by watchdog about a minute after a manual reboot with this:

[59.052364] mdss_dsi_cmds2buf_tx: failed to call cmd_dma_tx for cmd = 0x0

[ 59.052453] mdss_dsi_cmds_tx: failed to call

I told the user to disable your app set on boot and the issue did not appear anymore. This also happened on Mako if the gamma commands are sent during the screen off routine or after screen off has landed and then it booms either then the user screens on again or watchdog barks sometime after it (30 seconds roughly).

Couple suggestions for you to fix this:

* Have a broadcast receiver on your app to detect screen on/off and if it detects a screen off then block the set on boot operation and start it when the screen is on again:

* Acquire a wakelock to keep the screen on until the set on boot settings have been applied and release the wakelock after it

Hope that helps :)