yashsingh1/xdaforums huggingface dataset:
[Galaxy S 4 i9505 Android Development] fOmey:
As per requested, Logcat for Settings -> Display -> Brightness FC:

02-03 22:09:40.430: E/AndroidRuntime(21215): FATAL EXCEPTION: main
02-03 22:09:40.430: E/AndroidRuntime(21215): java.lang.NullPointerException
02-03 22:09:40.430: E/AndroidRuntime(21215):	at com.android.settings.BrightnessPreference.onBindDialogView(BrightnessPreference.java:224)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.preference.DialogPreference.showDialog(DialogPreference.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at com.android.settings.BrightnessPreference.showDialog(BrightnessPreference.java:195)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.preference.DialogPreference.onClick(DialogPreference.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.preference.Preference.performClick(Preference.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.preference.PreferenceScreen.onItemClick(PreferenceScreen.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.widget.AdapterView.performItemClick(AdapterView.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.widget.AbsListView.performItemClick(AbsListView.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.widget.AbsListView$PerformClick.run(AbsListView.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.os.Handler.handleCallback(Handler.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.os.Handler.dispatchMessage(Handler.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.os.Looper.loop(Looper.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at android.app.ActivityThread.main(ActivityThread.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at java.lang.reflect.Method.invokeNative(Native Method)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at java.lang.reflect.Method.invoke(Method.java:525)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:126)
02-03 22:09:40.430: E/AndroidRuntime(21215):	at dalvik.system.NativeStart.main(Native Method)
[Galaxy S 4 i9505 Android Development] thedoginthewok:
I have found another bug.

When you pull down the notification area and close the S View Cover, S View is not enabled.

Logcat included.

Also, I have a question:

In the previous version of the Blackbox Rom the layout of the S View Mode the icons in the notification bar were "condensed" a little, to fit the window better. In 2.2 the icons aren't moved at all:

I'll provide another screenshot of the previous Blackbox Rom as soon as I get home.

Is that intentional? If yes, could you include an option to enable the "condense" option for the icons?

edit:

Here is a screenshot of Blackbox 2.1 in S View Mode:

I scribbled the area red that is not visible through the window of the S View Cover.
[Galaxy S 4 i9505 Android Development] cobra11111:
S View works for me

Usa il non Metodo come Metodo avendo l Assenza di Limiti come Limite
[Galaxy S 4 i9505 Android Development] thedoginthewok:
It also works for me, but it has bugs which I meticulously described in my post.
[Galaxy S 4 i9505 Android Development] anab:
Hi there m8s!

i realy want to give this rom a try..

can someone just aswer me 2 things plz

The "aosp keyboard" included in this rom... is the samsung based with the numbers row and just a aosp theme, or the aosp keyboard for real?

And the camera included is the samsung original too right ?

thxx!!!:good:
[Galaxy S 4 i9505 Android Development] alvin551:
No it is the Google keyboard and Google/aosp camerq
[Galaxy S 4 i9505 Android Development] DSA:
Cheers Fomey, all users should use this guy as an example...

Fc is now fixed, thanks to the provided log

-----------------------------------

If people need to ask what camera is provided in the ROM, then you are going to have problems using a custom rom

I provide all relevant information in the changelog, there's not much more I can do

If that's not comprehendible, I'm not sure what to suggest

There's also a line regarding the keyboard...please read before posting
[Galaxy S 4 i9505 Android Development] fOmey:
Glad to help in any way possible..
[Galaxy S 4 i9505 Android Development] DSA:
i completely missed this post, having a look into it right now

Thanks for the log :highfive:

initial findings are:

01-29 14:08:33.926 E/AndroidRuntime(13877): java.lang.ArrayIndexOutOfBoundsException: length=5; index=5
01-29 14:08:33.926 E/AndroidRuntime(13877):	at com.android.systemui.statusbar.policy.NetworkController.updateTelephonySignalStrength(NetworkController.java:580)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at com.android.systemui.statusbar.policy.NetworkController.access$000(NetworkController.java:59)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at com.android.systemui.statusbar.policy.NetworkController$1.onSignalStrengthsChanged(NetworkController.java:436)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at android.telephony.PhoneStateListener$2.handleMessage(PhoneStateListener.java)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at android.os.Handler.dispatchMessage(Handler.java)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at android.os.Looper.loop(Looper.java)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at android.app.ActivityThread.main(ActivityThread.java)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at java.lang.reflect.Method.invokeNative(Native Method)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at java.lang.reflect.Method.invoke(Method.java:525)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java)
01-29 14:08:33.926 E/AndroidRuntime(13877):	at dalvik.system.NativeStart.main(Native Method)
01-29 14:08:33.926 W/ActivityManager(2077): Process com.android.systemui has crashed too many times: killing!

i need to look into that, i cant replicate it and ive never seen it before

can you give me a full breakdown of what you did with the rom please (wipe, flashing choice, set up etc)

Current changelog:

<b><u>Changes:</u></b>
Reworked settings app;
Fixed settings-volume-volume levels fc
Fixed settings-display-brightness fc
Fixed settings-display-wallpaper-lockscreen fc
Fixed settings-bluetooth-bluetooth pairing dialog pop up fc

Improved ripple effect on ripple lockscreen
Fixed bluetooth share
Disabled scrolling cache (Dramatically improves responsiveness)
Added GearManagerStub.apk in
Added AllShare apk/libs in
Added Pie in (Rom Control)

going to add a couple of nice new mods in, but mainly concentrating on fixing everything first (which includes fixing stuff before updating to a new base)

On the to-do list:

Flip cover/screen on action
Im going to temp remove the crt effects while i figure out why its conflicting with auto brightness
Look into the auto spacing on the statusbar when closing the flip cover
notifications fc when turn over motion setting is on
When you pull down the notification area and close the S View Cover, S View is not enabled. (related to 1st item in list)

anything ive missed?
[Galaxy S 4 i9505 Android Development] srimay:
Did you find anything regarding sending picture messages? Sent you my logcat a while back
[Galaxy S 4 i9505 Android Development] fOmey:
Funny the MMS FC was mentioned, I just discovered this FC while using the stock SMS app ! Talk about timing right:

02-06 13:20:49.503: E/AndroidRuntime(3923): FATAL EXCEPTION: send_mms
02-06 13:20:49.503: E/AndroidRuntime(3923): java.lang.NoSuchMethodError: Lcom/google/android/mms/pdu/SendReq;.setReserved
02-06 13:20:49.503: E/AndroidRuntime(3923):	at com.android.mms.transaction.MmsMessageSender.sendMessage(MmsMessageSender.java:131)
02-06 13:20:49.503: E/AndroidRuntime(3923):	at com.android.mms.data.WorkingMessage.sendMmsWorker(WorkingMessage.java:2766)
02-06 13:20:49.503: E/AndroidRuntime(3923):	at com.android.mms.data.WorkingMessage.access$200(WorkingMessage.java:101)
02-06 13:20:49.503: E/AndroidRuntime(3923):	at com.android.mms.data.WorkingMessage$2.run(WorkingMessage.java:2356)
02-06 13:20:49.503: E/AndroidRuntime(3923):	at java.lang.Thread.run(Thread.java:841)

There was another error which came up just before the android runtime on the logcat which could be some relevance:

02-06 13:20:48.612: E/SecureStorage(3990): [ERROR]:TZ Return code: -1 (0xffffffff)
02-06 13:20:48.612: E/SecureStorage(3990): [ERROR]:Error load config to TZ
02-06 13:20:48.612: E/SecureStorage(3990): [ERROR]:Error sending config file to TA/driver!
02-06 13:20:48.612: E/SecureStorage(3990): [ERROR]:Secure Storage Daemon failed to start
02-06 13:20:48.612: E/Mms/WorkingMessage(3923): mMessageUri = content://mms/drafts/5

Confirmed working with a third party SMS app (chomp sms).. worked perfectly fine with chomp.
[Galaxy S 4 i9505 Android Development] srimay:
Yeah I found that hangouts works as well, but its fcing on group text then you open hangouts and can read the text. Not a big deal for me as I can't stand group text constantly blowing up my phone.
[Galaxy S 4 i9505 Android Development] DSA:
I don't have MMS messages on my tariff so I can't check (last time I did it cost me nearly £10 extra which I'm not prepared to pay for when I'm doing this for free)

I will have a look at the files but it will be down to you guys to test it (I.e I don't want people to complain it doesn't work - I know that bit, just provide logs)
[Galaxy S 4 i9505 Android Development] DSA:
Fixing the flip cover stuff is gonna take a while. So I'm gonna upload the new rom with all the other fixes, at least you will have a 90% fixed rom to use

Will probably upload it tomorrow
[Galaxy S 4 i9505 Android Development] NeoXTC:
Can someone help me provide the log for DSA about this bug please.

Basically I can't get direct call to work properly. That is if you have a person's contact on screen you can just bring it to your ear and it'll call. If I go to settings and turn it on and try the tutorial. Then I go to my contacts and try it, it works.

Leave it after awhile, go back to contacts and do it, it doesn't work anymore. But if I go back to settings and click "try now" button and then go back to contacts it works. I can record the log but it might not help DSA much because I have many errors in the log with McClient errors. (tried fixing it but still that error keeps popping up)

I'll try and capture a log tonight DSA but if someone can help me it would be great.

Cheers
[Galaxy S 4 i9505 Android Development] fOmey:
Ill happily test/troubleshoot any MMS fixes..

I remember when I was deving my rom, I had to edit one of the files in system/framework to get MMS's to work correctly.. I'll try dig up the thread..

I believe it was frameworks.jar, I believe the MMS issue could be linked to the AOSP dialer...

EDIT: I found the following thread.

I could be wrong tho !
[Galaxy S 4 i9505 Android Development] DSA:
that thread is a bit redundant now as the relevant files are all over the place

In regards to the mms - i did try and port the aosp mms.apk with no success, as it turns out i left some files in related to that...that's what's causing the issue (ive removed the offending files in the new version)

It should now be fixed and working fine as ALL the files related to this are the proper samsung ones now, its just a themed mms.apk

Another 'to be expected' thing - anything like that is going to be related to the aosp systemui that i have ported

And yes, logs will be needed for that one as its not a quick fix

(i still cant figure the mcclient error in the logs either atm) But it doesn't matter about all the included info in the log, i know what to look for when you upload it
[Galaxy S 4 i9505 Android Development] NeoXTC:
Ok here goes the log file for the direct call. I've removed all xposed and mcclient stuff.

I hope this helps.
[Galaxy S 4 i9505 Android Development] ionutzvio:
Deleted
[Galaxy S 4 i9505 Android Development] lotzakritters:
You should probably ask that in here.

http://xdaforums.com/showthread.php?t=2429090
[Galaxy S 4 i9505 Android Development] Tryer1234:
Hi! Cool rom, but I keep getting force-close of the systemUI. Here's a logcat I made while the force closes were occurring. I'd love this rom to work but unfortunately this issue, and the GS4-pure-nexus causing it to not get past the boot animation.
[Galaxy S 4 i9505 Android Development] fOmey:
Simplified logcat:

E/AndroidRuntime( 4327): FATAL EXCEPTION: main
E/AndroidRuntime( 4327): java.lang.ArrayIndexOutOfBoundsException: length=5; index=5
E/AndroidRuntime( 4327): at com.android.systemui.statusbar.policy.NetworkController.updateTelephonySignalStrength(NetworkController.java:580)
E/AndroidRuntime( 4327): at com.android.systemui.statusbar.policy.NetworkController.access$000(NetworkController.java:59)
E/AndroidRuntime( 4327): at com.android.systemui.statusbar.policy.NetworkController$1.onSignalStrengthsChanged(NetworkController.java:436)
E/AndroidRuntime( 4327): at android.telephony.PhoneStateListener$2.handleMessage(PhoneStateListener.java)
E/AndroidRuntime( 4327): at android.os.Handler.dispatchMessage(Handler.java)
E/AndroidRuntime( 4327): at android.os.Looper.loop(Looper.java)
E/AndroidRuntime( 4327): at android.app.ActivityThread.main(ActivityThread.java)
E/AndroidRuntime( 4327): at java.lang.reflect.Method.invokeNative(Native Method)
E/AndroidRuntime( 4327): at java.lang.reflect.Method.invoke(Method.java:525)
E/AndroidRuntime( 4327): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java)
E/AndroidRuntime( 4327): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java)
E/AndroidRuntime( 4327): at dalvik.system.NativeStart.main(Native Method)
[Galaxy S 4 i9505 Android Development] wis1152:
Try this Mms.apk, back up old one move this one into system/apps set permission rw-r-r(0644) restart.
[Galaxy S 4 i9505 Android Development] DSA:
I don't even understand that bit

I need full details of what you did

Full wipe or not

Aroma choices

Phone set up

Anything new installed or straight from flash

Restoring anything
[Galaxy S 4 i9505 Android Development] Tryer1234:
Sure thing, any thing on the first issue though?

Full wipe always,

Aroma options: wipe data, do not install recovery, flash kt kernel.

Phone setup (not sure what you want for this): Att SGH-1337, twrp 2.5.0.2.

Flash order: Black box, pa 4.3 Gapps, loki-doki.zip (patches the kernel to bypass locked boot loader and run any s4 Roms except for the exynos chip set). After the ROM boots successfully at least once I go back to the recovery and flash gs4 pure nexus.zip (touchwiz camera) follows by loki-doki.

Nothing restored because the after flashing it, the black box boot animation plays indefinetly.
[Galaxy S 4 i9505 Android Development] juanysara:
Is it possible to save images and videos on SD card instead of internal memory?

Thank fantastic rom
[Galaxy S 4 i9505 Android Development] DSA:
I want it because you have unfortunately ignored the very first line in the op

This is only for the i9505, can't support anything else

That actually saves me time trying to fix that log error :victory:

Sorry dude, you will have to use a compatible rom

That is related the aosp camera and gallery, I will look into it but I can't promise anything
[Galaxy S 4 i9505 Android Development] Tryer1234:
Hah, that'd be funny if it were so easy to cast aside; unfortunately there's less going on here than you'd think. Here's how it really works, the only difference between the SGH-1337 and I9505 is a locked bootloader, which the carriers like to put on. That bootloader makes sure it is loading a signed Samsung kernel. To reiterate, The only thing setting these 2 phones apart is a verification function in the bootloader. The loki-doki patch bypasses the checking however, letting us run ANY S4 rom (source).

On top of this, Ktoonsez kernel comes built in with the loki-doki patch. The patch is skipped if flashed on a phone without a locked bootloader, so it just lies dormant for you. Now we get to my point, we're using the exact same kernels at this point. The only difference between these phones is in the bootloader, which is moot. Even if it wasn't a moot point, above the bootloader (which includes the kernel and rom) everything is functionally the same! So unless you are messing with bootloader stuff to fix those bugs, everything you do on I9505 will work on SGH-1337!

Anyway I looked over the shortened version of the logcat and found this:

java.lang.ArrayIndexOutOfBoundsException: [B][COLOR="Red"]length=5; index=5[/COLOR][/B]

It's been a long time since I last coded in java but I see the problem. The length of the array is 5 spots, but we start count at 0, so the spots are 0,1,2,3,4, with spot 4 being the last in the array. So index=5, is pointing to a spot outside of that array's length and that's throwing an exception.
[Galaxy S 4 i9505 Android Development] juanysara:
other question I have, how I can change the image of the lock screen?

and a small bug I found is to use a cover with lid and window to open the unlocked phone is not alone, with the stock if it does, is silly, but just so you know.

Thanks for your work.
[Galaxy S 4 i9505 Android Development] DSA:
Read the thread please, all questions are already covered
[Galaxy S 4 i9505 Android Development] DSA:
Is it the same situation for aosp ROMs too?
[Galaxy S 4 i9505 Android Development] Tryer1234:
I'm sorry, is what the same situation for AOSP roms? The bootloader? The kernel? The verification? The glitch I've encountered?

Or are you asking if I need to flash loki-doki with AOSP roms? Or possibly, "do I get the same issue force-close on an AOSP rom?"

What exactly were you referring to?

EDIT: You changed GE to AOSP, so I've done the same.
[Galaxy S 4 i9505 Android Development] DSA:
Well, the systemui (which is what the error is related to) is a pure aosp systemui from an international build (I.e not related to Samsung in any way)

So do you have to do anything different other than the bootloader / kernel thing for aosp roms?? Im assuming aosp builds for your version have more differences than what you have mentioned already?

Btw, I am prepared to look at the issue based on your responses, but the systemui isn't a Samsung apk
[Galaxy S 4 i9505 Android Development] Tryer1234:
I wouldn't be able to tell you if there are differences between AOSP roms for our respective phones. Cyanogenmod does provide different downloads for nightlies for SGH-1337 (jflteatt) and the other versions (such as verizon, tmobile, and international) but I'm not sure that's evidence that they are different in ways other than their kernels. I'm fairly sure I'm able to run the other versions, but I can't recall a specific instance in which I did. If you point me to a pure AOSP or GE rom built for your phone (i9505), I'd try flashing it with loki-doki and see if everything works. Just remember I still can't run roms for the octa-core (exynos) version, but then again neither should you.

I also know that the solution to running other carriers roms for us is either flash the loki-doki patch after the rom, OR flash a loki'ed kernel (such as ktoonsez) over the rom.

I see what you mean about it may not be an issue with Samsung.

Again I don't know what the differences are at a code level, if I had to guess the JFLTEATT (SGH-1337) build would come with loki-doki built into the kernel, while the JFLTE (I9505?) wouldn't. But that may not even be true, I wouldn't be able to tell because I always flash loki-doki even when it may be redundant (such as when a rom has loki baked in) just out of force-of-habit.

Thanks for considering it.
[Galaxy S 4 i9505 Android Development] Tom-Helge:
Hey DSA. I have some few questions to you.

Now as this ROM is a Hybrid between a Samsung ROM and a AOSP ROM, then i want to ask you these questions.

1. Would it be possible to choose what kind of camera you would like to install. Also that you can get the option to choose the AOSP camera or the Samsung camera in Aroma?

2. It's the same for the dialer. Would it be possible to get the option to choose between the the Samsung dialer and the AOSP dialer in Aroma when you are installing the ROM?

3. Last time i tried you ROM, the audio over bluetooth didn't work for me. Is that something that doesn't work in this ROM or was that just a problem on my side?

Yes, the Samsung camera and Samsung dialer with it's neat features and the smart features the Samsung ROMs have is some of the reasons i wont go over to any AOSP or CM ROMs. However, as a hybrid ROM, i would choose your ROM if it would be able to choose witch camera and dialer you could use if that would be able to do on this ROM?

Or is the Samsung camera and dialer in the new ROM already?

Hope to get an answer on my questions :D.
[Galaxy S 4 i9505 Android Development] DSA:
1. No

2. No

3. No idea, although I have done other fixes for Bluetooth in the new version

Its stated in the first post that I won't be adding touchwiz features that aren't already in the rom

-------------------------------

I've decided to revert the systemui back to a themed Samsung one for now, it fixes all the issues people are having...the aosp one will be back when I fix it

I just need to add the systemui smali mods in and the rom is done/ready to be uploaded (hopefully today as I have a funeral tomorrow)
[Galaxy S 4 i9505 Android Development] Tom-Helge:
Thanks for the quick response :laugh:.

Isn't your ROM using the TW framwork?

Last time i tried your ROM, that was on version 1.x, it had a TW framework, so i just took the Samsung camera apk file from the FoxHound ROM (also the zip file) and copied it over to the system/app folder and gave the camera apk file the right permissions.

I did the same with the Samsung dialer apk files to. And guess what?

It all worked after i did that as the ROM already had the TW framework that the Samsung camera and dialer needs. So it's all about adding those apk files to the system/app folder.

Ofc, if i'm totally wrong here, then feel free to correct me.

However, as i had other issues with the ROM at that time, i couldn't stay on your ROM as a main OS that time.

So it's not about adding new TW features if your ROM already have TW framework, it's just about adding some few files that will work 100% perfect when they are added without the need of modifying anything with the TW stuffs.

Anyways, it's your ROM and it's up to you to choose what to do with it.
[Galaxy S 4 i9505 Android Development] wis1152:
Tw stuff can be added quite easy. Someone should open a thread in themes and apps for this rom,with tw flashable stuff for this rom. With ops permission ofcourse:)
[Galaxy S 4 i9505 Android Development] DSA:
You can do what you like with the rom, all I'm saying is that I won't be adding it in...it defeats the point of a hybrid rom...you are basically after a stock themed rom, I suggest foxhound rom or purified
[Galaxy S 4 i9505 Android Development] Tom-Helge:
I think you misunderstand something here. Because a theme has nothing to do with an application added to the ROM.

But yeah, i support what a user said longer up that someone can start a topic in the Apps & Theme section where there can be a mod to this ROM where the Samsung camera, dialer, calender and so on can be added.
[Galaxy S 4 i9505 Android Development] wis1152:
I think these hybrid roms are great:) was using one on my i9100:) For me the big + is that all bloat ware is removed:) but I do like like some of the TW bits. I would open the thread but I really haven't got to time.

P.S Thanks to DSA for your time and rom buddy:thumbup:
[Galaxy S 4 i9505 Android Development] DSA:
OK, new ROM is now ready

Nearly everything is fixed (only one thing left which is the mms.apk adding contacts bug from what I can tell) and there's several new mods added in (not including the systemui)

I will put the change log up later

I'm out for the night now and my family funeral is tomorrow afternoon, I will upload after that