yashsingh1/xdaforums huggingface dataset:
[HTC Droid DNA] crpalmer:
I tried a cherry-pick before and it looked very bad. But, actually, a lot of it looks like it could be related to the comments that HTC strips from the source when the release that I added back (because it makes it easier to patch from all non-HTC sources).

If you want to take a crack at this, try doing this before cherry-picking their commit:

git show c81741a8337c2342d856ffeac0cc087452729290 drivers/media/video/msm include/media/msm_camera.h | patch -p1 -R

That will strip all the comments back out again and get rid of all those conflicts. The conflicts then look very simple (outside of arch/arm/mach-msm, which is where it gets much harder).
[HTC Droid DNA] renzo.olivares:
the board-monarudo-camera.c doesn't need to be updated, at least i didn't update it in my m7 kernel port

but i can't seem to get the kernel to build

drivers/gpu/msm/adreno_snapshot.c: In function 'snapshot_rb':

drivers/gpu/msm/adreno_snapshot.c:628: sorry, unimplemented: inlining failed in call to 'parse_ib': recursive inlining

drivers/gpu/msm/adreno_snapshot.c:588: sorry, unimplemented: called from here

make[3]: *** [drivers/gpu/msm/adreno_snapshot.o] Error 1

make[2]: *** [drivers/gpu/msm] Error 2

make[1]: *** [drivers/gpu] Error 2

make[1]: *** Waiting for unfinished jobs....

i don't believe it's related to any edits i made tho heres my commit https://github.com/Joelz9614/android_kernel_htc_dlx/commit/daa90f2bf8e64a8ad6f4f497ca412bc0a77ab7ef
[HTC Droid DNA] crpalmer:
Searching in the browser doesn't have any matches for adreno_snapshot...

Maybe try git checkout -b tmp HEAD~1 and make sure that builds?
[HTC Droid DNA] chad0989:
Looks like CM just merged an updated audio HAL along with the legacy HAL, both of which incorrectly detect our device for now. Building with a fix now and if all is well I'll submit upstream.

Edit: It's going to cause a bunch of routing issues again also until some other stuff gets merged in. Best to just revert their change for now for builds.
[HTC Droid DNA] crpalmer:
Aside from the routing issues, this may already be fixed for us thanks to the m7:

http://review.cyanogenmod.org/#/c/46473/
[HTC Droid DNA] crpalmer:
[MENTION=3124509]chad0989[/MENTION], FYI, I reverted the commit to use legacy alsa early this morning and haven't noticed any problems (play music on Bluetooth, voice calls with and without wired headset) using that build.

You may want to give it a try and see if you're ready to revert it.

Edit: actually, I just noticed that they had also enabled legacy audio in msm8960-common but since reverted that. So, I guess I was still running the legacy mode...
[HTC Droid DNA] chad0989:
They aren't allowing new HAL to build yet (see https://github.com/CyanogenMod/android_hardware_qcom_audio-caf/blob/cm-10.2/Android.mk) But we will need that flag when they allow the new HAL to build. I added it preemptively to hopefully avoid breakage. The issue was that the legacy HAL they pushed hadn't included some changes for our CSD client and platform detection. Looking at what was committed last night/today it should work now though.
[HTC Droid DNA] invisiblek:
Perfect timing :silly:

Tough luck dude =\

If it ends up being an extended period of time, I can give you an account on my box if you want/need.

Cool, I've updated my device repo.

I'll be afk for the weekend guys, so don't expect much from me until early next week =)

EDIT: ah crap, I accidently let this sneak in there...

Cherry pick this or revert the above patch or your build is likely going to fail.
[HTC Droid DNA] crpalmer:
The flickering problem does not seem to be magically fixed by switching to the M7 as a base kernel. I have been running the M7 based kernel all day today and I haven't had bad flickering but I can definitely see some flickering. This is fairly consistent with what I would expect from a DNA based kernel given the fact that today was a day where I was using my phone relatively lightly.
[HTC Droid DNA] chad0989:
It shouldn't be too long. Ordered some stuff yesterday and some more today. Hopefully I'll be able to get it together next week sometime and be ready to go again.

That's unfortunate. I was crossing my fingers that it would.
[HTC Droid DNA] travp624:
Hey guys I'm hoping you can help out here. Ever since this commit https://github.com/CM10DNA/android_device_htc_dlx/commit/17ad4bd325345620dcdfd8f52d66826c8eef26fe Google now don't recognize the mic input at all now. I'm just wondering if there is something else I missed.

edit: Oh forgot to mention only building 4.2.2 at the moment and I know this thread is about 10.2. But yes I'm using the 10.1 branches at the moment.
[HTC Droid DNA] chad0989:
That was a commit in the 10.2 branch, it wasn't supposed to be pulled into 10.1 but it looks like it was. Just simply revert it before you build.
[HTC Droid DNA] travp624:
I was kinda wondering that. Thanks for the quick reply.

On a side note is there a fix for hangouts that maybe I just missed somewhere?
[HTC Droid DNA] chad0989:
Can't wait for my stuff to get here. There are some pretty big changes happening in the m7 tree that will be quite beneficial to us.
[HTC Droid DNA] orangechoochoo:
Can you tease us with hints? :D
[HTC Droid DNA] times_infinity:
I think he's talking about the huge panel update that was pushed recently.
[HTC Droid DNA] .torrented:
He's talking about getting his new PC parts so he can continue working on our device unless you are referring to the m7 changes
[HTC Droid DNA] chad0989:
That's a small part of it but I'm more excited about the speaker amp stuff and power management.
[HTC Droid DNA] orangechoochoo:
M7 changes, i get excited when devs are excited about things they're cooking up.

I can't wait! Thanks to all the devs for their continued hard work :good:
[HTC Droid DNA] -DroidIsDNA-:
When do your parts arrive? I like power management :D
[HTC Droid DNA] riom4:
just out of curiosity what are the differences between those?
[HTC Droid DNA] Dri94:
Variants of dna and butterfly

This thread is getting posts that are non dev. Let's keep it clean so they can work. Not at anyone in particular :D :thumbup:
[HTC Droid DNA] stillthisguy:
I was wondering if ro.secure is set to 0 inside the ramdisk? I was trying to adb remount and getting remount failed: Operation not permitted. I don't remember having this issue in 10.1.
[HTC Droid DNA] times_infinity:
Did you set root access to app and adb?
[HTC Droid DNA] stillthisguy:
Yes, I had checked that before posting. I can adb shell, su, then mount but for some reason I cannot adb remount anymore.
[HTC Droid DNA] pio_masaki:
Do this

adb root

adb kill-server

adb remount

Adb for whatever reason doesn't always get root like it should, this will get back into root so remount will work again. If the root command hangs, ctrl c and then do kill-server and remount.

Tapatalked from my HTC DNA - Carbon
[HTC Droid DNA] stillthisguy:
This worked. I have to do this after every reboot, I wonder what is causing that issue, never had that before using CM10.2, though not saying it couldn't happen elsewhere.
[HTC Droid DNA] pio_masaki:
Seems to be a 4.3 thing, its the same for any device I work with, haven't looked at it since I'm the only person it bothers on those devices lol

Tapatalked from my HTC DNA - Carbon
[HTC Droid DNA] invisiblek:
just thought i'd poke in and let everyone know that usb is working

now, of course, the upstream m7 guys broke our camera lol

shouldn't be too much to get it unbroken

standby...
[HTC Droid DNA] chad0989:
I can't try it since my parts don't come in until tomorrow, but so you know where we were at, I was previously using their 4.2 libs. So updating to their 4.3 camera libs as they have may help. That is if it's not an issue with building.

What did the usb issue turn out to be?
[HTC Droid DNA] invisiblek:
I know what commit caused it, just trying to track down the particular file causing it

I may give blobs a shot too

For usb I ended up kanging the crap out of the m7 boardfile =P
[HTC Droid DNA] orangechoochoo:
What is superior about the M7 kernel compared to the dlx kernel?
[HTC Droid DNA] pio_masaki:
If the GPE ROM is any indication, it feels better in use. It may also be a matter of ease, if we can all use the same kernel, its better vs having a kernel for each board, but makes it harder to control changes affecting more devices down the line.

Its like making changes to ROM source for the DNA then finding out I can't build for the Thrive anymore because of it, and having to change it back or ifdef the changes so its only active on certain devices.

Tapatalked from my HTC DNA - Carbon
[HTC Droid DNA] invisiblek:
The M7 has a google-edition version. This alone should be enough to entice us to join in on it's fun since in theory we should get decent kernel source drops. Since the M7 has the same CPU (faster clock speed) and GPU as us, it makes sense that we should share a kernel repo rather than track our own.

This also allows us to work with several others people (All HTC One devs) rather than having to keep track of our own kernel repo.

Anyway, I think this thing is about ready. The final commit I'm going to push up for the initial bring-up of monarudo into the M7 kernel is here: http://review.cyanogenmod.org/#/c/48373/

Still a couple bugs to work on, but that's what nightlies are for!

Bugs:

- GPS is a big wonky (this has been an issue for me since I got this device, anyone else?)

- Audio - seems distorted at times (camcorder playback, volume cranked up really loud)

- Screen flicker??? <-- I still have yet to be able to reproduce this even once

I have a few more cleanup things to do too, as +crpalmer mentioned a page or two back too, but it shouldn't prevent us from getting some nightly love.
[HTC Droid DNA] .torrented:
Going to give this a go with my ROM as soon as it gets a green light... Excited!
[HTC Droid DNA] times_infinity:
Built and running this right now. It is smooooooth.
[HTC Droid DNA] times_infinity:
[MENTION=2385005]invisiblek[/MENTION]

Did the audio amp stuff actually get implemented yet? Headphone volume is ridiculous even only at 50%
[HTC Droid DNA] chad0989:
That's actually because the audio amp stuff hasn't been implemented yet. The m7 kernel removes a hack I made to the rt5501 headphone amp to reduce the gain. I'm going to merge in the audio amp stuff tonight and see how it goes. Setting up the build box right now.
[HTC Droid DNA] times_infinity:
[MENTION=3124509]chad0989[/MENTION]

So I kanged libaudioamp from the m7-common tree and it built just fine. Don't know if its working or not though.

Edit: nvm, it's probably not working.

I failed to look at the m7-common commit history. I am missing all of the tfa config files.
[HTC Droid DNA] pio_masaki:
This is where I wish I could do anything with kernels, it won't build for me at all, fix 40 errors, then get errors from the dlx's own board files which confuses me as it works normally in the dlx sources. Plus the initial bring up appears to be lacking a lot of dlx files. Oh well I'll have to wait until people who knows what they're doing get that taken care of I guess, I'm probably missing something stupid.

Tapatalked from my HTC DNA - Carbon
[HTC Droid DNA] times_infinity:
It shoudlve been as easy as cloning the m7 kernel source now and building for dlx.
[HTC Droid DNA] pio_masaki:
I figured that too, it wasn't. Its missing everything to support dlx, I gave up after an hour last night, I'll give it a go again tonight. I was tired when I tried it at like 1am, it really has to be something stupid, like the wrong branch or something.

Tapatalked from my HTC DNA - Carbon
[HTC Droid DNA] times_infinity:
o.O weird. Yeah. Make sure it's the cm-10.2 branch. I'm running a build right now based off the m7 kernel after [MENTION=2385005]invisiblek[/MENTION] got the changes merged.
[HTC Droid DNA] pio_masaki:
Yeah the more I think about it, I don't remember checking the branch so that's probably it, and like an idiot I was chasing the errors lol

I'll have to they again tonight. Earlier.

Tapatalked from my HTC DNA - Carbon
[HTC Droid DNA] crpalmer:
[MENTION=2385005]invisiblek[/MENTION], you said "nighties in sight" in the cm-10.2 ROM thread. Any clarification on what kind of time-frame you think that's on?

I'm asking because I currently do not have approval from my employer to commit to official CM and it's been slow getting that approval. I'm trying to gauge how aggressively I should be "encouraging" that process.
[HTC Droid DNA] invisiblek:
Next day or so.
[HTC Droid DNA] d08speed3:
Your own nightly with your kernel?
[HTC Droid DNA] times_infinity:
As in official cm nightlies.
[HTC Droid DNA] chad0989:
[MENTION=2385005]invisiblek[/MENTION]

Is there any reason you left the splash screen fix out of what was merged? I don't see a fix for it in any other commits unless I'm missing something.
[HTC Droid DNA] invisiblek:
Yea, after talking with intervigil, we decided hacking up mdp.c wasn't the best course of action. We should fix it properly rather than revert a CAF commit for it.
[HTC Droid DNA] miscom:
I am getting a lot of errors with omx_video_encoder.cpp when trying to build the ROM.

make: *** [/home3/android/cm10/out/target/product/dlx/obj/SHARED_LIBRARIES/libOmxVenc_intermediates/src/omx_video_base.o] Error 1

Is this a known issue? This started happening on 9/4.
[HTC Droid DNA] ML417:
May I ask how is the Bluetooth code in the m7 kernel compared with the cm10.1 code? Because Bluetooth is still causing me headaches. The problems I'm having is first with repairing my smart watch, then the phone improperly handles the connection when going to sleep, often resulting in the watch disconnecting, or occasionally a wakelock due to blue sleep, though currently I'm getting a much larger wifi wakelock, probably due to my campus wifi.

I can help investigate this more, and if need be I'll switch to the cm10.2 nightlies if the difference in the Bluetooth code is too big to try and help from my current ROM, though that might have to wait until next week due to homework and classes.
[HTC Droid DNA] invisiblek:
I've not tested bluetooth extensively. Check out the official nightly tomorrow =)

For devs:

https://github.com/CyanogenMod/android_device_htc_dlx

We should submit patches to Gerrit now for the device tree(s) and m7 kernel repo. I know our dlx tree has some redundancies with msm8960-common so we can clean some of that up too.
[HTC Droid DNA] crpalmer:
I can't remember 10.1 vs. 10.2 differences.

In general, the Bluetooth code is basically the sane between the DNA and m7 kernels. They started from our Bluetooth drivers and then improved things which we then incorporated into our kernel.
[HTC Droid DNA] ML417:
I'm getting a lot of problems with bluetooth running CM that i didn't on sense, which is why i was wondering on this information, because i love CM and hate sense, but these problems i'm having a driving me nuts. I'm willing to help explore any possible solutions for this, as i haven't seen anyone else mention having a smartwatch handy to test with.
[HTC Droid DNA] .torrented:
I'm experiencing the blue flickering again (I forget what it was called) using the M7's kernel.

Edit* I'm not going to lie, this feels way more smooth than our kernel did/does. I'm liking it.
[HTC Droid DNA] times_infinity:
First nightly is being built right now. :D
[HTC Droid DNA] munchy_cool:
http://get.cm/?device=dlx :D
[HTC Droid DNA] amit_sen:
Iam getting a blue flicker followed by black screen only :(

Not bootanimation , nothing.

Waited for 5mins.

Had to restore a backup.

I always clean flash.

EDIT :: https://plus.google.com/117962666888533781522/posts/ArqL2Yw8tun
[HTC Droid DNA] munchy_cool:
Something wrong with all nightlies of cm

Rocking a Red DNA on AOSP \m/
[HTC Droid DNA] crpalmer:
What's going to happen with the vendor tree?
[HTC Droid DNA] d3xt3rlab:
Oh boy what a bad luck, our first nightly and is bad from cm :(
[HTC Droid DNA] miscom:
Look at the file size; it's missing the vendor files.
[HTC Droid DNA] .torrented:
See I don't get why some people can flash my cyanfox ROM and others can't. I've obviously included the vendor files. Puzzles me...

I'm using cm's official trees for the device/kernel

On the flip side I'm not seeing any screen flickering :)
[HTC Droid DNA] amit_sen:
Managed to get crdroid booted with the newest changes i.e m7 kernel base.

Loving it :D

I also faced faced the issue that phone will say activating phone and it doesn't do anything. I then flashed gsm patch. It worked like charm.

Definitely noticed snappiness in animation and audio amp works very well.

One thing is that battery is draining very fast.

None of the cores are getting offline.

I changed the gov to interactive.

Thats my little review of new changes to DNA from official cm10.2 nightlies pov

DNA | ⓣⓐⓟⓐⓣⓐⓛⓚ | TF300T
[HTC Droid DNA] d3xt3rlab:
Wow just tried this one http://get.cm/get/jenkins/40874/cm-10.2-20130908-NIGHTLY-dlx.zip and is working incredible good. Hangouts working again yay! Big Thanks!

edit: Speakers work in Hangouts, mic still having issues in hangouts, google now and keyboard.
[HTC Droid DNA] Gorilla*:
So we should be downloading from the official cyanogen mod site now for nightlies?

Sent from my HTC DNA
[HTC Droid DNA] coachcrey:
Yeah
[HTC Droid DNA] El Ha$on:
That depends on you. What you want. If you want official then yes.
[HTC Droid DNA] d3xt3rlab:
There is a new one working great at least for me no data wipe needed though
[HTC Droid DNA] crpalmer:
[MENTION=2385005]invisiblek[/MENTION], my employer has still not given me the approval needed to sign a contributor agreement for CM so I can't submit code. I can, however, point you at existing commits. This commit:

https://github.com/CM10DNA/android_kernel_htc_dlx/commit/34fee5786a956812b69223cf07e99cfdb5918a0d

could probably stand to be reverted. It was something I was trying to rule out causes of the flickering, and there's no other reason to increase the minimum brightness.
[HTC Droid DNA] orb3000:
Please all keep it on topic and with respect.

Thanks,
[HTC Droid DNA] invisiblek:
will do

i'm still not seeing the flickering, like EVER lol
[HTC Droid DNA] crpalmer:
I didn't see it on my original DNA but then I had to get a replacement that flickers like crazy. If you ever have a random thought about it, I'm glad to try making changes. Unfortunately, I'm out of ideas for fixing it.
[HTC Droid DNA] crpalmer:
[MENTION=2385005]invisiblek[/MENTION] or [MENTION=3124509]chad0989[/MENTION]

If you want to try playing with any of my recent commits for potential inclusion in the official CM repos, I just updated my github:

https://github.com/crpalmer/dna-kernel/commits/4.x

The commits between 4.0.10 and 4.0.11 seem to make the bluetooth music playback better (less stuttering) but not perfect for me. Sorry that the ondemand change is not very clean, but maybe you don't care either because you're defaulting to interactive. The reason it's not clean is that half of the change comes from a previous bulk update to CAF in my earlier kernel branch so there wasn't a nice way to cherry-pick commits.

The commit between 4.0.11 and 4.0.12 is something I wrote a long time ago for CM 10.1. I forget exactly which processes were involved, but what I found was on boot, every once in a while, one service would be started and try to talk to another before it was started. This would print an error like:

[ 3.042942] c1 226 binder: 226:226 refcount change on invalid ref 0

and then the boot would hang. I saw this a couple of times today when making changes but obviously I can't confirm that this change actually fixes a boot hanging problem. However, there have been some people reporting that they couldn't boot the nightly and this could potentially be the cause and it is a very reasonable change.
[HTC Droid DNA] mr4r4n:
Would anyone happen to have the local manifest xml for the dna? Im prepping files for the buildbox im on to bring some awesome projects to the DNA
[HTC Droid DNA] times_infinity:
Just sync regular cm-10.2 and lunch cm_dlx-userdebug.

It'll pull the dlx device tree and it's dependencies.
[HTC Droid DNA] mr4r4n:
Only annoying part of the bb is lunch isnt installed, does that mean the device is now official?
[HTC Droid DNA] times_infinity:
Need to run . build/envsetup.sh

That'll enable the lunch command.
[HTC Droid DNA] mr4r4n:
You da man thanks, will be building later
[HTC Droid DNA] h2on0:
Along the same lines... Do I need to extract the proprietary blobs from the dna or is there repository like the muppets specifically for the dna. And if so, asking the same question again does anyone have a copy of their roomservice.xml they can post with the proper repos?

thanks, sorry if I am a little dense.
[HTC Droid DNA] times_infinity:
Clone it from the muppets. Make sure its the cm-10.2 branch.
[HTC Droid DNA] pyroguysf:
I haven't flashed an official, but all ROMs from the past few days are defaulting to Settings > More > Mobile Networks > CDMA Subscription = NV instead of RUIM/SIM, causing them to not have signal on boot until manually changed or waiting about 5-10 minutes. Hopefully a quick fix, just wanted to point it out.
[HTC Droid DNA] djnikko:
I'm on 9/19 build. Hangouts speaker works, when I switch to handset the mic will work, but I cannot hear the other caller. You also can't switch back to speaker.

Inscribed by Droid DNA/Nexus 10
[HTC Droid DNA] badogg:
Heh, so it's like a reverse mute? :good:
[HTC Droid DNA] -DroidIsDNA-:
This is a dev thread. If you aren't talking commits, etc, do not post here. Thank you!
[HTC Droid DNA] renzo.olivares:
how did this go?
[HTC Droid DNA] crpalmer:
If anyone that builds their own builds cares about bluetooth audio, I just pushed a commit up that is drastically improving things for me (but I have unpushed changes to the power HAL which may be helping too). Any feedback of a build that includes this commit would be appreciated:

http://review.cyanogenmod.org/50898
[HTC Droid DNA] loctorn:
I'd be more than happy to test a build with these changes if someone puts one up. (Can't do it myself since I'm away from the PC 5 days a week)

I know I uploaded some logs on the CM 10.2 thread regarding the Bluetooth skipping in hope that someone could figure out exactly what was going on as I use the Bluetooth streaming daily in my truck.

Thanks for all you do [MENTION=3857343]crpalmer[/MENTION]

Edit: My apologies I just seen this is the Dev thread after posting I thought I was in palmers kernel thread :headsmashdesk:

*Hit the thanks button if I helped you*
[HTC Droid DNA] milennium:
SIM Tools

Please add SIM Tools to CM 10.2... I need it to work with the Bank.
[HTC Droid DNA] betterthancrimzon:
Hello Folks, since this thread hasn't been touched in a couple months, I feel less bad asking a question:

Is the rear amp ever going to be functional, outside of Sense?
[HTC Droid DNA] danielhall2689:
Now that the update came out we should be seeing a lot of stuff fixed in the next few months (especially when the kernel source comes out) although I don't know how much fixing will be done to cm 4.2 now since we are at 4.3 and 4.4
[HTC Droid DNA] betterthancrimzon:
Oh, I don't mind which version. It just would be nice to have louder volume.
[HTC Droid DNA] crpalmer:
[MENTION=3124509]chad0989[/MENTION], I have a few questions.... None are urgent, 2 are my curiosity and 1 is just that I want us (you?) to make a choice...

Last night, you committed egl and gps changes to the vendor repo . Did this fix something for you? I still have some video and GPS issues that I haven't been bothering to look into yet which I assume you were trying to fix?

Speaking of GPS, why can't we just mimic what the M7 has done for GPS? I tried, as best I could, to do so today and it didn't help, but I'm curious what is different that would not let us just use their work?

Lastly, bluedroid was just changed to disable BLUETOOTH_QCOM_SW by default. I've run builds with it both on (the day before) and off (today) and I don't see any difference. Should we re-enable that for our device? I honestly can't tell if it is better enabled or disabled. Both have had some weirdness with the new builds (sometimes