yashsingh1/xdaforums huggingface dataset:
[HTC Droid DNA] crpalmer:
[MENTION=3124509]chad0989[/MENTION], can you test a commit? I have had a good (but not perfect, which is confusing) day on my flickering phone. Last night when I was looking through the recent changes to the msm8960 kernel, I noticed that they were specifying the vsync gpio in the mipi_dsi config and that we weren't. So I looked to see what they were doing with vsync in the panel config and based on that I made the change on this branch:

https://github.com/crpalmer/android_kernel_htc_dlx/tree/cm-10.2-flicker-vsync

Today was good. About 3 hours after last unplugging the phone, I had some flickering (not bad, but more than "just starting"). It went away pretty quickly and then was gone for about 5 hours when there was a "just starting" flickering that then went away very quickly as well.

I'm reluctant to suggest merging this change for a few reason.

First, because the commit message sucks and I want to change it when i know more... :)

Second, it is based on the code in a kernel that has been reporting to have device specific flickering. I can't help but wonder if that, by fixing the flickering in my phone, I would actually be causing problems in the vast majority of the phones.

Third, the logic in the kernel is fairly complex which makes it very hard to look at the code and tell whether or not I have even changed any behaviour. I haven't had time to instrument the code to know whether or not I've changed any of the behaviour as it relates to the vsync and I probably won't for a little bit.

Fourth, I don't understand how this relates to the m7 kernel. They have CMD and VIDEO devices and there is a similar configuration in (some of ?) the cmd devices but we are a video device. So, it looks like this change is doing something that is different from the M7 kernel.

Fifth, I was expecting something that really fixed the problem to fix it 100% of the time. There is a chance that I'm now finally seeing the small flickering that you just recently managed to reproduce, or that I've damaged something in my phone but more likely it's a sign that something else was different today and I haven't fixed anything.

If you can run it for a little bit while I continue to run it for a little while we can answer most of those questions.
[HTC Droid DNA] chad0989:
Pretty interesting. I'll give it a shot tonight and tomorrow and let you know.

Edit: So far so good.
[HTC Droid DNA] chad0989:
This is interesting:

http://review.cyanogenmod.org/#/c/48103/

Could be a great workaround for the speaker amp issues since the calibration info is included in the code rather than being loaded externally.
[HTC Droid DNA] crpalmer:
For me Wednesday was hands down, by far the best day I've had wrt the flickering. Just a couple of small and short and very subtle instances which is in contrast to often having my screen dancing a jig.

Yesterday was half way between that and a normal day. I had moderately large flickering after about 9 hours and then some intermittent flickering (about half the time) for the rest of the day.

If this change is fixing something (which I feel like it is), it's more like it reduces the severity of the flickering and isn't addressing the actual cause. [MENTION=2602340]whirl08[/MENTION] tested it as well and had similar feelings about it making it less severe.
[HTC Droid DNA] whirl08:
Yep, it's made a massive difference in the duration and severity of the flickering, I did have one bad flare up that lasted maybe an hour? But no flickering as of today at all, on full brightness.
[HTC Droid DNA] chad0989:
I haven't had any I'll effects from it. I can still see some minor flickering from time if I look closely to time but overall it does seem better.
[HTC Droid DNA] crpalmer:
I sent a pull request with this change (reworded) and another commit that adds some missing clocks. The missing clocks commit will add back the warning "dsi_clk stuck at off" because it looks like that warning only went away because we accidentally broke the mdp footswitch config.
[HTC Droid DNA] Flyhalf205:
http://review.cyanogenmod.org/#/c/48373/
[HTC Droid DNA] .torrented:
woah....

lol im thinking not really...
[HTC Droid DNA] chad0989:
Whose maintaining it?
[HTC Droid DNA] Flyhalf205:
Not a clue. That's the first time I've seen anything about a DNA on there... Never heard of Dan Pasanen
[HTC Droid DNA] renzo.olivares:
that's invisiblek i believe from d2vzw and jfvzw
[HTC Droid DNA] chad0989:
It is, we used to work together back on the OG dinc. Last I knew he went gs3 when I went to the rez though.
[HTC Droid DNA] amit_sen:
[MENTION=3124509]chad0989[/MENTION]

I really think that its about time we should look to get official CM status.

The only issues from cm10.1 FFC,BT audio has been fixed in cm10.2 already.

DNA | ⓣⓐⓟⓐⓣⓐⓛⓚ | TF300T
[HTC Droid DNA] chad0989:
I haven't because I don't really have the time or desire to be maintainer, but if someone else wants to they're more than welcome to. I've mentioned this before.

But like it's been pointed out above, it looks like someone wants to.
[HTC Droid DNA] KyJelly69:
Is that person starting from scratch or is he aware of the progress already made?
[HTC Droid DNA] times_infinity:
His github has the kernel and device tree forked from the CM10DNA git, so I'm going to say yes, he already knows about the progress that has been made.
[HTC Droid DNA] .torrented:
Sent him a gmail a bit ago, and times_infinity was right
[HTC Droid DNA] pio_masaki:
Might explain the trees showing up other ROM sources, pulling from CM would get it also.

Tapatalked from my HTC DNA - MoKee
[HTC Droid DNA] .torrented:
Dan confirms to be ( will be / said he planned on it ) the device maintainer so there we go, he said he sent chad an email about this stuff
[HTC Droid DNA] chad0989:
Oh, so he did send me an e-mail two days ago. I guess I should actually check it once in awhile. Haha.
[HTC Droid DNA] chad0989:
Can someone who uses encryption try this out and let me know if it works now:

https://github.com/CM10DNA/android_device_htc_dlx/commit/1ef602239fec135f14d6738fe7b290acd10887c0
[HTC Droid DNA] kxs783kms:
Give me the basics on what encryption is and I will try it. I don't use it, but I will test it for progress of these ROMs.
[HTC Droid DNA] ML417:
It's in settings > security > encrypt phone, make sure to have a nandroid saved off of your phone in case it screws up all of your storage
[HTC Droid DNA] danielhall2689:
I'm pretty sure it actually erases all your data so have your entire phone backed up to your computer
[HTC Droid DNA] miscom:
I have been pulling the sources and compiling this ROM in my Ubuntu PC. But since 8/19 any ROM I build get into a boot loop.

I flashed Flyhalf205's 8/20 ROM and it boots up and works flawlessly but the latest source I pulled from this morning still gets into a boot loop.

I noticed that Flyhalf205's build.prop says:

ro.build.display.id=cm_dlx-userdebug 4.3 JSS15J eng.david.20130820.000258 test-keys

ro.build.version.incremental=eng.david.20130820.00 0258

Whereas the source code I pulled says:

ro.build.display.id=cm_dlx-userdebug 4.3 JSS15J eng.root.20130819.181236 test-keys

ro.build.version.incremental=eng.miscom.20130819.1 81236

As you can see mine is still showing 8/19. I have no idea if I am doing something wrong or if the latest commits are not yet generally available. Any help is greatly appreciated.
[HTC Droid DNA] .torrented:
Have you tried doing a clean build? Run either "make clean" or "make clobber"
[HTC Droid DNA] kxs783kms:
I thought I was downloading something to install, but it looks like something that I will have to do through and type in ADB correct? As what am I looking once I do this? Or what do you what me to look for to report back to you?
[HTC Droid DNA] miscom:
Thank you for the tip! After make clean I noticed that I didn't have the right version of Java. I have reconfigured my build environment and I am compiling the code again.
[HTC Droid DNA] Dri94:
Is much more complicated than that. Best saved for the kernel devs here
[HTC Droid DNA] .torrented:
It's for anybody who builds these roms from source, hence why it's in the CM DEV thread
[HTC Droid DNA] orangechoochoo:
This stuff is above my pay grade.
[HTC Droid DNA] pio_masaki:
I think he meant for people who can see that and implement it, not ask how to do it to even get to where they can test it.

Well, the people who don't need a download to test, but can actually build the ROM/kernel to test it. Nothing against users that can't build and need a downloadable, flashable version, just saying what I took his view to be.

Tapatalked from my HTC DNA - Carbon
[HTC Droid DNA] invisiblek:
Phew...finally got this thing merged into the m7 cm kernel repo.

Still a few outstanding bugs (which shouldn't be overly difficult to squash)

- Bluetooth

- USB and Charging is broke <-- #1 priority

- Splash screen seems to 'burn' away before you see the cm logo (actually kinda cool, feels like your phone is melting lol)

After this all gets worked out, I think we are pretty close to ready for official nightlies.

This thing is SUPER smooth on this kernel base. I'm pretty stoked =)
[HTC Droid DNA] Gorilla*:
Thanks Invisiblek... When did you pick up the DNA? I remember you from the DINC.
[HTC Droid DNA] invisiblek:
Someone donated one to CM and I raised my hand to work on it =)

Yep, the good ol' dinc days...actually a good friend of mine is still running my dinc, cm-10.x (unofficial of course =])

I've been stuck in samsung land (d2vzw and jfltevzw) both great phones too!
[HTC Droid DNA] crpalmer:
[MENTION=3124509]chad0989[/MENTION], in the power HAL (device/htc/msm8960-common/power/power.c), they are setting cpufreq governor parameters at startup and then at each screen on / off. Aside from the fact that this grossly offends me (this should all be handled by applications, not by the system!), I think there is a real battery killer in there as well.

They set io_is_busy to true, which causes ondemand to stay at max speed while waiting for I/O. Eons ago, I found that HTC was also setting this somewhere and that it caused my phone to stay at max frequency when, for example, I was browsing the internet and I was waiting for a slow website to respond.

If you look in the kernel (drivers/cpufreq/cpufreq_ondemand.c) at the comment before should_io_be_busy(), the view of the kernel is that only certain Intel processors idle efficiently enough at high frequency and the rest should default to false.

While this doesn't affect me (I #iifdef'ed out the implementation if io_is_busy to be sure it couldn't be enabled in my kernel and I have also removed all this crap from the power HAL In my builds), I thought I would pass it along in case you wanted to fork msm8960-common or better yet fight the upstream fight.
[HTC Droid DNA] azndan2:
Hello all of you lovely people. Former donator here. I was wondering if any of you would be willing to help these guys out with RIL in the HTC One thread? http://xdaforums.com/showthread.php?t=2417400

Much love for my former DNA buddies.
[HTC Droid DNA] chad0989:
If I had a One... The wife just got one but it's in my best interest to not touch it. Haha.
[HTC Droid DNA] azndan2:
You are a wise man, Chad.
[HTC Droid DNA] miscom:
Noob question

Hello,

I am getting stuck at the following error while compiling:

Export includes file: hardware/libhardware_legacy/Android.mk -- /home3/android/cm10/out/target/product/dlx/obj/STATIC_LIBRARIES/libpower_intermediates/export_includes

make: *** No rule to make target `/home3/android/cm10/out/target/product/dlx/obj/STATIC_LIBRARIES/libminipigz_intermediates/export_includes', needed by `/home3/android/cm10/out/target/product/dlx/obj/EXECUTABLES/recovery_intermediates/import_includes'. Stop.

make: *** Waiting for unfinished jobs....

At first at thought it was related to not having the android-tools-fsutils package installed. I installed it but I still get the error.

What am I doing wrong? What package/lib am I missing?
[HTC Droid DNA] crpalmer:
You're missing libminipigz. You'll either need to wait for someone to update CM10DNA/android or you'll need to fetch the CyanogenMod android repo and cherry-pick the commit that adds that package.
[HTC Droid DNA] amit_sen:
Bug report ::

Voice msgs from whatsapp is blank/no sound as recieved by others.

However u can hear others voice msgs.

Dont know whether its a rom or kernel issue.

Tapatalked from TF300T - ParanoidAndroid
[HTC Droid DNA] times_infinity:
[MENTION=2385005]invisiblek[/MENTION] apparently joelz fixed USB and charging when he ported the M7 kernel a while back.

Apparently this is the commit https://github.com/Joelz9614/androi...mmit/ee55e7e8bbce3e4fa3fbca1be0080f0377867357

I wouldn't doubt that you'd have to get ifdef happy with that to keep things working for the M7 as well.
[HTC Droid DNA] chad0989:
Should be fixed now. :good:
[HTC Droid DNA] Dri94:
Wrong thread. And click on the paperclip in the top right and send audio clip that way instead. Mic icon doesn't work on any that I've tried
[HTC Droid DNA] miscom:
Well, it seems that "someone" updated the CM10DNA/android repository. THANK YOU DEVS!!! You are the best!

---------- Post added at 07:34 PM ---------- Previous post was at 07:31 PM ----------

Thank you Chad!
[HTC Droid DNA] invisiblek:
Yea....he went a little more nuclear on it than I planned to. Looks like he dropped a bunch of the current dlx stuff on top and made it compile =P

I'd prefer to be a little more surgical and get our stuff working with what's already there =)
[HTC Droid DNA] invisiblek:
Question for you gents, since I'm still pretty new to the DNA scene...

Do we really have different variants of this device?

I'm seeing references to both a Sony and a Sharp panel in our board files (mine happens to be a Sharp)

Also seeing two different gpio configurations, denoted as _XA_XB (which I'm assuming are two different ones in themselves) and _XC

If we don't need all these variants and stuff, I'd prefer to clean up these board files a bunch.
[HTC Droid DNA] Flyhalf205:
dlx

dlxpul

dlxj

dlxu

dlxub1
[HTC Droid DNA] invisiblek:
...

srsly?

go home htc...you're drunk...
[HTC Droid DNA] amathophobia:
http://www.engadget.com/2013/02/07/htc-droid-dna-butterfly/
[HTC Droid DNA] Flyhalf205:
Yeah. We could setup a dlx-common like the m7 device repos. Just suggesting.
[HTC Droid DNA] chad0989:
Is the commit on gerrit where you're at currently with the kernel? I pulled it and built because I was going to help out with fixing some of the bugs since I have some time but I had corrupted video. There were some issues building it initially also.
[HTC Droid DNA] invisiblek:
Yep

This:

http://review.cyanogenmod.org/#/c/48475/

(even though OTG is not working, I did it this way so that we could share with m7)

and this:

http://review.cyanogenmod.org/#/c/48373/

You'll need to compile the entire ROM (clobbered) so that the video hal gets compiled against the new kernel headers.

Also, I hang with the m7 guys in #msm8960-dev on freenode
[HTC Droid DNA] chad0989:
I'm aware. Still had corrupted video unfortunately.

Not sure if you have yet, but you'll need to update the device tree to use the AOSP style init.usb.rc rather than HTCs version.
[HTC Droid DNA] invisiblek:
Weird...

And yea, I updated init.usb.rc from m7 (seems identical to aosp)
[HTC Droid DNA] chad0989:
I'll pull it again. It was probably a bad merge since I had to fix it up to build even. I have some time tonight so provided it boots for me what are the current issues?
[HTC Droid DNA] invisiblek:
usb/adb not working

bluetooth

splash screen is all wonky, doesn't affect anything though, purely cosmetic
[HTC Droid DNA] chad0989:
Okay, its working now. The wonky splash screen has to do with the way our display initializes. It needs to have a delay in there before the very first display on. I'll see if I can fix anything tonight.
[HTC Droid DNA] invisiblek:
Thanks bud, I much appreciate the help =)

I had the device donated to me, so I feel obliged to work on it day and night, just had too much RL stuff to deal with lately lol.
[HTC Droid DNA] chad0989:
I totally understand. Real life is way more important, take care of that before worrying about pleasing a bunch of guys on a forum.
[HTC Droid DNA] invisiblek:
I do it for the guys on IRC :p
[HTC Droid DNA] chad0989:
Okay, display is good. I'll see if I can get usb going now also since that's of utmost importance.
[HTC Droid DNA] codezzie:
Posted this in flyhalfs rom thread on accident

I've tried several different things since this morning, the most stressing being some 720p and 1080p playback, and the antununununtujtnutn benchmark. Neither of these will bring online any of the offline cores.
[HTC Droid DNA] gators0223:
I noticed this a few days ago on my device and thought it was something particular to the builds I was doing myself. I ended up pulling the mpdecision from here:

https://github.com/CM10DNA/android_...a7e945e068c588dc50/proprietary/bin/mpdecision

and manually replacing the one in /system/bin. Now the other cores come online like they should and it is noticeably smoother. Not sure if this is a "good" fix but it works well enough for me.
[HTC Droid DNA] invisiblek:
Got BT working with latest patch set

Should have looked at this a bit earlier to raise the spirits lol. Spent all this time messing with USB and never noticed a simple defconfig change would fix bluetooth.

So....bugs left....

- usb (adb/mtp/etc)

- splash screen craziness (i tried adding a long msleep in there, didn't seem to make a difference) it should be noted that this happened after changing line 253 here

in order to get the display working
[HTC Droid DNA] chad0989:
That's great. Gotta love simple fixes.

I fixed the splash screen deal already when I fixed up the display initialization. It did have to do with that.

Here are all the changes I've made. This includes the display/splash stuff and what I had to do to get it to build.

http://chad0989.dyndns.org/dlx.patch

Not sure how you want to ifdef the stuff in mdp.c or if it will break any devices to just change it to the way we need it.

I'll try to work on USB some tomorrow.
[HTC Droid DNA] codezzie:
I had a feeling it was something todo with mpdecision, replacing it with the provided one causes cores to go offline and online under correct conditions.

Edit:

Spoke too soon, once again once the screen goes off only core 1 will be avail for use.
[HTC Droid DNA] invisiblek:
Nice!

Why are you having to change this other stuff in order to get it to build?

I can only assume you are getting some warnings that aren't allowed when building outside the rom tree?

Either way, those should go in a separate commit.

This is all that was needed for the splash screen stuff:

http://review.cyanogenmod.org/#/c/48373/7..8/arch/arm/mach-msm/board-monarudo-display.c

http://review.cyanogenmod.org/#/c/48373/7..8/drivers/video/msm/mdp.c

I saw a commit awhile back that actually removed the function that we added to mdp.c and added the one we just ifdef'd out for the m7 kernel. So I assume they are using it. I couldn't, however, figure out how they made that work with their current setup in order to kang it for us.
[HTC Droid DNA] chad0989:
If I recall, I think a couple of them were warnings being treated as errors. The camera stuff was an actual error on my end though. Either way a couple of them could be actual issues and might want to be looked into further.

You still likely want some of the other changes to the display file. Otherwise you're doubling up on all the video_on commands every time you unblank the display rather than just doing display_on with the proper delay.

As for the cont_splash stuff, I assume the m7 doesn't actually need it at all since they appear to disable it in their display file and that we can likely just make the change. But someone on the m7 side should test it to be safe.
[HTC Droid DNA] crpalmer:
I can't currently contribute new code to your commit (I am not currently permitted to submit to Cyanogenmod). However, I can point to existing commits...

When I patched our DNA based kernel to the right CAF video drivers, I suspect I ran into the same problem with the display. It's been awhile, but if you want to try something, can you try undoing the change on line 253 and cherry-picking this revert:

https://github.com/CM10DNA/android_kernel_htc_dlx/commit/4640fc280de62d78d5ae30414c23c4fabb96079d#drivers/video/msm/mdp.c

If that "fixes" the splash screen wonkiness by causing the display to not seem to turn on at all until autobrightness kicks in later in the boot, try cherry-picking this commit:

https://github.com/CM10DNA/android_kernel_htc_dlx/commit/cce006ccc1382ca3f74129fe8d0663f467cda941#drivers/video/msm/msm_fb.c
[HTC Droid DNA] crpalmer:
So the first commit I pointed you at and changing the cont_splash_screen back to 1 in the board file seems to fix the splash screen craziness. I think that you should probably also include this change:

https://github.com/CM10DNA/android_kernel_htc_dlx/commit/a12b3466943a2bc8029d87ef84430977db012a06

Without it, we are setting a clock incorrectly during the boot and that seems less than ideal to me...

Generally I just want to say, I'm very impressed that this is running with such a clean commit on top of the M7 kernel! I was very skeptical when you posted it. I haven't had time to play with it until today and I was very happy to see what a great job you were doing to keep the changes to the device specific files. Very nice.

What device tree are you using? Chad's? If so, my wired headset was not recognized when I tried to use it for a call today.

I also assume that the low latency audio is not working. The M7 kernel and the existing DNA kernel differed in the device number used for low latency audio.
[HTC Droid DNA] invisiblek:
Using my device tree here: https://github.com/invisiblek/android_device_htc_dlx

I'll look into your video patches tonight. I'd prefer not to disturb common stuff like video as much as possible, but if we have to, we have to =)
[HTC Droid DNA] crpalmer:
For the video patch, it should be easy to add an option and ifdef the change if you want to keep it clean.

I'm glad I asked about the device tree before I looked into the audio issues I was having. I'll start building with that tree instead.

One thing though, you changed the BOARD_KERNEL_CMDLINE to include HTC's user_debug=31. This introduces a ton of log spew if you don't set that to 0 instead.
[HTC Droid DNA] invisiblek:
Thanks for the tip, after this gets worked out I'll probably drop it back to 0 again.

Yea, I'll end up ifdef'ing that stuff in probably. Just trying to avoid caf merge conflicts down the road =)

Pretty sure its the m7 team's goal to switch to a caf-based kernel at some point.
[HTC Droid DNA] chad0989:
Unfortunately my build box has decided to die on me so I'm going to be out of it for probably the next week until I can get a new one together. It suffered the awful bad power supply -> fried everything fate.
[HTC Droid DNA] Imacellist:
Oh man that sucks. Sorry to hear that, that is the worst.
[HTC Droid DNA] pio_masaki:
Ouch, had that happen too.

Part of the carnage.

Tapatalked from my HTC DNA - Carbon
[HTC Droid DNA] crpalmer:
I built with your device tree and the wirehead headset (voice call) is very over amplified. So much so as to be unusable. Your tree adds

'RCV AMP EN Switch':1:1

to the voice use cases which seems to be what's causing the problem. I commented out these lines for the Earpiece and HAC Earpiece which made it much better.

There is also a slight popping on Bluetooth headset (voice call). This one is more subtle and doesn't make it unusable. It is also more annoying because I swear I have experienced this before and then fixed it (or Chad did or we stole something from the M7 that did).
[HTC Droid DNA] chad0989:
It's right here, the change with the gain at the bottom. You brought it up when we first had the issue.

05fb61e5abeca8ed2e84dffff63f5c3f69899dea

[MENTION=4630655]pio_masaki[/MENTION]

Ouch, that's rough. It's alright though, it gave me an excuse to order a shiny new SSD and some new memory. That should speed up my builds significantly.