yashsingh1/xdaforums huggingface dataset:
[HTC Droid DNA] chad0989:
The updated EGL libs smoothed things out quite a bit for me. I also recall getting some errors in my logcat before I updated them (I don't remember the specific errors though).

As for GPS. Our issue is that our libloc_api_v02 library has support for the GPS privacy lock, or PivacyLock (yes, no r) as HTC managed to call it. Unfortunately any HAL I can find from CAF to build does not have support to enable and disable the lock. This is why we have the odd workaround where you need to get a GPS lock in sense and reboot before you install CM, this unlocks the privacy lock and allows us to use a library and HAL without it. It appears that only, or at least mostly, CDMA devices utilize this lock. For some reason or another, building using the m7 lib and HAL don't work. There must be enough different between our SoCs regarding GPS that is not compatible. Since the mako uses our exact SoC I've found that using their lib and HAL works well, as long as the GPS is unlocked (they have no support and don't use the privacy lock). I've also found that the qcom GPS in general is extremely finicky, the smallest change seems to make it decide to not work completely.

Which brings me to my question, what issues are you seeing regarding video and GPS? I haven't gotten to run 4.3 full time yet as I need to make sure my phone is reliable during the day so its possible I'm missing some things, but I get a pretty much instant lock with GPS and haven't had any noticeable video issues (general use, playback on youtube, ran a few graphically intensive benchmarks).

As for bluedroid, I could be wrong but from what I can tell that flag has to do with the native bluetooth on qcom SoCs. We use our broadcom chip for BT so I would think it would be best to leave it disabled. Did you test calls with and without it just to make sure it didn't magically fix anything?
[HTC Droid DNA] crpalmer:
I actually have no problems with the video library in day-to-day use (for me), I don't play games so my GPU really isn't getting that heavily used. When I run Antutu benchmarks to see if anything drastic happened to the video drivers, some of the 3D rendering is missing most of the objects being rendered. It actually helps our our scores though.... :)

As I said, not something I've looked into at all (because it doesn't affect the things I use my phone for). I was fishing to see if that was what you were seeing or if there was something else that you were seeing that was fixed.

GPS is not locking for me. If I use GPS Status, it never shows a single satellite. I think I may have somehow gotten relocked. I'll have to get around to flashing back to a Sense ROM to see if that fixes it.

[QIUOTE]As for bluedroid, I could be wrong but from what I can tell that flag has to do with the native bluetooth on qcom SoCs. We use our broadcom chip for BT so I would think it would be best to leave it disabled. Did you test calls with and without it just to make sure it didn't magically fix anything?[/QUOTE]

Oh, I always try to test and hope for that magic! :)

I was inclined to leave it disabled, but I wanted to bring it up. I'm trying to stay ahead of all these small changes rather than let them all accumulate and try to sort through them later...
[HTC Droid DNA] chad0989:
Ah, I do see that now. Logcat gets spammed with this also:

I/Adreno200-ES20( 5605): <validate_vertex_attrib_state:53>: validate_vertex_attrib_state: No vertex attrib is enabled in a draw call!

Interesting

Edit: [MENTION=3857343]crpalmer[/MENTION] This actually appears to be a more widespread issue, either an antutu bug or a bug in the libs. Here's stock 4.3 on mako.

http://www.youtube.com/watch?v=95O8C8NGp5k
[HTC Droid DNA] crpalmer:
Nice. There's an update to Antutu out which does fix the problem for me. I have a few commits that get us synced up slightly better with the msm8960 kernel and the m7 kernel, but none of them would have been likely to have magically fixed the problem. Sounds like that wasn't our problem at all!
[HTC Droid DNA] chad0989:
[MENTION=3857343]crpalmer[/MENTION]

This is interesting, I'm going to give it a shot now.

http://review.cyanogenmod.org/#/c/46768/

Looks like that flag IS needed.
[HTC Droid DNA] crpalmer:
I sure hope that this works (I'm going to give it a try too). Looks like it also needs this commit though:

http://review.cyanogenmod.org/#/c/46777/

[MENTION=3124509]chad0989[/MENTION], how the hell does he figure this stuff out??

I have what may be reasonable sounding audio (at 6am, there aren't too many options to really test voice calls out) and I can be heard via bluetooth for the first time. How did it work out for you?
[HTC Droid DNA] chad0989:
I have no idea, but I'm glad he can and that he's finally working on an HTC phone some and not just samsung.

I unfortunately didn't get a chance to test. It was late and I fell asleep. That's awesome that it's working though. I'll flash when I get home from work tonight and see where its at/push.

On another note. Have you been having issues dirty flashing? I lose my gapps every time and after 1-2 flashes I end up with a ton of random FCs (Trebuchet, android phone).
[HTC Droid DNA] crpalmer:
I'll try it out a little better later today and see how it works talking to an actual person...

I haven't had any problems flashing. I always reflash the gapps package (you haven't to, don't you?). I don't have any problems with random FCs. I'm still on a dirty flashing from cm-10.1. I don't know if that makes a difference in any way. In the last week, I'm sure I've flashed more than 20 times without any of those problems (hell, three times this morning alone!).
[HTC Droid DNA] chad0989:
Hmm. Odd. Must be something on my end. I'll re sync and start fresh.
[HTC Droid DNA] crpalmer:
[MENTION=3124509]chad0989[/MENTION], I talked with an actual person and:

* audio definitely works both ways (although my wife thought it was funny to pretend that she couldn't hear me, shesh!),

* both sides still sound a little "tin"y, but better than it was before

My feeling is that something is over amplified. At minimum volume, the earpiece is still pretty loud. I changed the gain for the "Voice earpiece" and I think that made it much better:

diff snd_soc_msm_2x_Fusion3 snd_soc_msm_2x_Fusion3.orig

1103c1103

< 'EAR PA Gain':0:POS_2_DB

---

> 'EAR PA Gain':0:POS_6_DB

Assuming there is nothing crazy and bluetooth voice works for you, can you try both gains and see if that makes it less tin'y for you as well?
[HTC Droid DNA] times_infinity:
If you guys don't mind me asking, since you two seem to be squashing bugs left and right, what was keeping the DNA from getting official CM support for 10.1?
[HTC Droid DNA] chad0989:
Nothing other than the fact that we haven't submitted the tree. I want the camera to be fully functional before we even consider doing it. We need to get rid of the crash on the FFC.
[HTC Droid DNA] jctennis:
That's great, I'd love to be official. More of a status symbol than anything. You guys are doing a great job!
[HTC Droid DNA] times_infinity:
Gotcha. What I don't get, is most HTC phones have FFC problems because of face detect. And I'm pretty sure that's the problem here too, but I looked at the camera wrapper and you guys have face detect disabled.
[HTC Droid DNA] -DroidIsDNA-:
Guys, I hate to sound rude, but this is a development forum for developers. I'm sure they check flyhalfs 10.2 thread so please leave this clean :)
[HTC Droid DNA] .torrented:
If I'm not mistaken that only seems to have disabled it for the RFC not the FFC
[HTC Droid DNA] chad0989:
Its a bug in the libraries, despite it being disabled, it still detects a face on the front camera and tries to do some sort of post processing.
[HTC Droid DNA] renzo.olivares:
still can't seem to get passed this error definitely not related to my changes same happens on stock android 4.3 htc kernel atleast for me tried on both on cm10.2 toolchain and google's 4.4.3 toolchain
[HTC Droid DNA] chad0989:
I just pulled your camera source and fixed it up to build. Testing now.

To fix that error in adreno_snapshot.c remove "inline" from:

static inline int parse_ib

so that it is:

static int parse_ib

There's two instances so make sure you get them both.

Which camera libs are you using with that kernel? The m7 GE ones? Or 4.2.2 sense?
[HTC Droid DNA] renzo.olivares:
you're the man!! was up all night lol
[HTC Droid DNA] renzo.olivares:
they work with either from what i've seen on either rom camera works flawlessly whether the GE Port of 4.2.2 sense port
[HTC Droid DNA] chad0989:
Okay. I'll give those libs a shot.
[HTC Droid DNA] renzo.olivares:
how'd it go? are you still using our dna's camera wrapper? maybe we have to use the one's wrapper.
[HTC Droid DNA] .torrented:
Have there been any changes to MTP or how it works?

Edit* I see that vold.fstab was removed more like moved to a different file.
[HTC Droid DNA] renzo.olivares:
its in the ramdisk now.... fstab.dlx now i believe
[HTC Droid DNA] .torrented:
Yeah, it was causing issues with 4.2.2, must be a 4.3 thing
[HTC Droid DNA] chad0989:
I'm still getting a crash. Its not anything to do with the wrapper though. It looks like I'm getting a seg fault when it tries set_led_state. I'm guessing that the flash must be handled differently in the new libs and needs to be updated accordingly.
[HTC Droid DNA] chad0989:
Got it. FFC works well also (no crash with faces). A few changes and some cleaning up and I'll push tonight or tomorrow.
[HTC Droid DNA] renzo.olivares:
4.3 kernel source is out if you want to try merging that from the one or i'll give it a shot after u push ur source
[HTC Droid DNA] chad0989:
I just pushed everything. There are some resolution issues but those should be able to be easily fixed in the wrapper or overlay.
[HTC Droid DNA] renzo.olivares:
yea i see the problem in the overlay i believe, also is this change still necessary?

https://github.com/CM10DNA/android_device_htc_dlx/commit/ce56a96354e02188c595b995fe9e5d32b0eb523b

seems they've worked out the issues

edit: also shouldn't the path be changed to /overlay/packages/apps/Focal/res/values/arrays.xml instead of camera path
[HTC Droid DNA] times_infinity:
Looks like we're missing resolutions in the overlay.
[HTC Droid DNA] renzo.olivares:
Sent some pull requests.... working on 4.3 camera changes for kernel right now
[HTC Droid DNA] chad0989:
Its not necessary now, but it will be. I want to leave it in because as soon as they allow the new HAL to build our build will break.
[HTC Droid DNA] chad0989:
Just pushed a GPS HAL I'm playing with to cm-10.2-gps. It should have hardware geofencing support but I'm not 100% sure if its working right now. If some want to test go for it.
[HTC Droid DNA] renzo.olivares:
system.prop

-ro.telephony.default_network=10

+ro.telephony.default_network=8

chad this change fixes an issue were i wouldn't get service or data on first boot which would essentially leave me stuck in the setup unless i did the combo and got out and manually switched the default to cdma/lte in settings and ruim/sim even then on reboot data got lost, this fixes that issue so data on first boot and sticks on reboot, seems when it's set to Global that RUIM/SIM refuses to set, running like a champ =) oh flyhalf's 8/06 build is were this happened
[HTC Droid DNA] chad0989:
To clarify, its better at 10, or 8?
[HTC Droid DNA] renzo.olivares:
hehe sorry it's better at 8, on 10 i don't get service/data on first boot until i change it in mobile network settings to 8 (cdma/lte)
[HTC Droid DNA] renzo.olivares:
camera flash also seems to be partially broken idk if you caught it or not
[HTC Droid DNA] chad0989:
What's the issue? I'll look into it tonight.
[HTC Droid DNA] renzo.olivares:
well it behaves differently then it does on my s3 running cm 10.2, on the s3 when it's dark and i touch the screen (not the shutter button) to auto focus the camera flash turns on to actually be able to focus on something and not just darkness, but on the dna when i do the same camera flash does not turn on. idk if i explain it correctly let me know if you understand
[HTC Droid DNA] nsmal24:
Firing the flash to assist focus is a built-in function of the s3 camera. The dna doesn't do this even on stock. It's one of my big pet peeves with the dna camera. It is normal behavior however.
[HTC Droid DNA] crpalmer:
I have no idea how to tell if the geofencing is working or not. I did build this version and try out the GPS support and it worked fine for me. Any easy way to test the geofencing?
[HTC Droid DNA] chad0989:
I'm not sure of a way to positively test it. I was hoping someone else had an idea. I tried apps from the market but they work regardless. The hardware support is supposed to be lower power.
[HTC Droid DNA] chad0989:
I agree. I'm pretty sure that's a samsung only feature and is inherent in their proprietary libs.

Although, that is a really good idea to implement for all devices. Hmm....
[HTC Droid DNA] Flyhalf205:
Should tell you that the build I posted early this morning has the cm10.2-GPS branch so you could ask in the Rom thread how they are reporting it.
[HTC Droid DNA] djh816:
Isn't this just doing the wifi location grab, just transparently? That was my understanding. The wifi thing has worked in google maps for a while I thought this was just the silent automation of the existing "turn on wifi to 'improve' location" prompt. wifi location seems to be working as normal. I would assume that's all geofencing uses. Probably just google trying to get more access points in their known list.
[HTC Droid DNA] renzo.olivares:
probably placebo but when updating some prop libs from HTC One GE 4.3 and now rom seems a lot smoother i was having some lag issues before...will make a pull request

edit: pull request sent
[HTC Droid DNA] crpalmer:
[MENTION=3124509]chad0989[/MENTION], I just sent you 4 pull requests for the kernel. I try to keep separate topics in separate requests to make it easier for you to decline sets of changes that you don't want. Do you like that or would you prefer I just slapped them all into a single big pull request to save you having to deal with 4 of them?
[HTC Droid DNA] chad0989:
Sorry I haven't gotten a chance to check these out yet. I'll try to this weekend.

Either way is fine, it's up to you. I didn't get the requests though.

On another note, I have a feeling that the flicker issue may be related to dithering. I haven't gotten a chance to look at what changes were made regarding dithering in our updates but I'm crossing my fingers on it.
[HTC Droid DNA] crpalmer:
I'm a little skeptical... I could image something wonky with dithering causing something that looked like flickering, but how would it be only on the edges of the screen? I'm willing to consider any options though so if you have anything that you want me to try out with my phone I'd be happy to.

I currently believe that we have the same issue that the fireball is seeing and I haven't seen any mention of the M7 having the flickering issue.

I believe that the fireball is using android_kernel_htc_msm8960. The video code seems to be largely the same between our three kernels. The M7 has some additional functionality and the HDMI code is all over the place, but otherwise I don't see anything obviously different between the M7 and the fireball.

That combined with the fact that it carries over to recovery (even after turning the phone off and on again), makes me keep going back to clocks.
[HTC Droid DNA] KyJelly69:
Does changing the surface improvement option in performance make any difference?
[HTC Droid DNA] crpalmer:
No obvious difference, but it's hard to know because the flickering continues even when the problem is removed (power off / on / reboot recovery)...
[HTC Droid DNA] whirl08:
Chad/crpalmer - I disabled dithering, and my slight flicker I had is gone... but it could be a fluke.
[HTC Droid DNA] KyJelly69:
Even in recovery?
[HTC Droid DNA] whirl08:
Yeah, I've got no flickering anywhere right now.

I think that once the flickering diminishes, it's not visible in recovery and vice versa. I disabled dithering in performance menu, and let it sit idle for about 30 mins and it's gone.
[HTC Droid DNA] Gorilla*:
Audio only picks up from the top noise canceling mic when using google now or other voice services.

Can this be fixed to use the traditional bottom mic?
[HTC Droid DNA] KyJelly69:
Just saying...
[HTC Droid DNA] whirl08:
It appears to be random, because it's back now. Not as horrendous as it was on 4.2, but still visible. Dithering really didn't make a difference. Fluke :-\
[HTC Droid DNA] brennam7:
Chad/palmer...

Not sure if its any help, but my flickering went away from 4.2.2 to 4.3. I was one of the people having terrible flickering (stayed with aosp because sense blows goats)

Once again, not sure if it helps or just clutters the thread, just wanted to get it out there
[HTC Droid DNA] times_infinity:
HTCCDMAQualcommRIL got merged. Wonder if it'll benefit us at all.
[HTC Droid DNA] d08speed3:
Same here! Had horrible flickering on my phone on 4.2.2. Got a replacement phone this week (speaker blew) loaded CM 4.2.2 and what do you know flickering. So I loaded 4.3 and BAM no flickering and its been that way since Tuesday!
[HTC Droid DNA] renzo.olivares:
sent some pull requests for selinux support in the device tree needs testing also added row scheduler from caf and sent a pull request as well
[HTC Droid DNA] chad0989:
I had a build going with selinux also. Haha. Looks like everyone thinks alike.
[HTC Droid DNA] times_infinity:
Data arrows don't work. Not really important, but kinda annoying.
[HTC Droid DNA] Phaded:
Please take bugs to your specific ROM thread. This is for dev only.
[HTC Droid DNA] crpalmer:
[MENTION=3124509]chad0989[/MENTION],

A handful of users have made a comment about flashing 4.3 fixed the flickering problem. I was starting to worry that there was something specific in my kernel that was actually causing it so I spent last night and today running the built-in kernel (my build was from around 6pm eastern on Saturday). It still definitely has the flickering problem. I started this morning flicker free and was flickering somewhat after a few hours and flickering like crazy after about 5 hours. I left it installed to see if it would resolve itself like it does after restoring a Sense version. No happiness there.

I'm gradually running out of things to try to fix it. Did you look into the dithering at all to see if there was something there? I did see a dithering enabling change in the open CM commits this morning which, if you're right that it is dithering related, could explain why people think it is working better with 4.3.
[HTC Droid DNA] chad0989:
I'm messing with a few changes now. I noticed that I am able to see a very very faint flicker at times at the edges at certain brightness settings and certain backgrounds so I'm using that as my baseline.

I'm going to push my changes to a cm-10.2-flicker (kernel and device tree) branch right after I test this latest build. You can build off of it and let me know if it helps. It contains a dithering change as well as changes to the backlight. If it does by chance help maybe you will be able to isolate what helps and what doesn't.

You will need the patch you mentioned earlier also:

http://review.cyanogenmod.org/#/c/46671/
[HTC Droid DNA] crpalmer:
Mind pushing them up before you test them? I could kick off a build in parallel and I'm really curious to see what you're trying.

---------- Post added at 08:13 PM ---------- Previous post was at 07:25 PM ----------

I see that you pushed some changes up. Am I being dense or is the kernel change the same as setting brightness to 100%? Or do you think that CM is not actually setting it to 100% when it says 100%?
[HTC Droid DNA] chad0989:
That was an incorrect change. You're 100% correct. Going to push another now.

Edit: Should be up now. I think what I want to do is play with the led pwm frequency. Reading up on it we may either want to increase OR decrease the frequency. It depends on what the led driver can handle. This change puts it at what the m7 is using.

Edit 2: Testing it, 28k seems to actually make mine flicker more. Maybe if we play with it we can find a value that works... or maybe its unrelated to the source of the flicker on other devices.
[HTC Droid DNA] crpalmer:
You were too slow on getting it up. I'm running another test version now that I'm going to wait until it starts to flicker tomorrow before abandoning. I pulled in the latest m7 kernel commits which included one that I thought looked promising:

commit b7d9533fe2f50f725c96f2e7f01f0f224269ff6f

Author: Jordan Crouse <jcrouse@codeaurora.org>

Date: Thu Jul 18 16:20:08 2013 -0600

msm: kgsl: Use the kmalloc/vmalloc trick for the sharedmem page array

It was previously assumed that most GPU memory allocations would be

small enough to allow us to fit the array of page pointers into one

or two pages allocated via kmalloc. Recent reports have proven

those assumptions to be wrong - allocations on the order of 32MB will

end up trying to get 8 pages from kmalloc and 8 contiguous pages

on a busy system are a rare beast indeed.

So use the usual kmalloc/vmalloc trick instead - use kmalloc for the

page array when we can and vmalloc if we can't.

CRs-fixed: 513469

Change-Id: Ic0dedbad0a5b14abe6a8bd73342b3e68faa8c8b7

Signed-off-by: Jordan Crouse <jcrouse@codeaurora.org>

I wondered if this could explain why it worked fine for awhile (I never have flicker first thing in the morning) but then started.

I doubt that this will fix it though. When the flickering is bad, the phone does look more like the backlight is the problem. I missed the change you just committed when I looked through board-m7-display differences... Would the LED frequency be related to the panel's frequency? From memory, I think we are at 848 MHz and the M7 is at 860 MHz.
[HTC Droid DNA] chad0989:
I'm not sure how they're related, I'm pretty much grasping at straws. Logically it makes sense that the LED frequency can cause a flicker at some frequencies, but 28khz is far far beyond what the eye can perceive so at the same time it doesn't make sense that it could be the source.
[HTC Droid DNA] crpalmer:
Yes, I'm definitely grasping at straws as well. That commit is unlikely to help but I already had it built and running so I'll see what happens.

The reason I thought it was vaguely possibly related is that it could potentially explain why my phone is always perfect in the morning (after being idle) and then typically continues to show no flicker for a couple of hours before the flickering starts and gradually gets worse and then often it will ease up and then bad again).

I also think that there are several problems. You may be seeing a dithering problem which I'm not even seeing yet...
[HTC Droid DNA] crpalmer:
[MENTION=3124509]chad0989[/MENTION], no luck with any of the changes. With my change, it started to flicker very slightly after 3.5 hours. I installed your kernel changes (no device changes) and the flicker went away but then started again 2 hours later (and was flickering badly). I installed the ROM + kernel changes and they haven't stabilized in the last hour or so. I'm pretty sure that means that it's not a magic fix either.
[HTC Droid DNA] orangechoochoo:
My luck ran out, I'm getting a slight flickering on 4.3 Carbon with the stock kernel.
[HTC Droid DNA] d08speed3:
See! Lol

His: HTC DNA

Hers: LG Optimus G