yashsingh1/xdaforums huggingface dataset:
[One (M7) Themes and Apps] rayjr13:
It should load the replacement icons anytime the icon changes/is called right? Like a signal icon would be called everytime you change from 2 bars to 3 bars. and the status bar is always changing and calling icons. As most of these are status bar mods I'd expect the module to crank away almost nonstop with replacements.

/phone/stat_notify_voicemail.png

is not apart of the theme as far as I know. If you have that icon in the phone folder there is not a request for it. It should not be in there or it should error out the script. I don't have it in my theme and I don't get a missing error, and that folder is not dynamic afaik. if you do want it to be replaced you SHOULD try putting in apps folder and apps.txt for now. and see if it works. otherwise you can ask [MENTION=434511]agentdr8[/MENTION] about adding it in to /phone/ or making /phone/ dynamic, because I'm pretty certain it is neither.
[One (M7) Themes and Apps] agentdr8:
Xposed runs its hooks any time the targeted app runs whichever method is being hooked. For the apps.txt replacements, this means any time any app listed in there runs and requests a drawable resource, it tries to load the replacement. Some apps do this heavily at boot-up, and then less frequently if they're in the background.
[One (M7) Themes and Apps] agentdr8:
Yep. The exception to this is framework icons. They get loaded once at boot time, and that's it.

/phone and /misc content arrays are dynamic as of 2.3.6g. But com.android.phone doesn't have a stat_notify_voicemail.png resource.
[One (M7) Themes and Apps] agentdr8:
The default pack is included within the apk, in res/raw. It gets extracted to /sdcard/xsbm only if that directory does not exist (like first-time installs), otherwise it assumes it's been extracted already.

I usually also post it to the theme thread.
[One (M7) Themes and Apps] rayjr13:
Nullpointer exception is when the file is in the folder but shouldn't be?

android.content.res.Resources$NotFoundException exception is when it's not in there and should be?

---------- Post added at 12:36 PM ---------- Previous post was at 12:33 PM ----------

How do you use the misc array dynamically? I know obviously if one is missing it isn't a problem, but how do you know what you can add lol?
[One (M7) Themes and Apps] shpitz461:
I see. So it doesn't ask for a specific icon, therefore you need to reload all the icons? In the case Ray presented where the signal icon needs to be redrawn, you would think just that icon-set will be loaded, but the log shows that the complete icon-set is loaded.
[One (M7) Themes and Apps] agentdr8:
I should be catching the NPE so it doesn't get thrown. I must have missed a null array check somewhere.

This should be the case when you put a file in a folder and there is no resource found matching that filename within the target class/app.

Good question. I hadn't thought about that. lol. I'll see if I can come up with a list of what should go in there.
[One (M7) Themes and Apps] agentdr8:
A lot of the statusbar icons are requested constantly by the SystemUI process. I thought about caching frequently-requested icons, but that would incur quite a bit of memory penalty. With the One (m7/m8), the cpu and filesystem is plenty fast, and it then frees up the ram for other apps to utilize.
[One (M7) Themes and Apps] agentdr8:
Ok I posted a new beta version to the xposed repo. It should fix the NPE issue when the following folders are empty or missing: phone/, misc/, powermgr/. Also, those folders are now dynamic, just like the framework folders. Here's a break-down of what they can contain:

- phone/

Any drawable resource located within com.android.phone

Common ones: stat_sys_speakerphone, stat_notify_call_mute, stat_sys_phone_call, stat_notify_missed_call

- misc/

Drawable resources normally found on the left side of the statusbar, or ones on the left side of the right half of the statusbar. These are com.android.systemui resources.

Common ones: stat_notify_alarm, stat_notify_image, stat_notify_image_error, stat_notify_more, stat_sys_headphones, stat_sys_no_sim, stat_sys_sim_lock, stat_sys_sync, stat_sys_sync_anim0, stat_sys_sync_error

- powermgr/

Any drawable resource found in com.htc.htcpowermanager

Common ones: stat_notify_power_saver, stat_notify_application_monitor

This info will make its way to the iconpack info post at some point.
[One (M7) Themes and Apps] shpitz461:
Awesome, thanks!!

Is there a complete list somewhere of what goes where?
[One (M7) Themes and Apps] agentdr8:
For the most part, post 2 is still accurate, with the exception of:

framework/

This has been split out into framework/, htcframework/, htcresources/ and dsp/.

- framework/ is for resources found in the android package (framework-res.apk)

- htcframework/ is for resources found in the com.htc.framework package (framework-res-htc.apk)

- htcresources/ is for resources found in the com.htc.resources package (com.htc.resources.apk)

- dsp/ is for Beats or Boomsound resources (stat_sys_beats.png or stat_sys_boomsound.png)

And of course the 3 folders listed in my post above. Everything else should be the same.
[One (M7) Themes and Apps] rayjr13:
I think specifically the exception being that only icons in the "checked" sections are loaded. I only have framework checked so I don't get any loads from other folder excep the three tied to "framework"
[One (M7) Themes and Apps] heather1209:
I know it's technically a third party app and so no guarantees, but any thoughts on replacing the Google Maps navigation icon? I'm fairly certain it should be in the apps folder and text file called com.google.android.apps.maps-nav_notification_icon.png but it's not working and it also doesn't get colored if I try and change third party app icon colors. When I have the icon in the folder/text file, I get an error just like any other icon that may be in the pack but doesn't exist in the system to replace (I apologize, I don't have the exact wording).
[One (M7) Themes and Apps] rayjr13:
Still don't think it's ready for stable status?
[One (M7) Themes and Apps] agentdr8:
That does look to be right, based on what I can see in the decompiled code. The problem with Google apps are they are usually all obfuscated, so reading through their code is time-consuming and an exercise in futility.

Chances are, Maps is not requesting the icon in the way most apps do; with a getDrawable(R.drawable.resource_name). I think in that case the setReplacement method of xposed can't hook the call. The only way to replace it would be to find the actual method/class that the resource is requested in, and modify it there with a methodHook. Problem is, I can't readily see where this method is in their code. This is why the 3rd-party app stuff is experimental and will most likely never be able to progress beyond that.

Also, adding color to icons only works when the icon is successfully replaced. It won't add color to any stock/non-replaced icons.
[One (M7) Themes and Apps] agentdr8:
I'd rather work out these NPE kinks and stuff before promoting it. I think it's probably good at this point, unless I hear any other feedback.

Oh, and I'd want to get all the iconpacks updated to work with the new folder structure prior.
[One (M7) Themes and Apps] rayjr13:
I see. And it's your call but maybe remove 3rd party from your next stable version. Drop it back in the next beta.

There are other modules for general icon replacement that don't work as well on sense specific resources. So maybe your module just sticks to the basic title function. No one can be mad at you for that. Considering it does it to near perfection especially with the scaler.

Obviously if you are just up for the challenge or want to perfect your module doing third party apps is certainly doable in a way not far off from how you do it now.

sent from my T6DNA
[One (M7) Themes and Apps] agentdr8:
Well, the 3rd party apps support is just there for those that want to play with it. It'll probably never work 100% for all apps, and as long as people are aware of that, then I think it can just stay as a somewhat unsupported feature.

I'll post up a stable release tomorrow, and for the next beta, we can work on getting the Verizon support going.
[One (M7) Themes and Apps] rayjr13:
Yea it's always a beta app until it supports the best US network. ?

sent from my T6DNA
[One (M7) Themes and Apps] agentdr8:
Uploaded a new beta version to the repo for Verizon support. Select Verizon in carrier selection and give it a go.

Put those in the following directories: mobile/vzw1x, mobile/vzw3g, mobile/vzwlte

These are reused from the signal directory, and added the cdma 5 roams to signal/roam.
[One (M7) Themes and Apps] heather1209:
My mobile icons have been working thus far without this added support for Verizon. I was wondering why this is necessary if that's the case? Was it not working for everyone with vzw?
[One (M7) Themes and Apps] agentdr8:
[MENTION=4111823]rayjr13[/MENTION] requested it. Are you also on Verizon? The existing implementation for mobile icons only supported the 3-up/3-down images for all network types. The stock Verizon behavior is to use in/out/inandout icons, so that's what I implemented in the new beta. It will also do connected and dormant icons.
[One (M7) Themes and Apps] heather1209:
I am indeed Verizon. And that makes sense. Thanks!
[One (M7) Themes and Apps] themachinist:
Just wondering, is there any plans to hide icons e.g. hiding the "stat_notify_more" one? Or are there other xposed mods that allow such modifications?
[One (M7) Themes and Apps] agentdr8:
Sense 6 Toolbox should be able to do that.
[One (M7) Themes and Apps] rayjr13:
This appears to work really well. couldn't check all the functions like 1x and roaming but everything in the template replaced correctly and the mobile folders I only added one or two icons and the rest came from the rom successfully.

Looks good.
[One (M7) Themes and Apps] agentdr8:
ARHD is now up to 4.4.3. I've noticed a few icons from the default stencil pack that don't scale properly, probably because they are smaller than 76x76. If anyone has noticed any other issues running this mod on 4.4.3, please let me know.
[One (M7) Themes and Apps] kazemitsui:
I use the stencil pack, but havent noticed anything. But I mainly have it for battery, wifi, cell signal. most other icons not used.

What were the icons you noticed? and will it be updated?
[One (M7) Themes and Apps] agentdr8:
Just bluetooth and vibrate. I made some new ones that are similar but 76x76 and they look much better. Will update the default pack, along with the rest of the packs (bring them up to the latest layout) and release 2.4 stable.
[One (M7) Themes and Apps] rayjr13:
Waiting on 4.4.3 on santod040 One Max Rom. Thinking I may hang back acutally and stick to 4.4.2. not seeing the added headache vs the benefits yet. But if I do will let you know what I see. The one MAx port for the DNA poses some interesting rez and systemUI combos.

Glad to see a stable.
[One (M7) Themes and Apps] OnyxA:
Very nice.
[One (M7) Themes and Apps] jonata:
hi,

can I use on my new motoX 2014 2gen (KK 4.4.4) ?
[MENTION=434511]agentdr8[/MENTION] :

do you remember me ?

jonata ... help you to make italian translation ...

by :highfive:
[One (M7) Themes and Apps] agentdr8:
Hey there jonata! I doubt this mod would work on a MotoX; HTC has different class and method names in their SystemUI vs Moto or even AOSP.
[One (M7) Themes and Apps] rayjr13:
Cant recall how affected this will be but...the new decoupled Sense apps on the play store are also decoupling the reliance on the Sense framework. Similar to the ports of Sense/Blinkfeed component happening on XDA.

That being said if people notice modded icon no longer working in some app, it may likely be that the source change in the frameworks and SystemUI are no longer relied upon in the updated app.

I have seen this specifically in the new HTC Weather app posted to Google Play Store.
[One (M7) Themes and Apps] captainreynolds:
So, in their recent updates, the T-Mobile stock rom on the HTC One shows wifi and the current data connection at the same time. In my search to hide the data icon while connected to wifi, I found this xposed module which works great. However, on the "T-mobile" mode, it does not hide the data connection. If I choose the "international version" mode, it does hide the data connection - however, for some reason, it changes the icon pack for the data connection and it looks different when I disconnect from wifi. Is there anyway I can keep the T-mobile stock icons?
[One (M7) Themes and Apps] agentdr8:
The easiest way I can think of would be to select International as the carrier type, and then use a stock T-Mobile icon pack.
[One (M7) Themes and Apps] jonata:
hi mate,

come-back to HTC M8 ... :D

where to download the last ver of the mod ?

Thanks bro
[One (M7) Themes and Apps] agentdr8:
Welcome back. The xposed repo has the latest version. I think it's marked as experimental, but I'll be moving it to a stable release soon.
[One (M7) Themes and Apps] jonata:
hi,

thanks ...

download link is only for playstore ...
[One (M7) Themes and Apps] agentdr8:
Oh, it's also under the Downloads tab at the top of the thread.
[One (M7) Themes and Apps] rayjr13:
Xposed For 5.0 ... time to get back yo work lol. As you can see I moved on from my DNA. But still have it. Either way I'm curious to see your module work on 5.0. But I've got no root or 5.0 atm.

Sent from my Electric Boogalocked Turbo
[One (M7) Themes and Apps] agentdr8:
Yep, now that there's a working framework, I'll be flashing LP on my m7 and get to work :)
[One (M7) Themes and Apps] GerRudi:
Great to hear that you'll still update it after two years, very nice!

I never used this Mod before but I'm looking forward to it, because it has pretty much all the functions of GravityBox that I'd like to have for my Lollipop Sense ROM.

One thing I'm missing though is to slide on the Statusbar to adjust the brightness, do you think this is hard to implement? Because I would seriously love to see that mod!

Anyway thanks for the upcoming update and good luck :good:
[One (M7) Themes and Apps] agentdr8:
I posted this in the MaximusHD thread, but forgot to put it here. I've made some progress:

Maybe the GB implementation of the slide for brightness can be adapted for Sense. Will see how much effort is involved once I can get the base functionality working.
[One (M7) Themes and Apps] PdroidAndroid:
Hi, congratulations for this module, I am an user since long time.

Is this module open source ? I'm interested in how status clock is hidden.

Thanks
[One (M7) Themes and Apps] agentdr8:
This particular module isn't, but both the GPE and SGS variants are, and are posted on my github. They all share similar code.

For hiding the clock, I believe I'm just inflating the status_bar layout and changing the clock TextView visibility to View.GONE.
[One (M7) Themes and Apps] b3nji27:
Wait so is xsbm working on lollipop now? Because this is the only mod I've been wanting and have held off re rooting my m8 until this was done and xposed was out
[One (M7) Themes and Apps] agentdr8:
It's sort of working. Signal bar icons are the last thing to fix, but it seems to be a XF issue, or possibly some sort of ART optimization that needs to be worked around.
[One (M7) Themes and Apps] kazemitsui:
awesome news [MENTION=434511]agentdr8[/MENTION] this is definitely one of the mods im waiting for before moving to android5.0 on my m7!
[One (M7) Themes and Apps] iBART:
Are you planning to release it for 5.0.2 or 5.1?

I'm on 5.1 GPE rom and i need your module :P
[One (M7) Themes and Apps] agentdr8:
5.0.2 for now. Probably not until the framework is stable though.
[One (M7) Themes and Apps] agentdr8:
With rovo's latest release of the Xposed Framework for LP (alpha 3/bridge version 64), the module is closer to being 100% compatible. There are some outstanding issues; mainly GPS icons, and possibly some framework icons. I also haven't looked into the transparent statusbar, or the transparent notification window. That said, I've posted a new apk on the Downloads tab (up top) for those that want to try it out.
[One (M7) Themes and Apps] kazemitsui:
honestly most of my other modules work on LP now, but this is the one mod that i really want to work on LP. so great work and thanks! waiting for this before i move over to the latest arhd
[One (M7) Themes and Apps] sopiclan:
I just tried 2.4.0 but went back to 2.3.5 (all on xposed 3.0-alpha2)

For my settings these a the results

2.3.5 not working are GPS icon, alarm icon & battery colorize

2.4.0 not working are GPS icon, alarm icon & battery icon (it just disappears)

Still i'm happy with the things that do work

keep up the good work
[One (M7) Themes and Apps] bdizzle1686:
Hey [MENTION=434511]agentdr8[/MENTION] first off , great module, been using it since I got my m7 last may... I have a feature request / suggestion that no other Xposed htc module does, and as yours is specifically for statusbar mods , figured id c if u could implement it..

As u know, each one M# model has different audio settings and icons

(M7-beats, M8/M9- Boomsound, M8hk-Harman Kardan, etc.) Well, I always wanted the ability to change which icon appears in status bar , Example: M7 always shows beats audio icon, yet I've always wanted the ability to change/switch it to Boomsound icon, etc...

Would this be something that maybe eventually u could try implementing ?
[One (M7) Themes and Apps] agentdr8:
Try doing a complete uninstall-reboot-reinstall-reimport-reboot with 2.4.0.
[One (M7) Themes and Apps] agentdr8:
This is already possible by replacing the applicable icon (dsp/stat_sys_[beats|boomsound].png) in an iconpack. It picks the filename to use based on the hardware model.
[One (M7) Themes and Apps] sopiclan:
Tried it didn't help

When I have more time I'll do some more testing. My battery icon map is empty and if I choose to override battery icon, the icon disappears.

So I'll do some testing with other icon packages.
[One (M7) Themes and Apps] agentdr8:
Battery icon map? What is that?
[One (M7) Themes and Apps] sopiclan:
This one

I see the confusion i should have said Battery icon folder instead of map
[One (M7) Themes and Apps] agentdr8:
So you're saying the iconpack you're using has no images in the battery/ or battery/charge folders? Then it's working as designed, as it has no images to use as replacements.

Check the following directory on your phone and see if the iconpack is being unzipped properly: /data/data/com.dr8.sbicons.sense/xsbm
[One (M7) Themes and Apps] sopiclan:
The directory is filled the same way as the icon zip-package it imported.

So that's working good....

I'll play with some other packages over the weekend...to see if i messed-up my zip-package. But on Android 4.4.3 with 2.3.5 everything was working fine. So i think i has something to do with android 5.0.2..

But still i'm happy with everything thats working already
[One (M7) Themes and Apps] agentdr8:
It's possible. LP introduced most people to selinux enforcement, which causes all sorts of "issues" that weren't present in KK. You can also try setting selinux in permissive mode, then soft-reboot. I'm pretty sure I tested it in both enforcing and permissive, but it's possible something there is blocking.
[One (M7) Themes and Apps] sopiclan:
i'm already using permissive mode

I'll give you feedback after testing different zip files:good:
[One (M7) Themes and Apps] osiedacz:
GPS Icons

I know you mention that gps icon replacement doesn't work, but I wanted to at least give my experience with it. I am running xposed alpha 4 with stock at&t 5.0.2. I tried a few of the options in your module, but in all cases I had NOT checked the box to replace the gps icons. However, the mod was replacing them anyway. But in a very strange way. I tried 3 different icon packs which I'll list below. But no matter which one I tried my acquiring gps icon came from the stencil pack. Once the signal was acquired, the icon changed to the correct one for the pack I had selected. But the crazy thing is that I was not trying to replace the gps icon at all. If I disable the mod entirely, my stock gps icons come back.

Icon packs tried: skawt_iconpack_sense6.xsbm, itiskonrad_stencil_sense6.xsbm and agentdr8_stock_sense6-pct
[One (M7) Themes and Apps] agentdr8:
Yeah, I forgot to mention that. With Sense 6 and LP, the alternating animation when it's getting a gps lock come from stat_sys_gps_acquiring_anim.xml, which lists the 2 individual images, stat_sys_gps_on and stat_sys_gps_acquiring. Unfortunately under LP, replacing those 2 images individually doesn't seem to work. In the meantime, I just added the stencil images into the module resources, and replace the animation drawable.

So until I can figure out or work around that animation drawable issue, it'll just show the stencil gps icons for the animation.
[One (M7) Themes and Apps] osiedacz:
Got it, that makes sense. But also note, if your xposed mod is activated, there is no way to disable the gps icon replacement. It is replaced regardless of the checkbox for the gps icon.
[One (M7) Themes and Apps] agentdr8:
Ah, I messed up the preference in the process. I've fixed it in the version I just uploaded to the Downloads tab. Now it won't override the GPS animation at all, but it should show the preferred GPS "on" icon when a lock is finally achieved.
[One (M7) Themes and Apps] iElvis:
Any chance of updating for Sense 7/M9? I tried with the xposed alpha and nothing changed, I suspect because the file names/locations are all different. I am happy to help if you need dumps or whatever.
[One (M7) Themes and Apps] agentdr8:
I would need the SystemUI.apk, framework-res.apk, and framework-res-htc.apk from a deodexed rom.

Also, is the m9 running 5.0.x or 5.1.x?
[One (M7) Themes and Apps] iElvis:
Here are the files from ARHD, which is 5.0. We don't have 5.1 for the M9 yet, not even CM.

https://www.dropbox.com/s/bg0dai5n41o4qvj/M9.zip?dl=0
[One (M7) Themes and Apps] agentdr8:
Thanks. The classes I've looked at so far don't appear to be any different than those from Sense 6, so it should "just work".

Can you try enabling debug, and enable just the battery icon override to start with? If that works, move on to others one at a time, saving framework for last.

And when it fails to work, post up the xposed error.log?
[One (M7) Themes and Apps] iElvis:
Oh, FFS, I didn't have any of the icon overrides enabled. :rolleyes:

Battery, mobile data, and wifi are not working. Bluetooth and signal strength are.

Here's the log.
[One (M7) Themes and Apps] agentdr8:
Can you disable framework and leave the rest enabled and reboot to see if that changes the outcome?
[One (M7) Themes and Apps] iElvis:
Didn't help help. GPS is working, though--forgot to mention.

I enabled just battery, signal bar, data, wifi, bt, and gps. This was the log. No apparent errors.
[One (M7) Themes and Apps] agentdr8:
Can you post the updated error log?

Also, which version of the mod are you using?
[One (M7) Themes and Apps] iElvis:
See above. I have 2.3.5.
[One (M7) Themes and Apps] agentdr8:
Try 2.4.0a from the Downloads tab up top.
[One (M7) Themes and Apps] iElvis:
Yeah, just noticed that one, sorry. Installed and rebooted. Battery is now working, but wifi and mobile data still are not.

Log attached
[One (M7) Themes and Apps] agentdr8:
Ah, I know why. Can you run this real quick and provide the output?

/system/bin/getprop ro.build.sense.version

I have a new build that should address those two icons assuming the output is "7.0".
[One (M7) Themes and Apps] iElvis:
Yep, 7.0 it is.
[One (M7) Themes and Apps] agentdr8:
Try 2.4.0b that I just uploaded.
[One (M7) Themes and Apps] iElvis:
Wifi is now working, but still no mobile data. :(
[One (M7) Themes and Apps] agentdr8:
Hmmm. Can you run this:

logcat | grep -i Xposed > /sdcard/Download/logcat.txt

And provide that log file?
[One (M7) Themes and Apps] iElvis:
Okay, I ran it, but what did you want me to do? I went into the module and exited, reapplying the settings.
[One (M7) Themes and Apps] agentdr8:
Upload the logcat.txt from your Download directory.