yashsingh1/xdaforums huggingface dataset:
[Galaxy S III Android Development] DespairFactor:
Got this working on my shamu now:) Sweet! I had to do a little tweaking since I have LCD notifiers and powersuspend

Another note, kernel adiutor also support profiles, it is a tunable

[MENTION=3279788]ZaneZam[/MENTION], I will look at adding another option to the declarations for suspending to allow shamu devs to use the driver properly before I push it to my github. A few of us use LCD notifiers for some hotplugs and powersuspend as well, so we need to be able to prefer powersuspend for the suspend functions and still use our hotplugs:)
[Galaxy S III Android Development] DespairFactor:
[MENTION=3279788]ZaneZam[/MENTION] here is the commit for the LCD Notifiers and Powersuspend simultaneous usage. Let me know if you see anything I missed. Also, feel free to use it:)

https://github.com/DespairFactor/N6/commit/4b58d4d13512a42d318a311e65aae421ca613cf2
[Galaxy S III Android Development] ZaneZam:
apparently i was lost in macros in latest versions, well that might be also a result of less time for coding :)

thx man appreciated, this is kind of already in in beta8 but i will cross check yours and 'mine' (respectivley from another attentive guy *g*, thx [MENTION=2743057]legolas93[/MENTION])

maybe i can merge that together then.

cheers
[Galaxy S III Android Development] DespairFactor:
NP, just thought it made more sense to fix it properly in my source since others on shamu may pull it from me.

EDIT: on my own device the hotplugging doesn't actually seem to be working. Has this functionality been changed? I have tried it with a BFS and CFS CPU scheduler.
[Galaxy S III Android Development] ZaneZam:
yes was a good idea, so they have the fix earlier, beta 8 is in progress but still in a very early stage ;)

ehm, can't answer the "EDIT" question here and now i would have to check your settings in the governor. yes there were some changes related to it but they should impact functionality

in no way. will have a closer look into your sources when i have a bit more time.
[Galaxy S III Android Development] cantthinkofagoodname:
Could someone please tell me the values of the tunables that are changed with the Yank Optimal and/or Battery profile? Would really help a lot.

Edit: For the governor from the man above me ofcourse.
[Galaxy S III Android Development] ZaneZam:
the values can be found inside the profiles file: https://github.com/zanezam/cpufreq-governor-zzmoove/blob/opo-bacon/cpufreq_zzmoove_profiles.h

the link points to the snapdragon variant if u want the exynos values change to i9300 branch. ;)
[Galaxy S III Android Development] Myself5:
[MENTION=3279788]ZaneZam[/MENTION] I finally found some time to try compiling zzmoove for the Z2/Z3 again. I used the newest Version straight from Boeffla Kernel, however, now zzmoove refuses to compile.

this is the error I get:

http://sprunge.us/cDaY

Kernel Source is here:

https://github.com/Myself5/android_kernel_sony_msm8974

I hope you can help me with that.

Thanks in advance!
[Galaxy S III Android Development] ZaneZam:
great! ok either i'm blind or there is no zzmoove error in your log :)
[Galaxy S III Android Development] Myself5:
Oh wow I failed at dumping the error out to the page too... I'll get you a new one ASAP. It was something about a missing function.

I just browsed a Hangouts chat with a friend, thats the error:

../../../../../../kernel/sony/msm8974/drivers/cpufreq/cpufreq_zzmoove.c:7784:31: error: 'powersave_powersuspend' undeclared (first use in this function)

* * * register_power_suspend(&powersave_powersuspend);

I'll get you a complete one ASAP.
[Galaxy S III Android Development] ZaneZam:
no problem, now i can guess in which direction the error goes. might be one of the macro issues i've put in (unintentionally of course *g*)

your kernel has the powersuspend implementation included which was automatically "detected" by zzmoove but the issue

is that USE_LCD_NOTFIER (if enabled) accidently excludes the definition of the needed struct "powersave_powersuspend"

so the quick fix would be either disable powersuspend in kernel config (which might not be a good thing if u want to use

it for other parts in the kernel) or disable the USE_LCD_NOTFIER macro. OR wait for next version which fixes this ;)
[Galaxy S III Android Development] Myself5:
Well, afaik I did implemented lcd notifier just because it was needed by zzmoove.

https://github.com/Myself5/android_...mmit/4f196e4b8ce1013e8672911a28b2ea78149b8786

So I'll try by disabling it.

TIA!
[Galaxy S III Android Development] ZaneZam:
it's just an option so u can use it or u can use powersuspend ;)
[Galaxy S III Android Development] Myself5:
All right, I disabled the USE_LCD_NOTFIER macro as here:

https://github.com/Myself5/android_...mmit/d160333ac901a95a47b040a973800d1c8cf4b0f5

and compiled a Kernel.

Just flashed it, zzmoove seems to work :) (at least the phone did not reboot when I selected zzmoove)

I'll do some more tests about it. Thanks for your help so far ;)
[Galaxy S III Android Development] ZaneZam:
great to hear that, have fun with it ;)
[Galaxy S III Android Development] Ubimo:
I'm using boeffla kernel with zzmoove gov on my G900F but since a few weeks I'm getting random reboots using the zzmoove gov.

No OC or UV.

Most reboots I get with battery plus profile.

I' really loved your gov on my GT-i9300
[Galaxy S III Android Development] ZaneZam:
Yeah unfortunately known issue. we are on it. with "we" I mean lord boeffla and I. which kernel to u use? in case of boeffla kernel I would suggest to use the latest available version. it seems that version 1.0b6(with almost all new features disabled) works better than the new beta 7. too early to say it fixes the crashes but it looks promising. but I still have to find what's wrong with beta 7 if beta 6 keeps being stable.
[Galaxy S III Android Development] DespairFactor:
This could fix your issue if you need both notifiers.

https://github.com/DespairFactor/N6/commit/4b58d4d13512a42d318a311e65aae421ca613cf2

[MENTION=3279788]ZaneZam[/MENTION]

You don't have zzrelax in the OP.
[Galaxy S III Android Development] KURDKiNG:
Can i flash this kernel directly on top of beoflla kernel??
[Galaxy S III Android Development] ZaneZam:
even though that u are in the wrong thread I answer here: i guess you are asking if u can flash over the unofficial boeffla builds I provide. yes u can flash over and also vice versa ;)
[Galaxy S III Android Development] DespairFactor:
[MENTION=3279788]ZaneZam[/MENTION], are you available to speak with about the plugging prototypes used in the governor? I suspect there is something different in the prototypes that are causing issues with using this governor in 3.10.y kernels.
[Galaxy S III Android Development] ZaneZam:
Yes I'm here (almost every 30mins *g*)

well I discovered yesterday that there might be much more which can make troubles in 3.10+ sources.i even was kind of shocked because it goes in massive recoding direction ;) to see what's working i try building in 3.16 source these days but whithout hotplug, because this will be a desktop kernel. ;) but before I can do that I have to get rid of the profiles support. and there I'm "hanging" :)

to go into a deeper talk with u about hotplug prototypes I would have to reanalyse things as its been a while since I did bigger changes in that parts. I learn fast but I also forget fast :D (well that probably might be related to advancing age *g*)

can u give me same precise info what u think that makes troubles in 3.10 sources, next problem is I never used 3.10 sources so even can't imagine :)
[Galaxy S III Android Development] DespairFactor:
Shoot me a hangouts message if possible and we can try to work through getting it working on 3.10, I haven't fully looked at the source yet, but I'm eager to get this working for us. My hangouts is matthewdalex92@gmail.com
[Galaxy S III Android Development] ZaneZam:
thx will definitely do! coincidently exactly what I'm Woking on: compatibility with higher sources ;) but for today I'm off, just archived the profiles thingy. now compiling boeffla builds and then chilling :) cu on hangouts then..
[Galaxy S III Android Development] KURDKiNG:
Lol beofla updated today u gonna make yer compitable with his version?? And thnx bruh keep uo da good work
[Galaxy S III Android Development] sleeper994:
i'm pretty new to this, so can anyone suggest one of these governors that will help me reduce the temperature of cpu. I'm running boeffla alpha 9, and RR 5.5.3
[Galaxy S III Android Development] ZaneZam:
well we only have one governor here, but many settings for it :) what i can suggest would be the usage of the "game" profile setting. it has thermal blocks included.

or use any setting and give following tuneables the same values as they are in "game" setting :

65,	// scaling_block_temp

1100000,	// scaling_block_freq

5,	// scaling_block_threshold

3,	// scaling_block_force_down

this should help to reduce temperature ;)
[Galaxy S III Android Development] mostafaz:
Hi Zanezam :)

How this should act ?

When target temp reached then how many core should drop it's frequencies to 1100000 ? 3 core ( scaling_block_force_down ) ? if yes so it's value can be from 0 (n/a) to 4 for 4 core system

and scaling_block_threshold can get from 0 to 100 ?!! Threshold of what ?! load of core ?

edit: threshold of cpu load so it can go 5 more percent up -> 1155000

Thx ;)
[Galaxy S III Android Development] ZaneZam:
hi mos,

u answered your question yourself, its a load threshold yes :) but now i have one for u, what exactly do u mean

with "so it can go 5 more percent up -> 1155000" ?
[Galaxy S III Android Development] mostafaz:
hmm so it doesn't possible if this frequency not exist in freq-table !!?

i'd search in source for found the logic behind it but maybe misunderstood ! :p

another idea is if we have 6 freq table " 100 200 ... 500 600" and block freq is 100 thus it can ramp up to 500 if system needs :confused:

and stronger idea is threshold, but when ?

edit: it's all threshold,thx

ps: Thx for update ;)
[Galaxy S III Android Development] ZaneZam:
yeah u misunderstood a bit. its the same as with hotplug blocks it just waits the amount of blocking cycles till it decides the next time if a freq should go up or down

so it slows down the whole scaling thing and freq are staying longer. there are two modes the latter one, and this: it forcely pushes a freq down decision so it constantly

makes a "inverted" decision in the amount of cycles. so instead of going up as normal it goes down. so actually we do not have to deal with any freq or steps at all

as the block influences just the normal scaling process. dunno if that is more clear now for u, but that's how it works basically :)
[Galaxy S III Android Development] DespairFactor:
I have just fixed the powersuspend/lcd notifier issue on beta8, here is the commit for you all to use .

https://github.com/DespairFactor/N6/commit/26d641a4c13ff14c32faf2cdcab24c0b177e12bb
[Galaxy S III Android Development] Saber:
Zanezam :good:

I will compile a kernel build with the newest version of the governor and will report if it is error free.

Gsstudios
[Galaxy S III Android Development] KURDKiNG:
Im having troublr finding the links of da kernel
[Galaxy S III Android Development] konohanz:
There you are, may it helps you dude :)

http://boeffla.df-kunde.de/zanezam/linaro/
[Galaxy S III Android Development] DespairFactor:
The update with the zzrelax profile is running beautifully in my kernel, great work on the patch [MENTION=3279788]ZaneZam[/MENTION]
[Galaxy S III Android Development] Saber:
I still got the same problems I got on previous releases, the macro do not work correctly. But I just deleted the same lines and it builds correctly again :confused:

Thanks for the update zanezam!

gsstudios
[Galaxy S III Android Development] DespairFactor:
Explain the issue so we can sort it out
[Galaxy S III Android Development] ZaneZam:
bummer, you are talking about the "&dbs_info->prev_cpu_wall, 0)" problem u got previously, right?
[Galaxy S III Android Development] DespairFactor:
If this is it, remove the ", 0" at the end and try to compile.
[Galaxy S III Android Development] Saber:
Yeah, I've done that already and it is working fine on my phone.

Gsstudios.
[Galaxy S III Android Development] DespairFactor:
So, the solution is either stop trying to build with something that isn't truly 3.15 sources, or actually update your cpufreq drivers to be 3.15.
[Galaxy S III Android Development] ZaneZam:
yeah thats actually the problem i can't fix that whithout bringing in another macro to overrule again ;) the thing is CPU_IDLE_TIME_IN_CPUFREQ (which already was an exception for one plus one cm sources)

was made for backported 3.10 cpufreq which imply the existence of an additional parameter in get_cpu_idle_time function. so as DespairFactor mentioned u would have to update it to at least the 3.10 level.
[Galaxy S III Android Development] DespairFactor:
It's not something another filter would fix, since it is not a true 3.15. There is no real way for it to be modified to work with your source properly from an official support standpoint.
[Galaxy S III Android Development] Myself5:
Hum, looks like Sony Z series needs some special fix again... I used the unmodified beta8 snapdragon one.

http://myself5.de:12345/job/M5Kernel/109/console
[Galaxy S III Android Development] DespairFactor:
If you use hangouts shoot me a message and I'll help you fix it. Matthewdalex92@gmail.com
[Galaxy S III Android Development] ZaneZam:
Recommended Change!

Hi Guys (especially Devs),

i've just pushed a recommended change for zzmoove in develop branch:

removed conditional calculation of proportional frequency indroduced in

1.0 beta8 to fix sometimes returning 0 in 'zz_target' (=pushing to policy->min)

removed some uneeded things in 'zz_get_next_freq' function

fixed extensively falling back to proportional freq because of

missbehaving search optimization, this leads to a 'cleaner' scaling and

rarely falling back to proportional freq only on limit switching

as it mistakenly wasn't enabled before: enable freq search optimization

for ascending ordered freq tables

this patch should cleanly apply on all 1.0 beta8 versions

enjoy!

ZZ
[Galaxy S III Android Development] zeeshanhussain12:
How to change profiles

I have added zzmoove in my kernel and tried a lot to figure out how to change profiles but i was not able to change:p , some help would be appreciated:D
[Galaxy S III Android Development] konohanz:
Try to use Synapse on stock kernel or ArchiKernel, and Boeffla-Config v2 in Boeffla-Kernel :o
[Galaxy S III Android Development] zeeshanhussain12:
Actually I wanted to use it in my own kernel, nvm figured it out just change profile number in kernel auditor , thanks for helping
[Galaxy S III Android Development] robsonsilva:
Help

I get this error.
[Galaxy S III Android Development] ZaneZam:
Sry but never had such an error, so I can't say anything about it atm quick fix would be to disable thermal tripping. Just comment out the ENABLE_SNAP_THERMAL_SUPPORT macro. You won't miss this feature that much ;)

Gesendet von meinem ONE A2003 mit Tapatalk
[Galaxy S III Android Development] DespairFactor:
What is your SoC?

Don't worry bud, I'll look at this one for you:)
[Galaxy S III Android Development] robsonsilva:
Samsung Exynos 5410 (S4 GT-I9500)
[Galaxy S III Android Development] DespairFactor:
That is for snapdragon dude;) you are using a exynos, you shouldn't use that feature at all because its not for your SoC
[Galaxy S III Android Development] ZaneZam:
yes of course, thx despair ! i assumed he uses the right version . at 1:43am i didn't had much concentration left for getting in "deeper" :)

so [MENTION=6297150]treborbr[/MENTION] the exynos branch should be the right one for u even tough the difference between snapdragon and exynos versions are just

the pre-set macros.
[Galaxy S III Android Development] robsonsilva:
I do not have much experience in the matter. But as use the Exynos branch? Much like your governor use it on titan. And the governor only found on the Exynos 4 :(
[Galaxy S III Android Development] DespairFactor:
What are you looking to do that the exynos branch doesn't do for your SoC?
[Galaxy S III Android Development] robsonsilva:
Sorry I am new to the subject
[Galaxy S III Android Development] DespairFactor:
It's no problem really, its what we are here for.
[Galaxy S III Android Development] ZaneZam:
no problem everyone was "new" at some point :)

just use this version: https://github.com/zanezam/cpufreq-governor-zzmoove/tree/exynos its prepared to compile for exynos.

feel free to ask if u get stuck ;)
[Galaxy S III Android Development] robsonsilva:
It worked perfectly thank you. ZZMoove is the default governor of my Kernel ;D
[Galaxy S III Android Development] konohanz:
Wow that's great :good:

Me too, zzmoove governor will always be the first choice, and based on my experience zzmoove relax even has better performance and stability than pegasusq :D
[Galaxy S III Android Development] speedyd718:
Could someone point me in the direction to applying the most recent changes to my VZW Note2 kernel (using AGNI Stock)? The last update applied according to the dev's notes is 1.0beta5. Just FYI, I've never compiled a kernel, so I'm not sure where to start. Is there anything that can be flashed?
[Galaxy S III Android Development] ZaneZam:
im afraid u would have to go the "hard" way by building your own kernel. if u got one working image running (for example build with ANGi sources) it's a matter of min's to update to latest zzmoove version and rebuild. that's how (and actually is the reason why) many devs started doing things here (including me *g*): wanting something which isn't available yet *g* [MENTION=4365701]psndna88[/MENTION] even provides some build scripts here : https://github.com/psndna88/AGNI-pureSTOCK/blob/pureSTOCK-N7100-4.4.4/build_kernel_n7105.sh. to get things working quickly. but that's actually just half of the story as u have to know how to deal with the needed ramdisk and combining it after building zimage and modules. but i guess there are plenty of descriptions around here on xda about that. anyway i suggest to take a look into lord boefflas script here: https://github.com/zanezam/boeffla-kernel-samsung-s3/blob/boeffla43/bbuild.sh at least there are all needed things included for a i9300 kernel, not sure if that applies 100% for the note 2 too but i guess it's very near as this is a "for samsung usual method", but check yourself, learn and try ;)

btw. u can also get an idea how to start here for example : http://xda-university.com/as-a-developer/getting-started-building-a-kernel-from-source

so now its up to u how much u are motivated, good luck! :)
[Galaxy S III Android Development] Saber:
Hi zanezam, I noticed post 3 is a little outdated. I have made a summary on all zzmoove variables on my cpu governor thread: http://xdaforums.com/showpost.php?p=59289787&postcount=4 (just scroll down a bit until you see zzmoove)

Most of the descriptions came from your changelog, and so I made it much easier to find all the info in one place :)

regards, gsstudios
[Galaxy S III Android Development] xflowy:
just one question: which profile will be in use/applied if i'm running a kernel with kernel adiutor and simply select the zzmoove gov?
[Galaxy S III Android Development] ZaneZam:
that depends on which profile was set as the default in the source but normally that's profile 1 ;)
[Galaxy S III Android Development] xflowy:
hey man. is this still work in progress? just using your beta8.

thanks.
[Galaxy S III Android Development] ZaneZam:
great have fun with it. Yes as nothing other was stated, still fiddling around :)

currently working on big.little support but "got stopped" due to "less free time issues" ;)
[Galaxy S III Android Development] yuzhengwen:
I am on Xperia Z3, AndroPlus kernel with this governor.

I have a few questions (I don't think it has been answered, I checked back a few pages):

-how does this governor affect hotplug things like if I use intelliplug (there are many tunables in this governor that seemingly clashes with that of the hotplug)

-when does zzmove consider the phone sleeping -- when doing nothing? or when screen off?

-am I right that music mode has to be activated manually?

Last,

-how do I achieve strictly dual core setup, only using other 2 cores when above certain frequency as well as have thermal controls and good battery...

(hybrid of moderate, gaming, batteryplus?)
[Galaxy S III Android Development] ZaneZam:
hi yuzhengwen,

1.) the so called "native hotplugging" shouldn't influence it if the dev who implemented it did it the right way :) so he/she should either completely disable hotlpugging in the zzmoove code or disable it per tunable during runtime if he/she implemented a hotplug driver like intelliplug in addition (better said use it in addition). there are also examples around where u can use both (either/or) by switching tunables.for example i'm using this for not hotplug-able governors in my boeffla kernel port for the note 8. and lord boeffla uses a similar "mechanism" to switch from native to "stock" hotplugging in his one plus one kernel.

2.) when screen is switched off ;)

3.) yes u are right it's meant to be a manually switch so you can use it for example with tasker or any other app which can detect music playing and doing "actions" on demand

4.) exactly u would have to merge moderate + game setting (the thermal part) together ;) the good battery thing is subjective so i can't say if it will be good for u then. i just can mention that i used moderate a long time and bat "stayed good for me" in comparison to battery settings which i used to use before moderate. but that all on older samsung devices. so just give it a shot and see. ;)

cheers

ZZ
[Galaxy S III Android Development] yuzhengwen:
Thanks for quick reply, but i don't quite understand 1)

If I want to use zzmove native hotplug, then there will be an option in cpu hot plug to toggle it?

Zzmoove will not work with intelliplug or other plugs?

Really want to take full advantage of zzmoove which is awesome :)
[Galaxy S III Android Development] ZaneZam:
U can use intelliplug I just wanted to state that both at the sane time is not a good idea :) and the dev should ensure that either a dedicated hotplug driver is used OR native hotplugging. if native hotplug is activated in source of zzmoove u have a tuneable disable_hotplug to toggle it. ;)
[Galaxy S III Android Development] yuzhengwen:
So I have the disable hot plug tunable, meaning native hot plug is enabled?

So I should just not use any other hot plug? Disable intelliplug?

This is kind of confusing

Zzmoove is a governor that hot plugs itself? Is that what native means?

Heh, not very good at this stuff am I
[Galaxy S III Android Development] ZaneZam:
hehe no problem mate i'm patient and u almost got it :)

u should just not use both at the same time. so if u use zzmoove hotplugging (if it is available in the implemenation) then intelliplug or other hotplug driver should be disabled. if u want to use zzmoove native (yes this means governor itself plugs, this is btw. the oldschool way from back in the days like it was on older exynos SOCs and yes that's unusual on newer SOCs hence no other governor has it) then the "disable_hotplug" tunable should be set to 0 (switching is vice versa, so 1=hotplug off, 0=hotplug on)

condensed:

situation 1: only zzmoove native hotpug = hotplug in the governor: disable_hotplug (if available in implementation) should be set to 0 and no other hoplug driver is needed and should be even disabled if available.

situation 2: hotplug driver + zzmoove native hotplug = disable_hotplug (if available in implementation) should be set to 1 if u want to use the hotplug driver like intelliplug

situation 3: if "disable_hotplug tunable is not available then native hotplug was not enabled in the code and nothing has to be done as u have to use a separate hotplug driver to be able to hotplug (that's the default situation on newer SOC's with governors which has no hotplugging included anymore)
[Galaxy S III Android Development] yuzhengwen:
Get it now, thanks!

Zzmoove ftw